Jan Kotas [Fri, 30 Oct 2015 22:48:43 +0000 (15:48 -0700)]
Merge pull request #1903 from jashook/master
Remove redefinition of new and delete in alloc.h
Jan Kotas [Fri, 30 Oct 2015 22:47:49 +0000 (15:47 -0700)]
Merge pull request #1852 from botaberg/fixsyntaxx86
Fix syntax error on x86
Jan Kotas [Fri, 30 Oct 2015 22:44:53 +0000 (15:44 -0700)]
Merge pull request #1888 from JohnChen0/master
Modify Platform ID of Linux NIs (issue #1035)
William Godbe [Fri, 30 Oct 2015 22:08:31 +0000 (15:08 -0700)]
Merge pull request #1891 from wtgodbe/failingPinvokes
Disabled tests failing on Pinvoke to Kernel32.dll on Linux
Jarret Shook [Fri, 30 Oct 2015 20:40:12 +0000 (13:40 -0700)]
Remove redefinition of new and delete in alloc.h
VS 2015 RC 1 causes a breaking build with redefining new and delete as
static functions. Removing the static will cause link errors with other
redefined new and delete operators. These functions are redefined to just
assertonly in debug.
Jan Kotas [Fri, 30 Oct 2015 04:17:42 +0000 (21:17 -0700)]
Merge pull request #1898 from dotnet/reloc-type
Fix reloc type in the absence of reloc hint
Jan Kotas [Fri, 30 Oct 2015 03:40:19 +0000 (20:40 -0700)]
Merge pull request #1897 from dotnet-bot/from-tfs
Merge changes from TFS
Senthil [Fri, 30 Oct 2015 01:19:06 +0000 (18:19 -0700)]
Fix reloc type in the absence of reloc hint
When Reloc hint is no hint, JIT yields wrong Reloc type. mov eax, offset should yield DIR64 (MOFFSET for amd64) not HIGHLOW (MOFFSET for x86).
Matt Ellis [Thu, 29 Oct 2015 23:42:24 +0000 (16:42 -0700)]
Merge pull request #1894 from dotnet-bot/from-tfs
Merge changes from TFS
Aditya Mandaleeka [Thu, 29 Oct 2015 23:13:40 +0000 (16:13 -0700)]
Merge pull request #1880 from adityamandaleeka/chmod_linux_ci
Add chmod +x to individual test scripts in runtest.sh
John Chen [Thu, 29 Oct 2015 21:38:11 +0000 (14:38 -0700)]
Modify crossgen to allow loading NIs during Ready To Run compilation
[tfs-changeset: 1543250]
Lubomir Litchev [Thu, 29 Oct 2015 21:36:05 +0000 (14:36 -0700)]
Merge pull request #1893 from LLITCHEV/Issue1831
Fix putarg_stk for tail call functions.
Jan Kotas [Thu, 29 Oct 2015 20:27:34 +0000 (13:27 -0700)]
Add contract for getSystemVAmd64PassStructInRegisterDescriptor
[tfs-changeset: 1543232]
Matt Mitchell [Thu, 29 Oct 2015 19:12:26 +0000 (12:12 -0700)]
Merge pull request #1892 from mmitche/dont-use-git-commit
Temporarily remove GIT_COMMIT capture and passing
Matt Mitchell [Thu, 29 Oct 2015 19:00:12 +0000 (12:00 -0700)]
Temporarily remove GIT_COMMIT capture and passing
It looks like the previous build's GIT_COMMIT is being passed instead of the current, which is causing issues. Disable this for now and add logging so that this can be debugged
Lubomir Litchev [Wed, 28 Oct 2015 06:08:22 +0000 (23:08 -0700)]
Fix putarg_stk for tail call functions.
For tail calls the stack params should replace the current function arg
space and not be placed in the outgoing argument area.
Aditya Mandaleeka [Thu, 29 Oct 2015 18:41:58 +0000 (11:41 -0700)]
Merge pull request #1873 from kangaroo/arm-cleanup
[arm] Clean up a few places where the arm build has bit rotted
Aditya Mandaleeka [Thu, 29 Oct 2015 18:37:10 +0000 (11:37 -0700)]
Merge pull request #1875 from adityamandaleeka/remove_suspension
Initial removal of thread suspension code from PAL
William Godbe [Thu, 29 Oct 2015 17:32:21 +0000 (10:32 -0700)]
Disabled tests failing on Pinvoke to Kernel32.dll on Linux
John Chen [Thu, 29 Oct 2015 05:06:35 +0000 (22:06 -0700)]
Modify Platform ID of Linux NIs (issue #1035)
Matt Ellis [Thu, 29 Oct 2015 00:34:56 +0000 (17:34 -0700)]
Merge pull request #1887 from dotnet-bot/from-tfs
Merge changes from TFS
Aditya Mandaleeka [Thu, 29 Oct 2015 00:18:36 +0000 (17:18 -0700)]
Switch to corefx directory before running find command
Pallavi Taneja [Wed, 28 Oct 2015 19:51:36 +0000 (12:51 -0700)]
Expose Environment.Exit in mscorlib.dll.
This will later be consumed by the System.Runtime.Extensions contract.
[tfs-changeset: 1542759]
Geoff Norton [Wed, 28 Oct 2015 19:03:48 +0000 (19:03 +0000)]
[arm] Fix context accessor function naming
Bryan P. Arant [Wed, 28 Oct 2015 14:46:14 +0000 (07:46 -0700)]
Merge pull request #1882 from bryanar/pr1-test-fix
Fix for run-only pr1 tests.
Bryan Arant [Wed, 28 Oct 2015 08:39:05 +0000 (01:39 -0700)]
Fix for run-only pr1 tests.
Jan Vorlicek [Wed, 28 Oct 2015 00:59:26 +0000 (17:59 -0700)]
Merge pull request #1876 from stephentoub/local_realloc
Implement LocalReAlloc in PAL
Aditya Mandaleeka [Tue, 27 Oct 2015 23:21:49 +0000 (16:21 -0700)]
Add chmod +x to individual test scripts in runtest.sh
Jan Vorlicek [Tue, 27 Oct 2015 23:10:09 +0000 (16:10 -0700)]
Merge pull request #1878 from janvorli/fix-ex-try
Add missing exception holder to EX_TRY
Jan Vorlicek [Tue, 27 Oct 2015 17:30:58 +0000 (10:30 -0700)]
Add missing exception holder to EX_TRY
When the exception handling was changed recently, the exception holder
was added only to PAL_TRY / PAL_EXCEPT macros. But it needs to be
in the EX_TRY as well, otherwise first pass of exception handling
would incorrectly consider some exceptions unhandled.
Geoff Norton [Tue, 27 Oct 2015 20:20:08 +0000 (20:20 +0000)]
[arm] Fix the debug build as well
stephentoub [Tue, 27 Oct 2015 16:48:10 +0000 (12:48 -0400)]
Implement CoTaskMemRealloc in PAL
Also implement CoTaskMemRealloc in PAL, as it's exposed via the public Marshal.CoTaskMemRealloc.
Geoff Norton [Mon, 26 Oct 2015 22:23:31 +0000 (22:23 +0000)]
[arm] Clean up a few places where the arm build has bit rotted
stephentoub [Tue, 27 Oct 2015 03:03:04 +0000 (23:03 -0400)]
Implement LocalReAlloc in PAL
Marshal.ReAllocHGlobal is failing because it's expecting to find a LocalReAlloc implementation in libcoreclr's PAL. This commit adds one.
John Chen [Tue, 27 Oct 2015 15:51:37 +0000 (08:51 -0700)]
Merge pull request #1868 from JohnChen0/crossgen-linux
Fix a CrossGen assert on Linux
Aditya Mandaleeka [Mon, 26 Oct 2015 23:11:01 +0000 (16:11 -0700)]
Remove SuspendThread and SetThreadContext PAL tests.
Aditya Mandaleeka [Mon, 26 Oct 2015 22:42:45 +0000 (15:42 -0700)]
Remove unneeded includes and error in threadsusp.cpp
Aditya Mandaleeka [Mon, 26 Oct 2015 21:47:49 +0000 (14:47 -0700)]
Remove THREADMarkDiagnostic and its uses.
Aditya Mandaleeka [Sat, 24 Oct 2015 01:34:59 +0000 (18:34 -0700)]
Remove THREADHandleSuspendNative and THREADHandleResumeNative
Aditya Mandaleeka [Sat, 24 Oct 2015 01:32:08 +0000 (18:32 -0700)]
Set dwSuspendCount when resuming in pipe case
Aditya Mandaleeka [Sat, 24 Oct 2015 01:30:20 +0000 (18:30 -0700)]
Disable USE_SIGNALS_FOR_THREAD_SUSPENSION
Aditya Mandaleeka [Fri, 23 Oct 2015 23:15:50 +0000 (16:15 -0700)]
Make InjectActivationInternal on OS X use platform thread suspension
Aditya Mandaleeka [Fri, 23 Oct 2015 23:10:36 +0000 (16:10 -0700)]
Remove InternalSuspendThreadFromData and IsSuspensionStateSafe
Aditya Mandaleeka [Fri, 23 Oct 2015 22:49:49 +0000 (15:49 -0700)]
Remove dwUnsafeRegionCount and dwSuspCount
Aditya Mandaleeka [Fri, 23 Oct 2015 21:41:41 +0000 (14:41 -0700)]
Remove SuspendThread and associated code.
Aditya Mandaleeka [Fri, 23 Oct 2015 21:27:42 +0000 (14:27 -0700)]
Remove unused function IsAssertShutdownSafe
Aditya Mandaleeka [Fri, 23 Oct 2015 07:21:10 +0000 (00:21 -0700)]
Remove unused function PROCCondemnOtherThreads
Aditya Mandaleeka [Fri, 23 Oct 2015 07:19:51 +0000 (00:19 -0700)]
Remove PROCSuspendOtherThreads
Aditya Mandaleeka [Fri, 23 Oct 2015 06:49:43 +0000 (23:49 -0700)]
Remove Enter/LeaveUnsafeRegion
Aditya Mandaleeka [Fri, 23 Oct 2015 06:20:47 +0000 (23:20 -0700)]
Disable apithreadstress when STRESS_THREAD is not enabled
Lubomir Litchev [Mon, 26 Oct 2015 17:15:18 +0000 (10:15 -0700)]
Merge pull request #1862 from LLITCHEV/Issue1831
Fixed the bug described in GH issue 1831.
John Chen [Mon, 26 Oct 2015 15:48:06 +0000 (08:48 -0700)]
Fix a CrossGen assert on Linux
Resource string loading during CrossGen doesn't work on Linux.
Disable it for now. In many cases the loaded string isn't even used.
Matt Ellis [Mon, 26 Oct 2015 04:31:58 +0000 (21:31 -0700)]
Merge pull request #1229 from benpye/fix-complus-case-docs
Fix casing of COMPlus_ in documentation
Jan Kotas [Mon, 26 Oct 2015 03:30:38 +0000 (20:30 -0700)]
Merge pull request #1867 from dotnet-bot/from-tfs
Merge changes from TFS
Lubomir Litchev [Mon, 26 Oct 2015 01:19:27 +0000 (18:19 -0700)]
Fix for a build break. The gtNewOperNode is not a member of Lowering, but of Compiler. An extra comp-> dereferencing is needed. Talked to Matt Ellis and committing directly to avoid nightly broken build.
[tfs-changeset: 1541493]
Matt Ellis [Mon, 26 Oct 2015 00:29:52 +0000 (17:29 -0700)]
Merge pull request #1866 from dotnet-bot/from-tfs
Merge changes from TFS
Matt Ellis [Mon, 26 Oct 2015 00:29:03 +0000 (17:29 -0700)]
Merge pull request #1851 from ellismg/icu-remove-c-plus-plus
Remove OSX Homebrew ICU dependency
Matt Ellis [Sun, 25 Oct 2015 21:00:24 +0000 (14:00 -0700)]
Fix build break.
Wrong local name used in lowerarm64.cpp
[tfs-changeset: 1541475]
Matt Ellis [Sat, 24 Oct 2015 08:27:09 +0000 (01:27 -0700)]
Merge pull request #1861 from dotnet-bot/from-tfs
Merge changes from TFS
Lubomir Litchev [Fri, 23 Oct 2015 18:47:19 +0000 (11:47 -0700)]
Fixed the bug described in GH issue 1831.
When generating unboxing function, if the return value is nullables
returned in 2 registers, creating the temp var to pass to the
helper function is not enough. Also need to make sure the operand type
stack is properly maintained.
Rama krishnan Raghupathy [Sat, 24 Oct 2015 01:59:28 +0000 (18:59 -0700)]
Merge pull request #1857 from ramarag/testhygiene
Ensure each test has its own unique directory
Rama Krishnan Raghupathy [Fri, 23 Oct 2015 21:39:25 +0000 (14:39 -0700)]
Test Cleanup:
1. Ensures each test has its own unique directory
2. Use Project Reference to refer native CMakeLists.txt
3. Avoids copying the facades to the test build
Gaurav Khanna [Fri, 23 Oct 2015 22:52:07 +0000 (15:52 -0700)]
Merge pull request #1818 from gkhanna79/Fix1774
Fix Unix CoreConsole to correctly determine the path to the entrypoint executable
Matt Ellis [Fri, 23 Oct 2015 21:24:13 +0000 (14:24 -0700)]
Cleanup CMakeLists.txt
There were a few problems that needed to be addressed:
- Our detection logic around testing if ICU supported a feature was
still checking for C++ stuff instead of the coresponding C
code (which we ended up using).
- There was some cleanup we could do now that the OSX and other Unix
builds were split apart
Matt Ellis [Fri, 23 Oct 2015 21:23:55 +0000 (14:23 -0700)]
Fix spelling issues
Gaurav Khanna [Fri, 23 Oct 2015 21:13:59 +0000 (14:13 -0700)]
Address a messaging nit.
Gaurav Khanna [Mon, 19 Oct 2015 05:18:43 +0000 (22:18 -0700)]
Fix issue 1774
Cagri Aslan [Fri, 23 Oct 2015 16:47:35 +0000 (09:47 -0700)]
Merge pull request #1858 from caslan/addcriticalsectionexports
Add EnterCriticalSection / LeaveCriticalSection exports to libcoreclr
Matt Ellis [Fri, 23 Oct 2015 07:55:23 +0000 (00:55 -0700)]
Use correct close function for UNumberFormat
Cagri [Fri, 23 Oct 2015 06:59:38 +0000 (23:59 -0700)]
Add EnterCriticalSection / LeaveCriticalSection exports to libcoreclr
Lakshmi Priya [Fri, 23 Oct 2015 03:33:47 +0000 (20:33 -0700)]
Merge pull request #1834 from Priya91/fixnull
Add null checks to StackString usages.
Aditya Mandaleeka [Fri, 23 Oct 2015 02:17:17 +0000 (19:17 -0700)]
Merge pull request #1854 from janvorli/fix-comment
Fix obsolete comment
Lakshmi Priya Sekar [Thu, 22 Oct 2015 03:37:06 +0000 (20:37 -0700)]
Add null checks to StackString usages.
Bryan P. Arant [Fri, 23 Oct 2015 01:15:39 +0000 (18:15 -0700)]
Merge pull request #1832 from bryanar/enable_crossgen_tests
- Changes required to enable crossgen on the tests.
- Added priority level parameter to buildtest.cmd
- Added crossgen parameter to buildtest.cmd
- Updated testing documentation to reflect prioritylevel testing, and crossgen testing.
Jan Vorlicek [Fri, 23 Oct 2015 01:15:35 +0000 (18:15 -0700)]
Fix obsolete comment
Matt Ellis [Fri, 23 Oct 2015 00:46:54 +0000 (17:46 -0700)]
Use std::vector instead of calloc
This matches what we do in other places in calendarData.cpp, the RAII
pattern will make it easier to not leak memory.
Matt Ellis [Fri, 23 Oct 2015 00:42:48 +0000 (17:42 -0700)]
Merge pull request #1850 from dotnet-bot/from-tfs
Merge changes from TFS
Jan Vorlicek [Thu, 22 Oct 2015 23:52:57 +0000 (16:52 -0700)]
Merge pull request #1849 from janvorli/fix-fp-registers-offset
Fix floatingpoint register offsets in TransitionBlock for Unix
Rama Krishnan Raghupathy [Thu, 22 Oct 2015 23:19:25 +0000 (16:19 -0700)]
[adityam] Fix break in DllImport code for Desktop CLR.
[tfs-changeset: 1540922]
John Bottenberg [Thu, 22 Oct 2015 23:14:55 +0000 (16:14 -0700)]
Fix syntax error due to UNIX_AMD64_ABI_ONLY_ARG evaluating to an empty string on x86
Matt Ellis [Wed, 21 Oct 2015 20:48:37 +0000 (13:48 -0700)]
Link against libicucore on OSX
OSX ships with a copy of ICU (their globalization APIs are built on top
of it). Since we only use stable c based APIs, we can link against it
using the methods described in using a System ICU in the ICU User's
Guide (basically we disable function renaming, don't use C++ and only
use stable APIs).
The ICU headers are not part of the SDK, so we continue to need ICU
installed via Homebrew as a build time dependency.
Fixes dotnet/corefx#3849
Eugene Rozenfeld [Thu, 22 Oct 2015 22:37:41 +0000 (15:37 -0700)]
Merge pull request #1830 from erozenfeld/RotateBits
Generate efficient code for rotation patterns.
Matt Ellis [Thu, 22 Oct 2015 22:35:03 +0000 (15:35 -0700)]
Merge pull request #1848 from dotnet-bot/from-tfs
Merge changes from TFS
Bryan Arant [Thu, 22 Oct 2015 03:19:51 +0000 (20:19 -0700)]
Changes required to enable crossgen on the tests.
Rama Krishnan Raghupathy [Thu, 22 Oct 2015 22:07:33 +0000 (15:07 -0700)]
adding more context
[tfs-changeset: 1540889]
Rama Krishnan Raghupathy [Thu, 22 Oct 2015 21:10:15 +0000 (14:10 -0700)]
Addressing Desktop Build break due to addition of a new non windows event in Clretwall.man
[tfs-changeset: 1540865]
Stephen Toub [Thu, 22 Oct 2015 20:47:51 +0000 (16:47 -0400)]
Merge pull request #1816 from stephentoub/string_indexof_perf
Improve string.{Last}IndexOf perf on Unix for Ordinal/OrdinalIgnoreCase
Cagri Aslan [Thu, 22 Oct 2015 20:20:23 +0000 (13:20 -0700)]
Merge pull request #1840 from caslan/customnotificationfix
Fixed an issue with getting event size not working for custom notific…
stephentoub [Wed, 21 Oct 2015 02:32:14 +0000 (22:32 -0400)]
Update IndexOfOrdinalIgnoreCase to use full code units
stephentoub [Tue, 20 Oct 2015 19:34:38 +0000 (15:34 -0400)]
Improve string.{Last}IndexOf perf on Unix for Ordinal/OrdinalIgnoreCase
Our current implementation of IndexOfOrdinal for strings on Unix uses Substring to get the piece of the source string we care about; this results in an unnecessary allocation / string copy. When using OrdinalIgnoreCase, we also convert both the source and search strings to upper-case using ToUpperInvariant, resulting in more allocations. And our LastIndexOfOrdinal implementation delegates to IndexOfOrdinal repeatedly, incurring such allocations potentially multiple times.
This change reimplements Ordinal searching in managed code to not use Substring, and it implements OrdinalIgnoreCase searching via new functions exposed in the native globalization shim, so as to use ICU without having to make managed/native transitions for each character.
With the changes, {Last}IndexOf with Ordinal/OrdinalIgnoreCase are now allocateion-free (as you'd expect), and throughput when startIndex/count and/or OrdinalIgnoreCase are used is increased significantly, on my machine anywhere from 20% to 3x, depending on the inputs.
Koundinya Veluri [Thu, 22 Oct 2015 18:03:04 +0000 (11:03 -0700)]
Merge pull request #1833 from kouvel/Inline2
Move some functions to allow them to be inlined with clang
Jan Vorlicek [Thu, 22 Oct 2015 17:55:02 +0000 (10:55 -0700)]
Fix floatingpoint register offsets in TransitionBlock for Unix
The conversion between floating point register index and offset was incorrectly
multiplying the the index by 8 instead of 16. The xmm registers in the
TransitionBlock on Unix take 16 bytes each, not 8.
Matt Mitchell [Thu, 22 Oct 2015 15:45:48 +0000 (08:45 -0700)]
Merge pull request #1839 from mmitche/fix-linux-coreclr-tests
A couple tweaks to coreclr linux tests
Matt Mitchell [Thu, 22 Oct 2015 15:40:34 +0000 (08:40 -0700)]
A couple tweaks to coreclr linux tests
Cagri Aslan [Sat, 17 Oct 2015 00:43:39 +0000 (17:43 -0700)]
Fixed an issue with getting event size not working for custom notification event
Matt Ellis [Thu, 22 Oct 2015 05:43:32 +0000 (22:43 -0700)]
Merge pull request #1820 from richlander/rich-cleanup
Update license attribution
Koundinya Veluri [Tue, 20 Oct 2015 17:37:01 +0000 (10:37 -0700)]
Move some functions to allow them to be inlined with clang
For the moment, GetThread, _rotl/_rotr, Interlocked..., and similar functions were moved to allow inlining them with clang.
The plan is to eventually enable link-time optimization (LTO) to cover inlining across translation units.
Renamed some code files in PAL tests to compile as C++ to use the C++ inline semantics.
Brian Robbins [Thu, 22 Oct 2015 03:03:38 +0000 (20:03 -0700)]
Merge pull request #1827 from brianrob/tracinginit
Initialize LTTng tracepoint providers automatically
Rama krishnan Raghupathy [Thu, 22 Oct 2015 03:00:57 +0000 (20:00 -0700)]
Merge pull request #1751 from ramarag/eventsource
Enable EventSource Logging in Linux via Lttng
Eugene Rozenfeld [Tue, 13 Oct 2015 01:36:25 +0000 (18:36 -0700)]
Generate efficient code for rotation patterns.
This change adds code to recognize rotation idioms and generate efficient instructions for them.
Two new operators are added: GT_ROL and GT_ROR.
The patterns recognized:
(x << c1) | (x >>> c2) => x rol c1
(x >>> c1) | (x << c2) => x ror c2
where c1 and c2 are constant and c1 + c2 == bitsize(x)
(x << y) | (x >>> (N - y)) => x rol y
(x >>> y) | (x << (N - y)) => x ror y
where N == bitsize(x)
(x << y & M1) | (x >>> (N - y) & M2) => x rol y
(x >>> y & M1) | (x << (N - y) & M2) => x ror y
where N == bitsize(x)
M1 & (N - 1) == N - 1
M2 & (N - 1) == N - 1
For a simple benchmark with 4 rotation patterns in a tight loop
time goes from 7.324 to 2.600 (2.8 speedup).
Rotations found and optimized in mscorlib:
System.Security.Cryptography.SHA256Managed::RotateRight
System.Security.Cryptography.SHA384Managed::RotateRight
System.Security.Cryptography.SHA512Managed::RotateRight
System.Security.Cryptography.RIPEMD160Managed:MDTransform (320 instances!)
System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Rol1
System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Rol5
System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Rol30
System.Diagnostics.Tracing.EventSource.Sha1ForNonSecretPurposes::Drain
(9 instances of Sha1ForNonSecretPurposes::Rol* inlined)
Closes #1619.