Nikita Popov [Mon, 1 Aug 2022 05:28:36 +0000 (07:28 +0200)]
[MSSA] Fix expensive checks build
Nikita Popov [Mon, 1 Aug 2022 05:22:35 +0000 (07:22 +0200)]
[Examples] Fix SimplifyCFG example
After
fffabd53482f34f96ab9273486538f587e3d91fc, the v2 and v3
versions produce poison instead of undef. Also adjust the v1
version, as well as the test expectations, to make the example
pass again.
Nikita Popov [Thu, 28 Jul 2022 15:23:36 +0000 (17:23 +0200)]
[AA] Do not track Must in ModRefInfo
getModRefInfo() queries currently track whether the result is a
MustAlias on a best-effort basis. The only user of this functionality
is the optimized memory access type in MemorySSA -- which in turn
has no users. Given that this functionality has not found a user
since it was introduced five years ago (in D38862), I think we
should drop it again.
The context is that I'm working to separate FunctionModRefBehavior
to track mod/ref for different location kinds (like argmem or
inaccessiblemem) separately, and the fact that ModRefInfo also has
an unrelated Must flag makes this quite awkward, especially as this
means that NoModRef is not a zero value. If we want to retain the
functionality, I would probably split getModRefInfo() results into
a part that just contains the ModRef information, and a separate
part containing a (best-effort) AliasResult.
Differential Revision: https://reviews.llvm.org/D130713
Chuanqi Xu [Mon, 1 Aug 2022 03:07:13 +0000 (11:07 +0800)]
[NFC] Fill up the title underline in rst file
Fill up the title underline in rst file to avoid the CI error.
Chuanqi Xu [Mon, 1 Aug 2022 03:03:28 +0000 (11:03 +0800)]
Use @llvm.threadlocal.address intrinsic to access TLS variable
This is successor for D125291. This revision would try to use
@llvm.threadlocal.address in clang to access TLS variable. The reason
why the OpenMP tests contains a lot of change is that they uses
utils/update_cc_test_checks.py to update their tests.
Reviewed By: nikic
Differential Revision: https://reviews.llvm.org/D129833
Fangrui Song [Mon, 1 Aug 2022 02:55:05 +0000 (19:55 -0700)]
[ELF] Remove EhFrameSection::addSection. NFC
Chuanqi Xu [Mon, 1 Aug 2022 02:51:30 +0000 (10:51 +0800)]
Introduce @llvm.threadlocal.address intrinsic to access TLS variable
This belongs to a series of patches which try to solve the thread
identification problem in coroutines. See
https://discourse.llvm.org/t/address-thread-identification-problems-with-coroutine/62015
for a full background.
The problem consists of two concrete problems: TLS variable and readnone
functions. This patch tries to convert the TLS problem to readnone
problem by converting the access of TLS variable to an intrinsic which
is marked as readnone.
The readnone problem would be addressed in following patches.
Reviewed By: nikic, jyknight, nhaehnle, ychen
Differential Revision: https://reviews.llvm.org/D125291
Fangrui Song [Mon, 1 Aug 2022 00:47:09 +0000 (17:47 -0700)]
[ELF] redirectSymbols: skip versioned symbol combine if config->versionDefinitions.size() == 2
Jez Ng [Mon, 1 Aug 2022 00:16:08 +0000 (20:16 -0400)]
[lld-macho] Support EH frame pointer encodings that use sdata4
Previously we only supporting using the system pointer size (aka the
`absptr` encoding) because `llvm-mc`'s CFI directives always generate EH
frames with that encoding. But libffi uses 4-byte-encoded, hand-rolled
EH frames, so this patch adds support for it.
Fixes #56576.
Reviewed By: #lld-macho, oontvoo
Differential Revision: https://reviews.llvm.org/D130804
Sunho Kim [Mon, 1 Aug 2022 00:06:35 +0000 (09:06 +0900)]
[clang-repl] XFAIL windows properly in simple-exception test case.
We don't have proper exception support in LLJIT on windows yet. We have to xfail windows machine, but the previous check missed out some targets.
Jeff Niu [Tue, 19 Jul 2022 04:32:38 +0000 (21:32 -0700)]
[mlir] Remove types from attributes
This patch removes the `type` field from `Attribute` along with the
`Attribute::getType` accessor.
Going forward, this means that attributes in MLIR will no longer have
types as a first-class concept. This patch lays the groundwork to
incrementally remove or refactor code that relies on generic attributes
being typed. The immediate impact will be on attributes that rely on
`Attribute` containing a type, such as `IntegerAttr`,
`DenseElementsAttr`, and `ml_program::ExternAttr`, which will now need
to define a type parameter on their storage classes. This will save
memory as all other attribute kinds will no longer contain a type.
Moreover, it will not be possible to generically query the type of an
attribute directly. This patch provides an attribute interface
`TypedAttr` that implements only one method, `getType`, which can be
used to generically query the types of attributes that implement the
interface. This interface can be used to retain the concept of a "typed
attribute". The ODS-generated accessor for a `type` parameter
automatically implements this method.
Next steps will be to refactor the assembly formats of certain operations
that rely on `parseAttribute(type)` and `printAttributeWithoutType` to
remove special handling of type elision until `type` can be removed from
the dialect parsing hook entirely; and incrementally remove uses of
`TypedAttr`.
Reviewed By: lattner, rriddle, jpienaar
Differential Revision: https://reviews.llvm.org/D130092
Fangrui Song [Sun, 31 Jul 2022 23:59:57 +0000 (16:59 -0700)]
[ELF] Simplify EhInputSection::split. NFC
* Inline getReloc
* Fold the UINT32_MAX length check into the section size check.
This transformation is valid because we don't support .eh_frame input sections
larger than 32-bit (unrealistic even for large code models).
Fangrui Song [Sun, 31 Jul 2022 23:16:10 +0000 (16:16 -0700)]
[ELF] Split EhInputSection::pieces into cies and fdes
This simplifies code, removes a read32 (for id==0 check), and makes it feasible
to combine some operations in EhInputSection::split and EhFrameSection::addRecords.
Mostly NFC, but fixes "Relocation not in any piece" assertion failure in an
erroneous case when a relocation offset precedes all CIE/FDE pices.
Kazu Hirata [Sun, 31 Jul 2022 22:17:09 +0000 (15:17 -0700)]
Use drop_begin (NFC)
Kazu Hirata [Sun, 31 Jul 2022 22:17:08 +0000 (15:17 -0700)]
Use llvm::any_of (NFC)
Kazu Hirata [Sun, 31 Jul 2022 22:17:06 +0000 (15:17 -0700)]
[Hexagon] Remove unused declaration adjustForCalleeSavedRegsSpillCall (NFC)
The function definition was removed on Apr 23, 2015 in commit
876a19d8554510e6689b0a990e5e62af81506d80, but the declaration has
remained since.
Kazu Hirata [Sun, 31 Jul 2022 22:17:05 +0000 (15:17 -0700)]
[BOLT] Remove redundaunt string initialization (NFC)
Identified with readability-redundant-string-init.
Kazu Hirata [Sun, 31 Jul 2022 22:17:03 +0000 (15:17 -0700)]
[BOLT] Remove redundant const from return types (NFC)
Identified with readability-const-return-type.
Kazu Hirata [Sun, 31 Jul 2022 22:17:01 +0000 (15:17 -0700)]
[BOLT] Use boolean literals (NFC)
Identified with modernize-use-bool-literals.
Kazu Hirata [Sun, 31 Jul 2022 22:17:00 +0000 (15:17 -0700)]
[Sema] Remove an unused forward declaration (NFC)
Kazu Hirata [Sun, 31 Jul 2022 22:16:58 +0000 (15:16 -0700)]
[ExecutionEngine] Ensure newlines at the end of files (NFC)
NAKAMURA Takumi [Sun, 31 Jul 2022 22:03:30 +0000 (07:03 +0900)]
[Bazel] Add JITLink/COFFOptions.td (llvmorg-16-init-398-g88181375a3db)
Fangrui Song [Sun, 31 Jul 2022 21:52:20 +0000 (14:52 -0700)]
[ELF][test] Merge .eh_frame tests
Luís Marques [Fri, 29 Jul 2022 23:07:44 +0000 (01:07 +0200)]
[RISCV] Pre-RA expand pseudos pass
Expand load address pseudo-instructions earlier (pre-ra) to allow follow-up
patches to fold the addi of PseudoLLA instructions into the immediate
operand of load/store instructions.
Differential Revision: https://reviews.llvm.org/D123264
Jacques Pienaar [Sun, 31 Jul 2022 18:33:42 +0000 (11:33 -0700)]
[mlir][tosa] Switch missed accessors to prefixed form (NFC)
Fangrui Song [Sun, 31 Jul 2022 20:43:07 +0000 (13:43 -0700)]
[ELF][test] Test identical CIE content with different personality
If we change
CieRecord *&rec = cieMap[{cie.data(), personality}];
to
CieRecord *&rec = cieMap[{cie.data(), nullptr}];
The new test can catch the failure.
Tue Ly [Sun, 31 Jul 2022 20:32:21 +0000 (16:32 -0400)]
[libc][doc] Update implementation status of exp2f, sinhf, and coshf.
Jeff Niu [Sun, 31 Jul 2022 02:20:08 +0000 (22:20 -0400)]
[mlir][DCA] Fix visiting call ops when run at function scopes
When dead-code analysis is run at the scope of a function, call ops to
other functions at the same level were being marked as unreachable,
since the analysis optimistically assumes the call op to have no known
predecessors and that all predecessors are known, but the callee would
never get visited.
This patch fixes the bug by checking if a referenced function is above
the top-level op of the analysis, and is thus considered an external
callable.
Fixes #56830
Reviewed By: zero9178
Differential Revision: https://reviews.llvm.org/D130829
Alexander Belyaev [Sun, 31 Jul 2022 19:44:24 +0000 (21:44 +0200)]
Revert "Revert "[mlir] Reuse the code between `getMixed*s()` funcs in ViewLikeInterface.cpp.""
This reverts commit
e78d7637fbb08ec2c2e59939c015faadd47e32e7.
Differential Revision: https://reviews.llvm.org/D130706
Alexander Belyaev [Sun, 31 Jul 2022 19:25:20 +0000 (21:25 +0200)]
Revert "[mlir] Reuse the code between `getMixed*s()` funcs in ViewLikeInterface.cpp."
This reverts commit
e8c2877565149587fd66fbee591b7d44eecd667d.
Alexander Belyaev [Sun, 31 Jul 2022 16:04:46 +0000 (18:04 +0200)]
[mlir] Reuse the code between `getMixed*s()` funcs in ViewLikeInterface.cpp.
Differential Revision: https://reviews.llvm.org/D130706
Fangrui Song [Sun, 31 Jul 2022 18:58:08 +0000 (11:58 -0700)]
[ELF] Move EhInputSection out of inputSections. NFC
inputSections temporarily contains EhInputSection objects mainly for
combineEhSections. Place EhInputSection objects into a new vector
ehInputSections instead of inputSections.
Sanjay Patel [Sat, 30 Jul 2022 19:37:00 +0000 (15:37 -0400)]
[InstSimplify] fold FP rounding intrinsic with rounded operand
issue #56775
I rearranged the Thumb2 codegen test to avoid simplifying the chain
of rounding instructions. I'm assuming the intent of the test is
to verify lowering of each of those intrinsics.
Sanjay Patel [Sat, 30 Jul 2022 19:24:09 +0000 (15:24 -0400)]
[InstSimplify] add tests for FP rounding intrinsics; NFC
See issue #56775
Michał Górny [Sun, 31 Jul 2022 11:02:57 +0000 (13:02 +0200)]
[libcxx] [test] Cover i386 & sparc64 in string.capacity test
Differential Revision: https://reviews.llvm.org/D130837
Simon Pilgrim [Sun, 31 Jul 2022 11:14:58 +0000 (12:14 +0100)]
[X86] getFauxShuffleMask - use DemandedElts variant of getTargetShuffleInputs. NFCI.
We don't specify the demanded elts yet, this patch just rewires the getTargetShuffleInputs calls and gives an "all demanded elts" mask.
Jun Zhang [Sun, 31 Jul 2022 09:49:13 +0000 (17:49 +0800)]
[clang-repl] Fix incorrect return code
Without this patch, clang-repl incorrectly pass some tests when there's
error occured.
Signed-off-by: Jun Zhang <jun@junz.org>
Differential Revision: https://reviews.llvm.org/D130422
Simon Pilgrim [Sun, 31 Jul 2022 10:30:40 +0000 (11:30 +0100)]
[X86] combineX86ShufflesRecursively - determine demanded elts to pass to getTargetShuffleInputs
Only PACKSS/PACKUS faux shuffles make use of the demanded elts at the moment, but this at least improves the handling of a couple of truncation patterns.
Dawid Jurczak [Sun, 31 Jul 2022 08:51:01 +0000 (10:51 +0200)]
[NFC] Remove redundant CalculateSmallVectorDefaultInlinedElements usage from to_vector utility
CalculateSmallVectorDefaultInlinedElements<..>::value is already used as default value for second template parameter in SmallVector class declaration.
There is no need to pass it explicitly in to_vector.
Extracted from: https://reviews.llvm.org/D129781
Differential Revision: https://reviews.llvm.org/D130774
Jun Zhang [Sun, 31 Jul 2022 05:03:24 +0000 (13:03 +0800)]
[CodeGen][NFC] Use isa_and_nonnull instead of explicit check
Signed-off-by: Jun Zhang <jun@junz.org>
Fangrui Song [Sun, 31 Jul 2022 01:11:21 +0000 (18:11 -0700)]
[lld] Change vector to SmallVector. NFC
My lld executable is 1.6KiB smaller and some functions are now more efficient.
Fangrui Song [Sun, 31 Jul 2022 00:42:08 +0000 (17:42 -0700)]
[ELF] Move SyntheticSections to InputSection.h. NFC
Keep the main SectionBase hierarchy in InputSection.h.
And inline MergeInputSection::getParent.
Sunho Kim [Sun, 31 Jul 2022 00:19:17 +0000 (09:19 +0900)]
[JITLink][COFF] Remove unused variable.
Sunho Kim [Sun, 31 Jul 2022 00:09:22 +0000 (09:09 +0900)]
[JITLink][COFF] Handle COMDAT symbol with offset.
Handles COMDAT symbol with an offset and refactor the code to only generated symbol if the second symbol was encountered. This happens very infrequently but happens in recursive_mutex implementation of MSVC STL library.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D130454
Sunho Kim [Sun, 31 Jul 2022 00:02:23 +0000 (09:02 +0900)]
[JITLink][COFF][x86_64] Implement remaining IMAGE_REL_AMD64_REL32_*.
Implements remaining IMAGE_REL_AMD64_REL32_*. We only need IMAGE_REL_AMD64_REL32_4 for now but doing all remaining ones for completeness. (clang only uses IMAGE_REL_AMD64_REL32_1 and IMAGE_REL_AMD64_REL32)
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D130452
Sunho Kim [Sat, 30 Jul 2022 23:33:42 +0000 (08:33 +0900)]
[JITLink] Relax zero-fill edge assertions.
Relax zero-fill edge assertions to only consider relocation edges. Keep-alive edges to zero-fill blocks can cause this assertion which is too strict.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D130450
Fangrui Song [Sat, 30 Jul 2022 23:32:42 +0000 (16:32 -0700)]
[ELF] Simplify getRankProximity. NFC
Nico Weber [Sat, 30 Jul 2022 23:30:53 +0000 (19:30 -0400)]
[gn build] Port
88181375a3db more
srishti-cb [Sat, 30 Jul 2022 16:53:15 +0000 (12:53 -0400)]
[MLIR] Add a utility to sort the operands of commutative ops
Added a commutativity utility pattern and a function to populate it. The pattern sorts the operands of an op in ascending order of the "key" associated with each operand iff the op is commutative. This sorting is stable.
The function is intended to be used inside passes to simplify the matching of commutative operations. After the application of the above-mentioned pattern, since the commutative operands now have a deterministic order in which they occur in an op, the matching of large DAGs becomes much simpler, i.e., requires much less number of checks to be written by a user in her/his pattern matching function.
The "key" associated with an operand is the list of the "AncestorKeys" associated with the ancestors of this operand, in a breadth-first order.
The operand of any op is produced by a set of ops and block arguments. Each of these ops and block arguments is called an "ancestor" of this operand.
Now, the "AncestorKey" associated with:
1. A block argument is `{type: BLOCK_ARGUMENT, opName: ""}`.
2. A non-constant-like op, for example, `arith.addi`, is `{type: NON_CONSTANT_OP, opName: "arith.addi"}`.
3. A constant-like op, for example, `arith.constant`, is `{type: CONSTANT_OP, opName: "arith.constant"}`.
So, if an operand, say `A`, was produced as follows:
```
`<block argument>` `<block argument>`
\ /
\ /
`arith.subi` `arith.constant`
\ /
`arith.addi`
|
returns `A`
```
Then, the block arguments and operations present in the backward slice of `A`, in the breadth-first order are:
`arith.addi`, `arith.subi`, `arith.constant`, `<block argument>`, and `<block argument>`.
Thus, the "key" associated with operand `A` is:
```
{
{type: NON_CONSTANT_OP, opName: "arith.addi"},
{type: NON_CONSTANT_OP, opName: "arith.subi"},
{type: CONSTANT_OP, opName: "arith.constant"},
{type: BLOCK_ARGUMENT, opName: ""},
{type: BLOCK_ARGUMENT, opName: ""}
}
```
Now, if "keyA" is the key associated with operand `A` and "keyB" is the key associated with operand `B`, then:
"keyA" < "keyB" iff:
1. In the first unequal pair of corresponding AncestorKeys, the AncestorKey in operand `A` is smaller, or,
2. Both the AncestorKeys in every pair are the same and the size of operand `A`'s "key" is smaller.
AncestorKeys of type `BLOCK_ARGUMENT` are considered the smallest, those of type `CONSTANT_OP`, the largest, and `NON_CONSTANT_OP` types come in between. Within the types `NON_CONSTANT_OP` and `CONSTANT_OP`, the smaller ones are the ones with smaller op names (lexicographically).
---
Some examples of such a sorting:
Assume that the sorting is being applied to `foo.commutative`, which is a commutative op.
Example 1:
> %1 = foo.const 0
> %2 = foo.mul <block argument>, <block argument>
> %3 = foo.commutative %1, %2
Here,
1. The key associated with %1 is:
```
{
{CONSTANT_OP, "foo.const"}
}
```
2. The key associated with %2 is:
```
{
{NON_CONSTANT_OP, "foo.mul"},
{BLOCK_ARGUMENT, ""},
{BLOCK_ARGUMENT, ""}
}
```
The key of %2 < the key of %1
Thus, the sorted `foo.commutative` is:
> %3 = foo.commutative %2, %1
Example 2:
> %1 = foo.const 0
> %2 = foo.mul <block argument>, <block argument>
> %3 = foo.mul %2, %1
> %4 = foo.add %2, %1
> %5 = foo.commutative %1, %2, %3, %4
Here,
1. The key associated with %1 is:
```
{
{CONSTANT_OP, "foo.const"}
}
```
2. The key associated with %2 is:
```
{
{NON_CONSTANT_OP, "foo.mul"},
{BLOCK_ARGUMENT, ""}
}
```
3. The key associated with %3 is:
```
{
{NON_CONSTANT_OP, "foo.mul"},
{NON_CONSTANT_OP, "foo.mul"},
{CONSTANT_OP, "foo.const"},
{BLOCK_ARGUMENT, ""},
{BLOCK_ARGUMENT, ""}
}
```
4. The key associated with %4 is:
```
{
{NON_CONSTANT_OP, "foo.add"},
{NON_CONSTANT_OP, "foo.mul"},
{CONSTANT_OP, "foo.const"},
{BLOCK_ARGUMENT, ""},
{BLOCK_ARGUMENT, ""}
}
```
Thus, the sorted `foo.commutative` is:
> %5 = foo.commutative %4, %3, %2, %1
Signed-off-by: Srishti Srivastava <srishti.srivastava@polymagelabs.com>
Reviewed By: Mogball
Differential Revision: https://reviews.llvm.org/D124750
Sunho Kim [Sat, 30 Jul 2022 23:10:14 +0000 (08:10 +0900)]
[JITLink][COFF] Remove obsolete FIXMEs. (NFC)
Sunho Kim [Sat, 30 Jul 2022 23:08:19 +0000 (08:08 +0900)]
[JITLInk][COFF] Remove unnecessary unique_ptr. (NFC)
Sunho Kim [Sat, 30 Jul 2022 23:00:19 +0000 (08:00 +0900)]
[JITLink][COFF] Add explicit std::move.
Since ArgList is not copyable we need to make sure it's moved explicitly.
Nico Weber [Sat, 30 Jul 2022 22:58:10 +0000 (18:58 -0400)]
[gn build] Port
88181375a3db
Sunho Kim [Sat, 30 Jul 2022 22:49:37 +0000 (07:49 +0900)]
[JITLink][COFF] Implement include/alternatename linker directive.
Implements include/alternatename linker directive. Alternatename is used by static msvc runtime library. Alias symbol is technically incorrect (we have to search for external definition) but we don't have a way to represent this in jitlink/orc yet, this is solved in the following up patch.
Inlcude linker directive is used in ucrt to forcelly lookup the static initializer symbols so that they will be emitted. It's implemented as extenral symbols with live flag on that cause the lookup of these symbols.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D130276
Sunho Kim [Sat, 30 Jul 2022 20:42:16 +0000 (05:42 +0900)]
[clang-repl] Disable building when LLVM_STATIC_LINK_CXX_STDLIB is ON.
We have seen random symbol not found "__cxa_throw" error in fuschia build bots and out-of-tree users. The understanding have been that they are built without exception support, but it turned out that these platforms have LLVM_STATIC_LINK_CXX_STDLIB ON so that they link libstdc++ to llvm statically. The reason why this is problematic for clang-repl is that by default clang-repl tries to find symbols from symbol table of executable and dynamic libraries loaded by current process. It needs to load another libstdc++, but the platform that had LLVM_STATIC_LINK_CXX_STDLIB turned on is usally those with missing or obsolate shared libstdc++ in the first place -- trying to load it again would be destined to fail eventually with a risk to introuduce mixed libstdc++ versions.
A proper solution that doesn't take a workaround is statically link the same libstdc++ by clang-repl side, but this is not possible with old JIT linker runtimedyld. New just-in-time linker JITLink handles this relatively well, but it's not availalbe in majority of platforms. For now, this patch just disables the building of clang-repl when LLVM_STATIC_LINK_CXX_STDLIB is ON and removes the "__cxa_throw" check in exception unittest as well as reverting previous exception check flag patch.
Reviewed By: v.g.vassilev
Differential Revision: https://reviews.llvm.org/D130788
Joseph Huber [Fri, 29 Jul 2022 17:51:15 +0000 (13:51 -0400)]
[Libomptarget] Disable testing map_back_race.cpp
This test hasn't been fixed and causes spurious failures when testing.
This patch sets it as unsupported until we have a reliable fix.
Reviewed By: ronlieb
Differential Revision: https://reviews.llvm.org/D130789
Craig Topper [Sat, 30 Jul 2022 17:33:52 +0000 (10:33 -0700)]
[RISCV] Remove vmerges from vector ceil, floor, trunc lowering.
Use masked operations to suppress spurious exception bits being
set in fflags. Unfortunately, doing this adds extra copies.
Simon Pilgrim [Sat, 30 Jul 2022 17:57:11 +0000 (18:57 +0100)]
[X86] Use std::tie so we can have more meaningful variable names for demanded bits/elts pairs. NFCI.
*.first + *.second were proving difficult to keep track of.
Fangrui Song [Sat, 30 Jul 2022 17:55:59 +0000 (10:55 -0700)]
[ELF] Support missing relocations in RISCV::getImplicitAddend()
Fangrui Song [Sat, 30 Jul 2022 17:46:58 +0000 (10:46 -0700)]
[ELF] Support missing relocations in PPC64::getImplicitAddend()
Amir Ayupov [Sat, 30 Jul 2022 17:35:10 +0000 (10:35 -0700)]
Revert "[BOLT] Ignore functions accessing false positive jump tables"
This diff uncovers an ASAN leak in getOrCreateJumpTable:
```
Indirect leak of 264 byte(s) in 1 object(s) allocated from:
#1 0x4f6e48c in llvm::bolt::BinaryContext::getOrCreateJumpTable ...
```
The removal of an assertion needs to be accompanied by proper deallocation of
a `JumpTable` object for which `analyzeJumpTable` was unsuccessful.
This reverts commit
52cd00cabf479aa7eb6dbb063b7ba41ea57bce9e.
Kazu Hirata [Sat, 30 Jul 2022 17:35:56 +0000 (10:35 -0700)]
Use any_of (NFC)
Kazu Hirata [Sat, 30 Jul 2022 17:35:54 +0000 (10:35 -0700)]
Use is_contained (NFC)
Kazu Hirata [Sat, 30 Jul 2022 17:35:52 +0000 (10:35 -0700)]
Convert for_each to range-based for loops (NFC)
Kazu Hirata [Sat, 30 Jul 2022 17:35:51 +0000 (10:35 -0700)]
[bolt] Remove redundaunt virtual specifiers (NFC)
Identified with modernize-use-override.
Kazu Hirata [Sat, 30 Jul 2022 17:35:49 +0000 (10:35 -0700)]
[bolt] Remove redundaunt control-flow statements (NFC)
Identified with readability-redundant-control-flow.
Kazu Hirata [Sat, 30 Jul 2022 17:35:48 +0000 (10:35 -0700)]
Use nullptr instead of 0 (NFC)
Identified with modernize-use-nullptr.
Kazu Hirata [Sat, 30 Jul 2022 17:35:46 +0000 (10:35 -0700)]
[lld] Remove unused forward declarations (NFC)
Kazu Hirata [Sat, 30 Jul 2022 17:35:45 +0000 (10:35 -0700)]
[IR] Fix a header guard (NFC)
Identified with llvm-header-guard.
Kazu Hirata [Sat, 30 Jul 2022 17:35:43 +0000 (10:35 -0700)]
[ExecutionEngine] Ensure a newline at the end of a file (NFC)
Craig Topper [Sat, 30 Jul 2022 16:58:31 +0000 (09:58 -0700)]
[RISCV] Add merge operands to more RISCVISD::*_VL opcodes.
This adds a merge operand to all of the binary _VL nodes. Including
integer and widening. They all share multiclasses in tablegen
so doing them all at once was easiest.
I plan to use FADD_VL in an upcoming patch. The rest are just for
consistency to keep tablegen working.
This does reduce the isel table size by about 25k so that's nice.
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D130816
Craig Topper [Sat, 30 Jul 2022 16:56:16 +0000 (09:56 -0700)]
[RISCV] Swap the merge and mask operand order for VRGATHER*_VL and FCOPYSIGN_VL nodes.
Based on review feedback from D130816.
Simon Pilgrim [Sat, 30 Jul 2022 16:55:34 +0000 (17:55 +0100)]
[X86] computeKnownBitsForTargetNode - out of range X86ISD::VSRAI doesn't fold to zero
Noticed by inspection and I can't seem to make a test case, but SSE arithmetic bit shifts clamp to the max shift amount (i.e. create a sign splat) - combineVectorShiftImm already does something similar.
Dmitry Vassiliev [Sat, 30 Jul 2022 16:24:50 +0000 (18:24 +0200)]
[CodeGen] Fixed undeclared MISchedCutoff in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS
This patch fixes the error llvm/lib/CodeGen/MachineScheduler.cpp(755): error C2065: 'MISchedCutoff': undeclared identifier in case of NDEBUG and LLVM_ENABLE_ABI_BREAKING_CHECKS.
Note MISchedCutoff is declared under #ifndef NDEBUG.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D130425
Sanjay Patel [Sat, 30 Jul 2022 15:20:13 +0000 (11:20 -0400)]
[InstCombine] canonicalize more zext-and-of-bool compare to narrow and
https://alive2.llvm.org/ce/z/vBNiiM
This matches variants of patterns that were folded with:
b5a9361c90ca
Austin Kerbow [Sat, 30 Jul 2022 14:41:46 +0000 (07:41 -0700)]
[AMDGPU] Remove unused function
Simon Pilgrim [Sat, 30 Jul 2022 14:43:41 +0000 (15:43 +0100)]
OMPIRBuilder.h - fix Wdocumentation warning. NFC.
Simon Pilgrim [Sat, 30 Jul 2022 14:41:13 +0000 (15:41 +0100)]
Fix Wdocumentation warning. NFC.
warning: '\returns' command used in a comment that is attached to a function returning void
Simon Pilgrim [Sat, 30 Jul 2022 14:31:31 +0000 (15:31 +0100)]
[X86] combineSelect fold 'smin' style pattern select(pcmpgt(RHS, LHS), LHS, RHS) -> select(pcmpgt(LHS, RHS), RHS, LHS) if pcmpgt(LHS, RHS) already exists
Avoids repeated commuted comparisons when we're performing min/max and clamp patterns
Nuno Lopes [Sat, 30 Jul 2022 14:20:32 +0000 (15:20 +0100)]
ConstantFolding: fold OOB accesses to poison instead of undef
Sanjay Patel [Sat, 30 Jul 2022 13:43:09 +0000 (09:43 -0400)]
[InstCombine] avoid splitting a constant expression with div/rem fold
Follow-up to
d4940c0f3d43 to further limit the transform
to avoid an unintended pattern/fold of a constant expression.
Simon Pilgrim [Sat, 30 Jul 2022 12:59:47 +0000 (13:59 +0100)]
[DAG] Pull out repeated getOperand() calls for shuffle ops. NFC.
Simon Pilgrim [Sat, 30 Jul 2022 11:19:21 +0000 (12:19 +0100)]
[AMDGPU] Fix || vs && precedence warning. NFC.
Nuno Lopes [Sat, 30 Jul 2022 12:55:56 +0000 (13:55 +0100)]
[NFC] Switch a few uses of undef to poison as placeholders for unreachable code
Luo, Yuanke [Sat, 30 Jul 2022 11:39:03 +0000 (19:39 +0800)]
[X86] Add test cases for D129537
Simon Pilgrim [Sat, 30 Jul 2022 10:05:33 +0000 (11:05 +0100)]
SelectionDAGNodes.h - fix Wdocumentation warnings. NFC.
Simon Pilgrim [Sat, 30 Jul 2022 10:00:35 +0000 (11:00 +0100)]
DependencyScanningTool.h - fix Wdocumentation warning. NFC.
Simon Pilgrim [Sat, 30 Jul 2022 10:00:16 +0000 (11:00 +0100)]
Sema.h - fix Wdocumentation warnings. NFC.
Konstantin Varlamov [Sat, 30 Jul 2022 09:42:05 +0000 (02:42 -0700)]
[libc++][ranges] Implement `std::ranges::partial_sort_copy`.
Differential Revision: https://reviews.llvm.org/D130532
Alexander Shaposhnikov [Sat, 30 Jul 2022 09:06:37 +0000 (09:06 +0000)]
[InstCombine] Add fold for redundant sign bits count comparison
For power-of-2 C:
((X s>> ShiftC) ^ X) u< C --> (X + C) u< (C << 1)
((X s>> ShiftC) ^ X) u> (C - 1) --> (X + C) u> ((C << 1) - 1)
(https://github.com/llvm/llvm-project/issues/56479)
Test plan:
0/ ninja check-llvm check-clang + bootstrap LLVM/Clang
1/ https://alive2.llvm.org/ce/z/eEUfx3
Differential revision: https://reviews.llvm.org/D130433
Nikolas Klauser [Sun, 24 Jul 2022 14:46:57 +0000 (16:46 +0200)]
[libc++] Fix reverse_iterator::iterator_concept
Fixes https://github.com/llvm/llvm-project/issues/56504
Reviewed By: ldionne, Mordante, huixie90, #libc
Spies: libcxx-commits, hewillk
Differential Revision: https://reviews.llvm.org/D129794
Fangrui Song [Sat, 30 Jul 2022 08:24:55 +0000 (01:24 -0700)]
[ELF] Support missing relocations in AArch64::getImplicitAddend()
Alexander Shaposhnikov [Sat, 30 Jul 2022 08:23:45 +0000 (08:23 +0000)]
[InstCombine] Add baseline tests for redundant sign bits count folds
Add baseline tests. NFC.
(https://github.com/llvm/llvm-project/issues/56479)
Test plan:
ninja check-all
Differential revision: https://reviews.llvm.org/D130605
Fangrui Song [Sat, 30 Jul 2022 08:19:59 +0000 (01:19 -0700)]
[ELF] Write R_AARCH64_IRELATIVE addends with -z rel
Dawid Jurczak [Sat, 30 Jul 2022 07:15:11 +0000 (09:15 +0200)]
[NFC] Use more appropriate SmallVectorImpl::append call in std::initializer_list SmallVector constructor
Since we are in constructor there is no need to perform redundant call to SmallVectorImpl::clear() inside assign function.
Although calling cheaper append function instead assign doesn't make any difference on optimized builds
(DSE does the job removing stores), we still save some cycles for debug binaries.
Differential Revision: https://reviews.llvm.org/D130361
Phoebe Wang [Sat, 30 Jul 2022 05:13:21 +0000 (13:13 +0800)]
[X86][FP16] Regenerate test cases. NFC.
Kazu Hirata [Sat, 30 Jul 2022 04:18:44 +0000 (21:18 -0700)]
[llvm] Use is_contained (NFC)
Kazu Hirata [Sat, 30 Jul 2022 04:18:42 +0000 (21:18 -0700)]
Use is_sorted (NFC)
Kazu Hirata [Sat, 30 Jul 2022 04:18:41 +0000 (21:18 -0700)]
Use value instead of getValue (NFC)
Kazu Hirata [Sat, 30 Jul 2022 04:18:39 +0000 (21:18 -0700)]
[clang] Use has_value instead of value (NFC)