Armin Novak [Thu, 22 Oct 2015 07:31:47 +0000 (09:31 +0200)]
Fixed clipboard file transfer.
Armin Novak [Thu, 22 Oct 2015 07:01:30 +0000 (09:01 +0200)]
Fixed clipboard file contents response and message to string.
Bernhard Miklautz [Fri, 23 Oct 2015 10:38:13 +0000 (12:38 +0200)]
Merge pull request #2945 from mfleisz/wlog_compile_fix
wlog: Fix variable definitions
Martin Fleisz [Fri, 23 Oct 2015 10:08:20 +0000 (12:08 +0200)]
wlog: Fix variable definitions
Vic Lee [Fri, 23 Oct 2015 07:59:07 +0000 (15:59 +0800)]
Merge pull request #2929 from mfleisz/cliprdr_fix
cliprdr/server: Don't call CloseHandle on ChannelEvent
Martin Fleisz [Fri, 23 Oct 2015 06:49:24 +0000 (08:49 +0200)]
cliprdr/server: Fix memory leak
Hardening [Thu, 22 Oct 2015 08:35:43 +0000 (10:35 +0200)]
Merge pull request #2927 from MartinHaimberger/mh-log-returnvalues
wlog: fixed return values
MartinHaimberger [Wed, 21 Oct 2015 10:57:12 +0000 (12:57 +0200)]
Merge pull request #2939 from nfedera/fix-x11-clip-id
xfreerdp/clipr: fix self owned test and hardening
Martin Haimberger [Wed, 21 Oct 2015 08:11:06 +0000 (01:11 -0700)]
wlog: fixed return values
wlog used to return an int but the only meaning
of the return value was:
* negative ... error
* 0 or positive ... success
but the positve returned value was 1 or some id of some
subsystem, nothing meaningful for the caller.
For a more meaningful returnvalue we now use BOOL.
If something goes wrong FALSE is returned.
Martin Fleisz [Wed, 21 Oct 2015 07:53:42 +0000 (09:53 +0200)]
Merge pull request #2938 from LookBehind/master
Fix rdp_recv_logon_error_info
Norbert Federa [Tue, 20 Oct 2015 19:28:29 +0000 (21:28 +0200)]
xfreerdp/clipr: fix self owned test and hardening
- xf_cliprdr_is_self_owned() lied if multiple xfreerdp instances were
running.
- fixed a few unchecked callocs
- added/modified and handled some return values in compliance with
the new hardened channel api
LookBehind [Tue, 20 Oct 2015 14:05:09 +0000 (18:05 +0400)]
Fix rdp_recv_logon_error_info
As https://msdn.microsoft.com/en-us/library/
cc240641.aspx says - first is going errorNotificationType then errorNotificationData.
Martin Fleisz [Tue, 20 Oct 2015 06:44:52 +0000 (08:44 +0200)]
Merge pull request #2933 from realjiangms/fix_gdi_bitmap_update
GDI: Fix gdi_bitmap_update to check dest buffer size.
zihao.jiang [Sun, 18 Oct 2015 09:53:22 +0000 (17:53 +0800)]
GDI: Fix gdi_bitmap_update to check dest buffer size.
Martin Fleisz [Fri, 16 Oct 2015 09:40:25 +0000 (11:40 +0200)]
cliprdr/server: Don't call CloseHandle on EventHandle
Bernhard Miklautz [Fri, 16 Oct 2015 08:38:11 +0000 (10:38 +0200)]
Merge pull request #2910 from dupondje/master
FindGStreamer_1_0: fix build failure for new gstreamer versions
Marc-André Moreau [Wed, 14 Oct 2015 14:50:26 +0000 (10:50 -0400)]
Merge pull request #2924 from awakecoding/master
egfx multimon fixes
Marc-André Moreau [Tue, 13 Oct 2015 19:50:39 +0000 (15:50 -0400)]
libfreerdp-gdi: fix egfx multimon support
Marc-André Moreau [Tue, 13 Oct 2015 18:49:30 +0000 (14:49 -0400)]
xfreerdp: fix multiple egfx context support in X11 GFX
Marc-André Moreau [Tue, 13 Oct 2015 15:09:43 +0000 (11:09 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Tue, 13 Oct 2015 14:40:28 +0000 (10:40 -0400)]
Merge pull request #2919 from realjiangms/fix_allow_empty_password
Sec/NLA: Support passwordless (blank password) login with NLA.
Marc-André Moreau [Tue, 13 Oct 2015 14:23:58 +0000 (10:23 -0400)]
Merge pull request #2920 from awakecoding/mbedtls
WinPR mbed TLS support
Marc-André Moreau [Tue, 13 Oct 2015 13:54:59 +0000 (09:54 -0400)]
libwinpr-crypto: fix OpenSSL 1.0 HMAC API change
Marc-André Moreau [Tue, 13 Oct 2015 13:43:26 +0000 (09:43 -0400)]
libwinpr-crypto: fix error checking
Marc-André Moreau [Tue, 13 Oct 2015 13:13:52 +0000 (09:13 -0400)]
libwinpr-crypto: avoid linking to less common digests and ciphers
Hardening [Tue, 13 Oct 2015 06:53:45 +0000 (08:53 +0200)]
Merge pull request #2912 from realjiangms/shadow_fix_auth_nopasswd
Server/Shadow: Minor fix on authentication in shadow_client.c.
Marc-André Moreau [Fri, 9 Oct 2015 19:58:50 +0000 (15:58 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP into mbedtls
Marc-André Moreau [Fri, 9 Oct 2015 19:57:41 +0000 (15:57 -0400)]
winpr: make clean non-OpenSSL build possible (without schannel, makecert)
Marc-André Moreau [Fri, 9 Oct 2015 19:23:15 +0000 (15:23 -0400)]
libwinpr-crypto: add generic digest API and OpenSSL compatible key derivation
zihao.jiang [Fri, 9 Oct 2015 17:48:41 +0000 (01:48 +0800)]
Sec/NLA: Support passwordless (blank password) login with NLA.
It was supported in freerdp 1.0.2 but not supported in lastest master.
We should take empty password if it is explicitly specified with /v option.
If a password is not specified, we could first try SAM file. If the user entry does not exist, prompt for password.
Marc-André Moreau [Fri, 9 Oct 2015 16:15:31 +0000 (12:15 -0400)]
libwinpr-crypto: add generic cipher API with OpenSSL/mbedtls support
Marc-André Moreau [Thu, 8 Oct 2015 20:48:58 +0000 (16:48 -0400)]
libwinpr-sspi: remove OpenSSL dependency in NTLM SSPI module
Marc-André Moreau [Thu, 8 Oct 2015 20:26:37 +0000 (16:26 -0400)]
libwinpr-crypto: add rand and RC4 functions with OpenSSL/mbedtls
Marc-André Moreau [Thu, 8 Oct 2015 17:58:55 +0000 (13:58 -0400)]
libwinpr-crypto: add basic hashing and HMAC support with OpenSSL/mbedTLS
Marc-André Moreau [Tue, 6 Oct 2015 14:56:24 +0000 (10:56 -0400)]
winpr: isolate OpenSSL
Martin Fleisz [Tue, 6 Oct 2015 07:02:22 +0000 (09:02 +0200)]
Merge pull request #2914 from sriramster/master
Remove warning: HANDLE event variable unused
Marc-André Moreau [Mon, 5 Oct 2015 20:23:44 +0000 (16:23 -0400)]
winpr: start porting to non-OpenSSL
Sriram Raghunathan [Mon, 5 Oct 2015 17:12:59 +0000 (22:42 +0530)]
Remove warning: HANDLE event variable unused
zihao.jiang [Fri, 2 Oct 2015 08:09:12 +0000 (16:09 +0800)]
Server/Shadow: Fix Authentication in shadow_client.c.
Currently if username or password is not set, the authentication is always failed because the authentication callback is never tried.
Fix to always give a chance to try the subsystem authentication callback even if username / password is not set.
Marc-André Moreau [Mon, 5 Oct 2015 12:44:42 +0000 (08:44 -0400)]
Merge pull request #2909 from akallabeth/clipboard_remove_copy
Speedup for clipboard
Marc-André Moreau [Mon, 5 Oct 2015 12:40:34 +0000 (08:40 -0400)]
Merge pull request #2901 from volth/patch-1
Fixed crash when unused Japanese keys are pressed.
Jean-Louis Dupond [Sun, 4 Oct 2015 16:17:33 +0000 (18:17 +0200)]
FindGStreamer_1_0: fix build failure for new gstreamer versions
Armin Novak [Fri, 2 Oct 2015 07:29:00 +0000 (09:29 +0200)]
Remove unnecessary copy operation.
Martin Fleisz [Thu, 1 Oct 2015 11:45:20 +0000 (13:45 +0200)]
Merge pull request #2864 from bjcollins/smartcard_same_name_readers
Give unique aliases for smartcards with the same name, so that two re…
Norbert Federa [Thu, 1 Oct 2015 09:28:47 +0000 (11:28 +0200)]
Merge pull request #2908 from hardening/fix_region
Fix a bug in region_union_rect()
David FORT [Wed, 30 Sep 2015 19:14:43 +0000 (21:14 +0200)]
Fix a bug in region_union_rect()
When region_union_rect() was called with a rect that was above the region without
intersecting it, the first band was created too large. This patch fixes this and
add a unitary test.
All credits go to @nfedera that:
* found the bug;
* find a dataset to reproduce;
* code the unitary test;
* spotted a suspicious line that was the faulty one.
Hardening [Thu, 24 Sep 2015 19:18:46 +0000 (21:18 +0200)]
Merge pull request #2903 from ssieb/fix-redir
Don't fail the redirect if padding wasn't sent before disconnecting
Samuel Sieb [Thu, 24 Sep 2015 17:37:21 +0000 (10:37 -0700)]
Don't fail the redirect if padding wasn't sent before disconnecting
volth [Wed, 23 Sep 2015 18:40:34 +0000 (18:40 +0000)]
Update xf_keyboard.c
With Japanese physical keyboard and English layout, pressing the extra keys can cause FreeRDP crash.
Marc-André Moreau [Tue, 22 Sep 2015 15:53:50 +0000 (11:53 -0400)]
afreerdp: fix build warnings
Hardening [Mon, 21 Sep 2015 21:42:32 +0000 (23:42 +0200)]
Merge pull request #2899 from awakecoding/master
Standard RDP security server redirection fix
Marc-André Moreau [Mon, 21 Sep 2015 19:36:19 +0000 (15:36 -0400)]
libfreerdp-core: fix redirection with standard RDP security
Martin Fleisz [Mon, 21 Sep 2015 12:31:47 +0000 (14:31 +0200)]
Merge pull request #2897 from bjcollins/rail_fix_window_title
Minor rail fixes/tweaks
Hardening [Mon, 21 Sep 2015 11:50:29 +0000 (13:50 +0200)]
Merge pull request #2898 from bjcollins/smartcard_status_buffer_size
Fix use of invalid input causing SCARD_E_INSUFFICIENT_BUFFER errors
bjcollins [Fri, 18 Sep 2015 21:55:06 +0000 (16:55 -0500)]
Dont use invalid/bogus input value for cbAtrLen for Smartcard Status Calls, instead just always use the max value here to indicate we have max
buffer space available.
bjcollins [Fri, 18 Sep 2015 21:14:30 +0000 (16:14 -0500)]
fix window title for rail as it was not being set on initial window creation
remove duplicate call to XStoreName when setting window title
expand WITH_XEXT #define for rail window rects as extra unecessary work was being done when WITH_XEXT was not defined
Marc-André Moreau [Fri, 18 Sep 2015 15:57:01 +0000 (11:57 -0400)]
Merge pull request #2896 from awakecoding/master
Win32 Gateway Fix, iOS TCP connection infinite loop fix
Marc-André Moreau [Fri, 18 Sep 2015 15:38:27 +0000 (11:38 -0400)]
libwinpr-synch: fix broken FD_ISSET check caused by hidden type cast from int to char
Marc-André Moreau [Thu, 17 Sep 2015 18:32:40 +0000 (14:32 -0400)]
libfreerdp-core: fix gateway connectivity on Windows
Marc-André Moreau [Thu, 17 Sep 2015 15:16:20 +0000 (11:16 -0400)]
libwinpr-sspi: don't warn about non-error security statuses
Martin Fleisz [Thu, 17 Sep 2015 14:02:00 +0000 (16:02 +0200)]
Merge pull request #2895 from aballier/ffmpeg
channels/tsmf/client/ffmpeg: Fix build with ffmpeg git master.
Alexis Ballier [Thu, 17 Sep 2015 08:36:44 +0000 (10:36 +0200)]
channels/tsmf/client/ffmpeg: Fix build with ffmpeg git
Replace old, deprecated and now removed, APIs with their new equivalent while retaining backward compatibility with old ffmpeg versions.
Martin Fleisz [Thu, 17 Sep 2015 08:33:43 +0000 (10:33 +0200)]
Merge pull request #2890 from realjiangms/shadow_fix_memory_leak
server: Fix several memory leak found while running valgrind on freerdp-shadow
zihao.jiang [Tue, 15 Sep 2015 15:17:22 +0000 (23:17 +0800)]
server: Fix several memory leak while running valgrind on freerdp-shadow
Marc-André Moreau [Wed, 16 Sep 2015 14:41:32 +0000 (10:41 -0400)]
Merge branch 'master' of github.com:FreeRDP/FreeRDP
Marc-André Moreau [Wed, 16 Sep 2015 14:41:07 +0000 (10:41 -0400)]
Merge pull request #2889 from dvincent-devolutions/gateway
Fix RDP8 gateway disconnections
Denis Vincent [Wed, 16 Sep 2015 13:54:03 +0000 (09:54 -0400)]
Small corrections to BIO implementation.
Marc-André Moreau [Wed, 16 Sep 2015 00:52:46 +0000 (20:52 -0400)]
cmake: add mbed TLS detection
Marc-André Moreau [Tue, 15 Sep 2015 23:59:41 +0000 (19:59 -0400)]
libfreerdp-crypto: add locking of operations dealing with SSL*
Marc-André Moreau [Tue, 15 Sep 2015 17:03:11 +0000 (13:03 -0400)]
libfreerdp-core: alternative RDG BIO fix
Marc-André Moreau [Tue, 15 Sep 2015 14:37:57 +0000 (10:37 -0400)]
libfreerdp-core: fix code style
Martin Fleisz [Tue, 15 Sep 2015 13:57:56 +0000 (15:57 +0200)]
Merge pull request #2887 from FreeRDP/mh-file-api-extension
winpr/file: extend API
Marc-André Moreau [Tue, 15 Sep 2015 13:24:04 +0000 (09:24 -0400)]
Merge branch 'gateway' of https://github.com/dvincent-devolutions/FreeRDP
MartinHaimberger [Tue, 15 Sep 2015 13:16:37 +0000 (15:16 +0200)]
Merge pull request #2886 from clangm/master
Fix Network Characteristics Autodetect [RDPBCGR 2.2.14]
Marc-André Moreau [Tue, 15 Sep 2015 13:12:00 +0000 (09:12 -0400)]
Merge pull request #2888 from awakecoding/master
fix ARM64 data type portability
Marc-André Moreau [Tue, 15 Sep 2015 13:08:47 +0000 (09:08 -0400)]
Merge pull request #2879 from peterh/shape
xfreerdp: Fix window shape
Denis Vincent [Tue, 15 Sep 2015 13:03:39 +0000 (09:03 -0400)]
libfreerdp-core: Gateway RDP8 BIO correction. Fixes connection losses.
MartinHaimberger [Tue, 15 Sep 2015 12:53:55 +0000 (14:53 +0200)]
Merge pull request #2763 from akallabeth/nla_null_auth
Fixed server and client NLA state machine for NULL identity.
MartinHaimberger [Tue, 15 Sep 2015 12:45:42 +0000 (14:45 +0200)]
Merge pull request #2859 from akallabeth/resource_leak_fix
Fixes API misuse and logic errors
Martin Haimberger [Tue, 15 Sep 2015 11:14:30 +0000 (04:14 -0700)]
winpr/file: extend API
added windows code
fixed compiler issue
Bernhard Miklautz [Mon, 14 Sep 2015 23:18:19 +0000 (01:18 +0200)]
winpr/file: extend API
Add function GetFileHandleForFileDescriptor to get
a file handle for a valid file descriptor.
Hardening [Tue, 15 Sep 2015 07:07:15 +0000 (09:07 +0200)]
Merge pull request #2883 from bceverly/master
Updated OpenBSD changes
Marc-André Moreau [Mon, 14 Sep 2015 18:34:24 +0000 (14:34 -0400)]
winpr: fix ARM64 data type portability
Bryan Everly [Mon, 14 Sep 2015 17:21:00 +0000 (13:21 -0400)]
Merge remote-tracking branch 'upstream/master'
Bryan Everly [Mon, 14 Sep 2015 17:20:11 +0000 (13:20 -0400)]
Cleaned up previous OpenBSD change per recommendation
MartinHaimberger [Mon, 14 Sep 2015 15:15:50 +0000 (17:15 +0200)]
Merge pull request #2877 from bmiklautz/filehandling
winpr/file refactoring and regular file support
clangm [Fri, 11 Sep 2015 21:01:31 +0000 (15:01 -0600)]
Removed if statement that was causing network characteristics autodetect to not work
Bryan Everly [Fri, 11 Sep 2015 12:54:40 +0000 (08:54 -0400)]
Updated OpenBSD changes
Hardening [Fri, 11 Sep 2015 07:43:48 +0000 (09:43 +0200)]
Merge pull request #2880 from bceverly/master
Fixes for OpenBSD port
Bryan Everly [Fri, 11 Sep 2015 01:31:13 +0000 (21:31 -0400)]
Fixes for OpenBSD port
Peter Harris [Thu, 10 Sep 2015 22:15:55 +0000 (18:15 -0400)]
xfreerdp: Fix window shape
Don't abort the entire xf_rail_window_common function when the window is
already in the correct location.
To reproduce:
- move an application off the edge of the screen
- resize the window to cause a shape to be set
- move the application window fully on the screen
- resize the application window larger
- note lack of drawing in newly enlarged portion of window
Bug introduced in
abf6d4f71ea901e31ee2d1b4625fa805af6b0cc9 "xfreerdp:
prepare RAIL migration away from libfreerdp-rail" when
xf_rail_MoveWindow was copy-and-pasted into xf_rail_window_common
without noticing that the "return" would omit the rest of the combined
function, not just the portion that was pasted.
Martin Fleisz [Thu, 10 Sep 2015 13:23:11 +0000 (15:23 +0200)]
Merge pull request #2878 from akallabeth/screen_orientation_types
Added ORIENTATION_PREFERENCE from WinUser.h.
Armin Novak [Thu, 10 Sep 2015 11:26:37 +0000 (13:26 +0200)]
Added ORIENTATION_PREFERENCE from WinUser.h.
Bernhard Miklautz [Thu, 10 Sep 2015 09:50:10 +0000 (11:50 +0200)]
winpr/file: integrate pull request feedback
* simplify RemoveDirectory
* move std handle function into an extern C block
Bernhard Miklautz [Wed, 9 Sep 2015 15:07:40 +0000 (17:07 +0200)]
winpr/file: don't close stdin/stdout/stderr
If the handle is closed stdin/stdout/stderr should be left open.
Bernhard Miklautz [Wed, 9 Sep 2015 14:59:03 +0000 (16:59 +0200)]
winpr/file: fix ios build
comm is only build on linux.
Bernhard Miklautz [Wed, 9 Sep 2015 14:47:03 +0000 (16:47 +0200)]
winpr/file: initial regular file support
Add initial support for "regular" files. First implemented call is
GetStdHandle to get stdin/stdout/stderr.
Bernhard Miklautz [Wed, 9 Sep 2015 13:48:59 +0000 (15:48 +0200)]
winpr/file: refactoring
The used method for initalizing and registering the handle creators
had certain disadvantages like that it was necessary to have the creators
initialized before the first call to CreateFile. In case of comm it
wouldn't have been possible to open an comm port without calling any
other call related function first.
Now the handle creators are initialized the first time CreateFile is
called. This way it is also possible to ensure a certain order of the
handler invocations.
This commit also splits out the client side named pipe code from
the generic file handling (now called generic.c instead of file.c) and
uses the new handle creator infrastructure to register.
Bernhard Miklautz [Mon, 7 Sep 2015 09:42:07 +0000 (11:42 +0200)]
Merge pull request #2868 from nfedera/fix-inverted-pointer-colors
improve handling of inverted pointer colors
Bernhard Miklautz [Mon, 7 Sep 2015 09:15:51 +0000 (11:15 +0200)]
Merge pull request #2873 from mfleisz/makecert_change
makecert: Remove key usage attribute