Maryam Ariyan [Tue, 12 Sep 2017 01:44:17 +0000 (21:44 -0400)]
fixing failure on linux
Commit migrated from https://github.com/dotnet/corefx/commit/
fc03dc4f74da1df872958d4e087e46b38b02f04c
Maryam Ariyan [Mon, 11 Sep 2017 20:43:38 +0000 (16:43 -0400)]
Applying code review comments
fixes dotnet/corefx#22299 and dotnet/corefx#19956
Commit migrated from https://github.com/dotnet/corefx/commit/
1a22357d316cd39bd4cf163009480ac7689a8ddb
Maryam Ariyan [Mon, 11 Sep 2017 08:12:20 +0000 (08:12 +0000)]
Add test for 22299, to throw if folder passed in
Commit migrated from https://github.com/dotnet/corefx/commit/
5fcd9c7ece4b3f0186f6f4646ea8d1f9c4a01e47
Maryam Ariyan [Mon, 11 Sep 2017 06:01:29 +0000 (02:01 -0400)]
Refactored code and cleaned up tests
Commit migrated from https://github.com/dotnet/corefx/commit/
4620a97d1fd481c9bc4ec57db60ebda099d1cc15
Maryam Ariyan [Fri, 8 Sep 2017 04:21:07 +0000 (00:21 -0400)]
Improving unix implementation for UseShellExecute
Making sure we are coherent with mono implementation
Added unit tests per linux and osx
Commit migrated from https://github.com/dotnet/corefx/commit/
75f34a55635532134584b7910c0fd30fa81d591d
Eric Mellino [Fri, 25 Aug 2017 17:56:15 +0000 (10:56 -0700)]
Merge pull request dotnet/corefx#23242 from KostaVlev/master
Adding System.Drawing.Printing PrinterSettings tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
43c08c9e233647e1928a1758afddaf3161309f7e
Atsushi Kanamori [Fri, 25 Aug 2017 15:18:36 +0000 (08:18 -0700)]
Reenable tests that are now working on ILC (dotnet/corefx#23552)
Commit migrated from https://github.com/dotnet/corefx/commit/
5d3e42f831ec3d4c5964040e235824f779d5db53
dotnet-maestro-bot [Fri, 25 Aug 2017 15:17:56 +0000 (08:17 -0700)]
Update CoreClr, CoreFx, Standard to preview2-25625-02, preview2-25625-02, preview1-25625-01, respectively (dotnet/corefx#23550)
Commit migrated from https://github.com/dotnet/corefx/commit/
fe0f874448736f2f736232e3b9e1ce159a62f057
dotnet-maestro-bot [Fri, 25 Aug 2017 04:21:06 +0000 (21:21 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25625-00, beta-25625-00, respectively (dotnet/corefx#23540)
Commit migrated from https://github.com/dotnet/corefx/commit/
4979e8b57b4d926a3cebd101c1b6cd6cf7ada58d
Ahson Ahmed Khan [Fri, 25 Aug 2017 04:20:46 +0000 (21:20 -0700)]
Remove Span(T[], int) ctor (and ROS) (dotnet/corefx#23530)
* Remove Span(T[], int) ctor - from corefx issue dotnet/corefx#23471
* Remove uses of the Span/ROS constructor that takes an array and offset
Commit migrated from https://github.com/dotnet/corefx/commit/
9fff9097da3fbfcec995feb428780ca3e1c82972
dotnet-maestro-bot [Fri, 25 Aug 2017 02:41:00 +0000 (19:41 -0700)]
Update CoreClr, CoreSetup to preview2-25625-01, preview2-25624-02, respectively (dotnet/corefx#23538)
Commit migrated from https://github.com/dotnet/corefx/commit/
41855205a68202b3bb73622eecb6122dc24df731
Jan Vorlicek [Fri, 25 Aug 2017 01:14:06 +0000 (03:14 +0200)]
Update DotNetHost version refererence (dotnet/corefx#23536)
This change updates the version of the DotNetHost and DotNetHostPolicy
to a newer version that's available for RHEL 6 too.
Commit migrated from https://github.com/dotnet/corefx/commit/
d21b5400f9793024b5edaf7978ecb77c4f04bda4
Cory Rivera [Fri, 25 Aug 2017 00:40:45 +0000 (17:40 -0700)]
Fixed a bug where SqlDataReader.GetSchemaTable() would throw an error with UDT queries. (dotnet/corefx#23529)
Commit migrated from https://github.com/dotnet/corefx/commit/
101eb844e9c6555a3a29483c97941bdf03af84ed
Wes Haggard [Fri, 25 Aug 2017 00:18:00 +0000 (17:18 -0700)]
Merge pull request dotnet/corefx#23467 from jlanng/build-behind-corp-proxy
Allow build to work behind corporate proxy servers
Commit migrated from https://github.com/dotnet/corefx/commit/
63b4bb94df0722b43d17a2a8408d87d926c38360
Jan Kotas [Fri, 25 Aug 2017 00:13:27 +0000 (17:13 -0700)]
Make DisableMediaInsertionPrompt to be private struct to match CoreLib (dotnet/corefx#23507)
Commit migrated from https://github.com/dotnet/corefx/commit/
94b19a4a2405c9fabaf6564cb49cbc4b0957ac6c
Viktor Hofer [Thu, 24 Aug 2017 23:57:55 +0000 (01:57 +0200)]
Adding cross framework serialization and blob sanity check for serializable Exception types (dotnet/corefx#23523)
* Adding cross framework serialization and blob sanity check for serializable Exception types
* Add AggregateException equality check and check InnerException of Exception type
* Refine test data for exceptions
* Manual StackTrace override for Exception serialization tests
* Improved exception serialization data
Commit migrated from https://github.com/dotnet/corefx/commit/
a534c0ebbd3c5741f97590ece32f1b31645f0994
James Ko [Thu, 24 Aug 2017 21:55:28 +0000 (17:55 -0400)]
Override CopyTo in BufferedStream and GZipStream (dotnet/corefx#23493)
Commit migrated from https://github.com/dotnet/corefx/commit/
075d30f9e1cca06bb919897e1baea266dce4cda9
Eric Mellino [Thu, 24 Aug 2017 19:23:42 +0000 (12:23 -0700)]
Merge pull request dotnet/corefx#23182 from qmfrederik/drawing/linux
System.Drawing: Consolidate GraphicsContainer code accross Unix and Windows
Commit migrated from https://github.com/dotnet/corefx/commit/
e79c45a1148a2b8e85edd613c0b1b28d43ae0879
Tijoy Tom [Thu, 24 Aug 2017 19:19:53 +0000 (12:19 -0700)]
Merge pull request dotnet/corefx#23521 from tijoytom/master
Add Marshal ThrowExceptionForHR test.
Commit migrated from https://github.com/dotnet/corefx/commit/
8ba8c9429b1639472fe641324ce49d2f0dd9c261
tijoytk [Thu, 24 Aug 2017 17:02:35 +0000 (10:02 -0700)]
Add Marshal ThrowExceptionForHR test.
Marshal.GetExceptionForHR and Marshal.ThrowExceptionForHR
should give the same exception for the same error-code.
Taking care of review comments
Commit migrated from https://github.com/dotnet/corefx/commit/
37b8ebd0939b4ebc0962d96902fcbe034838613b
Nina Chikanov [Thu, 24 Aug 2017 16:57:06 +0000 (09:57 -0700)]
Wrap CurrentCulture assignments in RemoteInvokes for Issue dotnet/corefx#23328 (dotnet/corefx#23492)
* nits addressed
Commit migrated from https://github.com/dotnet/corefx/commit/
dc7b772819f5f08a9d45c4185354d498c57569e9
Stephen Toub [Thu, 24 Aug 2017 16:35:39 +0000 (12:35 -0400)]
Add tests for FileStream span-based overrides (dotnet/corefx#23481)
Commit migrated from https://github.com/dotnet/corefx/commit/
7c35a83d31acf6c8f67ab8714847c71107a8b5db
Stephen Toub [Thu, 24 Aug 2017 15:21:08 +0000 (11:21 -0400)]
Merge pull request dotnet/corefx#23462 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25624-02, preview2-25624-01, beta-25624-00, beta-25624-01, beta-25624-01, preview1-25624-01, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
06d361cf2bbce39389d293f4d3fd9dae3619e034
Stephen Toub [Thu, 24 Aug 2017 14:32:31 +0000 (10:32 -0400)]
Fix Stream read/write span tests for updated behavior
Commit migrated from https://github.com/dotnet/corefx/commit/
97d2c67cf71f90709ca11fc281a16365e747b6b7
dotnet-maestro-bot [Thu, 24 Aug 2017 13:31:08 +0000 (06:31 -0700)]
Update CoreClr, CoreFx, External, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25624-02, preview2-25624-01, beta-25624-00, beta-25624-01, beta-25624-01, preview1-25624-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
866b5b6e8bd2408a6bab9579b297eb49e35c5e73
Joseph Tremoulet [Thu, 24 Aug 2017 03:35:58 +0000 (23:35 -0400)]
Undo a few JIT layout workarounds (dotnet/corefx#23510)
Remove some `goto`s that were added to work around dotnet/coreclrdotnet/corefx#9692
(poor code layout for loop exit paths) -- the JIT's layout decisions
were improved in dotnet/coreclrdotnet/corefx#13314, and these particular `goto`s are
no longer needed; the same machine code is generated with or without
this change.
Some `goto`s previously tagged as workarounds for dotnet/coreclrdotnet/corefx#9692 are
still relevant for keeping codesize down pending dotnet/coreclrdotnet/corefx#13549;
update their comments accordingly.
Part of dotnet/corefx#23395.
Commit migrated from https://github.com/dotnet/corefx/commit/
d90ebb8bcfc24827c7eb478c178d8f98a8b98dd3
Santiago Fernandez Madero [Thu, 24 Aug 2017 02:11:47 +0000 (21:11 -0500)]
Change SkipOnTargetFramework to ConditionalTheory as this will enable the tests in UapAot whenever we move to running them inside AppContainer (dotnet/corefx#23511)
Commit migrated from https://github.com/dotnet/corefx/commit/
f499ace4c19ee2ef8975c8c436601e04b6b6efc5
Karel Zikmund [Wed, 23 Aug 2017 22:27:44 +0000 (15:27 -0700)]
Add Interop backup owner
Commit migrated from https://github.com/dotnet/corefx/commit/
9d8f4b41d0cfc1f360beb2d3e7eb04f21c6a07cc
Krzysztof Wicher [Wed, 23 Aug 2017 22:25:05 +0000 (15:25 -0700)]
Merge pull request dotnet/corefx#23490 from krwq/fix23343
fix improperly generated method tokens in XSL IlGen
Commit migrated from https://github.com/dotnet/corefx/commit/
4bd525506ae175fad974d2cc5a235b6da950afeb
Karel Zikmund [Wed, 23 Aug 2017 22:18:04 +0000 (15:18 -0700)]
Fix GH user name casing
Commit migrated from https://github.com/dotnet/corefx/commit/
bdb63ae48e2d9066216d718ecbadcc9e4bf61a88
Dan Moseley [Wed, 23 Aug 2017 20:23:07 +0000 (13:23 -0700)]
update owners (dotnet/corefx#23488)
Commit migrated from https://github.com/dotnet/corefx/commit/
9247c705fe8959e14cf77e12fef172cd25e2f155
Matt Galbraith [Wed, 23 Aug 2017 20:14:00 +0000 (13:14 -0700)]
Merge pull request dotnet/corefx#23508 from MattGal/Remove_extra_UAPAOT
Fix pipeline entries which cause 3x extra AOT runs
Commit migrated from https://github.com/dotnet/corefx/commit/
718c4f7e28b35baf059917667927fc8ad0e3b668
Matt Galbraith [Wed, 23 Aug 2017 20:10:09 +0000 (13:10 -0700)]
Remove Windows.10.Amd64.Core from desktop runs as this is uninteresting there and no expected variance from regular windows 10 skus.
Commit migrated from https://github.com/dotnet/corefx/commit/
a72eb4bf8a77fd94d865b0ced81dbf27f129a0ba
smile21prc [Wed, 23 Aug 2017 19:24:04 +0000 (12:24 -0700)]
Initialize tools twice, to fix corefx build breaks and enable RHEL6 (dotnet/corefx#23509)
* Initialize tools twice, to fix corefx build breaks and enable RHEL6
Initialize tools twice, to fix corefx build breaks and enable RHEL6
* Remove unnecessary "workingFolder" values
Remove unnecessary "workingFolder" values
Commit migrated from https://github.com/dotnet/corefx/commit/
1bb6d8b3b89d069871024657bc3883e45f70ffde
Matt Galbraith [Wed, 23 Aug 2017 19:08:16 +0000 (12:08 -0700)]
Fix pipeline entries which cause 3x extra AOT runs
Commit migrated from https://github.com/dotnet/corefx/commit/
1a3c6dae19ce28f0544362c5f41a1a8fe1bebba1
Viktor Hofer [Wed, 23 Aug 2017 13:04:13 +0000 (15:04 +0200)]
Set InvariantCulture Local explicitely and improve error logging (dotnet/corefx#23486)
* Set InvariantCulture Local explicitely and improve error logging
Commit migrated from https://github.com/dotnet/corefx/commit/
dd8bc0d9e929ff4a7da368ae1c16b9b33e9c8a6a
Jon Hanna [Wed, 23 Aug 2017 01:56:26 +0000 (02:56 +0100)]
Don't consider TypeParameterTypes in Microsoft.CSharp constraint checks (dotnet/corefx#23287)
Since we only consider constraints for calls on actual types (rather
than we would if compiling a call from within a generic method), arg is
never a TypeParameterType, so don't consider the case of it being so.
Entails removal of ERR_GenericConstraintNotSatisfiedTyVar, contributes
to dotnet/corefx#22470
Commit migrated from https://github.com/dotnet/corefx/commit/
1f1c37bd65c78e75c6b3f5f3113e859c9d18aa42
smile21prc [Wed, 23 Aug 2017 00:52:05 +0000 (17:52 -0700)]
Correct the docker file path when granting it access. (dotnet/corefx#23495)
Correct the docker file path when granting it access.
Commit migrated from https://github.com/dotnet/corefx/commit/
9b0e5ebde44f04446dc6f6109202e77bbcf4b22f
smile21prc [Wed, 23 Aug 2017 00:35:05 +0000 (17:35 -0700)]
Grant access to downloaded docker files. (dotnet/corefx#23494)
Grant access to downloaded docker files.
Commit migrated from https://github.com/dotnet/corefx/commit/
a8eb759862beb00c7b54293400b0ca617c1979f6
Eric Erhardt [Wed, 23 Aug 2017 00:28:28 +0000 (19:28 -0500)]
Update dogfooding instructions to copy native assets. (dotnet/corefx#23474)
Native assets aren't being copied when following the dogfooding instructions because the Microsoft.NETCore.App package is being preferred over the local CoreFX package.
Commit migrated from https://github.com/dotnet/corefx/commit/
7d694172b2275ddd0ed1524dbec83f07295672f4
smile21prc [Tue, 22 Aug 2017 23:26:42 +0000 (16:26 -0700)]
Fix "Download docker file" BD (dotnet/corefx#23491)
Fix "Download docker file" BD
Commit migrated from https://github.com/dotnet/corefx/commit/
fd3004d31e233ff42cab77f1ef0a49ea388bc9ac
Krzysztof Wicher [Tue, 22 Aug 2017 22:58:19 +0000 (15:58 -0700)]
fix improperly generated method tokens in XSL IlGen
Commit migrated from https://github.com/dotnet/corefx/commit/
16a09e2210c87306ffaff86e74750789acafce43
smile21prc [Tue, 22 Aug 2017 22:10:53 +0000 (15:10 -0700)]
Replace "Initialize tools" to only download docker files (dotnet/corefx#23450)
* Replace "Initialize tools" to only download docker files
This way "Initialize tools" will be done later INSIDE docker, instead of
OUTSIDE. This fixes issue:
https://github.com/dotnet/core-eng/issues/1544
* Put docker files into dir "tools/dockerscripts" instead of root.
Put docker files into dir "tools/dockerscripts" instead of root.
Commit migrated from https://github.com/dotnet/corefx/commit/
70dc13edc883b2e7778b4c99d9ba7edabbedec26
Jon Hanna [Tue, 22 Aug 2017 21:38:28 +0000 (22:38 +0100)]
Remove dead code from CreateArray in Microsoft.CSharp & tidy the rest (dotnet/corefx#23272)
* Remove dead code from BindArrayIndexCore
Is only ever called with expression typed ArrayType so remove path for
other types.
* Remove unused BindingFlags argument.
* Include fallback within ChooseArrayIndexType
Int32 is always used when it fails to find a match, so move that logic into it, itself.
* Remove branch for CreateArrayIndex called with non-array.
Never happens.
Also, element type was already found for unsafe check, so pass it in.
* Move ArrayType flag setting into ArrayType ctor
* Remove bindInder
Only caller was removed as dead code.
Commit migrated from https://github.com/dotnet/corefx/commit/
ac12102849394460d50a09a0c3c113088ed483ef
Jon Hanna [Tue, 22 Aug 2017 21:16:42 +0000 (22:16 +0100)]
Some Microsoft.CSharp.RuntimeBinder.SymbolTable refactoring (dotnet/corefx#23071)
* Define AddMethodToSymbolTable as taking MethodBase
AddMethodToSymbolTable is called with a MemberInfo that can be either a
MethodInfo or a ConstructorInfo, and takes different paths for each.
Much of what these paths do is a duplication of calls that are
available through those types common MethodBase base.
Change the parameter type to MethodBase and use it as much as possible.
* Replace if-else ladder on Type with switch on TypeCode
* Remove some unused locals and assignments
* Cache parameter from array rather than hitting array repeatedly.
* Use typed GetCustomAttribute rather than GetCustomAttributes
Commit migrated from https://github.com/dotnet/corefx/commit/
ab0b5de73f02f7b993e1ee1c43c5d2604877f56c
Andrew Stanton-Nurse [Tue, 22 Aug 2017 19:31:59 +0000 (12:31 -0700)]
Remove invalid "bold" syntax in EventCounter docs (dotnet/corefx#23482)
The use of "**" to try to call out a piece of preformatted code as bold doesn't actually work, because the preformatted code block overrides any Markdown syntax in the block. The EventCounter docs use this to try to call out a section of preformatted code as bold, and it causes confusion, as the user may think that the `**` sequence is needed (when it is actually invalid)
Commit migrated from https://github.com/dotnet/corefx/commit/
7c3c88d490ae557241aa838695063415822dc692
Jon Hanna [Tue, 22 Aug 2017 19:05:02 +0000 (20:05 +0100)]
Remove Microsoft.CSharp.RuntimeBinder.Semantics.SymbolLoader.FCanLift (dotnet/corefx#23062)
Always returns true (flag for static compiling where nullable and hence
lifting is not available).
Remove, and paths for it being false.
Commit migrated from https://github.com/dotnet/corefx/commit/
02d647bba44e63496aaa4aa4b5953a355a4c8f1b
Omar Tawfik [Tue, 22 Aug 2017 18:42:06 +0000 (11:42 -0700)]
Fix duplicate types exception on WinRT interfaces (dotnet/corefx#23402)
* Fix duplicate types exception on WinRT interfaces
* Maintaining order
Commit migrated from https://github.com/dotnet/corefx/commit/
158b600e764c7dcc1e7117609c4d9709d62f1755
Cory Rivera [Tue, 22 Aug 2017 18:19:08 +0000 (11:19 -0700)]
Disable SqlClient tests that use TestTdsServer, since TestTdsServer has some issues that can cause connection test timeouts and other failures. (dotnet/corefx#23453)
Commit migrated from https://github.com/dotnet/corefx/commit/
61bd711c3e977ee789831855b96618a7200b5b8f
Santiago Fernandez Madero [Tue, 22 Aug 2017 16:02:53 +0000 (11:02 -0500)]
Fix wrong SkipOnTargetFramework in EnvironmentTests which were not skipped in uapaot (dotnet/corefx#23452)
Commit migrated from https://github.com/dotnet/corefx/commit/
6572e105ca33d067b6012cc5946e01c6552af06a
James Lanng [Tue, 22 Aug 2017 11:23:28 +0000 (12:23 +0100)]
If a proxy server responds with 407, credentials required, attempt to pass default credentials. Required in many corporate network scenarios
Commit migrated from https://github.com/dotnet/corefx/commit/
273a47ab9e3b5930d4d0d3f5d981ff4227f790c1
James Ko [Tue, 22 Aug 2017 05:54:18 +0000 (01:54 -0400)]
Move argument validation for some ImmutableList functions to ImmutableList.Node (dotnet/corefx#23237)
* Move argument validation to ImmutableList.Node
* Remove argument validation from Builder
Commit migrated from https://github.com/dotnet/corefx/commit/
9133938aa24bfe6b842fab824a50d4bc489264db
Hugh Bellamy [Tue, 22 Aug 2017 05:53:32 +0000 (07:53 +0200)]
Add DesignerOptionService tests (dotnet/corefx#23013)
* Add DesignerOptionService tests
* Use assert extensions
* Fix typo
Commit migrated from https://github.com/dotnet/corefx/commit/
5d357030caf3c81489245df82b226e0294239d8d
Koundinya Veluri [Tue, 22 Aug 2017 03:49:36 +0000 (20:49 -0700)]
Tests for fix to AssemblyName(string) version parsing (dotnet/corefx#23243)
* Tests for fix to AssemblyName(string) version parsing
Depends on https://github.com/dotnet/coreclr/pull/13373
Part of fix for https://github.com/dotnet/corefx/issues/22663
* Address feedback, don't allow missing component, add assembly load tests with different versions
* Add static references to test assemblies, change Skip to ActiveIssue for UapAot for one test
Commit migrated from https://github.com/dotnet/corefx/commit/
d69db9e2a82b60db9f3f093ac72384d6f234eb9d
Stephen Toub [Tue, 22 Aug 2017 03:40:43 +0000 (23:40 -0400)]
Expose/test Encoder/Decoder span-based APIs (dotnet/corefx#23361)
* Expose/test Encoder/Decoder span-based APIs
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
5ccd70817fbd5a411a5ee05da3d6dcc7d561199c
dotnet-maestro-bot [Tue, 22 Aug 2017 02:36:41 +0000 (19:36 -0700)]
Update CoreClr to preview2-25622-01 (dotnet/corefx#23457)
Commit migrated from https://github.com/dotnet/corefx/commit/
65b2e20741fd1a9a3ad186678a6c48a10055e418
Jeremy Kuhne [Tue, 22 Aug 2017 01:34:32 +0000 (18:34 -0700)]
Use FromApp APIs to allow brokered file access (dotnet/corefx#23316)
* Use FromApp APIs to allow brokered file access
This changes our P/Invokes to use the FromApp variants, which
allow for brokered file access on UAP. These are only included
in the UAP build.
Adds tests for the brokered IO WinRT functions and removes a
dead option from movefile. This option was removed in Windows 8
and did not work correctly in prior OSes. (This was needed
for this change.)
This change depends on the referenced dll being packaged and
added to our dependencies. There is a related change for CoreCLR
that supports FileStream.
* Address feedback.
* Remove unused define.
* Test tweaks
* Add ActiveIssue to known test failure
Unsetting attribute after setting isn't working (only in brokered
locations). A fix to FileApiInterop.dll is in the works.
* Disable other attributes test.
Commit migrated from https://github.com/dotnet/corefx/commit/
5e16d10c41536446f7be2299c61cdc85992966c0
Stephen Toub [Tue, 22 Aug 2017 00:45:05 +0000 (20:45 -0400)]
Expose and test primitive span-based {Try}Parse methods (dotnet/corefx#23277)
Commit migrated from https://github.com/dotnet/corefx/commit/
e08ef3a7b851c4dcecf620e74ef567f087573bb4
Stephen Toub [Mon, 21 Aug 2017 23:51:06 +0000 (19:51 -0400)]
Merge pull request dotnet/corefx#23224 from Paxxi/ipaddress_span
Add IPAddress Span-based APIs
Commit migrated from https://github.com/dotnet/corefx/commit/
1fc5e1e02804665a5b9755b665122e9811276702
Jose Perez Rodriguez [Mon, 21 Aug 2017 23:44:09 +0000 (16:44 -0700)]
Add FileApiInterop.dll to uap corefx private package (dotnet/corefx#23454)
* Add FileApiInterop.dll to uap corefx private package
* Fix allConfigurations build
Commit migrated from https://github.com/dotnet/corefx/commit/
8769745f6bd85d9ca7d8f5c7270cbe457dd25c79
Tarek Mahmoud Sayed [Mon, 21 Aug 2017 22:45:26 +0000 (15:45 -0700)]
Fix Globalization Tests on High Sierra (dotnet/corefx#23451)
Commit migrated from https://github.com/dotnet/corefx/commit/
f7492d0990f1534d037510e1c9db82a1d388dbfa
Shin Mao [Mon, 21 Aug 2017 20:10:08 +0000 (13:10 -0700)]
Disabled Sgen Tests. (dotnet/corefx#23446)
Commit migrated from https://github.com/dotnet/corefx/commit/
075853493df2dd30cdbf15834739e6e1d0ecf4fe
dotnet-maestro-bot [Mon, 21 Aug 2017 19:29:40 +0000 (12:29 -0700)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25621-02, preview2-25621-02, beta-25621-00, beta-25621-00, preview1-25621-01, respectively (dotnet/corefx#23414)
Commit migrated from https://github.com/dotnet/corefx/commit/
8c9f003877272079b50ba50a450ee8ee00c95368
Justin Van Patten [Mon, 21 Aug 2017 19:07:06 +0000 (12:07 -0700)]
Avoid unnecessary intermediate Version allocation (dotnet/corefx#23424)
* FrameworkName: Avoid unnecessary Version allocation
`Version..ctor(string)` is implemented by calling `Version.Parse`, which
allocates an intermediate `Version` instance. Avoid the unnecessary
intermediate allocation by using `Version.Parse` directly.
* XslCompiledTransform: Avoid unnecessary Version allocation
`Version..ctor(string)` is implemented by calling `Version.Parse`, which
allocates an intermediate `Version` instance. Avoid the unnecessary
intermediate allocation by using `Version.Parse` directly. Also, some
minor cleanup while making changes here.
Commit migrated from https://github.com/dotnet/corefx/commit/
48903a35b3dba9b3f316b55ec115f578ab0a9391
Stephen Toub [Mon, 21 Aug 2017 15:53:11 +0000 (11:53 -0400)]
Mitigate regressions in IPAddress
Commit migrated from https://github.com/dotnet/corefx/commit/
a13c1ddd4945aaee96d1ab16e7218472572afa8f
Per Bjorklund [Sat, 12 Aug 2017 17:44:24 +0000 (19:44 +0200)]
Implement Span overloads for IPAddress class
See issue dotnet/corefx#22607
This adds
public IPAddress(ReadOnlySpan<byte> address)
public IPAddress(ReadOnlySpan<byte> address, long scopeid)
public bool TryWriteBytes(Span<byte> destination, out int bytesWritten)
public static IPAddress Parse(ReadOnlySpan<char> ipSpan)
public static bool TryParse(ReadOnlySpan<char> ipSpan, out IPAddress address)
public static bool TryFormat(Span<char> destination, out int bytesWritten)
Commit migrated from https://github.com/dotnet/corefx/commit/
0029b322154053a76b085ccb6f3f820a5c9a263f
smile21prc [Mon, 21 Aug 2017 15:39:14 +0000 (08:39 -0700)]
Enable rhel6 in both official builds and CI of corefx master (dotnet/corefx#23088)
* Enable RedHat 6 in master, changes in pipeline.json
Enable RedHat 6 in master, changes in pipeline.json
* Enable RHEL6 in corefx CI
Enable RHEL6 in corefx CI
* Pass OS name to scripts
* Use OSName to get docker name
* Try fixing the error of "Unknown OS name"
Try fixing the error of "Unknown OS name"
* Change reporting OS of RHEL6 to "RedHat6"
Change reporting OS of RHEL6 to "RedHat6"
* Update dockertag of Centos6, and add logic to detect rhel6
Update dockertag of Centos6, and add logic to detect rhel6
* Port changes from Release/2.0.0 to fix RHEL 6 official builds
Port changes from Release/2.0.0 to fix RHEL 6 official builds
* Revert CI changes per Wes's review comment as they are not needed for now
Revert CI changes per Wes's review comment as they are not needed for
now
Commit migrated from https://github.com/dotnet/corefx/commit/
3490f49e52e0a2fde89c17162602955a928ddca3
Aditya Mandaleeka [Sat, 19 Aug 2017 01:26:09 +0000 (18:26 -0700)]
Merge pull request dotnet/corefx#23403 from adityamandaleeka/fix_hang_in_concurrentQueue_uapaot
Fix a uapaot hang in a ConcurrentQueue test
Commit migrated from https://github.com/dotnet/corefx/commit/
7a673547563dc92f1f4cad802d7b57483cdf7500
Nina Chikanov [Sat, 19 Aug 2017 01:21:38 +0000 (18:21 -0700)]
Force System.Data.DataSetExtension tests to build in chk (dotnet/corefx#23408)
Commit migrated from https://github.com/dotnet/corefx/commit/
6e536f37914f4067904562c39db6dda69c93ac53
Huangli Wu [Sat, 19 Aug 2017 00:32:08 +0000 (17:32 -0700)]
Fix the sgen issue when use NaN as the default value. (dotnet/corefx#23366)
* Fix the codegen issue when use NaN as the default value. Move the NaN test from runtimeonly to XmlTest so it will be included in Sgen test run.
* Add brackets.
Commit migrated from https://github.com/dotnet/corefx/commit/
e60c0219511656c6834f96ea41a5f48bbe6815f5
Wes Haggard [Sat, 19 Aug 2017 00:26:17 +0000 (17:26 -0700)]
Merge pull request dotnet/corefx#23337 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25618-04, preview2-25618-02, beta-25618-00, beta-25618-00, preview1-25618-01, respectively (master)
Commit migrated from https://github.com/dotnet/corefx/commit/
1874920e32f457a33391762119fff30e290ab0a4
Huangli Wu [Fri, 18 Aug 2017 23:45:01 +0000 (16:45 -0700)]
Workaround sgen automation errors. (dotnet/corefx#23400)
* Workaround sgen automation errors.
* Use typeof(XmlSerializerTests)
Commit migrated from https://github.com/dotnet/corefx/commit/
433b94a050806d9eb9389a0e428306f706ffdada
Nina Chikanov [Fri, 18 Aug 2017 23:37:11 +0000 (16:37 -0700)]
Fix Test: System.Data.Tests.SqlTypes.SqlStringTest/SqlDateTimeToSqlString (dotnet/corefx#23392)
Commit migrated from https://github.com/dotnet/corefx/commit/
82ba3c4a2059ecc53707acc116466dbf1ea5b4a3
Karel Zikmund [Fri, 18 Aug 2017 23:15:59 +0000 (16:15 -0700)]
Update Windows build dependencies
* Delete obsolete "Visual Studio Command Prompt" - command prompt will automatically detect it
Commit migrated from https://github.com/dotnet/corefx/commit/
a09106fb5ac521ccf08744e850fdabd504ce8bc5
Justin Van Patten [Fri, 18 Aug 2017 22:45:16 +0000 (15:45 -0700)]
Avoid unnecessary char[] allocation in GetComputerName (dotnet/corefx#23384)
* Avoid char[] allocation in GetComputerName
Avoid the `char[]` allocation in the `GetComputerName` Win32 interop
code by using `stackalloc`, which is used to implement
`Environment.MachineName` on Windows.
While we're at it, the size of the buffer can be reduced. The current
length is 256, but this is only for historical reasons when the buffer
needed to be large enough to support Unix host names when it'd be
calling a PAL implementation in CoreCLR on Unix. We're no longer calling
a PAL implementation, so we can reduce the size of the buffer to what's
required for this function. According to the MSDN documentation for
`GetComputerName`, "the buffer size should be large enough to contain
MAX_COMPUTERNAME_LENGTH + 1 characters."
Also, update `GetComputerName` to return null on error, so the calling
code in `Environment.Windows.cs` will throw `InvalidOperationException()`
as documented.
* Address PR feedback
* Checked cast
Commit migrated from https://github.com/dotnet/corefx/commit/
a83ee864b050657769f0f046d6694b6368c22ad1
Viktor Hofer [Fri, 18 Aug 2017 22:44:15 +0000 (00:44 +0200)]
Setting culture to Invariant to avoid not installed user language on test machines (dotnet/corefx#23391)
Commit migrated from https://github.com/dotnet/corefx/commit/
c61981dc5b87ac3f389a4c63ed97dae9dde37c77
Nina Chikanov [Fri, 18 Aug 2017 22:40:13 +0000 (15:40 -0700)]
Improve UnloadingAndProcessExitTests.netcoreapp.cs to help narrow down repro for recurring bug (dotnet/corefx#23397)
* Improve test to help narrow down repro
* Tag with ActiveIssue
Commit migrated from https://github.com/dotnet/corefx/commit/
d0d507db673c0422e984a8bc4d90dba3673cbfd4
Aditya Mandaleeka [Fri, 18 Aug 2017 00:45:30 +0000 (17:45 -0700)]
Fix a uapaot hang in a ConcurrentQueue test.
Commit migrated from https://github.com/dotnet/corefx/commit/
6fcb0042699e840e3d41fcb8b2a9e6ae75089a54
danmosemsft [Fri, 18 Aug 2017 17:41:36 +0000 (10:41 -0700)]
Fix build break
Commit migrated from https://github.com/dotnet/corefx/commit/
456bc80b0b29421829f41d970f6cfc556b6b8535
Tomas Weinfurt [Fri, 18 Aug 2017 17:37:57 +0000 (10:37 -0700)]
Add notes for Ubuntu 17.04
Commit migrated from https://github.com/dotnet/corefx/commit/
6d438c2d010b9dfb2f2e8941123edc7a57df6c7f
Egor Bogatov [Fri, 18 Aug 2017 16:53:49 +0000 (19:53 +0300)]
Implement QuoteIdentifier and UnquoteIdentifier in OdbcCommandBuilder (dotnet/corefx#22499)
Implement QuoteIdentifier and UnquoteIdentifier in OdbcCommandBuilder
Commit migrated from https://github.com/dotnet/corefx/commit/
ed3609d3e00d139171a28cbbd92bceb990866ed6
dotnet-maestro-bot [Fri, 18 Aug 2017 13:33:09 +0000 (06:33 -0700)]
Update CoreClr, CoreFx, ProjectNTfs, ProjectNTfsTestILC, Standard to preview2-25618-04, preview2-25618-02, beta-25618-00, beta-25618-00, preview1-25618-01, respectively
Commit migrated from https://github.com/dotnet/corefx/commit/
cd117388176102f637796853ad3fb045de864616
Stephen Toub [Fri, 18 Aug 2017 13:06:05 +0000 (09:06 -0400)]
Override Read/Write(span) on System.Net.Http streams (dotnet/corefx#23345)
Commit migrated from https://github.com/dotnet/corefx/commit/
c351ba1f094871e4ae97f23f20f26648662cc4e6
Nina Chikanov [Fri, 18 Aug 2017 00:46:53 +0000 (17:46 -0700)]
Expose and Add Tests for BitConverter APIs in Corefx (dotnet/corefx#23164)
Commit migrated from https://github.com/dotnet/corefx/commit/
4a120148edaeb0e96aafbf15bd844b8022f63ad1
Jon Hanna [Thu, 17 Aug 2017 22:40:39 +0000 (23:40 +0100)]
WarningsAsErrors and DisabledWarnings are not boolean. (dotnet/corefx#23335)
Remove WarningsAsErrors and set DisabledWarnings to 219 as that warning
is given in several places.
Fixes dotnet/corefx#23334
Commit migrated from https://github.com/dotnet/corefx/commit/
77b23b4caeabcc349b440212bb752bcc53c0fda2
Tomas Weinfurt [Thu, 17 Aug 2017 22:38:07 +0000 (15:38 -0700)]
add option to specify clang and few minor improvements for Linux (dotnet/corefx#23302)
* add option to specify clang and few minor improvements
* roll-back $* $@ change. that should be separate PR
Commit migrated from https://github.com/dotnet/corefx/commit/
39b450561071309276b7cef7a4ecb45407423ec0
Aditya Mandaleeka [Thu, 17 Aug 2017 21:15:43 +0000 (14:15 -0700)]
Delete bad test from AsyncValueTaskMethodBuilderTests. (dotnet/corefx#23356)
Commit migrated from https://github.com/dotnet/corefx/commit/
41fd569ab880073a0140c8aee232ee118250a450
Egor Bogatov [Thu, 17 Aug 2017 19:52:07 +0000 (22:52 +0300)]
[System.Data] move AppDomain.Unload to a separate "partial" file (SqlDependencyUtils) (dotnet/corefx#23350)
Commit migrated from https://github.com/dotnet/corefx/commit/
27d024cc4e25bc6d88a1c23ac9146ea1c5acedcb
Justin Van Patten [Thu, 17 Aug 2017 19:49:18 +0000 (12:49 -0700)]
Update Area owners in the Issue Guide (dotnet/corefx#23349)
Commit migrated from https://github.com/dotnet/corefx/commit/
2e34bf0ea9f24817921a44875b2946cff3929674
Maira Wenzel [Thu, 17 Aug 2017 19:43:12 +0000 (12:43 -0700)]
Some style fixes (dotnet/corefx#21837)
Commit migrated from https://github.com/dotnet/corefx/commit/
b3ea783d580a9fcd2e05990e5756f2fda94dcf18
Paulo Janotti [Thu, 17 Aug 2017 17:32:49 +0000 (10:32 -0700)]
Capture PR feedback issues from UWP6.0 port. (dotnet/corefx#23342)
* Capture PR feedback issues from UWP6.0 port.
* PR feedback: link and typo
Commit migrated from https://github.com/dotnet/corefx/commit/
a51a205a631ff113f05df1d08e92f3ab70fda43d
Viktor Hofer [Thu, 17 Aug 2017 16:41:33 +0000 (18:41 +0200)]
Set fixed culture for CookieContainer blob sanity check (dotnet/corefx#23285)
* Set fixed culture for CookieContainer blob sanity check
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
04c1a2ce4e9eb46f229038961e99702336780b06
Justin Van Patten [Thu, 17 Aug 2017 16:40:45 +0000 (09:40 -0700)]
Use Encoding.Preamble in StreamReader/Writer (dotnet/corefx#23321)
Commit migrated from https://github.com/dotnet/corefx/commit/
e0c1f209895962575c0e77290aeafe80e8f47b52
DonaldHarris [Thu, 17 Aug 2017 16:34:52 +0000 (09:34 -0700)]
Fix missing ISerializable interface on some types in System.Drawing (dotnet/corefx#22982)
* Fix missing ISerializable interface on some types in System.Drawing. Fixes dotnet/corefx#22599.
* Fix PR comments
* Fix InvalidPrinterException constructor
* Update System.Drawing.Common refs and ApiCompat file
* Move InvalidPrinterException serialization code into common code compilation itemgroup instead of windows only
* Correctly throw PNSE in unsupported ctor and cleanup code
Commit migrated from https://github.com/dotnet/corefx/commit/
171820d3f2d62e420aa0fbbbbe4ad8e6b3d937c4
Justin Van Patten [Thu, 17 Aug 2017 16:29:25 +0000 (09:29 -0700)]
System.Private.Xml: Use Encoding.Preamble (dotnet/corefx#23323)
* System.Private.Xml: Use Encoding.Preamble
Use the new `Encoding.Preamble` property to avoid unnecessary `byte[]`
allocations for encodings that return cached instances from `Preamble`
(e.g. all of the built-in encodings that have preambles).
* Avoid TypeLoadException in async code
Factor out the "eat preamble" code into its own method (that can be
reused by both the sync and async code) to prevent the
`ReadOnlySpan<byte>` preamble from being captured in a field of the
async state machine. This avoids the System.TypeLoadException : A value
type containing a by-ref instance field, such as Span<T>, cannot be used
as the type for a class instance field.
Commit migrated from https://github.com/dotnet/corefx/commit/
6d7be63179868eac8d799c32846c3f724950abdd
Stephen Toub [Thu, 17 Aug 2017 15:14:11 +0000 (11:14 -0400)]
Disable hanging "stack guard" tests (dotnet/corefx#23339)
Commit migrated from https://github.com/dotnet/corefx/commit/
0547375d71a7b0ea8e81e7690e2e6b0ceb6c70e6
Justin Van Patten [Thu, 17 Aug 2017 14:19:05 +0000 (07:19 -0700)]
DataContractSerialization: Use Encoding.Preamble (dotnet/corefx#23324)
Use the new `Encoding.Preamble` property to avoid unnecessary `byte[]`
allocations for encodings that return cached instances from `Preamble`
(e.g. all of the built-in encodings that have preambles).
Commit migrated from https://github.com/dotnet/corefx/commit/
78bab3761914ec58ae793f4fb8a8940cba4d9188
Justin Van Patten [Thu, 17 Aug 2017 14:18:41 +0000 (07:18 -0700)]
HttpListener: Use Encoding.Preamble (dotnet/corefx#23325)
Use the new `Encoding.Preamble` property to avoid unnecessary `byte[]`
allocations for encodings that return cached instances from `Preamble`
(e.g. all of the built-in encodings that have preambles).
Commit migrated from https://github.com/dotnet/corefx/commit/
e873d95917a683cc681ab08c9311b2647a2e741c
dotnet-maestro-bot [Thu, 17 Aug 2017 11:10:13 +0000 (04:10 -0700)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-25617-00, beta-25617-00, respectively (dotnet/corefx#23326)
Commit migrated from https://github.com/dotnet/corefx/commit/
43f78840284de81bfd1b5fe4deceedf95c673cf8
dotnet-maestro-bot [Thu, 17 Aug 2017 02:28:10 +0000 (19:28 -0700)]
Update CoreFx, CoreSetup to preview2-25617-01, preview2-25616-02, respectively (dotnet/corefx#23318)
Commit migrated from https://github.com/dotnet/corefx/commit/
76d2ed0bb6d07b4e03cd01c6f1402328ed62f0e1