commit-queue@webkit.org [Fri, 18 May 2012 09:08:48 +0000 (09:08 +0000)]
Unreviewed, rolling out r117558.
http://trac.webkit.org/changeset/117558
https://bugs.webkit.org/show_bug.cgi?id=86827
Wrong rebaseline per rolling out 117556 (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18
* platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
* platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
* platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/mac-snowleopard/fast/forms/input-value-expected.png:
* platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
* platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
* platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
* svg/custom/svg-fonts-in-text-controls-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 May 2012 09:03:05 +0000 (09:03 +0000)]
Unreviewed, rolling out r117557.
http://trac.webkit.org/changeset/117557
https://bugs.webkit.org/show_bug.cgi?id=86826
Wrong rebaseline per rolling out 117556 (Requested by rniwa on
#webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18
* platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
* platform/mac/editing/inserting/before-after-input-element-expected.txt:
* platform/mac/editing/pasteboard/4806874-expected.txt:
* platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/mac/editing/pasteboard/input-field-1-expected.txt:
* platform/mac/editing/selection/3690703-2-expected.png:
* platform/mac/editing/selection/3690703-2-expected.txt:
* platform/mac/editing/selection/3690703-expected.txt:
* platform/mac/editing/selection/3690719-expected.txt:
* platform/mac/editing/selection/4895428-3-expected.txt:
* platform/mac/editing/selection/4975120-expected.txt:
* platform/mac/editing/selection/drag-select-1-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
* platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/mac/fast/css/input-search-padding-expected.txt:
* platform/mac/fast/css/line-height-expected.txt:
* platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/dom/isindex-001-expected.txt:
* platform/mac/fast/dom/isindex-002-expected.txt:
* platform/mac/fast/events/autoscroll-expected.png:
* platform/mac/fast/events/autoscroll-expected.txt:
* platform/mac/fast/events/context-no-deselect-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/encoding-test-expected.txt:
* platform/mac/fast/forms/fieldset-align-expected.txt:
* platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/input-align-expected.png:
* platform/mac/fast/forms/input-align-expected.txt:
* platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/mac/fast/forms/input-appearance-disabled-expected.png:
* platform/mac/fast/forms/input-appearance-disabled-expected.txt:
* platform/mac/fast/forms/input-appearance-focus-expected.png:
* platform/mac/fast/forms/input-appearance-focus-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/forms/input-appearance-readonly-expected.txt:
* platform/mac/fast/forms/input-appearance-selection-expected.txt:
* platform/mac/fast/forms/input-appearance-visibility-expected.txt:
* platform/mac/fast/forms/input-appearance-width-expected.png:
* platform/mac/fast/forms/input-appearance-width-expected.txt:
* platform/mac/fast/forms/input-baseline-expected.png:
* platform/mac/fast/forms/input-baseline-expected.txt:
* platform/mac/fast/forms/input-disabled-color-expected.png:
* platform/mac/fast/forms/input-disabled-color-expected.txt:
* platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/mac/fast/forms/input-field-text-truncated-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
* platform/mac/fast/forms/input-readonly-empty-expected.txt:
* platform/mac/fast/forms/input-spaces-expected.txt:
* platform/mac/fast/forms/input-table-expected.txt:
* platform/mac/fast/forms/input-text-click-inside-expected.txt:
* platform/mac/fast/forms/input-text-click-outside-expected.txt:
* platform/mac/fast/forms/input-text-double-click-expected.txt:
* platform/mac/fast/forms/input-text-drag-down-expected.txt:
* platform/mac/fast/forms/input-text-option-delete-expected.txt:
* platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/mac/fast/forms/input-text-word-wrap-expected.txt:
* platform/mac/fast/forms/input-type-text-min-width-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/forms/input-width-expected.txt:
* platform/mac/fast/forms/minWidthPercent-expected.txt:
* platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/plaintext-mode-2-expected.txt:
* platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/mac/fast/forms/search-rtl-expected.png:
* platform/mac/fast/forms/search-rtl-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/forms/select-empty-option-height-expected.txt:
* platform/mac/fast/forms/tabbing-input-iframe-expected.png:
* platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
* platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
* platform/mac/fast/forms/text-style-color-expected.png:
* platform/mac/fast/forms/text-style-color-expected.txt:
* platform/mac/fast/forms/textfield-focus-ring-expected.txt:
* platform/mac/fast/forms/textfield-outline-expected.txt:
* platform/mac/fast/forms/textfield-overflow-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.png:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-javascript-expected.txt:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/mac/fast/replaced/width100percent-textfield-expected.txt:
* platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
* platform/mac/fast/table/003-expected.txt:
* platform/mac/fast/table/colspanMinWidth-expected.txt:
* platform/mac/fast/table/spanOverlapRepaint-expected.txt:
* platform/mac/fast/table/text-field-baseline-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/hixie/mixed/003-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
* platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
* platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
* platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
* platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
* platform/mac/tables/mozilla/dom/tableDom-expected.txt:
* platform/mac/tables/mozilla/other/move_row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 09:00:28 +0000 (09:00 +0000)]
Unreviewed, rolling out r117556.
http://trac.webkit.org/changeset/117556
https://bugs.webkit.org/show_bug.cgi?id=86825
Wrong fix. IE still adds 1px padding. We're missing that in
textarea (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-18
Source/WebCore:
* css/html.css:
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
LayoutTests:
* fast/forms/input-textarea-padding-match-expected.html: Removed.
* fast/forms/input-textarea-padding-match.html: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 18 May 2012 08:53:05 +0000 (08:53 +0000)]
Web Inspector: remove File abstraction from the AdvancedSearchController, migrate it to UISourceCode.
https://bugs.webkit.org/show_bug.cgi?id=86809
Reviewed by Yury Semikhatsky.
This change migrates AdvancedSearchController from "Object" to "UISourceCode".
I don't see why we need this abstraction and as a side effect, it makes search
across scripts work for styles.
* English.lproj/localizedStrings.js:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
(WebInspector.FileBasedSearchResultsPane.SearchResult):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype.createSearchResultsPane):
* inspector/front-end/inspector.js:
(WebInspector._registerShortcuts):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 08:40:55 +0000 (08:40 +0000)]
[perf-test] Add 7 micro benchmarks for DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=86816
Reviewed by Ryosuke Niwa.
We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds seven micro benchmarks for DOM bindings.
id-getter.html covers 'element.property' in Dromaeo/dom-attr.html,
'innerHTML' in Dromaeo/dom-modify.html, and other DOM attributes that
return a String.
id-setter.html covers 'element.property = value' in Dromaeo/dom-attr.html,
and other DOM attributes that sets a String.
undefined-id-getter.html covers undefined DOM attributes that return an empty String.
append-child.html covers 'appendChild' and 'removeChild' in Dromaeo/dom-modify.html.
insert-before.html covers 'insertBefore' in Dromaeo/dom-modify.html and replaceChild().
create-element.html covers 'createElement', 'createTextNode' and 'cloneNode'
in Dromaeo/dom-modify.html, and other DOM methods that return a new Node object.
node-list-access.html covers 'childNodes' in Dromaeo/dom-traverse.html,
and other DOM attributes that access NodeList.
Test results in my Linux desktop:
[id-getter]
RESULT Bindings: id-getter= 550.
517821097 runs/s
median= 550.
688360451 runs/s, stdev= 0.
970723739106 runs/s, min= 548.
628428928 runs/s, max= 552.
070263488 runs/s
RESULT Bindings: id-getter= 550.
655839847 runs/s
median= 550.
688360451 runs/s, stdev= 1.
03312821884 runs/s, min= 549.
313358302 runs/s, max= 552.
070263488 runs/s
RESULT Bindings: id-getter= 550.
277753355 runs/s
median= 550.
344180225 runs/s, stdev= 1.
19960683464 runs/s, min= 547.
945205479 runs/s, max= 552.
070263488 runs/s
RESULT Bindings: id-getter= 550.
072271009 runs/s
median= 550.
344180225 runs/s, stdev= 1.
38925152131 runs/s, min= 547.
263681592 runs/s, max= 552.
070263488 runs/s
RESULT Bindings: id-getter= 548.
802050235 runs/s
median= 548.
628428928 runs/s, stdev= 1.
18244513683 runs/s, min= 545.
905707196 runs/s, max= 550.
688360451 runs/s
[id-setter]
RESULT Bindings: id-setter= 211.
370591663 runs/s
median= 210.
803689065 runs/s, stdev= 1.
4555795889 runs/s, min= 209.
973753281 runs/s, max= 214.
285714286 runs/s
RESULT Bindings: id-setter= 215.
439081352 runs/s
median= 214.
797136038 runs/s, stdev= 1.
50920388121 runs/s, min= 213.
049267643 runs/s, max= 218.
446601942 runs/s
RESULT Bindings: id-setter= 216.
721698466 runs/s
median= 215.
956886352 runs/s, stdev= 1.
54090749644 runs/s, min= 214.
285714286 runs/s, max= 219.
78021978 runs/s
RESULT Bindings: id-setter= 216.
343019087 runs/s
median= 215.
827338129 runs/s, stdev= 1.
46619894553 runs/s, min= 215.
053763441 runs/s, max= 218.
97810219 runs/s
RESULT Bindings: id-setter= 216.
799288017 runs/s
median= 215.
956886352 runs/s, stdev= 1.
49100776978 runs/s, min= 215.
311004785 runs/s, max= 219.
78021978 runs/s
[undefined-id-getter]
RESULT Bindings: undefined-id-getter= 494.
104255241 runs/s
median= 494.
132368875 runs/s, stdev= 1.
13092821109 runs/s, min= 490.
797546012 runs/s, max= 495.
662949195 runs/s
RESULT Bindings: undefined-id-getter= 493.
921802916 runs/s
median= 493.
827160494 runs/s, stdev= 1.
25097443119 runs/s, min= 490.
196078431 runs/s, max= 495.
662949195 runs/s
RESULT Bindings: undefined-id-getter= 491.
976485667 runs/s
median= 492.
004920049 runs/s, stdev= 0.
947090576896 runs/s, min= 490.
196078431 runs/s, max= 493.
827160494 runs/s
RESULT Bindings: undefined-id-getter= 491.
987710185 runs/s
median= 494.
132368875 runs/s, stdev= 8.
66602543327 runs/s, min= 454.
545454545 runs/s, max= 495.
662949195 runs/s
RESULT Bindings: undefined-id-getter= 494.
195515847 runs/s
median= 494.
437577256 runs/s, stdev= 1.
06135681702 runs/s, min= 490.
797546012 runs/s, max= 495.
662949195 runs/s
[append-child]
RESULT Bindings: append-child= 260.
628237026 runs/s
median= 260.
926399352 runs/s, stdev= 2.
55231060598 runs/s, min= 256.
739409499 runs/s, max= 265.
604249668 runs/s
RESULT Bindings: append-child= 280.
796193436 runs/s
median= 280.
791435348 runs/s, stdev= 2.
53961321867 runs/s, min= 277.
427490542 runs/s, max= 286.
085825748 runs/s
RESULT Bindings: append-child= 279.
856209714 runs/s
median= 280.
25477707 runs/s, stdev= 2.
85447647301 runs/s, min= 275.
344180225 runs/s, max= 284.
237726098 runs/s
RESULT Bindings: append-child= 280.
834502714 runs/s
median= 280.
25477707 runs/s, stdev= 2.
67738046429 runs/s, min= 277.
427490542 runs/s, max= 287.
206266319 runs/s
RESULT Bindings: append-child= 274.
723872106 runs/s
median= 273.
291925466 runs/s, stdev= 3.
03671746706 runs/s, min= 272.
614622057 runs/s, max= 282.
413350449 runs/s
[insert-before]
RESULT Bindings: insert-before= 180.
986913006 runs/s
median= 180.
878552972 runs/s, stdev= 0.
758038687299 runs/s, min= 180.
18018018 runs/s, max= 183.
968462549 runs/s
RESULT Bindings: insert-before= 186.
339916144 runs/s
median= 186.
170212766 runs/s, stdev= 0.
869022097127 runs/s, min= 185.
676392573 runs/s, max= 189.
798339265 runs/s
RESULT Bindings: insert-before= 189.
45344838 runs/s
median= 189.
349112426 runs/s, stdev= 0.
811854866567 runs/s, min= 187.
79342723 runs/s, max= 192.
539109507 runs/s
RESULT Bindings: insert-before= 189.
363295991 runs/s
median= 189.
349112426 runs/s, stdev= 0.
75387713097 runs/s, min= 188.
014101058 runs/s, max= 192.
076830732 runs/s
RESULT Bindings: insert-before= 189.
252041642 runs/s
median= 189.
349112426 runs/s, stdev= 0.
840447225363 runs/s, min= 187.
573270809 runs/s, max= 192.
076830732 runs/s
[create-element]
RESULT Bindings: create-element= 280.
675830077 runs/s
median= 280.
701824914 runs/s, stdev= 0.
788606343054 runs/s, min= 279.
441117764 runs/s, max= 282.
542885974 runs/s
RESULT Bindings: create-element= 276.
427631436 runs/s
median= 277.
227722772 runs/s, stdev= 3.
39874667549 runs/s, min= 262.
417994377 runs/s, max= 279.
162512463 runs/s
RESULT Bindings: create-element= 277.
156894411 runs/s
median= 277.
227722772 runs/s, stdev= 1.
13255119226 runs/s, min= 274.
914089347 runs/s, max= 278.
884462151 runs/s
RESULT Bindings: create-element= 278.
066825356 runs/s
median= 278.
191822254 runs/s, stdev= 0.
686497782792 runs/s, min= 276.
953511375 runs/s, max= 279.
162512463 runs/s
RESULT Bindings: create-element= 276.
431538109 runs/s
median= 276.
406712734 runs/s, stdev= 0.
759593662298 runs/s, min= 275.
229357798 runs/s, max= 278.
053624628 runs/s
[node-list-access]
RESULT Bindings: node-list-access= 222.
747504073 runs/s
median= 222.
772277228 runs/s, stdev= 0.
789027527555 runs/s, min= 221.
674876847 runs/s, max= 224.
159402242 runs/s
RESULT Bindings: node-list-access= 220.
722448287 runs/s
median= 221.
266217576 runs/s, stdev= 1.
65463497875 runs/s, min= 217.
391304348 runs/s, max= 222.
222222222 runs/s
RESULT Bindings: node-list-access= 222.
195870443 runs/s
median= 222.
222222222 runs/s, stdev= 0.
489709262091 runs/s, min= 221.
13022113 runs/s, max= 223.
048327138 runs/s
RESULT Bindings: node-list-access= 221.
431121677 runs/s
median= 221.
538545435 runs/s, stdev= 0.
608292116087 runs/s, min= 220.
048899756 runs/s, max= 222.
772277228 runs/s
RESULT Bindings: node-list-access= 219.
001367135 runs/s
median= 221.
538545435 runs/s, stdev= 4.
65773933007 runs/s, min= 209.
973753281 runs/s, max= 222.
496909765 runs/s
* Bindings/append-child.html: Added.
* Bindings/create-element.html: Added.
* Bindings/id-getter.html: Added.
* Bindings/id-setter.html: Added.
* Bindings/insert-before.html: Added.
* Bindings/node-list-access.html: Added.
* Bindings/undefined-id-getter.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 18 May 2012 08:25:07 +0000 (08:25 +0000)]
Web Inspector: add an option to show last N hidden children of node in heap profiler
https://bugs.webkit.org/show_bug.cgi?id=86757
Reviewed by Pavel Feldman.
Renamed "Show next N" to "Show N before" and added "Show N after" button. Also
when all 3 buttons would have equal effect there is now only "Show all N" button.
* English.lproj/localizedStrings.js:
* inspector/front-end/ShowMoreDataGridNode.js:
(WebInspector.ShowMoreDataGridNode):
(WebInspector.ShowMoreDataGridNode.prototype._showLastChunk):
(WebInspector.ShowMoreDataGridNode.prototype._updateLabels):
(WebInspector.ShowMoreDataGridNode.prototype.createCells):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 08:15:58 +0000 (08:15 +0000)]
[EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
https://bugs.webkit.org/show_bug.cgi?id=86101
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-18
Reviewed by Ryosuke Niwa.
Source/WebKit/efl:
Add missing implementation setSerializeHTTPLoads to EFL's
DumpRenderTreeSupport to allow testing resource load order.
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setSerializeHTTPLoads):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
Add missing implementation setSerializeHTTPLoads to allow
testing resource load order.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setSerializeHTTPLoads):
LayoutTests:
Unskip test cases which rely on LayoutTestController's setSerializeHTTPLoads
implementation and add EFL expectations for tests same as in mac port (MIME
type is "application/javascript" instead of "application/x-javascript").
* platform/efl/Skipped:
* platform/efl/fast/loader/file-protocol-fragment-expected.txt: Removed. The current
result matches the base expectation, so removed the platform-specific results.
* platform/efl/fast/preloader/document-write-2-expected.txt: Added.
* platform/efl/fast/preloader/document-write-expected.txt: Added.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Fri, 18 May 2012 08:12:03 +0000 (08:12 +0000)]
Source/WebKit/chromium: [chromium] plumb the frame for which a drag was initiated to the WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=86670
Reviewed by Kent Tamura.
* public/WebViewClient.h:
(WebKit::WebViewClient::startDragging):
(WebViewClient):
* src/DragClientImpl.cpp:
(WebKit::DragClientImpl::startDrag):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::startDragging):
* src/WebViewImpl.h:
(WebViewImpl):
Tools: [chromium] plumb the frame for which a drag was initiated to the WebViewClient
https://bugs.webkit.org/show_bug.cgi?id=86670
Reviewed by Kent Tamura.
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::startDragging):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 May 2012 07:48:05 +0000 (07:48 +0000)]
Chromium Mac rebaseline after r117556.
* platform/chromium-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690703-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/3690719-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4895428-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/4975120-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
* platform/chromium-mac-snowleopard/fast/css/input-search-padding-expected.png:
* platform/chromium-mac-snowleopard/fast/css/line-height-expected.png:
* platform/chromium-mac-snowleopard/fast/css/text-input-with-webkit-border-radius-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/fast/css/text-overflow-input-expected.png: Modified property svn:mime-type.
* platform/chromium-mac-snowleopard/fast/dom/isindex-001-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/isindex-002-expected.png:
* platform/chromium-mac-snowleopard/fast/events/autoscroll-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/basic-inputs-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/box-shadow-override-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/button-submit-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/encoding-test-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/fieldset-align-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/form-element-geometry-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/form-in-malformed-markup-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-appearance-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-spaces-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-table-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-double-click-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-drag-down-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-value-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-width-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/minWidthPercent-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-position-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/range/input-appearance-range-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/range/range-thumb-height-percentage-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/search-display-none-cancel-button-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/search-rtl-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/search-styled-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/text-style-color-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/textfield-outline-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-no-summary4-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open-javascript-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open2-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-open4-expected.png:
* platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-searchandspeech-expected.txt:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-snowleopard/fast/table/003-expected.png:
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-expected.png:
* platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-snowleopard/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug99948-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/chromium-mac/css3/selectors3/html/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-69-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-23-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-69-expected.png:
* platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/chromium-mac/fast/events/context-no-deselect-expected.png:
* platform/chromium-mac/fast/forms/basic-inputs-expected.txt:
* platform/chromium-mac/fast/forms/box-shadow-override-expected.txt:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-mac/fast/forms/form-element-geometry-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-disabled-expected.txt:
* platform/chromium-mac/fast/forms/input-appearance-height-expected.txt:
* platform/chromium-mac/fast/forms/input-disabled-color-expected.txt:
* platform/chromium-mac/fast/forms/input-value-expected.txt:
* platform/chromium-mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/chromium-mac/fast/forms/textfield-overflow-expected.png:
* platform/chromium-mac/fast/forms/validation-message-appearance-expected.txt:
* platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Modified property svn:mime-type.
* platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
* platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 May 2012 07:46:19 +0000 (07:46 +0000)]
SnowLeopard and SVG rebaselines after r117556.
* platform/mac-snowleopard/fast/forms/basic-inputs-expected.png:
* platform/mac-snowleopard/fast/forms/form-element-geometry-expected.png:
* platform/mac-snowleopard/fast/forms/input-appearance-height-expected.png:
* platform/mac-snowleopard/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/mac-snowleopard/fast/forms/input-value-expected.png:
* platform/mac-snowleopard/fast/forms/placeholder-position-expected.png:
* platform/mac-snowleopard/fast/forms/plaintext-mode-2-expected.png:
* platform/mac-snowleopard/fast/forms/search-vertical-alignment-expected.png:
* svg/custom/svg-fonts-in-text-controls-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 May 2012 07:44:21 +0000 (07:44 +0000)]
Mac rebaseline after r117556.
* platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/mac/editing/input/caret-at-the-edge-of-input-expected.txt:
* platform/mac/editing/inserting/before-after-input-element-expected.txt:
* platform/mac/editing/pasteboard/4806874-expected.txt:
* platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/mac/editing/pasteboard/input-field-1-expected.txt:
* platform/mac/editing/selection/3690703-2-expected.png:
* platform/mac/editing/selection/3690703-2-expected.txt:
* platform/mac/editing/selection/3690703-expected.txt:
* platform/mac/editing/selection/3690719-expected.txt:
* platform/mac/editing/selection/4895428-3-expected.txt:
* platform/mac/editing/selection/4975120-expected.txt:
* platform/mac/editing/selection/drag-select-1-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
* platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
* platform/mac/fast/css/input-search-padding-expected.txt:
* platform/mac/fast/css/line-height-expected.txt:
* platform/mac/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/mac/fast/css/text-overflow-input-expected.txt:
* platform/mac/fast/dom/isindex-001-expected.txt:
* platform/mac/fast/dom/isindex-002-expected.txt:
* platform/mac/fast/events/autoscroll-expected.png:
* platform/mac/fast/events/autoscroll-expected.txt:
* platform/mac/fast/events/context-no-deselect-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/encoding-test-expected.txt:
* platform/mac/fast/forms/fieldset-align-expected.txt:
* platform/mac/fast/forms/floating-textfield-relayout-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/input-align-expected.png:
* platform/mac/fast/forms/input-align-expected.txt:
* platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/mac/fast/forms/input-appearance-disabled-expected.png:
* platform/mac/fast/forms/input-appearance-disabled-expected.txt:
* platform/mac/fast/forms/input-appearance-focus-expected.png:
* platform/mac/fast/forms/input-appearance-focus-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/mac/fast/forms/input-appearance-readonly-expected.txt:
* platform/mac/fast/forms/input-appearance-selection-expected.txt:
* platform/mac/fast/forms/input-appearance-visibility-expected.txt:
* platform/mac/fast/forms/input-appearance-width-expected.png:
* platform/mac/fast/forms/input-appearance-width-expected.txt:
* platform/mac/fast/forms/input-baseline-expected.png:
* platform/mac/fast/forms/input-baseline-expected.txt:
* platform/mac/fast/forms/input-disabled-color-expected.png:
* platform/mac/fast/forms/input-disabled-color-expected.txt:
* platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/mac/fast/forms/input-field-text-truncated-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
* platform/mac/fast/forms/input-readonly-empty-expected.txt:
* platform/mac/fast/forms/input-spaces-expected.txt:
* platform/mac/fast/forms/input-table-expected.txt:
* platform/mac/fast/forms/input-text-click-inside-expected.txt:
* platform/mac/fast/forms/input-text-click-outside-expected.txt:
* platform/mac/fast/forms/input-text-double-click-expected.txt:
* platform/mac/fast/forms/input-text-drag-down-expected.txt:
* platform/mac/fast/forms/input-text-option-delete-expected.txt:
* platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/mac/fast/forms/input-text-word-wrap-expected.txt:
* platform/mac/fast/forms/input-type-text-min-width-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/forms/input-width-expected.txt:
* platform/mac/fast/forms/minWidthPercent-expected.txt:
* platform/mac/fast/forms/number/input-appearance-number-rtl-expected.png:
* platform/mac/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/mac/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/mac/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/mac/fast/forms/placeholder-position-expected.txt:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
* platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/mac/fast/forms/plaintext-mode-2-expected.txt:
* platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/mac/fast/forms/search-rtl-expected.png:
* platform/mac/fast/forms/search-rtl-expected.txt:
* platform/mac/fast/forms/search-styled-expected.txt:
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/forms/select-empty-option-height-expected.txt:
* platform/mac/fast/forms/tabbing-input-iframe-expected.png:
* platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
* platform/mac/fast/forms/text-control-intrinsic-widths-expected.txt:
* platform/mac/fast/forms/text-style-color-expected.png:
* platform/mac/fast/forms/text-style-color-expected.txt:
* platform/mac/fast/forms/textfield-focus-ring-expected.txt:
* platform/mac/fast/forms/textfield-outline-expected.txt:
* platform/mac/fast/forms/textfield-overflow-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.png:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-javascript-expected.txt:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
* platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/mac/fast/replaced/width100percent-textfield-expected.txt:
* platform/mac/fast/speech/speech-bidi-rendering-expected.txt:
* platform/mac/fast/table/003-expected.txt:
* platform/mac/fast/table/colspanMinWidth-expected.txt:
* platform/mac/fast/table/spanOverlapRepaint-expected.txt:
* platform/mac/fast/table/text-field-baseline-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/hixie/mixed/003-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
* platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
* platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
* platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
* platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
* platform/mac/tables/mozilla/dom/tableDom-expected.txt:
* platform/mac/tables/mozilla/other/move_row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 May 2012 07:42:02 +0000 (07:42 +0000)]
WebKit erroneously add 1px padding in input elements
https://bugs.webkit.org/show_bug.cgi?id=86784
Reviewed by Kent Tamura.
Source/WebCore:
Fixed the bug by removing the code that added left and right paddings in input elements.
The code was added in r13567 to match a very old version of Internet Explorer but this quirk
does not seem to exists in IE9 (both in quirks and standard modes).
A lot of tests need to be rebaselined due to 1px difference inside input elements, and 2px
differences for the width of input elements. (In some extreme cases, line breaking changed
due to the width change).
Test: fast/forms/input-textarea-padding-match.html
* css/html.css:
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerTextStyle):
LayoutTests:
Add a regression.
Also rebaseline tests in separate commits per getting rid of extra 1px padding on left and right.
Input elements' widths got shrunk by 2px in most cases and the text moved 1px to the start
(left for LTR and right for RTL).
* fast/forms/input-textarea-padding-match-expected.html: Added.
* fast/forms/input-textarea-padding-match.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 07:37:01 +0000 (07:37 +0000)]
[Qt] Gesture tap highlighter needs to take overflow clip into account.
https://bugs.webkit.org/show_bug.cgi?id=84989
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-18
Reviewed by Kenneth Rohde Christiansen.
.:
* ManualTests/qt/tap-highlighting-overflow-hidden.html: Added.
Source/WebCore:
Apply overflow clip on the focus ring if needed.
Follow up patches are needed to address the following cases.
[Qt] Gesture tap highlighter should take parent iframe's transform into account.
https://bugs.webkit.org/show_bug.cgi?id=86645
[Qt] Gesture tap highlighter needs to take frame clipping into account.
https://bugs.webkit.org/show_bug.cgi?id=86646
[Qt] Gesture tap highlighter's overflow clip is not always correct when
nested enclosing containers have transforms.
https://bugs.webkit.org/show_bug.cgi?id=86641
Manual test: ManualTests/qt/tap-highlighting-overflow-hidden.html
* page/GestureTapHighlighter.cpp:
(WebCore::GestureTapHighlighter::pathForNodeHighlight):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 18 May 2012 07:29:42 +0000 (07:29 +0000)]
Chromium rebaselines.
* platform/chromium-mac-leopard/fast/lists/003-vertical-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Removed.
* platform/chromium-mac/fast/lists/003-vertical-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 07:20:36 +0000 (07:20 +0000)]
[perf-test] Add a binding benchmark for div.setAttribute()
https://bugs.webkit.org/show_bug.cgi?id=86815
Reviewed by Ryosuke Niwa.
We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds a benchmark for div.setAttribute(). This benchmark
covers 'setAttribute' in Dromaeo/dom-attr.html and other DOM methods
that return an undefined.
Test results in my Linux desktop:
RESULT Bindings: set-attribute= 793.
745073252 runs/s
median= 791.
589665765 runs/s, stdev= 6.
00467159709 runs/s, min= 785.
27607362 runs/s, max= 808.
080808081 runs/s
RESULT Bindings: set-attribute= 790.
858444164 runs/s
median= 787.
918921436 runs/s, stdev= 7.
86264953655 runs/s, min= 780.
234070221 runs/s, max= 806.
04534005 runs/s
RESULT Bindings: set-attribute= 787.
277571417 runs/s
median= 784.
31372549 runs/s, stdev= 7.
45363346657 runs/s, min= 778.
588807786 runs/s, max= 804.
020100503 runs/s
RESULT Bindings: set-attribute= 782.
401393791 runs/s
median= 779.
062978802 runs/s, stdev= 6.
48250081621 runs/s, min= 777.
642770352 runs/s, max= 796.
019900498 runs/s
RESULT Bindings: set-attribute= 791.
792516608 runs/s
median= 791.
556728232 runs/s, stdev= 6.
49182980397 runs/s, min= 779.
220779221 runs/s, max= 808.
080808081 runs/s
* Bindings/set-attribute.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 07:06:58 +0000 (07:06 +0000)]
[EFL] appcache tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=86619
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-18
Reviewed by Ryosuke Niwa.
Source/WebKit/efl:
No longer set the application cache path in ewk_main since the
path can only be set once and this prevents DRT (or apps) to set
it. Update the ewk_settings documentation to reflect these
changes.
* ewk/ewk_main.cpp:
(_ewk_init_body):
* ewk/ewk_settings.h:
Tools:
Correctly set the application cache database path in EFL's
DumpRenderTree initialization code.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 07:03:28 +0000 (07:03 +0000)]
[EFL] Add simple implementation of Web Intents
https://bugs.webkit.org/show_bug.cgi?id=86354
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-18
Reviewed by Eric Seidel.
.:
Enable WEB_INTENTS flag by default on EFL port.
* Source/cmake/OptionsEfl.cmake:
Source/WebKit:
Add new ewk_intent.* and ewk_intent_request.* files to CMake.
* CMakeLists.txt:
* PlatformEfl.cmake:
Source/WebKit/efl:
Add new EFL wrappers for WebCore's Intent and IntentRequest.
Implement dispatchIntent() in EFL's FrameLoaderClient and emit a new
"intent,new" signal on the frame to notify clients of new intent
requests.
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore):
(WebCore::FrameLoaderClientEfl::dispatchIntent):
* WebCoreSupport/FrameLoaderClientEfl.h:
(FrameLoaderClientEfl):
* ewk/ewk_frame.cpp:
(ewk_frame_intent_new):
* ewk/ewk_frame.h:
* ewk/ewk_frame_private.h:
* ewk/ewk_intent.cpp: Added.
(_Ewk_Intent):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_data_get):
(ewk_intent_service_get):
(ewk_intent_extra_get):
(ewk_intent_new):
(ewk_intent_free):
* ewk/ewk_intent.h: Added.
* ewk/ewk_intent_private.h: Added.
(WebCore):
* ewk/ewk_intent_request.cpp: Added.
(_Ewk_Intent_Request):
(ewk_intent_request_ref):
(ewk_intent_request_unref):
(ewk_intent_request_intent_get):
(ewk_intent_request_result_post):
(ewk_intent_request_failure_post):
(ewk_intent_request_new):
* ewk/ewk_intent_request.h: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 06:49:43 +0000 (06:49 +0000)]
[perf-test] Add a binding benchmark for div.getAttribute()
https://bugs.webkit.org/show_bug.cgi?id=86814
Reviewed by Ryosuke Niwa.
We should remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds a benchmark for div.getAttribute(). This benchmark
covers 'getAttribute' in Dromaeo/dom-attr.html, and other DOM methods
that return a String.
Test results in my Linux desktop:
RESULT Bindings: get-attribute= 250.
088158538 runs/s
median= 250.
469728765 runs/s, stdev= 4.
66551901315 runs/s, min= 240.
673886883 runs/s, max= 256.
739409499 runs/s
RESULT Bindings: get-attribute= 250.
209764698 runs/s
median= 250.
626959986 runs/s, stdev= 4.
12030002477 runs/s, min= 241.
254523522 runs/s, max= 255.
102040816 runs/s
RESULT Bindings: get-attribute= 248.
907532887 runs/s
median= 250.
312891114 runs/s, stdev= 3.
23173125874 runs/s, min= 240.
673886883 runs/s, max= 251.
572327044 runs/s
RESULT Bindings: get-attribute= 250.
243680844 runs/s
median= 250.
783797637 runs/s, stdev= 4.
19327170024 runs/s, min= 240.
963855422 runs/s, max= 255.
102040816 runs/s
RESULT Bindings: get-attribute= 245.
329046608 runs/s
median= 244.
948040416 runs/s, stdev= 2.
24314248534 runs/s, min= 240.
384615385 runs/s, max= 248.
756218905 runs/s
* Bindings/get-attribute.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 18 May 2012 06:32:36 +0000 (06:32 +0000)]
[GTK] KURL::fileSystemPath() should strip the query of the uri
https://bugs.webkit.org/show_bug.cgi?id=86721
Reviewed by Martin Robinson.
* platform/gtk/KURLGtk.cpp:
(WebCore::KURL::fileSystemPath): Use the already parsed path to
create the GFile instead of the whole URL string. The parsed path
doesn't include neither the fragment (#) nor the query (?) parts.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 06:29:59 +0000 (06:29 +0000)]
[perf-test] Add a binding benchmark for getElementById()
https://bugs.webkit.org/show_bug.cgi?id=86808
Reviewed by Ryosuke Niwa.
Currently Bindings/dom-attributes.html is just a collection
of random DOM attributes and methods. We should remove it and
instead add more reasonable micro benchmarks by classifying
DOM binding call paths.
This patch adds a benchmark for document.getElementById(),
which covers other DOM methods that return a Node Object.
The reason why we want to add a benchmark for document.getElementById()
in spite of the fact that Dromaeo/dom-query.html is already testing
document.getElementById(), is that Dromaeo/dom-query.html outputs one
result for several benchmarks (i.e. getElementById().nodeType,
getElementsByTagName()[0].nodeType etc), and thus we cannot observe
regression of getElementById() itself. (Catching regression of
getElementById() would be critical.)
Test results in my Linux desktop:
RESULT Bindings: get-element-by-id= 300.
933707795 runs/s
median= 302.
267002519 runs/s, stdev= 3.
04954648504 runs/s, min= 295.
930949445 runs/s, max= 305.
34351145 runs/s
RESULT Bindings: get-element-by-id= 302.
030324483 runs/s
median= 302.
267481977 runs/s, stdev= 1.
78518068367 runs/s, min= 298.
507462687 runs/s, max= 304.
568527919 runs/s
RESULT Bindings: get-element-by-id= 301.
993483538 runs/s
median= 302.
648171501 runs/s, stdev= 1.
87604126626 runs/s, min= 296.
662546354 runs/s, max= 304.
568527919 runs/s
RESULT Bindings: get-element-by-id= 301.
936607982 runs/s
median= 302.
45758701 runs/s, stdev= 1.
88991087072 runs/s, min= 298.
879202989 runs/s, max= 304.
955527319 runs/s
RESULT Bindings: get-element-by-id= 301.
952234563 runs/s
median= 302.
648171501 runs/s, stdev= 1.
59929752614 runs/s, min= 299.
625468165 runs/s, max= 304.
568527919 runs/s
* Bindings/get-element-by-id.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 06:03:56 +0000 (06:03 +0000)]
[perf-test] Add a benchmark for body.scrollTop
https://bugs.webkit.org/show_bug.cgi?id=86806
Reviewed by Ryosuke Niwa.
Currently Bindings/dom-attributes.html is just a collection of random
DOM attributes and methods. We should remove it and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
This patch adds a benchmark for body.scrollTop, which covers other
DOM attributes that return small integers.
(Note: Performance optimization for the benchmark will be coming soon.)
Test results in my Linux desktop:
RESULT Bindings: scroll-top= 209.
410654239 runs/s
median= 211.
64021164 runs/s, stdev= 4.
09958741195 runs/s, min= 201.
005025126 runs/s, max= 212.
483399734 runs/s
RESULT Bindings: scroll-top= 195.
651111157 runs/s
median= 196.
319018405 runs/s, stdev= 1.
77011627406 runs/s, min= 191.
846522782 runs/s, max= 197.
28729963 runs/s
RESULT Bindings: scroll-top= 200.
004907612 runs/s
median= 201.
511335013 runs/s, stdev= 3.
27455403827 runs/s, min= 193.
236714976 runs/s, max= 202.
53164557 runs/s
RESULT Bindings: scroll-top= 209.
582737512 runs/s
median= 210.
803689065 runs/s, stdev= 3.
16769655464 runs/s, min= 203.
045685279 runs/s, max= 211.
920529801 runs/s
RESULT Bindings: scroll-top= 199.
924607687 runs/s
median= 201.
13144338 runs/s, stdev= 3.
11080503619 runs/s, min= 193.
003618818 runs/s, max= 202.
02020202 runs/s
* Bindings/scroll-top.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 05:50:42 +0000 (05:50 +0000)]
[V8][Refactoring] Remove V8Proxy::deletionNotHandledByInterceptor()
https://bugs.webkit.org/show_bug.cgi?id=86803
Reviewed by Dimitri Glazkov.
V8Proxy::deletionNotHandledByInterceptor() is used by V8StorageCustom.cpp
only, just in order to return v8::Handle<v8::Boolean>(). In such cases,
other custom bindings are hard-coding 'return v8::Handle<v8::Boolean>()'.
Thus we can hard-code 'return v8::Handle<v8::Boolean>()' in V8StorageCustom.cpp
too, and remove V8Proxy::deletionNotHandledByInterceptor().
No tests. No change in behavior.
* bindings/v8/V8Proxy.h:
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::storageDeleter):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 18 May 2012 05:44:42 +0000 (05:44 +0000)]
Web Inspector: speed-up markQueriableHeapObjects function.
https://bugs.webkit.org/show_bug.cgi?id=86732
Reviewed by Yury Semikhatsky.
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Fri, 18 May 2012 05:35:07 +0000 (05:35 +0000)]
Some Spelling Mistakes Result in Compile Errors with ENABLE(FILE_SYSTEM) in LocalFileSystem.cpp
https://bugs.webkit.org/show_bug.cgi?id=86103
Reviewed by Rob Buis.
Added build fixes and some (limited) common implementation for non-chromium ports.
No new tests as this should have no functionality changes.
* Modules/filesystem/DOMFileSystemBase.cpp:
(WebCore::DOMFileSystemBase::isValidType): Added common implementation for non-chromium ports.
(WebCore::DOMFileSystemBase::crackFileSystemURL): Ditto.
(WebCore::DOMFileSystemBase::supportsToURL): Ditto.
(WebCore::DOMFileSystemBase::createFileSystemURL): Ditto.
* Modules/filesystem/LocalFileSystem.cpp:
(WebCore::LocalFileSystem::readFileSystem): Fixed.
(WebCore::LocalFileSystem::requestFileSystem): Fixed.
* platform/blackberry/AsyncFileSystemBlackBerry.cpp:
(WebCore::AsyncFileSystem::openFileSystem): Fixed.
* platform/gtk/AsyncFileSystemGtk.cpp:
(WebCore::AsyncFileSystem::openFileSystem): Fixed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 04:57:07 +0000 (04:57 +0000)]
AudioBufferSourceNode and MediaElementAudioSourceNode should support multi-channel > stereo
https://bugs.webkit.org/show_bug.cgi?id=75119
Patch by Wei James <james.wei@intel.com> on 2012-05-17
Reviewed by Chris Rogers.
As multiple channel support in AudioBus and other places is already
implemented, the check can be removed here.
* Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::setFormat):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Fri, 18 May 2012 04:46:34 +0000 (04:46 +0000)]
[EFL][DRT] Call resetInternalsObject() after each test.
https://bugs.webkit.org/show_bug.cgi?id=86793
Reviewed by Antonio Gomes.
We need to reset the internals object's settings after running
each test so that there are no interferences between each test's
results.
Source/WebKit/efl:
* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::globalContextRefForFrame):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:
Tools:
* DumpRenderTree/efl/DumpRenderTree.cpp:
(runTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 18 May 2012 04:41:07 +0000 (04:41 +0000)]
Unreviewed, WebKit2 GTK/Qt build fix attempt after r117516.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pilgrim@chromium.org [Fri, 18 May 2012 04:37:37 +0000 (04:37 +0000)]
[Chromium] Move Web Workers methods to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86799
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::didStartWorkerRunLoop):
(WebKit::Platform::didStopWorkerRunLoop):
* chromium/public/WebWorkerRunLoop.h: Added.
(WebCore):
(WebKit):
(WebWorkerRunLoop):
(Task):
(WebKit::WebWorkerRunLoop::Task::~Task):
(WebKit::operator==):
(WebKit::operator<):
Source/WebKit/chromium:
* WebKit.gyp:
* public/WebWorkerRunLoop.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::didStartWorkerRunLoop):
(WebCore::PlatformSupport::didStopWorkerRunLoop):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 18 May 2012 04:33:59 +0000 (04:33 +0000)]
<rdar://problem/
11419933> Problems with flipped writing modes and compositing
https://bugs.webkit.org/show_bug.cgi?id=86032
Reviewed by Anders Carlsson.
Source/WebCore:
Test: compositing/bounds-in-flipped-writing-mode.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateLayerBounds): Apply a writing-mode flip to the bounding box
if needed.
LayoutTests:
* compositing/bounds-in-flipped-writing-mode-expected.txt: Added.
* compositing/bounds-in-flipped-writing-mode.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 18 May 2012 03:39:09 +0000 (03:39 +0000)]
[V8][Refactoring] Remove V8Proxy::throwError(const char*, v8::Isolate* = 0)
https://bugs.webkit.org/show_bug.cgi?id=86794
Reviewed by Adam Barth.
As commented here (https://bugs.webkit.org/show_bug.cgi?id=84074#c5),
I am refactoring a series of confusing throwError()s.
This patch removes V8Proxy::throwError(const char*, v8::Isolate* = 0).
No tests. No change in behavior.
* bindings/v8/V8Utilities.cpp:
(WebCore::extractTransferables):
(WebCore::getMessagePortArray):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::constructWebGLArrayWithArrayBufferArgument):
(WebCore::constructWebGLArray):
* bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:
(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::setDragImageCallback):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::openCallback):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionStartAccessorGetter):
(WebCore::V8HTMLInputElement::selectionStartAccessorSetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorGetter):
(WebCore::V8HTMLInputElement::selectionEndAccessorSetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
(WebCore::V8HTMLInputElement::selectionDirectionAccessorSetter):
(WebCore::V8HTMLInputElement::setSelectionRangeCallback):
* bindings/v8/custom/V8HTMLMediaElementCustom.cpp:
(WebCore::V8HTMLMediaElement::controllerAccessorSetter):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::inspectedObjectCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Fri, 18 May 2012 03:36:12 +0000 (03:36 +0000)]
[chromium] Scale all compositor output by the defaultDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=86051
Reviewed by James Robinson.
Source/Platform:
* chromium/public/WebLayerTreeView.h:
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore:
On initialization, give the defaultDeviceScaleFactor to the compositor
to have it scale all output from WebCore's layout size to physical
pixels. This allows us to scale up to high-dpi devices without using
fixed-layout, so we can leave the WebCore frame size in layout pixels,
while drawing the frame into a larger physical pixel size.
CCLayerTreeHost becomes aware of the deviceScaleFactor and scales all
output by this factor by scaling the viewport and all drawing
transforms.
Anything that works in physical pixels (content space), uses the
deviceViewportSize() in place of the viewportSize(), since when
deviceScaleFactor != 1 in CCLayerTreeHost, the WebCore viewport
is no longer physical pixels.
Scroll positions are in layout pixels, and must be scaled to/from
content space within the compositor.
Unit tests: CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
(WebCore::LayerRendererChromium::viewportSize):
(WebCore::LayerRendererChromium::viewportWidth):
(WebCore::LayerRendererChromium::viewportHeight):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::setViewportSize):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
(CCLayerTreeHost):
(WebCore::CCLayerTreeHost::deviceViewportSize):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::setViewportSize):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::viewportSize):
(CCLayerTreeHostImpl):
Source/WebKit/chromium:
Add the applyDefaultDeviceScaleInCompositor setting. When enabled, we
apply the scale factor during compositing instead of applying it through
the pageScaleFactor.
NonCompositedContentHost is the GraphicLayerClient for the GraphicsLayer
containing the document's body. It needs to report the page/device scale
that should be used when scaling the contents of the GraphicsLayer, and
when changes occur to them such that its contentsSize or contentsScale
is affected.
Store the deviceScaleFactor being used in the compositor. The remainder
of the deviceScaleFactor() is being applied to the pageScale.
* public/WebSettings.h:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
(WebKit::NonCompositedContentHost::setViewport):
* src/NonCompositedContentHost.h:
(NonCompositedContentHost):
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setPageScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
(WebKit::WebViewImpl::enableFixedLayoutMode):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* src/WebViewImpl.h:
* tests/CCLayerTreeHostTest.cpp:
(MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::afterTest):
(WTF):
(WTF::TEST_F):
* tests/LayerRendererChromiumTest.cpp:
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 18 May 2012 03:24:44 +0000 (03:24 +0000)]
[Shadow DOM] Add an assertion to make sure a visited node is not an active insertion point.
https://bugs.webkit.org/show_bug.cgi?id=86708
Reviewed by Eric Seidel.
Since InsertionPoint now has isActive() member function,
we can add an assertion to ComposedShadowTreeWalker::assertPrecondition()
using that function.
No new tests, no change in behavior.
* dom/ComposedShadowTreeWalker.h:
(WebCore::ComposedShadowTreeWalker::assertPrecondition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 18 May 2012 03:16:23 +0000 (03:16 +0000)]
Unreviewed, rolling out r117526.
http://trac.webkit.org/changeset/117526
https://bugs.webkit.org/show_bug.cgi?id=86801
broke Chromium Mac 10.5 layout test canaries (Requested by
pkasting on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-17
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 18 May 2012 03:01:54 +0000 (03:01 +0000)]
[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=32670
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=82129
https://bugs.webkit.org/show_bug.cgi?id=83503
https://bugs.webkit.org/show_bug.cgi?id=86439
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 18 May 2012 02:45:11 +0000 (02:45 +0000)]
[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=23489
http://code.google.com/p/chromium/issues/detail?id=67540
http://code.google.com/p/chromium/issues/detail?id=68436
http://code.google.com/p/chromium/issues/detail?id=77706
https://bugs.webkit.org/show_bug.cgi?id=47949
https://bugs.webkit.org/show_bug.cgi?id=65462
https://bugs.webkit.org/show_bug.cgi?id=68436
https://bugs.webkit.org/show_bug.cgi?id=73838
https://bugs.webkit.org/show_bug.cgi?id=74694
https://bugs.webkit.org/show_bug.cgi?id=83185
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fischman@chromium.org [Fri, 18 May 2012 02:36:45 +0000 (02:36 +0000)]
[Chromium] Store HTTP version in WebURLResponse
https://bugs.webkit.org/show_bug.cgi?id=86522
Reviewed by Adam Barth.
Source/Platform:
* chromium/public/WebURLResponse.h:
(WebURLResponse):
Source/WebCore:
No new tests; this isn't exposed to the web platform.
* platform/chromium/support/WebURLResponse.cpp:
(WebKit::WebURLResponse::httpVersion):
(WebKit):
(WebKit::WebURLResponse::setHTTPVersion):
* platform/network/chromium/ResourceResponse.h:
(ResourceResponse):
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::httpVersion):
(WebCore::ResourceResponse::setHTTPVersion):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leviw@chromium.org [Fri, 18 May 2012 02:14:17 +0000 (02:14 +0000)]
Floor y coordinate in Chromium's GraphicsContext::drawLineForText to avoid anti-aliasing
https://bugs.webkit.org/show_bug.cgi?id=86775
Reviewed by Eric Seidel.
Despite operating in floats, we always want to draw lines for text aligned to pixel boundaries.
There are similar functions to do this in other platforms, but to get proper results, we only
need to floor the y value, as we always draw these lines horizontally.
No tests. No change in behavior prior to sub-pixel change.
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::drawLineForText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 18 May 2012 02:12:45 +0000 (02:12 +0000)]
[chromium] Prune unnecessary failure expectations.
http://code.google.com/p/chromium/issues/detail?id=11251
http://code.google.com/p/chromium/issues/detail?id=69181
http://code.google.com/p/chromium/issues/detail?id=124313
http://code.google.com/p/chromium/issues/detail?id=124779
https://bugs.webkit.org/show_bug.cgi?id=80067
https://bugs.webkit.org/show_bug.cgi?id=84125
https://bugs.webkit.org/show_bug.cgi?id=85553
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 18 May 2012 02:05:10 +0000 (02:05 +0000)]
scm.add() doesn't work properly with svn 1.7
https://bugs.webkit.org/show_bug.cgi?id=86779
Reviewed by Ojan Vafai.
The code relied on '.svn' directories being present
in order to tell if a directory had already been added to the
repository; this is no longer true in SVN 1.7.
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM):
(SCM.in_working_directory):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN):
(SVN.in_working_directory):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 18 May 2012 01:46:16 +0000 (01:46 +0000)]
[chromium] Fix bad baseline from trac.webkit.org/changeset/117480/.
https://bugs.webkit.org/show_bug.cgi?id=84167
Unreviewed, test expectations update.
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 18 May 2012 01:40:56 +0000 (01:40 +0000)]
Linux amd64 platform reported as i686
https://bugs.webkit.org/show_bug.cgi?id=86778
http://code.google.com/p/chromium/issues/detail?id=128167
Remove the old hard-coded gyp define and allow the more recent (but
still quite old) code in Source/WebCore/page/NavigatorBase.cpp to take
precedence and detect this at runtime.
Patch by Michael Moss <mmoss@chromium.org> on 2012-05-17
Reviewed by Tony Chang.
No new tests because it's hardware dependent.
* WebCore.gyp/WebCore.gyp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 18 May 2012 01:34:01 +0000 (01:34 +0000)]
Setting array index -1 and looping over array causes bad behavior
https://bugs.webkit.org/show_bug.cgi?id=86733
<rdar://problem/
11477670>
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
* dfg/DFGOperations.cpp:
LayoutTests:
* fast/js/dfg-negative-array-index-expected.txt: Added.
* fast/js/dfg-negative-array-index.html: Added.
* fast/js/script-tests/dfg-negative-array-index.js: Added.
(foo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Fri, 18 May 2012 01:28:03 +0000 (01:28 +0000)]
[chromium] More rebaselines/expectation updates.
https://bugs.webkit.org/show_bug.cgi?id=86441
Unreviewed, test expectations update.
* platform/chromium-linux/fast/borders/border-antialiasing-expected.png:
* platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-leopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
* platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vangelis@chromium.org [Fri, 18 May 2012 01:20:41 +0000 (01:20 +0000)]
Source/Platform: [chromium] Expose layer tiling size options to WebSettings
https://bugs.webkit.org/show_bug.cgi?id=86425
Adding entries for tile size and max untiled layer size.
Reviewed by Adrienne Walker.
* chromium/public/WebLayerTreeView.h:
(WebKit):
(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):
Source/WebCore: [chromium] Expose layer tiling size options to WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=86425
Removing hardcoded tile size and max untiled layer size from TiledLayerChromium
and instead have the values passed in via the LTH CCSettings. This will allow
different compositor instances to adjust tiling parameters as needed and makes
it possible to set the values via command line arguments.
Reviewed by Adrienne Walker.
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::TiledLayerChromium):
(WebCore::TiledLayerChromium::updateTileSizeAndTilingOption):
Made some additional adjustments to the single-tile heuristic
to make it work better with arbitrary sizes while still avoiding
to create unreasonably large layers.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCSettings::CCSettings):
(CCSettings):
Source/WebKit/chromium: Expose layer tiling size options to WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=86425
This will allow tiling parameters to be set via command line flags
passed to the Renderer.
Reviewed by Adrienne Walker.
* public/WebSettings.h:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setDefaultTileSize):
(WebKit):
(WebKit::WebSettingsImpl::setMaxUntiledLayerSize):
* src/WebSettingsImpl.h:
(WebSettingsImpl):
(WebKit::WebSettingsImpl::defaultTileSize):
(WebKit::WebSettingsImpl::maxUntiledLayerSize):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pilgrim@chromium.org [Fri, 18 May 2012 01:12:35 +0000 (01:12 +0000)]
[Chromium] Move fileUtilities to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=86777
Reviewed by Adam Barth.
Part of a refactoring series. See tracking bug 82948.
Source/Platform:
* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
(WebKit::Platform::fileUtilities):
* chromium/public/WebFileUtilities.h: Added.
(WebKit):
(WebFileUtilities):
(WebKit::WebFileUtilities::revealFolderInOS):
(WebKit::WebFileUtilities::fileExists):
(WebKit::WebFileUtilities::deleteFile):
(WebKit::WebFileUtilities::deleteEmptyDirectory):
(WebKit::WebFileUtilities::getFileSize):
(WebKit::WebFileUtilities::getFileModificationTime):
(WebKit::WebFileUtilities::directoryName):
(WebKit::WebFileUtilities::pathByAppendingComponent):
(WebKit::WebFileUtilities::makeAllDirectories):
(WebKit::WebFileUtilities::getAbsolutePath):
(WebKit::WebFileUtilities::isDirectory):
(WebKit::WebFileUtilities::filePathToURL):
(WebKit::WebFileUtilities::openFile):
(WebKit::WebFileUtilities::closeFile):
(WebKit::WebFileUtilities::seekFile):
(WebKit::WebFileUtilities::truncateFile):
(WebKit::WebFileUtilities::readFromFile):
(WebKit::WebFileUtilities::writeToFile):
(WebKit::WebFileUtilities::~WebFileUtilities):
Source/WebKit/chromium:
* WebKit.gyp:
* public/WebFileUtilities.h:
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::fileExists):
(WebCore::PlatformSupport::deleteFile):
(WebCore::PlatformSupport::deleteEmptyDirectory):
(WebCore::PlatformSupport::getFileSize):
(WebCore::PlatformSupport::revealFolderInOS):
(WebCore::PlatformSupport::getFileModificationTime):
(WebCore::PlatformSupport::directoryName):
(WebCore::PlatformSupport::pathByAppendingComponent):
(WebCore::PlatformSupport::makeAllDirectories):
(WebCore::PlatformSupport::getAbsolutePath):
(WebCore::PlatformSupport::isDirectory):
(WebCore::PlatformSupport::filePathToURL):
(WebCore::PlatformSupport::openFile):
(WebCore::PlatformSupport::closeFile):
(WebCore::PlatformSupport::seekFile):
(WebCore::PlatformSupport::truncateFile):
(WebCore::PlatformSupport::readFromFile):
(WebCore::PlatformSupport::writeToFile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 May 2012 00:55:43 +0000 (00:55 +0000)]
Not reviewed.
Rolled out r117495 because it caused som out of memory crashes.
* heap/Heap.cpp:
(JSC::Heap::collect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 18 May 2012 00:40:30 +0000 (00:40 +0000)]
Refactored the Heap to move more MarkedSpace logic into MarkedSpace
https://bugs.webkit.org/show_bug.cgi?id=86790
Reviewed by Gavin Barraclough.
* heap/Heap.cpp:
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::markRoots):
(JSC):
(JSC::Heap::objectCount):
(JSC::Heap::size):
(JSC::Heap::capacity):
(JSC::Heap::collect):
* heap/Heap.h:
(Heap): Took all the functors from here...
* heap/MarkedBlock.h:
(CountFunctor):
(JSC::MarkedBlock::CountFunctor::CountFunctor):
(JSC::MarkedBlock::CountFunctor::count):
(JSC::MarkedBlock::CountFunctor::returnValue):
(MarkedBlock):
* heap/MarkedSpace.h:
(JSC::ClearMarks::operator()):
(JSC):
(JSC::Sweep::operator()):
(JSC::MarkCount::operator()):
(JSC::Size::operator()):
(JSC::Capacity::operator()):
(MarkedSpace):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity): and put them here.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 18 May 2012 00:12:48 +0000 (00:12 +0000)]
Plug-ins blacklist mechanism can tell clients about plug-in with null identifier
https://bugs.webkit.org/show_bug.cgi?id=86788
<rdar://problem/
11479503>
Reviewed by John Sullivan.
Pass along the URL string of the blocked plug-in so we can find the plug-in even if there was no
MIME type specified in the <embed> or <object> tag.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
* UIProcess/WebPageProxy.h:
(WebPageProxy):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 23:35:41 +0000 (23:35 +0000)]
Memory leak in NetworkInfoClient
https://bugs.webkit.org/show_bug.cgi?id=86603
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-17
Reviewed by Adam Barth.
Source/WebCore:
Fix a memory leak in NetworkInfoClient by using OwnPtr and
change the class not to inherite from RefCounted.
* Modules/networkinfo/NetworkInfoClient.h:
Source/WebKit/efl:
Fix a memory leak in NetworkInfoClient by using OwnPtr and making
the client to be owned by the View.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 17 May 2012 23:25:51 +0000 (23:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86786
Two mathml/presentation tests fail on Mac
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 17 May 2012 23:25:46 +0000 (23:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86785
Two fast/repaint tests fail on mac lion
* platform/mac-lion/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Thu, 17 May 2012 23:20:26 +0000 (23:20 +0000)]
IndexedDB: Remove IDBIndex.storeName
https://bugs.webkit.org/show_bug.cgi?id=86676
Reviewed by Tony Chang.
Source/WebCore:
Older versions of the IDB spec exposed IDBIndex.storeName. While it's been removed
from the IDL, the additional storage/plumbing are unnecessary clutter. Nuke it!
No new tests - no functional changes.
* Modules/indexeddb/IDBIndexBackendImpl.cpp:
(WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): Remove storeName parameter, and
const declaration on object store param. The former was used to get a non-const pointer
via indirection in openCursorInternal.
(WebCore::IDBIndexBackendImpl::openCursorInternal): Use store pointer directly, don't
look it up by name in the transaction.
* Modules/indexeddb/IDBIndexBackendImpl.h:
(WebCore::IDBIndexBackendImpl::create): Remove storeName parameters.
(IDBIndexBackendImpl): Remove storeName() method.
* Modules/indexeddb/IDBIndexBackendInterface.h:
(IDBIndexBackendInterface): Remove storeName parameter.
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove storeName parameter.
(WebCore::IDBObjectStoreBackendImpl::loadIndexes): Remove storeName parameter.
Source/WebKit/chromium:
* public/WebIDBIndex.h:
(WebIDBIndex): Can't remove from here until Chromium is updated
* src/IDBIndexBackendProxy.cpp: Removed storeName()
* src/IDBIndexBackendProxy.h: Removed storeName()
(IDBIndexBackendProxy):
* src/WebIDBIndexImpl.cpp: Removed storeName()
* src/WebIDBIndexImpl.h: Removed storeName()
(WebIDBIndexImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zhajiang@rim.com [Thu, 17 May 2012 23:19:04 +0000 (23:19 +0000)]
[BlackBerry] thestar.com/iphone Viewport Weirdness
https://bugs.webkit.org/show_bug.cgi?id=86756
Reviewed by George Staikos.
PR 156710
On high DPI devices, the virtual viewport size of this page was smaller
than screen size. During the refreshing of the page, we reset the scale
when the state was Committed, then layouted and rendered contents based
on the virtual viewport size and default scale 1, which caused a small
size thumbnail before we restored the previous view state.
Fixed it by keeping the previous scale, user scalable and
m_userViewportArguments during the Committed state of refreshing.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 17 May 2012 23:11:20 +0000 (23:11 +0000)]
Don't let -[CALayer renderInContext:] try to render WebView's root layer
https://bugs.webkit.org/show_bug.cgi?id=86773
<rdar://problem/
10950075>
Reviewed by Dan Bernstein.
-[CALayer renderInContext:] doesn't correctly render our layer tree, so
don't let it try. Calling drawRect: with a bitmap context will already
do the right thing for WebViews.
* WebView/WebHTMLView.mm: Create a subclass of CALayer called WebLayerHostingLayer.
(-[WebLayerHostingLayer renderInContext:]): override renderInContext: to be a NOOP.
(-[WebHTMLView attachRootLayer:]): Create a WebLayerHostingLayer rather than a CALayer.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Thu, 17 May 2012 23:03:05 +0000 (23:03 +0000)]
IndexedDB: Implement IDBObjectStore.autoIncrement
https://bugs.webkit.org/show_bug.cgi?id=86662
Reviewed by Dimitri Glazkov.
Source/WebCore:
Simple boolean accessor defined in the IDB spec, which reflects the
object store's internal autoIncrement flag.
Test: storage/indexeddb/objectstore-basics.html
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::autoIncrement): Forward call to back end.
(WebCore):
* Modules/indexeddb/IDBObjectStore.h: Expose attribute as method.
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStore.idl: Define the attribute.
* Modules/indexeddb/IDBObjectStoreBackendInterface.h: Expose in interface.
(IDBObjectStoreBackendInterface):
Source/WebKit/chromium:
* src/IDBObjectStoreBackendProxy.cpp:
(WebKit::IDBObjectStoreBackendProxy::autoIncrement):
(WebKit):
* src/IDBObjectStoreBackendProxy.h:
(IDBObjectStoreBackendProxy):
* src/WebIDBObjectStoreImpl.cpp:
(WebKit::WebIDBObjectStoreImpl::autoIncrement):
(WebKit):
* src/WebIDBObjectStoreImpl.h:
(WebIDBObjectStoreImpl):
LayoutTests:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/resources/objectstore-basics.js:
(setVersionSuccess):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 17 May 2012 22:44:30 +0000 (22:44 +0000)]
Update Apple buildbots to prioritize latest changelists
https://bugs.webkit.org/show_bug.cgi?id=86766
Reviewed by Brady Eidson.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(pickLatestBuild): Function to get the most pick the most recent build request.
(loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
use the pickLatestBuild function when choosing which request to build next.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 22:35:07 +0000 (22:35 +0000)]
[V8][Refactoring] Remove throwError("message", XXXError) from CodeGeneratorV8.pm
https://bugs.webkit.org/show_bug.cgi?id=86744
Reviewed by Adam Barth.
As commented in https://bugs.webkit.org/show_bug.cgi?id=84074#c5,
I am refactoring a series of confusing throwError()s.
This patch removes throwError("message", XXXError) in CodeGeneratorV8.pm
and replaces it with throwTypeError("message") or throwError(XXXError, "message").
No tests. No change in behavior.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::constructorCallback):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::constructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::acceptTransferListCallback):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::multiTransferListCallback):
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 22:27:48 +0000 (22:27 +0000)]
Add more descriptive warnings for framebuffer incomplete conditions
https://bugs.webkit.org/show_bug.cgi?id=86774
Patch by Gregg Tavares <gman@google.com> on 2012-05-17
Reviewed by Kenneth Russell.
No new tests as there is no new functionality
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::checkStatus):
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
* html/canvas/WebGLFramebuffer.h:
(WebGLFramebuffer):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::printGLWarningToConsole):
* html/canvas/WebGLRenderingContext.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 17 May 2012 22:26:59 +0000 (22:26 +0000)]
[chromium] Rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=86441
Unreviewed, test expecations update.
* platform/chromium-mac-leopard/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac-leopard/fast/multicol/column-count-with-rules-expected.png:
* platform/chromium-mac-leopard/fast/multicol/column-rules-expected.png:
* platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac-leopard/fast/multicol/overflow-unsplittable-expected.png:
* platform/chromium-mac-leopard/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-mac-leopard/fast/multicol/positive-leading-expected.png:
* platform/chromium-mac-snowleopard/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/column-count-with-rules-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/column-rules-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/overflow-unsplittable-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-mac-snowleopard/fast/multicol/positive-leading-expected.png:
* platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
* platform/chromium-mac/fast/multicol/column-count-with-rules-expected.png:
* platform/chromium-mac/fast/multicol/column-rules-expected.png:
* platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png:
* platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
* platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/chromium-mac/fast/multicol/positive-leading-expected.png:
* platform/chromium-mac/fast/multicol/vertical-lr/column-count-with-rules-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/column-count-with-rules-expected.png: Added.
* platform/chromium-mac/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 17 May 2012 22:09:29 +0000 (22:09 +0000)]
Endeavour to make the windows test bot actually able to run tests.
https://bugs.webkit.org/show_bug.cgi?id=86772
Reviewed by Sam Weinig.
Source/WebCore:
Use WEBKIT_EXPORT to get correct export behaviour on windows, rather than
relying on the .def files.
* bindings/js/JSDOMGlobalObject.h:
(JSDOMGlobalObject):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Source/WebKit2:
Remove the ClassInfo exports from the .def files as we're now using
WEBKIT_EXPORT declarations to get expected behaviour on windows.
* win/WebKit2.def:
* win/WebKit2CFLite.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Thu, 17 May 2012 22:04:49 +0000 (22:04 +0000)]
[perf-test] Add a micro benchmark for div.firstChild getter for an undefined firstChild
https://bugs.webkit.org/show_bug.cgi?id=86725
Reviewed by Ryosuke Niwa.
We are going to remove Bindings/dom-attributes.html and instead add more
reasonable micro benchmarks by classifying DOM binding call paths.
In this bug, we add a micro benchmark for div.firstChild getter for an
undefined firstChild. This benchmark covers other undefined DOM attributes
that return a null.
(Note: In V8, div.firstChild for an undefined firstChild is currently slower
than div.firstChild for a defined firstChild.)
Test results in my Linux desktop:
RESULT Bindings: undefined-first-child= 541.
408311042 runs/s
median= 541.
205412054 runs/s, stdev= 1.
29841219187 runs/s, min= 537.
897310513 runs/s, max= 543.
209876543 runs/s
RESULT Bindings: undefined-first-child= 541.
00750695 runs/s
median= 540.
540540541 runs/s, stdev= 0.
967521230965 runs/s, min= 539.
215686275 runs/s, max= 543.
209876543 runs/s
RESULT Bindings: undefined-first-child= 523.
630714897 runs/s
median= 523.
560209424 runs/s, stdev= 1.
01570919645 runs/s, min= 522.
193211488 runs/s, max= 525.
624178712 runs/s
RESULT Bindings: undefined-first-child= 553.
077663588 runs/s
median= 553.
459119497 runs/s, stdev= 0.
805697397863 runs/s, min= 551.
378446115 runs/s, max= 554.
156171285 runs/s
RESULT Bindings: undefined-first-child= 541.5401432 runs/s
median= 541.
538666618 runs/s, stdev= 0.
954301364767 runs/s, min= 539.
877300613 runs/s, max= 543.
209876543 runs/s
* Bindings/undefined-first-child.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 17 May 2012 21:59:05 +0000 (21:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86266
r112643/r116697 break Webview form input fields
-and corresponding-
<rdar://problem/
11400430>
Reviewed by Dan Bernstein.
There is a recent history of changes in this are that seem worth documenting.
First was the change to switch to using NSTextFieldCell to draw text fields:
http://trac.webkit.org/changeset/104240
That led to problems because of the clear background that I thought at the time
were specific to MountainLion. To fix that, I made this change:
http://trac.webkit.org/changeset/110480
But that change resulted in styled text fields getting an un-themed border, which
led to this change on the branch: http://trac.webkit.org/changeset/112643 and a
change on TOT that was identical for Lion and SnowLeopard but introduced new
behavior for MountainLion: http://trac.webkit.org/changeset/116697
And that brings us to this bug, where it turns out the clear background is a
problem on Lion and SnowLeopard too. This patch fixes the bug by using the
original WebCoreSystemInterface function to paint all text fields on Lion and
SnowLeopard that are styled. This is what we used to paint all text fields before
r104240, which is the first change listed above. Un-styled text fields will still
use NSTextFieldCell on these platforms, but with a hardcoded white background.
* rendering/RenderThemeMac.h:
(RenderThemeMac):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 17 May 2012 21:49:43 +0000 (21:49 +0000)]
IconDatabase: Move icon retain/release off of the main thread.
<http://webkit.org/b/85799>
<rdar://problem/9507113>
Reviewed by Brady Eidson.
Batch up the retain/release operations and execute them as part of the sync thread loop.
The batch execution is guarded by a new mutex (m_urlsToRetainOrReleaseLock.)
This avoids blocking the main thread on m_urlAndIconLock for basic retain/release.
There is one exception; if there are pending retain/release operations in synchronousIconForPageURL,
it will acquire the lock and flush the operations.
There should be no behavior change, this is only meant to reduce lock contention.
* loader/icon/PageURLRecord.h:
(WebCore::PageURLRecord::retain):
(WebCore::PageURLRecord::release):
Added a 'count' argument to these so we can batch up the operations in IconDatabase.
* loader/icon/IconDatabase.h:
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performScheduleOrDeferSyncTimer):
(WebCore::IconDatabase::performScheduleOrDeferSyncTimerOnMainThread):
(WebCore::IconDatabase::scheduleOrDeferSyncTimer):
Perform the the timer scheduling on the main thread as it can be done on a different
thread by way of retainIconForPageURL or releaseIconForPageURL.
(WebCore::IconDatabase::synchronousIconForPageURL):
(WebCore::IconDatabase::retainIconForPageURL):
(WebCore::IconDatabase::performRetainIconForPageURL):
(WebCore::IconDatabase::releaseIconForPageURL):
(WebCore::IconDatabase::performReleaseIconForPageURL):
(WebCore::IconDatabase::retainedPageURLCount):
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::syncThreadMainLoop):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Thu, 17 May 2012 21:31:10 +0000 (21:31 +0000)]
Kill RenderLayer::relativePositionOffset(LayoutUnit& relX, LayoutUnit& relY) and cleanup RenderInline::clippedOverflowRectForRepaint
https://bugs.webkit.org/show_bug.cgi?id=86551
Reviewed by Abhishek Arya.
No test since there is no expected change in behavior.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clippedOverflowRectForRepaint):
Changed the function to use LayoutRect arithmetics instead of calculating
top / left manually. While at it, improved the naming, removed some local
variables and removed an unneeded style() NULL-check.
* rendering/RenderLayer.h: Removed the function.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 17 May 2012 21:23:22 +0000 (21:23 +0000)]
Increase the GC allocation trigger
https://bugs.webkit.org/show_bug.cgi?id=86699
Reviewed by Sam Weinig.
This helps a lot when the heap is growing, and helps to resolve
the regression caused by r116484.
* heap/Heap.cpp:
(JSC::Heap::collect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Thu, 17 May 2012 21:21:26 +0000 (21:21 +0000)]
Make the docked Web Inspector use autoresizing masks so the view doesn't jitter when
resizing the window.
https://webkit.org/b/86765
Reviewed by John Sullivan.
* UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter close]): Added. Zero out _inspectorProxy.
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Preform the work on a delay to
prevent interfering with Cocoa's resizing.
(WebKit::WebInspectorProxy::createInspectorWindow): Added setAutoresizingMask: call.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Removed setAutoresizingMask: call.
createInspectorWindow and platformAttach do this now.
(WebKit::WebInspectorProxy::platformDidClose): Call close on WKWebInspectorProxyObjCAdapter.
(WebKit::WebInspectorProxy::platformAttach): Added setAutoresizingMask: call.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 17 May 2012 21:17:36 +0000 (21:17 +0000)]
[BlackBerry] Fix linking errors
https://bugs.webkit.org/show_bug.cgi?id=86768
Reviewed by Antonio Gomes.
Add some missing stubs so we can link again.
* platform/blackberry/ContextMenuBlackBerry.cpp:
(WebCore::ContextMenu::itemCount):
(WebCore):
* platform/blackberry/PlatformScreenBlackBerry.cpp:
(WebCore::screenHorizontalDPI):
(WebCore):
(WebCore::screenVerticalDPI):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 21:06:53 +0000 (21:06 +0000)]
[EFL] Gardening, update test number tracking media-continues-playing-after-replace-source.html
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 17 May 2012 21:05:03 +0000 (21:05 +0000)]
[chromium] Remove passing tests, re-number some still-present issues.
https://bugs.webkit.org/show_bug.cgi?id=86441
https://bugs.webkit.org/show_bug.cgi?id=86701
https://bugs.webkit.org/show_bug.cgi?id=86712
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 17 May 2012 20:57:38 +0000 (20:57 +0000)]
Fix rounding in paintSelection
https://bugs.webkit.org/show_bug.cgi?id=86693
Reviewed by Eric Seidel.
Break out rounding logic from InlineTextBox::paintSelection into separate
function and use it for all the EllipsisBox paintSelection implementation
and selection gap calculation. This ensures that selections are painted
without gaps and overlaps once we turn on subpixel layout.
No new tests, covered by existing tests in editing/selection and
editing/style.
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paintSelection):
* rendering/InlineTextBox.cpp:
(WebCore::alignSelectionRectToDevicePixels):
(WebCore):
(WebCore::InlineTextBox::paintSelection):
* rendering/InlineTextBox.h:
(WebCore):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 20:55:31 +0000 (20:55 +0000)]
[EFL] Gardening, update expectations after r117426.
* platform/efl/editing/unsupported-content/list-type-before-expected.txt:
* platform/efl/editing/unsupported-content/table-type-after-expected.txt:
* platform/efl/editing/unsupported-content/table-type-before-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 May 2012 20:46:14 +0000 (20:46 +0000)]
Rebaseline Chromium results after r117477
Unreviewed gardening.
* platform/chromium-linux/css2.1/
20110323/table-height-algorithm-023-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-023-expected.png.
* platform/chromium-linux/css2.1/
20110323/table-height-algorithm-024-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-024-expected.png.
* platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png.
* platform/chromium-linux/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png.
* platform/chromium-mac-leopard/css2.1/
20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/
20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/
20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
* platform/chromium-mac/css2.1/
20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/table-height-algorithm-023-expected.txt: Added.
* platform/chromium-mac/css2.1/
20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-mac/css2.1/
20110323/table-height-algorithm-024-expected.txt: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.txt: Added.
* platform/chromium-win/css2.1/
20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/table-height-algorithm-023-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-023-expected.txt.
* platform/chromium-win/css2.1/
20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-win/css2.1/
20110323/table-height-algorithm-024-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-024-expected.txt.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-win/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Thu, 17 May 2012 20:30:51 +0000 (20:30 +0000)]
[Gtk] fast/dom/gc-10.html behaves badly
https://bugs.webkit.org/show_bug.cgi?id=86771
Unreviewed, skipping fast/dom/gc-10.html as it badly affects other tests.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Thu, 17 May 2012 20:10:35 +0000 (20:10 +0000)]
[BlackBerry] Cleanup headers in SelectionHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=86760
Reviewed by Antonio Gomes.
Clean up includes in SelectionHandler.cpp.
* WebKitSupport/SelectionHandler.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 May 2012 20:08:23 +0000 (20:08 +0000)]
Rebaseline two tests on Mac and update Mac expectations after r117339
Unreviewed gardening.
* platform/mac/fast/repaint/float-overflow-expected.txt:
* platform/mac/fast/repaint/float-overflow-right-expected.txt:
* platform/mac/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 20:04:08 +0000 (20:04 +0000)]
[chromium] Limiting render surface texture manager memory to 0 when contentsMemoryUseBytes is large.
https://bugs.webkit.org/show_bug.cgi?id=86764
Patch by Michal Mocny <mmocny@google.com> on 2012-05-17
Reviewed by Adrienne Walker.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::beginDrawingFrame):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 17 May 2012 20:01:50 +0000 (20:01 +0000)]
In vertical writing modes, pagination may split a line after a block shifts
https://bugs.webkit.org/show_bug.cgi?id=86763
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/multicol/pageLogicalOffset-vertical.html
LayoutState::pageLogicalOffset() was returning bogus results in vertical writing modes,
because it was always using physical heights. Changed it to take a RenderBox and use its
writing mode to choose between heights and widths.
* rendering/LayoutState.cpp:
(WebCore::LayoutState::pageLogicalOffset):
(WebCore::LayoutState::addForcedColumnBreak):
* rendering/LayoutState.h:
(LayoutState):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::markForPaginationRelayoutIfNeeded):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
LayoutTests:
* fast/multicol/pageLogicalOffset-vertical-expected.html: Added.
* fast/multicol/pageLogicalOffset-vertical.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Thu, 17 May 2012 19:58:35 +0000 (19:58 +0000)]
[BlackBerry] expandSelectionToGranularity should only use VisibleSelection and not range.
https://bugs.webkit.org/show_bug.cgi?id=86759
Reviewed by Antonio Gomes.
expandSelectionToGranularity unnecesarily converted the
selection to range and back. Using the selection
directly is preferred.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::expandSelectionToGranularity):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Thu, 17 May 2012 19:43:26 +0000 (19:43 +0000)]
Move run-in handling to addChild, instead of in layout.
https://bugs.webkit.org/show_bug.cgi?id=86387
Reviewed by Julien Chaffraix.
Source/WebCore:
Tests: fast/runin/insert-before-run-in.html
fast/runin/run-in-after-run-in.html
fast/runin/run-in-parent-add-child.html
fast/runin/run-in-parent-block-child-add-and-intrude.html
fast/runin/run-in-parent-block-child-add.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks): handle run-ins here
instead of layout. We do run-in handling when we see a new child with run-in display
or add a new block whose previous sibling is run-in.
(WebCore::RenderBlock::makeChildrenNonInline): if we will have block children, need
to move run-in back to its original position.
(WebCore::RenderBlock::handleSpecialChild): no longer need to handle run-ins during layout.
(WebCore::destroyRunIn): helper to destroy a block or inline run-in.
(WebCore):
(WebCore::RenderBlock::createReplacementRunIn): helper to create the new replacement run-in.
For moveRunInUnderSiblingBlockIfNeeded, it will be used to create a new inline run-in
that goes into the next sibling block. For moveRunInToOriginalPosition, it creates a new
block run-in that goes back to where it came from.
(WebCore::RenderBlock::moveRunInUnderSiblingBlockIfNeeded): almost same as previous
handleRunInChild function, but with the return type removed. Also, we don't allow
a run-in to intrude into a block that already has a run-in.
(WebCore::RenderBlock::moveRunInToOriginalPosition): moves run-in back to where it came from.
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBox.cpp:
* rendering/RenderBox.h:
(RenderBox):
* rendering/RenderBoxModelObject.cpp: move all moveChild* functions from RenderBox, since
they can now be used to move children of inlines.
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore):
(WebCore::RenderBoxModelObject::moveChildrenTo): same.
* rendering/RenderBoxModelObject.h:
(RenderBoxModelObject):
(WebCore::RenderBoxModelObject::moveChildTo): same.
(WebCore::RenderBoxModelObject::moveAllChildrenTo): same.
(WebCore::RenderBoxModelObject::moveChildrenTo): same.
LayoutTests:
The following tests need the render tree results as they help
to show the positioning of the run-in with respect to the next
sibling block.
* fast/runin/insert-before-run-in-expected.png: Added.
* fast/runin/insert-before-run-in-expected.txt: Added.
* fast/runin/insert-before-run-in.html: Added.
* fast/runin/run-in-after-run-in-expected.png: Added.
* fast/runin/run-in-after-run-in-expected.txt: Added.
* fast/runin/run-in-after-run-in.html: Added.
* fast/runin/run-in-parent-add-child-expected.png: Added.
* fast/runin/run-in-parent-add-child-expected.txt: Added.
* fast/runin/run-in-parent-add-child.html: Added.
* fast/runin/run-in-parent-block-child-add-and-intrude-expected.png: Added.
* fast/runin/run-in-parent-block-child-add-and-intrude-expected.txt: Added.
* fast/runin/run-in-parent-block-child-add-and-intrude.html: Added.
* fast/runin/run-in-parent-block-child-add-expected.png: Added.
* fast/runin/run-in-parent-block-child-add-expected.txt: Added.
* fast/runin/run-in-parent-block-child-add.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 17 May 2012 19:38:37 +0000 (19:38 +0000)]
Support Copy ... actions for the Web Inspector remote debugging mode.
https://bugs.webkit.org/show_bug.cgi?id=86621
Reviewed by Pavel Feldman.
Source/WebCore:
* English.lproj/localizedStrings.js:
* inspector/front-end/InspectorFrontendHostStub.js:
(.WebInspector.InspectorFrontendHostStub):
(.WebInspector.InspectorFrontendHostStub.prototype.documentCopy):
(.WebInspector.InspectorFrontendHostStub.prototype.copyText):
(.WebInspector.clipboardAccessDeniedMessage):
(.WebInspector.ClipboardAccessDeniedScreen):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.documentCopy):
(WebInspector.documentCopyEventFired):
Source/WebKit/chromium:
* src/js/DevTools.js:
(WebInspector.clipboardAccessDeniedMessage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 May 2012 19:36:25 +0000 (19:36 +0000)]
Rebaseline results after r117339
Unreviewed gardening.
* fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium-mac-leopard/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-mac-leopard/editing/selection/inline-table-expected.png:
* platform/chromium-mac-leopard/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac-leopard/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-mac-leopard/fast/inline-block/001-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/inline-table-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac-snowleopard/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-mac-snowleopard/fast/inline-block/001-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.png:
* platform/chromium-mac/editing/pasteboard/innerText-inline-table-expected.txt: Added.
* platform/chromium-mac/editing/selection/inline-table-expected.png:
* platform/chromium-mac/editing/selection/inline-table-expected.txt: Added.
* platform/chromium-mac/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac/editing/selection/table-caret-3-expected.txt: Added.
* platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.png:
* platform/chromium-mac/fast/css-generated-content/inline-display-types-expected.txt: Added.
* platform/chromium-mac/fast/inline-block/001-expected.png:
* platform/chromium-mac/fast/inline-block/001-expected.txt: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.txt: Added.
* platform/chromium-win-vista/fast/css-generated-content/inline-display-types-expected.png: Removed.
* platform/chromium-win-vista/fast/inline-block/001-expected.png: Removed.
* platform/chromium-win-xp/fast/css-generated-content/inline-display-types-expected.png: Removed.
* platform/chromium-win-xp/fast/inline-block/001-expected.png: Removed.
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Copied from LayoutTests/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt.
* platform/gtk/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/qt/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 19:10:14 +0000 (19:10 +0000)]
[EFL] Gardening, unskip test after r117205.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Thu, 17 May 2012 19:08:03 +0000 (19:08 +0000)]
This is not a joke: 3.7X speedup from removing a call to sleep
https://bugs.webkit.org/show_bug.cgi?id=86702
Reviewed by Eric Seidel.
The speedup was on a GC benchmark, with a custom VM caching layer
not in TOT yet.
Instruments showed most GC threads spending the majority of their
time sleeping instead of doing useful work. Removing the call to
sleep sped up the benchmark.
* wtf/TCSpinLock.h:
(TCMalloc_SlowLock): Since a spin lock is only ever held for a short
amount of time, don't sleep for a long amount of time waiting for it
to unlock -- yielding to the scheduler is sufficient.
If we find a case where someone is sitting on a spin lock for over 2ms,
we should fix the spin lock holder, not the spin lock.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 17 May 2012 19:07:57 +0000 (19:07 +0000)]
CSS 2.1 failure: table-height-algorithm-023 and -024 fail
https://bugs.webkit.org/show_bug.cgi?id=85405
Reviewed by Eric Seidel.
Source/WebCore:
Treat vertical-align: [length] the same as vertical-align: baseline.
Tests: css2.1/
20110323/table-height-algorithm-023.htm
css2.1/
20110323/table-height-algorithm-024.htm
fast/table/mozilla-bug10296-vertical-align-1.html
fast/table/mozilla-bug10296-vertical-align-2.html
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::layoutRows):
LayoutTests:
* css2.1/
20110323/table-height-algorithm-023.htm: Added.
* css2.1/
20110323/table-height-algorithm-024.htm: Added.
Tests from the CSS test suite.
* fast/table/mozilla-bug10296-vertical-align-1.html: Added.
* fast/table/mozilla-bug10296-vertical-align-2.html: Added.
I split out the part of bug10296-1.html that gets rebaselined here so that the new results
are visible. I also changed the text so that the expected result is less mysterious.
* platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-023-expected.png: Added.
* platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-023-expected.txt: Added.
* platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-024-expected.png: Added.
* platform/chromium-linux-x86/css2.1/
20110323/table-height-algorithm-024-expected.txt: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.png: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-1-expected.txt: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.png: Added.
* platform/chromium-linux-x86/fast/table/mozilla-bug10296-vertical-align-2-expected.txt: Added.
* platform/chromium-win/tables/mozilla/bugs/bug10296-1-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Thu, 17 May 2012 19:04:53 +0000 (19:04 +0000)]
Fix rounding in RenderFlowThread::paintIntoRegion
https://bugs.webkit.org/show_bug.cgi?id=86695
Reviewed by Eric Seidel.
Fix rounding of offset in paintIntoRegion to ensure that we paint on
device pixel boundaries.
Covered by existing tests in fast/regions.
* platform/graphics/FractionalLayoutPoint.h:
(WebCore::roundedIntPoint):
Add roundedIntPoint(FractionalLayoutSize) function.
(WebCore):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::paintIntoRegion):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 19:04:08 +0000 (19:04 +0000)]
[EFL] Gardening after r116339.
Add platform-specific results for the tests below.
* platform/efl/fast/repaint/float-overflow-expected.txt: Added.
* platform/efl/fast/repaint/float-overflow-right-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 17 May 2012 18:58:40 +0000 (18:58 +0000)]
[Qt] Fix MiniBrowser by using correct syntax for qrc URLs
https://bugs.webkit.org/show_bug.cgi?id=86761
Reviewed by Alexis Menard.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::updateVisualMockTouchPoints):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 17 May 2012 18:57:16 +0000 (18:57 +0000)]
Parser: Avoid unnecessary ref count churn in token constructors.
<http://webkit.org/b/86667>
Reviewed by Antti Koivisto.
Pass AtomicString by const reference to avoid useless ref count churn
in AtomicHTMLToken() and AtomicXMLToken().
* html/parser/HTMLToken.h:
(WebCore::AtomicHTMLToken::AtomicHTMLToken):
* xml/parser/MarkupTokenBase.h:
(WebCore::AtomicMarkupTokenBase::AtomicMarkupTokenBase):
* xml/parser/XMLToken.h:
(WebCore::AtomicXMLToken::AtomicXMLToken):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 18:50:00 +0000 (18:50 +0000)]
[EFL] Gardening, unskip another passing test after r117426.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Thu, 17 May 2012 18:48:29 +0000 (18:48 +0000)]
Make PluginInfoStore properly thread-safe.
<http://webkit.org/b/86648>
<rdar://problem/
11451178>
Reviewed by Darin Adler.
Source/WebCore:
* plugins/PluginData.h:
(WebCore::MimeClassInfo::isolatedCopy):
(WebCore::PluginInfo::isolatedCopy):
Source/WebKit2:
Deep copy the internal storage of PluginInfoStore after constructing it, as we can
be doing this from a secondary thread.
* Shared/Plugins/PluginModuleInfo.h:
(WebKit::PluginModuleInfo::isolatedCopy):
* UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::deepIsolatedCopyPluginInfoVector):
(WebKit::PluginInfoStore::loadPluginsIfNecessary):
(WebKit::PluginInfoStore::plugins):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hbono@chromium.org [Thu, 17 May 2012 18:44:39 +0000 (18:44 +0000)]
[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=86591
Reviewed by Ryosuke Niwa.
This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
function to remove platform-specific code from Editor::respondToChangedSelection
function.
No new tests, no change in behavior.
Source/WebCore:
* editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
* loader/EmptyClients.h:
(WebCore::EmptyTextCheckerClient::shouldEraseMarkersAfterChangeSelection):
* platform/text/TextCheckerClient.h:
(TextCheckerClient):
Source/WebKit/blackberry:
* WebCoreSupport/EditorClientBlackBerry.cpp:
(WebCore::EditorClientBlackBerry::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebCoreSupport/EditorClientBlackBerry.h:
(EditorClientBlackBerry):
Source/WebKit/chromium:
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* src/EditorClientImpl.h:
(EditorClientImpl):
Source/WebKit/efl:
* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebCoreSupport/EditorClientEfl.h:
(EditorClientEfl):
Source/WebKit/gtk:
* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* WebCoreSupport/TextCheckerClientGtk.h:
(TextCheckerClientGtk):
Source/WebKit/mac:
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
Source/WebKit/qt:
* WebCoreSupport/TextCheckerClientQt.cpp:
(WebCore::TextCheckerClientQt::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebCoreSupport/TextCheckerClientQt.h:
(TextCheckerClientQt):
Source/WebKit/win:
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient):
Source/WebKit/wince:
* WebCoreSupport/EditorClientWinCE.cpp:
(WebKit::EditorClientWinCE::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* WebCoreSupport/EditorClientWinCE.h:
(EditorClientWinCE):
Source/WebKit/wx:
* WebKitSupport/EditorClientWx.cpp:
(WebCore::EditorClientWx::shouldEraseMarkersAfterChangeSelection):
(WebCore):
* WebKitSupport/EditorClientWx.h:
(EditorClientWx):
Source/WebKit2:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):
(WebKit):
* WebProcess/WebCoreSupport/WebEditorClient.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 17 May 2012 18:41:27 +0000 (18:41 +0000)]
[chromium] Convert GraphicsLayerChromium to use WebLayer types
https://bugs.webkit.org/show_bug.cgi?id=86269
Reviewed by Adrienne Walker.
Source/Platform:
Adds some new WebLayer / WebContentLayer APIs that WebCore::GraphicsLayerChromium needs.
* chromium/public/WebContentLayer.h:
(WebCore):
(WebKit):
(WebContentLayer):
* chromium/public/WebLayer.h:
(WebKit):
(WebKit::WebLayer::isNull):
(WebLayer):
* chromium/public/WebTransformationMatrix.h:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
Fix a memory leak - WebPrivateOwnPtr<>s have to be explicitly cleared.
(WebTransformationMatrix):
Source/WebCore:
This converts GraphicsLayerChromium over to use WebLayer and WebContentLayer. The conversion is not completely
as the Web*Layer APIs are not yet quite complete enough to use everywhere, and the PlatformLayer typedef is not
changed in this patch. The places where we have to punch out through API layer are marked by
unwrap<*LayerChromium>() calls and FIXME's in the Web*Layer.h files. There aren't many.
Refactor only, existing tests apply.
* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit):
(WebKit::WebTransformationMatrix::reset):
(WebKit::WebTransformationMatrix::projectPoint):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
(WebCore::GraphicsLayerChromium::willBeDestroyed):
(WebCore::GraphicsLayerChromium::setName):
(WebCore::GraphicsLayerChromium::updateNames):
(WebCore::GraphicsLayerChromium::removeFromParent):
(WebCore::GraphicsLayerChromium::setSize):
(WebCore::GraphicsLayerChromium::setTransform):
(WebCore::GraphicsLayerChromium::setBackgroundColor):
(WebCore::GraphicsLayerChromium::clearBackgroundColor):
(WebCore::GraphicsLayerChromium::setContentsOpaque):
(WebCore::GraphicsLayerChromium::setFilters):
(WebCore::GraphicsLayerChromium::setMaskLayer):
(WebCore::GraphicsLayerChromium::setBackfaceVisibility):
(WebCore::GraphicsLayerChromium::setOpacity):
(WebCore::GraphicsLayerChromium::setReplicatedByLayer):
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
(WebCore::GraphicsLayerChromium::setContentsToImage):
(WebCore::GraphicsLayerChromium::setContentsToCanvas):
(WebCore::GraphicsLayerChromium::addAnimation):
(WebCore::GraphicsLayerChromium::pauseAnimation):
(WebCore::GraphicsLayerChromium::removeAnimation):
(WebCore::GraphicsLayerChromium::suspendAnimations):
(WebCore::GraphicsLayerChromium::resumeAnimations):
(WebCore::GraphicsLayerChromium::setContentsToMedia):
(WebCore::GraphicsLayerChromium::hostLayerForChildren):
(WebCore::GraphicsLayerChromium::layerForParent):
(WebCore::GraphicsLayerChromium::platformLayer):
(WebCore::GraphicsLayerChromium::setDebugBackgroundColor):
(WebCore::GraphicsLayerChromium::setDebugBorder):
(WebCore::GraphicsLayerChromium::updateChildList):
(WebCore::GraphicsLayerChromium::updateLayerPosition):
(WebCore::GraphicsLayerChromium::updateLayerSize):
(WebCore::GraphicsLayerChromium::updateAnchorPoint):
(WebCore::GraphicsLayerChromium::updateTransform):
(WebCore::GraphicsLayerChromium::updateChildrenTransform):
(WebCore::GraphicsLayerChromium::updateMasksToBounds):
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
(WebCore::GraphicsLayerChromium::updateLayerIsDrawable):
(WebCore::GraphicsLayerChromium::updateLayerBackgroundColor):
(WebCore::GraphicsLayerChromium::updateContentsRect):
(WebCore::GraphicsLayerChromium::updateContentsScale):
(WebCore::GraphicsLayerChromium::setupContentsLayer):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(WebCore::GraphicsLayerChromium::hasContentsLayer):
(WebCore::GraphicsLayerChromium::contentsLayer):
(WebCore::GraphicsLayerChromium::primaryLayer):
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
Source/WebKit/chromium:
* WebKit.gyp:
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::clearClient):
(WebKit):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<ContentLayerChromium>):
* src/WebContentLayerImpl.cpp:
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* src/WebLayer.cpp:
(WebKit::WebLayer::setSublayerTransform):
(WebKit):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::setIsDrawable):
(WebKit::WebLayer::setPreserves3D):
(WebKit::WebLayer::setDoubleSided):
(WebKit::WebLayer::setBackgroundColor):
(WebKit::WebLayer::setContentsScale):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 17 May 2012 18:34:37 +0000 (18:34 +0000)]
remove bit rotted comment about css properties
https://bugs.webkit.org/show_bug.cgi?id=86750
Reviewed by Alexis Menard.
It's not clear to me what the first block was even referring to.
Aural doesn't seem to exist anymore. It might be worth keeping,
"All the CSS properties are not supported by the renderer at the
moment.", but it seems obvious to me.
No new tests, just removing a comment.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pkasting@chromium.org [Thu, 17 May 2012 18:33:33 +0000 (18:33 +0000)]
[chromium] Remove unnecessary expectations for passing tests.
https://bugs.webkit.org/show_bug.cgi?id=86698
Unreviewed, test expectations update.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 17 May 2012 18:22:38 +0000 (18:22 +0000)]
Insert source file and line number for v8 function calls into tracing
https://bugs.webkit.org/show_bug.cgi?id=84613
Reviewed by Kentaro Hara.
The trace for v8 function calls doesn't include any information about
what function is being called. Pass this information along so it can
be less opaque.
* bindings/v8/V8Proxy.cpp:
(WebCore::resourceInfo):
(WebCore):
(WebCore::resourceString):
(WebCore::V8Proxy::instrumentedCallFunction):
* platform/chromium/TraceEvent.h:
(WebCore::TraceEvent::TraceStringWithCopy::TraceStringWithCopy):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 18:21:02 +0000 (18:21 +0000)]
[EFL] Gardening, unskip some tests after r117426.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 17 May 2012 18:09:37 +0000 (18:09 +0000)]
[EFL] Add API for Web Database handling
https://bugs.webkit.org/show_bug.cgi?id=85178
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-17
Reviewed by Antonio Gomes.
Source/WebKit:
Added the new Web Database API to the buildsystem.
* PlatformEfl.cmake:
Source/WebKit/efl:
Add API for Web Database. This API will allow a browser
to query information about size, name, filename and remove
databases based on the origin. It will be also possible to
list all databases for a given origin.
* ewk/EWebKit.h:
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_web_database_get_all):
* ewk/ewk_security_origin.h:
* ewk/ewk_settings.cpp:
* ewk/ewk_settings.h:
* ewk/ewk_web_database.cpp: Added.
(_Ewk_Web_Database):
(ewk_web_database_display_name_get):
(ewk_web_database_expected_size_get):
(ewk_web_database_filename_get):
(ewk_web_database_name_get):
(ewk_web_database_security_origin_get):
(ewk_web_database_size_get):
(ewk_web_database_remove):
(ewk_web_database_remove_all):
(ewk_web_database_free):
(ewk_web_database_list_free):
(ewk_web_database_new):
* ewk/ewk_web_database.h: Added.
* ewk/ewk_web_database_private.h: Copied from Source/WebKit/efl/ewk/EWebKit.h.
(WebCore):
Tools:
Use the newly introduced Web Database API in EFL's DRT.
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearAllDatabases):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caio.oliveira@openbossa.org [Thu, 17 May 2012 17:54:40 +0000 (17:54 +0000)]
[Qt] REGRESSION(101967): It made editing/style/iframe-onload-crash-mac.html timeout
https://bugs.webkit.org/show_bug.cgi?id=73802
Reviewed by Ryosuke Niwa.
Source/WebCore:
Timeout was caused by an infinite in the outer loop of
pushDownInlineStyleAroundNode(). The outer loop variable 'current' should point at the
node containing 'targetNode'. The inner loop traverse the children of 'current'
and discover the children that contains 'targetNode'.
However, before the inner loop, we call removeInlineStyleFromElement() that can
potentially remove the 'current' node from the tree, moving its children to
'current' former parent. For that reason 'child' and 'lastChild' are collected
before this call.
The tricky part is that changing the 'current' children parent, we might trigger
further side-effects, that can remove either 'child' or 'lastChild' from the tree
too. The infinite loop was due to 'child' being off the document, so it's
nextSibling() is 0, and we go another run of outer loop without changing
'current' because the 'targetNode' wasn't in the first child that inner loop
couldn't reach.
When testing Qt on Mac, there was also a crash in RenderTextControl when the font
family was empty, this patch fixes it as well.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Use NodeVector
instead of relying on first/last child being valid after
removeInlineStyleFromElement() is called. Skip the child if it has no parent,
this is an indication that it was removed from the tree.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hasValidAvgCharWidth): Empty AtomicStrings aren't
supported by HashSet, so we have to early return in this case.
LayoutTests:
* platform/qt/Skipped: Unskipped. Note that it is still skipped for wk2 because
setEditingBehavior is not implemented for WebKitTestRunner yet.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 17 May 2012 17:52:33 +0000 (17:52 +0000)]
Web Inspector: implement Go To selector for stylesheet files.
https://bugs.webkit.org/show_bug.cgi?id=86751
Reviewed by Yury Semikhatsky.
StyleSheetOutlineDialog is introduced.
* English.lproj/localizedStrings.js:
* inspector/front-end/FilteredItemSelectionDialog.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createDebugToolbar):
(WebInspector.ScriptsPanel.prototype._createButtonAndRegisterShortcuts):
(WebInspector.ScriptsPanel.prototype._showOutlineDialog):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSheetOutlineDialog):
(WebInspector.StyleSheetOutlineDialog.show):
(WebInspector.StyleSheetOutlineDialog.prototype.itemTitleAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemKeyAt):
(WebInspector.StyleSheetOutlineDialog.prototype.itemsCount):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems.didGetStyleSheet):
(WebInspector.StyleSheetOutlineDialog.prototype.selectItem):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._generateTabId):
(WebInspector.TabbedEditorContainer.prototype.currentFile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Thu, 17 May 2012 17:50:30 +0000 (17:50 +0000)]
REGRESSION (r117449): Unreviewed, rolling out r117449.
https://bugs.webkit.org/show_bug.cgi?id=86753
Broke many unskipped tests which lack expectations
* platform/efl/Skipped:
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
projects / profile / ivi / webkit-efl.git / log