clang-format [Tue, 26 Jul 2016 05:50:48 +0000 (22:50 -0700)]
test: apply clang-format
Change-Id: I0d9ab85855eb723f653a7bb09b3d0d31dd6cfd2f
James Zern [Tue, 26 Jul 2016 23:34:54 +0000 (16:34 -0700)]
.clang-format: disable DerivePointerAlignment
everything outside of third_party should follow 'PointerAlignment:
right' i.e., associate the '*' with the variable
+ add a note about the clang-format that generated this file
Change-Id: I13e3f4f5fb6e22a8fa7fc3d06879c995b7c41a39
James Zern [Tue, 26 Jul 2016 22:54:31 +0000 (22:54 +0000)]
Merge "vpx_ports: apply clang-format"
James Zern [Tue, 26 Jul 2016 21:19:17 +0000 (21:19 +0000)]
Merge "vpx_mem: apply clang-format"
James Zern [Tue, 26 Jul 2016 21:18:24 +0000 (21:18 +0000)]
Merge "vpx_util: apply clang-format"
Alex Converse [Tue, 26 Jul 2016 19:39:54 +0000 (19:39 +0000)]
Merge "Only consider visible 4x4s in pixel domain error."
James Zern [Tue, 26 Jul 2016 18:49:17 +0000 (18:49 +0000)]
Merge "register_state_check: simplify Check() methods"
clang-format [Tue, 26 Jul 2016 05:33:21 +0000 (22:33 -0700)]
vpx_util: apply clang-format
Change-Id: Ie7eab608e2906b9a2b3533db95292ebc430ad377
James Zern [Sat, 23 Jul 2016 18:33:29 +0000 (11:33 -0700)]
register_state_check: simplify Check() methods
- make Check() void as the EXPECT's are sufficient to document failure
cumulatively this has the effect of avoiding reporting incorrect Check()
failures due to earlier test failures.
Change-Id: I2cf775449f18c90c1506b8eadd7067adbc3ea046
Alex Converse [Mon, 25 Jul 2016 18:05:40 +0000 (11:05 -0700)]
Only consider visible 4x4s in pixel domain error.
BDRATE change
derf144: -0.327
lowres: -0.048
midres: -0.125
hdres: -0.238
Change-Id: I789aba9870b5c2952373a7dd4fc8ed45590c3c54
clang-format [Mon, 25 Jul 2016 21:22:32 +0000 (14:22 -0700)]
vpx_ports: apply clang-format
Change-Id: Ice343335a40238fd21490bce0ce2972bdcb87055
clang-format [Mon, 25 Jul 2016 21:16:28 +0000 (14:16 -0700)]
vpx_mem: apply clang-format
Change-Id: I0440686fc03f1ee02bd0168c91e671a0a2d0056a
clang-format [Sat, 23 Jul 2016 03:07:03 +0000 (20:07 -0700)]
vpx_dsp: apply clang-format
Change-Id: I3ea3e77364879928bd916f2b0a7838073ade5975
James Zern [Mon, 25 Jul 2016 19:47:37 +0000 (19:47 +0000)]
Merge "configure: test for -Wfloat-conversion"
Johann Koenig [Mon, 25 Jul 2016 19:44:04 +0000 (19:44 +0000)]
Merge "Fix compilation error under Clang 4.0."
Ivan Krasin [Mon, 25 Jul 2016 19:11:02 +0000 (12:11 -0700)]
Fix compilation error under Clang 4.0.
The LLVM trunk has reached 4.0 and now __clang_major__ is not enough
to distinguish between old XCode Clang and the new 'real' Clang.
Using __apple_build_version__ allows to make this distinction.
BUG=chromium:631144
Change-Id: I0b6e46fddfe4f409c7b7e558bda34872e60ee2d9
James Zern [Fri, 22 Jul 2016 20:13:56 +0000 (13:13 -0700)]
configure: test for -Wfloat-conversion
supported by clang, gcc-4.9+
Change-Id: I893766de7307fef9a8b68c0cfae137c9d3b0dbe8
James Zern [Mon, 25 Jul 2016 19:00:37 +0000 (19:00 +0000)]
Merge "vp9: fix frame-level threaded decode shutdown"
Alex Converse [Mon, 25 Jul 2016 17:50:42 +0000 (17:50 +0000)]
Merge "Minor skip segment simplification."
Scott LaVarnway [Mon, 25 Jul 2016 11:58:24 +0000 (11:58 +0000)]
Merge "VP9: get_pred_context_switchable_interp() -- encoder side"
James Zern [Sat, 23 Jul 2016 18:41:52 +0000 (11:41 -0700)]
vp8/decodeframe: fix signed/unsigned comparison
quiets a visual studio warning
Change-Id: Ic7725616bc2cb837e6f79294d4fcff36b67af834
James Zern [Sat, 23 Jul 2016 17:59:15 +0000 (10:59 -0700)]
vp9: fix frame-level threaded decode shutdown
Shutdown all threads before reclaiming any memory. The frame-level
parallel decoder may access data from another worker.
BUG=webm:1259
Change-Id: I26856ebd1f77cc4a4545331baa19bbf3e01c4ea4
clang-format [Sat, 23 Jul 2016 17:55:44 +0000 (10:55 -0700)]
vp8/postproc.c: disable clang-format for RGB_TO_YUV
Change-Id: Id2a936301ec1e3d5648b4f8adbf4e6625002589d
James Zern [Sat, 23 Jul 2016 01:27:14 +0000 (01:27 +0000)]
Merge "vpx/: apply clang-format"
James Zern [Sat, 23 Jul 2016 01:18:31 +0000 (01:18 +0000)]
Merge changes I0089e884,Icb0ecb9e
* changes:
vp8/postproc: fix implicit float conversion
blockiness_test: fix implicit float conversion
James Zern [Sat, 23 Jul 2016 01:17:49 +0000 (01:17 +0000)]
Merge "resize_test: fix implicit float->int conversion"
James Bankoski [Sat, 23 Jul 2016 00:51:37 +0000 (00:51 +0000)]
Merge "vp8:fix threading issues"
Jim Bankoski [Thu, 21 Jul 2016 16:20:10 +0000 (09:20 -0700)]
vp8:fix threading issues
1 - stops de allocating before threads are closed.
2 - limits threads to mb_rows when mb_rows < partitions
BUG=webm:851
Change-Id: I7ead53e80cc0f8c2e4c1c53506eff8431de2a37e
James Zern [Fri, 22 Jul 2016 23:01:09 +0000 (16:01 -0700)]
vp8/postproc: fix implicit float conversion
float->int as reported by -Wfloat-conversion
Change-Id: I0089e8847b218c47526bcfbb0fffd9aad7c5adb3
Yury Gitman [Fri, 15 Jul 2016 17:32:04 +0000 (10:32 -0700)]
Add VPX_SWAP macro
Change-Id: I60e233eddef238ad918183392794084673f27d2d
James Zern [Fri, 22 Jul 2016 22:08:59 +0000 (15:08 -0700)]
blockiness_test: fix implicit float conversion
float->int as reported by -Wfloat-conversion
Change-Id: Icb0ecb9e2d54edb95813d9f2de34cb6c27b63cbd
Alex Converse [Fri, 22 Jul 2016 19:10:46 +0000 (12:10 -0700)]
Minor skip segment simplification.
Change-Id: I34863fce1abe94f9539e9a5a6149ae1efb6501bd
Marco Paniconi [Fri, 22 Jul 2016 21:27:05 +0000 (21:27 +0000)]
Merge "vp9 1pass-vbr: Adjust gf setting for nonzero-lag case."
James Zern [Fri, 22 Jul 2016 20:11:07 +0000 (13:11 -0700)]
resize_test: fix implicit float->int conversion
Change-Id: I1efc16fa158740a06da719a1ea90c6dd6a182bb4
Marco [Fri, 22 Jul 2016 18:44:58 +0000 (11:44 -0700)]
vp9 1pass-vbr: Adjust gf setting for nonzero-lag case.
Change-Id: I230c586c6d5ae56ee9a6d37b7d9452351bb4bd80
Paul Wilkins [Fri, 22 Jul 2016 09:27:34 +0000 (09:27 +0000)]
Merge "Sample points to reduce encode overhead."
Paul Wilkins [Fri, 22 Jul 2016 09:27:19 +0000 (09:27 +0000)]
Merge "Noise energy Experiment in first pass."
clang-format [Fri, 22 Jul 2016 02:58:19 +0000 (19:58 -0700)]
vpx/: apply clang-format
Change-Id: I95922a64568bf289863c1564212b6be5beec36df
Yunqing Wang [Fri, 22 Jul 2016 00:24:32 +0000 (17:24 -0700)]
Add back header in threading.h
Added back the header needed in threading.h
Change-Id: I2ce66ad4fe58004997623f6c3f3b8dd11640aa98
Yunqing Wang [Thu, 21 Jul 2016 21:32:54 +0000 (21:32 +0000)]
Merge "Revert "Amend and improve VP8 multithreading implementation""
Yunqing Wang [Thu, 14 Jul 2016 21:50:52 +0000 (14:50 -0700)]
Revert "Amend and improve VP8 multithreading implementation"
Reverted the patch because of possible performance issue.
Change-Id: I49944f827ccd38ed194c9f8d9cb9036fa9bf79e1
Scott LaVarnway [Thu, 21 Jul 2016 18:47:51 +0000 (11:47 -0700)]
VP9: get_pred_context_switchable_interp() -- encoder side
Change-Id: I7217c90d5cf38c51b76759a2dc4f10070f3a40ac
Alex Converse [Thu, 21 Jul 2016 18:38:27 +0000 (11:38 -0700)]
MinArfFreqTest: Don't leak video on failure.
Change-Id: I250379f0ac8d4929c9032e7343290e2980fc2e77
Alex Converse [Thu, 21 Jul 2016 18:36:41 +0000 (11:36 -0700)]
Make test encoder test driver less likely to leak on failure.
Individual tests still need to be updated.
Change-Id: Ic433d0f742e13560b136f136b72b2a9973970d78
James Zern [Thu, 21 Jul 2016 03:05:20 +0000 (03:05 +0000)]
Merge changes from topic 'clang-tidy'
* changes:
vp8/onyx_if.c: rework #if's to avoid dangling else's
vp8/bitstream.c: rework #if to avoid dangling else
Johann [Thu, 21 Jul 2016 01:49:04 +0000 (18:49 -0700)]
Merge remote-tracking branch 'origin/khakicampbell'
Johann [Thu, 30 Jun 2016 23:00:50 +0000 (16:00 -0700)]
Release v1.6.0 Khaki Campbell Duck
Change-Id: I08da365dd889093f9919476a02ee96ae9615f140
jackychen [Wed, 20 Jul 2016 22:58:35 +0000 (15:58 -0700)]
vp9: Fix the clang warning of unsigned int type.
Change-Id: I6308db16bd626fa5943925471e9171f567669350
Yaowu Xu [Tue, 12 Jul 2016 18:11:26 +0000 (11:11 -0700)]
Fix encoder crashes for odd size input
(cherry picked from commit
98431cde070a33fe346f1316abd8437cd873dbfa)
Change-Id: Id5c30c419282369cc8c3280d9a70b34a859a71d8
James Zern [Wed, 20 Jul 2016 06:03:45 +0000 (23:03 -0700)]
vp8/onyx_if.c: rework #if's to avoid dangling else's
Change-Id: Ieda8958a3da1000424fcff91a1315d0049612202
James Zern [Wed, 20 Jul 2016 06:02:34 +0000 (23:02 -0700)]
vp8/bitstream.c: rework #if to avoid dangling else
Change-Id: I9178ae75876f3df3fa3271314db39830552b9549
James Zern [Wed, 20 Jul 2016 19:34:59 +0000 (19:34 +0000)]
Merge changes from topic 'clang-tidy'
* changes:
vp8/{bitstream,rdopt},y4minput: correct break placement
y4minput.c: correct empty loop formatting
vp8: simplify a few #if's
vp8: remove extra semicolons
Yaowu Xu [Wed, 20 Jul 2016 16:25:14 +0000 (09:25 -0700)]
Change to call vp9_post_proc_frame()
This commit changes the call in vp9 encoder from vp9_deblock() to
vp9_post_proc_frame() to ensure the data structures used in the call
are properly allocated. This fixes an encoder crash when configured
with --enable-internal-stats.
Change-Id: I2393b336c0f566665336df4f1ba91c405eb56764
James Zern [Wed, 20 Jul 2016 03:51:25 +0000 (20:51 -0700)]
vp8/{bitstream,rdopt},y4minput: correct break placement
these should be placed within {}s when present
Change-Id: If00e9766fa8cb039cc070467f353a468f99460fb
James Zern [Wed, 20 Jul 2016 03:46:39 +0000 (20:46 -0700)]
y4minput.c: correct empty loop formatting
prefer {}s over ';'
Change-Id: I563fc82717e1deb4f42a40e03dca318c6adaa0c1
James Zern [Wed, 20 Jul 2016 03:45:28 +0000 (20:45 -0700)]
vp8: simplify a few #if's
bitstream.c: asserts are disabled when CONFIG_DEBUG is unset
vp8_dx_iface.c: split |s into 2 statements across #if bounds
Change-Id: I307d1e969134db5c9c0edd7690589b6b29116cbd
James Zern [Wed, 20 Jul 2016 03:44:14 +0000 (20:44 -0700)]
vp8: remove extra semicolons
Change-Id: I84e1a293ee033865f82c244e8aaaadfb2fb27e63
clang-format [Tue, 19 Jul 2016 02:44:59 +0000 (19:44 -0700)]
top-level: apply clang-format
Change-Id: Ibd5395bf8956a80f7c0df4d539c7a42c927a1fc7
James Zern [Tue, 19 Jul 2016 21:24:29 +0000 (21:24 +0000)]
Merge "vp8: apply clang-tidy google-readability-braces-around-statements"
clang-tidy [Tue, 19 Jul 2016 06:15:57 +0000 (23:15 -0700)]
vp8: apply clang-tidy google-readability-braces-around-statements
applied against an x86_64 configure
clang-tidy-3.7.1 \
-checks='-*,google-readability-braces-around-statements' \
-header-filter='.*' -fix
+ clang-format afterward
Change-Id: I6694edeaee89b58b8b3082187e6756561136b459
James Zern [Tue, 19 Jul 2016 19:21:07 +0000 (19:21 +0000)]
Merge "examples: apply clang-format"
James Zern [Tue, 19 Jul 2016 19:12:23 +0000 (19:12 +0000)]
Merge changes Ia6004c08,I1954f9d6
* changes:
cosmetics: Add a few explanatory comments
cosmetics: Correct grammar/spelling in comments
Yury Gitman [Mon, 18 Jul 2016 18:24:23 +0000 (11:24 -0700)]
cosmetics: Add a few explanatory comments
Change-Id: Ia6004c08e6f5fd269a1bbd4df51ce9b76345150d
Marco Paniconi [Tue, 19 Jul 2016 17:17:16 +0000 (17:17 +0000)]
Merge "vp9: Allow usage of lookahead for real-time, 1 pass vbr."
Johann Koenig [Tue, 19 Jul 2016 16:37:42 +0000 (16:37 +0000)]
Merge "Change 'git cl upload' default to --no-squash"
James Zern [Tue, 19 Jul 2016 06:09:36 +0000 (06:09 +0000)]
Merge changes I18982dbf,I15c8976c
* changes:
build/make/Makefile: add a 'test_*' default target
build/make/Makefile: remove default suffix rules
Pascal Massimino [Tue, 19 Jul 2016 03:52:54 +0000 (03:52 +0000)]
Merge "take II: variance_test partial clean-up"
clang-format [Tue, 19 Jul 2016 02:04:56 +0000 (19:04 -0700)]
examples: apply clang-format
Change-Id: Icc3bbb07c99a31a70030baec7e51b881902a7b5e
James Bankoski [Tue, 19 Jul 2016 00:57:45 +0000 (00:57 +0000)]
Merge "configure: turn on all unused warnings by default"
James Zern [Mon, 18 Jul 2016 23:30:58 +0000 (16:30 -0700)]
build/make/Makefile: add a 'test_*' default target
allows 'make test_libvpx', etc. some reworking of the makefiles would be
needed to avoid hard coding targets here.
Change-Id: I18982dbf691e7d36ab8bcf5934bab9340687b061
James Zern [Mon, 18 Jul 2016 23:30:40 +0000 (16:30 -0700)]
build/make/Makefile: remove default suffix rules
Change-Id: I15c8976c6478bf75ec617398f49461b310ab7569
skal [Thu, 14 Jul 2016 00:33:22 +0000 (17:33 -0700)]
take II: variance_test partial clean-up
remove some (but not all yet!) tuple mis-use, and revamp the code a lot.
Factorize some common chores into MainTestClass.
Change-Id: Id37b7330eebe80d19b9d12a454f24ff9be6b1116
Marco [Wed, 17 Feb 2016 20:03:57 +0000 (12:03 -0800)]
vp9: Allow usage of lookahead for real-time, 1 pass vbr.
Allow usage of lookahead for VBR in real-time mode, for 1 pass vbr.
Current usage is for fast checking of future scene cuts/changes,
and adjusting rate control (gf interval and active_worst/target size).
Added unittests (datarate) for 1 pass vbr mode, with non-zero lag.
Added an experimental option to limit QP based on lookahead.
Overall positive gain in metrics on ytlive set:
avgPNSR/SSIM up on average ~1-3%; several clips up by 5, 7%.
Change-Id: I960d57dfc89de121c4824b9a9bf88d2814e74b56
Johann [Mon, 18 Jul 2016 21:15:24 +0000 (14:15 -0700)]
Change 'git cl upload' default to --no-squash
Chromium changed the upstream default to --squash but this conflicts
with libvpx historical defaults.
Change-Id: I80f2f2b48e2ba08e02184b50e6d5f8f5e76fec24
Yury Gitman [Wed, 15 Jun 2016 01:57:29 +0000 (18:57 -0700)]
cosmetics: Correct grammar/spelling in comments
Change-Id: I1954f9d6e33abff9081fe7a5cf59d5497768e0df
Jim Bankoski [Mon, 18 Jul 2016 13:54:50 +0000 (06:54 -0700)]
prepend ++ instead of post in for loops.
Applied the following regex :
search for: (for.*\(.*;.*;) ([a-zA-Z_]*)\+\+\)
replace with: \1 ++\2)
This misses some for loops:
ie : for (mb_col = 0; mb_col < oci->mb_cols; mb_col++, mi++)
Change-Id: Icf5f6fb93cced0992e0bb71d2241780f7fb1f0a8
James Zern [Sat, 16 Jul 2016 22:01:19 +0000 (22:01 +0000)]
Merge "Revert "variance_test partial clean-up""
James Zern [Sat, 16 Jul 2016 18:11:51 +0000 (11:11 -0700)]
vpx_plane_add_noise_c: normalize int types
quiets signed/unsigned mismatch warning
Change-Id: Iaabd7dfff110ba26056258457541f5635d2e85e6
James Zern [Sat, 16 Jul 2016 18:54:21 +0000 (11:54 -0700)]
Revert "variance_test partial clean-up"
This reverts commit
f993ed5c86217e31b92ecc7ef58d7d7860b80108.
build warnings under msvc, segfaults with high-bitdepth enabled.
Change-Id: I67502651107830bcadb6ef56d8f2709cccbfdf2b
Pascal Massimino [Sat, 16 Jul 2016 04:50:44 +0000 (04:50 +0000)]
Merge "sad_test: add some const to methods"
Pascal Massimino [Sat, 16 Jul 2016 04:41:46 +0000 (04:41 +0000)]
Merge "vp9_error_block_test: simplify fn wrapper generation"
Pascal Massimino [Sat, 16 Jul 2016 04:07:00 +0000 (21:07 -0700)]
sad_test: add some const to methods
Change-Id: I6f2481509b0aa94338ed6185f80c4a6b65532280
Pascal Massimino [Sat, 16 Jul 2016 03:56:10 +0000 (03:56 +0000)]
Merge "remove tuple from 'sad_test.cc'"
James Zern [Sat, 16 Jul 2016 03:27:45 +0000 (20:27 -0700)]
vp9_error_block_test: simplify fn wrapper generation
Change-Id: I1f1d396b9456e52e863c4c75f23c3d17420668b4
skal [Sat, 16 Jul 2016 01:50:23 +0000 (18:50 -0700)]
remove tuple from 'sad_test.cc'
+ general clean-up
Change-Id: Ib9dca3d1a3b7f0c1bedef2a26c9ff5ae1c289e8a
clang-format [Thu, 14 Jul 2016 05:26:28 +0000 (22:26 -0700)]
vp8: apply clang-format
Change-Id: I7605b6678014a5426ceb45c27b54885e0c4e06ed
James Zern [Thu, 14 Jul 2016 22:18:30 +0000 (15:18 -0700)]
add .clang-format, based on Google style
derived from clang-format 3.7.1; same as used in libaom
Change-Id: I8ea915a41d1f2ea3b0d4e4dab9ebc808e9116f11
James Bankoski [Sat, 16 Jul 2016 01:48:07 +0000 (01:48 +0000)]
Merge "addnoise : clear out static size for generated noise"
Jim Bankoski [Fri, 15 Jul 2016 22:52:45 +0000 (15:52 -0700)]
addnoise : clear out static size for generated noise
Change-Id: I5d4343f2da9cd4b01dd37be7a048d159fec109d1
Jim Bankoski [Fri, 15 Jul 2016 22:26:20 +0000 (15:26 -0700)]
configure: turn on all unused warnings by default
Change-Id: I7f6cb446cd3ac57ac39835cf065d9501a66acd5b
Jim Bankoski [Fri, 15 Jul 2016 22:04:57 +0000 (15:04 -0700)]
vp9_postproc.c : unused variable if not vp9_highbitdepth.
Change-Id: Ib89b128f23767934c40b5add3fcf9dbd875e82f9
James Bankoski [Fri, 15 Jul 2016 17:33:53 +0000 (17:33 +0000)]
Merge "postproc : fix function parameters for noise functions."
Jim Bankoski [Fri, 15 Jul 2016 15:27:34 +0000 (08:27 -0700)]
postproc : fix function parameters for noise functions.
Change-Id: I582b6307f28bfc987dcf8910379a52c6f679173c
James Zern [Fri, 15 Jul 2016 07:31:29 +0000 (07:31 +0000)]
Merge "variance_test partial clean-up"
skal [Thu, 14 Jul 2016 00:33:22 +0000 (17:33 -0700)]
variance_test partial clean-up
remove some (but not all yet!) tuple mis-use, and revamp the code a lot.
Factorize some common chores into MainTestClass.
Change-Id: Ia14f3924140e8545e4f10d0504475681baae8336
James Zern [Thu, 14 Jul 2016 19:48:51 +0000 (19:48 +0000)]
Merge "vp9_intrapred_test: follow-up cleanup"
James Zern [Thu, 14 Jul 2016 01:36:17 +0000 (18:36 -0700)]
gtest-all.cc: quiet an unused variable warning
under windows / mingw builds
Change-Id: I93f9a5df77cea0c28d4afb272abcde5a9732e355
skal [Wed, 13 Jul 2016 22:40:33 +0000 (15:40 -0700)]
vp9_intrapred_test: follow-up cleanup
address few comments from
ce050afaf3e288895c3bee4160336e2d2133b6ea
Change-Id: I5d8fc9dab35c4ee5ec3671134c4eef4ec241e309
James Bankoski [Wed, 13 Jul 2016 22:04:47 +0000 (22:04 +0000)]
Merge "postproc: noise style fixes."
Hui Su [Wed, 13 Jul 2016 21:30:11 +0000 (21:30 +0000)]
Merge "Revert "Eliminate isolated and small tail coefficients:""