Matthew Waters [Wed, 25 Aug 2021 06:59:40 +0000 (16:59 +1000)]
test: add tests for sdes-based RTP header extensions
mid, stream id and repaired stream id.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>
Matthew Waters [Wed, 25 Aug 2021 06:58:16 +0000 (16:58 +1000)]
rtpmanager: add support for RFC8852 (rid) RTP header extensions
Both for regular RID and for adding on a repaired (RTX) etc stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>
Matthew Waters [Wed, 25 Aug 2021 06:38:44 +0000 (16:38 +1000)]
rtpmanager: add support for writing RFC8843 (BUNDLE mid) RTP header extension
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1759>
Nicolas Dufresne [Wed, 16 Mar 2022 17:17:21 +0000 (13:17 -0400)]
codecs: av1: Fix state when we show existing keyframe
Showing existing keyframe have special meaning in AV1. All the references
frame will be refreshed with the original keyframe information. The refresh
process (7.20) is implemented by saving data from the frame_header into the
state. To fix this special case, load all the relevant information into the
frame_header.
As there is nothing happening in between this and the loading of the key-frame
into the state, this patch also remove the separate API function, using it
internally instead.
Fixes #1090
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1971>
Sebastian Dröge [Fri, 18 Mar 2022 17:33:00 +0000 (19:33 +0200)]
videocrop: Add support for v210
Like UYVY and similar formats this is rounding down to the start of the
previous macro-pixel to not mix up the different components.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1988>
Sebastian Dröge [Fri, 18 Mar 2022 17:06:05 +0000 (19:06 +0200)]
videocrop: Use GST_ROUND_DOWN_2 instead of re-defining a local version
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1988>
Sebastian Dröge [Fri, 18 Mar 2022 17:03:57 +0000 (19:03 +0200)]
videocrop: Rename PACKED_COMPLEX to PACKED_YVYU
It's not handling any kind of complex packed format, only formats that
are like YVYU.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1988>
Jakub Adam [Fri, 18 Mar 2022 12:04:59 +0000 (13:04 +0100)]
d3d11: Fix some typos
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1985>
Thibault Saunier [Fri, 18 Mar 2022 12:07:48 +0000 (09:07 -0300)]
validate: Totally hide media descriptor node types from the API
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1986>
Nirbheek Chauhan [Fri, 18 Mar 2022 08:13:00 +0000 (13:43 +0530)]
meson: Fix warning about build_root() and source_root()
```
../meson.build:384: WARNING: Project targeting '>= 0.60.0' but tried to use feature deprecated since '0.56.0': meson.build_root. use meson.project_build_root() or meson.global_build_root() instead.
../meson.build:385: WARNING: Project targeting '>= 0.60.0' but tried to use feature deprecated since '0.56.0': meson.source_root. use meson.project_source_root() or meson.global_source_root() instead.
...
WARNING: Deprecated features used:
* 0.56.0: {'meson.source_root', 'meson.build_root'}
```
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>
Nirbheek Chauhan [Fri, 18 Mar 2022 08:12:27 +0000 (13:42 +0530)]
meson: Bump all meson requirements to 0.60
Lots of new warnings ever since
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1934
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>
Nirbheek Chauhan [Fri, 18 Mar 2022 08:07:30 +0000 (13:37 +0530)]
openexr: Fix some warnings
```
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:46:24: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
46 | virtual Int64 tellg ();
| ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
23 | typedef IMATH_NAMESPACE::Int64 Int64;
| ^~~~~
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:47:32: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
47 | virtual void seekg (Int64 pos);
| ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
23 | typedef IMATH_NAMESPACE::Int64 Int64;
| ^~~~~
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:67:26: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
67 | Int64 MemIStream::tellg ()
| ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
23 | typedef IMATH_NAMESPACE::Int64 Int64;
| ^~~~~
../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:73:29: warning: ‘Imf_3_1::Int64’ is deprecated: use uint64_t [-Wdeprecated-declarations]
73 | MemIStream::seekg (Int64 pos)
| ^
In file included from ../subprojects/gst-plugins-bad/ext/openexr/gstopenexrdec.cpp:32:
/usr/include/OpenEXR/ImfInt64.h:23:32: note: declared here
23 | typedef IMATH_NAMESPACE::Int64 Int64;
| ^~~~~
```
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>
Nirbheek Chauhan [Fri, 18 Mar 2022 08:05:56 +0000 (13:35 +0530)]
subprojects/avtp: Update to latest avtp 0.2.0
Fixes some meson warnings too.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1977>
He Junyan [Fri, 18 Mar 2022 01:48:46 +0000 (09:48 +0800)]
codecparsers: av1parser: Fix a typo in FilmGrainParams comment.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1974>
Matthew Waters [Fri, 18 Mar 2022 09:43:24 +0000 (20:43 +1100)]
discoverer: chain up to parent finalize methods in all our types
Fixes a memory leak:
Direct leak of 32 byte(s) in 1 object(s) allocated from:
#0 0x5ac5cd in malloc /src/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:129:3
#1 0x1007007 in g_malloc /work/glib-2.72.0/_builddir/../glib/gmem.c:125:13
#2 0xf82e82 in g_data_set_internal /work/glib-2.72.0/_builddir/../glib/gdataset.c:464:8
#3 0xf833f7 in g_datalist_id_set_data_full /work/glib-2.72.0/_builddir/../glib/gdataset.c:670:3
#4 0xef81be in g_object_notify_queue_freeze /work/glib-2.72.0/_builddir/../gobject/gobject.c:295:7
#5 0xef79c6 in g_object_unref /work/glib-2.72.0/_builddir/../gobject/gobject.c:3632:16
#6 0x5e58bf in LLVMFuzzerTestOneInput /src/gstreamer/ci/fuzzing/gst-discoverer.c:132:5
#7 0x4dd1a2 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:611:15
#8 0x4dc98a in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:514:3
#9 0x4de6c4 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:809:5
#10 0x4dea29 in fuzzer::Fuzzer::Loop(std::__Fuzzer::vector<fuzzer::SizedFile, std::__Fuzzer::allocator<fuzzer::SizedFile> >&) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerLoop.cpp:857:3
#11 0x4ce4a0 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerDriver.cpp:912:6
#12 0x4f6f52 in main /src/llvm-project/compiler-rt/lib/fuzzer/FuzzerMain.cpp:20:10
#13 0x7f1c709980b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x240b2)
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1984>
Jakub Adam [Thu, 10 Mar 2022 16:37:26 +0000 (17:37 +0100)]
d3d11screencapturesrc: Allow capturing screen sub-area
Adds crop-x, crop-y, crop-width, crop-height properties specifying the
screen area to capture.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1932>
Nirbheek Chauhan [Tue, 15 Mar 2022 11:31:59 +0000 (17:01 +0530)]
webrtcbin: Warn when offer didn't intersect with transceiver caps
We were silently falling back to creating a recvonly offer if the caps
didn't intersect.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Tue, 15 Mar 2022 11:01:56 +0000 (16:31 +0530)]
webrtc-sendrecv: Fix create-answer caps negotiation
We need to parse the payload type map provided by the offer SDP and
set those values on the payloader, otherwise webrtcbin will create
a recvonly answer SDP and we won't send anything to the browser.
Fixed it for both C and Python sendrecv examples.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Tue, 15 Mar 2022 08:30:48 +0000 (14:00 +0530)]
webrtc_sendrecv.py: Add picture-id-mode to rtpvp8pay
This doesn't just make TWCC stats perform better, it also fixes
stuttery video playback in Chrome.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Sat, 5 Mar 2022 15:03:48 +0000 (20:33 +0530)]
webrtc_sendrecv.py: Print an error on unknown JSON message
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Sat, 5 Mar 2022 14:51:53 +0000 (20:21 +0530)]
webrtc_sendrecv.py: Add missing copyright headers
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Sat, 5 Mar 2022 14:36:37 +0000 (20:06 +0530)]
webrtc_sendrecv.py: Implement all negotiation modes
Earlier, the example only supported one negotiation mode:
* Browser client is running, gstreamer starts a call and sends offer
Now these three modes are also supported:
* Browser client is running, gstreamer starts a call and sends an
offer request
* gstreamer connects and waits for browser client to start a call and
send an offer
* gstreamer connects and waits for browser client to start a call and
send an offer request
The following features are still missing:
* Data channel support
* TWCC support + stats logging
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Tue, 1 Mar 2022 18:37:52 +0000 (00:07 +0530)]
webrtc_sendrecv.py: Make it executable
Why wasn't it already. Tired of typing 'python webrtc_sendrecv.py'.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Tue, 1 Mar 2022 18:33:29 +0000 (00:03 +0530)]
webrtc_sendrecv.py: Fix event loop usage for messages
Instead of creating a new loop, we should just be fetching the running
loop, then doing a blocking network call inside the callback, schedule
it on the event loop. This is what the C example does too.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Nirbheek Chauhan [Tue, 1 Mar 2022 18:23:32 +0000 (23:53 +0530)]
webrtc_sendrecv.py: Use default arg for server URL
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1864>
Matthew Waters [Fri, 18 Mar 2022 07:35:05 +0000 (18:35 +1100)]
ci/fuzzing: update glib version to 2.72.0
Fixes an issue where on configure, glib's internal gnulib was tripping
up the undefined behaviour sanitizer with a divide by 0.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1976>
Vivienne Watermeier [Mon, 17 Jan 2022 15:10:37 +0000 (16:10 +0100)]
glvideomixerelement: send translated navigation events to the relevant sink pads
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1495>
Vivienne Watermeier [Wed, 5 Jan 2022 18:33:06 +0000 (19:33 +0100)]
compositor: send translated navigation events to the relevant sink pads
Fixes #888
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1495>
Matthew Waters [Fri, 18 Mar 2022 02:16:42 +0000 (13:16 +1100)]
ci/fuzzling: fix oss-fuzz build
gst-plugins-base doesn't have a cairo option anymore.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1975>
Thibault Saunier [Mon, 7 Mar 2022 20:21:48 +0000 (17:21 -0300)]
validate: Cleanup ABI and make it ready to be stabilized this cycle
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Thibault Saunier [Mon, 7 Mar 2022 19:29:19 +0000 (16:29 -0300)]
validate: Introspect gst-validate-runner.c
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Thibault Saunier [Thu, 3 Mar 2022 01:21:40 +0000 (22:21 -0300)]
validate: Add getters for ValidateReports
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Wed, 2 Mar 2022 12:52:37 +0000 (12:52 +0000)]
validate: Change IssueId type to guint32
Which is a bit more bindings-friendly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Wed, 2 Mar 2022 10:54:17 +0000 (10:54 +0000)]
validate: ssim: Respect requested dump recurrence parameter
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Wed, 2 Mar 2022 10:27:10 +0000 (10:27 +0000)]
validate: Keep scenario alive enough when executing actions
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Wed, 2 Mar 2022 13:11:43 +0000 (13:11 +0000)]
validate: Introspection annotation cleanups
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Mon, 28 Feb 2022 10:58:41 +0000 (10:58 +0000)]
validate: Fix padding and constants
Without this the Rust -sys validate crate tests don't pass.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Mon, 28 Feb 2022 10:57:55 +0000 (10:57 +0000)]
validate: Expose all public headers in main header
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Philippe Normand [Mon, 28 Feb 2022 10:56:59 +0000 (10:56 +0000)]
validate: Fix pkgconfig name
Making it consistent with the reset of GStreamer. This also means that
anyone wanting to target -validate >= 1.22 needs to change the way they
link against it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1810>
Sangchul Lee [Tue, 15 Mar 2022 06:44:17 +0000 (15:44 +0900)]
rtpjitterbuffer: Fix invalid memory access in rtp_jitter_buffer_pop()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1973>
Vivienne Watermeier [Wed, 23 Feb 2022 16:39:18 +0000 (17:39 +0100)]
documentation: improve misleading wording
The documentation for several gst_*_writable_structure functions stated
that they would never return NULL, without making clear that the passed
object is required to be writable. This changes the wording in those
cases to make that requirement more clear.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1784>
Matthew Waters [Thu, 17 Mar 2022 02:36:25 +0000 (13:36 +1100)]
ccconverter: drop data with a warning if scratch buffers overflow
Instead of asserting which could bring down the entire application.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1972>
Hou Qi [Mon, 14 Mar 2022 08:19:33 +0000 (16:19 +0800)]
v4l2videodec: set frame duration according to framerate
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1953>
Philippe Normand [Thu, 10 Mar 2022 18:22:49 +0000 (18:22 +0000)]
uri: Build doubly-linked list by prepending items
As outlined in the API documentation, g_list_append() iterates over the whole
list, which can quickly introduce performance issues when the list becomes very
big, such as for data URIs for instance.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1909>
Philippe Normand [Tue, 8 Mar 2022 12:04:41 +0000 (12:04 +0000)]
typefind: Skip parsing of data URIs
Commit
a46ab2ced20d757e0e770d4de1edc3a152cc4f2f introduced a regression,
breaking typefinding for media content muxed in mp4 container and serialized to
data URIs. For this case it doesn't make sense to look for a file extension, so
skip URI parsing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1909>
Corentin Noël [Tue, 15 Mar 2022 13:00:06 +0000 (14:00 +0100)]
basesink: Fix annotations
We should annotate the Class and not the object itself.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1965>
Corentin Noël [Tue, 15 Mar 2022 12:59:16 +0000 (13:59 +0100)]
gst-plugins-base: Fix several annotations
Add annotations for virtual methods when possible.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1965>
Corentin Noël [Tue, 15 Mar 2022 12:57:11 +0000 (13:57 +0100)]
validate: Fix typo in get_reports
Return without s isn't taken into account for the introspection.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1965>
Tim-Philipp Müller [Tue, 15 Mar 2022 13:49:09 +0000 (13:49 +0000)]
rtspsrc: proxy new "add-reference-timestamp-meta" property from rtpjitterbuffer
When syncing to an RFC7273 clock this will add the original
reconstructed reference clock timestamp to buffers in form
of a GstReferenceTimestampMeta.
This is useful when we want to process or analyse data based
on the original timestamps untainted by any local adjustments,
for example reconstruct AES67 audio streams with sample accuracy.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1964>
Tim-Philipp Müller [Tue, 15 Mar 2022 11:56:28 +0000 (11:56 +0000)]
rtpbin: proxy new "add-reference-timestamp-meta" property from rtpjitterbuffer
When syncing to an RFC7273 clock this will add the original
reconstructed reference clock timestamp to buffers in form
of a GstReferenceTimestampMeta.
This is useful when we want to process or analyse data based
on the original timestamps untainted by any local adjustments,
for example reconstruct AES67 audio streams with sample accuracy.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1964>
Tim-Philipp Müller [Tue, 15 Mar 2022 01:35:17 +0000 (01:35 +0000)]
rtpjitterbuffer: add "add-reference-timestamp-meta" property
When syncing to an RFC7273 clock this will add the original
reconstructed reference clock timestamp to buffers in form
of a GstReferenceTimestampMeta.
This is useful when we want to process or analyse data based
on the original timestamps untainted by any local adjustments,
for example reconstruct AES67 audio streams with sample accuracy.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1964>
Philippe Normand [Fri, 11 Mar 2022 17:02:55 +0000 (17:02 +0000)]
wpe: Reintroduce persistent WebContext
A WebContext leak was introduced in MR
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2252.
If we wanted one WebContext per WebView we should also unref the
WebKitWebContext when destroying the WebView.
This patch reintroduces the persistent WebContext, initially part of
https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1484.
Fixes #1084
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1933>
Tim-Philipp Müller [Thu, 16 Dec 2021 18:41:38 +0000 (18:41 +0000)]
opusenc: change default bitrate-type from cbr to constrained-vbr
Which is the default in libopus itself as well, with a comment
that constrained-vbr is considered "safer for real-time use".
Unclear why CBR was the default in the first place.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1451>
Mathieu Duponchelle [Tue, 15 Mar 2022 23:05:19 +0000 (00:05 +0100)]
webrtcbin: fix deadlock when setting up FEC encoder
We bind transceivers' fec_percentage property to the FEC encoder
percentage property, and with the binding bidirectional a deadlock
was introduced by the latest changes from !1762:
We take hold of the transceiver's object lock, then add the binding
and set the property to its initial value on the encoder, which causes
set_property to deadlock in the transceiver when the binding kicks in.
Changing the binding type to DEFAULT (source to target) is enough
to address the deadlock and still serves the original intent.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1967>
MGlolenstine [Tue, 15 Mar 2022 15:01:39 +0000 (15:01 +0000)]
doc: handy-elements: fix audiotestsrc description
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1966>
Sangchul Lee [Thu, 10 Mar 2022 10:22:52 +0000 (19:22 +0900)]
webrtcbin: Check data channel transport for notifying 'ice-gathering-state'
Previously, it did not care about data channel's. It is fixed by adding
some conditions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1957>
Nirbheek Chauhan [Tue, 15 Mar 2022 07:27:49 +0000 (12:57 +0530)]
rtpbuffer: The out args for rtp extension data are optional
The code checks that these are != NULL before dereferencing them.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1962>
Hou Qi [Tue, 15 Mar 2022 01:49:59 +0000 (09:49 +0800)]
v4l2videodec: safely retrun from video_dec_loop with stream unlock
This is to avoid decoder hang when doing trick play between
different resolutions.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1960>
Sebastian Dröge [Mon, 14 Mar 2022 11:59:37 +0000 (13:59 +0200)]
rtpjitterbuffer: Improve accuracy of RFC7273 clock time calculations
Previously the result of the calculations included inaccuracies caused
by the NTP clock estimation, which caused the timestamps to jitter
+/- 1/clockrate.
By reorganizing the calculations it is possible to get rid of this
inaccuracy and calculate deterministic and exact packet timestamps based
on the actual NTP clock as long as the estimation is not off by more
than 2**31 clockrate units.
The only remaining inaccuracy that is introduced now is caused by the
conversion from the NTP clock to the pipeline clock.
Also split up debug output, demote many messages to the trace debug
level and output more intermediate results.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1955>
Nirbheek Chauhan [Mon, 14 Mar 2022 06:59:04 +0000 (12:29 +0530)]
twcc: Add some logging to debug TWCC feedback
This should allow people to debug when TWCC feedback is not enabled
because they haven't set the extmap in the caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1952>
Nirbheek Chauhan [Mon, 14 Mar 2022 08:15:36 +0000 (13:45 +0530)]
twcc: Note that packet-loss-pct can count reordering as loss
This is difficult to encounter in ordinary networks, but is
encountered when using tc-netem to add random delays to packets, and
also when your UDP stream is bonded over multiple links with varying
characteristics.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1952>
Seungha Yang [Sun, 13 Mar 2022 16:19:53 +0000 (01:19 +0900)]
nvcodec: Move CUDA <-> GL, D3D11, NVMM copy function to utils
This method can be used in other elements as well.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1945>
Seungha Yang [Fri, 11 Mar 2022 16:12:25 +0000 (01:12 +0900)]
nvh265sldec: Add support for delayed output
Delay 4 frames in case of non-live to improve throughput
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>
Seungha Yang [Sat, 12 Mar 2022 12:54:45 +0000 (21:54 +0900)]
h265decoder: Add support for delayed output
Functionally identical to the other decoder baseclasses.
Delayed output can improve throughput depending on decoding APIs.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>
Seungha Yang [Fri, 11 Mar 2022 15:53:04 +0000 (00:53 +0900)]
h265decoder: Update documentation
Sync up with other baseclasses
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>
Seungha Yang [Fri, 11 Mar 2022 19:45:22 +0000 (04:45 +0900)]
h265decoder: Drain decoder on new_sequence()
Holding previously decoded but not outputted pictures even after
new_sequence is not a safe approach in various aspect.
However, we cannot drain out DPB on new_sequence() unconditionally,
because there is a case where decoder should drop decoded pictures
if NoOutputOfPriorPicsFlag is set.
To detect NoOutputOfPriorPicsFlag before the new_sequence() call,
this patch splits decoding process into two path, one for nal unit parsing
in order to detect NoOutputOfPriorPicsFlag and then each nal unit
will be decoded.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>
Seungha Yang [Fri, 11 Mar 2022 18:15:48 +0000 (03:15 +0900)]
h265decoder: Remove unused pts variable
We can know timestamp from associated GstVideoCodecFrame
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1937>
Bastien Nocera [Thu, 10 Mar 2022 09:25:53 +0000 (10:25 +0100)]
convertframe: Add support for GL-memory backend GstFrame input
Add "gldownload" early in the pipeline so that GL-memory backed raw
frames can be downloaded and processed on the CPU.
Closes: #1073
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1916>
Havard Graff [Fri, 11 Aug 2017 14:33:23 +0000 (16:33 +0200)]
rtprtxsend: don't require clock-rate in caps
For multiplexing, the rtpstreams you are multiplexing might not use
the same clock-rate.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1881>
Havard Graff [Fri, 4 Nov 2016 10:47:20 +0000 (11:47 +0100)]
rtprtxsend: don't start the task unless we are doing rtx
The rtxsend element can do pass-through when not enabled (no pt-map set)
and in those cases there is no point in starting an additional task
that does absolutely nothing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1880>
Xavier Claessens [Mon, 14 Mar 2022 12:56:16 +0000 (08:56 -0400)]
Bump Meson requirement to >=0.60.0
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1934>
Xavier Claessens [Fri, 11 Mar 2022 23:08:14 +0000 (18:08 -0500)]
Meson: Set install_tag on some files
Meson tries to guess the tag (runtime, devel, etc) for every installed
file, but it cannot guess them all. There is a list at the end of
meson-log.txt of files we need to tag manually.
See https://mesonbuild.com/Installing.html#installation-tags.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1934>
Havard Graff [Mon, 27 Jun 2016 12:28:06 +0000 (14:28 +0200)]
rtprtxreceive: add ssrc-map property
Mirroring the rtxsend, this allows the application to "pre-map" the
retransmission-ssrcs to the "real" ssrc, if this information is known.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1878>
Carlos Rafael Giani [Sun, 8 Sep 2019 13:54:08 +0000 (15:54 +0200)]
mpg123: Add gapless playback support
Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1028>
Sebastian Dröge [Tue, 5 Oct 2021 10:43:50 +0000 (13:43 +0300)]
avaudenc: Add support for AV_PKT_DATA_SKIP_SAMPLES side data
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1028>
Carlos Rafael Giani [Tue, 10 Sep 2019 15:30:07 +0000 (17:30 +0200)]
avauddec: Add clipping meta support for gapless playback
Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1028>
Carlos Rafael Giani [Sat, 7 Sep 2019 17:15:42 +0000 (19:15 +0200)]
mpegaudioparse: Support gapless playback
Gapless playback is handled by adjusting buffer timestamps & durations
and by adding GstAudioClippingMeta.
Support for "Frankenstein" streams (= poorly stitched together streams)
is also added, so that gapless playback support doesn't prevent those
from being properly played.
Co-authored-by: Sebastian Dröge <sebastian@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1028>
Jan Alexander Steffens (heftig) [Fri, 11 Mar 2022 09:32:42 +0000 (10:32 +0100)]
deinterlace: scalerbob: Reduce latency to 0
We only need the current field, just like `linear`.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1926>
Vivia Nikolaidou [Sat, 12 Mar 2022 15:13:48 +0000 (17:13 +0200)]
yadif: Fix CHECK macro for YUY2 format
Used to make comb artifacts for videotestsrc pattern=ball for YUY2
format only (not AYUV).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1938>
Seungha Yang [Sat, 12 Mar 2022 15:17:48 +0000 (00:17 +0900)]
nvenc: Fix deadlock because of too strict buffer pool size
The pool size might need to be larger than encoding surface pool size.
Also, because we always copy input frame into internal CUDA memory,
there's no reason to restrict max size of buffer pool.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1939>
He Junyan [Sat, 12 Mar 2022 02:31:13 +0000 (10:31 +0800)]
va: Fix a regression because of "Invert video codec frame dependency".
1. Always set the according GstVaH264EncFrame pointer when GstVideoCodecFrame
pointer is assigned, which can make the logic safe.
2. Fix the forgotten change in _sort_by_frame_num. Its input pointer now is
GstVideoCodecFrame type.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1935>
Seungha Yang [Tue, 8 Mar 2022 18:45:18 +0000 (03:45 +0900)]
codecs: Rename picture clear functions
Our convention for clear method is gst_clear_foo_bar().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1897>
Andoni Morales Alastruey [Fri, 11 Mar 2022 10:27:15 +0000 (11:27 +0100)]
windows: increase the timeout to create the windows docker image
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1912>
Andoni Morales Alastruey [Wed, 9 Mar 2022 22:53:25 +0000 (23:53 +0100)]
ci: force a new windows image to update cerbero's bootstrap
See:https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/743#note_1270646
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1912>
Seungha Yang [Fri, 11 Mar 2022 14:20:26 +0000 (23:20 +0900)]
nvh265sldec: Always fill SPS/PPS related parameters
Address compare was not a valid approach since it works
only if SPS/PPS id are changed. Otherwise it will always point to
the same address of member variables of h265parser.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1931>
Damian Hobson-Garcia [Thu, 10 Mar 2022 08:03:45 +0000 (17:03 +0900)]
doc: New cropping parameters added to v4l2src
v4l2src add several new parameters to control cropping of
the captured video stream. Update the doc cache to reflect
this.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1089>
Damian Hobson-Garcia [Fri, 15 Oct 2021 09:33:50 +0000 (18:33 +0900)]
examples: v4l2: Add v4l2src crop example
Add a simple utility to illustrate how to set input cropping on v4l2src.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1089>
Damian Hobson-Garcia [Thu, 14 Oct 2021 08:22:19 +0000 (17:22 +0900)]
v4l2src: Add support for cropping at capture source input
Add properties to control input cropping in the V4L2 device.
The input cropping is applied before composing the result to the
capture buffer. By default the capture size will be set to the same
size as the crop region, but it can be scaled to a different output
frame size if supported by the V4L2 device.
If scaling is not supported, the cropped image will
be composed as is into the top-left corner of the capture buffer.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1089>
Damian Hobson-Garcia [Wed, 13 Oct 2021 08:33:12 +0000 (17:33 +0900)]
v4l2object: Add function to get crop regions from device
Get the current crop bounding region from the V4L2 device so
that it can be provided to applications and used to validate
crop settings. Also make the default crop region available so
that it can be used to reset the crop when appropriate.
Uses the selection API when available with fallback to the crop
API for older kernels.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1089>
Damian Hobson-Garcia [Thu, 30 Sep 2021 08:56:56 +0000 (17:56 +0900)]
v4l2object: rename crop function to reflect its usage
The gst_v4l2_object_set_crop() is used for removing buffer
alignment padding. Give it a name that better reflects
that usage. This helps to distinguish from cropping of the
input image (e.g. cropping at the image sensor on a captre
device), which can be unrelated to the memory buffer padding,
especially if scaling is involved.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1089>
Jan Schmidt [Tue, 1 Mar 2022 16:45:48 +0000 (03:45 +1100)]
playbin3: Remove stale code
Remove now-unused get_stream_type_for_event() function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Edward Hervey [Fri, 21 Jan 2022 15:23:38 +0000 (16:23 +0100)]
decodebin3: Reset parsebin when new caps arrive
Check if parsebin can handle the new caps, and if not reset it so that it can
reconfigure itself for the new stream format.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Edward Hervey [Wed, 9 Mar 2022 09:15:08 +0000 (10:15 +0100)]
decodebin3: Convert checks to assertions
"decodebin.input" is never resetted and should always be present, therefore make
it an assertion check
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Edward Hervey [Fri, 21 Jan 2022 13:52:07 +0000 (14:52 +0100)]
parsebin: Implement ACCEPT_CAPS handling
The default query handler would go through typefind, which by default accepts
any CAPS. But once configured, parsebin can't reconfigure itself, it should
therefore pass through the ACCEPT_CAPS query to the first element after
typefind (if any).
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Jan Schmidt [Mon, 17 Jan 2022 18:48:08 +0000 (05:48 +1100)]
playbin3: Hold playbin lock on pad-added
Take the playbin lock when accessing the combiner
to add a new pad to link to. Fixes races against
streams-selected messages triggering reconfiguration.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Jan Schmidt [Mon, 17 Jan 2022 15:52:47 +0000 (02:52 +1100)]
playbin3: Reconfigure on streams-selected message.
Don't reconfigure outputs when the select-streams
event is sent from the app, as the selection may
not take effect for some time. Instead, wait
for the pipeline to confirm the new set of
selected streams when it sends the message.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Jan Schmidt [Wed, 10 Nov 2021 16:20:23 +0000 (03:20 +1100)]
playsink: Fix reconfiguration after removing text_sink
If we previously had subtitles coming in, the video
may be chained through a text overlay block. Before,
the code would end up trying to link pads that were
already linked and video would not get reconnected
properly.
To fix that, make sure that the candidate
pads are actually unlinked first. If a textoverlay
is present and no longer needed, it will be cleaned
up later in the reconfiguration sequence.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1900>
Jan Schmidt [Fri, 6 Aug 2021 09:27:02 +0000 (19:27 +1000)]
playsink: Complete reconfiguration on pad release.
Requesting a new pad can start a reconfiguration cycle, where
playsink will block all input pads and wait for data on them
before doing internal reconfiguration. If a pad is released,
that reconfiguration might never trigger because it's now waiting
for a pad that doesn't exist any more.
In that case, complete the reconfiguration on pad release.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1180>
Seungha Yang [Fri, 11 Mar 2022 10:32:59 +0000 (19:32 +0900)]
h264decoder: Fix invalid memory access
gst_h264_dpb_needs_bump() can be called with null picture
in case of live
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1928>
Branko Subasic [Thu, 10 Feb 2022 07:01:02 +0000 (08:01 +0100)]
rtponviftimestamp: add support for using reference timestamps
Make it posible to configure the element to obtain the timestamps from
reference timestamp meta data instead of using the ntp-offset property,
or estimating its own offset. Currently the only time format supported
is "timestamp/x-unix", i.e. UTC time expressed in the unix time epoch.
In addition the custom event GstNtpOffset has been renamed to
GstOnvifTimestamp, to reflect that it is not necessarily used to convey
the ntp-offset. As a consequence we had to modify a couple of files in
the rtsp-server as well.
Fixes #984
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1683>