contrib/qtwebsockets.git
10 years agoAdd null pointer checks
Kurt Pattyn [Fri, 1 Nov 2013 22:51:36 +0000 (23:51 +0100)]
Add null pointer checks

Change-Id: I3582e4ebc6aa275a10dd03b9189cafdc72dc236f
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoReplace qGreater with std::greater
Kurt Pattyn [Fri, 1 Nov 2013 22:13:27 +0000 (23:13 +0100)]
Replace qGreater with std::greater

Change-Id: I1c2e2f14bbbd1dfc8dc30d4a0cdff7ded0222113
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRemove ignoreSslErrors
Kurt Pattyn [Fri, 1 Nov 2013 21:48:39 +0000 (22:48 +0100)]
Remove ignoreSslErrors

Change-Id: I12dd46acb1bd7f71cf6df0eb2fae62bb3b655369
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoClose namespace at end of file
Kurt Pattyn [Fri, 1 Nov 2013 21:11:11 +0000 (22:11 +0100)]
Close namespace at end of file

Change-Id: Idc899e8081e31c3ba93893dc23abd89b4691f6e7
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRename autobahn to manual
Kurt Pattyn [Fri, 1 Nov 2013 20:27:39 +0000 (21:27 +0100)]
Rename autobahn to manual

Change-Id: I34bc23f60ee69c4005495defd22d2079a5206426
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRemove websocketcorsauthenticator tests from non-developer builds
Kurt Pattyn [Fri, 1 Nov 2013 20:17:40 +0000 (21:17 +0100)]
Remove websocketcorsauthenticator tests from non-developer builds

Change-Id: Ifadd89c4e51367b2bf04852bcb1d1d856543069e
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRename autobahn to manual
Kurt Pattyn [Fri, 1 Nov 2013 19:56:16 +0000 (20:56 +0100)]
Rename autobahn to manual

Change-Id: I82236190d8af0ef75c605ac662d217c2f3d94dc6
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRemove unneeded files
Kurt Pattyn [Fri, 1 Nov 2013 17:55:23 +0000 (18:55 +0100)]
Remove unneeded files

Change-Id: Iff3e9b3abdc3e9159ec75ca5466aad6f93314aa4
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdd correct license headers
Kurt Pattyn [Fri, 1 Nov 2013 17:17:43 +0000 (18:17 +0100)]
Add correct license headers

Change-Id: I789cd780697aedbca7a90a5991df00b2c7e9ec98
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRefine doc generation
Kurt Pattyn [Fri, 1 Nov 2013 16:35:16 +0000 (17:35 +0100)]
Refine doc generation

Change-Id: I9da90086c63b88a5664f241da2fa9687c3882ddf
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoReplace int with qintptr for socket descriptor
Kurt Pattyn [Fri, 1 Nov 2013 13:58:59 +0000 (14:58 +0100)]
Replace int with qintptr for socket descriptor

Change-Id: Ie554b90a62c504e3ef54fd2d36e93806f4871f81
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoInclude qml example on when quick is available
Kurt Pattyn [Fri, 1 Nov 2013 13:10:14 +0000 (14:10 +0100)]
Include qml example on when quick is available

Change-Id: I35956c27253819ddacbb2abd403b06f97e57bd31
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdd functionality to ignore ssl errors
Kurt Pattyn [Fri, 1 Nov 2013 12:12:28 +0000 (13:12 +0100)]
Add functionality to ignore ssl errors

Change-Id: I81248b9af104c0b3d37c9cfcef250a102f4b1d32
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoImplement of secure web sockets
Kurt Pattyn [Thu, 31 Oct 2013 08:31:25 +0000 (09:31 +0100)]
Implement of secure web sockets

Change-Id: I1f96d5e4e327eae211fd6b458168e1f7607e2dcf
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoMark line as not relevant for code coverage
Kurt Pattyn [Sat, 19 Oct 2013 20:47:59 +0000 (22:47 +0200)]
Mark line as not relevant for code coverage

Change-Id: Id82bed1b3fa0ac0e48239894ad94b4d3778ee800
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdd check for host() method
Kurt Pattyn [Sat, 19 Oct 2013 17:31:02 +0000 (19:31 +0200)]
Add check for host() method

Change-Id: I12d6761232193c62888681bb71ee0d5c6df9d3d2
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRemove CXX debug flags from project file
Kurt Pattyn [Sat, 19 Oct 2013 17:19:48 +0000 (19:19 +0200)]
Remove CXX debug flags from project file

The debug flags are normally set by the Qt build environment.

Change-Id: Icc61c7d5aeed7c73ac6c947d31d9eed71c02a606
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRemove const from return value of operator =
Kurt Pattyn [Sat, 19 Oct 2013 12:39:49 +0000 (14:39 +0200)]
Remove const from return value of operator =

Change-Id: I062756f8b337afee0b4f04bd6631d83bc560a607
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoPut assignment on separate line to avoid compiler optimization
Kurt Pattyn [Sat, 19 Oct 2013 12:33:24 +0000 (14:33 +0200)]
Put assignment on separate line to avoid compiler optimization

Change-Id: I981c2caba0d6a96ee54226ec001de6da8df9e5c2
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdd flag to not optimize when in debug mode
Kurt Pattyn [Sat, 19 Oct 2013 12:25:25 +0000 (14:25 +0200)]
Add flag to not optimize when in debug mode

Change-Id: Iefaf4f6361042b3c3e5fb9bc620228e3e9cd3cbd
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdd test for constructor and assignment operator
Kurt Pattyn [Sat, 19 Oct 2013 11:19:04 +0000 (13:19 +0200)]
Add test for constructor and assignment operator

Change-Id: I4a475ca6e173a7102d465d821f1427d0b6d206d0
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRemove QtWebSockets from include directives
Kurt Pattyn [Tue, 15 Oct 2013 12:04:43 +0000 (14:04 +0200)]
Remove QtWebSockets from include directives

Having QtWebSockets/ in front of the includes, results in a failing Windows build.

Change-Id: I3b7f9ee3f1f06d4588a25a02324d1e1f0e4fde81
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoReplaced getter methods of HandshakeResponse to be in line with Qt
Kurt Pattyn [Sun, 13 Oct 2013 19:27:50 +0000 (21:27 +0200)]
Replaced getter methods of HandshakeResponse to be in line with Qt

Change-Id: I23d9e75413c04a8a2f43ea0b940a0bab33d8d8de
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoCompleted unit tests for handshake request
Kurt Pattyn [Sun, 13 Oct 2013 15:16:56 +0000 (17:16 +0200)]
Completed unit tests for handshake request

Change-Id: I9558c0244e2285e7dc266bfcb3c51887fb7200d7
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoAdded unit tests for CorsAuthenticator
Kurt Pattyn [Sun, 13 Oct 2013 13:54:27 +0000 (15:54 +0200)]
Added unit tests for CorsAuthenticator

Change-Id: Id87b72bd6980aba5c134d7bfa7abf87d24e9a0ee
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoAdded remaining tests
Kurt Pattyn [Sat, 12 Oct 2013 18:59:40 +0000 (20:59 +0200)]
Added remaining tests

Change-Id: I006e84a06eb0315e81cdb389612f0be7ae494bd8
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoCompleted websocketframe unit tests
Kurt Pattyn [Sun, 13 Oct 2013 13:30:33 +0000 (15:30 +0200)]
Completed websocketframe unit tests

Replaced tab with space

Change-Id: Ifc47621069870123b5db458a1ba2bb0d66a5419d
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoCall other mask function instead of implementing it twice
Kurt Pattyn [Sat, 12 Oct 2013 19:00:17 +0000 (21:00 +0200)]
Call other mask function instead of implementing it twice

Change-Id: Ib196422ed7de2da420010e89347c98a02affef9a
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoRenamed getter methods to be Qt compliant
Kurt Pattyn [Sun, 13 Oct 2013 11:01:40 +0000 (13:01 +0200)]
Renamed getter methods to be Qt compliant

Renamed all getXXX() methods in QWebSocketFrame to XXX() methods to be Qt compliant.

Change-Id: Iea47bcf1772a755f303065ff12d07b0ba99d4aac
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoRenamed getters in HandshakeRequest to comply with Qt
Kurt Pattyn [Sun, 13 Oct 2013 14:03:02 +0000 (16:03 +0200)]
Renamed getters in HandshakeRequest to comply with Qt

Renamed all getXXX() methods by XXX() methods.

Change-Id: I54f52eb5dfc7342b7aecafb3ec65aa54e7b20d13
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoExport mask functions to be usable for unit testing
Kurt Pattyn [Sat, 12 Oct 2013 19:01:17 +0000 (21:01 +0200)]
Export mask functions to be usable for unit testing

Change-Id: If72486c4543240448a8abdfa3cc7e96331ed0b05
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdapted auto.pro to include websocketframe unit test
Kurt Pattyn [Sun, 13 Oct 2013 10:26:56 +0000 (12:26 +0200)]
Adapted auto.pro to include websocketframe unit test

Change-Id: Ife8486a480d2a56a77d96ca6d331994d8f7ea0a1
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded unittests for QWebSocketProtocol
Kurt Pattyn [Sat, 12 Oct 2013 19:02:02 +0000 (21:02 +0200)]
Added unittests for QWebSocketProtocol

Added copyright headers

Change-Id: Idef8307ef80db9e5805b880514bd3a9c18ddf125
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded TODO explaining some optimizations
Kurt Pattyn [Sun, 13 Oct 2013 10:15:07 +0000 (12:15 +0200)]
Added TODO explaining some optimizations

Moved documentation from .h to .cpp
Export QWebSocketFrame class for unit testing
Added unit tests for web socket frames

Change-Id: I824da86fed37fbcd1f5671a21467af7a66f5c019
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded const to local variable
Kurt Pattyn [Sun, 13 Oct 2013 10:13:16 +0000 (12:13 +0200)]
Added const to local variable

Change-Id: I3f62335945ce21ba950328473a2ea180c1ca6ae8
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agomake use of the new Q_NULLPTR keyword & shorten if(ptr) conditions
Steven Ceuppens [Thu, 10 Oct 2013 14:05:54 +0000 (16:05 +0200)]
make use of the new Q_NULLPTR keyword & shorten if(ptr) conditions

Change-Id: I4a71909134032d10b398ede74c431964bce7d675
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded checks for valid control frames
Kurt Pattyn [Thu, 10 Oct 2013 19:12:27 +0000 (21:12 +0200)]
Added checks for valid control frames

Also added extra checks on signals
Added extra comments
Cleaned up superfluous TODOs

Change-Id: I8ec760f0984bee4bd4cc757ce3ef6d7ed1c01102
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoAdded boundary checks on string lists
Kurt Pattyn [Thu, 10 Oct 2013 19:10:57 +0000 (21:10 +0200)]
Added boundary checks on string lists

Change-Id: I366ed84e54ebd49d0a1a202e5131eab4b486b4c5
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoImmediately stop processing after reception of a control frame
Kurt Pattyn [Thu, 10 Oct 2013 19:10:28 +0000 (21:10 +0200)]
Immediately stop processing after reception of a control frame

Change-Id: Ifdd9db4bb251d9a58a0739ce269591b2d9438bf4
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoChanged expected failure with expected success
Kurt Pattyn [Sun, 6 Oct 2013 11:20:24 +0000 (13:20 +0200)]
Changed expected failure with expected success

Due to an issue that has been solved in Qt, all tests for non-character codes should now succeed
This change also contains some minor bug fixes for incorrect signatures in signal-slot connections

Change-Id: I6d8de9c40026465ffde58c9cbe848ce8871008f6
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoCommented out non-implemented method
Kurt Pattyn [Sun, 6 Oct 2013 10:40:55 +0000 (12:40 +0200)]
Commented out non-implemented method

Change-Id: Ifd54d93abb2a33c23b59621bed1101493e6c40ba
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded module QtWebSockets to documentation
Kurt Pattyn [Sat, 5 Oct 2013 20:56:26 +0000 (22:56 +0200)]
Added module QtWebSockets to documentation

Change-Id: Ic1707be7fed88c63b770d41e3dc600da545e4005
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoReplaced tabs by spaces
Kurt Pattyn [Sat, 5 Oct 2013 20:55:47 +0000 (22:55 +0200)]
Replaced tabs by spaces

Change-Id: If12cafe55ac10d312228840cdce08818485594bd
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded core to Qt
Kurt Pattyn [Sat, 5 Oct 2013 17:37:20 +0000 (19:37 +0200)]
Added core to Qt

Change-Id: I122ff3f018ab1df7b93cf3ae817dbd91955e7cbe
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded ordered to CONFIG
Kurt Pattyn [Sat, 5 Oct 2013 17:37:58 +0000 (19:37 +0200)]
Added ordered to CONFIG

Added conditional include

Change-Id: I0472942b97485ee9c04d6211d77715389d4b70e7
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoChanged the way SUBDIRS is configured
Kurt Pattyn [Sat, 5 Oct 2013 17:38:46 +0000 (19:38 +0200)]
Changed the way SUBDIRS is configured

Change-Id: Ia92805075d2187d51ea4f653a6e898754b2c6517
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoReplaced qStableSort with std::sort
Kurt Pattyn [Sat, 5 Oct 2013 17:40:45 +0000 (19:40 +0200)]
Replaced qStableSort with std::sort

Changed tab to 4 spaces

Change-Id: Ifb1a4ce4926da081d653b749478f1b494809b068
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded clarifying comment
Kurt Pattyn [Sat, 5 Oct 2013 18:32:52 +0000 (20:32 +0200)]
Added clarifying comment

Change-Id: Idb41dce15b8fbeccf26df3d69722685d5554ad1c
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded tests with no close code and/or close reason
Kurt Pattyn [Sat, 5 Oct 2013 18:37:11 +0000 (20:37 +0200)]
Added tests with no close code and/or close reason

Change-Id: Ic908137ad5c76972a0e9515586f5af4671f47fdd
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoChanged module name to QtWebSockets
Kurt Pattyn [Sat, 5 Oct 2013 19:38:31 +0000 (21:38 +0200)]
Changed module name to QtWebSockets

Change-Id: Ib404634017129c3639c1e96685306e333ad73686
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdapted documentaton
Kurt Pattyn [Sat, 5 Oct 2013 19:39:37 +0000 (21:39 +0200)]
Adapted documentaton

Change-Id: I6ffcc86b9bbc6efe27b7005a3df6f62f0d1a9293
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded some tests
Kurt Pattyn [Sat, 5 Oct 2013 19:39:51 +0000 (21:39 +0200)]
Added some tests

Change-Id: I598de5c955eb8c5224035fd9c2469b132c39d06c
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoRenamed test methods to be consistent
Kurt Pattyn [Sat, 5 Oct 2013 18:35:12 +0000 (20:35 +0200)]
Renamed test methods to be consistent

Change-Id: I1ce7385817db74879701ddb628aab4ea6c5ebd56
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoCheck on ending '?' before adding a '?' (led to an internal server error of Autobahn)
Kurt Pattyn [Sat, 5 Oct 2013 13:24:16 +0000 (15:24 +0200)]
Check on ending '?' before adding a '?' (led to an internal server error of Autobahn)

Change-Id: Id51b6ae1eabfda7e0daa3eaa64be93bc6140afbb
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoUpdate unit tests
Steven Ceuppens [Mon, 30 Sep 2013 08:43:18 +0000 (10:43 +0200)]
Update unit tests

Private unittests get now build with:

$qmake -config private_tests

Change-Id: I5fb234e9c6f86cf2d740a604923eb8a501699d44
Reviewed-by: Sergio Ahumada <sergio.ahumada@digia.com>
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoUpdate to fix minor compiler warnings
Steven Ceuppens [Mon, 30 Sep 2013 09:10:01 +0000 (11:10 +0200)]
Update to fix minor compiler warnings

Change-Id: I9b8e4cb5ad174faaf7d8c32a00a0b4b4c66edb68
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoUncommented data processor from auto.pro
Kurt Pattyn [Sun, 29 Sep 2013 18:53:22 +0000 (20:53 +0200)]
Uncommented data processor from auto.pro

Change-Id: Ia04d205ecf5fa86b7be577536c77414cfb06ebbc
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoInclude qwebsocketdataprocessor iso dataprocessor
Kurt Pattyn [Sun, 29 Sep 2013 18:52:58 +0000 (20:52 +0200)]
Include qwebsocketdataprocessor iso dataprocessor

Change-Id: Ic522190a929c8f86ab364cc52cc0afeadb0fcc44
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agomoved class to separate file
Steven Ceuppens [Sun, 29 Sep 2013 18:41:29 +0000 (20:41 +0200)]
moved class to separate file

As QWebSocketFrame is quite big, i moved it into its own file, for futher implementation:wq

Change-Id: Iadf51323d5e8151c8345057614f4c49f81e626b1
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoupdate _global file, to match Qt default
Steven Ceuppens [Sun, 29 Sep 2013 17:56:37 +0000 (19:56 +0200)]
update _global file, to match Qt default

Change-Id: I4bbf6bd60abd93bd18947b8d2a9d42784aaea10b
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoremoved unused includes
Steven Ceuppens [Sun, 29 Sep 2013 17:47:27 +0000 (19:47 +0200)]
removed unused includes

Change-Id: I7b934942c77b1da566acf77dc46521975c3ecba4
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agowhitesapce updates
Steven Ceuppens [Sun, 29 Sep 2013 17:51:49 +0000 (19:51 +0200)]
whitesapce updates

Change-Id: I3e7feb9123868c558e5500c2142774df54afdfc6
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoupdate class & filenames
Steven Ceuppens [Sun, 29 Sep 2013 17:21:55 +0000 (19:21 +0200)]
update class & filenames

Change-Id: Idd2caa074f2f3feba99714bf6927ca879809ad47
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoremove declaration, only Qt5 will be supported
Steven Ceuppens [Sun, 29 Sep 2013 17:22:54 +0000 (19:22 +0200)]
remove declaration, only Qt5 will be supported

Change-Id: I4e1c4b0948aca2fa76b2ebec2163ed1fc82d8154
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoreorganized unittests & added module pri
Steven Ceuppens [Sun, 29 Sep 2013 16:30:25 +0000 (18:30 +0200)]
reorganized unittests & added module pri

Change-Id: Ib1aa45f7cc07ea4564b0e5f1315273a2526a4e74
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoReplaced foreach calls with iterators
Kurt Pattyn [Sun, 29 Sep 2013 15:57:48 +0000 (17:57 +0200)]
Replaced foreach calls with iterators

Removed commented out lines

Change-Id: Ieccf43a4bb6b06b62acb347777b5481846144d14
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoAdded const keyword to const variables
Kurt Pattyn [Sun, 29 Sep 2013 14:54:29 +0000 (16:54 +0200)]
Added const keyword to const variables

Change-Id: I470d9bebbb86645ca766804e1005f3cb85256b38
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoAdded const to const variables, added QStringLiteral
Kurt Pattyn [Sun, 29 Sep 2013 15:20:03 +0000 (17:20 +0200)]
Added const to const variables, added QStringLiteral

Removed whitespace again to make sanity bot happy

Change-Id: Ifb0ae2566af73759593b2c46ec9cf4c93d6f3fcc
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoRemoved unused constant declaration
Kurt Pattyn [Sun, 29 Sep 2013 14:59:57 +0000 (16:59 +0200)]
Removed unused constant declaration

Change-Id: Iee07585470404281daae768c2db745b65b036dba
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoReplaced fromLatin1() with QStringLiteral
Kurt Pattyn [Sun, 29 Sep 2013 14:43:17 +0000 (16:43 +0200)]
Replaced fromLatin1() with QStringLiteral

Replaced tabs with spaces

Change-Id: Ice5adcf10bc7294852661f64c41836f8c97275bc
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoReplace string literals with QString::fromLatin1() expression
Kurt Pattyn [Sun, 29 Sep 2013 13:13:08 +0000 (15:13 +0200)]
Replace string literals with QString::fromLatin1() expression

to avoid deprecated warning (since Qt 5.1.1)
Replaced fromLatin1() with QStringLiteral

Change-Id: I0602cbe905310796357af97c8310dad6346c5f73
Reviewed-by: Steven Ceuppens <steven.ceuppens@icloud.com>
10 years agoReplace string literals with QString::fromLatin1() expression, to avoid deprecated...
Kurt Pattyn [Sun, 29 Sep 2013 12:39:19 +0000 (14:39 +0200)]
Replace string literals with QString::fromLatin1() expression, to avoid deprecated warning (since Qt 5.1.1)

Change-Id: Ie0c6218aae2eb829aa90b15f042e032a2c8a3d88
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoReplace string literals with QString::fromLatin1() expression, to avoid deprecated...
Kurt Pattyn [Sun, 29 Sep 2013 12:29:02 +0000 (14:29 +0200)]
Replace string literals with QString::fromLatin1() expression, to avoid deprecated warning (since Qt 5.1.1)

Change-Id: I01cec0e4e168815e486945afb03dd8f1ec2e949b
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoChanges to integrate the websocket module as a full Qt Add-On module
Steven Ceuppens [Fri, 27 Sep 2013 12:27:27 +0000 (14:27 +0200)]
Changes to integrate the websocket module as a full Qt Add-On module

- Changed project files to use Qt structure
- Moved existing sources into subdirectory, to make room for moduels
- Created a "import/qmlwebsocket" module skeleton (works, but needs to be extended)
- Modified examples to not use "include(.pri)", but use "QT += websocket"
- Added qml example skeleton (works, but no useful functionality yet)

Project can be build with:

$ qmake
$ make
$ make install

Module can be used in other projects with

QT += websockets

Change-Id: I2123026958b264670dbf8a978dee76edf5855806
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agotests: Enable "make check" to run unit tests
Sergio Ahumada [Sat, 28 Sep 2013 12:42:31 +0000 (14:42 +0200)]
tests: Enable "make check" to run unit tests

Change-Id: I8333e7a19d937003f16a02d4e10e1a542150d63f
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoUpdate .gitignore
Sergio Ahumada [Sat, 28 Sep 2013 12:53:37 +0000 (14:53 +0200)]
Update .gitignore

Add mkspecs/ include/ and lib/ to the ignore list

Change-Id: Ifad1eb78e3bd1b2b825a30a31df325e836c77e3e
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoAdded TODOs for extra tests
Kurt Pattyn [Sat, 28 Sep 2013 11:11:22 +0000 (13:11 +0200)]
Added TODOs for extra tests

Change-Id: I816d9adf686106443fe65df499f6615eca4599c5
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoUpdate .gitignore file
Sergio Ahumada [Wed, 25 Sep 2013 18:07:38 +0000 (20:07 +0200)]
Update .gitignore file

Change-Id: I2093ea60192aff6c82a4815cec472d4b23e8961f
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agosync.profile: Remove qtnetwork from %dependencies
Sergio Ahumada [Wed, 25 Sep 2013 17:55:41 +0000 (19:55 +0200)]
sync.profile: Remove qtnetwork from %dependencies

qtnetwork is not a repository, so it doesn't make sense here.

Change-Id: I679df09f47b3996a3c1157b500f1d0381a61398d
Reviewed-by: Kurt Pattyn <pattyn.kurt@gmail.com>
10 years agoThere was no '?' between path and query. Bug detected by someone on the internet.
Kurt Pattyn [Fri, 6 Sep 2013 15:09:32 +0000 (17:09 +0200)]
There was no '?' between path and query. Bug detected by someone on the internet.

10 years agoOpen buffer in readonly mode iso readwrite mode
Kurt Pattyn [Sun, 1 Sep 2013 17:40:27 +0000 (19:40 +0200)]
Open buffer in readonly mode iso readwrite mode

10 years agoCorrected failing tests
Kurt Pattyn [Sun, 1 Sep 2013 17:33:44 +0000 (19:33 +0200)]
Corrected failing tests

10 years agoAdded checks for non-emitting of other signals than the one we expect
Kurt Pattyn [Sun, 1 Sep 2013 11:54:04 +0000 (13:54 +0200)]
Added checks for non-emitting of other signals than the one we expect

10 years agoAdded tests for valid and invalid close codes
Kurt Pattyn [Sun, 1 Sep 2013 11:53:26 +0000 (13:53 +0200)]
Added tests for valid and invalid close codes
Added tests for invalid UTF8 sequences in close frames

10 years agoAdded maxMessageSize() and maxFrameSize() static getters to aid in unit testing
Kurt Pattyn [Sun, 1 Sep 2013 11:49:00 +0000 (13:49 +0200)]
Added maxMessageSize() and maxFrameSize() static getters to aid in unit testing

10 years agoUpdate README.md
Kurt Pattyn [Sun, 1 Sep 2013 11:36:54 +0000 (13:36 +0200)]
Update README.md

10 years agoAdded payload to ping() method and pong() signal
Kurt Pattyn [Sat, 31 Aug 2013 18:57:26 +0000 (20:57 +0200)]
Added payload to ping() method and pong() signal

10 years agoChanged the way origins are checked. Instead of a virtual method, we now use a QCorsA...
Kurt Pattyn [Sat, 31 Aug 2013 18:43:37 +0000 (20:43 +0200)]
Changed the way origins are checked. Instead of a virtual method, we now use a QCorsAuthenticator object and the signal originAuthenticationRequired(). This is modelled after the way QNetworkAccessManager handles authentication.
By using a signal iso of virtual method, applications must not subclass QWebSocketServer anymore to add origin checks.

10 years agoAdded \internal to documentation of new methods
Kurt Pattyn [Sat, 31 Aug 2013 17:13:36 +0000 (19:13 +0200)]
Added \internal to documentation of new methods

10 years agoMoved registerMetaType calls to init() method
Kurt Pattyn [Sat, 31 Aug 2013 17:09:01 +0000 (19:09 +0200)]
Moved registerMetaType calls to init() method

10 years agoMoved processing of control frame from QWebSocketPrivate to DataProcessor.
Kurt Pattyn [Sat, 31 Aug 2013 17:07:32 +0000 (19:07 +0200)]
Moved processing of control frame from QWebSocketPrivate to DataProcessor.
Added closeReceived(), pingReceived() and pongReceived() signals.
Added processClose(), processPing() and processPong() slot to QWebSocketPrivate

10 years agoAdded documentation for internally used classes
Kurt Pattyn [Sat, 31 Aug 2013 17:04:14 +0000 (19:04 +0200)]
Added documentation for internally used classes

10 years agoAdded ordered flag to build in declared order
Kurt Pattyn [Sat, 31 Aug 2013 16:47:24 +0000 (18:47 +0200)]
Added ordered flag to build in declared order

10 years agoAdded -Wextra compiler check
Kurt Pattyn [Fri, 30 Aug 2013 12:05:28 +0000 (14:05 +0200)]
Added -Wextra compiler check

10 years agoAdded -Wall and -Werror flags when building on mac (is in fact dependent on the compi...
Kurt Pattyn [Fri, 30 Aug 2013 11:58:40 +0000 (13:58 +0200)]
Added -Wall and -Werror flags when building on mac (is in fact dependent on the compiler that is used; currently don't know how to check that)

10 years agoAdded extra unit tests
Kurt Pattyn [Thu, 29 Aug 2013 19:05:43 +0000 (21:05 +0200)]
Added extra unit tests

10 years agoAdded a bunch of tests (still not complete; listed tests still to be done in TO DO...
Kurt Pattyn [Wed, 28 Aug 2013 22:19:02 +0000 (00:19 +0200)]
Added a bunch of tests (still not complete; listed tests still to be done in TO DO items)

10 years agoAdded TO DO's for tests still to be implemented
Kurt Pattyn [Wed, 28 Aug 2013 22:18:05 +0000 (00:18 +0200)]
Added TO DO's for tests still to be implemented

10 years agoChanged error string
Kurt Pattyn [Wed, 28 Aug 2013 22:17:27 +0000 (00:17 +0200)]
Changed error string

10 years agoSolved comparison bug (detected through unit tests :-) )
Kurt Pattyn [Wed, 28 Aug 2013 22:16:55 +0000 (00:16 +0200)]
Solved comparison bug (detected through unit tests :-) )