Matthew Leibowitz [Thu, 11 Aug 2016 22:10:20 +0000 (00:10 +0200)]
Corrected C header definition
Matthew Leibowitz [Thu, 11 Aug 2016 22:09:23 +0000 (00:09 +0200)]
Merge pull request #16 from google/chrome/m53
Update to latest m53
senorblanco [Thu, 11 Aug 2016 19:23:08 +0000 (12:23 -0700)]
Always init SkPathRef variables.
[Cherry-pick of
9c1d45d986f3c58593fde0fd62ab22e056dd3881 to m53 branch.]
BUG=623195
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
TBR=bsalomon@google.com
Review-Url: https://codereview.chromium.org/
2235363002
Matthew Leibowitz [Thu, 4 Aug 2016 16:07:40 +0000 (18:07 +0200)]
Added SkColorTable support to the C API
Matthew Leibowitz [Tue, 2 Aug 2016 16:12:16 +0000 (18:12 +0200)]
Merge branch 'chrome/m53' into xamarin-mobile-bindings
Matthew Leibowitz [Fri, 29 Jul 2016 18:06:05 +0000 (20:06 +0200)]
[C API] Added extra SkPath methods
reed [Tue, 26 Jul 2016 13:41:51 +0000 (06:41 -0700)]
Fix ASAN bot
TBR=reed@google.com
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2152573002
Review-Url: https://codereview.chromium.org/
2152573002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2182123002
Matthew Leibowitz [Mon, 25 Jul 2016 18:08:49 +0000 (20:08 +0200)]
Merge branch 'chrome/m53' into xamarin-mobile-bindings
reed [Mon, 25 Jul 2016 16:37:27 +0000 (09:37 -0700)]
cherry-pick fix for large conic weights
https://codereview.chromium.org/
2142393003
BUG=627414
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174413002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
TBR=caryclark@google.com
Review-Url: https://codereview.chromium.org/
2174413002
reed [Mon, 25 Jul 2016 15:46:18 +0000 (08:46 -0700)]
cherry-pick https://codereview.chromium.org/
2159223005
BUG=629455
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2174383002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2174383002
borenet [Mon, 25 Jul 2016 11:34:07 +0000 (04:34 -0700)]
Cherry-pick infra assets changes to chrome/m53 to prevent bots breaking
-----
Change SKPs to new asset management format
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2169653003
DOCS_PREVIEW= https://skia.org/?cl=
2169653003
Review-Url: https://codereview.chromium.org/
2169653003
-----
Add "skp" asset
Don't get rid of SKP_VERSION and associated stuff just yet.
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2167763002
DOCS_PREVIEW= https://skia.org/?cl=
2167763002
Review-Url: https://codereview.chromium.org/
2167763002
-----
Add vulkan sdk to CIPD
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164953002
Review-Url: https://codereview.chromium.org/
2164953002
-----
BUG=630725
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2175743004
Matthew Leibowitz [Sat, 23 Jul 2016 00:13:30 +0000 (02:13 +0200)]
Merge pull request #15 from mono/update-skia-m52
Update skia to m53
Matthew Leibowitz [Thu, 21 Jul 2016 19:57:40 +0000 (21:57 +0200)]
Merge branch 'chrome/m53' into update-skia-m52
bsalomon [Thu, 21 Jul 2016 15:31:21 +0000 (08:31 -0700)]
Init path color in distance field path renderer test
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2164313002
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
TBR=egdaniel@google.com
Review-Url: https://codereview.chromium.org/
2164313002
Matthew Leibowitz [Wed, 20 Jul 2016 15:18:54 +0000 (17:18 +0200)]
Removed additional members from sk_imageinfo_t
Matthew Leibowitz [Wed, 20 Jul 2016 13:16:51 +0000 (15:16 +0200)]
Added some comments to the C API
Matthew Leibowitz [Wed, 20 Jul 2016 12:25:54 +0000 (14:25 +0200)]
Merged the C code for upstreaming
Matthew Leibowitz [Tue, 19 Jul 2016 23:56:29 +0000 (01:56 +0200)]
A few changes to reduce the diff
Matthew Leibowitz [Tue, 19 Jul 2016 22:12:37 +0000 (00:12 +0200)]
Make sure to check for NULL first
Matthew Leibowitz [Tue, 19 Jul 2016 20:58:16 +0000 (22:58 +0200)]
The C enums are now direct cast instead of array lookups
Matthew Leibowitz [Tue, 19 Jul 2016 16:14:37 +0000 (18:14 +0200)]
WinRT cannot exit a process, so just no-op
benjaminwagner [Tue, 19 Jul 2016 15:54:47 +0000 (08:54 -0700)]
Cherry-pick Skia infra fixes to m53 so that Windows and Android bots can run tests.
-----
Convert SK Images to new assets format
Depends on https://codereview.chromium.org/
2162563002/
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2155163002
Review-Url: https://codereview.chromium.org/
2155163002
-----
Add Android SDK asset
This will allow us to use CIPD to install the Android SDK on bots.
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2086003002
Review-Url: https://codereview.chromium.org/
2086003002
-----
Convert Win toolchain to CIPD package
BUG=skia:5427
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2111713003
Review-Url: https://codereview.chromium.org/
2111713003
-----
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2159213002
Matthew Leibowitz [Tue, 19 Jul 2016 01:05:32 +0000 (03:05 +0200)]
removed the obsolete C type
Matthew Leibowitz [Tue, 19 Jul 2016 00:13:10 +0000 (02:13 +0200)]
Added another SkTypeface method
Matthew Leibowitz [Tue, 19 Jul 2016 00:07:58 +0000 (02:07 +0200)]
SkColorProfileType is removed
Matthew Leibowitz [Tue, 19 Jul 2016 00:07:26 +0000 (02:07 +0200)]
removed test filters
Matthew Leibowitz [Tue, 19 Jul 2016 00:03:48 +0000 (02:03 +0200)]
Added direct casting for enums
bsalomon [Mon, 18 Jul 2016 21:28:53 +0000 (14:28 -0700)]
Cherry-pick fix for GrAADistanceFieldPathRenderer bounds to M53.
-----------
Initialize fGammaCorrect in DF Path Renderer unit test
TBR=jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2157933003
Review-Url: https://codereview.chromium.org/
2157933003
Fix leak when DFPR fails to draw path
TBR=jvanverth@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2144283002
Review-Url: https://codereview.chromium.org/
2144283002
Make GrBatchAtlas robust against attempts to add large rects.
Make GrAADistanceFieldPathRenderer robust against paths that in src space wind up being too large for the atlas.
BUG=chromium:627443
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2144663004
Review-Url: https://codereview.chromium.org/
2144663004
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/
2160563004
Matthew Leibowitz [Mon, 18 Jul 2016 21:06:14 +0000 (23:06 +0200)]
Merge branch 'chrome/m53' into update-skia-m52
# Conflicts:
# gyp/common_conditions.gypi
# gyp/dng_sdk.gyp
# include/core/SkPreConfig.h
# src/gpu/gl/GrGLGpu.cpp
# src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp
# tests/PathOpsBuilderTest.cpp
Matthew Leibowitz [Mon, 18 Jul 2016 17:12:06 +0000 (19:12 +0200)]
Merge branch 'feature-patheffect' into update-skia-m52
Matthew Leibowitz [Mon, 18 Jul 2016 15:28:38 +0000 (17:28 +0200)]
Added the unref to the C API
Matthew Leibowitz [Mon, 18 Jul 2016 14:59:05 +0000 (16:59 +0200)]
[HACK] This works around the error in VS2015U3
- https://github.com/mono/SkiaSharp/issues/114
- "An internal error has occurred in the compiler."
Matthew Leibowitz [Thu, 14 Jul 2016 13:54:42 +0000 (15:54 +0200)]
Removing duplicate code after the merge
Matthew Leibowitz [Thu, 14 Jul 2016 00:06:25 +0000 (02:06 +0200)]
Updated the code to the newer version
Matthew Leibowitz [Wed, 13 Jul 2016 23:42:15 +0000 (01:42 +0200)]
Merge branch 'feature-patheffect' into update-skia-m52
# Conflicts:
# include/c/xamarin/sk_x_types.h
# src/c/xamarin/sk_x_types_priv.h
Matthew Leibowitz [Wed, 13 Jul 2016 23:23:36 +0000 (01:23 +0200)]
make sure that we always build for shared libraries
Matthew Leibowitz [Wed, 13 Jul 2016 23:23:13 +0000 (01:23 +0200)]
undoing change to opts.gyp
Matthew Leibowitz [Wed, 13 Jul 2016 23:22:26 +0000 (01:22 +0200)]
both arm/x86 require the fix
Matthew Leibowitz [Wed, 13 Jul 2016 16:56:01 +0000 (18:56 +0200)]
Added path effects to the C API
Matthew Leibowitz [Tue, 12 Jul 2016 01:31:52 +0000 (03:31 +0200)]
Added empty C files
Matthew Leibowitz [Mon, 11 Jul 2016 13:38:49 +0000 (15:38 +0200)]
Revert "Revert "Work around missing __mulodi4() on ARMv7 + Clang builds.""
This reverts commit
50876c22fa75cb0d64129b8d0c87d00f2486351f.
Matthew Leibowitz [Mon, 11 Jul 2016 13:34:18 +0000 (15:34 +0200)]
Revert "Work around missing __mulodi4() on ARMv7 + Clang builds."
This reverts commit
1b112ecdbd187474b9bfb5603dccc280b75cf9b6.
Miguel de Icaza [Sat, 9 Jul 2016 02:46:53 +0000 (22:46 -0400)]
[C API] Add sk_image_new_from_bitmap
Miguel de Icaza [Wed, 6 Jul 2016 14:30:24 +0000 (10:30 -0400)]
[C API] Cast everything to ints to avoid compile time errors on Android
Miguel de Icaza [Wed, 6 Jul 2016 02:21:47 +0000 (22:21 -0400)]
[C API] Add support for SkPath.RawIter, in addition to SkPath.Iter
Miguel de Icaza [Sun, 3 Jul 2016 04:27:23 +0000 (00:27 -0400)]
[C API] Add SkPath APIs to add sub-paths
Miguel de Icaza [Sun, 3 Jul 2016 04:10:18 +0000 (00:10 -0400)]
[C API] Add sk_path's iterators, and add the missing sk_matrix methods that I lost
Miguel de Icaza [Sat, 2 Jul 2016 02:47:24 +0000 (22:47 -0400)]
[Skia/C] Add bindings for SKPath Reset/Rewind
halcanary [Thu, 30 Jun 2016 15:34:06 +0000 (08:34 -0700)]
SkPDF: allow overriding Producer metadata
Cherry-pick
9f4b332 to m53
I recommend not using this functionality.
Also, some documentation.
BUG=skia:5436
Review-Url: https://codereview.chromium.org/
2074583003
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true
// discussed this cherry pick
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/
2110543007
benjaminwagner [Thu, 30 Jun 2016 11:47:45 +0000 (04:47 -0700)]
Revert of Better encapsulate oval/rrect batchs. (patchset #4 id:60001 of https://codereview.chromium.org/
2104423003/ )
Reason for revert:
Chromium roll is failing:
https://build.chromium.org/p/chromium.linux/builders/Android%20Arm64%20Builder%20%28dbg%29/builds/35938/steps/compile/logs/stdio
[1505/19896] CXX obj/skia/skia/GrOvalRenderer.o
FAILED: obj/skia/skia/GrOvalRenderer.o
/mnt/data/b/build/slave/cache/cipd/goma/gomacc ../../third_party/android_tools/ndk/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/bin/aarch64-linux-android-g++ -MMD -MF obj/skia/skia/GrOvalRenderer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DDISABLE_NACL -DENABLE_SUPERVISED_USERS=1 -DUSE_PROPRIETARY_CODECS -DVIDEO_HOLE=1 -DSAFE_BROWSING_DB_REMOTE -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DENABLE_WEBVR -DFIELDTRIAL_TESTING_ENABLED -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DANDROID_NDK_VERSION=r10e -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_DEFAULT_FONT_CACHE_LIMIT=
1048576 -DXML_STATIC -I../.. -Igen -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/include/private -I../../third_party/skia/include/client/android -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../third_party/zlib -I../../third_party/android_tools/ndk/sources/android/cpufeatures -I../../third_party/expat/files/lib -I../../third_party/freetype-android/include -I../../third_party/freetype-android/src/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables -fPIC -pipe -ffunction-sections -fno-short-enums -finline-limit=64 -Os -fdata-sections -ffunction-sections -g1 --sysroot=../../third_party/android_tools/ndk/platforms/android-21/arch-arm64 -fvisibility=hidden -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fno-exceptions -Wno-deprecated -Wno-narrowing -c ../../third_party/skia/src/gpu/GrOvalRenderer.cpp -o obj/skia/skia/GrOvalRenderer.o
In file included from ../../third_party/skia/include/private/../private/SkTemplates.h:17:0,
from ../../third_party/skia/include/private/SkTArray.h:12,
from ../../third_party/skia/src/gpu/GrBufferAllocPool.h:11,
from ../../third_party/skia/src/gpu/GrBatchFlushState.h:11,
from ../../third_party/skia/src/gpu/GrOvalRenderer.cpp:10:
../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory: In instantiation of 'void std::__1::unique_ptr<_Tp, _Dp>::reset(std::__1::unique_ptr<_Tp, _Dp>::pointer) [with _Tp = std::__1::__function::__base<bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>; _Dp = std::__1::__allocator_destructor<std::__1::allocator<std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)> > >; std::__1::unique_ptr<_Tp, _Dp>::pointer = std::__1::__function::__base<bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>*]':
../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2598:52: required from 'std::__1::unique_ptr<_Tp, _Dp>::~unique_ptr() [with _Tp = std::__1::__function::__base<bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>; _Dp = std::__1::__allocator_destructor<std::__1::allocator<std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)> > >]'
../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/functional:1603:72: required from 'std::__1::function<_Rp(_ArgTypes ...)>::function(_Fp, typename std::__1::enable_if<(std::__1::function<_Rp(_ArgTypes ...)>::__callable<_Fp>::value && (! std::__1::is_same<_Fp, std::__1::function<_Rp(_ArgTypes ...)> >::value))>::type*) [with _Fp = GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>; _Rp = bool; _ArgTypes = {GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int}; typename std::__1::enable_if<(std::__1::function<_Rp(_ArgTypes ...)>::__callable<_Fp>::value && (! std::__1::is_same<_Fp, std::__1::function<_Rp(_ArgTypes ...)> >::value))>::type = void]'
../../third_party/skia/src/gpu/GrBatchFlushState.h:80:9: required from here
../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:2630:34: error: invalid conversion from 'std::__1::unique_ptr<std::__1::__function::__base<bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>, std::__1::__allocator_destructor<std::__1::allocator<std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)> > > >::pointer {aka std::__1::__function::__base<bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>*}' to 'std::__1::__allocator_destructor<std::__1::allocator<std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)> > >::pointer {aka std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>*}' [-fpermissive]
__ptr_.second()(__tmp);
^
In file included from ../../third_party/skia/include/private/../private/SkTemplates.h:17:0,
from ../../third_party/skia/include/private/SkTArray.h:12,
from ../../third_party/skia/src/gpu/GrBufferAllocPool.h:11,
from ../../third_party/skia/src/gpu/GrBatchFlushState.h:11,
from ../../third_party/skia/src/gpu/GrOvalRenderer.cpp:10:
../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include/memory:3474:10: note: initializing argument 1 of 'void std::__1::__allocator_destructor<_Alloc>::operator()(std::__1::__allocator_destructor<_Alloc>::pointer) [with _Alloc = std::__1::allocator<std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)> >; std::__1::__allocator_destructor<_Alloc>::pointer = std::__1::__function::__func<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)>, std::__1::allocator<GrBatchFlushState::doUpload(GrDrawBatch::DeferredUploadFn&)::<lambda(GrSurface*, int, int, int, int, GrPixelConfig, const void*, size_t)> >, bool(GrSurface*, int, int, int, int, GrPixelConfig, const void*, long unsigned int)>*]'
void operator()(pointer __p) _NOEXCEPT
^
Original issue's description:
> Better encapsulate oval/rrect batchs.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104423003
>
> Committed: https://skia.googlesource.com/skia/+/
5fd209e8ee477c703bc5c11b008f247d515fc0fc
> Committed: https://skia.googlesource.com/skia/+/
7f06c6947a3bef78dc57b9252779567c33604c90
TBR=robertphillips@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2111883002
bsalomon [Thu, 30 Jun 2016 01:41:53 +0000 (18:41 -0700)]
Hide more GrBatch Geometry structs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2110903002
Review-Url: https://codereview.chromium.org/
2110903002
bsalomon [Thu, 30 Jun 2016 00:55:27 +0000 (17:55 -0700)]
Better encapsulate oval/rrect batchs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104423003
Committed: https://skia.googlesource.com/skia/+/
5fd209e8ee477c703bc5c11b008f247d515fc0fc
Review-Url: https://codereview.chromium.org/
2104423003
benjaminwagner [Wed, 29 Jun 2016 22:24:57 +0000 (15:24 -0700)]
Revert of Better encapsulate oval/rrect batchs. (patchset #3 id:40001 of https://codereview.chromium.org/
2104423003/ )
Reason for revert:
Causing assertion error on Test-Mac-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug (https://chromium-swarm.appspot.com/user/task/
2fb6ee239783b910) and Test-Win8-MSVC-ShuttleA-GPU-GTX960-x86_64-Debug (https://chromium-swarm.appspot.com/user/task/
2fb6ebcc157fed10).
Original issue's description:
> Better encapsulate oval/rrect batchs.
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104423003
>
> Committed: https://skia.googlesource.com/skia/+/
5fd209e8ee477c703bc5c11b008f247d515fc0fc
TBR=robertphillips@google.com,bsalomon@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/
2109913005
reed [Wed, 29 Jun 2016 21:33:11 +0000 (14:33 -0700)]
add SK_SUPPORT_PRECHECK_CLIPRECT experiment for clipRect
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2113443002
Review-Url: https://codereview.chromium.org/
2113443002
bsalomon [Wed, 29 Jun 2016 21:16:32 +0000 (14:16 -0700)]
Better encapsulate oval/rrect batchs.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104423003
Review-Url: https://codereview.chromium.org/
2104423003
caryclark [Wed, 29 Jun 2016 21:07:45 +0000 (14:07 -0700)]
fix asan bug triggered by pathops fuzz tests
R=dogben@google.com
TBR=reed@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2111473004
Review-Url: https://codereview.chromium.org/
2111473004
robertphillips [Wed, 29 Jun 2016 20:43:22 +0000 (13:43 -0700)]
Move dump of batches to be after the forwardCombine call in prepareBatches
This eliminates an unfortunate red herring. Text batching isn't actually as bad as I had feared.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2110123003
Review-Url: https://codereview.chromium.org/
2110123003
reed [Wed, 29 Jun 2016 18:36:34 +0000 (11:36 -0700)]
add short-desc
So that the UI can display the contents of "short-desc" inline with the verb.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2107913003
Review-Url: https://codereview.chromium.org/
2107913003
caryclark [Wed, 29 Jun 2016 17:46:08 +0000 (10:46 -0700)]
fix another pathops fuzz bug
Tunnel out the error case when the numerics
create uncalculable angles.
R=mmoroz@chromium.org
TBR=reed@google.com
BUG=624351
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103863005
Review-Url: https://codereview.chromium.org/
2103863005
robertphillips [Wed, 29 Jun 2016 17:28:11 +0000 (10:28 -0700)]
Add Annotations to old debugger
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2110083002
Review-Url: https://codereview.chromium.org/
2110083002
benjaminwagner [Wed, 29 Jun 2016 17:26:44 +0000 (10:26 -0700)]
Disable PathOpsFailOp test for Bazel ASAN test, because there are double->float cast overflows in PathOps code.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104303003
Review-Url: https://codereview.chromium.org/
2104303003
caryclark [Wed, 29 Jun 2016 15:18:38 +0000 (08:18 -0700)]
fix fuzz test that exceeds numeric limit
The extreme values here exceed an internal test that expects
computed numbers to be less than MAX_FLT. Use MAX_DBL instead.
R=mmoroz@chromium.org
TBR=reed@google.com
BUG=624346
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103903004
Review-Url: https://codereview.chromium.org/
2103903004
halcanary [Wed, 29 Jun 2016 14:23:47 +0000 (07:23 -0700)]
SkPDF: always assume SkStreamAsset behaves as specified
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104223003
Review-Url: https://codereview.chromium.org/
2104223003
benjaminwagner [Wed, 29 Jun 2016 14:02:54 +0000 (07:02 -0700)]
Check for empty output in adb_wait_for_charge.
Example error in https://chromium-swarm.appspot.com/user/task/
2f96d6439584e411
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2105813003
Review-Url: https://codereview.chromium.org/
2105813003
robertphillips [Wed, 29 Jun 2016 13:56:12 +0000 (06:56 -0700)]
Dump batch bounds and scissor rect
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2108503004
Review-Url: https://codereview.chromium.org/
2108503004
halcanary [Wed, 29 Jun 2016 13:31:32 +0000 (06:31 -0700)]
SkPDF: SkPDFStream takes only SkStreamAsset
This is possible since https://crrev.com/
869763002. Later, I'll clean
up the logic and class constructors. For now, I assert everywhere I
expect a SkStreamAsset to be well-behaved (duplcate, hasLength).
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2098393002
Review-Url: https://codereview.chromium.org/
2098393002
martina.kollarova [Wed, 29 Jun 2016 12:12:31 +0000 (05:12 -0700)]
Remove unnecessary includes in src/pdf/
Use forward declaration more.
BUG=None
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2110033002
Review-Url: https://codereview.chromium.org/
2110033002
reed [Wed, 29 Jun 2016 01:54:19 +0000 (18:54 -0700)]
add annotations to debugger
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2105113002
Review-Url: https://codereview.chromium.org/
2105113002
Miguel de Icaza [Wed, 29 Jun 2016 00:17:42 +0000 (20:17 -0400)]
[C API] Add convenience SkCanvas draw circle
Miguel de Icaza [Tue, 28 Jun 2016 23:48:46 +0000 (19:48 -0400)]
[C API] add more Matrix APIs
robertphillips [Tue, 28 Jun 2016 21:45:31 +0000 (14:45 -0700)]
Spruce up batch info printouts
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2107013002
Review-Url: https://codereview.chromium.org/
2107013002
fmenozzi [Tue, 28 Jun 2016 21:03:03 +0000 (14:03 -0700)]
Changes to Lua gradient scraping
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103973002
Review-Url: https://codereview.chromium.org/
2103973002
egdaniel [Tue, 28 Jun 2016 20:38:26 +0000 (13:38 -0700)]
Fix vulkan onGetWritePixelsInfo
When the configs are the same in Vulkan we know we can do write pixels,
but the caller may need to do a draw, so make sure we set up the
tempDrawInfo before returning.
BUG=skia:5461, skia:5458
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2108873003
Review-Url: https://codereview.chromium.org/
2108873003
bsalomon [Tue, 28 Jun 2016 18:56:42 +0000 (11:56 -0700)]
Make lines a special case in GrShape
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2108523002
Committed: https://skia.googlesource.com/skia/+/
c62318c748a1907649bd75382c4f4fd10533f2b3
Review-Url: https://codereview.chromium.org/
2108523002
bsalomon [Tue, 28 Jun 2016 18:18:47 +0000 (11:18 -0700)]
Revert of Make lines a special case in GrShape (patchset #5 id:120001 of https://codereview.chromium.org/
2108523002/ )
Reason for revert:
Assertion failures
Original issue's description:
> Make lines a special case in GrShape
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2108523002
>
> Committed: https://skia.googlesource.com/skia/+/
c62318c748a1907649bd75382c4f4fd10533f2b3
TBR=robertphillips@google.com,egdaniel@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2109613003
robertphillips [Tue, 28 Jun 2016 18:02:30 +0000 (11:02 -0700)]
Tighten up masking of colorType & alphaType in SkImageInfo serialization (for fuzzer bug)
In this case the int that contains the color and alpha types is getting munged. We don't really case that the surplus bits are 0 just that the values we care about are reasonable.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2110493002
Review-Url: https://codereview.chromium.org/
2110493002
rmistry [Tue, 28 Jun 2016 17:52:47 +0000 (10:52 -0700)]
Update CT documentation on skia.org
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103853002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2103853002
Review-Url: https://codereview.chromium.org/
2103853002
bsalomon [Tue, 28 Jun 2016 17:41:34 +0000 (10:41 -0700)]
Make lines a special case in GrShape
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2108523002
Review-Url: https://codereview.chromium.org/
2108523002
rmistry [Tue, 28 Jun 2016 17:17:03 +0000 (10:17 -0700)]
Add blacklist for the Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-CT_IMG_DECODE_100k_SKPs bot
BUG=skia:5462
BUG=skia:5466
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2101403003
# Try bots do not run this code.
NOTRY=true
Review-Url: https://codereview.chromium.org/
2101403003
caryclark [Tue, 28 Jun 2016 16:23:57 +0000 (09:23 -0700)]
fix fuzz bugs
Detect more places where the pathops numerics cause numbers
to become nearly identical and subsequently fail. These tests
have extreme inputs and cannot succeed.
Also remove the expectSuccess parameter from PathOpsDebug
and check instead in the test framework.
R=mbarbella@chromium.org
TBR=reed@google.com
BUG=623072,623022
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103513002
Review-Url: https://codereview.chromium.org/
2103513002
robertphillips [Tue, 28 Jun 2016 16:04:34 +0000 (09:04 -0700)]
Address two fuzzer bugs:
SkImageInfos that were made invalid weren't being caught
Messing with the size of a SAVE record wasn't being caught
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104973003
Review-Url: https://codereview.chromium.org/
2104973003
egdaniel [Tue, 28 Jun 2016 15:07:26 +0000 (08:07 -0700)]
Enable many more tests for Vulkan
BUG=skia:5461
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103133002
Review-Url: https://codereview.chromium.org/
2103133002
msarett [Tue, 28 Jun 2016 14:16:40 +0000 (07:16 -0700)]
Move SkColorSpace ICC parsing/writing code to its own file
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2101823003
Review-Url: https://codereview.chromium.org/
2101823003
reed [Tue, 28 Jun 2016 12:43:28 +0000 (05:43 -0700)]
remove SK_SUPPORT_LEGACY_COLORPROFILETYPE dead-code
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2101983003
TBR=
Review-Url: https://codereview.chromium.org/
2101983003
robertphillips [Tue, 28 Jun 2016 11:54:54 +0000 (04:54 -0700)]
Fix mask applied to SkPath::fFillType in readFromMemory to fix fuzzer bug
The fFillType field only needs/uses 2 bits - not all 8
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2099113004
Review-Url: https://codereview.chromium.org/
2099113004
borenet [Tue, 28 Jun 2016 11:41:49 +0000 (04:41 -0700)]
Add CIPD support for bot assets
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2085473002
Review-Url: https://codereview.chromium.org/
2085473002
Miguel de Icaza [Tue, 28 Jun 2016 03:06:07 +0000 (23:06 -0400)]
[C API] Add more sk_matrix operations
egdaniel [Mon, 27 Jun 2016 21:34:55 +0000 (14:34 -0700)]
Fix Vulkan readPixels
Fixed bug with setting up tempReadTexture from previous CL.
Also, previously we were not correctly handling the rowBytes during the read.
BUG=skia:5461
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2102633003
Review-Url: https://codereview.chromium.org/
2102633003
csmartdalton [Mon, 27 Jun 2016 21:02:10 +0000 (14:02 -0700)]
Check PremulType during GrGradientEffect::onIsEqual
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2100223003
Review-Url: https://codereview.chromium.org/
2100223003
egdaniel [Mon, 27 Jun 2016 19:57:00 +0000 (12:57 -0700)]
Add support for draws in vulkan read and write pixels
GL has a lot more optimizations checks here to make sure we do the most
effecient and correct draw here, but for now as long as the features
are support we just do basic draws for both reads and writes when we
need certain conversions.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2105433002
Review-Url: https://codereview.chromium.org/
2105433002
hcm [Mon, 27 Jun 2016 19:54:07 +0000 (12:54 -0700)]
Update roadmap and remove highlights
Use new file hosted on skia.org for 16-17 roadmap
Remove aging published highlights in favor of release notes
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2104563002
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2104563002
Review-Url: https://codereview.chromium.org/
2104563002
rmistry [Mon, 27 Jun 2016 19:51:47 +0000 (12:51 -0700)]
Update documentation on how to download CT SKPs
BUG=skia:5465
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2103443003
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=
2103443003
Review-Url: https://codereview.chromium.org/
2103443003
robertphillips [Mon, 27 Jun 2016 19:26:29 +0000 (12:26 -0700)]
Fix Perlin noise fuzz issue
The main "fix" here was that the assert was checking the un-clamped input value rather than the clamped value.
The SkValidatingReadBuffer.cpp change was required to get the reproducing fuzz test case to complete.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2107453002
Review-Url: https://codereview.chromium.org/
2107453002
robertphillips [Mon, 27 Jun 2016 19:05:39 +0000 (12:05 -0700)]
Address ASAN fuzzer complaint
This addresses a class of fuzzer failure where the paint index has been
made invalid but the calling code doesn't handle a null pointer return.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2099343002
Review-Url: https://codereview.chromium.org/
2099343002
dvonbeck [Mon, 27 Jun 2016 18:40:45 +0000 (11:40 -0700)]
SkLightingShader normal vector CPU computation refactor.
The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
This CL's base was the CL for GPU handling: https://codereview.chromium.org/
2043393002/
What this CL includes:
- A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2050773002
Committed: https://skia.googlesource.com/skia/+/
790a70118327a129cb6b48fabe80f4e184c1e67c
Review-Url: https://codereview.chromium.org/
2050773002
robertphillips [Mon, 27 Jun 2016 18:11:05 +0000 (11:11 -0700)]
Fix up flags to SkGpuBlurUtils::GaussianBlur
This fixes a bug introduced in: https://codereview.chromium.org/
1961953002/ (Reland of Simplify SkGpuBlurUtils::GaussianBlur method)
Although the 'canOverwriteSrc' flag is/was being used I still believe we're better off re-adding it after the mask-blur refactoring finishes.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2100873002
Review-Url: https://codereview.chromium.org/
2100873002
bsalomon [Mon, 27 Jun 2016 18:08:43 +0000 (11:08 -0700)]
Fix inverse test for GrDFAAPR::onCanDrawPath
TBR=egdaniel@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2105443002
Review-Url: https://codereview.chromium.org/
2105443002
bsalomon [Mon, 27 Jun 2016 17:00:19 +0000 (10:00 -0700)]
Use a union inside GrShape to hold geometry
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2094023002
Review-Url: https://codereview.chromium.org/
2094023002
dvonbeck [Mon, 27 Jun 2016 16:30:19 +0000 (09:30 -0700)]
Revert of Refactoring of CPU NormalMap handling out into its own class (patchset #13 id:240001 of https://codereview.chromium.org/
2050773002/ )
Reason for revert:
GMs are crashing on Windows Test trybots
Original issue's description:
> SkLightingShader normal vector CPU computation refactor.
>
> The purpose of this change is to refactor the handling of normal maps out of SkLightingShader, laying the groundwork to eventually allow for multiple normal sources.
>
> This CL's base was the CL for GPU handling: https://codereview.chromium.org/
2043393002/
>
> What this CL includes:
>
> - A refactor of the SkLightingShader context's code that deals with reading normals off of a normal map. This is now abstracted out into a NormalSource::Provider class that the context uses.
>
> BUG=skia:
> GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2050773002
>
> Committed: https://skia.googlesource.com/skia/+/
790a70118327a129cb6b48fabe80f4e184c1e67c
TBR=egdaniel@google.com,reed@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review-Url: https://codereview.chromium.org/
2101653002
csmartdalton [Mon, 27 Jun 2016 16:29:07 +0000 (09:29 -0700)]
Add a GL cap for instanced rendering to floating point
We have observed on OS X that instanced draws don't always behave
correctly when the framebuffer is floating point.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=
2095183002
Review-Url: https://codereview.chromium.org/
2095183002