platform/core/uifw/voice-control.git
2 years agoDeallocate the list memory after using it 82/283782/1
Suyeon Hwang [Mon, 31 Oct 2022 06:12:28 +0000 (15:12 +0900)]
Deallocate the list memory after using it

- Issue:
Command list was note deallocated after using it.

- Solution:
vc_cmd_db module creates the command list for update commands DB, but
after using it, the module did not deallocate the list. It can occur
memory leak. Thus, this patch adds code for deallocating the list.

Change-Id: Iffc7acb78aa577fdd56a27efd1abdc2a802d05eb
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoUse setter to set invocation name safely 81/283781/1
Suyeon Hwang [Fri, 28 Oct 2022 06:24:43 +0000 (15:24 +0900)]
Use setter to set invocation name safely

- Issue:
The invocation name previously set can be leaked.

- Solution:
The invocation name parameter is set by __vc_db_insert_commands_list()
without checking invocation itself. In most cases, invocation name is
not set by this function, but in special cases, memory leak can
occurred if use repeatedely set command list.
Thus, this patch prevents leak using setter function. The setter
function checks the invocation name paraemeter and safely changes it.

Change-Id: Ibe373fd51d5c2880ccea1d2b6699cd5614ffe49c
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoUpdate version to 1.70.7 09/282509/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/hotfix/20221116.110242 accepted/tizen/unified/20221005.090827 tizen_7.0_m2_release
wn.jang [Wed, 5 Oct 2022 00:46:53 +0000 (09:46 +0900)]
Update version to 1.70.7

Change-Id: I1f90e77141b0d188275521e2f66c466bfbd78a66

2 years agoCheck if tidl_info is NULL before use when vc mgr app is terminated 08/282508/1
wn.jang [Tue, 4 Oct 2022 12:00:37 +0000 (21:00 +0900)]
Check if tidl_info is NULL before use when vc mgr app is terminated

Change-Id: I43a3c753eabb0ccb308545c47fbe3beaf0fc8114

2 years agoFix coverity issues 34/282334/1 accepted/tizen/unified/20221004.073922
sooyeon [Fri, 30 Sep 2022 02:02:36 +0000 (11:02 +0900)]
Fix coverity issues

Change-Id: Ica79c8c2c2804e9f11e45480914726085637eff7
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd NOT_SUPPORTED error description in the header 25/282325/1
sooyeon [Thu, 22 Sep 2022 07:38:35 +0000 (16:38 +0900)]
Add NOT_SUPPORTED error description in the header

Change-Id: I5f43440efbcf00e7ec6503a345b0a5a86b36f2c0
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd permission denied error and descriptions 24/282324/1
sooyeon [Thu, 22 Sep 2022 04:46:47 +0000 (13:46 +0900)]
Add permission denied error and descriptions

Change-Id: Iaf1b54300feb01f789cac0af799982a3d6492a3b
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd remarks for additional privileges 23/282323/1
sooyeon [Thu, 22 Sep 2022 01:29:22 +0000 (10:29 +0900)]
Add remarks for additional privileges

Change-Id: I3ce6765012901624f928e0c86c80a0248d0e6dea
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd and Rearrange descriptions 22/282322/1
sooyeon [Mon, 8 Aug 2022 05:03:41 +0000 (14:03 +0900)]
Add and Rearrange descriptions

Change-Id: I78f52786dbcb48d34b56ffd41ba47c41a7a6316c
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd TIDL privileges in vce header description 21/282321/1
sooyeon [Mon, 8 Aug 2022 02:44:01 +0000 (11:44 +0900)]
Add TIDL privileges in vce header description

Change-Id: Ic689323869a141bcc21d51fa695cae1e0b63574d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoUpdate version to 1.70.6 83/282183/1 accepted/tizen/unified/20220929.080315
wn.jang [Wed, 28 Sep 2022 04:14:37 +0000 (13:14 +0900)]
Update version to 1.70.6

Change-Id: I10ed1ade43238e73c857acf21251d238f1412557

2 years agoAdd usleep while waiting for releasing callback function 82/282182/1
wn.jang [Wed, 28 Sep 2022 04:13:31 +0000 (13:13 +0900)]
Add usleep while waiting for releasing callback function

Change-Id: I3516ec0834dda1eb4d9d8af2e993671e9a89dda8

2 years agoRetry when prepare_sync is failed 69/282169/1
wn.jang [Wed, 28 Sep 2022 00:55:08 +0000 (09:55 +0900)]
Retry when prepare_sync is failed

Change-Id: I9a96cd1254fefd746a76e6f8bb1fe2bba255293e

2 years agoAdd logic to avoid reconnetion when finalize 45/281945/1 accepted/tizen/unified/20220926.025525
wn.jang [Fri, 23 Sep 2022 07:50:49 +0000 (16:50 +0900)]
Add logic to avoid reconnetion when finalize

Cause: The on_disconnect() cb is called, even a client requtests to disconnect.

Change-Id: I463ad1321968cc86b775125b220dfc8f1ce8b9b3
Solution: Check whether ipc listening state or not when tries to reconnect.

2 years agoAdd prepare_sync function to connect directly 92/281692/1 accepted/tizen/unified/20220921.091827
wn.jang [Tue, 20 Sep 2022 23:46:22 +0000 (08:46 +0900)]
Add prepare_sync function to connect directly

Cause: The Web TCs were blocked and failed.

Change-Id: I5b64a3f281b59191d8c41fc60a44eacdcdd5edb3
Solution: Connect directly when web api request to prepare

2 years agoAdd to disconnect rpc socket when client is finalized 77/281677/1
wn.jang [Tue, 20 Sep 2022 11:46:23 +0000 (20:46 +0900)]
Add to disconnect rpc socket when client is finalized

Cause: __on_disconnection is called when engine is terminated due to no more clients.

Change-Id: If3cfaa9c35ce8477e3c08e7d12c211d49e622c42
Solution: To avoid reconnect by service reset, disconnect rpc socket when client is finalized.

2 years agoFix coverity issues 94/280894/1 accepted/tizen/unified/20220908.013413
sooyeon [Tue, 6 Sep 2022 01:52:24 +0000 (10:52 +0900)]
Fix coverity issues

Change-Id: I3db738f369e0a7a36f09e73ca1f9740a79f1b8ef
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoMerge "fix issue that voice control client can not get service state update" into... accepted/tizen/unified/20220826.161539 submit/tizen/20220826.042422
Seongmin Park [Fri, 26 Aug 2022 04:23:46 +0000 (04:23 +0000)]
Merge "fix  issue that voice control client can not get service state update" into tizen

2 years agoMerge "send error to client when server disconnected" into tizen
Seongmin Park [Fri, 26 Aug 2022 04:23:38 +0000 (04:23 +0000)]
Merge "send error to client when server disconnected" into tizen

2 years agoChange interval and order when client connect to daemon 61/280261/1
ulgal-park [Thu, 11 Aug 2022 11:58:02 +0000 (20:58 +0900)]
Change interval and order when client connect to daemon

Change-Id: Ie6dc0b87e757171b372918d85d99637bd921f0f5

2 years agofix issue that voice control client can not get service state update 59/280259/1
ulgal-park [Thu, 25 Aug 2022 09:50:02 +0000 (18:50 +0900)]
fix  issue that voice control client can not get service state update

Change-Id: Ic2004192c199f807582b2d1a9512b396f61a0bce

2 years agosend error to client when server disconnected 58/280258/1
ulgal-park [Thu, 25 Aug 2022 07:35:35 +0000 (16:35 +0900)]
send error to client when server disconnected

Change-Id: I8318e562a6c16c3cb8b3375de079883fcddcbb00

2 years agoMerge "fix vc_mgr_tidl header guards typo" into tizen
Seongmin Park [Mon, 8 Aug 2022 05:40:47 +0000 (05:40 +0000)]
Merge "fix vc_mgr_tidl header guards typo" into tizen

2 years agoRefactor vc_mgr_ducking module implementation 12/279312/1
Suyeon Hwang [Fri, 5 Aug 2022 06:07:23 +0000 (15:07 +0900)]
Refactor vc_mgr_ducking module implementation

This patch includes these features:
- Use predefined macro instead of magic number
- Use error enum value instead of magic number
- Enhance log content for debugging and changed function name.
- Use cpp for implementing vc_mgr_ducking module for future
enahancement.
- Create unit functions in vc_mgr_ducking module for higher
maintainability.
- Add sound stream type for ducking TTS sound volume.

Change-Id: I0d7d7d4bbe7d8aaa89546f127eba8a853b9e45d2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoFix typo 11/279311/1
황수연/Tizen Platform Lab(SR)/삼성전자 [Fri, 5 Aug 2022 04:38:15 +0000 (13:38 +0900)]
Fix typo

Change-Id: Ic5d0574c1ce90984bb36b1abe686b51f0e9566db
Co-authored-by: 코드리뷰봇/Quality Tool Lab(SR)/삼성전자 <reviewbot@samsung.com>
2 years agoAdd vc_mgr_ducking files 10/279310/1
Suyeon Hwang [Fri, 5 Aug 2022 03:45:42 +0000 (12:45 +0900)]
Add vc_mgr_ducking files

This patch is cherry-picked from next commit:
https://review.tizen.org/gerrit/c/platform/core/uifw/voice-control/+/230142

Change-Id: I13d3c62eb06bdc0368b6c0b1bb3a6627dd4c70ef
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agofix vc_mgr_tidl header guards typo 88/279288/1
ulgal-park [Fri, 5 Aug 2022 06:08:52 +0000 (15:08 +0900)]
fix vc_mgr_tidl header guards typo

Change-Id: I983f7144dff58f2d62a78a578c2db0204c5c8d17

2 years agoReplace the name METHOD_ERROR_TO_APP with METHOD_ERROR 46/279246/1
sooyeon [Thu, 4 Aug 2022 07:28:51 +0000 (16:28 +0900)]
Replace the name METHOD_ERROR_TO_APP with METHOD_ERROR

Change-Id: I6ca381930becc1a6a01be55aa45b0dcac173637d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoChange variable names and function names 45/279245/1
sooyeon [Thu, 4 Aug 2022 04:42:54 +0000 (13:42 +0900)]
Change variable names and function names

Change-Id: I3eea6c8094a1752911243ce8e9202ecf3b256ec4
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove unnecessary codes (get_handle, xid) 44/279244/1
sooyeon [Thu, 4 Aug 2022 02:25:29 +0000 (11:25 +0900)]
Remove unnecessary codes (get_handle, xid)

Change-Id: Ided2c548d480e7933aa0bb6ecf4312b8c84f6d8d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove unused codes 43/279243/1
sooyeon [Thu, 4 Aug 2022 01:31:44 +0000 (10:31 +0900)]
Remove unused codes

Change-Id: Ie4c287f6745631d386d8aa5edc387c4662c1a95d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove vc handle in vc and vc_client 42/279242/1
sooyeon [Wed, 3 Aug 2022 11:22:03 +0000 (20:22 +0900)]
Remove vc handle in vc and vc_client

Change-Id: I6dc961c12e2949539df54251b8a0b4a752620c3a
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove unused functions 41/279241/1
sooyeon [Wed, 3 Aug 2022 08:35:04 +0000 (17:35 +0900)]
Remove unused functions

Change-Id: I448171a8c8076a09886c8a5b26bb85d098e34360
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove a logic to check TIDL privileges 06/279106/2 accepted/tizen/unified/20220802.144742 submit/tizen/20220802.063524
sooyeon [Tue, 2 Aug 2022 05:55:20 +0000 (14:55 +0900)]
Remove a logic to check TIDL privileges

Change-Id: I82f566421225fd7d6e903fe45a7c30592e9fbf6c
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoFix tidl error handling codes 66/279066/1 submit/tizen/20220802.012937
sooyeon [Mon, 1 Aug 2022 11:20:41 +0000 (20:20 +0900)]
Fix tidl error handling codes

Change-Id: I2d4662c41d486335b597d5f3930164150873f5d9
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoChange type casting using intptr_t 48/279048/1
sooyeon [Mon, 1 Aug 2022 06:11:23 +0000 (15:11 +0900)]
Change type casting using intptr_t

Change-Id: I596abafd51aa4af3e537b0df561b40c50cfcbc52
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoUpdate version (1.70.5) 38/279038/1 submit/tizen/20220801.042437
sooyeon [Mon, 1 Aug 2022 01:46:42 +0000 (10:46 +0900)]
Update version (1.70.5)

Change-Id: Idc0ab244ddd26b049995da126cdee2c6e73deb62
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoFix svace and coverity issues 01/279001/3
sooyeon [Fri, 29 Jul 2022 06:00:12 +0000 (15:00 +0900)]
Fix svace and coverity issues

Change-Id: Ic72a37bbbd082b9cbb35f8cafdf9384a6cbd60d6
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoReplace codes to check feature and privilege 77/278977/1
sooyeon [Wed, 6 Jul 2022 07:11:34 +0000 (16:11 +0900)]
Replace codes to check feature and privilege

Change-Id: I2691dbf7a1c3f4a5bcdb8e9eebb29b28cad050ce
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove unnecessary logs 76/278976/1
sooyeon [Wed, 6 Jul 2022 06:10:13 +0000 (15:10 +0900)]
Remove unnecessary logs

Change-Id: I7f4316fba8a62061cbe819465f2520e10e187fcb
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoReplace duplicated codes and Remove unnecessary logs 75/278975/1
sooyeon [Wed, 6 Jul 2022 04:56:28 +0000 (13:56 +0900)]
Replace duplicated codes and Remove unnecessary logs

Change-Id: I595a15ba1e9b430e6e6f31ab84a491d60f7fc175
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoFix TC issues (ignore ipc error in vce TCs and remove unnecessary codes) 74/278974/1
sooyeon [Mon, 4 Jul 2022 07:55:59 +0000 (16:55 +0900)]
Fix TC issues (ignore ipc error in vce TCs and remove unnecessary codes)

Change-Id: I4944efd2ce825fc69ab6dcc86d90bc2b854f8d35
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd privilege checker for TIDL privileges 73/278973/1
sooyeon [Thu, 30 Jun 2022 09:33:26 +0000 (18:33 +0900)]
Add privilege checker for TIDL privileges

Change-Id: Iaf23e79bf61094688579297613f7e1ec3753d618
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRename function name and Rearrange codes 72/278972/1
sooyeon [Thu, 30 Jun 2022 08:44:12 +0000 (17:44 +0900)]
Rename function name and Rearrange codes

Change-Id: Iaa053e9004dd3aaf3e6caa99bfcab5288d73211b
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoFix a minor issue (engine_appid was not saved in info handle) 71/278971/1
sooyeon [Thu, 30 Jun 2022 04:37:55 +0000 (13:37 +0900)]
Fix a minor issue (engine_appid was not saved in info handle)

Change-Id: I380beddfa0953fd21a9524158d8aa5b8f098878c
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove unnecessary command and Fix return value in vcd_client_widget_get_foreground_pid() 70/278970/1
sooyeon [Thu, 30 Jun 2022 02:48:50 +0000 (11:48 +0900)]
Remove unnecessary command and Fix return value in vcd_client_widget_get_foreground_pid()

Change-Id: I686738186f46907a74adccf412bc2295a1b79655
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoUnify bundle data in client, mgr, and widget 69/278969/1
sooyeon [Wed, 29 Jun 2022 08:39:17 +0000 (17:39 +0900)]
Unify bundle data in client, mgr, and widget

Change-Id: If822325a6edfcc6d6ea6fdf65229455fb8f081f6
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoChange return values and Fix minor issues 68/278968/1
sooyeon [Wed, 29 Jun 2022 06:44:11 +0000 (15:44 +0900)]
Change return values and Fix minor issues

Change-Id: I1d10d83f58b3ec36ed3308b8906a5151b7571875
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRemove files and codes related to DBus 67/278967/1
sooyeon [Wed, 29 Jun 2022 01:51:11 +0000 (10:51 +0900)]
Remove files and codes related to DBus

Change-Id: I48d11a36f6551c9169d576218b9b56660de85489
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRename extern functions and Rearrange codes 66/278966/1
sooyeon [Tue, 28 Jun 2022 02:22:34 +0000 (11:22 +0900)]
Rename extern functions and Rearrange codes

Change-Id: I3da3d9e9a46b6126af91b9ddcc16b4f00ef4123f
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoFix minor issues (indentation, filemod, add a checker of return values, etc) 65/278965/1
sooyeon [Tue, 28 Jun 2022 02:02:03 +0000 (11:02 +0900)]
Fix minor issues (indentation, filemod, add a checker of return values, etc)

Change-Id: I0f34be3b3fdfd659e7f47bca5d82f0c5333c1840
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoReplace IPC of vc_setting 64/278964/1
sooyeon [Mon, 27 Jun 2022 08:12:33 +0000 (17:12 +0900)]
Replace IPC of vc_setting

Change-Id: I58f30103efd851762c01e6f2730087364c1b8cf8
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd a missing file in CMakeLists and a code to handle TTS feedback data 63/278963/1
sooyeon [Sun, 26 Jun 2022 06:15:35 +0000 (15:15 +0900)]
Add a missing file in CMakeLists and a code to handle TTS feedback data

Change-Id: I9e8ef00e6e88a363cfc47578b9e19e7335f3f4c1
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoImplement functions related to auth, set_foreground, send_utterance_status 62/278962/1
sooyeon [Thu, 23 Jun 2022 01:47:28 +0000 (10:47 +0900)]
Implement functions related to auth, set_foreground, send_utterance_status

Change-Id: Ieddc83ffd9e76e75eedf28416dd21e952a6419ba
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoDisconnection dbus relationship 61/278961/1
sooyeon [Wed, 22 Jun 2022 09:45:50 +0000 (18:45 +0900)]
Disconnection dbus relationship

Change-Id: Ia8bfdf75fb6b8aad8bbcd49968e3185434cdfe1e
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoRename functions and Implement some TODOs 60/278960/1
sooyeon [Wed, 22 Jun 2022 09:32:41 +0000 (18:32 +0900)]
Rename functions and Implement some TODOs

Change-Id: Ic517b7bd84168c53d06dd5b752bee91d418e94a2
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd namespace(-n) option to build tidlc and Change TIDL apis 59/278959/1
sooyeon [Mon, 20 Jun 2022 12:05:33 +0000 (21:05 +0900)]
Add namespace(-n) option to build tidlc and Change TIDL apis

Change-Id: I1feba522be81db7567081650613e506f085d1906
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoAdd functions related to auth and stub tidl 58/278958/1
sooyeon [Mon, 13 Jun 2022 12:07:36 +0000 (21:07 +0900)]
Add functions related to auth and stub tidl

Change-Id: I1eded5e4c8f419de2925d30019c4c1579d013008
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoReplace IPC (VCC) from dbus to tidl 57/278957/1
sooyeon [Fri, 3 Jun 2022 09:10:20 +0000 (18:10 +0900)]
Replace IPC (VCC) from dbus to tidl

Change-Id: Ief592a9240490c404b756b37cb7b887c3a974321
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoChange retry logic to match TIDL 82/275282/3
ulgal-park [Thu, 19 May 2022 10:39:58 +0000 (19:39 +0900)]
Change retry logic to match TIDL

Change-Id: I50b7ca2aa38904ebbc92bcdf6ba2b3390995ea69

2 years agoFix ipc sync function's return value 81/275281/2
ulgal-park [Thu, 19 May 2022 10:39:01 +0000 (19:39 +0900)]
Fix ipc sync function's return value

Change-Id: Ideac4cd335daf2de50153f96443af85bde0a0f49

2 years agoReplace IPC between widget and server from dbus to tidl 80/275280/2
ulgal-park [Thu, 19 May 2022 09:53:58 +0000 (18:53 +0900)]
Replace IPC between widget and server from dbus to tidl

Change-Id: I82d73ad71b794ab13f7bfd1a6298c531cf4805b4

2 years agoReplace IPC between manager and server from dbus to tidl 79/275279/2
ulgal-park [Fri, 13 May 2022 06:32:04 +0000 (15:32 +0900)]
Replace IPC between manager and server from dbus to tidl

Change-Id: I76e2c9aeef41f3d166fbe19feca62d3364f875bd

2 years agoMerge "Fix line coverage scope and test option" into tizen
Suyeon Hwang [Thu, 28 Jul 2022 01:10:53 +0000 (01:10 +0000)]
Merge "Fix line coverage scope and test option" into tizen

2 years agoAdd metadata key 14/278714/3 accepted/tizen/unified/20220728.044817 submit/tizen/20220726.013524 submit/tizen/20220727.082051
ulgal-park [Mon, 25 Jul 2022 08:44:05 +0000 (17:44 +0900)]
Add metadata key

Change-Id: I898af8cff671a6b591360b86607c21831485d3e7

2 years agoFix line coverage scope and test option 70/278670/1
Suyeon Hwang [Mon, 25 Jul 2022 02:47:25 +0000 (11:47 +0900)]
Fix line coverage scope and test option

This patch reduces the scope for checking line coverage. The line
coverage is for checking client API, so other files in this repo is not
target of the line coverage test.

Change-Id: I677a34eb9a682a7cfd0c3d7e061fda1b7554cf17
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoCheck whether symbolic link or real file 09/277009/5
wn.jang [Wed, 29 Jun 2022 05:52:08 +0000 (14:52 +0900)]
Check whether symbolic link or real file

If open a file in write mode and do not check whether the file is a symbolic link or not, the file can be overwritten unintentionally.
So, this commit will check whether the file is symbolic link or real file.

Change-Id: I9db8c0287b479ef7474a2525fc1de3bd39e47e22

2 years agoUpdate version (1.70.4) 35/276235/1 accepted/tizen/unified/20220614.134607 submit/tizen/20220613.094311 submit/tizen/20220614.055600
Suyeon Hwang [Mon, 13 Jun 2022 08:14:53 +0000 (17:14 +0900)]
Update version (1.70.4)

Change-Id: I481f920d4592c0e7b1acfa02e40406c15f7305c8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoFix unittest for line coverage automation 86/276186/1
Suyeon Hwang [Fri, 10 Jun 2022 10:20:26 +0000 (19:20 +0900)]
Fix unittest for line coverage automation

Change-Id: I81ba58b22167ee07f155fc0fc0c468a4095b1989
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoFix gcov package contents for automation 41/276041/1
Suyeon Hwang [Thu, 9 Jun 2022 02:47:08 +0000 (11:47 +0900)]
Fix gcov package contents for automation

Change-Id: Ia9f42f9670c8c44d0cbfcfcffbed2d9751628829
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoMerge "Revert "Replace IPC between manager and server from dbus to tidl"" into tizen accepted/tizen/unified/20220502.003742 submit/tizen/20220429.072034
Seongmin Park [Fri, 29 Apr 2022 07:04:49 +0000 (07:04 +0000)]
Merge "Revert "Replace IPC between manager and server from dbus to tidl"" into tizen

2 years agoRevert "Replace IPC between manager and server from dbus to tidl" 89/274489/1
Seongmin Park [Fri, 29 Apr 2022 05:14:03 +0000 (05:14 +0000)]
Revert "Replace IPC between manager and server from dbus to tidl"

This reverts commit 58c72fc9dde94ee12ecae41b579b724c86269eba.

Reason for revert: this commit will be re-merged when all dbus replaced to tidl

Change-Id: Ic50ef53ff4b1e455464e587a9282f0b1989f5414

2 years agoMerge "Revert "Replace IPC between widget and server from dbus to tidl"" into tizen
Seongmin Park [Fri, 29 Apr 2022 05:09:53 +0000 (05:09 +0000)]
Merge "Revert "Replace IPC between widget and server from dbus to tidl"" into tizen

2 years agoRevert "Replace IPC between widget and server from dbus to tidl" 82/274482/1
Seongmin Park [Fri, 29 Apr 2022 02:57:40 +0000 (02:57 +0000)]
Revert "Replace IPC between widget and server from dbus to tidl"

This reverts commit a88b50ad66a722e2b44735155623da2b8d2a75e0.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I1e670df9d691736100f61edb16bf54fa349e6090

2 years agoMerge "Replace IPC between widget and server from dbus to tidl" into tizen
Seongmin Park [Fri, 29 Apr 2022 02:44:46 +0000 (02:44 +0000)]
Merge "Replace IPC between widget and server from dbus to tidl" into tizen

2 years agoReplace IPC between widget and server from dbus to tidl 51/273451/5
ulgal-park [Tue, 15 Mar 2022 03:04:27 +0000 (12:04 +0900)]
Replace IPC between widget and server from dbus to tidl

Change-Id: I08d104ed3511cfb0b251062e5521664105ae2cb3

2 years agoAdd metadata profile xml file 68/273768/3
wn.jang [Wed, 13 Apr 2022 10:38:09 +0000 (19:38 +0900)]
Add metadata profile xml file

Change-Id: I34c62f51fef48d29ce505c5ba010f72d7b4194ba

2 years agoReplace IPC between manager and server from dbus to tidl 50/273450/8
ulgal-park [Mon, 14 Feb 2022 10:31:00 +0000 (19:31 +0900)]
Replace IPC between manager and server from dbus to tidl

Change-Id: I0495d54c8a3ae5f89b5c38750e80760391a8e4c9

2 years agoAdd error into the description of vce_send_error() 70/272270/1 submit/tizen/20220314.023839
Suyeon Hwang [Mon, 14 Mar 2022 02:25:06 +0000 (11:25 +0900)]
Add error into the description of vce_send_error()

Change-Id: I64f455f0433459508d6016f16806fc9b296626ca
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoRemove unused codes 25/272025/2
wn.jang [Mon, 7 Mar 2022 03:12:27 +0000 (12:12 +0900)]
Remove unused codes

UpdateEvent has never used until now.
But this should be supported for notifying update state.
Therefore, I leave a TODO comment.

Change-Id: I4ef0ea99785b51c23cf9c93363d93a65c67ca0a5

2 years agoUpdate version (1.70.3) 33/271633/1 accepted/tizen/unified/20220224.125740 submit/tizen/20220224.102331
sooyeon [Thu, 24 Feb 2022 10:10:46 +0000 (19:10 +0900)]
Update version (1.70.3)

Change-Id: Ie8ba2b7c8d416de1662759984565737a5541bb9a
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoFix svace issue (PASSED_TO_PROC_AFTER_RELEASE) 75/271575/1
sooyeon [Wed, 23 Feb 2022 15:19:48 +0000 (00:19 +0900)]
Fix svace issue (PASSED_TO_PROC_AFTER_RELEASE)

Change-Id: I5278c5197e3298fb4fdd933eb5972d8c3e6dc5f7
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
2 years agoUpdate version to 1.70.2 41/270741/1 accepted/tizen/unified/20220209.131743 submit/tizen/20220208.060036
wn.jang [Tue, 8 Feb 2022 05:56:05 +0000 (14:56 +0900)]
Update version to 1.70.2

Change-Id: I6a3f5cd4bf2065da5f832aad153ebf4eb5a7b247

2 years agoMerge "Fix defects from static analysis tool" into tizen
Wonnam Jang [Tue, 8 Feb 2022 05:57:31 +0000 (05:57 +0000)]
Merge "Fix defects from static analysis tool" into tizen

2 years agoFix defects from static analysis tool 24/270724/1
wn.jang [Tue, 8 Feb 2022 05:24:43 +0000 (14:24 +0900)]
Fix defects from static analysis tool

Change-Id: I9cb797a9f2ab1ade83b2e752359fe906ede6c5f5

2 years agoCall service state changed callback before state changed callback 72/269072/2
Suyeon Hwang [Fri, 7 Jan 2022 07:35:08 +0000 (16:35 +0900)]
Call service state changed callback before state changed callback

https://review.tizen.org/gerrit/c/platform/core/uifw/voice-control/+/223267
The patch of this link makes that service state changed callback is called asynchronously. This was
because prepare process was handled on sub thread. In order to assure the callback calls on main
thread, the patch seperated the code for calling service state changed callback and state changed
callback. However, this change made client can not assure the value of service state because it
was updated unknown timing.

To solve this problem, this patch calls the service state changed callback before calling the state
changed callback. Current code does not handle the prepare process on sub thread but on main
thread. So, by this change, service state would be synchornously updated when the state changed
callback is called.

Change-Id: I276577fb494a93c8e4f58182c2e16a6ff88b7423
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoUpdate version to 1.70.1 13/269813/1 submit/tizen/20220120.074711
wn.jang [Thu, 20 Jan 2022 07:33:20 +0000 (16:33 +0900)]
Update version to 1.70.1

Change-Id: I9d3cf3d032bdf59657fbb54729707b5b325f2743

2 years agoCoverage support for robot profile 80/269780/1
wn.jang [Thu, 20 Jan 2022 06:31:25 +0000 (15:31 +0900)]
Coverage support for robot profile

Change-Id: Ifc880b594a7183e62603ee6801c5bad6465e985b

2 years agoGet library name from vconf 25/269025/1
Suyeon Hwang [Thu, 6 Jan 2022 11:31:56 +0000 (20:31 +0900)]
Get library name from vconf

Current code tries to get full path of dependency module from vconf of system. This means that
framework allows to use annonymous library which is installed on any location. However, this
behavior might allow to access malicious code and this would become critical problem.

To solve this issue, this patch fix that the code gets the file name of library from the vconf.
By this patch, all dependency module libraries should be installed predetermined location.
The location is read only directory, so malicious code can not be located.

Change-Id: I5ab83609229a0fe84b152894b3935d586859c98a
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoMerge branch 'tizen_6.5' into tizen 92/268592/1
Suyeon Hwang [Mon, 27 Dec 2021 09:40:27 +0000 (18:40 +0900)]
Merge branch 'tizen_6.5' into tizen

Change-Id: I3cdca0b8231528f8d8bc29144b81857f753975dc

2 years agoUpdate version (1.70.0) 91/268591/1
Suyeon Hwang [Mon, 27 Dec 2021 09:14:39 +0000 (18:14 +0900)]
Update version (1.70.0)

Change-Id: I3ff2697cbbb06d9e2fc1dbaa7ab0b5bad473642a
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoUpdate version (1.65.6) 81/268581/1
Suyeon Hwang [Mon, 27 Dec 2021 08:35:37 +0000 (17:35 +0900)]
Update version (1.65.6)

Change-Id: Ief5c962460cf35e3396f347ab0aab79fc61a7b2d
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoUnify indentation of enums on vce.h 16/267216/2
Suyeon Hwang [Tue, 30 Nov 2021 02:06:53 +0000 (11:06 +0900)]
Unify indentation of enums on vce.h

Change-Id: I101f12cea06cfd55a5b1c75fc2cb91982a52a814
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoMake function for get pid that requests tts play 37/266937/2
Suyeon Hwang [Mon, 22 Nov 2021 10:50:37 +0000 (19:50 +0900)]
Make function for get pid that requests tts play

Change-Id: Ica6e6c058814f06a3e276dc65474d175a21f837a
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoSend error about tts failed to client app 36/266936/2
Suyeon Hwang [Mon, 22 Nov 2021 10:32:57 +0000 (19:32 +0900)]
Send error about tts failed to client app

Change-Id: Ic7736f0f2381bc873f87da0f8d455b61ebd87d1a
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoChange variable related with uid to unsigned integer 71/268571/1
Suyeon Hwang [Mon, 27 Dec 2021 05:47:38 +0000 (14:47 +0900)]
Change variable related with uid to unsigned integer

Change-Id: Id74b98a2adc21d5e71905203ec5752c11b826abf
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoAdd handle type value when initialize config 30/267830/1
Suyeon Hwang [Fri, 10 Dec 2021 07:50:10 +0000 (16:50 +0900)]
Add handle type value when initialize config

When client initialize the vc_config_mgr, manager and setting client send the handle with unique
type value as a parameter into. This is because the uid can be used to check the type of client
when vc_config_mgr needs to identify the client. However, widget client did not add unique value
into the handle.

Thus, this patch makes the widget client send handle with unique value for widget client. By this
change, widget client also works same as other types of client.

Change-Id: I3eb28c8a97621dd9809447bd63a79858f7353ef8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoFix format string and variable name 39/267739/4
Suyeon Hwang [Thu, 9 Dec 2021 09:32:36 +0000 (18:32 +0900)]
Fix format string and variable name

By changing data type of uid, many mismatchess between data of format string and variable are
generated. And also, the name 'uid' is used too generally. I may cause misunderstand about
the purpose of the variable.

To solve this problem, this patch changes the format string to match the variables. And also,
this patch changes the name of variable to make name more clear.

Change-Id: Id86e57b5ce39589c7c65eeb9106abf8040f6aed6
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
2 years agoUpdate version to 1.65.5 67/267767/1 accepted/tizen/6.5/unified/20211212.212835 submit/tizen_6.5/20211209.233844
wn.jang [Thu, 9 Dec 2021 13:18:59 +0000 (22:18 +0900)]
Update version to 1.65.5

Change-Id: Ie91a2bdc2fb1955f30e1b6f539f794b43edfed4b

2 years agoUpdate version to 1.65.5 66/267766/1 accepted/tizen/unified/20211210.115150 submit/tizen/20211209.233938
wn.jang [Thu, 9 Dec 2021 13:18:59 +0000 (22:18 +0900)]
Update version to 1.65.5

Change-Id: Ie91a2bdc2fb1955f30e1b6f539f794b43edfed4b