review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

dandov [Wed, 16 Jul 2014 02:46:26 +0000 (19:46 -0700)]

Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices.

BUG=skia:2745

Committed: https://skia.googlesource.com/skia/+/612364de87cb2012239c4f6435e8e11760617fdc

R=jvanverth@google.com, bsalomon@google.com, egdaniel@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/387113002

commit | commitdiff | tree

bsalomon [Wed, 16 Jul 2014 02:41:17 +0000 (19:41 -0700)]

Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys.

Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF.

Cleans up docs around GrBackendEffectFactory.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/379113004

commit | commitdiff | tree

piotaixr [Wed, 16 Jul 2014 02:41:08 +0000 (19:41 -0700)]

Caching the result of readPixelsSupported

The call was calling GR_GL_GetIntegerv 2 times for each readPixels
and thus was causing a loss of performance

(resubmit of issue 344793008)

Benchmark url: http://packages.gkny.fr/tst/index.html

BUG=skia:2681

Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c

R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, mtklein@google.com, bsalomon@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/364193004

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 23:17:44 +0000 (19:17 -0400)]

revert timer changes

BUG=skia:

Review URL: https://codereview.chromium.org/397843002

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 23:04:14 +0000 (19:04 -0400)]

nanobench on Windows: try compiler barriers around timer instead.

BUG=skia:

Review URL: https://codereview.chromium.org/391193003

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 22:39:49 +0000 (18:39 -0400)]

Disable LTCG for nanobench.

NOTREECHECKS=true

BUG=skia:
R=mtklein@google.com

Review URL: https://codereview.chromium.org/393953006

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 21:56:37 +0000 (17:56 -0400)]

Try to debug Windows infinite loops in nanobench.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/396753004

commit | commitdiff | tree

mtklein [Tue, 15 Jul 2014 21:38:53 +0000 (14:38 -0700)]

Keep at most one GPU device alive at a time.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/392013004

commit | commitdiff | tree

mtklein [Tue, 15 Jul 2014 20:29:34 +0000 (13:29 -0700)]

SkAutoRef seems lonely. Might as well delete it.

(On the other hand, SkAutoUnref is well-used.)

NOTREECHECKS=true

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/393953004

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 20:10:02 +0000 (16:10 -0400)]

DM: destroy contexts after each GPU task instead of before

This is for consistency with bench/nanobench/GM. Haven't seen it make a difference.

BUG=skia:

Review URL: https://codereview.chromium.org/397743004

commit | commitdiff | tree

scroggo [Tue, 15 Jul 2014 19:34:26 +0000 (12:34 -0700)]

Change SkCanvasState to use inheritance.

The base class, SkCanvasState, now holds the version, width, and
height. These fields will always be a necessary part of the class.
(Also add in some padding.)
The other fields, which may change, have been moved into the
subclass, SkCanvasState_v1. If/when the version changes, it will
correspond to a new subclass.
In SkCanvasStateUtils::CreateFromCanvasState, check the version on
the base class, then do a static_cast to the version corresponding
to SkCanvasState::version.

Remove CANVAS_STATE_VERSION, which is redundant with the version
specified by the subclass.

Use unambiguous type for rowBytes.

Build Android with SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG. This allows us
to run the full suite of CanvasState tests. It is also representative
of what will be used on Android by WebView.

Fix CanvasStateTest where it was broken inside ifdef'ed out code.

Use SkCanvas::getBaseLayerSize() instead of the deprecated
SkCanvas::getDeviceSize().

Update the comments in the header to be more clear. In particular,
an SkCanvasState can only be used to pass an SkCanvas' state to a
future version of Skia (or the same); not an older version.

NOTREECHECKS=true

BUG=b/15693384
R=reed@google.com, mtklein@google.com, djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/372003002

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 17:40:19 +0000 (13:40 -0400)]

destroyContexts after each bench instead of before

BUG=skia:

Review URL: https://codereview.chromium.org/394893002

commit | commitdiff | tree

mtklein [Tue, 15 Jul 2014 17:30:31 +0000 (10:30 -0700)]

Give windows boring bars and use 'us' for microseconds.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/393673006

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 16:01:06 +0000 (12:01 -0400)]

force another build

BUG=skia:

Review URL: https://codereview.chromium.org/397493008

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 15:49:58 +0000 (11:49 -0400)]

Force a build for nanobench.

BUG=skia:

Review URL: https://codereview.chromium.org/391983002

commit | commitdiff | tree

mtklein [Tue, 15 Jul 2014 15:27:06 +0000 (08:27 -0700)]

Add --resetGpuContext to both DM and nanobench.

Defaulting to true to be conservative for now.

BUG=skia:

NOTREECHECKS=true
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/398483005

commit | commitdiff | tree

kozyatinskiy [Tue, 15 Jul 2014 15:08:01 +0000 (11:08 -0400)]

https://chromiumcodereview.appspot.com/331133004/

patch from issue 331133004

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 15:00:26 +0000 (11:00 -0400)]

Another forced run for Android bots.

BUG=skia:

Review URL: https://codereview.chromium.org/388683005

commit | commitdiff | tree

Mike Klein [Tue, 15 Jul 2014 14:37:53 +0000 (10:37 -0400)]

force build

BUG=skia:

Review URL: https://codereview.chromium.org/391103002

commit | commitdiff | tree

borenet [Tue, 15 Jul 2014 12:30:47 +0000 (05:30 -0700)]

Whitespace change to test failures after https://skia.googlesource.com/buildbot/+/0e977d0753ecc81fd4e45e088ebc5bc16f0b4b75 and https://skia.googlesource.com/buildbot/+/0e6fdada778ad14e38b25f8b5827a8b156674045

BUG=skia:
R=mtklein@google.com
TBR=mtklein

Author: borenet@google.com

Review URL: https://codereview.chromium.org/397613003

commit | commitdiff | tree

bensong [Mon, 14 Jul 2014 23:36:06 +0000 (16:36 -0700)]

manual bench rebase after f459c85, adjusted with ed458688e284508f17a0408a093d89a8b5966e32

R=robertphillips@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/394673002

commit | commitdiff | tree

dandov [Mon, 14 Jul 2014 21:52:36 +0000 (14:52 -0700)]

Revert of drawVertices bug on gpu side (https://codereview.chromium.org/387113002/)

Reason for revert:
compare gms failed on 6 images, I will check them and determine if they need a rebaseline or if the output is incorrect.

Original issue's description:
> Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices.
>
> BUG=skia:2745
>
> Committed: https://skia.googlesource.com/skia/+/612364de87cb2012239c4f6435e8e11760617fdc

R=jvanverth@google.com, bsalomon@google.com, egdaniel@google.com
TBR=bsalomon@google.com, egdaniel@google.com, jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2745

Author: dandov@google.com

Review URL: https://codereview.chromium.org/395613002

commit | commitdiff | tree

reed [Mon, 14 Jul 2014 21:39:15 +0000 (14:39 -0700)]

patch from issue 383923002

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/394603003

commit | commitdiff | tree

dandov [Mon, 14 Jul 2014 21:26:04 +0000 (14:26 -0700)]

Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices.

BUG=skia:2745
R=jvanverth@google.com, bsalomon@google.com, egdaniel@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/387113002

commit | commitdiff | tree

halcanary [Mon, 14 Jul 2014 19:59:59 +0000 (12:59 -0700)]

Fix memory leak introduced in crrev.com/387863005

NOTRY=true
R=bungeman@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/395543002

commit | commitdiff | tree

tfarina [Mon, 14 Jul 2014 19:32:47 +0000 (12:32 -0700)]

Cleanup: Remove unused/unimplemented SkTextLayout.h.

Nobody uses it in Skia, Chromium and Blink. And it does not have any
implementation either.

BUG=None
TEST=make all
R=mtklein@google.com, reed@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/385323002

commit | commitdiff | tree

mtklein [Mon, 14 Jul 2014 19:28:47 +0000 (12:28 -0700)]

nanobench: add --runOnce.

BUG=skia:
R=egdaniel@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/392583005

commit | commitdiff | tree

krajcevski [Mon, 14 Jul 2014 19:00:04 +0000 (12:00 -0700)]

Add support for NEON intrinsics to speed up texture compression. We can
now convert the time that we would have spent uploading the texture to
compressing it giving a net 50% memory savings for these things.

Committed: https://skia.googlesource.com/skia/+/bc9205be0a1094e312da098348601398c210dc5a

R=robertphillips@google.com, mtklein@google.com, kevin.petit@arm.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/390453002

commit | commitdiff | tree

mtklein [Mon, 14 Jul 2014 18:30:37 +0000 (11:30 -0700)]

nanobench: support --outResultsFile

BUG=skia:
R=kelvinly@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/390933002

commit | commitdiff | tree

scroggo [Mon, 14 Jul 2014 17:25:00 +0000 (10:25 -0700)]

Include SkTypes before using ifdefs.

Fixes Android framework build.

When building for the Android framework, we depend on SkUserConfig.h
to define things like SK_SUPPORT_GPU. So we cannot have the first
include inside a guard requring SK_SUPPORT_GPU to be defined. Include
SkTypes first, which will pull in SkUserConfig, define the flag, and
allow us to include GrContextFactory.h.

R=reed@google.com, djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/394533003

commit | commitdiff | tree

scroggo [Mon, 14 Jul 2014 17:22:02 +0000 (10:22 -0700)]

Alphabetize defines in generated SkUserConfig.

When generating SkUserConfig.h for Android, alphabetize the defines.

This will make one merge much harder to look at, but every following
one much easier.

R=mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/388693003

commit | commitdiff | tree

senorblanco [Mon, 14 Jul 2014 17:19:54 +0000 (10:19 -0700)]

Fix for saveLayer() with filters vs. the BBox Hierarchy.

When building acceleration structures for SkPicture, we must transform
the primitive's bounds not only by its own SkPaint, but by the paints of
any saveLayer()s currently active above it.

We do this by pushing the SkPaint onto a stack on
saveLayer(), and popping them on restore(). We also push
a NULL paint in save(), so that the pushes and pops are
balanced.

BUG=skia:2734
R=mtklein@google.com, reed@google.com, robertphillips@google.com

Committed: https://skia.googlesource.com/skia/+/6ca0b6a46cbe9bef3e2b9b9db813ec864efd62de

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/380373003

commit | commitdiff | tree

reed [Mon, 14 Jul 2014 17:13:57 +0000 (10:13 -0700)]

remove unused SkPixelRef constructor

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/390893002

commit | commitdiff | tree

reed [Mon, 14 Jul 2014 16:21:31 +0000 (09:21 -0700)]

remove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/387313004

commit | commitdiff | tree

halcanary [Mon, 14 Jul 2014 16:12:12 +0000 (09:12 -0700)]

Move SkPDFStream back to SkStream to save memory.

SkPDFStream stores data as a SkStreamRewindable to minimize
deep duplication and memory overhead.

SkStreamToStreamRewindable function to deal with fact that
SkTypeface returns a SkStream.

BUG=skia:2743
R=djsollen@google.com, mtklein@google.com, bungeman@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/387863005

commit | commitdiff | tree

halcanary [Mon, 14 Jul 2014 15:32:18 +0000 (08:32 -0700)]

Revert of Enable the SSSE3 compile time check on all platforms. (https://codereview.chromium.org/391693004/)

Reason for revert:
windows fail

Original issue's description:
> Enable the SSSE3 compile time check on all platforms.
>
> BUG=skia:2746
>
> Committed: https://skia.googlesource.com/skia/+/ee349531446ae2a8336b0903e05d0b2150d2131f

R=mtklein@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2746

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/390063002

commit | commitdiff | tree

senorblanco [Mon, 14 Jul 2014 15:25:33 +0000 (08:25 -0700)]

Revert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and
"resizeimagefiler is ok with a BBH now".

This reverts commits 6ca0b6a46cbe9bef3e2b9b9db813ec864efd62de and 8fa73202eaffbd7591ee218ad452b9afde81f505.

Apparently causing problems in SKP playback.

R=mtklein@google.com, robertphillips@google.com
TBR=mtklein, robertphillips
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381353005

commit | commitdiff | tree

djsollen [Mon, 14 Jul 2014 14:58:41 +0000 (07:58 -0700)]

Enable the SSSE3 compile time check on all platforms.

BUG=skia:2746
R=mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/391693004

commit | commitdiff | tree

scroggo [Mon, 14 Jul 2014 14:58:34 +0000 (07:58 -0700)]

Remove last SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX.

Should have been included in https://codereview.chromium.org/379323002
but it was overlooked. As of that CL, the flag does not do anything.

BUG=skia:1976
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/390033002

commit | commitdiff | tree

robertphillips [Mon, 14 Jul 2014 14:53:26 +0000 (07:53 -0700)]

Make SkPictureShader and SkPictureImageFilter use const SkPictures

R=mtklein@google.com, reed@google.com
TBR=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/390023002

commit | commitdiff | tree

scroggo [Mon, 14 Jul 2014 14:53:18 +0000 (07:53 -0700)]

Remove unused kImageIsOpaque_Flag.

This flag is never set or read. We now look at the alpha type to
determine opacity.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/385943003

commit | commitdiff | tree

djordje.pesut [Mon, 14 Jul 2014 14:48:11 +0000 (07:48 -0700)]

MIPS: added optimization for SkRGB16_Opaque_Blitter::blitMask

gaint is ~30%

R=djsollen@google.com

Author: djordje.pesut@imgtec.com

Review URL: https://codereview.chromium.org/357693002

commit | commitdiff | tree

piotaixr [Mon, 14 Jul 2014 14:48:04 +0000 (07:48 -0700)]

Deleted SkImage::newShaderClamp: not used, not implemented.

Implemented SkImage::newShader.

BUG=skia:2701, 344804
R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/345463009

commit | commitdiff | tree

Robert Phillips [Mon, 14 Jul 2014 13:28:15 +0000 (09:28 -0400)]

Reallow default SkPicture constructor for Chromium

This is breaking the Chromium build in:
external/chromium_org/android_webview/browser/browser_view_renderer.cc

TBR=reed@google.com

Review URL: https://codereview.chromium.org/392593002

commit | commitdiff | tree

robertphillips [Sun, 13 Jul 2014 17:09:42 +0000 (10:09 -0700)]

Make GrAtlas::removePlot static

This CL just calves off a small chunk of (Add atlased layer purging - https://codereview.chromium.org/367073002/).

R=jvanverth@google.com
TBR=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/388103002

commit | commitdiff | tree

Robert Phillips [Sun, 13 Jul 2014 16:00:50 +0000 (12:00 -0400)]

Remove Skia's use of the default SkPicture constructor and multi-clone

This cannot be landed until (Chrome: Switch to one-at-a-time SkPicture::clone interface - https://codereview.chromium.org/380323002/) has landed.

R=mtklein@google.com
TBR=reed@google.com

Review URL: https://codereview.chromium.org/388833003

commit | commitdiff | tree

robertphillips [Sun, 13 Jul 2014 14:55:53 +0000 (07:55 -0700)]

Remove SkPicture copy constructor

Given where we're heading with SkPicture why would you need to make a copy?

R=reed@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/381133002

commit | commitdiff | tree

reed [Sun, 13 Jul 2014 11:32:32 +0000 (04:32 -0700)]

Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels

This reverts commit 651eaeadeb0b1407f5fe192aeda90db1680fa2b8.

TBR=

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/390693002

commit | commitdiff | tree

reed [Sun, 13 Jul 2014 04:10:52 +0000 (21:10 -0700)]

don't draw unpremul alpha (yet)

without these early exits, we can treat unpremul colors as premul, generating asserts and wacky colors.

TBR=

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/386203002

commit | commitdiff | tree

reed [Sat, 12 Jul 2014 20:16:10 +0000 (13:16 -0700)]

Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/388803007/)

Reason for revert:
still failing (randomly?) bench sometimes. need stack dump to diagnose.

Original issue's description:
> Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
> usning it.
>
> Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)"
>
> This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce.
>
> TBR=scroggo@google.com
>
> Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/382543005

commit | commitdiff | tree

reed [Sat, 12 Jul 2014 19:26:36 +0000 (12:26 -0700)]

Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
usning it.

Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)"

This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce.

R=reed@chromium.org
TBR=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/388803007

commit | commitdiff | tree

halcanary [Sat, 12 Jul 2014 02:45:23 +0000 (19:45 -0700)]

Make SkPDFFont::fFontInfo a const pointer.

BUG=skia:2742
R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/383063007

commit | commitdiff | tree

jvanverth [Sat, 12 Jul 2014 02:45:16 +0000 (19:45 -0700)]

Refactor SkGrFontScaler and SkGrFontKey into non-virtual versions.

This is a pre-cleanup for another change, but has the side benefit of making
the code simpler in general.

No perf increase, despite removing virtual functions.

R=bsalomon@google.com, egdaniel@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/385263002

commit | commitdiff | tree

caryclark [Fri, 11 Jul 2014 20:21:17 +0000 (13:21 -0700)]

fix ios break

R=reed@android.com
TBR=reed
NOTREECHECKS=TRUE
NOTRY=TRUE

BUG=skia:

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/388933003

commit | commitdiff | tree

krajcevski [Fri, 11 Jul 2014 20:15:15 +0000 (13:15 -0700)]

Revert of Add support for NEON intrinsics to speed up texture compression. We can (https://codereview.chromium.org/390453002/)

Reason for revert:
Breaking chrome.

Original issue's description:
> Add support for NEON intrinsics to speed up texture compression. We can
> now convert the time that we would have spent uploading the texture to
> compressing it giving a net 50% memory savings for these things.
>
> Committed: https://skia.googlesource.com/skia/+/bc9205be0a1094e312da098348601398c210dc5a

R=robertphillips@google.com, mtklein@google.com, kevin.petit@arm.com
TBR=kevin.petit@arm.com, mtklein@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/384053003

commit | commitdiff | tree

scroggo [Fri, 11 Jul 2014 19:19:00 +0000 (12:19 -0700)]

No need to cache local matrix in picture shader.

Now that the local matrix cannot be changed, we no longer need
to keep track of it to regenerate the bitmap shader.

Depends on https://codereview.chromium.org/379323002

R=fmalita@google.com, fmalita@chromium.org

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/387043002

commit | commitdiff | tree

caryclark [Fri, 11 Jul 2014 19:14:51 +0000 (12:14 -0700)]

ios fixes

skia_ios.mm
Get the app's Documents directory and pass use it to set the resource path.
This is a quick hack which will be replaced by a new application that is
a tiny shim around a command line tool.

SkImageEncoder.h
SkForceLinking.cpp
SkImageDecoder_CG.cpp
Add support for FORCE_LINKING so iOS sees the PNG encoder and others.

SkFloatBits.cpp
SkPoint.cpp
Handle denormalized numbers that are floored by the iOS ARM processor.

SkImageDecoder_iOS.mm
Remove empty encoder factory.

SkTouchGesture.cpp
Return early on empty state on touch rather than aborting (crashing)

JpegTest.cpp
Hal via stackoverflow.com says partial jpegs can be gray as well.

skia_test.cpp
Remove crash handler call for now to avoid link failure.

OverwriteLine.h
Remove fancy line overwrite for iOS.

Resources.cpp
Add interface to set resource directory based on runtime query.

BUG=skia:2736 skia:2737 skia:2738
R=reed@google.com, halcanary@google.com, mtklein@google.com, tfarina@chromium.org

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/373383003

commit | commitdiff | tree

krajcevski [Fri, 11 Jul 2014 19:12:27 +0000 (12:12 -0700)]

Add support for NEON intrinsics to speed up texture compression. We can
now convert the time that we would have spent uploading the texture to
compressing it giving a net 50% memory savings for these things.

R=robertphillips@google.com, mtklein@google.com, kevin.petit@arm.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/390453002

commit | commitdiff | tree

mtklein [Fri, 11 Jul 2014 18:57:07 +0000 (11:57 -0700)]

nanobench: add a cute bar chart

Give this a try? Helpful, or gets in the way?

BUG=skia:
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/390483002

commit | commitdiff | tree

scroggo [Fri, 11 Jul 2014 18:33:52 +0000 (11:33 -0700)]

Remove SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX.

This is no longer needed by Android.

BUG=skia:1976
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/379323002

commit | commitdiff | tree

mtklein [Fri, 11 Jul 2014 18:27:01 +0000 (11:27 -0700)]

resizeimagefiler is ok with a BBH now

BUG=skia:
R=senorblanco@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/387933002

commit | commitdiff | tree

scroggo [Fri, 11 Jul 2014 17:45:11 +0000 (10:45 -0700)]

Use unpremul for premul_and_unpremul_alpha_ bench.

Using the wrong color type resulted in invalid colors.

R=bsalomon@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/382243005

commit | commitdiff | tree

scroggo [Fri, 11 Jul 2014 17:42:12 +0000 (10:42 -0700)]

Use SkShader's localMat for SkLocalMatrixShader.

Instead of setting SkShader::fLocalMatrix to Identity and storing
a separate SkMatrix inside SkLocalMatrixShader, reuse
SkShader::fLocalMatrix.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/386693003

commit | commitdiff | tree

senorblanco [Fri, 11 Jul 2014 17:09:02 +0000 (10:09 -0700)]

New Mac 10.6 x86_64 Debug baselines for perlin noise tests.

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384043002

commit | commitdiff | tree

bsalomon [Fri, 11 Jul 2014 17:01:02 +0000 (10:01 -0700)]

This moves us towards variable length effect keys. The overall program key now allows for it. After the header it stores an array of offsets to effect keys. This allows us to grab the effect keys to pass to effects when they generate code. It also ensures that we can't get a collision by sets of keys that are different lengths but are the same when appended together.

R=robertphillips@google.com, jvanverth@google.com, egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/356513003

commit | commitdiff | tree

senorblanco [Fri, 11 Jul 2014 16:56:03 +0000 (09:56 -0700)]

Fix for saveLayer() with filters vs. the BBox Hierarchy.

When building acceleration structures for SkPicture, we must transform
the primitive's bounds not only by its own SkPaint, but by the paints of
any saveLayer()s currently active above it.

We do this by pushing the SkPaint onto a stack on
saveLayer(), and popping them on restore(). We also push
a NULL paint in save(), so that the pushes and pops are
balanced.

BUG=skia:2734
R=mtklein@google.com, reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/380373003

commit | commitdiff | tree

egdaniel [Fri, 11 Jul 2014 16:13:37 +0000 (09:13 -0700)]

Revert of Remove gpu shader optimatization for solid white or trans black colors (https://codereview.chromium.org/375823005/)

Reason for revert:
possible test and gm failures

Original issue's description:
> Remove gpu shader optimatization for solid white or trans black colors
>
> Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.
>
> With optimization in (ms):
>          White       Blue        Checkered
> Linux    ~80         ~80         ~160
> N7       ~800        ~1100       ~1500
> Moto-e   ~830        ~1100       ~2500
>
> Without optimization in (ms):
>          White       Blue        Checkered
> Linux    ~80         ~80         ~80
> N7       ~1100       ~1100       ~1100
> Moto-e   ~1100       ~1100       ~1500
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/385163004

commit | commitdiff | tree

scroggo [Fri, 11 Jul 2014 16:05:32 +0000 (09:05 -0700)]

Revert of Remove public_headers.gypi, unneeded by Skia. (https://codereview.chromium.org/381633003/)

Reason for revert:
Breaking canary: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT/builds/1207/steps/Update/logs/stdio

Original issue's description:
> Remove public_headers.gypi, unneeded by Skia.
>
> This file not needed by Skia, and is almost always out of date.
> We recommend generating this inside Android WebView, where it is
> used. Generating it is relatively straightforward; here is one way:
> https://codereview.chromium.org/198063002/diff/110001/platform_tools/android/gyp_gen/gen_public_headers.py
>
> BUG=skia:2350
>
> Committed: https://skia.googlesource.com/skia/+/a3fce46f7c85eb3eb5c5373c1eaa0336d9756252

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2350

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/382153007

commit | commitdiff | tree

egdaniel [Fri, 11 Jul 2014 15:57:40 +0000 (08:57 -0700)]

Remove gpu shader optimatization for solid white or trans black colors

Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.

With optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~160
N7       ~800        ~1100       ~1500
Moto-e   ~830        ~1100       ~2500

Without optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~80
N7       ~1100       ~1100       ~1100
Moto-e   ~1100       ~1100       ~1500

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/375823005

commit | commitdiff | tree

epoger [Fri, 11 Jul 2014 15:52:35 +0000 (08:52 -0700)]

roll "common" DEPS, and replace tools/pyutils with it

BUG=skia:2682
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/385783002

commit | commitdiff | tree

bungeman [Fri, 11 Jul 2014 15:52:26 +0000 (08:52 -0700)]

Update find_name_and_attributes to take ttc index and rename to SkTypeface_FreeType::ScanFont.

The name 'ScanFont' is to mirror the naming convention of similar functions in FontConfig.

R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/382053003

commit | commitdiff | tree

djsollen [Fri, 11 Jul 2014 15:47:23 +0000 (08:47 -0700)]

explicitly add /data/local/tmp to the library path to support new AOSP restrictions

BUG=skia:2660
R=tomhudson@chromium.org, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/387893003

commit | commitdiff | tree

scroggo [Fri, 11 Jul 2014 15:47:16 +0000 (08:47 -0700)]

Remove public_headers.gypi, unneeded by Skia.

This file not needed by Skia, and is almost always out of date.
We recommend generating this inside Android WebView, where it is
used. Generating it is relatively straightforward; here is one way:
https://codereview.chromium.org/198063002/diff/110001/platform_tools/android/gyp_gen/gen_public_headers.py

BUG=skia:2350
R=robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/381633003

commit | commitdiff | tree

mtklein [Fri, 11 Jul 2014 15:42:17 +0000 (08:42 -0700)]

Slim Skia down to just one murmur3 implementation.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587

Committed: https://skia.googlesource.com/skia/+/67a3271f0de9ccc32d559b042b862528272047cc

Committed: https://skia.googlesource.com/skia/+/53d435990bdb4d14df78013da45a9364d0287ebe

CQ_EXTRA_TRYBOTS=tryserver.skia:Perf-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/376183004

commit | commitdiff | tree

bsalomon [Fri, 11 Jul 2014 15:42:11 +0000 (08:42 -0700)]

Add support for 64bit atomic inc/dec/cas

R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/377073002

commit | commitdiff | tree

jcgregorio [Fri, 11 Jul 2014 14:48:20 +0000 (07:48 -0700)]

Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)

Reason for revert:
Maybe causing crashes in bench.

http://108.170.220.120:10117/builders/Test-ChromeOS-Daisy-MaliT604-Arm7-Debug/builds/2608/steps/RunBench/logs/stdio

Original issue's description:
> add readPixels() to SkBitmap
>
> BUG=chromium:390782
>
> Committed: https://skia.googlesource.com/skia/+/c4f216151b6ade70c35fade09a353052f40236b1

R=scroggo@google.com, bsalomon@google.com, reed@google.com
TBR=bsalomon@google.com, reed@google.com, scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=chromium:390782

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/382243003

commit | commitdiff | tree

jcgregorio [Fri, 11 Jul 2014 13:51:59 +0000 (06:51 -0700)]

Pin to a newer version of ANGLE than M36 branch.

R=robertphillips@google.com
TBR=robertphillips@google.com

BUG=skia:

NOTRY=true

NOTREECHECKS=true

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/390433002

commit | commitdiff | tree

robertphillips [Fri, 11 Jul 2014 13:45:58 +0000 (06:45 -0700)]

Revert of Add alternate SkPicture::clone (https://codereview.chromium.org/381193002/)

Reason for revert:
Going to try to just remove the many-at-once clone interface

Original issue's description:
> Add alternate SkPicture::clone
>
> This adds an alternate version of SkPicture::clone for two reasons:
>
> 1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor)
>
> 2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely.
>
> Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/)
>
> Committed: https://skia.googlesource.com/skia/+/e372e78223a8ce916d276d6e0420d552fb0267e9

R=mtklein@google.com, reed@google.com
TBR=mtklein@google.com, reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/386933004

commit | commitdiff | tree

bensong [Fri, 11 Jul 2014 13:34:58 +0000 (06:34 -0700)]

manual bench rebase after bf0b9ce

R=robertphillips@google.com, jcgregorio@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

NOTREECHECKS=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/385073005

commit | commitdiff | tree

jcgregorio [Fri, 11 Jul 2014 13:30:55 +0000 (06:30 -0700)]

Pin to a specific version of ANGLE.

Pulling from HEAD is dangerous, as we now know. This change is a temporary fix
to open the tree, we need a system for which version of ANGLE we are pinning to.

BUG=skia:

NOTRY=true

NOTREECHECKS=true
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/387893002

commit | commitdiff | tree

bungeman [Thu, 10 Jul 2014 22:18:23 +0000 (15:18 -0700)]

Add file access modes to sk_exists.

Both Windows and Posix 'access' calls take a mode parameter which,
in addition to checking existence, checks access modes.
This change exposes this functionality.

R=mtklein@google.com, reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/384903002

commit | commitdiff | tree

reed [Thu, 10 Jul 2014 21:29:43 +0000 (14:29 -0700)]

Revert of Slim Skia down to just one murmur3 implementation. (https://codereview.chromium.org/376183004/)

Reason for revert:
broke 10.6 compile

[17:13:56.863876] [4/336] CXX obj/src/core/core.SkBBoxHierarchyRecord.o
[17:13:56.863997] FAILED: c++ -MMD -MF obj/src/core/core.SkBBoxRecord.o.d -DSK_INTERNAL -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=1 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCEFIELD_FONTS=0 -DSK_SCALAR_IS_FLOAT -DSK_BUILD_FOR_MAC -DSK_USE_POSIX_THREADS -DSK_RELEASE -DNDEBUG -I../../include/config -I../../include/core -I../../include/pathops -I../../include/pipe -I../../include/ports -I../../include/utils -I../../include/xml -I../../src/core -I../../src/sfnt -I../../src/image -I../../src/opts -I../../src/utils -I../../include/utils/mac -I../../include/gpu -I../../src/gpu -fasm-blocks -mpascal-strings -O3 -gdwarf-2 -Wnewline-eof -mmacosx-version-min=10.6 -arch x86_64 -mssse3 -fvisibility=hidden -fvisibility-inlines-hidden  -c ../../src/core/SkBBoxRecord.cpp -o obj/src/core/core.SkBBoxRecord.o
[17:13:56.864085] In file included from ../../src/core/SkPictureFlat.h:14,
[17:13:56.864130]                  from ../../src/core/SkPictureData.h:14,
[17:13:56.864173]                  from ../../src/core/SkPictureRecord.h:18,
[17:13:56.864217]                  from ../../src/core/SkBBoxRecord.h:12,
[17:13:56.864261]                  from ../../src/core/SkBBoxRecord.cpp:9:
[17:13:56.864336] ../../src/core/SkChecksum.h: In static member function ‘static uint32_t SkChecksum::Compute(const uint32_t*, size_t)’:
[17:13:56.864397] ../../src/core/SkChecksum.h:127: error: invalid conversion from ‘const uint32_t*’ to ‘const uint32_t*’
[17:13:56.864462] ../../src/core/SkChecksum.h:128: error: invalid conversion from ‘const uint32_t*’ to ‘const uint32_t*’
[17:13:56.864510] ../../src/core/SkChecksum.h:129: error: comparison between distinct pointer types ‘const uint32_t*’ and ‘const uint32_t*’ lacks a cast

Original issue's description:
> Slim Skia down to just one murmur3 implementation.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587
>
> Committed: https://skia.googlesource.com/skia/+/67a3271f0de9ccc32d559b042b862528272047cc
>
> Committed: https://skia.googlesource.com/skia/+/53d435990bdb4d14df78013da45a9364d0287ebe

R=mtklein@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/381253003

commit | commitdiff | tree

mtklein [Thu, 10 Jul 2014 21:16:04 +0000 (14:16 -0700)]

Enable tools/CrashHandler again.

  - Defaults to on the bots, triggered off CHROME_HEADLESS=1 in the environment.
  - Defaults off otherwise.
  - Can be enabled by setting CHROME_HEADLESS=1 (weird) or GYP_DEFINES=skia_crash_handler=1.

BUG=skia:
R=borenet@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/383813002

commit | commitdiff | tree

reed [Thu, 10 Jul 2014 21:15:57 +0000 (14:15 -0700)]

add readPixels() to SkBitmap

BUG=chromium:390782
R=scroggo@google.com, bsalomon@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/377303002

commit | commitdiff | tree

robertphillips [Thu, 10 Jul 2014 21:10:58 +0000 (14:10 -0700)]

Add alternate SkPicture::clone

This adds an alternate version of SkPicture::clone for two reasons:

1) Chromium uses the SkPicture copy constructor to unpack the pictures from the old-style clone interface (and I would like to remove the copy ctor)

2) This is part of the long term plan to wean Chrome off of cloning. Once pictures are thread safe we will switch the new SkPicture::clone call to just return 'this'. From there it is a small step to removing clone entirely.

Note that the two versions of clone() is temporary. Once this is landed (and rolled) I will land a Chrome-side patch to remove their use of the old interface (Use new SkPicture::clone interface - https://codereview.chromium.org/380323002/)

R=mtklein@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/381193002

commit | commitdiff | tree

mtklein [Thu, 10 Jul 2014 21:10:45 +0000 (14:10 -0700)]

Slim Skia down to just one murmur3 implementation.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587

Committed: https://skia.googlesource.com/skia/+/67a3271f0de9ccc32d559b042b862528272047cc

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/376183004

commit | commitdiff | tree

Ben Wagner [Thu, 10 Jul 2014 20:21:49 +0000 (16:21 -0400)]

Handle NULL typeface in SampleApp.

It is possible that SampleApp will use the NULL typeface as the default.
This is valid and should be handled properly on shutdown.

commit | commitdiff | tree

senorblanco [Thu, 10 Jul 2014 20:02:30 +0000 (13:02 -0700)]

Yet more perlin noise rebaselines.

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/385733003

commit | commitdiff | tree

senorblanco [Thu, 10 Jul 2014 19:42:01 +0000 (12:42 -0700)]

You guessed it -- more perlin noise rebaselines.

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/386693002

commit | commitdiff | tree

senorblanco [Thu, 10 Jul 2014 19:01:29 +0000 (12:01 -0700)]

Ibid.

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381223002

commit | commitdiff | tree

senorblanco [Thu, 10 Jul 2014 18:57:26 +0000 (11:57 -0700)]

Yet more perlin noise rebaselines.

(Apparently my rebaseline_server skills leave something to be desired.)

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384863002

commit | commitdiff | tree

senorblanco [Thu, 10 Jul 2014 18:29:20 +0000 (11:29 -0700)]

Some more perlinnoise rebaselines.

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381973002

commit | commitdiff | tree

mtklein [Thu, 10 Jul 2014 18:24:18 +0000 (11:24 -0700)]

Use a consume load in SkLazyPtr.

This only affects ARM, where an acquire needs a memory barrier but consume does not. I am interested to see if there's a noticeable effect on the Android bots.

BUG=skia:

NOTRY=true
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/381143002

commit | commitdiff | tree

robertphillips [Thu, 10 Jul 2014 18:24:12 +0000 (11:24 -0700)]

Re-add friend Chrome requires

R=jcgregorio@google.com
TBR=jcgregorio@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/381963002

commit | commitdiff | tree

mtklein [Thu, 10 Jul 2014 18:11:50 +0000 (11:11 -0700)]

Split SkTRacy into SkTRacy and SkTRacyReffable.

Looks like TSAN can't always suppress our existing implementation of SkTRacy
(what is turning here into SkTRacyReffable). To minimize flakiness, use
SkTRacy where possible and SkTRacyReffable where necessary.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/497cda3a6b72b9cb390334e8756d38b4ffac044f

NOTRY=true
R=robertphillips@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/388503002

commit | commitdiff | tree

senorblanco [Thu, 10 Jul 2014 17:52:21 +0000 (10:52 -0700)]

New baselines for perlin noise changes.

Pixel results affected by ca6a7c29452e13cf63bb4e225972065cbfe6e265

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/385643003

commit | commitdiff | tree

mtklein [Thu, 10 Jul 2014 17:38:22 +0000 (10:38 -0700)]

Split SkTRacy into SkTRacy and SkTRacyReffable.

Looks like TSAN can't always suppress our existing implementation of SkTRacy
(what is turning here into SkTRacyReffable). To minimize flakiness, use
SkTRacy where possible and SkTRacyReffable where necessary.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/388503002

commit | commitdiff | tree

Derek Sollenberger [Thu, 10 Jul 2014 17:04:24 +0000 (13:04 -0400)]

Add config to build mips with dsp2 optimizations enabled by default.

R=borenet@google.com

Review URL: https://codereview.chromium.org/380213004

commit | commitdiff | tree

robertphillips [Thu, 10 Jul 2014 16:35:12 +0000 (09:35 -0700)]

Cleanup SkPicture* classes a bit

This is an attempt to reduce the number of friends the various SkPicture* classes have.
Probably the only controversial part is making getBitmap, getPath, getPicture and getPaint
public on SkPictureData (and adding a new initIterator entry point).

R=mtklein@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/384753004

commit | commitdiff | tree

epoger [Thu, 10 Jul 2014 16:03:23 +0000 (09:03 -0700)]

import google-api-python-client using DEPS

BUG=skia:2641
R=jcgregorio@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/381933002

Domain: Dotnet / API;