David Zeuthen [Mon, 20 Jun 2011 20:32:03 +0000 (16:32 -0400)]
GDBus: Unref worker from worker-thread to avoid race
... otherwise we might end up using the worker after it has been
freed. Reported by Dan Winship and Colin Walters.
This fix uncovered a bug in the /gdbus/nonce-tcp test case so "fix"
that as well to use a better way of having one thread wait for another
(using quotes for the word "fix" since it's pretty hackish to
busy-wait in one thread to wait for another).
Signed-off-by: David Zeuthen <davidz@redhat.com>
Colin Walters [Mon, 20 Jun 2011 18:09:31 +0000 (14:09 -0400)]
gthread tests: Remove spurious return;
Colin Walters [Mon, 20 Jun 2011 15:15:27 +0000 (11:15 -0400)]
gclosure: Add G_TYPE_ENUM and G_TYPE_PARAM for g_cclosure_marshal_generic()
These are fundamental types missed in the original commit.
Colin Walters [Mon, 20 Jun 2011 17:41:52 +0000 (13:41 -0400)]
gdbus-test-codegen: Allocate full integer space for uint16 properties
Because there is no G_TYPE_[U]INT16, we need to use integer types,
otherwise we'll end up overwriting memory (in this case on the stack).
Javier Jardón [Mon, 20 Jun 2011 10:48:25 +0000 (11:48 +0100)]
configure.ac: Generate xz tarballs by default
Chun-wei Fan [Mon, 20 Jun 2011 03:50:57 +0000 (11:50 +0800)]
Visual C++ 2010 project files update
Consolidate my previous commit into property file... should have realized
this sooner...
Chun-wei Fan [Mon, 20 Jun 2011 03:34:15 +0000 (11:34 +0800)]
Update Visual C++ 2010 Projects
-Seperate intermediate directories for each project to avoid intermittent
MSBuild errors that a build log cannot be written while in use, and
update the property sheet as necessary.
-Minor cleanups of uneeded tags in the projects/properties
Christian Persch [Sat, 18 Jun 2011 14:22:53 +0000 (16:22 +0200)]
Clarify nul-termination of g_utf8_to_ucs4[_fast] result
The docs for g_utf8_to_ucs4_fast didn't mention that the resulting
string is terminated by a 0 character.
Bug #652897.
Matthias Clasen [Sun, 19 Jun 2011 05:42:48 +0000 (01:42 -0400)]
Add tests for GCache
Matthias Clasen [Sun, 19 Jun 2011 05:05:26 +0000 (01:05 -0400)]
asyncqueue: improve test coverage
Matthias Clasen [Sun, 19 Jun 2011 05:05:05 +0000 (01:05 -0400)]
utils: silence tests unless verbose
Matthias Clasen [Sun, 19 Jun 2011 05:04:48 +0000 (01:04 -0400)]
logging: improve test coverage
Matthias Clasen [Sun, 19 Jun 2011 05:04:30 +0000 (01:04 -0400)]
hash: Improve test coverage
Chun-wei Fan [Sat, 18 Jun 2011 09:55:58 +0000 (17:55 +0800)]
Update gsettings/glib-compile-schemas VS Projects
These tools require the use of GModule headers also, so update the include
directories so that the correct gmodule.h will be included instead of the
system-installed version.
Colin Walters [Fri, 17 Jun 2011 13:39:48 +0000 (09:39 -0400)]
gvariant: Mark g_variant_new_variant as constructor
https://bugzilla.gnome.org/show_bug.cgi?id=647796
Colin Walters [Fri, 17 Jun 2011 12:52:05 +0000 (08:52 -0400)]
gdatainputstream: Add Since: tags and update gio-sections.txt
https://bugzilla.gnome.org/show_bug.cgi?id=652758
Colin Walters [Thu, 16 Jun 2011 18:00:36 +0000 (14:00 -0400)]
GDataInputStream: Add _utf8() variants of _read_line
These will validate the resulting line, and throw a conversion error.
In practice these will likely be used by bindings, but it's good
for even C apps too that don't want to explode if that text file
they're reading into Pango actually has invalid UTF-8.
https://bugzilla.gnome.org/show_bug.cgi?id=652758
Colin Walters [Thu, 16 Jun 2011 17:14:44 +0000 (13:14 -0400)]
GDataInputStream: Clarify read_line() docs, mark as byte array
g_data_input_stream_read_line() and
g_data_input_stream_read_line_finish() don't do any encoding checks,
so we shouldn't call the returned value a "string" (which I'd like to
mean UTF-8). Annotate them as byte arrays and add encoding warnings
to the docstrings.
https://bugzilla.gnome.org/show_bug.cgi?id=652758
Patrick Welche [Tue, 14 Jun 2011 08:43:33 +0000 (09:43 +0100)]
Fix build due to trivial typos in
ab0e9dbf.
https://bugzilla.gnome.org/show_bug.cgi?id=652750
Murray Cumming [Wed, 15 Jun 2011 08:47:13 +0000 (10:47 +0200)]
G_STATIC_REC_MUTEX_INIT: Add a 0 to the initialization.
This avoids a compiler warning about an incomplete initialization
when using this.
Ryan Lortie [Wed, 15 Jun 2011 02:44:10 +0000 (22:44 -0400)]
Drop dead code in GVariant parser
There is no chance that an unsigned integer value will be negative after
we do the bounds check that enforces its non-negativity.
Caught by Matthias running Coverity.
Matthias Clasen [Wed, 15 Jun 2011 00:44:15 +0000 (20:44 -0400)]
Eliminate some dead code
Matthias Clasen [Wed, 15 Jun 2011 00:36:37 +0000 (20:36 -0400)]
Remove a redundant NULL check
Matthias Clasen [Wed, 15 Jun 2011 00:15:04 +0000 (20:15 -0400)]
Silence a compiler warning
Matthias Clasen [Tue, 14 Jun 2011 23:52:19 +0000 (19:52 -0400)]
Add some argument checks to filename conversion functions
Colin Walters [Tue, 14 Jun 2011 22:46:06 +0000 (18:46 -0400)]
gmain: Close race condition in _g_main_wake_up_all_contexts()
Running gthread/tests/spawn-multithreaded in a loop, I very easily hit:
GLib-CRITICAL **: g_main_context_wakeup: assertion `g_atomic_int_get (&context->ref_count) > 0' failed
Testing the refcount still left a window where we would fall into the
assertion. Fix this by just locking the context.
Colin Walters [Wed, 8 Jun 2011 15:31:14 +0000 (11:31 -0400)]
gmain: Only run through signal delivery once per read()
This is what I intended to do before.
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Sat, 11 Jun 2011 16:10:57 +0000 (12:10 -0400)]
gmain: Use sigset_t for keeping track of installed signals
Minor code cleanup.
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Fri, 10 Jun 2011 14:48:07 +0000 (10:48 -0400)]
gspawn: Reset signal handlers for synchronous spawning
We should by default reset signal handlers; particularly with the
ability to install them via g_unix_signal_source_new(), we don't
want to call a user callback inside a fork()ed helper process.
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Sat, 11 Jun 2011 21:25:13 +0000 (17:25 -0400)]
glib/tests/unix.c: Also test SIGTERM
We expect this to not kill the process, so it'd be a good one to test.
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Fri, 10 Jun 2011 14:35:27 +0000 (10:35 -0400)]
spawn-multithreaded: Clean up IO channel code
I modeled the new bits after how gunixmount.c handles GIOChannel;
it's apparently easier not to look at the condition.
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Fri, 10 Jun 2011 14:14:25 +0000 (10:14 -0400)]
gspawn: Handle EINTR in a few more cases
I was debugging gthread/tests/spawn-multithreaded.c, and while I
don't think I actually hit EINTR in any of these cases, it'd be
good to fix them anyways.
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Fri, 10 Jun 2011 11:29:28 +0000 (07:29 -0400)]
spawn-singlethread.c: New test
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Colin Walters [Fri, 10 Jun 2011 11:27:29 +0000 (07:27 -0400)]
spawn-multithreaded: Also look for lt-test-echo
I hate libtool =(
https://bugzilla.gnome.org/show_bug.cgi?id=652072
Matthias Clasen [Tue, 14 Jun 2011 20:32:55 +0000 (16:32 -0400)]
If dup fails don't call close()
Matthias Clasen [Tue, 14 Jun 2011 20:20:26 +0000 (16:20 -0400)]
Remove a redundant assertion
A gsize is never going below 0.
Matthias Clasen [Tue, 14 Jun 2011 20:18:45 +0000 (16:18 -0400)]
Don't compare unsigned numbers with 0
It does not work.
David Zeuthen [Tue, 14 Jun 2011 22:11:09 +0000 (18:11 -0400)]
GDBusMessage: Optimize serializer and deserializer
... by using a switch instead of if-then-else.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Colin Walters [Tue, 14 Jun 2011 16:28:57 +0000 (12:28 -0400)]
gclosure: Add missing include
Matthias Clasen [Tue, 14 Jun 2011 15:40:32 +0000 (11:40 -0400)]
Don't do < 0 on an unsigned value
It won't work. read() returns a signed value, anyway.
Matthias Clasen [Tue, 14 Jun 2011 14:16:35 +0000 (10:16 -0400)]
Silence a compiler warning
Even though we are confident the filename will always
end in .gmarkup, the compiler doesn't know that...
Matthias Clasen [Tue, 14 Jun 2011 14:12:46 +0000 (10:12 -0400)]
Don't leak resources in error cases
Matthias Clasen [Tue, 14 Jun 2011 14:07:22 +0000 (10:07 -0400)]
Don't forget to free resources in an early return
Matthias Clasen [Tue, 14 Jun 2011 14:04:06 +0000 (10:04 -0400)]
Avoid a deref-before-NULL-check warning
Matthias Clasen [Tue, 14 Jun 2011 13:53:26 +0000 (09:53 -0400)]
Remove unneeded NULL check
We ensure 10 lines up that parameters is not NULL.
Matthias Clasen [Tue, 14 Jun 2011 13:50:55 +0000 (09:50 -0400)]
Remove an unneeded NULL check
data->proxy cannot be NULL here, or we'd have crashed 10 lines up.
Matthias Clasen [Tue, 14 Jun 2011 13:44:45 +0000 (09:44 -0400)]
Silence an uninitialize variable warning
Matthias Clasen [Tue, 14 Jun 2011 11:17:06 +0000 (07:17 -0400)]
Fix up symbol lists and docs
Xan Lopez [Thu, 9 Jun 2011 21:50:22 +0000 (23:50 +0200)]
gclosure: add missing fundamental types to generic marshaler
for GObject type the ffi->gvalue conversion was not handled. The
GFlags type was completely missing.
Vincent Untz [Tue, 14 Jun 2011 07:01:25 +0000 (09:01 +0200)]
GDesktopAppInfo: Fix declaration of g_desktop_app_info_get_nodisplay
Vincent Untz [Sun, 12 Jun 2011 10:22:59 +0000 (12:22 +0200)]
GDesktopAppInfo: Add g_desktop_app_info_get_nodisplay
Necessary for rebasing gnome-menus on top of GDesktopAppInfo.
https://bugzilla.gnome.org/show_bug.cgi?id=652385
Matthias Clasen [Tue, 14 Jun 2011 03:54:59 +0000 (23:54 -0400)]
bump version
Matthias Clasen [Tue, 14 Jun 2011 01:58:33 +0000 (21:58 -0400)]
2.29.8
Matthias Clasen [Tue, 14 Jun 2011 03:19:45 +0000 (23:19 -0400)]
Fix doc generation
It helps to use the same file name on both ends...
Matthias Clasen [Tue, 14 Jun 2011 02:48:54 +0000 (22:48 -0400)]
Use a realistic timeout in a test
Who knew that g_test_trap_fork() takes a timeout in microseconds...
Matthias Clasen [Tue, 14 Jun 2011 00:48:20 +0000 (20:48 -0400)]
Update NEWS
Colin Walters [Mon, 13 Jun 2011 18:17:44 +0000 (14:17 -0400)]
gdbus-codegen tests: Fix usage of top_srcddir
Based on a patch from Rico Tzschichholz.
Ryan Lortie [Mon, 13 Jun 2011 13:27:41 +0000 (09:27 -0400)]
Formally deprecate G_CONST_RETURN
Ryan Lortie [Mon, 13 Jun 2011 13:27:28 +0000 (09:27 -0400)]
Drop a few more G_CONST_RETURN
Dan Winship [Sun, 12 Jun 2011 20:17:30 +0000 (16:17 -0400)]
update .gitignores
Colin Walters [Fri, 10 Jun 2011 16:58:49 +0000 (12:58 -0400)]
gspawn: Fix annotations
g-ir-scanner wants guint8.
Christophe Fergeau [Thu, 9 Jun 2011 11:36:19 +0000 (13:36 +0200)]
Fix regression in qsort_r BSD detection
We can use AC_CHECK_FUNCS to detect if qsort_r is available on
the system or not since it will unconditionnally define
HAVE_QSORT_R, which we don't want since on BSD, qsort_r isn't usable
for us, so we don't want to have HAVE_QSORT_R defined on such platforms.
By using AC_CHECK_FUNC instead, we can defer defining HAVE_QSORT_R until
we have actually tested it's usable.
https://bugzilla.gnome.org/show_bug.cgi?id=651920
Yaron Shahrabani [Fri, 10 Jun 2011 09:54:51 +0000 (12:54 +0300)]
Updated Hebrew translation.
Mario Blättermann [Fri, 10 Jun 2011 09:17:15 +0000 (11:17 +0200)]
[l10n] Updated German translation
Abduxukur Abdurixit [Fri, 10 Jun 2011 08:19:12 +0000 (10:19 +0200)]
Added UG translation
Jorge González [Thu, 9 Jun 2011 21:00:04 +0000 (23:00 +0200)]
Updated Spanish translation
Murray Cumming [Thu, 9 Jun 2011 18:17:52 +0000 (20:17 +0200)]
gioenums.h: Remove trailing commas
David Zeuthen [Thu, 9 Jun 2011 17:29:58 +0000 (13:29 -0400)]
gdbus: Don't pass an unintialized GError pointer
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 9 Jun 2011 17:22:18 +0000 (13:22 -0400)]
gdbus: Add --recurse and --only-properties options
These options are useful when debugging D-Bus services and working
with bug reports.
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 9 Jun 2011 16:25:04 +0000 (12:25 -0400)]
gdbus: Clarify the --xml option in the man page
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 9 Jun 2011 16:02:30 +0000 (12:02 -0400)]
Bug 652197 – Improper handling of double values in GDBusMessage
Matthew Bucknall pointed out
GDBusMessage does not serialize/deserialize double values correctly
on platforms with strict alignment constraints (in my particular
case, ARM926EJ-S).
This was reported in
https://bugzilla.gnome.org/show_bug.cgi?id=652197
Signed-off-by: David Zeuthen <davidz@redhat.com>
David Zeuthen [Thu, 9 Jun 2011 15:51:47 +0000 (11:51 -0400)]
gdbus-codegen: Fix build
See https://bugzilla.gnome.org/show_bug.cgi?id=651998 for details.
Signed-off-by: David Zeuthen <davidz@redhat.com>
Ryan Lortie [Sun, 13 Mar 2011 03:04:53 +0000 (22:04 -0500)]
Document the deprecatation of G_CONST_RETURN
...but don't actually deprecate it yet.
Ryan Lortie [Sun, 13 Mar 2011 02:50:45 +0000 (21:50 -0500)]
Remove all uses of G_CONST_RETURN
Just use 'const'.
https://bugzilla.gnome.org/show_bug.cgi?id=644611
Ryan Lortie [Thu, 9 Jun 2011 15:11:30 +0000 (11:11 -0400)]
gobject: remove -DG_DISABLE_CONST_RETURNS
GObject had a few cases of depending on G_CONST_RETURN not being defined
to 'const'. Remove those in preparation for deprecation of
G_CONST_RETURN.
Alexander Shopov [Thu, 9 Jun 2011 04:00:57 +0000 (07:00 +0300)]
Updated Bulgarian translation
Matthias Clasen [Thu, 9 Jun 2011 03:48:55 +0000 (23:48 -0400)]
Move gmain docs inline
Matthias Clasen [Thu, 9 Jun 2011 03:44:39 +0000 (23:44 -0400)]
Move gutils docs inline
Matthias Clasen [Thu, 9 Jun 2011 03:29:21 +0000 (23:29 -0400)]
Remove unused template
Christophe Fergeau [Wed, 8 Jun 2011 09:18:26 +0000 (11:18 +0200)]
bitlock: don't use asm goto on older gcc
asm goto was addded in gcc 4.5 so don't try to use it on gcc versions
older than this one. This is achieved by explicitly checking gcc
version, an alternative would be to try to compile a program using
asm volatile in configure.
https://bugzilla.gnome.org/show_bug.cgi?id=651959
Matthias Clasen [Thu, 9 Jun 2011 02:38:11 +0000 (22:38 -0400)]
Test the previous fix
Just make one of the existing GApplication test cases use
a dash in the id.
Ryan Lortie [Thu, 9 Jun 2011 02:21:15 +0000 (22:21 -0400)]
GApplication: allow '-' in application ID
By converting it to _ before trying to shove it into an object path.
https://bugzilla.gnome.org/show_bug.cgi?id=652025
Colomban Wendling [Tue, 7 Jun 2011 19:59:15 +0000 (21:59 +0200)]
Fix a typo in GBinding
https://bugzilla.gnome.org/show_bug.cgi?id=652081
Javier Jardón [Wed, 8 Jun 2011 15:26:08 +0000 (16:26 +0100)]
gconverter: Improve cross-references
Dan Winship [Tue, 7 Jun 2011 21:22:58 +0000 (17:22 -0400)]
Fix export_symbols variable in gio/Makefile.am
https://bugzilla.gnome.org/show_bug.cgi?id=646608
Dan Winship [Tue, 7 Jun 2011 21:19:24 +0000 (17:19 -0400)]
Fix "Since" tags on g_data_input_stream_read_upto{,_async}
https://bugzilla.gnome.org/show_bug.cgi?id=647930
Giovanni Campagna [Sun, 3 Apr 2011 16:53:04 +0000 (18:53 +0200)]
gutils, gspawn: fix introspection annotations
Fix various (out) arguments, (allow-none) and (array zero-terminated=1)
for g_spawn_*() and some others.
Some additional fixes by Colin Walters <walters@verbum.org>
https://bugzilla.gnome.org/show_bug.cgi?id=646635
Colin Walters [Tue, 7 Jun 2011 21:07:46 +0000 (17:07 -0400)]
Update annotations from gobject-introspection/gir/glib-2.0.c
This covers most of them.
Colin Walters [Tue, 7 Jun 2011 20:26:43 +0000 (16:26 -0400)]
glib-types.h: Include glib.h, since we use G_BEGIN_DECLS
This header is included individually by g-ir-scanner.
Colin Walters [Fri, 3 Jun 2011 18:53:27 +0000 (14:53 -0400)]
Generate $module-public-headers.txt file, feed it to gtk-doc
Rather than having the gtk-doc build machinery have a list of header
files to exclude, change the GLib build to dump a list of public
header files generated from the maintained Makefile.am files for
each of glib/, gobject/, gio/.
Also, for glib, always install glib-unix.h, even on non-Unix
platforms, for the same reason we install gwin32.h even on Unix.
https://bugzilla.gnome.org/show_bug.cgi?id=651745
Colin Walters [Tue, 7 Jun 2011 18:17:11 +0000 (14:17 -0400)]
gdbus-codegen: Clean config.pyc to make distcheck happy
Colin Walters [Tue, 7 Jun 2011 17:02:41 +0000 (13:02 -0400)]
g_get_user_data_dir(): Don't warn if XDG_RUNTIME_DIR isn't set
We have a meaningful fallback, and warning causes the tests to break.
Kjartan Maraas [Tue, 7 Jun 2011 08:02:40 +0000 (10:02 +0200)]
Updated Norwegian bokmål translation
Marek Černocký [Tue, 7 Jun 2011 06:08:16 +0000 (08:08 +0200)]
Updated Czech translation
Matthias Clasen [Tue, 7 Jun 2011 03:24:36 +0000 (23:24 -0400)]
Add a testcase for the previous fix
Matthias Clasen [Tue, 7 Jun 2011 03:23:29 +0000 (23:23 -0400)]
GDataList: don't hold the bitlock over callbacks
g_datalist_id_clear_i was dropping the dataset lock around
the destroy notifies, but kept the bitlock. This was causing
deadlocks when finalizing widgets.
Chun-wei Fan [Tue, 7 Jun 2011 02:58:54 +0000 (10:58 +0800)]
Update VS 2008/2010 property sheets
"Install" the new gobject/glib-types.h as well... it is needed.
Chun-wei Fan [Tue, 7 Jun 2011 02:49:29 +0000 (10:49 +0800)]
Update gsettings utilities in GIO
Avoid C99-style variable declaration
Chun-wei Fan [Tue, 7 Jun 2011 02:32:47 +0000 (10:32 +0800)]
Update config.h.win32.in
-Make contents more like the current config.h(.in)
-vsnprintf is included in VS 2008+
Chun-wei Fan [Tue, 7 Jun 2011 00:55:31 +0000 (08:55 +0800)]
Update the year in the *.rc.in files
Sorry this change came a bit late...