mikelawther@chromium.org [Wed, 27 Jun 2012 18:23:09 +0000 (18:23 +0000)]
CSS3 calc: blending involving expressions
https://bugs.webkit.org/show_bug.cgi?id=86160
Reviewed by Tony Chang.
Source/WebCore:
If either endpoint of a blend involves a calc expression, we create a new
expression to perform the blend calculation.
Test: css3/calc/transitions.html
css3/calc/transitions-dependent.html
* platform/Length.cpp:
(WebCore):
(WebCore::Length::blendCalculation):
* platform/Length.h:
(WebCore::Length::blend):
(Length):
LayoutTests:
Removed existing test as it was folded into transitions.html.
* css3/calc/transition-start-end-with-calc-expected.txt: Removed.
* css3/calc/transition-start-end-with-calc.html: Removed.
* css3/calc/transitions-dependent-expected.txt: Added.
* css3/calc/transitions-dependent.html: Added.
* css3/calc/transitions-expected.txt: Added.
* css3/calc/transitions.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121351
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Wed, 27 Jun 2012 17:48:23 +0000 (17:48 +0000)]
[Shadow] Triggers assertion in VisibleSelection::adjustSelectionToAvoidCrossingBoundaries()
https://bugs.webkit.org/show_bug.cgi?id=89918
Reviewed by Ryosuke Niwa.
This patch adds a testcase of selection from Shadow DOM to some elements outside of shadow host.
r121303, which is a patch for another issue, fixed this issue.
* editing/shadow/breaking-editing-boundaries-2-expected.txt: Added.
* editing/shadow/breaking-editing-boundaries-2.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121350
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 17:45:24 +0000 (17:45 +0000)]
Move CSSWrapShape style resolution from StyleResolver to StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=89668
Patch by Hans Muller <hmuller@adobe.com> on 2012-06-27
Reviewed by Andreas Kling.
Moved the resolution of the shapeInside and shapeOutside CSS properties
from the StyleResolver class to StyleBuilder. This is just refactoring
in preparation for fixing https://bugs.webkit.org/show_bug.cgi?id=89670.
No new tests were required.
* css/StyleBuilder.cpp:
(WebCore):
(ApplyPropertyWrapShape):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121349
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
achicu@adobe.com [Wed, 27 Jun 2012 17:38:05 +0000 (17:38 +0000)]
Blur filter causes issues when scrolling
https://bugs.webkit.org/show_bug.cgi?id=89475
Reviewed by Simon Fraser.
Source/WebCore:
This patch disables the fast scrolling when there is a fixed postioned element that
has a filter applied on its parent layer. Otherwise the scroll blitting will just
copy the outsets of the blur effect.
Test: css3/filters/blur-filter-page-scroll.html
* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):
LayoutTests:
Checking that the fixed positioned element repaints correctly when there is a blur filter
applied on its parent layer.
* css3/filters/blur-filter-page-scroll.html: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-expected.png: Added.
* platform/chromium/css3/filters/blur-filter-page-scroll-expected.txt: Added.
* platform/chromium/TestExpectations: The new test needs to be checked on Windows.
* platform/mac/css3/filters/blur-filter-page-scroll-expected.png: Added.
* platform/mac/css3/filters/blur-filter-page-scroll-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121348
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kling@webkit.org [Wed, 27 Jun 2012 17:22:30 +0000 (17:22 +0000)]
REGRESSION(r121296): New zero-size background tests asserting on Mac.
<http://webkit.org/b/90071>
Reviewed by Dan Bernstein.
Remove ASSERT(patternTransform.isInvertible()) as this is now a valid scenario.
* platform/graphics/cg/ImageCG.cpp:
(WebCore::Image::drawPattern):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121347
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 27 Jun 2012 16:55:51 +0000 (16:55 +0000)]
[Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
https://bugs.webkit.org/show_bug.cgi?id=90081
Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
Reviewed by Noam Rosenthal.
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121346
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Wed, 27 Jun 2012 15:52:00 +0000 (15:52 +0000)]
[WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
https://bugs.webkit.org/show_bug.cgi?id=90061
Reviewed by Gustavo Noronha Silva.
Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
this flag libtool tells the linker to set the rpath for the output
file to the full path of the .libs directory, instead of using a
wrapper script to set up the LD_LIBRARY_PATH. This will allow us
to directly reuse builds in the pure testing bots.
* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121345
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shinyak@chromium.org [Wed, 27 Jun 2012 15:18:07 +0000 (15:18 +0000)]
HTMLStyleElement::removedFrom seems incorrect.
https://bugs.webkit.org/show_bug.cgi?id=89986
Reviewed by Hajime Morita.
This is a follow-up patch for Bug 88495. The Same bug as Bug 88495 seems to exist on
HTMLStyleElement::removedFrom().
No new tests, hard to write a test case.
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::removedFrom):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121344
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reed@google.com [Wed, 27 Jun 2012 15:06:24 +0000 (15:06 +0000)]
Cleanup scaling code in text-decorations for SVG InlineText. Use scale() instead of getCTM/normalizeTransform/setCTM
to use more standard pattern for scaling, and to allow for these operations to be recorded and played back later
(potentially with a different starting matrix). This effectively reverts change# 78704.
https://bugs.webkit.org/show_bug.cgi?id=89888
Reviewed by Nikolas Zimmermann.
No new tests. Current layouttests exercise this code path.
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintDecorationWithStyle):
(WebCore::SVGInlineTextBox::paintTextWithShadows):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121343
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rjkroege@chromium.org [Wed, 27 Jun 2012 14:55:13 +0000 (14:55 +0000)]
[chromium] out-of-order assert in WebViewImpl setDeviceScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=90006
The assert in WebViewImpl::setDeviceScaleFactor should test for non-scaling
after we have set both m_DeviceScaleInCompositor and page()->deviceScaleFactor()
instead of in between.
Reviewed by James Robinson.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setDeviceScaleFactor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121342
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 27 Jun 2012 14:27:00 +0000 (14:27 +0000)]
[Qt] Remove redundant NDEBUG definition
Already handled in default_post.prf.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.
* WebCore.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121341
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 27 Jun 2012 14:24:56 +0000 (14:24 +0000)]
[Qt] No need to save and restore TEMPLATE in a function
This was a leftover from when the logic was not in its own function scope.
QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
will surprisingly affect the global scope as well, so we have to save and restore it.
Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.
* qmake/mkspecs/features/functions.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121340
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 27 Jun 2012 13:05:43 +0000 (13:05 +0000)]
[Qt] Fix lookup location for sqlite sources
Don't look in the install dir - we are unlikely to find anything there
unless we are doing a developer build.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.
* qmake/mkspecs/features/features.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121339
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 27 Jun 2012 13:02:03 +0000 (13:02 +0000)]
[Qt] Remove redundant c++11 warning suppression code
This is already handled in default_post.
Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
Reviewed by Tor Arne Vestbø.
* Target.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121338
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 27 Jun 2012 11:35:06 +0000 (11:35 +0000)]
Unexpected end of style sheet in @font-face rule discards it rather than closes all open constructs
https://bugs.webkit.org/show_bug.cgi?id=89980
Reviewed by Antti Koivisto.
Source/WebCore:
Use the "closing_brace" at the end of font_face rather than the explicit "'}' maybe_space".
Test: fast/css/font-face-unexpected-end.html
* css/CSSGrammar.y:
LayoutTests:
* fast/css/font-face-unexpected-end-expected.html: Added.
* fast/css/font-face-unexpected-end.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121337
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Wed, 27 Jun 2012 11:30:42 +0000 (11:30 +0000)]
[Qt] Add missing heades to HEADERS
For JavaScriptCore there aren't any Qt specific files, so we include all
headers for easy editing in Qt Creator.
Reviewed by Simon Hausmann.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121336
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 27 Jun 2012 10:21:55 +0000 (10:21 +0000)]
Rename Element::rareData() to Element::elementRareData(), and Element::ensureRareData() to Element::ensureElementRareData()
https://bugs.webkit.org/show_bug.cgi?id=90050
Reviewed by Ryosuke Niwa.
Element::rareData()/Element::ensureRareData() and
Node::rareData()/Node::ensureRareData() are confusing. They are not virtual
methods. For clarification, we can rename Element::rareData() to
Element::elementRareData(), and Element::ensureRareData() to
Element::ensureElementRareData().
c.f. SVGRareData uses SVGElement::rareSVGData() and SVGElement::ensureRareSVGData().
(We might want to rename them to SVGElement::svgRareData() and
SVGElement::ensureSVGRareData() in a follow-up patch.)
No tests. No change in behavior.
* dom/Element.cpp:
(WebCore::Element::~Element):
(WebCore::Element::elementRareData):
(WebCore::Element::ensureElementRareData):
(WebCore::Element::attributes):
(WebCore::Element::attach):
(WebCore::Element::detach):
(WebCore::Element::recalcStyle):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::shadowPseudoId):
(WebCore::Element::setShadowPseudoId):
(WebCore::Element::focus):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):
(WebCore::Element::computedStyle):
(WebCore::Element::setStyleAffectedByEmpty):
(WebCore::Element::styleAffectedByEmpty):
(WebCore::Element::cancelFocusAppearanceUpdate):
(WebCore::Element::classList):
(WebCore::Element::optionalClassList):
(WebCore::Element::dataset):
(WebCore::Element::containsFullScreenElement):
(WebCore::Element::setContainsFullScreenElement):
(WebCore::Element::hasNamedNodeMap):
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):
* dom/Element.h:
(Element):
* html/LabelableElement.cpp:
(WebCore::LabelableElement::labels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121335
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dominicc@chromium.org [Wed, 27 Jun 2012 09:44:31 +0000 (09:44 +0000)]
[Chromium] Remove unused build scripts and empty folders for JavaScriptCore w/ gyp
https://bugs.webkit.org/show_bug.cgi?id=90029
Source/JavaScriptCore:
Reviewed by Adam Barth.
* gyp: Removed.
* gyp/generate-derived-sources.sh: Removed.
* gyp/generate-dtrace-header.sh: Removed.
* gyp/run-if-exists.sh: Removed.
* gyp/update-info-plist.sh: Removed.
Source/WebCore:
* gyp: Removed empty dir.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121334
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 09:26:03 +0000 (09:26 +0000)]
Unreviewed, rolling out r121271.
http://trac.webkit.org/changeset/121271
https://bugs.webkit.org/show_bug.cgi?id=90056
Broke a whole bunch of tests and also caused crashes in some
tests (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27
* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121333
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 27 Jun 2012 09:19:15 +0000 (09:19 +0000)]
[Gtk] Add support for the Gamepad API
https://bugs.webkit.org/show_bug.cgi?id=87503
Reviewed by Carlos Garcia Campos.
.:
Only enable the Gamepad feature on Linux as support
for other operating systems is not present.
Check for the GIO Unix and GUdev dependencies when the
Gamepad feature is enabled.
* configure.ac:
Source/WebCore:
Add support for the Gamepad feature on the GTK port.
The support is available only on Linux, with each gamepad device being presented
through a GamepadDeviceLinux object. The implementation of this class relies on
the Linux kernel joystick API.
Gamepad devices are recognized through the GamepadsGtk class, of which implementation
is based on GUdev. This way devices are properly registered on connection as objects of
the GamepadDeviceGtk class which inherits GamepadDeviceLinux. GamepadDeviceGtk reads the
joystick data through GIO pollable streams and updates the device state accordingly. The
GamepadsGtk object is then polled for gamepads data through the sampleGamepads method.
No new tests - tests already exist but require additional testing infrastructure.
* GNUmakefile.am:
* GNUmakefile.list.am:
* bindings/gobject/GNUmakefile.am:
* bindings/js/JSDOMBinding.h: Add the jsArray method that operates on a Vector of floats.
(WebCore):
(WebCore::jsArray):
* platform/gtk/GamepadsGtk.cpp: Added.
(WebCore):
(GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::create):
(WebCore::GamepadDeviceGtk::GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::~GamepadDeviceGtk):
(WebCore::GamepadDeviceGtk::readCallback):
(GamepadsGtk):
(WebCore::GamepadsGtk::GamepadsGtk):
(WebCore::GamepadsGtk::~GamepadsGtk):
(WebCore::GamepadsGtk::registerDevice):
(WebCore::GamepadsGtk::unregisterDevice):
(WebCore::GamepadsGtk::updateGamepadList):
(WebCore::GamepadsGtk::onUEventCallback):
(WebCore::GamepadsGtk::isGamepadDevice):
(WebCore::sampleGamepads):
* platform/linux/GamepadDeviceLinux.cpp: Added.
(WebCore):
(WebCore::GamepadDeviceLinux::GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::~GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::updateForEvent):
(WebCore::GamepadDeviceLinux::normalizeAxisValue):
(WebCore::GamepadDeviceLinux::normalizeButtonValue):
* platform/linux/GamepadDeviceLinux.h: Added.
(WebCore):
(GamepadDeviceLinux):
(WebCore::GamepadDeviceLinux::connected):
(WebCore::GamepadDeviceLinux::id):
(WebCore::GamepadDeviceLinux::timestamp):
(WebCore::GamepadDeviceLinux::axesCount):
(WebCore::GamepadDeviceLinux::axesData):
(WebCore::GamepadDeviceLinux::buttonsCount):
(WebCore::GamepadDeviceLinux::buttonsData):
Source/WebKit/gtk:
Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk library.
* GNUmakefile.am:
Source/WebKit2:
Add the Gamepad feature dependencies libraries to the LIBADD
list for the libwebkitgtk2 library.
* GNUmakefile.am:
Tools:
Enable the gamepad support for the GTK port.
* Scripts/webkitperl/FeatureList.pm:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121332
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Jun 2012 09:15:18 +0000 (09:15 +0000)]
Fix gcc build after r121302
https://bugs.webkit.org/show_bug.cgi?id=90055
Reviewed by Mark Rowe.
Source/ThirdParty:
Assume RTTI is disabled so that gtest builds under XCode 3.2.6.
* gtest/xcode/Config/General.xcconfig:
Tools:
Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121331
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 27 Jun 2012 08:54:43 +0000 (08:54 +0000)]
Rename rareSVGData() to svgRareData()
https://bugs.webkit.org/show_bug.cgi?id=90051
Reviewed by Nikolas Zimmermann.
Since rareSVGData() returns SVGRareData, it would make sense to
rename rareSVGData() to svgRareData(). Similarly, we can rename
ensureRareSVGData() to ensureSVGRareData(), and hasRareSVGData()
to hasSVGRareData().
c.f. bug 90050 is trying to introduce elementRareData() and
ensureElementRareData().
No tests. No change in behavior.
* WebCore.order:
* dom/Node.h:
(WebCore::Node::hasSVGRareData):
(WebCore::Node::setHasSVGRareData):
(WebCore::Node::clearHasSVGRareData):
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::willRecalcStyle):
(WebCore::SVGElement::svgRareData):
(WebCore::SVGElement::ensureSVGRareData):
(WebCore::SVGElement::mapInstanceToElement):
(WebCore::SVGElement::removeInstanceMapping):
(WebCore::SVGElement::instancesForElement):
(WebCore::SVGElement::setCursorElement):
(WebCore::SVGElement::cursorElementRemoved):
(WebCore::SVGElement::setCursorImageValue):
(WebCore::SVGElement::cursorImageValueRemoved):
(WebCore::SVGElement::correspondingElement):
(WebCore::SVGElement::setCorrespondingElement):
(WebCore::SVGElement::animatedSMILStyleProperties):
(WebCore::SVGElement::ensureAnimatedSMILStyleProperties):
(WebCore::SVGElement::setUseOverrideComputedStyle):
(WebCore::SVGElement::computedStyle):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::instanceUpdatesBlocked):
(WebCore::SVGStyledElement::setInstanceUpdatesBlocked):
(WebCore::SVGStyledElement::hasPendingResources):
(WebCore::SVGStyledElement::setHasPendingResources):
(WebCore::SVGStyledElement::clearHasPendingResourcesIfPossible):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121330
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kkristof@inf.u-szeged.hu [Wed, 27 Jun 2012 08:30:09 +0000 (08:30 +0000)]
[Qt] Unreviewed gardening, rebaseline after r121303.
Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-06-27
* platform/qt/editing/deleting/delete-br-002-expected.txt:
* platform/qt/editing/deleting/delete-br-004-expected.txt:
* platform/qt/editing/deleting/delete-br-005-expected.txt:
* platform/qt/editing/deleting/delete-br-006-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121329
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 27 Jun 2012 08:27:02 +0000 (08:27 +0000)]
Add cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89564
Reviewed by Tony Chang.
* BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
(BuildStepsConstructorTest):
(BuildStepsConstructorTest.generateTests):
(BuildStepsConstructorTest.createTest):
(BuildStepsConstructorTest.createTest.doTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121328
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 27 Jun 2012 07:48:24 +0000 (07:48 +0000)]
LabelableElement.cpp should include not ElementRareData.h but NodeRareData.h
https://bugs.webkit.org/show_bug.cgi?id=90047
Reviewed by Kent Tamura.
This is a simple refactoring. What LabelableElement uses is
not ElementRareData but NodeRareData.
No tests. No change in behavior.
* html/LabelableElement.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Wed, 27 Jun 2012 07:28:31 +0000 (07:28 +0000)]
[V8] Refactor V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get()
https://bugs.webkit.org/show_bug.cgi?id=90044
Reviewed by Adam Barth.
'static_cast<V8BindingPerIsolateData*>(isolate->GetData())' is duplicated
in V8BindingPerIsolateData::current() and V8BindingPerIsolateData::get().
This patch removes the duplication.
No tests. No change in behavior.
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::current):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Wed, 27 Jun 2012 07:26:35 +0000 (07:26 +0000)]
Unreviewed GTK gardening, updating baselines after r121303.
* platform/gtk/editing/deleting/delete-br-002-expected.txt:
* platform/gtk/editing/deleting/delete-br-004-expected.txt:
* platform/gtk/editing/deleting/delete-br-005-expected.txt:
* platform/gtk/editing/deleting/delete-br-006-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 27 Jun 2012 07:26:34 +0000 (07:26 +0000)]
[Qt] Fix compilation of example platform plugin with Qt 5
Reviewed by Kenneth Christiansen.
Use QLatin1String where appropriate and use the Qt 5 plugin
system with Qt 5.
* examples/platformplugin/WebPlugin.cpp:
(SingleSelectionPopup::SingleSelectionPopup):
(MultipleItemListDelegate::MultipleItemListDelegate):
(MultipleSelectionPopup::MultipleSelectionPopup):
* examples/platformplugin/WebPlugin.h:
(WebPlugin):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 27 Jun 2012 07:09:30 +0000 (07:09 +0000)]
[Qt] Avoid use of deprecated Qt API
Reviewed by Tor Arne Vestbø.
QGuiApplication::inputPanel() has been deprecated in favour of
inputMethod().
* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::QtWebPageEventHandler):
(WebKit::QtWebPageEventHandler::~QtWebPageEventHandler):
(WebKit::setInputPanelVisible):
(WebKit::QtWebPageEventHandler::inputPanelVisibleChanged):
(WebKit::QtWebPageEventHandler::updateTextInputState):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 06:37:55 +0000 (06:37 +0000)]
Unreviewed. Rolled DEPS.
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
* DEPS:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yosin@chromium.org [Wed, 27 Jun 2012 06:03:35 +0000 (06:03 +0000)]
[Platform] Change implementation of LocaleICU class to support more UDateFormat.
https://bugs.webkit.org/show_bug.cgi?id=89967
Reviewed by Kent Tamura.
This patch changes internal functions of LocaleICU class to process
multiple ICU date time format handles in addition to short date time
format handle.
This patch is a part of implementing input type time. I'll add time
format related ICU date time format handles.
No new tests. This patch doesn't change behavior.
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeShortDateFormat): Changed to use openDateFormat().
(WebCore::LocaleICU::openDateFormat): Added for common usage of udt_open().
(WebCore::getDateFormatPattern): Added for common usage of udt_toPattern().
(WebCore::localizeFormat): Changed to take String parameter.
(WebCore::LocaleICU::initializeLocalizedDateFormatText): Changed to use getDateFormatPattern.
(WebCore::LocaleICU::createLabelVector): Changed to take UDateFormat parameter.
(WebCore::LocaleICU::initializeCalendar): Changed for helper functions.
* platform/text/LocaleICU.h:
(LocaleICU):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 27 Jun 2012 05:40:18 +0000 (05:40 +0000)]
Return correct value for css variables enabled runtime flag.
https://bugs.webkit.org/show_bug.cgi?id=90040
Reviewed by Dimitri Glazkov.
Was always returning true for the runtime flag when the compile time flag was on. That was good for testing,
but not so much for production.
* page/Settings.h:
(WebCore::Settings::cssVariablesEnabled):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 04:22:47 +0000 (04:22 +0000)]
DragData::asFilenames should not push same file names to result in Windows.
https://bugs.webkit.org/show_bug.cgi?id=79861
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-06-26
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: platform/win/fast/forms/file/drag-and-drop-files.html
* platform/win/DragDataWin.cpp:
(WebCore::DragData::asFilenames):
LayoutTests:
* platform/win/fast/forms/file/drag-and-drop-files-expected.txt: Added.
* platform/win/fast/forms/file/drag-and-drop-files.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Jun 2012 04:03:04 +0000 (04:03 +0000)]
Rebaseline after r121286 and r121290.
* editing/deleting/merge-into-empty-block-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Wed, 27 Jun 2012 03:49:44 +0000 (03:49 +0000)]
[Chromium] Rebaseline fast/backgrounds/size/zero.html. Caused by r121296
Unreviewed.
* platform/chromium-mac-snowleopard/fast/backgrounds/size/zero-expected.png:
* platform/chromium-mac/fast/backgrounds/size/zero-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 27 Jun 2012 03:44:05 +0000 (03:44 +0000)]
Reduced (but did not eliminate) use of "berzerker GC"
https://bugs.webkit.org/show_bug.cgi?id=89237
Reviewed by Gavin Barraclough.
(PART 2)
../JavaScriptCore:
This part turns off "berzerker GC" and turns on incremental shrinking.
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep): Free or shrink after sweeping to
maintain the behavior we used to get from the occasional berzerker GC,
which would run all finalizers and then free or shrink all blocks
synchronously.
* heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping): Sweep zapped blocks, too. It's always
safe to sweep a zapped block (that's the point of zapping), and it's
sometimes profitable. For example, consider this case: Block A does some
allocation (transitioning Block A from Marked to FreeListed), then GC
happens (transitioning Block A to Zapped), then all objects in Block A
are free, then the incremental sweeper visits Block A. If we skipped
Zapped blocks, we'd skip Block A, even though it would be profitable to
run its destructors and free its memory.
* runtime/GCActivityCallback.cpp:
(JSC::DefaultGCActivityCallback::doWork): Don't sweep eagerly; we'll do
this incrementally.
../WebCore:
Don't ASSERT that RootObject's destructor runs and invalidates all
RuntimeObjects before their destructors run.
We don't guarantee this behavior because some RuntimeObjects may already
be garbage by the time RootObject's destructor runs, in which case
RootObject's weak pointers will be NULL, and RootObject will not call
invalidate() on them.
It's been theoretically possible for this ASSERT to fire for a while now.
This patch makes it fire all the time.
Luckily, we only needed the behavior guarded by this ASSERT for WebKit1
in Safari on Windows (cf. https://bugs.webkit.org/show_bug.cgi?id=61317),
to handle the way WebKit1 would unload plugin DLLs. If this ever becomes
an issue again, we can fix it by (a) not unloading plugin DLLs,
(b) migrating WebKit1 to the WebKit2 JS-plugin binding model, (c) making
the Instance pointer in a RuntimeObject an indirect pointer through
RootObject, or (c) giving RuntimeObject some sort of special way to
access a zombie weak pointer.
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::destroy): ASSERT removed. Anders said so.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Wed, 27 Jun 2012 03:30:32 +0000 (03:30 +0000)]
[Chromium] Rebaseline 4 tests in editing/deleting. Caused by r121303.
Unreviewed.
* platform/chromium-linux-x86/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
* platform/chromium-linux-x86/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
* platform/chromium-linux-x86/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
* platform/chromium-linux-x86/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
* platform/chromium-linux/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
* platform/chromium-linux/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
* platform/chromium-linux/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
* platform/chromium-linux/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
* platform/chromium-win-xp/editing/deleting/delete-br-002-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-002-expected.txt.
* platform/chromium-win-xp/editing/deleting/delete-br-004-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-004-expected.txt.
* platform/chromium-win-xp/editing/deleting/delete-br-005-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-005-expected.txt.
* platform/chromium-win-xp/editing/deleting/delete-br-006-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/deleting/delete-br-006-expected.txt.
* platform/chromium-win/editing/deleting/delete-br-002-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-004-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-005-expected.txt:
* platform/chromium-win/editing/deleting/delete-br-006-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 03:02:48 +0000 (03:02 +0000)]
REGRESSION(r107836): box shadow not drawn for opaque images with an opaque background
https://bugs.webkit.org/show_bug.cgi?id=89958
Patch by Douglas Stockwell <dstockwell@chromium.org> on 2012-06-26
Reviewed by Simon Fraser.
Source/WebCore:
Don't attempt to draw the box shadow as part of the background if the background is
obscured.
Test: fast/box-shadow/image-box-shadow.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore):
* rendering/RenderImage.h:
(RenderImage):
LayoutTests:
* fast/box-shadow/image-box-shadow-expected.html: Added.
* fast/box-shadow/image-box-shadow.html: Added.
* fast/box-shadow/resources/green-alpha.png: Added.
* fast/box-shadow/resources/green.jpg: Added.
* fast/box-shadow/resources/green.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Wed, 27 Jun 2012 02:20:21 +0000 (02:20 +0000)]
Fix new Wunused-private-field violations that crept in
https://bugs.webkit.org/show_bug.cgi?id=90032
Reviewed by Adam Barth.
* page/Performance.h:
(Performance):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Wed, 27 Jun 2012 02:11:13 +0000 (02:11 +0000)]
Change return type in bandwidth attribute of network information API
https://bugs.webkit.org/show_bug.cgi?id=89959
Reviewed by Adam Barth.
According to network information API spec, bandwidth attribute should return double type.
But, existing implementation has used *long* and *unsigned int* types.
Source/WebCore:
No new tests. Covered by existing tests.
* Modules/networkinfo/NetworkInfo.cpp:
(WebCore::NetworkInfo::NetworkInfo):
* Modules/networkinfo/NetworkInfo.h:
(WebCore::NetworkInfo::create):
(WebCore::NetworkInfo::bandwidth):
(NetworkInfo):
* Modules/networkinfo/NetworkInfoClient.h:
(NetworkInfoClient):
* Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::bandwidth):
* Modules/networkinfo/NetworkInfoConnection.h:
(NetworkInfoConnection):
* testing/Internals.cpp:
(WebCore::Internals::setNetworkInformation):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:
Source/WebKit/efl:
* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::bandwidth):
* WebCoreSupport/NetworkInfoClientEfl.h:
(NetworkInfoClientEfl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
macpherson@chromium.org [Wed, 27 Jun 2012 01:57:13 +0000 (01:57 +0000)]
Be careful not to read past the end of input in CSSParser::lex() when looking for variable definitions.
https://bugs.webkit.org/show_bug.cgi?id=89949
Reviewed by Abhishek Arya.
Added repro case as fast/css/short-inline-style.html.
* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 01:49:20 +0000 (01:49 +0000)]
[chromium] Remove WebView::graphicsContext3D getter
https://bugs.webkit.org/show_bug.cgi?id=89916
Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Adrienne Walker.
Source/Platform:
Remove unused getter.
* chromium/public/WebLayerTreeView.h:
(WebLayerTreeView):
Source/WebCore:
Deletes code supporting compositor context getter.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(CCSingleThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Removes WebView::graphicsContext3D getter. This getter was used to access the compositor's context, which is an
inherently dangerous operation since the compositor context may not be safe to use on the main thread and has
somewhat complicated creation / recreation semantics. A shared context is exposed
(WebView::sharedGraphicsContext3D) for callers who may want access to a context in a share group with the
compositor.
* public/WebView.h:
(WebView):
* src/WebLayerTreeView.cpp:
* src/WebViewImpl.cpp:
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 01:41:06 +0000 (01:41 +0000)]
Unexpected element sizes when mixing inline-table with box-sizing
https://bugs.webkit.org/show_bug.cgi?id=89819
Patch by Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org> on 2012-06-26
Reviewed by Julien Chaffraix.
Source/WebCore:
This change handles box-sizing: border-box property for CSS tables properly.
Test: fast/box-sizing/css-table-with-box-sizing.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::layout):
LayoutTests:
* fast/box-sizing/css-table-with-box-sizing-expected.txt: Added.
* fast/box-sizing/css-table-with-box-sizing.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Wed, 27 Jun 2012 01:38:41 +0000 (01:38 +0000)]
Add support for preciseTime() to WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=90027
Reviewed by Darin Adler.
It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::preciseTime):
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Wed, 27 Jun 2012 01:34:01 +0000 (01:34 +0000)]
DFG PutByValAlias is too aggressive
https://bugs.webkit.org/show_bug.cgi?id=90026
<rdar://problem/
11751830>
Source/JavaScriptCore:
Reviewed by Gavin Barraclough.
For CSE on normal arrays, we now treat PutByVal as impure. This does not appear to affect
performance by much.
For CSE on typed arrays, we fix PutByValAlias by making GetByVal speculate that the access
is within bounds. This also has the effect of making our out-of-bounds handling consistent
with WebCore.
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::byValIsPure):
(JSC::DFG::Graph::clobbersWorld):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
LayoutTests:
Reviewed by Gavin Barraclough.
* fast/js/dfg-put-by-val-setter-then-get-by-val-expected.txt: Added.
* fast/js/dfg-put-by-val-setter-then-get-by-val.html: Added.
* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias-expected.txt: Added.
* fast/js/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.html: Added.
* fast/js/script-tests/dfg-put-by-val-setter-then-get-by-val.js: Added.
(foo):
(for):
* fast/js/script-tests/dfg-uint8clampedarray-out-of-bounds-put-by-val-alias.js: Added.
(foo):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 27 Jun 2012 01:31:22 +0000 (01:31 +0000)]
Optimize mappings of simple transforms in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=90034
Reviewed by Dean Jackson.
For transforms that are identity or simple translations, don't
fall off the fast path in RenderGeometryMap; we can just
treat them as offsets.
Improves performance on pages with lots of translateZ(0) elements.
Remove RenderGeometryMapStep::mapPoint() and mapQuad(), which
were unused.
No new tests; optimization only, and tested by assertions.
* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::push):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 27 Jun 2012 00:41:28 +0000 (00:41 +0000)]
Touch adjustment does not target shadow DOM elements
https://bugs.webkit.org/show_bug.cgi?id=89556
Source/WebCore:
The position of internal shadow-DOM nodes were not being considered
when determining the snap position when TOUCH_ADJUSTMENT is enabled
for fine tuning the position of synthetic mouse events. This
restriction results in not being able to select the calendar picker
when input type=date, or to clear the search field for input
type=search.
Patch by Kevin Ellis <kevers@chromium.org> on 2012-06-26
Reviewed by Antonio Gomes.
Test: touchadjustment/nested-shadow-node.html
* page/EventHandler.cpp:
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
LayoutTests:
Cannot open calendar picker for input type=date using a touch tap
gesture if TOUCH_ADJUSTMENT is enabled. When touch adjustment is
enabled, the position of a touch point is snapped to the center of an
element when generating synthetic mouse events. The position of shadow
nodes was not being considered when determining the snap position.
This test verifies that touch adjustment now considers shadow-DOM
when calculating the snap position.
Patch by Kevin Ellis <kevers@chromium.org> on 2012-06-26
Reviewed by Antonio Gomes.
* touchadjustment/nested-shadow-node-expected.txt: Added.
* touchadjustment/nested-shadow-node.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
peter@chromium.org [Wed, 27 Jun 2012 00:06:19 +0000 (00:06 +0000)]
[Chromium] Decrease the number of conditional blocks in features.gypi
https://bugs.webkit.org/show_bug.cgi?id=90013
Reviewed by Adam Barth.
Consolidate two Android-specific and accelerated-compositing-specific
conditional blocks into other blocks which serve an identical purpose.
* features.gypi:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 27 Jun 2012 00:00:52 +0000 (00:00 +0000)]
Stop calling node() and deprecatedEditingOffset() in comparePositions
https://bugs.webkit.org/show_bug.cgi?id=54535
Reviewed by Enrica Casucci.
Source/WebCore:
Replaced deprecatedNode() and deprecatedEditingOffset() by containerNode() and computeOffsetInContainerNode()
in comparePositions().
In addition, fixed a bunch of bugs in DeleteSelectionCommand::handleSpecialCaseBRDelete revealed by this change:
- Use node after position instead of deprecated node in determinig whether start and end positions at a br.
- Don't set m_startsAtEmptyLine true when BR is wrapped in a block element. The only reason this code had worked
was positions like (div, offset, 0) and (br, before) in <div><br> were treated differently, which we no longer do.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete):
* editing/htmlediting.cpp:
(WebCore::comparePositions):
LayoutTests:
Rebaselined existing tests. There are no user-visible changes.
* editing/inseting/font-size-clears-from-typing-style-expected.txt: No longer keeps div's around
when merging paragraphs.
* platform/mac/editing/deleting/delete-br-002-expected.txt:
* platform/mac/editing/deleting/delete-br-004-expected.txt:
* platform/mac/editing/deleting/delete-br-005-expected.txt:
* platform/mac/editing/deleting/delete-br-006-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Tue, 26 Jun 2012 23:54:46 +0000 (23:54 +0000)]
Teach the Apple port how to build the test tools in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=89540
Reviewed by Jon Lee & Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
(RunUnitTests.start): ditto
* Scripts/build-webkit: add tools to the projects build list
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 26 Jun 2012 23:43:03 +0000 (23:43 +0000)]
Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90025
Reviewed by Simon Fraser.
Move the chromium-specific filtering code into config.js and replace it with a method on each platform
config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 23:39:57 +0000 (23:39 +0000)]
[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
https://bugs.webkit.org/show_bug.cgi?id=89976
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Antonio Gomes.
Rewrite EFL implementation of Filesystem listDirectory() in order to
use eina_file_ls() instead of POSIX C functions. This results in
shorter code.
No new tests, behavior has not changed.
* platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 23:34:21 +0000 (23:34 +0000)]
Crash at WebCore::TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=89526
<rdar://problem/
10305315>
Patch by Alice Cheng <alice_cheng@apple.com> on 2012-06-26
Reviewed by Darin Adler.
Source/WebCore:
The range used for marking becomes invalid after SpellingCorrectionCommand, due to changes in the DOM made by ReplaceSelectionCommand.
This invalid range caused marking to be incorrect, and Mail.app to crash when iterating through the invalid range. To fix this,
recalculate the range for marking after SpellingCorrectionCommand.
Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
* editing/Editor.cpp: (WebCore::Editor::markAndReplaceFor):
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::hasAutocorrectedMarker):
* testing/Internals.h: (Internals):
* testing/Internals.idl:
LayoutTests:
* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
* platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 26 Jun 2012 23:32:24 +0000 (23:32 +0000)]
Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=90024
Reviewed by Ojan Vafai.
Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.
* editing/inserting/font-size-clears-from-typing-style-expected.txt:
* editing/inserting/font-size-clears-from-typing-style.html:
* editing/inserting/script-tests: Removed.
* editing/inserting/script-tests/TEMPLATE.html: Removed.
* editing/inserting/script-tests/font-size-clears-from-typing-style.js: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tsepez@chromium.org [Tue, 26 Jun 2012 23:18:31 +0000 (23:18 +0000)]
[chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.
https://bugs.webkit.org/show_bug.cgi?id=89906
Reviewed by Nate Chapin.
This patch treats mixed CachedRawResources as affecting the display of insecure content.
Source/WebCore:
Tests: http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html
http/tests/security/mixedContent/insecure-xhr-in-main-frame.html
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkInsecureContent):
LayoutTests:
* http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html: Added.
* http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-xhr-in-main-frame.html: Added.
* http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 23:08:09 +0000 (23:08 +0000)]
background-size:0 shows as 1px instead of invisible
https://bugs.webkit.org/show_bug.cgi?id=86942
Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Eric Seidel.
As per the specification http://www.w3.org/TR/css3-background/#background-size, if the background image's width or height resolves to zero,
this causes the image not to be displayed. The effect should be the same as if it had been a transparent image.
This is also mentioned in http://www.w3.org/TR/2002/WD-css3-background-
20020802/#background-size.
Source/WebCore:
Test: fast/backgrounds/zero-background-size.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):
LayoutTests:
* fast/backgrounds/size/zero.html:
* fast/backgrounds/zero-background-size-expected.html: Added.
* fast/backgrounds/zero-background-size.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/fast/backgrounds/size/zero-expected.png:
* platform/mac/fast/backgrounds/size/zero-expected.txt:
* platform/qt/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 26 Jun 2012 23:02:00 +0000 (23:02 +0000)]
[v8] Clean up generated Dictionary-handling code
https://bugs.webkit.org/show_bug.cgi?id=89994
Reviewed by Adam Barth.
No change in behavior, so no new tests.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 26 Jun 2012 23:00:43 +0000 (23:00 +0000)]
Fix failing garden-o-matic unittests
https://bugs.webkit.org/show_bug.cgi?id=90021
Reviewed by Adam Barth.
These had all just fallen out of date.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 23:00:04 +0000 (23:00 +0000)]
Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set
https://bugs.webkit.org/show_bug.cgi?id=89997
Patch by Raymond Toy <rtoy@google.com> on 2012-06-26
Reviewed by Eric Seidel.
No new tests needed for a compile issue
* Modules/webaudio/AudioNode.cpp: Include stdio.h
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noam.rosenthal@nokia.com [Tue, 26 Jun 2012 22:51:35 +0000 (22:51 +0000)]
[Qt] Use premultiplied alpha when extracting image data in WebGL
https://bugs.webkit.org/show_bug.cgi?id=89937
Reviewed by Jocelyn Turcotte.
Perform conversion in QImage only if the image format is not ARGB32 or
ARGB32_Premultiplied. Otherwise, allow packPixels to perform the conversion if the formats
don't match, as packPixels already performs pixel-specific operations.
Covered by tests in LayoutTests/fast/canvas/webgl, e.g. webgl-composite-modes.html.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jsbell@chromium.org [Tue, 26 Jun 2012 22:04:09 +0000 (22:04 +0000)]
IndexedDB: Move method precondition checks to front end objects
https://bugs.webkit.org/show_bug.cgi?id=89377
Reviewed by Tony Chang.
Now that metadata exists on the front end, most of the pre-condition validation checks
done on IDB method calls from script can be moved to the front end which simplifies the
code significantly in the case of complex methods like IDBObjectStore::put().
Adds an internal "active" flag for transactions, although the behavior is not accurate
to the spec (it should only be true during event callbacks - http://webkit.org/b/89379).
The back-end methods can then be simplifed to just adding async tasks to the transaction,
and the front end methods can take care of all exception cases except for asynchronous
transaction abort which still requires plumbing back to the front end.
No functional changes - no new tests.
* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Migrate from IDBObjectStoreBackendImpl::put.
(WebCore::IDBCursor::advance): Add more explicit transaction-is-active check.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto.
(WebCore::IDBCursor::effectiveObjectStore): Convenience function (source may be store or index).
(WebCore):
* Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::isKeyCursor): Distinguish from IDBCursorWithValue.
(IDBCursor):
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update): Remove migrated check.
* Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
* Modules/indexeddb/IDBDatabase.cpp: Migrate checks.
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Replace checks with assertions.
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
* Modules/indexeddb/IDBIndex.cpp: Add transaction-is-active checks.
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* Modules/indexeddb/IDBObjectStore.cpp: Migrate cehcks.
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add): Delegates to put(PutMode)
(WebCore::IDBObjectStore::put): Delegates to put(PutMode)
(WebCore): Adds put(PutMode) which has the unified checks migrated from
IDBObjectStoreBackendImpl::put.
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
* Modules/indexeddb/IDBObjectStore.h: Adds put(PutMode).
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal): Fix trace symbol.
(WebCore::IDBObjectStoreBackendImpl::put): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::deleteIndex): Remove migrated checks.
* Modules/indexeddb/IDBTransaction.cpp: Add active flag tracking.
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isActive):
(WebCore::IDBTransaction::isReadOnly): Group IDL/non-IDL methods.
(IDBTransaction):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 26 Jun 2012 21:46:34 +0000 (21:46 +0000)]
Fix a test after r121286.
* editing/deleting/merge-into-empty-block-2.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 21:35:55 +0000 (21:35 +0000)]
Unreviewed, rolling out r121285.
http://trac.webkit.org/changeset/121285
https://bugs.webkit.org/show_bug.cgi?id=90014
"We misinterpreted 'size of the initial containing block'"
(Requested by tomz on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26
Source/WebCore:
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
* css/CSSToStyleMap.h:
(CSSToStyleMap):
* css/MediaQueryEvaluator.cpp:
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
LayoutTests:
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Removed.
* ietestcenter/css3/valuesandunits/units-000.htm:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 21:30:44 +0000 (21:30 +0000)]
[chromium] Expose rendering statistics to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=88268
Patch by Dave Tu <dtu@chromium.org> on 2012-06-26
Reviewed by James Robinson.
The WebKit side of a basic framework for exposing rendering statistics
to Chromium's --enable-benchmarking extension.
Source/Platform:
* chromium/public/WebLayerTreeView.h:
(WebRenderingStatistics):
(WebKit):
(WebLayerTreeView):
Source/WebCore:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::implFrameNumber):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::implFrameNumber):
(WebCore):
(WebCore::CCThreadProxy::implFrameNumberOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStatistics):
(WebKit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Tue, 26 Jun 2012 21:21:54 +0000 (21:21 +0000)]
Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010
Reviewed by Simon Fraser.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
The old code never worked. This is hard to test because change handlers require
a user-initiated action and the code is changing the window's location, which would
navigate the test page.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
due to the large margin-bottom.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 26 Jun 2012 21:06:24 +0000 (21:06 +0000)]
Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries-001.html, merge-into-empty-block-1.html and merge-into-empty-block-2.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=90011
Reviewed by Eric Seidel.
* editing/deleting/delete-3959464-fix-expected.txt: Added.
* editing/deleting/delete-3959464-fix.html:
* editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
* editing/deleting/delete-at-paragraph-boundaries-001.html:
* editing/deleting/merge-into-empty-block-1-expected.txt: Added.
* editing/deleting/merge-into-empty-block-1.html:
* editing/deleting/merge-into-empty-block-2-expected.txt: Added.
* editing/deleting/merge-into-empty-block-2.html:
* platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/chromium-linux/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-linux/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-linux/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-mac-leopard/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
* platform/mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
* platform/qt/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/qt/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomz@codeaurora.org [Tue, 26 Jun 2012 20:23:26 +0000 (20:23 +0000)]
ietestcenter/css3/valuesandunits/units-000.htm asserts
https://bugs.webkit.org/show_bug.cgi?id=86176
Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-06-26
Reviewed by Beth Dakin.
Source/WebCore:
Modified computeLengthDouble() to handle vh, vw, and vmin units. Per the spec
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) viewport -percentage
lengths are "relative to the size of the initial containing block", which I read to be
the size of the parent element. Since parentStyle was not available in computeLengthDouble,
most of the changes for this patch involved "pushing down" the parentStyle pointer through
the network of computeLength methods and dependencies.
Tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html
css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html
css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html
* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::parentStyle):
(WebCore):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
* css/CSSToStyleMap.h:
(CSSToStyleMap):
* css/MediaQueryEvaluator.cpp:
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(WebCore::StyleResolver::parentNode):
(StyleResolver):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
LayoutTests:
Adding explicit tests for viewport border length tests. Inspired by IE Test center
units-000 test which highlighted that vw, vh, and vmin were not being handled in computeLengthDouble().
Also, adjusting test_expectations and Skipped for units-000, which no longer Asserts with this
patch implemented.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Added.
* ietestcenter/css3/valuesandunits/units-000.htm:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 26 Jun 2012 20:17:09 +0000 (20:17 +0000)]
[chromium] Add WebLayer API for scrolling
https://bugs.webkit.org/show_bug.cgi?id=89913
Reviewed by Adrienne Walker.
Source/Platform:
Adds WebScrollableLayer type to represent a layer that can be scrolled by the user. Currently WebContentLayers
are scrollable and no other layer types are, although this might change in the future.
* chromium/public/WebContentLayer.h:
(WebKit::WebContentLayer::WebContentLayer):
* chromium/public/WebLayer.h:
(WebLayer):
* chromium/public/WebScrollableLayer.h:
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):
Source/WebCore:
Use new WebScrollableLayer type in ScrollingCoordinatorChromium. This file peeks "under the hood" a fair amount
since we don't have WebLayer API for scrollbar layers yet.
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):
Source/WebKit/chromium:
Use WebScrollableLayer type in NonCompositedContentHost.
* WebKit.gyp:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::reserveScrollbarLayers):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::haveScrollLayer):
(WebKit):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
(WebCore):
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::WebContentLayer):
* src/WebLayer.cpp:
(WebKit::WebLayer::numberOfChildren):
(WebKit):
(WebKit::WebLayer::childAt):
(WebKit::WebLayer::setAlwaysReserveTextures):
* src/WebScrollableLayer.cpp:
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Tue, 26 Jun 2012 20:09:31 +0000 (20:09 +0000)]
Unreviewed, rolling out r120501.
http://trac.webkit.org/changeset/120501
https://bugs.webkit.org/show_bug.cgi?id=89126
[skia] Fix is too heavy-handed
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::drawNeedsCopy):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::isDeferred):
(WebCore::PlatformContextSkia::setDeferred):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 19:55:32 +0000 (19:55 +0000)]
[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779
Patch by Yong Li <yoli@rim.com> on 2012-06-26
Reviewed by Rob Buis.
Fix non-JIT build on BlackBerry broken by r121196.
* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mifenton@rim.com [Tue, 26 Jun 2012 19:52:14 +0000 (19:52 +0000)]
[BlackBerry] Add WebPage interface for Async spell check.
https://bugs.webkit.org/show_bug.cgi?id=89999
Reviewed by Rob Buis.
PR 124517.
Add interface for IMS async spell checking.
Reviewed Internally by Nima Ghanavatian.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
* WebKitSupport/InputHandler.h:
(InputHandler):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Tue, 26 Jun 2012 19:42:05 +0000 (19:42 +0000)]
DFG::operationNewArray is unnecessarily slow, and may use the wrong array
prototype when inlined
https://bugs.webkit.org/show_bug.cgi?id=89821
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
Fixes all array allocations to use the right structure, and hence the right prototype. Adds
inlining of new Array(...) with a non-zero number of arguments. Optimizes allocations of
empty arrays.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSArray.h:
(JSC):
(JSC::constructArray):
* runtime/JSGlobalObject.h:
(JSC):
(JSC::constructArray):
LayoutTests:
Rubber stamped by Geoffrey Garen.
* fast/js/dfg-cross-global-object-inline-new-array-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-elements.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-size.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array.html: Added.
* fast/js/script-tests/cross-global-object-inline-global-var.js:
(done):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array.js: Added.
(foo):
(done):
(doit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 26 Jun 2012 19:40:08 +0000 (19:40 +0000)]
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676
Unreviewed typo fix, pointed out by Darin Adler.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adamk@chromium.org [Tue, 26 Jun 2012 19:36:50 +0000 (19:36 +0000)]
MutationObserver.observe should treat a null or undefined options argument as empty
https://bugs.webkit.org/show_bug.cgi?id=89992
Reviewed by Ojan Vafai.
Source/WebCore:
The WebIDL spec was recently updated to treat null or undefined
Dictionary arguments the same as the empty dictionary. This patch
updates MutationObserver.observe to follow that spec.
Note that we still throw a SYNTAX_ERR in this case, since it's an
error not to pass one of "attributes", "childList", or "characterData"
as a key in the dictionary.
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):
LayoutTests:
* fast/mutation/observe-exceptions-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 19:34:23 +0000 (19:34 +0000)]
[chromium] The single thread proxy should not automatically tick new animations.
https://bugs.webkit.org/show_bug.cgi?id=89996
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.
Source/WebCore:
No new tests. No change to existing functionality.
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):
Source/WebKit/chromium:
* WebKit.gypi:
* tests/CCSingleThreadProxyTest.cpp: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Tue, 26 Jun 2012 19:21:32 +0000 (19:21 +0000)]
[chromium] Mark a layout test as timeout
https://bugs.webkit.org/show_bug.cgi?id=90003
fast/js/repeat-cached-vm-reentry.html started timing out on Mac debug and Win debug builds
between r121233:121239.
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Tue, 26 Jun 2012 19:16:08 +0000 (19:16 +0000)]
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676
Reviewed by Abhishek Arya.
Source/WebCore:
Tests: fast/table/auto-table-layout-colgroup-removal-crash.html
fast/table/fixed-table-layout/colgroup-removal-crash.html
fast/table/fixed-table-layout/prepend-in-fixed-table.html
The issue comes from RenderTable not properly dirtying its preferred logical
widths. As the table layout codes (both fixed and auto), recomputes their internal
structures at computePreferredLogicalWidth, the internal structure doesn't match
the table sizing and we crash.
This fix adds a work-around in FixedTableLayout::layout (which matches AutoTableLayout).
The long-term fix would be to properly fix the logic but this is a lot safer, especially
since our logic is really not bullet-proof at the moment.
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
Added an internal structure recomputation, if we have drifted from our table's structure.
Also we need to update nEffCols if we call calcWidthArray.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
Added a comment matching FixedTableLayout. The nEffCols is unneeded but kept for consistency
with FixedTableLayout.
LayoutTests:
* fast/table/auto-table-layout-colgroup-removal-crash-expected.txt: Added.
* fast/table/auto-table-layout-colgroup-removal-crash.html: Added.
* fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt: Added.
* fast/table/fixed-table-layout/colgroup-removal-crash.html: Added.
2 cases where we remove a colgroup after having done layout.
* fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt: Added.
* fast/table/fixed-table-layout/prepend-in-fixed-table.html: Added.
This is a copy of fast/table/prepend-in-anonymous-table.html modified to work with
fixed table layout. This covers a bug found during testing that is fixed as part of
this broader change.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:42:29 +0000 (18:42 +0000)]
[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784
Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.
Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.
Source/WebCore:
Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):
Source/WebKit/chromium:
* tests/LayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hclam@chromium.org [Tue, 26 Jun 2012 18:39:31 +0000 (18:39 +0000)]
[chromium] Mark a layout test as fail
https://bugs.webkit.org/show_bug.cgi?id=89998
compositing/webgl/webgl-nonpremultiplied-blend.html started failing after r121267, give it IMAGE failure.
* platform/chromium/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpu@apple.com [Tue, 26 Jun 2012 18:38:56 +0000 (18:38 +0000)]
On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982
Reviewed by Darin Adler.
Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
behave consistently.
Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor().
* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:34:54 +0000 (18:34 +0000)]
Do early-return when author and user styles are disabled.
https://bugs.webkit.org/show_bug.cgi?id=89947
Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Andreas Kling.
* dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:27:44 +0000 (18:27 +0000)]
webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Eric Seidel.
webkit-patch patches-to-review will now output the list of
bugs with patches pending for review that has the user on CC,
excluding patches with cq-, sorted by the age of the patch.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_from_review_queue):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_from_review_queue):
(MockBugzilla.__init__):
(MockBugzilla.authenticate):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview):
(PatchesToReview.__init__):
(PatchesToReview._print_report):
(PatchesToReview._generate_report):
(PatchesToReview.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_patches_to_review):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 18:09:22 +0000 (18:09 +0000)]
[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=89933
Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Kenneth Russell.
Source/WebCore:
GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
Since the compositor doesn't use GC3D any more, these are no longer needed.
* platform/chromium/support/Extensions3DChromium.cpp:
* platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
* platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DPrivate::grContext):
* platform/chromium/support/GraphicsContext3DPrivate.h:
(WebCore):
(GraphicsContext3DPrivate):
* platform/graphics/chromium/Extensions3DChromium.h:
Source/WebKit/chromium:
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 17:56:46 +0000 (17:56 +0000)]
[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=89797
Patch by Yasuhiro Matsuda <mazda@chromium.org> on 2012-06-26
Reviewed by James Robinson.
No new tests. This patch doesn't change behavior.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 26 Jun 2012 17:01:21 +0000 (17:01 +0000)]
nrwt: broken for chromium on vista
https://bugs.webkit.org/show_bug.cgi?id=89988
Reviewed by Tony Chang.
r121194 removed support for 'chromium-win-vista' as a separate
port, but this actually prevented the code from running on vista
at all, which is unduly harsh and broke the websocket tests on
the (non-webkit) chromium bots that are still running on vista.
It's probably good enough to pretend that vista is win7 instead;
some layout tests will still fail but at least things'll run.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.determine_full_port_name):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 16:30:49 +0000 (16:30 +0000)]
Web Inspector: Native memory snapshots crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=89977
Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
shawnsingh@chromium.org [Tue, 26 Jun 2012 16:20:07 +0000 (16:20 +0000)]
[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931
Reviewed by James Robinson.
WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
#ifdef or #if have different behavior. There are some places in
the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should
actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those
#ifdef statements.
* public/WebTextRun.h:
(WebTextRun):
* public/linux/WebFontRenderStyle.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 26 Jun 2012 15:00:43 +0000 (15:00 +0000)]
cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215
We need it because it is deprecated and will be dropped in buildbot 0.8.7
Reviewed by Tony Chang.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.__init__):
(Factory.__init__):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 14:39:59 +0000 (14:39 +0000)]
[Qt] Baseline missing for 3D transforms tests.
https://bugs.webkit.org/show_bug.cgi?id=89973
Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.
Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
Add missing baselines for all unskipped 3D transforms tests.
* platform/qt/Skipped:
* platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Tue, 26 Jun 2012 14:01:12 +0000 (14:01 +0000)]
[Qt][Win] Symbols are not exported in QtWebKit5.dll
https://bugs.webkit.org/show_bug.cgi?id=88873
Reviewed by Tor Arne Vestbø.
Source/WebKit:
* api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.
Tools:
When linking the target dll make sure to re-export the symbols from
the static libraries marked as export, with the help of a little python
script and a qmake extra compiler.
* Scripts/generate-win32-export-forwards: Added.
* qmake/mkspecs/features/win32/default_post.prf:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 13:09:25 +0000 (13:09 +0000)]
[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=89924
"bytesPerLine == targetRect.width() / 4" is invalid.
This patch amended it into "bytesPerLine == targetRect.width() * 4".
Moreover, changed magic number 4 to bytesPerPixel.
Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-26
Reviewed by Noam Rosenthal.
No new tests. Covered by existing tests.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 13:07:17 +0000 (13:07 +0000)]
Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718
Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-26
Reviewed by Noam Rosenthal.
Defined a new member that says what type of output code must be generated
(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.
* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):
* platform/graphics/ANGLEWebKitBridge.h:
(ANGLEWebKitBridge):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Tue, 26 Jun 2012 12:56:13 +0000 (12:56 +0000)]
Fix bug where animations failed to start
https://bugs.webkit.org/show_bug.cgi?id=89943
Reviewed by Nikolas Zimmermann.
Source/WebCore:
The unpause code previously checked that the animations had not started
before un-setting the pause state. This meant that if an animation was
paused and unpaused before the animations started, it would remain in the
paused state. This patch simply reorders the unpause logic to fix this bug.
Test: svg/custom/animate-initial-pause-unpause.html
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::resume):
LayoutTests:
* svg/custom/animate-initial-pause-unpause-expected.txt: Added.
* svg/custom/animate-initial-pause-unpause.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 12:49:12 +0000 (12:49 +0000)]
[EFL] Gardening of new passing tests
https://bugs.webkit.org/show_bug.cgi?id=89970
Unreviewed gardening.
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
* platform/efl/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Tue, 26 Jun 2012 12:32:38 +0000 (12:32 +0000)]
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955
Reviewed by Vsevolod Vlasov.
Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 12:17:41 +0000 (12:17 +0000)]
[BlackBerry] Limit session storage quota to 5MB by default
https://bugs.webkit.org/show_bug.cgi?id=89941
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-06-26
Reviewed by Rob Buis.
Limit session storage quota to 5MB by default for BlackBerry
porting.
Internally reviewed by George Staikos.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::sessionStorageQuota):
(BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
* Api/WebSettings.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 12:10:58 +0000 (12:10 +0000)]
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655
Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.
Simplify the implementation of SharedBuffer::createWithContentsOfFile()
in EFL port.
No new test, no behavior change.
* platform/efl/SharedBufferEfl.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 11:27:55 +0000 (11:27 +0000)]
[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=89964
Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Andreas Kling.
Added missing null pointer check.
* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 26 Jun 2012 10:36:21 +0000 (10:36 +0000)]
[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89647
Unreviewed, update GTK test expectations.
r121215 has fixed the assertion failure, so the test doesn't crash
anymore.
Patch by Simon Pena <spena@igalia.com> on 2012-06-26
* platform/gtk/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kinuko@chromium.org [Tue, 26 Jun 2012 10:26:26 +0000 (10:26 +0000)]
Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856
Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/filesystem/get-metadata.html
* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.Entry.prototype.get isDirectory):
(WebInspector.FileSystemModel.Entry.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._directoryContentReceived):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.directoryContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):
LayoutTests:
* http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.writeFile):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest):
(writeFile.didGetFileSystem):
(writeFile):
(writeFile.didGetWriter.writer.onwrite):
(writeFile.didGetWriter):
* http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
* http/tests/inspector/filesystem/get-metadata.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc