platform/core/ml/nnfw.git
5 years ago[neurun] Correct header inclusions in Executor (#4618)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Fri, 8 Mar 2019 07:09:59 +0000 (16:09 +0900)]
[neurun] Correct header inclusions in Executor (#4618)

- `BackendResolver` is not needed
- Plan is required for `Executor`, not `IExecutor`

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoIntroduce nnapi-header CMake target (#4631)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 07:01:58 +0000 (16:01 +0900)]
Introduce nnapi-header CMake target (#4631)

This commit introduces nnapi-header target in CMake, and removes all
the occurences of NNFW_INCLUDE_DIR via linking this target instead.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoacl version up to 19.02 (#4549)
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 02:27:18 +0000 (11:27 +0900)]
acl version up to 19.02 (#4549)

* build ACL unconditionally

- This patch should be reverted after CI infra(e.g .pre-built ACL binary) is updated.

* Compute Library update to v19.02

- Update ACL to v19.02
- Remove unness. files from ARMComputeEx

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
5 years agoFix split implementation and test (#4622)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Fri, 8 Mar 2019 00:50:55 +0000 (09:50 +0900)]
Fix split implementation and test (#4622)

* Fix split implementation and test

Fix plit implementation based on NeuralNetworksEx.h spec
- Fix split in nnapi_delegate.cpp
- Fix pacl implementation
- Fix spli test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Fix comment

5 years ago[neurun] ReduceSum op (#4612)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 7 Mar 2019 22:29:52 +0000 (07:29 +0900)]
[neurun] ReduceSum op (#4612)

This commit adds `ReduceSumEx` op and enable testcase into neurun.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Enable Logistic op in acl_cl (#4599)
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 10:28:25 +0000 (19:28 +0900)]
[neurun] Enable Logistic op in acl_cl (#4599)

* [neurun] Enable Logistic op in acl_cl

This commit allows to run logistic op using acl_cl kernel

Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
* Remove these tests in skip list of neurun

5 years agoDo NOT use TFLITE_DEPEND (#4623)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 05:16:44 +0000 (14:16 +0900)]
Do NOT use TFLITE_DEPEND (#4623)

Each source package provides the source path as a variable.
Let's use these dedicated variables instead of TFLITE_DEPEND.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoRemove OPTION_TOOLCHAIN variable (#4626)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 05:16:31 +0000 (14:16 +0900)]
Remove OPTION_TOOLCHAIN variable (#4626)

This commit removes OPTION_TOOLCHAIN variable in Makefile, and uses
OPTION instead in order to simplify Makefile.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoIntroduce CI infra neurun build and test scripts (#4611)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 04:36:44 +0000 (13:36 +0900)]
Introduce CI infra neurun build and test scripts (#4611)

* Introduce CI infra neurun build and test scripts

Introduce neurun build scripts
Introduce neurun cpu and acl_cl test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Backend setting for acl_cl

5 years ago[neurun] Fix build break due to namespace change (#4625)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 7 Mar 2019 04:33:02 +0000 (13:33 +0900)]
[neurun] Fix build break due to namespace change (#4625)

Remove specifying `compiler::` namespace for `IExecutionBuilder`. Use
`using` at the top of the source code instead.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoAlways require NEON2SSESource for TFLITE build (#4620)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 03:31:52 +0000 (12:31 +0900)]
Always require NEON2SSESource for TFLITE build (#4620)

* Always require NEON2SSESource for TFLITE build

NEON2SSE is a header-only library, and thus there is no need to exclude
it for cross or arm native build.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Check TARGET_ARCH in NEON2SSESource package

5 years ago[neurun] Enable Exp op in neurun (#4554)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 7 Mar 2019 02:28:31 +0000 (11:28 +0900)]
[neurun] Enable Exp op in neurun (#4554)

Related : #4259

This commit enables `Exp` op in `neurun` for `acl_cl`, that is from `PACL`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoRemove (deprecated) kernel testing project (#4621)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 02:28:16 +0000 (11:28 +0900)]
Remove (deprecated) kernel testing project (#4621)

This kernel testing project was introduced as a test at the early stage,
but is not used anymore.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Remove LINEARIZED state (#4617)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 7 Mar 2019 01:24:54 +0000 (10:24 +0900)]
[neurun] Remove LINEARIZED state (#4617)

Remove LINEARIZED state from Compiler's state. This is not a general
state since `DataflowExecutor` does not have this state.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Introduce Config `EXECUTOR` (#4616)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 7 Mar 2019 01:17:23 +0000 (10:17 +0900)]
[neurun] Introduce Config `EXECUTOR` (#4616)

Introduce environment variable `EXECUTOR` to specify which executor to
use.

Now we can run with Dataflow Executor with these variables.

```bash
export CPU_MEMORY_PLANNER=Bump
export EXECUTOR=Dataflow
```

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoUpdate variable setting in scripts (#4603)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 01:10:19 +0000 (10:10 +0900)]
Update variable setting in scripts (#4603)

- Remove export in scripts/standalone

We can remove them because we call other script using source

- Remove setting BENCHMARK_ACL_BUILD

- Use make command more lines

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove unused inclusion in Executor.cc (#4615)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 7 Mar 2019 00:57:34 +0000 (09:57 +0900)]
[neurun] Remove unused inclusion in Executor.cc (#4615)

Remove unused header inclusion in `Executor.cc`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoFix packaging related code (#4593)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 00:55:31 +0000 (09:55 +0900)]
Fix packaging related code (#4593)

Packaging scripts in test suite to support test in target device
Call build_test_suite for x64 test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoDo not guess build mode (native/cross) (#4607)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 7 Mar 2019 00:55:12 +0000 (09:55 +0900)]
Do not guess build mode (native/cross) (#4607)

This commit updates identify_platform.cmake to use configuration
variable that user provides.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoIntroduce CI infra build script for model test (#4613)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 11:37:14 +0000 (20:37 +0900)]
Introduce CI infra build script for model test (#4613)

Introduce runtime build script for model test

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoDo NOT require Flatbuffers (#4614)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 11:36:58 +0000 (20:36 +0900)]
Do NOT require Flatbuffers (#4614)

It turns out that TensorFlow Lite does not depend on Flatbuffers
runtime.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Fix a compile error (#4609)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 10:10:40 +0000 (19:10 +0900)]
[neurun] Fix a compile error (#4609)

This commit fixes an error occurred due to a gap of the source merge.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Extract IExecutionBuilder to a file (#4602)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 08:26:02 +0000 (17:26 +0900)]
[neurun] Extract IExecutionBuilder to a file (#4602)

Extract IExecutionBuilder to a file in namespace `compiler`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Add a helper function and an assertion (#4598)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 08:24:28 +0000 (17:24 +0900)]
[neurun] Add a helper function and an assertion (#4598)

This commit adds a helper function and an assertion in `model::operand::Object`.
  - The helper function `hasData()` check whether Object has the data or not.
  - Add an assertion to `model::operand::Object::data()`.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Fix missing error handling (#4597)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 08:24:12 +0000 (17:24 +0900)]
[neurun] Fix missing error handling (#4597)

This commit fixes missing error handling.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Fixed typo in LogisticNode (#4600)
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 08:23:58 +0000 (17:23 +0900)]
[neurun] Fixed typo in LogisticNode (#4600)

This commit fixes typo in LogisticNode

Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
5 years agoGenerate NNAPI tests during CMake configuration (#4601)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 08:21:57 +0000 (17:21 +0900)]
Generate NNAPI tests during CMake configuration (#4601)

The current implementation invokes test generating script inside
Makefile.

Now, CMake will invoke this script during configuration.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoRename and fix pacl test (#4595)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 07:53:45 +0000 (16:53 +0900)]
Rename and fix pacl test (#4595)

- Rename pacl build scripts
- Rename pacl test script

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoVersion update to 0.3 for tizen gbs build (#4596)
이춘석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 07:43:07 +0000 (16:43 +0900)]
Version update to 0.3 for tizen gbs build (#4596)

- Note that nnfw of tizen 5.5 branch had been updated to v0.3

Signed-off-by: Chunseok Lee <chunseok.lee@samsung.com>
5 years agoIntroduce CI infra coverage scripts (#4582)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 07:42:14 +0000 (16:42 +0900)]
Introduce CI infra coverage scripts (#4582)

- Introduce coverage build script
- Introduce coverage test script
- Introduce coverage report script
- Rename coverage report command

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[Neurun] Transpose op (#4541)
윤현식/On-Device Lab(SR)/Principal Engineer/삼성전자 [Wed, 6 Mar 2019 05:54:06 +0000 (14:54 +0900)]
[Neurun] Transpose op (#4541)

* [Neurun] Transpose op

This adds `transpose` op and test cases into Neurun.

Signed-off-by: Hyun Sik Yoon <hyunsik.yoon@samsung.com>
* move assert(...) in StageGenerator to OperationValidator

* remove visit() of TransposeNode in cpu/StqageGenerator.h

5 years agoIntroduce CI infra x64 build and test scripts (#4592)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 05:36:36 +0000 (14:36 +0900)]
Introduce CI infra x64 build and test scripts (#4592)

Introduce x64 build and test scripts

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove switch stmt from addOperationEx (#4591)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 05:20:19 +0000 (14:20 +0900)]
[neurun] Remove switch stmt from addOperationEx (#4591)

As applied in #4577, This commit removes switch stmt from addOperationEx too.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Enable DIV op in neurun (#4551)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 04:42:23 +0000 (13:42 +0900)]
[neurun] Enable DIV op in neurun (#4551)

* [neurun] Enable DIV op in neurun

This commit enables `DIV` op in `neurun` for `acl_cl`, that is from `PACL`

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
* Fix typo

* Add override

5 years agoRename directory for standalone script (#4589)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 04:21:23 +0000 (13:21 +0900)]
Rename directory for standalone script (#4589)

Rename directory for standalone script: scripts/ci -> scripts/standalone

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoMove tizen test script (#4581)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 04:08:14 +0000 (13:08 +0900)]
Move tizen test script (#4581)

Move tizen test script from scripts/command to scripts/ci

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Extract Backend as a separate file (#4587)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 01:06:23 +0000 (10:06 +0900)]
[neurun] Extract Backend as a separate file (#4587)

Extract `backend::Backend` as a separate file.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Enable compilation for DataflowExecutor (#4586)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 6 Mar 2019 00:26:35 +0000 (09:26 +0900)]
[neurun] Enable compilation for DataflowExecutor (#4586)

* [neurun] Enable compilation for DataflowExecutor

This enables compilation compiles to DataflowExecutor. Currently it uses
only Executor, however the `use_dataflow_executor` will be decided with
a config value.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Set use_dataflow_executor = false

As default is Executor(Linear).

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoChange file access mode in script/ci (#4583)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 6 Mar 2019 00:24:27 +0000 (09:24 +0900)]
Change file access mode in script/ci (#4583)

Change docker_build_cross_arm_ubuntu_release.sh access mode in script/ci

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove acl and internal_acl_build targets (#4580)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 23:58:47 +0000 (08:58 +0900)]
Remove acl and internal_acl_build targets (#4580)

Now, there is no code/routine that invokes these targets.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoRemove benchmark acl script (#4564)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 10:26:57 +0000 (19:26 +0900)]
Remove benchmark acl script (#4564)

This commit removes ACL benchmark script, and updates related test
driver.

Note that this commit does not remove the option of test driver to
maintain the compatibility with CI infrastructure.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoMove CI infra tizen build script (#4578)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 10:21:00 +0000 (19:21 +0900)]
Move CI infra tizen build script (#4578)

Move CI infra tizen cross build and gbs build script from script/command

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRename format check command (#4579)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 10:07:10 +0000 (19:07 +0900)]
Rename format check command (#4579)

Rename format check command: format-checker -> format_check

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove switch stmt from addOperation (#4577)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 09:41:15 +0000 (18:41 +0900)]
[neurun] Remove switch stmt from addOperation (#4577)

Remove switch statement from addOperation and delegate operation
creation to OperationFactory.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Choose memory planner for cpu backend (#4552)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 09:38:02 +0000 (18:38 +0900)]
[neurun] Choose memory planner for cpu backend (#4552)

* [neurun] Choose memory planner for cpu backend

Support Environment Variable "CPU_MEMORY_PLANNER" for users to choose
which memory planner to use.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
* Remove "Planner" suffix for keys

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[PACL] Apply DepthwiseConvolutionLayer3x3 to DepthwiseConv operation (#4354)
장지섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 08:23:07 +0000 (17:23 +0900)]
[PACL] Apply DepthwiseConvolutionLayer3x3 to DepthwiseConv operation (#4354)

* [PACL] Apply 3x3 kernel to DepthwiseConv operation

This commit Applies 3x3 kernel to DepthwiseConv operation that has a weight of width and height is 3.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* [PACL] Intrudoces helper functions getting the index of height and width

This commit intrudoces helper functions getting the index of height and width without reference to the data layout.

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
* Append comments to added helper functions

This commit appends comments to added helper functions getting index of a dimension
  - Append a TODO comment
  - Elaborate a param comment
  - Change the name of the helper function

Signed-off-by: jiseob.jang <jiseob.jang@samsung.com>
5 years ago[neurun] Replace graph with model in Linear (#4519)
김용섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 07:33:05 +0000 (16:33 +0900)]
[neurun] Replace graph with model in Linear (#4519)

Replace Graph with Model in Linear so that this would make Linear not
dependent on Graph

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
5 years agoExit code for command fail (#4571)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 07:21:40 +0000 (16:21 +0900)]
Exit code for command fail (#4571)

Only exit with code when fail
Otherwise, just return

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoRemove compiler version for tizen (#4569)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 06:25:26 +0000 (15:25 +0900)]
Remove compiler version for tizen (#4569)

Remove compiler version 5 for tizen build
It will use default setting for arm softfp crossbuild in build host

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Fix build break (#4574)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 06:24:47 +0000 (15:24 +0900)]
[neurun] Fix build break (#4574)

This fixes build break due to recently merged commits.

Resolve #4573

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoUpdate build and test in readme file (#4550)
남궁석/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 06:24:19 +0000 (15:24 +0900)]
Update build and test in readme file (#4550)

* Update build and test in readme file

There are some modifications after build and test processes are updated.
This commit will add those information.

Signed-off-by: Seok NamKoong <sk.namkoong@samsung.com>
* remove some tag and sentence

5 years agoFormat checker command (#4570)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 06:24:01 +0000 (15:24 +0900)]
Format checker command (#4570)

- Introduce format checker command  (format-checker.sh will be removed)
- Fix git-hooks to use command
- Return instead of exit 0 for success

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove OP macro of StageGenerator in backends (#4526)
윤지영/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 05:45:34 +0000 (14:45 +0900)]
[neurun] Remove OP macro of StageGenerator in backends (#4526)

The OP macro forces all operation to be implemented.
But each operation is meaningful only when the operation is actually implemented.
If backend does not have the operation, neurun can use a different backend.

Remove dummy definition and add default throw function

Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
5 years ago[neurun] Create all nodes with OperationFactory (#4567)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 02:42:09 +0000 (11:42 +0900)]
[neurun] Create all nodes with OperationFactory (#4567)

Move the nodes creation from `ANeuralNetworksModel_addOperation` to
`OperationFactory` for all 3 nodes that are still not moved.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoRemove deprecated docker script (#4565)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 02:04:41 +0000 (11:04 +0900)]
Remove deprecated docker script (#4565)

Remove deprecated scripts for common docker setting
Current scripts are using common setting script in scripts/config

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoUse ROOTFS_DIR without indirection (#4562)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 00:58:18 +0000 (09:58 +0900)]
Use ROOTFS_DIR without indirection (#4562)

* Use ROOTFS_DIR without indirection

The current implementation of Makfile sets ROOTFS_ARM/ROOTFS_ARM64 from
ROOTFS_DIR environment variable, and CMake uses ROOTFS_ARM/ROOTFS_ARM64
environment variable to locate the location of root filesystem.

This commit eliminates this indirection and now CMake uses ROOTFS_DIR
without indirection.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Update configure command

5 years ago[neurun] Create nodes with OperationFactory (#4563)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 5 Mar 2019 00:33:38 +0000 (09:33 +0900)]
[neurun] Create nodes with OperationFactory (#4563)

Move the nodes creation from `ANeuralNetworksModel_addOperation` to
`OperationFactory` for the nodes that are still not moved.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoIntroduce CI test and build script (#4561)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 00:26:15 +0000 (09:26 +0900)]
Introduce CI test and build script (#4561)

- Introduce directory for CI
- Introduce build script for pure acl release/debug build
- Introduce test script for pure acl

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoIntroduce 'nnfw' shell script (#4560)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 00:12:49 +0000 (09:12 +0900)]
Introduce 'nnfw' shell script (#4560)

* Introduce 'nnfw' shell script

This commit copies "run" as "nnfw" as the first step to rename "run" as
"nnfw".

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
* Update format-checker.sh

5 years agoRemove 'build-acl' command (#4558)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 5 Mar 2019 00:11:02 +0000 (09:11 +0900)]
Remove 'build-acl' command (#4558)

This commit removes unused 'build-acl' command.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years agoRemove unused targets in Makefile (#4556)
박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 4 Mar 2019 09:48:15 +0000 (18:48 +0900)]
Remove unused targets in Makefile (#4556)

This commit removes deprecated target "check" and related internal targets.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
5 years ago[neurun] Add some framework tests for neurun (#4546)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 4 Mar 2019 06:11:34 +0000 (15:11 +0900)]
[neurun] Add some framework tests for neurun (#4546)

This commit adds some `framework tests` for `neurun`

- depth_conv
- MODELS/mobilenet
- reshape

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoFix acl gbs build (#4548)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 4 Mar 2019 06:11:21 +0000 (15:11 +0900)]
Fix acl gbs build (#4548)

* Fix acl gbs build

Skip downloading arm compute source code downloading

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
* Try to download source if cannot find installed code

5 years agoClean up ARMComputeConfig.cmake file (#4547)
대인기/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 4 Mar 2019 05:50:32 +0000 (14:50 +0900)]
Clean up ARMComputeConfig.cmake file (#4547)

* Clean up ARMComputeConfig.cmake file

This patch cleans up existing ARMComputeConifg.cmake.
- Change ARMCompute_LIB_SEARCH_PATCHS to installed directory.
  . After building ARM Compute library, the libraries will be
    installed in the directory pointed by ARMCompute_PREFIX.
- Remove unnecessary target_link_libraries.
  . ARM Compute library can refer to OpenCL stub library itself.
- Add SConstruct file to cross-compile ARM Compute library
  . Now ARM Compute library upstream doesn't support Tizen
    platform so we will use SConstruct considered for Tizen
    until the change will go to upstream.
- Add several comments.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Move SConstruct to cmake/package/ARMCompute

Signed-off-by: Inki Dae <inki.dae@samsung.com>
5 years agoUse member variable to remain dlopen handle (#4534)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 4 Mar 2019 04:21:56 +0000 (13:21 +0900)]
Use member variable to remain dlopen handle (#4534)

Use member variable to avoid warning by handle lost without dlclose()

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Revise OperationValidator for simplicity (#4543)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 4 Mar 2019 04:18:51 +0000 (13:18 +0900)]
[neurun] Revise OperationValidator for simplicity (#4543)

Revise OperationValidator to override only used methods.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoAdd initialize lost class members initialization (#4535)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 4 Mar 2019 02:08:20 +0000 (11:08 +0900)]
Add initialize lost class members initialization (#4535)

Add initialize class members not defined yet

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[CMake] Print download error (#4529)
Saulo Aldighieri Moraes/Security R&D /SRBR/Assistant Engineer/삼성전자 [Mon, 4 Mar 2019 02:07:15 +0000 (23:07 -0300)]
[CMake] Print download error (#4529)

Improvement on cmake script to print detailed status message when download fails.
Example of new message format:

[ 11s] CMake Error at cmake/modules/ExternalSourceTools.cmake:39 (message):
[ 11s] error: downloading
[ 11s] 'https://github.com/ARM-software/ComputeLibrary/archive/v18.11.tar.gz'
[ 11s] failed
[ 11s]
[ 11s] status_code: 1
[ 11s] status_string: "Unsupported protocol"
[ 11s] log: Protocol "https" not supported or disabled in libcurl
[ 11s]
[ 11s] Closing connection -1

Signed-off-by: Saulo A. Moraes <s.moraes@samsung.com>
5 years ago[neurun] Fix Concat Elimination was not working (#4538)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 4 Mar 2019 02:00:30 +0000 (11:00 +0900)]
[neurun] Fix Concat Elimination was not working (#4538)

Implement default implementation for `NodeVisitor::visit(Subgraph)`.
Remove override implementation of `IStageGenerator`.
The default implementation is NOP so SubTensorAnalyzer was not working.
SubTensorAnalyzer changes are necessary for this commit otherwise it
crashes.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoWong directory name: tranpose -> transpose (#4537)
윤현식/On-Device Lab(SR)/Principal Engineer/삼성전자 [Thu, 28 Feb 2019 07:56:58 +0000 (16:56 +0900)]
Wong directory name: tranpose -> transpose (#4537)

Fixed wong directory name from `tranpose` to `transpose`

Signed-off-by: Hyun Sik Yoon <hyunsik.yoon@samsung.com>
5 years ago[neurun] Enable Cast op in neurun (#4496)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 28 Feb 2019 06:54:15 +0000 (15:54 +0900)]
[neurun] Enable Cast op in neurun (#4496)

* [neurun] Enable Cast op in neurun

This commit enables `Cast` op in `neurun` for `acl_cl`, that is from `PACL`.

* Initialize CLKernelLibraryEx

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoException handling on tflite_run (#4531)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Feb 2019 04:40:56 +0000 (13:40 +0900)]
Exception handling on tflite_run (#4531)

- Add noexcept keyword for Args constructor
- Add try-catch for external tflite interpreter setting

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoFix tflite_run tensor loader bug (#4533)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Feb 2019 04:40:29 +0000 (13:40 +0900)]
Fix tflite_run tensor loader bug (#4533)

Fix tflite_run tensor loader's raw data pointer type: unique_ptr of array

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoInstall gcc-6.2.1 abi toolchain (#4524)
대인기/On-Device Lab(SR)/Staff Engineer/삼성전자 [Thu, 28 Feb 2019 04:35:32 +0000 (13:35 +0900)]
Install gcc-6.2.1 abi toolchain (#4524)

* Install gcc-6.2.1 abi toolchain

This toolchain will be used to build NNFW for Tizen.

Signed-off-by: Inki Dae <inki.dae@samsung.com>
* Fix typo

Signed-off-by: Inki Dae <inki.dae@samsung.com>
5 years ago[neurun] Add Logistic operation (#4523)
윤지영/On-Device Lab(SR)/Engineer/삼성전자 [Thu, 28 Feb 2019 00:49:00 +0000 (09:49 +0900)]
[neurun] Add Logistic operation (#4523)

This commit does not have any kernel implementation.
It's only for a basic structure for Logistic operation.

Signed-off-by: Jiyoung Yun <jy910.yun@samsung.com>
5 years agoFix neurun build error (#4520)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Wed, 27 Feb 2019 08:17:57 +0000 (17:17 +0900)]
Fix neurun build error (#4520)

Fix neurun build error by conflict DataflowExecutor and Subgraph implementation. It's just workaround

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Auto-generate Config strings (#4515)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 07:22:27 +0000 (16:22 +0900)]
[neurun] Auto-generate Config strings (#4515)

With macro expansion, this commit generates variables for config
strings. It is recommended to use auto-generated Config string rather
than raw strings.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Revise graph partitioning code (#4510)
김용섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 07:17:54 +0000 (16:17 +0900)]
[neurun] Revise graph partitioning code (#4510)

* [neurun] Revise graph partitioning code

- Move graph paritionining code from Linear to Graph.
- Handle Subgraphs as like LowerInfo until Execution

* Add skipped code to fix failed test

* Change the access specifier of partition method from public to private

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
5 years ago[neurun] Revert to using const_cast for extendRank in Mul op (#4503)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 07:14:17 +0000 (16:14 +0900)]
[neurun] Revert to using const_cast for extendRank in Mul op (#4503)

* [neurun] Revert to using const_cast for extendRank in Mul op

This commit reverts to using `const_cast` for `extendRank` in `Mul` op.
That's because we've figured out the current implementation treats `copy` of `shape` object not `reference`.
It makes the `shape` not extend actually.

It seems it was a coincidence to be run all of tests related `broadcasting`.
(We need to check the tests...)

* add TrivialTest.BroadcastMulTwo test

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Fix multiple output bug in DotDumper (#4514)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 07:12:57 +0000 (16:12 +0900)]
[neurun] Fix multiple output bug in DotDumper (#4514)

This commit fixes multiple output bug in `DotDumper`.

```
node0 -> obj5
node0 -> obj5
node0 -> obj5
```

```
node0 -> obj3
node0 -> obj4
node0 -> obj5
```

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Less verbose namespace (#4509)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 06:55:03 +0000 (15:55 +0900)]
[neurun] Less verbose namespace (#4509)

Make namespace less verbose for IObject and its subclasses.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neuron] Correct wrong copyright year in SubNode (#4512)
이상규/On-Device Lab(SR)/Principal Engineer/삼성전자 [Wed, 27 Feb 2019 05:39:08 +0000 (14:39 +0900)]
[neuron] Correct wrong copyright year in SubNode (#4512)

SubNode in neurun is introduced this year (2019).
However, it was merged with 2018.
I've found it during implementation of squeeze.

Signed-off-by: Sanggyu Lee <sg5.lee@samsung.com>
5 years ago[neurun] Introduce DataflowExecutor (#4502)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 03:48:01 +0000 (12:48 +0900)]
[neurun] Introduce DataflowExecutor (#4502)

This commit introduces `DataFlowExecutor` which runs with
ready-run-notify mechanism. Unlike `Executor`(linear) the next operation
to execute is not decided at compile time, it rather chooses at runtime.
This makes it possible to run the model in parallel and soon we will
introduce multi-threaded executor.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Move the ownership of LowerInfoMap (#4504)
김용섭/On-Device Lab(SR)/Engineer/삼성전자 [Wed, 27 Feb 2019 01:35:38 +0000 (10:35 +0900)]
[neurun] Move the ownership of LowerInfoMap (#4504)

Move the ownership of LowerInfoMap from Graph to Linear

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
5 years ago[neurun] Sub operation (#4476)
윤현식/On-Device Lab(SR)/Principal Engineer/삼성전자 [Tue, 26 Feb 2019 10:25:53 +0000 (19:25 +0900)]
[neurun] Sub operation  (#4476)

* [neurun] sub operator support

Files for model and compilation were added. Test-skip file was modified.

Signed-off-by: Hyun Sik Yoon <hyunsik.yoon@samsung.com>
* frameworktest was added

* fix format checker error

* add TODO comment for const_cast issue

* renaming SubstractNode to SubNode

5 years agoIntroduce method to check compilable (#4500)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Feb 2019 09:07:52 +0000 (18:07 +0900)]
Introduce method to check compilable (#4500)

Introduce method to check compilable to handle case cannot compile (environment variable setting,  unspecified operand shape, etc)

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years agoChange Element in Linear to have lower_info (#4462)
김용섭/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Feb 2019 07:51:07 +0000 (16:51 +0900)]
Change Element in Linear to have lower_info (#4462)

Change Element in Linear to have lower_info for accessing backend
directly on compilation phase

Signed-off-by: Yongseop Kim <yons.kim@samsung.com>
5 years agoFrontend to support unspecified model input and output (#4495)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Feb 2019 07:49:41 +0000 (16:49 +0900)]
Frontend to support unspecified model input and output (#4495)

- Some model don't have specified shape for Input and output
- In that case, pass input and output shape to executor when prepare inference

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Introduce Job for DataflowExecutor (#4492)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Feb 2019 07:48:54 +0000 (16:48 +0900)]
[neurun] Introduce Job for DataflowExecutor (#4492)

Introduce Job class that is used by DataflowExecutor. This class is for
notified-run-notify mechanism.

- Once all waiting nodes are notified, this node can be executed
- Schedule this node and run
- After execution notify its outputs to awaiting nodes

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoSet input and output for interpreter (#4498)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Tue, 26 Feb 2019 07:48:35 +0000 (16:48 +0900)]
Set input and output for interpreter (#4498)

Collect input and output information for interpreter
Prepare set input and output

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove Plan from Compiler (#4497)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Tue, 26 Feb 2019 07:04:16 +0000 (16:04 +0900)]
[neurun] Remove Plan from Compiler (#4497)

Remove Plan object from Compiler members. It is not needed as a member
since it is only for `Executor`(linear).

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Fix typo in getOutputOperandIndex (#4489)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Feb 2019 09:36:30 +0000 (18:36 +0900)]
[neurun] Fix typo in getOutputOperandIndex (#4489)

I think it is correct to use `model().outputs` instead of `model().inputs` in `getOutputOperandIndex`.
This commit changes `model().inputs` to ``model().outputs` in `getOutputOperandIndex`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years ago[neurun] Enable tanh in neurun (#4467)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Feb 2019 09:22:36 +0000 (18:22 +0900)]
[neurun] Enable tanh in neurun (#4467)

* [neurun] Enable tanh in neurun

This commit enables `tanh` in `neurun` for `acl_cl`, that is from `PACL`.

* Fix typo

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoUse interpreter for model cannot compile (#4482)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Feb 2019 09:21:52 +0000 (18:21 +0900)]
Use interpreter for model cannot compile (#4482)

Use interpreter if try to compile, but cannot compile

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Introduce FunctionSequence (#4473)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Feb 2019 09:21:41 +0000 (18:21 +0900)]
[neurun] Introduce FunctionSequence (#4473)

Introduce `exec::FunctionSequence` class which is a linear composite of
`IFunction`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Fix enum typo in StageGenerator (#4487)
김수진/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Feb 2019 09:21:02 +0000 (18:21 +0900)]
[neurun] Fix enum typo in StageGenerator (#4487)

This commit fixes enum typo in `StageGenerator` for `StridedSliceNode`.

Signed-off-by: sjsujinkim <sjsujin.kim@samsung.com>
5 years agoFix cmake arm compute build and makefile (#4470)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Feb 2019 07:26:52 +0000 (16:26 +0900)]
Fix cmake arm compute build and makefile (#4470)

* Fix cmake arm compute build and makefile

- Remove legacy makefile setting for acl build
- Support multi-core acl build
- Fix acl install command to make directory and copy sequencially

* Support disable multithread acl build

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>
5 years ago[neurun] Remove unnecessary code in Graph::lower (#4486)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Feb 2019 07:26:30 +0000 (16:26 +0900)]
[neurun] Remove unnecessary code in Graph::lower (#4486)

Now that lower info is created just above, we do not need to clear the
containers manually.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years ago[neurun] Introduce ExecutorBase (#4483)
이한종/On-Device Lab(SR)/Engineer/삼성전자 [Mon, 25 Feb 2019 07:25:36 +0000 (16:25 +0900)]
[neurun] Introduce ExecutorBase (#4483)

This commit introduces `ExecutorBase` class which a subclass of
`IExecutor` for the convenience of setting inputs/outputs.
`ExecutorBase` does not depend on `Plan`, which make it possible to
implement `DataflowExecutor` without `Plan`.

Signed-off-by: Hanjoung Lee <hanjoung.lee@samsung.com>
5 years agoDisable acl build for tizen cross build (#4479)
오형석/On-Device Lab(SR)/Staff Engineer/삼성전자 [Mon, 25 Feb 2019 06:28:39 +0000 (15:28 +0900)]
Disable acl build for tizen cross build (#4479)

Update build script to disable acl build for tizen cross build

Signed-off-by: Hyeongseok Oh <hseok82.oh@samsung.com>