sdk/emulator/qemu.git
15 years agoqemu: msix nit: clear msix_entries_nr on error
Michael S. Tsirkin [Wed, 22 Jul 2009 15:51:14 +0000 (18:51 +0300)]
qemu: msix nit: clear msix_entries_nr on error

I don't think it's critical to do this, but it's
best to keep uninit and error recovery consistent.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoQEMU BOCHS bios patches to use maxcpus value.
Jes Sorensen [Thu, 23 Jul 2009 15:03:43 +0000 (17:03 +0200)]
QEMU BOCHS bios patches to use maxcpus value.

Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoIntroduce -smp , maxcpus= flag to specify maximum number of CPUS.
Jes Sorensen [Thu, 23 Jul 2009 15:03:42 +0000 (17:03 +0200)]
Introduce -smp , maxcpus= flag to specify maximum number of CPUS.

Follow on patch will use it to determine the size of the MADT and
other BIOS tables.

Signed-off-by: Jes Sorensen <jes@sgi.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoUse Little Endian for Dirty Log
Alexander Graf [Mon, 27 Jul 2009 10:49:56 +0000 (12:49 +0200)]
Use Little Endian for Dirty Log

We currently use host endian long types to store information
in the dirty bitmap.

This works reasonably well on Little Endian targets, because the
u32 after the first contains the next 32 bits. On Big Endian this
breaks completely though, forcing us to be inventive here.

So Ben suggested to always use Little Endian, which looks reasonable.

We only have dirty bitmap implemented in Little Endian targets so far
and since PowerPC would be the first Big Endian platform, we can just
as well switch to Little Endian always with little effort without
breaking existing targets.

This is the userspace part of the patch. It shouldn't change anything
for existing targets, but help PowerPC.

It replaces my older patch called "Use 64bit pointer for dirty log".

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoUse 64bit pointer for dirty log
Alexander Graf [Fri, 24 Jul 2009 23:16:44 +0000 (01:16 +0200)]
Use 64bit pointer for dirty log

Dirty logs currently get written with native "long" size. On little endian
it doesn't matter if we use uint64_t instead though, because we'd still end
up using the right bytes.

On big endian, this does become a bigger problem, so we need to ensure that
kernel and userspace talk the same language, which means getting rid of "long"
and using a defined size instead.

So I decided to use 64 bit types at all times. This doesn't break existing
targets but will in conjunction with a patch I'll send to the KVM ML make
dirty logs work with 32 bit userspace on 64 kernel with big endian.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoHPET fixes for reg writes
Beth Kon [Fri, 24 Jul 2009 16:26:59 +0000 (12:26 -0400)]
HPET fixes for reg writes

This patch addresses the problems found by Andriy Gapon:

- The code was incorrectly overwriting the high order 32
  bits of the timer and hpet config registers. This didn't show up
  in testing because linux and windows use hpet in legacy mode,
  where the high order 32 bits (advertising available interrupts)
  of the timer config register are ignored, and the high order 32
  bits of the hpet config register are reserved and unused.

- The mask for level-triggered interrupts was off by a bit. (hpet
  doesn't currently support level-triggered interrupts).

In addition, I removed some unused #defines, and corrected the ioapic
interrupt values advertised. I'd set this up early in hpet development
and never went back to correct it, and no bugs resulted since linux and
windows use hpet in legacy mode where available interrupts are ignored.

Signed-off-by: Beth Kon <eak@us.ibm.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoslirp: Fix guestfwd for incoming data
Jan Kiszka [Wed, 22 Jul 2009 15:03:52 +0000 (17:03 +0200)]
slirp: Fix guestfwd for incoming data

Unless a virtual server address was explicitly defined (which is
impossible with the legacy -net channel format), guestfwd did not
properly forwarded host->guest packets. This patch fixes it.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoswitch -drive to QemuOpts.
Gerd Hoffmann [Wed, 22 Jul 2009 14:43:04 +0000 (16:43 +0200)]
switch -drive to QemuOpts.

Demo QemuOpts in action ;)

Implementing a alternative way to specify the filename should be
just a few lines of code now once we decided how the cmd line syntax
should look like.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoQemuOpts: framework for storing and parsing options.
Gerd Hoffmann [Wed, 22 Jul 2009 14:43:03 +0000 (16:43 +0200)]
QemuOpts: framework for storing and parsing options.

This stores device parameters in a better way than unparsed strings.

New types:
  QemuOpt       -  one key-value pair.
  QemuOpts      -  group of key-value pairs, belonging to one
                   device, i.e. one drive.
  QemuOptsList  -  list of some kind of devices, i.e. all drives.

Functions are provided to work with these types.  The plan is that some
day we will pass around QemuOpts pointers instead of strings filled with
"key1=value1,key2=value2".

Check out the next patch to see all this in action ;)

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu-option: factor out parse_option_size
Gerd Hoffmann [Wed, 22 Jul 2009 14:43:02 +0000 (16:43 +0200)]
qemu-option: factor out parse_option_size

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu-option: factor out parse_option_bool
Gerd Hoffmann [Wed, 22 Jul 2009 14:43:01 +0000 (16:43 +0200)]
qemu-option: factor out parse_option_bool

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agomove parser functions from vl.c to qemu-option.c
Gerd Hoffmann [Wed, 22 Jul 2009 14:43:00 +0000 (16:43 +0200)]
move parser functions from vl.c to qemu-option.c

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agokill drives_opt
Gerd Hoffmann [Wed, 22 Jul 2009 14:42:59 +0000 (16:42 +0200)]
kill drives_opt

cleanup pretty simliar to the drives_table removal patch:
 - drop the table and make a linked list out of it.
 - pass around struct pointers instead of table indices.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoadd support for drive ids.
Gerd Hoffmann [Wed, 22 Jul 2009 14:42:58 +0000 (16:42 +0200)]
add support for drive ids.

-drive accepts the new id= now, allowing to explicitely name your
drives.  They will show up with that name in "info block" if specified,
otherwise the existing namimg scheme is used to autogenerate one.

There is also a new function to lookup drives by name.  Not used yet.
The plan is to link disk drivers and drives using the drive id instead
of passing around pointers to BlockDriveState.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agokill drives_table
Gerd Hoffmann [Wed, 22 Jul 2009 14:42:57 +0000 (16:42 +0200)]
kill drives_table

First step cleaning up the drives handling.  This one does nothing but
removing drives_table[], still it became seriously big.

drive_get_index() is gone and is replaced by drives_get() which hands
out DriveInfo pointers instead of a table index.  This needs adaption in
*tons* of places all over.

The drives are now maintained as linked list.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev/pci: hook up i440fx.
Gerd Hoffmann [Wed, 22 Jul 2009 13:17:01 +0000 (15:17 +0200)]
qdev/pci: hook up i440fx.

Hook i44fx pcihost into sysbus.
Convert Host bridge and ISA bridge pci devices to qdev.
Tag as no-user.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev: add -device command line option.
Gerd Hoffmann [Wed, 15 Jul 2009 11:59:26 +0000 (13:59 +0200)]
qdev: add -device command line option.

The -device switch is the users frontend to the qdev_device_add function
added by the previous patch.

Also adds a linked list where command line options can be saved.
Use it for the new -device and for the -usbdevice and -bt switches.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev: bus walker + qdev_device_add()
Gerd Hoffmann [Wed, 15 Jul 2009 11:59:25 +0000 (13:59 +0200)]
qdev: bus walker + qdev_device_add()

This patch implements a parser and qdev tree walker for bus paths and
adds qdev_device_add on top of this.

A bus path can be:
  (1) full path, i.e. /i440FX-pcihost/pci.0/lsi/scsi.0
  (2) bus name, i.e. "scsi.0".  Best used together with id= to make
      sure this is unique.
  (3) relative path starting with a bus name, i.e. "pci.0/lsi/scsi.0"

For the (common) case of a single child bus being attached to a device
it is enougth to specify the device only, i.e. "pci.0/lsi" will be
accepted too.

qdev_device_add() adds devices and accepts bus= parameters to find the
bus the device should be attached to.  Without bus= being specified it
takes the first bus it finds where the device can be attached to (i.e.
first pci bus for pci devices, ...).

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev: create default bus names.
Gerd Hoffmann [Wed, 15 Jul 2009 11:59:24 +0000 (13:59 +0200)]
qdev: create default bus names.

Create a default bus name if none is passed to qbus_create().

If the parent device has DeviceState->id set it will be used to create
the bus name,. i.e. -device lsi,id=foo will give you a scsi bus named
"foo.0".

If there is no id BusInfo->name (lowercased) will be used instead, i.e.
-device lsi will give you a scsi bus named "scsi.0".

A scsi adapter with two scsi busses would have "scsi.0" and "scsi.1" or
"$id.0" and "$id.1" busses.  The numbers of the child busses are per
device, i.e. when adding two lsi adapters both will have a "*.0" child
bus.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev/pci: use qdev_prop_pci_devfn
Gerd Hoffmann [Wed, 15 Jul 2009 11:59:23 +0000 (13:59 +0200)]
qdev/pci: use qdev_prop_pci_devfn

Put the new property into use.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqdev/prop: add pci devfn property
Gerd Hoffmann [Wed, 15 Jul 2009 11:59:22 +0000 (13:59 +0200)]
qdev/prop: add pci devfn property

So we can parse "$slot.$fn" strings into devfn numbers.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd a pc-0.11 machine type and make the pc type an alias
Mark McLoughlin [Wed, 22 Jul 2009 09:02:51 +0000 (10:02 +0100)]
Add a pc-0.11 machine type and make the pc type an alias

The pc-0.11 type allows users of qemu-0.11 to use a machine type which
they know will remain compatible when the upgrade to qemu-0.12.

Management tools may choose to canonicalize the 'pc' machine type to
'pc-0.11' so that if the 'pc' alias changes target in future versions
of qemu, the machine type used will remain compatible.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd machine type aliases
Mark McLoughlin [Wed, 22 Jul 2009 09:02:50 +0000 (10:02 +0100)]
Add machine type aliases

Add an 'alias' field to QEMUMachine and display it in the output of
'qemu -M ?' with an '(aliased to foo)' suffix.

Aliases can change targets in newer versions of qemu, so management tools
may choose canonicalize machine types to ensure that if a user chooses an
alias, that the actual machine type used will remain compatible in
future.

This is intended to mimic a symlink to a machine description file.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd support for fd=name to tap and socket networking
Mark McLoughlin [Wed, 22 Jul 2009 08:11:42 +0000 (09:11 +0100)]
Add support for fd=name to tap and socket networking

This allows a program to initialize a host networking device using a
file descriptor passed over a unix monitor socket.

The program must first pass the file descriptor using SCM_RIGHTS
ancillary data with the getfd monitor command. It then may do
"host_net_add tap fd=name" to use the named file descriptor.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd monitor_get_fd() command for fetching named fds
Mark McLoughlin [Wed, 22 Jul 2009 08:11:41 +0000 (09:11 +0100)]
Add monitor_get_fd() command for fetching named fds

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd getfd and closefd monitor commands
Mark McLoughlin [Wed, 22 Jul 2009 08:11:40 +0000 (09:11 +0100)]
Add getfd and closefd monitor commands

Add monitor commands to support passing file descriptors via
SCM_RIGHTS.

getfd assigns the passed file descriptor a name for use with other
monitor commands.

closefd allows passed file descriptors to be closed. If a monitor
command actually uses a named file descriptor, closefd will not be
required.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd SCM_RIGHTS support to unix socket character devices
Mark McLoughlin [Wed, 22 Jul 2009 08:11:39 +0000 (09:11 +0100)]
Add SCM_RIGHTS support to unix socket character devices

If a file descriptor is passed via a message with SCM_RIGHTS ancillary
data on a unix socket, store the file descriptor for use in the
chr_read() handler. Close the file descriptor if it was not used.

The qemu_chr_get_msgfd() API provides access to the passed descriptor.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoMake tcp_chr_read() use recvmsg()
Mark McLoughlin [Wed, 22 Jul 2009 08:11:38 +0000 (09:11 +0100)]
Make tcp_chr_read() use recvmsg()

Split out tcp_chr_recv() out of tcp_chr_read() and implement it on
non-win32 using recvmsg(). This is needed for a subsequent patch
which implements SCM_RIGHTS support.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosparc64 really implement itlb/dtlb automatic replacement writes
Igor Kovalenko [Sun, 26 Jul 2009 21:57:39 +0000 (01:57 +0400)]
sparc64 really implement itlb/dtlb automatic replacement writes

- implement "used" bit in tlb translation entry
- mark tlb entry used if qemu code/data translation succeeds
- fold i/d mmu replacement writes code into replace_tlb_1bit_lru which
adds 1bit lru replacement algorithm; previously code tried to replace
first unlocked entry only

- extract more bitmasks to named macros
- add "immu" or "dmmu" type name to debugging output where appropriate

Signed-off-by: igor.v.kovalenko@gmail.com
--
Kind regards,
Igor V. Kovalenko

15 years agosparc64 name mmu registers and general cleanup
Igor Kovalenko [Sun, 26 Jul 2009 21:49:04 +0000 (01:49 +0400)]
sparc64 name mmu registers and general cleanup

- add names to mmu registers, this helps understanding the code which
uses/modifies them.
- fold i/d mmu tlb entries tag and tte arrays into arrays of tlb entries
- extract demap_tlb routine (code duplication)
- extract replace_tlb routine (code duplication)

- flush qemu tlb translations when replacing sparc64 mmu tlb entries

I have no test case which demands flushing qemu translations,
and this patch should have no other visible changes to runtime.

Signed-off-by: igor.v.kovalenko@gmail.com
--
Kind regards,
Igor V. Kovalenko

15 years agoGive the kernel more room
Alexander Graf [Sun, 26 Jul 2009 06:31:32 +0000 (06:31 +0000)]
Give the kernel more room

My self-built PPC kernel doesn't fit in the region reserved for
the kernel, so I can't use -kernel with it.

Let's just extend the region.

Signed-off-by: Alexander Graf <agraf@suse.de>
15 years agoPPC: Round VGA BIOS size to page boundary
Alexander Graf [Sun, 26 Jul 2009 06:31:15 +0000 (06:31 +0000)]
PPC: Round VGA BIOS size to page boundary

When giving KVM a slot of a size not on page boundary, it chokes. So let's
just round up the VGA BIOS size so nobody complains anymore and we don't need
to implement sub-page slots.

Required for booting a PPC guest in KVM.

Signed-off-by: Alexander Graf <agraf@suse.de>
15 years agoFix period initialization
malc [Fri, 24 Jul 2009 01:16:12 +0000 (05:16 +0400)]
Fix period initialization

Signed-off-by: malc <av1474@comtv.ru>
15 years agoprovide tests for pit in kernel and irqchip in kernel
Glauber Costa [Tue, 21 Jul 2009 15:26:58 +0000 (12:26 -0300)]
provide tests for pit in kernel and irqchip in kernel

KVM can have an in-kernel pit or irqchip. While we don't implement it
yet, having a way for test for it (that always returns zero) will allow us
to reuse code in qemu-kvm that tests for it.

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu-thread: use pthread_equal
Sebastian Herbszt [Sun, 19 Jul 2009 13:16:09 +0000 (15:16 +0200)]
qemu-thread: use pthread_equal

Fixes

qemu-thread.c: In function `qemu_thread_equal':
qemu-thread.c:161: error: invalid operands to binary ==

Use of pthread_equal suggested by Filip Navara.

Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoLink bios files when building out of tree
Jan Kiszka [Fri, 17 Jul 2009 09:20:10 +0000 (11:20 +0200)]
Link bios files when building out of tree

When starting a qemu binary directly from the build directory and that
dir is located outside the source files, the search for bios files
fails. Fix this by linking them from the build to the source directory.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosignrom.sh: portability fix
Christoph Egger [Fri, 17 Jul 2009 13:23:51 +0000 (15:23 +0200)]
signrom.sh: portability fix

Attached patch makes signrom.sh working on NetBSD.
The output of the 'od' command leads to a syntax error
which breaks the build.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agonotify io_thread at the end of rx handling
Glauber Costa [Mon, 20 Jul 2009 17:07:41 +0000 (13:07 -0400)]
notify io_thread at the end of rx handling

This is a backport from qemu-kvm. Just instead of using kvm's specific
notification mechanism, we use qemu_notify_event()

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agointroduce on_vcpu
Glauber Costa [Thu, 16 Jul 2009 21:55:28 +0000 (17:55 -0400)]
introduce on_vcpu

on_vcpu is a qemu-kvm function that will make sure that a specific
piece of code will run on a requested cpu. We don't need that because
we're restricted to -smp 1 right now, but those days are likely to end soon.

So for the benefit of having qemu-kvm share more code with us, I'm
introducing our own version of on_vcpu(). Right now, we either run
a function on the current cpu, or abort the execution, because it would
mean something is seriously wrong.

As an example code, I "ported" kvm_update_guest_debug to use it,
with some slight differences from qemu-kvm.

This is probably 0.12 material

Signed-off-by: Glauber Costa <glommer@redhat.com>
CC: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu-io: reject invalid pattern
Christoph Hellwig [Sun, 19 Jul 2009 23:19:25 +0000 (01:19 +0200)]
qemu-io: reject invalid pattern

Replace the use of atoi which is used for pattern parsing currently with
strtol.  Atoi won't parse sedecimal pattern values (it always returns 0),
but qemu-iotests use such pattern values.  Also reject every pattern
that is not a unsigned char as we pass the pattern to memset which
expect a bye value (despite having the pattern argument declared as int).

Based on an earlier patch by Stefan Weil which did not include the
error handling.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reported-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqemu-io: Rework alloc command
Kevin Wolf [Mon, 20 Jul 2009 14:48:43 +0000 (16:48 +0200)]
qemu-io: Rework alloc command

The alloc command in qemu-io is mostly useless currently. Instead of doing a
single call to bdrv_is_allocated, we must call bdrv_is_allocated in a loop
until we have found out for each requested sector if it is allocated or not
(bdrv_is_allocated returns a number of sectors that are known to be in the same
state as the first one, but it is not required to include all of them)

This changes the output format of the alloc command so that a change to the
expected output of qemu-iotests 019 is necessary once this is included.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoqmu-img: fix qemu-img convert to generate a valid image when the source referenced...
Akkarit Sangpetch [Fri, 17 Jul 2009 08:02:15 +0000 (10:02 +0200)]
qmu-img: fix qemu-img convert to generate a valid image when the source referenced a backing file

Make 'qemu-img convert' copies unallocated parts of the source image
when -B option was not specified.

Signed-off-by: Akkarit Sangpetch <asangpet@andrew.cmu.edu>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agovmdk: Fix backing file handling
Kevin Wolf [Fri, 17 Jul 2009 06:20:41 +0000 (08:20 +0200)]
vmdk: Fix backing file handling

Instead of storing the backing file in its own BlockDriverState, VMDK uses the
BlockDriverState of the raw image file it opened. This is wrong and breaks
functions that access the backing file or protocols. This fix replaces all
occurrences of s->hd->backing_* with bs->backing_*.

This fixes qemu-iotests failure in 020 (Commit changes to backing file).

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agouse struct initializer for audio.c
Juan Quintela [Mon, 20 Jul 2009 18:57:00 +0000 (20:57 +0200)]
use struct initializer for audio.c

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoAdd save/restore support to the LSI logic SCSI device model.
Nolan [Mon, 20 Jul 2009 21:11:35 +0000 (14:11 -0700)]
Add save/restore support to the LSI logic SCSI device model.

This patch requires "Handle BH's queued by AIO completions in
qemu_aio_flush()" to work reliably.  The combination of those two
patches survived 300+ migrations with heavy IO load running in the
guest.

Signed-off-by: Nolan Leake <nolan <at> sigbus.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoHandle BH's queued by AIO completions in qemu_aio_flush()
Nolan [Mon, 20 Jul 2009 21:01:25 +0000 (14:01 -0700)]
Handle BH's queued by AIO completions in qemu_aio_flush()

Without this, the call to qemu_aio_flush during migration doesn't
actually flush all in-flight SCSI IOs.

Signed-off-by: Nolan Leake <nolan <at> sigbus.net>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoFake dirty loggin when it's not there
Alexander Graf [Fri, 17 Jul 2009 11:51:48 +0000 (13:51 +0200)]
Fake dirty loggin when it's not there

Some KVM platforms don't support dirty logging yet, like IA64 and PPC,
so in order to still have screen updates on those, we need to fake it.

This patch just tells the getter function for dirty bitmaps, that all
pages within a slot are dirty when the slot has dirty logging enabled.

That way we can implement dirty logging on those platforms sometime when
it drags down performance, but share the rest of the code with dirty
logging capable platforms.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoUse correct input constant
Alexander Graf [Fri, 17 Jul 2009 11:51:46 +0000 (13:51 +0200)]
Use correct input constant

440 and desktop codes use different input constants for interrupt indication.

Let's use the respective ones for KVM.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoFix warning in kvm-all.c
Alexander Graf [Fri, 17 Jul 2009 11:51:45 +0000 (13:51 +0200)]
Fix warning in kvm-all.c

This fixes a warning I stumbled across while compiling qemu on PPC64.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoSet PVR in sregs
Alexander Graf [Fri, 17 Jul 2009 11:51:43 +0000 (13:51 +0200)]
Set PVR in sregs

We need to tell the kernel about some initial CPU state we don't have yet,
so let's use the "sregs" IOCTL for that and simply put the Processor Version
Register in there.

Now the kernel knows which guest CPU to virtualize.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoEnable PPC KVM for non-embedded
Alexander Graf [Fri, 17 Jul 2009 11:51:42 +0000 (13:51 +0200)]
Enable PPC KVM for non-embedded

We now have KVM on PPC64 too and might get it on PPC32 as well, as soon
as someone writes it.

So let's enable KVM for PPC32 and PPC64 targets.

Signed-off-by: Alexander Graf <agraf@suse.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoSparc32: convert Sun4c interrupt controller to qdev
Blue Swirl [Tue, 21 Jul 2009 19:57:32 +0000 (19:57 +0000)]
Sparc32: convert Sun4c interrupt controller to qdev

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc32: convert SBI to qdev
Blue Swirl [Tue, 21 Jul 2009 19:25:59 +0000 (19:25 +0000)]
Sparc32: convert SBI to qdev

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoFix CONFIG_PROFILER
Blue Swirl [Tue, 21 Jul 2009 12:18:03 +0000 (12:18 +0000)]
Fix CONFIG_PROFILER

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc32/64: use 64 bit type for memory size
Blue Swirl [Tue, 21 Jul 2009 11:20:11 +0000 (11:20 +0000)]
Sparc32/64: use 64 bit type for memory size

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoqdev: add 64 bit type
Blue Swirl [Tue, 21 Jul 2009 11:10:41 +0000 (11:10 +0000)]
qdev: add 64 bit type

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc64: refactor kernel init
Blue Swirl [Tue, 21 Jul 2009 10:49:47 +0000 (10:49 +0000)]
Sparc64: refactor kernel init

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc64: refactor CPU init
Blue Swirl [Tue, 21 Jul 2009 10:46:23 +0000 (10:46 +0000)]
Sparc64: refactor CPU init

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc64: convert memory to qdev
Blue Swirl [Tue, 21 Jul 2009 10:04:47 +0000 (10:04 +0000)]
Sparc64: convert memory to qdev

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc64: convert boot prom to qdev
Blue Swirl [Tue, 21 Jul 2009 09:58:02 +0000 (09:58 +0000)]
Sparc64: convert boot prom to qdev

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc32: Fix lance
Blue Swirl [Tue, 21 Jul 2009 08:36:52 +0000 (08:36 +0000)]
Sparc32: Fix lance

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc64: convert APB to qdev
Blue Swirl [Tue, 21 Jul 2009 08:36:37 +0000 (08:36 +0000)]
Sparc64: convert APB to qdev

Thanks to Igor Kovalenko for a bugfix.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoFix most warnings (errors with -Werror) when debugging is enabled
Blue Swirl [Mon, 20 Jul 2009 17:19:25 +0000 (17:19 +0000)]
Fix most warnings (errors with -Werror) when debugging is enabled

I used the following command to enable debugging:
perl -p -i -e 's/^\/\/#define DEBUG/#define DEBUG/g' * */* */*/*

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoFix build with DEBUG_PCI in pci_host.h enabled
Blue Swirl [Mon, 20 Jul 2009 10:37:51 +0000 (10:37 +0000)]
Fix build with DEBUG_PCI in pci_host.h enabled

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoClean up fdc qdev conversion
Blue Swirl [Mon, 20 Jul 2009 06:56:23 +0000 (06:56 +0000)]
Clean up fdc qdev conversion

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoFix rbase initialization
malc [Sun, 19 Jul 2009 21:14:43 +0000 (01:14 +0400)]
Fix rbase initialization

Signed-off-by: malc <av1474@comtv.ru>
15 years agoFix a similar configure typo from microblaze.
Andrzej Zaborowski [Sat, 18 Jul 2009 12:32:00 +0000 (14:32 +0200)]
Fix a similar configure typo from microblaze.

15 years agothis patch fixes a typo where armv4l was incorrectly spelled arm4l,
Laurent Desnogues [Sat, 18 Jul 2009 12:23:39 +0000 (14:23 +0200)]
this patch fixes a typo where armv4l was incorrectly spelled arm4l,
preventing the correct handling of --cpu=armv4l.

Laurent

Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
15 years agothis patch improves the ARM back-end in the following way:
Laurent Desnogues [Sat, 18 Jul 2009 12:20:30 +0000 (14:20 +0200)]
this patch improves the ARM back-end in the following way:

- use movw/movt to load immediate values for ARMv7-A
- implement add/sub/and/or/xor with immediate (only 8-bit)

Laurent

Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Andrzej Zaborowski <andrew.zaborowski@intel.com>
15 years agotcg: Fix tcg_gen_rotr_i64
Aurelien Jarno [Sat, 18 Jul 2009 09:15:40 +0000 (11:15 +0200)]
tcg: Fix tcg_gen_rotr_i64

Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
15 years agoUse correct byteswap routine for elf_note
malc [Sat, 18 Jul 2009 09:12:20 +0000 (13:12 +0400)]
Use correct byteswap routine for elf_note

All elf64_note structure members are Elf64_Word (which is 32bit value)
hence using bswaptls to byteswap it on 64bit platforms is incorrect.

Signed-off-by: malc <av1474@comtv.ru>
15 years agoAvoid name clashes with symbols that leak from system headers
malc [Sat, 18 Jul 2009 09:10:12 +0000 (13:10 +0400)]
Avoid name clashes with symbols that leak from system headers

Signed-off-by: malc <av1474@comtv.ru>
15 years agoPPC 32/64 GUEST_BASE support
malc [Sat, 18 Jul 2009 06:08:40 +0000 (10:08 +0400)]
PPC 32/64 GUEST_BASE support

Signed-off-by: malc <av1474@comtv.ru>
15 years agoFix LHZX opcode value
malc [Sat, 18 Jul 2009 09:15:55 +0000 (13:15 +0400)]
Fix LHZX opcode value

Signed-off-by: malc <av1474@comtv.ru>
15 years agoUserspace guest address offsetting
Juan Quintela [Fri, 17 Jul 2009 18:11:36 +0000 (20:11 +0200)]
Userspace guest address offsetting

Fix type in i386 tcg.

Signed-off-by: Juan Quintela <quintela@redhat.com>
15 years agobsd-users: fix strace
Christoph Egger [Fri, 17 Jul 2009 17:48:03 +0000 (17:48 +0000)]
bsd-users: fix strace

Hi!

Attached patch fixes an unlock bug in strace.
Catched by gcc due to an use of uninitialized variable.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

15 years agoisxdigit -> qemu_isxdigit
Christoph Egger [Fri, 17 Jul 2009 17:48:02 +0000 (17:48 +0000)]
isxdigit -> qemu_isxdigit

Hi!

Attached patch uses qemu_isxdigit() instead of isxdigit().
Fixes build warning on NetBSD.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

15 years agofix build warnings
Christoph Egger [Fri, 17 Jul 2009 17:48:01 +0000 (17:48 +0000)]
fix build warnings

Hi!

Attached patch fixes build warnings due to use of different pointer
signedness.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

15 years agoELF codedump build failures
Laurent Desnogues [Fri, 17 Jul 2009 12:33:41 +0000 (13:33 +0100)]
ELF codedump build failures

Rename ELF coredump types to avoid conflict with the corresponding host types.

Signed-off-by: Laurent Desnogues <laurent.desnogues@gmail.com>
15 years agoUserspace guest address offsetting
Paul Brook [Fri, 17 Jul 2009 11:48:08 +0000 (12:48 +0100)]
Userspace guest address offsetting

Re-implement GUEST_BASE support.
Offset guest ddress space by default if the guest binary contains
regions below the host mmap_min_addr.
Implement support for i386, x86-64 and arm hosts.

Signed-off-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Paul Brook <paul@codesourcery.com>
15 years agoSuppress a Sparse warning
Blue Swirl [Fri, 17 Jul 2009 11:18:53 +0000 (11:18 +0000)]
Suppress a Sparse warning

Move the export to a file used by both qdev.c and sysbus.c.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc32: use hex for version numbers
Blue Swirl [Fri, 17 Jul 2009 11:01:50 +0000 (11:01 +0000)]
Sparc32: use hex for version numbers

0x10000000 looks better than 268435456.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc32: fix escc devices broken by ee6847d19be16c789b8bd4e553b7cd6701ba1245
Blue Swirl [Fri, 17 Jul 2009 11:01:49 +0000 (11:01 +0000)]
Sparc32: fix escc devices broken by ee6847d19be16c789b8bd4e553b7cd6701ba1245

The logic of Zilog makes channel B the first device and channel A the
second one.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoSparc32: fix fdc io_base
Blue Swirl [Fri, 17 Jul 2009 11:01:48 +0000 (11:01 +0000)]
Sparc32: fix fdc io_base

On some Sparc32 machines, fdc is located above 4G limit, so uint32_t is not
appropriate type for io_base.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoFix sparc-softmmu breakage by ee6847d19be16c789b8bd4e553b7cd6701ba1245
Blue Swirl [Fri, 17 Jul 2009 11:01:47 +0000 (11:01 +0000)]
Fix sparc-softmmu breakage by ee6847d19be16c789b8bd4e553b7cd6701ba1245

Move the qdev_init(dev); call after the setting of d->size.
Thanks to Filip Navara.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoFix OpenBSD build
Blue Swirl [Fri, 17 Jul 2009 11:01:45 +0000 (11:01 +0000)]
Fix OpenBSD build

The header sys-queue.h must be #included early, otherwise at some point OS
queue macros will be used. On OpenBSD, those don't define TAILQ_FOREACH_SAFE.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
15 years agoARM host fixes
Paul Brook [Fri, 17 Jul 2009 10:21:12 +0000 (11:21 +0100)]
ARM host fixes

Minor TCG cleanups and warning fixes for ARM hosts.

Signed-off-by: Paul Brook <paul@codesourcery.com>
15 years agoOnly allow -cpu host when KVM is enabled
Anthony Liguori [Fri, 17 Jul 2009 03:20:22 +0000 (22:20 -0500)]
Only allow -cpu host when KVM is enabled

-cpu host is not at all useful when using tcg.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoMove CLOCKLIBS and PTHREADLIBS out of CONFIG_LINUX_USER_ONLY
Anthony Liguori [Fri, 17 Jul 2009 03:02:43 +0000 (22:02 -0500)]
Move CLOCKLIBS and PTHREADLIBS out of CONFIG_LINUX_USER_ONLY

Otherwise, -lrt doesn't get added to the softmmu build.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoInitialize cpuid variables
Anthony Liguori [Fri, 17 Jul 2009 02:33:48 +0000 (21:33 -0500)]
Initialize cpuid variables

This causes a build break when !KVM.

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoIgnore -Waddress for alsaaudio.c
malc [Fri, 17 Jul 2009 01:57:04 +0000 (05:57 +0400)]
Ignore -Waddress for alsaaudio.c

/usr/include/alsa/pcm.h contains:

#define snd_pcm_sw_params_alloca(ptr) do { assert(ptr); *ptr = (snd_pcm_sw_params_t *) alloca(snd_pcm_sw_params_sizeof()); memset(*ptr, 0, snd_pcm_sw_params_sizeof()); } while (0)

The assert generates: "error: the address of 'sw_params' will always
evaluate as 'true'" which combined with -Werror prevents alsaaudio.o
from being built with certain versions of GCC.

15 years agoUpdate version for 0.11 development
Anthony Liguori [Thu, 16 Jul 2009 23:12:18 +0000 (18:12 -0500)]
Update version for 0.11 development

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoUpdate version for 0.11.0-rc0
Anthony Liguori [Thu, 16 Jul 2009 23:10:53 +0000 (18:10 -0500)]
Update version for 0.11.0-rc0

15 years agoGenerate $target_dir/config.h from $target_dir/config.mak
Juan Quintela [Thu, 16 Jul 2009 16:34:20 +0000 (18:34 +0200)]
Generate $target_dir/config.h from $target_dir/config.mak

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agoRefactor config_softfloat selection in another list
Juan Quintela [Thu, 16 Jul 2009 16:34:19 +0000 (18:34 +0200)]
Refactor config_softfloat selection in another list

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agorename s/config_mak/config_host_mak/ and s/config_h/config_host_h/
Juan Quintela [Thu, 16 Jul 2009 16:34:18 +0000 (18:34 +0200)]
rename s/config_mak/config_host_mak/ and s/config_h/config_host_h/

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosimplify TARGET_ABI_DIR generation
Juan Quintela [Thu, 16 Jul 2009 16:34:17 +0000 (18:34 +0200)]
simplify TARGET_ABI_DIR generation

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosimplify TARGET_ARCH2 generation
Juan Quintela [Thu, 16 Jul 2009 16:34:16 +0000 (18:34 +0200)]
simplify TARGET_ARCH2 generation

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agosimplify TARGET_BASE_ARCH generation
Juan Quintela [Thu, 16 Jul 2009 16:34:15 +0000 (18:34 +0200)]
simplify TARGET_BASE_ARCH generation

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
15 years agogenerate TARGET_<arch name> for config.h
Juan Quintela [Thu, 16 Jul 2009 16:34:14 +0000 (18:34 +0200)]
generate TARGET_<arch name> for config.h

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>