platform/upstream/gcc.git
2 years agolibstdc++: Improve test for printing volatile pointers
Jonathan Wakely [Tue, 5 Oct 2021 13:45:11 +0000 (14:45 +0100)]
libstdc++: Improve test for printing volatile pointers

libstdc++-v3/ChangeLog:

* testsuite/27_io/basic_ostream/inserters_other/char/volatile_ptr.cc:
Check result matches non-volatile pointer.

2 years agoAllow more kinds of invariant addresses in GIMPLE FE
Richard Biener [Tue, 5 Oct 2021 12:18:09 +0000 (14:18 +0200)]
Allow more kinds of invariant addresses in GIMPLE FE

The gimple FE is too restrictive in what it accepts as
literals, the following makes it also accept &a[10] for example.

2021-10-05  Richard Biener  <rguenther@suse.de>

PR c/102605
gcc/c/
* gimple-parser.c (c_parser_gimple_postfix_expression):
Accept more address _Literals.

gcc/testsuite/
* gcc.dg/gimplefe-46.c: New testcase.

2 years agoc++: templated static local var has value-dep addr [PR98930]
Patrick Palka [Tue, 5 Oct 2021 13:50:02 +0000 (09:50 -0400)]
c++: templated static local var has value-dep addr [PR98930]

Here uses_template_parms returns false for the dependent type A<&impl::i>,
which causes tsubst_aggr_type to think it's non-dependent and not bother
substituting into it, leading to breakage.

This patch fixes this by making has_value_dependent_address also return
true for templated static local variables.

PR c++/98930

gcc/cp/ChangeLog:

* pt.c (has_value_dependent_address): Return true for a static
local variable from a function template.

gcc/testsuite/ChangeLog:

* g++.dg/cpp1z/nontype4.C: New test.
* g++.dg/cpp1z/nontype4a.C: New test.

2 years agogfortran.dg/gomp/pr43711.f90: Change dg-* for XFAIL->PASS
Tobias Burnus [Tue, 5 Oct 2021 12:28:10 +0000 (14:28 +0200)]
gfortran.dg/gomp/pr43711.f90: Change dg-* for XFAIL->PASS

gcc/testsuite/
* gfortran.dg/gomp/pr43711.f90: Add dg-error + dg-prune-output,
remove dg-excess-errors to change XFAIL to PASS.

2 years agoMake flow of option processing more readily visible
Richard Biener [Tue, 5 Oct 2021 10:35:57 +0000 (12:35 +0200)]
Make flow of option processing more readily visible

This moves calls to various option processing stages to one place,
toplev::main.

2021-10-05  Richard Biener  <rguenther@suse.de>

* toplev.c (no_backend): Remove global var.
(process_options): Pass in no_backend, move post_options
langhook call to toplev::main.
(do_compile): Pass in no_backend, move process_options call
to toplev::main.
(toplev::run_self_tests): Check no_backend at the caller.
(toplev::main): Call post_options and process_options
split out from do_compile, do self-tests only if
no_backend is initialized.

2 years agoAmend function names with UID when dumping with TDF_UID
Richard Biener [Tue, 5 Oct 2021 09:41:42 +0000 (11:41 +0200)]
Amend function names with UID when dumping with TDF_UID

The following makes sure to amend more function names with the
associated DECL_UID when dumping with TDF_UID, in particular
function names printed as part of calls and in the function header.
That allows one to more easily follow the call flow of PR102528
where coroutines cause three clones of the name 'test2' that are
not distinguishable otherwise.

2021-10-05  Richard Biener  <rguenther@suse.de>

* tree-cfg.c (dump_function_to_file): Dump the UID of the
function as part of the name when requested.
* tree-pretty-print.c (dump_function_name): Dump the UID when
requested and the langhook produced the actual name.

2 years agoMore .DEFERRED_INIT expansion rework
Richard Biener [Tue, 5 Oct 2021 07:28:20 +0000 (09:28 +0200)]
More .DEFERRED_INIT expansion rework

This avoids looking at the type size and instead uses the size
as passed to .DEFERRED_INIT to determine the size of the non-MEM
to be initialized.  It also arranges for possibly poly-int
inits to always use zero-initialization rather than not initializing
and when we need to pun puns the LHS instead of the constant value.

That correctly initializes the variable-size typed array in the
testcase for PR102285 and the SVE vector in PR102587 where for
the testcase I needed to add a SVE capable -march as to not
ICE later.

2021-10-05  Richard Biener  <rguenther@suse.de>

PR middle-end/102587
PR middle-end/102285
* internal-fn.c (expand_DEFERRED_INIT): Fall back to
zero-initialization as last resort, use the constant
size as given by the DEFERRED_INIT argument to build
the initializer.

* gcc.target/aarch64/sve/pr102587-1.c: Add -march=armv8.3-a+sve.
* gcc.target/aarch64/sve/pr102587-2.c: Likewise.

2 years agolibstdc++: Fix testcase for newly-implemented C++20 semantics [PR102535]
Jonathan Wakely [Tue, 5 Oct 2021 08:32:11 +0000 (09:32 +0100)]
libstdc++: Fix testcase for newly-implemented C++20 semantics [PR102535]

libstdc++-v3/ChangeLog:

PR c++/102535
* testsuite/20_util/is_trivially_constructible/value.cc: Adjust
expected value for C++20.

2 years agolibstdc++: Add noexcept to some std::function internals
Jonathan Wakely [Mon, 4 Oct 2021 14:22:58 +0000 (15:22 +0100)]
libstdc++: Add noexcept to some std::function internals

libstdc++-v3/ChangeLog:

* include/bits/std_function.h (_Any_data::_M_access): Add
noexcept.
(_Function_base::_Base_manager::_M_get_pointer): Likewise.
(_Function_base::_Base_manager::_M_not_empty_function):
Likewise.

2 years agolibstdc++: Support printing volatile pointers (P1147R1)
Jonathan Wakely [Mon, 4 Oct 2021 14:22:00 +0000 (15:22 +0100)]
libstdc++: Support printing volatile pointers (P1147R1)

To avoid needing to export a new symbol from the library (for now) the
new member function uses __attribute__((always_inline)).

libstdc++-v3/ChangeLog:

* include/std/ostream (operator<<(const volatile void*)):
Add new overload, as per P1147R1.
* testsuite/27_io/basic_ostream/inserters_other/char/volatile_ptr.cc:
New test.

2 years agolibstdc++: Update __cpp_lib_adaptor_iterator_pair_constructor value
Jonathan Wakely [Mon, 4 Oct 2021 19:16:47 +0000 (20:16 +0100)]
libstdc++: Update __cpp_lib_adaptor_iterator_pair_constructor value

I started implementing this feature before it was voted into the C++ WP,
and forgot to update the feature test macro after it was approved.

This defines it to the correct value, as specified in the C++23 draft.

libstdc++-v3/ChangeLog:

* include/bits/stl_queue.h
(__cpp_lib_adaptor_iterator_pair_constructor): Set to correct
value.
* include/bits/stl_stack.h
(__cpp_lib_adaptor_iterator_pair_constructor): Likewise.
* include/std/version
(__cpp_lib_adaptor_iterator_pair_constructor): Likewise.
* testsuite/23_containers/queue/cons_from_iters.cc: Update
expected value.
* testsuite/23_containers/stack/cons_from_iters.cc: Likewise.

2 years ago[Ada] Plug small loophole with boolean values
Eric Botcazou [Fri, 24 Sep 2021 13:20:22 +0000 (15:20 +0200)]
[Ada] Plug small loophole with boolean values

gcc/ada/

* gcc-interface/trans.c (gnat_to_gnu): Do not wrap boolean values
referenced in pragmas.

2 years ago[Ada] Do not unconditionally inline expression functions with -gnatd.8
Eric Botcazou [Thu, 12 Aug 2021 20:53:53 +0000 (22:53 +0200)]
[Ada] Do not unconditionally inline expression functions with -gnatd.8

gcc/ada/

* gcc-interface/trans.c (Subprogram_Body_to_gnu): Do not set the
DECL_DISREGARD_INLINE_LIMITS flag if -gnatd.8 is specified.

2 years ago[Ada] Fix latent bug in set_end_locus_from_node
Bob Duff [Wed, 11 Aug 2021 11:44:31 +0000 (07:44 -0400)]
[Ada] Fix latent bug in set_end_locus_from_node

gcc/ada/

* gcc-interface/trans.c (set_end_locus_from_node): Check that
Handled_Statement_Sequence is not Empty before calling
End_Label, because the Empty node has no End_Label, and
depending on the exact node layout chosen by gen_il, calling
End_Label might crash, or might work OK by accident.

2 years ago[Ada] Minor include directives placement adjustment
Eric Botcazou [Mon, 2 Aug 2021 18:53:30 +0000 (20:53 +0200)]
[Ada] Minor include directives placement adjustment

gcc/ada/

* gcc-interface/cuintp.c: Adjust placement of include directive.
* gcc-interface/targtyps.c: Likewise.

2 years ago[Ada] introduce stack scrub (strub) feature
Alexandre Oliva [Thu, 23 Sep 2021 12:46:54 +0000 (09:46 -0300)]
[Ada] introduce stack scrub (strub) feature

gcc/ada/

* doc/gnat_rm.rst: Add...
* doc/gnat_rm/security_hardening_features.rst: New.
* doc/gnat_rm/about_this_guide.rst: Link to new chapter.
* gnat_rm.texi: Regenerate.
* gcc-interface/utils.c (handle_strub_attribute): New.
(gnat_internal_attribute_table): Add strub.
* libgnat/a-except.adb: Make Rcheck_CE_* strub-callable.
* libgnat/a-except.ads (Raise_Exception): Likewise.
(Raise_Exception_Always): Likewise.
* libgnat/s-arit128.ads (Multiply_With_Ovflo_Check128):
Likewise.
* libgnat/s-arit64.ads (Multiply_With_Ovflo_Check64):
Likewise.
* libgnat/s-secsta.ads (SS_Allocate, SS_Mark, SS_Release):
Likewise.

2 years ago[Ada] Mark private component renaming as coming from source
Eric Botcazou [Thu, 23 Sep 2021 10:06:42 +0000 (12:06 +0200)]
[Ada] Mark private component renaming as coming from source

gcc/ada/

* exp_ch9.adb (Install_Private_Data_Declarations): Copy the Sloc of
components for the local renamings as well as the Comes_From_Source
flag, and also set Warnings_Off on them.  Use Nam local variable.

2 years ago[Ada] Add comments in Ada.Task_Initialization
Arnaud Charlet [Thu, 23 Sep 2021 10:04:41 +0000 (06:04 -0400)]
[Ada] Add comments in Ada.Task_Initialization

gcc/ada/

* libgnarl/a-tasini.ads (Set_Initialization_Handler): Update
comments.

2 years ago[Ada] Include errno.h in QNX specific part of the signal handling
Corentin Gay [Mon, 20 Sep 2021 15:27:37 +0000 (17:27 +0200)]
[Ada] Include errno.h in QNX specific part of the signal handling

gcc/ada/

* init.c (QNX): Add #include errno.h.

2 years ago[Ada] Remove left-overs of Unaligned_Valid attribute
Eric Botcazou [Thu, 23 Sep 2021 09:18:02 +0000 (11:18 +0200)]
[Ada] Remove left-overs of Unaligned_Valid attribute

gcc/ada/

* exp_attr.adb (Expand_Fpt_Attribute): Likewise.
* snames.ads-tmpl (Name_Unaligned_Valid): Delete.

2 years ago[Ada] Forbids use of Compile_Time_(Error|Warning) as configuration pragma
Etienne Servais [Mon, 20 Sep 2021 09:15:36 +0000 (11:15 +0200)]
[Ada] Forbids use of Compile_Time_(Error|Warning) as configuration pragma

gcc/ada/

* sem_prag.adb (Analyze_Pragma): Forbid use of
Compile_Time_(Error|Warning) as configuration pragma.
* doc/gnat_ugn/the_gnat_compilation_model.rst:
Compile_Time_(Error|Warning) and Compiler_Unit(_Warning) are not
configuration pragmas and shall not be listed as such.  The
following pragmas are either obsolete or undocumented:
No_Run_Time, Propagate_Exceptions, Rational, Ravenscar,
Restricted_Run_Time, Short_Descriptors, Universal_Data.  Fix
some typos (notably on Restriction_Warnings).
* doc/gnat_rm/implementation_defined_pragmas.rst: Move
Rename_Pragma documentation to alphabetical order.
* gnat_rm.texi, gnat_ugn.texi: Regenerate.

2 years ago[Ada] Add sys/time.h #include for QNX
Corentin Gay [Tue, 7 Sep 2021 12:18:06 +0000 (14:18 +0200)]
[Ada] Add sys/time.h #include for QNX

gcc/ada/

* adaint.c (QNX): Add #include for sys/time.h.

2 years ago[Ada] Issue a proper error message when no format specifier found
Pascal Obry [Thu, 16 Sep 2021 17:10:39 +0000 (19:10 +0200)]
[Ada] Issue a proper error message when no format specifier found

gcc/ada/

* libgnat/g-forstr.adb (Next_Format): When there is no more
format specifier found issue a proper error message instead of
raising a contraint error.

2 years ago[Ada] Fix negative numbers formatted with leading zero
Pascal Obry [Thu, 16 Sep 2021 14:23:55 +0000 (16:23 +0200)]
[Ada] Fix negative numbers formatted with leading zero

gcc/ada/

* libgnat/g-forstr.adb (Get_Formatted): Fix computation of the
number of zero to use in the formatted string. This was a wrong
copy/paste.

2 years ago[Ada] Minor code clean-up
Pascal Obry [Thu, 16 Sep 2021 14:23:07 +0000 (16:23 +0200)]
[Ada] Minor code clean-up

gcc/ada/

* libgnat/g-forstr.adb (Get_Formatted): Minor code clean-up.

2 years ago[Ada] Add missing functions to Wide_Wide_Characters Handling
Etienne Servais [Fri, 17 Sep 2021 10:29:46 +0000 (12:29 +0200)]
[Ada] Add missing functions to Wide_Wide_Characters Handling

gcc/ada/

* libgnat/a-zchhan.ads, libgnat/a-zchhan.adb
(Character_Set_Version, Is_Basic, To_Basic): New.
* libgnat/a-zchuni.ads, libgnat/a-zchuni.adb (Is_Basic,
To_Basic): New.

2 years ago[Ada] Improve error message on array aggregates
Yannick Moy [Thu, 16 Sep 2021 14:51:15 +0000 (16:51 +0200)]
[Ada] Improve error message on array aggregates

gcc/ada/

* sem_aggr.adb (Resolve_Array_Aggregate): Improve error message.

2 years ago[Ada] Front-end support for Storage_Model feature
Gary Dismukes [Mon, 13 Sep 2021 21:40:34 +0000 (17:40 -0400)]
[Ada] Front-end support for Storage_Model feature

gcc/ada/

* aspects.ads (type Aspect_Id): Add
Aspect_Designated_Storage_Model and Aspect_Storage_Model_Type.
(Aspect_Argument): Add associations for the above new aspects.
(Is_Representation_Aspect): Likewise.
(Aspect_Names, Aspect_Delay): Likewise.
* exp_ch4.adb (Expand_N_Allocator): Call Find_Storage_Op rather
than Find_Prim_Op.
* exp_intr.adb (Expand_Unc_Deallocation): Likewise.
* exp_util.ads (Find_Storage_Op): New function that locates
either a primitive operation of a storage pool or an operation
of a storage-model type specified in its Storage_Model_Type
aspect.
* exp_util.adb (Find_Storage_Op): New function that calls either
Find_Prim_Op or Get_Storage_Model_Type_Entity to locate a
storage-related operation that is associated with a type.
* sem_ch13.adb (Analyze_Aspects_At_Freeze_Point): Analyzes,
resolves, and validates the arguments of aspect
Designated_Storage_Model_Type.
(Analyze_Aspect_Specifications): Sets delay-related flags on
storage-model aspects when Delay_Required. Checks that aspect
Designated_Storage_Model is only specified for an access type
and that aspect Storage_Model_Type is only specified on an
immutably limited type. Also records such aspects for their
associated types.
(Check_Aspect_At_Freeze_Point): Resolve each of the argument
associations given for a Storage_Model_Type aspect.
(Resolve_Storage_Model_Type_Argument): New procedure that
resolves an argument given in the association for a given entity
name associated with a type with aspect Storage_Model_Type,
ensuring that it has the proper kind or profile.
(Validate_Storage_Model_Type_Aspect): New procedure that checks
the legality and completeness of the entity associations given
in a Storage_Model_Type aspect.
* sem_util.ads (package Storage_Model_Support): New nested
package that encapsulates a set of convenient utility functions
for retrieving entities, etc. associated with
storage-model-related types and objects.
(Get_Storage_Model_Type_Entity): New function to return a
specified entity associated with a type that has aspect
Storage_Model_Type.
(Has_Designated_Storage_Model_Aspect): New function that returns
whether a type has aspect Designated_Storage_Model.
(Has_Storage_Model_Type_Aspect): New function that returns
whether a type has aspect Storage_Model_Type.
(Storage_Model_Object): New function that returns the object
Entity_Id associated with a type's Designated_Storage_Model
aspect.
(Storage_Model_Type): New function that returns the type
associated with a storage-model object (when the object's type
specifies Storage_Model_Type).
(Storage_Model_Address_Type): New function that returns the
Address_Type associated with a type that has aspect
Storage_Model_Type.
(Storage_Model_Null_Address): New function that returns the
Null_Address constant associated with a type that has aspect
Storage_Model_Type.
(Storage_Model_Allocate): New function that returns the Allocate
procedure associated with a type that has aspect
Storage_Model_Type.
(Storage_Model_Deallocate): New function that returns the
Deallocate procedure associated with a type that has aspect
Storage_Model_Type.
(Storage_Model_Copy_From): New function that returns the
Copy_From procedure associated with a type that has aspect
Storage_Model_Type.
(Storage_Model_Copy_To): New function that returns the Copy_To
procedure associated with a type that has aspect
Storage_Model_Type.
(Storage_Model_Storage_Size): New function that returns the
Storage_Size function associated with a type that has aspect
Storage_Model_Type.
* sem_util.adb (package Storage_Model_Support): Body of new
nested package that contains the implementations the utility
functions declared in the spec of this package.
* snames.ads-tmpl: Add new names Name_Designated_Storage_Pool,
Name_Storage_Model, Name_Storage_Model_Type, Name_Address_Type,
Name_Copy_From, Name_Copy_To, and Name_Null_Address for the new
aspects and associated aspect arguments.

2 years ago[Ada] Note that -gnatd_t is used in CCG
Richard Kenner [Tue, 14 Sep 2021 12:28:09 +0000 (08:28 -0400)]
[Ada] Note that -gnatd_t is used in CCG

gcc/ada/

* debug.adb: Add documentation for -gnatd_t.

2 years ago[Ada] Add case to consider ENODEV a "file not found error"
Corentin Gay [Thu, 9 Sep 2021 09:57:06 +0000 (11:57 +0200)]
[Ada] Add case to consider ENODEV a "file not found error"

gcc/ada/

* sysdep.c (__gnat_is_file_not_found_error): Add else if case.

2 years ago[Ada] Rewrite operator entity in derived class-wide expressions
Piotr Trojanek [Fri, 10 Sep 2021 20:29:27 +0000 (22:29 +0200)]
[Ada] Rewrite operator entity in derived class-wide expressions

gcc/ada/

* exp_util.adb (Build_Class_Wide_Expression): Replace entities
of both identifiers and operator symbols.

2 years ago[Ada] Propagate Ghost status from parent to derived subprograms
Piotr Trojanek [Fri, 10 Sep 2021 20:27:20 +0000 (22:27 +0200)]
[Ada] Propagate Ghost status from parent to derived subprograms

gcc/ada/

* sem_ch3.adb (Derive_Subprogram): Copy ghost status from parent
to derived subprogram.

2 years ago[Ada] Add Default_Initial_Condition to type Unbounded_String
Joffrey Huguet [Fri, 10 Sep 2021 13:10:33 +0000 (15:10 +0200)]
[Ada] Add Default_Initial_Condition to type Unbounded_String

gcc/ada/

* libgnat/a-strunb.ads, libgnat/a-strunb__shared.ads: Add
Default_Initial_Condition to Unbounded_String.

2 years ago[Ada] Disable contract cases on formal containers
Claire Dross [Fri, 10 Sep 2021 10:05:27 +0000 (12:05 +0200)]
[Ada] Disable contract cases on formal containers

gcc/ada/

* libgnat/a-cfdlli.ads: Use pragma Assertion_Policy to disable
contract cases at execution.
* libgnat/a-cfinve.ads: Idem.
* libgnat/a-cofove.ads: Idem.
* libgnat/a-cfhase.ads: Idem.
* libgnat/a-cfhama.ads: Idem.
* libgnat/a-cforse.ads: Idem.
* libgnat/a-cforma.ads: Idem.

2 years ago[Ada] Improve message on missing all/for in pre-Ada-2022 modes
Bob Duff [Thu, 9 Sep 2021 16:24:32 +0000 (12:24 -0400)]
[Ada] Improve message on missing all/for in pre-Ada-2022 modes

gcc/ada/

* par-ch4.adb (P_Iterated_Component_Association): Parse these
features the same way in all language versions.  Move the call
to Error_Msg_Ada_2022_Feature into semantic analysis.
* sem_aggr.adb (Resolve_Iterated_Component_Association,
Resolve_Iterated_Association): Move the call to
Error_Msg_Ada_2022_Feature here from par-ch4.adb.

2 years ago[Ada] Improve error message on missing all/for in quantified expression
Yannick Moy [Thu, 9 Sep 2021 04:29:43 +0000 (06:29 +0200)]
[Ada] Improve error message on missing all/for in quantified expression

gcc/ada/

* sem_res.adb (Resolve): Recognize specially that case.

2 years ago[Ada] Proof of Ada.Strings.Maps
Yannick Moy [Thu, 2 Sep 2021 21:29:38 +0000 (23:29 +0200)]
[Ada] Proof of Ada.Strings.Maps

gcc/ada/

* libgnat/a-strmap.adb: Add ghost code for proof.
(To_Range): This is the most involved proof, as it requires
creating the result of the call to To_Domain as a ghost
variable, and show the unicity of this result in order to prove
the postcondition.
* libgnat/a-strmap.ads: (SPARK_Proof_Sorted_Character_Sequence):
New ghost function.
(To_Domain): Add postcondition regarding sorting of result.
(To_Range): Fix postcondition that should compare Length instead
of Last for the results of To_Domain and To_Range, as the value
of Last for an empty result is not specified in the Ada RM.

2 years ago[Ada] Proof of Ada.Characters.Handling
Yannick Moy [Tue, 31 Aug 2021 08:21:42 +0000 (10:21 +0200)]
[Ada] Proof of Ada.Characters.Handling

gcc/ada/

* libgnat/a-chahan.adb: Add loop invariants as needed to prove
subprograms.  Also use extended return statements where
appropriate and not done already.  Mark data with
Relaxed_Initialization where needed for initialization by parts.
Convert regular functions to expression functions where needed
for proof.
* libgnat/a-chahan.ads: Add postconditions.
* libgnat/a-strmap.ads (Model): New ghost function to create a
publicly visible model of the private data Character_Mapping,
needed in order to prove subprograms in Ada.Characters.Handling.

2 years agoAdjust gfortran.dg/predict-2.f90
Richard Biener [Tue, 5 Oct 2021 06:35:17 +0000 (08:35 +0200)]
Adjust gfortran.dg/predict-2.f90

After teaching VN to handle internal functions we now optimize
the redundant inner loop preheader check of the testcase making
the dump scanning fail because there's nothing to predict left.
The following restores the inner preheader check by making it
not redundant.

2021-10-05  Richard Biener  <rguenther@suse.de>

* gfortran.dg/predict-2.f90: Adjust to avoid redundant
inner loop preheader checking code.

2 years agoDaily bump.
GCC Administrator [Tue, 5 Oct 2021 00:16:29 +0000 (00:16 +0000)]
Daily bump.

2 years agoc-family: Implement -Warray-compare [PR97573]
Marek Polacek [Wed, 29 Sep 2021 15:45:24 +0000 (11:45 -0400)]
c-family: Implement -Warray-compare [PR97573]

This patch addresses one of my leftovers from GCC 11.  C++20 introduced
[depr.array.comp]: "Equality and relational comparisons between two operands
of array type are deprecated." so this patch adds -Warray-compare.  Since the
code in question is dubious (the comparison doesn't actually compare the array
elements), I've added this warning for C too, and enabled it in all C++ modes.

PR c++/97573

gcc/c-family/ChangeLog:

* c-common.h (do_warn_array_compare): Declare.
* c-warn.c (do_warn_array_compare): New.
* c.opt (Warray-compare): New option.

gcc/c/ChangeLog:

* c-typeck.c (parser_build_binary_op): Call do_warn_array_compare.

gcc/cp/ChangeLog:

* typeck.c (cp_build_binary_op): Call do_warn_array_compare.

gcc/ChangeLog:

* doc/invoke.texi: Document -Warray-compare.

gcc/testsuite/ChangeLog:

* c-c++-common/Warray-compare-1.c: New test.
* c-c++-common/Warray-compare-2.c: New test.

2 years agoavoid hardreg autoinit
Richard Biener [Mon, 4 Oct 2021 12:24:07 +0000 (14:24 +0200)]
avoid hardreg autoinit

This avoids initializating "uninitialized" hardregs like SP.

2021-10-04  Richard Biener  <rguenther@suse.de>

* gimplify.c (is_var_need_auto_init): DECL_HARD_REGISTER
variables are not to be initialized.

* gcc.dg/auto-init-hardreg-1.c: New testcase.

2 years agod: gdc driver ignores -static-libstdc++ when automatically linking libstdc++ library
Iain Buclaw [Sun, 3 Oct 2021 14:02:24 +0000 (16:02 +0200)]
d: gdc driver ignores -static-libstdc++ when automatically linking libstdc++ library

Adds handling of `-static-libstc++' in the gdc driver, so that libstdc++
is appropriately linked if libstdc++ is either needed or seen on the
command-line.

PR d/102574

gcc/d/ChangeLog:

* d-spec.cc (lang_specific_driver): Link libstdc++ statically if
-static-libstdc++ was given on command-line.

2 years agod: Save target node before parsing optimize options in case it changes.
Iain Buclaw [Sun, 3 Oct 2021 13:21:05 +0000 (15:21 +0200)]
d: Save target node before parsing optimize options in case it changes.

Fixes an ICE seen on PowerPC targets with the attr_optimize*.d tests in
the gdc.dg testsuite.

gcc/d/ChangeLog:

* d-attribs.cc (d_handle_optimize_attribute): Save target node before
calling parse_optimize_options in case it changes.

2 years agomiddle-end/102285 - refine .DEFERRED_INIT expansion
Richard Biener [Mon, 4 Oct 2021 09:34:27 +0000 (11:34 +0200)]
middle-end/102285 - refine .DEFERRED_INIT expansion

This refines the way we figure whether we are facing a register
that cannot be initialized by emitting a memset away from inspecting
expanded RTL of the LHS to using the predicates expand_assignment
is using to detect decls or MEM_REFs with non-memory DECL_RTL.

2021-10-04  Richard Biener  <rguenther@suse.de>

* expr.h (non_mem_decl_p): Declare.
(mem_ref_refers_to_non_mem_p): Likewise.
* expr.c (non_mem_decl_p): Export.
(mem_ref_refers_to_non_mem_p): Likewise.
* internal-fn.c (expand_DEFERRED_INIT): Do not expand the LHS
but check the base with mem_ref_refers_to_non_mem_p
and non_mem_decl_p.

* c-c++-common/pr102285.c: New testcase.

2 years agotree-optimization/102570 - teach VN about internal functions
Richard Biener [Mon, 4 Oct 2021 08:57:45 +0000 (10:57 +0200)]
tree-optimization/102570 - teach VN about internal functions

We're now using internal functions for a lot of stuff but there's
still missing VN support out of laziness.  The following instantiates
support and adds testcases for FRE and PRE (hoisting).

2021-10-04  Richard Biener  <rguenther@suse.de>

PR tree-optimization/102570
* tree-ssa-sccvn.h (vn_reference_op_struct): Document
we are using clique for the internal function code.
* tree-ssa-sccvn.c (vn_reference_op_eq): Compare the
internal function code.
(print_vn_reference_ops): Print the internal function code.
(vn_reference_op_compute_hash): Hash it.
(copy_reference_ops_from_call): Record it.
(visit_stmt): Remove the restriction around internal function
calls.
(fully_constant_vn_reference_p): Use fold_const_call and handle
internal functions.
(vn_reference_eq): Compare call return types.
* tree-ssa-pre.c (create_expression_by_pieces): Handle
generating calls to internal functions.
(compute_avail): Remove the restriction around internal function
calls.

* gcc.dg/tree-ssa/ssa-fre-96.c: New testcase.
* gcc.dg/tree-ssa/ssa-pre-33.c: Likewise.

2 years agolibstdc++: Implement P1518R2 for container deduction guides
Jonathan Wakely [Mon, 4 Oct 2021 13:04:20 +0000 (14:04 +0100)]
libstdc++: Implement P1518R2 for container deduction guides

This implements the C++23 P1518R2 proposal "Stop overconstraining
allocators in container deduction guides" as a fix for C++17 and C++20
too.

The changes allow class template argument deduction to ignore the type
of a constructor argument that initializes an allocator_type parameter
if the type should be deducible only from the other arguments. So for
the constructor vector(const vector&, const allocator_type&) only the
first argument is used for deduction, allowing the second argument to be
anything that is implicitly convertible to argument_type. Previously
deduction would fail or an ill-formed type would be deduced if the
second argument wasn't of type allocator_type.

The unordered containers do not need changes, because their
allocator-extended constructors use the allocator_type alias, which
comes from the dependent base class so is already a non-deduced context.

libstdc++-v3/ChangeLog:

* include/bits/forward_list.h (forward_list): Use non-deduced
context for allocator parameter of allocator-extended copy and
move constructors.
* include/bits/stl_bvector.h (vector<bool>): Likewise.
* include/bits/stl_deque.h (deque): Likewise.
* include/bits/stl_list.h (list): Likewise.
* include/bits/stl_map.h (map): Likewise.
* include/bits/stl_multimap.h (multimap): Likewise.
* include/bits/stl_multiset.h (multiset): Likewise.
* include/bits/stl_set.h (set): Likewise.
* include/bits/stl_vector.h (vector): Likewise.
* include/bits/stl_queue.h (queue, priority_queue): Do not
constrain Allocator template parameter of deduction guides that
have a Container parameter.
* include/bits/stl_stack.h (stack): Likewise.
* include/debug/deque (__gnu_debug::deque): Use non-deduced
context for allocator parameter of allocator-extended copy and
move constructors.
* include/debug/list (__gnu_debug::list): Likewise.
* include/debug/map.h (__gnu_debug::map): Likewise.
* include/debug/multimap.h (__gnu_debug::multimap): Likewise.
* include/debug/multiset.h (__gnu_debug::multiset): Likewise.
* include/debug/set.h (__gnu_debug::set): Likewise.
* include/debug/vector (__gnu_debug::vector): Likewise.
* testsuite/23_containers/deque/cons/deduction.cc: Test class
template argument deduction with non-deduced allocator
arguments.
* testsuite/23_containers/forward_list/cons/deduction.cc:
Likewise.
* testsuite/23_containers/list/cons/deduction.cc: Likewise.
* testsuite/23_containers/map/cons/deduction.cc: Likewise.
* testsuite/23_containers/multimap/cons/deduction.cc: Likewise.
* testsuite/23_containers/multiset/cons/deduction.cc: Likewise.
* testsuite/23_containers/priority_queue/deduction.cc: Likewise.
* testsuite/23_containers/queue/deduction.cc: Likewise.
* testsuite/23_containers/set/cons/deduction.cc: Likewise.
* testsuite/23_containers/stack/deduction.cc: Likewise.
* testsuite/23_containers/unordered_map/cons/deduction.cc:
Likewise.
* testsuite/23_containers/unordered_multimap/cons/deduction.cc:
Likewise.
* testsuite/23_containers/unordered_multiset/cons/deduction.cc:
Likewise.
* testsuite/23_containers/unordered_set/cons/deduction.cc:
Likewise.
* testsuite/23_containers/vector/cons/deduction.cc: Likewise.

2 years agolibstdc++: Add missing noexcept to std::variant helper
Jonathan Wakely [Mon, 4 Oct 2021 09:21:58 +0000 (10:21 +0100)]
libstdc++: Add missing noexcept to std::variant helper

libstdc++-v3/ChangeLog:

* include/std/variant (__detail::__variant::__as): Add missing
noexcept to first overload.

2 years agolibstdc++: Disable std::string{,_view} construction from nullptr (P2166R1)
Jonathan Wakely [Fri, 1 Oct 2021 20:27:24 +0000 (21:27 +0100)]
libstdc++: Disable std::string{,_view} construction from nullptr (P2166R1)

Implement this C++23 feature. Because construction from a null pointer
is undefined, we can implement it for C++11 and up, turning undefined
behaviour into a compilation error.

libstdc++-v3/ChangeLog:

* include/bits/basic_string.h (basic_string(nullptr_t)): Define
as deleted.
(operator=(nullptr_t)): Likewise.
* include/bits/cow_string.h (basic_string(nullptr_t)): Likewise.
(operator=(nullptr_t)): Likewise.
* include/std/string_view (basic_string_view(nullptr_t)):
Likewise.
* testsuite/21_strings/basic_string/cons/char/nullptr.cc: New test.
* testsuite/21_strings/basic_string_view/cons/char/nonnull.cc:
Change dg-warning to dg-error.
* testsuite/21_strings/basic_string_view/cons/wchar_t/nonnull.cc:
Likewise.

2 years agoRemove static marker for range in alloca pass.
Aldy Hernandez [Sun, 3 Oct 2021 17:42:10 +0000 (19:42 +0200)]
Remove static marker for range in alloca pass.

The m_ranges[] field in int_range<N> are trees, so they live in GC
space.  Since invalid_range is static, it must be marked with GTY
magic.  However, calculating invalid_range is not particularly slow,
or on a critical path, so we can just put it in local scope and
recalculate every time.

Tested on x86-64 Linux.

gcc/ChangeLog:

PR tree-optimization/102560
* gimple-ssa-warn-alloca.c (alloca_call_type): Remove static
marker for invalid_range.

gcc/testsuite/ChangeLog:

* g++.dg/Walloca2.C: New test.

2 years agomiddle-end/102587 - avoid auto-init for VLA vectors
Richard Biener [Mon, 4 Oct 2021 08:02:39 +0000 (10:02 +0200)]
middle-end/102587 - avoid auto-init for VLA vectors

This avoids ICEing for VLA vector auto-init by not initializing.

2021-10-04  Richard Biener  <rguenther@suse.de>

PR middle-end/102587
* internal-fn.c (expand_DEFERRED_INIT): Guard register
initialization path an avoid initializing VLA registers
with it.

* gcc.target/aarch64/sve/pr102587-1.c: New testcase.
* gcc.target/aarch64/sve/pr102587-2.c: Likewise.

2 years ago[Ada] Incremental patch for restriction No_Dynamic_Accessibility_Checks
Justin Squirek [Tue, 29 Jun 2021 22:38:09 +0000 (18:38 -0400)]
[Ada] Incremental patch for restriction No_Dynamic_Accessibility_Checks

gcc/ada/

* doc/gnat_rm/standard_and_implementation_defined_restrictions.rst:
Add new entry for No_Dynamic_Accessibility_Checks documenting
behavior.
* gnat_rm.texi: Regenerate.
* exp_ch4.adb (Expand_N_In): Perform special expansion for
membership tests when No_Dynamic_Accessibility_Checks is active.
* sem_attr.adb (Resolve_Attribute): Skip static accessibility
check on actuals for anonymous access type formal parameters,
and add constants for readability.
* sem_util.adb (Function_Call_Or_Allocator_Level): Use the
innermost master for determining the level for function calls
within the alternative accessibility model.
(Type_Access_Level): Properly get the level for anonymous access
function result types.

2 years ago[Ada] Document the current behaviour of -gnateA switch
Piotr Trojanek [Mon, 6 Sep 2021 13:40:23 +0000 (15:40 +0200)]
[Ada] Document the current behaviour of -gnateA switch

gcc/ada/

* doc/gnat_ugn/building_executable_programs_with_gnat.rst
(gnateA): This switch no longer looks at the formal parameter
type being composite (as originally mandated by SPARK), but in
the parameter passing mechanism being not specified (as
currently mandated by Ada).
* gnat_ugn.texi: Regenerate.

2 years ago[Ada] Handle properly user_defined literals given by operators.
Ed Schonberg [Sun, 5 Sep 2021 15:22:52 +0000 (11:22 -0400)]
[Ada] Handle properly user_defined literals given by operators.

gcc/ada/

* sem_ch6.adb (Analyze_Operator_Symbol): Recognize strings as
operator names when they are the value of one of the Ada2022
aspects for User_Defined_Literals.
* sem_ch13.adb (Analyze_One_Aspect): Handle an aspect value
given by an Operator_Name.
(Validate_Literal_Aspect): Call Analyze_Operator_Symbol when
needed.

2 years ago[Ada] Fix indentation in generated AST construction functions
Piotr Trojanek [Mon, 6 Sep 2021 11:30:43 +0000 (13:30 +0200)]
[Ada] Fix indentation in generated AST construction functions

gcc/ada/

* gen_il-gen.adb (Put_Make_Spec): Don't emit the LF character in
the middle of a string, because the Put routine won't indent it
properly.

2 years ago[Ada] Implement CUDA_Device
Ghjuvan Lacambre [Tue, 17 Aug 2021 08:37:02 +0000 (10:37 +0200)]
[Ada] Implement CUDA_Device

gcc/ada/

* gnat_cuda.adb (Remove_CUDA_Device_Entities): New function.
(Expand_CUDA_Package): Call Remove_CUDA_Device_Entities.
* gnat_cuda.ads (Expand_CUDA_Package): Expand documentation.
* sem_prag.adb (Analyze_Pragma): Remove warning about
CUDA_Device not being implemented.

2 years ago[Ada] Completion of support for AI12-0409 (attribute Preelaborable_Initialization)
Gary Dismukes [Wed, 1 Sep 2021 23:58:14 +0000 (19:58 -0400)]
[Ada] Completion of support for AI12-0409 (attribute Preelaborable_Initialization)

gcc/ada/

* sem_ch7.adb (Analyze_Package_Specification): For types marked
as Must_Have_Preelab_Init, we now check for the presence of a
Preelaborable_Initialization aspect on the type, and pass the
aspect's expression (if any) on the call to
Has_Preelaborable_Initialization (or pass Empty if the type has
no such aspect or the aspect has no associated expression).
* sem_util.ads (Has_Preelaborable_Initialization): Change
Boolean formal parameter Formal_Types_Have_Preelab_Init to
instead be a formal of type Node_Id (named Preelab_Init_Expr),
to allow passing an expression that may be a conjunction of
Preelaborable_Initialization aspects. Revise spec comment
accordingly (and remove ??? comment).
* sem_util.adb (Type_Named_In_Preelab_Init_Expression): New
nested function with a result indicating whether a given type is
named as the prefix of a Preelaborable_Initialization attribute
in the expression of a corresponding P_I aspect.
(Has_Preelaborable_Initialization): For generic formal derived
and private types, test whether the type is named in the
expression Preelab_Init_Expr (by calling
Type_Named_In_Preelab_Init_Expression), and if so, treat the
formal type as having preelaborable initialization (returning
True).
* libgnat/a-cobove.ads (Vector): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as Element_Type'Preelaborable_Initialization.
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-cbdlli.ads (List): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as Element_Type'Preelaborable_Initialization.
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-cbhama.ads (Map): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as (Element_Type'Preelaborable_Initialization and
Key_Type'Preelaborable_Initialization).
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-cborma.ads (Map): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as (Element_Type'Preelaborable_Initialization and
Key_Type'Preelaborable_Initialization).
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-cbhase.ads (Set): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as Element_Type'Preelaborable_Initialization.
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-cborse.ads (Set): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as Element_Type'Preelaborable_Initialization.
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-cbmutr.ads (Tree): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as Element_Type'Preelaborable_Initialization.
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).
* libgnat/a-coboho.ads (Holder): Replace pragma
Preelaborable_Initialization with the aspect, specifying its
value as Element_Type'Preelaborable_Initialization.
(Cursor): Replace pragma P_I with the aspect (defaulting to
True).

2 years ago[Ada] Mark Ada.Text_IO in SPARK
Yannick Moy [Fri, 3 Sep 2021 07:19:49 +0000 (09:19 +0200)]
[Ada] Mark Ada.Text_IO in SPARK

gcc/ada/

* libgnat/a-textio.adb: Mark body out of SPARK.
* libgnat/a-textio.ads: Mark spec in SPARK and private part out
of SPARK.
* sem.adb (Semantics.Do_Analyze): Similar to ghost code
attributes, save and restore value of
Ignore_SPARK_Mode_Pragmas_In_Instance.

2 years ago[Ada] Minor comment fix in System.Regpat
Bob Duff [Fri, 3 Sep 2021 13:25:46 +0000 (09:25 -0400)]
[Ada] Minor comment fix in System.Regpat

gcc/ada/

* libgnat/s-regpat.ads: Change Data_First to Data'First. Change
"still" to "always".  Similar changes for Data_Last.

2 years ago[Ada] Refactor duplicate code for pretty-printing GNAT AST
Piotr Trojanek [Fri, 3 Sep 2021 07:46:33 +0000 (09:46 +0200)]
[Ada] Refactor duplicate code for pretty-printing GNAT AST

gcc/ada/

* sprint.adb (Sprint_Node_Actual): Refactor code for generic
package and subprogram declarations.

2 years ago[Ada] Remove repeated calls to Prefix in resolution of array accesses
Piotr Trojanek [Wed, 1 Sep 2021 10:55:13 +0000 (12:55 +0200)]
[Ada] Remove repeated calls to Prefix in resolution of array accesses

gcc/ada/

* sem_res.adb (Resolve_Indexed_Component, Resolve_Slice): Rename
the local constant Name to Pref; remove repeated calls to
Prefix.

2 years ago[Ada] Emit specific SCOs for decisions of quantified expressions
Matthieu Eyraud [Fri, 2 Jul 2021 12:37:55 +0000 (14:37 +0200)]
[Ada] Emit specific SCOs for decisions of quantified expressions

gcc/ada/

* scos.ads: Extend the documentation.
* par_sco.adb (Process_Decisions): Emit specific SCOs for
quantified expressions.

2 years ago[Ada] Fix comment about expansion of slices
Piotr Trojanek [Mon, 23 Aug 2021 11:34:22 +0000 (13:34 +0200)]
[Ada] Fix comment about expansion of slices

gcc/ada/

* checks.adb (Selected_Range_Checks): Fix style.
* exp_ch4.adb (Expand_N_Slice): Fix style and comment.
* sem_res.adb (Resolve_Indexed_Component): Fix style.

2 years ago[Ada] Add Ada RM description of Ada.Strings.Bounded as comments in the spec
Yannick Moy [Tue, 27 Jul 2021 14:19:05 +0000 (16:19 +0200)]
[Ada] Add Ada RM description of Ada.Strings.Bounded as comments in the spec

gcc/ada/

* libgnat/a-strbou.ads: Add comments.

2 years ago[Ada] Fix for a static Leading_Part attribute raising constraint error
Piotr Trojanek [Tue, 31 Aug 2021 17:13:29 +0000 (19:13 +0200)]
[Ada] Fix for a static Leading_Part attribute raising constraint error

gcc/ada/

* sem_attr.adb (Eval_Attribute): Evaluation of attribute
Leading_Part with illegal second parameter is now similar to
evaluation of Remainder with its second parameter being zero.

2 years ago[Ada] Fix resolution of Declare_Expressions involving transient scopes
Ed Schonberg [Mon, 30 Aug 2021 21:41:29 +0000 (17:41 -0400)]
[Ada] Fix resolution of Declare_Expressions involving transient scopes

gcc/ada/

* sem_res.adb (Resolve_Declare_Expression): Use tree traversals
to perform name capture of local entities in the expression of
the construct.
* exp_util.adb (Possible_Side_Effects_In_SPARK): Do not apply to
the prefix of an attribute reference Reduce when that prefix is
an aggregate, because it will be expanded into a loop, and has
no identifiable type.

2 years ago[Ada] Fix latent problem in Sem_Ch8.Build_Class_Wide_Wrapper
Javier Miranda [Mon, 30 Aug 2021 12:25:50 +0000 (08:25 -0400)]
[Ada] Fix latent problem in Sem_Ch8.Build_Class_Wide_Wrapper

gcc/ada/

* sem_ch8.adb (Build_Class_Wide_Wrapper): Fix handling of
class-wide subtypes; required to handle chains of
instantiations. Adding also code to identify these wrappers and
properly resolve instantiations where the wrapper and a tagged
type primitive are visible.
* einfo.ads (Is_Class_Wide_Wrapper): Adding documentation.
* gen_il-fields.ads (Opt_Field_Enum): Adding
Is_Class_Wide_Wrapper.
* gen_il-gen-gen_entities.adb (Root_Entity_Type): Adding
semantic flag Is_Class_Wide_Wrapper.

2 years ago[Ada] Declaration_Node for Itypes returns Empty or declaration
Bob Duff [Sun, 29 Aug 2021 15:25:08 +0000 (11:25 -0400)]
[Ada] Declaration_Node for Itypes returns Empty or declaration

gcc/ada/

* einfo.ads (Declaration_Node): Document that Declaration_Node
for Itypes.
* einfo-utils.adb (Declaration_Node): Make it return Empty for
Itypes, or a proper type or subtype declaration.
* gen_il-gen.adb: Minor comment improvement.

2 years ago[Ada] Fix handling of slices with subtype names
Piotr Trojanek [Fri, 27 Aug 2021 15:48:15 +0000 (17:48 +0200)]
[Ada] Fix handling of slices with subtype names

gcc/ada/

* sem_res.adb (Resolve_Slice): Fix application of range checks
to slice range given as a subtype name.

2 years ago[Ada] Fix missing check on slice with a subtype indication
Piotr Trojanek [Thu, 26 Aug 2021 15:35:27 +0000 (17:35 +0200)]
[Ada] Fix missing check on slice with a subtype indication

gcc/ada/

* sem_res.adb (Resolve_Slice): Handle range given as a subtype
indication.

2 years ago[Ada] Fix handling of 'Image acting as a prefix of a slice in CodePeer
Piotr Trojanek [Tue, 24 Aug 2021 21:58:40 +0000 (23:58 +0200)]
[Ada] Fix handling of 'Image acting as a prefix of a slice in CodePeer

gcc/ada/

* sem_res.adb (Resolve_Slice): Add custom handling of attribute
Image and similar in CodePeer mode. This complements the
existing custom handling of these attributes in
Expand_N_Attribute_Reference.

2 years ago[Ada] Spurious non-variable error on implicitly dereferenced in-mode formal
Justin Squirek [Mon, 19 Jul 2021 18:03:35 +0000 (14:03 -0400)]
[Ada] Spurious non-variable error on implicitly dereferenced in-mode formal

gcc/ada/

* sem_util.adb (Is_Variable): Add check for implicitly
dereferenced access types
(Is_Dependent_Component_Of_Mutable_Object): Set Prefix_Type when
not specified.

2 years ago[Ada] Adjust documentation of -fdump-ada-spec in GNAT UG
Eric Botcazou [Thu, 26 Aug 2021 13:42:05 +0000 (15:42 +0200)]
[Ada] Adjust documentation of -fdump-ada-spec in GNAT UG

gcc/ada/

* doc/gnat_ugn/the_gnat_compilation_model.rst (Binding generation):
Document specific behavior for /include/-ending paths and update.
* gnat_ugn.texi: Regenerate.

2 years ago[Ada] PR ada/102073
Arnaud Charlet [Thu, 26 Aug 2021 13:21:22 +0000 (09:21 -0400)]
[Ada] PR ada/102073

gcc/ada/

PR ada/102073
* socket.c (__gnat_gethostbyaddr, __gnat_inet_pton): Add missing
return statements.

2 years ago[Ada] Crash on allocator in alternative accessibility modes
Justin Squirek [Sat, 14 Aug 2021 11:32:17 +0000 (07:32 -0400)]
[Ada] Crash on allocator in alternative accessibility modes

gcc/ada/

* sem_util.adb (Function_Or_Allocator_Level): Properly handle
direct function calls in the default alternative accessibility
checking mode.

2 years ago[Ada] Entities in E_Loop scopes are not library-level entities
Javier Miranda [Thu, 26 Aug 2021 17:40:14 +0000 (13:40 -0400)]
[Ada] Entities in E_Loop scopes are not library-level entities

gcc/ada/

* sem_util.adb (Is_Library_Level_Entity): Return False for
entities defined in E_Loop scopes. This change is not required
by the frontend; it is required by tools that depend on the
frontend sources.
* einfo-utils.adb (Is_Dynamic_Scope): Code cleanup.

2 years ago[Ada] Spurious accessibility error on renamed expression
Justin Squirek [Wed, 18 Aug 2021 03:12:00 +0000 (23:12 -0400)]
[Ada] Spurious accessibility error on renamed expression

gcc/ada/

* sem_util.adb (Accessibility_Level): Add a case to handle
renamed subprograms in addition to renamed objects.

2 years ago[Ada] VxWorks inconsistent use of return type Fixup
Doug Rupp [Fri, 20 Aug 2021 15:26:58 +0000 (08:26 -0700)]
[Ada] VxWorks inconsistent use of return type Fixup

gcc/ada/

* libgnarl/s-osinte__vxworks.ads (tlsKeyCreate): Return int.
* libgnarl/s-tpopsp__vxworks-rtp.adb (ERROR): Declare from
System.VxWorks.Ext.ERROR.
(Initialize): Declare IERR. Assert it.
* libgnarl/s-tpopsp__vxworks.adb (ERROR): Declare from
System.VxWorks.Ext.ERROR.
(Is_Valid_Task): Declare IERR. Test return.
* libgnarl/s-vxwext__kernel.adb (semDelete): Return STATUS.

2 years ago[Ada] Emit debugging information for TSD object
Eric Botcazou [Mon, 23 Aug 2021 16:16:05 +0000 (18:16 +0200)]
[Ada] Emit debugging information for TSD object

gcc/ada/

* exp_disp.adb (Make_DT): Copy the Needs_Debug_Info flag from the
type onto the TSD object.

2 years ago[Ada] Fix compiler internal error
Steve Baird [Tue, 17 Aug 2021 17:01:11 +0000 (10:01 -0700)]
[Ada] Fix compiler internal error

gcc/ada/

* sem_util.adb (Is_Repeatedly_Evaluated): Handle the case of an
Old attribute reference that occurs within what was originally a
quantified expression but which expansion has transformed into
an Expression_With_Actions.

2 years ago[Ada] Improve checking for invalid index values when accessing array elements
Steve Baird [Mon, 16 Aug 2021 23:41:40 +0000 (16:41 -0700)]
[Ada] Improve checking for invalid index values when accessing array elements

gcc/ada/

* exp_ch4.adb (Expand_N_Indexed_Component): The two improvements
described above.

2 years agoFortran: Avoid var initialization in interfaces [PR54753]
Tobias Burnus [Mon, 4 Oct 2021 07:38:43 +0000 (09:38 +0200)]
Fortran: Avoid var initialization in interfaces [PR54753]

Intent(out) implies deallocation/default initialization; however, it is
pointless to do this for dummy-arguments symbols of procedures which are
inside an INTERFACE block. – This also fixes a bogus error for the attached
included testcase, but fixing the non-interface version still has to be done.

PR fortran/54753

gcc/fortran/ChangeLog:

* resolve.c (can_generate_init, resolve_fl_variable_derived,
resolve_symbol): Only do initialization with intent(out) if not
inside of an interface block.

2 years agoRemove dead code in config/rs6000/vxworks.h
Eric Botcazou [Mon, 4 Oct 2021 07:16:19 +0000 (09:16 +0200)]
Remove dead code in config/rs6000/vxworks.h

These lines were added last year:

/* Initialize library function table.  */
 #undef TARGET_INIT_LIBFUNCS
 #define TARGET_INIT_LIBFUNCS rs6000_vxworks_init_libfuncs

but TARGET_INIT_LIBFUNCS is #undef-ed in config/rs6000/rs6000.c and
rs6000_vxworks_init_libfuncs is nowhere defined in any case.

gcc/
* config/rs6000/vxworks.h (TARGET_INIT_LIBFUNCS): Delete.

2 years agoDaily bump.
GCC Administrator [Mon, 4 Oct 2021 00:16:22 +0000 (00:16 +0000)]
Daily bump.

2 years agoFix for powerpc64 long double complex divide failure
Patrick McGehearty [Sun, 3 Oct 2021 22:07:06 +0000 (18:07 -0400)]
Fix for powerpc64 long double complex divide failure

- - - -

New in version 6: Due to an oversight (i.e. coding error), version 5
changed the use of __LIBGCC_TF_EPSILON__ to __LIBGCC_DF_EPSILON__ but
not the other LIBGCC_TF values. For correct execution of the long
double test case it is necessary to also switch to using
__LIBGCC_DF_MIN__. For consistency we also switch to using
__LIBGCC_DF_MAX__. LDBL_MIN is 2**53 times as larger than DBL_MIN.
The larger value causes the code to switch the order of computation
when it is not optimal, resulting in failure for one of the values
in the cdivchk_ld.c test. Using DBL_MIN does not cause that failure..

There may be opportunity for further refinement of IBM128 format
Long Double complex divide, but that's beyond the scope of this
patch.

- - - -

This revision adds a test in libgcc/libgcc2.c for when
"__LIBGCC_TF_MANT_DIG__ == 106" to use __LIBGCC_DF_EPSILON__ instead
of __LIBGCC_TF_EPSILON__. That is specific to IBM 128-bit format long
doubles where EPSILON is very, very small and 1/EPSILON oveflows to
infinity. This change avoids the overflow without affecting any other
platform. Discussion in the patch is adjusted to reflect this
limitation.

It does not make any changes to .../rs6000/_divkc3.c, leaving it to
use __LIBGCC_KF__*. That means the upstream gcc will not build in
older IBM environments that do not recognize the KF floating point
mode properly. Environments that do not need IBM longdouble support
do build cleanly.

- - - -
This patch addresses the failure of powerpc64 long double complex divide
in native ibm long double format after the patch "Practical improvement
to libgcc complex divide".

The new code uses the following macros which are intended to be mapped
to appropriate values according to the underlying hardware representation.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101104

RBIG     a value near the maximum representation
RMIN     a value near the minimum representation
         (but not in the subnormal range)
RMIN2    a value moderately less than 1
RMINSCAL the inverse of RMIN2
RMAX2    RBIG * RMIN2  - a value to limit scaling to not overflow

When "long double" values were not using the IEEE 128-bit format but
the traditional IBM 128-bit, the previous code used the LDBL values
which caused overflow for RMINSCAL. The new code uses the DBL values.

RBIG  LDBL_MAX = 0x1.fffffffffffff800p+1022
      DBL_MAX  = 0x1.fffffffffffff000p+1022

RMIN  LDBL_MIN = 0x1.0000000000000000p-969
RMIN  DBL_MIN  = 0x1.0000000000000000p-1022

RMIN2 LDBL_EPSILON = 0x0.0000000000001000p-1022 = 0x1.0p-1074
RMIN2 DBL_EPSILON  = 0x1.0000000000000000p-52

\e[ORMINSCAL 1/LDBL_EPSILON = inf (1.0p+1074 does not fit in IBM 128-bit).
         1/DBL_EPSILON  = 0x1.0000000000000000p+52

RMAX2 = RBIG * RMIN2 = 0x1.fffffffffffff800p-52
        RBIG * RMIN2 = 0x1.fffffffffffff000p+970

The MAX and MIN values have only modest changes since the maximum and
minimum values are about the same as for double precision.  The
EPSILON field is considerably different. Due to how very small values
can be represented in the lower 64 bits of the IBM 128-bit floating
point, EPSILON is extremely small, so far beyond the desired value
that inversion of the value overflows and even without the overflow,
the RMAX2 is so small as to eliminate most usage of the test.

The change has been tested on gcc135.fsffrance.org and gains the
expected improvements in accuracy for long double complex divide.

libgcc/
PR target/101104
* libgcc2.c (RMIN2, RMINSCAL, RMAX2):
Use more correct values for native IBM 128-bit.

2 years agocoroutines: Fail with a sorry when presented with a VLA [PR 101765].
Iain Sandoe [Sat, 2 Oct 2021 15:15:38 +0000 (16:15 +0100)]
coroutines: Fail with a sorry when presented with a VLA [PR 101765].

We do not support this yet.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
PR c++/101765

gcc/cp/ChangeLog:

* coroutines.cc (register_local_var_uses): Emit a sorry if
we encounter a VLA in the coroutine local variables.

gcc/testsuite/ChangeLog:

* g++.dg/coroutines/pr101765.C: New test.

2 years agocoroutines: Await expressions are not allowed in handlers [PR 99710].
Iain Sandoe [Sat, 2 Oct 2021 13:43:39 +0000 (14:43 +0100)]
coroutines: Await expressions are not allowed in handlers [PR 99710].

C++20 [expr.await] / 2
An await-expression shall appear only in a potentially-evaluated expression
within the compound-statement of a function-body outside of a handler.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
PR c++/99710

gcc/cp/ChangeLog:

* coroutines.cc (await_statement_walker): Report an error if
an await expression is found in a handler body.

gcc/testsuite/ChangeLog:

* g++.dg/coroutines/pr99710.C: New test.

2 years agocoroutines: Fix ICE with an invalid await_suspend type [PR100673].
John Eivind Helset [Fri, 21 May 2021 23:53:22 +0000 (01:53 +0200)]
coroutines: Fix ICE with an invalid await_suspend type [PR100673].

The reported ICE occurs when an invalid (non-template) type is found
as the return for an await_suspend.

Fixed by amending build_co_await to ensure that await_suspend return-
type is a template-instantiation before checking to see if it is a
valid coroutine handle type.

Signed-off-by: John Eivind Helset <jehelset@gmail.com>
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
PR c++/100673

gcc/cp/ChangeLog:

* coroutines.cc (build_co_await): Guard against NULL
await_suspend types.

gcc/testsuite/ChangeLog:

* g++.dg/coroutines/pr100673.C: New test.

2 years agocoroutines: Ensure co_await_exprs have TREE_SIDE_EFFECTS set [PR 101133].
Iain Sandoe [Sat, 2 Oct 2021 12:40:09 +0000 (13:40 +0100)]
coroutines: Ensure co_await_exprs have TREE_SIDE_EFFECTS set [PR 101133].

Although it is not immediately evident from the symptoms, the PR is
caused by a variable having a DECL_INITIAL() containing a co_await.
This is not correct, since such expressions have side-effects.

We were marking the overall co_await expression correctly, but if a
consumer of that expression stripped out the underlying co_await_expr
then the latter would not be properly marked.

Fixed by marking both the underlying and any containing await expr
with TREE_SIDE_EFFECTS.  Also mark type-dependent co_await expressions.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
PR c++/101133

gcc/cp/ChangeLog:

* coroutines.cc (build_co_await): Mark co_await_expr trees
with TREE_SIDE_EFFECTS, also mark any containing expression.
(finish_co_await_expr): Mark type-dependent co_await_expr
trees with TREE_SIDE_EFFECTS.

gcc/testsuite/ChangeLog:

* g++.dg/coroutines/pr101133.C: New test.

2 years agocoroutines: Look through NOPs for awaiter variables [PR 99575].
Iain Sandoe [Sat, 2 Oct 2021 11:44:01 +0000 (12:44 +0100)]
coroutines: Look through NOPs for awaiter variables [PR 99575].

There was a missing STRIP_NOPS which meant that, in some cases,
an awaiter variable could be hidden by a view-convert-expr.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
PR c++/99575

gcc/cp/ChangeLog:

* coroutines.cc (build_co_await): Strip NOPs from
candidate awaiter expressions before testing to see
if they need a temporary.

gcc/testsuite/ChangeLog:

* g++.dg/coroutines/pr99575.C: New test.

2 years agooptions: check for CL_OPTIMIZATION only for cl_options.
Martin Liska [Sun, 3 Oct 2021 12:25:11 +0000 (14:25 +0200)]
options: check for CL_OPTIMIZATION only for cl_options.

gcc/ChangeLog:

* toplev.c (toplev::main): Check opt_index if it is a part
of cl_options.

2 years agoDaily bump.
GCC Administrator [Sun, 3 Oct 2021 00:16:17 +0000 (00:16 +0000)]
Daily bump.

2 years agolibstdc++: Fix typos in std::filesystem code
Jonathan Wakely [Sat, 2 Oct 2021 20:18:19 +0000 (21:18 +0100)]
libstdc++: Fix typos in std::filesystem code

There were a couple of typos in r12-4070 and r12-4071 which don't show
up when building for POSIX targets.

libstdc++-v3/ChangeLog:

* src/c++17/fs_ops.cc (create_directory): Fix typo in enum name.
* src/filesystem/ops-common.h (__last_system_error): Add
explicit cast to avoid narrowing conversion.
(do_space): Fix type in function name.

2 years ago[PR102563] Do not clobber range in operator_lshift::op1_range.
Aldy Hernandez [Sat, 2 Oct 2021 14:59:26 +0000 (16:59 +0200)]
[PR102563] Do not clobber range in operator_lshift::op1_range.

We're clobbering the final range before we're done calculating it.

Tested on x86-64 Linux.

gcc/ChangeLog:

PR tree-optimization/102563
* range-op.cc (operator_lshift::op1_range): Do not clobber
range.

gcc/testsuite/ChangeLog:

* gcc.dg/tree-ssa/pr102563.c: New test.

2 years agocontrib: filter out mmx.md file.
Martin Liska [Sat, 2 Oct 2021 11:30:28 +0000 (13:30 +0200)]
contrib: filter out mmx.md file.

contrib/ChangeLog:

* filter-clang-warnings.py: Filter out -Wtautological-compare
for the file.

2 years agoAdd libgomp.fortran/order-reproducible-*.f90
Tobias Burnus [Sat, 2 Oct 2021 09:29:35 +0000 (11:29 +0200)]
Add libgomp.fortran/order-reproducible-*.f90

libgomp/ChangeLog:

* testsuite/libgomp.fortran/order-reproducible-1.f90: New test
based on libgomp.c-c++-common/order-reproducible-1.c.
* testsuite/libgomp.fortran/order-reproducible-2.f90: Likewise.
* testsuite/libgomp.fortran/my-usleep.c: New test.

2 years agooptions: fix ASAN issue during saving of opt. options
Martin Liska [Sat, 2 Oct 2021 07:31:46 +0000 (09:31 +0200)]
options: fix ASAN issue during saving of opt. options

gcc/ChangeLog:

* toplev.c (toplev::main): save_decoded_options[0] is program
name and so it should be skipped.

2 years agoc-family: Fix bootstrap for targets defining TARGET_FORMAT_TYPES.
Iain Sandoe [Sat, 2 Oct 2021 08:19:24 +0000 (09:19 +0100)]
c-family: Fix bootstrap for targets defining TARGET_FORMAT_TYPES.

A recent improvement in Waddress causes a bootstrap failure on
targets that define TARGET_FORMAT_TYPES since it cannot be NULL
if defined to an address.

There is no default for this target macro, and it would seem no
purpose to defining it to NULL, so the warning appears reasonable.

Fixed by removing the pointless test.

Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
gcc/c-family/ChangeLog:

* c-format.c: Remove a test of TARGET_FORMAT_TYPES with
NULL, this is not needed.

2 years agoUse unsigned long long in asm-x86-linux-rdmsr.c
H.J. Lu [Sat, 2 Oct 2021 02:26:08 +0000 (19:26 -0700)]
Use unsigned long long in asm-x86-linux-rdmsr.c

Use unsigned long long for 64-bit integer since unsigned long is 32 bits
for x32.

* gcc.dg/analyzer/torture/asm-x86-linux-rdmsr.c (DECLARE_ARGS):
Use unsigned long long for x86-64.

2 years agoDaily bump.
GCC Administrator [Sat, 2 Oct 2021 00:16:31 +0000 (00:16 +0000)]
Daily bump.