Nico Weber [Thu, 2 Jan 2020 17:22:04 +0000 (12:22 -0500)]
[gn build] (manually) merge
24ab9b537e61b3 yet more, to fix redef warnings
Sid Manning [Thu, 2 Jan 2020 16:27:05 +0000 (10:27 -0600)]
Add TPREL relocation support to Hexagon
Differential Revision: https://reviews.llvm.org/D71069
James Y Knight [Sat, 21 Dec 2019 22:18:38 +0000 (17:18 -0500)]
update_test_checks: match CHECK-EMPTY lines for replacement.
In
a8a89c77ea3c16b45763fca6940bbfd3bef7884f, the script started adding
CHECK-EMPTY lines, but the regex for which lines to replace was not
updated.
James Henderson [Fri, 20 Dec 2019 13:51:18 +0000 (13:51 +0000)]
[test][ELF] Verify debug line corruption messages are printed once
LLD warns if it encounters malformed debug data when parsing line
information for an undefined reference. We only want to warn once.
This patch adds additional checking to make sure the warnings are
printed only once, both for variables within the same program and
variables in later line programs.
Reviewed by: grimar, MaskRay
Differential Revision: https://reviews.llvm.org/D71759
Kevin P. Neal [Mon, 23 Dec 2019 19:05:06 +0000 (14:05 -0500)]
[SystemZ] Use FNeg in s390x clang builtins
The s390x builtins are still using FSub instead of FNeg. Correct that.
Nico Weber [Thu, 2 Jan 2020 17:11:59 +0000 (12:11 -0500)]
fix doc grammar-o to cycle bots
James Henderson [Fri, 20 Dec 2019 12:32:43 +0000 (12:32 +0000)]
[test][llvm-dwarfdump][NFC] Remove unused check
Reviewed by: JDevlieghere
Differential Revision: https://reviews.llvm.org/D71756
Sam McCall [Thu, 2 Jan 2020 16:59:10 +0000 (17:59 +0100)]
[clangd] Reorder FindTarget.h - group targetDecl() stuff and findExplicitReferences(). NFC
James Henderson [Fri, 20 Dec 2019 11:30:37 +0000 (11:30 +0000)]
[test][llvm-dwarfdump][NFC] Improve test readability
This patch adds and improves comments in the debug_line_invalid.test and
its associated input file so that it is easier to follow. It uses '##'
to make comments stand out from lit and FileCheck commands.
It also reflows some commands so that the lines are not so long and are
easier to read and fixes some copy/paste errors.
Reviewed by: JDevlieghere
Differential Revision: https://reviews.llvm.org/D71752
Nico Weber [Thu, 2 Jan 2020 16:44:07 +0000 (11:44 -0500)]
[gn build] (manually) merge
24ab9b537e61b3 more
serge-sans-paille [Thu, 2 Jan 2020 16:16:48 +0000 (17:16 +0100)]
Add intrinsics_gen *dependency* on Bye example
serge-sans-paille [Thu, 2 Jan 2020 16:05:59 +0000 (17:05 +0100)]
Add intrinsics_gen dependency on Bye example
This fixes build error introduced by commit
24ab9b537e61b3fe5e6a1019492ff6530d82a3ee
Nico Weber [Thu, 2 Jan 2020 16:07:31 +0000 (11:07 -0500)]
Revert "[gn build] (manually) merge
68a235d07f9e70"
This reverts commit
6ff6d32ebfec3150aa462cd31042b5719edb84da,
because
68a235d07f9e70 was reverted in
e406cca5f9.
Nico Weber [Thu, 2 Jan 2020 16:06:09 +0000 (11:06 -0500)]
[gn build] (manually) merge
24ab9b537e61b3
James Henderson [Thu, 2 Jan 2020 15:35:22 +0000 (15:35 +0000)]
Revert "build: reduce CMake handling for zlib"
This reverts commit
68a235d07f9e7049c7eb0c8091f37e385327ac28.
This commit broke the clang-x64-windows-msvc build bot and a follow-up
commit did not fix it. Reverting to fix the bot.
James Henderson [Thu, 2 Jan 2020 15:34:40 +0000 (15:34 +0000)]
Revert "build: make `LLVM_ENABLE_ZLIB` a tri-bool for users"
This reverts commit
e6c7ed6d2164a0659fd9f6ee44f1375d301e3cad.
This commit was an attempt to fix the build bots, but it still left the
clang-x64-windows-msvc bot in a broken state.
Ulrich Weigand [Thu, 2 Jan 2020 15:54:49 +0000 (16:54 +0100)]
[FPEnv] Default NoFPExcept SDNodeFlag to false
The NoFPExcept bit in SDNodeFlags currently defaults to true, unlike all
other such flags. This is a problem, because it implies that all code that
transforms SDNodes without copying flags can introduce a correctness bug,
not just a missed optimization.
This patch changes the default to false. This makes it necessary to move
setting the (No)FPExcept flag for constrained intrinsics from the
visitConstrainedIntrinsic routine to the generic visit routine at the
place where the other flags are set, or else the intersectFlagsWith
call would erase the NoFPExcept flag again.
In order to avoid making non-strict FP code worse, whenever
SelectionDAGISel::SelectCodeCommon matches on a set of orignal nodes
none of which can raise FP exceptions, it will preserve this property
on all results nodes generated, by setting the NoFPExcept flag on
those result nodes that would otherwise be considered as raising
an FP exception.
To check whether or not an SD node should be considered as raising
an FP exception, the following logic applies:
- For machine nodes, check the mayRaiseFPException property of
the underlying MI instruction
- For regular nodes, check isStrictFPOpcode
- For target nodes, check a newly introduced isTargetStrictFPOpcode
The latter is implemented by reserving a range of target opcodes,
similarly to how memory opcodes are identified. (Note that there a
bit of a quirk in identifying target nodes that are both memory nodes
and strict FP nodes. To simplify the logic, right now all target memory
nodes are automatically also considered strict FP nodes -- this could
be fixed by adding one more range.)
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D71841
serge_sans_paille [Sat, 8 Jun 2019 15:37:47 +0000 (17:37 +0200)]
Generalize the pass registration mechanism used by Polly to any third-party tool
There's quite a lot of references to Polly in the LLVM CMake codebase. However
the registration pattern used by Polly could be useful to other external
projects: thanks to that mechanism it would be possible to develop LLVM
extension without touching the LLVM code base.
This patch has two effects:
1. Remove all code specific to Polly in the llvm/clang codebase, replaicing it
with a generic mechanism
2. Provide a generic mechanism to register compiler extensions.
A compiler extension is similar to a pass plugin, with the notable difference
that the compiler extension can be configured to be built dynamically (like
plugins) or statically (like regular passes).
As a result, people willing to add extra passes to clang/opt can do it using a
separate code repo, but still have their pass be linked in clang/opt as built-in
passes.
Differential Revision: https://reviews.llvm.org/D61446
Sam McCall [Mon, 16 Dec 2019 18:08:51 +0000 (19:08 +0100)]
Revert "Revert "[clangd] Implement "textDocument/documentLink" protocol support""
This reverts commit
079ef783dd5530b5f87beefe624b9179547ded7e.
The revert describes a test failure without details, after offline
discussion this in in a private/unsupported build system and doesn't
seem to reflect a real upstream bug.
Nicolas Vasilache [Thu, 2 Jan 2020 15:06:46 +0000 (10:06 -0500)]
[mlir][Linalg] NFC - Make consistent use of op.emitOpError
Summary: This is part of an ongoing cleanup and uniformization work.
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72084
Nicolas Vasilache [Thu, 2 Jan 2020 14:54:47 +0000 (09:54 -0500)]
[mlir][Linalg] NFC - Cleanup Linalg Declarative Transformations
Summary:
This is part of an ongoing cleanup and uniformization work.
This diff performs 3 types of cleanups:
1. Uniformize transformation names.
2. Replace all pattern operands that need not be captured by `$_`
3. Replace all usage of pattern captured op by the normalized `op` name (instead of positional parameters such as `$0`)
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72081
Alexey Bataev [Thu, 2 Jan 2020 14:26:32 +0000 (09:26 -0500)]
[OpenMP] Fix formatting of OpenMP error message, by Wang Tianqing.
Summary: `getListOfPossibleValues()` formatted incorrectly when there is only one value, emitting something like `expected 'conditional' or in OpenMP clause 'lastprivate'`.
Reviewers: jdoerfert, ABataev
Reviewed By: jdoerfert
Subscribers: guansong, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71884
Alex Richardson [Thu, 2 Jan 2020 14:53:33 +0000 (14:53 +0000)]
[llvm-ranlib] Relax D-flag.test to allow it to pass on Windows hosts
It appears that Windows hosts always report rwxrwxrwx even with the
chmod 644 invocation. As this test only cares about the timestamps
and not the permissions, use a regex wildcard instead.
Sanjay Patel [Thu, 2 Jan 2020 14:33:50 +0000 (09:33 -0500)]
[InstCombine] remove uses before deleting instructions (PR43723)
This is a less ambitious alternative to previous attempts to fix
this bug with:
rG56b2aee1875a
rGef02831f0a4e
rG56b2aee1875a
...because those all failed bot testing with use-after-free or
other problems.
The original crashing/assert problem is still showing up on
various fuzzers, so I've added a new minimal test based on
another one of those failures.
Instead of trying to manage and coordinate the logic in
isAllocSiteRemovable() with the deletion loops, just loosen
the existing code that handles casts and GEP by replacing
with undef to allow other opcodes. That means that no
instructions with uses should assert on deletion, and there
are hopefully no non-obvious sanitizer bugs induced.
Nicolas Vasilache [Thu, 2 Jan 2020 14:22:44 +0000 (09:22 -0500)]
[mlir][Linalg] NFC - Rename ViewTraits -> StructuredOpTraits
Summary: This is part of an ongoing cleanup and uniformization work.
Reviewers: ftynse
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72079
Nicolas Vasilache [Thu, 2 Jan 2020 14:14:23 +0000 (09:14 -0500)]
[mlir][Linalg] NFC - Rename LinalgGeneric -> GenericLinalg
Summary: This is part of an ongoing cleanup and uniformization work.
Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72078
Jay Foad [Thu, 2 Jan 2020 14:14:27 +0000 (14:14 +0000)]
Remove unneeded extra variable realArgIdx. NFC.
Dmitri Gribenko [Thu, 2 Jan 2020 14:18:35 +0000 (15:18 +0100)]
Make the llvm-ranlib/help-message.test test pass in unusual configurations
The version string can be customized by CMake options, so the 'LLVM
version' substring is not guaranteed to appear (see
VersionPrinter::print in llvm/lib/Support/CommandLine.cpp).
David Green [Thu, 2 Jan 2020 11:43:37 +0000 (11:43 +0000)]
[ARM] Update ifcvt test target triples and opcodes. NFC
Some of the instructions in these tests were technically invalid
combinations (using ARM opcodes in Thumb mode, for example). Update the
targets and the instructions used to be more correct.
Raphael Isemann [Thu, 2 Jan 2020 13:46:39 +0000 (14:46 +0100)]
[lldb] Fix crash in AccessDeclContextSanity when copying FunctionTemplateDecl inside a record.
Summary:
We currently don't set access specifiers for function template declarations. This seems to be fine
as long as the function template is not declared inside any record in which case Clang asserts
with the following once we try to query it's access:
```
Assertion failed: (Access != AS_none && "Access specifier is AS_none inside a record decl"), function AccessDeclContextSanity,
```
This patch just marks these function template declarations as public to make Clang happy.
Reviewers: shafik, teemperor
Reviewed By: teemperor
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71909
Alex Richardson [Thu, 2 Jan 2020 13:27:32 +0000 (14:27 +0100)]
Fix D-flag.test by running chmod before creating the archive
Not all systems create the .o file with mode 644 by default.
Adding an explicit chmod invocation should fix this test added in
535b3c6b2f1c81ed91942ebd9ea06a1022dc59a1
Qiu Chaofan [Thu, 2 Jan 2020 13:15:20 +0000 (21:15 +0800)]
[NFC] Add explicit instantiation to releaseNode
Resolve a build failure about undefined symbols introduced by f9f78cf.
Differential Revision: https://reviews.llvm.org/D72069
Andrzej Warzynski [Thu, 19 Dec 2019 20:37:57 +0000 (20:37 +0000)]
[AArch64][SVE] Gather loads: pass 32 bit unpacked offsets as nxv2i32
Summary:
Currently 32 bit unpacked offsets are passed as nxv2i64. However, as
pointed out in https://reviews.llvm.org/D71074, using nxv2i32 instead
would improve consistency with:
* how other arguments are treated
* how scatter stores are implemented
This patch makes sure that 32 bit unpacked offsets are passes as nxv2i32
instead of nxv2i64.
Reviewers: sdesmalen, efriedma
Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71724
Alex Richardson [Thu, 2 Jan 2020 12:44:02 +0000 (13:44 +0100)]
[llvm-ranlib] Handle -D and -U command line flag
I have been trying to build CheriBSD (a fork for FreeBSD for the CHERI
CPU) with LLVM binutils instead of the default elftoolchain utilities.
I noticed that building static archives was failing because ranlib is
invoked with the -D flag. This failed with llvm-ranlib since it parses
the -D flag as the archive path and reports an error that more than one
archive has been passed.
This fixes https://llvm.org/PR41707
Reviewed By: rupprecht
Differential Revision: https://reviews.llvm.org/D71554
Alexander Lanin [Thu, 2 Jan 2020 11:28:53 +0000 (19:28 +0800)]
[docs] Update path to clang-tools-extra
Summary:
> tools/clang/tools/extra
has become
>clang-tools-extra
which was not updated in all docs.
Reviewers: alexfh, aaron.ballman, ilya-biryukov, juliehockett
Reviewed By: aaron.ballman
Subscribers: Jim, cfe-commits
Tags: #clang-tools-extra, #clang
Differential Revision: https://reviews.llvm.org/D71982
Raphael Isemann [Thu, 2 Jan 2020 10:57:00 +0000 (11:57 +0100)]
[lldb][NFC] Remove unused variable in DWARFASTParserClang::ParseSingleMember
Raphael Isemann [Mon, 30 Dec 2019 20:20:01 +0000 (21:20 +0100)]
[lldb][NFC] Create type-safe function for creating a CompilerType from a QualType
LLDB frequently converts QualType to CompilerType. This is currently done like this:
result = CompilerType(this, qual_type_var.getAsOpaquePtr())
There are a few shortcomings in this current approach:
1. CompilerType's constructor takes a void* pointer so it isn't type safe.
2. We can't add any sanity checks to the CompilerType constructor (e.g. that the type
actually belongs to the passed ClangASTContext) without expanding the TypeSystem API.
3. The logic for converting QualType->CompilerType is spread out over all of LLDB so
changing it is difficult (e.g., what if we want to just pass the type ptr and not the
1type_ptr | qual_flags1 to CompilerType).
This patch adds a `ClangASTContext::GetType` function similar to the other GetTypeForDecl
functions that does this conversion in a type safe way.
It also adds a sanity check for Tag-based types that the type actually belongs to the
current ClangASTContext (Types don't seem to know their ASTContext, so we have to
workaround by looking at the decl for the underlying TagDecl. This doesn't cover all types
we construct but it's better than no sanity check).
Shengchen Kan [Thu, 2 Jan 2020 06:24:13 +0000 (14:24 +0800)]
[NFC] Make the type of X86AlignBranchBoundary compatible
Change the type of X86AlignBranchBoundary from cl::opt<uint64_t> to
cl::opt<unsigned> since the template class cl::opt is only instantiated with
type unsigned, int, std::string, char and bool.
Fangrui Song [Thu, 2 Jan 2020 06:14:33 +0000 (22:14 -0800)]
[XRay][test] Fix xray-empty-firstmbb.mir and delete incorrect xray-empty-function.mir
xray-empty-firstmbb.mir does not test the intended code path. Change
xray-instruction-threshold to 0 to exercise the code path.
Delete xray-empty-function.mir . Empty MachineFunction does not work.
Various passes (e.g. MachineDominatorTree) assume the presence of an
entry block.
Lei Zhang [Thu, 2 Jan 2020 03:42:39 +0000 (22:42 -0500)]
[mlir][spirv] NFC: Move shader ABI attributes to a new file
This allows us to include the definitions of these attributes in
other files without pulling in all dependencies for lowering.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D72054
Lei Zhang [Thu, 2 Jan 2020 03:39:28 +0000 (22:39 -0500)]
[mlir][spirv] Fix links in docs and update dialect docs
Summary:
This commit fixes links to code directories and uses doc links on
mlir.llvm.org where possible. The docs in TableGen dialect definition
is also updated to reflect recent developments.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D72051
Craig Topper [Thu, 2 Jan 2020 03:06:05 +0000 (19:06 -0800)]
[X86] Add x86_regcallcc calling convention to function declaration recently added in a test.
The callsite had the calling convention, but not the function itself.
Nico Weber [Thu, 2 Jan 2020 03:06:31 +0000 (22:06 -0500)]
[gn build] (manually) merge
68a235d07f9e70
Brian Gesiak [Thu, 2 Jan 2020 01:24:14 +0000 (20:24 -0500)]
[Coroutines] const-ify internal helpers (NFC)
Several helpers internal to llvm/Transforms/Coroutines do not use
'const' for parameters that are not modified. Add const where possible.
Craig Topper [Thu, 2 Jan 2020 02:14:13 +0000 (18:14 -0800)]
[X86] Add test cases for regcall function that takes a long double as a parameter, but does not return a long double.
I believe we are incorrectly doing some FP stack manipulations
after the call.
Craig Topper [Thu, 2 Jan 2020 01:30:05 +0000 (17:30 -0800)]
[RegisterClassInfo] Use SmallVector::assign instead of resize to make sure we erase previous contents from all entries of the vector.
resize only writes to elements that get added. Any elements that
already existed maintain their previous value. In this case we're
trying to erase cached information so we should use assign which
will write to every element.
Found while trying to add new tests to an existing X86 test and
noticed register allocation changing in other functions.
Brian Gesiak [Thu, 2 Jan 2020 01:07:34 +0000 (20:07 -0500)]
[Coroutines] Rename "legacy" passes (NFC)
A series of patches beginning with https://reviews.llvm.org/D71898
propose to add an implementation of the coroutine passes to the new pass
manager. As part of these changes, the coroutine passes that implement
the legacy pass manager interface are renamed, to `<PassName>Legacy`.
This mirrors similar changes that have been made to many other passes in
LLVM as they've been transitioned to support both old and new pass
managers.
This commit splits out the renaming portion of that patch and commits it
in advance as an NFC (no functional change intended) commit. It renames:
* `CoroEarly` => `CoroEarlyLegacy`
* `CoroSplit` => `CoroSplitLegacy`
* `CoroElide` => `CoroElideLegacy`
* `CoroCleanup` => `CoroCleanupLegacy`
Saleem Abdulrasool [Thu, 2 Jan 2020 00:57:00 +0000 (16:57 -0800)]
build: make `LLVM_ENABLE_ZLIB` a tri-bool for users
Treat the flag `LLVM_ENABLE_ZLIB` as a tri-bool, `FORCE_ON` being `ON`,
and `ON` being an auto-detect. This is needed as many of the builders
enable the flag without having zlib available.
Saleem Abdulrasool [Wed, 1 Jan 2020 23:01:04 +0000 (15:01 -0800)]
build: reduce CMake handling for zlib
Rather than handling zlib handling manually, use `find_package` from CMake
to find zlib properly. Use this to normalize the `LLVM_ENABLE_ZLIB`,
`HAVE_ZLIB`, `HAVE_ZLIB_H`. Furthermore, require zlib if `LLVM_ENABLE_ZLIB` is
set to `YES`, which requires the distributor to explicitly select whether
zlib is enabled or not. This simplifies the CMake handling and usage in
the rest of the tooling.
Fangrui Song [Wed, 1 Jan 2020 23:55:14 +0000 (15:55 -0800)]
[mlir] Fix -Wrange-loo-analysis warnings
for (const auto &x : llvm::zip(..., ...))
->
for (auto x : llvm::zip(..., ...))
The return type of zip() is a wrapper that wraps a tuple of references.
> warning: loop variable 'p' is always a copy because the range of type 'detail::zippy<detail::zip_shortest, ArrayRef<long> &, ArrayRef<long> &>' does not return a reference [-Wrange-loop-analysis]
Fangrui Song [Wed, 1 Jan 2020 23:28:48 +0000 (15:28 -0800)]
[lld] Fix -Wrange-loop-analysis warnings
One instance looks like a false positive:
lld/ELF/Relocations.cpp:1622:14: note: use reference type 'const std::pair<ThunkSection *, uint32_t> &' (aka 'cons
t pair<lld::elf::ThunkSection *, unsigned int> &') to prevent copying
for (const std::pair<ThunkSection *, uint32_t> ts : isd->thunkSections)
It is not changed in this commit.
Alexandre Ganea [Wed, 1 Jan 2020 22:23:06 +0000 (17:23 -0500)]
[polly][Support] Un-break polly tests
Previously, the polly unit tests were stuck in a infinite loop.
There was an edge case in StringRef::count() introduced by
9f6b13e5cce96066d7262d224c971d93c2724795, where an empty 'Str' would cause the function to never exit.
Also fixed usage in polly.
Alexandre Ganea [Wed, 1 Jan 2020 22:05:16 +0000 (17:05 -0500)]
[mlir] Fix compilation warnings
Fixes:
- (MSVC) F:\llvm-project\mlir\lib\Dialect\Linalg\Analysis\DependenceAnalysis.cpp(103): warning C4551: function call missing argument list
- (Clang) tools\mlir\lib\Dialect\SPIRV\SPIRVCanonicalization.inc(232,1): warning: unused function 'populateWithGenerated' [-Wunused-function]
Alexandre Ganea [Tue, 31 Dec 2019 19:04:29 +0000 (14:04 -0500)]
[mlir] Fix linking with LLD
The issue is that /WHOLEARCHIVE is interpreted differently in LLD, which needs the same exact path as the .lib; whereas link.exe can take the library name, withoutout a path or extension, if that was already supplied on the cmd-line. I'll write a follow-up patch to fix the issue in LLD.
Alexandre Ganea [Tue, 31 Dec 2019 19:00:31 +0000 (14:00 -0500)]
[mlir] Fix warnings when compiling with Clang 9.0
Fixes: warning: comparison of integers of different signs: 'const unsigned int' and '(anonymous namespace)::OperationPrinter::(anonymous enum at F:\llvm-project\mlir\lib\IR\AsmPrinter.cpp:1444:3)' [-Wsign-compare]
Saleem Abdulrasool [Wed, 1 Jan 2020 22:19:41 +0000 (14:19 -0800)]
tests: XFAIL/UNSUPPORTED tests on Windows
Now that we are building the python bindings on Windows once more, the
extended testsuite is running. Mark a few failing tests and skip a few
tests which hang. This should at least bring the bot back to green
without reverting the Python changes which are an improvement for the
build system and enable another ~35% of the test suite which was
previously disabled.
Nikita Popov [Wed, 1 Jan 2020 19:09:40 +0000 (20:09 +0100)]
[InstCombine] Preserve inbounds when merging with zero-index GEP (PR44423)
This addresses https://bugs.llvm.org/show_bug.cgi?id=44423.
If one of the GEPs is inbounds and the other is zero-index,
we can also preserve inbounds.
Differential Revision: https://reviews.llvm.org/D72060
Raphael Isemann [Wed, 1 Jan 2020 21:42:25 +0000 (22:42 +0100)]
[lldb][NFC] Simplify CompilerType constructors/destructors and fix unused variable warning
CompilerType has no virtual functions and no statements in its constructors,
so we can simplify this code. This also allows Clang to emit unused variable warnings
for CompilerType, so I also removed one unused variable that otherwise causes -Werror
builds to fail.
Mark de Wever [Wed, 1 Jan 2020 21:19:18 +0000 (22:19 +0100)]
Revert "Adds -Wrange-loop-analysis to -Wall"
The sanitizer-x86_64-linux buildbot failed to build lld with -Werror.
This reverts commit
d8117542ac57f6051674ca70ea14c0e0d7d9b046.
Nikita Popov [Wed, 1 Jan 2020 19:09:40 +0000 (20:09 +0100)]
[InstCombine] Fix incorrect inbounds on GEP of GEP (PR44425)
This fixes https://bugs.llvm.org/show_bug.cgi?id=44425. We need to
drop inbounds if one of the GEPs is not inbounds. This was already
done when creating a new GEP, but not when modifying in place.
Differential Revision: https://reviews.llvm.org/D72059
Lorenzo Casalino [Wed, 1 Jan 2020 19:53:16 +0000 (19:53 +0000)]
[MachineScheduler] improve reuse of 'releaseNode'method
The 'SchedBoundary::releaseNode' is merely invoked for releasing the Top/Bottom root nodes.
However, 'SchedBoundary::releasePending' uses its same logic to check if the Pending queue
has any releasable SUnit.
It is possible to slightly modify the body of the two, allowing re-use of the former ('releaseNode')
in the latter.
Patch by Lorenzo Casalino <lorenzo.casalino93@gmail.com>
Reviewers: MatzeB, fhahn, atrick
Reviewed By: fhahn
Differential Revision: https://reviews.llvm.org/D65506
Nikita Popov [Wed, 1 Jan 2020 19:27:20 +0000 (20:27 +0100)]
[InstCombine] Add tests for PR44423 and PR44425; NFC
Nikita Popov [Wed, 1 Jan 2020 19:25:13 +0000 (20:25 +0100)]
[InstCombine] Regenerate test checks; NFC
Nikita Popov [Wed, 1 Jan 2020 10:15:13 +0000 (11:15 +0100)]
[InstCombine] Add tests for sub nuw of geps; NFC
Tests for PR44419.
Craig Topper [Wed, 1 Jan 2020 18:29:09 +0000 (10:29 -0800)]
[X86] Call SimplifyMultipleUseDemandedBits from combineVSelectToBLENDV if the condition is used by something other than select conditions.
We might be able to bypass some nodes on the condition path.
Differential Revision: https://reviews.llvm.org/D71984
Mark de Wever [Wed, 1 Jan 2020 16:23:18 +0000 (17:23 +0100)]
Adds -Wrange-loop-analysis to -Wall
This makes the range loop warnings part of -Wall.
Fixes PR32823: Warn about accidental coping of data in range based for
Differential Revision: https://reviews.llvm.org/D68912
Mark de Wever [Wed, 1 Jan 2020 16:23:20 +0000 (17:23 +0100)]
Improve Wrange-loop-analyses for rvalue reference
The Wrange-loop-analyses warns if a copy is made. Suppress this warning when
a temporary is bound to a rvalue reference.
While fixing this issue also found a copy-paste error in test6, which is also
fixed.
Differential Revision: https://reviews.llvm.org/D71806
Mark de Wever [Wed, 1 Jan 2020 16:23:19 +0000 (17:23 +0100)]
Adds fixit hints to the -Wrange-loop-analysis
Differential Revision: https://reviews.llvm.org/D68913
Mark de Wever [Wed, 1 Jan 2020 16:23:21 +0000 (17:23 +0100)]
[NFC] Fixes -Wrange-loop-analysis warnings
This avoids new warnings due to D68912 adds -Wrange-loop-analysis to -Wall.
Differential Revision: https://reviews.llvm.org/D71857
Raphael Isemann [Wed, 1 Jan 2020 17:47:44 +0000 (18:47 +0100)]
[lldb][NFC] Make some checks more readable in Variable::PrivateAutoComplete
David Green [Mon, 30 Dec 2019 13:01:09 +0000 (13:01 +0000)]
[ARM] Add +mve feature to mve tests. NFC
Sylvestre Ledru [Wed, 1 Jan 2020 11:55:59 +0000 (12:55 +0100)]
clang-tidy doc: Remove severities as they don't make consensus
Reviewers: jdoerfert, aaron.ballman
Reviewed By: aaron.ballman
Subscribers: whisperity, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72049
Liu, Chen3 [Tue, 31 Dec 2019 03:38:17 +0000 (11:38 +0800)]
add strict float for round operation
Differential Revision: https://reviews.llvm.org/D72026
Fangrui Song [Wed, 1 Jan 2020 08:15:28 +0000 (00:15 -0800)]
[MC][TargetMachine] Delete MCTargetOptions::MCPIECopyRelocations
clang/lib/CodeGen/CodeGenModule performs the -mpie-copy-relocations
check and sets dso_local on applicable global variables. We don't need
to duplicate the work in TargetMachine shouldAssumeDSOLocal.
Verified that -mpie-copy-relocations can still emit PC relative
relocations for external variable accesses.
clang -target x86_64 -fpie -mpie-copy-relocations -c => R_X86_64_PC32
clang -target aarch64 -fpie -mpie-copy-relocations -c => R_AARCH64_ADR_PREL_PG_HI21+R_AARCH64_LDST64_ABS_LO12_NC
Fangrui Song [Tue, 31 Dec 2019 23:00:59 +0000 (15:00 -0800)]
[ELF][RISCV][test] Test absolute/PC-relative/branch relocations to undefined weak symbols
Hideto Ueno [Wed, 1 Jan 2020 06:25:19 +0000 (15:25 +0900)]
[Attributor] AAValueConstantRange: Value range analysis using constant range
This patch introduces `AAValueConstantRange`, which answers a possible range for integer value in a specific program point.
One of the motivations is propagating existing `range` metadata. (I think we need to change the situation that `range` metadata cannot be put to Argument).
The state is a tuple of `ConstantRange` and it is initialized to (known, assumed) = ([-∞, +∞], empty).
Currently, AAValueConstantRange is created when AAValueSimplify cannot
simplify the value.
Supported
- BinaryOperator(add, sub, ...)
- CmpInst(icmp eq, ...)
- !range metadata
`AAValueConstantRange` is not intended to extend to polyhedral range value analysis.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D71620
Craig Topper [Wed, 1 Jan 2020 05:40:58 +0000 (21:40 -0800)]
[X86] Fix typo in getCMovOpcode.
The 64-bit HasMemoryOperand line was using CMOV32rm instead of
CMOV64rm. Not sure how to test this. We have no test coverage
that passes true for HasMemoryOperand.
Craig Topper [Wed, 1 Jan 2020 04:29:41 +0000 (20:29 -0800)]
[X86] Add X87 FCMOV support to X86FlagsCopyLowering.
Fixes PR44396
Matt Arsenault [Mon, 30 Dec 2019 19:46:24 +0000 (14:46 -0500)]
DAG: Stop trying to fold FP -(x-y) -> y-x in getNode with nsz
This was increasing the number of instructions when fsub was legalized
on AMDGPU with no signed zeros enabled. This fold should be guarded by
hasOneUse, and I don't think getNode should be doing that. The same
fold is already done as a regular combine through isNegatibleForFree.
This does require duplicating, even though isNegatibleForFree does
this combine already (and properly checks hasOneUse) to avoid one PPC
regression. In the regression, the outer fneg has nsz but the fsub
operand does not. isNegatibleForFree only sees the operand, and
doesn't see it's used from a nsz context. A nsz parameter needs to be
added and threaded through isNegatibleForFree to avoid this.
Fangrui Song [Tue, 31 Dec 2019 23:06:31 +0000 (15:06 -0800)]
[ELF][RISCV] Improve error message for unknown relocations
Like rLLD354040.
Craig Topper [Tue, 31 Dec 2019 23:57:17 +0000 (15:57 -0800)]
[X86] Constant fold KSHIFT of an all zeros vector to just an all zeros vector.
Craig Topper [Tue, 31 Dec 2019 23:06:47 +0000 (15:06 -0800)]
[X86][InstCombine] Add constant folding and simplification support for pdep and pext
The instructions use a mask to either pack disjoint bits together(pext) or spread bits to disjoint locations(pdep). If the mask is all 0s then no bits are extracted or deposited. If the mask is all ones, then the source value is written to the result since no compression or expansion happens. Otherwise if both the source and mask are constant we can walk the bits in the source/mask and calculate the result.
There other crazier things we could do like computeKnownBits or turning pext into shift/and if only a single contiguous range of bits is extracted.
Fixes PR44389
Differential Revision: https://reviews.llvm.org/D71952
Craig Topper [Tue, 31 Dec 2019 23:05:21 +0000 (15:05 -0800)]
[X86] Use carry flag from add for (seteq (add X, -1), -1).
If we just subtracted 1 and are checking if the result is -1. We can use the carry flag from the ADD instead of an explicit CMP. I'm using the same checks for the add users as EmitTest.
Fixes one case from PR44412
Differential Revision: https://reviews.llvm.org/D72019
Craig Topper [Tue, 31 Dec 2019 22:04:09 +0000 (14:04 -0800)]
[LegalizeVectorOps][AArch64] Stop asking for v4f16 fp_round and fp_extend to be promoted.
These operations are needed as building blocks for promoting so they
can't be promoted themselves.
This appeared to work because the fp_extend query type for operation
actions is the result type, not the input type so it never triggered
in the legalizer.
For fp_round, the vector op legalizer just ended up creating a
nop fp_extend that was elided by getNode, followed by a nop
fp_round that was also elided by getNode. This was followed by
a final fp_round from v4f32 back to vf416 which was CSEd to the
original node. Then legalize vector ops just believed that node
legalized to itself. LegalizeDAG took another crack at promoting
it, but didn't have a handler so just skipped it with a debug
message saying it wasn't promoted.
This patch just removes the operation actions to avoid this
non-sense. Found while trying to refactor LegalizeVectorOps to
handle multiple result nodes better.
Matt Arsenault [Tue, 31 Dec 2019 18:51:52 +0000 (13:51 -0500)]
AMDGPU: Precommit test showing extra instructions are introduced
Martin Storsjö [Tue, 31 Dec 2019 19:38:43 +0000 (21:38 +0200)]
Revert "[Diagnostic] Add ftabstop to -Wmisleading-indentation"
This reverts commit
b47b35ff51b355a446483777155290541ab64fae.
This caused failed asserts (Assertion `FIDAndOffset.second >
ColNo && "Column number smaller than file offset?"' failed.)
on a source file with a single line containing
"int main (void) { for( int i = 0; i < 9; i++ ); return 0; }".
Michael Liao [Wed, 25 Dec 2019 05:47:18 +0000 (00:47 -0500)]
[amdgpu] Fix scoreboard updating on `s_waitcnt_vscnt`.
Summary: - Other counters are accidentally cleared.
Subscribers: arsenm, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71866
Alexey Bataev [Tue, 31 Dec 2019 17:41:57 +0000 (12:41 -0500)]
[OPENMP]Emit artificial threprivate vars as threadlocal, if possible.
It may improve performance for declare reduction constructs.
Jacques Pienaar [Tue, 31 Dec 2019 18:56:24 +0000 (10:56 -0800)]
[mlir][docs] Remove redundant path prefix
./ is not needed.
Craig Topper [Tue, 31 Dec 2019 18:57:58 +0000 (10:57 -0800)]
[X86] Add test case for opposite branch condition for PR44412. NFC
Craig Topper [Tue, 31 Dec 2019 18:33:30 +0000 (10:33 -0800)]
[CodeGen] Emit conj/conjf/confjl libcalls as fneg instructions if possible.
We already recognize the __builtin versions of these, might as well
recognize the libcall version.
Differential Revision: https://reviews.llvm.org/D72028
Jacques Pienaar [Tue, 31 Dec 2019 17:52:19 +0000 (09:52 -0800)]
[mlir] Make code blocks more consistent
Use the same form specification for the same type of code.
Sanjay Patel [Tue, 31 Dec 2019 17:29:53 +0000 (12:29 -0500)]
[InstCombine] fold zext of masked bit set/clear
This does not solve PR17101, but it is one of the
underlying diffs noted here:
https://bugs.llvm.org/show_bug.cgi?id=17101#c8
We could ease the one-use checks for the 'clear'
(no 'not' op) half of the transform, but I do not
know if that asymmetry would make things better
or worse.
Proofs:
https://rise4fun.com/Alive/uVB
Name: masked bit set
%sh1 = shl i32 1, %y
%and = and i32 %sh1, %x
%cmp = icmp ne i32 %and, 0
%r = zext i1 %cmp to i32
=>
%s = lshr i32 %x, %y
%r = and i32 %s, 1
Name: masked bit clear
%sh1 = shl i32 1, %y
%and = and i32 %sh1, %x
%cmp = icmp eq i32 %and, 0
%r = zext i1 %cmp to i32
=>
%xn = xor i32 %x, -1
%s = lshr i32 %xn, %y
%r = and i32 %s, 1
Sanjay Patel [Tue, 31 Dec 2019 17:00:07 +0000 (12:00 -0500)]
[InstCombine] add/adjust tests for masked bit; NFC
Stephen Kelly [Sun, 29 Dec 2019 19:21:57 +0000 (19:21 +0000)]
Implement additional traverse() overloads
Summary:
These overloads make it possible to wrap unless(), anyOf(), has() etc
with the traverse matcher.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71977
Stephen Kelly [Sun, 29 Dec 2019 19:19:55 +0000 (19:19 +0000)]
Unnest struct in Matcher implementation
This allows implementation of the traverse() matcher to surround
matchers like unless().
Stephen Kelly [Sun, 29 Dec 2019 19:19:35 +0000 (19:19 +0000)]
Match code following lambdas when ignoring invisible nodes
Reviewers: aaron.ballman
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71976
Johannes Doerfert [Tue, 31 Dec 2019 16:55:07 +0000 (10:55 -0600)]
[Attributor][Fix] Avoid leaking memory after D68765
Nikita Popov [Tue, 31 Dec 2019 16:42:38 +0000 (17:42 +0100)]
Revert "[InstCombine] Fix infinite loop due to bitcast <-> phi transforms"
This reverts commit
27a0795943fee0f30b995fe5165428afc2dfd402.
Seems to break test-suite.
Jinsong Ji [Tue, 31 Dec 2019 16:24:35 +0000 (16:24 +0000)]
[PowerPC][NFC] Fix clang-tidy warning
Reported by
https://results.llvm-merge-guard.org/amd64_debian_testing_clang8-726/clang-tidy.txt
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11672:10:
warning: invalid case style for variable 'isEQ'
[readability-identifier-naming]
bool isEQ = (MI.getOpcode() == PPC::ANDI_rec_1_EQ_BIT ||
^~~~
IsEq
/mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/lib/Target/PowerPC/PPCISelLowering.cpp:11679:14:
warning: invalid case style for variable 'dl'
[readability-identifier-naming]
DebugLoc dl = MI.getDebugLoc();
^~
Dl