platform/upstream/nodejs.git
9 years agotest: fix parallel/test-tls-getcipher
Roman Reiss [Sun, 15 Feb 2015 17:35:14 +0000 (18:35 +0100)]
test: fix parallel/test-tls-getcipher

The test blindly assumes that the default cipher suite supports RC4
ciphers. This corrects the case where RC4 might not be available in the
default ciphers by setting the client to use the same suite as the
server.

PR-URL: https://github.com/iojs/io.js/pull/853
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agobenchmark: add a few querystring benchmarks
Brian White [Sun, 15 Feb 2015 04:26:50 +0000 (23:26 -0500)]
benchmark: add a few querystring benchmarks

PR-URL: https://github.com/iojs/io.js/pull/847
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
9 years agotest: verify fields in spawn{Sync} errors
cjihrig [Fri, 13 Feb 2015 21:39:24 +0000 (16:39 -0500)]
test: verify fields in spawn{Sync} errors

This commit validates the properties of ENOENT error objects
returned by spawn() and spawnSync().

PR-URL: https://github.com/iojs/io.js/pull/838
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agodoc: correct `it's` to `its` in process
Charmander [Fri, 13 Feb 2015 21:25:29 +0000 (13:25 -0800)]
doc: correct `it's` to `its` in process

"This event is emitted when io.js empties its event loop..."

PR-URL: https://github.com/iojs/io.js/pull/837
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodoc: add geek as collaborator
Wyatt Preul [Fri, 13 Feb 2015 18:49:30 +0000 (12:49 -0600)]
doc: add geek as collaborator
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #835

9 years agourl: reslove urls with . and ..
Amir Saboury [Sat, 10 Jan 2015 03:01:32 +0000 (22:01 -0500)]
url: reslove urls with . and ..

'.' and '..' are directory specs and resolving urls with or
without the hostname with '.' and '..' should add a trailing
slash to the end of the url.

Fixes: https://github.com/joyent/node/issues/8992
PR-URL: https://github.com/iojs/io.js/pull/278
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agonet: remove use of arguments in Server constructor
cjihrig [Wed, 24 Sep 2014 03:08:35 +0000 (23:08 -0400)]
net: remove use of arguments in Server constructor

The current implementation uses the arguments object in the Server()
constructor. Since both arguments to Server() are optional, there was a
high likelihood of accessing a non-existent element in arguments, which
carries a performance overhead. This commit replaces the arguments
object with named arguments.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Conflicts:
lib/net.js

9 years agodoc: grammar fix in smalloc
Debjeet Biswas [Sun, 8 Feb 2015 22:45:03 +0000 (04:15 +0530)]
doc: grammar fix in smalloc

PR-URL: https://github.com/joyent/node/pull/9164
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
9 years agotest: Timeout#unref() does not return instance
Jan Schär [Mon, 9 Feb 2015 15:51:12 +0000 (16:51 +0100)]
test: Timeout#unref() does not return instance

Timeout#unref() call returns undefined, not this. The test already
worked before, because the interval was still unref'd, and the test also
succeeds without clearing the interval.

PR-URL: https://github.com/joyent/node/pull/9171
Reviewed-by: Colin Ihrig <cjihrig@gmail.com>
Reviewed-by: Timothy J Fontaine <tjfontaine@gmail.com>
Conflicts:
test/simple/test-timers-unref.js

9 years agodoc: fix code syntax
Dan Dascalescu [Thu, 12 Feb 2015 07:25:01 +0000 (23:25 -0800)]
doc: fix code syntax

Add a ';' to the end of a function call in documentation.

PR-URL: https://github.com/joyent/node/pull/9198
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agomodule: replace NativeModule.require
Herbert Vojčík [Thu, 12 Feb 2015 13:50:47 +0000 (14:50 +0100)]
module: replace NativeModule.require

The NativeModule system passes NativeModule.require transparently and so
is unnecessary to call explicitly.

The only one which should have the prefix is the in line 295, where
actually implements a big fs-based module system and actually requires a
native module. That is left unchanged.

PR-URL: https://github.com/joyent/node/pull/9201
Ref: https://github.com/joyent/node/issues/2009
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Conflicts:
lib/module.js

9 years agodoc: use correct signature for assert()
Andrei Sedoi [Fri, 9 Jan 2015 17:55:32 +0000 (19:55 +0200)]
doc: use correct signature for assert()

The message argument is optional for both assert() and
assert.ok(). This commit makes message optional for assert().

PR-URL: https://github.com/joyent/node/pull/9003
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agonet: throw on invalid socket timeouts
cjihrig [Tue, 16 Dec 2014 22:17:28 +0000 (17:17 -0500)]
net: throw on invalid socket timeouts

This commit restricts socket timeouts non-negative, finite
numbers. Any other value throws a TypeError or RangeError.
This prevents subtle bugs that can happen due to type
coercion.

Fixes: https://github.com/joyent/node/issues/8618
PR-URL: https://github.com/joyent/node/pull/8884
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Conflicts:
lib/timers.js
test/simple/test-net-settimeout.js
test/simple/test-net-socket-timeout.js

9 years agodoc: fix sentence grammar timers.markdown
Omer Wazir [Thu, 12 Feb 2015 06:13:54 +0000 (23:13 -0700)]
doc: fix sentence grammar timers.markdown

Just added ', it' because the phrasing did not seem correct.

PR-URL: https://github.com/iojs/io.js/pull/815
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agotest: distribute crypto tests into separate files
Brendan Ashworth [Thu, 12 Feb 2015 08:19:25 +0000 (00:19 -0800)]
test: distribute crypto tests into separate files

This commit distributes many of the various tests that were previously
strewn about `test-crypto.js` into their own files, such as for Ciphers
and Deciphers, Hashing, and HMACs. Copy pasta, and no style changes
besides removing a few now-unnecessary closures.

Helps eliminate file bloat and allows for easier test prognosis.

PR-URL: https://github.com/iojs/io.js/pull/827
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: increase mark class contrast ratio
Omer Wazir [Thu, 12 Feb 2015 17:30:18 +0000 (10:30 -0700)]
doc: increase mark class contrast ratio

PR-URL: https://github.com/iojs/io.js/pull/824
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: better font-smoothing for firefox
Jeremiah Senkpiel [Thu, 12 Feb 2015 15:55:55 +0000 (10:55 -0500)]
doc: better font-smoothing for firefox

does the same thing for firefox as 'antialiased' does for webkit.

PR-URL: https://github.com/iojs/io.js/pull/820
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: disable font ligatures
Roman Reiss [Thu, 12 Feb 2015 09:48:31 +0000 (10:48 +0100)]
doc: disable font ligatures

PR-URL: https://github.com/iojs/io.js/pull/816
Reviewed-By: Nicu Micleușanu <micnic90@gmail.com>
9 years agodoc: Close code span correctly
Omer Wazir [Thu, 12 Feb 2015 05:51:57 +0000 (22:51 -0700)]
doc: Close code span correctly

The code span is closed with a straight quote instead of the correct
back tick being used.

PR-URL: https://github.com/iojs/io.js/pull/814
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
9 years agosrc: reduce AsyncWrap memory footprint
Ben Noordhuis [Fri, 30 Jan 2015 14:15:56 +0000 (15:15 +0100)]
src: reduce AsyncWrap memory footprint

Fold two integral fields into one and use bitops to access/manipulate
them.

PR-URL: https://github.com/iojs/io.js/pull/667
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agosrc: remove obsoleted queue.h header
Ben Noordhuis [Fri, 30 Jan 2015 11:55:25 +0000 (12:55 +0100)]
src: remove obsoleted queue.h header

It has been obsoleted by the previous commit.  Now it's time to say
goodbye.

PR-URL: https://github.com/iojs/io.js/pull/667
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agosrc: switch from QUEUE to intrusive list
Ben Noordhuis [Fri, 30 Jan 2015 11:54:53 +0000 (12:54 +0100)]
src: switch from QUEUE to intrusive list

This commit also breaks up req_wrap.h into req-wrap.h and req-wrap-inl.h
to work around a circular dependency issue in env.h.

PR-URL: https://github.com/iojs/io.js/pull/667
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agosrc: add typesafe intrusive list
Ben Noordhuis [Fri, 30 Jan 2015 11:54:28 +0000 (12:54 +0100)]
src: add typesafe intrusive list

This is a replacement for the QUEUE macros.  It implements the same
functionality but in a way that lets the compiler typecheck it.

PR-URL: https://github.com/iojs/io.js/pull/667
Reviewed-By: Bert Belder <bertbelder@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agoevents: optimize adding and removing of listeners
Brian White [Wed, 11 Feb 2015 22:00:12 +0000 (17:00 -0500)]
events: optimize adding and removing of listeners

These optimizations result in >2x speedup in the ee-add-remove
benchmark:

* Don't mutate array.length when removing the last listener for
an event
* Don't bother checking max listeners if listeners isn't an array
* Don't call delete when removing the last event in _events, just
re-assign a new object instead

PR-URL: https://github.com/iojs/io.js/pull/785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
9 years agoevents: move slow path to separate function too
Brian White [Tue, 10 Feb 2015 18:12:09 +0000 (13:12 -0500)]
events: move slow path to separate function too

This keeps in line with how things are done for the fast path
and *might* even provide a *slight* performance increase.

PR-URL: https://github.com/iojs/io.js/pull/785
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
9 years agobuffer: expose internals on binding
Vladimir Kurchatkin [Mon, 9 Feb 2015 14:19:56 +0000 (17:19 +0300)]
buffer: expose internals on binding

Remove internal object and expose functions directly on binding.  This
makes possible to simply use internal functions in other builtin
modules.

PR-URL: https://github.com/iojs/io.js/pull/770
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
9 years agosrc: cleanup `Isolate::GetCurrent()`
Vladimir Kurchatkin [Fri, 6 Feb 2015 17:48:14 +0000 (20:48 +0300)]
src: cleanup `Isolate::GetCurrent()`

PR-URL: https://github.com/iojs/io.js/pull/807
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
9 years agodoc: change effect to affect in errors.md
Ryan Seys [Wed, 11 Feb 2015 13:56:31 +0000 (08:56 -0500)]
doc: change effect to affect in errors.md

PR-URL: https://github.com/iojs/io.js/pull/799
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodoc: add sam-github as collaborator
Sam Roberts [Wed, 11 Feb 2015 01:14:02 +0000 (17:14 -0800)]
doc: add sam-github as collaborator

Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: https://github.com/iojs/io.js/pull/791

9 years agodoc: remove Caine section from contributing guide
Michaël Zasso [Wed, 11 Feb 2015 15:57:31 +0000 (16:57 +0100)]
doc: remove Caine section from contributing guide

Caine bot is not active on the repository anymore.
This section is just confusing for new contributors.

Fixes: https://github.com/iojs/io.js/issues/802
PR-URL: https://github.com/iojs/io.js/pull/804
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: fix libuv link
Yosuke Furukawa [Wed, 11 Feb 2015 15:56:18 +0000 (00:56 +0900)]
doc: fix libuv link

PR-URL: https://github.com/iojs/io.js/pull/803
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agocrypto: fix to check ext method for shared lib
Shigeki Ohtsu [Wed, 11 Feb 2015 14:35:47 +0000 (23:35 +0900)]
crypto: fix to check ext method for shared lib

In the case of using openssl with shared library,
reinterpret_cast<X509V3_EXT_I2V>(i2v_GENERAL_NAMES)) refers plt
pointer so that SafeX509ExtPrint returns false.
Fix it to check it with method of NID_subject_alt_name

This patch originally was created by Fedor Indutny
and Ben Noordhuis

Fixes: https://github.com/iojs/io.js/issues/617
PR-URL: https://github.com/iojs/io.js/pull/800

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agodoc: fix wording in fs.appendFile
Rudolf Meijering [Wed, 11 Feb 2015 15:37:23 +0000 (17:37 +0200)]
doc: fix wording in fs.appendFile

PR-URL: https://github.com/iojs/io.js/pull/801
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agosrc: remove trailing whitespace
Vladimir Kurchatkin [Wed, 11 Feb 2015 13:17:04 +0000 (16:17 +0300)]
src: remove trailing whitespace

PR-URL: https://github.com/iojs/io.js/pull/798
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agodoc: update error links
Chris Dickinson [Wed, 11 Feb 2015 03:33:58 +0000 (19:33 -0800)]
doc: update error links

PR-URL: https://github.com/iojs/io.js/pull/793
Reviewed-by: Rod Vagg <rod@vagg.org>
9 years agoWorking on v1.2.1
Rod Vagg [Wed, 11 Feb 2015 02:50:19 +0000 (13:50 +1100)]
Working on v1.2.1

9 years ago2015-02-10 io.js v1.2.0 Release v1.2.0
Rod Vagg [Wed, 11 Feb 2015 01:41:07 +0000 (12:41 +1100)]
2015-02-10 io.js v1.2.0 Release

Notable changes:

* stream:
  - Simpler stream construction, see
    https://github.com/iojs/readable-stream/issues/102 for details.
    This extends the streams base objects to make their constructors
    accept default implementation methods, reducing the boilerplate
    required to implement custom streams. An updated version of
    readable-stream will eventually be released to match this change
    in core. (@sonewman)
* dns:
  - `lookup()` now supports an `'all'` boolean option, default to
    `false` but when turned on will cause the method to return an
    array of *all* resolved names for an address, see,
    https://github.com/iojs/io.js/pull/744 (@silverwind)
* assert:
  - Remove `prototype` property comparison in `deepEqual()`,
    considered a bugfix, see https://github.com/iojs/io.js/pull/636
    (@vkurchatkin)
  - Introduce a `deepStrictEqual()` method to mirror `deepEqual()`
    but performs strict equality checks on primitives, see
    https://github.com/iojs/io.js/pull/639 (@vkurchatkin)
* **tracing**:
  - Add LTTng (Linux Trace Toolkit Next Generation) when compiled
    with the  `--with-lttng` option. Trace points match those
    available for DTrace and ETW.
    https://github.com/iojs/io.js/pull/702 (@thekemkid)
* npm upgrade to 2.5.1
* **libuv** upgrade to 1.4.0
* Add new collaborators:
  - Aleksey Smolenchuk (@lxe)
  - Shigeki Ohtsu (@shigeki)

9 years agodoc: add error documentation
Chris Dickinson [Tue, 10 Feb 2015 20:48:55 +0000 (12:48 -0800)]
doc: add error documentation

PR-URL: https://github.com/iojs/io.js/pull/789
Reviewed-by: Rod Vagg <rod@vagg.org>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodoc: update AUTHORS list
Rod Vagg [Wed, 4 Feb 2015 07:42:42 +0000 (18:42 +1100)]
doc: update AUTHORS list

Update AUTHORS file using tools/update-authors.sh

PR-URL: https://github.com/iojs/io.js/pull/713
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: add shigeki as collaborator
Shigeki Ohtsu [Tue, 10 Feb 2015 15:27:47 +0000 (00:27 +0900)]
doc: add shigeki as collaborator

Fixes: https://github.com/iojs/io.js/issues/778
PR-URL: https://github.com/iojs/io.js/pull/782

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agofs: improve `readFile` performance
Vladimir Kurchatkin [Tue, 3 Feb 2015 19:07:02 +0000 (22:07 +0300)]
fs: improve `readFile` performance

This commit improves `readFile` performance by
reducing number of closure allocations and using
`FSReqWrap` directly.

PR-URL: https://github.com/iojs/io.js/pull/718

Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agodeps: update libuv to 1.4.0
Saúl Ibarra Corretgé [Mon, 9 Feb 2015 20:16:26 +0000 (21:16 +0100)]
deps: update libuv to 1.4.0

PR-URL: https://github.com/iojs/io.js/pull/773
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agotracing: add lttng support for tracing on linux
Glen Keane [Thu, 22 Jan 2015 12:35:16 +0000 (12:35 +0000)]
tracing: add lttng support for tracing on linux

This commit adds the ability to enable userspace tracing with lttng
in io.js. It adds tracepoints for all the equivalent dtrace and ETW
tracepoints. To use these tracepoints enable --with-lttng on linux.

PR-URL: https://github.com/iojs/io.js/pull/702
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ryan Graham <ryan@strongloop.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
9 years agoevents: optimize various functions
Brian White [Thu, 5 Feb 2015 20:35:33 +0000 (15:35 -0500)]
events: optimize various functions

Cache events and listeners objects where possible and loop over
Object.keys() instead of using for..in. These changes alone give
~60-65% improvement in the ee-add-remove benchmark.

The changes to EventEmitter.listenerCount() gives ~14%
improvement and changes to emitter.listeners() gives
significant improvements for <50 listeners
(~195% improvement for 10 listeners).

The changes to emitter.emit() gives 3x speedup for the fast
cases with multiple handlers and a minor speedup for the slow
case with multiple handlers.

The swapping out of the util.is* type checking functions with inline
checks gives another ~5-10% improvement.

PR-URL: https://github.com/iojs/io.js/pull/601
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
9 years agotest: fix test failure with shared openssl
Shigeki Ohtsu [Mon, 9 Feb 2015 04:56:38 +0000 (13:56 +0900)]
test: fix test failure with shared openssl

When configured with share openssl, use external openssl command and
check if it can be executed.

Fixes: https://github.com/iojs/io.js/issues/618
PR-URL: https://github.com/iojs/io.js/pull/762
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: fix typo in crypto
Haoliang Gao [Mon, 9 Feb 2015 08:21:15 +0000 (16:21 +0800)]
doc: fix typo in crypto

PR-URL: https://github.com/iojs/io.js/pull/765
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodoc: change the order of crypto.publicDecrypt
Haoliang Gao [Mon, 9 Feb 2015 09:13:28 +0000 (17:13 +0800)]
doc: change the order of crypto.publicDecrypt

PR-URL: https://github.com/iojs/io.js/pull/767
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoassert: introduce `deepStrictEqual`
Vladimir Kurchatkin [Wed, 28 Jan 2015 16:48:56 +0000 (19:48 +0300)]
assert: introduce `deepStrictEqual`

`deepStrictEqual` works the same way as `strictEqual`, but
uses `===` to compare primitives and requires prototypes of
equal objects to be the same object.

Fixes: https://github.com/joyent/node/issues/7161
Fixes: https://github.com/iojs/io.js/issues/620
PR-URL: https://github.com/iojs/io.js/pull/639
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
9 years agodoc: fix dns.lookup options example
Roman Reiss [Sun, 8 Feb 2015 10:17:32 +0000 (11:17 +0100)]
doc: fix dns.lookup options example

PR-URL: https://github.com/iojs/io.js/pull/757
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
9 years agodoc: update antiquated process.versions output
Ben Noordhuis [Sat, 7 Feb 2015 11:08:39 +0000 (12:08 +0100)]
doc: update antiquated process.versions output

PR-URL: https://github.com/iojs/io.js/pull/750
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agodoc: update node.js references in api docs
Ben Noordhuis [Sat, 7 Feb 2015 10:25:13 +0000 (11:25 +0100)]
doc: update node.js references in api docs

Fixes: https://github.com/iojs/io.js/issues/740
PR-URL: https://github.com/iojs/io.js/pull/750
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agohttps: simpler argument check
Michaël Zasso [Sat, 7 Feb 2015 11:40:05 +0000 (12:40 +0100)]
https: simpler argument check

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
9 years agoutil: simplify `isPrimitive`
Vladimir Kurchatkin [Fri, 6 Feb 2015 13:06:07 +0000 (16:06 +0300)]
util: simplify `isPrimitive`

Everything that is not an object should be a primitive.

PR-URL: https://github.com/iojs/io.js/pull/739

Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agobenchmark: bump eventemitter number of iterations
Ben Noordhuis [Fri, 6 Feb 2015 20:40:53 +0000 (21:40 +0100)]
benchmark: bump eventemitter number of iterations

Some of the benchmarks that were added in commit 847b9d2 complete too
quickly to draw meaningful conclusions from.  Increase the number of
iterations to make them run longer.

PR-URL: https://github.com/iojs/io.js/pull/746
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agodns: allow dns.lookup() to return all addresses
Roman Reiss [Fri, 6 Feb 2015 20:43:50 +0000 (21:43 +0100)]
dns: allow dns.lookup() to return all addresses

This commit adds the 'all' option to dns.lookup(), allowing
all lookup results to be returned.

Semver: Minor
Fixes: https://github.com/iojs/io.js/issues/736
PR-URL: https://github.com/iojs/io.js/pull/744
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agobuffer: don't compare same buffers
Vladimir Kurchatkin [Fri, 6 Feb 2015 15:54:29 +0000 (18:54 +0300)]
buffer: don't compare same buffers

PR-URL: https://github.com/iojs/io.js/pull/742

Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agobenchmark: add more EventEmitter benchmarks
Brian White [Thu, 5 Feb 2015 20:26:28 +0000 (15:26 -0500)]
benchmark: add more EventEmitter benchmarks

PR-URL: https://github.com/iojs/io.js/pull/730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
9 years agodoc: add lxe as collaborator
Aleksey Smolenchuk [Fri, 6 Feb 2015 18:13:55 +0000 (10:13 -0800)]
doc: add lxe as collaborator

PR-URL: https://github.com/iojs/io.js/pull/745
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agodeps: make node-gyp work again on windows
Bert Belder [Thu, 15 Jan 2015 00:39:30 +0000 (01:39 +0100)]
deps: make node-gyp work again on windows

* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: https://github.com/iojs/io.js/pull/422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
9 years agodeps: make node-gyp fetch tarballs from iojs.org
Ben Noordhuis [Tue, 13 Jan 2015 22:22:49 +0000 (23:22 +0100)]
deps: make node-gyp fetch tarballs from iojs.org

Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: https://github.com/iojs/io.js/pull/343
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agodeps: upgrade npm to 2.5.1
Forrest L Norvell [Fri, 6 Feb 2015 09:14:25 +0000 (01:14 -0800)]
deps: upgrade npm to 2.5.1

PR-URL: https://github.com/iojs/io.js/pull/738
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agolib: make debug client connect to 127.0.0.1
Ben Noordhuis [Fri, 6 Feb 2015 15:32:35 +0000 (16:32 +0100)]
lib: make debug client connect to 127.0.0.1

On machines without network connectivity, a DNS lookup for 'localhost'
may fail.  Connect to 127.0.0.1 to skip the host resolve step.

Fixes: https://github.com/iojs/io.js/issues/726
PR-URL: https://github.com/iojs/io.js/pull/741
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
9 years agoassert: don't compare object `prototype` property
Vladimir Kurchatkin [Wed, 28 Jan 2015 15:27:20 +0000 (18:27 +0300)]
assert: don't compare object `prototype` property

All own enumerable properties are compared already. Comparing
`prototype` property specifically can cause weird behaviour.

PR-URL: https://github.com/iojs/io.js/pull/636
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoasyncwrap: fix nullptr parent check
Trevor Norris [Thu, 5 Feb 2015 23:52:09 +0000 (16:52 -0700)]
asyncwrap: fix nullptr parent check

The nullptr check for parent on entry to the constructor should be ==
not !=. This allows reqs that have a parent to run their own init hook
callbacks even if kCallInitHook has been disabled.

9 years agotest: accept EPROTONOSUPPORT ipv6 error
Ben Noordhuis [Thu, 5 Feb 2015 22:52:33 +0000 (23:52 +0100)]
test: accept EPROTONOSUPPORT ipv6 error

The IPv6 test in parallel/test-dgram-error-message-address may fail
when the host system has disabled IPv6, as is the case on our FreeBSD
machines.  The test already accepted EAFNOSUPPORT as of commit 5ba307a,
now make it accept EPROTONOSUPPORT as well.

I'm not exactly thrilled by the profusion of error codes but they are
all legitimate.

PR-URL: https://github.com/iojs/io.js/pull/733
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agoasyncwrap: fix constructor condition for early ret
Trevor Norris [Thu, 5 Feb 2015 22:54:12 +0000 (15:54 -0700)]
asyncwrap: fix constructor condition for early ret

AsyncWrap should always properly propagate asynchronous calls to any
child that is created. Regardless whether kCallInitHook is currently
active. The previous logic would always return early if kCallInitHook
wasn't set.

PR-URL: https://github.com/iojs/io.js/pull/732
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodocs: include mention of new crypto methods
Calvin Metcalf [Thu, 5 Feb 2015 12:52:42 +0000 (07:52 -0500)]
docs: include mention of new crypto methods

Include mention of privateEncrypt and publicDecrypt in changelog.

PR-URL: https://github.com/iojs/io.js/pull/722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
9 years agochild_process: add debug and error details
Zach Bruggeman [Thu, 5 Feb 2015 03:03:18 +0000 (19:03 -0800)]
child_process: add debug and error details

This commit adds debug() calls to spawn() and spawnSync(), and
attaches additional information to Error objects.

Fixes: https://github.com/iojs/io.js/issues/720
PR-URL: https://github.com/iojs/io.js/pull/721
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
9 years agocrypto: clear error on return in TLS methods
Fedor Indutny [Wed, 4 Feb 2015 21:01:11 +0000 (00:01 +0300)]
crypto: clear error on return in TLS methods

Methods like `X509_STORE_add_cert` may push errors onto OpenSSL's error
stack. Ensure that they won't pop up in a different places like
`tls_wrap.cc`.

Fix: https://github.com/iojs/io.js/issues/712
PR-URL: https://github.com/iojs/io.js/pull/719
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agostream: simpler stream constructon
Sam Newman [Tue, 3 Feb 2015 01:12:41 +0000 (01:12 +0000)]
stream: simpler stream constructon

Adds simplified constructor pattern, allowing users
to provide "read", "write", "transform", "flush", and
"writev" functions as stream options in lieu of subclassing.

Semver: minor
PR-URL: https://github.com/iojs/io.js/pull/697
Fixes: https://github.com/iojs/readable-stream/issues/102
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agobenchmark: allow compare via fine-grained filters
Brian White [Wed, 4 Feb 2015 16:11:48 +0000 (11:11 -0500)]
benchmark: allow compare via fine-grained filters

Before this commit, only benchmark targets defined in Makefile could
be used. This commit allows execution of common.js directly and
passing of filter arguments directly, allowing you to run either a
subset of benchmarks or a single specific benchmark for comparison.

PR-URL: https://github.com/iojs/io.js/pull/711
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agosrc: reduce cpu profiler overhead
Ben Noordhuis [Thu, 29 Jan 2015 17:48:30 +0000 (18:48 +0100)]
src: reduce cpu profiler overhead

Reduce the overhead of the CPU profiler by suppressing SIGPROF signals
when sleeping / polling for events. Avoids unnecessary wakeups when the
CPU profiler is active.

The benefits are quite substantial on systems where it is expensive to
query the system time (most virtualized environments). Before, it was
common to see over 20% of wall clock time being spent on clock_gettime()
system calls.

PR: https://github.com/iojs/io.js/pull/466
Reviewed-by: Bert Belder <bertbelder@gmail.com>
9 years agobenchmark: don't use template strings
Evan Lucas [Wed, 4 Feb 2015 08:24:28 +0000 (02:24 -0600)]
benchmark: don't use template strings

When running benchmark/compare.js, it is typical to run a version of
node that does not support template strings. This provides backwards
compatibility for comparing benchmarks using older versions of node.

PR-URL: https://github.com/iojs/io.js/pull/714
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: simplified pure consensus seeking
Mikeal Rogers [Sat, 31 Jan 2015 00:04:38 +0000 (19:04 -0500)]
doc: simplified pure consensus seeking

This changes TC addition to a standard TC motion instead
of requiring unanimous consent of all members.

PR-URL: https://github.com/iojs/io.js/pull/677
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agodoc: update streams wg charter
Chris Dickinson [Fri, 30 Jan 2015 21:47:27 +0000 (13:47 -0800)]
doc: update streams wg charter

PR-URL: https://github.com/iojs/io.js/pull/599
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agoAdjusting for feedback in the PR.
Mikeal Rogers [Fri, 30 Jan 2015 18:58:44 +0000 (13:58 -0500)]
Adjusting for feedback in the PR.

9 years agoInitial documentation for working groups.
Mikeal Rogers [Sat, 24 Jan 2015 22:11:06 +0000 (17:11 -0500)]
Initial documentation for working groups.

9 years agodoc: add GPG fingerprint for chrisdickinson
Chris Dickinson [Tue, 3 Feb 2015 23:16:13 +0000 (15:16 -0800)]
doc: add GPG fingerprint for chrisdickinson

PR-URL: https://github.com/iojs/io.js/pull/710
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agodoc: add TC meeting 2015-01-28 minutes
Rod Vagg [Tue, 3 Feb 2015 04:28:49 +0000 (15:28 +1100)]
doc: add TC meeting 2015-01-28 minutes

PR-URL: https://github.com/iojs/io.js/pull/699
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
9 years agoWorking on v1.1.1
Chris Dickinson [Tue, 3 Feb 2015 22:19:29 +0000 (14:19 -0800)]
Working on v1.1.1

9 years ago2015-02-03 io.js v1.1.0 Release v1.1.0
Chris Dickinson [Tue, 3 Feb 2015 22:13:21 +0000 (14:13 -0800)]
2015-02-03 io.js v1.1.0 Release

Notable changes:

* debug: fix v8 post-mortem debugging.
* crypto: publicEncrypt now supports password-protected private keys.
* crypto: ~30% speedup on hashing functions.
* errors
  - better formatting via util.inspect
  - more descriptive errors from fs. This necessitated a
    NODE_MODULE_VERSION bump.
  - more descriptive errors from http.setHeader
* dep updates:
  - npm: upgrade to 2.4.1
  - http-parser: rollback to 2.3.0
  - libuv: update to 1.3.0
  - v8: update to 4.1.0.14
* http.request: inherited properties on options are now respected
* add iterable interface to buffers.
* fs: fix fd leak on `fs.createReadStream`. See 497fd72 for details.
* installer: on Windows, emit WM_SETTINGCHANGE after install to make
  other running processes aware of the PATH changes.
* Added new collaborators:
  - Vladimir Kurchatkin (@vkurchatkin)
  - Micleușanu Nicu (@micnic)

9 years agotools: add release tool and docs, remove old tools
Rod Vagg [Sat, 31 Jan 2015 10:55:37 +0000 (21:55 +1100)]
tools: add release tool and docs, remove old tools

Also added binary download documentation to the README.md and
GPG release key fingerprint for @rvagg.

PR-URL: https://github.com/iojs/io.js/pull/681
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
9 years agov8abbr: ASCIISTRINGTAG => ONEBYTESTRINGTAG
Fedor Indutny [Tue, 3 Feb 2015 13:59:48 +0000 (16:59 +0300)]
v8abbr: ASCIISTRINGTAG => ONEBYTESTRINGTAG

Fix: iojs/io.js#461
PR-URL: https://github.com/iojs/io.js/pull/706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agogyp: enable postmortem support, fix dtrace paths
Fedor Indutny [Tue, 3 Feb 2015 13:59:35 +0000 (16:59 +0300)]
gyp: enable postmortem support, fix dtrace paths

Fix: iojs/io.js#461
PR-URL: https://github.com/iojs/io.js/pull/706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: fix postmortem support in v8
Fedor Indutny [Tue, 3 Feb 2015 13:59:19 +0000 (16:59 +0300)]
deps: fix postmortem support in v8

Fix: iojs/io.js#461
PR-URL: https://github.com/iojs/io.js/pull/706
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodtrace: fix removal of unused probes
Glen Keane [Tue, 3 Feb 2015 09:46:34 +0000 (09:46 +0000)]
dtrace: fix removal of unused probes

Fixes Windows compile failures introduced in d75fecf6f

PR-URL: https://github.com/iojs/io.js/pull/703
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agohttp: replace util._extend() with [].slice()
Jonathan Ong [Wed, 28 Jan 2015 04:08:43 +0000 (20:08 -0800)]
http: replace util._extend() with [].slice()

PR-URL: https://github.com/iojs/io.js/pull/634
Reviewed-BY: Nicu Micleușanu <micnic90@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
9 years agobenchmark: clean up common.js
Brendan Ashworth [Fri, 30 Jan 2015 02:15:57 +0000 (18:15 -0800)]
benchmark: clean up common.js

This commit cleans up `benchmark/common.js` with a few generic changes
such as the following:

- declare all `require()`'d libraries at the top instead of in the
  middle
- add some empty whitespace where it helps readability
- changes ambiguous variable names
- standardizes most if / else blocks
- missing semicolons

PR-URL: https://github.com/iojs/io.js/pull/662
Reviewed-By: Nicu Micleușanu <micnic90@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
9 years agocrypto: support passwords in publicEncrypt
Calvin Metcalf [Tue, 27 Jan 2015 19:58:22 +0000 (14:58 -0500)]
crypto: support passwords in publicEncrypt

Private keys may be used along with publicEncrypt since the private key
includes the public one.  This adds the ability to use encrypted private
keys which previously threw an error.  This commit also makes sure the
user exposed functions have names.

PR-URL: https://github.com/iojs/io.js/pull/626
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoprocess: fix regression in unlistening signals
Sam Roberts [Tue, 30 Dec 2014 02:00:02 +0000 (18:00 -0800)]
process: fix regression in unlistening signals

When the last signal listener is removed, the signal wrap should be
closed, restoring the default signal handling behaviour. This is done in
a (patched) process.removeListener(). However, events.removeAllListeners
has an optimization to avoid calling removeListener() if there are no
listeners for the 'removeListener' event, introduced in 56668f54d1. That
caused the following code to fail to terminate:

    process.stdin.resume();
    function listener() {};
    process.on('SIGINT', listener);
    process.removeAllListeners('SIGINT');
    process.kill(process.pid, 'SIGINT')

while the following will terminate:

    process.stdin.resume();
    function listener() {};
    process.on('SIGINT', listener);
    process.removeListener('SIGINT', listener);
    process.kill(process.pid, 'SIGINT')

Replace the method patching with use of the 'newListener' and
'removeListener' events, which will fire no matter which methods are
used to add or remove listeners.

PR-URL: https://github.com/iojs/io.js/pull/687
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoevents: remove indeterminancy from event ordering
Sam Roberts [Mon, 2 Feb 2015 03:57:31 +0000 (19:57 -0800)]
events: remove indeterminancy from event ordering

The order of the `newListener` and `removeListener` events with respect
to the actual adding and removing from the underlying listeners array
should be deterministic. There is no compelling reason for leaving it
indeterminate. Changing the ordering is likely to result in breaking
code that was unwittingly relying on the current behaviour, and the
indeterminancy makes it impossible to use these events to determine when
the first or last listener is added for an event.

PR-URL: https://github.com/iojs/io.js/pull/687
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agosrc: remove unused dtrace probes
Glen Keane [Mon, 2 Feb 2015 18:57:17 +0000 (18:57 +0000)]
src: remove unused dtrace probes

Removed DTRACE_NET_SOCKET_READ and DTRACE_NET_SOCKET_WRITE
as they were never called from within the source code.

PR-URL: https://github.com/iojs/io.js/pull/694
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agonet: check close callback is function
Yosuke Furukawa [Mon, 26 Jan 2015 17:55:19 +0000 (02:55 +0900)]
net: check close callback is function

PR-URL: https://github.com/iojs/io.js/pull/609
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
9 years agodgram: check close callback is function
Yosuke Furukawa [Mon, 26 Jan 2015 17:28:18 +0000 (02:28 +0900)]
dgram: check close callback is function

PR-URL: https://github.com/iojs/io.js/pull/609
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
9 years agolib: reduce util.is*() usage
cjihrig [Thu, 29 Jan 2015 01:05:53 +0000 (20:05 -0500)]
lib: reduce util.is*() usage

Many of the util.is*() methods used to check data types
simply compare against a single value or the result of
typeof. This commit replaces calls to these methods with
equivalent checks. This commit does not touch calls to the
more complex methods (isRegExp(), isDate(), etc.).

Fixes: https://github.com/iojs/io.js/issues/607
PR-URL: https://github.com/iojs/io.js/pull/647
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agodeps: make node-gyp work again on windows
Bert Belder [Thu, 15 Jan 2015 00:39:30 +0000 (01:39 +0100)]
deps: make node-gyp work again on windows

* Fetch from the correct url.
* Link compiled addons with iojs.lib instead of node.lib.
* Disable checksum checks for iojs.lib until our website supports
  them.

PR: https://github.com/iojs/io.js/pull/422
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-by: Rod Vagg <rod@vagg.org>
9 years agodeps: make node-gyp fetch tarballs from iojs.org
Ben Noordhuis [Tue, 13 Jan 2015 22:22:49 +0000 (23:22 +0100)]
deps: make node-gyp fetch tarballs from iojs.org

Apply a small patch that makes node-gyp fetch the tarballs from
https://iojs.org/ instead of http://nodejs.org/

A patch better suited for inclusion upstream will be put together
shortly.

PR-URL: https://github.com/iojs/io.js/pull/343
Reviewed-By: Rod Vagg <rod@vagg.org>
9 years agodeps: upgrade npm to 2.4.1
Forrest L Norvell [Fri, 30 Jan 2015 11:12:07 +0000 (03:12 -0800)]
deps: upgrade npm to 2.4.1

PR-URL: https://github.com/iojs/io.js/pull/663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
9 years agoassert: use util.inspect() to create error messages
cjihrig [Fri, 30 Jan 2015 15:25:32 +0000 (10:25 -0500)]
assert: use util.inspect() to create error messages

Currently, JSON.stringify() is used to create error messages
on failed assertions. This causes an error when stringifying
objects with circular references. This commit switches out
JSON.stringify() for util.inspect(), which can handle
circular references.

PR-URL: https://github.com/iojs/io.js/pull/668
Reviewed-By: Julien Gilli <julien.gilli@joyent.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
9 years agofs: improve error messages
Bert Belder [Sat, 31 Jan 2015 10:48:34 +0000 (11:48 +0100)]
fs: improve error messages

* Include a description for the error message
* For rename, link, and symlink, include both the source and destination
  path in the error message.
* Expose the destination path as the `dest` property on the error object.
* Fix a bug where `ThrowUVException()` would incorrectly delegate to
  `Environment::TrowErrnoException()`.

API impact:
* Adds an extra overload for node::UVException() which takes 6
  arguments.

PR: https://github.com/iojs/io.js/pull/675
Fixes: https://github.com/iojs/io.js/issues/207
Closes: https://github.com/iojs/io.js/pull/293
Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl>