Christopher Michael [Tue, 28 Apr 2020 16:35:07 +0000 (12:35 -0400)]
ecore-evas-drm: Fix broken init count
We should not assume that there is only ever 1 drm ecore_evas here so
we need to handle init count properly
@fix
Marcel Hollerbach [Sun, 29 Sep 2019 16:04:51 +0000 (18:04 +0200)]
build: install eo files per default
in the last release we turned that off, because we started to stabelize
API back there, but the .eo file format wasnt ready yet.
Now, the file format is stable. And we stabelized more widgets, which
means, we should also install the .eo files per default.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D10242
Boris Faure [Sat, 25 Apr 2020 13:03:30 +0000 (13:03 +0000)]
meson: allow debug-threads to be disabled in debug
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11756
Mike Blumenkrantz [Wed, 22 Apr 2020 17:18:25 +0000 (13:18 -0400)]
tests/elm: add more naviframe tests
some tests to explicitly verify callback and internal behavior
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11752
Mike Blumenkrantz [Wed, 22 Apr 2020 17:16:50 +0000 (13:16 -0400)]
tests/elm: add util callback for capturing event_info in smart callbacks
useful when we want to verify that e.g., a certain object item is passed
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11751
Mike Blumenkrantz [Wed, 22 Apr 2020 17:17:43 +0000 (13:17 -0400)]
tests/elm: add some more specific convenience macros for size checks
sometimes a test might only want to verify the width or height of an object
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11750
Mike Blumenkrantz [Wed, 22 Apr 2020 17:15:45 +0000 (13:15 -0400)]
tests/elm: check all objects for signal interface before calling signal funcs
just being extra paranoid here since there's some classes which implement
some layout/content interfaces without implementing signals
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11749
Mike Blumenkrantz [Wed, 22 Apr 2020 17:14:48 +0000 (13:14 -0400)]
tests/elm: add a list sizing test
basic test to ensure that list sizing is homogeneous and works as it
"should", even though list sizing internals are a black hole of lost time
and dreams
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11748
Mike Blumenkrantz [Wed, 22 Apr 2020 17:13:57 +0000 (13:13 -0400)]
elm/list: avoid erroring on non-elm item contents
putting raw evas and edje objects in here has historically been done,
so handle it without errors
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11747
Marcel Hollerbach [Sun, 26 Apr 2020 15:29:09 +0000 (17:29 +0200)]
efl_fileselector_entry: do not crash on a invalid model
something is happening during shutdown, when a fileselector was created
before. This is ending up in a strcmp to a NULL ptr, which crashes, with
the now, we ensure that we are not crashing anymore, when that is
happning.
TO solve this properly we should really fix the cause of a invalid model
beeing returned, however, i do not feel compftable doing that so short
before a release.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11762
Marcel Hollerbach [Sat, 18 Apr 2020 08:46:37 +0000 (10:46 +0200)]
efl_ui_focus_manager_calc: correctly flag elements used
when setting the relation from two widgets a<->b a is used as well as b.
This now correctly sets these flags.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Differential Revision: https://phab.enlightenment.org/D11730
WooHyun Jung [Mon, 4 May 2020 01:59:33 +0000 (10:59 +0900)]
evas_font_query: fixed the wrong arrangement when white-char is on wrapping point
Current textblock does not have proper logic for processing line wrapping when -
1. white-char is on wrapping point
2. white-char is drawn with different font from the characters which are before and after it
So, this change would follow the old logic which assumes the font for white-character is
always cached by the current processing font.
After making proper changes in textblock, then this patch can be reverted.
@tizen_fix
Change-Id: I18f782402dafe64358c9094566ce41f96b8cbb84
Hermet Park [Wed, 29 Apr 2020 04:25:28 +0000 (13:25 +0900)]
canvas vg: Correct order of data free.
vfd data is firstly initialized and
must be freed in the last.
Change-Id: Ife3294933b601bfb7a293b409082a1282215a6d7
Lukasz Oleksak [Tue, 21 Apr 2020 07:28:20 +0000 (09:28 +0200)]
[atspi] Propagation of app_gesture_support attribute from content to base layout of naviframe_item
Change-Id: I65ba479fc0674dd918012a51096293f7f988a17e
Hermet Park [Tue, 28 Apr 2020 05:35:26 +0000 (14:35 +0900)]
canvas clip: replace hash to cached array.
Each child_map_across_mark() takes 0.026ms with eina_hash
we can reduce the performing time by replacing the hash to array to 0.0041ms in a device.
Before Average: 0.026ms
Mostly it takes 23 times in the scrolling. thus it takes 3%(0.48ms) in one frame rendering (16ms)
After Average: 0.0041ms
Mostly it takes 23 times in the scrolling. thus it takes 0.6%(0.096ms) in one frame rendering (16ms)
result: map calc 5x faster than original (0.384ms improved)
Thanks Subhransu for report this.
@optimization
Change-Id: Iba6d9addd0d092214dda4dd3f60e90b0aec1b8a7
Mike Blumenkrantz [Mon, 27 Apr 2020 13:46:45 +0000 (09:46 -0400)]
elm/cnp: remove const from static function return
this makes no sense
../src/lib/elementary/elm_cnp.c:54:15: warning: type qualifiers ignored on function return type [-Wignored-qualifiers]
54 | static inline const Elm_Sel_Format
Reviewed-by: Christopher Michael <devilhorns@comcast.net>
Differential Revision: https://phab.enlightenment.org/D11759
Xavi Artigas [Mon, 27 Apr 2020 15:25:27 +0000 (17:25 +0200)]
doxygen docs: Fix most errors on Evas_Legacy.h
Oh boy... References to Unified API, horribly misshapen groups,
typos, invalid commands, invalid references, and on top of that,
Evas VG.
Xavi Artigas [Mon, 27 Apr 2020 13:54:10 +0000 (15:54 +0200)]
doxygen docs: Put Evas_Canvas legacy methods in the right group
"Evas_Group" does not exist, and "Evas" is a top-level group without content
(only subgroups). So I guess all these methods belong to the "Evas_Canvas" group.
This brings even more docs into existence, fixing multiple missing references.
Xavi Artigas [Mon, 27 Apr 2020 13:15:12 +0000 (15:15 +0200)]
doxygen docs: Fix invalid refs to Layout
All widgets copy&pasted the same description, including an invalid reference
to "Layout", which should be "Elm_Layout".
SOME of them had been fixed over the years but this commit fixes all of them.
This significantly reduces the number of Doxygen warnings and adds meaningful
links to the docs.
Xavi Artigas [Mon, 27 Apr 2020 11:40:27 +0000 (13:40 +0200)]
doxygen docs: Add missing Elementary group
Elementary has a main page (elementary_main) like other libs (Ecore, Evas...)
but it was missing a doxygen group like the other libs. This group is not
terribly useful but it is manually referenced from dozens of places, resulting
in lots of warnings.
I thought this solution is simpler than removing all the manual references.
Xavi Artigas [Mon, 27 Apr 2020 10:28:57 +0000 (12:28 +0200)]
doxygen docs: Match doc with correct enum for Render_Op
Docs did not match the intended enum value due to incorrect usage of the
doxygen tags.
Also, Evas_Render_Op was the only member of the top-level Evas group, so
I moved it inside one subgroup, where methods using it reside.
Xavi Artigas [Mon, 27 Apr 2020 10:05:17 +0000 (12:05 +0200)]
doxygen docs: Put APIs in correct group
"Evas_Object" does not exist as a group, so the docs for these 29 methods
did not show in the output.
Xavi Artigas [Mon, 27 Apr 2020 08:01:09 +0000 (10:01 +0200)]
doxygen docs: Document compositor sync API as deprecated
This is currently a NOP and we should remove this API later on.
Meanwhile, turn the note about this API being experimental into
a deprecation warning.
Woochanlee [Mon, 27 Apr 2020 10:46:54 +0000 (19:46 +0900)]
elm_spinner: list spinner signal clean up to following Common GUI.
Change-Id: If69ed24820c4a5d39cc8d5667f3050ebd16e5176
JunsuChoi [Mon, 27 Apr 2020 10:29:47 +0000 (19:29 +0900)]
efl_ui_image: Fix unnecessary unload of memfile_set.
Summary:
In D11392, fixed to call file_unload when doing memfile_set.
Therefore, "load,error" callback was called while unloading object
that was not loaded when first load with memfile_set.
So fix it to avoid unnecessary unloading.
Test Plan:
{
F3871804}
cp ./test_imge.c ./efl/
cd efl
gcc -o test_image test_image.c -g `pkg-config --cflags --libs elementary`
./test_image
Loading image...
Async file load failed.
Image is ready to show.
Reviewers: Hermet, kimcinoo, herb
Reviewed By: Hermet
Subscribers: cedric, #reviewers, #committers, zmike
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11758
Change-Id: I5d30e5b35c08481cb2eaa7eb4a45d07e49433082
Hermet Park [Fri, 24 Apr 2020 12:26:25 +0000 (21:26 +0900)]
canvas gl: fix nutty code of partial rendering toggle.
clean up partial rendering code for maintaining
and makei it work properly while toggling.
Change-Id: I8827c2526397fb73c961a0f4449f2bacd6525418
Carsten Haitzler (Rasterman) [Sun, 26 Apr 2020 12:15:33 +0000 (13:15 +0100)]
elm - combobox - pretty borken but make it a little less
add some tests so i can see smaller comboboxes with padding and fix
the scaling which was broken.
Daniel Kolesa [Sun, 26 Apr 2020 00:29:35 +0000 (02:29 +0200)]
eolian: require opaque structs to be used by ref always
For now only in stable API.
Carsten Haitzler (Rasterman) [Sat, 25 Apr 2020 13:44:23 +0000 (14:44 +0100)]
efreet - work around conconforming apps putting startupwmclass in quotes
riot does
StartupWMClass="Riot"
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html
does not allow for quoting here. you can quote fields in an exec line
- for shell and replacement purposes, but not other fields like this
above. this is a workaround a broken app so matching window to desktop
file works.
@fix
Carsten Haitzler (Rasterman) [Fri, 24 Apr 2020 23:19:08 +0000 (00:19 +0100)]
evas gl - fix coverity complaint in shader cache update
Carsten Haitzler (Rasterman) [Fri, 24 Apr 2020 15:54:11 +0000 (16:54 +0100)]
evas gl - shader cache was needless losing and overwriting
we were losing cached chaders and overwriting the cache all the time
when apps finished compiling new shaders and at other points... when
they should have already had a populated shader cache that was all
fine and happy. this fixes that so once the cache is fully populated
it wont write anymore and it wont lose existing shaders in the cache
@fix
Ali [Fri, 24 Apr 2020 11:55:12 +0000 (20:55 +0900)]
evas_gl_context: reduce conditions for image orientation check
Reviewers: woohyun, eunue, kimcinoo, Hermet
Reviewed By: Hermet
Subscribers: kimcinoo, cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11755
Hermet Park [Fri, 24 Apr 2020 12:11:27 +0000 (21:11 +0900)]
canvas layer: +prevent null layer objects.
Change-Id: I7a822d314ee16e984db25aa0180b61affa0cdd8c
Hermet Park [Fri, 24 Apr 2020 12:00:39 +0000 (21:00 +0900)]
canvas layer: find the top item for only valids.
In some case, top layer doesn't have valid objects,
That case, we must find and return top object in the next layer.
Change-Id: I3c6fc8a683a1b3673a06f8e544a04809ed3a353e
Woochanlee [Fri, 24 Apr 2020 04:32:59 +0000 (13:32 +0900)]
elm_spinner: Implement Tizen_6.0 Common profile GUI.
Add internal API to enable scroll item align feature only in list spinner.
Enable scroll item align and valign in list spinner.
Spinner will sending signal to genlist for item font change.
Change-Id: I8b3d6fe38ce14e73502846df29b50dd09b707d2a
JunsuChoi [Thu, 23 Apr 2020 11:13:31 +0000 (20:13 +0900)]
evas_gl_common: Add env "EVAS_GL_TEXTURE_ATLAS_DISABLE" to control texture atlas for image upload
To disable texture atlas, calling setenv before elm_win_add
*This patch was added for a fix issue related to atlas image of product code.(tizen_4.0)
Change-Id: I422433c05244b785c96e7a9d52469cde7189cb83
Stefan Schmidt [Wed, 22 Apr 2020 15:44:04 +0000 (17:44 +0200)]
exactness: check action for NULL
If the given events list is NULL the data pointer would be as well. Make
sure we check for NULL here before accessing.
CID: 1419843
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11754
Stefan Schmidt [Fri, 17 Apr 2020 13:03:28 +0000 (15:03 +0200)]
exactness: use convinience ecore_file function to get dir
Instead of doing our own parsing here we should use ecore_file_dir_get()
which uses dirname() already to solve this.
CID: 1422196
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11727
Stefan Schmidt [Fri, 17 Apr 2020 12:34:21 +0000 (14:34 +0200)]
exactness: do not access potential NULL pointer
These to code lines should be in one block and not one exectued without
the if.
CID: 1422198
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11726
Carsten Haitzler (Rasterman) [Thu, 23 Apr 2020 10:38:20 +0000 (11:38 +0100)]
Revert "meson: do not install .eo files of not installed header files"
This reverts commit
d4946a0d072ff301026e6c56e095a87305def1a0.
install these - e builds against efl will fail if they try use
efl-canvas-wl without headers... :)
Ali [Wed, 22 Apr 2020 08:28:55 +0000 (08:28 +0000)]
EFl_Canvas_Text: add typedef for backward compatibility in legacy headers
Reviewed-by: Carsten Haitzler (Rasterman) <raster@rasterman.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11744
Carsten Haitzler (Rasterman) [Wed, 22 Apr 2020 11:49:34 +0000 (12:49 +0100)]
ecore_file - address issue about false positive of finding a file in ./
it may report an exe is installed if it happens to be in cwd but cwd
isnt in path. the "full/relative" path handling case mishandled this.
fixes T8678
@fix
Maria Bialota [Wed, 22 Apr 2020 17:59:14 +0000 (19:59 +0200)]
[atspi] _accessible_reading_material_get: Added Efl.Access.Selection interface check before calling Selection method
Change-Id: I32852473f98445e7c2af177d74632ce077b45e0a
SangHyeon Jade Lee [Wed, 22 Apr 2020 07:08:44 +0000 (16:08 +0900)]
genlist : fix direction calc for adjust align get
Change-Id: I8aeb9067089c83327b583574dcc6f25073e38a61
Signed-off-by: SangHyeon Jade Lee <sh10233.lee@samsung.com>
(cherry picked from commit
dc3fa9f66766fbb008e327f837268b31136317b6)
Bartlomiej Grzelewski [Tue, 21 Apr 2020 11:31:23 +0000 (13:31 +0200)]
elm_atspi_bridge: fix unregister object usage
All objects paths in accessible_reading_material_get
method should be registered before return them to user.
Change-Id: Idd5f824cc25ef083a0ec490e4fdfe911c3e11373
Bowon Ryu [Tue, 21 Apr 2020 12:32:46 +0000 (21:32 +0900)]
elm_entry: do not set SENSITIVE_DATA in INPUT_PANEL_LAYOUT_PASSWORD
If input_hint is set to SENSITIVE_DATA in elm_entry_input_panel_layout_set,
Even when the password mode of elm_entry is false,
some functions cause the problem to behave like password mode.
This patch makes the entry's password mode operation depend only on the elm_entry_password_set API.
Change-Id: Ie1a9efc13fc34cf09212209d0c6459e3221ca541
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Alastair Poole [Tue, 21 Apr 2020 17:19:36 +0000 (18:19 +0100)]
ecore_wl2: EFL Wayland Build on FreeBSD
This enables a user to build EFL with wayland support enabled
on FreeBSD. It is NOT functioning, but everything starts at
some point.
This requires also linking against -lepoll-shim.
Meson arguments:
-Deeze=false -Dv4l2=false -Dfb=false -Ddrm=false -Dwl=true \
-Dsystemd=false
@fix T8659
Daniel Kolesa [Tue, 21 Apr 2020 15:46:17 +0000 (17:46 +0200)]
eolian: clarify @move tag usage in documentation
Marcel Hollerbach [Sat, 11 Apr 2020 19:15:07 +0000 (21:15 +0200)]
elementary: fix string definition
eolian is note made to have ptr(char) be the same as string.
Differential Revision: https://phab.enlightenment.org/D11740
Marcel Hollerbach [Sat, 11 Apr 2020 17:55:27 +0000 (19:55 +0200)]
eina: add new definitions to a old enum
this is sadly needed due to the fact that we have a .eo defnition in the
.eot file which contains the flags keyword.
Differential Revision: https://phab.enlightenment.org/D11739
Marcel Hollerbach [Sat, 11 Apr 2020 17:32:38 +0000 (19:32 +0200)]
elementary: these definitions are in real header files
there is no reason to have them in the .eot files. They are also not
namespaced in the way we want to have types.
Differential Revision: https://phab.enlightenment.org/D11738
Marcel Hollerbach [Fri, 10 Apr 2020 13:47:11 +0000 (15:47 +0200)]
evas: remove dead struct definition
this is not used anywhere
Differential Revision: https://phab.enlightenment.org/D11737
Marcel Hollerbach [Sun, 19 Apr 2020 19:37:37 +0000 (21:37 +0200)]
eo: install eot files correctly
eina_types.eot is needed in order to fetch all needed informations.
Differential Revision: https://phab.enlightenment.org/D11736
Marcel Hollerbach [Sun, 19 Apr 2020 19:37:03 +0000 (21:37 +0200)]
elementary: do not install legacy .eo files
they do not have any purpose to be installed on the filesystem.
Differential Revision: https://phab.enlightenment.org/D11735
Marcel Hollerbach [Sun, 19 Apr 2020 19:33:48 +0000 (21:33 +0200)]
meson: do not install .eo files of not installed header files
Differential Revision: https://phab.enlightenment.org/D11733
Stefan Schmidt [Tue, 21 Apr 2020 09:22:33 +0000 (11:22 +0200)]
release: Update NEWS and bump version for 1.24.0-beta3 release
WooHyun Jung [Tue, 21 Apr 2020 05:37:23 +0000 (14:37 +0900)]
evas_object_textblock: add null check for return of eina_inlist_remove
Christopher Michael [Mon, 20 Apr 2020 23:31:44 +0000 (19:31 -0400)]
ecore-drm2: Change ERR to WRN
No real need for these to be ERR because we are not going to crash if
these happen anyway.
Christopher Michael [Fri, 17 Apr 2020 16:52:00 +0000 (12:52 -0400)]
ecore-evas-wayland: Fix formatting
NB: No functional changes
Bowon Ryu [Tue, 21 Apr 2020 06:25:43 +0000 (15:25 +0900)]
marquee: add stack above between p_obj and textblock.
Stacks p_obj for marquee animation on the existing textblock.
Adjust the z-index with this.
This prevents other ui elements from being placed between the textblock and p_obj.
Change-Id: I2f71ef66233938b3c758eac5c1b3548c5d107d42
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Daniel Kolesa [Mon, 20 Apr 2020 12:36:14 +0000 (14:36 +0200)]
eolian: fix C type serialization of error()
Daniel Kolesa [Mon, 20 Apr 2020 12:19:26 +0000 (14:19 +0200)]
eolian: only warn instead of erroring on unused imports
Marcel Hollerbach [Mon, 20 Apr 2020 06:46:45 +0000 (08:46 +0200)]
exactness-inspect: do not use sprintf
there is not yet a CID for this, but we should probebly not do that.
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Reviewed-by: Xavi Artigas <xavierartigas@yahoo.es>
Differential Revision: https://phab.enlightenment.org/D11731
Marcel Hollerbach [Fri, 17 Apr 2020 13:17:52 +0000 (15:17 +0200)]
exactness-inspect: remove abscure xor check
this is a obscure check, if this was ever reached, then it would simply
crash, because one pointer will be NULL, but strcmp will be called on
it.
CID 1419854
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11722
Xavi Artigas [Mon, 20 Apr 2020 10:22:44 +0000 (12:22 +0200)]
doxygen docs: Fix all invalid @param names
There were quite a few of these...
Stefan Schmidt [Fri, 17 Apr 2020 13:23:44 +0000 (15:23 +0200)]
exactness: make sure we handle a negative file descriptor
In an error case the fd could be negative here and we should check
before feeding it into fdopen(). This is the same patch we used in
recorder.c
CID: 1422194
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11728
Stefan Schmidt [Fri, 17 Apr 2020 12:12:48 +0000 (14:12 +0200)]
exactness: make sure we handle a negative file descriptor
In an error case the fd could be negative here and we should check
before feeding it into fdopen().
CID: 1422197
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11725
Stefan Schmidt [Fri, 17 Apr 2020 12:06:57 +0000 (14:06 +0200)]
exactness: handle case where eet_data_image_write() fails
We never checked how many bytes had been written. Check on return and
propagate error upwards to caller.
CID: 1419856
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11724
Stefan Schmidt [Fri, 17 Apr 2020 11:35:38 +0000 (13:35 +0200)]
exactness: remove unused code
We no longer support the old .rec format and we can always expect the
file to be exu. Coverity found this block to be always true so the else
part could not be reached.
CID: 1421996
Reviewed-by: Marcel Hollerbach <mail@marcel-hollerbach.de>
Differential Revision: https://phab.enlightenment.org/D11723
Carsten Haitzler (Rasterman) [Sun, 19 Apr 2020 22:27:01 +0000 (23:27 +0100)]
elm theme - add support for smooth restart for e
just extra data item and extra program only used if it's a new e
Hermet Park [Fri, 17 Apr 2020 09:14:48 +0000 (18:14 +0900)]
canvas svg: fix memory leak.
free svg node commands & points data after usage.
@fix
Change-Id: I598b93a083699e032c12f53b01dda1b6573d2b62
Woochanlee [Mon, 6 Apr 2020 10:06:51 +0000 (19:06 +0900)]
elm_spinner: Prevent to create inc/dec button in list spinner.
There is no inc/dec button in list spinner UX
@tizen_feature
Change-Id: Ic4eff7193f2b782c29d27037164c002f06def200
Carsten Haitzler (Rasterman) [Sun, 19 Apr 2020 17:41:08 +0000 (18:41 +0100)]
elm - theme - add outline style for frames
new standard style. outline.
Daniel Kolesa [Sat, 18 Apr 2020 23:53:50 +0000 (01:53 +0200)]
eolian: globally enable eolian_state_check, except for beta classes
Beta classes won't have their namespaces validated at this point.
It is possible to set EOLIAN_CHECK_NAMESPACES_BETA=1 to enable
checking those as well, if you want to fix them all.
Daniel Kolesa [Sat, 18 Apr 2020 23:44:50 +0000 (01:44 +0200)]
remove unused imports in eo/eot files
Daniel Kolesa [Sat, 18 Apr 2020 23:43:33 +0000 (01:43 +0200)]
eolian: add composites into hard deps when checking
This prevents composites from being considered unused imports.
Carsten Haitzler (Rasterman) [Sat, 18 Apr 2020 16:36:25 +0000 (17:36 +0100)]
evas_textblock/evas_text/evas_textgrid: pick textrun fonts
Summary:
Picking font on textrun, will now give priority into font picked by the user, regardless of script type.
picking font due script can cause many inconvenient results
Example of wrong results: (User font is **NotoColorEmoji**)
{
F3847118} -> add 'a' at the end (notice how text render is wrong) {
F3847119} -> add tab before 'a' (text rendering now is right) {
F3847120}
After Change results: (User font is **NotoColorEmoji**)
{
F3847118} -> add 'a' at the end -> {
F3847122}-> add tab before 'a' -> {
F3847123}
Also now the following lines will be shown exactly the same, regardless of characters order
```
"가123A321"
"A321가123"
"123가A321"
"A가123321"
```
Test Plan:
```
#include <Elementary.h>
/*
gcc -o example test.c `pkg-config --cflags --libs elementary`
*/
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *en;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("", "");
elm_win_autodel_set(win, EINA_TRUE);
en = elm_entry_add(win);
elm_entry_scrollable_set(en, EINA_TRUE);
evas_object_size_hint_weight_set(en, EVAS_HINT_EXPAND, EVAS_HINT_EXPAND);
evas_object_size_hint_align_set(en, EVAS_HINT_FILL, EVAS_HINT_FILL);
elm_entry_text_style_user_push(en,"DEFAULT='font=NotoColorEmoji font_size=30 color=red'");
elm_object_text_set(en, "☪123456a");
evas_object_show(en);
elm_object_content_set(win, en);
evas_object_resize(win, 400, 200);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
Reviewers: woohyun, bowonryu, tasn, raster, cedric
Reviewed By: tasn
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Maniphest Tasks: T8556
Differential Revision: https://phab.enlightenment.org/D11302
Ali [Sat, 18 Apr 2020 16:36:11 +0000 (17:36 +0100)]
evas_textgrid: update text props to use current script font
Summary:
This update make the textgrid same as evas_text and evas_textblock to use current picked font for text_props instead of script_font
This patch will fix terminology emoji rendering when used applying D11302.
Reviewers: raster, woohyun
Reviewed By: woohyun
Subscribers: cedric, #reviewers, #committers
Tags: #efl
Differential Revision: https://phab.enlightenment.org/D11729
Carsten Haitzler (Rasterman) [Sat, 18 Apr 2020 16:28:10 +0000 (17:28 +0100)]
evas render - flush, dont clear unref/clean arrays on render done
we build these arrays to hold tjhings to clean up when done ... but if
one frame happens ot have a lot - the allocation stays huge as we only
clean not flush, so flush to keep memory down.
@optimize
Godly T.Alias [Wed, 15 Apr 2020 17:53:48 +0000 (23:23 +0530)]
[Genlist] Unfreeze event fix
Unfreeze event is not occuring properly. If item is on deletion genlist remains in freezed state Unfreeze genlist regardless of deletion state
Change-Id: I50d517edb85811ea6c367f2d22d80f5759bce326
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Wonki Kim [Sat, 11 Apr 2020 03:51:24 +0000 (12:51 +0900)]
ecore_anim: fix animator ticking logic to gain accuarte
ecore_loop_time has set by a improper timestamp just before animator callback is invoked.
ecore_animator is built over ecore_thread. ticking is handled in 'thread_func'
and a tick is fired by calling ecore_thread_feedback with a timestamp argument.
In notify func, ecore_time_loop_set has take place with the argument from thread func.
the argument could be unacceptable because notify function is invoked asynchronously.
if there were many thing to do in the loop, time gap must be incresed.
animator tick leads elm logic to calculate next position in animating.
so it is neccessary to use actual time for the calculating.
this patch fixes the animator to set loop time by a actual time.
Change-Id: I1f00a5d074a78da5a87fba55bc1ab13a4f1311df
Hosang Kim [Wed, 8 Apr 2020 03:58:20 +0000 (12:58 +0900)]
ecore_wl: To use vsync as custom source of animator
This patch includes below patches
ecore: fixed wrong codes regarding ecore_anim_vsync
ecore: Remove condition about timeout in animator with vsync
ecore_anim : Add safety code to ecore_anim
ecore_anim: Fix don't call animator_cb
ecore_wayland: Remove codes irrelevant to poll()
@tizen_only
Change-Id: I2223cc9b4574d17b99f91c5b7e6c8587c9e7852f
Signed-off-by: Hosang Kim <hosang12.kim@samsung.com>
ch.jeong47 [Thu, 9 Apr 2020 04:55:12 +0000 (13:55 +0900)]
Add debug information to ecore_wl2
- add debug information which for analyzing of many issues related to touch event.
Sometimes we need more information regarding touch events of ecore_wl2.
Change-Id: I0c495c2b25fef7a6062febeddd43f7753a67e406
Signed-off-by: ch.jeong47 <ch.jeong47@samsung.com>
HyukSoon Choi [Mon, 13 Apr 2020 10:10:41 +0000 (19:10 +0900)]
spinner: flick to open feature
Change-Id: Ice51bbca22d07552193e3c10bb1a22c33481e365
Signed-off-by: HyukSoon Choi <hs619.choi@samsung.com>
SangHyeon Jade Lee [Tue, 7 Apr 2020 08:18:27 +0000 (17:18 +0900)]
edje : add new feature of color class can be aliased by item data in the group
search object color_class can be aliased different name by looking into
item.data of group style.
data {
item: "color/aliased_color_class_name" "original_color_class_name"
}
@tizen_only
Change-Id: Ic94f51d3066d8942ad86f6f3ef91de29917be9b7
Godly T.Alias [Wed, 15 Apr 2020 17:10:01 +0000 (22:40 +0530)]
[Genlist] Avoid unnecessary refcount in item
Item is not getting deleted. Refcount was not becoming < 1.Unref the item for allowing item to be deleted
Change-Id: Iaf8b71bb06c7c6f5a3e70fc89796e815e5336424
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Godly T.Alias [Wed, 15 Apr 2020 12:44:43 +0000 (18:14 +0530)]
[Genlist] Contribution of item free optimization on clear
Change-Id: Id229f881b45dfc27ecf4f7bda8b22648c0e4d2c7
Signed-off-by: Suresh Kumar <suresh.ku1@samsung.com>
Godly T.Alias [Wed, 15 Apr 2020 03:57:55 +0000 (09:27 +0530)]
[Genlist] Avoid non alignable items being aligned during recalculations
Change-Id: Iec2208485f4b5e62e954270eb2c5f78c08637161
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
Godly T.Alias [Tue, 14 Apr 2020 06:00:37 +0000 (11:30 +0530)]
[Genlist] Safety checks to avoid crashes
Change-Id: Ic951e1382b7e82488b82a2cec042bb0ab50b026c
Signed-off-by: Yukti Pandey <yukti.pandey@samsung.com>
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 18:19:52 +0000 (19:19 +0100)]
Revert "evas_textblock: pick textrun fonts"
This reverts commit
9b987c67e1e38602ba2e4c9c990798e99d938bbe.
this breaks color emoji in terminology (evas textgrid).
Marcel Hollerbach [Fri, 17 Apr 2020 13:15:41 +0000 (15:15 +0200)]
exactness-inspect: unit1 can never be NULL
checkinf for it beeing NULL means that we would have to equip every
usage of unit1 with a check, but that is useless.
CID 1419859
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11721
Marcel Hollerbach [Fri, 17 Apr 2020 13:11:26 +0000 (15:11 +0200)]
exactness-inspect: fix NULL access
ii might be NULL so we should ensure it is not NULL to call item_select
CID 1419865
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11720
Marcel Hollerbach [Fri, 17 Apr 2020 13:08:27 +0000 (15:08 +0200)]
exactness-inspect: sanitize if clause
these if clause where a bit bottom up, and the xor operation here seemed
totally wrong, with this code we are simply displaying both entiteis of
the two structs when they are there. *or* we are replacing it with the
fallback.
CID1419875
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11719
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 11:47:34 +0000 (12:47 +0100)]
elm - genlist test - handl g_data being null
fix CID 1396944 1396946
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 11:28:35 +0000 (12:28 +0100)]
ecore - examples - fix gnutls fd handler example warnings
just error returns not being checked. not an issue really, but this
silences warnings.
fix CID 1164185 715896 98094 1400818
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 11:14:19 +0000 (12:14 +0100)]
ecore - proc env - fix values return NULL case - coverity
this fixes CID 1419857
Carsten Haitzler (Rasterman) [Fri, 17 Apr 2020 10:04:38 +0000 (11:04 +0100)]
evas cache - up padding just in case i was off by one
coverity was complaining but it's a false positive - it seems to not
realze the loadopts_append does nul terminate at the end.
Mike Blumenkrantz [Wed, 25 Mar 2020 14:07:56 +0000 (10:07 -0400)]
tests/elm: add image tests to verify internal object size is clamped to object size
ensure that this doesn't break again
ref 11587
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11599
Hermet Park [Fri, 17 Apr 2020 09:14:48 +0000 (18:14 +0900)]
canvas svg: fix memory leak.
free svg node commands & points data after usage.
@fix
Ali [Thu, 16 Apr 2020 15:51:31 +0000 (15:51 +0000)]
evas_textblock: prevent segfault if there are no style
```
#include <Elementary.h>
EAPI_MAIN int
elm_main(int argc EINA_UNUSED, char **argv EINA_UNUSED)
{
Evas_Object *win, *textblock;
elm_policy_set(ELM_POLICY_QUIT, ELM_POLICY_QUIT_LAST_WINDOW_CLOSED);
win = elm_win_util_standard_add("", "");
elm_win_autodel_set(win, EINA_TRUE);
textblock = evas_object_textblock_add(win);
evas_object_resize(textblock, 360, 360);
evas_object_show(textblock);
evas_object_textblock_text_markup_set(textblock, "<b>b</b>");
evas_object_resize(win, 360, 360);
evas_object_show(win);
elm_run();
return 0;
}
ELM_MAIN()
```
this application will crash.
Any font format specified in text, if there are now style will cause the crash.
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Stefan Schmidt <stefan@datenfreihafen.org>
Differential Revision: https://phab.enlightenment.org/D11686