platform/upstream/glibc.git
17 years ago[BZ #2526, BZ #3138, BZ #3143]
Ulrich Drepper [Tue, 12 Sep 2006 11:44:01 +0000 (11:44 +0000)]
[BZ #2526, BZ #3138, BZ #3143]

2006-09-12  Jakub Jelinek  <jakub@redhat.com>
[BZ #2526]
* README.libm: Fix a thinko in sqrt algorithm description.

[BZ #3143]
* manual/string.texi (argz_delete): Fix prototype.
Patch by <alpt@freaknet.org>.

2006-08-26  Joseph Myers  <joseph@codesourcery.com>

[BZ #3138]
* io/test-lfs.c (do_prepare): Give name_len type size_t.
* io/tst-fcntl.c (do_prepare): Likewise.
* posix/tst-exec.c (do_prepare): Likewise.
* posix/tst-preadwrite.c (do_prepare): Likewise.
* posix/tst-spawn.c (do_prepare): Likewise.
* posix/tst-truncate.c (do_prepare): Likewise.
* rt/tst-aio.c (do_prepare): Likewise.
* rt/tst-aio64.c (do_prepare): Likewise.
* stdlib/test-canon2.c (do_prepare): Give test_dir_len type
size_t.

17 years ago[BZ #2821] cvs/fedora-glibc-20060910T1832
Ulrich Drepper [Sat, 9 Sep 2006 16:56:29 +0000 (16:56 +0000)]
[BZ #2821]

* time/mktime.c (guess_time_tm): Fix overflow detection.
* time/Makefile (tests): Add bug-mktime1.
* time/bug-mktime1.c: New file.

17 years ago[BZ #3189]
Ulrich Drepper [Sat, 9 Sep 2006 16:22:01 +0000 (16:22 +0000)]
[BZ #3189]

..
[BZ #3189, #3188]
(mremap): Likewise.

17 years ago[BZ #3189]
Ulrich Drepper [Sat, 9 Sep 2006 16:18:28 +0000 (16:18 +0000)]
[BZ #3189]

2006-09-09  Ulrich Drepper  <drepper@redhat.com>
[BZ #3189]
* misc/sys/mman.h (remap_file_pages): Make available for _GNU_SOURCE.

17 years ago[BZ #1006]
Ulrich Drepper [Sat, 9 Sep 2006 11:21:48 +0000 (11:21 +0000)]
[BZ #1006]

* sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela):
Ensure relocation doesn't clobber any bits outside of the
immediate field for R_SPARC_TLS_LE_HIX22, R_SPARC_WDISP30,
R_SPARC_HI22 and R_SPARC_H44.

17 years ago[BZ #3123]
Ulrich Drepper [Fri, 8 Sep 2006 10:41:17 +0000 (10:41 +0000)]
[BZ #3123]

2006-09-08  Ulrich Drepper  <drepper@redhat.com>
[BZ #3123]
* sysdeps/pthread/pthread_cond_wait.c (__condvar_cleanup): Don't
increment WAKEUP_SEQ if this would increase the value beyond TOTAL_SEQ.
* sysdeps/unix/sysv/linux/i386/i486/pthread_cond_wait.c: Likewise.
* sysdeps/unix/sysv/linux/i386/i486/pthread_cond_timedwait.c: Likewise.
* sysdeps/unix/sysv/linux/x86_64/pthread_cond_wait.c: Likewise.
* Makefile (tests): Add tst-cond22.
* tst-cond22.c: New file.

17 years ago[BZ #2775]
Ulrich Drepper [Thu, 7 Sep 2006 16:06:54 +0000 (16:06 +0000)]
[BZ #2775]

* malloc/malloc.c (sYSMALLOc): Only call grow_heap if
(long) (MINSIZE + nb - old_size) is positive.

* malloc/arena.c (grow_heap): When growing bail even if new_size
is negative.

17 years ago[BZ #3155]
Ulrich Drepper [Thu, 7 Sep 2006 13:50:31 +0000 (13:50 +0000)]
[BZ #3155]

2006-09-07  Jakub Jelinek  <jakub@redhat.com>
[BZ #3155]
* sysdeps/powerpc/powerpc32/fpu/s_lrint.S (__lrint): Don't access
stack below r1.

* posix/regex_internal.c (re_string_reconstruct): Handle
offset < pstr->valid_raw_len && pstr->offsets_needed case.
Ensure no bytes read before raw_mbs array.  Pass a saved copy of
pstr->valid_len - 1 rather than pstr->valid_raw_len - 1 to
re_string_context_at.
* posix/Makefile: Add rules to build and run bug-regex26 test.
* posix/bug-regex26.c: New test.

* dlfcn/Makefile (LDLIBS-bug-atexit3-lib.so): Add ld.so.

17 years ago* locale/programs/ld-collate.c (collate_read): Goto sym_equiv_free cvs/fedora-glibc-20060907T0853
Ulrich Drepper [Wed, 6 Sep 2006 16:51:47 +0000 (16:51 +0000)]
* locale/programs/ld-collate.c (collate_read): Goto sym_equiv_free

rather than col_sym_free.  Move seqp declaration earlier.

* resolv/gai_suspend.c (gai_suspend): Make sure result is initialized.

17 years ago[BZ #3124]
Ulrich Drepper [Tue, 5 Sep 2006 17:18:23 +0000 (17:18 +0000)]
[BZ #3124]

2006-09-05  Ulrich Drepper  <drepper@redhat.com>
[BZ #3124]
* descr.h (struct pthread): Add parent_cancelhandling.
* sysdeps/pthread/createthread.c (create_thread): Pass parent
cancelhandling value to child.
* pthread_create.c (start_thread): If parent thread was canceled
reset the SIGCANCEL mask.
* Makefile (tests): Add tst-cancel25.
* tst-cancel25.c: New file.

17 years ago* nscd/initgrcache.c (addinitgroupsX): Move any_success
Ulrich Drepper [Tue, 5 Sep 2006 15:33:13 +0000 (15:33 +0000)]
* nscd/initgrcache.c (addinitgroupsX): Move any_success

decl before first goto out.

17 years ago2006-03-04 Jakub Jelinek <jakub@redhat.com>
Ulrich Drepper [Tue, 5 Sep 2006 14:49:19 +0000 (14:49 +0000)]
2006-03-04  Jakub Jelinek  <jakub@redhat.com>

            Roland McGrath  <roland@redhat.com>

* sysdeps/unix/sysv/linux/i386/lowlevellock.h
(LLL_STUB_UNWIND_INFO_START, LLL_STUB_UNWIND_INFO_END,
LLL_STUB_UNWIND_INFO_3, LLL_STUB_UNWIND_INFO_4): Define.
(lll_mutex_lock, lll_robust_mutex_lock, lll_mutex_cond_lock,
lll_robust_mutex_cond_lock, lll_mutex_timedlock,
lll_robust_mutex_timedlock, lll_mutex_unlock,
lll_robust_mutex_unlock, lll_lock, lll_unlock): Use them.
Add _L_*_ symbols around the subsection.
* sysdeps/unix/sysv/linux/i386/i486/lowlevellock.S: Add unwind info.
* sysdeps/unix/sysv/linux/i386/i486/lowlevelrobustlock.S: Likewise.

2006-03-03  Jakub Jelinek  <jakub@redhat.com>
            Roland McGrath  <roland@redhat.com>

* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h
(LLL_STUB_UNWIND_INFO_START, LLL_STUB_UNWIND_INFO_END,
LLL_STUB_UNWIND_INFO_5, LLL_STUB_UNWIND_INFO_6): Define.
(lll_mutex_lock, lll_robust_mutex_lock, lll_mutex_cond_lock,
lll_robust_mutex_cond_lock, lll_mutex_timedlock,
lll_robust_mutex_timedlock, lll_mutex_unlock,
lll_robust_mutex_unlock, lll_lock, lll_unlock): Use them.
Add _L_*_ symbols around the subsection.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.S: Add unwind info.
* sysdeps/unix/sysv/linux/x86_64/lowlevelrobustlock.S: Likewise.

17 years ago* Makerules (shlib.lds): If have-hash-style, put .hash section cvs/fedora-glibc-20060905T0633
Ulrich Drepper [Tue, 5 Sep 2006 02:02:55 +0000 (02:02 +0000)]
* Makerules (shlib.lds): If have-hash-style, put .hash section

at the end of the RO segment.

2006-09-04  Ulrich Drepper  <drepper@redhat.com>

* elf/do-lookup.h (do_lookup_x): Initialize symidx in case the new
style hash table format is used.

2006-09-04  Jakub Jelinek  <jakub@redhat.com>

17 years ago* resolv/res_mkquery.c (res_nmkquery): Set hp->id to statp->id after
Ulrich Drepper [Mon, 4 Sep 2006 18:00:58 +0000 (18:00 +0000)]
* resolv/res_mkquery.c (res_nmkquery): Set hp->id to statp->id after

randomization rather than before.
* resolv/res_init.c (res_randomid): Don't call gettimeofday here.

17 years ago* dlfcn/Makefile (LDLIBS-bug-atexit3-lib.so): Add cvs/fedora-glibc-20060831T1812
Ulrich Drepper [Thu, 31 Aug 2006 17:16:11 +0000 (17:16 +0000)]
* dlfcn/Makefile (LDLIBS-bug-atexit3-lib.so): Add

ld.so.

* malloc/malloc.c (_int_malloc): Use full list insert and not
shortcut which assumes the list is empty for large requests
too.

* elf/tst-addr1.c (do_test): Allow i.dli_sname "_IO_printf".

17 years ago* pthread_rwlock_trywrlock.c (__pthread_rwlock_trywrlock): Respect cvs/fedora-glibc-20060831T0640
Ulrich Drepper [Wed, 30 Aug 2006 19:11:05 +0000 (19:11 +0000)]
* pthread_rwlock_trywrlock.c (__pthread_rwlock_trywrlock): Respect

reader preference.
* sysdeps/pthread/pthread_rwlock_timedwrlock.c
(pthread_rwlock_timedwrlock): Likewise.
* sysdeps/pthread/pthread_rwlock_wrlock.c (__pthread_rwlock_wrlock):
Likewise.

17 years ago* sysdeps/unix/sysv/linux/alpha/bits/fcntl.h (splice): Add offin
Ulrich Drepper [Wed, 30 Aug 2006 15:05:29 +0000 (15:05 +0000)]
* sysdeps/unix/sysv/linux/alpha/bits/fcntl.h (splice): Add offin

and offout arguments to the prototype.
* sysdeps/unix/sysv/linux/s390/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/powerpc/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/sparc/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/sh/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/i386/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/ia64/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/x86_64/bits/fcntl.h (splice): Likewise.
* sysdeps/unix/sysv/linux/syscalls.list (splice): Adjust args string.

17 years ago* elf/dl-load.c (_dl_init_paths): Expand DSTs.
Ulrich Drepper [Tue, 29 Aug 2006 01:44:27 +0000 (01:44 +0000)]
* elf/dl-load.c (_dl_init_paths): Expand DSTs.

17 years ago* elf/dl-open.c (dl_open_worker): Allow $LIB and $PLATFORM in
Ulrich Drepper [Mon, 28 Aug 2006 22:57:23 +0000 (22:57 +0000)]
* elf/dl-open.c (dl_open_worker): Allow $LIB and $PLATFORM in

dlopen parameters.

17 years ago* inet/getnameinfo.c (getnameinfo): For AF_INET, check errno cvs/fedora-glibc-20060828T1903
Ulrich Drepper [Mon, 28 Aug 2006 16:24:10 +0000 (16:24 +0000)]
* inet/getnameinfo.c (getnameinfo): For AF_INET, check errno

only if herrno is NETDB_INTERNAL.  Handle errors other than
ERANGE outside of the loops, handle TRY_AGAIN.

* locale/programs/ld-ctype.c (translit_flatten): Issue error
if other's ctype category was missing.
* locale/programs/ld-collate.c (collate_read): Return if
copy_locale's collate category is missing.

17 years ago[BZ #2684]
Ulrich Drepper [Mon, 28 Aug 2006 00:58:32 +0000 (00:58 +0000)]
[BZ #2684]

2006-08-27  Ulrich Drepper  <drepper@redhat.com>
[BZ #2684]
* malloc/malloc.c (public_rEALLOc): Try harder by using other
arenas if allocation failed.
Patch mostly by Jan Edler <jan.edler@indexengines.com>.

17 years ago* malloc/malloc.c (bin_at): Rewrite to be more clear and to not
Ulrich Drepper [Sun, 27 Aug 2006 04:38:05 +0000 (04:38 +0000)]
* malloc/malloc.c (bin_at): Rewrite to be more clear and to not

waste bins[0..1].
(malloc_state): Reduce bins size by 2.
(_int_malloc): Fix test for large enough buffer for early termination.
When no unsorted block matches perfectly and an exiting block has
to be split, use full list insert and not shortcut which assumes
the list is empty.

17 years ago* locale/programs/ld-ctype.c (ctype_read): Better patch for read
Ulrich Drepper [Sat, 26 Aug 2006 21:41:37 +0000 (21:41 +0000)]
* locale/programs/ld-ctype.c (ctype_read): Better patch for read

failure.

17 years ago* sysdeps/unix/sysv/linux/libc_pthread_init.c (freeres_libpthread):
Ulrich Drepper [Fri, 25 Aug 2006 13:29:19 +0000 (13:29 +0000)]
* sysdeps/unix/sysv/linux/libc_pthread_init.c (freeres_libpthread):

Only define ifdef SHARED.

17 years ago* locale/programs/ld-ctype.c (ctype_read): If CTYPE is NULL, don't cvs/fedora-glibc-20060825T0639
Ulrich Drepper [Fri, 25 Aug 2006 00:39:53 +0000 (00:39 +0000)]
* locale/programs/ld-ctype.c (ctype_read): If CTYPE is NULL, don't

do anything.

17 years ago* sysdeps/generic/ldsodefs.h (DL_ADDR_SYM_MATCH): For undefined
Ulrich Drepper [Thu, 24 Aug 2006 20:29:43 +0000 (20:29 +0000)]
* sysdeps/generic/ldsodefs.h (DL_ADDR_SYM_MATCH): For undefined

symbol require exact match (these are PLTs).
* sysdeps/unix/sysv/linux/powerpc/powerpc64/ldsodefs.h
(_dl_ppc64_addr_sym_match): Likewise.

17 years ago[BZ #2683]
Ulrich Drepper [Thu, 24 Aug 2006 20:21:08 +0000 (20:21 +0000)]
[BZ #2683]

2006-08-24  Ulrich Drepper  <drepper@redhat.com>
[BZ #2683]
* elf/dl-addr.c (_dl_addr): Don't ignore all undefined symbols.
If symbol has a value use it.
* elf/tst-dladdr1.c: New file.
* elf/Makefile: Add rules to build and run tst-addr1.

17 years ago* malloc/malloc.c (sYSMALLOc): Avoid infinite loop if MMAP
Ulrich Drepper [Thu, 24 Aug 2006 17:30:37 +0000 (17:30 +0000)]
* malloc/malloc.c (sYSMALLOc): Avoid infinite loop if MMAP

keeps failing and heap growth or new heap creation isn't
successful either.
* malloc/tst-malloc.c (main): Add new tests.

17 years ago[BZ #2734]
Ulrich Drepper [Thu, 24 Aug 2006 07:09:54 +0000 (07:09 +0000)]
[BZ #2734]

2006-08-24  Ulrich Drepper  <drepper@redhat.com>
[BZ #2734]
* sysdeps/i386/bits/byteswap.h (__bswap_32): Use same conditions
as in the x86-64 code to use bswap.

17 years ago[BZ #2680]
Ulrich Drepper [Thu, 24 Aug 2006 06:50:32 +0000 (06:50 +0000)]
[BZ #2680]

17 years ago* posix/unistd.h (getlogin_r): Condition on __USE_POSIX199506, not
Ulrich Drepper [Thu, 24 Aug 2006 06:48:22 +0000 (06:48 +0000)]
* posix/unistd.h (getlogin_r): Condition on __USE_POSIX199506, not

__USE_UNIX98.
* posix/bits/unistd.h: Likewise.

17 years ago* allocatestack.c (queue_stack): Move freeing of surplus stacks to...
Ulrich Drepper [Wed, 23 Aug 2006 17:47:19 +0000 (17:47 +0000)]
* allocatestack.c (queue_stack): Move freeing of surplus stacks to...

(free_stacks): ...here.
(__free_stack_cache): New function.
* pthreadP.h: Declare __free_stack_cache.
* sysdeps/pthread/pthread-functions.h (pthread_functions): Add
ptr_freeres.
* init.c (pthread_functions): Initialize ptr_freeres.
* sysdeps/unix/sysv/linux/libc_pthread_init.c (freeres_libptread):
New freeres function.

17 years ago* locales/nn_NO: Copy more categories from nb_NO.
Ulrich Drepper [Tue, 22 Aug 2006 17:06:51 +0000 (17:06 +0000)]
* locales/nn_NO: Copy more categories from nb_NO.

17 years ago[BZ #2751] cvs/fedora-glibc-20060822T0706
Ulrich Drepper [Tue, 22 Aug 2006 06:47:33 +0000 (06:47 +0000)]
[BZ #2751]

2006-05-15  Mike Frysinger  <vapier@gentoo.org>
[BZ #2751]
* string/strchr.c: Add cast to avoid warning.

17 years agoplatforms define as 512K. For 64-bit platforms as 32MB. The lower
Ulrich Drepper [Tue, 22 Aug 2006 06:42:35 +0000 (06:42 +0000)]
platforms define as 512K.  For 64-bit platforms as 32MB.  The lower

17 years ago* malloc/malloc.c (DEFAULT_MMAP_THRESHOLD_MAX): For 32-bit
Ulrich Drepper [Tue, 22 Aug 2006 06:19:12 +0000 (06:19 +0000)]
* malloc/malloc.c (DEFAULT_MMAP_THRESHOLD_MAX): For 32-bit

platforms define as 1MB.  For 64-bit platforms as 32MB.  The lower
limit is needed to avoid the exploding of the address space
requirement for secondary heaps.
* malloc/arena.c (HEAP_MAX_SIZE): Define using
DEFAULT_MMAP_THRESHOLD_MAX if it is defined.

17 years ago[BZ #3018]
Ulrich Drepper [Mon, 21 Aug 2006 21:06:35 +0000 (21:06 +0000)]
[BZ #3018]

2006-07-30  Joseph S. Myers  <joseph@codesourcery.com>
[BZ #3018]
* Makerules (depfiles): Handle extra-test-objs the same as
extra-objs.
(common-mostlyclean): Likewise.
* dlfcn/Makefile (extra-objs): Add modules to extra-test-objs
instead.
* elf/Makefile (extra-objs): Likewise.
* stdlib/Makefile (extra-objs): Likewise.

17 years ago[BZ #3044]
Ulrich Drepper [Mon, 21 Aug 2006 20:03:52 +0000 (20:03 +0000)]
[BZ #3044]

2006-08-14  Eric Blake
<ebb9@byu.net>

[BZ #3044]
* misc/error.h: Assume C89 or better.
* misc/error.c: Likewise.

17 years ago[BZ #3040]
Ulrich Drepper [Mon, 21 Aug 2006 19:44:56 +0000 (19:44 +0000)]
[BZ #3040]

2006-08-21  Ulrich Drepper  <drepper@redhat.com>
[BZ #3040]
* sysdeps/unix/sysv/linux/openat.c: Fix compilation if
__ASSUME_ATFCTS is defined.

17 years ago* sysdeps/unix/sysv/linux/bits/posix_opt.h: Define
Ulrich Drepper [Sun, 20 Aug 2006 19:37:08 +0000 (19:37 +0000)]
* sysdeps/unix/sysv/linux/bits/posix_opt.h: Define

_XOPEN_REALTIME_THREADS.

17 years ago* malloc/malloc.c (_int_malloc): Limit number of unsorted blocks
Ulrich Drepper [Sat, 19 Aug 2006 22:34:27 +0000 (22:34 +0000)]
* malloc/malloc.c (_int_malloc): Limit number of unsorted blocks

to sort in each call.

17 years ago* nis/nss_nis/nis-service.c (internal_nis_getservent_r): . If map
Ulrich Drepper [Sat, 19 Aug 2006 18:37:10 +0000 (18:37 +0000)]
* nis/nss_nis/nis-service.c (internal_nis_getservent_r): . If map

is empty simply return and use next service.
* nis/nss_nis/nis-rpc.c (internal_nis_getrpcent_r): Likewise.

17 years ago* locale/programs/charmap.c (charmap_read): Add new parameter. It
Ulrich Drepper [Sat, 19 Aug 2006 17:54:05 +0000 (17:54 +0000)]
* locale/programs/charmap.c (charmap_read): Add new parameter.  It

tells us when not finding a charmap file is an error.
* locale/programs/charmap.h: Adjust charmap_read prototype.
* iconv/iconv_prog.c (main): Tell charmap_read it's no error if we
cannot find a charmap.
* locale/programs/localedef.c (main): Adjust charmap_read call.

17 years ago[BZ #3034]
Ulrich Drepper [Sat, 19 Aug 2006 15:46:08 +0000 (15:46 +0000)]
[BZ #3034]

2006-08-19  Ulrich Drepper  <drepper@redhat.com>
[BZ #3034]
* locales/ml_IN (abmon): Fix June entry.
* locales/bn_IN: (abday): Fix Tuesday entry.
(day): Likewise.
(abmon): Fix January and February entries.
(mon): Likewise.
Patches by Mayank Jain <majain@redhat.com>.

17 years ago* sysdeps/unix/sysv/linux/clock_settime.c (INTERNAL_VSYSCALL): Use cvs/fedora-glibc-20060815T2033
Ulrich Drepper [Tue, 15 Aug 2006 13:41:04 +0000 (13:41 +0000)]
* sysdeps/unix/sysv/linux/clock_settime.c (INTERNAL_VSYSCALL): Use

HAVE_CLOCK_GETRES_VSYSCALL as guard macro rather than
HAVE_CLOCK_GETTIME_VSYSCALL.
(maybe_syscall_settime_cpu): Use plain INTERNAL_VSYSCALL here.

17 years ago* sysdeps/unix/sysv/linux/sparc/sparc64/pause.c: Use cvs/fedora-glibc-20060815T0533
Ulrich Drepper [Tue, 15 Aug 2006 05:27:55 +0000 (05:27 +0000)]
* sysdeps/unix/sysv/linux/sparc/sparc64/pause.c: Use

sysdeps/posix/pause.c implementation instead.

2006-08-09  Jakub Jelinek  <jakub@redhat.com>

* sysdeps/unix/nice.c (nice): Transform EACCES errno from setpriority
to EPERM.

17 years ago* sysdeps/powerpc/powerpc32/dl-trampoline.S (_dl_runtime_resolve):
Ulrich Drepper [Mon, 14 Aug 2006 23:11:18 +0000 (23:11 +0000)]
* sysdeps/powerpc/powerpc32/dl-trampoline.S (_dl_runtime_resolve):

Don't clobber caller's LRSAVE.
(_dl_prof_resolve): Likewise.

17 years ago[BZ #1996]
Ulrich Drepper [Mon, 14 Aug 2006 22:16:14 +0000 (22:16 +0000)]
[BZ #1996]

2006-08-14  Ulrich Drepper  <drepper@redhat.com>
[BZ #1996]
* libio/memstream.c (open_memstream): Allocate initial buffer with
calloc.
* libio/wmemstream.c (open_wmemstream): Likewise.
* libio/strops.c: Pretty printing.
(_IO_str_overflow): Clear uninitialized part of the new buffer.
(enlarge_userbuf): New function.
(_IO_str_seekoff): Call it if seek position is larger than current
buffer.
* libio/wstrops.c: Likewise.
* libio/vasprintf.c: Add comment as to why we do not have to use
calloc instead of malloc to allocate initial buffer.
* libio/Makefile (tests): Add bug-memstream1 and bug-wmemstream1.
* libio/bug-memstream1.c: New file.
* libio/bug-wmemstream1.c: New file.

17 years ago* libio/wstrops.c: Remove dead macro definitions and comments.
Ulrich Drepper [Mon, 14 Aug 2006 04:44:32 +0000 (04:44 +0000)]
* libio/wstrops.c: Remove dead macro definitions and comments.

* libio/strops.c: Likewise.

17 years ago[BZ #2764]
Ulrich Drepper [Mon, 14 Aug 2006 03:59:19 +0000 (03:59 +0000)]
[BZ #2764]

2006-08-13  Ulrich Drepper  <drepper@redhat.com>
[BZ #2764]
* login/utmpname.c (__utmpname): Remove unnecessary test.

17 years ago[BZ #935]
Ulrich Drepper [Sun, 13 Aug 2006 20:17:02 +0000 (20:17 +0000)]
[BZ #935]

2006-08-13  Ulrich Drepper  <drepper@redhat.com>
[BZ #935]
* SUPPORTED (SUPPORTED-LOCALES): Add fy_NL.
* locales/fy_NL: New file.

17 years ago[BZ #2832, BZ #2987]
Ulrich Drepper [Sun, 13 Aug 2006 08:21:10 +0000 (08:21 +0000)]
[BZ #2832, BZ #2987]

2006-06-08  Joseph Myers  <jsm28@gcc.gnu.org>
[BZ #2832]
* math/gen-libm-test.pl (clean_up_number): Do not remove trailing
0s from integers.

2006-08-13  Ulrich Drepper  <drepper@redhat.com>

[BZ #2987]
* sysdeps/unix/sysv/linux/clock_settime.c: Add code to use syscall
for CPU clocks.
* sysdeps/unix/clock_settime.c: Add support for platform-specific
setting of CPU clocks.

17 years ago[BZ #3034]
Ulrich Drepper [Sun, 13 Aug 2006 06:38:52 +0000 (06:38 +0000)]
[BZ #3034]

17 years ago* locales/pa_IN (day): Fix spelling of Saturday.
Ulrich Drepper [Sun, 13 Aug 2006 05:57:40 +0000 (05:57 +0000)]
* locales/pa_IN (day): Fix spelling of Saturday.

* locales/or_IN (mon): Fix spelling of May.
* locales/ml_IN (day): Fix spelling of Sunday, Monday, Wednesday.
(abmon): Fix spelling of March to October.
(mon): Fix spelling of March, April, June, August to December.
Patches by Mayank Jain <majain@redhat.com>.

17 years ago[BZ #2843]
Ulrich Drepper [Sun, 13 Aug 2006 01:56:09 +0000 (01:56 +0000)]
[BZ #2843]

2006-08-12  Ulrich Drepper  <drepper@redhat.com>
[BZ #2843]
* pthread_join.c (pthread_join): Account for self being canceled
when checking for deadlocks.
* tst-join5.c: Cleanups.  Allow to be used in tst-join6.
(tf1): Don't print anything after pthread_join returns, this would be
another cancellation point.
(tf2): Likewise.
* tst-join6.c: New file.
* Makefile (tests): Add tst-join6.

17 years ago[BZ #2841]
Ulrich Drepper [Sat, 12 Aug 2006 21:23:54 +0000 (21:23 +0000)]
[BZ #2841]

2006-06-23  Paul Eggert  <eggert@cs.ucla.edu>
[BZ #2841]
* sysdeps/generic/stdint.h (UINT8_C, UINT16_C): Don't append 'U',
since C99 requires the result to promote to 'int' when uint_least8_t
and uint_least16_t promote to 'int'.

17 years ago[BZ #3013]
Ulrich Drepper [Sat, 12 Aug 2006 20:19:55 +0000 (20:19 +0000)]
[BZ #3013]

* locale/programs/ld-ctype.c (ctype_output): Adjust alignments, fix
lenght of one output field, correct bitmask creation.
* locale/programs/ld-time.c: Add alignment.

17 years ago[BZ #2997]
Ulrich Drepper [Sat, 12 Aug 2006 17:58:16 +0000 (17:58 +0000)]
[BZ #2997]

2006-08-12  Ulrich Drepper  <drepper@redhat.com>
[BZ #2997]
* misc/error.c: Add space between program name and message if file
name is missing.

17 years ago[BZ #2998]
Ulrich Drepper [Sat, 12 Aug 2006 17:49:50 +0000 (17:49 +0000)]
[BZ #2998]

2006-08-03  Eric Blake
<ebb9@byu.net>

[BZ #2998]
* misc/error.c (error_tail) [_LIBC]: Avoid invalid free.

17 years ago* malloc/memusagestat.c: Silence warnings. cvs/fedora-glibc-20060810T0627
Ulrich Drepper [Wed, 9 Aug 2006 22:21:20 +0000 (22:21 +0000)]
* malloc/memusagestat.c: Silence warnings.

17 years ago* malloc/malloc.c: Dynamically size mmap treshold if the program
Ulrich Drepper [Wed, 9 Aug 2006 21:51:56 +0000 (21:51 +0000)]
* malloc/malloc.c: Dynamically size mmap treshold if the program

frees mmaped blocks.
Patch by Valerie Henson and Arjan van de Ven.

17 years ago* sysdeps/unix/sysv/linux/ia64/bits/fcntl.h (O_DIRECT): Protect with
Ulrich Drepper [Tue, 8 Aug 2006 18:29:16 +0000 (18:29 +0000)]
* sysdeps/unix/sysv/linux/ia64/bits/fcntl.h (O_DIRECT): Protect with

__USE_GNU.

17 years ago* stdlib/strtol_l.c (__strtol_ul_max_tab, __strtol_ul_rem_tab,
Ulrich Drepper [Tue, 8 Aug 2006 15:51:48 +0000 (15:51 +0000)]
* stdlib/strtol_l.c (__strtol_ul_max_tab, __strtol_ul_rem_tab,

__strtol_ull_max_tab, __strtol_ull_rem_tab): Declare.
(DEF): Don't put the var into .gnu.linkonce.r.* section.
Only provide var definitions in strtol_l (or for *ull*
in strtoll_l).

* stdio-common/bug16.c (tests): New array.
(do_tests): Allow the first hexadecimal digit
to be 1, 2, 4 or 8.  Do 3 additional tests.

* sysdeps/s390/fpu/libm-test-ulps: Update.

* sysdeps/unix/sysv/linux/s390/s390-32/fchownat.c (fchownat): Use
fchownat syscall if available.
* sysdeps/unix/sysv/linux/powerpc/fchownat.c (fchownat): Likewise.
* sysdeps/unix/sysv/linux/sh/fchownat.c (fchownat): Likewise.
* sysdeps/unix/sysv/linux/i386/fchownat.c (fchownat): Likewise.

(rec_dirsearch) [case HIGHER_NAME]: Correctly size ndomain array.

17 years ago* nis/nis_xdr.c: Avoid some function calls.
Ulrich Drepper [Tue, 8 Aug 2006 00:39:32 +0000 (00:39 +0000)]
* nis/nis_xdr.c: Avoid some function calls.

17 years ago2006-08-07 Jakub Jelinek <jakub@redhat.com> cvs/fedora-glibc-20060807T1859
Ulrich Drepper [Mon, 7 Aug 2006 17:40:53 +0000 (17:40 +0000)]
2006-08-07  Jakub Jelinek  <jakub@redhat.com>

            Ulrich Drepper  <drepper@redhat.com>

* nis/nis_call.c (rec_dirsearch) [case LOWER_NAME]: Don't take
short cut if only one name component is stripped away.

17 years ago* nis/nis_call.c: Minor cleanups throughout.
Ulrich Drepper [Mon, 7 Aug 2006 16:03:46 +0000 (16:03 +0000)]
* nis/nis_call.c: Minor cleanups throughout.

(rec_dirsearch) [HIGHER_NAME]: Correctly size ndomain array.
(first_shoot): Add search_parent_first parameter.  Only if it is set
search parent server first.
If directory for table found through cold start cache is not the same
as referenced in the cache, don't use it.
(__nisfind_server): Take additional parameter.  Pass it on to
first_shoot.
(__prepare_niscall): Adjust __nisfind_server call.
* nis/rpcsvc/nislib.h: Adjust __nisfind_server prototype.
* nis/nis_table.c: Adjust __nisfind_server call.
* nis/nis_lookup.c: Likewise.
(nis_lookup): Don't loop endlessly if name is reduced to ".".

17 years ago[BZ #2182]
Ulrich Drepper [Thu, 3 Aug 2006 20:36:43 +0000 (20:36 +0000)]
[BZ #2182]

* math/s_cacosh.c: Return values from positive branch.
* math/s_cacoshf.c: Likewise.
* math/s_cacoshl.c: Likewise.

* sysvipc/msgrcv.c: Likewise.
* include/sys/msg.h: Likewise.

17 years ago[BZ #2098]
Ulrich Drepper [Thu, 3 Aug 2006 18:39:04 +0000 (18:39 +0000)]
[BZ #2098]

element for NEWGROUPS.
[BZ #2098]

17 years ago[BZ #2883]
Ulrich Drepper [Thu, 3 Aug 2006 15:41:32 +0000 (15:41 +0000)]
[BZ #2883]

* sysvipc/sys/msg.h: Change return value to ssize_t.
* sysdeps/unix/sysv/linux/msgrcv.c: Likewise.

17 years ago (getgrouplist): Simplify code a bit. Don't allocate one additional
Ulrich Drepper [Thu, 3 Aug 2006 15:31:32 +0000 (15:31 +0000)]
(getgrouplist): Simplify code a bit.  Don't allocate one additional
element on NEWGROUPS.

17 years ago* grp/initgroups.c (internal_getgrouplist): Remove unnecessary
Ulrich Drepper [Thu, 3 Aug 2006 15:26:02 +0000 (15:26 +0000)]
* grp/initgroups.c (internal_getgrouplist): Remove unnecessary

test introduced in patch for bz #661.
(getgrouplist): Simplify code a bit.

17 years ago[BZ #2908]
Ulrich Drepper [Thu, 3 Aug 2006 09:36:43 +0000 (09:36 +0000)]
[BZ #2908]

* stdio-common/printf_fphex.c (__printf_fphex): When rounding up
'f', use '1' as leading digit not '\1'.
* stdio-common/Makefile (tests): Add bug16.
* stdio-common/bug16.c: New file.

[BZ #2914]
* sysdeps/unix/sysv/linux/gethostid.c: Don't define OLD_HOSTIDFILE
and don't try to open it.  The patch introducing the macro
contained a bug and used the same file name as the new file
instead of using /var/adm/hostid.  Nobody complaint so I'm taking
this out completely.

[BZ #2926]
* assert/assert.h: Move cast to void inside ?: to quiet gcc.
Patch by Jerry James <Jerry.James@usu.edu>.

17 years agoDon't define OLD_HOSTIDFILE and don't try to open it. The patch introducing the...
Ulrich Drepper [Thu, 3 Aug 2006 08:49:48 +0000 (08:49 +0000)]
Don't define OLD_HOSTIDFILE and don't try to open it.  The patch introducing the macro contained a bug and used the same file name as the new file instead of using /var/adm/hostid.  Nobody complaint so I'm taking this out completely.

17 years agotypotypo
Roland McGrath [Thu, 3 Aug 2006 08:39:32 +0000 (08:39 +0000)]
typotypo

* hurd/getdport.c (__getdport): Don't return EBADF; instead set

17 years agoMove cast to void inside ?: to quiet gcc.
Ulrich Drepper [Thu, 3 Aug 2006 08:30:09 +0000 (08:30 +0000)]
Move cast to void inside ?: to quiet gcc.

17 years ago[BZ #2978]
Ulrich Drepper [Thu, 3 Aug 2006 08:17:20 +0000 (08:17 +0000)]
[BZ #2978]

2006-08-03  Ulrich Drepper  <drepper@redhat.com>
* rt/Makefile (tests): Add tst-clock2.
* rt/tst-clock2.c: New file.

[BZ #2978]
* resolv/gai_notify.c (__gai_notify_only): Copy memory for thread
function and its parameters and pass it to new thread.
(__gai_notify): Add support for alternative waiting for completion.
* resolv/gai_suspend.c (gai_suspend): Add support for alternative
waiting for completion.
* resolv/getaddrinfo_a.c: Likewise.
* resolv/gai_misc.h (struct waitlist): Don't add cond if alternative
waiting for completion is used.
* resolv/gai_misc.c: Allow overwriting code to start helper thread.
* resolv/gai_cancel.c: Include <gai_misc.h> not "gai_misc.h".
* resolv/gai_error.c: Likewise.
* resolv/gai_sigqueue.c: Likewise.

* hurd/getdport.c (__detdport): Don't return EBADF; instead set
errno to EBADF and return MACH_PORT_NULL.
* posix/Makefile (CFLAGS-waitid.c): Add -fasynchronous-unwind-tables.

17 years agoNPTL specific definitions for async name lookup.
Ulrich Drepper [Thu, 3 Aug 2006 07:54:18 +0000 (07:54 +0000)]
NPTL specific definitions for async name lookup.

17 years ago2006-08-02 Thomas Schwinge <tschwinge@gnu.org>
Roland McGrath [Thu, 3 Aug 2006 01:19:07 +0000 (01:19 +0000)]
2006-08-02  Thomas Schwinge  <tschwinge@gnu.org>

        * hurd/getdport.c (__detdport): Don't return EBADF; instead set
        errno to EBADF and return MACH_PORT_NULL.

17 years ago2006-08-02 Thomas Schwinge <tschwinge@gnu.org>
Roland McGrath [Thu, 3 Aug 2006 01:18:36 +0000 (01:18 +0000)]
2006-08-02  Thomas Schwinge  <tschwinge@gnu.org>

        * hurd/getdport.c (__detdport): Don't return EBADF; instead set
        errno to EBADF and return MACH_PORT_NULL.

17 years ago(_dl_addr): Finish fixup after renaming. cvs/fedora-glibc-20060802T1808
Ulrich Drepper [Wed, 2 Aug 2006 17:05:55 +0000 (17:05 +0000)]
(_dl_addr): Finish fixup after renaming.

17 years ago[BZ #2980] cvs/fedora-glibc-20060802T1650
Ulrich Drepper [Wed, 2 Aug 2006 16:45:53 +0000 (16:45 +0000)]
[BZ #2980]

2006-06-23  Joseph Myers  <joseph@codesourcery.com>
[BZ #2980]
* posix/Makefile (CFLAGS-waitid.c): Add
-fasynchronous-unwind-tables.

2006-08-02  Ulrich Drepper  <drepper@redhat.com>

* elf/dl-addr.c (_dl_addr): If GNU-style hash tables are present,
walk them instead of the symbol table.

17 years ago* locales/es_NI: Define real t_fmt_ampm and am_pm.
Ulrich Drepper [Wed, 2 Aug 2006 02:19:14 +0000 (02:19 +0000)]
* locales/es_NI: Define real t_fmt_ampm and am_pm.

* locales/es_PE: Likewise.

17 years ago* nscd/initgrcache.c (addinitgroupsX): Judge successful lookups by
Ulrich Drepper [Wed, 2 Aug 2006 00:08:03 +0000 (00:08 +0000)]
* nscd/initgrcache.c (addinitgroupsX): Judge successful lookups by

status of NSS calls, not the number of returned entries.

17 years ago* sysdeps/unix/sysv/linux/syscalls.list: Remove add_key,
Ulrich Drepper [Tue, 1 Aug 2006 15:56:17 +0000 (15:56 +0000)]
* sysdeps/unix/sysv/linux/syscalls.list: Remove add_key,

request_key, keyctl.

17 years ago* sysdeps/unix/sysv/linux/Versions: Finally add add_key,
Ulrich Drepper [Tue, 1 Aug 2006 07:16:26 +0000 (07:16 +0000)]
* sysdeps/unix/sysv/linux/Versions: Finally add add_key,

request_key, and keyctl back.

17 years ago* sysdeps/unix/sysv/linux/dl-osinfo.h: Remove unnecessary include.
Ulrich Drepper [Tue, 1 Aug 2006 06:55:58 +0000 (06:55 +0000)]
* sysdeps/unix/sysv/linux/dl-osinfo.h: Remove unnecessary include.

that the directory is empty even on non-POSIX filesystems.

17 years ago* elf/tst-auditmod1.c: Fix typo in #error.
Ulrich Drepper [Tue, 1 Aug 2006 06:49:55 +0000 (06:49 +0000)]
* elf/tst-auditmod1.c: Fix typo in #error.

* elf/tst-auditmod1.c: Remove code for unsupported architectures.

17 years ago* iconvdata/run-iconv-test.sh: Run cmp in C locale.
Ulrich Drepper [Tue, 1 Aug 2006 06:46:18 +0000 (06:46 +0000)]
* iconvdata/run-iconv-test.sh: Run cmp in C locale.

17 years ago* stdlib/test-canon.c (do_test): Close fd before unlinking file so
Ulrich Drepper [Tue, 1 Aug 2006 06:40:11 +0000 (06:40 +0000)]
* stdlib/test-canon.c (do_test): Close fd before unlinking file so

that directory is empty even on non-POSIX filesystems.

17 years ago* elf/dl-open.c (dl_open_worker): Add branch prediction.
Ulrich Drepper [Mon, 31 Jul 2006 23:54:19 +0000 (23:54 +0000)]
* elf/dl-open.c (dl_open_worker): Add branch prediction.

17 years ago* nis/nss_compat/compat-grp.c: Avoid unnecessary setgrent calls into
Ulrich Drepper [Mon, 31 Jul 2006 23:34:45 +0000 (23:34 +0000)]
* nis/nss_compat/compat-grp.c: Avoid unnecessary setgrent calls into

the backend NSS module.  If backend setgrent call failed, don't have
internal_setgrent fail.  Just remember this until it is needed.
* nis/nss_compat/compat-pwd.c: Likewise.
* nis/nss_compat/compat-spwd.c: Likewise.

17 years agoAvoid unnecessary setXXent calls into the backend NSS module. If backend setXXent...
Ulrich Drepper [Mon, 31 Jul 2006 23:33:04 +0000 (23:33 +0000)]
Avoid unnecessary setXXent calls into the backend NSS module.  If backend setXXent call failed, don't have internal_setXXent fail.  Just remember this until it is needed.

17 years ago* sysdeps/unix/sysv/linux/ia64/sigsuspend.c: File removed. cvs/fedora-glibc-20060731T0706
Roland McGrath [Mon, 31 Jul 2006 05:58:51 +0000 (05:58 +0000)]
* sysdeps/unix/sysv/linux/ia64/sigsuspend.c: File removed.

* sysdeps/unix/sysv/linux/x86_64/sigsuspend.c: File removed.
* sysdeps/unix/sysv/linux/s390/s390-64/sigsuspend.c: File removed.
* sysdeps/unix/sysv/linux/sparc/sparc64/sigsuspend.c: File removed.

* sysdeps/unix/sysv/linux/not-cancel.h (pause_not_cancel): New macro.
(nanosleep_not_cancel): New macro.
(sigsuspend_not_cancel): new macro.
* sysdeps/unix/sysv/linux/sigsuspend.c [__ASSUME_REALTIME_SIGNALS]
(do_sigsuspend): Define as inline.
(__sigsuspend): Always use do_sigsuspend.
[! NO_CANCELLATION] (__sigsuspend_nocancel): New function.
* include/signal.h: Declare __sigsuspend_nocancel.
* sysdeps/posix/pause.c
[! NO_CANCELLATION] (__pause_nocancel): New function.

* include/unistd.h (__pause_nocancel): Add attribute_hidden.
* include/time.h (__nanosleep_nocancel): Likewise.

17 years ago2006-07-30 Roland McGrath <roland@redhat.com>
Roland McGrath [Mon, 31 Jul 2006 05:57:52 +0000 (05:57 +0000)]
2006-07-30  Roland McGrath  <roland@redhat.com>

* include/unistd.h (__pause_nocancel): Add attribute_hidden.
* include/time.h (__nanosleep_nocancel): Likewise.

17 years ago* locale/programs/localedef.c (add_to_readlist): Rename local
Ulrich Drepper [Sun, 30 Jul 2006 22:24:49 +0000 (22:24 +0000)]
* locale/programs/localedef.c (add_to_readlist): Rename local

variables to avoid confusion.

* locale/programs/charmap.c (charmap_read): Emit error message if
charmap couldn't be found or read.

17 years ago* sysdeps/unix/sysv/linux/kernel-features.h: Define cvs/fedora-glibc-20060729T2255
Ulrich Drepper [Sat, 29 Jul 2006 05:07:43 +0000 (05:07 +0000)]
* sysdeps/unix/sysv/linux/kernel-features.h: Define

__ASSUME_FUTEX_LOCK_PI.
* include/time.h: Declare __nanosleep_nocancel.
* include/unistd.h: Declare __pause_nocancel.

17 years ago2006-07-28 Ulrich Drepper <drepper@redhat.com>
Ulrich Drepper [Sat, 29 Jul 2006 04:42:09 +0000 (04:42 +0000)]
2006-07-28  Ulrich Drepper  <drepper@redhat.com>

    Jakub Jelinek  <jakub@redhat.com>

* descr.h: Change ENQUEUE_MUTEX and DEQUEUE_MUTEX for bit 0
notification of PI mutex.  Add ENQUEUE_MUTEX_PI.
* pthreadP.h: Define PTHREAD_MUTEX_PI_* macros for PI mutex types.
* pthread_mutex_setprioceilining.c: Adjust for mutex type name change.
* pthread_mutex_init.c: Add support for priority inheritance mutex.
* pthread_mutex_lock.c: Likewise.
* pthread_mutex_timedlock.c: Likewise.
* pthread_mutex_trylock.c: Likewise.
* pthread_mutex_unlock.c: Likewise.
* sysdeps/pthread/pthread_cond_broadcast.c: For PI mutexes wake
all mutexes.
* sysdeps/unix/sysv/linux/i386/i486/pthread_cond_broadcast.c: Likewise.
* sysdeps/unix/sysv/linux/x86_64/pthread_cond_broadcast.c: Likewise.
* sysdeps/unix/sysv/linux/pthread-pi-defines.sym: New file.
* sysdeps/unix/sysv/linux/Makefile (gen-as-const-header): Add
pthread-pi-defines.sym.
* sysdeps/unix/sysv/linux/i386/lowlevellock.h: Define FUTEX_LOCK_PI,
FUTEX_UNLOCK_PI, and FUTEX_TRYLOCK_PI.
* sysdeps/unix/sysv/linux/x86_64/lowlevellock.h: Likewise.
* sysdeps/unix/sysv/linux/bits/posix_opt.h: Define
_POSIX_THREAD_PRIO_INHERIT to 200112L.
* tst-mutex1.c: Adjust to allow use in PI mutex test.
* tst-mutex2.c: Likewise.
* tst-mutex3.c: Likewise.
* tst-mutex4.c: Likewise.
* tst-mutex5.c: Likewise.
* tst-mutex6.c: Likewise.
* tst-mutex7.c: Likewise.
* tst-mutex7a.c: Likewise.
* tst-mutex8.c: Likewise.
* tst-mutex9.c: Likewise.
* tst-robust1.c: Likewise.
* tst-robust7.c: Likewise.
* tst-robust8.c: Likewise.
* tst-mutexpi1.c: New file.
* tst-mutexpi2.c: New file.
* tst-mutexpi3.c: New file.
* tst-mutexpi4.c: New file.
* tst-mutexpi5.c: New file.
* tst-mutexpi6.c: New file.
* tst-mutexpi7.c: New file.
* tst-mutexpi7a.c: New file.
* tst-mutexpi8.c: New file.
* tst-mutexpi9.c: New file.
* tst-robust1.c: New file.
* tst-robust2.c: New file.
* tst-robust3.c: New file.
* tst-robust4.c: New file.
* tst-robust5.c: New file.
* tst-robust6.c: New file.
* tst-robust7.c: New file.
* tst-robust8.c: New file.
* Makefile (tests): Add the new tests.

* pthread_create.c (start_thread): Add some casts to avoid warnings.
* pthread_mutex_destroy.c: Remove unneeded label.

17 years ago* dlfcn/Makefile (LDLIBS-bug-atexit3-lib.so): Use this instead of
Ulrich Drepper [Fri, 28 Jul 2006 19:57:56 +0000 (19:57 +0000)]
* dlfcn/Makefile (LDLIBS-bug-atexit3-lib.so): Use this instead of

LDFLAGS.  Add -lgcc_eh and libc_nonshared (again) to make sure we
get the __stack_chk_fail_local definition when it's needed.

17 years ago* dlfcn/Makefile: Add rules to build and run bug-atexit3.
Ulrich Drepper [Thu, 27 Jul 2006 01:31:43 +0000 (01:31 +0000)]
* dlfcn/Makefile: Add rules to build and run bug-atexit3.

* dlfcn/bug-atexit3.c: New file.
* dlfcn/bug-atexit3-lib.cc: New file.

17 years ago* dlfcn/dlmopen.c (dlmopen_doit): Don't allow RTLD_GLOBAL to be
Ulrich Drepper [Wed, 26 Jul 2006 08:21:54 +0000 (08:21 +0000)]
* dlfcn/dlmopen.c (dlmopen_doit): Don't allow RTLD_GLOBAL to be

used when the namespace is not the base namespace.