Hyotaek Shim [Tue, 23 Jul 2019 02:51:40 +0000 (11:51 +0900)]
Fix WantedBy field in storaged.service
Change-Id: I286fdc9d645bd8ef43e0406d0cc113883a043646
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Mon, 8 Jul 2019 11:27:50 +0000 (20:27 +0900)]
Delete meaningless configuration
Change-Id: Id8f15543dd3431dfb85a4c4bcb7b4b289da5391c
sanghyeok.oh [Mon, 8 Jul 2019 08:06:53 +0000 (17:06 +0900)]
coverity fix
Change-Id: I79e8640d6ccbd0b810451ba284d23c042ff89c67
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Wed, 26 Jun 2019 05:49:47 +0000 (14:49 +0900)]
Move storaged.service from multi-user.target to delayed.target
Change-Id: Id10bce3ae57d76c3cfc335a62b0de515038b0d19
INSUN PYO [Tue, 25 Jun 2019 02:49:19 +0000 (11:49 +0900)]
Remove unnecessary dependency from storaged.service
Change-Id: I1d83cc00e3952ec140a55b15294be1fb6d90dc3b
sanghyeok.oh [Wed, 12 Jun 2019 00:16:42 +0000 (09:16 +0900)]
block: dbus: (rework)modified to reply error type message if failed
- reply empty body gvariant if there are no matched device
- reply error type msg if error occured
Change-Id: Iec43b9c22284bb717939d219a3d7ac8f17d1be7e
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Mon, 10 Jun 2019 10:17:36 +0000 (10:17 +0000)]
Revert "block: dbus: modified to reply error type message if failed"
This reverts commit
bdbefcfd9dc654860f7988d69753b5159e1bfb86.
Change-Id: I44d2ed00df58ab2871a1f5c36870c44e3d2e0c30
sanghyeok.oh [Mon, 27 May 2019 06:42:45 +0000 (15:42 +0900)]
dbus-policy: modified to use default deny - allow signal
Change-Id: If756dfd5b399debde8ec3893b55084930c219e04
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Tue, 14 May 2019 11:08:05 +0000 (20:08 +0900)]
block: add type converting function for enum block_device_type
Change-Id: I04d09f8639b1604d543f9746cfc926a87dd084e0
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Fri, 10 May 2019 11:34:00 +0000 (20:34 +0900)]
block: dbus: modified to reply error type message if failed
gdbus method handler should reply g_variant with valid signature or error type message.
Change-Id: I00398b6d0614c5117ac5f0ac5801d504126721dd
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Fri, 3 May 2019 05:22:54 +0000 (14:22 +0900)]
dbus-policy: rearrange policy
Just clean up. It doesn't change policy behavior.
Change-Id: I92dc171300c8ce15a172a7a2b9fbbab7d8fd1c27
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Tue, 30 Apr 2019 04:29:49 +0000 (13:29 +0900)]
Fix problem that change smack lable of /run to "*"
Pre condition
- USB memory stick formatted with ext4.
- There should be no regular files.
Problem
- Smack lable of /run is changed to "*".
Cause
- "find $MOUNT_DIRECTORY -type f | xargs" return blank if there is no files.
- storaged runs on "/"
- "chsmack -a '*'" changes all files in the current directory.
Solution
- runs xargs with "-r" option.
- Man page of xargs: "If the standard input does not contain any nonblanks, do not run the command. Normally, the command is run once even if there is no input. This option is a GNU extension."
Change-Id: I642aaf84ea4752698eaa8be18fd105019779f86a
Hyotaek Shim [Mon, 22 Apr 2019 08:30:43 +0000 (17:30 +0900)]
Do not wait for System StartupFinished
1) udev event --> sysinit.target/systemd-udevd.service
2) /tmp --> sysinit.target
3) /opt --> sysinit.target or initrd
4) /opt/usr --> wait-mount@opt-usr.service
So, storaged does not need to wait for StartupFinished.
Without this patch, storaged cannot complete booting_done()
when even a single service unit fails.
dbus-send --system --print-reply
--type=method_call
--dest=org.freedesktop.systemd1
/org/freedesktop/systemd1
org.freedesktop.DBus.Properties.Get
string:"org.freedesktop.systemd1.Manager"
string:"SystemState"
variant string "starting"
Change-Id: I7275cc91e1904600f0c0a7cd7ac2dd243e15922b
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Yunmi Ha [Thu, 11 Apr 2019 08:46:41 +0000 (17:46 +0900)]
Add systemd state checking logic
If system session is already running,
storaged can't receive StartupFinished signal.
In that case, add logic to check the systemd state at startup.
Change-Id: Ied8af322c1e8d4e5e34ea84f2e1c8f968c56a733
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Wed, 10 Apr 2019 08:24:52 +0000 (17:24 +0900)]
Change libgdbus library name to libsyscommon.
Change-Id: Ie86ed9961540c81f9301088b098ad00ef1e9a203
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 9 Apr 2019 05:29:15 +0000 (14:29 +0900)]
block: Added logic to wait for thread processing on exit
If the thread has remain job when it exit,
it need to wait for finishing it.
Change-Id: I09aba16ee427222537d279487711a4ecfbaff795
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 26 Feb 2019 09:27:04 +0000 (18:27 +0900)]
Restore permission of source files.
Change-Id: If50fc0975bd053d71a7fdbc49d22c0822dbb483d
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Yunmi Ha [Tue, 26 Feb 2019 02:46:06 +0000 (11:46 +0900)]
Apply consistent log messages.
1. First letter to uppercase.
2. Period at the end.
3. Rearrange parameters.
Change-Id: I6705c61a5d03c99b2371a5df0d76eafa29e39526
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
pr.jung [Fri, 15 Feb 2019 08:57:38 +0000 (17:57 +0900)]
Modify external-storage and extended-internal-sd directory paths
Change-Id: Ibb92488d33812d8d0ff3fecd9c0e4016a44aa064
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 14 Feb 2019 05:27:01 +0000 (14:27 +0900)]
Avoid TOCTOU condition
- chmod() did't change smack label of already existing directory.
- remove() can't remove not empty directory
Change-Id: I801ecfaf5df86122fb553891598d7b27b43069e3
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 30 Jan 2019 08:35:27 +0000 (17:35 +0900)]
storaged could cause heap use after free
- Call free() on remove_operation()(Thread)
- Access op->op on add_operation()(Main thread)
Change-Id: Iee3b3a545a04889d79f1d696dadce9d842769259
Signed-off-by: pr.jung <pr.jung@samsung.com>
lokilee73 [Thu, 27 Dec 2018 02:59:13 +0000 (11:59 +0900)]
Remove executable flag from non-executable files
Change-Id: Icd5e1876b505bb4e4cc5f7d513ab0ec60abbc761
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
pr.jung [Mon, 17 Dec 2018 10:50:08 +0000 (19:50 +0900)]
storage: Add popup and notification as well
Change-Id: Ide44a71213baa09e4122c61030c4388b03f65e43
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
(cherry picked from commit
663b8496576b7761ed4b1ae3a7db7b0eab7e6924)
pr.jung [Fri, 14 Dec 2018 04:37:04 +0000 (13:37 +0900)]
dlog: Fix dlog format errors
Change-Id: I9fc9cbdbb7d52aff3de8bcaf23a475b840284ffe
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Fri, 7 Dec 2018 06:28:20 +0000 (15:28 +0900)]
dlog: Fix dlog format errors
Change-Id: I0e8141da652a5c6db57455740f5cb0e09e646c13
Signed-off-by: pr.jung <pr.jung@samsung.com>
Pawel Kowalski [Thu, 16 Aug 2018 10:49:27 +0000 (12:49 +0200)]
Add Apache 2.0 license headers
Change-Id: I52155a8b06a6cc9f2a476d5ec76763051d9c7443
pr.jung [Thu, 26 Jul 2018 08:48:32 +0000 (17:48 +0900)]
Add GetStorageLevel dbus method
Change-Id: I07bff489585935b5a533f010ae79c4e91d72cc65
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Fri, 6 Jul 2018 04:31:48 +0000 (13:31 +0900)]
Change watchdog timeout from 30 sec. to 90 sec.
It has been observed,
after a long suspend timeout/delay, Systemd may kill processes by Watchdog timeout as soon as it is thawed.
This is a workaground patch to avoid such a problem.
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] Freezing of tasks failed after 20.006 seconds (1 tasks refusing to freeze, wq_bu$
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] shealth-exercis D 0 16604 3220 0x00400209
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] Call trace:
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff8008085b70>] __switch_to+0x8c/0xa0
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80088d4720>] __schedule+0x37c/0x72c
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80088d4bcc>] schedule+0x8c/0xac
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80088d786c>] schedule_timeout+0x148/0x38c
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff8008439f78>] kbase_destroy_context+0x394/0x448
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80084465d4>] kbase_release+0xf4/0x158
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80081ded58>] __fput+0xf4/0x1a8
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80081dee68>] ____fput+0xc/0x14
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80080bd378>] task_work_run+0xbc/0xe8
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff80080891a0>] do_notify_resume+0x80/0x90
[Thu Jul 5 03:18:04 2018] [1: kworker/u4:9: 8153] [<
ffffff8008082f8c>] work_pending+0x8/0x10
...
Jul 05 14:37:25 localhost systemd[1]: storaged.service: Watchdog timeout (limit 30s)!
Jul 05 14:37:25 localhost systemd[1]: storaged.service: Killing process 3092 (storaged) with signal SIGABRT.
Change-Id: I4ce6d243dca5b30bc8a6f7cd526c724227dbfcdf
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Tue, 3 Jul 2018 06:29:05 +0000 (15:29 +0900)]
svace fix
Change-Id: I35d4440f60d1ef2468bd07a7afea1545c5178ded
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
pr.jung [Mon, 25 Jun 2018 04:58:09 +0000 (13:58 +0900)]
storage: Change NeedCleanup signal from "ss" to "is"
- Change NeedCleanup signal "ss" to "is"
Path is sent by tzplatform_variable enum
- Remove Full and ChangeState signals
Change-Id: Iac9f52b5ef7d03f6bdd38be7bcf29393f310a87d
Signed-off-by: pr.jung <pr.jung@samsung.com>
lokilee73 [Thu, 21 Jun 2018 07:34:30 +0000 (16:34 +0900)]
Fix dbus returned error by unmatched signature between storaged and system-popup
Change-Id: Iecf6cd5c6f57484b813bd9983bf9a5af0975714c
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
pr.jung [Wed, 20 Jun 2018 05:00:07 +0000 (14:00 +0900)]
storage: Add new dbus method "GetStorageLevel"
- input: "i"
TZ_SYS_USER, TZ_SYS_OPT, TZ_SYS_TMP
- output: "s"
normal, warning, critical, full, and error message
Change-Id: I3954776c0f156bdbae43332393b62a55016eb015
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 12 Jun 2018 09:34:38 +0000 (18:34 +0900)]
storage: Write file when storage status is changed
- /run/storaged/needcleanup/trigger
Change-Id: Ie48cb6020670e321a54771def0a4a40331df6152
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Thu, 21 Jun 2018 02:33:29 +0000 (11:33 +0900)]
Boot optimization: add systemd unit dependency, After=dbus.service deviced.service
Change-Id: I1a6d22fdc5480310d17934c4071b554746ac034c
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Thu, 7 Jun 2018 08:30:50 +0000 (17:30 +0900)]
storage: Check /opt partition storage size and add NeedCleanup signal
- Check /opt/usr, /tmp, /opt size
- Broadcast NeedCleanup signal when memory level is changed
normal -> warning/critical/full
warning -> critical/full
critical -> full
Change-Id: I39d42624be0dbe4923f79c5e744502f2661a2103
Signed-off-by: pr.jung <pr.jung@samsung.com>
sanghyeok.oh [Thu, 17 May 2018 04:50:30 +0000 (13:50 +0900)]
dbus-policy: change to default deny policy
Change-Id: I747566fac4beaf96dc72dbc962231b974e84930c
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Mon, 14 May 2018 00:26:11 +0000 (09:26 +0900)]
block: Change file permission to "rw-rw-rw-" in vfat external storage
Change-Id: If37a891c911401308e906d2fb2ea14fef7881546
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 8 May 2018 07:32:18 +0000 (16:32 +0900)]
block: When block device is not found, GetDeviceInfo return with id less than 0
Change-Id: Ic434c6dc0e52625d772e8a9a8c172a8d01dcf182
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Mon, 30 Apr 2018 11:42:12 +0000 (20:42 +0900)]
Add .gitignore
Change-Id: Ia28aca5d442dbf585f70fb94063057d830a66f47
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 30 Apr 2018 10:56:58 +0000 (19:56 +0900)]
Fix systemd-assisted dbus activation sequence
Change-Id: I6d3ddd8a9673957156f23f8fbd410adce5dd03cb
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Tue, 10 Apr 2018 07:42:56 +0000 (16:42 +0900)]
svace fix
Change-Id: Ied1b5ed5a994f53e216e7d8f7105b28623031200
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
lokilee73 [Thu, 5 Apr 2018 04:42:37 +0000 (13:42 +0900)]
fix a compile error
Change-Id: I963a1f94d45c84d84fa781bed22b070ddad834d1
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
lokilee73 [Wed, 4 Apr 2018 12:44:46 +0000 (21:44 +0900)]
Refactor dbus_handle_init into two parts
It's to apply a fix in deviced which timing issue happend by telephony.
When telephony requests AddPoweroffWait, it fails because dbus in deviced is not ready.
Change-Id: I7b333f0a43965ac75ccccf03262fae44dbea66ce
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Hyotaek Shim [Tue, 3 Apr 2018 08:34:11 +0000 (17:34 +0900)]
Apply Full RELRO linker options ("-Wl,-z,relro,-z,now") to storaged
In addition to Partial RELRO, Full RELRO makes "GOT Table becomes read-only."
Change-Id: I1b946a542281a4b62f578d843189f768d3a6f72c
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Fri, 23 Mar 2018 09:58:14 +0000 (18:58 +0900)]
libgdbus: Change dbus methods to use libgdbus
Change-Id: I91baa9945d6351fbc99a832f4847a25ce4ef0c9e
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 22 Mar 2018 05:01:21 +0000 (14:01 +0900)]
libgdbus: Move common gdbus interfaces to libsystem package
Change-Id: Icc59a49192a4a5a9f1392eb44a2a7551ecf6ba4d
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 15 Mar 2018 04:30:16 +0000 (13:30 +0900)]
block: Add mmc inserted & removed popup
- Launch notice popup when mmc is mounted and unexpectedly removed
Change-Id: I0978c2bb8eee80129490065bac1749cf03883674
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 13 Mar 2018 11:26:19 +0000 (20:26 +0900)]
block: Fix code to be more readable
Change-Id: I413ad40cb7cd633f5ad2f2af3af4343e9e497e79
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 13 Mar 2018 10:47:02 +0000 (19:47 +0900)]
block: Change external storage permission to 777
- Directory permission is 777, uid is root groupid is priv_externalstorage
- security-manager will handle access control for external storage
- When externalstorage privilege is configured as privacy,
security framework will enforce this privilege with different mechanism - per-application mount namespace.
In such case mount options must be different to allow all users and groups access to mount point.
If an application is not supposed to have access to externalstorage,
security-manager will mount a special directory over sdcard mount point.
In such case access control is no longer based on GID,
so mount options must allow application access regardless of its groups.
Change-Id: I1582d3afd70354cc81d7142fee4c9edf4c94ef30
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 13 Mar 2018 02:24:28 +0000 (11:24 +0900)]
block: Remove memset
Change-Id: I758bed8d6bbd08425135ea2461ffe4717925f01b
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 12 Mar 2018 08:59:35 +0000 (17:59 +0900)]
block: Create default directory for mmc
- Create default directories (Images, Videos, Sountds, Downloads) for primary sdcard
Change-Id: If3cb0d66ad41d13c05a00dfc85256f8eabafc8b3
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Wed, 7 Mar 2018 23:50:30 +0000 (08:50 +0900)]
Minor fixes: chmod files, rename dbus conf file, etc.
Change-Id: Ia23bfea0d18dd65f9c3a7a504f0b7b4817980d89
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
sanghyeok.oh [Mon, 5 Mar 2018 13:23:51 +0000 (22:23 +0900)]
dbus: modify dbus policy correctly
Change-Id: I3d26b9ed55aa7462e3fa4fe3ff44a1578f595a4d
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
pr.jung [Tue, 27 Feb 2018 09:08:34 +0000 (18:08 +0900)]
block: Add GetStatvfs dbus method
Change-Id: I2d6f6fa61a8785638624e93ee02992c880da3f70
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Mon, 5 Mar 2018 11:45:26 +0000 (20:45 +0900)]
Add compile options: -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64
Change-Id: Ieb40d80c30668673177f6ccee9e580d79b62ef6e
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 20 Feb 2018 05:50:02 +0000 (14:50 +0900)]
auto-test: Add auto-test for storaged
Change-Id: I272e1c869628569663da76aa377892a58a5042ba
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 26 Feb 2018 11:05:44 +0000 (20:05 +0900)]
Change speedcheck methods by using O_DIRECT read operations
to prevent corruption in existing filesystem on MicroSD card.
Further work might be required to consider optimized zero-page reads in several MicroSD cards.
Change-Id: Ic26f9c3c5396bbad7b21683d1b08a72c6a8404a3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Fri, 9 Feb 2018 06:05:28 +0000 (15:05 +0900)]
block: Fix dbus method string format for GetControl
Change-Id: Iff6538b88827af03d9622d62dcfa650d78ce2a1c
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Tue, 6 Feb 2018 11:17:26 +0000 (20:17 +0900)]
Straighten up the code
Change-Id: I8804cdf9385afcc74eda7939650bb4fff8be2973
Signed-off-by: pr.jung <pr.jung@samsung.com>
sanghyeok.oh [Mon, 5 Feb 2018 08:17:50 +0000 (17:17 +0900)]
dbus: change dbus library from dbus to gdbus
Change-Id: I87f7fb5d88cba95f08b1927012f9b65cadc538a0
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
sanghyeok.oh [Tue, 1 Aug 2017 06:50:22 +0000 (15:50 +0900)]
dbus: clean up dbus policy
Change-Id: I2dd9e43cbfc9a5353fcf91035a684d355a50dbe2
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
INSUN PYO [Mon, 15 Jan 2018 02:31:53 +0000 (11:31 +0900)]
DPM: refactoring. splitting dbus response variables
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: Ic4d95d570e1aed841d7c64c0f882f390283d2426
Jung [Fri, 12 Jan 2018 04:35:06 +0000 (04:35 +0000)]
Merge "DPM: fix bug. wrong dbus return value." into tizen
INSUN PYO [Fri, 12 Jan 2018 04:29:21 +0000 (13:29 +0900)]
DPM: fix bug. wrong dbus return value.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I9e9f505976560457aeb3ee799394e51e8abde86e
Hyotaek Shim [Thu, 21 Dec 2017 08:18:08 +0000 (17:18 +0900)]
Remove tizen_build_devel_mode in the spec
Change-Id: I42e6d7db925f41e9cdddc26809f6ca84fcb0c368
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 5 Dec 2017 01:35:31 +0000 (10:35 +0900)]
block: Check fs_usage on retrieve_udev_device()
- fs_usage for ext4 and vfat is filesystem and for crypto_LUKS is crypto.
- There is format requests for ext4 or vfat only. (not crypto_LUKS)
Change-Id: Ic1ceb8bc57c89f1d46a5b991a04244ddc25a727d
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 4 Dec 2017 08:21:01 +0000 (17:21 +0900)]
block: Call pipe_trigger() for BLOCK_LUKS_CLOSE operation
Change-Id: I2676b017768797cc4d70bc3f20818827f4eafdfd
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 30 Nov 2017 07:23:48 +0000 (16:23 +0900)]
block: Close luks and remove block device
- Remove operation frees bdev structure
Change-Id: I138310ea793261cd0163472820eaf0abda7b1df2
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 29 Nov 2017 11:03:38 +0000 (20:03 +0900)]
block: When block is disabled, extended internal storage should not be unmounted
- When block control is off,
storaged doesn't deal with mount, format, and unmount operation
storaged doesn't unmount extended internal storage
storaged only handles uevents for extended internal storage
- Mount and Foramt dbus methods for extended internal storage are blocked
- Unmount dbus method for device node is blocked
- FormatwithType dbus method for mapper node is blocked
Change-Id: I723acb5601ad6fd6f53da1dce3f408108f2e676a
Signed-off-by: pr.jung <pr.jung@samsung.com>
INSUN PYO [Thu, 30 Nov 2017 05:58:40 +0000 (14:58 +0900)]
refactoring : remove unused parameter.
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I655750c0fde5cf606ca3195e49656891a4510980
pr.jung [Tue, 21 Nov 2017 07:14:43 +0000 (16:14 +0900)]
block: Rearrange block_init and block_exit sequence.
- Get internal storage number on block_init().
- Call pipe_exit() after threads stop.
Change-Id: I2bbcc296448a907052d96a2486700be37a92087f
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit
bb0d0846aecf8c021fd704d79f577a2d20d890b6)
pr.jung [Wed, 22 Nov 2017 05:46:57 +0000 (14:46 +0900)]
block: Unref udev device
Change-Id: Ibe9df053cfb7f6e0fd0bb37332057154c57ffaf4
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Thu, 16 Nov 2017 05:54:40 +0000 (14:54 +0900)]
block: register uevent control after block_init_from_udev_enumerate()
Change-Id: I1abf743b6c48c0ac706b28e1d6d53ae248340388
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Mon, 20 Nov 2017 04:46:53 +0000 (13:46 +0900)]
block: Change unmount option in remove_whole_block_device()
- UNMOUNT_NORMAL to UNMOUNT_FORCE
Change-Id: Ifa184f174d575060944e66d4dffda5cd0050b0a3
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Wed, 15 Nov 2017 08:45:49 +0000 (17:45 +0900)]
block: Check booting is done when storaged handles uevent
- Uevent for internal storage is handled before booting is done and block_init_from_udev_enumerate() called
Change-Id: I61d48551b15707c27a41ff63cb01a8c0f47ec2c5
Signed-off-by: pr.jung <pr.jung@samsung.com>
INSUN PYO [Mon, 6 Nov 2017 08:52:39 +0000 (17:52 +0900)]
DPM support
Signed-off-by: INSUN PYO <insun.pyo@samsung.com>
Change-Id: I2cfb22bcba36f3b8b3c3a487052a228033fe5769
INSUN PYO [Mon, 6 Nov 2017 08:39:50 +0000 (17:39 +0900)]
dbus name cleanup
pr.jung [Tue, 31 Oct 2017 08:13:14 +0000 (17:13 +0900)]
block,app: Support extended internal storage -> portable storage setting
- Only block type of mapper node(/dev/mapper/extendedsd) is BLOCK_EXTENDEDSD_DEV
- Not handle unformatted storage is setting on external storage using extended-sd app.
- Remove mount operation as extended internal storage when "ExtendedInternalSD" is sent as mount path (Mount dbus method)
- Support unmount operation for extended internal storage
- Add BLOCK_LUKS_CLOSE operation.
- Need to close luks when unmounting mapper node
- Register storage callback for removed signal for external storage(ex. /dev/mmcblk1p1)
- Register storage callback for mapper node
- internal -> portable setting: Get mapper node removed signal to progress format operation for external storage.
- portable -> internal setting: Get mapper node mounted signal to progress app ui
Change-Id: Iba8206e6e50ff2ed7df18931cd63c5c88109d049
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Jung [Mon, 30 Oct 2017 09:33:29 +0000 (09:33 +0000)]
Revert "Support reformatting from internal to external storage"
This reverts commit
c2ea6ef05797aaf0181c45ed5bcf03741ce76194.
Change-Id: If8fce2a3e84b393952d986b99f71ae7dc1109638
pr.jung [Tue, 31 Oct 2017 04:58:44 +0000 (13:58 +0900)]
app: Launch setting app when "Move apps now" and "Set Default storage" button touched
Change-Id: Id9596a1dcdeb681866bc7d5a45aa7a2884a8ec7c
Signed-off-by: pr.jung <pr.jung@samsung.com>
Hyotaek Shim [Mon, 30 Oct 2017 09:07:14 +0000 (18:07 +0900)]
Avoid crash on storaged UI
Change-Id: Ib198495d8e69238fb526f772a9aea835634490c3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 30 Oct 2017 08:01:49 +0000 (17:01 +0900)]
Check if ode_luke_close is done by using access(EXTENDEDSD_NODE_PATH, F_OK)
Change-Id: If135e1e74f478ea8ba2d2e154c5a823f03b5be98
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 30 Oct 2017 07:32:30 +0000 (16:32 +0900)]
Handle exceptional cases in request_check_speed() to avoid divide-by-zero
Change-Id: I9ff67572cbe5b866aff2e1f49220c60271aa81b9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Mon, 30 Oct 2017 02:50:05 +0000 (11:50 +0900)]
Support reformatting from internal to external storage
Change-Id: Idcf3befbd50de35899545cddf142865cee547cb9
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 25 Oct 2017 11:57:45 +0000 (20:57 +0900)]
Make vcont_set_int() to be set for extendedsd
Change-Id: I97e656033855152c938d34c0aa6ec456b49335ac
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 25 Oct 2017 09:28:53 +0000 (18:28 +0900)]
Add a new operation type (BLOCK_LUKS_CLOSE)
Change-Id: I83db5761c72df35c8b28126fff039014eacc00cf
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 25 Oct 2017 08:30:17 +0000 (17:30 +0900)]
Use ode_luks_close_sync() instead of ode_luks_close()
ode_luks_close_sync() is performed at add_operation(BLOCK_DEV_REMOVE) of /dev/mmcblkX that is set up as crypto_LUKS
Change-Id: Ib4509d9b29fb2c00bed95907df92c76028fe2f63
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 25 Oct 2017 08:01:08 +0000 (17:01 +0900)]
Remove udev_update flag, which was used to avoid udev property update as NULL
(The device-mapper sync-mode patch resolved the problem(NULL update).)
Change-Id: I82381b55ab3c745d9f2a45caa6ce6d587c0c80b3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 24 Oct 2017 07:26:39 +0000 (16:26 +0900)]
Update udev properties for /dev/mapper/extendedsd by using retrieve_udev_device()
Change-Id: I040d66ac070a8a62710d1113ec4e7f8a62242f38
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Tue, 24 Oct 2017 06:23:52 +0000 (15:23 +0900)]
Update bdev properties on UDEV_CHANGE
Change-Id: I0e701c3aee78f372a65d1286e5a6d286dc95c66d
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Thu, 19 Oct 2017 05:53:49 +0000 (14:53 +0900)]
block: Unmount mapper node when extended internal storage is removed
Change-Id: I4176eaa2b5419aff67ba400734369acb3b6514d6
Signed-off-by: pr.jung <pr.jung@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Thu, 19 Oct 2017 11:07:14 +0000 (20:07 +0900)]
Remove MS_NOEXEC option from ext4 mount for extended internal storage
Change-Id: Ia6a0947427a68323df24e3e32cc38d2ab4f98375
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Thu, 19 Oct 2017 07:24:20 +0000 (16:24 +0900)]
block: Launch popup when extended internal storage is inserted
- Popup launchs ode ui for password
Change-Id: I872c3f52993022d23f1e35670f45c9a9946d7bdd
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit
e1442c70e678b4c29cbabc04fdc9cba98a679c93)
Hyotaek Shim [Thu, 19 Oct 2017 07:47:37 +0000 (16:47 +0900)]
Add dependency to dbus.socket in storaged.service
Change-Id: I42fb8b7bdfaaf143ba9cf139df9de73f7b0c5899
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
(cherry picked from commit
fe9ff73d99312682c5df4b023f29d65db98ee52a)
pr.jung [Wed, 18 Oct 2017 06:25:14 +0000 (15:25 +0900)]
app: Need to unmount sdcard before launching encryption app
Change-Id: Id01b0888d3b102e350844c2a00c7c6790b9e3a24
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit
863659e8fc5e53a0edc780dc2a49f20e2fdf3470)
Hyotaek Shim [Tue, 17 Oct 2017 12:06:25 +0000 (21:06 +0900)]
Fix sleep function waiting for udev properties
Change-Id: Ie893ebe310f20bcaab3630c139e1329e0167eed6
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Tue, 17 Oct 2017 11:43:30 +0000 (20:43 +0900)]
app: Remove test code
- Get Primary mmc id and devpath using dbus method call
Change-Id: I0a798bad0dfb7e7ad69e986c81f37c2620c1067d
Signed-off-by: pr.jung <pr.jung@samsung.com>
(cherry picked from commit
c670c0e89036d4f96847456b0c8f896c38503fb3)
Hyotaek Shim [Tue, 17 Oct 2017 11:09:08 +0000 (20:09 +0900)]
Fix for mounting the extended internal storage (/dev/mapper/extendedsd)
Change-Id: Icac79f0f46d8f2baf76d0052aaac0a905e2d7985
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
pr.jung [Mon, 16 Oct 2017 10:08:43 +0000 (19:08 +0900)]
app: Launch org.tizen.ode for encryption and get signal for mapper node from storaged
- Launch org.tizen.ode for extended internal storage encryption
- Wait for mapper node mounted signal (DeviceChanged)
Change-Id: I592795cd7249114c2994ab22f5ed3e259e8b1bae
Signed-off-by: pr.jung <pr.jung@samsung.com>
pr.jung [Mon, 16 Oct 2017 09:23:06 +0000 (18:23 +0900)]
app: Need to launch app with launch option
- Can skip portable / extended internal selection page
Change-Id: Ib4d1dc7e06c65ad6bccb8779c47ca271b391a352
Signed-off-by: pr.jung <pr.jung@samsung.com>