bmeurer@chromium.org [Mon, 21 Oct 2013 07:19:11 +0000 (07:19 +0000)]
Prepare push to trunk. Now working on version 3.22.17.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
31913002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17276
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 18 Oct 2013 14:55:21 +0000 (14:55 +0000)]
Make stack_parameter_count a plain register.
R=rossberg@chromium.org, danno@chromium.org
Review URL: https://codereview.chromium.org/
28993003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17275
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
titzer@chromium.org [Fri, 18 Oct 2013 14:28:24 +0000 (14:28 +0000)]
Implement global load elimination based on flow engine.
BUG=
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
27148004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17273
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Fri, 18 Oct 2013 12:52:07 +0000 (12:52 +0000)]
Handlify JSObject::HasReal*Property.
R=ulan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27518002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17272
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
loislo@chromium.org [Fri, 18 Oct 2013 11:25:43 +0000 (11:25 +0000)]
HeapProfiler: integrate FindUntrackedObjects into js code.
In some cases we would like to check untracked objects right from the js code.
Otherwise the objects might be collected rigth before check.
BUG=none
R=hpayer@chromium.org, yurys@chromium.org
Review URL: https://codereview.chromium.org/
27717003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17270
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
loislo@chromium.org [Fri, 18 Oct 2013 10:59:55 +0000 (10:59 +0000)]
HeapProfiler: for the test purposes we would like to trace object movements.
When we have an untracked allocations we need to fix it.
It is a bit tricky process due to lack of logging.
I added FLAG_heap_profiler_trace_objects that enables log for object movements.
Drive by fix: with help of logging I found a bug in LeftTrim method for FixedArray.
BUG=none
R=svenpanne@chromium.org, yurys@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17258
Committed: https://code.google.com/p/v8/source/detail?r=17263
Review URL: https://codereview.chromium.org/
27694004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17269
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Fri, 18 Oct 2013 10:54:45 +0000 (10:54 +0000)]
Tweak Math.log on ia32/x64
ia32 and x64 more consistent now
1. use non-transcendental cache version of log for x64
2. use negative infinity constant instead of pushing to stack and loading to XMM register
3. remove movdbl, use movsd directly. movdbl seems confusing
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
27197013
Patch from Weiliang Lin <weiliang.lin2@gmail.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17268
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 18 Oct 2013 10:32:11 +0000 (10:32 +0000)]
Prepare push to trunk. Now working on version 3.22.16.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
28883002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17265
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 18 Oct 2013 09:50:06 +0000 (09:50 +0000)]
Revert "HeapProfiler: for the test purposes we would like to trace object movements."
This reverts r17263 because of compile failures accross all builds.
TBR=loislo@chromium.org
Review URL: https://codereview.chromium.org/
28773002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17264
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
loislo@chromium.org [Fri, 18 Oct 2013 09:40:00 +0000 (09:40 +0000)]
HeapProfiler: for the test purposes we would like to trace object movements.
When we have an untracked allocations we need to fix it.
It is a bit tricky process due to lack of logging.
I added FLAG_heap_profiler_trace_objects that enables log for object movements.
Drive by fix: with help of logging I found a bug in LeftTrim method for FixedArray.
BUG=none
R=svenpanne@chromium.org, yurys@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17258
Review URL: https://codereview.chromium.org/
27694004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17263
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Fri, 18 Oct 2013 09:06:58 +0000 (09:06 +0000)]
Removed dead code from mksnapshot.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
28683002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17262
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Fri, 18 Oct 2013 08:56:14 +0000 (08:56 +0000)]
Always make a copy of a string when adding it to StringsStorage
Otherwise the string passed as const char* may be disposed and we will end up with a dangling pointer.
Also changed StringsStorage::GetCopy so that a copy is not created if the string is already in the cache.
BUG=None
R=alph@chromium.org, svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
27627006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17260
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
loislo@chromium.org [Fri, 18 Oct 2013 08:11:36 +0000 (08:11 +0000)]
Revert "HeapProfiler: for the test purposes we would like to trace object movements."
Compilation failed on Win64.
This reverts commit
6909faccca68c04b7ec4537538e6e7a0cc1650b8.
BUG=none
TBR=yurys
Review URL: https://codereview.chromium.org/
28573002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17259
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
loislo@chromium.org [Fri, 18 Oct 2013 07:43:50 +0000 (07:43 +0000)]
HeapProfiler: for the test purposes we would like to trace object movements.
When we have an untracked allocations we need to fix it.
It is a bit tricky process due to lack of logging.
I added FLAG_heap_profiler_trace_objects that enables log for object movements.
Drive by fix: with help of logging I found a bug in LeftTrim method for FixedArray.
BUG=none
R=svenpanne@chromium.org, yurys@chromium.org
Review URL: https://codereview.chromium.org/
27694004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17258
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rafaelw@chromium.org [Thu, 17 Oct 2013 20:49:45 +0000 (20:49 +0000)]
Prevent changes to hidden properties from being observable via Object.observe
This addresses the leak that mstarzinger points out (https://codereview.chromium.org/
26390003/) and includes the test.
Note that this adds a test that observing changes to the empty-string property remains possible.
BUG=
R=mstarzinger@chromium.org, rossberg@chromium.org
Review URL: https://codereview.chromium.org/
26592012
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17257
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Thu, 17 Oct 2013 13:09:28 +0000 (13:09 +0000)]
Make it possible to run a test only in the standard variant.
Use this for mjsunit/unicode-case-overoptimization, which is not
related to Crankshaft at all and takes ages.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
27704002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17255
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 17 Oct 2013 12:48:28 +0000 (12:48 +0000)]
Add regression test for optimized count operation.
This is a regression test for a bug with handling of count operations
that target a JavaScript accessor on the prototype chain in Crankshaft.
R=jkummerow@chromium.org
BUG=chromium:306851
TEST=mjsunit/regress/regress-crbug-306851
Review URL: https://codereview.chromium.org/
27702002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17254
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
marja@chromium.org [Thu, 17 Oct 2013 11:48:03 +0000 (11:48 +0000)]
Enable calling the SetReference* & SetObjectGroupId functions with a Persistent<SubclassOfValue>.
This is needed for https://codereview.chromium.org/
26792002/
BUG=
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
27512003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17253
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 17 Oct 2013 10:02:45 +0000 (10:02 +0000)]
Cosmetic: Add macros for NaN, undefined and Infinity to native js code.
Nobody should need to use $NaN, 0/0, 1/0 and void 0.
R=mvstanton@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27491002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17252
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Thu, 17 Oct 2013 08:03:12 +0000 (08:03 +0000)]
Prepare push to trunk. Now working on version 3.22.15.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
27676002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17249
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
palfia@homejinni.com [Wed, 16 Oct 2013 23:15:30 +0000 (23:15 +0000)]
MIPS: Add support for Token::NE and Token::NE_STRICT to TokenToCondition.
Port r17239 (
c203175f)
Original commit message:
This is required to be able to use these tokens with
HCompareNumericAndBranch.
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/
27516004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17248
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 16 Oct 2013 16:27:17 +0000 (16:27 +0000)]
Fix leak in optimizing compiler thread.
R=mvstanton@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27473006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17247
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 16 Oct 2013 14:47:20 +0000 (14:47 +0000)]
Improve queuing for concurrent OSR.
Specifically, this includes:
- Encapsulating data structure for osr buffer into CyclicBuffer
- Use the new CyclicQueue instead of UnboundedQueue to queue new jobs.
We can enqueue and dequeue a CyclicQueue on both ends in O(1).
This allows us to add OSR jobs to the front for lower compile latency.
- Dispose osr buffer by one stale job per GC to avoid leak
R=titzer@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
25505002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17244
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
olivf@chromium.org [Wed, 16 Oct 2013 14:39:27 +0000 (14:39 +0000)]
Fix lower bound of shr.
BUG=
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
27503002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17243
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Wed, 16 Oct 2013 14:33:04 +0000 (14:33 +0000)]
Get rid of HEAP_PROFILE macro
All usages of the macro were replaced with direct calls to the heap profiler. The macro does null check for HeapProfiler which is always true.
BUG=None
R=yangguo@chromium.org
Review URL: https://codereview.chromium.org/
26166004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17242
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 16 Oct 2013 14:17:31 +0000 (14:17 +0000)]
Revert "TransitionAndStoreStub bailout needs to transition (and store)."
This reverts commit r17216 breaking fast/js/cross-frame-bad-time.html test.
R=mvstanton@chromium.org
TEST=webkit:fast/js/cross-frame-bad-time.html
Review URL: https://codereview.chromium.org/
27516002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17241
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
titzer@chromium.org [Wed, 16 Oct 2013 13:19:46 +0000 (13:19 +0000)]
Remove dead constants not in block #0.
BUG=
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
27473004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17240
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Wed, 16 Oct 2013 12:20:21 +0000 (12:20 +0000)]
Add support for Token::NE and Token::NE_STRICT to TokenToCondition.
This is required to be able to use these tokens with
HCompareNumericAndBranch.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
27043010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17239
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 16 Oct 2013 11:52:03 +0000 (11:52 +0000)]
Refactor part of handles.cc
BUG=
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
26955004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17238
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 16 Oct 2013 11:16:49 +0000 (11:16 +0000)]
Return descriptor ownership after TrimDescriptorArray to allow resharing of descriptor arrays
BUG=None
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
27197002
Patch from Ross McIlroy <rmcilroy@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17237
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 16 Oct 2013 09:16:56 +0000 (09:16 +0000)]
Implement fixpoint iteration for escape analysis.
R=titzer@chromium.org
Review URL: https://codereview.chromium.org/
23533003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17235
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Wed, 16 Oct 2013 09:13:31 +0000 (09:13 +0000)]
Handlify GetPropertyWithCallback.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27335002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17234
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Wed, 16 Oct 2013 08:58:53 +0000 (08:58 +0000)]
Prepare push to trunk. Now working on version 3.22.14.
R=jkummerow@chromium.org, bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
27288003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17230
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Wed, 16 Oct 2013 08:15:06 +0000 (08:15 +0000)]
Fix unexpected stack traces in test-cpu-profiler/JsNativeJsSample
This is a follow-up fix for r17140 which makes sure that cpu profiler is started before profiled js functions are compiled so that the profiler gets information about "no frame" ranges along with add code events.
BUG=v8:2933
R=jkummerow@chromium.org, loislo@chromium.org
Review URL: https://codereview.chromium.org/
27121003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17229
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Wed, 16 Oct 2013 08:10:36 +0000 (08:10 +0000)]
AllocationSites for all literals
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
24250005
Review URL: https://codereview.chromium.org/
27366003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17228
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Wed, 16 Oct 2013 08:08:41 +0000 (08:08 +0000)]
Fix for non-SSE2.
BUG=cctest/test-assembler-ia32/AssemblerIa32Extractps
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
27476004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17227
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
haitao.feng@intel.com [Wed, 16 Oct 2013 03:30:06 +0000 (03:30 +0000)]
Refactor deferred_objects_double_values_ a little in the deoptimization
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
25583004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17226
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
palfia@homejinni.com [Tue, 15 Oct 2013 23:12:15 +0000 (23:12 +0000)]
MIPS: Make TestJSArrayForAllocationMemento less awkward.
Port r17220 (
be968d52)
Original commit message:
Generated code ended up having two conditional jump statements in a
row. Also introduce JumpIfJSArrayHasAllocationMemento which handles
most cases more simply.
BUG=
R=gergely@homejinni.com
Review URL: https://codereview.chromium.org/
27421002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17225
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rafaelw@chromium.org [Tue, 15 Oct 2013 19:28:11 +0000 (19:28 +0000)]
Handlify JSObject::SetObserved
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
27070002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17224
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
olivf@chromium.org [Tue, 15 Oct 2013 16:12:25 +0000 (16:12 +0000)]
Properly export uin32_bias double constant.
This makes LoadUint32 snapshot safe.
BUG=
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
27156004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17223
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Tue, 15 Oct 2013 15:35:23 +0000 (15:35 +0000)]
Revert "AllocationSites for all literals"
This reverts commit r17219 due to WebKit failures.
R=mstarzinger@chromium.org
TBR=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
26539010
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17222
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Tue, 15 Oct 2013 15:06:04 +0000 (15:06 +0000)]
Simplify array element access in Hydrogen.
No change in functionality intended.
R=mvstanton@chromium.org
Review URL: https://codereview.chromium.org/
26986004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17221
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Tue, 15 Oct 2013 15:04:29 +0000 (15:04 +0000)]
Make TestJSArrayForAllocationMemento less awkward.
Generated code ended up having two conditional jump statements in a
row. Also introduce JumpIfJSArrayHasAllocationMemento which handles
most cases more simply.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
26841009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17220
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Tue, 15 Oct 2013 14:52:58 +0000 (14:52 +0000)]
AllocationSites for all literals
BUG=
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
24250005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17219
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Tue, 15 Oct 2013 14:04:49 +0000 (14:04 +0000)]
Do not rely on actual NaN value for testing extractps.
BUG=cctest/test-assembler-ia32/AssemblerIa32Extractps, cctest/test-assembler-x64/AssemblerX64Extractps
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
26704004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17218
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
svenpanne@chromium.org [Tue, 15 Oct 2013 12:51:58 +0000 (12:51 +0000)]
Fixed bug in extractps instruction on ia32 and x64
This is a fixed version of https://codereview.chromium.org/
27097002/
which was originally written by weiliang.lin@intel.com.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
27301003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17217
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Tue, 15 Oct 2013 12:42:03 +0000 (12:42 +0000)]
TransitionAndStoreStub bailout needs to transition (and store).
Performance regression found in test regress-2185-2.js. The problem was
that the bailout method for TransitionAndStoreStub was not performing
the appropriate transition.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
26911007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17216
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
dslomov@chromium.org [Tue, 15 Oct 2013 11:27:12 +0000 (11:27 +0000)]
Do not look up ArrayBuffer on global object in typed array constructor.
BUG=v8:2931
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
27238009
Patch from Ben Noordhuis <info@bnoordhuis.nl>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17215
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Tue, 15 Oct 2013 11:24:37 +0000 (11:24 +0000)]
Delete dead code from HOptimizedGraphBuilder::VisitCompareOperation
R=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
26419005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17214
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 15 Oct 2013 08:59:26 +0000 (08:59 +0000)]
Disable RegExpInterruption test for interpreted irregexp.
Interrupts are not currently supported by interpreted irregexp.
R=mvstanton@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27312002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17209
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 15 Oct 2013 08:57:36 +0000 (08:57 +0000)]
Remove deprecated "i::" prefix from the pre-parser.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
26296006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17208
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 15 Oct 2013 08:32:58 +0000 (08:32 +0000)]
Unify several checking methods between parser and pre-parser.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
27206002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17207
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Tue, 15 Oct 2013 08:22:27 +0000 (08:22 +0000)]
Prepare push to trunk. Now working on version 3.22.13.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
27309002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17204
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Tue, 15 Oct 2013 08:06:01 +0000 (08:06 +0000)]
Fix regexp interrupt test.
R=jochen@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
26848011
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17203
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 14 Oct 2013 16:46:51 +0000 (16:46 +0000)]
Introduce ParserBase for common code between parser and pre-parser.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
27182002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17202
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Mon, 14 Oct 2013 14:15:22 +0000 (14:15 +0000)]
Retire concurrent recompilation delay for non-stress testing.
Instead, we block concurrent recompilation until unblocked. This makes
affected tests more predictable and run shorter.
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
26758003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17199
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 14 Oct 2013 14:00:28 +0000 (14:00 +0000)]
Add histograms to track fraction of heap spaces and percentage of generated crankshaft code.
BUG=None
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
27023003
Patch from Ross McIlroy <rmcilroy@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17198
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
ulan@chromium.org [Mon, 14 Oct 2013 13:35:06 +0000 (13:35 +0000)]
Out-of-line constant pool on Arm: Stage 2 - Introduce ConstantPoolArray object.
Second stage of implementing an out-of-line constant pool on Arm. This CL
Introduces the ConstantPoolArray object which will be used as the backing
store of out-of-line constant pools. Nothing uses this object yet.
BUG=
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
22601003
Patch from Ross McIlroy <rmcilroy@chromium.org>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17197
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
titzer@chromium.org [Mon, 14 Oct 2013 13:32:02 +0000 (13:32 +0000)]
Reduce queue size in dead code elimination by eagerly processing live instructions.
BUG=
R=rmcilroy@chromium.org
Review URL: https://codereview.chromium.org/
27178002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17196
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 14 Oct 2013 13:25:36 +0000 (13:25 +0000)]
Fix initial comparison combined_type
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27183002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17195
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 14 Oct 2013 13:08:52 +0000 (13:08 +0000)]
Add additional postmortem debugging metadata to support decoding two-byte
strings, sliced strings, and changes to some object property representations.
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
26034002
Patch from David Pacheco <dap@joyent.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17194
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jkummerow@chromium.org [Mon, 14 Oct 2013 13:07:41 +0000 (13:07 +0000)]
Move v8_optimized_debug default value to standalone.gypi
This is so that Chromium can have its own overridable default value without colliding with ours.
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
26317009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17193
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 14 Oct 2013 13:07:20 +0000 (13:07 +0000)]
Remove deprecated v8::preparser namespace.
R=ulan@chromium.org
Review URL: https://codereview.chromium.org/
27174002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17192
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Mon, 14 Oct 2013 12:41:28 +0000 (12:41 +0000)]
Track JS allocations as they arrive with no affection on performance when tracking is switched off.
BUG=277984
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
22852024
Patch from Alexandra Mikhaylova <amikhaylova@google.com>.
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17191
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 14 Oct 2013 12:14:42 +0000 (12:14 +0000)]
Reenable 17167: "Ensure lower <= upper bound"
Fixed handlification bug (see 2nd patch).
Will handlify Type::Union and Type::Intersect in separate CL.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
27164003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17189
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 14 Oct 2013 11:06:15 +0000 (11:06 +0000)]
Unify handling of position info in AST, part 3
* Turn CaseClause into a proper AstNode
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
23684058
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17187
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
hpayer@chromium.org [Mon, 14 Oct 2013 09:48:44 +0000 (09:48 +0000)]
Use pages from lower to higher addresses in new space.
This CL constitutes the invariant that the top pointer in new space is always larger than objects allocated since the last new space garbage collection.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
26865004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17185
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 14 Oct 2013 09:41:41 +0000 (09:41 +0000)]
Unify handling of position info in AST, part 2
* Eliminate Conditional::then/else_position and WhileStatement::condition_position.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
23597037
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17184
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Mon, 14 Oct 2013 09:24:58 +0000 (09:24 +0000)]
Unify handling of position info in AST, part 1
* AstNode now has a position info.
* Removed various ad-hoc position infos from subclasses (most of which had it).
* Position is always set with the constructor, instead of later.
* Take care to use kNoPosition in the right spots, to not crash the debugger.
Still to do:
* Eliminate Conditional::then/else_position and WhileStatement::condition_position.
* Make CaseClause a proper AstNode and eliminate its custom position.
* If possible, eliminate all uses of kNoPosition.
R=yangguo@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
24076007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17183
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Mon, 14 Oct 2013 09:22:34 +0000 (09:22 +0000)]
Drop useless HForceRepresentation in BinaryOpStub.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
27167002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17182
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
titzer@chromium.org [Mon, 14 Oct 2013 09:22:19 +0000 (09:22 +0000)]
Return the new state from local analysis in flow-engine.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
27166003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17181
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yurys@chromium.org [Mon, 14 Oct 2013 08:57:46 +0000 (08:57 +0000)]
profile-generator.* code clean-up
* Removed unused CodeEntry::CopyData
* Removed unnecessary INLINE macros
BUG=None
R=loislo@chromium.org, yangguo@chromium.org
Review URL: https://codereview.chromium.org/
25382003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17180
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Mon, 14 Oct 2013 08:42:54 +0000 (08:42 +0000)]
Prepare push to trunk. Now working on version 3.22.12.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
27163003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17177
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Mon, 14 Oct 2013 08:03:35 +0000 (08:03 +0000)]
HIsStringAndBranch does an implicit SMI check if necessary.
No need to test for SMI first using HIsSmiAndBranch.
R=svenpanne@chromium.org
Review URL: https://codereview.chromium.org/
27160002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17175
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
haitao.feng@intel.com [Mon, 14 Oct 2013 06:31:01 +0000 (06:31 +0000)]
Remove unnecessary MarkAsDeferredCalling when changing a tagged value to double
R=danno@chromium.org
Review URL: https://codereview.chromium.org/
25373003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17174
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
palfia@homejinni.com [Fri, 11 Oct 2013 23:37:56 +0000 (23:37 +0000)]
MIPS: Truncate booleans to 0/1 in truncating t-to-i.
Port r17166 (
0a4bf790)
Original commit message:
Truncate booleans to 0/1 in truncating t-to-i.
Thanks to weiliang.lin2@gmail.com for discovering the issue.
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/
26742006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17173
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
palfia@homejinni.com [Fri, 11 Oct 2013 21:26:10 +0000 (21:26 +0000)]
MIPS: Remove BaseLoad/StoreStub compilers, and the stub-cache interface duplication.
Port r17165 (
e3cb6e2e)
BUG=
R=plind44@gmail.com
Review URL: https://codereview.chromium.org/
26883007
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17172
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
cira@chromium.org [Fri, 11 Oct 2013 17:54:31 +0000 (17:54 +0000)]
Original review https://codereview.chromium.org/
25855005.
Reverting reverted r17148 and fixing build (test) breakage by side stepping the Windows vs. Linux issue of different Date object for the same millisecond time stamp.
We do that by using UTC Date methods (they eliminate DST problems).
Windows:
new Date(
129193200000);
Sun Feb 03 1974 23:00:00 GMT-0800 (Pacific Standard Time)
Linux:
new Date(
129193200000);
Mon Feb 04 1974 00:00:00 GMT-0700 (PST)
BUG=2919
R=dslomov@chromium.org, mnita@google.com
Review URL: https://codereview.chromium.org/
26918002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17171
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 11 Oct 2013 16:41:34 +0000 (16:41 +0000)]
Revert 17167: "Ensure lower <= upper bound"
Due to crashes in nosnap ia32
TBR=rossberg@chromium.org
Review URL: https://codereview.chromium.org/
27046002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17170
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
danno@chromium.org [Fri, 11 Oct 2013 15:24:45 +0000 (15:24 +0000)]
Adding Cira & Mihai to OWNERS for internationalization (i18n)
Keeping the names together so that I can put one comment for both.
Might also sort alphabetically, with the comment after each email.
Not sure what option was best, I have seen it done both ways.
R=cira@chromium.org, danno@chromium.org
Review URL: https://codereview.chromium.org/
26534002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17168
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Fri, 11 Oct 2013 15:17:58 +0000 (15:17 +0000)]
Ensure lower <= upper bound
R=jkummerow@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
26959004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17167
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
olivf@chromium.org [Fri, 11 Oct 2013 15:13:12 +0000 (15:13 +0000)]
Truncate booleans to 0/1 in truncating t-to-i.
Thanks to weiliang.lin2@gmail.com for discovering the issue.
BUG=
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
26824002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17166
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 11 Oct 2013 14:05:23 +0000 (14:05 +0000)]
Remove BaseLoad/StoreStub compilers, and the stub-cache interface duplication.
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
26873002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17165
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 11 Oct 2013 14:03:54 +0000 (14:03 +0000)]
Fix pre-parsing of 'use strict' directive after string literals.
R=ulan@chromium.org
TEST=mjsunit/regress/regress-parse-use-strict
Review URL: https://codereview.chromium.org/
27025002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17164
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
rossberg@chromium.org [Fri, 11 Oct 2013 13:59:01 +0000 (13:59 +0000)]
Minor tweaks to types cctest
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
26223006
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17163
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 11 Oct 2013 13:54:14 +0000 (13:54 +0000)]
Unify ComputeLoad/StoreHandler and dispatch on compile.
BUG=
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
26831002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17162
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 11 Oct 2013 13:48:14 +0000 (13:48 +0000)]
Centralize handler caching and probing in ic.cc.
Also purge invalid POLYMORPHIC stubs. In a next step the compilers should probably be merged and the "Compute*" on the stub-cache removed.
BUG=
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
25548009
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17161
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mstarzinger@chromium.org [Fri, 11 Oct 2013 13:40:08 +0000 (13:40 +0000)]
Remove dead IsEqualString and IsEqualNumber method.
R=hpayer@chromium.org
Review URL: https://codereview.chromium.org/
26833002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17160
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
titzer@chromium.org [Fri, 11 Oct 2013 13:00:42 +0000 (13:00 +0000)]
Implement first version of HFlowEngine, a framework for performing global flow-sensitive analyses.
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
25254002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17159
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
verwaest@chromium.org [Fri, 11 Oct 2013 10:50:26 +0000 (10:50 +0000)]
Add a slow stub for store ICs.
BUG=
R=ulan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/
26807003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17158
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Fri, 11 Oct 2013 10:34:17 +0000 (10:34 +0000)]
Prepare push to trunk. Now working on version 3.22.11.
R=verwaest@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
26977003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17155
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
mvstanton@chromium.org [Fri, 11 Oct 2013 09:25:14 +0000 (09:25 +0000)]
Allow FastCloneShallowObjectStub to use AllocationMementos.
(currently turned off)
BUG=
R=mstarzinger@chromium.org
Review URL: https://codereview.chromium.org/
26827002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17154
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
jochen@chromium.org [Fri, 11 Oct 2013 07:42:43 +0000 (07:42 +0000)]
Revert r17018 - "Turn on handle zapping for release builds"
BUG=none
R=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/
26457002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17152
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
bmeurer@chromium.org [Fri, 11 Oct 2013 07:12:06 +0000 (07:12 +0000)]
Load/Store cannot handle double representation.
Assert that the representation for Load/Store in the X64 MacroAssembler
is never Double. Also add missing test case for the Load/Store macros.
TEST=cctest/test-macro-assembler-x64
R=mvstanton@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17135
Review URL: https://codereview.chromium.org/
25990002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17151
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
dslomov@chromium.org [Thu, 10 Oct 2013 20:01:42 +0000 (20:01 +0000)]
Add instruction factories to HHasInstanceTypeAndBranch.
R=bmeurer@chromium.org
Review URL: https://codereview.chromium.org/
26859003
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17150
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
dslomov@chromium.org [Thu, 10 Oct 2013 19:43:05 +0000 (19:43 +0000)]
Revert "Fixing timezone issues with date-time/parse-* tests."
This reverts commit r17148 for breaking tests on Windows.
TBR=cira@google.com,titzer@chromium.org
Review URL: https://codereview.chromium.org/
26467005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17149
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
cira@chromium.org [Thu, 10 Oct 2013 17:54:33 +0000 (17:54 +0000)]
Fixing timezone issues with date-time/parse-* tests.
BUG=2919
TEST=All tests passing when local timezone was set to EST.
R=mnita@google.com, titzer@chromium.org
Review URL: https://codereview.chromium.org/
25855005
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17148
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
olivf@chromium.org [Thu, 10 Oct 2013 16:49:25 +0000 (16:49 +0000)]
Only set binary operation side effects flags, when observable.
BUG=
R=verwaest@chromium.org
Review URL: https://codereview.chromium.org/
26712002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17147
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 10 Oct 2013 15:38:52 +0000 (15:38 +0000)]
Handlify GetPropertyWithFailedAccessCheck.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
25732002
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17146
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00
yangguo@chromium.org [Thu, 10 Oct 2013 15:27:02 +0000 (15:27 +0000)]
Handlify JSObject::GetProperty????Interceptor.
R=mstarzinger@chromium.org
BUG=
Review URL: https://codereview.chromium.org/
25669004
git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17145
ce2b1a6d-e550-0410-aec6-
3dcde31c8c00