Alexander Galazin [Thu, 22 Aug 2019 11:42:23 +0000 (13:42 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I4059d84b79a3ad4504f436fa39dc2cddb294f8d7
Matthew Netsch [Wed, 14 Aug 2019 11:08:32 +0000 (16:38 +0530)]
Split compute workload into multiple submissions
Reduces workload per submission
Components: Vulkan
VK-GL-CTS Issue: 1751
Affects:
dEQP-VK.memory_model.message_passing.*
Change-Id: Ia9e9b63851b18ae1d5c1b65426ee864d760bf87c
Panagiotis Apostolou [Thu, 25 Jul 2019 10:29:18 +0000 (12:29 +0200)]
Add pipeline barriers flushing buffer data to host
This commit adds a few buffer pipeline barriers whose purpose is to flush
gpu caches, making the buffer data visible to the host.
Affects:
dEQP-VK.pipeline.push_constant.compute_pipeline.simple_test
dEQP-VK.glsl.builtin.precision.*
dEQP-VK.glsl.builtin.function.*
dEQP-VK.api.command_buffers.record_simul_use_secondary_one_primary
dEQP-VK.synchronization.op.single_queue.*
dEQP-VK.query_pool.occlusion_query.*
Components: Vulkan
VK-GL-CTS issue: 1898
Change-Id: Ic6a467b4d1db6cebebf34c8d386e519016fc3fe9
Alexander Galazin [Wed, 14 Aug 2019 12:04:45 +0000 (14:04 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I6c972fa2e2028e4f813ab96eb565c93c440faf9d
Alexander Galazin [Wed, 14 Aug 2019 11:52:47 +0000 (13:52 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I7f00708e05e1cf20c6439e52287d21eacf32ca01
Hsin-Hsiao Lin [Thu, 25 Jul 2019 07:13:34 +0000 (09:13 +0200)]
Provide a highp variable to MAKE_HIGH_BALLOT_RESULT
The MAKE_HIGH_BALLOT_RESULT macro assumes the input is 32bit.
Given a mediump variable, ex: gl_SubgroupSize, would produce an
undefined result when the input value is >= 16 and the computation
is in 16 bits.
Provide a highp input would ensure the computation is in 32 bits.
Affects:
dEQP-VK.subgroups.ballot_other.*
Components: vulkan
VK-GL-CTS issue: 1894
Change-Id: I22987f20be3d08444c52cb722fc23494777a5636
Fabio [Thu, 25 Jul 2019 15:08:16 +0000 (17:08 +0200)]
Update device_group test to ignore VK_SUBOPTIMAL_KHR
The transform used to create the swapchain does not match the
surface rotation. This causes vkQueuePresentKHR to return
VK_SUBOPTIMAL_KHR. This return code can be ignored.
Components: Vulkan
VK-GL-CTS Issue: 1899
Affects: dEQP-VK.wsi.android.swapchain.render.device_group
Change-Id: I27d8e61007dd049b8e9cc532918056b8493a9b52
Stephen Gallimore [Wed, 31 Jul 2019 15:24:57 +0000 (16:24 +0100)]
Add result buffer invalidates to depth stencil resolve tests
Components: Vulkan
VK-GL-CTS issue: 1907
Affects: dEQP-VK.renderpass2.depth_stencil_resolve.*
Change-Id: I90920f6005b0d6a72a78c588f4c3abec81826516
Chris Forbes [Sun, 28 Jul 2019 20:34:13 +0000 (13:34 -0700)]
Add missing checks for sampleShading feature
These cases were missed in the previous pass as they were masked by the
(correct) check for fragmentStoresAndAtomics.
Components: Vulkan
Affects: dEQP-VK.glsl.builtin_var.*
VK-GL-CTS Issue: 1901
Change-Id: I4d19c5075d14f60ead4c6df6370fffc870cde68a
Slawomir Cygan [Tue, 6 Aug 2019 19:53:18 +0000 (21:53 +0200)]
Fix wrong image usage flags in external memory info tests
According to spec:
"If usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, usage must
also contain at least one of VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT,
VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, or
VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT."
This change adds adds COLOR, DEPTH or INPUT usage bit alongside TRANSIENT usage.
VK-GL-CTS Issue: 1913
Components: Vulkan
Change-Id: If7d4b3889f9b8709af09d448fdb24e61d493ebde
Affects: dEQP-VK.api.external.memory*info
Ari Suonpaa [Tue, 23 Apr 2019 11:57:47 +0000 (14:57 +0300)]
Make random number usage platform independent
Generating multiple random numbers in argument
list can happen in different order depending on
implementation. This change makes these happen
in the same order with all implementations.
Affects:
dEQP-VK.api.granularity.*
dEQP-VK.draw.basic_draw.*
dEQP-VK.protected_memory.*
dEQP-VK.glsl.builtin.function.common.*
dEQP-VK.glsl.builtin.function.pack_unpack.*
dEQP-VK.glsl.texture_gather.*
dEQP-VK.spirv_assembly.*
dEQP-GLES3*.functional.shaders.builtin_functions.common.*
Components: Vulkan, OpenGL, Framework
(cherry picked from commit
0106f01209fe7abb7f4daf029318a1de17844c48)
VK-GL-CTS issue: 1591
Change-Id: Iaaff9625fd331ed7184efd50b89fc835c701ac6f
Arkadiusz Sarwa [Wed, 24 Jul 2019 10:41:42 +0000 (12:41 +0200)]
Fixes 64bit random values for 32bit CTS build
In 32bit build a 64bit random value is assigned
to 32bit value what cause different path of execution.
Components: Vulkan
VK-GL-CTS Issue: 1895
Affects:
dEQP-VK.memory.pipeline_barrier.all.*
Change-Id: I1f51b8b30be9a70ae82326609bc382431b8f3b80
Alexander Galazin [Tue, 23 Jul 2019 18:02:50 +0000 (20:02 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I4ed438d3edefade78a1602957d3d26fa777175c2
Panagiotis Apostolou [Fri, 12 Jul 2019 09:25:43 +0000 (11:25 +0200)]
Pipeline barriers flushing buffer data to host
Adds pipeline barriers after vkCmdDispatch which essentially flushes gpu
caches and the buffer data becomes visible to the host.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.*
dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop_opquantize.*
Components: Vulkan
VK-GL-CTS issue: 1880
Change-Id: Ib99a4ed9a1a2d57b286dea2251b3bc4a67002dfb
Igor Ostrowski [Mon, 15 Apr 2019 07:56:39 +0000 (09:56 +0200)]
Add compatible memory type check for given handle
Affects:
dEQP-VK.synchronization.win32_keyed_mutex.*
Components: Vulkan
VK-GL-CTS issue: 1866
Change-Id: I982bcd2e2ac15aa5cae403fcec859b28bcaf7999
Alexander Galazin [Fri, 12 Jul 2019 07:47:09 +0000 (09:47 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I01ed4686a43801a91df0459b821fd047f4858940
Boris Zanin [Mon, 8 Jul 2019 13:27:50 +0000 (15:27 +0200)]
Remove conformance version test from Android
Removes conformance version tests from android CTS.
Split tests designed to validate VK_KHR_driver_properties
into several smaller tests.
Add three more records into knownDriverIds.
Add:
* dEQP-VK.api.driver_properties.*
Remove:
* dEQP-VK.api.driver_properties
Components: vulkan
VK-GL-CTS issue: 1839
Change-Id: I9b591778c9833fd890c9af46cb87d9f5eb695dbd
Mike Byrne [Mon, 1 Jul 2019 10:53:36 +0000 (11:53 +0100)]
Fix Android WSI incremental present image tests
The pipeline for Android WSI incremental present image tests was not
provided with a valid scissor rect. This caused the tests to perform
incorrectly (and violates Vulkan requirements).
Affects: dEQP-VK.wsi.android.incremental_present.*
VK-GL-CTS Issue: 1867
Change-Id: I257ab8ae59a13e24fb299b6b47e925f3c105aecb
Components: Vulkan, AOSP
Alex Walters [Thu, 11 Jul 2019 14:17:53 +0000 (15:17 +0100)]
Exclude dEQP-VK.ssbo.layout.random.scalar.75
Remove dEQP-VK.ssbo.layout.random.scalar.75 from mustpass, added to
excluded test list. The shader length is quite extreme resulting in an
overly high runtime where certain devices can easily hit the watchdog.
Affects:
dEQP-VK.ssbo.layout.random.scalar.75
Components: Vulkan
VK-GL-CTS Issue: 1829
Change-Id: I57627fc895ed4a0e023e9f81e0cc6cdc203d2485
Slawomir Cygan [Tue, 9 Jul 2019 10:19:26 +0000 (12:19 +0200)]
Add support for building with Visual Studio 2019
Components: Framework
Change-Id: I52c92750e9e2874b86fd7bceea0070ad609909c1
Alexander Galazin [Thu, 4 Jul 2019 07:34:10 +0000 (09:34 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Id458e912df4bb49e821279d353b056d4baaac114
Yiwei Zhang [Sat, 22 Jun 2019 02:14:25 +0000 (19:14 -0700)]
Split shared_presentable_image tests into more dimensions to avoid timeout
Components: Vulkan
VK-GL-CTS Issue: 1842
Affects: dEQP-VK.wsi.*.shared_presentable_image.*
Change-Id: I957c106b756fab4be5b17f7d0a6d9ad2a14fce75
Mike Byrne [Mon, 24 Jun 2019 06:44:23 +0000 (07:44 +0100)]
Fix Android WSI shared presentable image test OOM
The dEQP-VK.wsi.android.shared_presentable_image.scale_down tests fail
intermittently with OOM errors. A simliar fix as implemented for
WSI incremental presentable image tests resolves this.
Affects: dEQP-VK.wsi.android.shared_presentable_image.scale_down.*
Components: Vulkan, AOSP
VK-GL-CTS Issue: 1858
Change-Id: Iee7a31560e46b6c449d14ec6e7c75d7406ae6d82
Mike Byrne [Tue, 25 Jun 2019 13:39:53 +0000 (14:39 +0100)]
Fix Android WSI shared presentable image tests
The pipeline for Android WSI shared presentable image tests was not
provided with a valid scissor rect. This caused the tests to perform
incorrectly (and violates Vulkan requirements).
Affects:
dEQP-VK.wsi.android.shared_presentable_image.scale_down.demand
dEQP-VK.wsi.android.shared_presentable_image.scale_down.continuous
VK-GL-CTS Issue: 1857
Change-Id: I060c12d7192945ecbe01dfcc8e89c03874b9b218
Components: Vulkan, AOSP
Maciej Jesionowski [Tue, 25 Jun 2019 16:31:04 +0000 (18:31 +0200)]
Fix vertex binding stride in rasterization.primitive_size.points
The graphics pipeline is using two vertex input attributes: position and color.
The vertex binding stride was incorrectly set to only the size of position,
rather than the size of position and color.
Components: Vulkan
VK-GL-CTS issue: 1851
Affects:
dEQP-VK.rasterization.primitive_size.points.*
Change-Id: I9a55386652788672c94547938933b4969407ac86
Mika Väinölä [Tue, 9 Apr 2019 13:28:45 +0000 (16:28 +0300)]
Fix Clang 8 and GCC 9 warnings
Rename some TYPE_LAST and STATE_LAST enums that produce variable
shadowing warnings with Clang 8. Reimplement tcu::Format::Hex methods
using stringstream and IO manipulators instead of format strings
and add a cast to deUint32 to fix warnings on GCC 9.
Component: Framework
VK-GL-CTS issue: 1631
Change-Id: Ide4b25c106810b725c5ed7caaaf676f02e81b368
(cherry picked from commit
31dd7a0b3c38181ebdaf10bdc95f8c591734c342)
Szymon Szczyrbak [Mon, 24 Jun 2019 07:21:33 +0000 (09:21 +0200)]
Fix wrong image usage flags in api feature info tests
According to spec:
"If usage includes VK_IMAGE_USAGE_TRANSIENT_ATTACHMENT_BIT, usage must
also contain at least one of VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT,
VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT, or
VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT."
This change adds isValidImageUsageFlagCombination() checks, so invalid
usage flag combinations are not used in test.
VK-GL-CTS Issue: 1850
Components: Vulkan
Affects:
dEQP-VK.api.info.image_format_properties2.*
dEQP-VK.api.info.sparse_image_format_properties2.*
Change-Id: Ibc0249686c6ee91ab3758918ab4067694730134c
Alexander Galazin [Wed, 19 Jun 2019 08:26:43 +0000 (10:26 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I790b99605bc605884329e9c71d58ce998443afe2
Chris Forbes [Fri, 14 Jun 2019 19:38:05 +0000 (12:38 -0700)]
Fix sample read tests to use sample rate shading
- The first shader uses gl_SampleID, so needs to run with sample rate
shading.
- Require the sampleRateShading device feature
Affects: dEQP-VK.renderpass*.sampleread.*
Components: Vulkan
VK-GL-CTS Issue: 1832
Change-Id: Ic99ac60581a546deb674db273d6438af8b5b7595
Alexander Galazin [Sun, 16 Jun 2019 18:19:44 +0000 (20:19 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I98bb1ccddd45a95d1f146e3b37d77c89e712034b
Alex Walters [Tue, 11 Jun 2019 15:42:33 +0000 (16:42 +0100)]
Fix image_extent test to handle OOM errors
The image_extent tests attempt to create a window with the maximum
supported extents, though it is not always possible to create such
a window due to platform memory constraints.
As long as the error was an out of memory error, allow the test to
pass. This fix only applies to the image_extent sub-test.
Affects:
dEQP-VK.wsi.*.swapchain.create.image_extent
Components: Vulkan
VK-GL-CTS issue: 1780
Change-Id: I5ac5439417424d101f6dc8d4f92da79b8fda2313
Alexander Galazin [Tue, 21 May 2019 08:31:32 +0000 (10:31 +0200)]
Whitelist Vulkan CTS 1.1.4.2
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: I67bcb51a4bde4253c8cd81735729459cea3d0f24
Alexander Galazin [Thu, 6 Jun 2019 15:10:54 +0000 (17:10 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Id4adb91216cbc973009a884cf29f1d6fa4412980
Joerg Wagner [Sun, 2 Jun 2019 16:11:57 +0000 (18:11 +0200)]
Handle 1.0 vs 1.1 differences for VK_KHR_device_group
Several entry points are expected to be enabled through
VK_KHR_device_group under Vulkan 1.0 but were moved to
VK_KHR_swapchain under Vulkan 1.1
Account for the subtle difference by taking the apiVersion
into account when checking extension entry point exposure.
Affects:
dEQP-VK.api.version_check.entry_points
Components: Framework, Vulkan
VK-GL-CTS issue: 1802
Change-Id: Ic47d53cd4dcac24282d054eeae671464509235c9
Chris Forbes [Mon, 3 Jun 2019 14:38:47 +0000 (07:38 -0700)]
Check for toplevel sparse binding support bit in sparse pipeline tests
VK-GL-CTS Issue: 1806
Components: Vulkan
Bug: b/
130838280
Affects: dEQP-VK.pipeline.multisample.*sparse
Change-Id: I18f0960228e24dddcfee6d85c2c4ae647439a3c6
Alexander Galazin [Thu, 6 Jun 2019 12:14:06 +0000 (14:14 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iacf5cbc1f08c49bf71e46b0959514ee9dcfeb21f
Alexander Galazin [Thu, 6 Jun 2019 11:25:43 +0000 (13:25 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ie2fcbf82b366c324d4b48ddeaffd0b5654cf2d60
Yiwei Zhang [Tue, 4 Jun 2019 02:18:13 +0000 (19:18 -0700)]
Add a checker for vkQueuePresent returning VK_SUBOPTIMAL_KHR
Components: Vulkan
VK-GL-CTS Issue: 1811
Affects: dEQP-VK.wsi.*
Affects: dEQP-VK.protected_memory.interaction.wsi.*
Change-Id: I81320fb9fee34c6d1ec006d0a66d482eb2f8fb7c
Chris Forbes [Mon, 3 Jun 2019 17:45:28 +0000 (10:45 -0700)]
Fix more sampleShading issues in dEQP-VK.pipeline.multisample_shader_builtin.*
The `pattern` case here does not require per-sample shading, and the
request for the feature is easily disabled. The `write` case could
potentially also run without per-sample shading, but is plumbed
differently, so I have not adjusted it to run per-pixel.
All remaining cases which used per-sample shading have been
adjusted to check for the sampleShading feature efore running.
VK-GL-CTS Issue: 1807
Affects: dEQP-VK.pipeline.multisample_shader_builtin.sample_mask.*
Components: Vulkan
Change-Id: Iab86205fa89ace6f55ad00ba3fc51e2745a28744
Alexander Galazin [Wed, 5 Jun 2019 10:38:33 +0000 (12:38 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Idfd64426bcfb647d1725a05becd0e0a30f59768b
Martin Freebody [Fri, 24 May 2019 13:30:32 +0000 (14:30 +0100)]
Fix for SSBO offset alignment
Affects: dEQP-VK.ssbo.unsized_array_length.*
Components: Vulkan
VK-GL-CTS issue: 1796
Change-Id: I8953c2a58fe90a3165aa3255e542336a0c6d0a1e
(cherry picked from commit
eaa8fbf9c0e15e36e7c202947fbc13216761dbf6)
Martin Freebody [Fri, 24 May 2019 13:30:32 +0000 (14:30 +0100)]
Fix for SSBO offset alignment
Affects: dEQP-VK.ssbo.unsized_array_length.*
Components: Vulkan
VK-GL-CTS issue: 1796
Change-Id: I8953c2a58fe90a3165aa3255e542336a0c6d0a1e
Alexander Galazin [Fri, 31 May 2019 09:59:41 +0000 (11:59 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I9d51446c4b7c61633be355ded691af9785645802
Yiwei Zhang [Thu, 16 May 2019 05:22:36 +0000 (22:22 -0700)]
Split incremental_present tests into more dimensions to avoid timeout
Components: Vulkan
VK-GL-CTS Issue: 1778
Affects: dEQP-VK.wsi.android.incremental_present.*
Bug:
132817706
Test: dEQP-VK.wsi.android.incremental_present.*
Change-Id: I54168fe61bda31654696fcfbd71b37ce29fc7ba4
Matthew Netsch [Tue, 28 May 2019 23:37:16 +0000 (19:37 -0400)]
Fixes protected memory swapchain image format oom
Some image format test cases (like the image extent cases)
could create configs too large for the protected heap
Components: Vulkan
VK-GL-CTS Issue: 1793
Affects:
dEQP-VK.protected_memory.interaction.wsi.android.swapchain.create.image_format
Change-Id: If98f43a85ff289d091e3bb7c75d998a666efac80
Matthew Netsch [Wed, 29 May 2019 17:13:34 +0000 (13:13 -0400)]
Split compute workload into multiple submissions
Reduces workload per submission
Components: Vulkan
VK-GL-CTS Issue: 1751
Affects:
dEQP-VK.memory_model.message_passing.*
Change-Id: I4834dda74b95b802b2e39df42af9efd3c643208a
Alexander Galazin [Thu, 30 May 2019 10:29:11 +0000 (12:29 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I7a134ecbc159b4f01dfbb3456ffd9c526a0d9f22
Chris Forbes [Tue, 28 May 2019 16:32:39 +0000 (09:32 -0700)]
Require variablePointersStorageBuffer feature in pointer_parameter tests
These tests declare OpCapability VariablePointersStorageBuffer but don't
check for the feature.
Components: Vulkan
Affects: dEQP-VK.spirv_assembly.instruction.graphics.pointer_parameter.buffer_memory_variable_pointers*
VK-GL-CTS Issue: 1792
Change-Id: I81fb83b473c484b151caf212ecd2348c72494f1d
Matthew Netsch [Thu, 23 May 2019 13:06:45 +0000 (09:06 -0400)]
Fixes precise occlusion query tests
Individual test cases were not isolated
so they interfered with each other
Components: Vulkan
VK-GL-CTS Issue: 1784
Affects:
dEQP-VK.query_pool.occlusion_query.*precise*
Change-Id: I6ad422612c80c6aa5efc90fd90e0e7ce91e9f8bb
Alexander Galazin [Fri, 24 May 2019 08:50:49 +0000 (10:50 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iaf1958f4db9588eba3ea77b4a1e7d41b4fc20c13
Alexander Galazin [Fri, 24 May 2019 07:48:11 +0000 (09:48 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ided1b0de70eddb65bb70983ed341435dc3a99621
Jeff Bolz [Fri, 7 Dec 2018 01:38:40 +0000 (19:38 -0600)]
Waiver for device-scope core memory model tests.
https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/1356
Components: Vulkan
Affects: dEQP-VK.memory_model.*core11*.device.*
Change-Id: Ibf5d1ca0232471246ac16a9491d9ae54d87c74a8
Alexander Galazin [Wed, 22 May 2019 10:21:27 +0000 (12:21 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Ibdcd0cae47c3eca35db283b67a62e21de81e5cf3
Ilkka Saarelainen [Wed, 15 May 2019 12:01:14 +0000 (15:01 +0300)]
Add GeometryPointSize feature check
Some tests were using gl_PointSize without checking if the
shaderTessellationAndGeometryPointSize feature is supported and enabled.
This CL adds the feature checks to those tests. If the feature is not
supported/enabled, an alternative geometry shader code without
gl_PointSize will be used.
Affects:
dEQP-VK.glsl.*geometry
dEQP-VK.ycbcr.*geometry*
dEQP-VK.query_pool.*
dEQP-VK.transform_feedback.simple.streams_pointsize*
Components: Vulkan
VK-GL-CTS issue: 1763
Change-Id: If58bb5129144bae8d51dca84a3d0c89b46be1343
(cherry picked from commit
d4b80f34b70ae497b6bb0573859209ae28197a35)
Ilkka Saarelainen [Wed, 15 May 2019 12:01:14 +0000 (15:01 +0300)]
Add GeometryPointSize feature check
Some tests were using gl_PointSize without checking if the
shaderTessellationAndGeometryPointSize feature is supported and enabled.
This CL adds the feature checks to those tests. If the feature is not
supported/enabled, an alternative geometry shader code without
gl_PointSize will be used.
Affects:
dEQP-VK.glsl.*geometry
dEQP-VK.ycbcr.*geometry*
dEQP-VK.query_pool.*
dEQP-VK.transform_feedback.simple.streams_pointsize*
Components: Vulkan
VK-GL-CTS issue: 1763
Change-Id: If58bb5129144bae8d51dca84a3d0c89b46be1343
(cherry picked from commit
d4b80f34b70ae497b6bb0573859209ae28197a35)
Alexander Galazin [Wed, 22 May 2019 06:46:41 +0000 (08:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Iaaff1bd558b7938a73c553c312f8271a8e288cd3
Toni Merilehti [Wed, 15 May 2019 14:49:42 +0000 (17:49 +0300)]
Add feature checks to shader builtin tests
Some shader builtin tests use SampleId and SamplePosition BuiltIns
in shaders, which both require the SampleRateShading OpCapability
and the sampleRateShading Vulkan feature. This CL adds the missing
feature checks when required by the shaders.
Affects:
dEQP-VK.pipeline.multisample_shader_builtin.sample_id.*
dEQP-VK.pipeline.multisample_shader_builtin.sample_position.*
Components: Vulkan
VK-GL-CTS issue: 1744
Change-Id: I4557b5cd79191f7ca1202562416d12d3b1d8ce60
(cherry picked from commit
3f2ce1e5bcf568fe0a65a4ed638e0589b8694482)
Chris Forbes [Fri, 17 May 2019 15:48:42 +0000 (08:48 -0700)]
Check for imageCubeArray feature in image tests
Components: Vulkan
Affects: dEQP-VK.image.*cube_array*
VK-GL-CTS Issue: #1781
Change-Id: Idbf3e96481336820520a46293ca3eaf74b21654d
Chris Forbes [Thu, 16 May 2019 00:18:47 +0000 (17:18 -0700)]
Check for required features in memory model tests
All of these tests expect to be able to write to storage buffers; check
for the vertexPipelineStoresAndAtomics or fragmentStoresAndAtomics
features as appropriate.
VK-GL-CTS Issue: 1777
Components: Vulkan
Affects: dEQP-VK.memory_model.*
Change-Id: I51adeda82ba7af22368c239a6abfc481479700f1
Bas Nieuwenhuizen [Thu, 2 May 2019 21:13:14 +0000 (23:13 +0200)]
Fix image sizes for formats that need a multiple of 2.
All these have in their format definition something like
"Images in this format must be defined with a width that is a multiple
of two."
in their format definition.
This patch makes sure we actually use even sizes for images with these
formats.
It is not ideal that I have to hardcode these lists but I don't know a
better source to get them from.
Affects:
dEQP-VK.api.invariance.random
Components: Vulkan
VK-GL-CTS issue: 1766
Change-Id: Ie19583db56e7ae483136e1fb4651ae625efb9c02
Alexander Galazin [Mon, 20 May 2019 10:24:42 +0000 (12:24 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I7cb87c9d21e2ba725b199ee59663ece150333993
Alexander Galazin [Mon, 20 May 2019 09:40:23 +0000 (11:40 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I782d2f2d769d92e11f7e558cdefb56d187fe53e6
Alexander Galazin [Mon, 20 May 2019 08:58:43 +0000 (10:58 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I0fd601c9fc32f66eb7e45322801a930d4f33c4dc
Alexander Galazin [Mon, 20 May 2019 08:12:17 +0000 (10:12 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ib38bd02e2ed4c74ee845e19eb25b8de05fb0e312
Ari Suonpaa [Tue, 30 Apr 2019 10:36:09 +0000 (13:36 +0300)]
Check for largePoints feature and add 1px test variant
Pipeline multisample tests were using point size of 3
without checking for largePoints feature. Now the feature
is checked and a 1 pixel variant is also added.
Affects:
dEQP-VK.pipeline.multisample.*.primitive_point
New tests:
dEQP-VK.pipeline.multisample.*.primitive_point_1px
Components: Vulkan
VK-GL-CTS issue: 1739
Change-Id: I0eef68b8194a1026a98b19579d1d3c1b7f9c9cc7
(cherry picked from commit
c382ec855438509b201c4aa5eff6b730534f2f3c)
Boris Zanin [Thu, 16 May 2019 15:23:19 +0000 (17:23 +0200)]
Remove incorrect unroll_dont_unroll test
According SPIR-V validator: Unroll and DontUnroll
loop controls must not both be specified.
Remove tests:
* dEQP-VK.spirv_assembly.instruction.compute.loop_control.unroll_dont_unroll
Affects:
* dEQP-VK.spirv_assembly.instruction.compute.loop_control.*
VK-GL-CTS issue: 1779
Change-Id: Ib799f96a290bb08df1175f1dc6f6d212314665af
Chris Forbes [Wed, 15 May 2019 17:38:01 +0000 (10:38 -0700)]
Don't set sampleShadingEnable in dEQP-VK.pipeline.framebuffer_attachment.*
These tests don't need per-sample shading, and didn't check for whether
it was supported by the device.
Components: Vulkan
Affects: dEQP-VK.pipeline.framebuffer_attachment.*ms
VK-GL-CTS Issue: 1776
Change-Id: Ic8477262410e1531c1acabe494c2cf64c199dd6b
Lingfeng Yang [Fri, 8 Feb 2019 15:36:00 +0000 (07:36 -0800)]
Fix stack underflow in incremental present test
This uses the current object's m_queueFamilyIndex instead of a queue
family index that is on the stack, avoiding using a stale stack address
when the test runs.
VK-GL-CTS issue: 1585
Affects:
dEQP-VK.wsi.*.incremental_present.*
Components: Vulkan
Change-Id: I80228651b799d3444676cdcbf5cc845bcb195fe9
(cherry picked from commit
a268922558ed0c353a7d8b6845f8d6279b72af29)
Alexander Galazin [Fri, 10 May 2019 10:06:12 +0000 (12:06 +0200)]
Update fetch_sources.py to Python 3
Components: Framework
Change-Id: I7f75a084e5128b1a19be7649a06a315e91a36688
(cherry picked from commit
9c4f100a056b084876e874a1b115192225b9a61a)
Graeme Leese [Mon, 14 Jan 2019 19:01:56 +0000 (19:01 +0000)]
Tests for VK_KHR_uniform_buffer_standard_layout
Enables the existing std430 UBO tests based on support for the
extension.
Components: Vulkan
Affects: dEQP-VK.ubo.*.std430.*
Change-Id: I224377696979eea0ac8ca0b3f190414909ddc0a8
(cherry picked from commit
00a15d59264d0853c5d9ef2a0178293f536a3d29)
Alexander Galazin [Fri, 10 May 2019 06:14:38 +0000 (08:14 +0200)]
Whitelist Vulkan CTS 1.1.4.1
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: Iad3e3c27e48585dc2143f8bf800a4ed56d9f2f01
Alexander Galazin [Thu, 9 May 2019 18:40:58 +0000 (20:40 +0200)]
Update gen_framework_c.py for python3
Components: Framework
Change-Id: If332d1f79f6f861fd49d16ee700967bdcf80b598
Alexander Galazin [Thu, 9 May 2019 18:02:47 +0000 (20:02 +0200)]
Update SPIR-V Tools
Components: Framework
Change-Id: I6f5971307e97ed55bd7c2164a94dd997784e0105
Alexander Galazin [Tue, 23 Apr 2019 19:09:43 +0000 (21:09 +0200)]
Require Python 3
Require Python 3 as some components used by the CTS already need it.
Update SPIR-V Tools: Fixes build issues on Windows and OpUnreachable validation.
Components: Framework, AOSP, Vulkan, OpenGL
Affects: dEQP-VK.*, builds
VK-GL-CTS issue: 1665
VK-GL-CTS issue: 1627
VK-GL-CTS issue: 1716
Change-Id: I719574b50aa16fdb0d06e85981a029ae8e0c4416
(cherry picked from commit
b1e5e376ccb021339741c927f99d9c2378ecc6cc)
Eric Werness [Tue, 20 Nov 2018 17:34:06 +0000 (09:34 -0800)]
Update generate scripts for python3
Components: Framework
Change-Id: Ia3db51e520ffbab7613f9948f23e6320b2815462
(cherry picked from commit
c7ebd5a8c32ae0b16789fc700d62502a5891aeae)
Eric Werness [Fri, 16 Nov 2018 21:50:40 +0000 (13:50 -0800)]
Support Python3 as well in gen_release_info.py
The CMake file version check can end up picking python3 in some cases -
making the Python code compatible with python3 seems easier than
adjusting the version check.
Components: Frameworks
Change-Id: Iab37090ab813dcb7839490225ca2a4bf2f721c12
(cherry picked from commit
f1bcdd5e9df1f83cc9dc4ef7235d3da16e9f7fab)
Alexander Galazin [Thu, 9 May 2019 09:46:54 +0000 (11:46 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Icae001e33d6a01954a6461d38bc8226abb48775e
Alexander Galazin [Thu, 9 May 2019 09:15:26 +0000 (11:15 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I015156c0e368515b0cecc70775a82a5537baa341
Slawomir Cygan [Mon, 29 Apr 2019 11:45:02 +0000 (13:45 +0200)]
Fix regression in subgroups tests after merging
393912cd
This extends the additional verification to catch uninitialized memory from
commit
393912cd to tests added in 1.1.3, so after
393912cd.
This fixes regression that occured on master after
393912cd was merged.
Components: Vulkan
VK-GL-CTS Issue: 1757
Change-Id: Icb7fe91ee2839626d8ebc90ae2788f85b0e835b7
Affects: dEQP-VK.subgroups.basic.framebuffer.*tess*
Matthew Netsch [Thu, 25 Apr 2019 18:41:15 +0000 (14:41 -0400)]
Fixes linear support check for pipeline tests
Removes old workaround for certain formats
Components: Vulkan
VK-GL-CTS Issue: 1755
Affects:
dEQP-VK.pipeline.sampler.*
Change-Id: Ia35303f11132f84560f06c13c7a94e3f9be888db
Chris Forbes [Fri, 3 May 2019 20:53:14 +0000 (13:53 -0700)]
Check for depthBiasClamp feature before using it
VK-GL-CTS Issue: 1764
Affects: dEQP-VK.dynamic_state.rs_state.depth_bias_clamp
Change-Id: Iccd05a1eac2285125847a392c4065d36c88cb426
Chris Forbes [Wed, 1 May 2019 14:43:48 +0000 (07:43 -0700)]
Check for imageCubeArray support before using VK_IMAGE_VIEW_TYPE_CUBE_ARRAY
VK-GL-CTS Issue: 1761
Components: Vulkan
Affects: dEQP-VK.binding_model.shader_access.*cube_array*
Change-Id: I918227d1518c3d7f6cefd7931531aafb34fcf9f8
Alexander Galazin [Sun, 28 Apr 2019 12:33:14 +0000 (14:33 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: Ief71fa1e4d028988c1e5bc9c0d477787c8a1fcd6
Alexander Galazin [Sun, 28 Apr 2019 08:36:59 +0000 (10:36 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I71fc7f7b5ccaf55f0ad0ec40d4e0720bebbabb50
Graeme Leese [Tue, 9 Apr 2019 11:25:19 +0000 (12:25 +0100)]
Reduce expected precision of RGB10A2 filtering
The code in the YCbCr tests says that it was copied from the texture
explicit lod tests, but those tests give rgb10a2 a 'low' precision, not
'fp16'. Reduce the precision expected in the YCbCr tests.
Components: Vulkan
VK-GL-CTS Issue: 1731
Affects: dEQP-VK.ycbcr.*
dEQP-VK.protected_memory.interaction.ycbcr.*
Change-Id: Ib0ae233fc271ded2f9987fe448dcd351e509a0c4
(cherry picked from commit
5deebf4709ed3e2c3aaad3b8bb8703f236309b97)
Carl Ritson [Thu, 14 Mar 2019 16:25:30 +0000 (16:25 +0000)]
Fix memory initialisation in subgroups tests
Subgroup tests expand memory allocations to accommodate std140 layout
shaders; however, the extra memory is not initialised.
This changes initialisation to be based on the actually allocated
buffer size and adds additional verification to catch uninitialised
memory.
Affects:
dEQP-VK.subgroups.*
Components: Vulkan
VK-GL-CTS Issue: 1639
Change-Id: I0dfc0abb9bcbe63b5d1d5ad43e6fee99389fdfa2
Matthew Netsch [Wed, 24 Apr 2019 16:02:30 +0000 (12:02 -0400)]
Fixes pipeline tests to check for maxSamplerLodBias
Components: Vulkan
VK-GL-CTS Issue: 1750
Affects:
dEQP-VK.pipeline.sampler.*
Change-Id: I1ed594f0eb5cf8e249eda5eb31b114f1bfb93fd2
Alexander Galazin [Wed, 24 Apr 2019 05:59:25 +0000 (07:59 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I558e81a43c829769f170c4b26f3b290d88cf708e
Alexander Galazin [Tue, 23 Apr 2019 18:10:25 +0000 (20:10 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: If4d754edf8a5c942ebf51fcbb3a71d87bfbc7856
Alexander Galazin [Tue, 23 Apr 2019 17:13:22 +0000 (19:13 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I578c423d59f3c21357dd6f448f68cee5b46a98d0
Alexander Galazin [Tue, 23 Apr 2019 16:47:53 +0000 (18:47 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I4e639df46cf1f19a0bde8a061fa54d0bc1f7732d
Dan Sinclair [Mon, 15 Apr 2019 19:55:23 +0000 (15:55 -0400)]
Roll Amber.
This Cl rolls the Amber version to pickup the removal of
CopyBitsOfValueToBuffer which is triggering alignment errors on certain
platforms.
d26ee22 Unify buffer sizes. (#465)
dd5b5e6 Convert ProbeSSBO to use Format objects. (#464)
ee7662c Add doc/engines.md (#463)
d84f541 Convert BufferCommand to use Format. (#462)
e8302e1 Dawn engine: refactor (#455)
5299cf3 Move Format up into base Buffer class (#461)
847634a Use Format instead of DatumType where possible. (#460)
e968f5c AmberScript and README updates (#459)
d4e543b Add Buffer::GetFormat (#458)
ae06ff8 Simplify Format::GetBytesize; rename to SizeInBytes (#457)
b322b20 [vulkan] Allow setting vertex buffer with a data buffer (#450)
43248b2 [AmberScript] Add DERIVE_PIPELINE (#453)
5397303 Dawn engine: Adapt to latest Dawn API. (#454)
77b90e8 Update Dawn config file (#440)
6a39267 [vulkan] copy fb data onto device (#452)
7f72bbf [vulkan] Add a write framebuffer state; cleanup (#449)
a8acd2e Generate a Format from a DataBuffer. (#448)
da78976 [vulkan] TransferImage knows current layout and stage (#445)
1f834b8 [amberscript] Add REPEAT command (#443)
1806fc6 [amberscript] Fix BUFFER commands in examples (#447)
135cef4 Add EXPECT EQ_BUFFER command (#444)
c5afcf2 Add amber overview doc (#442)
3ba9e39 [vulkan] simplify image transition code. (#441)
VK-GL-CTS issue: 1735
Components: Framework
Affects: dEQP-VK.*
Change-Id: If13ab968d26aec30c7a5bf4ebde952e6947c00fa
(cherry picked from commit
532f56f72878c4b1ba4230debc90e0bafe51b4b5)
Boris Zanin [Thu, 11 Apr 2019 08:07:12 +0000 (10:07 +0200)]
Add float 16 calculation into FMA tests
Add one more calculation flavor into calculation
Float16 FMA tests.
Updates:
* dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic*.fma
* dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic*.fma*
Components: Vulkan
VK-GL-CTS issue: 1730
Change-Id: Ic3c378a75d23afcafb0f6ce7052351d70d4d30bc
(cherry picked from commit
67a010acd731667bcf067652d11ba494f0afff95)
Juan A. Suarez Romero [Mon, 15 Apr 2019 16:39:12 +0000 (16:39 +0000)]
Create YCbCr with PREDEFINED layout
This fixes validation errors due mismatch with the expected initial
layout.
Affects:
* dEQP-VK.ycbcr.conversion.*
Components: Vulkan
VK-GL-CTS issue: 1737
Change-Id: If30f5ebb73529850c6bbafcd8e42bed6143864c3
(cherry picked from commit
bcfe10d9aa5dbdb05296a5891e358b3581288845)
Chris Forbes [Mon, 15 Apr 2019 23:03:23 +0000 (16:03 -0700)]
Check for geometry shader support when testing adjacency topologies
Clipping tests would attempt to create pipelines using adjacency
topologies without checking for geometry shader support.
This seems to be a benign failure on most real implementations, but is a
VU violation.
Affects: dEQP-VK.clipping.clip_volume.*
VK-GL-CTS Issue: 1738
Change-Id: Iac6cfc6a669f2e533ce8ceaf4e7c2448b9fe4883
(cherry picked from commit
9c97d200e33e781ebb9f85df1195bcb84e013833)
ygole [Wed, 27 Mar 2019 11:38:37 +0000 (17:08 +0530)]
Add hasDisplay check after createWsiDisplay throws
Commit
b7efacd7b3 (Check if CTS has platform display for wsi-type) added
checks after createWsiDisplay failure to prevent reporting test failure
if native display for requested wsi-type isn't avaiable. This situation
can occur if vulkan driver supports multiple wsi extensions and only one
native display is available. Change did not fix all the places where
createWsiDisplay is called. The check is missing in file
vktImageMutableTests.cpp so fix it.
Affects: dEQP-VK.image.swapchain_mutable.*
Components: Vulkan, Framework
VK-GL-CTS issue: 1558
Change-Id: Iffc50a70ed48fb18c4d609c8d74b8e4615e4297d
(cherry picked from commit
984a7606ec93dfe90a17127357c7f0b0262bcd51)
Toni Merilehti [Thu, 11 Apr 2019 10:18:14 +0000 (13:18 +0300)]
Add feature checks to spirv assembly tests
Adds missing checks for vertexPipelineStoresAndAtomics and
fragmentStoresAndAtomics core device features to spirv assembly
tests when required by the shaders.
Affects:
dEQP-VK.spirv_assembly.instruction.graphics.*
Components: Vulkan
VK-GL-CTS issue: 1725
Change-Id: I33af3faac948913f2f5ac7a4d385c323b00e5444
(cherry picked from commit
c71c2e3a5afa19c68c0ad9a03d18c06d2997b2c3)
Alexander Galazin [Fri, 22 Mar 2019 09:06:18 +0000 (10:06 +0100)]
Fix uninitialized variable reported by gcc 8.3
VK-GL-CTS issue: 1656
Components: Vulkan
Affects: dEQP-VK.sparse_resources.*
Change-Id: I298c795b05c0c204f04970da7a923f797c4478b8
(cherry picked from commit
1dadbfc46128054db7679bb662eba16b20a241c1)
Joan Orantos [Tue, 16 Apr 2019 13:42:20 +0000 (15:42 +0200)]
Fix element size for R16G16B16A16_UNORM.
The PlanarFormatDescription set for this format
was specifying 16 bytes instead of 8. This would
generate wrong input image on the test group
dEQP-VK.ycbcr.conversion.r16*
Components: Vulkan
Affects:
dEQP-VK.ycbcr.conversion.r16*
VK-GL-CTS issue: 1740
Change-Id: Ic364128febaa3b85b9ade767049e4f4f3f894357
Alexander Galazin [Tue, 16 Apr 2019 10:23:41 +0000 (12:23 +0200)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/vulkan-cts-1.1.4
Change-Id: I9a6fa607958cf6864cec912aa0bfc6edf27224cf