Fix vertex/index buffer leaks

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1123823004

Add matrix configs to DM

BUG=skia:832

Review URL: https://codereview.chromium.org/1125793002

DM: add a Via to simulate SP pictures.

Will use this to test the other CL that adds small SkPicture implementations.

Not quite sure why patch_primitive doesn't draw the same in 8888 and sp-8888, but everything else does, so I'm not going to let that hold me back for now.

BUG=skia:

Review URL: https://codereview.chromium.org/1126613005

Make drawImage a virtual on SkDevice

Now with patch for SkDeferredCanvas

This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57.

BUG=skia:

Review URL: https://codereview.chromium.org/1122643005

add DeferredCanvas mode to SampleApp

BUG=skia:

Review URL: https://codereview.chromium.org/1129603002

create GrInOrderCommandBuilder

BUG=skia:

Review URL: https://codereview.chromium.org/1118403003

DM: add draw_to_canvas() to trim some boilerplate for Vias.

BUG=skia:

Review URL: https://codereview.chromium.org/1123743007

remove dead code behind BOOL_ONGETINFO

need this to land in chrome first https://codereview.chromium.org/1125573002

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1123473004

SkPDF: Remove unused deprecated functions in SkPDFTypes

depends on:
    http://crrev.com/1107923002
    http://crrev.com/1103163002
    http://crrev.com/1110533002
    http://crrev.com/1107913002
    http://crrev.com/1106163002

BUG=skia:3585

Review URL: https://codereview.chromium.org/1113583002

Move RectBatch to GrRect

BUG=skia:

Review URL: https://codereview.chromium.org/1127713002

Add presubmit to run `{dm,nanobench}_flags.py test` when changed.

BUG=skia:

Review URL: https://codereview.chromium.org/1129443005

SkPDF: clean up uses of deprecated calls in SkPDFFont

BUG=skia:3585

Review URL: https://codereview.chromium.org/1110533002

Move DrawInfo out from GrDrawTarget and rename to GrVertices.

Review URL: https://codereview.chromium.org/1124733004

Create GrCommandBuilder

BUG=skia:

Review URL: https://codereview.chromium.org/1113313003

Blacklist tiles_rt-gpu gm imagefilterscropped on GalaxyS4

BUG=skia:3802

Review URL: https://codereview.chromium.org/1115303004

add deferred config to DM

BUG=skia:

Review URL: https://codereview.chromium.org/1113273006

Adjust tolerance to fix GPU hairline curve issues

BUG=chromium:472847

Review URL: https://codereview.chromium.org/1126793003

SkPDF: clean up uses of deprecated calls in SkDocument_PDF

BUG=skia:3585

Review URL: https://codereview.chromium.org/1107913002

Avoid using SkPathEffect::DashInfo in GrStrokeInfo

Avoid using SkPathEffect::DashInfo for storing the phase
in GrStrokeInfo. Instead, just use normal instance variables.

Fixes the copy constructor pointing the DashInfo interval pointer
to the wrong interval data.

Also fixes GrStrokeInfo::setDashInfo(const SkPathEffect::DashInfo&)
by updating the fDashType correctly.

Makes it simpler to write code such as the operator== in the future.

Review URL: https://codereview.chromium.org/1110093002

remove dead code for  SK_SUPPORT_LEGACY_RADIAL_GRADIENT_SQRT

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1122933002

cleanup

BUG=skia:

Review URL: https://codereview.chromium.org/1085583006

remove dead SK_SUPPORT_LEGACY_CUBIC_CHOPPER code

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1116263005

Start on simplifying generateGeometry() overrides

Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963

Review URL: https://codereview.chromium.org/1122673002

Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188… (patchset #2 id:20001 of https://codereview.chromium.org/1122813002/)

Reason for revert:
did not update DeferredCanvas

Original issue's description:
> Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/)"
>
> Fixed serialization from prev CL
>
> This reverts commit 973d1f1f60f2710a268a3165aa4f3460502d4be5.
>
> BUG=skia:3803
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/5392785080001fe737fac9e5801fc2127a78d4fb

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803

Review URL: https://codereview.chromium.org/1123743006

Remove canTweakAlphaForCoverage from XP's since batch reads flag.

BUG=skia:

Review URL: https://codereview.chromium.org/1127693002

Fix typeface ids on Mac.

The current typeface ids with CoreText rely on ATS (which causes
memory use issues) or font data (which is unreliable, and will not
work with axes and synthetics). This changes the code so that stream
fonts never end up in the cache and always get a unique id, and
system fonts will be given an id as they are used.

Review URL: https://codereview.chromium.org/1125763002

Don't attempt to draw path if dashing or stroking fails

TBR=egdaniel@google.com

Committed: https://skia.googlesource.com/skia/+/39202f12d37b6ef69ffaddcaa8cc92c621fcda41

Review URL: https://codereview.chromium.org/1119393002

Revert of Start on simplifying generateGeometry() overrides (patchset #10 id:160001 of https://codereview.chromium.org/1122673002/)

Reason for revert:
Breaking bots

Original issue's description:
> Start on simplifying generateGeometry() overrides
>
> Committed: https://skia.googlesource.com/skia/+/f28381c6866cad92af8ebe5b9d2db074613b1963

TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1124633003

Start on simplifying generateGeometry() overrides

Review URL: https://codereview.chromium.org/1122673002

Revert of Don't attempt to draw path if dashing or stroking fails (patchset #1 id:1 of https://codereview.chromium.org/1119393002/)

Reason for revert:
Doesn't draw

Original issue's description:
> Don't attempt to draw path if dashing or stroking fails
>
>
> TBR=egdaniel@google.com
>
> Committed: https://skia.googlesource.com/skia/+/39202f12d37b6ef69ffaddcaa8cc92c621fcda41

TBR=egdaniel@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1119423002

ignore_result()

BUG=skia:3801

Review URL: https://codereview.chromium.org/1127603003

Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/)"

Fixed serialization from prev CL

This reverts commit 973d1f1f60f2710a268a3165aa4f3460502d4be5.

BUG=skia:3803
TBR=

Review URL: https://codereview.chromium.org/1122813002

Get debugger compiling again

Review URL: https://codereview.chromium.org/1125543003

Move state management to GrInOrderDrawBuffer

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269

Review URL: https://codereview.chromium.org/1120143002

Don't attempt to draw path if dashing or stroking fails

TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1119393002

Move instanced index buffer creation to flush time

Committed: https://skia.googlesource.com/skia/+/ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26

Review URL: https://codereview.chromium.org/1116943004

Revert of Move instanced index buffer creation to flush time (patchset #6 id:100001 of https://codereview.chromium.org/1116943004/)

Reason for revert:
messed up caching, recreating index buffers all the time.

Original issue's description:
> Move instanced index buffer creation to flush time
>
> Committed: https://skia.googlesource.com/skia/+/ab622c7b8cc8c39f0a594e4392b9e31b7e1ddb26

TBR=joshualitt@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1126613003

Revert of make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/)

Reason for revert:
need to make serialization work for pictures, now that images are "real"

Original issue's description:
> make drawImage a virtual on SkDevice
>
> default impl will turn the Image into a (raster) bitmap and call drawBitmap.
>
> BUG=skia:3803
>
> Committed: https://skia.googlesource.com/skia/+/f603fb3d0e5fa57c3f228d66945bef198b001135

TBR=bsalomon@google.com,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3803

Review URL: https://codereview.chromium.org/1122803002

remove redundant/deprecated TwoPointRadial gradiet -- use TwoPointConical

This CL derived from https://codereview.chromium.org/1114243005/

BUG=skia:

Review URL: https://codereview.chromium.org/1117423003

make drawImage a virtual on SkDevice

default impl will turn the Image into a (raster) bitmap and call drawBitmap.

BUG=skia:3803

Review URL: https://codereview.chromium.org/1118823004

Move instanced index buffer creation to flush time

Review URL: https://codereview.chromium.org/1116943004

Support SKIA_OUT on Mac and ChromeOS

BUG=skia:3774

Review URL: https://codereview.chromium.org/1122593003

Revert of Move state management to GrInOrderDrawBuffer (patchset #4 id:60001 of https://codereview.chromium.org/1120143002/)

Reason for revert:
Breaks windows

Original issue's description:
> Move state management to GrInOrderDrawBuffer
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269

TBR=bsalomon@google.com,robertphillips@google.com,joshualitt@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1119353002

Move state management to GrInOrderDrawBuffer

BUG=skia:

Review URL: https://codereview.chromium.org/1120143002

Update src/svg to follow C++11 style rule for {virtual,override}.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual
and final implies both virtual and override.

The entries were found using the following command line:

$ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M
"[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]"

The regex was a courtesy of nick@chromium.org

BUG=None
R=mtklein@google.com

Review URL: https://codereview.chromium.org/1123573004

SkPictureShader: scale down if width or height is larger than maxTextureSize

Grdient renders black because of failure onCreateTexture
if one of width or height is larger than maxTextureSize
with --force-gpu-rasterization.

BUG=chromium:473166

Review URL: https://codereview.chromium.org/1101513004

Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1124513002

remove unneeded SK_SUPPORT_LEGACY_IMAGEFILTER_TO_COLORFILTER flag

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1120033003

Add hairlines batch unit test

BUG=skia:

Review URL: https://codereview.chromium.org/1119563002

Fix for valgrind

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1127453002

Move bounds to GrBatch

BUG=skia:

Review URL: https://codereview.chromium.org/1121463002

clean up pre-storage in canvas

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1117213003

Simple CL to add a joinWithPossiblyEmptyArg to SkRect

BUG=skia:

Review URL: https://codereview.chromium.org/1118293002

SkPDF: clean up uses of deprecated calls in tests

BUG=skia:3585

Review URL: https://codereview.chromium.org/1106163002

SkTime: return timezone information; format in ISO-8601

Motivation: PDF/A metadata will need the creation date embedded in it.

Also, GetDateTime returns local time in Win32.  This now behaves the
same as on Unix systems.

BUG=skia:3110

Review URL: https://codereview.chromium.org/1109593002

This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.

Review URL: https://codereview.chromium.org/1107973004

Move resource fonts to common location.

Move resource fonts to resources/fonts, add a destortable font for
testing, and clean up how the tests create fonts from resources.

R=joshualitt@google.com

Review URL: https://codereview.chromium.org/1120823002

Simple CL to Compute bounds in GrContext::drawVertices

BUG=skia:

Review URL: https://codereview.chromium.org/1117953003

Add batch unit tests for ovals

BUG=skia:

Review URL: https://codereview.chromium.org/1108403005

add heuristic to pour small pictures into recordings, rather than ref'ing

BUG=skia:

Review URL: https://codereview.chromium.org/1118693003

Make SkAutoTDelete's operator T*() const, like all the others.

BUG=skia:

Review URL: https://codereview.chromium.org/1114043005

Fix gpu memory accounting for auto-resolving MSAA.

BUG=skia:

Review URL: https://codereview.chromium.org/1115233002

Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1118053002

Add missing include to SkPictureContentInfo.

BUG=skia:

Review URL: https://codereview.chromium.org/1113023003

simple cleanup in GrTargetCommands

BUG=skia:

Review URL: https://codereview.chromium.org/1116923003

Fix for texture allocation failure in 'preAbandonGpuContext' mode

Review URL: https://codereview.chromium.org/1118723003

use pathops utils to improve precision of cubic chopping in scan converter

BUG=skia:

Review URL: https://codereview.chromium.org/1113963002

Fix build warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]

Review URL: https://codereview.chromium.org/1109933003

Looks like rssPages * pageSize is overflowing on 32-bit Linux...

... resulting in apparently negative memory usage:

  (-2040/2058MB  5867) 1.81s    serialize-8888 skp  top25desk_google_com_calendar_.skp

Turns out long is 32-bit there, long long is 64-bit.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/1117923002

DM+nanobench: print both current and max RSS.

out/Debug/dm:
    ( 360/380 MB  2112) 396ms   gpu gm  xfermodes

out/Release/nanobench:
    32/33  MB 1659    2.46µs  2.55µs  2.54µs  2.67µs  2%  ▄▄▄▅▅▃▂▁▂█  gpu gradient_conicalZero_clamp_hicolor

out/Debug/nanobench:
    42/42  MB   desk_css3gradients.skp_1    8888

BUG=skia:

NOTREECHECKS=true

Review URL: https://codereview.chromium.org/1115203002

Fix build warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]

Review URL: https://codereview.chromium.org/1110353003

Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1118683002

Check for NULL familyName in SkFontMgr_fontconfig.

If the familyName is NULL, don't bother spending time trying to add
it to the FcPattern.

Review URL: https://codereview.chromium.org/1115073002

Use texture barriers to read directly from the RT

Updates GrXferProcessor to read directly from the RT texture when
texture barriers are supported and it needs to know the dst color.
Also adds the notion of an Xfer barrier and uses it to issue texture
barriers when the XP will read the RT.

BUG=skia:

Review URL: https://codereview.chromium.org/1040303002

Use colorfilter instead of imagefilter when possible

needs https://codereview.chromium.org/1115713003 to land first in chrome

BUG=skia:

Review URL: https://codereview.chromium.org/986353002

Make XPFragmentBuilder only Builder with access to DstCopy.
Plus a bunch of renaming.

BUG=skia:

Review URL: https://codereview.chromium.org/1110033004

FontConfig character/lang match requires weak family.

In FontConfig the normal priority order of matches is character, family,
language; however family can be marked as weak which changes the order to
character, language, family. This is what is desired in
matchFamilyStyleCharacter.

Review URL: https://codereview.chromium.org/1118553002

Add dash lines batch unit test

BUG=skia:

Review URL: https://codereview.chromium.org/1108053004

Pull out shader-specific caps into GrShaderCaps and GrGLSLCaps

BUG=skia:

Review URL: https://codereview.chromium.org/1116713002

Handpick 16 Skia page sets to create SP enabled SKPs from

Context is in: https://code.google.com/p/skia/issues/detail?id=3763#c18

NOTRY=true
BUG=skia:3763

Review URL: https://codereview.chromium.org/1115003002

Fix double blend in GrAAConvexPathRenderer

Updates GrAAConvexPathRenderer to not draw the interior fan of a
convex path when it does not exist (i.e when segment count <= 2).

TODO: We should also detect and combine colinear segments in order to
make sure we catch every case.

BUG=skia:

Review URL: https://codereview.chromium.org/1094293002

Initial CL to create GrBatchTest infrastructure

BUG=skia:

Review URL: https://codereview.chromium.org/1109153004

onCreateDevice -> NULL now means the caller should create its own (bitmap) device

BUG=skia:

Review URL: https://codereview.chromium.org/1116453002

minor fixes to cubics code and overall alignment of how bounds and tops are computed for all curve types

All but 17 extended tests work.

A helper function is privately added to SkPath.h to permit a test to modify a given point in a path.

BUG=skia:3588

Review URL: https://codereview.chromium.org/1107353004

Implementing a scanline decoder for jpeg

BUG=skia:3257

Review URL: https://codereview.chromium.org/1092303003

Straighten out SkPicture::AccelData APIs.

Must have been we needed them to be weird (mutable, const setter) before.
It doesn't look like that's necessary now... we can just pass it to the
constructor.

BUG=skia:

Review URL: https://codereview.chromium.org/1112833003

Remove system call in DW for default font.

The last user of the GDI default font in DW is
onMatchFamilyStyleCharacter and it doesn't appear to actually need
to use it. This change removes a system call, making things a bit
faster, as well as eliminating a call blocked in the sandbox.

BUG=chromium:459056

Review URL: https://codereview.chromium.org/1107283003

Requires a minor API change to pass the color table to getScanlineDecoder, as we do with getPixels().

BUG=skia:3722

Review URL: https://codereview.chromium.org/1061713007

Create SP enabled SKPs from only the top_25_smooth page set.

Context is here: https://code.google.com/p/skia/issues/detail?id=3763#c14

BUG=skia:3763
NOTRY=true

Review URL: https://codereview.chromium.org/1111273003

Remove unneeded features from GrBufferAllocPool

Review URL: https://codereview.chromium.org/1103423004

Pass dashing info from drawPath to Gr side

Pass dashing info also from drawPath calls to gpu path rendering code.
Previously dashing info was preserved only for fast-pathed drawRects and
such.

This enables path renderers to see dashing info for arbitrary paths.

Review URL: https://codereview.chromium.org/1114463002

SkRWBuffer for thread-safe 'stream' sharing

WIP
- Can accumulate (write) data in one thread, and share snapshots of it in other threads
  ... e.g. network accumulates image data, and periodically we want to decode/draw it
- If this sort of thing sticks, should we promote SkData to have the same generality as
  SkRBuffer?

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1106113002

Remove GrFlushToGpuDrawTarget and move functionality up to GrDrawTarget.

Review URL: https://codereview.chromium.org/1117433002

create GrTestUtils.h, move some common functions into it

BUG=skia:

Review URL: https://codereview.chromium.org/1117443002

doc: add quickstart to linux and macos

also, better install_deps

NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1112663002

Review URL: https://codereview.chromium.org/1112663002

Remove useless SkASSERT in SkRect.h and SkRegion.h

The pointer of reference is always not-null. It causes >50k lines of warnning when chromium is compiled by clang.
Warning looks like
../../third_party/skia/include/core/SkRect.h:284:19: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
    do { if (&r) break; SkNO_RETURN_HINT(); SkDebugf_FileLine("../../third_party/skia/include/core/SkRect.h", 284, false, "%s:%d: failed assertion \"%s\"\n", "../../third_party/skia/include/core/SkRect.h", 284, "&r"); SkDebugf_FileLine("../../third_party/skia/include/core/SkRect.h", 284, true, "SK_CRASH"); } while (false);

Review URL: https://codereview.chromium.org/1111013002

Do circular clipping in normalized space

BUG=skia:426217

Review URL: https://codereview.chromium.org/1110173002

Fix SkTDynamicHash.h:183:29: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]

Review URL: https://codereview.chromium.org/1115433004

Update documentation for "COMMIT=false".

The meaning of "COMMIT=false" was changed in https://code.google.com/p/chromium/issues/detail?id=470609.
I have also updated the corresponding Chromium documentation in https://sites.google.com/a/chromium.org/dev/developers/testing/commit-queue

BUG=skia:
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1107343004

Review URL: https://codereview.chromium.org/1107343004

Run DM on GalaxyS* in one thread

Drive-by cleanup of Xoom

BUG=skia:3214

Review URL: https://codereview.chromium.org/1106173004