Eric Anholt [Thu, 20 Oct 2011 21:55:53 +0000 (14:55 -0700)]
mesa: Remove build infrastructure for r300c and r600c.
These drivers have been superseded by the gallium equivalents.
Eric Anholt [Fri, 14 Oct 2011 19:27:48 +0000 (12:27 -0700)]
radeon: Delete DRI1 screen init code and thus support for !kernel_mm.
It's past time, and it was going to get in the way of the renderbuffer
mapping refactor. We dropped all the other DRI1 drivers for this
release, and I can't imagine anybody supporting DRI1 radeon classic in
a new release of Mesa.
Cleanup of the resulting dead code to follow.
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Eric Anholt [Fri, 14 Oct 2011 18:17:39 +0000 (11:17 -0700)]
dri: Drop _dri_texformats that just obfuscate MESA_FORMAT names.
The remaining _dri_texformats are the ones that are variable depending
on the endianness of the system.
Eric Anholt [Fri, 14 Oct 2011 00:17:04 +0000 (17:17 -0700)]
radeon: Use _mesa_get_format_base_format for winsys renderbuffer setup.
Eric Anholt [Fri, 14 Oct 2011 00:14:11 +0000 (17:14 -0700)]
radeon: Remove dead swrast renderbuffer setup code.
This was from the stub code in the initial commit of this file.
Kenneth Graunke [Tue, 25 Oct 2011 19:55:54 +0000 (12:55 -0700)]
glsl: Remove pointless uses of glsl_type::get_base_type().
These are effectively doing type->get_base_type()->base_type, which is
equivalent to type->base_type. Just use that, as it's simpler.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Marek Olšák [Fri, 28 Oct 2011 17:05:44 +0000 (19:05 +0200)]
r600g: don't flush before reading query results
Taken care of by the winsys.
Marek Olšák [Fri, 28 Oct 2011 16:27:00 +0000 (18:27 +0200)]
r600g: only maintain the list of active queries
And not all existing queries. The only reason we have that list is to be able
to suspend and resume the active ones.
This reduces looping over queries when suspending and resuming.
The queries no longer have to track some of their states.
Marek Olšák [Fri, 28 Oct 2011 10:44:19 +0000 (12:44 +0200)]
r600g: cleanup r600_query_result
Marek Olšák [Fri, 28 Oct 2011 10:37:54 +0000 (12:37 +0200)]
r600g: don't flush in r600_get_backend_mask
The winsys does the flush in buffer_map.
Marek Olšák [Fri, 28 Oct 2011 10:34:57 +0000 (12:34 +0200)]
r600g: remove redundant variable r600_query::buffer_size
Marek Olšák [Fri, 28 Oct 2011 15:44:02 +0000 (17:44 +0200)]
r300g: remove useless code
Alan Coopersmith [Fri, 21 Oct 2011 23:17:56 +0000 (16:17 -0700)]
gallium/auxiliary/util: Solaris also has standard Unix sockets
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Tom Stellard [Sun, 23 Oct 2011 01:30:46 +0000 (18:30 -0700)]
r300/compiler: Fix scheduler bug causing texture corruption
We weren't setting TEX_SEM_WAIT on instructions that read the value of a
TEX instruction and also wrote the same register as the TEX instruction.
This is the sequence we were miscompiling:
1: TEX temp[0], input[2].xy__, 2D[0]
...
16: src0.xyz = temp[22], src1.xyz = temp[0], src2.xyz = temp[19]
MAD temp[0].xyz, src0.xxx, src1.xyz, src2.xxx
https://bugs.freedesktop.org/show_bug.cgi?id=42090
Paul Berry [Sat, 22 Oct 2011 16:33:16 +0000 (09:33 -0700)]
i965/gen6+: Add support for noperspective interpolation.
This required the following changes:
- WM setup now makes the appropriate set of barycentric coordinates
(perspective vs. noperspective) available to the fragment shader,
based on whether the shader requires perspective interpolation,
noperspective interpolation, both, or neither.
- The fragment shader backend now uses the appropriate set of
barycentric coordiantes when interpolating, based on the
interpolation mode returned by
ir_variable::determine_interpolation_mode().
- SF setup now uses gl_fragment_program::InterpQualifier to determine
which attributes are to be flat shaded (as opposed to the old logic,
which only flat shaded colors).
- CLIP setup now ensures that the clipper outputs non-perspective
barycentric coordinates when they are needed by the fragment shader.
Fixes the remaining piglit tests of interpolation qualifiers that were
failing:
- interpolation-flat-*-smooth-none
- interpolation-flat-other-flat-none
- interpolation-noperspective-*
- interpolation-smooth-gl_*Color-flat-*
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Sat, 22 Oct 2011 16:33:12 +0000 (09:33 -0700)]
i965/gen6+: Rename GEN6_CLIP_BARYCENTRIC_ENABLE.
The name was misleading. The actual effect of the bit is to cause
the clipper to emit *non-perspective* barycentric coordinate
information (which is only needed when doing noperspective
interpolation).
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Fri, 21 Oct 2011 14:56:08 +0000 (07:56 -0700)]
i965/fs: use determine_interpolation_mode().
This patch changes how fs_visitor::emit_general_interpolation()
decides what kind of interpolation to do. Previously, it used the
shade model to determine how to interpolate colors, and used smooth
interpolation on everything else. Now it uses
ir_variable::determine_interpolation_mode(), so that it respects GLSL
1.30 interpolation qualifiers.
Fixes piglit tests interpolation-flat-*-smooth-{distance,fixed,vertex}
and interpolation-flat-other-flat-{distance,fixed,vertex}.
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Sat, 22 Oct 2011 00:20:32 +0000 (17:20 -0700)]
i965/gen6+: Parameterize barycentric interpolation modes.
This patch modifies the fragment shader back-end so that instead of
using a single delta_x/delta_y register pair to store barycentric
coordinates, it uses an array of such register pairs, one for each
possible intepolation mode.
When setting up the WM, we intstruct it to only provide the
barycentric coordinates that are actually needed by the fragment
shader--that is computed by brw_compute_barycentric_interp_modes().
Currently this function returns just
BRW_WM_PERSPECTIVE_PIXEL_BARYCENTRIC, because this is the only
interpolation mode we support. However, that will change in a later
patch.
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Fri, 21 Oct 2011 21:16:25 +0000 (14:16 -0700)]
i965/fs: Fix split_virtual_grfs() when delta_xy not in a virtual register.
This patch modifies the special case in
fs_visitor::split_virtual_grfs() that prevents splitting from being
applied to the delta_x/delta_y register pair (this register pair needs
to remain contiguous so that it can be used by the PLN instruction).
When gen>=6, this register pair is in a fixed location, not a virtual
register, so it was in no danger of being split. And
split_virtual_grfs' attempt not to split it was preventing some other
unrelated register from being split.
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Fri, 21 Oct 2011 14:55:48 +0000 (07:55 -0700)]
glsl: add ir_variable::determine_interpolation_mode() function.
This function determines how a variable should be interpolated based
both on interpolation qualifiers and the current shade model.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Fri, 21 Oct 2011 14:40:37 +0000 (07:40 -0700)]
glsl: Distinguish between no interpolation qualifier and 'smooth'
Previously, we treated the 'smooth' qualifier as equivalent to no
qualifier at all. However, this is incorrect for the built-in color
variables (gl_FrontColor, gl_BackColor, gl_FrontSecondaryColor, and
gl_BackSecondaryColor). For those variables, if there is no qualifier
at all, interpolation should be flat if the shade model is GL_FLAT,
and smooth if the shade model is GL_SMOOTH.
To make this possible, I added a new value to the
glsl_interp_qualifier enum, INTERP_QUALIFIER_NONE.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Paul Berry [Wed, 26 Oct 2011 01:06:37 +0000 (18:06 -0700)]
mesa: Expose GLSL interpolation qualifiers in gl_fragment_program.
This patch makes GLSL interpolation qualifiers visible to drivers via
the array InterpQualifier[] in gl_fragment_program, so that they can
easily be used by driver back-ends to select the correct interpolation
mode.
Previous to this patch, the GLSL compiler was using the enum
ir_variable_interpolation to represent interpolation types. Rather
than make a duplicate enum in core mesa to represent the same thing, I
moved the enum into mtypes.h and renamed it to be more consistent with
the other enums defined there.
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Marek Olšák [Thu, 27 Oct 2011 13:29:45 +0000 (15:29 +0200)]
docs: update GL3 status
EXT_texture_array has been completed for quite a while.
Removing BindBufferBase+Range, because they're part of EXT_transform_feedback.
Marek Olšák [Thu, 27 Oct 2011 10:27:34 +0000 (12:27 +0200)]
r600g: remove redundant variable r600_pipe_context::blit
Marek Olšák [Tue, 25 Oct 2011 14:30:11 +0000 (16:30 +0200)]
mesa: initialize ARB_transform_feedback2 dispatch
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Marek Olšák [Tue, 25 Oct 2011 14:15:05 +0000 (16:15 +0200)]
mesa: improve EXT_transform_feedback display list support
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Marek Olšák [Mon, 24 Oct 2011 00:21:48 +0000 (02:21 +0200)]
mesa: fix GL error checking in TransformFeedbackVaryings
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Brian Paul [Wed, 26 Oct 2011 16:38:29 +0000 (10:38 -0600)]
st/glx: fix mixed declarations and code, remove unused var
Brian Paul [Tue, 25 Oct 2011 23:41:12 +0000 (17:41 -0600)]
st/mesa: tell VBO module to always unmap buffers before drawing
Without this it's possible to wind up in a draw call with the
glBegin/End VBO still in a mapped state. This is a problem for
the SVGA3D driver and probably not good for other HW drivers.
Eric Anholt [Fri, 21 Oct 2011 17:45:48 +0000 (10:45 -0700)]
glsl: Rename remaining internal builtins from gl_MESA* to gl_*MESA.
This matches the usual convention for extension builtin variables.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Eric Anholt [Mon, 17 Oct 2011 21:53:13 +0000 (14:53 -0700)]
intel: Drop texture border support code.
Now that texture borders are gone, we never need to allocate our
textures through non-miptrees, which simplifies some irritating paths.
v2: Remove the !mt support case from intel_map_texture_image()
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> (v1)
Reviewed-by: Brian Paul <brianp@vmware.com>
Eric Anholt [Mon, 17 Oct 2011 21:34:52 +0000 (14:34 -0700)]
intel: Enable stripping of texture borders.
This replaces software rendering of textures with the deprecated
1-pixel border (which is always bad, since mipmapping is rather broken
in swrast, and GLSL 1.30 is unsupported) with hardware rendering that
just pretends there was never a border (so you have potential seams on
apps that actually intentionally used the 1-pixel borders, but correct
rendering otherwise).
This doesn't regress any piglit tests on gen6 (since the texwrap
border/bordercolor cases already failed due to broken border color
handling), but regresses texwrap border cases on original gen4 since
those end up sampling the border color instead of the border pixels.
It's a small price to pay for not thinking about texture borders any
more.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
Eric Anholt [Tue, 25 Oct 2011 19:10:21 +0000 (12:10 -0700)]
mesa: Apply StripTextureBorder to CopyTexImage as well.
Reviewed-by: Brian Paul <brianp@vmware.com>
Eric Anholt [Mon, 17 Oct 2011 21:30:26 +0000 (14:30 -0700)]
mesa: Fold gallium's texture border stripping into a core Mesa option.
We wanted to reuse this in the Intel driver.
v2: Move the flag to ctx->Const
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> (v1)
Reviewed-by: Brian Paul <brianp@vmware.com>
Eric Anholt [Tue, 25 Oct 2011 21:38:39 +0000 (14:38 -0700)]
mesa: Skip texstore for 0-sized texture data.
The intel driver (and gallium, it looks like, though it doesn't use
these texstore functions at this point) doesn't bother making storage
for textures with 0 width, height, or depth. This avoids them having
to deal with returning a mapping for that nonexistent data.
Fixes assertion failures with an upcoming intel driver change.
Reviewed-by: Brian Paul <brianp@vmware.com>
Marek Olšák [Wed, 26 Oct 2011 13:52:32 +0000 (15:52 +0200)]
r600g: remove redundant assignment of pipe_draw_info in draw_vbo
Dave Airlie [Wed, 26 Oct 2011 13:50:47 +0000 (15:50 +0200)]
llvmpipe: llvmpipe doesn't support pure integers yet.
Should fix: https://bugs.freedesktop.org/show_bug.cgi?id=42240
Signed-off-by: Dave Airlie <airlied@redhat.com>
Marek Olšák [Wed, 26 Oct 2011 00:17:52 +0000 (02:17 +0200)]
r600g: cleanup draw_vbo and add comments
Vinson Lee [Wed, 26 Oct 2011 03:30:27 +0000 (20:30 -0700)]
ralloc: Move declaration before code.
Fixes build error with MSVC.
Vinson Lee [Wed, 26 Oct 2011 03:19:07 +0000 (20:19 -0700)]
scons: Add link_uniforms.cpp to SConscript.
Ian Romanick [Mon, 24 Oct 2011 19:23:50 +0000 (12:23 -0700)]
ir_to_mesa: Use uniform_field_visitor to add all struct fields to parameter list
Previously the uniform was passed as single, whole structure to
_mesa_add_parameter. This was completely bogus and resulted in a
DataType of 0 (instead of a valid GLSL type enum).
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41980
Tested-by: Brian Paul <brianp@vmware.com>
Cc: Bryan Cain <bryancain3@gmail.com>
Cc: Vinson Lee <vlee@vmware.com>
Cc: José Fonseca <jfonseca@vmware.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Ian Romanick [Tue, 25 Oct 2011 02:37:11 +0000 (19:37 -0700)]
linker: Add uniform_field_visitor class to process leaf fields of a uniform
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Kenneth Graunke [Tue, 25 Oct 2011 02:33:16 +0000 (19:33 -0700)]
ralloc: Add new [v]asprintf_rewrite_tail functions.
This can be useful if you want to create a bunch of temporary strings
with a common prefix. For example, when iterating over uniform
structure fields, one might want to create temporary strings like
"pallete.primary", "palette.outline", and "pallette.shadow".
This could be done by overwriting the '.' with a null-byte and calling
ralloc_asprintf_append, but that incurs the cost of strlen("pallete")
every time...when this is already known.
These new functions allow you rewrite the tail of the string, given a
starting index. If the starting index is the length of the string, this
is equivalent to appending.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Ian Romanick [Fri, 21 Oct 2011 18:21:02 +0000 (11:21 -0700)]
linker: Eliminate more dead code after demoting shader inputs and outputs
Consider the following vertex shader and fragment shader:
// vertex shader
varying vec4 v;
uniform vec4 u;
void main() { gl_Position = vec4(0.0); v = u; }
// fragment shader
void main() { gl_FragColor = vec4(0.0); }
Since the fragment shader does not use 'v', it is demoted from a
varying to a simple global variable. Once that happens, the
assignment to 'v' is useless, and it should be removed. In addition,
'u' is no longer active, and it should also be removed.
Performing extra dead code elimination after demoting shader inputs
and outputs takes care of this. This elimination must occur before
assigning uniform locations, or the declaration of 'u' cannot be
removed.
This change *breaks* the piglit test getuniform-01, but that test is
already incorrect. The test uses a vertex shader that assigns to a
user-defined varying, but it has no fragment shader. Since Mesa does
not support ARB_separate_shader_objects (we only support the EXT
version), the linker correctly eliminates the user-defined varying.
The cascading effect is that the uniform queried by the C code of the
test is also (correctly) eliminated.
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41980
Tested-by: Brian Paul <brianp@vmware.com>
Cc: Bryan Cain <bryancain3@gmail.com>
Cc: Vinson Lee <vlee@vmware.com>
Cc: José Fonseca <jfonseca@vmware.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Ian Romanick [Fri, 21 Oct 2011 18:17:39 +0000 (11:17 -0700)]
glsl: Add uniform_locations_assigned parameter to do_dead_code opt pass
Setting this flag prevents declarations of uniforms from being removed
from the IR. Since the IR is directly used by several API functions
that query uniforms in shaders, uniform declarations cannot be removed
after the locations have been set. However, it should still be safe
to reorder the declarations (this is not tested).
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41980
Tested-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Bryan Cain <bryancain3@gmail.com>
Cc: Vinson Lee <vlee@vmware.com>
Cc: José Fonseca <jfonseca@vmware.com>
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Kenneth Graunke [Mon, 24 Oct 2011 06:02:05 +0000 (23:02 -0700)]
i965: Add more #defines for Gen6+ 3DSTATE_GS fields.
These should be useful for doing transform feedback on Sandybridge.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Kenneth Graunke [Mon, 24 Oct 2011 05:27:14 +0000 (22:27 -0700)]
i965: Add new brw_context::max_gs_threads constant.
These are correct to the best of my knowledge, gleaned from a variety of
internal sources. Sadly, the Sandybridge PRM has incorrect limits.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Kenneth Graunke [Mon, 24 Oct 2011 05:10:03 +0000 (22:10 -0700)]
i965: Rename (vs|wm)_max_threads to max_(vs|wm)_threads for consistency.
The inconsistency between vs_max_threads and max_vs_entries was rather
annoying. I could never seem to remember which one was reversed, which
made it harder to find quickly. "Max __ Threads" seems more natural.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Kenneth Graunke [Mon, 24 Oct 2011 04:42:27 +0000 (21:42 -0700)]
i965: Remove "single threaded" INTEL_DEBUG mode.
According to the docs for 3DSTATE_PS (Gen7+) and 3DSTATE_WM (Gen6),
there is a platform dependent value for the minimum number of pixel
shader threads. It may also vary based on whether WIZ Hashing is on.
For example, Ivybridge requires at least 4 threads if WIZ hashing is
disabled, and 8 if it's enabled. Programming it to use less threads is
illegal. Sandybridge appears to have similar restrictions.
So on newer platforms, INTEL_DEBUG=sing will probably just hang the GPU.
Rather than try to patch it up for newer platforms and extend it to
support geometry shaders, just remove it as it isn't that useful anyway.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Kenneth Graunke [Mon, 17 Oct 2011 23:41:57 +0000 (16:41 -0700)]
mesa: Remove unnecessary and incorrect TexEnv parameter validation.
For GL_RGB_SCALE and GL_ALPHA_SCALE targets, the API wrapper code
attempts to ensure the parameter is 1.0, 2.0, or 4.0.
This is unnecessary: set_combiner_scale in texenv.c (called by
_mesa_TexEnvfv) already checks this and raises an appropriate error.
It's also incorrect: For glTexEnvx, the API validation code directly
compares the GLfixed input parameter with a floating point constant,
prior to converting fixed-point to floating point.
Fixes an issue in the OpenGL ES 1.1 conformance suite.
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Stéphane Marchesin [Mon, 24 Oct 2011 19:03:16 +0000 (12:03 -0700)]
st/glx: Implement texture_from_pixmap without DRI.
Makes texture_from_pixmap work with non-DRI llvmpipe.
Stéphane Marchesin [Tue, 18 Oct 2011 17:26:04 +0000 (10:26 -0700)]
i915g: Cleanup the vertex sampler interface a bit.
Stéphane Marchesin [Tue, 18 Oct 2011 17:25:02 +0000 (10:25 -0700)]
i915g: Flesh out TODO idea.
Chad Versace [Mon, 24 Oct 2011 20:55:43 +0000 (13:55 -0700)]
intel: Kill dead code in intel_miptree_copy_teximage()
Kill the code paths taken when src_mt is null. It is never null, otherwise
there would be a segfault on line 4 of this function:
GLuint width = src_mt->level[level].width;
(Some interleaved lines in the diff make the real diff non-obvious. All
I did was delete some code and then left-shifted what remained to correct
the indentation.)
Reviewed-by: Eric Anholt <eric@aholt.net>
Signed-off-by: Chad Versace <chad@chad-versace.us>
Vinson Lee [Tue, 25 Oct 2011 15:23:02 +0000 (08:23 -0700)]
tgsi: Fix memory leak in out-of-memory path.
Fixes Coverity resource leak defect.
Reviewed-by: Brian Paul <brianp@vmware.com>
Vinson Lee [Tue, 25 Oct 2011 17:08:59 +0000 (10:08 -0700)]
swrast: Fix memory leak in out-of-memory path.
Fixes Coverity resource leak defect.
Reviewed-by: Brian Paul <brianp@vmware.com>
Brian Paul [Tue, 25 Oct 2011 17:25:55 +0000 (11:25 -0600)]
swrast: use _mesa_ffs() instead of ffs()
Fixes MSVC build.
Marek Olšák [Tue, 25 Oct 2011 17:20:14 +0000 (19:20 +0200)]
r600g: move some code out of draw_vbo into new r600_update_derived_state
Marek Olšák [Tue, 25 Oct 2011 15:44:55 +0000 (17:44 +0200)]
r600g: cleanup some magic numbers
Marek Olšák [Tue, 25 Oct 2011 14:39:18 +0000 (16:39 +0200)]
r600g: don't render if pipe_draw_info::count is 0
Also call r600_conv_pipe_prim earlier.
Brian Paul [Tue, 25 Oct 2011 14:45:37 +0000 (08:45 -0600)]
mesa: fix comment language
Vinson Lee [Mon, 24 Oct 2011 21:45:39 +0000 (14:45 -0700)]
pp: Fix memory leak on error path.
Fixes Coverity resource leak defect.
Reviewed-by: José Fonseca <jfonseca@vmware.com>
Marek Olšák [Mon, 24 Oct 2011 23:28:39 +0000 (01:28 +0200)]
r600g: set correct tiling flags in depth info
The kernel currently overwrites the flags, but if we stopped doing that,
this would break badly.
Jeremy Huddleston [Mon, 24 Oct 2011 23:21:28 +0000 (16:21 -0700)]
apple: Implement applegl_unbind_context
glXMakeCurrent(dpy, None, NULL) would not correctly unbind the context
causing subsequent GLX requests to fail in peculiar ways
http://xquartz.macosforge.org/trac/ticket/514
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Brian Paul [Mon, 24 Oct 2011 15:40:07 +0000 (09:40 -0600)]
util: handle failed mapping in u_upload_alloc()
Reviewed-by: José Fonseca <jfonseca@vmware.com>
Brian Paul [Mon, 24 Oct 2011 15:37:26 +0000 (09:37 -0600)]
util: handle failed mapping in u_upload_alloc_buffer()
Reviewed-by: José Fonseca <jfonseca@vmware.com>
Vinson Lee [Mon, 24 Oct 2011 18:57:15 +0000 (11:57 -0700)]
mesa: Fix memory leak in out-of-memory path.
Fixes Coverity resource leak defect.
Reviewed-by: Brian Paul <brianp@vmware.com>
Eric Anholt [Wed, 19 Oct 2011 00:17:28 +0000 (17:17 -0700)]
glsl: Fix gl_NormalMatrix swizzle setup to match i965's invariants.
A driver trying to set up builtin uniforms is faced with a problem:
How do I walk the ir_variable structure (representing an array of
structs, or array of matrices, or struct, or whatever), and set up
driver structures so that dereference of that uniform gets the
corresponding ParameterValues[] entry. The rule in general is that
each corresponding vector-sized field of an array of structs is one
builtin uniform state slot. i965 relied on another invariant: each
state slot has a number of unique channel swizzles corresponding to
the number of elements in the field's vector, to avoid needing to walk
the glsl_type in parallel to get at vector_elements.
All of the builtin uniforms followed this behavior, except for
gl_NormalMatrix. That's a mat3 (so 3 vec3s), but it was swizzled as 3
vec4s.
Fixes piglit glsl-fs-normalmatrix.
Reviewed-by: Paul Berry <stereotype441@gmail.com>
Eric Anholt [Fri, 21 Oct 2011 22:17:16 +0000 (15:17 -0700)]
glsl: Add gl_MaxVaryingComponents in GLSL 1.30.
This is the new name for gl_MaxVaryingFloats now that non-float
varyings exist. Fixes piglit
glsl-1.30/execution/maximums/gl_MaxVaryingFloats
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Kenneth Graunke [Fri, 21 Oct 2011 08:03:37 +0000 (01:03 -0700)]
i965: Apply post-sync non-zero workaround to homebrew workaround.
In commit
3e5d3626, Eric added a homebrew workaround to fix GPU hangs in
the Mesa "engine" demo and oglc's api-texcoord test.
Unfortunately, his PIPE_CONTROL contains a Depth Stall, which
necessitates the post-sync non-zero workaround,
Fixes GPU hangs in Civilization 4, PlaneShift, and 3DMMES.
Hopefully Heroes of Newerth as well, though I haven't tested that.
NOTE: This is candidate for the 7.11 branch.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40324
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41096
Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-and-tested-by: Eric Anholt <eric@anholt.net>
Marek Olšák [Mon, 24 Oct 2011 19:08:13 +0000 (21:08 +0200)]
docs: update relnotes-7.12
Marek Olšák [Mon, 24 Oct 2011 19:05:38 +0000 (21:05 +0200)]
r300g: expose ARB_ES2_compatibility by claiming FIXED format support
Adel Gadllah [Mon, 24 Oct 2011 17:41:03 +0000 (19:41 +0200)]
nv50: fix max texture levels
MAX_TEXTURE_2D_LEVELS and MAX_TEXTURE_CUBE_LEVELS are supposed to be
14 not 13, while MAX_TEXTURE_3D_LEVELS should be 12 not 10.
Marek Olšák [Mon, 24 Oct 2011 17:44:49 +0000 (19:44 +0200)]
winsys/radeon: don't use the new GEM_WAIT ioctl for now
Tom Fogal [Wed, 19 Oct 2011 20:41:35 +0000 (14:41 -0600)]
Only use gcc visibility support with gcc4+.
I had a colleague hitting issues compiling with an old gcc3.2
system. These patches got them through.
NOTE: This is a candidate for the 7.11 branch.
Reviewed-by: Brian Paul <brianp@vmware.com>
Mathias Fröhlich [Sat, 8 Oct 2011 19:33:23 +0000 (21:33 +0200)]
winsys/radeon: restore the old r600g winsys memory characteristics.
Use VRAM for static and immutable buffers. This restores the
recently removed r600g winsys behaviour for memory locations.
This also improoves rendering times on the gpu for some
OpenSceneGraph based test cases by about 15%.
Signed-off-by: Marek Olšák <maraeo@gmail.com>
Brian Paul [Sun, 23 Oct 2011 16:14:27 +0000 (10:14 -0600)]
util: remove gotos in u_upload_mgr.c
We can trivially remove the gotos in two places in this code and make
it a bit more readable.
Reviewed-by: José Fonseca <jfonseca@vmware.com>
Mathias Fröhlich [Sat, 22 Oct 2011 10:57:01 +0000 (12:57 +0200)]
mesa: Avoid ABA problem on buffer object bind.
Make sure we do not run into the classic ABA problem on buffer object bind,
reusing this name and may be never rebind since we get an new name
that was just deleted and never rebound in between.
The explicit rebinding to the debault object in the current context
prevents the above in the current context, but another context
sharing the same objects might suffer from this problem.
Minor var renaming and comments edited by Brian.
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@web.de>
Signed-off-by: Brian Paul <brianp@vmware.com>
Brian Paul [Mon, 24 Oct 2011 02:21:18 +0000 (20:21 -0600)]
swrast: fix comment typo (s/texure/texture/)
Brian Paul [Mon, 24 Oct 2011 02:17:53 +0000 (20:17 -0600)]
mesa: remove dead code from teximage.c
Mathias Fröhlich [Wed, 19 Oct 2011 05:54:20 +0000 (07:54 +0200)]
mesa: Fix multithreaded buffer object refcounting.
Buffer objects may be shared across contexts.
Rework the array attrib push/pop implementation
to be thread safe. Make use of more library functions
for this purpose.
Signed-off-by: Mathias Fröhlich <Mathias.Froehlich@web.de>
Reviewed-by: Brian Paul <brianp@vmware.com>
Marek Olšák [Sun, 23 Oct 2011 18:29:06 +0000 (20:29 +0200)]
r300g: don't call u_trim_pipe_prim in r300_swtcl_draw_vbo
This was dead code anyway.
Marek Olšák [Fri, 21 Oct 2011 01:32:29 +0000 (03:32 +0200)]
u_blitter: accept overriden width0 and height0
We'll use this soon.
Marek Olšák [Fri, 21 Oct 2011 00:09:40 +0000 (02:09 +0200)]
u_blitter: add a copy_texture function which uses views and not resources
The views (sampler views and surfaces) are great tools for changing resource
properties without having to change pipe_resource.
Brian Paul [Sun, 23 Oct 2011 17:19:46 +0000 (11:19 -0600)]
intel: remove duplicated #include of texstore.h
Brian Paul [Sun, 23 Oct 2011 17:18:22 +0000 (11:18 -0600)]
radeon: remove unnecessary #includes of texstore.h
Brian Paul [Sun, 23 Oct 2011 16:39:38 +0000 (10:39 -0600)]
configs: add vmgfx-related dirs to configs/linux-dri
Brian Paul [Sun, 23 Oct 2011 16:44:47 +0000 (10:44 -0600)]
swrast: update renderbuffer format assertion
Failed when exercising i965 swrast fallback rendering.
Brian Paul [Sun, 23 Oct 2011 16:44:47 +0000 (10:44 -0600)]
mesa: add swrast_texture_image::Buffer
In the past, swrast_texture_image::Data has been overloaded. It could
either point to malloc'd memory storing texture data, or it could point
to a current mapping of GPU memory.
Now, Buffer always points to malloc'd memory (if we're not using GPU
memory) and Data always points to mapped memory. The next step would
be to rename Data -> Map.
This change also involves adding swrast functions for mapping textures
and renderbuffers prior to rendering to setup the Data pointer. Plus,
corresponding functions to unmap texures and renderbuffers. This is
very much like similar code in the dri drivers.
Brian Paul [Sun, 23 Oct 2011 16:44:47 +0000 (10:44 -0600)]
mesa: remove _mesa_alloc_texmemory(), _mesa_free_texmemory()
Core Mesa no longer does any texture memory allocation.
Brian Paul [Sun, 23 Oct 2011 16:44:47 +0000 (10:44 -0600)]
mesa: move gl_texture_image::Data, RowStride, ImageOffsets to swrast
Only swrast and the drivers that fall back to swrast need these fields now.
This removes the last of the fields related to software rendering from
gl_texture_image.
Brian Paul [Sun, 23 Oct 2011 16:08:06 +0000 (10:08 -0600)]
llvmpipe: point out that there's two stencil writemasks
In lp_build_stencil_op() the incoming 'stencil' var is a 2-element array.
There's a front-face writemask and a back-face writemask but we're ignoring
the later. This patch doesn't fix anything but at least points out the
problem.
Brian Paul [Sun, 23 Oct 2011 16:05:14 +0000 (10:05 -0600)]
llvmpipe: compare front_facing to NULL to improve readability
Compare 'front_facing' to NULL to make it more obvious that front_facing
is a pointer and not a simple boolean value.
Brian Paul [Sun, 23 Oct 2011 16:02:53 +0000 (10:02 -0600)]
gallivm: added lp_build_print_ivec4() function
Brian Paul [Sun, 23 Oct 2011 16:00:00 +0000 (10:00 -0600)]
mesa: improve the warning message in _mesa_choose_tex_format()
Bug 42128 hits this _mesa_warning() call.
Eric Anholt [Tue, 27 Sep 2011 21:54:10 +0000 (14:54 -0700)]
glsl: Add support for constant expression evaluation on round(), roundEven().
v2: Avoid the C99 rounding functions, because I don't trust
get/setting the C99 rounding mode from inside our library not having
other side effects. Instead, open-code roundEven() behavior around
Mesa's IROUND, which we're already testing for C99 rounding mode
safety.
Fixes glsl-1.30/compiler/built-in-functions/round*
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Mathias Fröhlich [Fri, 14 Oct 2011 14:25:21 +0000 (16:25 +0200)]
dri-r600: Hook up a drm_descriptor configuration function
Returns a configuration that makes the dri state-tracker-manager
throttle.
Mathias Fröhlich [Sun, 23 Oct 2011 06:57:43 +0000 (08:57 +0200)]
r600g: make r[67]00 not bail out on PRED_SETNE_INT.
Dave Airlie [Sat, 22 Oct 2011 19:13:20 +0000 (20:13 +0100)]
r600g: make if's use PRED_SETNE_INT no matter what.
This is more correct for TGSI if, and with native ints enabled
it fixes 25 piglit fails.
Signed-off-by: Dave Airlie <airlied@redhat.com>
Dave Airlie [Sat, 22 Oct 2011 19:11:26 +0000 (20:11 +0100)]
r600g: print inst in hex in dumps
since we have them as hex in the headers.
Signed-off-by: Dave Airlie <airlied@redhat.com>