platform/upstream/gstreamer.git
5 years agovaapipostproc: allow cropping via properties
U. Artie Eoff [Mon, 8 Jul 2019 21:18:00 +0000 (14:18 -0700)]
vaapipostproc: allow cropping via properties

Add crop-left, crop-right, crop-top and crop-bottom
properties to vaapipostproc.

5 years agovaapipostproc: rotate outbuf and crop meta if forwarding
U. Artie Eoff [Sat, 31 Aug 2019 00:31:45 +0000 (17:31 -0700)]
vaapipostproc: rotate outbuf and crop meta if forwarding

When forwarding crop meta to downstream, the output
buffer and crop meta need to be rotated, too.

Test:
 for i in 90r 180 90l vert horiz ul-lr ur-ll
 do
  gst-launch-1.0 -vf videotestsrc num-buffers=500 \
   ! videocrop top=100 bottom=30 left=40 right=20 \
   ! vaapipostproc video-direction=$i \
   ! vaapisink & \
  gst-launch-1.0 -vf videotestsrc num-buffers=500 \
   ! videocrop top=100 bottom=30 left=40 right=20 \
   ! vaapipostproc video-direction=$i \
   ! identity drop-allocation=true \
   ! vaapisink
 done

5 years agovaapipostproc: fix output buffer WxH for crop meta forwarding
U. Artie Eoff [Fri, 30 Aug 2019 21:14:30 +0000 (14:14 -0700)]
vaapipostproc: fix output buffer WxH for crop meta forwarding

Adding crop meta x,y to w,h only compensates for left,top
cropping.  But we also need to compensate for right,bottom
cropping.

The video meta contains the appropriate w,h (uncropped)
values, so use it instead.

Test:

 gst-launch-1.0 -vf videotestsrc num-buffers=500 \
  ! videocrop top=50 bottom=30 left=40 right=20 \
  ! vaapipostproc ! vaapisink & \
 gst-launch-1.0 -vf videotestsrc num-buffers=500 \
  ! videocrop top=50 bottom=30 left=40 right=20 \
  ! vaapipostproc ! identity drop-allocation=1 \
  ! vaapisink

5 years agovaapipostproc: handle size and direction together in src events
U. Artie Eoff [Wed, 4 Sep 2019 17:52:51 +0000 (10:52 -0700)]
vaapipostproc: handle size and direction together in src events

Mapping a pointer event needs to consider both size and
video-direction operations together, not just one or the other.

This fixes an issue where x,y were not being mapped correctly
for 90r, 90l, ur-ll and ul-lr video-direction. In these directions,
the WxH are swapped and GST_VAAPI_POSTPROC_FLAG_SIZE is set.  Thus,
the first condition in the pointer event handling was entered and
x,y scale factor were incorrectly computed due to srcpad WxH
swap.

This also fixes all cases where both video-direction and scaling
are enabled at the same time.

Test that all pointer events map appropriately:

for i in `seq 0 7`
do
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} width=300 \
  ! vaapisink
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} width=300 height=200 \
  ! vaapisink
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} height=200 \
  ! vaapisink
 GST_DEBUG=vaapipostproc:5 gst-launch-1.0 -vf videotestsrc \
  ! vaapipostproc video-direction=${i} \
  ! vaapisink
done

5 years agovaapipostproc: advertise crop meta is handled
U. Artie Eoff [Tue, 20 Aug 2019 21:22:57 +0000 (14:22 -0700)]
vaapipostproc: advertise crop meta is handled

Advertise to upstream that vaapipostproc can handle
crop meta.

When used in conjunction with videocrop plugin, the
videocrop plugin will only do in-place transform on the
crop meta when vaapipostproc advertises the ability to
handle it.  This allows vaapipostproc to apply the crop
meta on the output buffer using vaapi acceleration.
Without this advertisement, the videocrop plugin will
crop the output buffer directly via software methods,
which is not what we desire.

vaapipostproc will not apply the crop meta if downstream
advertises crop meta handling; vaapipostproc will just
forward the crop meta to downstream.  If crop meta is
not advertised by downstream, then vaapipostproc will
apply the crop meta.

Examples:

1. vaapipostproc will forward crop meta to vaapisink
 gst-launch-1.0 videotestsrc \
  ! videocrop left=10 \
  ! vaapipostproc \
  ! vaapisink

2. vaapipostproc will do the cropping
 gst-launch-1.0 videotestsrc \
  ! videocrop left=10 \
  ! vaapipostproc \
  ! identity drop-allocation=1 \
  ! vaapisink

5 years agolibs: encoder: clean two virtual func in encoder class
He Junyan [Thu, 29 Aug 2019 10:44:36 +0000 (18:44 +0800)]
libs: encoder: clean two virtual func in encoder class

set_property and get_default_properties functions are no longer
needed for encoder class.

5 years agolibs: encoder: delete old set_property and property enum feienc264
He Junyan [Thu, 29 Aug 2019 10:43:30 +0000 (18:43 +0800)]
libs: encoder: delete old set_property and property enum feienc264

5 years agolibs: encoder: delete old set_property and property enum in h264 fei
He Junyan [Thu, 29 Aug 2019 10:39:27 +0000 (18:39 +0800)]
libs: encoder: delete old set_property and property enum in h264 fei

5 years agolibs: encoder: delete old set_property and property enum in vp9
He Junyan [Thu, 29 Aug 2019 10:37:58 +0000 (18:37 +0800)]
libs: encoder: delete old set_property and property enum in vp9

5 years agolibs: encoder: delete old set_property and property enum in vp8
He Junyan [Thu, 29 Aug 2019 10:36:51 +0000 (18:36 +0800)]
libs: encoder: delete old set_property and property enum in vp8

5 years agolibs: encoder: delete old set_property and property enum in mpeg2
He Junyan [Thu, 29 Aug 2019 10:35:59 +0000 (18:35 +0800)]
libs: encoder: delete old set_property and property enum in mpeg2

5 years agolibs: encoder: delete old set_property and property enum in jpeg
He Junyan [Thu, 29 Aug 2019 10:34:57 +0000 (18:34 +0800)]
libs: encoder: delete old set_property and property enum in jpeg

5 years agolibs: encoder: delete old set_property and property enum in h265
He Junyan [Thu, 29 Aug 2019 10:31:56 +0000 (18:31 +0800)]
libs: encoder: delete old set_property and property enum in h265

5 years agolibs: encoder: delete old set_property and property enum in h264
He Junyan [Thu, 29 Aug 2019 10:30:07 +0000 (18:30 +0800)]
libs: encoder: delete old set_property and property enum in h264

5 years agolibs: encoder: delete EncoderPropInfo related functions
He Junyan [Thu, 29 Aug 2019 10:17:42 +0000 (18:17 +0800)]
libs: encoder: delete EncoderPropInfo related functions

5 years agolibs: encoder: delete encoder_set_property
He Junyan [Thu, 29 Aug 2019 08:13:19 +0000 (16:13 +0800)]
libs: encoder: delete encoder_set_property

We no longer need this obsolete set_property function now after
switch to standard gobject's property manner.
Also delete the old encoder's property enum in the header file.

5 years agolibs: encoder: delete properties_get_default for base class
He Junyan [Thu, 29 Aug 2019 07:59:43 +0000 (15:59 +0800)]
libs: encoder: delete properties_get_default for base class

5 years agoplugin: encode: delete useless init_properties.
He Junyan [Thu, 29 Aug 2019 07:52:04 +0000 (15:52 +0800)]
plugin: encode: delete useless init_properties.

Also delete the get_properties function in encode class. We now
use g_object_class_list_properties to get all properties for
internal encoder class.

5 years agoplugin: encode: delete set/get_property func in encode class
He Junyan [Thu, 29 Aug 2019 07:43:45 +0000 (15:43 +0800)]
plugin: encode: delete set/get_property func in encode class

Use standard gobject's property functions to replace the old way.

5 years agoplugin: encode: delete gst_vaapiencode_init_properties
He Junyan [Thu, 29 Aug 2019 07:31:16 +0000 (15:31 +0800)]
plugin: encode: delete gst_vaapiencode_init_properties

No need to init the properties got by get_default_properties func
now. The properties are inited correctly in internal encoder class.

5 years agolibs: encoder: delete 3 useless init macro
He Junyan [Thu, 29 Aug 2019 07:19:10 +0000 (15:19 +0800)]
libs: encoder: delete 3 useless init macro

5 years agolibs: encoder: delete get_default_properties of feienc
He Junyan [Thu, 29 Aug 2019 07:16:26 +0000 (15:16 +0800)]
libs: encoder: delete get_default_properties of feienc

5 years agolibs: encoder: delete get_default_properties of H264 Fei
He Junyan [Thu, 29 Aug 2019 07:14:14 +0000 (15:14 +0800)]
libs: encoder: delete get_default_properties of H264 Fei

5 years agolibs: encoder: delete get_default_properties of VP9
He Junyan [Thu, 29 Aug 2019 07:07:17 +0000 (15:07 +0800)]
libs: encoder: delete get_default_properties of VP9

5 years agolibs: encoder: delete get_default_properties of VP8
He Junyan [Thu, 29 Aug 2019 07:06:25 +0000 (15:06 +0800)]
libs: encoder: delete get_default_properties of VP8

5 years agolibs: encoder: delete get_default_properties of MPEG2
He Junyan [Thu, 29 Aug 2019 07:03:52 +0000 (15:03 +0800)]
libs: encoder: delete get_default_properties of MPEG2

5 years agolibs: encoder: delete get_default_properties of JPEG
He Junyan [Thu, 29 Aug 2019 07:03:19 +0000 (15:03 +0800)]
libs: encoder: delete get_default_properties of JPEG

5 years ago libs: encoder: delete get_default_properties of H265
He Junyan [Fri, 30 Aug 2019 11:15:38 +0000 (19:15 +0800)]
 libs: encoder: delete get_default_properties of H265

5 years agolibs: encoder: delete get_default_properties of H264
He Junyan [Thu, 29 Aug 2019 06:59:12 +0000 (14:59 +0800)]
libs: encoder: delete get_default_properties of H264

5 years agolibs: encoder: delete the useless constructed func for encoder.
He Junyan [Thu, 29 Aug 2019 06:53:59 +0000 (14:53 +0800)]
libs: encoder: delete the useless constructed func for encoder.

5 years agolibs: encoder: implement get_view_ids for h264 encoder.
He Junyan [Mon, 26 Aug 2019 15:16:33 +0000 (23:16 +0800)]
libs: encoder: implement get_view_ids for h264 encoder.

5 years agogst: encode: enable new type of property mechanism.
He Junyan [Tue, 20 Aug 2019 15:56:33 +0000 (23:56 +0800)]
gst: encode: enable new type of property mechanism.

5 years agogst: encode: add property help functions for encoder properties.
He Junyan [Tue, 20 Aug 2019 14:16:35 +0000 (22:16 +0800)]
gst: encode: add property help functions for encoder properties.

The encoder is a true gstobject now and all the properties are using
gobject's properties mechanism. Add help functions to handle the properties
between encode and encoder class.
The basic idea is mapping the same property between encoder and encode. All
the encoder's properties will have the same name, the same type in encode.
The set/get property function just forward the property setting/getting to
the encoder using the same property name and value. Because the encoder is
created on needed, we need to cache the property setting in encode.

5 years agolibs: encoder: add flags to all encoder properties.
He Junyan [Fri, 30 Aug 2019 10:39:32 +0000 (18:39 +0800)]
libs: encoder: add flags to all encoder properties.

G_PARAM_CONSTRUCT make all properties init correctly, we do not
need to init the properties manually.
G_PARAM_FLAG_VAAPI_ENCODER_EXPOSURE is a vaapi encoder specific
flag, means need to expose the property to according encode class.

5 years agolibs: encoder: Add properties for h264 encoder fei.
He Junyan [Tue, 20 Aug 2019 09:00:39 +0000 (17:00 +0800)]
libs: encoder: Add properties for h264 encoder fei.

Install properties for h264 encoder fei class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for h264 fei encoder.
He Junyan [Tue, 20 Aug 2019 07:58:30 +0000 (15:58 +0800)]
libs: encoder: Add properties for h264 fei encoder.

Install properties for h264 fei encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for vp9 encoder.
He Junyan [Tue, 20 Aug 2019 07:29:27 +0000 (15:29 +0800)]
libs: encoder: Add properties for vp9 encoder.

Install properties for vp9 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for vp8 encoder.
He Junyan [Tue, 20 Aug 2019 07:01:02 +0000 (15:01 +0800)]
libs: encoder: Add properties for vp8 encoder.

Install properties for vp8 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for mpeg2 encoder.
He Junyan [Tue, 20 Aug 2019 06:31:58 +0000 (14:31 +0800)]
libs: encoder: Add properties for mpeg2 encoder.

Install properties for mpeg2 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for jpeg encoder.
He Junyan [Tue, 20 Aug 2019 06:53:06 +0000 (14:53 +0800)]
libs: encoder: Add properties for jpeg encoder.

Install properties for jpeg encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for h265 encoder.
He Junyan [Tue, 20 Aug 2019 06:12:36 +0000 (14:12 +0800)]
libs: encoder: Add properties for h265 encoder.

Install properties for h265 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: Add properties for h264 encoder.
He Junyan [Mon, 19 Aug 2019 17:33:40 +0000 (01:33 +0800)]
libs: encoder: Add properties for h264 encoder.

Install properties for h264 encoder class. Also set the new get/set
property functions for gobject class. Still use the old properties
way now and this new feature will be enabled later.

5 years agolibs: encoder: add properties and prop help functions
He Junyan [Mon, 19 Aug 2019 07:38:09 +0000 (15:38 +0800)]
libs: encoder: add properties and prop help functions

Add all common properties to encoder base class. rate-control and
tune are moved to sub class.

5 years agolibs: encoder: delete useless gst_vaapi_encoder_new func.
He Junyan [Thu, 29 Aug 2019 06:38:49 +0000 (14:38 +0800)]
libs: encoder: delete useless gst_vaapi_encoder_new func.

GstVaapiEncoder is a abstract gobject and never be created directly.

5 years agolib: encoder: gstobjectfy all vaapi encoders.
He Junyan [Fri, 26 Jul 2019 16:55:53 +0000 (00:55 +0800)]
lib: encoder: gstobjectfy all vaapi encoders.

Replace all gstvaapiobject in vaapi encoders with standard gstobject.
Let the gstobject common logic to handle all the init and finalize
works. But the property install/set/get still use the old way, need
to be improved later.

5 years agovaapipostproc: check for filter before appending caps
Víctor Manuel Jáquez Leal [Thu, 29 Aug 2019 10:11:36 +0000 (12:11 +0200)]
vaapipostproc: check for filter before appending caps

While ensuring the allowed sink pad caps, the filter attributes set
the frame size restriction, but it is not ensured, at that moment,
that the filter is already instantiaded.

In order to silence the glib logs, this patch add only calls
gst_vaapi_filter_append_caps() if the filter is instantiated.

5 years agoClassify vaapidecodebin as a hardware decoder
Thibault Saunier [Wed, 28 Aug 2019 16:49:03 +0000 (12:49 -0400)]
Classify vaapidecodebin as a hardware decoder

5 years agolibs: postproc: fix a memory leak point.
He Junyan [Tue, 27 Aug 2019 10:12:45 +0000 (18:12 +0800)]
libs: postproc: fix a memory leak point.

filter_ops and filter_formats should already have valid value when
the function gst_vaapipostproc_ensure_filter_caps re-enter

5 years agolibs: util: Fix a memory leak in config_surface_attributes_get
He Junyan [Mon, 26 Aug 2019 17:30:36 +0000 (01:30 +0800)]
libs: util: Fix a memory leak in config_surface_attributes_get

5 years agovaapidecode: support transform ROI meta
Wangfei [Thu, 22 Aug 2019 06:33:54 +0000 (14:33 +0800)]
vaapidecode: support transform ROI meta

This will benefit the use case like:

src --->   encode    ---> decode ---> circle ROI ---> sink
     |                |
     --> analyse to -->
         get ROI

5 years agodocstrings: port ulinks to markdown links
Mathieu Duponchelle [Fri, 23 Aug 2019 17:10:15 +0000 (19:10 +0200)]
docstrings: port ulinks to markdown links

5 years agolibs: remove context's overlay
Víctor Manuel Jáquez Leal [Tue, 20 Aug 2019 15:05:14 +0000 (17:05 +0200)]
libs: remove context's overlay

The context overlay was an optimization to apply a video composition
to all the surfaces bound to a context.

But since commit 18031dc6 this optimization was disabled, so it is
better just get rid of it.

5 years agolibs: remove surface's parent context
Víctor Manuel Jáquez Leal [Tue, 20 Aug 2019 14:50:46 +0000 (16:50 +0200)]
libs: remove surface's parent context

In commit 18031dc6 surface's parent context is not assigned because of
circular references. Since then (2013), there's has no issue with
subpictures attached to a context, the current only users of this API.

This patch cleans up all of related code with the unused surface's
parent context.

5 years agovaapidecode: guard if no structure is available in caps
Víctor Manuel Jáquez Leal [Sun, 18 Aug 2019 11:53:53 +0000 (13:53 +0200)]
vaapidecode: guard if no structure is available in caps

5 years agovaapipostproc: append frame size restrictions in caps
Víctor Manuel Jáquez Leal [Sun, 18 Aug 2019 11:53:19 +0000 (13:53 +0200)]
vaapipostproc: append frame size restrictions in caps

5 years agolibs: profilecaps: refactor common code
Víctor Manuel Jáquez Leal [Sun, 18 Aug 2019 11:09:58 +0000 (13:09 +0200)]
libs: profilecaps: refactor common code

5 years agovaapiencode: set frame size restrictions in caps
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:35:58 +0000 (19:35 +0200)]
vaapiencode: set frame size restrictions in caps

Fixes: #12

5 years agovaapiencode: enhance how the profile is defined
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:28:27 +0000 (19:28 +0200)]
vaapiencode: enhance how the profile is defined

This code doesn't define the profile used by the internal encoder, but
it used to "predict" which is going to be used and to get the caps
restrictions.

Before the profile was predicted by checking the donwstream caps, but
sometimes they are not defined, setting an unknown profile. In order
to enhances this situation, the encoder asks to internal encoder if it
has one. If so, it is used.

To ask the internal encoder's profile a new accessor function was
added: gst_vaapi_encoder_get_profile()

5 years agolibs: profilecaps: defines gst_vaapi_profile_caps_append_encoder()
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:26:36 +0000 (19:26 +0200)]
libs: profilecaps: defines gst_vaapi_profile_caps_append_encoder()

Previously it was just a boilerplate. Now it is real implementation.

5 years agolibs: utils: treat va_rt_format as bitwise flag
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:17:48 +0000 (19:17 +0200)]
libs: utils: treat va_rt_format as bitwise flag

The return value of vaGetConfigAttributes() of VAConfigAttribRTFormat
is a bitwise flag with *all* the supported chroma types.

Previously it was assumed that the return value was a single value,
thus when returning the GST_VAAPI_CHROMA_TYPE_XXX the code was a
simple case. But it is wrong.

This patch changes the case block with a sequence of ifs testing the
bitwise. For now we assume a "priority" list in the testing sequence.

5 years agolibs: profile: add gst_vaapi_profile_get_va_name()
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 16:07:43 +0000 (18:07 +0200)]
libs: profile: add gst_vaapi_profile_get_va_name()

gst_vaapi_profile_get_name() returns a proper name for
GstCaps. Nonetheless, there are many profiles which don't have a name
representation for that realm.

gst_vaapi_profile_get_va_name() returns the name of the profile
according to its VAProfile name.

This new funtion is used in the encoder error message.

5 years agolibs: profilecaps: move caps config into a new file
Víctor Manuel Jáquez Leal [Mon, 5 Aug 2019 17:47:30 +0000 (19:47 +0200)]
libs: profilecaps: move caps config into a new file

Implement all the appending of frame size restrictions in caps, for
encoders and decoders, in a new source file.

5 years agolibs: decoder: ref the caps as property
Víctor Manuel Jáquez Leal [Mon, 5 Aug 2019 17:45:49 +0000 (19:45 +0200)]
libs: decoder: ref the caps as property

5 years agolibs: context: add gst_vaapi_context_get_surface_attributes()
Víctor Manuel Jáquez Leal [Fri, 2 Aug 2019 14:56:17 +0000 (16:56 +0200)]
libs: context: add gst_vaapi_context_get_surface_attributes()

This function copies the surface attributes from the context's object
to the caller.

5 years agolibs: move memory types conversions to gstvaapiutils
Víctor Manuel Jáquez Leal [Fri, 2 Aug 2019 10:46:55 +0000 (12:46 +0200)]
libs: move memory types conversions to gstvaapiutils

And add more supported memory types by current VA.

5 years agolibs: utils: remove unused function gst_vaapi_get_surface_formats()
Víctor Manuel Jáquez Leal [Thu, 1 Aug 2019 17:48:21 +0000 (19:48 +0200)]
libs: utils: remove unused function gst_vaapi_get_surface_formats()

5 years agolibs: context, filter: use new surface attributes API
Víctor Manuel Jáquez Leal [Thu, 1 Aug 2019 17:46:17 +0000 (19:46 +0200)]
libs: context, filter: use new surface attributes API

5 years agolibs: utils: add gst_vaapi_config_surface_attributes_get()
Víctor Manuel Jáquez Leal [Thu, 1 Aug 2019 17:13:39 +0000 (19:13 +0200)]
libs: utils: add gst_vaapi_config_surface_attributes_get()

To extract the surface restrictions per config using a new structure:
GstVaapiConfigSurfaceAttributes

5 years agoSplit the surface attribute retrieval
Víctor Manuel Jáquez Leal [Wed, 31 Jul 2019 11:08:43 +0000 (13:08 +0200)]
Split the surface attribute retrieval

5 years agovaapipostproc: handle navigation downstream event
Víctor Manuel Jáquez Leal [Mon, 15 Jul 2019 19:51:46 +0000 (21:51 +0200)]
vaapipostproc: handle navigation downstream event

When navigation events contains coordiantes those have to be mapped
to the new size and/or orientation.

5 years agotest-vaapisink: also use vaapipostproc to change orientation
Víctor Manuel Jáquez Leal [Mon, 15 Jul 2019 19:23:21 +0000 (21:23 +0200)]
test-vaapisink: also use vaapipostproc to change orientation

5 years agovaapipostproc: handle image-orientation upstream event
Víctor Manuel Jáquez Leal [Mon, 15 Jul 2019 19:27:20 +0000 (21:27 +0200)]
vaapipostproc: handle image-orientation upstream event

Now that vaapipostproc can possible handle video-direction, it
should also handle the image-orientation event from upstream if
video-direction property is set to auto.

5 years agovaapipostproc: add missing locks when adding flags
Víctor Manuel Jáquez Leal [Fri, 26 Jul 2019 20:09:37 +0000 (22:09 +0200)]
vaapipostproc: add missing locks when adding flags

5 years agovaapipostproc: update filter before fixate caps
Víctor Manuel Jáquez Leal [Fri, 26 Jul 2019 20:05:29 +0000 (22:05 +0200)]
vaapipostproc: update filter before fixate caps

It is requiered to know if postproc is capable to change the video
direction before fixating the source caps.

In order to do it, it'ss required to know if there's a functional VPP,
but that's checked at create() vmethod, which occurs after caps
fixating.

This patch checks for a functional VPP at fixate caps and, if so,
checks for the enabled filtes and later do the caps fixations.

5 years agovaapipostproc: element warning if video direction is unsupported
Víctor Manuel Jáquez Leal [Fri, 26 Jul 2019 17:46:09 +0000 (19:46 +0200)]
vaapipostproc: element warning if video direction is unsupported

If the video direction is unsupported by the driver, an element
warning is posted in the bus to notify the application.

gst_vaapi_enum_type_get_nick() was added in the library thus it can
be used elsewhere. It retrives the nick from an enum gtype.

5 years agolibs: filter: check mirror and rotation caps only once
Víctor Manuel Jáquez Leal [Fri, 26 Jul 2019 17:09:54 +0000 (19:09 +0200)]
libs: filter: check mirror and rotation caps only once

This patch locks the display before querying the pipeline caps and
stores the mirror and rotation capabilities, thus they are not queried
every time the video direction is set.

5 years agolibs: encoder: vp9: set VP9_0 profile as default
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 17:51:29 +0000 (19:51 +0200)]
libs: encoder: vp9: set VP9_0 profile as default

Commit 0afc8131 introduced a regression and only NV12 format were
admitted, failing in any other valid color format.

This patch sets the profile to GST_VAAPI_PROFILE_VP9_0 by default.

5 years agolibs: filter: fail if first color balance value is invalid
Víctor Manuel Jáquez Leal [Fri, 16 Aug 2019 11:25:06 +0000 (13:25 +0200)]
libs: filter: fail if first color balance value is invalid

5 years agolibs: filter: set all color balance values
Yan Wang [Tue, 6 Aug 2019 11:24:08 +0000 (19:24 +0800)]
libs: filter: set all color balance values

When set multiple settings of color balance like hue, saturation,
brightness and contrast for vaapipostproc, they should be set as
parameters of color balance filter, at the same color balance
filter calling.

Otherwise, multiple color balance filter calling will cause
previous setting get reset by the last calling with default value.

Fixes #182.

Signed-off-by: Yan Wang <yan.wang@linux.intel.com>
5 years agolibs: h265dec: remove limitation of get iq matrix
Wangfei [Fri, 16 Aug 2019 03:02:08 +0000 (11:02 +0800)]
libs: h265dec: remove limitation of get iq matrix

According hevc spec, scaling_list_data is not related
to chroma_format_idc.

5 years agolibs: videopool: fix undocumented behavior and counting
He Junyan [Thu, 30 May 2019 15:52:51 +0000 (23:52 +0800)]
libs: videopool: fix undocumented behavior and counting

gst_vaapi_video_pool_reserve_unlocked() hit an undocumented behavoir
because it locks twice the same mutex.

Also, n had different meanings in the current code: as an increase
value and as a new total of allocated surfaces.

This patche removes the undocumented behavoir (usually a deadlock) and
fixes the meaning of n as the new total of allocated surfaces.

Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
5 years agolibs: utils: Add missing entries for string_of_VAEntrypoint.
He Junyan [Wed, 17 Jul 2019 03:56:45 +0000 (11:56 +0800)]
libs: utils: Add missing entries for string_of_VAEntrypoint.

5 years agolibs: encoder: Consider vp9 profiles based on input format.
He Junyan [Thu, 18 Jul 2019 14:01:01 +0000 (22:01 +0800)]
libs: encoder: Consider vp9 profiles based on input format.

Only support GST_VAAPI_PROFILE_VP9_0 and GST_VAAPI_PROFILE_VP9_2 now.

Fix: #184

5 years agovaapivideomemory: demote error message to info
Víctor Manuel Jáquez Leal [Mon, 12 Aug 2019 16:41:52 +0000 (18:41 +0200)]
vaapivideomemory: demote error message to info

The main reason to demote the message's level is because it is not an
error, it's a possible output of the trial and there's a code path
that handles it.

Secondly, it's very annoying when using gallium driver for radeon.

5 years agolibs: encoder: h264: support ICQ/QVBR bitrate control mode
Wangfei [Thu, 18 Jul 2019 05:32:46 +0000 (13:32 +0800)]
libs: encoder: h264: support ICQ/QVBR bitrate control mode

ICQ is Intelligent Constant Quality. It will use the initial QP
vaule of icq-quality-factor to adjust QP at MB level intelligently
to improve subjective quality.

QVBR is Quality defined VBR. It will use qvbr-quality-factor to
adjust QP for each MB to get enough quality picture without waste
of bits.

5 years agolibs: Let GST_VAAPI_RATECONTROL_MASK return unsigned int
Wangfei [Mon, 5 Aug 2019 02:51:24 +0000 (10:51 +0800)]
libs: Let GST_VAAPI_RATECONTROL_MASK return unsigned int

The value return from GST_VAAPI_RATECONTROL_MASK will be used by
GST_VAAPI_POPCOUNT32 as its inpput. GST_VAAPI_POPCOUNT32 can only
deal with unsigned int. Otherwise there may be an error of out of
range of integer if we define few more rate-control mode.

5 years agovaapidecodebin: set queue's max size buffers to 1
Víctor Manuel Jáquez Leal [Fri, 7 Jun 2019 07:54:12 +0000 (09:54 +0200)]
vaapidecodebin: set queue's max size buffers to 1

Otherwise the queue will swallow all the available decoder's surfaces
reaching a dead-lock.

This setting might impact the bin's peformance, but it's a trade-off.

5 years agovaapidecodebin: set properties default values
Víctor Manuel Jáquez Leal [Fri, 7 Jun 2019 07:53:08 +0000 (09:53 +0200)]
vaapidecodebin: set properties default values

5 years agovaapidecode: don't error if can't push buffers downtream
Víctor Manuel Jáquez Leal [Fri, 31 May 2019 11:12:35 +0000 (13:12 +0200)]
vaapidecode: don't error if can't push buffers downtream

When the code path goes to push buffers downstream when no surface
available in decoder context, and it fails the code bails out with a
fatal error.

That behavior is wrong, since it shouldn't be fatal. The use case is
when the video stream is disabled.

This patch just ignores the errors in this situation and demotes the
level of a log message.

5 years agolibs: encoder: h264,h265: add new property "max-qp"
Wangfei [Sat, 18 May 2019 05:24:35 +0000 (13:24 +0800)]
libs: encoder: h264,h265: add new property "max-qp"

Add new property "max-qp" to allow set the maximum quantisation
parameter values.

5 years agolibs: encoder: vp9: add low power mode encode
Wangfei [Thu, 23 May 2019 14:18:52 +0000 (10:18 -0400)]
libs: encoder: vp9: add low power mode encode

By now, this feature only support by media-driver on Ice Lake
platform, more information you can reference:
https://github.com/intel/media-driver

5 years agovaapipostproc: update PAR when rotating
U. Artie Eoff [Mon, 15 Jul 2019 22:33:07 +0000 (15:33 -0700)]
vaapipostproc: update PAR when rotating

When rotating, swap pixel-aspect-ratio during
negotiation.

Fixes #181

5 years agovaapipostproc: add rotation support
U. Artie Eoff [Mon, 1 Jul 2019 22:26:18 +0000 (15:26 -0700)]
vaapipostproc: add rotation support

Adds vpp rotation support to vaapipostproc.  Uses
property video-direction. Default is identity (no
rotation).

Closes #104

5 years agolibs: encoder: h265: pass diff_cu_qp_delta_depth flag to driver
Wangfei [Wed, 22 May 2019 14:47:30 +0000 (10:47 -0400)]
libs: encoder: h265: pass diff_cu_qp_delta_depth flag to driver

Intel media-driver requires enablement of diff_cu_qp_delta_depth when
cu_qp_delta_enabled_flag enabled.

Fixes: #177

5 years agolibs: encoder: Add MB ratecontrol mode to get its string
Wangfei [Mon, 1 Jul 2019 09:02:33 +0000 (17:02 +0800)]
libs: encoder: Add MB ratecontrol mode to get its string

5 years agolibs: encoder: refine guard of bitrate control mode
Wangfei [Mon, 1 Jul 2019 08:52:00 +0000 (16:52 +0800)]
libs: encoder: refine guard of bitrate control mode

Remove useless guard of all bitrate control mode's guard except MB
which is define in VA-API version 0.39.1.

5 years agoh264: Update for parse_vui_params parameter removal.
Jan Schmidt [Fri, 28 Jun 2019 14:08:40 +0000 (00:08 +1000)]
h264: Update for parse_vui_params parameter removal.

Update calls to the h264 parser lib for removal of the
parse_vui_params parameter.

5 years agolibs: dec: vp9: do not use display size as decoded size
Wang Zhanjun [Mon, 24 Jun 2019 20:26:56 +0000 (16:26 -0400)]
libs: dec: vp9: do not use display size as decoded size

If display size is smaller than current frame size, then the crop size
will be set as display size, which either crashes the pipeline or the
output MD5 does not match. Rather it should use the actual decoded size.

This patch removes the cropping set. For rendering we can use aspect
ratio to set display size.

Fixes #175

Signed-off-by: Wang Zhanjun <zhanjunx.wang@intel.com>
Signed-off-by: Xu Guangxin <guangxin.xu@intel.com>
5 years agoUpdate README
Víctor Manuel Jáquez Leal [Fri, 28 Jun 2019 14:32:51 +0000 (16:32 +0200)]
Update README

5 years agolibs: dec: h265: Consider chroma_bit_depth to choose chrome type
He Junyan [Tue, 25 Jun 2019 11:11:12 +0000 (19:11 +0800)]
libs: dec: h265: Consider chroma_bit_depth to choose chrome type

For some main-10 stream, sometime the luma is 8 bits while chrome is more
than 8 bits, which cause using the wrong NV12 surface as the render target
and decoding error.

Fix #176