platform/upstream/ofono.git
13 years agounit: Minor style updates to test-sms
Denis Kenzior [Wed, 8 Dec 2010 16:31:05 +0000 (10:31 -0600)]
unit: Minor style updates to test-sms

13 years agoAUTHORS: Mention Oleg's contributions
Denis Kenzior [Wed, 8 Dec 2010 16:27:48 +0000 (10:27 -0600)]
AUTHORS: Mention Oleg's contributions

13 years agounit: add national dialect SMS character set tests
Oleg Zhurakivskyy [Wed, 1 Dec 2010 12:27:42 +0000 (14:27 +0200)]
unit: add national dialect SMS character set tests

13 years agosimutil: fixup style according to M11
Denis Kenzior [Wed, 8 Dec 2010 15:43:25 +0000 (09:43 -0600)]
simutil: fixup style according to M11

13 years agogdbus: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:01 +0000 (17:39 -0200)]
gdbus: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agostk: Handle provide local info proactive command
Yang Gu [Tue, 30 Nov 2010 10:44:50 +0000 (18:44 +0800)]
stk: Handle provide local info proactive command

13 years agosmsutil: Make timezone an optional field
Yang Gu [Tue, 30 Nov 2010 10:44:49 +0000 (18:44 +0800)]
smsutil: Make timezone an optional field

13 years agotest: When priting help for enter-pin, exit
Denis Kenzior [Wed, 8 Dec 2010 13:03:01 +0000 (07:03 -0600)]
test: When priting help for enter-pin, exit

13 years agosmsutil: Change the range of time zone
Yang Gu [Tue, 30 Nov 2010 10:44:48 +0000 (18:44 +0800)]
smsutil: Change the range of time zone

13 years agophonesim: Add modem reset trigger
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:56 +0000 (16:52 -0200)]
phonesim: Add modem reset trigger

13 years agoAdd ofono_modem_reset()
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:55 +0000 (16:52 -0200)]
Add ofono_modem_reset()

Some modems can screw up everything and then we will need to do a silent
reset of the modem. This patch take the modem back to the OFFLINE state.

13 years agomodem: add ofono_modem_reset() to modem.h
Gustavo F. Padovan [Fri, 3 Dec 2010 18:52:54 +0000 (16:52 -0200)]
modem: add ofono_modem_reset() to modem.h

13 years agomodem: only unref pending if it is a powered pending
Gustavo F. Padovan [Fri, 3 Dec 2010 21:40:22 +0000 (19:40 -0200)]
modem: only unref pending if it is a powered pending

13 years agoTODO: add owner to 'SIM PIN retry counter' task
Lucas De Marchi [Thu, 2 Dec 2010 12:46:46 +0000 (10:46 -0200)]
TODO: add owner to 'SIM PIN retry counter' task

13 years agoTODO: Add owner for the CNAP task
Gustavo F. Padovan [Thu, 2 Dec 2010 17:14:43 +0000 (15:14 -0200)]
TODO: Add owner for the CNAP task

13 years agogatchat: fix canceling in progress commands
Vinicius Costa Gomes [Thu, 2 Dec 2010 20:13:42 +0000 (17:13 -0300)]
gatchat: fix canceling in progress commands

As g_queue_peek_head() returns the node data field, we have to compare
it against the actual command, not against the pointer to the queue node.

13 years agosmsutil: Minor style fix
Denis Kenzior [Tue, 7 Dec 2010 02:11:55 +0000 (20:11 -0600)]
smsutil: Minor style fix

13 years agobuild: Silence another make message
Marcel Holtmann [Tue, 7 Dec 2010 09:00:36 +0000 (10:00 +0100)]
build: Silence another make message

13 years agoMark ofono/*.h symbolink links as built sources
Rémi Denis-Courmont [Mon, 6 Dec 2010 15:49:56 +0000 (17:49 +0200)]
Mark ofono/*.h symbolink links as built sources

This forces automake/make to build them first if needed (as before).
But it avoids marking every single header as a dependency of every
single object. Thus we do not need a bogus full rebuild of the tree
everytime a header is added.

13 years agovoicecall: fix dial result handling
Pekka Pessi [Fri, 26 Nov 2010 15:14:49 +0000 (17:14 +0200)]
voicecall: fix dial result handling

The existing call will be automatically put on hold if there is an
existing active call when dialing. On some modems the dial request
returns only after the dialed call is active and the existing call has
been put on hold.

However, on isimodem driver the dial request returns immediately before
the existing call has changed its status. With isimodem driver the
dial_handle_result() selected the existing call from the list when it
should have created a new one.

The dial result handling now guards againt returning a previously dialed
active call as result.

13 years agonetwork: Send strength as a byte, not uint16
Denis Kenzior [Fri, 3 Dec 2010 18:14:06 +0000 (12:14 -0600)]
network: Send strength as a byte, not uint16

To be consistent with the documentation

13 years agoAUTHORS: Mention Helen's contributions
Denis Kenzior [Thu, 2 Dec 2010 20:24:07 +0000 (14:24 -0600)]
AUTHORS: Mention Helen's contributions

13 years agoste: Minor style fixes
Denis Kenzior [Thu, 2 Dec 2010 20:23:35 +0000 (14:23 -0600)]
ste: Minor style fixes

13 years agoste: Restructure caif channel creation
Helen Clemson [Thu, 2 Dec 2010 11:05:40 +0000 (12:05 +0100)]
ste: Restructure caif channel creation

This is restructuring the caif channel creation, so that at a later
date multiple AT channels can be supported. This effectively moves
the channel creation from ste_enable, into its own function,
ste_create_channel.

13 years agoisi/voicecall: fix handling of waiting calls
Pekka Pessi [Fri, 3 Dec 2010 08:30:50 +0000 (10:30 +0200)]
isi/voicecall: fix handling of waiting calls

Also, do not retrieve calls after isi_release_all_active() because
retrieving is now only an unwanted side-effect .

13 years agoisi/voicecall: avoid side-effects of release
Pekka Pessi [Fri, 3 Dec 2010 08:30:49 +0000 (10:30 +0200)]
isi/voicecall: avoid side-effects of release

If a call was held automatically when an another call was dialed or
answered, it gets retrieved when the other call is released unless
auto change features is explicitly disabled.

Drop cause_type parameter because it is never used.

Use cause code for busy when releasing incoming or waiting calls.

13 years agoisi/voicecall: add call id to queued requests
Pekka Pessi [Fri, 3 Dec 2010 08:30:48 +0000 (10:30 +0200)]
isi/voicecall: add call id to queued requests

13 years agoisi/voicecall: fix status reporting
Pekka Pessi [Fri, 3 Dec 2010 08:30:47 +0000 (10:30 +0200)]
isi/voicecall: fix status reporting

Do not report incoming calls to the oFono core until they can be
answered.

Report MT_RELEASED or MO_RELEASED via ofono_voicecall_notify(),
TERMINATED calls via ofono_voicecall_disconnected().

13 years agocoding-style M14: parenthesis around sizeof arg
Pekka Pessi [Fri, 3 Dec 2010 09:05:28 +0000 (11:05 +0200)]
coding-style M14: parenthesis around sizeof arg

13 years agotest: Unregister agents on keyboard interrupt
Aki Niemi [Fri, 3 Dec 2010 12:47:40 +0000 (14:47 +0200)]
test: Unregister agents on keyboard interrupt

Control-C now calls UnregisterAgent(), so the agents exit cleanly.

13 years agotest: Fix script output
Aki Niemi [Fri, 3 Dec 2010 12:46:51 +0000 (14:46 +0200)]
test: Fix script output

There is no proposing, just action.

13 years agoTODO: Add owner for IAP database task
Aki Niemi [Fri, 3 Dec 2010 12:36:17 +0000 (14:36 +0200)]
TODO: Add owner for IAP database task

13 years agodoc: Don't go over 80 characters / line
Denis Kenzior [Thu, 2 Dec 2010 17:22:07 +0000 (11:22 -0600)]
doc: Don't go over 80 characters / line

13 years agodoc: Move DisconnectReason to the signals section
Denis Kenzior [Thu, 2 Dec 2010 17:21:07 +0000 (11:21 -0600)]
doc: Move DisconnectReason to the signals section

13 years agoatmodem: fix DBG message
Gustavo F. Padovan [Tue, 30 Nov 2010 22:14:39 +0000 (20:14 -0200)]
atmodem: fix DBG message

13 years agoAUTHORS: Mention Rafael's contributions
Denis Kenzior [Thu, 2 Dec 2010 14:13:41 +0000 (08:13 -0600)]
AUTHORS: Mention Rafael's contributions

13 years agoHACKING: Add ofono.conf file copy command required
Rafael Ignacio Zurita [Tue, 30 Nov 2010 21:56:23 +0000 (18:56 -0300)]
HACKING: Add ofono.conf file copy command required

Add ofono.conf copy command required for oFono core daemon to work.

13 years agoHACKING: add guidelines to patch submission
Lucas De Marchi [Wed, 1 Dec 2010 15:46:44 +0000 (13:46 -0200)]
HACKING: add guidelines to patch submission

13 years agosmsutil: Fix issue in mwi dcs decoding
Jeevaka Badrappan [Thu, 2 Dec 2010 09:43:27 +0000 (01:43 -0800)]
smsutil: Fix issue in mwi dcs decoding

13 years agotest: Add support for PlayTone and LoopTone
Zhigang Li [Thu, 2 Dec 2010 09:29:22 +0000 (17:29 +0800)]
test: Add support for PlayTone and LoopTone

13 years agoAUTHORS: Mention Antti's contributions
Denis Kenzior [Thu, 2 Dec 2010 13:58:48 +0000 (07:58 -0600)]
AUTHORS: Mention Antti's contributions

13 years agogprs: Fix for gprs context conversion
Antti Paila [Thu, 2 Dec 2010 07:19:00 +0000 (09:19 +0200)]
gprs: Fix for gprs context conversion

13 years agosmsutil: Fix uninitialized optional elements
Denis Kenzior [Thu, 2 Dec 2010 13:53:54 +0000 (07:53 -0600)]
smsutil: Fix uninitialized optional elements

sms_decode was never memsetting the returned structure, so if any
optional elements were present in the SMS (e.g. status report) then the
structure was not completely initialized.

13 years agosms: Use the right union member for DCS check
Denis Kenzior [Thu, 2 Dec 2010 13:49:49 +0000 (07:49 -0600)]
sms: Use the right union member for DCS check

13 years agodoc: Mark EmergencyNumbers property readonly
Denis Kenzior [Wed, 1 Dec 2010 22:25:17 +0000 (16:25 -0600)]
doc: Mark EmergencyNumbers property readonly

13 years agostk: Add busy error for the display text command
Guillaume Lucas [Tue, 30 Nov 2010 13:21:50 +0000 (13:21 +0000)]
stk: Add busy error for the display text command

According to the sequence 1.2 of the ETSI TS 102 384 a busy
screen error should be returns for the display text proactive
command when the ME is not able to display the text.

13 years agosim: be more paranoid for triggering EFest read
Jeevaka Badrappan [Mon, 29 Nov 2010 16:57:39 +0000 (08:57 -0800)]
sim: be more paranoid for triggering EFest read

13 years agoTODO: minor typo
Denis Kenzior [Mon, 29 Nov 2010 19:53:36 +0000 (13:53 -0600)]
TODO: minor typo

13 years agocore: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
core: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agosimutil: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
simutil: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agosimfs: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
simfs: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agoutil: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
util: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agostkutil: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
stkutil: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agosmsutil: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:03 +0000 (17:39 -0200)]
smsutil: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agoplugins: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:02 +0000 (17:39 -0200)]
plugins: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agogatchat: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:39:00 +0000 (17:39 -0200)]
gatchat: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agoexamples: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:38:59 +0000 (17:38 -0200)]
examples: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agogisi: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:38:58 +0000 (17:38 -0200)]
gisi: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agounit: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:38:57 +0000 (17:38 -0200)]
unit: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agoisi: Get rid of a pointless check in cf driver
Denis Kenzior [Mon, 29 Nov 2010 17:47:47 +0000 (11:47 -0600)]
isi: Get rid of a pointless check in cf driver

13 years agodrivers: explicitly compare pointers to NULL
Lucas De Marchi [Sat, 27 Nov 2010 19:38:56 +0000 (17:38 -0200)]
drivers: explicitly compare pointers to NULL

This patch was generated by the following semantic patch
(http://coccinelle.lip6.fr/)

// <smpl>
@fix disable is_null,isnt_null1@
expression *E;
@@

- !E
+ E == NULL
// </smpl>

13 years agocoding-style: add rule about checking NULL pointer
Lucas De Marchi [Sat, 27 Nov 2010 19:38:55 +0000 (17:38 -0200)]
coding-style: add rule about checking NULL pointer

13 years agoTODO: Mark CTM task as done
Lucas De Marchi [Sat, 27 Nov 2010 19:22:55 +0000 (17:22 -0200)]
TODO: Mark CTM task as done

13 years agophonesim: implement ctm atom
Lucas De Marchi [Sat, 27 Nov 2010 19:22:54 +0000 (17:22 -0200)]
phonesim: implement ctm atom

13 years agoisi: Update radio-settings to use new API
Denis Kenzior [Mon, 29 Nov 2010 13:51:53 +0000 (07:51 -0600)]
isi: Update radio-settings to use new API

13 years agoradio-settings: Update API to use ofono_bool_t
Denis Kenzior [Mon, 29 Nov 2010 13:51:41 +0000 (07:51 -0600)]
radio-settings: Update API to use ofono_bool_t

13 years agoatmodem: Forgot to reset sms data on remove
Denis Kenzior [Sat, 27 Nov 2010 17:57:50 +0000 (11:57 -0600)]
atmodem: Forgot to reset sms data on remove

13 years agoconfigure: do not hard-code the C run-time library name
Rémi Denis-Courmont [Mon, 29 Nov 2010 08:29:02 +0000 (10:29 +0200)]
configure: do not hard-code the C run-time library name

Since oFono does (obviously) not use -nostdlib, this only broke support
for alternative C run-times.

13 years agosimutil: Add EFcfis and EFcphs-cff file Ids
Jeevaka Badrappan [Fri, 26 Nov 2010 06:23:31 +0000 (22:23 -0800)]
simutil: Add EFcfis and EFcphs-cff file Ids

13 years agocall-volume: Minor coding style fix
Jeevaka Badrappan [Fri, 26 Nov 2010 21:21:06 +0000 (13:21 -0800)]
call-volume: Minor coding style fix

13 years agoaudio-settings: Remove unwanted check
Jeevaka Badrappan [Fri, 26 Nov 2010 12:27:42 +0000 (04:27 -0800)]
audio-settings: Remove unwanted check

13 years agocall-volume: Remove extra line at EOF
Jeevaka Badrappan [Fri, 26 Nov 2010 20:59:38 +0000 (12:59 -0800)]
call-volume: Remove extra line at EOF

13 years agodoc: update cdma-voicecall-manager-api.txt
Arun Ravindran [Fri, 26 Nov 2010 09:54:02 +0000 (11:54 +0200)]
doc: update cdma-voicecall-manager-api.txt

13 years agonetwork: Use bit as size instead of byte
Yang Gu [Thu, 25 Nov 2010 12:29:00 +0000 (20:29 +0800)]
network: Use bit as size instead of byte

13 years agocore: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
core: Remove stray newlines in messages sent to log

13 years agoisigen: Remove stray newlines in DBG
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isigen: Remove stray newlines in DBG

13 years agoste: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
ste: Remove stray newlines in messages sent to log

13 years agoisi: Remove stray newlines in messages sent to log
Rémi Denis-Courmont [Thu, 25 Nov 2010 10:51:03 +0000 (12:51 +0200)]
isi: Remove stray newlines in messages sent to log

13 years agocall-volume: Fix dbus error message type
Jeevaka Badrappan [Fri, 26 Nov 2010 14:59:32 +0000 (06:59 -0800)]
call-volume: Fix dbus error message type

13 years agobuild: Add forgotten test/test-tty
Denis Kenzior [Fri, 26 Nov 2010 19:22:55 +0000 (13:22 -0600)]
build: Add forgotten test/test-tty

13 years agotest: add test/set-tty script
Lucas De Marchi [Thu, 25 Nov 2010 17:42:00 +0000 (15:42 -0200)]
test: add test/set-tty script

To enable/disable text-telephony support

13 years agoctm: Tweak documentation to reflect implementation
Denis Kenzior [Fri, 26 Nov 2010 18:56:43 +0000 (12:56 -0600)]
ctm: Tweak documentation to reflect implementation

13 years agoctm: fix minor style issues
Denis Kenzior [Fri, 26 Nov 2010 18:55:50 +0000 (12:55 -0600)]
ctm: fix minor style issues

13 years agoctm: add documentation for TextTelephony interface
Lucas De Marchi [Thu, 25 Nov 2010 17:41:58 +0000 (15:41 -0200)]
ctm: add documentation for TextTelephony interface

13 years agoctm: Add initial CTM atom implementation
Lucas De Marchi [Thu, 25 Nov 2010 17:41:57 +0000 (15:41 -0200)]
ctm: Add initial CTM atom implementation

13 years agoctm: add public header
Lucas De Marchi [Thu, 25 Nov 2010 17:41:56 +0000 (15:41 -0200)]
ctm: add public header

13 years agostkutil: Minor style fixes
Denis Kenzior [Thu, 25 Nov 2010 23:58:37 +0000 (17:58 -0600)]
stkutil: Minor style fixes

13 years agostkutil: Use sms_dcs_decode in decode_text
Guillaume Lucas [Thu, 25 Nov 2010 16:15:04 +0000 (16:15 +0000)]
stkutil: Use sms_dcs_decode in decode_text

This is a much more pedantic version that can be used to
retrieve the text character set.

13 years agostk: use bigger timeout in DisplayText
Andrzej Zaborowski [Tue, 23 Nov 2010 13:35:41 +0000 (14:35 +0100)]
stk: use bigger timeout in DisplayText

When the wait for user confirmation bit is set.

13 years agocall-forwarding: skip property change data and fax
Jeevaka Badrappan [Wed, 24 Nov 2010 09:57:33 +0000 (01:57 -0800)]
call-forwarding: skip property change data and fax

13 years agodoc: Add PropertyChanged signal to voicecall api
Denis Kenzior [Wed, 24 Nov 2010 21:43:31 +0000 (15:43 -0600)]
doc: Add PropertyChanged signal to voicecall api

13 years agodoc: Add GetProperties to CDMA voicecall api
Denis Kenzior [Wed, 24 Nov 2010 21:43:17 +0000 (15:43 -0600)]
doc: Add GetProperties to CDMA voicecall api

13 years agodoc: Update voicecallmanager-api.txt
Arun Ravindran [Wed, 24 Nov 2010 14:56:11 +0000 (16:56 +0200)]
doc: Update voicecallmanager-api.txt

13 years agotext-telephony: add new interface to feature map
Lucas De Marchi [Tue, 23 Nov 2010 18:04:14 +0000 (16:04 -0200)]
text-telephony: add new interface to feature map

13 years agotext-telephony: define new dbus interface
Lucas De Marchi [Tue, 23 Nov 2010 18:04:13 +0000 (16:04 -0200)]
text-telephony: define new dbus interface

13 years agoTODO: Take ownership of neighbor cell atom task
Aki Niemi [Wed, 24 Nov 2010 12:39:20 +0000 (14:39 +0200)]
TODO: Take ownership of neighbor cell atom task

13 years agodoc: update radio-settings-api with possible errors
Lucas De Marchi [Tue, 23 Nov 2010 18:08:35 +0000 (16:08 -0200)]
doc: update radio-settings-api with possible errors

When GetProperties() and SetProperty() are called, there are more errors
that might be returned. Add them in documentation.

13 years agoRelease 0.36 0.36
Marcel Holtmann [Tue, 23 Nov 2010 13:55:57 +0000 (14:55 +0100)]
Release 0.36

13 years agodoc: Add initial CDMA D-Bus API proposal
Denis Kenzior [Tue, 23 Nov 2010 12:59:39 +0000 (06:59 -0600)]
doc: Add initial CDMA D-Bus API proposal

13 years agocommon: remove redundant predicate
Rémi Denis-Courmont [Tue, 23 Nov 2010 12:40:38 +0000 (14:40 +0200)]
common: remove redundant predicate

If the first character is a plus sign, then it is not a nul, then
the string length is true anyway.