platform/upstream/libSkiaSharp.git
9 years agoFix DiscardableMemoryPool::free race condition
halcanary [Thu, 26 Mar 2015 21:08:56 +0000 (14:08 -0700)]
Fix DiscardableMemoryPool::free race condition

BUG=skia:3596

Review URL: https://codereview.chromium.org/1017943003

9 years agoRevert of Make the canvas draw looper setup update the canvas save count (patchset...
reed [Thu, 26 Mar 2015 20:40:09 +0000 (13:40 -0700)]
Revert of Make the canvas draw looper setup update the canvas save count (patchset #1 id:1 of https://codereview.chromium.org/1034033004/)

Reason for revert:
makes internalSave and internalSaveLayer inconsistent. Need to find a different solution.

Original issue's description:
> Make the canvas draw looper setup update the canvas save count
>
> Image filter in a paint would leave save count in wrong state
> for normal draws. This could be observed through the canvas
> references during the draw call. An example of this is
> inspecting the canvas during a draw looper.
>
> patch from issue 993863002 at patchset 20001 (http://crrev.com/993863002#ps20001)
>
> BUG=skia:
> TBR=kkinnunen@nvidia.com
>
> Committed: https://skia.googlesource.com/skia/+/fd3a91e1fc4de69611b5297f624a1cd65db4ced1

TBR=kkinnunen@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1037653004

9 years agoMake the canvas draw looper setup update the canvas save count
reed [Thu, 26 Mar 2015 20:29:56 +0000 (13:29 -0700)]
Make the canvas draw looper setup update the canvas save count

Image filter in a paint would leave save count in wrong state
for normal draws. This could be observed through the canvas
references during the draw call. An example of this is
inspecting the canvas during a draw looper.

patch from issue 993863002 at patchset 20001 (http://crrev.com/993863002#ps20001)

BUG=skia:
TBR=kkinnunen@nvidia.com

Review URL: https://codereview.chromium.org/1034033004

9 years agoSkPMFloat::trunc()
mtklein [Thu, 26 Mar 2015 19:32:29 +0000 (12:32 -0700)]
SkPMFloat::trunc()

Add and test trunc(), which is what get() used to be before rounding.
Using trunc() is a ~40% speedup on our linear gradient bench.

#neon #floats
BUG=skia:3592
#n5
#n9
CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus5-Adreno330-Arm7-Debug-Trybot;client.skia.android:Test-Android-Nexus9-TegraK1-Arm64-Release-Trybot

Review URL: https://codereview.chromium.org/1032243002

9 years agoAndroid HWUI backend Nanobench
tomhudson [Thu, 26 Mar 2015 18:28:06 +0000 (11:28 -0700)]
Android HWUI backend Nanobench

Uses filtering canvas from utils/android, shared with DM.
Follow-up plans in https://skbug.com/3589, https://skbug.com/3595

R=djsollen@google.com

Review URL: https://codereview.chromium.org/1029423010

9 years agosmall fix for nanobench segfault when not running any tests
joshualitt [Thu, 26 Mar 2015 17:41:02 +0000 (10:41 -0700)]
small fix for nanobench segfault when not running any tests

BUG=skia:

Review URL: https://codereview.chromium.org/1030353004

9 years agoRemove unused HWAA flag and uniqueID field from GrDrawTargetCaps.
egdaniel [Thu, 26 Mar 2015 17:13:05 +0000 (10:13 -0700)]
Remove unused HWAA flag and uniqueID field from GrDrawTargetCaps.

BUG=skia:

Review URL: https://codereview.chromium.org/1019303005

9 years agoDebugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents)
robertphillips [Thu, 26 Mar 2015 17:08:04 +0000 (10:08 -0700)]
Debugger: remove dead feature (SkPicture offset display) & fix bug (unbalanced indents)

Displaying the offset into an SkPicture hasn't worked for a while so this CL deletes the feature.
When "Save Layer" was renamed to "SaveLayer" the code that computes the indent in the list view was broken. This CL patches the problem.

Review URL: https://codereview.chromium.org/1034733004

9 years agoSilence PNG warnings from SkPngCodec.
scroggo [Thu, 26 Mar 2015 17:07:56 +0000 (10:07 -0700)]
Silence PNG warnings from SkPngCodec.

Review URL: https://codereview.chromium.org/1009633005

9 years agouse new faster/vector impl for chopping conics
reed [Thu, 26 Mar 2015 16:10:22 +0000 (09:10 -0700)]
use new faster/vector impl for chopping conics

BUG=skia:

Review URL: https://codereview.chromium.org/1035943002

9 years agoAdd support for using alternative backends (like DirectX) when creating a GrGpu.
egdaniel [Thu, 26 Mar 2015 16:09:41 +0000 (09:09 -0700)]
Add support for using alternative backends (like DirectX) when creating a GrGpu.

BUG=skia:

Review URL: https://codereview.chromium.org/1038643002

9 years agoadd legacy pathop enums; fix uninitialized warning
caryclark [Thu, 26 Mar 2015 16:05:12 +0000 (09:05 -0700)]
add legacy pathop enums; fix uninitialized warning

R=reed@google.com
BUG=skia:3588
NOTREECHECKS=true
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1034073004

9 years agocumulative pathops patch
caryclark [Thu, 26 Mar 2015 14:52:43 +0000 (07:52 -0700)]
cumulative pathops patch

Replace the implicit curve intersection with a geometric curve intersection. The implicit intersection proved mathematically unstable and took a long time to zero in on an answer.

Use pointers instead of indices to refer to parts of curves. Indices required awkward renumbering.

Unify t and point values so that small intervals can be eliminated in one pass.

Break cubics up front to eliminate loops and cusps.

Make the Simplify and Op code more regular and eliminate arbitrary differences.

Add a builder that takes an array of paths and operators.

Delete unused code.

BUG=skia:3588
R=reed@google.com

Review URL: https://codereview.chromium.org/1037573004

9 years agoremove slower scalar code in favor of vectors
reed [Thu, 26 Mar 2015 14:26:08 +0000 (07:26 -0700)]
remove slower scalar code in favor of vectors

BUG=skia:

Review URL: https://codereview.chromium.org/1001833006

9 years agoAdd a paint filter utility canvas (SkPaintFilterCanvas)
fmalita [Thu, 26 Mar 2015 14:24:48 +0000 (07:24 -0700)]
Add a paint filter utility canvas (SkPaintFilterCanvas)

Introduce a paint filter proxy base class as a SkDrawFilter replacement,
and convert SkDebugCanvas to use the new approach.

BUG=skia:3587
R=reed@google.com,mtklein@google.com,robertphillips@google.com,tomhudson@google.com

Review URL: https://codereview.chromium.org/1032173002

9 years agoUse a wrapper for SkDebugf in SkCodec.
scroggo [Thu, 26 Mar 2015 14:15:55 +0000 (07:15 -0700)]
Use a wrapper for SkDebugf in SkCodec.

It can be silenced or not with one flag.
Always print when building for the android framework.

Also remove the meaningless define of override to override.

BUG=skia:3257

Review URL: https://codereview.chromium.org/1032093004

9 years agoSkCodec: conditionally remove fInfo
halcanary [Thu, 26 Mar 2015 13:29:03 +0000 (06:29 -0700)]
SkCodec: conditionally remove fInfo

Review URL: https://codereview.chromium.org/1029423005

9 years agoAdd a go-fast button to Skia GYP configs.
mtklein [Thu, 26 Mar 2015 12:30:44 +0000 (05:30 -0700)]
Add a go-fast button to Skia GYP configs.

./gyp_skia -Dskia_fast=1 will
  - always optimize for the current machine as much as possible
  - drop the frame pointer
  - optimize floating point arithmetic ignoring IEEE compliance

This allows things like 3-argument VEX prefix SSE instructions and
NEON autovectorization, and can give some seriously helpful clues
about how to rearrange floating point math for speed.

I've been having trouble with LTO linking, so I'll leave that out for now.

I don't think we should set up bots with this mode.  -ffast-math means
I'm forced to run DM with --match ~Blend ~Path ~Rect ~Math ~Scalar
~Matrix ~Point before it passes, which is a disconcerting chunk of tests
to disable (including all of PathOps).

BUG=skia:

Review URL: https://codereview.chromium.org/1036533003

9 years agopdf skp tabl_worldjournal.skp took 5 days to run on Valgrind
mtklein [Thu, 26 Mar 2015 12:12:13 +0000 (05:12 -0700)]
pdf skp tabl_worldjournal.skp took 5 days to run on Valgrind

 #notry

BUG=skia:
NOTRY=true

Review URL: https://codereview.chromium.org/1030263003

9 years agoremove #if 0 code
reed [Thu, 26 Mar 2015 11:15:19 +0000 (04:15 -0700)]
remove #if 0 code

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1032273003

9 years agouse custom search for pathmeasure
reed [Thu, 26 Mar 2015 11:13:08 +0000 (04:13 -0700)]
use custom search for pathmeasure

BUG=skia:

Review URL: https://codereview.chromium.org/1037653002

9 years agoC++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}
mtklein [Thu, 26 Mar 2015 01:17:31 +0000 (18:17 -0700)]
C++11 override should now be supported by all of {bots,Chrome,Android,Mozilla}

NOPRESUBMIT=true

BUG=skia:
DOCS_PREVIEW= https://skia.org/?cl=1037793002

Review URL: https://codereview.chromium.org/1037793002

9 years agohack on linear gradient
mtklein [Thu, 26 Mar 2015 01:13:02 +0000 (18:13 -0700)]
hack on linear gradient

Am I going nuts or can we get this down to just adds and converts in the loop?

#floats #n9
BUG=skia:3592
CQ_INCLUDE_TRYBOTS=client.skia.android:Test-Android-Nexus9-TegraK1-Arm64-Release-Trybot

Review URL: https://codereview.chromium.org/1008973004

9 years agoRemove sfnt dependency from xps gyp tartget.
bungeman [Wed, 25 Mar 2015 21:48:05 +0000 (14:48 -0700)]
Remove sfnt dependency from xps gyp tartget.

The xps gyp target depends on skia_lib, which in turn contains
the sfnt target (and re-exports it settings). As a result, it
should not separately depend on the sfnt target. This currently
isn't causing issues because the sfnt target is mostly header only,
but any code in it may be duplicated.

Review URL: https://codereview.chromium.org/1038693003

9 years agoUse Sk4x to speed-up bounds of an array of points
reed [Wed, 25 Mar 2015 21:30:49 +0000 (14:30 -0700)]
Use Sk4x to speed-up bounds of an array of points

BUG=skia:

Review URL: https://codereview.chromium.org/1015633004

9 years agoAdd more parameters to GrTextContext::canDraw
cdalton [Wed, 25 Mar 2015 21:02:37 +0000 (14:02 -0700)]
Add more parameters to GrTextContext::canDraw

Updates canDraw to accept all the same Skia/Gr objects as the drawText
functions, since that information may very well be relevant in
determining whether a context can draw.

Also moves the onDrawTextBlob implementation directly into
drawTextBlob.

BUG=skia:

Review URL: https://codereview.chromium.org/1010113004

9 years agoTest scanline decoding in DM.
scroggo [Wed, 25 Mar 2015 20:48:49 +0000 (13:48 -0700)]
Test scanline decoding in DM.

BUG=skia:3475

Review URL: https://codereview.chromium.org/999173010

9 years agoReplace error checking mutex initializer with the glibc-compatible version
djsollen [Wed, 25 Mar 2015 20:47:13 +0000 (13:47 -0700)]
Replace error checking mutex initializer with the glibc-compatible version

No public API changes.
TBR=reed@google.com

Review URL: https://codereview.chromium.org/1038733002

9 years agoUpdate 4-at-a-time APIs.
mtklein [Wed, 25 Mar 2015 20:43:34 +0000 (13:43 -0700)]
Update 4-at-a-time APIs.

There is no reason to require the 4 SkPMFloats (registers) to be adjacent.
The only potential win in loads and stores comes from the SkPMColors being adjacent.

Makes no difference to existing bench.

BUG=skia:

Review URL: https://codereview.chromium.org/1035583002

9 years agosimple patch to always init SkTextBlob uniqueID
joshualitt [Wed, 25 Mar 2015 20:40:13 +0000 (13:40 -0700)]
simple patch to always init SkTextBlob uniqueID

BUG=skia:

Review URL: https://codereview.chromium.org/1036613002

9 years agoSkPDF SkPDFObject::addResources signature simplified
halcanary [Wed, 25 Mar 2015 20:23:13 +0000 (13:23 -0700)]
SkPDF SkPDFObject::addResources signature simplified

-   SkPDFcatalog keeps a ordered list of object pointers
-   Elimiante SkTSet template class
-   SkPDFObject::addResources signature changes

BUG=skia:3585

Review URL: https://codereview.chromium.org/1038523004

9 years agoLazy SKP image decoding in DM.
mtklein [Wed, 25 Mar 2015 20:13:43 +0000 (13:13 -0700)]
Lazy SKP image decoding in DM.

@sugoi:
Early out to avoid some segfaults in SkImageDecoder_libjpeg.cpp.
I am just flailing here... things seem to work, but I have no idea why.
This prints out a lot:
    libjpeg error 85 <End Of Image> from output_raw_data [0 0]

@halcanary:
I'm skipping on ImageSrc for now.  Leon's refactoring that quite a lot.

This causes minor diffs for the GPU backend, given that we're now
going through the YUV path.  It also reduced peak RAM usage on
my desktop from 1.26GB to 1.08GB.

BUG=skia:

Review URL: https://codereview.chromium.org/1010983004

9 years agoland some real hashtags
mtklein [Wed, 25 Mar 2015 20:08:42 +0000 (13:08 -0700)]
land some real hashtags

BUG=skia:

Review URL: https://codereview.chromium.org/1029973003

9 years agoAdd post upload hook to substitute hashtags for their mapped text
rmistry [Wed, 25 Mar 2015 19:53:35 +0000 (12:53 -0700)]
Add post upload hook to substitute hashtags for their mapped text

BUG=skia:3586
NOTRY=true

Review URL: https://codereview.chromium.org/1004733009

9 years agoSkPDF: eliminate skpdfpage class
halcanary [Wed, 25 Mar 2015 19:45:28 +0000 (12:45 -0700)]
SkPDF: eliminate skpdfpage class

BUG=skia:3585

Review URL: https://codereview.chromium.org/1007083004

9 years agoFix android_run_skia script to allow for larger blacklist
msarett [Wed, 25 Mar 2015 19:28:33 +0000 (12:28 -0700)]
Fix android_run_skia script to allow for larger blacklist

BUG=skia:

Review URL: https://codereview.chromium.org/1011653004

9 years agoSkPDF: merge skdocument_pdf and skpdfdocument
halcanary [Wed, 25 Mar 2015 19:15:04 +0000 (12:15 -0700)]
SkPDF: merge skdocument_pdf and skpdfdocument

BUG=skia:3585

Review URL: https://codereview.chromium.org/1034793002

9 years agoSKPDF: refactor pdfcatalog and pdfdocument
halcanary [Wed, 25 Mar 2015 18:29:18 +0000 (11:29 -0700)]
SKPDF:  refactor pdfcatalog and pdfdocument

SkPDFCatalog:
-   remove first-page-specific code (no longer needed, never
    used) (e.g. addObject()).
-   Make use of SkHashMap for lookups (simplifies code).
-   inline all small methods
-   emitXrefTable moved to SkPDFDocument.cpp
-   no longer store offsets in this data structure (moved to
    SkPDFDocument.cpp)
-   setFileOffset gone.
-   own substitute refs directly.

SkPDFDocument::EmitPDF()
-   All sites that call into SkPDFCatalog modified.
-   catalog.addObject only called in a single place, after the
    resouceSet is built
-   offsets moved to local array.

SkPDFPage:
-   finalizePage no longer deals with SkPDFCatalog or resource sets.
-   GeneratePageTree no longer deals with SkPDFCatalog

SkPDFObjRef
-   emitObject respects the substitution map

Unit Tests:
-   respect SkPDFCatalog::addObject signature change.

SkTHash:
-   #include SkChecksum for SkGoodHash
-   Copyright notice added

Review URL: https://codereview.chromium.org/1033543002

9 years agoAdd scanline decoding to SkCodec.
scroggo [Wed, 25 Mar 2015 18:11:52 +0000 (11:11 -0700)]
Add scanline decoding to SkCodec.

Add an interface for decoding scanlines, and implement that interface
in the PNG decoder.

Use a separate method to determine whether an image that used a type
with alpha was actually opaque.

SkScanlineDecoder.h:
New interface for decoding scanlines.

SkCodec.h:
Add getScanlineDecoder.
Add a virtual function (with non-virtual caller) for determining
whether the image truly had alpha. The client can call this to
determine if the image was actually opaque if it reported having alpha.
Remove code to sneakily change the passed in alpha type.

SkCodec_libpng.*:
Split up code onGetPixels into helper functions that can be shared with
the scanline decoder.
Implement scanline decoding.
Implement onReallyHasAlpha.

SkSwizzler.*:
Add a new SrcConfig as a default, which is invalid.
Add a function for setting fDstRow directly.
Assert fDstRow is not NULL.

BUG=skia:3257

Review URL: https://codereview.chromium.org/1010903003

9 years agoSkTHash: add checksum include
halcanary [Wed, 25 Mar 2015 17:22:53 +0000 (10:22 -0700)]
SkTHash: add checksum include

Review URL: https://codereview.chromium.org/1030883006

9 years agoAdd copyright headers to remaining gyp files.
scroggo [Wed, 25 Mar 2015 17:22:41 +0000 (10:22 -0700)]
Add copyright headers to remaining gyp files.

Prevents some PRESUBMIT errors.

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1035523003

9 years agoRemove SkClipStack's manual rounding of BW clip rects
robertphillips [Wed, 25 Mar 2015 16:11:30 +0000 (09:11 -0700)]
Remove SkClipStack's manual rounding of BW clip rects

The full fix for this bug is nudging the image in device space. That is going to be a large change. This CL should address the immediate problem.

This CL will alter the following GMs:
clipdrawdraw
convex_poly_clip
complexclip_bw_*
filltypespersp
complexclip3_simple

BUG=423834

Review URL: https://codereview.chromium.org/1033453003

9 years agoSkPDF: skpdfdocument and skpdfpage use skpdfdevice in a const way
halcanary [Wed, 25 Mar 2015 15:45:42 +0000 (08:45 -0700)]
SkPDF: skpdfdocument and skpdfpage use skpdfdevice in a const way

BUG=skia:3585

Review URL: https://codereview.chromium.org/1035513003

9 years agoSkPDF: add canon assert before adding code that might break it
halcanary [Wed, 25 Mar 2015 15:38:03 +0000 (08:38 -0700)]
SkPDF: add canon assert before adding code that might break it

Motivation: We can write subsets (by page) of pdf documents (but this
in't yet exposed in the public API), but it is a bad idea to mix pages
from multiple documents (de-duping will break).  This assert verifies
that we don't do this by accident in the future.

BUG=skia:3585

Review URL: https://codereview.chromium.org/1037573005

9 years agoSkPDF: unclass skpdfdocument
halcanary [Wed, 25 Mar 2015 14:52:56 +0000 (07:52 -0700)]
SkPDF: unclass skpdfdocument

BUG=skia:3585

Review URL: https://codereview.chromium.org/1030193002

9 years agoMore file types to check for (C).
mtklein [Wed, 25 Mar 2015 14:21:20 +0000 (07:21 -0700)]
More file types to check for (C).
 - objective C++           (31)
 - objective C             (4)
 - C                       (2)
 - alternate C++ extension (1)
 - Go                      (1)

BUG=skia:

Review URL: https://codereview.chromium.org/1032143002

9 years agoFix for ClipMaskManager drawSimpleRect
joshualitt [Wed, 25 Mar 2015 14:16:21 +0000 (07:16 -0700)]
Fix for ClipMaskManager drawSimpleRect

BUG=chromium:466819

Review URL: https://codereview.chromium.org/1031143002

9 years agoAdd copyright to gyp/codec.gyp.
scroggo [Wed, 25 Mar 2015 14:16:13 +0000 (07:16 -0700)]
Add copyright to gyp/codec.gyp.

Review URL: https://codereview.chromium.org/1023673010

9 years agoSkPDF: clean up skpdfdocument, add static functions
halcanary [Wed, 25 Mar 2015 14:11:08 +0000 (07:11 -0700)]
SkPDF: clean up skpdfdocument, add static functions

Add SkPDFDocument::EmitPDF and SkPDFDocument::GetCountOfFontTypes

Also, make SkPDFDocument::appendPage return void, not bool.

Motivation: These static functions can be used to print subsets of a
pdf document (functionality to be added in a later CL).

BUG=skia:3585

Review URL: https://codereview.chromium.org/1036853002

9 years agoAdd copyright headers DM.
scroggo [Wed, 25 Mar 2015 14:11:02 +0000 (07:11 -0700)]
Add copyright headers DM.

Review URL: https://codereview.chromium.org/1037713003

9 years agoFixing memory leak in ico decoder
msarett [Wed, 25 Mar 2015 13:29:18 +0000 (06:29 -0700)]
Fixing memory leak in ico decoder

BUG=skia:

NOTREECHECKS=true
TBR=scroggo@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/1036873002

9 years agoEnabling ico decoding with use of png and bmp decoders
msarett [Wed, 25 Mar 2015 12:27:48 +0000 (05:27 -0700)]
Enabling ico decoding with use of png and bmp decoders

BUG=skia:3257

NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1011343003

9 years agoSkPDF refactor skpdfdocument
halcanary [Wed, 25 Mar 2015 12:06:30 +0000 (05:06 -0700)]
SkPDF refactor skpdfdocument

Most fields removed, made local to emitPDF function (since we never
emit twice).

Variables made into stack variables or auto-unrefed.

we hold devices, not pages.

addResourcesToCatalog inlined

unused setPage function removed.

deprecated getCountOfFontTypes function removed

private functions removed

BUG=skia:3585

Review URL: https://codereview.chromium.org/1034583002

9 years agoAdd copyright check to PRESUBMIT
borenet [Wed, 25 Mar 2015 11:47:02 +0000 (04:47 -0700)]
Add copyright check to PRESUBMIT

BUG=skia:1724

Review URL: https://codereview.chromium.org/1003363005

9 years agoSkChopCubicAt2 using Sk2s -- 2x faster
reed [Wed, 25 Mar 2015 02:24:34 +0000 (19:24 -0700)]
SkChopCubicAt2 using Sk2s -- 2x faster

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1036753002

9 years agoSkPDF: unit test cleanup
halcanary [Tue, 24 Mar 2015 22:29:39 +0000 (15:29 -0700)]
SkPDF: unit test cleanup

BUG=skia:3585

Review URL: https://codereview.chromium.org/1033833002

9 years agoRevert of pathops version two (patchset #16 id:150001 of https://codereview.chromium...
reed [Tue, 24 Mar 2015 20:55:33 +0000 (13:55 -0700)]
Revert of pathops version two (patchset #16 id:150001 of https://codereview.chromium.org/1002693002/)

Reason for revert:
ASAN investigation

Original issue's description:
> pathops version two
>
> R=reed@google.com
>
> marked 'no commit' to attempt to get trybots to run
>
> TBR=reed@google.com
>
> Committed: https://skia.googlesource.com/skia/+/ccec0f958ffc71a9986d236bc2eb335cb2111119

TBR=caryclark@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1029993002

9 years agoRevert of remove obsolete tests (patchset #1 id:1 of https://codereview.chromium...
caryclark [Tue, 24 Mar 2015 20:52:49 +0000 (13:52 -0700)]
Revert of remove obsolete tests (patchset #1 id:1 of https://codereview.chromium.org/1030883002/)

Reason for revert:
working on asan fix

Original issue's description:
> remove obsolete tests
>
> remove tests that are breaking the build -- uninitialized memory
>
> TBR=reed
>
> Committed: https://skia.googlesource.com/skia/+/e02c944e97ad6a3b8befb1f4f784919767941ba6

TBR=reed@android.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1036633002

9 years agoRevert of fix destructor order to fix build (patchset #1 id:1 of https://codereview...
caryclark [Tue, 24 Mar 2015 20:47:57 +0000 (13:47 -0700)]
Revert of fix destructor order to fix build (patchset #1 id:1 of https://codereview.chromium.org/1033703002/)

Reason for revert:
working on asan fix

Original issue's description:
> fix destructor order to fix build
>
> TBR=reed
>
> Committed: https://skia.googlesource.com/skia/+/c207f9b2e8d6fb5386197fa8a8d258d2c4603418

TBR=reed@android.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1033803002

9 years agoRevert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id...
tomhudson [Tue, 24 Mar 2015 20:47:41 +0000 (13:47 -0700)]
Revert of Enabling ico decoding with use of png and bmp decoders (patchset #10 id:280001 of https://codereview.chromium.org/1011343003/)

Reason for revert:
Reverting on suspicion of massive bot failures - possible command line too long?

Original issue's description:
> Enabling ico decoding with use of png and bmp decoders
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/15bfd075d38e4422a477e22940d06a137f66cc97

TBR=scroggo@google.com,reed@google.com,djsollen@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257

Review URL: https://codereview.chromium.org/1022843005

9 years agoSwitch DM to use utils/android/SkAndroidSDKCanvas
tomhudson [Tue, 24 Mar 2015 19:46:40 +0000 (12:46 -0700)]
Switch DM to use utils/android/SkAndroidSDKCanvas

Use (better) paint filter shared with nanobench, instead
of custom implementation.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/1036523002

9 years agoEnabling ico decoding with use of png and bmp decoders
msarett [Tue, 24 Mar 2015 19:24:27 +0000 (12:24 -0700)]
Enabling ico decoding with use of png and bmp decoders

BUG=skia:3257

Review URL: https://codereview.chromium.org/1011343003

9 years agoFix assert in debugger
robertphillips [Tue, 24 Mar 2015 18:09:07 +0000 (11:09 -0700)]
Fix assert in debugger

Review URL: https://codereview.chromium.org/1029903002

9 years agoIncrease timeout of ukwsj to get more consistent SKP captures
rmistry [Tue, 24 Mar 2015 17:58:37 +0000 (10:58 -0700)]
Increase timeout of ukwsj to get more consistent SKP captures

BUG=skia:3574
TBR=borenet
NOTRY=true

Review URL: https://codereview.chromium.org/1038443002

9 years agoSkPDF: Fix leak in SkPDFShader
halcanary [Tue, 24 Mar 2015 17:21:34 +0000 (10:21 -0700)]
SkPDF: Fix leak in SkPDFShader

TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1006813010

9 years agoenable color-matrix-floats again, watching arm64 bots
reed [Tue, 24 Mar 2015 17:04:38 +0000 (10:04 -0700)]
enable color-matrix-floats again, watching arm64 bots

BUG=skia:
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/1035493002

9 years agoGo back to storeAligned / LoadAligned for SkPMFloat <->Sk4f.
mtklein [Tue, 24 Mar 2015 16:47:11 +0000 (09:47 -0700)]
Go back to storeAligned / LoadAligned for SkPMFloat <->Sk4f.

This seems to fix the miscompilation bug on ARM64 / Release / GCC 4.9.

We switched this over originally for perf issues with NEON, but I can't see any now.  Will keep an eye out.

BUG=skia:3570

Review URL: https://codereview.chromium.org/1026403002

9 years agofix destructor order to fix build
caryclark [Tue, 24 Mar 2015 16:16:25 +0000 (09:16 -0700)]
fix destructor order to fix build

TBR=reed

Review URL: https://codereview.chromium.org/1033703002

9 years agoremove obsolete tests
caryclark [Tue, 24 Mar 2015 15:17:16 +0000 (08:17 -0700)]
remove obsolete tests

remove tests that are breaking the build -- uninitialized memory

TBR=reed

Review URL: https://codereview.chromium.org/1030883002

9 years agoSkPDF: clean up extra references
halcanary [Tue, 24 Mar 2015 15:12:55 +0000 (08:12 -0700)]
SkPDF:  clean up extra references

This cleans up code left behind from  http://crrev.com/870333002

Review URL: https://codereview.chromium.org/1029263004

9 years agoMove SkMatrixImageFilter.h into src/core.
senorblanco [Tue, 24 Mar 2015 14:51:30 +0000 (07:51 -0700)]
Move SkMatrixImageFilter.h into src/core.

Callers in Blink have been updated to call
SkImageFilter::CreateMatrixFilter() instead.

BUG=skia:3568

Review URL: https://codereview.chromium.org/1013753013

9 years agopathops version two
caryclark [Tue, 24 Mar 2015 14:28:17 +0000 (07:28 -0700)]
pathops version two

R=reed@google.com

marked 'no commit' to attempt to get trybots to run

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1002693002

9 years agoRevert of Revert of remove colorfilter native-565 support. complicating w/ no real...
reed [Tue, 24 Mar 2015 13:35:23 +0000 (06:35 -0700)]
Revert of Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #1 id:1 of https://codereview.chromium.org/1022673007/)

Reason for revert:
fix for chrome has landed...

Original issue's description:
> Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/)
>
> Reason for revert:
> skia/ext/benchmarking_canvas.cc references HasFilter16 :(
>
> Original issue's description:
> > remove colorfilter native-565 support. complicating w/ no real value.
> >
> > BUG=skia:
> > TBR=
> >
> > Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710
>
> TBR=reed@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/92b47c49016749249ff8521e424c4373b4a74241

TBR=reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1016103004

9 years agoaacc + bbdd
mtklein [Tue, 24 Mar 2015 13:16:30 +0000 (06:16 -0700)]
aacc + bbdd

SkMatrix::mapPts() using aacc/bbdd was always worse than using badc():
  - On Intel, it was faster than exisiting swizzle, but badc() is 10% faster still (one pshufd instead of two).
  - On ARM, existing swizzle < badc() < aacc()+bbdd(), even though aacc() then bbdd() is really a single vtrn instruction.

I will revert SkMatrix.cpp before submitting.  Just thought you might like to look.

Will think more and try to gear up Instruments on ARM.

BUG=skia:

Review URL: https://codereview.chromium.org/1012573003

9 years agoRevert of remove colorfilter native-565 support. complicating w/ no real value. ...
reed [Tue, 24 Mar 2015 12:18:09 +0000 (05:18 -0700)]
Revert of remove colorfilter native-565 support. complicating w/ no real value. (patchset #2 id:20001 of https://codereview.chromium.org/1015533011/)

Reason for revert:
skia/ext/benchmarking_canvas.cc references HasFilter16 :(

Original issue's description:
> remove colorfilter native-565 support. complicating w/ no real value.
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/2151353d161fe389cdc0db62cfe1932c7680f710

TBR=reed@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1022673007

9 years agoRevert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codere...
reed [Tue, 24 Mar 2015 11:13:45 +0000 (04:13 -0700)]
Revert "Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.org/967943002/)"

disabled for the momment -- need to understand arm64 glitches

This reverts commit 374a4c3b744e8c77455efa73b139950136f7b374.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1028403002

9 years agoremove colorfilter native-565 support. complicating w/ no real value.
reed [Tue, 24 Mar 2015 10:50:22 +0000 (03:50 -0700)]
remove colorfilter native-565 support. complicating w/ no real value.

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1015533011

9 years agoRevert of correct reporting of kAlphaUnchanged_Flag in ModeFilter (patchset #1 id...
reed [Tue, 24 Mar 2015 10:48:27 +0000 (03:48 -0700)]
Revert of correct reporting of kAlphaUnchanged_Flag in ModeFilter (patchset #1 id:1 of https://codereview.chromium.org/1033583002/)

Reason for revert:
reverting experiment. need to rebaseilne layouttest

svg/css/text-gradient-shadow.svg

Original issue's description:
> correct reporting of kAlphaUnchanged_Flag in ModeFilter
>
> BUG=skia:
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/afced66b508ac4cd3616e2f707db27b7d6f670e1

TBR=
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1026313002

9 years agocorrect reporting of kAlphaUnchanged_Flag in ModeFilter
reed [Tue, 24 Mar 2015 03:05:04 +0000 (20:05 -0700)]
correct reporting of kAlphaUnchanged_Flag in ModeFilter

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1033583002

9 years agoRevert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview...
reed [Tue, 24 Mar 2015 01:52:57 +0000 (18:52 -0700)]
Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.org/967943002/)

Reason for revert:
Arm64 seems to be having glitches :(

See gm:colormatrix on Arm64/TegraK1/Nexus9

last square should be all white, but it has stripes

Original issue's description:
> impl colormatrix w/ floats
>
> this needs to land first https://codereview.chromium.org/1031713003
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/7971def11be91ed08eae7107b372322d24e67544

TBR=mtklein@google.com,caryclark@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1030743003

9 years agoimpl colormatrix w/ floats
reed [Mon, 23 Mar 2015 21:35:25 +0000 (14:35 -0700)]
impl colormatrix w/ floats

this needs to land first https://codereview.chromium.org/1031713003

BUG=skia:

Review URL: https://codereview.chromium.org/967943002

9 years agoStart fresh on swizzles
mtklein [Mon, 23 Mar 2015 20:19:03 +0000 (13:19 -0700)]
Start fresh on swizzles

This removes all the existing Sk4x swizzles and adds badc(), which is
both fast on all implementations and currently useful.

BUG=skia:

Review URL: https://codereview.chromium.org/997353005

9 years agoBoth DM and nanobench need this, so moving the duplicated code to
tomhudson [Mon, 23 Mar 2015 19:51:20 +0000 (12:51 -0700)]
Both DM and nanobench need this, so moving the duplicated code to
one common spot. (It's incomplete, and has had bugs, so it's not
like we can confidently write once, copy-paste, and not maintain
again.)

Because SkPathEffect::exposedInAndroidJavaAPI() only builds in the
Android Framework, we might want to make all this code Framework-only?

R=djsollen@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/1021823003

9 years agoReplace _mm_cvtps_epi32(x) with _mm_cvttps_epi32(_mm_add_ps(0.5f), x).
mtklein [Mon, 23 Mar 2015 19:01:45 +0000 (12:01 -0700)]
Replace _mm_cvtps_epi32(x) with _mm_cvttps_epi32(_mm_add_ps(0.5f), x).

We don't have control over which way _mm_cvtps_epi32 rounds.

  - This makes the SSE SkPMFloat rounding consistent with _neon and _none.
  - Sk4f::cast<Sk4i>() is closer to (int)float's behavior.  (Correct when >=0).

Add tests that would fail at head.

BUG=skia:

Review URL: https://codereview.chromium.org/1029163002

9 years agoAdd font "index" to lmp parser.
bungeman [Mon, 23 Mar 2015 16:08:54 +0000 (09:08 -0700)]
Add font "index" to lmp parser.

When ttc index support was added, it was added and tested on Android
with the jb parser. This adds it to the lmp parser.

Review URL: https://codereview.chromium.org/1023313002

9 years agoremove meaningless matrix benches, add mapPts() and add new benches
reed [Mon, 23 Mar 2015 15:15:14 +0000 (08:15 -0700)]
remove meaningless matrix benches, add mapPts() and add new benches

mapPts definitely faster than mapPoints (identity and perspective same speed). Up to 3x for large values of N.

cloned from https://codereview.chromium.org/1031443002/

BUG=skia:

Review URL: https://codereview.chromium.org/1030653002

9 years agoInitial change to move text blob to GrTextContext
joshualitt [Mon, 23 Mar 2015 15:13:04 +0000 (08:13 -0700)]
Initial change to move text blob to GrTextContext

BUG=skia:

Review URL: https://codereview.chromium.org/1019633002

9 years agoGet rid of excess cleverness in benchmark
tomhudson [Mon, 23 Mar 2015 14:46:13 +0000 (07:46 -0700)]
Get rid of excess cleverness in benchmark

RotatedRectBench was asking for its base layer size, which may
not be what it expects with odd canvas modes (particularly proxies).
Most benchmarks are not so sophisticated; they hard-wire their
size and just use that (expected) value.

R=mtklein@google.com,djsollen@google.com
BUG=skia:3566

Review URL: https://codereview.chromium.org/1015013004

9 years agoMake SkCanvas::getBaseLayerSize() virtual
tomhudson [Mon, 23 Mar 2015 14:22:40 +0000 (07:22 -0700)]
Make SkCanvas::getBaseLayerSize() virtual

Subclasses of SkCanvas may need to override the behavior here - for
example, any proxy or deferred canvas may not know its own size and
need to delegate to another object.

We'll also work on reducing use of this function
(https://skbug.com/3569), but some of the current uses seem to be
semantically necessary.

R=reed@google.com
BUG=skia:3566

Review URL: https://codereview.chromium.org/1022423002

9 years agoFix two typos in coding style
kkinnunen [Mon, 23 Mar 2015 13:27:23 +0000 (06:27 -0700)]
Fix two typos in coding style

Fix two typos in coding style:
- Memory Managemt
- if (NULL == x) equated to if (x)
NOTRY=true
DOCS_PREVIEW= https://skia.org/?cl=1032463002

Review URL: https://codereview.chromium.org/1032463002

9 years agoPreserve texture compression when saving a revised skp from debugger
robertphillips [Mon, 23 Mar 2015 12:46:51 +0000 (05:46 -0700)]
Preserve texture compression when saving a revised skp from debugger

Without this CL, saving a revised skp out the debugger can greatly expand the memory it requires.

Review URL: https://codereview.chromium.org/1020103005

9 years agoDo not playback pending commands for full deferred canvas writePixels
kkinnunen [Mon, 23 Mar 2015 09:18:02 +0000 (02:18 -0700)]
Do not playback pending commands for full deferred canvas writePixels

Do not playback pending commands for full deferred canvas writePixels.

Changes the test to catch cases where discard is done without
a snapshot.

Review URL: https://codereview.chromium.org/939103002

9 years agoUpdate SKP version
skia.buildbots [Sun, 22 Mar 2015 08:14:17 +0000 (01:14 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=

Review URL: https://codereview.chromium.org/1030453002

9 years agoremove SK_SUPPORT_LEGACY_ARCTO_QUADS code
reed [Sat, 21 Mar 2015 02:41:10 +0000 (19:41 -0700)]
remove SK_SUPPORT_LEGACY_ARCTO_QUADS code

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1023103004

9 years agochange default impl to facilitate transition in blink/chrome
reed [Fri, 20 Mar 2015 22:25:25 +0000 (15:25 -0700)]
change default impl to facilitate transition in blink/chrome

BUG=skia:
TBR=

need deps roll to see if this works... since skia can no longer build/test in this legacy mode.

Review URL: https://codereview.chromium.org/1026923002

9 years agoremove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code
reed [Fri, 20 Mar 2015 21:20:09 +0000 (14:20 -0700)]
remove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1020403002

9 years agoSome usability ideas around SkTHash.
mtklein [Fri, 20 Mar 2015 20:48:42 +0000 (13:48 -0700)]
Some usability ideas around SkTHash.

  - By default, use new SkGoodHash to hash keys, which is:
    * for 4 byte values, use SkChecksum::Mix,
    * for SkStrings, use SkChecksum::Murmur3 on the data,
    * for other structs, shallow hash the struct with Murmur3.
  - Expand SkChecksum::Murmur3 to support non-4-byte-aligned data.
  - Add const foreach() methods.
  - Have foreach() take a functor, which allows lambdas.

BUG=skia:

Review URL: https://codereview.chromium.org/1021033002

9 years agocleanup using constructors
reed [Fri, 20 Mar 2015 20:46:08 +0000 (13:46 -0700)]
cleanup using constructors

BUG=skia:
TBR=

Review URL: https://codereview.chromium.org/1024193002

9 years agouse Sk2s for conics
reed [Fri, 20 Mar 2015 20:23:43 +0000 (13:23 -0700)]
use Sk2s for conics

BUG=skia:

Review URL: https://codereview.chromium.org/1025033002

9 years agoSk2x::invert() and Sk2x::approxInvert()
mtklein [Fri, 20 Mar 2015 20:17:42 +0000 (13:17 -0700)]
Sk2x::invert() and Sk2x::approxInvert()

BUG=skia:

Review URL: https://codereview.chromium.org/1024993002