Daniel Juyung Seo [Tue, 26 Nov 2013 17:02:41 +0000 (02:02 +0900)]
evas evas_render: removed unnecessary semicolon from a macro.
This fixes coverity CID 1132631.
Daniel Juyung Seo [Tue, 26 Nov 2013 16:52:21 +0000 (01:52 +0900)]
ecore ibus_imcontext: print the value of cursor_pos only when cursor_pos
is not null.
This fixes coverity CID 1132624.
Daniel Juyung Seo [Tue, 26 Nov 2013 16:48:58 +0000 (01:48 +0900)]
ecore scim_imcontext: do not check null for ic. it was already checked
by EINA_SAFETY_ON_NULL_RETURN.
This fixes coverity CID 1132628.
Daniel Juyung Seo [Tue, 26 Nov 2013 16:39:40 +0000 (01:39 +0900)]
emotion emotion_test: free allocated data when the dependent object is
deleted.
This fixes coverity CID 1099709.
Rafael Antognolli [Tue, 26 Nov 2013 16:10:15 +0000 (14:10 -0200)]
ecore_evas/wayland: Update comments inside rotation code.
Rafael Antognolli [Tue, 26 Nov 2013 16:01:35 +0000 (14:01 -0200)]
ecore_evas/wayland: Fix non-resize rotation.
Fix phab T392.
Notice that it should reopen T359, as it wasn't really fixed, but a
rotation with resize was being used when a non-resized rotation was
requested. The cause of the "protruding surfaces" is likely the fact
that Elementary is setting the opaque regions manually, instead of
leaving it to Ecore_Evas. This must be fixed either inside Elementary
itself, or adding the "surface extents" (shadow/non-visible surface
parts) info to Ecore_Evas too.
Rafael Antognolli [Tue, 26 Nov 2013 13:41:54 +0000 (11:41 -0200)]
Revert "evas: allow fuzziness on the texture format returned by GL."
This reverts commit
2b5b3438e82a9a1bb4086864660942d3c1ddc113.
Breaks gl engines when using GLES + EGL.
Tom Hacohen [Tue, 26 Nov 2013 13:08:55 +0000 (13:08 +0000)]
Eo: Fixed eo_manual_free to always return a value.
I wonder how come this wasn't triggered in 64bit and only in 32.
Tom Hacohen [Tue, 26 Nov 2013 12:26:30 +0000 (12:26 +0000)]
Evas tests: Add canvas free with ref tests.
This should check test for the issue fixed in:
bb4a19b5ad6a8fc6720154700aabfa32f4b71244
8bba92fbca7c721a7582b098698404e491f44941
Tom Hacohen [Tue, 26 Nov 2013 12:16:22 +0000 (12:16 +0000)]
Evas object: Set manual_free to false once obj is detached from canvas.
This means unref will really free the object instead of just let it
linger in memory once the object is unrefed.
This is also correct because once detached from the canvas, Evas has
nothing to do with the object and it shouldn't need the manual free
anymore.
Tom Hacohen [Tue, 26 Nov 2013 12:10:53 +0000 (12:10 +0000)]
Eo: Make eo_manual_free() return a success flag.
eo_manual_free() can fail in some cases, and it is useful for users of
this API to know about it in order to decide what to do.
Tom Hacohen [Tue, 26 Nov 2013 11:46:49 +0000 (11:46 +0000)]
Evas layer: Fix deletion of canvas with still-refed objects.
This fixes the infinite loop while deleting canvases with still
referenced objects.
The canvas should not assume it can get rid of all of the objects. Some
objects might be referenced. I also added a printf to let the user know
about it.
This fixes T565.
ChunEon Park [Tue, 26 Nov 2013 11:32:42 +0000 (20:32 +0900)]
evas - fix the memory corruption introduced by evas fonts_zero
Tom Hacohen [Tue, 26 Nov 2013 10:10:24 +0000 (10:10 +0000)]
Eo: Add an error message when old parent is wrong.
This is an addition to raster's fix in
55d8156414012e718a7e7adb3f9cd33e19744dc1
(eo - base class protection against NULL old_parent_pd)
Daniel Juyung Seo [Tue, 26 Nov 2013 08:10:14 +0000 (17:10 +0900)]
ChangeLog: fixed formatting of Cedric's last changelog.
Daniel Juyung Seo [Tue, 26 Nov 2013 06:58:24 +0000 (15:58 +0900)]
Ecore animator: delete animater's internal timer in _end_tick() in all cases.
When the ecore_animator_source_set() is called with different sources repeatedly, sometimes internal timer is not deleted and this leads animator misbehavior.
Especially when the source is changed from ECORE_ANIMATOR_SOURCE_TIMER to ECORE_ANIMATOR_SOURCE_CUSTOM before the SOURCE_TIMER's internal timer is deleted, this problem occurs.
In this case, even though _end_tick() is called in ecore_animator_source_set(), the SOURCE_TIMER's timer is not deleted because the source is already changed to CUSTOM.
So we should delete the internal timer in _end_tick() in all cases.
Carsten Haitzler (Rasterman) [Tue, 26 Nov 2013 08:01:26 +0000 (17:01 +0900)]
eo - base class protection against NULL old_parent_pd
bug T569 still shows that we have cases where, during e shutdown, we
still get eo_data_scope_get() return NULL for a parent object.
whatever this is, segfaulting is much worse than protecting and
marching on. so protect
Cedric Bail [Tue, 26 Nov 2013 08:00:24 +0000 (17:00 +0900)]
evas: allow fuzziness on the texture format returned by GL.
ChunEon Park [Tue, 26 Nov 2013 04:05:05 +0000 (13:05 +0900)]
evas - stop over redraw of map content with smart object.
clip object would always stay in a changed state. nobody was walking them to reset.
Now we do reset there state as soon as we do render them.
Jihoon Kim [Mon, 25 Nov 2013 23:48:21 +0000 (08:48 +0900)]
fix clang warning in _edje_entry_focus_in_cb
Tom Hacohen [Mon, 25 Nov 2013 15:45:01 +0000 (15:45 +0000)]
Ecore con dns test: Fix test hangs.
This should fix the test hangs on Jenkins. Fixed them for me.
The problem was, that the timeout was not handled correctly.
The server object was deleted, but the mainloop was not stopped.
Tom Hacohen [Mon, 25 Nov 2013 14:39:14 +0000 (14:39 +0000)]
Evas textblock: Fixed wrapping of lines ending with whites.
Whites at the end of lines ending with whites should not be cut, but
should be wrapped (there's no legal line break there).
Thanks to Shilpa Singh for reporting.
Tom Hacohen [Mon, 25 Nov 2013 14:38:05 +0000 (14:38 +0000)]
Evas textblock: Added a test for wraps ending with whites.
This tests for word wraps of lines ending with whites.
Those whites should not be cut, they should be wrapped as well.
Carsten Haitzler (Rasterman) [Mon, 25 Nov 2013 13:29:12 +0000 (22:29 +0900)]
evas - gl engine - async texture upload - protect null tex handle access
this stops a very blantant segv when accessing async->tex when it is
NULL on _evas_gl_preload_main_loop_wakeup().
Ryuan Choi [Mon, 25 Nov 2013 10:21:52 +0000 (19:21 +0900)]
ecore_file: Print more informative message when inotify_add_watch was failed.
inotify_add_watch can be failed because of several reasons.
Chris Michael [Mon, 25 Nov 2013 07:47:52 +0000 (07:47 +0000)]
Fix keyrepeat going crazy ;)
Previously, if you were hold down shift for 1-2 seconds and then press
a key, you would get superfluous key repeats (even tho you released
the printable key). This was because the "key repeat" code was not
checking for the same key before (re)starting the repeat timer.
This fixes the repeating key issue by checking if the key pressed is
different than the one already pressed. If so, it will (re)start the
timer. If it is not different, then the timer is already running and
we don't need to do anything.
Fixes T552
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 25 Nov 2013 07:35:13 +0000 (07:35 +0000)]
Fix ecore wayland key events to fill in Ecore_Event_Key with X11-like
values.
Previously, the keyname and key fields of the Ecore_Event_Key
structure were being filled in with the capitalized version of the
key. This is due to xkb_keysym_get_name always returning keys with the
modifier applied. There is no actual function in xkbcommon to Not do
this :/ so we have to manually check if Shift is pressed, and if so
then we need to convert the key to lowercase.
Fixes T550
Signed-off-by: Chris Michael <cp.michael@samsung.com>
ChunEon Park [Mon, 25 Nov 2013 07:05:12 +0000 (16:05 +0900)]
evas - code refactoring.
merge duplicated(almost) functions to one.
Carsten Haitzler (Rasterman) [Mon, 25 Nov 2013 05:51:25 +0000 (14:51 +0900)]
1.8.0-beta1
ChunEon Park [Mon, 25 Nov 2013 01:42:16 +0000 (10:42 +0900)]
efl - fixed ugly indentation.
ChunEon Park [Mon, 25 Nov 2013 01:09:34 +0000 (10:09 +0900)]
evas - fix proxy render to update the proxies recursively.
If a proxy has proxies, all the chained proxies should be updated recursively.
Carsten Haitzler (Rasterman) [Sun, 24 Nov 2013 10:14:28 +0000 (19:14 +0900)]
fix smart sma by allowing more recursion
this ups the recursion allowance to 4096. it solves T494
Carsten Haitzler (Rasterman) [Sun, 24 Nov 2013 02:48:40 +0000 (11:48 +0900)]
evas - update extension/module loader list to match generic loaders list
Carsten Haitzler (Rasterman) [Sat, 23 Nov 2013 14:30:27 +0000 (23:30 +0900)]
ecore-evas - examples - simply broken example - fix
this fixes T558 - it was just a broken example
Carsten Haitzler (Rasterman) [Sat, 23 Nov 2013 14:07:54 +0000 (23:07 +0900)]
evas - examples - fix broken evas stacking example
this fixes a broken example that assumes getting name always succeeds.
this fixes T559
U. Artie Eoff [Fri, 22 Nov 2013 23:07:14 +0000 (15:07 -0800)]
evas/examples: fix clipper colors in evas-object-manipulation
This makes the clipper colors correct and also gets rid of the
following error message spam:
ERR..._color_set() Evas only handles pre multiplied colors!
Fixes T557
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
maxerba [Fri, 22 Nov 2013 20:28:37 +0000 (21:28 +0100)]
Adding galician and spanish translations in desktop files
maxerba [Fri, 22 Nov 2013 20:26:49 +0000 (21:26 +0100)]
Adding polish translation
U. Artie Eoff [Fri, 22 Nov 2013 12:39:03 +0000 (04:39 -0800)]
ecore-wayland: test for subsurface protocol in wayland core
The subsurface protocol was moved into Wayland Core
around v1.3.90 (i.e. v1.4.0).
Test if subsurface protocol is part of wayland-client.h.
If not, we include our own copy of the protocol header.
Also, some whitespace cleanup in ecore_wl.c.
Tested with Wayland 1.3.0 and 1.3.90 (master:360dca5).
Fixes T529
Signed-off-by: U. Artie Eoff <ullysses.a.eoff@intel.com>
ChunEon Park [Fri, 22 Nov 2013 05:02:40 +0000 (14:02 +0900)]
edje - fix the side effect introduced by
12aba0db5a0949488d37b69b8696ed424666dca8
Now do recalc parts correctly when edje is moved.
Cedric Bail [Fri, 22 Nov 2013 01:49:48 +0000 (10:49 +0900)]
evas: Let fix the mess in our header instead of sweeping it under the carpet.
This also does fix the build on Windows.
This reverts commit
86c08e6985d5b213c6227d7cb7bc73177aade66e.
Mike Blumenkrantz [Thu, 21 Nov 2013 19:43:49 +0000 (14:43 -0500)]
workaround for T543
this prevents crashing in efm:u2, but is really bad and needs to be fixed more competently before release
Tom Hacohen [Thu, 21 Nov 2013 14:16:30 +0000 (14:16 +0000)]
Evas textblock: Improved debug helper functions.
Carsten Haitzler (Rasterman) [Thu, 21 Nov 2013 11:53:28 +0000 (20:53 +0900)]
evas - map fast path for rectangular objects had color mul wrong
this fixes the color multiplication logic in the fast path to be
correct.
Sebastian Dransfeld [Thu, 21 Nov 2013 11:24:41 +0000 (12:24 +0100)]
efreet: Check for missing icon cache file
Fixes T196
Tom Hacohen [Thu, 21 Nov 2013 10:55:37 +0000 (10:55 +0000)]
Revert "evas: this headers order are seriously insane..."
Perhaps they are insane, but as the comments imply it defines
USE_HARFBUZZ which is needed afterwards. You just broke everything. I
know it's a mess there, but it's a mess that works. Your change doesn't.
This reverts commit
d4b9e3b287d01fe12462fba872db18de0f7a407a.
Sebastian Dransfeld [Thu, 21 Nov 2013 09:45:27 +0000 (10:45 +0100)]
ecore_evas: No error if window creation fails
It is common that some types of ee's will fail as the underlying system
does not support it, just warn.
Sebastian Dransfeld [Thu, 21 Nov 2013 09:43:17 +0000 (10:43 +0100)]
evas: No error if blacklisted, just warn
Cedric Bail [Thu, 21 Nov 2013 09:24:16 +0000 (18:24 +0900)]
evas: this headers order are seriously insane, hope that one fix the last breakage.
Sebastian Dransfeld [Thu, 21 Nov 2013 08:27:28 +0000 (09:27 +0100)]
efreet: Only lock once for efficiency
Sebastian Dransfeld [Thu, 21 Nov 2013 08:26:31 +0000 (09:26 +0100)]
efreet: TODO++
Sebastian Dransfeld [Wed, 20 Nov 2013 12:20:03 +0000 (13:20 +0100)]
efreet: store volatile value locally before return
Cedric Bail [Thu, 21 Nov 2013 07:08:55 +0000 (16:08 +0900)]
evas: fixing headers order for windows build is insane.
Cedric Bail [Thu, 21 Nov 2013 06:33:21 +0000 (15:33 +0900)]
evas: sorry for the last broken commit.
Cedric Bail [Thu, 21 Nov 2013 06:18:42 +0000 (15:18 +0900)]
evas: header order are important.
First system, then EFL public, then EFL internal. If not, you break windows
build.
Cedric Bail [Thu, 21 Nov 2013 05:48:50 +0000 (14:48 +0900)]
evas: actually include the header.
Cedric Bail [Thu, 21 Nov 2013 05:46:59 +0000 (14:46 +0900)]
eina: fix the crash seen by some during rebuild.
Before this patch, we were unconditionnaly destroying the Eina_File if that one
did change on disk. We also make sure that we remove the right entry from the cache
if the file did change there.
ChunEon Park [Thu, 21 Nov 2013 04:50:19 +0000 (13:50 +0900)]
edje - actually we don't need extra variable.
ChunEon Park [Thu, 21 Nov 2013 04:26:37 +0000 (13:26 +0900)]
edje - Fix to update map enabled part when edje object is moved.
ChunEon Park [Thu, 21 Nov 2013 04:12:34 +0000 (13:12 +0900)]
edje - cleaning the code.
keep our code convention.
ChunEon Park [Thu, 21 Nov 2013 04:00:55 +0000 (13:00 +0900)]
edje - use Eina_Bool.
Cedric Bail [Thu, 21 Nov 2013 01:47:27 +0000 (10:47 +0900)]
evas: reduce numbers of call to eet_init/eet_shutdown.
ChunEon Park [Thu, 21 Nov 2013 01:25:35 +0000 (10:25 +0900)]
edje - more elaborated compare to reduce compare count.
Tom Hacohen [Wed, 20 Nov 2013 12:16:47 +0000 (12:16 +0000)]
Eo tests: Added a parent_set parameter validity test.
Tom Hacohen [Wed, 20 Nov 2013 11:53:45 +0000 (11:53 +0000)]
Eo: Check parent is valid in eo_parent_set.
This is an extension to raster's
0355a6a296d8c4a22bf2a2e844a0ba0d4e0abd2e
(eo - fix _parent_set in base clase when old_parent_pd is NULL).
I also added an error message in case this check fails.
Carsten Haitzler (Rasterman) [Wed, 20 Nov 2013 11:20:26 +0000 (20:20 +0900)]
eo - fix _parent_set in base clase when old_parent_pd is NULL
this should fix T538
Cedric Bail [Wed, 20 Nov 2013 11:06:50 +0000 (20:06 +0900)]
eina: cleanup file destruction and reintroduce EINA_MAGIC use.
Cedric Bail [Wed, 20 Nov 2013 11:04:58 +0000 (20:04 +0900)]
edje: fix use of eina_hash_pointer_new to actually look at the right value.
ChunEon Park [Wed, 20 Nov 2013 09:52:12 +0000 (18:52 +0900)]
edje - removed unused function.
Jérémy Zurcher [Wed, 20 Nov 2013 09:19:16 +0000 (10:19 +0100)]
eina: fix a possible race condition during eina_file_close.
replay 7e8fb93 without the breakage
Jérémy Zurcher [Wed, 20 Nov 2013 09:11:21 +0000 (10:11 +0100)]
Revert "eina: fix a possible race condition during eina_file_close."
it breaks everything
This reverts commit
7e8fb93206ee95945bb757267832537c13ab4287.
Carsten Haitzler (Rasterman) [Wed, 20 Nov 2013 09:06:10 +0000 (18:06 +0900)]
evas - table - protect against invalid cell/row values (16bit overflow)
Cedric Bail [Wed, 20 Nov 2013 04:02:37 +0000 (13:02 +0900)]
eina: fix a possible race condition during eina_file_close.
The lock on the main hash was taken to late (after we took the decision
to remove the targeted Eina_File from the cache), this means it was possible
to get an Eina_File from the cache that was going to be removed. This patch
attempt to fix that potential race condition.
Hopefully should fix T461.
Carsten Haitzler (Rasterman) [Tue, 19 Nov 2013 23:41:42 +0000 (08:41 +0900)]
Docs fix for ecore_animator_add fixed
Summary:
Function returns boolean value, docs said it can return int.
I had fixed that.
Reviewers: cedric, raster
Reviewed By: raster
CC: cedric
Differential Revision: https://phab.enlightenment.org/D342
Tom Hacohen [Tue, 19 Nov 2013 16:03:41 +0000 (16:03 +0000)]
Evas textblock: Fixed order of tags inserted with markup_app/prepend.
The order was messed up when inserting a few formats in the
markup_append/prepend functions without any characters between them.
For example, inserting "<b><i>" would result in "<i><b>" being inserted.
Thanks to YoungBok Shin for reporting this.
Tom Hacohen [Tue, 19 Nov 2013 15:36:34 +0000 (15:36 +0000)]
Evas textblock tests: Added tests for correct tag ordering.
Check that tags entered are correctly ordered.
Tom Hacohen [Tue, 19 Nov 2013 15:47:06 +0000 (15:47 +0000)]
Evas textblock tests: Added a complex markup set/get test.
This should make things more robust as thing tests a lot.
Ryuan Choi [Tue, 19 Nov 2013 15:20:58 +0000 (00:20 +0900)]
Add several missing Config.cmake.in
- EldbusConfig.cmake.in
- EthumbClientConfig.cmake.in
- EthumbConfig.cmake.in
Jérémy Zurcher [Tue, 19 Nov 2013 14:58:16 +0000 (15:58 +0100)]
efl.m4: change backslash sequences capability detection
removes ./configure: line 14173: test: =: unary operator expected
Daniel Zaoui [Tue, 19 Nov 2013 14:30:56 +0000 (16:30 +0200)]
Evas Smart: print Eo id instead of pointer to internal data.
Tom Hacohen [Tue, 19 Nov 2013 13:12:56 +0000 (13:12 +0000)]
Tests: fix the print summary for tests with dev profile.
When the dev profile is enabled, tests are also enabled if
libcheck is found. Fix the print in the summary to reflect
that.
Tom Hacohen [Tue, 19 Nov 2013 13:06:24 +0000 (13:06 +0000)]
Revert "configure does not print tests option as a default"
This reverts commit
d93c4b23072d3fe4cd2b2375cf87b424d1a56ba6.
Auto is not an option, and does not mean it'll be automatically
detected.
What auto means is that unless explicitly enabled/disabled it'll check
according to the build profile and will enable it automatically if using
the dev profile.
Chris Michael [Tue, 19 Nov 2013 10:34:27 +0000 (10:34 +0000)]
Add support for storing mulitple touch points.
Send events to properly focused surface.
Fill in missing parts of the event structures (ev->root, ev->multi).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 19 Nov 2013 10:32:51 +0000 (10:32 +0000)]
Add list of touch points to input structure, and a pointer to the
"touch" focused surface.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Tue, 19 Nov 2013 09:38:10 +0000 (09:38 +0000)]
Remove unused variable
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Carsten Haitzler (Rasterman) [Tue, 19 Nov 2013 08:21:58 +0000 (17:21 +0900)]
1.8.0-alpha2
Carsten Haitzler (Rasterman) [Tue, 19 Nov 2013 08:07:49 +0000 (17:07 +0900)]
distcheck - solve missing ecore_evas_drm.h
Stefan Schmidt [Mon, 18 Nov 2013 15:32:23 +0000 (16:32 +0100)]
mailmap: Add two more entries for Mike and Sebastian
Also fix some trailing whitespaces in the same commit. Breaking atomic commits here.
Stefan Schmidt [Mon, 18 Nov 2013 14:35:12 +0000 (15:35 +0100)]
doc: Use correct line break to fix build
Escaping the backslash we want to use for a line break is a really bad idea.
Introduced in
f126afbba21af39c493f21424b653bb5c2e0d58f to support a crippled
echo without new line option.
The linebreak was not detected and thus the first image name used as a target.
Broke our nightly efl build with make distcheck and made me really unhappy to
while searching for the cause.
Chris Michael [Mon, 18 Nov 2013 12:58:54 +0000 (12:58 +0000)]
Don't send pointer_enter events on touch_down.
Fix touch_down and touch_up to send proper button ID (ecore_x sends 0).
Fixes Phab Ticket T468
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 18 Nov 2013 12:52:38 +0000 (12:52 +0000)]
Remove read code.
Fixes Coverity CID1039498
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 18 Nov 2013 12:37:38 +0000 (12:37 +0000)]
ftell can return -1 to indicate error, so trap for that
Fixes Coverity CID1039358
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 18 Nov 2013 11:58:39 +0000 (11:58 +0000)]
ftell can return -1 to indicate error, so trap for that.
Fixes Coverity CID1039356
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 18 Nov 2013 11:48:00 +0000 (11:48 +0000)]
Malloc cannot accept a negative number so check 'num' parameter before
calling malloc.
Fixes Coverity CID1039352
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Cedric Bail [Mon, 18 Nov 2013 09:20:35 +0000 (18:20 +0900)]
evas: those if (re) are useless indeed.
Should fix CID 1129611 and CID 1129612 from this week coverity scan.
Cedric Bail [Mon, 18 Nov 2013 08:57:59 +0000 (17:57 +0900)]
eina: try to handle all possible 64bits pointers environment.
Cedric Bail [Mon, 18 Nov 2013 07:01:27 +0000 (16:01 +0900)]
evas: try to clarify licensing for people that are going to make their own Evas loader.
Chris Michael [Mon, 18 Nov 2013 10:15:54 +0000 (10:15 +0000)]
Remove dead assignments reported by nightly build
cw/cy are never used inside the "dosel" block, so no need to fetch
geometry and calculate difference here (already fetched below when
needed anyway).
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 18 Nov 2013 08:04:07 +0000 (08:04 +0000)]
Partial revert of
eb84475503da9f40d6a79e
Actually, we don't need to free this data here.
Signed-off-by: Chris Michael <cp.michael@samsung.com>
Chris Michael [Mon, 18 Nov 2013 07:56:13 +0000 (07:56 +0000)]
Check for valid drag type before trying to strdup.
When deleting the drag, free any dupped strings.
Hopefully this fixes Phab Ticket T471. Don't know for sure as I cannot
reproduce the crash here :/
Signed-off-by: Chris Michael <cp.michael@samsung.com>