platform/upstream/libSkiaSharp.git
10 years agoFix submit_try
borenet [Thu, 5 Jun 2014 14:32:15 +0000 (07:32 -0700)]
Fix submit_try

BUG=skia:2643
R=epoger@google.com, tfarina@chromium.org

Author: borenet@google.com

Review URL: https://codereview.chromium.org/317823003

10 years agoAdd bench for rectanizers
robertphillips [Thu, 5 Jun 2014 14:18:03 +0000 (07:18 -0700)]
Add bench for rectanizers

R=bsalomon@google.com, jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/319523003

10 years agoChange default generators on windows to include msvs-ninja rather than msvs
bsalomon [Thu, 5 Jun 2014 14:10:21 +0000 (07:10 -0700)]
Change default generators on windows to include msvs-ninja rather than msvs

BUG=skia:2439
R=epoger@google.com
TBR=epoger@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/317903002

10 years agoTwo new benches for ETC1 bitmaps.
krajcevski [Thu, 5 Jun 2014 14:03:39 +0000 (07:03 -0700)]
Two new benches for ETC1 bitmaps.

First bench: Simply render from a compressed ETC1 bitmap. This is roughly
equal between compressed and uncompressed data.

Second bench: Notify the bitmap that the pixels have changed (that's right,
like a liar) to force a re-upload to the GPU. On this bench, decompressed
textures seem to inexplicably do an order of magnitude better than
compressed textures when it should be the other way around, but that
investigation is reserved for a future CL.

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/317023002

10 years agoOn Windows, fail if there are missing files specified in the project.
jvanverth [Wed, 4 Jun 2014 22:57:57 +0000 (15:57 -0700)]
On Windows, fail if there are missing files specified in the project.

BUG=skia:2638
R=robertphillips@google.com, borenet@google.com, rmistry@google.com, epoger@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/319503003

10 years agoRemove SK_IGNORE_DWRITE_BITMAP_FIX.
bungeman [Wed, 4 Jun 2014 22:19:47 +0000 (15:19 -0700)]
Remove SK_IGNORE_DWRITE_BITMAP_FIX.

This define has been removed from Blink and is no longer used anywhere.

R=reed@google.com
TBR=reed1

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/319513006

10 years agoRevert "rebaseline_server: download actual-results.json files from GCS instead of...
epoger [Wed, 4 Jun 2014 22:09:18 +0000 (15:09 -0700)]
Revert "rebaseline_server: download actual-results.json files from GCS instead of SVN"

This reverts commit f4666045f378dee22ce40108e90bf5195634ebfc.

BUG=skia:2641
NOTREECHECKS=True
NOTRY=True
R=jcgregorio@google.com
TBR=jcgregorio

Author: epoger@google.com

Review URL: https://codereview.chromium.org/317783004

10 years agoUpdate expectations for gyp change.
bungeman [Wed, 4 Jun 2014 22:04:10 +0000 (15:04 -0700)]
Update expectations for gyp change.

It appears that with the gyp update, floating point operations
on x86_32 are ever so slightly different when drawing some paths.

R=jvanverth@google.com
TBR=jvanverth@google.com
NOTRY=True

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/315043006

10 years agoRemove Android flag for legacy SkCanvas::drawPicture API
robertphillips [Wed, 4 Jun 2014 18:43:42 +0000 (11:43 -0700)]
Remove Android flag for legacy SkCanvas::drawPicture API

Android should no longer need this flag

R=scroggo@google.com, djsollen@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/316933005

10 years agoRemove SkImageRef and related functionality.
Hal Canary [Wed, 4 Jun 2014 18:38:48 +0000 (14:38 -0400)]
Remove SkImageRef and related functionality.

From here on out, use SkDecodingImageGenerator+SkDiscardablePixelRef.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/100183002

10 years agoUpdate gyp for msvs-ninja.
bungeman [Wed, 4 Jun 2014 18:35:03 +0000 (11:35 -0700)]
Update gyp for msvs-ninja.

BUG=skia:2439
R=borenet@google.com, epoger@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/311213002

10 years agoAdd utils gypi file
egdaniel [Wed, 4 Jun 2014 17:37:06 +0000 (10:37 -0700)]
Add utils gypi file

BUG=skia:
R=bsalomon@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/317733003

10 years agoRelocate SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE
fmalita [Wed, 4 Jun 2014 17:27:36 +0000 (10:27 -0700)]
Relocate SK_IGNORE_CORRECT_HIGH_QUALITY_IMAGE_SCALE

Temporarily move the flag into Chromium's repo, to facilitate
atomic remove-and-suppress-failures changes.

BUG=380686
R=humper@google.com
TBR=humper@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/319533002

10 years agorebaseline_server: download actual-results.json files from GCS instead of SVN
epoger [Wed, 4 Jun 2014 17:02:58 +0000 (10:02 -0700)]
rebaseline_server: download actual-results.json files from GCS instead of SVN

BUG=skia:553
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/310093003

10 years agoRevert of Move Dashing filterPath to a dashing utils file (https://codereview.chromiu...
egdaniel [Wed, 4 Jun 2014 16:59:08 +0000 (09:59 -0700)]
Revert of Move Dashing filterPath to a dashing utils file (https://codereview.chromium.org/314623004/)

Reason for revert:
Need to create utils.gypi file and update chrome

Original issue's description:
> Move Dashing filterPath to a dashing utils file
>
> From inside GrContext, we have a need to create an SkPath an original path and
> some dashing info. We do not have access to the original path effect so we need
> a way to make the FilterPath function accessible outside of the effect. So I moved
> the core filterPath code (and all need helper functions) out of SkDashPathEffect
> and created a SkDashPath in utils to store these helper functions.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/576dcdc793a762ec63fbecdbfd5768066b548fe5

R=bsalomon@google.com, reed@google.com, rmistry@google.com
TBR=bsalomon@google.com, reed@google.com, rmistry@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/317663003

10 years agoAdd non power of two gm for ETC1 bitmap
krajcevski [Wed, 4 Jun 2014 16:57:47 +0000 (09:57 -0700)]
Add non power of two gm for ETC1 bitmap

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/316813005

10 years agoUse tests tag for Skia tools on Android.
scroggo [Wed, 4 Jun 2014 15:25:50 +0000 (08:25 -0700)]
Use tests tag for Skia tools on Android.

When generating the makefiles for Skia testing tools on Android,
use the tag 'tests' and do not use the tags 'optional' or 'eng'.

R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/315013003

10 years agoUse Identity matrix for SkTransparentShader.
scroggo [Wed, 4 Jun 2014 15:21:01 +0000 (08:21 -0700)]
Use Identity matrix for SkTransparentShader.

The SkTransparentShader is just a placeholder that should not
actually be used, so its CTM is not meaningful. However, it needs
to be invertible in order to not assert in SkShader::Context's
constructor. So use SkMatrix::I().

This fixes a CTS test on Android.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/315743003

10 years agoIs this SkDebug important? It drives me nuts.
mtklein [Wed, 4 Jun 2014 15:20:41 +0000 (08:20 -0700)]
Is this SkDebug important?  It drives me nuts.

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/310113006

10 years agoWhitespace change to test bugdroid
Ravi Mistry [Wed, 4 Jun 2014 15:18:54 +0000 (11:18 -0400)]
Whitespace change to test bugdroid

(SkipBuildbotRuns)

BUG=skia:2139
BUG=chromium:380617

10 years agoMove Dashing filterPath to a dashing utils file
egdaniel [Wed, 4 Jun 2014 15:15:53 +0000 (08:15 -0700)]
Move Dashing filterPath to a dashing utils file

From inside GrContext, we have a need to create an SkPath an original path and
some dashing info. We do not have access to the original path effect so we need
a way to make the FilterPath function accessible outside of the effect. So I moved
the core filterPath code (and all need helper functions) out of SkDashPathEffect
and created a SkDashPath in utils to store these helper functions.

BUG=skia:
R=bsalomon@google.com, reed@google.com, rmistry@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/314623004

10 years agoAdd bench to measure drawing a dashed grid
egdaniel [Wed, 4 Jun 2014 15:15:31 +0000 (08:15 -0700)]
Add bench to measure drawing a dashed grid

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/310083005

10 years agoAlter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)
robertphillips [Wed, 4 Jun 2014 12:40:44 +0000 (05:40 -0700)]
Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613004

10 years agoWhitespace change to test bugdroid
Ravi Mistry [Wed, 4 Jun 2014 11:04:29 +0000 (07:04 -0400)]
Whitespace change to test bugdroid

(SkipBuildbotRuns)

BUG=skia:2139,chromium:380617

10 years agoUpdate SKP version to 17
borenet [Wed, 4 Jun 2014 06:13:07 +0000 (23:13 -0700)]
Update SKP version to 17

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/312043004

10 years agoreadd SK_SUPPORT_LEGACY_SETCONFIG_INFO -- missed a place in a blink test
reed [Tue, 3 Jun 2014 23:51:10 +0000 (16:51 -0700)]
readd SK_SUPPORT_LEGACY_SETCONFIG_INFO -- missed a place in a blink test

R=jvanverth@google.com
TBR=jvanverth
NOTRY=True

Author: reed@google.com

Review URL: https://codereview.chromium.org/316753002

10 years agoDisable PDF in dm for tonight. It's crashy.
mtklein [Tue, 3 Jun 2014 22:59:23 +0000 (15:59 -0700)]
Disable PDF in dm for tonight.  It's crashy.

BUG=skia:2598
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/317533003

10 years agoAdded grid data to logging output
kelvinly [Tue, 3 Jun 2014 22:43:34 +0000 (15:43 -0700)]
Added grid data to logging output

BUG=skia:
R=bensong@google.com, jcgregorio@google.com

Author: kelvinly@google.com

Review URL: https://codereview.chromium.org/318433003

10 years agoremove unneeded flags SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_DEVICE_C...
reed [Tue, 3 Jun 2014 22:39:06 +0000 (15:39 -0700)]
remove unneeded flags SK_SUPPORT_LEGACY_SETCONFIG_INFO and SK_SUPPORT_LEGACY_DEVICE_CONFIG

TBR=scroggo

Author: reed@google.com

Review URL: https://codereview.chromium.org/315733002

10 years agoAndroid: remove -lcutils dependency
mtklein [Tue, 3 Jun 2014 22:38:18 +0000 (15:38 -0700)]
Android: remove -lcutils dependency

I believe we no longer depend on this after we ported our atomics to __sync.

Tested by running android_ninja.

BUG=skia:
R=scroggo@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/318493002

10 years agoDM: add pdf
mtklein [Tue, 3 Jun 2014 20:57:14 +0000 (13:57 -0700)]
DM: add pdf

BUG=skia:2598
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312873002

10 years agoDM: go back to memcmp for BitmapsEqual
mtklein [Tue, 3 Jun 2014 20:56:54 +0000 (13:56 -0700)]
DM: go back to memcmp for BitmapsEqual

Even when autovectorized, using MaxComponentDifference is slower than memcmp.
And debug builds (most runs of DM) will never even be autovectorized.

DM::MaxComponentDifference is the top function on DM profile, and memcmp moves
to ~20th.

BUG=skia:
R=halcanary@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/315743002

10 years agoWhitespace change to test the new cron.chrome bugdroid.
Ravi Mistry [Tue, 3 Jun 2014 20:39:21 +0000 (16:39 -0400)]
Whitespace change to test the new cron.chrome bugdroid.

(SkipBuildbotRuns)
BUG=skia:2139

Review URL: https://codereview.chromium.org/309333003

10 years agoFix neglected cleanup of SkTileGridPicture.h
robertphillips [Tue, 3 Jun 2014 20:34:06 +0000 (13:34 -0700)]
Fix neglected cleanup of SkTileGridPicture.h

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/312803003

10 years agoReturn NULL when building empty LayerRasterizer.
scroggo [Tue, 3 Jun 2014 20:12:51 +0000 (13:12 -0700)]
Return NULL when building empty LayerRasterizer.

In SkLayerRasterizer::snapshotRasterizer() and ::detachRasterizer(),
if no layers have been added, do not attempt to create an
SkLayerRasterizer. Instead, return NULL.

This fixes an error when running tests on Android.

Update dox to state that NULL may be returned.

Add tests.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/313653006

10 years agoInitial KTX file decoder
krajcevski [Tue, 3 Jun 2014 20:04:35 +0000 (13:04 -0700)]
Initial KTX file decoder

R=bsalomon@google.com, robertphillips@google.com, halcanary@google.com, reed@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302333002

10 years agoAdd LICENSE & README.google files to third_party/etc1
robertphillips [Tue, 3 Jun 2014 19:31:09 +0000 (12:31 -0700)]
Add LICENSE & README.google files to third_party/etc1

R=djsollen@google.com, krajcevski@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309343004

10 years agoSK_CPU_ARM --> SK_CPU_ARM32
mtklein [Tue, 3 Jun 2014 19:07:31 +0000 (12:07 -0700)]
SK_CPU_ARM --> SK_CPU_ARM32

That's what it means.  It keeps confusing us as named today.

BUG=skia:
R=djsollen@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/314643004

10 years agomanual bench rebase after 55ada06
jvanverth [Tue, 3 Jun 2014 18:46:30 +0000 (11:46 -0700)]
manual bench rebase after 55ada06

R=robertphillips@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/315683004

10 years agoremove SkBounder -- unused and unloved
reed [Tue, 3 Jun 2014 17:53:59 +0000 (10:53 -0700)]
remove SkBounder -- unused and unloved

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/312553006

10 years agodownload_actuals.py: download JSON files from Google Storage instead of skia-autogen
epoger [Tue, 3 Jun 2014 17:35:28 +0000 (10:35 -0700)]
download_actuals.py: download JSON files from Google Storage instead of skia-autogen

uses google-api-python-client instead of gsutil binary to interact with Google Storage

BUG=skia:553
R=rmistry@google.com, bensong@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/309653005

10 years agoa few rebaseline stragglers from image scaling change
humper [Tue, 3 Jun 2014 17:20:49 +0000 (10:20 -0700)]
a few rebaseline stragglers from image scaling change

BUG=skia:
NOTRY=True
NOTREECHECKS=True
TBR=jvanverth

Author: humper@google.com

Review URL: https://codereview.chromium.org/311853004

10 years agoARM Skia NEON patches - 38 - arm64 8888 blitters
kevin.petit [Tue, 3 Jun 2014 17:08:07 +0000 (10:08 -0700)]
ARM Skia NEON patches - 38 - arm64 8888 blitters

Enable NEON on arm64 for most 8888 blitters

This patch enables NEON optimisation for the Color32, S32_Blend,
S32A_Opaque blitters on arm64.

Here are the perf improvements vs the existing code:

Color32:
========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -2.39% |     23.78% |
+-------+------------+------------+
|     2 |     -5.46% |      8.88% |
+-------+------------+------------+
|     4 |     -4.74% |      4.89% |
+-------+------------+------------+
|     8 |     67.74% |    107.12% |
+-------+------------+------------+
|    16 |     40.03% |    101.20% |
+-------+------------+------------+
|    64 |     11.09% |     98.40% |
+-------+------------+------------+
|   256 |     -2.20% |     74.81% |
+-------+------------+------------+
|  1024 |     -4.28% |     78.90% |
+-------+------------+------------+

S32_Blend:
==========

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |      7.84% |     -6.75% |
+-------+------------+------------+
|     2 |     28.95% |     39.77% |
+-------+------------+------------+
|     4 |      5.80% |      8.26% |
+-------+------------+------------+
|     8 |      1.35% |     33.80% |
+-------+------------+------------+
|    16 |     -2.13% |     41.13% |
+-------+------------+------------+
|    64 |     -4.91% |     42.84% |
+-------+------------+------------+
|   256 |     -6.53% |     48.72% |
+-------+------------+------------+
|  1024 |     -6.65% |     46.66% |
+-------+------------+------------+

S32A_Opaque:
============

+-------+------------+------------+
| count | Cortex-A53 | Cortex-A57 |
+-------+------------+------------+
|     1 |     -7.51% |    -19.06% |
+-------+------------+------------+
|     2 |     -5.02% |    -27.70% |
+-------+------------+------------+
|     4 |     15.38% |    -21.66% |
+-------+------------+------------+
|     8 |     -0.98% |      1.05% |
+-------+------------+------------+
|    16 |     -7.35% |      3.34% |
+-------+------------+------------+
|    64 |     50.53% |     94.63% |
+-------+------------+------------+
|   256 |     71.17% |    164.10% |
+-------+------------+------------+
|  1024 |     79.58% |    197.60% |
+-------+------------+------------+

Signed-off-by: Kevin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/302283003

10 years agoRemove legacy picture recording
robertphillips [Tue, 3 Jun 2014 17:04:47 +0000 (10:04 -0700)]
Remove legacy picture recording

This is unblocked now that Android no longer uses the old interface.

This is just the first step in cleaning this up. Future CLs will constify SkPicture access in SkCanvas and split up the SkPicture/SkPicturePlayback/SkPictureRecord trio.

R=bsalomon@google.com, reed@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/313613002

10 years agoUpdate SKP version to 16
borenet [Tue, 3 Jun 2014 16:38:11 +0000 (09:38 -0700)]
Update SKP version to 16

Automatic commit by the RecreateSKPs bot.

TBR=

Author: borenet@google.com

Review URL: https://codereview.chromium.org/313593002

10 years agoFix etc1 support for SkFiddle.
jcgregorio [Tue, 3 Jun 2014 16:04:44 +0000 (09:04 -0700)]
Fix etc1 support for SkFiddle.

Also update design doc to fix MySQL notation for auto incrementing columns.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/315643002

10 years agoFix memory leak in etc1bitmap GM.
mtklein [Tue, 3 Jun 2014 16:04:33 +0000 (09:04 -0700)]
Fix memory leak in etc1bitmap GM.

We never drop our first ref on fileData. (All our ref counts start at one).
SkAutoTUnref<T> is almost always the right thing to use for refcounted types.

BUG=skia:2635
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/310793003

10 years agoAllow chrome to use old version of installPixels.
scroggo [Tue, 3 Jun 2014 14:57:51 +0000 (07:57 -0700)]
Allow chrome to use old version of installPixels.

R=jvanverth@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/312703003

10 years agoUpdate link to Doxygen.
jcgregorio [Tue, 3 Jun 2014 14:38:35 +0000 (07:38 -0700)]
Update link to Doxygen.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/302543007

10 years agoRebase a few GMs and remove some tests from ignored-tests.txt
Brian Salomon [Tue, 3 Jun 2014 14:01:47 +0000 (10:01 -0400)]
Rebase a few GMs and remove some tests from ignored-tests.txt

Review URL: https://codereview.chromium.org/311813003

10 years agoRemove brackets from gm names.
scroggo [Tue, 3 Jun 2014 13:50:26 +0000 (06:50 -0700)]
Remove brackets from gm names.

BUG=skia:2634
R=epoger@google.com, borenet@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/307373003

10 years agoFall back to using clip effect for outer rect in drawdrrect
bsalomon [Tue, 3 Jun 2014 13:34:58 +0000 (06:34 -0700)]
Fall back to using clip effect for outer rect in drawdrrect

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/310483010

10 years agoWhitespace change to test multiple master support in CQ
rmistry [Tue, 3 Jun 2014 13:30:09 +0000 (06:30 -0700)]
Whitespace change to test multiple master support in CQ

TBR=
BUG=skia:2624

(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/315633002

10 years agoremove unneeded flags
reed [Tue, 3 Jun 2014 12:31:00 +0000 (05:31 -0700)]
remove unneeded flags

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/316463002

10 years agoWhitespace change to test new CQ trybot
rmistry [Tue, 3 Jun 2014 11:31:55 +0000 (04:31 -0700)]
Whitespace change to test new CQ trybot

TBR=
BUG=skia:2203
(SkipBuildbotRuns)

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/311813002

10 years agoRevert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromiu...
mtklein [Tue, 3 Jun 2014 02:34:19 +0000 (19:34 -0700)]
Revert of Try TSAN blacklist for SkGLContextHelper::init. (https://codereview.chromium.org/309823004/)

Reason for revert:
the bot's clang doesn't know -fsanitize-blacklist

Original issue's description:
> Try TSAN blacklist for SkGLContextHelper::init.
>
> Submitting to test this; this particular problem only happens on the bot.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/314543002

10 years agoTry TSAN blacklist for SkGLContextHelper::init.
mtklein [Tue, 3 Jun 2014 02:11:06 +0000 (19:11 -0700)]
Try TSAN blacklist for SkGLContextHelper::init.

Submitting to test this; this particular problem only happens on the bot.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309823004

10 years agoClean up another silly race in benches when run concurrently.
mtklein [Tue, 3 Jun 2014 01:22:12 +0000 (18:22 -0700)]
Clean up another silly race in benches when run concurrently.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/309193003

10 years agoTweak TSAN suppressions.
mtklein [Mon, 2 Jun 2014 23:40:06 +0000 (16:40 -0700)]
Tweak TSAN suppressions.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/312613002

10 years agoremove unneeded inval
reed [Mon, 2 Jun 2014 21:41:24 +0000 (14:41 -0700)]
remove unneeded inval

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/307993012

10 years agoadd makeOffset and makeInset to SkRect
reed [Mon, 2 Jun 2014 21:38:28 +0000 (14:38 -0700)]
add makeOffset and makeInset to SkRect

TBR=bsalomon

precursor for https://codereview.chromium.org/306013010

Author: reed@google.com

Review URL: https://codereview.chromium.org/306893012

10 years agouse most innocuous characters possible within skimage output filenames
epoger [Mon, 2 Jun 2014 21:26:18 +0000 (14:26 -0700)]
use most innocuous characters possible within skimage output filenames

BUG=skia:2634
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/302323003

10 years agoChange #def to be opt-out
krajcevski [Mon, 2 Jun 2014 20:51:34 +0000 (13:51 -0700)]
Change #def to be opt-out

R=jvanverth@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/308143008

10 years agoRevert of stop using brackets within skimage output filenames (https://codereview...
epoger [Mon, 2 Jun 2014 20:46:21 +0000 (13:46 -0700)]
Revert of stop using brackets within skimage output filenames (https://codereview.chromium.org/303263012/)

Reason for revert:
Broke http://108.170.220.120:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Release/builds/2806/steps/UploadSKImageResults/logs/stdio :

[13:38:43.401942] /bin/sh: 1: Syntax error: "(" unexpected
[13:38:43.902632] Command /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/scripts/slave/../../third_party/gsutil/gsutil cp -a private /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Link-HD4000-x86_64-Release/build/skia/out/Release/skimage_out/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png gs://chromium-skia-gm/skimage/output/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png failed with retcode 2, try 1.

Original issue's description:
> stop using brackets within skimage output filenames
>
> BUG=skia:2634
>
> Committed: https://skia.googlesource.com/skia/+/f07892413cd2359549dc187f1d10bc48d7d263ba

R=scroggo@google.com
TBR=scroggo@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2634

Author: epoger@google.com

Review URL: https://codereview.chromium.org/314443002

10 years agoUpdate TSAN suppressions.
mtklein [Mon, 2 Jun 2014 20:46:17 +0000 (13:46 -0700)]
Update TSAN suppressions.

TSAN suppressions need to be on their own line, even free of comments.

Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load.
Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN
has an atomic load that makes the annotation moot.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/be7de4fc4229b70b0954f3ea5e3b053dae4c1a9d

R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308073013

10 years agostop using brackets within skimage output filenames
epoger [Mon, 2 Jun 2014 20:35:22 +0000 (13:35 -0700)]
stop using brackets within skimage output filenames

BUG=skia:2634
R=scroggo@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/303263012

10 years agoUpdate expectations to fix self tests.
scroggo [Mon, 2 Jun 2014 20:34:08 +0000 (13:34 -0700)]
Update expectations to fix self tests.

R=epoger@google.com
TBR=epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/306313004

10 years agoUpdate TSAN suppressions.
mtklein [Mon, 2 Jun 2014 20:23:49 +0000 (13:23 -0700)]
Update TSAN suppressions.

TSAN suppressions need to be on their own line, even free of comments.

Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load.
Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN
has an atomic load that makes the annotation moot.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308073013

10 years agouse colortype instead of config
reed [Mon, 2 Jun 2014 20:07:26 +0000 (13:07 -0700)]
use colortype instead of config

clone of https://codereview.chromium.org/305133006/

TBR=

BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/301233011

10 years agoTSAN caught us racing in ScalarBench.cpp
mtklein [Mon, 2 Jun 2014 19:41:07 +0000 (12:41 -0700)]
TSAN caught us racing in ScalarBench.cpp

http://108.170.220.102:10117/builders/Test-Ubuntu13-ShuttleA-HD2000-x86_64-Debug-TSAN/builds/914/steps/RunDM/logs/stdio

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=14992

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/305033002

10 years agoAllow access to device config for Moz2d.
jvanverth [Mon, 2 Jun 2014 19:27:25 +0000 (12:27 -0700)]
Allow access to device config for Moz2d.

BUG=skia:2633
R=robertphillips@google.com, borenet@google.com, george@mozilla.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/304273009

10 years agoRevert of Update SKP version to 13 (https://codereview.chromium.org/309753004/)
borenet [Mon, 2 Jun 2014 19:19:29 +0000 (12:19 -0700)]
Revert of Update SKP version to 13 (https://codereview.chromium.org/309753004/)

Reason for revert:
Did not include perf baselines.

Original issue's description:
> Update SKP version to 13
>
> TBR=
>
> Committed: https://skia.googlesource.com/skia/+/7574153e9cc52b1b560ded02a2b219cda4b1816c

R=rmistry@google.com
TBR=rmistry@google.com
NOTREECHECKS=true
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/309813003

10 years agoAdding resource files
Robert Phillips [Mon, 2 Jun 2014 19:18:27 +0000 (15:18 -0400)]
Adding resource files

The ktx file is to test the new ktx reader
The pkm shrinks the size of the pkm test file

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/312563002

10 years agoUpdate SKP version to 13
borenet [Mon, 2 Jun 2014 19:15:31 +0000 (12:15 -0700)]
Update SKP version to 13

R=rmistry@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/309753004

10 years agoRemove legacy Picture-recording flags from Android build
robertphillips [Mon, 2 Jun 2014 19:09:29 +0000 (12:09 -0700)]
Remove legacy Picture-recording flags from Android build

R=scroggo@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/304333002

10 years agoRemove unitmappers header.
scroggo [Mon, 2 Jun 2014 18:32:56 +0000 (11:32 -0700)]
Remove unitmappers header.

This file contained a bunch of unitmappers. Luckily noone includes
it, since it wouldn't compile (the unitmapper class was removed in
https://codereview.chromium.org/288313009).

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/295383013

10 years agoClean up SkOnce:
mtklein [Mon, 2 Jun 2014 18:26:59 +0000 (11:26 -0700)]
Clean up SkOnce:

  1 Remove atExit feature: clients can do it just as well as SkOnce can.
  2 Remove support for functors: no one but the unit test did that.
  3 Remove support for unused non-static SkOnceFlag (no SK_ONCE_INIT).
  4 Add SkOnce variants for no-arg functions so we're not forced to pass dummy values all the time.
  5 Merge SkSpinlock and SkOnceFlag, making all members private.
  6 More notes about memory barriers, adding an acquire load after acquiring the spinlock.

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/302083003

10 years agoinvert comparison sense for reason return
humper [Mon, 2 Jun 2014 18:09:12 +0000 (11:09 -0700)]
invert comparison sense for reason return

BUG=skia:
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/313433003

10 years agoCompile-time initialize special SkMatrices.
mtklein [Mon, 2 Jun 2014 17:59:35 +0000 (10:59 -0700)]
Compile-time initialize special SkMatrices.

BUG=skia:
R=bungeman@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/303263011

10 years agoMove GrIPoint16 to SkIPoint16 (and remove GrPoint.h)
robertphillips [Mon, 2 Jun 2014 17:20:14 +0000 (10:20 -0700)]
Move GrIPoint16 to SkIPoint16 (and remove GrPoint.h)

R=bsalomon@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/309683002

10 years agoPort most uses of SkOnce to SkLazyPtr.
mtklein [Mon, 2 Jun 2014 15:44:27 +0000 (08:44 -0700)]
Port most uses of SkOnce to SkLazyPtr.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=15006

Committed: http://code.google.com/p/skia/source/detail?r=15014

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

10 years agoFix bracket outside of ifdef
krajcevski [Mon, 2 Jun 2014 15:02:45 +0000 (08:02 -0700)]
Fix bracket outside of ifdef

R=jvanverth@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/305333003

10 years agoClean up SkLazyPtrs only in SK_DEVELOPER mode.
mtklein [Mon, 2 Jun 2014 14:53:01 +0000 (07:53 -0700)]
Clean up SkLazyPtrs only in SK_DEVELOPER mode.

Checking only SK_DEBUG may make SkLazyPtr too anal about leaks for
clients.  Still working through strange leak problems inside Skia
tests, so it's probably premature to turn it on in Chrome tests.

BUG=379570
R=reed@google.com, mtklein@google.com, bungeman@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/308003014

10 years agoInitial work to get ETC1 data up to the GPU
krajcevski [Mon, 2 Jun 2014 14:38:14 +0000 (07:38 -0700)]
Initial work to get ETC1 data up to the GPU

Committed: http://code.google.com/p/skia/source/detail?r=15001

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/302783002

10 years agoUpdate comments about debugging on master.
scroggo [Mon, 2 Jun 2014 14:19:13 +0000 (07:19 -0700)]
Update comments about debugging on master.

Update the makefile to reference the correct location of
config.mk.

R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/308703009

10 years agoAdd Sample slide for Rectanizers
robertphillips [Mon, 2 Jun 2014 14:15:18 +0000 (07:15 -0700)]
Add Sample slide for Rectanizers

R=jvanverth@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/303263005

10 years agohide SkDevice::config()
reed [Mon, 2 Jun 2014 12:45:31 +0000 (05:45 -0700)]
hide SkDevice::config()

TBR=robertphilips

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/302253002

10 years agoWhitespace change to test the Git Skia CQ
rmistry [Mon, 2 Jun 2014 12:29:08 +0000 (05:29 -0700)]
Whitespace change to test the Git Skia CQ

NOTREECHECKS=true
BUG=skia:2613
TBR=

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/311603002

10 years agoUse googlesource VIEW_VC in codereview.settings
rmistry [Mon, 2 Jun 2014 12:20:32 +0000 (05:20 -0700)]
Use googlesource VIEW_VC in codereview.settings

BUG=skia:2613
NOTREECHECKS=true
NOTRY=true
R=borenet@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/309643005

10 years agoWhitespace change to test the Git Skia CQ
rmistry [Mon, 2 Jun 2014 12:12:27 +0000 (05:12 -0700)]
Whitespace change to test the Git Skia CQ

NOTREECHECKS=true
TBR=
BUG=skia:
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/308703008

10 years agoWhitespace
Eric Boren [Mon, 2 Jun 2014 12:03:43 +0000 (08:03 -0400)]
Whitespace

BUG=skia:

Review URL: https://codereview.chromium.org/304233004

10 years agoremove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
commit-bot@chromium.org [Sat, 31 May 2014 21:47:03 +0000 (21:47 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE

R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/308953002

git-svn-id: http://skia.googlecode.com/svn/trunk@15016 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org...
commit-bot@chromium.org [Sat, 31 May 2014 00:15:22 +0000 (00:15 +0000)]
Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/)

Reason for revert:
linux x86-64 release segfault in src/ports/SkFontHost_fontconfig.cpp:107

http://108.170.220.120:10117/builders/Test-Ubuntu12-ShuttleA-GTX660-x86_64-Release/builds/905/steps/RunTests/logs/stdio

Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006
>
> Committed: http://code.google.com/p/skia/source/detail?r=15014

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/306063004

git-svn-id: http://skia.googlecode.com/svn/trunk@15015 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoPort most uses of SkOnce to SkLazyPtr.
commit-bot@chromium.org [Fri, 30 May 2014 23:59:12 +0000 (23:59 +0000)]
Port most uses of SkOnce to SkLazyPtr.

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=15006

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/304383005

git-svn-id: http://skia.googlecode.com/svn/trunk@15014 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew file for simpler updating of Android defines.
commit-bot@chromium.org [Fri, 30 May 2014 21:53:01 +0000 (21:53 +0000)]
New file for simpler updating of Android defines.

When building Skia for the Android framework, we will now read a
file which only includes defines. This will make it easier for
people deprecating APIs to add the guard to Android.

R=reed@google.com, djsollen@google.com, bungeman@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/305193002

git-svn-id: http://skia.googlecode.com/svn/trunk@15013 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd a way for the gpu veto to report back the reason why it said no
commit-bot@chromium.org [Fri, 30 May 2014 21:52:52 +0000 (21:52 +0000)]
Add a way for the gpu veto to report back the reason why it said no

BUG=2334
R=bsalomon@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/301423002

git-svn-id: http://skia.googlecode.com/svn/trunk@15012 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agofix casting issue with or operator
commit-bot@chromium.org [Fri, 30 May 2014 21:07:05 +0000 (21:07 +0000)]
fix casting issue with or operator

R=reed@google.com, epoger@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/305253002

git-svn-id: http://skia.googlecode.com/svn/trunk@15011 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPAR...
commit-bot@chromium.org [Fri, 30 May 2014 21:03:38 +0000 (21:03 +0000)]
Revert of remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS (https://codereview.chromium.org/308083010/)

Reason for revert:
broke skia/ext/bitmap_platform_device_cairo.cc:44:56: error: no matching function for call to â€˜SkBitmap::installPixels

Original issue's description:
> remove SK_SUPPORT_LEGACY_ASIMAGEINFO and SK_SUPPORT_LEGACY_INSTALLPIXELSPARAMS
>
> TBR=
> NOTRY=
>
> Committed: http://code.google.com/p/skia/source/detail?r=15007

TBR=
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/301353006

git-svn-id: http://skia.googlecode.com/svn/trunk@15010 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org...
commit-bot@chromium.org [Fri, 30 May 2014 21:00:52 +0000 (21:00 +0000)]
Revert of Port most uses of SkOnce to SkLazyPtr. (https://codereview.chromium.org/304383005/)

Reason for revert:
Leaking refs on SkTypeface on Macs.

Original issue's description:
> Port most uses of SkOnce to SkLazyPtr.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=15006

R=reed@google.com, mtklein@chromium.org
TBR=mtklein@chromium.org, reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/304283007

git-svn-id: http://skia.googlecode.com/svn/trunk@15009 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAllow SkPictureImageFilter to be serialized when not run cross-process.
senorblanco@chromium.org [Fri, 30 May 2014 20:50:56 +0000 (20:50 +0000)]
Allow SkPictureImageFilter to be serialized when not run cross-process.

Picture serialization is not yet hardened, but it turns out we do need
serialization of SkPictureImageFilter for deferred SVG-on-SVG filters,
since the SkPaints (and thus the SkImageFilters) are serialized by
SkPictureRecord. However, deferred filters are always drawn in the
same process, so we can safely serialize them in this case. We do this
by turning the compile-time check for
SK_ALLOW_PICTUREIMAGEFILTER_SERIALIZATION to a runtime check for
isCrossProcess().

The image filter fuzzer sample was also modified to enable fuzzing
of basic picture image filters (the code had rotted a bit, being behind
an #ifdef that no one sets).

BUG=375162
R=sugoi@google.com

Review URL: https://codereview.chromium.org/311443003

git-svn-id: http://skia.googlecode.com/svn/trunk@15008 2bbb7eff-a529-9590-31e7-b0007b416f81