Gurchetan Singh [Tue, 7 Nov 2017 20:29:56 +0000 (20:29 +0000)]
Lower correlation threshold in flush-finish tests again
am:
6455e6f987
Change-Id: I06395cdc2b3b19e7426f35e80981d0547309ede4
Gurchetan Singh [Fri, 6 Oct 2017 16:06:21 +0000 (09:06 -0700)]
Lower correlation threshold in flush-finish tests again
This test expects predictability from glFlush/glFinish timing.
In particular, the code from FlushFinishCase::analyzeResults()
checks that the result falls within specific timing thresholds.
Notice that in the GLES3 specification, there is no requirement for
timing, just a guarantee that "commands [...] complete in finite time".
This is a problem because it makes the test very flaky, for example
if the CPU/GPU clocks are not ramping up fast enough.
BUG=b:
67331095
TEST=Ran dEQP-GLES3.functional.flush_finish.finish on Elm for over 3+ hours
Observed 1.5% to 2% flakiness without this patch. Observed no flakiness
with this patch.
(cherry picked from commit
59f4fcde5ac1402ab3b911cf6a9f66b886c10464)
Signed-off-by: Gurchetan Singh <gurchetansingh@google.com>
Pyry Haulos [Tue, 5 Sep 2017 15:31:55 +0000 (15:31 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20 am:
338a411fd3
am:
0d9b810283
Change-Id: Ic07c0dafc51bf12a82794d02786b885f8b1323f8
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
9e85a126d2
Change-Id: Idf3c0904f9695e04b48901c23c79b7dcd101d0dc
Pyry Haulos [Tue, 5 Sep 2017 15:21:55 +0000 (15:21 +0000)]
Fix issues in pipeline.timestamp.transfer_tests am:
0f672f2a20
am:
338a411fd3
Change-Id: I6edcc0661c9d702a5bb518d24eebf7702145318f
Pyry Haulos [Tue, 5 Sep 2017 15:14:23 +0000 (15:14 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: Ib7e13db1c7801095b925890f226a38969a1b418e
Pyry Haulos [Tue, 5 Sep 2017 15:13:55 +0000 (15:13 +0000)]
Fix issues in pipeline.timestamp.transfer_tests
am:
0f672f2a20
Change-Id: I41d95ce51483f786706f9402701208801e73ecdc
Pyry Haulos [Thu, 9 Mar 2017 17:46:29 +0000 (09:46 -0800)]
Fix issues in pipeline.timestamp.transfer_tests
This change fixes two issues:
* Buffer overrun in vkCmdCopyBufferToImage and vkCmdCopyImageToBuffer
tests.
* Validation error (srcStageMask must not be 0).
VK-GL-CTS issue: 185
Components: Vulkan
Change-Id: I9679566f08c4a914eb6066bab248abd6d51e0f7e
Graeme Leese [Fri, 4 Aug 2017 22:20:34 +0000 (22:20 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am:
4f1051ad32 am:
b8e4ff4043
am:
a2d901c3d8
Change-Id: I4da52aeb3a4c496dd7071eedff513db057a86ed1
Graeme Leese [Fri, 4 Aug 2017 22:14:34 +0000 (22:14 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am:
4f1051ad32
am:
5bd0fb31a1
Change-Id: Id14e6caccfe5173661572abb58006199597a945e
Graeme Leese [Fri, 4 Aug 2017 22:14:33 +0000 (22:14 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev am:
4f1051ad32
am:
b8e4ff4043
Change-Id: I79289a400b489142682865c5a9f8153d2b97650f
Graeme Leese [Fri, 4 Aug 2017 22:08:05 +0000 (22:08 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev
am:
4f1051ad32
Change-Id: I3bc55d8c7271eb61c7c593505dab8e13e0b48e16
Graeme Leese [Fri, 4 Aug 2017 22:03:02 +0000 (22:03 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev
am:
4f1051ad32
Change-Id: I4f54481292ffaaf5e1cf56a05ef24f7dfa4983f3
Treehugger Robot [Fri, 4 Aug 2017 21:56:36 +0000 (21:56 +0000)]
Merge "Fix extension support checks in negative api tests" into nougat-cts-dev
Mika Isojrvi [Wed, 19 Jul 2017 18:18:59 +0000 (18:18 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
b426d8bfad am:
580f143209 am:
73a16f417e am:
550064261f am:
1b81ecf035
am:
68d441aedd
Change-Id: I0987771e5baa7f39cdecfcfa12dec7bf03c627a8
Mika Isojrvi [Wed, 19 Jul 2017 18:16:00 +0000 (18:16 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
b426d8bfad am:
580f143209 am:
73a16f417e am:
550064261f
am:
1b81ecf035
Change-Id: Ib2b42f6a400417daa850bd107b56373475058840
Mika Isojrvi [Wed, 19 Jul 2017 18:13:31 +0000 (18:13 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
b426d8bfad am:
580f143209 am:
73a16f417e
am:
550064261f
Change-Id: I9cd9791970b8a466b1a3a31adae45d9375ab5321
Mika Isojrvi [Wed, 19 Jul 2017 18:10:30 +0000 (18:10 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
14cd264501 am:
6e80057a20
am:
cae1fe52ac
Change-Id: Iad44b21021d6f24b0d6c126cf81cf24632a0aaab
Mika Isojrvi [Wed, 19 Jul 2017 18:10:29 +0000 (18:10 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
b426d8bfad am:
580f143209
am:
73a16f417e
Change-Id: I28d74629adfb6ebb7898c1fc7c9bd831ca4562ae
Mika Isojrvi [Wed, 19 Jul 2017 18:07:01 +0000 (18:07 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
14cd264501
am:
6e80057a20
Change-Id: I85568945b0bb02c5b82dbba6ba449cd851358694
Mika Isojrvi [Wed, 19 Jul 2017 18:07:00 +0000 (18:07 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
b426d8bfad
am:
580f143209
Change-Id: Ib4610c6afd22db3a464e3079ddca088aefaed271
Mika Isojrvi [Wed, 19 Jul 2017 18:04:31 +0000 (18:04 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898
am:
14cd264501
Change-Id: Ide39036c1f956b64464d21eced9a16c0a2022f2b
Mika Isojrvi [Wed, 19 Jul 2017 18:04:31 +0000 (18:04 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898 am:
14cd264501
am:
d4c01761d3
Change-Id: I3fe580bed5dcdb5f41742c0e6e0ee1db05eae572
Mika Isojrvi [Wed, 19 Jul 2017 18:04:29 +0000 (18:04 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898
am:
b426d8bfad
Change-Id: I98bcc7054eeca8fb9621694f0b628727bdcdec2c
Mika Isojrvi [Wed, 19 Jul 2017 18:02:00 +0000 (18:02 +0000)]
Fix atomic ssbo xor test
am:
f0fa05e898
Change-Id: I593778e49374ab84b2b5b0b3fca57f36adf18684
Mika Isojrvi [Wed, 19 Jul 2017 18:00:27 +0000 (18:00 +0000)]
Fix atomic ssbo xor test am:
f0fa05e898
am:
14cd264501
Change-Id: Ib554d7464534203cbcde53f0ebd6931082900a82
Mika Isojrvi [Wed, 19 Jul 2017 17:57:28 +0000 (17:57 +0000)]
Fix atomic ssbo xor test
am:
f0fa05e898
Change-Id: Ibc16a0ff1a6b1dbe764d4beafa5d9b63d9c090e9
Mika Isojärvi [Thu, 14 Apr 2016 17:28:16 +0000 (10:28 -0700)]
Fix atomic ssbo xor test
Allow any values in high order bits in xor tests when using uint types.
Bug:
28144118
Change-Id: I0670aa12642882a329cb923487198fdf045b912b
Mika Isojrvi [Wed, 12 Jul 2017 23:07:20 +0000 (23:07 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
4d1d6446da
am:
b78f9b0e57
Change-Id: Ib4da93e41b7aeb93dcb5614cfe5c88d2e7fe3cd5
Mika Isojrvi [Wed, 12 Jul 2017 23:04:14 +0000 (23:04 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
4d1d6446da am:
6c0e0ebde7
am:
371f033807
Change-Id: Id2893b6d91866acc764b8030410a8b52d0a98f6f
Mika Isojrvi [Wed, 12 Jul 2017 23:04:00 +0000 (23:04 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
e37b18673d am:
97ce4c6f8c am:
4c56c58687 am:
0ddc9faea1 am:
d2d7d49296
am:
301312d147
Change-Id: Ief92acaf946b4146cd59f5d43128935c36052d41
Mika Isojrvi [Wed, 12 Jul 2017 22:57:29 +0000 (22:57 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
4d1d6446da
am:
6c0e0ebde7
Change-Id: If4af4e7b7e38776f4512e4089db08513dfc3d836
Mika Isojrvi [Wed, 12 Jul 2017 22:55:31 +0000 (22:55 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a
am:
4d1d6446da
Change-Id: I665044280c34a26c85886038cf3022bd490a4d16
Mika Isojrvi [Wed, 12 Jul 2017 22:55:29 +0000 (22:55 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
e37b18673d am:
97ce4c6f8c am:
4c56c58687 am:
0ddc9faea1
am:
d2d7d49296
Change-Id: Ibe5746d2974294959fce2319e7e3ebfff99d8293
Mika Isojrvi [Wed, 12 Jul 2017 22:53:28 +0000 (22:53 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a
am:
4d1d6446da
Change-Id: I9931765924b1102c011bd1d75522f9b4f7089dd2
Mika Isojrvi [Wed, 12 Jul 2017 22:51:32 +0000 (22:51 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
e37b18673d am:
97ce4c6f8c am:
4c56c58687
am:
0ddc9faea1
Change-Id: I4fbba2ef9ac41c6130da0f0c3b9fba2212bc4f78
Mika Isojrvi [Wed, 12 Jul 2017 22:51:27 +0000 (22:51 +0000)]
Mask compared bits in atomic operation tests.
am:
b2ed9fbe1a
Change-Id: I2f7b4cfbf2d926966af7c9956db670080771c164
Mika Isojrvi [Wed, 12 Jul 2017 22:49:57 +0000 (22:49 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
e37b18673d am:
97ce4c6f8c
am:
4c56c58687
Change-Id: I980ef2baab6051b674a3374d32f4f705a2b67f40
Mika Isojrvi [Wed, 12 Jul 2017 22:48:00 +0000 (22:48 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a am:
e37b18673d
am:
97ce4c6f8c
Change-Id: I56e0700af0ce17a904e5a71852c99e1437d79212
Mika Isojrvi [Wed, 12 Jul 2017 22:45:28 +0000 (22:45 +0000)]
Mask compared bits in atomic operation tests. am:
b2ed9fbe1a
am:
e37b18673d
Change-Id: Ic61ec45f634d0c53b6319b3bed92ef77c5c1b20c
Mika Isojrvi [Wed, 12 Jul 2017 22:43:56 +0000 (22:43 +0000)]
Mask compared bits in atomic operation tests.
am:
b2ed9fbe1a
Change-Id: I34ad163b4088436c5c3f8d41809f626b0904cef0
Graeme Leese [Thu, 23 Feb 2017 16:56:10 +0000 (16:56 +0000)]
Fix extension support checks in negative api tests
Add checks for tessellation and geometry shader support for negative
shader storage and primitive bounding box tests.
Move all uses of cubemap array textures inside the extension checks in
the texture tests.
Bug:
29835218
Change-Id: I6051fff231285ed7d9c71015c2bb11a9fc7b909b
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
Mika Isojärvi [Tue, 5 Apr 2016 17:42:09 +0000 (10:42 -0700)]
Mask compared bits in atomic operation tests.
Bug:
27975797
Change-Id: Id24a784b5b8a665f509218358d58d7eca9a7bb93
Android Build Merger (Role) [Wed, 3 May 2017 16:11:18 +0000 (16:11 +0000)]
Merge "Merge "Fix color change verification in dithering tests" into nougat-cts-dev am:
acf47d464f am:
c2594c65ff" into nyc-mr1-dev
Pyry Haulos [Wed, 3 May 2017 16:11:07 +0000 (16:11 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev am:
acf47d464f am:
45d860b737
am:
2196375b32
Change-Id: If38159d29357c10a4fcae002dee923433cf48ff6
Pyry Haulos [Wed, 3 May 2017 16:11:06 +0000 (16:11 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev am:
acf47d464f
am:
c2594c65ff
Change-Id: I8b7fab12228e9366c9f96280288a88867bbd4724
Pyry Haulos [Wed, 3 May 2017 16:08:46 +0000 (16:08 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev am:
9a83ec3f47 am:
9443c9c4c0
am:
578ae6d230
Change-Id: I36eb3d69950032890a944b6ca326ef9dbcc4221a
Pyry Haulos [Wed, 3 May 2017 16:08:35 +0000 (16:08 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev am:
acf47d464f
am:
45d860b737
Change-Id: I9bfa731b074538d354a25945f760ba00d9c31ad1
Alexander Galazin [Wed, 3 May 2017 16:08:35 +0000 (16:08 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev am:
eebcec1b52 am:
71a9bc447d
am:
620c938d61
Change-Id: I5f0ad6166b794a441678451ccb70c9628f3100ca
Pyry Haulos [Wed, 3 May 2017 16:07:36 +0000 (16:07 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev
am:
acf47d464f
Change-Id: I82bfed0cc9cee128a8552b4e8cf3fb87ced37c9f
Android Build Merger (Role) [Wed, 3 May 2017 16:07:03 +0000 (16:07 +0000)]
Merge "Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev am:
9a83ec3f47 am:
90e6678bc9" into nyc-mr1-dev
Pyry Haulos [Wed, 3 May 2017 16:06:57 +0000 (16:06 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev am:
9a83ec3f47
am:
90e6678bc9
Change-Id: I06a9f451d5ba510d77b89c01dbe33229bbd75319
Android Build Merger (Role) [Wed, 3 May 2017 16:06:52 +0000 (16:06 +0000)]
Merge "Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev am:
eebcec1b52 am:
2585331908" into nyc-mr1-dev
Pyry Haulos [Wed, 3 May 2017 16:06:47 +0000 (16:06 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev am:
9a83ec3f47
am:
9443c9c4c0
Change-Id: Iaab965ccbaeb3ca315a5da67ae342b25b1fccb35
Alexander Galazin [Wed, 3 May 2017 16:06:47 +0000 (16:06 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev am:
eebcec1b52
am:
2585331908
Change-Id: Ide25b381041f3c545b53906842a2caa7733b7ddc
Android Build Merger (Role) [Wed, 3 May 2017 16:06:44 +0000 (16:06 +0000)]
Merge "Try to determine renderable format in lifetime tests am:
c0a5dc217f am:
e94af4b69f am:
d92ff56cca" into nyc-mr1-dev
Pyry Haulos [Wed, 3 May 2017 16:06:40 +0000 (16:06 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev
am:
acf47d464f
Change-Id: Iabf1c0d76db9f83f64cae805f89bd60230cd0408
Pyry Haulos [Wed, 3 May 2017 16:06:36 +0000 (16:06 +0000)]
Try to determine renderable format in lifetime tests am:
c0a5dc217f
am:
eba26e2387
Change-Id: I849814817f65bd5e127463af9fb5a27a9759870c
Alexander Galazin [Wed, 3 May 2017 16:06:35 +0000 (16:06 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev am:
eebcec1b52
am:
71a9bc447d
Change-Id: Iba7f7005d3fe89e5a927cf5afe07a13a3312a525
Pyry Haulos [Wed, 3 May 2017 16:06:35 +0000 (16:06 +0000)]
Try to determine renderable format in lifetime tests am:
c0a5dc217f am:
e94af4b69f
am:
d92ff56cca
Change-Id: I4b38bd10ac0d0748948c7ec5e72c5595689ac7b7
Pyry Haulos [Wed, 3 May 2017 16:04:22 +0000 (16:04 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev
am:
9a83ec3f47
Change-Id: I18cb5efebe1ed2b56818fc2c5b8da89f0a4fd1d7
Treehugger Robot [Wed, 3 May 2017 16:04:13 +0000 (16:04 +0000)]
Merge "Fix color change verification in dithering tests" into nougat-cts-dev
Alexander Galazin [Wed, 3 May 2017 16:04:08 +0000 (16:04 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev
am:
eebcec1b52
Change-Id: I4c726cca01d733fadfeef64f9ade6318bed6e66b
Pyry Haulos [Wed, 3 May 2017 16:04:06 +0000 (16:04 +0000)]
Try to determine renderable format in lifetime tests am:
c0a5dc217f
am:
e94af4b69f
Change-Id: Ia413488ae565cb75cc79260362ff4dd7cf1c2ef5
Pyry Haulos [Wed, 3 May 2017 16:03:19 +0000 (16:03 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev
am:
9a83ec3f47
Change-Id: I1dfb480ed3b5fb7f384a8fe9b0a852134fde1500
Alexander Galazin [Wed, 3 May 2017 16:03:07 +0000 (16:03 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev
am:
eebcec1b52
Change-Id: Ib4d673157f82d00d0d27ab3496ac8a1dc6634fe1
Pyry Haulos [Wed, 3 May 2017 16:02:07 +0000 (16:02 +0000)]
Try to determine renderable format in lifetime tests
am:
c0a5dc217f
Change-Id: I36f65b41ac4958f0794e4ca52a9703e80aa37fab
Treehugger Robot [Wed, 3 May 2017 16:01:05 +0000 (16:01 +0000)]
Merge "DEPTH_STENCIL_OES as tex format requires OES_depth_texture" into nougat-cts-dev
Treehugger Robot [Wed, 3 May 2017 15:59:50 +0000 (15:59 +0000)]
Merge "Fix error mask generation in checkLineContinuity" into nougat-cts-dev
Pyry Haulos [Wed, 3 May 2017 15:58:34 +0000 (15:58 +0000)]
Try to determine renderable format in lifetime tests
am:
c0a5dc217f
Change-Id: I99514ee1a3ccb9a0aa397f0a8e9e7d45b47ec9ba
Alexander Galazin [Thu, 20 Apr 2017 12:08:44 +0000 (14:08 +0200)]
Fix error mask generation in checkLineContinuity
Even if some pixels are missing the function could return
all-zero errorMask if the messageLimitcounter was exhausted.
Components: AOSP
Affects: dEQP-GLES31.functional.primitive_bounding_box.lines.*
Google bug:
35987764
Pyry Haulos [Tue, 18 Apr 2017 23:13:59 +0000 (16:13 -0700)]
Fix color change verification in dithering tests
Tests were supposed to allow color change once per row/column depending
on gradient direction but instead allowed color change in constant
direction only once over whole image.
Affects:
dEQP-GLES2.functional.dither.disabled.gradient_*
dEQP-GLES3.functional.dither.disabled.gradient_*
Bug:
37477346
Change-Id: I37ef06b4ff527f8c316eae56c8a99c88cdaaf4b4
Pyry Haulos [Mon, 17 Apr 2017 21:34:27 +0000 (14:34 -0700)]
Try to determine renderable format in lifetime tests
Affects:
dEQP-GLES2.functional.lifetime.attach.deleted_input.renderbuffer_framebuffer
dEQP-GLES2.functional.lifetime.attach.deleted_input.texture_framebuffer
dEQP-GLES2.functional.lifetime.attach.deleted_output.renderbuffer_framebuffer
dEQP-GLES2.functional.lifetime.attach.deleted_output.texture_framebuffer
Bug:
36724173
Change-Id: I46196317c144f294adce65ff4690571d28e1caf3
Pyry Haulos [Mon, 17 Apr 2017 19:34:26 +0000 (12:34 -0700)]
DEPTH_STENCIL_OES as tex format requires OES_depth_texture
Affects:
dEQP-GLES2.functional.fbo.completeness.*
dEQP-GLES3.functional.fbo.completeness.*
Bug:
36727598
Merged-In: Ic79408c21b80ea458baecf79c042e2694e72e0b2
Change-Id: Ib302b21b2b28d4f13aa6df8bdcac878f22ae51be
Android Build Merger (Role) [Tue, 11 Apr 2017 17:22:26 +0000 (17:22 +0000)]
Merge "Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev am:
aeef6dd8f5 am:
a4ddab16dd" into nyc-mr1-dev
Ian Romanick [Tue, 11 Apr 2017 17:22:20 +0000 (17:22 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev am:
aeef6dd8f5
am:
a4ddab16dd
Change-Id: Id0387a01061c95f4c51728c8af917aa63354097b
Ian Romanick [Tue, 11 Apr 2017 17:22:19 +0000 (17:22 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev am:
aeef6dd8f5 am:
fdc198ba11
am:
c7970bbd83
Change-Id: I1a41ff937b2f7328f7ef9b18cc8074614113c242
Ian Romanick [Tue, 11 Apr 2017 17:17:48 +0000 (17:17 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev am:
aeef6dd8f5
am:
fdc198ba11
Change-Id: Ieb66f942f4d5e690f1cdfecfc92144deca46d12a
Ian Romanick [Tue, 11 Apr 2017 17:13:20 +0000 (17:13 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev
am:
aeef6dd8f5
Change-Id: Ia384b5bb86c9e07ecc47a0c1002205ce27f4e399
Ian Romanick [Tue, 11 Apr 2017 17:13:17 +0000 (17:13 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev
am:
aeef6dd8f5
Change-Id: I8300511b30c7bd03885a6cb019970852f7e72693
Treehugger Robot [Tue, 11 Apr 2017 16:56:42 +0000 (16:56 +0000)]
Merge "Try harder to defeat GLSL compiler dead-code optimizations" into nougat-cts-dev
Ian Romanick [Thu, 10 Nov 2016 01:29:01 +0000 (17:29 -0800)]
Try harder to defeat GLSL compiler dead-code optimizations
A number of CTS tests generate shaders like like:
#version 310 es
buffer TargetInterface
{
highp float target;
};
highp vec4 readInputs()
{
highp vec4 retValue = vec4(0.0);
retValue += vec4(float(target));
return retValue;
}
void writeOutputs(in highp vec4 dummyValue)
{
target = float(dummyValue.y);
}
void main()
{
writeOutputs(readInputs());
}
After various common optimizations this becomes:
buffer TargetInterface
{
highp float target;
};
void main()
{
target = target;
}
In the absence of memoryBarrier() or qualifiers on the buffer, there is
no guarantee about the order of writes to the buffer. Since this write
is not guaranteed to be visible either on the GPU or the CPU, we
eliminate it. Since there is no access to target in the shader, we
report GL_REFERENCED_BY_FRAGMENT_SHADER = GL_FALSE. The tests expect
GL_TRUE.
The vectored versions of this test swizzle the value read from the
buffer before writing it back. These writes are not eliminated.
Adding a uniform instead of a literal constant also prevents the reads
and writes of the SSBO from being eliminated.
v2: Ignore the uniform named "zero" in
ResourceListTestCase::verifyResourceList. The alternative was to add
zero to the resource list, but that required making small changes
(mostly removing const) from over a dozen places in the code. This
slightly hacky, but localized, change seemed better.
v3: Various coding standards fixes suggested by Alexander Galazin and
Pyry. Add getDummyZeroUniformName to query name of the zero uniform and
a lot more documentation. Both suggested by Pyry.
The following tests are affected:
- dEQP-GLES31.functional.program_interface_query.buffer_variable.random.6
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.compute.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.separable_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_geo_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_geo_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_geo_fragment_only_fragment.unnamed_block.float
- dEQP-GLES31.functional.program_interface_query.buffer_variable.referenced_by.vertex_tess_geo_fragment.unnamed_block.float
Change-Id: I867ad32476269ac1272c09672be0a6d6fe37e31e
Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=16114
Google bug:
37228062
Pyry Haulos [Fri, 17 Mar 2017 12:22:38 +0000 (12:22 +0000)]
Fix warning introduced in
2c9e3ec9 am:
521361d83d
am:
19bf995047
Change-Id: I092e8e8e119e4e004bb1451cb1fb999bf2e9a42d
Pyry Haulos [Fri, 17 Mar 2017 12:14:33 +0000 (12:14 +0000)]
Fix warning introduced in
2c9e3ec9 am:
521361d83d am:
5f34117776
am:
eba2559865
Change-Id: Ic1f2a2853173047311052607311518ea9b3b5264
Pyry Haulos [Fri, 17 Mar 2017 12:11:19 +0000 (12:11 +0000)]
Fix warning introduced in
2c9e3ec9 am:
521361d83d
am:
5f34117776
Change-Id: I79c64f4d5c3d494e7c5f11df44a00478648e581a
Pyry Haulos [Fri, 17 Mar 2017 12:09:41 +0000 (12:09 +0000)]
Fix warning introduced in
2c9e3ec9
am:
521361d83d
Change-Id: I82a9917cb875a166583a41e3d1bb7702ae2d3db8
Pyry Haulos [Fri, 17 Mar 2017 12:08:03 +0000 (12:08 +0000)]
Fix warning introduced in
2c9e3ec9
am:
521361d83d
Change-Id: Iaf6e63f119e32613ec46fa9135c7c3be42fd47b3
Pyry Haulos [Wed, 15 Mar 2017 19:23:06 +0000 (12:23 -0700)]
Fix warning introduced in
2c9e3ec9
Change-Id: I42bef21b2cc7274f107e5455dea1e382d8a419f4
(cherry picked from commit
d8b452a7533c195b1328918bb696a819542ff044)
Alexander Galazin [Wed, 15 Mar 2017 18:44:38 +0000 (18:44 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev am:
0532365740 am:
dce98dc6e9
am:
650fc6607d
Change-Id: I15dea4f22dff8a97150ade21c3496273e99ab3ba
Alexander Galazin [Wed, 15 Mar 2017 18:40:08 +0000 (18:40 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev am:
0532365740
am:
468843cf08
Change-Id: I9dbbc27bd20cfa6a2142ac132da5068b471046a3
Alexander Galazin [Wed, 15 Mar 2017 18:40:07 +0000 (18:40 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev am:
0532365740
am:
dce98dc6e9
Change-Id: I8e13f121b5f9f075ec01196d81ac541c8e1b55f7
Alexander Galazin [Wed, 15 Mar 2017 18:35:38 +0000 (18:35 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev
am:
0532365740
Change-Id: I33b9d9b1fbe0b11ce2af87708bd9682ed728a706
Alexander Galazin [Wed, 15 Mar 2017 18:35:35 +0000 (18:35 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev
am:
0532365740
Change-Id: I12be73b76f9ae43955fbca0071f36b897e82f0d9
Treehugger Robot [Wed, 15 Mar 2017 18:30:21 +0000 (18:30 +0000)]
Merge "Further relax line verification in primitive bbox tests" into nougat-cts-dev
Alexander Galazin [Wed, 15 Mar 2017 15:37:25 +0000 (15:37 +0000)]
Use glReadnPixels only if KHR_robustness is supported am:
d99ba132d9 am:
875d3c2990
am:
4a2a606f28
Change-Id: I295fdd5c2bfeb2d85b09d1717b19d7b92d270389
Alexander Galazin [Wed, 15 Mar 2017 15:32:24 +0000 (15:32 +0000)]
Use glReadnPixels only if KHR_robustness is supported am:
d99ba132d9
am:
875d3c2990
Change-Id: I00af902dcb247905e4f8b3610697177acd98879b
Alexander Galazin [Wed, 15 Mar 2017 15:27:24 +0000 (15:27 +0000)]
Use glReadnPixels only if KHR_robustness is supported
am:
d99ba132d9
Change-Id: I61323fdb484c606044509dc6d8ea6724dd8989a8
Alexander Galazin [Wed, 15 Mar 2017 15:27:24 +0000 (15:27 +0000)]
Use glReadnPixels only if KHR_robustness is supported am:
d99ba132d9
am:
d01980d03d
Change-Id: I08946ff5a8682be58afe58db7ba462229e1ad8c7
Alexander Galazin [Wed, 15 Mar 2017 15:22:52 +0000 (15:22 +0000)]
Use glReadnPixels only if KHR_robustness is supported
am:
d99ba132d9
Change-Id: Icd032ba51a9c2c6141b21083b300e8709ecd7b45
Alexander Galazin [Mon, 6 Mar 2017 18:44:38 +0000 (19:44 +0100)]
Further relax line verification in primitive bbox tests
The original relaxation patch
ba45591407d0207e8ba0634ea5636fd721ed781f
allowed lines to be 1 pixel thinner or thicker compared
to the expected width. Unfortunately it missed the case
of a line with the width of 1 pixel that has extra verification
in the framework. This change covers this gap.
Google bug:
35987764
Change-Id: I193d76ae13738702c9d7361d1957f15ea7600c4f
projects / platform / upstream / VK-GL-CTS.git / log