Mark Wielaard [Sat, 22 Nov 2014 16:33:05 +0000 (17:33 +0100)]
libelf: elf_getphdrnum sanity check the returned phnum result.
The internal __elf_getphdrnum_rdlock might return an inconsistent phnum.
Return a sanitized value, or return an error to users that rely on phnum
to be consistent. That way iterating over all phdrs using elf_getphdr
will return consistent results.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 24 Nov 2014 21:17:51 +0000 (22:17 +0100)]
dwarf.h: Add DW_LANG_C11, DW_LANG_C_plus_plus_11 and DW_LANG_C_plus_plus_14.
The following patch is needed to recognize the new DW_LANG constants
that GCC 5 might emit as implemented by this GCC patch:
https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02852.html
Also added to https://fedorahosted.org/elfutils/wiki/DwarfExtensions
GCC 5 can emit these new DWARFv5 draft language constants. Handle them in
dwarf_aggregate_size and dwarf_getfuncs. Also handle DW_LANG_Go in
dwarf_aggregate_size (lower bound for array is zero for Go).
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 26 Nov 2014 16:51:28 +0000 (17:51 +0100)]
dwarf.h: Add DW_AT_noreturn.
DW_AT_noreturn is added by GCC5 for functions that don't return to their
caller. It is set on a DW_TAG_subprogram for the traditional GNU noreturn
attribute, the C11 _Noreturn keyword or C++11 [[noreturn]] attribute. It
is a new DWARF5 extension. This is a constant only addition to dwarf.h.
No other part of elfutils currently depends on this attribute.
Also added to https://fedorahosted.org/elfutils/wiki/DwarfExtensions
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 18 Nov 2014 09:07:10 +0000 (10:07 +0100)]
libdwfl: Sanity check the symbol table before use.
Make sure the number of symbols reported and the first global fit the data.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 18 Nov 2014 09:01:48 +0000 (10:01 +0100)]
readelf: Fix sanity check of DW_FORM_block length in print_cfa_program
We were checking the reg nr, not the length of the block.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 18 Nov 2014 08:56:01 +0000 (09:56 +0100)]
libelf: Check for overflow in version_xlate elf_cvt_Verdef and elf_cvt_Verneed.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 17 Nov 2014 22:35:28 +0000 (23:35 +0100)]
readelf: When the version chain ends, stop processing the entries.
The version definition, auxiliary version, version dependency and needed
version sections chain information together through "next" fields. When
the "next" field is zero there are no more information entries. Stop
processing when we see zero instead of repeatedly processing the same
entry (at offset zero from the current one).
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 17 Nov 2014 22:15:45 +0000 (23:15 +0100)]
Check elf_strptr didn't fail getting section name.
Since elf_strptr can fail and return NULL we should always check the result
before usage. Debug sections are only handled by section name, so make sure
the name actually exists.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 17 Nov 2014 22:01:34 +0000 (23:01 +0100)]
readelf: Warn if ptr_size is not 4 or 8 bytes.
Just warn and don't call print_cfa_program in that case. Bad things will
happen and the result is mostly bogus.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 16 Nov 2014 23:42:53 +0000 (00:42 +0100)]
libelf: elf_getshdrstrndx cannot use SHN_XINDEX without section headers.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 16 Nov 2014 23:33:36 +0000 (00:33 +0100)]
libelf: Fix handling of (extended) phnum.
If there is no e_phoff e_phnum cannot be trusted. Extended phnum can only
be gotten if we have an actual section table and a shdr for section zero,
Extended phnum can be too large to fit in the file (or a size_t).
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 16 Nov 2014 10:40:08 +0000 (11:40 +0100)]
readelf: Robustify print_cfa_program.
Check block len before calling print_ops.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 16 Nov 2014 10:30:51 +0000 (11:30 +0100)]
gelf_getnote: Check padding overflow.
Since ELF notes need to be properly aligned they can include padding.
Make sure the padding itself and the padding calculation doesn't overflow.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 16 Nov 2014 10:19:29 +0000 (11:19 +0100)]
libelf: getdata check 64bit values correctly on 32bit arch.
On 32bit arches size_t is too small to do size and overflow checks
of 64bit ELF files. Use the actual Elf64 types to make sure checks
on 64bit ELF files are done correctly on 32bit arches.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 14 Nov 2014 20:42:47 +0000 (21:42 +0100)]
readelf: Sanity check CIE unit_length and augmentationlen in debug_frame.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 14 Nov 2014 16:05:08 +0000 (17:05 +0100)]
libelf: gelf_getnote check for offset overflow.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 14 Nov 2014 15:58:36 +0000 (16:58 +0100)]
libdwelf: Check the d_buf actually exists in dwelf_elf_gnu_debuglink.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 14 Nov 2014 11:38:12 +0000 (12:38 +0100)]
libdwfl: dwfl_module_getdwarf.c don't use symtab with bogus sh_entsize.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 14 Nov 2014 11:24:28 +0000 (12:24 +0100)]
readelf: Check def == NULL before use in handle_versym.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 10 Nov 2014 13:49:20 +0000 (14:49 +0100)]
libdwfl: find_dynsym don't assume dynamic linker has adjusted DYNAMIC entries.
commit 037505 "Fix resolving ELF symbols for live PIDs with deleted files"
changed find_dynsym to assume the PT_DYNAMIC entries had been adjusted by
the dynamic linker. That is often a correct assumption when the ELF image
comes from remote memory. But we cannot rely on that. In the case of the
vdso image the DYNAMIC segment has not been adjusted for example.
There is no good way to determine whether the DYNAMIC segment has or
hasn't been adjusted already to the load address by the dynamic linker.
So we just try twice. Once without and if the fails again with assuming
adjustments being applied.
Includes a new vdsosyms testcase that fails on i686 before and succeeds
after the fix.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 13 Nov 2014 14:43:02 +0000 (15:43 +0100)]
libelf: Fix unsigned overflow check in elf_getdata.
Mark Wielaard [Sat, 8 Nov 2014 15:18:34 +0000 (16:18 +0100)]
libelf: Use mempcpy not __mempcpy.
We were using mempcpy everywhere else, only __libelf_next_arhdr_wrlock used
__mempcpy.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 11 Nov 2014 13:10:04 +0000 (14:10 +0100)]
libdw: Fix dwarf_getsrclines.c 32bit compile error.
__libdw_getsrclines should have been marked as internal_function in
both libdwP.h and dwarf_getsrclines.c. Do address_size comparison as
uint8_t to avoid signedness warning.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Petr Machata [Fri, 17 Oct 2014 00:47:15 +0000 (02:47 +0200)]
Test cases for .debug_macro support
Signed-off-by: Petr Machata <pmachata@redhat.com>
Petr Machata [Fri, 17 Oct 2014 00:47:03 +0000 (02:47 +0200)]
Support .debug_macro
- This code is based on the following proposal:
http://www.dwarfstd.org/ShowIssue.php?issue=110722.1
- dwarf_getmacros serves either of .debug_macinfo or .debug_macro
transparently, but if the latter uses opcode 0xff, it bails out with
an error. The reason is that in .debug_macro, 0xff is a custom code
that can mean anything, while in .debug_macinfo there's fixed
semantics associated with 0xff.
- dwarf_getmacros_off is a new interface used for requesting iteration
through transparently included units.
- dwarf_macro_getparamcnt and dwarf_macro_param are new interfaces
used for requesting number of parameters of an opcode and individual
parameters. dwarf_macro_getsrcfiles is a new interface used for
requesting a file part of .debug_line unit associated with macro
unit that the opcode comes from.
- The existing interfaces dwarf_macro_opcode, dwarf_macro_param1 and
dwarf_macro_param2 remain operational for old- as well as new-style
Dwarf macro sections, if applicable.
- dwarf_getsrclines was made into a light wrapper around a worker
function that loads line unit given its offset. The worker also
caches loaded units in an offset-keyed search tree, so that we don't
end up re-reading units even though they were read in a different
domain (e.g. a macro unit request can prime cache for later CU
lookup). dwarf_macro_getsrcfiles calls the worker function under
covers.
Signed-off-by: Petr Machata <pmachata@redhat.com>
Mark Wielaard [Sat, 8 Nov 2014 13:04:27 +0000 (14:04 +0100)]
readelf.c (handle_versym): Initialize vername and filename array elements.
We check whether the elements are set before printing their contents,
but didn't make sure they were initialized.
Reported-by: Hanno Böck <hanno@hboeck.de>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 7 Nov 2014 11:54:02 +0000 (12:54 +0100)]
readelf: Sanity check hash section contents before processing.
Reported by: Hanno Böck <hanno@hboeck.de>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 7 Nov 2014 11:47:16 +0000 (12:47 +0100)]
libelf: Correct shdr size check for (raw) getdata.
Reported-by: Hanno Böck <hanno@hboeck.de>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 6 Oct 2014 20:00:16 +0000 (22:00 +0200)]
libdw: Add dwarf_peel_type. Use it in dwarf_aggregate_size.
Add new function dwarf_peel_type. Some type annotations in DWARF are
specified by modifier tag type wrappers instead of attributes.
For type aliases (typedef) and qualifiers (const, volatile, restrict)
tags dwarf_peel_type follows the DW_AT_type attributes till it finds
a base, user-defined, reference or pointer type DIE.
Use this new function in the backends for return type DIEs (replacing
the existing dwarf_peel_type there) and in dwarf_aggregate_size so
it can provide the sizes for qualified types too. Add a new version
and testcase for the new dwarf_aggregate_size functionality.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Petr Machata [Wed, 15 Oct 2014 17:28:08 +0000 (19:28 +0200)]
Drop unused field struct Dwarf_Files_s.cu
Signed-off-by: Petr Machata <pmachata@redhat.com>
Mark Wielaard [Sun, 5 Oct 2014 15:12:41 +0000 (17:12 +0200)]
dwarf.h: Add DW_AT_GNU_deleted.
DW_AT_GNU_deleted is added by G++ for C++11 deleted special member
functions (= delete;). This is a constant only addition to dwarf.h.
No other part of elfutils currently depends on this attribute.
Also added to https://fedorahosted.org/elfutils/wiki/DwarfExtensions
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 2 Oct 2014 20:53:44 +0000 (22:53 +0200)]
tests: run-deleted.sh unset VALGRIND_CMD before running deleted.
We don't want to run the deleted test process under valgrind then
eu-stack will see the valgrind process backtrace.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 2 Oct 2014 12:00:47 +0000 (14:00 +0200)]
libdw: dwarf_aggregate_size return CU address_size for sizeless pointer/refs.
Tested-by: Conrad Meyer <cse.cem@gmail.com>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Jan Kratochvil [Fri, 26 Sep 2014 20:42:19 +0000 (22:42 +0200)]
Support note NT_FILE for locating files.
Martin Milata:
------------------------------------------------------------------------------
RFE: dwfl_core_file_report: use NT_FILE core note if the link_map chain is broken
https://bugzilla.redhat.com/show_bug.cgi?id=1129777
The dwfl_core_file_report function follows dynamic linker's link_map chain in
order to determine the shared libraries used by the executable. As this data
structure is located in writable memory it can be overwritten by garbage, which
is sometimes the case.
https://github.com/abrt/satyr/issues/127#issuecomment-
46957546
Since version 3.7 (commit
2aa362c49), Linux kernel adds NT_FILE note to core
files which contains the files mapped by the process, including shared
libraries.
------------------------------------------------------------------------------
dwfl_core_file_report now tries to fall back on NT_FILE if the link_map chain
is broken.
elfutils would already find the appropriate binary file from
/usr/lib/debug/.build-id/ symbolic links. But those symbolic links do not have
to be present on the system while NT_FILE still points to the correct binaries.
Filenames from the note NT_FILE are used only if link_map filenames failed to
locate matching binaries.
tests/test-core.core.bz2 had to have its NT_FILE disabled as run-unstrip-n.sh
otherwise FAILs:
FAIL: 0x7f67f2aaf000+0x202000 - . - /home/jkratoch/redhat/elfutils-libregr/test-core-lib.so
PASS: 0x7f67f2aaf000+0x202000 - . - test-core-lib.so
As test-core-lib.so is found in link_map but it is not present on the disk
elfutils now chooses the more reliable filename from NT_FILE (although that
filename is also not found on the disk). Updating the expected text would be
also sufficient.
libdwfl/
2014-09-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Support NT_FILE for locating files.
* core-file.c (dwfl_core_file_report): New variables note_file and
note_file_size, set them and pass them to dwfl_segment_report_module.
* dwfl_segment_report_module.c: Include common.h and fcntl.h.
(buf_has_data, buf_read_ulong, handle_file_note): New functions.
(invalid_elf): New function from code of dwfl_segment_report_module.
(dwfl_segment_report_module): Add parameters note_file and
note_file_size. New variables elf and fd, clean them up in finish.
Move some code to invalid_elf. Call handle_file_note, if it found
a name verify the file by invalid_elf. Protect elf and fd against
cleanup by finish if we found the file for new Dwfl_Module.
* libdwflP.h (dwfl_segment_report_module): Add parameters note_file and
note_file_size.
tests/
2014-09-26 Jan Kratochvil <jan.kratochvil@redhat.com>
Support NT_FILE for locating files.
* Makefile.am (TESTS): Add run-linkmap-cut.sh.
(EXTRA_DIST): Add run-linkmap-cut.sh, linkmap-cut-lib.so.bz2,
linkmap-cut.bz2 and linkmap-cut.core.bz2 .
* linkmap-cut-lib.so.bz2: New file.
* linkmap-cut.bz2: New file.
* linkmap-cut.core.bz2: New file.
* run-linkmap-cut.sh: New file.
* run-unstrip-n.sh: Update its expected output.
Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
Mark Wielaard [Tue, 23 Sep 2014 19:31:42 +0000 (21:31 +0200)]
libdwfl: dwfl_segment_report_module use ei_class, ei_data and e_type.
To make it easier to see that the code is using the correct fields of
the ehdr e32/e64 union extract ei_class, ei_data and e_type early and
use them directly.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Petr Machata [Sat, 13 Sep 2014 22:47:42 +0000 (00:47 +0200)]
readelf: Fix typo in a check in handle_relocs_rela
- Testing shdr makes no sense, that pointer was dereferenced several
times throughout the section. destshdr on the other hand is not
tested at all.
Signed-off-by: Petr Machata <pmachata@redhat.com>
Jan Kratochvil [Tue, 9 Sep 2014 20:58:26 +0000 (22:58 +0200)]
Add is_executable to Dwfl_Module.
Next patch will find module names from NT_FILE note so that main executable
will no longer necessarily have the name "[exe]" or "[pie]".
-e|--executable still should be able to override such module.
libdwfl/
2014-09-18 Jan Kratochvil <jan.kratochvil@redhat.com>
* dwfl_build_id_find_elf.c (dwfl_build_id_find_elf): Use IS_EXECUTABLE.
* dwfl_segment_report_module.c (dwfl_segment_report_module): Set
IS_EXECUTABLE.
* libdwflP.h (struct Dwfl_Module): New field is_executable.
Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
Petr Machata [Fri, 12 Sep 2014 17:03:33 +0000 (19:03 +0200)]
Rename read_ubyte_unaligned_inc to read_addr_unaligned_inc
- The behavior of this function has been changed to read only
address-sized quantities, i.e. the size of 2 is no longer allowed.
(Size of 1 never was.) The two outstanding uses, both in readelf.c,
which actually do use this call to read address-sized units, were
updated, rejecting fields that indicate weird address sizes.
- The three related calls, read_sbyte_unaligned_inc,
read_ubyte_unaligned and read_sbyte_unaligned were dropped. There
are currently no uses for these calls.
Signed-off-by: Petr Machata <pmachata@redhat.com>
Petr Machata [Wed, 10 Sep 2014 20:26:28 +0000 (22:26 +0200)]
Accept DW_AT_GNU_call_site_* as attributes that hold location expressions
- These are extension attributes that correspond in behavior to
attributes described in this proposal:
http://www.dwarfstd.org/ShowIssue.php?issue=100909.2
- N.B.: DW_AT_call_site_data_location doesn't have a DW_AT_GNU_*
counterpart.
Signed-off-by: Petr Machata <pmachata@redhat.com>
Petr Machata [Wed, 10 Sep 2014 20:25:35 +0000 (22:25 +0200)]
elf_begin sets elf_errno for cases that the file is completely unreadable
- The problem this is trying to solve can be seen for example thus:
$ eu-readelf -a /
eu-readelf: failed reading '/': (null)
With the fix we see a proper error number and get a reasonable error
message:
$ eu-readelf -a /
eu-readelf: failed reading '/': invalid file descriptor
Signed-off-by: Petr Machata <pmachata@redhat.com>
Jan Kratochvil [Sun, 17 Aug 2014 16:49:36 +0000 (18:49 +0200)]
Fix resolving ELF symbols for live PIDs with deleted files
For deleted shared library files the offsets to the symbol table were
calculated wrongly from the phdrs because the main_bias wasn't taken into
account.
Formerly shared libraries did not get resolved properly:
#2 0x00007fc4d86c56d6
#3 0x0000000000400938 main
Fixed elfutils produce:
#2 0x00007f61094876d6 libfunc
#3 0x0000000000400938 main
Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
Josh Stone [Mon, 25 Aug 2014 21:40:35 +0000 (14:40 -0700)]
Prevent premature @AR@ replacement in a sed expression.
The Makefile rule for make-debug-archive has a sed expression to replace
@AR@ will the installed name, but this was itself getting replaced when
the Makefile was configured, for a pattern like "s,ar,/path/prefix-,g".
Havoc ensued in the resulting make-debug-archive.
The fix matches it using a regex bracket expression, "[@]AR[@]", so sed
will still match it, but it's immune to configure's replacement.
Signed-off-by: Josh Stone <jistone@redhat.com>
Mark Wielaard [Mon, 25 Aug 2014 20:13:57 +0000 (22:13 +0200)]
Prepare 0.160 release.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 15 Aug 2014 14:03:21 +0000 (16:03 +0200)]
libdw: Add new function dwarf_cu_die.
Given a Dwarf_Die or Dwarf_Attribute it is often convenient to get at the
CU DIE and the CU header information. There is dwarf_diecu but that doesn't
provide all information from the header and it doesn't work for attributes.
Add a new dwarf_cu_die function that provides all information given a
Dwarf_CU, which both Dwarf_Die and Dwarf_Attribute reference.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 15 Aug 2014 11:08:24 +0000 (13:08 +0200)]
libdw: Add new function dwarf_cu_getdwarf.
In both systemtap and libabigail there is a need to get the actual Dwarf
underlying an Dwarf_Die or Dwarf_Attribute. Following a DIE reference
might end up in an alternate Dwarf since the addition of DWZ multifile
forms. Both Dwarf_Die and Dwarf_Attribute already contain a Dwarf_CU
handle. Add a function dwarf_cu_getdwarf to retrieve the underlying
Dwarf using the Dwarf_CU.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 14 Aug 2014 20:07:44 +0000 (22:07 +0200)]
libdwfl: Handle LZMA .ko.xz compressed kernel modules.
Linux kernel modules can not just be compressed with gz and bz2, but also
with xz.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Kyle McMartin [Mon, 9 Jun 2014 19:06:26 +0000 (21:06 +0200)]
aarch64: use <sys/user.h> defined register structures
glibc now supplies these (compatible) structs instead of including the
kernel's <asm/ptrace.h> header, so let's use them. Annoyingly this will
cause new elfutils to FTBFS on old glibc, and vice versa. So include a
new configure check for the new struct names and use the old ones if
they are not avilable.
Signed-off-by: Kyle McMartin <kyle@redhat.com>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Jan Kratochvil [Thu, 24 Jul 2014 18:47:17 +0000 (20:47 +0200)]
Fix report_r_debug for prelinked libraries
Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>
Mark Wielaard [Mon, 14 Jul 2014 12:34:15 +0000 (14:34 +0200)]
m4: Handle cross-compile situations in biarch.m4 tests.
Reported-by: Leonard Crestez <lcrestez@ixiacom.com>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 4 Jul 2014 12:30:48 +0000 (14:30 +0200)]
Add ppc64le ELFv2 abi support to backends and elflint.
The big endian vs little endian changes are already handled by detecting
the EI_DATA data encoding. And the function descriptors are already not
used when we see there is no .opd section. This change adds new checks
for st_other bits, new relocations and recognizes DT_PPC64_OPT.
Signed-off-by: Menanteau Guy <menantea@linux.vnet.ibm.com>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 4 Jul 2014 11:39:18 +0000 (13:39 +0200)]
Update elf.h from glibc.
Includes new bits needed for ppc64le ELFv2 abi.
https://bugzilla.redhat.com/show_bug.cgi?id=1110249
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 4 Jul 2014 11:26:12 +0000 (13:26 +0200)]
backends: aarch64_return_value_location should handle DW_ATE_boolean.
Found with run-native-test.sh om debian arm64.
http://bugs.debian.org/753552
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Kurt Roeckx [Tue, 24 Jun 2014 20:08:36 +0000 (22:08 +0200)]
Make the attach code build again on non-Linux hosts.
Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Mark Wielaard [Wed, 18 Jun 2014 08:57:58 +0000 (10:57 +0200)]
dwarf.h: Remove non-existing DW_TAG_mutable_type.
The DW_TAG_mutable_type was only mentioned in an early draft of DWARFv3.
But was removed because there are no C++ mutable qualified types. It was
replaced by a new attribute DW_AT_mutable on DW_TAG_member DIEs. The new
attribute is available in dwarf.h.
http://dwarfstd.org/ShowIssue.php?issue=050223.1
DW_TAG_mutable_type was only used internally in some backends (which
just ignored it anyway). dwarves did use it to turn it into a string
value, libabigail used it and ignored it (patches to remove sent).
GCC, GDB and binutils don't use nor define it.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sat, 14 Jun 2014 15:15:37 +0000 (17:15 +0200)]
libebl: Add ebl_func_addr_mask plus ARM backend implementation.
The ARM EABI says that the zero bit of function symbol st_value indicates
whether the symbol points to a THUMB or ARM function. Also the return
value address in an unwind will contain the same extra bit to indicate
whether to return to a regular ARM or THUMB function. Add a new ebl
function to mask off such bits and turn a function value into a function
address so that we get the actual value that a function symbol or return
address points to. It isn't easily possible to reuse the existing
ebl_resolve_sym_value for this purpose, so we end up with another hook
that can be used from dwfl_module_getsym, handle_cfi and elflint.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Petr Machata [Fri, 20 Jun 2014 20:59:43 +0000 (22:59 +0200)]
backends (*_return_value_location): call dwarf_peeled_die_type
... instead of inlining equivalent code.
Signed-off-by: Petr Machata <pmachata@redhat.com>
Mark Wielaard [Sun, 15 Jun 2014 09:35:50 +0000 (11:35 +0200)]
tests/backtrace.c (frame_callback): Error on seeing more than 16 frames.
Don't fill up the test logs with obviously bogus frames.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 13 Jun 2014 23:09:17 +0000 (01:09 +0200)]
tests: backtrace.c accept __libc_do_syscall as first frame symname.
On some architectures (Debian armhl) system calls go through
__libc_do_syscall instead of __kernel_vsyscall. Accept either of
these symbol names for the first backtrace frame.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 13 Jun 2014 23:01:58 +0000 (01:01 +0200)]
tests: backtrace-subr.sh add check_native_unsupported.
The special arm check in check_unsupported should only trigger for native
tests, otherwise on arm various backtrace tests would be skipped that
should work just fine.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 15 Jun 2014 20:14:04 +0000 (22:14 +0200)]
libdwfl: linux-core-attach.c handle possible unaligned data access.
Use libdw/memory-access.h macros read_4ubyte_unaligned_noncvt and
read_8ubyte_unaligned_noncvt to access possibly unaligned data in
core files.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 11 Jun 2014 13:14:23 +0000 (15:14 +0200)]
libdwfl: Record dwfl_attach_state error and return it on failure.
When dwfl_attach_state fails functions that need the process state should
return the error that caused the attach to fail. Use this in the backtrace
test to signal any attach failure. This makes sure that architectures that
don't provide unwinder support get properly detected (and the tests SKIPs)
Also don't assert when trying to attach a non-core ELF file, but return an
error to indicate failure.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 10 Jun 2014 13:09:23 +0000 (15:09 +0200)]
libdwfl: dwfl_standard_argp should not fail when not able to attach Dwfl.
As pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=1107654
commit 191080 introduced a thinko that caused dwfl_standard_argp
to fail if the Dwfl couldn't be attached. Instead of generating a warning
as the comment intended, the failure would be fatal. But even warning
about dwfl_core_file_attach () or dwfl_linux_proc_attach () failing
would be a mistake. The caller/user might not be interested in such
a non-fatal issue. So just ignore if the call failed for whatever reason.
If the caller is interested in warning up front about this issue, then
dwfl_pid () should be called to check the Dwfl is attached. Things should
work just fine for anything that doesn't call any of the dwfl_state related
functions.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 27 May 2014 08:25:27 +0000 (10:25 +0200)]
readelf: Skip section if name is NULL in print_debug.
Don't crash and burn when a section doesn't have a name (possibly invalid
ELF file string table). Just try the next section instead of calling strcmp
on NULL.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 26 May 2014 20:54:38 +0000 (22:54 +0200)]
readelf: Don't print 'for section' when rela section sh_info is zero.
This matches how handle_relocs_rel already printed the header.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 26 May 2014 20:35:30 +0000 (22:35 +0200)]
unstrip: Allow prelinked, but non-split .bss section.
If the section sh_size of the original and undo section are equal then
match them and don't set split_bss. This is also what prelink's
undo_sections allows.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 26 May 2014 19:28:05 +0000 (21:28 +0200)]
unstrip: Add --force to force combining files when ELF headers don't match.
Older versions of GNU binutils strip would drop some ELF header flags.
Causing the main ELF file and the separate .debug file to have mismatched
ELF header fields. Unfortunately some distros are still shipping such files.
eu-unstrip doesn't want to recombine such files. Add a more explicit
explanation which fields don't match and provide a --force, -F flag to
force combining such files anyway (producing a warning).
https://bugzilla.redhat.com/show_bug.cgi?id=698005
https://bugzilla.redhat.com/show_bug.cgi?id=806474
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 20 May 2014 08:44:28 +0000 (10:44 +0200)]
Regenerate *.po files.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 19 May 2014 14:52:56 +0000 (16:52 +0200)]
backends: Add ebl_check_reloc_target_type.
And implement for arm and ia64. Both have special section types that
are valid targets for a reloc. Both refer to unwind data. elflint now
just calls ebl_check_reloc_target_type instead of hard coding the
expected section types.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sun, 18 May 2014 20:41:19 +0000 (22:41 +0200)]
tests: Don't use static functions in testfile-backtrace-demangle.
Compilers and demanglers might treat local/static functions different
between versions. In particular g++ 4.1.2 and libstdc++ mangle and
demangle the static void cxxfunc (int i) function as _Z7cxxfunci.
While g++ 4.8.2 and libstdc++ mangle and demangle it as _ZL7cxxfunci.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Sat, 17 May 2014 22:28:26 +0000 (00:28 +0200)]
Prepare 0.159 release.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 15 May 2014 14:03:59 +0000 (16:03 +0200)]
libdwfl: Don't leak fd on error in linux-proc-maps.c (grovel_auxv).
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Fri, 2 May 2014 22:23:06 +0000 (00:23 +0200)]
Remove --enable-dwz. dwz alt debug is no longer experimental.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 1 May 2014 12:48:27 +0000 (14:48 +0200)]
libdwfl: Move dwz alt multi file searching to find_debuginfo callback.
Don't hard code the Dwarf dwz alt multi file search but allow the user
to override it through the standard Dwfl_Callbacks. Also move ownership
completely to the user of dwarf_setalt by removing free_alt from Dwarf
and adding alt, fd and elf fields to Dwfl_Module. Add a relative .dwz
file test case.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 30 Apr 2014 21:00:40 +0000 (23:00 +0200)]
libdwelf: Add dwelf_elf_gnu_build_id.
Move internal function __libdwfl_find_build_id to libdwelf and use it to
add a public dwelf_elf_gnu_build_id function to extract the NT_GNU_BUILD_ID
from an ELF file using either the shdrs or phdrs. Adjust internal callers
and add a testcase.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Florian Weimer [Tue, 15 Apr 2014 15:11:17 +0000 (17:11 +0200)]
Move .gnu_debugaltlink handling from libdw to libdwfl
Also use dwelf_dwarf_gnu_debugaltlink to locate the alternate debugging
information.
Signed-off-by: Florian Weimer <fweimer@redhat.com>
Florian Weimer [Tue, 15 Apr 2014 14:58:39 +0000 (16:58 +0200)]
tests/allfcts.c: Install alternate debug information
This change also adds more error checking and reporting.
Signed-off-by: Florian Weimer <fweimer@redhat.com>
Florian Weimer [Thu, 24 Apr 2014 12:06:43 +0000 (14:06 +0200)]
libdwelf: Add dwelf_dwarf_gnu_debugaltlink
Signed-off-by: Florian Weimer <fweimer@redhat.com>
Florian Weimer [Tue, 15 Apr 2014 12:31:55 +0000 (14:31 +0200)]
libdw: Add dwarf_getalt, dwarf_setalt
Signed-off-by: Florian Weimer <fweimer@redhat.com>
Florian Weimer [Tue, 15 Apr 2014 12:04:19 +0000 (14:04 +0200)]
dwarf_elf_begin: Add .gnu_debugaltlink to the sectiondata array
And use it if DWZ mode is enabled.
Signed-off-by: Florian Weimer <fweimer@redhat.com>
Mark Wielaard [Fri, 11 Apr 2014 21:52:47 +0000 (23:52 +0200)]
libdwelf: New DWARF ELF Low-level Functions. Add dwelf_elf_gnu_debuglink.
New public header elfutils/libdwelf.h for low-level DWARF/ELF helper
functions. The new function dwelf_elf_gnu_debuglink returns the name and
crc as found in the .gnu_debuglink section of an ELF file.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 22 Apr 2014 21:26:34 +0000 (23:26 +0200)]
readelf: handle_core_item make sure variable length array isn't zero size.
The printed array should have at least space for the terminating zero char.
Found by gcc -fsanitize=undefined while running run-readelf-vmcoreinfo.sh.
runtime error: variable length array bound evaluates to non-positive value 0
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 22 Apr 2014 20:52:06 +0000 (22:52 +0200)]
libdwfl: __libdwfl_frame_reg_[gs]et use uint64_t when checking bits.
Found by gcc -fsanitize=undefined while running the backtrace-core-ppc test.
runtime error: shift exponent 45 is too large for 32-bit type 'unsigned int'
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 22 Apr 2014 20:23:18 +0000 (22:23 +0200)]
readelf.c (print_gdb_index_section): Use unsigned int for 31 bits left shift.
Found by gcc -fsanitize=undefined.
left shift of 1 by 31 places cannot be represented in type 'int'
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Tue, 22 Apr 2014 14:43:11 +0000 (16:43 +0200)]
libdw (get_sleb128_step): Remove undefined behavior.
As pointed out by gcc -fsanitize=undefined left shifting a negative value
is undefined. Replace it with a multiplication of the signed value as
suggested by Richard Henderson and Josh Stone.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 23 Apr 2014 07:54:30 +0000 (09:54 +0200)]
tests: run-nm-self.sh use test = not == for string comparisons.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Kurt Roeckx [Tue, 22 Apr 2014 19:46:22 +0000 (21:46 +0200)]
Unwinding is only supported on Linux
Signed-off-by: Kurt Roeckx <kurt@roeckx.be>
Mark Wielaard [Sun, 13 Apr 2014 15:39:57 +0000 (17:39 +0200)]
Remove mudflap build option.
The --enable-mudflap configure build has been broken for 2 years without
anybody apparently noticing. GCC 4.9 removed mudflap support. Before
release we now run make distcheck with valgrind support. Removal of the
mudflap configure option simplifies the build a little.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 9 Apr 2014 20:38:07 +0000 (22:38 +0200)]
readelf: Read the decompressed data when processing .zdebug DWARF sections.
readelf uses libdw to open the Dwarf and read some of the DWARF data.
But it also uses its own parsers to display some of the low-level
unprocessed data. If the DWARF debug section was zlib compressed it
should actually use the decompressed section data from libdw instead
of the raw section data.
Includes a testcase for those sections that couldn't be properly
displayed when compressed before.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Thu, 10 Apr 2014 13:02:53 +0000 (15:02 +0200)]
readelf: convert up to a target long in buf_read_ulong.
Add a i686 corefile test.
Reported-by: Markus Engel <m_engel@cs.uni-kl.de>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 9 Apr 2014 09:48:23 +0000 (11:48 +0200)]
backends: Add aarch64 native and core unwind support.
Add aarch64 backend functions frame_nregs and set_initial_registers_tid.
Mark pc_register in aarch64 prstatus_regs as pc_register.
Add backtrace-core-aarch64 testcase.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 9 Apr 2014 09:33:23 +0000 (11:33 +0200)]
CVE-2014-0172 Check for overflow before calling malloc to uncompress data.
https://bugzilla.redhat.com/show_bug.cgi?id=1085663
Reported-by: Florian Weimer <fweimer@redhat.com>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Jean Pihet [Fri, 28 Mar 2014 14:13:10 +0000 (15:13 +0100)]
backends: add ARM compatible mode to AARCH64
Add the initial register setup for AARCH64 running ARM code (so
called compat mode). This makes 'eu-stack -p' happy on ARM binaries
while running on a AARCH64 kernel.
Signed-off-by: Jean Pihet <jean.pihet@linaro.org>
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 19 Mar 2014 13:41:00 +0000 (14:41 +0100)]
backends: AARCH64_ABS32 and AARCH64_ABS64 are also valid in ET_REL.
This is tested now in a native aarch64 build by tests/run-elflint-self.sh
since we added some .o files to the self tests.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 3 Mar 2014 14:07:31 +0000 (15:07 +0100)]
libdwfl: elf_from_remote_memory only trust shdrs of last file-only segment.
If the last PT_LOAD segment that contains the whole shdrs also extends
the segment in memory beyond the end of file the program might be reusing
the memory space that we expect the shdrs to be in. Don't trust the shdrs
are valid in that case.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Josh Stone [Wed, 12 Mar 2014 01:13:55 +0000 (18:13 -0700)]
libdwfl: test dwflsyms on ET_EXEC with minisymtab
This adds testfilebaxmin, an ET_EXEC binary with .gnu_debugdata that
doesn't match the load address of the main file. A previous bug made
this trigger a kernel heuristic that forces the module to act like
ET_DYN, which makes things like dwfl_module_relocate_address report
relative addresses rather than proper absolute addresses.
For example, before the fix dwflsyms would print:
deregister_tm_clones (0) 0x400430, rel: 0x430 (.text)
Now it properly prints:
deregister_tm_clones (0) 0x400430, rel: 0x400430 (.text)
These new test additions confirm that it's fixed.
Signed-off-by: Josh Stone <jistone@redhat.com>
Josh Stone [Tue, 11 Mar 2014 17:19:28 +0000 (10:19 -0700)]
libdwfl: dwfl_module_getdwarf.c (open_elf) only (re)set mod->e_type once.
As noted in https://sourceware.org/bugzilla/show_bug.cgi?id=16676#c2 for
systemtap, the heuristic used by open_elf to set the kernel Dwfl_Module
type to ET_DYN, even if the underlying ELF file e_type was set to
ET_EXEC, could trigger erroneously for non-kernel/non-main (debug or
aux) files. Make sure we only set the e_type of the module once when
processing the main file (when the phdrs can be trusted).
Mark Wielaard [Tue, 4 Mar 2014 10:27:15 +0000 (11:27 +0100)]
libdwfl: dwfl_linux_proc_find_elf use elf_from_remote_memory for (deleted).
If a module has a "(deleted)" main ELF file, then try to read it from
remote memory if the Dwfl has process state attached by reusing the ptrace
mechanism from linux-pid-attach.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Mon, 3 Mar 2014 10:43:43 +0000 (11:43 +0100)]
libdwfl: elf_from_remote_memory should use pagesize, not p_align.
elf_from_remote_memory would use the actual p_align of the PT_LOAD segments
to calculate the loadbase, end and start of a segment. But the dynamic
loader aligns the segments using the pagesize and only sanity checks the
p_align values. So we should do the same to get accurate segment addresses.
Also fixes a small memory leak in case the ELF image appears to be bad.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Mark Wielaard [Wed, 5 Mar 2014 15:17:54 +0000 (16:17 +0100)]
readelf: Print DW_FORM_sdata values as signed numbers.
Printing DW_FORM_sdata numbers as unsigned values is misleading.
Signed-off-by: Mark Wielaard <mjw@redhat.com>
Jan Kratochvil [Mon, 3 Mar 2014 23:04:27 +0000 (00:04 +0100)]
Fix abort() on missing section headers.
libdw/
2014-03-03 Jan Kratochvil <jan.kratochvil@redhat.com>
Fix abort() on missing section headers.
* dwarf_begin_elf.c (check_section): Replace abort call by goto err.
New label err to return NULL.
Signed-off-by: Jan Kratochvil <jan.kratochvil@redhat.com>