platform/upstream/dotnet/runtime.git
5 years agoCondition failing test on Nano (dotnet/corefx#39403)
Viktor Hofer [Thu, 11 Jul 2019 20:41:14 +0000 (22:41 +0200)]
Condition failing test on Nano (dotnet/corefx#39403)

Commit migrated from https://github.com/dotnet/corefx/commit/bd30a3f458b6b0f71204fc3630b2d29b780c4167

5 years agoSeveral additional HttpStress improvements (dotnet/corefx#39388)
Stephen Toub [Thu, 11 Jul 2019 17:02:38 +0000 (13:02 -0400)]
Several additional HttpStress improvements (dotnet/corefx#39388)

- Enable HTTP/1.1 and HTTP/2 to be used concurrently
- Fix duplex tests now that only custom content may be duplex
- Add option to set pooled connection lifetime to stress connection management
- Add client operation for reading portion of response and throwing the rest away

Commit migrated from https://github.com/dotnet/corefx/commit/88ab17433f45c37e4e28e2bb6dce3c74aea81c0d

5 years agoClean up Timer tests (dotnet/corefx#39333)
Stephen Toub [Thu, 11 Jul 2019 15:55:30 +0000 (11:55 -0400)]
Clean up Timer tests (dotnet/corefx#39333)

- Add argument names to Assert.Throws
- Add coverage for some uncovered cases
- Put test classes in namespaces
- Consolidate some tests

Commit migrated from https://github.com/dotnet/corefx/commit/ccf9ccfc38922cfe1c6eaa568e83b09119a2dd6b

5 years agoS.S.C.Pkcs: Make static field initialization order deterministic
Filip Navara [Thu, 11 Jul 2019 15:52:36 +0000 (17:52 +0200)]
S.S.C.Pkcs: Make static field initialization order deterministic

Remove ManagedPkcsPal.Instance to avoid any potential misuse, which solves the cctor ordering problem.

Makes a static method for the reason the ManagedPkcsPal was being directly invoked into.

Commit migrated from https://github.com/dotnet/corefx/commit/014b7bc7c6b70deccef6d9a775852656cc514f5d

5 years agoAdd script to support VS Test Explorer (dotnet/corefx#39358)
Viktor Hofer [Thu, 11 Jul 2019 13:36:38 +0000 (15:36 +0200)]
Add script to support VS Test Explorer (dotnet/corefx#39358)

Commit migrated from https://github.com/dotnet/corefx/commit/08a4e0f6f929a86b7c7bc4558a507b90bf5545ae

5 years agoHttpStress: Use randomized content lengths (dotnet/corefx#39368)
Eirik Tsarpalis [Thu, 11 Jul 2019 12:59:25 +0000 (13:59 +0100)]
HttpStress: Use randomized content lengths (dotnet/corefx#39368)

* HttpStress: use randomized content lengths

Adds pseudo-random content payloads in the http stress test harness.
All random data derives from a single seed which can be optionally specified at the CLI.

* address feedback

* Remove dead code

Commit migrated from https://github.com/dotnet/corefx/commit/e642ef9c661680c3d3eb650e37fb28d82f2fafec

5 years agoRemove stale nullable !s and pragmas (dotnet/corefx#39376)
Stephen Toub [Thu, 11 Jul 2019 12:51:57 +0000 (08:51 -0400)]
Remove stale nullable !s and pragmas (dotnet/corefx#39376)

Also update TODO-NULLABLE comments to be more specific where appropriate.

Commit migrated from https://github.com/dotnet/corefx/commit/1ea12d43e92e9ceb0c28157d81ffd6224cf05706

5 years agoMerge pull request dotnet/corefx#39222 from eiriktsarpalis/fix-ignored-settings-ack
Eirik Tsarpalis [Thu, 11 Jul 2019 11:06:47 +0000 (12:06 +0100)]
Merge pull request dotnet/corefx#39222 from eiriktsarpalis/fix-ignored-settings-ack

Http2LoopbackConnection: Wait for pending ACK before setting up for new ignored settings frames

Commit migrated from https://github.com/dotnet/corefx/commit/a393ffee970c6d962c5830bb1c6fa4c3a3e268a6

5 years agoDisable GCNotificationTests test (dotnet/corefx#39375)
Stephen Toub [Thu, 11 Jul 2019 03:55:22 +0000 (23:55 -0400)]
Disable GCNotificationTests test (dotnet/corefx#39375)

Commit migrated from https://github.com/dotnet/corefx/commit/cb0ade0e10e168873d35d10b9ba118e9bfde029f

5 years agoExclude built-in HttpContent types from duplex with SocketsHttpHandler's HTTP/2 ...
Stephen Toub [Thu, 11 Jul 2019 03:31:30 +0000 (23:31 -0400)]
Exclude built-in HttpContent types from duplex with SocketsHttpHandler's HTTP/2 (dotnet/corefx#39352)

For 3.0:
- Adds an internal virtual AllowDuplex to HttpContent that defaults to true
- Override that on all of our HttpContent-derived types to return false
- SocketsHttpHandler's HTTP/2 implementation checks that, and if it returns false, awaits the sending of the request body as part of SendAsync.

Post-3.0, we'll revisit, likely with public surface area.

Commit migrated from https://github.com/dotnet/corefx/commit/e75dd151c9e5aa94cf33c7c9d14a53180df747dd

5 years agoAdd timer firing test for very long timers (dotnet/corefx#39311)
Stephen Toub [Thu, 11 Jul 2019 03:29:30 +0000 (23:29 -0400)]
Add timer firing test for very long timers (dotnet/corefx#39311)

Commit migrated from https://github.com/dotnet/corefx/commit/1cf1d5d89da25ab2a163aaf760eb5861c7d4875e

5 years agoAdd support for types derived from supported BCL collections (dotnet/corefx#39001)
Layomi Akinrinade [Thu, 11 Jul 2019 02:16:02 +0000 (22:16 -0400)]
Add support for types derived from supported BCL collections (dotnet/corefx#39001)

* Add support for types derived from supported BCL collections

* Fix merge issues

* Re-add commented-out tests

* Address review comments

Commit migrated from https://github.com/dotnet/corefx/commit/6005a1ed7772772e211a962141cb17dfc4e26539

5 years agoAdded CompleteAsync to PipeReader and PipeWriter (dotnet/corefx#39255)
David Fowler [Thu, 11 Jul 2019 01:29:09 +0000 (18:29 -0700)]
Added CompleteAsync to PipeReader and PipeWriter (dotnet/corefx#39255)

* Added CompleteAsync to PipeReader and PipeWriter
- Since the introduction of PipeReader and PipeWriter wrappers over a Stream, we need the ability to asynchronously flush buffered data to the stream on complete. This can happen if GetMemory/Advance is called without calling FlushAsync and today that results in data truncation. This change introuduces a way to asynchronously complete a PipeReader or PipeWriter so that we can flush buffered data asynchronously and also dispose the underlying Stream asynchronously.
- Changed StreamPipeWriter to synchronously write and flush buffered data in Complete and asynchronously write and flush buffered data in CompleteAsync.
- Added some tests.
- The DefaultPipeReader and DefaultPipeWriter don't have this problem so they are using the default implementation (which delegates to the syncrhonous Complete).

Commit migrated from https://github.com/dotnet/corefx/commit/ae79f49a7aa96cc6a8be59bb09b2246150587392

5 years agoFix VB string tests on non-english cultures (dotnet/corefx#39361)
Miha Zupan [Thu, 11 Jul 2019 01:23:32 +0000 (03:23 +0200)]
Fix VB string tests on non-english cultures (dotnet/corefx#39361)

`CurrentUICulture` can be en-US even if the `CurrentCulture` used for number formatting is not.

Commit migrated from https://github.com/dotnet/corefx/commit/d2f78d70ff76f9f25402cd0139bbabe7ec2dac4c

5 years agochecking if empty string is an installed font (dotnet/corefx#39309)
Anirudh Agnihotry [Thu, 11 Jul 2019 00:27:24 +0000 (17:27 -0700)]
checking if empty string is an installed font (dotnet/corefx#39309)

* checking if empty string is an installed font

* Not running font converter tests for netfx and disposing the installed FOnts object

Commit migrated from https://github.com/dotnet/corefx/commit/06f5035b13bd25c05d1d2810de8db81403e86e4f

5 years agoAlign date time parsing with 8601 spec (dotnet/corefx#39187)
Jeremy Kuhne [Wed, 10 Jul 2019 22:19:37 +0000 (15:19 -0700)]
Align date time parsing with 8601 spec (dotnet/corefx#39187)

* Align date time parsing with 8601 spec

- Clarifies what specification pieces we're adhering to
- Reorganize code to expect completely valid UTF-8 sequence
- Add corner cases and fix a few issues
- Restructure parser to attempt to clarify state
- Keep state in struct to avoid passing several parameters

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/1247fa7a193e52bc89bc49c4ba6e44739df2dcee

5 years agomaking test as outerloop (dotnet/corefx#39365)
Anirudh Agnihotry [Wed, 10 Jul 2019 22:16:49 +0000 (15:16 -0700)]
making test as outerloop (dotnet/corefx#39365)

Commit migrated from https://github.com/dotnet/corefx/commit/df2673a2bf08b3d027704ed64f2c4aeedc44d89e

5 years agoRemove System.Reflection.Emit from ApiCompat baselines (dotnet/corefx#39346)
William Godbe [Wed, 10 Jul 2019 22:00:37 +0000 (15:00 -0700)]
Remove System.Reflection.Emit from ApiCompat baselines (dotnet/corefx#39346)

Commit migrated from https://github.com/dotnet/corefx/commit/de3902bb56f1254ec1af4bf7d092fc2c048734cc

5 years agoMarking the test with outerloop attribute (dotnet/corefx#39349)
Anirudh Agnihotry [Wed, 10 Jul 2019 19:58:23 +0000 (12:58 -0700)]
Marking the test with outerloop attribute (dotnet/corefx#39349)

* making the test outerloop

* adding comment

Commit migrated from https://github.com/dotnet/corefx/commit/5e44821bd670530cd2bf1dd330079f6e2d8e5284

5 years agoDelete deadcode identified by the ILLinker update (dotnet/corefx#39347)
Jan Kotas [Wed, 10 Jul 2019 13:41:53 +0000 (06:41 -0700)]
Delete deadcode identified by the ILLinker update (dotnet/corefx#39347)

Commit migrated from https://github.com/dotnet/corefx/commit/1a26c1617216c078e725ed0a697b93e2cc5d3074

5 years ago[master] Update dependencies from dotnet/arcade (dotnet/corefx#39279)
dotnet-maestro[bot] [Wed, 10 Jul 2019 09:52:56 +0000 (11:52 +0200)]
[master] Update dependencies from dotnet/arcade (dotnet/corefx#39279)

* Update dependencies from https://github.com/dotnet/arcade build 20190708.1

- Microsoft.DotNet.XUnitExtensions - 2.4.1-beta.19358.1
- Microsoft.DotNet.XUnitConsoleRunner - 2.5.1-beta.19358.1
- Microsoft.DotNet.VersionTools.Tasks - 1.0.0-beta.19358.1
- Microsoft.DotNet.ApiCompat - 1.0.0-beta.19358.1
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19358.1
- Microsoft.DotNet.Build.Tasks.Configuration - 1.0.0-beta.19358.1
- Microsoft.DotNet.Build.Tasks.Feed - 2.2.0-beta.19358.1
- Microsoft.DotNet.Build.Tasks.Packaging - 1.0.0-beta.19358.1
- Microsoft.DotNet.CodeAnalysis - 1.0.0-beta.19358.1
- Microsoft.DotNet.CoreFxTesting - 1.0.0-beta.19358.1
- Microsoft.DotNet.GenAPI - 1.0.0-beta.19358.1
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19358.1
- Microsoft.DotNet.RemoteExecutor - 1.0.0-beta.19358.1
- Microsoft.DotNet.GenFacades - 1.0.0-beta.19358.1

* Remove code moved to arcade CoreFxTesting

* Disable deps generation on failing projects

* Manual darc update from build '20190709.4'

Commit migrated from https://github.com/dotnet/corefx/commit/dcf1c8f51bcdbd79e08cc672e327d50612690a25

5 years agoFix for System.ComponentModel.Annotations packaging (dotnet/corefx#39184)
Diego Vega [Wed, 10 Jul 2019 03:08:10 +0000 (21:08 -0600)]
Fix for System.ComponentModel.Annotations packaging (dotnet/corefx#39184)

* WIP: Fix for System.ComponentModel.Annotations packaging

We currently build assemblies for multiple targets from this source code. We didn't add conditions when we added new types to the API, which resulted in the .NET Standard assemblies containing types that are not implemented in all compliant platforms. This is tracked by dotnet/corefx#38849.

Whith this change, we are switching to harvesting assemblies from the previous stable package for older targets like .NET Standard 2.0 and .NET Framework, and just build the library for .NET Core 3.0 and .NET Standard 2.1.

* Eric's feedback

* Attempt to fix UAP

* Attempting different fix for UAP

Bring back UAP InboxOnTargetFramework entry and removing from suppressions.

* Yet another attempt to fix UAP

The exception message mentions uap10.0.16300, which has a separate assembly version in the baseline package index.

* Backing out attempts to fix UAP

* I believe this is the right fix for UAP

Fingers crossed

Commit migrated from https://github.com/dotnet/corefx/commit/aef8ed681c53f0e04733878e240c072036dd6679

5 years agoChange pipe options defaults to be -1 (dotnet/corefx#39338)
Stephen Toub [Wed, 10 Jul 2019 02:18:03 +0000 (22:18 -0400)]
Change pipe options defaults to be -1 (dotnet/corefx#39338)

* Change pipe options defaults to be -1

* Update PipeOptionsTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/9bf9ae013134c6ff88fd905bd13fe07da96b66b4

5 years agoPort of the VB Financial module (dotnet/corefx#31181) (dotnet/corefx#39147)
Edison Henrique Andreassy [Wed, 10 Jul 2019 00:49:48 +0000 (21:49 -0300)]
Port of the VB Financial module (dotnet/corefx#31181) (dotnet/corefx#39147)

* Port of the VB Financial module (dotnet/corefx#31181)

* Added more tests for the Financial module

* Skip some tests on alpine

Commit migrated from https://github.com/dotnet/corefx/commit/b6edaf0ac1ca42b48fd6c836f9bb472090d832a8

5 years agoBinplace dotnet sdk folder (dotnet/corefx#39291)
Viktor Hofer [Tue, 9 Jul 2019 21:44:46 +0000 (23:44 +0200)]
Binplace dotnet sdk folder (dotnet/corefx#39291)

Commit migrated from https://github.com/dotnet/corefx/commit/75ae0a9a0ccf29854080ee0fecc1f54f69a65b56

5 years agoReduce JIT and type load overhead in WinForms startup (dotnet/corefx#39315)
Michal Strehovský [Tue, 9 Jul 2019 21:37:53 +0000 (23:37 +0200)]
Reduce JIT and type load overhead in WinForms startup (dotnet/corefx#39315)

https://github.com/dotnet/corefx/pull/37853#discussion_r300974699

The existing code was trading startup perf for throughput in a codepath that is unlikely to be executed commonly. The common scenario is that the `UserPreferencesChanging` event is not fired for the entire lifetime of the app (I left an app listening for this event running for an hour of normal work and never once was the event fired. I then changed system colors to force it).

To set up the high performance path, we have to load two unique `Func` instantiations and JIT a generic method. It's likely the throughput optimization won't pay for itself in terms of CPU cycles even if someone does change quite a few settings.

Commit migrated from https://github.com/dotnet/corefx/commit/3c37204d825c567ead19d8b2d9513efca25dd7c8

5 years agoDon't close connection for responses to session based authentication and 100-Continue...
Tomas Weinfurt [Tue, 9 Jul 2019 19:25:14 +0000 (21:25 +0200)]
Don't close connection for responses to session based authentication and 100-Continue (dotnet/corefx#38744)

* don't close connection for responses to session based authenticatin

* move sendRequestContentTask

* feedback from review

Commit migrated from https://github.com/dotnet/corefx/commit/2e73965a126946afc986175fd667ce3c31f03731

5 years agoFix param name in System.Collllections that slipped through when adding nullable...
Santiago Fernandez Madero [Tue, 9 Jul 2019 18:50:33 +0000 (11:50 -0700)]
Fix param name in System.Collllections that slipped through when adding nullable annotations (dotnet/corefx#39305)

Commit migrated from https://github.com/dotnet/corefx/commit/3293517906c213293201ced602bb49d90d20ad39

5 years agoFixing issue happenning on very large zip files (dotnet/corefx#39099)
buyaa-n [Tue, 9 Jul 2019 16:49:17 +0000 (09:49 -0700)]
Fixing issue happenning on very large zip files (dotnet/corefx#39099)

Fixing issue happenning on very large zip files dotnet/corefx#39099

Commit migrated from https://github.com/dotnet/corefx/commit/78589e4d2c98bf71cefa4dbc94cde3783b60a934

5 years agoDisable TaskDropsExecutionContextUponCompletion test
Stephen Toub [Tue, 9 Jul 2019 12:42:16 +0000 (08:42 -0400)]
Disable TaskDropsExecutionContextUponCompletion test

Commit migrated from https://github.com/dotnet/corefx/commit/01e6dd5a99c8134f7c585758b8e0a71f2120728a

5 years agoDisable AsyncMethodsDropsStateMachineAndExecutionContextUponCompletion test
Stephen Toub [Tue, 9 Jul 2019 12:41:12 +0000 (08:41 -0400)]
Disable AsyncMethodsDropsStateMachineAndExecutionContextUponCompletion test

Commit migrated from https://github.com/dotnet/corefx/commit/9f9b7c0930e8c8fcd9696410ce2bd0dbc9ac37ab

5 years agoAdd RIDs for released/releasing OS/Distro versions
Jeremy Barton [Tue, 9 Jul 2019 03:11:30 +0000 (20:11 -0700)]
Add RIDs for released/releasing OS/Distro versions

* Alpine 3.10 just released
* Alpine 3.11 has a project page with a projected 4 month due date
* FreeBSD 11.3 is imminent

Not added:

* CentOS has a project page for CentOS 8 but it's still described as ambiguous future
* Oracle Linux 8.1 isn't being added to mirror RHEL 8.1 because OL 8.0 has not yet released

Commit migrated from https://github.com/dotnet/corefx/commit/00e9443746b9e2d022a09d70d11d6ee2acd2a341

5 years agoUpdate APICompat baselines
wtgodbe [Mon, 8 Jul 2019 19:24:15 +0000 (12:24 -0700)]
Update APICompat baselines

Commit migrated from https://github.com/dotnet/corefx/commit/50de5595f53213990c245accce6b933a1589cbb9

5 years agoDon't recheck for attributes if the path is too long (dotnet/corefx#39299)
Jeremy Kuhne [Tue, 9 Jul 2019 03:05:26 +0000 (20:05 -0700)]
Don't recheck for attributes if the path is too long (dotnet/corefx#39299)

One of our existing tests hits this on some machines. There is no point in retrying if the path is too long and we don't want to add it to the assert either.

Fixes dotnet/corefx#39048

Commit migrated from https://github.com/dotnet/corefx/commit/af2e995a851fe0d218b8c9d17e08b0802150b102

5 years agoUse Uri.OriginalString when serializing (dotnet/corefx#39015)
Jeremy Kuhne [Mon, 8 Jul 2019 21:06:56 +0000 (14:06 -0700)]
Use Uri.OriginalString when serializing (dotnet/corefx#39015)

* Use Uri.OriginalString when serializing

We want to be lossless if possible when round tripping (outside of escaping). To do so we need to write OriginalString instead of using ToString().

Removing pending issue reference as it was closed (we won't be adding a Uri parser to the reader).

Add user reported scenario.

* Address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/398dc98e66b1fa59d67e7977a667b95c5e5f5135

5 years agoFix inconsistent behavior in VersionConverter and UriTypeConverter with full framewor...
Roman Marusyk [Mon, 8 Jul 2019 17:08:37 +0000 (20:08 +0300)]
Fix inconsistent behavior in VersionConverter and UriTypeConverter with full framework (dotnet/corefx#39203)

* Fix inconsistent behavior in VersionConverter and UriTypeConverter with full framework

* Add test cases

* Add using

Commit migrated from https://github.com/dotnet/corefx/commit/ed5b558c8637dc9628ff62322784975238baaf88

5 years agoFix p/invoke declaration of GetUserObjectInformationW (dotnet/corefx#39285)
Michal Strehovský [Mon, 8 Jul 2019 16:20:04 +0000 (18:20 +0200)]
Fix p/invoke declaration of GetUserObjectInformationW (dotnet/corefx#39285)

Port of dotnet/winformsdotnet/corefx#1247.

Commit migrated from https://github.com/dotnet/corefx/commit/7d4b620cf7bcda28ed276c00e27def9d42e06c7c

5 years agoRename JsonCamelCaseNamePolicy -> JsonCamelCaseNamingPolicy (dotnet/corefx#39273)
Roman Marusyk [Mon, 8 Jul 2019 13:01:19 +0000 (16:01 +0300)]
Rename JsonCamelCaseNamePolicy -> JsonCamelCaseNamingPolicy (dotnet/corefx#39273)

Commit migrated from https://github.com/dotnet/corefx/commit/9f2cd6683e7488773c18f6fa2017ab181ba2cdcd

5 years agomake ExpectSettingsAck timeout parameter optional
Eirik Tsarpalis [Mon, 8 Jul 2019 09:21:25 +0000 (10:21 +0100)]
make ExpectSettingsAck timeout parameter optional

Commit migrated from https://github.com/dotnet/corefx/commit/5787e8ec90207b400e4f9fc13cd51a31fb48adfc

5 years agoEnsure BitArray unsafe accesses are within bounds (dotnet/corefx#39270)
Stephen Toub [Mon, 8 Jul 2019 03:00:23 +0000 (23:00 -0400)]
Ensure BitArray unsafe accesses are within bounds (dotnet/corefx#39270)

To avoid any potential issues that could arise from concurrent mutation of a BitArray while its doing unsafe processing (e.g. one thread calling And/Or/Xor while another thread resizes the BitArray via set_Length), this changes the implementations that use unsafe code to operate on a local snapshot that's fully validated locally.

Commit migrated from https://github.com/dotnet/corefx/commit/3b426f78a3aab1a45f797ac22e70fd203165d810

5 years agoDisable ConnectAsync_AddHostHeader_Success test (dotnet/corefx#39272)
Stephen Toub [Sun, 7 Jul 2019 22:17:19 +0000 (18:17 -0400)]
Disable ConnectAsync_AddHostHeader_Success test (dotnet/corefx#39272)

Commit migrated from https://github.com/dotnet/corefx/commit/480727f253bbe53bd94376830f3d4e645ee90ed0

5 years agoDon't force flush for data packets in SocketsHttpHandler HTTP/2 (dotnet/corefx#39236)
Stephen Toub [Sat, 6 Jul 2019 22:45:11 +0000 (18:45 -0400)]
Don't force flush for data packets in SocketsHttpHandler HTTP/2 (dotnet/corefx#39236)

* Don't force flush for data packets in SocketsHttpHandler HTTP/2

Allow the write stream to request a flush via FlushAsync, but don't internally force a flush on each data packet.

* Address PR feedback

Also tweak use of ArrayBuffer.ActiveSpan/Memory.Length to just ArrayBuffer.ActiveLength.

Commit migrated from https://github.com/dotnet/corefx/commit/15abdfc3816352c64098735b79a98dd97524ee36

5 years agoFix System.Diagnostics.Process failures with disabled Remote Registry service (dotnet...
Jan Kotas [Sat, 6 Jul 2019 20:46:32 +0000 (13:46 -0700)]
Fix System.Diagnostics.Process failures with disabled Remote Registry service (dotnet/corefx#39215)

* Fix System.Diagnostics.Process failures with disabled Remote Registry service

* Make the test more similar to other tests that depend on performance counters

Commit migrated from https://github.com/dotnet/corefx/commit/da2cf2d7e6976b13cbc24eb9ae7d98b630dd3be3

5 years agoRemove unused code from Linux crypto shim
Jeremy Barton [Sat, 6 Jul 2019 02:47:55 +0000 (19:47 -0700)]
Remove unused code from Linux crypto shim

* Remove uncalled methods in Interop.Crypto and clean using-imports

* Remove uncalled DLLEXPORT functions and their now-unused portable funcs.

Remove unused code from the crypto shim so that we don't pay a maintenance cost on it going forward.

Some functions have just fallen out of use slowly, others were shifts that left the old version intact just-in-case.

* Pass 1: For each file in the cryptoshim Interop directory (from X509Certificates, Algorithms, Encoding, and System.Net.Security) delete any methods that are uncalled.
* Pass 2: Delete anything in the shim that was abandoned by pass 1
Be surprised at things like CryptoNative_DsaCreate, which had a DllImport and a .h declaration, but no body.
* Pass 3: grep DLLEXPORT *.h, delete anything that is not mapped to by a DllImport
* Pass 4: Delete any function pointers that get bound during the portable build load but are no longer used (by this change)

It was less removal than anticipated. No audit was done that each function pointer that's bound is actually still used (other than the ones that had a usage reduced in this change); it felt less valuable per unit of time expended.

Commit migrated from https://github.com/dotnet/corefx/commit/6c6d68558aaccbd16de6e84cf7e59c0fb32b8273

5 years agoAdd RHEL 8.1 runtime id to the runtime id graph
Omair Majid [Fri, 5 Jul 2019 20:58:50 +0000 (16:58 -0400)]
Add RHEL 8.1 runtime id to the runtime id graph

RHEL 8.1 is expected to release around 6 months after RHEL 8.0. That
would put it around Nov 2019. If it follows the RHEL 7 tradition, it
should get identified as 'rhel.8.1`.

Commit migrated from https://github.com/dotnet/corefx/commit/8a02800c1e8002302bcc9340fe59eb8e199c9817

5 years agoEnable XUnit Analyzers (dotnet/corefx#38676)
Viktor Hofer [Fri, 5 Jul 2019 20:50:57 +0000 (22:50 +0200)]
Enable XUnit Analyzers (dotnet/corefx#38676)

* Enable XUnit Analyzers

Commit migrated from https://github.com/dotnet/corefx/commit/b8a7f34e1b64e5c594f591aa8683f34506eb9736

5 years agoFix VisualBasic.Core test failures on non-English locales (dotnet/corefx#39213)
Jan Kotas [Fri, 5 Jul 2019 18:32:38 +0000 (11:32 -0700)]
Fix VisualBasic.Core test failures on non-English locales (dotnet/corefx#39213)

Commit migrated from https://github.com/dotnet/corefx/commit/313ac450b3c07d8c93c5a1de3173d3299971bf38

5 years agoFix wrong outerloop/innerloop variable (dotnet/corefx#39217)
Viktor Hofer [Fri, 5 Jul 2019 18:30:34 +0000 (20:30 +0200)]
Fix wrong outerloop/innerloop variable (dotnet/corefx#39217)

* Fix wrong outerloop/innerloop variable

Commit migrated from https://github.com/dotnet/corefx/commit/1961dbf1672be1d30dd3e9e8cda1e8fad573b70e

5 years agoSmall improvements to HTTP2 testing (dotnet/corefx#39209)
Geoff Kizer [Fri, 5 Jul 2019 18:19:16 +0000 (11:19 -0700)]
Small improvements to HTTP2 testing (dotnet/corefx#39209)

* method tests

* in debug, start with very small buffer sizes to induce buffer growing

Commit migrated from https://github.com/dotnet/corefx/commit/3fdc11c8d4720b6ae361cfa306710d2f20b5536e

5 years agoaddress feedback
Eirik Tsarpalis [Fri, 5 Jul 2019 18:05:40 +0000 (19:05 +0100)]
address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/232e244db3c1c604bbfa03ac268dcf1047ee4491

5 years agoChange Span.Fill(0) call to Span.Clear() instead
Levi Broderick [Fri, 5 Jul 2019 16:41:08 +0000 (09:41 -0700)]
Change Span.Fill(0) call to Span.Clear() instead

Commit migrated from https://github.com/dotnet/corefx/commit/c663f3ff12bcd95c54e9106aee218671d06fd675

5 years agoMove RegionInfo.DisplayName test to outer loop (dotnet/corefx#39212)
Jan Kotas [Fri, 5 Jul 2019 16:22:11 +0000 (09:22 -0700)]
Move RegionInfo.DisplayName test to outer loop (dotnet/corefx#39212)

Commit migrated from https://github.com/dotnet/corefx/commit/6a40a039c1f169c27777bdb7af32b14728897ee8

5 years agoMake the Http2LoopbackConnection.ExpectSettingsAck() method handle outstanding acks...
Eirik Tsarpalis [Fri, 5 Jul 2019 15:55:07 +0000 (16:55 +0100)]
Make the Http2LoopbackConnection.ExpectSettingsAck() method handle outstanding acks more gracefully. Should fix dotnet/corefx#39082

Commit migrated from https://github.com/dotnet/corefx/commit/5458bdac1cc3dd0989d35060b72d83c08499ca53

5 years agoFix and re-enable outerloop test on OLEDB (dotnet/corefx#38024)
Maryam Ariyan [Thu, 4 Jul 2019 18:00:02 +0000 (11:00 -0700)]
Fix and re-enable outerloop test on OLEDB (dotnet/corefx#38024)

Commit migrated from https://github.com/dotnet/corefx/commit/477abf147d8860fae35f975fddafb2711ee42bd4

5 years agoMore cleanup for linker heuristics (dotnet/corefx#39191)
Jan Kotas [Thu, 4 Jul 2019 13:13:46 +0000 (06:13 -0700)]
More cleanup for linker heuristics (dotnet/corefx#39191)

- Deleting dead or unrechable code
- Adding ILLinkTrim.xml files for types and methods accessed via reflection

Commit migrated from https://github.com/dotnet/corefx/commit/0375ae0db48bf5c20b4fbcc5e4ccd5f2e3944cff

5 years agoAdd more options to HttpStress program (dotnet/corefx#39188)
Stephen Toub [Thu, 4 Jul 2019 11:30:25 +0000 (07:30 -0400)]
Add more options to HttpStress program (dotnet/corefx#39188)

- "listOps" option, to see what numbers correspond to which client operations
- New client operation for HEAD
- New client operation for PUT
- New client operation for POST duplex, but that dribbles a byte at a time
- Fixed POST duplex to use ResponseHeadersRead
- Enable HTTP logging to be started to the console during a run

Commit migrated from https://github.com/dotnet/corefx/commit/2f42dde968da92f1c67a91ab7b915af7c63848e5

5 years agoDelete getting-started-core.md
Viktor Hofer [Thu, 4 Jul 2019 07:43:57 +0000 (09:43 +0200)]
Delete getting-started-core.md

Commit migrated from https://github.com/dotnet/corefx/commit/1537f4706cc5155f99c5d2d62e4be0f594dbbf02

5 years agoUpdate windows-instructions.md
Viktor Hofer [Thu, 4 Jul 2019 07:40:31 +0000 (09:40 +0200)]
Update windows-instructions.md

Commit migrated from https://github.com/dotnet/corefx/commit/6a2b0cfad37ff74d7f19524d08b3a1d1e2085e7b

5 years agoDelete net-platform-standard.md
Viktor Hofer [Thu, 4 Jul 2019 07:35:29 +0000 (09:35 +0200)]
Delete net-platform-standard.md

Commit migrated from https://github.com/dotnet/corefx/commit/6efc2d5139538ae107b41b53c7e8d36b5ea14f22

5 years agoUpdate net-core-applications.md
Viktor Hofer [Thu, 4 Jul 2019 07:34:33 +0000 (09:34 +0200)]
Update net-core-applications.md

Commit migrated from https://github.com/dotnet/corefx/commit/3d40dc82597719d802edc9ac95ae84ca320a4ce6

5 years agoDelete advanced-inner-loop-testing.md
Viktor Hofer [Thu, 4 Jul 2019 07:28:25 +0000 (09:28 +0200)]
Delete advanced-inner-loop-testing.md

Remove this doc as it won't work anymore moving forward and the preferred path is to use dotnet.exe and not invoke csc or vbc manually anymore.

Commit migrated from https://github.com/dotnet/corefx/commit/4d6cbe58074bd5edb720071d786fe1772e26b9b1

5 years agoDelete cross-platform-testing.md
Viktor Hofer [Thu, 4 Jul 2019 07:26:58 +0000 (09:26 +0200)]
Delete cross-platform-testing.md

Commit migrated from https://github.com/dotnet/corefx/commit/ab592e49272cbd6a20b521745d6949e53c2d5cd7

5 years agoMake `GetGCMemoryInfo` aware that `MemoryLoadBytes` can decrease after allocating...
Vladimir Sadov [Thu, 4 Jul 2019 02:12:29 +0000 (19:12 -0700)]
Make `GetGCMemoryInfo` aware that `MemoryLoadBytes` can decrease after allocating since it also depends on what other processes are doing. (dotnet/corefx#39183)

Commit migrated from https://github.com/dotnet/corefx/commit/a14c8a3e624bb2cb39616b2fa3a373f0e223ec04

5 years agoAugment HttpStress app to track socket reuse errors (dotnet/corefx#39179)
Stephen Toub [Wed, 3 Jul 2019 23:57:22 +0000 (19:57 -0400)]
Augment HttpStress app to track socket reuse errors (dotnet/corefx#39179)

Commit migrated from https://github.com/dotnet/corefx/commit/b21ca5fddd281f835de98dbe950405bcf9397ac4

5 years agoHide some tests under IsPreciseGcSupported condition (dotnet/corefx#39176)
Egor Bogatov [Wed, 3 Jul 2019 23:53:28 +0000 (02:53 +0300)]
Hide some tests under IsPreciseGcSupported condition (dotnet/corefx#39176)

Commit migrated from https://github.com/dotnet/corefx/commit/9b75a46f6f716f77bb0e904b1cd4dd13aa83f0b9

5 years agoFix EventLog tests on latest Win10 (dotnet/corefx#39182)
Jan Kotas [Wed, 3 Jul 2019 23:53:11 +0000 (16:53 -0700)]
Fix EventLog tests on latest Win10 (dotnet/corefx#39182)

The Security EventLog is ACLed for admin access only. Remove it from the set we look
for to make the test work in regular prompt.

Commit migrated from https://github.com/dotnet/corefx/commit/0d33f64bac69f2527b927c6a0d9d3a571c231aea

5 years agoTemporarily disable `MemoryLoadBytes` scenario in `GetGCMemoryInfo` test (dotnet...
Vladimir Sadov [Wed, 3 Jul 2019 23:52:47 +0000 (16:52 -0700)]
Temporarily disable `MemoryLoadBytes` scenario in `GetGCMemoryInfo` test (dotnet/corefx#39180)

* Temporarily disable `MemoryLoadBytes` scenario in `GetGCMemoryInfo` test

* added a reference to the bug

Commit migrated from https://github.com/dotnet/corefx/commit/29817ea42e841c0df1bf0a96f735956571011163

5 years agoMove XamlAccessLevel to System.Windows.Extensions.dll
Vatsan Madhavan [Wed, 3 Jul 2019 23:27:05 +0000 (16:27 -0700)]
Move XamlAccessLevel to System.Windows.Extensions.dll

WPF needs continued access to XamlAccessLevel type. System.Xaml.Permissions.XamlLoadPermission also needs to use XamlAccessLevel.

WPF is trying to remove its references to System.Security.Permissions. In order to complete this work, XamlAccessLevel is being moved to System.Windows.Extensions.dll (while leaving XamlLoadPermission in System.Permission.dll as-is). This will allow WindowsDesktop.App to bundle System.Windows.Extensions.dll (but not carry System.Security.Permissions.dll).

Commit migrated from https://github.com/dotnet/corefx/commit/758b1bfe0693801c3ac3e1b3b103a3b5e64be14a

5 years agoPrep work for cleaning up linker heuristics (dotnet/corefx#39142)
Jan Kotas [Wed, 3 Jul 2019 23:00:26 +0000 (16:00 -0700)]
Prep work for cleaning up linker heuristics (dotnet/corefx#39142)

- Deleting dead or unrechable code
- Adding ILLinkTrim.xml files for types and methods accessed via reflection

Commit migrated from https://github.com/dotnet/corefx/commit/bc1f6ae4e757251c8691fe94e68617ce1516e684

5 years agoFont converter implementation made similar to netfx (dotnet/corefx#39098)
Anirudh Agnihotry [Wed, 3 Jul 2019 22:59:39 +0000 (15:59 -0700)]
Font converter implementation made similar to netfx (dotnet/corefx#39098)

* Font converter implementation made similar to netfx

* addressing feedback and fixing tests for spanish ci leg

* name changes and checking the paramter name in argument Exception

* fixing netfx failures and removing some redundant code

Commit migrated from https://github.com/dotnet/corefx/commit/9635883cfc69eee3161693715a522ddecca05794

5 years agoCode coverage JsonDocument, JsonElement (dotnet/corefx#39103)
buyaa-n [Wed, 3 Jul 2019 20:35:51 +0000 (13:35 -0700)]
Code coverage JsonDocument, JsonElement (dotnet/corefx#39103)

 Improve coverage, remove unreachable section

Commit migrated from https://github.com/dotnet/corefx/commit/b00b4a5110c209b522fc711e48cd5243b3fb34ec

5 years agoMerge pull request dotnet/corefx#39102 from terrajobst/ns21-baselining
Immo Landwerth [Wed, 3 Jul 2019 18:44:00 +0000 (11:44 -0700)]
Merge pull request dotnet/corefx#39102 from terrajobst/ns21-baselining

Simplify baselining for .NET Standard

Commit migrated from https://github.com/dotnet/corefx/commit/c430820321ac002d5e832867410f3232e703b79d

5 years agoFix argument name & use nameof instead of magic string (dotnet/corefx#39154)
Youssef1313 [Wed, 3 Jul 2019 17:57:56 +0000 (19:57 +0200)]
Fix argument name & use nameof instead of magic string (dotnet/corefx#39154)

* Fix argument name & use nameof instead of magic string

* Update GraphicsTests.cs

Commit migrated from https://github.com/dotnet/corefx/commit/bb7e8b542f5f16ce5497097bbc2b26d77c601dbe

5 years agoEnsure HttpClient.Get*Async helpers wrap IOExceptions (dotnet/corefx#39137)
Stephen Toub [Wed, 3 Jul 2019 17:05:41 +0000 (13:05 -0400)]
Ensure HttpClient.Get*Async helpers wrap IOExceptions (dotnet/corefx#39137)

IOExceptions may emerge from the underlying response streams, but GetString/ByteArrayAsync should throw a wrapper HttpRequestException in this case.

Commit migrated from https://github.com/dotnet/corefx/commit/1c3d001566b0d38c90e074e33d7394d507311956

5 years agoMove CultureInfoConverter to the new test base and fix NRE (dotnet/corefx#38980)
Hugh Bellamy [Wed, 3 Jul 2019 15:38:51 +0000 (16:38 +0100)]
Move CultureInfoConverter to the new test base and fix NRE (dotnet/corefx#38980)

Commit migrated from https://github.com/dotnet/corefx/commit/a9594f72540034902e2bcb2a5187fcdba584cf36

5 years agoAdd MemberDescriptor tests and fix bugs (dotnet/corefx#39066)
Hugh Bellamy [Wed, 3 Jul 2019 15:36:08 +0000 (16:36 +0100)]
Add MemberDescriptor tests and fix bugs (dotnet/corefx#39066)

Commit migrated from https://github.com/dotnet/corefx/commit/f610925aee0ee4ad0586f677815dd0601209560f

5 years agoDisable two Task GC tests for UWP (dotnet/corefx#39157)
Stephen Toub [Wed, 3 Jul 2019 14:37:04 +0000 (10:37 -0400)]
Disable two Task GC tests for UWP (dotnet/corefx#39157)

They're sporadically failing in CI.

Commit migrated from https://github.com/dotnet/corefx/commit/7a9c2ab617229faad613fa5554b298df388f6fb7

5 years agoEnabling GetGCMemoryInfo test (dotnet/corefx#39131)
Vladimir Sadov [Wed, 3 Jul 2019 13:53:20 +0000 (06:53 -0700)]
Enabling GetGCMemoryInfo test (dotnet/corefx#39131)

* enable the test

* additional output to narrow the location of a failure, if happens

* run 1000 times

* revert the "run 1000 times" change

Commit migrated from https://github.com/dotnet/corefx/commit/9d2435f051c59cd30cbfad0fec2f0ab54fc80538

5 years agoFix conflict resolution for design time build (dotnet/corefx#39134)
Santiago Fernandez Madero [Wed, 3 Jul 2019 12:09:16 +0000 (05:09 -0700)]
Fix conflict resolution for design time build (dotnet/corefx#39134)

Commit migrated from https://github.com/dotnet/corefx/commit/7264bc96154f937dd69ff971f6be695de0a13a13

5 years agoFix comments and ellipsis in code examples (dotnet/corefx#39132)
Andrei K [Wed, 3 Jul 2019 04:57:09 +0000 (21:57 -0700)]
Fix comments and ellipsis in code examples (dotnet/corefx#39132)

Fix comments and ellipsis in code examples to make it copy-pasteable.

Commit migrated from https://github.com/dotnet/corefx/commit/1162dfc1b5da79dc29f3d28935b4c96c9d38a743

5 years agoFix DateTimeOffsetConverterTests test (dotnet/corefx#39123)
Stephen Toub [Wed, 3 Jul 2019 04:13:57 +0000 (00:13 -0400)]
Fix DateTimeOffsetConverterTests test (dotnet/corefx#39123)

We're getting a sporadic failure in CI due from a DateTimeOffset TypeConverter test.  I believe the issue is that another test which changes the current culture to fr-FR runs before or concurrently and ends up affecting the test.  I've fixed that test to do the culture change in another process (as is done in every other such test), but just in case that doesn't fix it, I've also augmented the test helper class that represents a test case here to have a ToString that makes the xunit output more debuggable.

Commit migrated from https://github.com/dotnet/corefx/commit/f64f217d7f1ad4acf72b004e848b30c2a2d305a1

5 years agoMerge pull request dotnet/corefx#39107 from geoffkizer/http2exceptionfix
Geoff Kizer [Wed, 3 Jul 2019 03:17:08 +0000 (20:17 -0700)]
Merge pull request dotnet/corefx#39107 from geoffkizer/http2exceptionfix

clean up HTTP2 protocol exception handling

Commit migrated from https://github.com/dotnet/corefx/commit/d0a88cf805724b9a58e272dc3eff8ce45ff48322

5 years agoAvoid extra allocation and interface calls in Append (dotnet/corefx#39045)
Stephen Toub [Wed, 3 Jul 2019 02:53:36 +0000 (22:53 -0400)]
Avoid extra allocation and interface calls in Append (dotnet/corefx#39045)

Commit migrated from https://github.com/dotnet/corefx/commit/2ead5143ce31d6d25089a1f16e9619a374d48d4b

5 years agoStop using EDI.Throw for shared exception objects in HTTP/2 (dotnet/corefx#39135)
Stephen Toub [Wed, 3 Jul 2019 02:34:06 +0000 (22:34 -0400)]
Stop using EDI.Throw for shared exception objects in HTTP/2 (dotnet/corefx#39135)

Commit migrated from https://github.com/dotnet/corefx/commit/4d56f6ddc5ec0901414e161199fe891cfe183e5d

5 years agoaddress feedback
Geoff Kizer [Wed, 3 Jul 2019 00:25:06 +0000 (17:25 -0700)]
address feedback

Commit migrated from https://github.com/dotnet/corefx/commit/490593ffa52cd818a8c0ebeb5298b48b3844237b

5 years agoUpdate HttpStress app to accomodate recent changes (dotnet/corefx#39125)
Stephen Toub [Tue, 2 Jul 2019 21:21:10 +0000 (17:21 -0400)]
Update HttpStress app to accomodate recent changes (dotnet/corefx#39125)

Commit migrated from https://github.com/dotnet/corefx/commit/64310c8da5c631a7271609a3cdbf2b0d58366783

5 years agocorrect sending RST when request body fails (dotnet/corefx#39117)
Tomas Weinfurt [Tue, 2 Jul 2019 21:14:10 +0000 (23:14 +0200)]
correct sending RST when request body fails (dotnet/corefx#39117)

* correct sending RST when request body fails

* move test back to OuterLoop

* remove unnecesary ConfigureAwait()

Commit migrated from https://github.com/dotnet/corefx/commit/26360c82c55c0c8dfc1c358614872b3c160c3bf6

5 years agoFix Ping.Send() to return correct PingReply status (dotnet/corefx#39012)
Cory Nelson [Tue, 2 Jul 2019 18:11:36 +0000 (11:11 -0700)]
Fix Ping.Send() to return correct PingReply status (dotnet/corefx#39012)

Fix Ping.Send() to return valid status rather than throw exception for every non-success result. Regression from Core 2.2. Resolves dotnet/corefx#38770.

Commit migrated from https://github.com/dotnet/corefx/commit/b132f92c28e4c4f696610f48cd9b3afb78b5eff3

5 years agoSystem.Numerics.Vectors: Remove reflection in GenericVectorTests (dotnet/corefx#39095)
Alexander Köplinger [Tue, 2 Jul 2019 17:57:26 +0000 (19:57 +0200)]
System.Numerics.Vectors: Remove reflection in GenericVectorTests (dotnet/corefx#39095)

* System.Numerics.Vectors: Remove reflection in GenericVectorTests

This allows us to use the test with the managed linker enabled in Xamarin.iOS
since it no longer strips out the MaxValue/MinValue fields.

* Fix T4 template to use type aliases instead of type names

The .cs file was changed but the .tt was still using the old style.

Commit migrated from https://github.com/dotnet/corefx/commit/29af4242a751d17c658a36375dce26bff1dd8dd2

5 years agoUpdate issue-guide.md
Tarek Mahmoud Sayed [Tue, 2 Jul 2019 17:45:12 +0000 (10:45 -0700)]
Update issue-guide.md

Commit migrated from https://github.com/dotnet/corefx/commit/9d9ca028ae18281476ce49ed8f8bf52f5f360663

5 years agoRemove cancellation token from new System.Data CloseAsync() (dotnet/corefx#39070)
Shay Rojansky [Tue, 2 Jul 2019 17:44:36 +0000 (19:44 +0200)]
Remove cancellation token from new System.Data CloseAsync() (dotnet/corefx#39070)

Affects DbDataReader and DbConnection, since these APIs are very likely
to be used for cleanup only, in which case a cancellation token is
an anti-pattern (similar to why DisposeAsync doesn't accept one).

See discussion here:
https://github.com/dotnet/standard/pull/1283#pullrequestreview-255383035

Fixes dotnet/corefx#39069

Commit migrated from https://github.com/dotnet/corefx/commit/539ed313db3ecbfb2ac9dffbb360bb7108fb4c22

5 years agoHonor dictionary key policy when serializing (dotnet/corefx#39032)
Layomi Akinrinade [Tue, 2 Jul 2019 17:39:28 +0000 (13:39 -0400)]
Honor dictionary key policy when serializing (dotnet/corefx#39032)

* Honor dictionary key policy when serializing

* Address review feedback

Commit migrated from https://github.com/dotnet/corefx/commit/00b49d189519677732bcde79a91bee955f3f7a82

5 years agoCompile InvocationExpression target if necessary (dotnet/corefx#39101)
Charles Stoner [Tue, 2 Jul 2019 17:28:28 +0000 (10:28 -0700)]
Compile InvocationExpression target if necessary (dotnet/corefx#39101)

Commit migrated from https://github.com/dotnet/corefx/commit/52a6a31678753e25ce9b6949d45ea85b215aed81

5 years agoIncrease System.Data.Common test coverage (dotnet/corefx#38340)
Bradley Grainger [Tue, 2 Jul 2019 15:21:33 +0000 (08:21 -0700)]
Increase System.Data.Common test coverage (dotnet/corefx#38340)

* Increase DataTableMappingCollection test coverage.
* Increase BinaryNode.EvalBinaryOp test coverage.
* Increase test coverage of aggregate operators.

Commit migrated from https://github.com/dotnet/corefx/commit/86ef1c507faa24ca4406b9e8ebfede2a2ae52100

5 years agoclean up HTTP2 protocol exception handling
Geoff Kizer [Tue, 2 Jul 2019 10:22:04 +0000 (03:22 -0700)]
clean up HTTP2 protocol exception handling

Commit migrated from https://github.com/dotnet/corefx/commit/63e8aa4481928d4dc58c4cb563bfab7fdde322d0

5 years agoimprove Http2_PendingSend_SendsReset test. (dotnet/corefx#39097)
Tomas Weinfurt [Tue, 2 Jul 2019 08:07:50 +0000 (10:07 +0200)]
improve Http2_PendingSend_SendsReset test. (dotnet/corefx#39097)

* improve Http2_PendingSend_SendsReset

* style update

Commit migrated from https://github.com/dotnet/corefx/commit/ec138afba514ce9b53d931d66129e02e8be147a1

5 years agoUse same Encoding for Asc() and Chr() (dotnet/corefx#39096)
Charles Stoner [Tue, 2 Jul 2019 04:13:57 +0000 (21:13 -0700)]
Use same Encoding for Asc() and Chr() (dotnet/corefx#39096)

Commit migrated from https://github.com/dotnet/corefx/commit/11fc2aa48748edb8cf2a9642d0ab0c3b84c393df

5 years agoUse _camelCase for (logically) private properties
Immo Landwerth [Tue, 2 Jul 2019 01:01:52 +0000 (18:01 -0700)]
Use _camelCase for (logically) private properties

Commit migrated from https://github.com/dotnet/corefx/commit/aaf1a0d6872cbded8bee06ab7975128da83df200

5 years agoAdd a number of new RealFormatter tests (dotnet/corefx#38627)
Tanner Gooding [Tue, 2 Jul 2019 00:29:21 +0000 (17:29 -0700)]
Add a number of new RealFormatter tests (dotnet/corefx#38627)

* Add a number of new RealFormatter tests

* Fixing up some custom formatter tests in response to dotnet/coreclrdotnet/corefx#25400

* Don't run the custom numeric format tests against the UTF8Formatter

Commit migrated from https://github.com/dotnet/corefx/commit/1ab9b44f1a22cb94f74139ac946b0ba7a6532286

5 years agoAdd newline at the end of the baseline
Immo Landwerth [Tue, 2 Jul 2019 00:10:33 +0000 (17:10 -0700)]
Add newline at the end of the baseline

When updating the baseline, a newline will always be added. This avoids noisy
diffs.

Commit migrated from https://github.com/dotnet/corefx/commit/cc34137ee7989287381a69bcbdfbc93ea88dd913