review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

bungeman [Wed, 23 Jul 2014 18:28:18 +0000 (11:28 -0700)]

Revert of Enable the SSSE3 compile time check on all platforms. (https://codereview.chromium.org/403583002/)

Reason for revert:
This is blocking the roll. Chromium Windows trybots (like win_chromium_x64_rel) are crashing in the SSSE3 code (for example SkCanvasVideoRenderTest.CroppedFrame).

Original issue's description:
> Enable the SSSE3 compile time check on all platforms (3rd attempt)
>
> BUG=skia:2746
>
> Committed: https://skia.googlesource.com/skia/+/933834851f9d48fbd85b728cc92e1f0134bfaa4e

R=halcanary@google.com, mtklein@google.com, djsollen@google.com
TBR=djsollen@google.com, halcanary@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2746

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/418523002

commit | commitdiff | tree

robertphillips [Wed, 23 Jul 2014 11:55:09 +0000 (04:55 -0700)]

Fix some flaky perf triggers

R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/416483002

commit | commitdiff | tree

robertphillips [Tue, 22 Jul 2014 23:36:13 +0000 (16:36 -0700)]

Revert of SkFontMgr for Android. (https://codereview.chromium.org/414483002/)

Reason for revert:
Reverting to unblock DEPS roll.

Original issue's description:
> SkFontMgr for Android.
>
> Committed: https://skia.googlesource.com/skia/+/4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06

R=djsollen@google.com, tomhudson@google.com, bungeman@google.com
TBR=bungeman@google.com, djsollen@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/408143010

commit | commitdiff | tree

robertphillips [Tue, 22 Jul 2014 23:34:37 +0000 (16:34 -0700)]

Revert "Update fontmgr expectations."

This reverts commit ff4b56b2d52b0e0042d8b2201fd125a6258dd791.

R=bungeman@gmail.com
TBR=bungeman@gmail.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/406323004

commit | commitdiff | tree

bungeman [Tue, 22 Jul 2014 22:21:24 +0000 (18:21 -0400)]

Update fontmgr expectations.

commit | commitdiff | tree

piotaixr [Tue, 22 Jul 2014 22:02:05 +0000 (15:02 -0700)]

Now able to set the localMatrix when creating a SkShader from a SkImage

BUG=skia:2771
R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, bsalomon@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/409653003

commit | commitdiff | tree

djsollen [Tue, 22 Jul 2014 20:56:34 +0000 (13:56 -0700)]

fix android_framework build do to missing library at link time

R=scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/407073006

commit | commitdiff | tree

jvanverth [Tue, 22 Jul 2014 20:25:26 +0000 (13:25 -0700)]

Replace use of GrTHashTable in GrFontCache with SkTDynamicHash.

Searching the font cache for existing text strikes was showing up
as a hotspot on Android. This change reduces that cost.

R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/390103002

commit | commitdiff | tree

bsalomon [Tue, 22 Jul 2014 20:09:46 +0000 (13:09 -0700)]

Revert "Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… (https://codereview.chromium.org/376703009/)"

This reverts commit 249171e7d29b5559f3eefe9dbd437030bfad3fda.

Uses 32 bit id instead of 64. Renamed instanceID to uniqueID to match existing code.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/414493002

commit | commitdiff | tree

bsalomon [Tue, 22 Jul 2014 20:09:05 +0000 (13:09 -0700)]

Make nanobench setup configs outside of loop over benchmarks

R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/410683005

commit | commitdiff | tree

bungeman [Tue, 22 Jul 2014 20:02:58 +0000 (16:02 -0400)]

Suppress fontmgr gm changes while Android catches up.

commit | commitdiff | tree

senorblanco [Tue, 22 Jul 2014 19:49:25 +0000 (12:49 -0700)]

Remove the single-sigma version of SkDropShadowImageFilter::Create().

It's no longer used in Chrome.

BUG=skia:
R=bsalomon@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/407203002

commit | commitdiff | tree

scroggo [Tue, 22 Jul 2014 19:38:55 +0000 (12:38 -0700)]

Run CanvasState test across a library boundary.

Refactor CanvasStateTest to pull out functions which can
either be called directly or from a shared library. Add a
command line flag to pass in the path to a library to open
to call those functions from.

Separate different CanvasTest tests into separate DEF_TEST
tests. This allows them to be run in parallel.

Move the ifdefs outside of function declarations to skip
running CanvasTest tests which do nothing.

Add the canvas_state_lib target. It is a shared library that
exports some functions to be called by another version of
Skia.

BUG=b/15693384
R=djsollen@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/400043003

commit | commitdiff | tree

scroggo [Tue, 22 Jul 2014 19:09:30 +0000 (12:09 -0700)]

Introduce skia_pic gyp variable.

skia_pic tells ninja to use -fPIC when building for position
independent code.

Set skia_pic to true when building our existing targets that
require position independent code.

Also use skia_pic when building for Android.

R=mtklein@google.com, djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/406613003

commit | commitdiff | tree

bungeman [Tue, 22 Jul 2014 19:07:14 +0000 (12:07 -0700)]

SkFontMgr for Android.

R=djsollen@google.com, tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/414483002

commit | commitdiff | tree

bsalomon [Tue, 22 Jul 2014 18:17:14 +0000 (11:17 -0700)]

Remove unused enum value and member of GrGpuObject

R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/413523002

commit | commitdiff | tree

caryclark [Tue, 22 Jul 2014 17:54:07 +0000 (10:54 -0700)]

remove command line args

R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/408243003

commit | commitdiff | tree

caryclark [Tue, 22 Jul 2014 17:40:06 +0000 (10:40 -0700)]

fix nacl

R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/407163002

commit | commitdiff | tree

robertphillips [Tue, 22 Jul 2014 17:18:06 +0000 (10:18 -0700)]

Add auto purging for SkPicture-related Ganesh resources (esp. layers)

This is intended to lower the bookkeeping burden for the Layer Caching feature. Cached layers are now automatically purged when a picture is deleted.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/408923002

commit | commitdiff | tree

caryclark [Tue, 22 Jul 2014 17:15:34 +0000 (10:15 -0700)]

share dm and command flags

Share command flags between dm and unit tests.
Also, allow dm's core to be included by itself and iOSShell.

Command line flags that are the same (or nearly the same) in DM
and in skia_tests have been moved to common_flags. Authors,
please check to see that the shared common flag is correct for
the tool.

For iOS, the 'tool_main' entry point has a wrapper to allow multiple
tools to be statically linked in the iOSShell.
Since SkCommandLineFlags::Parse can only be called once, these calls
are disabled in the IOS build.

Since the iOS app directory is dynamically assigned a name, use '@' to
select it. (This is the same convention chosen by the Mobile Harness
iOS file system utilities.)

Move the heart of dm.gyp into dm.gypi so that it can be included by
itself and iOSShell.gyp.

Add tools/flags/SkCommonFlags.* to define and declare common
command line flags.

Add support for dm to iOSShell.

BUG=skia:
R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/389653004

commit | commitdiff | tree

joshualitt [Tue, 22 Jul 2014 16:52:11 +0000 (09:52 -0700)]

Initial change to move 2D kernel to its own file.

BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/379253003

commit | commitdiff | tree

krajcevski [Tue, 22 Jul 2014 14:44:00 +0000 (07:44 -0700)]

Refactor texture compressors into separate files

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/403383003

commit | commitdiff | tree

sugoi [Tue, 22 Jul 2014 14:26:35 +0000 (07:26 -0700)]

Added count validation in SkImageFilter::Common::unflatten()

BUG=395641
R=reed@google.com, senorblanco@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/405983006

commit | commitdiff | tree

djsollen [Tue, 22 Jul 2014 14:20:18 +0000 (07:20 -0700)]

Enable the SSSE3 compile time check on all platforms (3rd attempt)

BUG=skia:2746
R=halcanary@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/403583002

commit | commitdiff | tree

egdaniel [Tue, 22 Jul 2014 13:46:45 +0000 (06:46 -0700)]

Rebaseline from recent gpu optimization changes
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/408203002

commit | commitdiff | tree

robertphillips [Tue, 22 Jul 2014 12:02:50 +0000 (05:02 -0700)]

Rebaseline some flaky perf triggers

R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/411513002

commit | commitdiff | tree

cdalton [Mon, 21 Jul 2014 22:32:44 +0000 (15:32 -0700)]

Add a GrPathRange class

Adds a GrPathRange object that represents a range of paths on the gpu.
Updates GrDrawTarget::drawPaths and supporting code to use GrPathRange
instead of an array of GrPath objects.

Change-Id: I67845f3893cd4d955db947d699aa3733cbb081e0

BUG=skia:
R=bsalomon@google.com, jvanverth@google.com, kkinnunen@nvidia.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/400713003

commit | commitdiff | tree

bsalomon [Mon, 21 Jul 2014 21:24:01 +0000 (14:24 -0700)]

Make GrCacheable implement its own ref counting.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/392333008

commit | commitdiff | tree

epoger [Mon, 21 Jul 2014 20:55:57 +0000 (13:55 -0700)]

roll common DEPS

R=borenet@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/404823005

commit | commitdiff | tree

egdaniel [Mon, 21 Jul 2014 20:47:57 +0000 (13:47 -0700)]

Add macro so that gpu trace marker can add an arg to the TRACE_EVENT it makes

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/379223004

commit | commitdiff | tree

robertphillips [Mon, 21 Jul 2014 19:40:57 +0000 (12:40 -0700)]

Move GrTMultiMap to src/core and rename it

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/401343002

commit | commitdiff | tree

krajcevski [Mon, 21 Jul 2014 18:44:37 +0000 (11:44 -0700)]

First pass at a blitter for R11 EAC alpha masks. This shaves 10ms off
of the polygon gpu benchmark on the Nexus 7v2 (which is about 6.7% faster).

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/406693002

commit | commitdiff | tree

sugoi [Mon, 21 Jul 2014 18:37:39 +0000 (11:37 -0700)]

Skia side RGB to YUV gpu conversion

This code is the one that's currently working in my local chromium build. A few things still need to be addressed and I'll highlight these directly in the code.

BUG=skia:
R=reed@google.com, bsalomon@google.com, senorblanco@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com, halcanary@google.com

Author: sugoi@chromium.org

Review URL: https://codereview.chromium.org/374743003

commit | commitdiff | tree

egdaniel [Mon, 21 Jul 2014 18:37:28 +0000 (11:37 -0700)]

Remove gpu shader optimatization for solid white or trans black colors

Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.

With optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~160
N7       ~800        ~1100       ~1500
Moto-e   ~830        ~1100       ~2500

Without optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~80
N7       ~1100       ~1100       ~1100
Moto-e   ~1100       ~1100       ~1500

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7

R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/375823005

commit | commitdiff | tree

borenet [Mon, 21 Jul 2014 17:01:56 +0000 (10:01 -0700)]

Move DirectWrite skimage expectations -> GDI

BUG=skia:
R=scroggo@google.com, bungeman@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/407973003

commit | commitdiff | tree

krajcevski [Mon, 21 Jul 2014 16:54:23 +0000 (09:54 -0700)]

Let blitters be notified when they're done being used

R=reed@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/399593007

commit | commitdiff | tree

bsalomon [Mon, 21 Jul 2014 15:03:14 +0000 (08:03 -0700)]

Allow GrGLEffects to produce variable length keys.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/385713005

commit | commitdiff | tree

reed [Mon, 21 Jul 2014 14:31:53 +0000 (07:31 -0700)]

hide public factory for intermediate class

Use SK_DECLARE_UNFLATTENABLE_OBJECT if the subclass should not be directly instantiated.

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/399383007

commit | commitdiff | tree

dominikg [Mon, 21 Jul 2014 09:43:20 +0000 (02:43 -0700)]

Remove use of SK_SUPPORT_LEGACY_LAYERRASTERIZER_API.

Mozilla have removed any uses of the legacy API from their Moz2D code.
Since they were the last users we know of, we can remove the legacy API.

BUG=skia:2187
R=scroggo@google.com, reed@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/402613003

commit | commitdiff | tree

robertphillips [Sun, 20 Jul 2014 16:40:00 +0000 (09:40 -0700)]

Replace GrTHash with SkTDynamicHash

Mike: SkTDynamicHash changes
Brian: Ganesh changes

This removes three instances of GrTHash leaving the ones in GrTextStrike.h

R=mtklein@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/402693003

commit | commitdiff | tree

robertphillips [Sun, 20 Jul 2014 16:21:02 +0000 (09:21 -0700)]

Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… (https://codereview.chromium.org/376703009/)

Reason for revert:
Trying to unblock roll wedged on 64 bit intrinsic call on XP

Original issue's description:
> Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are deleted.
>
> Also, rename GrCacheable::getGenerationID() to getInstanceID() since it doesn't behave like other "generation" IDs.
>
> Committed: https://skia.googlesource.com/skia/+/91bdbcdbbdf5cdf0fdb4518a0d30206c964cfdf6

R=jvanverth@google.com, bsalomon@google.com
TBR=bsalomon@google.com, jvanverth@google.com
NOTREECHECKS=true
NOTRY=true

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/405023003

commit | commitdiff | tree

caryclark [Fri, 18 Jul 2014 17:58:56 +0000 (10:58 -0700)]

git sample app working on iOS

R=jvanverth@google.com

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/405653002

commit | commitdiff | tree

halcanary [Fri, 18 Jul 2014 16:18:40 +0000 (09:18 -0700)]

Make ScaledImageCache unit test less dependent on global state.

motivation: The ASAN bot routinely trips this unit test.

R=tomhudson@chromium.org, tomhudson@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/401833002

commit | commitdiff | tree

djsollen [Fri, 18 Jul 2014 14:09:33 +0000 (07:09 -0700)]

expand workaround to all 32-bit mips devices without the appropriate gcc support

R=halcanary@google.com, reed@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/400753004

commit | commitdiff | tree

egdaniel [Fri, 18 Jul 2014 13:15:43 +0000 (06:15 -0700)]

Cache the return values of getBlendOpts in GrDrawState

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/404473007

commit | commitdiff | tree

rmistry [Fri, 18 Jul 2014 12:25:56 +0000 (05:25 -0700)]

Adding djsollen to list of owners

(SkipBuildbotRuns)

BUG=skia:
R=djsollen@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/397813007

commit | commitdiff | tree

caryclark [Fri, 18 Jul 2014 12:08:14 +0000 (05:08 -0700)]

update pathops core and tests

split out skpclip (the test of 1M pictures) into its own project

TBR=reed

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/400033002

commit | commitdiff | tree

djsollen [Thu, 17 Jul 2014 21:00:57 +0000 (14:00 -0700)]

Fix mac NDK builds

R=jvanverth@google.com, scroggo@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/401613005

commit | commitdiff | tree

jcgregorio [Thu, 17 Jul 2014 20:54:36 +0000 (13:54 -0700)]

Fix GLubyte to GrGLubyte.

BUG=skia:
R=mtklein@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/405433008

commit | commitdiff | tree

jcgregorio [Thu, 17 Jul 2014 20:14:16 +0000 (13:14 -0700)]

Change JSON output of nanobench.

We're moving away from BigQuery for storing results so the output doens't have to conform to BQ requirements, which allows simplifying the format. Also stop parsing the filename for information and pass in buildbot parameters explicitly.

Adds the following flags to nanobench:

--key
--gitHash

BUG=skia:
R=mtklein@google.com, bsalomon@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/392393002

commit | commitdiff | tree

epoger [Thu, 17 Jul 2014 19:54:16 +0000 (12:54 -0700)]

combine base_unittest.py modules from gm and tools

general cleanup, which will also help with http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"')

R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/397103003

commit | commitdiff | tree

bungeman [Thu, 17 Jul 2014 19:17:55 +0000 (12:17 -0700)]

Remove SkRefPtr.

R=mtklein@google.com, reed@google.com, bsalomon@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/393913002

commit | commitdiff | tree

mtklein [Thu, 17 Jul 2014 18:23:07 +0000 (11:23 -0700)]

Revert of nanobench: --veryVerbose for more Win7 debugging (https://codereview.chromium.org/401663002/)

Reason for revert:
Shouldn't be needed anymore.

Original issue's description:
> nanobench: --veryVerbose for more Win7 debugging
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e57452d

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/404543004

commit | commitdiff | tree

bsalomon [Thu, 17 Jul 2014 17:50:59 +0000 (10:50 -0700)]

Fix alpha textures in NV ES3 contexts on Windows.

Make unit tests iterate over all the rendering GL context types rather than using kNative.

Fix the extension printing when gStartupSpew is set.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/398183002

commit | commitdiff | tree

Mike Klein [Thu, 17 Jul 2014 17:19:22 +0000 (13:19 -0400)]

nanobench: --veryVerbose for more Win7 debugging

BUG=skia:

Review URL: https://codereview.chromium.org/401663002

commit | commitdiff | tree

halcanary [Thu, 17 Jul 2014 17:17:28 +0000 (10:17 -0700)]

erase bitmap inside unit test to make valgrind happier

R=mtklein@google.com
TBR=sunshine

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/397273006

commit | commitdiff | tree

mtklein [Thu, 17 Jul 2014 17:02:30 +0000 (10:02 -0700)]

Revert of Revert of Revert of Force DM rebuild. (https://codereview.chromium.org/402663003/)

Reason for revert:
we have to go deeper

Original issue's description:
> Revert of Revert of Force DM rebuild. (https://codereview.chromium.org/399123002/)
>
> Reason for revert:
> jkl;
>
> Original issue's description:
> > Revert of Force DM rebuild. (https://codereview.chromium.org/400723002/)
> >
> > Reason for revert:
> > asdf
> >
> > Original issue's description:
> > > Force DM rebuild.
> > >
> > > BUG=skia:
> > >
> > > Committed: https://skia.googlesource.com/skia/+/8a10de1
> >
> > TBR=mtklein@chromium.org
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/f42e08c12533f2a165bc08451f5ab5dd1363618b
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/41f30cd87ece55971b17e4a59873cf31100ee1a0

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/397293004

commit | commitdiff | tree

mtklein [Thu, 17 Jul 2014 16:34:20 +0000 (09:34 -0700)]

Revert of Revert of Force DM rebuild. (https://codereview.chromium.org/399123002/)

Reason for revert:
jkl;

Original issue's description:
> Revert of Force DM rebuild. (https://codereview.chromium.org/400723002/)
>
> Reason for revert:
> asdf
>
> Original issue's description:
> > Force DM rebuild.
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/8a10de1
>
> TBR=mtklein@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/f42e08c12533f2a165bc08451f5ab5dd1363618b

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/402663003

commit | commitdiff | tree

cdalton [Thu, 17 Jul 2014 16:28:36 +0000 (09:28 -0700)]

Add IsPath to GrGLInterface

This will be used by path ranges.

BUG=skia:
R=bsalomon@google.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/403563002

commit | commitdiff | tree

bsalomon [Thu, 17 Jul 2014 16:28:07 +0000 (09:28 -0700)]

Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are deleted.

Also, rename GrCacheable::getGenerationID() to getInstanceID() since it doesn't behave like other "generation" IDs.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/376703009

commit | commitdiff | tree

mtklein [Thu, 17 Jul 2014 16:07:19 +0000 (09:07 -0700)]

Revert of Force DM rebuild. (https://codereview.chromium.org/400723002/)

Reason for revert:
asdf

Original issue's description:
> Force DM rebuild.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/8a10de1

R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/399123002

commit | commitdiff | tree

Mike Klein [Thu, 17 Jul 2014 16:05:19 +0000 (12:05 -0400)]

Force DM rebuild.

BUG=skia:

Review URL: https://codereview.chromium.org/400723002

commit | commitdiff | tree

mtklein [Thu, 17 Jul 2014 15:38:23 +0000 (08:38 -0700)]

nanobench: Protect more against infinite loops.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/404543002

commit | commitdiff | tree

robertphillips [Thu, 17 Jul 2014 15:26:44 +0000 (08:26 -0700)]

Make GrLayerCache use multiple plots in its atlas

Until we have a recycling Rectanizer the atlas purging must occur at the GrPlot level. This CL breaks the atlas into four plots to give some room for purging (without trashing the entire atlas).

This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/)

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/397873004

commit | commitdiff | tree

epoger [Thu, 17 Jul 2014 15:22:12 +0000 (08:22 -0700)]

create copy_config.py and rename_config.py for skbug 2752

BUG=skia:2752
NOTRY=True
(SkipBuildbotRuns)

R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/397293002

commit | commitdiff | tree

qiankun.miao [Thu, 17 Jul 2014 15:18:23 +0000 (08:18 -0700)]

Fix warning about missing shared library symbols in android_gdbserver

Grab related shared libraryies. Remove libcorkscrew.so due libcorkscrew
is removed from AOSP.

BUG=skia:
R=djsollen@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/399843002

commit | commitdiff | tree

bsalomon [Thu, 17 Jul 2014 14:55:11 +0000 (07:55 -0700)]

Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys.

Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF.

Cleans up docs around GrBackendEffectFactory.

Committed: https://skia.googlesource.com/skia/+/c0ea398aff8254e31152cbb94c9ab6150428e252

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/379113004

commit | commitdiff | tree

reed [Thu, 17 Jul 2014 14:03:09 +0000 (07:03 -0700)]

factor out flattening/unflattening of common fields from SkImageFilter

This is a precursor to changing SkImageFilters (and all effects) to unflatten via a factory instead of a constructor. In that world, each subclass of ImageFilter will need to control/initiate the unflattening of the common fields, so they can be extract and passed to their Factory.

R=senorblanco@google.com, robertphillips@google.com, mtklein@google.com, senorblanco@chromium.org

Author: reed@google.com

Review URL: https://codereview.chromium.org/395273002

commit | commitdiff | tree

scroggo [Thu, 17 Jul 2014 13:58:28 +0000 (06:58 -0700)]

Generate makefile for bench_pictures.

When generating Android framework makefiles, create one for
bench_pictures.

BUG=skia:2744
R=djsollen@google.com, halcanary@google.com, mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/391423002

commit | commitdiff | tree

halcanary [Thu, 17 Jul 2014 13:58:01 +0000 (06:58 -0700)]

Set maximum output size for scaled-image-cache images

Accessable via:
SkScaledImageCache::{G,S}etMaximumOutputSizeForHighQualityFilter

Also, a unit test.

BUG=389439
R=humper@google.com, tomhudson@google.com, reveman@chromium.org, vangelis@chromium.org, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/394003003

commit | commitdiff | tree

Mike Klein [Thu, 17 Jul 2014 00:23:43 +0000 (20:23 -0400)]

(temporarily?) disable no-oped benches

BUG=skia:

Review URL: https://codereview.chromium.org/391343007

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 23:59:32 +0000 (19:59 -0400)]

Use __rdtsc on Windows.

This seems to be ~100x higher resolution than QueryPerformanceCounter.  AFAIK, all our Windows perf bots have constant_tsc, so we can be a bit more direct about using rdtsc directly: it'll always tick at the max CPU frequency.

Now, the question remains, what is the max CPU frequency to divide through by?  It looks like QueryPerformanceFrequency actually gives the CPU frequency in kHz, suspiciously exactly what we need to divide through to get elapsed milliseconds.  That was a freebie.

I did some before/after comparison on slow benchmarks.  Timings look the same.  Going to land this without review tonight to see what happens on the bots; happy to review carefully tomorrow.

R=mtklein@google.com
TBR=bungeman

BUG=skia:

Review URL: https://codereview.chromium.org/394363003

commit | commitdiff | tree

krajcevski [Wed, 16 Jul 2014 22:21:13 +0000 (15:21 -0700)]

Add new ASTC pixel config

R=bsalomon@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/399623004

commit | commitdiff | tree

epoger [Wed, 16 Jul 2014 21:45:47 +0000 (14:45 -0700)]

roll common DEPS, now using recursedeps

BUG=skia:2618
R=borenet@google.com, cmp@chromium.org

Author: epoger@google.com

Review URL: https://codereview.chromium.org/392353003

commit | commitdiff | tree

mtklein [Wed, 16 Jul 2014 21:29:53 +0000 (14:29 -0700)]

Remove benches from DM.

This idea turned out to be more redundant than useful.

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/399463003

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 21:18:20 +0000 (17:18 -0400)]

Disable assertion of fBoundsIsDirty.

We allow this to be raced on, and it may have already become not-dirty by the
time we get to this function if computed by another thread.

BUG=skia:

Review URL: https://codereview.chromium.org/398913002

commit | commitdiff | tree

bungeman [Wed, 16 Jul 2014 20:46:06 +0000 (13:46 -0700)]

Remove ambiguous operator= on AutoCFRelease.

The operator= is ambiguous as to the state of the reference count.
Until we have rvalue assignment operators, just use 'reset' as the name
of the reference stealing assignment to AutoCFRelease.

R=reed@google.com, mtklein@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/400453002

commit | commitdiff | tree

joshualitt [Wed, 16 Jul 2014 20:32:56 +0000 (13:32 -0700)]

32 bpp floating point textures

This is VERY preliminary, but it was sufficient for me to get 32 bit floating point textures in a sample app

BUG=skia:
R=bsalomon@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/359803003

commit | commitdiff | tree

krajcevski [Wed, 16 Jul 2014 20:31:41 +0000 (13:31 -0700)]

Buffer four scanlines prior to blitting. We will eventually use this
to blit four scanlines in a row in order to aggressively compress alpha
masks as the information comes in. This CL is only to introduce the API
and to make sure that nothing breaks in the general case.

R=reed@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/387953005

commit | commitdiff | tree

krajcevski [Wed, 16 Jul 2014 20:26:43 +0000 (13:26 -0700)]

Generalize mask helper a bit for compression

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/398603004

commit | commitdiff | tree

robertphillips [Wed, 16 Jul 2014 20:26:24 +0000 (13:26 -0700)]

Add unique ID to GrPlot

This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/) where it is used for plot lifetime management (i.e., tracking which plots are locked).

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/391153002

commit | commitdiff | tree

robertphillips [Wed, 16 Jul 2014 20:21:21 +0000 (13:21 -0700)]

Chromium no longer needs the SkPicture default constructor

With the landing of the Chromium CL (Remove use of default SkPicture constructor - https://codereview.chromium.org/387343003/) Chromium should no longer require the SK_SUPPORT_LEGACY_DEFAULT_PICTURE_CTOR flag.

R=halcanary@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/398463002

commit | commitdiff | tree

qiankun.miao [Wed, 16 Jul 2014 20:21:15 +0000 (13:21 -0700)]

Make gdb work for 64-bit Skia

BUG=skia:
R=djsollen@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/398733002

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 20:20:12 +0000 (16:20 -0400)]

rebaseline most dw changes

BUG=skia:

Review URL: https://codereview.chromium.org/402443002

commit | commitdiff | tree

Derek Sollenberger [Wed, 16 Jul 2014 19:51:39 +0000 (15:51 -0400)]

Fix broken android framework builds where 32-bit MIPS compilers lack 64-bit __sync operators.

R=mtklein@google.com, reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/398153002

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 19:20:58 +0000 (15:20 -0400)]

Remove yet-unused 64-bit atomic hooks.

For now, I think we'll just be using sk_atomic_inc on 64-bit values, so
let's cut out the dead code for now.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/398003004

commit | commitdiff | tree

Derek Sollenberger [Wed, 16 Jul 2014 19:20:01 +0000 (15:20 -0400)]

Remove outdated compiler restrictions.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/394263002

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 18:19:54 +0000 (14:19 -0400)]

Skip tiling on bitmapscroll:
- off by exactly one pixel when using DirectWrite
- also at least one pixel off on ChromeOS

BUG=skia:
R=bungeman@google.com

Review URL: https://codereview.chromium.org/394243002

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 17:26:19 +0000 (13:26 -0400)]

Reexport skia_gdi.

BUG=skia:

Review URL: https://codereview.chromium.org/398043004

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 17:11:50 +0000 (13:11 -0400)]

Put skia_directwrite back for now.

BUG=skia:

Review URL: https://codereview.chromium.org/397073002

commit | commitdiff | tree

Mike Klein [Wed, 16 Jul 2014 17:06:04 +0000 (13:06 -0400)]

skia_directwrite -> skia_gdi

This will require lots of rebaselines and a bot CL to swap our lone direct write bot to a lone GDI bot.

BUG=skia:
R=bungeman@google.com

Review URL: https://codereview.chromium.org/394223003

commit | commitdiff | tree

bungeman [Wed, 16 Jul 2014 16:10:41 +0000 (09:10 -0700)]

Revert of Reopened: Caching the result of readPixelsSupported (https://codereview.chromium.org/364193004/)

Reason for revert:
This appears to be causing failures on Android when running tests.

Original issue's description:
> Caching the result of readPixelsSupported
>
> The call was calling GR_GL_GetIntegerv 2 times for each readPixels
> and thus was causing a loss of performance
>
> (resubmit of issue 344793008)
>
> Benchmark url: http://packages.gkny.fr/tst/index.html
>
> BUG=skia:2681
>
> Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c
>
> Committed: https://skia.googlesource.com/skia/+/8339371f1ec3c57a0741932fd96bff32c53d4e54

R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, mtklein@google.com, bsalomon@google.com, piotaixr@chromium.org
TBR=bsalomon@chromium.org, bsalomon@google.com, junov@chromium.org, mtklein@google.com, piotaixr@chromium.org, reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2681

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/395203002

commit | commitdiff | tree

epoger [Wed, 16 Jul 2014 15:28:23 +0000 (08:28 -0700)]

make gm self-tests launch python unittests automatically
(not just within the rebaseline_server subdirectory)

Generally useful, but needed asap for my work on http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"')

BUG=skia:677
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/398043002

commit | commitdiff | tree

mtklein [Wed, 16 Jul 2014 13:16:43 +0000 (06:16 -0700)]

Revert of Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys. (https://codereview.chromium.org/379113004/)

Reason for revert:
Most likely candidate for Valgrind failures:

[21:10:08.755668] ==3036== Use of uninitialised value of size 8
[21:10:08.755753] ==3036==    at 0x734AB2: GrGpuGL::ProgramCache::getProgram(GrGLProgramDesc const&, GrEffectStage const**, GrEffectStage const**) (GrGpuGL_program.cpp:107)
[21:10:08.755788] ==3036==    by 0x734ED2: GrGpuGL::flushGraphicsState(GrGpu::DrawType, GrDeviceCoordTexture const*) (GrGpuGL_program.cpp:253)
[21:10:08.755811] ==3036==    by 0x6E81C2: GrGpu::setupClipAndFlushState(GrGpu::DrawType, GrDeviceCoordTexture const*, GrDrawState::AutoRestoreEffects*, SkRect const*) (GrGpu.cpp:350)
[21:10:08.755837] ==3036==    by 0x6E9BE8: GrGpu::onDraw(GrDrawTarget::DrawInfo const&) (GrGpu.cpp:390)
[21:10:08.755858] ==3036==    by 0x6EEECE: GrInOrderDrawBuffer::flush() (GrDrawTarget.h:506)
[21:10:08.755879] ==3036==    by 0x6D0EB4: GrContext::flush(int) (GrContext.cpp:1327)
[21:10:08.755900] ==3036==    by 0x6D3F8F: GrContext::writeTexturePixels(GrTexture*, int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrContext.cpp:1349)
[21:10:08.755922] ==3036==    by 0x6D39D7: GrContext::writeRenderTargetPixels(GrRenderTarget*, int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrContext.cpp:1632)
[21:10:08.755949] ==3036==    by 0x6FFDF3: GrRenderTarget::writePixels(int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrRenderTarget.cpp:45)
[21:10:08.755978] ==3036==    by 0x735563: SkGpuDevice::onWritePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkGpuDevice.cpp:280)
[21:10:08.756003] ==3036==    by 0x57A048: SkBaseDevice::writePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkDevice.cpp:106)
[21:10:08.756025] ==3036==    by 0x56D0AE: SkCanvas::writePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkCanvas.cpp:700)
[21:10:08.756050] ==3036==    by 0x56D156: SkCanvas::writePixels(SkBitmap const&, int, int) (SkCanvas.cpp:652)
[21:10:08.756077] ==3036==    by 0x5109B6: test_WritePixels(skiatest::Reporter*, GrContextFactory*) (WritePixelsTest.cpp:464)
[21:10:08.756099] ==3036==    by 0x51114C: skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (WritePixelsTest.cpp:361)
[21:10:08.756122] ==3036==    by 0x406BE8: skiatest::Test::run() (Test.cpp:107)
[21:10:08.756145] ==3036==    by 0x4064C2: SkTestRunnable::run() (skia_test.cpp:109)
[21:10:08.756167] ==3036==    by 0x405D1A: tool_main(int, char**) (skia_test.cpp:221)
[21:10:08.756189] ==3036==    by 0x405F75: main (skia_test.cpp:239)
[21:10:08.756211] ==3036==  Uninitialised value was created by a stack allocation
[21:10:08.756233] ==3036==    at 0x734CC8: GrGpuGL::flushGraphicsState(GrGpu::DrawType, GrDeviceCoordTexture const*) (GrGpuGL_program.cpp:213)

Original issue's description:
> Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys.
>
> Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF.
>
> Cleans up docs around GrBackendEffectFactory.
>
> Committed: https://skia.googlesource.com/skia/+/c0ea398aff8254e31152cbb94c9ab6150428e252

R=robertphillips@google.com, jvanverth@google.com, bsalomon@google.com
TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/394213002

commit | commitdiff | tree

ljagielski [Wed, 16 Jul 2014 03:02:04 +0000 (20:02 -0700)]

Leaking CGBitmapContext in SkFontHost_mac

third_party/skia/src/ports/SkFontHost_mac.cpp: don't increase retain count of
newly assigned CFTypeRef in AutoCFRelease::reset(). Each time CFTypeRef is
assigned to AutoCFRelease, AutoCFRelease becomes its sole owner.

BUG=skia:
R=reed@google.com, bungeman@google.com, rmistry@google.com, sheyang@chromium.org

Author: ljagielski@opera.com

Review URL: https://codereview.chromium.org/393513003

commit | commitdiff | tree

bungeman [Wed, 16 Jul 2014 03:01:56 +0000 (20:01 -0700)]

Fix some issues with sfnt maxp headers.

The TT version was missing the second to last member,
and the names of the asserts in the CFF version were wrong.

R=mtklein@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/390203003

commit | commitdiff | tree

reed [Wed, 16 Jul 2014 02:56:55 +0000 (19:56 -0700)]

remove dead code from sample

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/393063002

commit | commitdiff | tree

scroggo [Wed, 16 Jul 2014 02:56:48 +0000 (19:56 -0700)]

Remove kImageIsImmutable_Flag.

This flag was only used when setting or checking SkBitmap's
immutability when it did not have an SkPixelRef. Now that an
SkBitmap *must* have one in order to draw (e.g. you can no
longer have an SkBitmap that owns its pixels directly), its
immutabity without an SkPixelRef makes no sense.

Also, now that the flags are not contiguous starting from
0x01, use a more appropriate check to ensure only meaningful
flags are used.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/387083002

commit | commitdiff | tree

qiankun.miao [Wed, 16 Jul 2014 02:51:41 +0000 (19:51 -0700)]

Use va_list variable safely

va_list variable will be invalid after the first call. Use va_copy to
initialize the va_list for another call.

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/394763004

commit | commitdiff | tree

halcanary [Wed, 16 Jul 2014 02:51:35 +0000 (19:51 -0700)]

Make SkTextureCompressor compile with Clang 3.5

kR11EACModifierPalettes moved inside #ifdef where it is used

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/391113002

Domain: Dotnet / API;