profile/ivi/webkit-efl.git
12 years ago[chromium] Refactor canvas, plugin, and video drawing to be more data-driven
commit-queue@webkit.org [Wed, 18 Jan 2012 21:03:19 +0000 (21:03 +0000)]
[chromium] Refactor canvas, plugin, and video drawing to be more data-driven
https://bugs.webkit.org/show_bug.cgi?id=76274

Patch by Tim Dresser <tdresser@chromium.org> on 2012-01-18
Reviewed by James Robinson.

Source/WebCore:

This is the first step in refactoring canvas, plugin, and video drawing.
The CCCustomLayerDrawQuad implementation has been copied to CCCanvasDrawQuad, CCPluginDrawQuad and CCVideoDrawQuad.
All references to CustomLayer have been removed.

As this is a refactor, no new tests were added. CCLayerTreeHostImplTest.blendingOffWhenDrawingOpaqueLayers was modified to
no longer test culling.

* WebCore.gypi:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCanvasQuad):
(WebCore::LayerRendererChromium::drawVideoQuad):
(WebCore::LayerRendererChromium::drawPluginQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCCanvasDrawQuad::create):
(WebCore::CCCanvasDrawQuad::CCCanvasDrawQuad):
* platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCCanvasDrawQuad::layer):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h:
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toCanvasDrawQuad):
(WebCore::CCDrawQuad::toVideoDrawQuad):
(WebCore::CCDrawQuad::toPluginDrawQuad):
* platform/graphics/chromium/cc/CCDrawQuad.h:
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCPluginDrawQuad.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCPluginDrawQuad::create):
(WebCore::CCPluginDrawQuad::CCPluginDrawQuad):
* platform/graphics/chromium/cc/CCPluginDrawQuad.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCPluginDrawQuad::layer):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCPluginLayerImpl.h:
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCVideoDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.cpp.
(WebCore::CCVideoDrawQuad::create):
(WebCore::CCVideoDrawQuad::CCVideoDrawQuad):
* platform/graphics/chromium/cc/CCVideoDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCCustomLayerDrawQuad.h.
(WebCore::CCVideoDrawQuad::layer):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):
* platform/graphics/chromium/cc/CCVideoLayerImpl.h:

Source/WebKit/chromium:

No longer test culling in CCLayerTreeHostImplTest.blendingOffWhenDrawingLayers.

* tests/CCLayerTreeHostImplTest.cpp:
(WebKit::BlendStateCheckLayer::appendQuads):
(WebKit::BlendStateCheckLayer::setExpectation):
(WebKit::BlendStateCheckLayer::quadsAppended):
(WebKit::BlendStateCheckLayer::BlendStateCheckLayer):
(WebKit::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Unsafe cross origin access errors should show stack trace in console.
vsevik@chromium.org [Wed, 18 Jan 2012 20:59:10 +0000 (20:59 +0000)]
Web Inspector: Unsafe cross origin access errors should show stack trace in console.
https://bugs.webkit.org/show_bug.cgi?id=73099

Reviewed by Pavel Feldman.

Source/WebCore:

Test: http/tests/inspector/console-cross-origin-iframe-logging.html

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::reportUnsafeAccessTo):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addConsoleMessage):
* dom/ScriptExecutionContext.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldAllowNavigation):
* page/Console.cpp:
(WebCore::Console::addMessage):
* page/Console.h:
* page/DOMWindow.cpp:
(WebCore::PostMessageTimer::PostMessageTimer):
(WebCore::PostMessageTimer::stackTrace):
(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):
(WebCore::DOMWindow::printErrorMessage):

LayoutTests:

* http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.
* http/tests/inspector/console-cross-origin-iframe-logging.html: Added.
* http/tests/inspector/resources/cross-origin-iframe.html: Added.
* platform/chromium/http/tests/inspector/console-cross-origin-iframe-logging-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd [CallWith] support for attributes in JSC/V8 idl code generators.
commit-queue@webkit.org [Wed, 18 Jan 2012 20:29:30 +0000 (20:29 +0000)]
Add [CallWith] support for attributes in JSC/V8 idl code generators.
Part of https://bugs.webkit.org/show_bug.cgi?id=76035

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-18
Reviewed by Adam Barth.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateAttributeCallWith):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):
(GenerateNormalAttrSetter):
(GenerateAttributeCallWith):
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::withScriptStateAttribute):
(WebDOMTestObj::setWithScriptStateAttribute):
(WebDOMTestObj::withScriptExecutionContextAttribute):
(WebDOMTestObj::setWithScriptExecutionContextAttribute):
(WebDOMTestObj::withScriptStateAttributeRaises):
(WebDOMTestObj::setWithScriptStateAttributeRaises):
(WebDOMTestObj::withScriptExecutionContextAttributeRaises):
(WebDOMTestObj::setWithScriptExecutionContextAttributeRaises):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_with_script_state_attribute):
(webkit_dom_test_obj_set_with_script_state_attribute):
(webkit_dom_test_obj_get_with_script_execution_context_attribute):
(webkit_dom_test_obj_set_with_script_execution_context_attribute):
(webkit_dom_test_obj_get_with_script_state_attribute_raises):
(webkit_dom_test_obj_set_with_script_state_attribute_raises):
(webkit_dom_test_obj_get_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_with_script_execution_context_attribute_raises):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj withScriptStateAttribute]):
(-[DOMTestObj setWithScriptStateAttribute:]):
(-[DOMTestObj withScriptExecutionContextAttribute]):
(-[DOMTestObj setWithScriptExecutionContextAttribute:]):
(-[DOMTestObj withScriptStateAttributeRaises]):
(-[DOMTestObj setWithScriptStateAttributeRaises:]):
(-[DOMTestObj withScriptExecutionContextAttributeRaises]):
(-[DOMTestObj setWithScriptExecutionContextAttributeRaises:]):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::withScriptStateAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjInternal::withScriptStateAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeRaisesAttrGetter):
(WebCore::TestObjInternal::withScriptExecutionContextAttributeRaisesAttrSetter):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago file:// doesn't work as base URL
ap@apple.com [Wed, 18 Jan 2012 20:18:34 +0000 (20:18 +0000)]
    file:// doesn't work as base URL
        https://bugs.webkit.org/show_bug.cgi?id=76496

        Updating more layout test results.

        * fast/loader/url-parse-1-expected.txt: This was already in the patch, just failed to land.

        * http/tests/misc/bubble-drag-events-expected.txt: Missed that one among failure noise.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Broken build with undefined reference to shm_open and shm_unlink
commit-queue@webkit.org [Wed, 18 Jan 2012 20:12:51 +0000 (20:12 +0000)]
[Qt][WK2] Broken build with undefined reference to shm_open and shm_unlink
https://bugs.webkit.org/show_bug.cgi?id=76538

Patch by Luciano Wolf <luciano.wolf@openbossa.org> on 2012-01-18
Reviewed by Tor Arne Vestbø.

The -lrt parameter was coming before -lWebKit2 during linkage.

Moved rt lib inclusion from Source/api.pri to WebKit2.pri as it should be aware
of its own dependencies instead of letting WebKit guess about. Letting
it on api.pri can lead to a wrong parameter's order during linker phase.
Ubuntu 11.10 was giving errors about SharedMemory (shm_open and
shm_unlink undefined symbols).

.:

* Source/api.pri:

Source/WebKit2:

The issue was fixed with the help of Aloisio Almeida and Lauro Venancio.

* WebKit2.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoadd test expections ahead of skia DEPS roll
reed@google.com [Wed, 18 Jan 2012 19:59:39 +0000 (19:59 +0000)]
add test expections ahead of skia DEPS roll
https://bugs.webkit.org/show_bug.cgi?id=76477

Reviewed by NOBODY: Unreviewed
see http://code.google.com/p/chromium/issues/detail?id=110493

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Update expectations and baselines for various tests
jamesr@google.com [Wed, 18 Jan 2012 19:48:05 +0000 (19:48 +0000)]
[chromium] Update expectations and baselines for various tests

* platform/chromium-linux/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-all-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-container-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Removed.
* platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Removed.
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/chromium-win/svg/custom/linking-a-03-b-viewBox-expected.txt:
* platform/chromium-win/svg/transforms/animated-path-inside-transformed-html-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Chromium Linux GPU 32 to the list of allowed Chromium Linux
abarth@webkit.org [Wed, 18 Jan 2012 19:39:04 +0000 (19:39 +0000)]
Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
configurations.

* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed: fix failing inspector test.
pfeldman@chromium.org [Wed, 18 Jan 2012 18:58:52 +0000 (18:58 +0000)]
Not reviewed: fix failing inspector test.

* inspector/elements/set-html-via-resource.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CG] Rasterized scaling of transformed SVG shapes with gradient fill and -webkit...
timothy_horton@apple.com [Wed, 18 Jan 2012 18:49:51 +0000 (18:49 +0000)]
[CG] Rasterized scaling of transformed SVG shapes with gradient fill and -webkit-svg-shadow applied
https://bugs.webkit.org/show_bug.cgi?id=76482
<rdar://problem/10415483>

Reviewed by Simon Fraser.

Scale the CGLayer used when filling or stroking a shadowed path or rect with
a gradient in GraphicsContextCG. Previously, the CGLayer was created and rendered
into at the untransformed size of the shape, leading to pixelation when it was
then scaled up and drawn into the destination.

Add AffineTransform::mapSize() to map a size through a transformation.

Test: svg/custom/transform-with-shadow-and-gradient.svg

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::strokeRect):
* platform/graphics/transforms/AffineTransform.cpp:
(WebCore::AffineTransform::mapSize): Added.
* platform/graphics/transforms/AffineTransform.h:

Add a test that ensures that SVG shapes are drawn crisply when transformed
if they have both a gradient fill and -webkit-svg-shadow applied.

* platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
* platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt: Added.
* svg/custom/transform-with-shadow-and-gradient.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAccessibility: Chromium needs methods to scroll an object into view or to a specific...
dmazzoni@google.com [Wed, 18 Jan 2012 18:46:41 +0000 (18:46 +0000)]
Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460

Reviewed by Chris Fleizach.

Source/WebCore:

Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html
       platform/chromium/accessibility/scroll-to-global-point-nested.html
       platform/chromium/accessibility/scroll-to-global-point-iframe.html
       platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html
       platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
       platform/chromium/accessibility/scroll-to-make-visible-iframe.html
       platform/chromium/accessibility/scroll-to-make-visible-main-window.html
       platform/chromium/accessibility/scroll-to-make-visible-nested.html
       platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html

* accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
* accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):

Tools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

LayoutTests:

* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago file:// doesn't work as base URL
ap@apple.com [Wed, 18 Jan 2012 18:41:43 +0000 (18:41 +0000)]
    file:// doesn't work as base URL
        https://bugs.webkit.org/show_bug.cgi?id=76496

        Reviewed by Darin Adler.

        Test: fast/url/degenerate-file-base.html

        * platform/KURL.cpp: (WebCore::KURL::parse): Handle degenerate file URLs properly.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Web Inspector: highlight DOM nodes from detached DOM trees.
loislo@chromium.org [Wed, 18 Jan 2012 18:20:40 +0000 (18:20 +0000)]
[chromium] Web Inspector: highlight DOM nodes from detached DOM trees.
https://bugs.webkit.org/show_bug.cgi?id=76545

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshotNode.prototype.get isNativeRoot):
(WebInspector.HeapSnapshotNode.prototype.get isDetachedDOMTree):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype._markDetachedDOMTreeNodes):
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
* inspector/front-end/heapProfiler.css:
(.detached-dom-tree-node):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebKit/mac: Missing NSForegroundColorAttributeName should be treated as black...
enrica@apple.com [Wed, 18 Jan 2012 18:12:19 +0000 (18:12 +0000)]
Source/WebKit/mac: Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
https://bugs.webkit.org/show_bug.cgi?id=76490
<rdar://problem/9460733>

Starting with Lion, there is no more NSForegroundColor attribute in the dictionary
if the color matches the default (solid black).
The fix consists in treating the lack of color as solid black instead of transparent as
we did before.

Added a TestWebKitAPI test.

Reviewed by Darin Adler and Dan Bernstein.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _styleForAttributeChange:]):

Tools: Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
https://bugs.webkit.org/show_bug.cgi?id=76490
<rdar://problem/9460733>

Added TestWebKitAPI test.

Reviewed by Dan Bernstein.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
* TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
changeAttributes to the WebView.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCross-platform processor core counter fix
commit-queue@webkit.org [Wed, 18 Jan 2012 18:10:30 +0000 (18:10 +0000)]
Cross-platform processor core counter fix
https://bugs.webkit.org/show_bug.cgi?id=76540

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-18
Reviewed by Zoltan Herczeg.

I attached "OS(FREEBSD)" to "#if OS(DARWIN) || OS(OPENBSD) || OS(NETBSD)"
and I removed the OS checking macros from ParallelJobsGeneric.cpp because
the NumberOfCores.cpp contains them for counting CPU cores.
The processor core counter patch located at
https://bugs.webkit.org/show_bug.cgi?id=76530

* wtf/NumberOfCores.cpp:
* wtf/ParallelJobsGeneric.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] Listen to GDK_SCROLL_MASK
commit-queue@webkit.org [Wed, 18 Jan 2012 18:06:55 +0000 (18:06 +0000)]
[GTK] Listen to GDK_SCROLL_MASK
https://bugs.webkit.org/show_bug.cgi?id=76529

Source/WebKit/gtk:

Set GDK_SCROLL_MASK explicitly, as WebKitWebView does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.

Patch by Carlos Garnacho <carlosg@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.

* webkit/webkitwebview.cpp:
(webkit_web_view_realize):

Source/WebKit2:

Set GDK_SCROLL_MASK explicitly, as WebKitWebViewBase does handle
scroll events, scrolling currently works because GTK+ happens
to send such events to widgets listening to GDK_BUTTON_PRESS_MASK,
but this isn't the intended behavior, so it's subject to change.

Patch by Carlos Garnacho <carlosg@gnome.org> on 2012-01-18
Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseRealize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: there should be a way to set HTML for given frame.
pfeldman@chromium.org [Wed, 18 Jan 2012 17:56:42 +0000 (17:56 +0000)]
Web Inspector: there should be a way to set HTML for given frame.
https://bugs.webkit.org/show_bug.cgi?id=76548

Reviewed by Yury Semikhatsky.

* inspector/Inspector.json:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::setDocumentContent):
* inspector/InspectorPageAgent.h:
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMModelResourceBinding.prototype.setContent.callbackWrapper):
(WebInspector.DOMModelResourceBinding.prototype.setContent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] fontCache related assertion revealed by r105143
ossy@webkit.org [Wed, 18 Jan 2012 17:41:51 +0000 (17:41 +0000)]
[Qt] fontCache related assertion revealed by r105143
https://bugs.webkit.org/show_bug.cgi?id=76534

Unreviewed gardening. Skip a guilty test to paint the bot green.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] [regression] A couple of tests failing after r105253
sergio@webkit.org [Wed, 18 Jan 2012 17:40:46 +0000 (17:40 +0000)]
[GTK] [regression] A couple of tests failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76549

Reviewed by Gustavo Noronha Silva.

Fixes a regression added by r105253. The method that
RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
instead of popsMenuByArrowKeys().

No new tests as it's already covered by
fast/forms/select-popup-pagekeys.html and
fast/forms/select/menulist-onchange-fired-with-key-up-down.html
that started to fail after the revision mentioned above.

* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt][WK2] Fix the debug build.
abecsi@webkit.org [Wed, 18 Jan 2012 17:35:27 +0000 (17:35 +0000)]
[Qt][WK2] Fix the debug build.

Unreviewed.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(setInputPanelVisible): Remove assertion from non-member function.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed: adding missing test data file.
pfeldman@chromium.org [Wed, 18 Jan 2012 17:27:52 +0000 (17:27 +0000)]
Not reviewed: adding missing test data file.

* inspector/elements/resources/set-html-via-resource-iframe.html: Added.
* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r105262.
ossy@webkit.org [Wed, 18 Jan 2012 17:19:35 +0000 (17:19 +0000)]
[Qt] Unreviewed gardening after r105262.
https://bugs.webkit.org/show_bug.cgi?id=76457

* platform/qt/Skipped: Skip inspector/elements/set-html-via-resource.html until proper fix.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: omit compression field in HAR entries for resources coming from cache
caseq@chromium.org [Wed, 18 Jan 2012 17:14:12 +0000 (17:14 +0000)]
Web Inspector: omit compression field in HAR entries for resources coming from cache
https://bugs.webkit.org/show_bug.cgi?id=76543

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildContent):
(WebInspector.HAREntry.prototype.get responseCompression):

LayoutTests:

* http/tests/inspector/resource-har-conversion-expected.txt:
* http/tests/inspector/resource-har-headers-expected.txt:
* http/tests/inspector/resource-parameters-expected.txt:
* platform/chromium/http/tests/inspector/resource-har-conversion-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening. Skip failing tests, simplify qt-wk2 skipped list.
ossy@webkit.org [Wed, 18 Jan 2012 17:09:01 +0000 (17:09 +0000)]
[Qt] Unreviewed gardening. Skip failing tests, simplify qt-wk2 skipped list.

* platform/qt-wk2/Skipped:
* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[CSSRegions]Fix region style code in CSSStyleSelector
mihnea@adobe.com [Wed, 18 Jan 2012 16:57:16 +0000 (16:57 +0000)]
[CSSRegions]Fix region style code in CSSStyleSelector
https://bugs.webkit.org/show_bug.cgi?id=76453

Reviewed by Antti Koivisto.

Source/WebCore:

Follow up after comments in https://bugs.webkit.org/show_bug.cgi?id=76064.
With the new approach, the css rule specificity is correctly taken into account
when applying the region style rule.
No new tests, the region style tests are still disabled.

* css/CSSStyleSelector.cpp:
(WebCore::RuleSet::RuleSetSelectorPair::RuleSetSelectorPair):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::collectMatchingRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForRegion):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::checkRegionStyle):
(WebCore::CSSStyleSelector::checkRegionSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::addRegionRule):
(WebCore::RuleSet::addRulesFromSheet):
(WebCore::isInsideRegionRule):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:

LayoutTests:

Fix the test as it was not taking into account the selector specificity.
* fast/regions/region-style-block-background-color.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMac fails to fire an 'error' event for a <video> <source> having an URL with no file...
jer.noble@apple.com [Wed, 18 Jan 2012 16:39:05 +0000 (16:39 +0000)]
Mac fails to fire an 'error' event for a <video> <source> having an URL with no file extension
https://bugs.webkit.org/show_bug.cgi?id=76494

Reviewed by Eric Carlson.

No new tests; fixes compositing/video/video-with-invalid-source.html. Modified
media/video-source-error-no-candidate.html to check error condition.

When we run out of media engines for a given resource, inform the media player client
that resource loading failed by calling mediaPlayerResourceNotSupported().

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerResourceNotSupported):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerResourceNotSupported):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit2 needs layoutTestController.overridePreference
ossy@webkit.org [Wed, 18 Jan 2012 16:06:55 +0000 (16:06 +0000)]
WebKit2 needs layoutTestController.overridePreference
https://bugs.webkit.org/show_bug.cgi?id=42197

Unreviewed gardening, skip failing tests due to this bug.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Test fonts metric differencies with Qt5
ossy@webkit.org [Wed, 18 Jan 2012 16:02:07 +0000 (16:02 +0000)]
[Qt] Test fonts metric differencies with Qt5
https://bugs.webkit.org/show_bug.cgi?id=75710

Unreviewed gardening, unskip now passing tests after tesfont fix

* platform/qt-5.0/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCSS Shaders: Parse float parameters for the custom() filter syntax
achicu@adobe.com [Wed, 18 Jan 2012 15:42:34 +0000 (15:42 +0000)]
CSS Shaders: Parse float parameters for the custom() filter syntax
https://bugs.webkit.org/show_bug.cgi?id=76253

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Custom CSS filters allow passing parameters from CSS to the underlying rendering technology (in this case WebGL Shaders).
This patch adds support for parameters of types float, vec2, vec3 and vec4.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustomParamsAttribute

Tests: css3/filters/effect-custom-combined-missing.html
       css3/filters/effect-custom-parameters.html

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
    Added CustomFilterParameter.h, CustomFilterNumberParameter.h and CustomFilterOperation.cpp to the projects.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterNumberParameter):
(WebCore::CSSComputedStyleDeclaration::valueForCustomFilterParameter):
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
    Added the computed parameters in alphabetic order (CustomFilterOperation always keeps the parameters sorted).
* css/CSSComputedStyleDeclaration.h:
* css/CSSStyleSelector.cpp:
(WebCore::sortParametersByNameComparator):
(WebCore::CSSStyleSelector::parseCustomFilterNumberParamter):
(WebCore::CSSStyleSelector::parseCustomFilterParameterList):
(WebCore::CSSStyleSelector::createCustomFilterOperation):
    Added parsing for float, vec2, vec3 and vec4. The values are space separated.

* css/CSSStyleSelector.h:
* platform/graphics/filters/CustomFilterNumberParameter.h: Added.
(WebCore::CustomFilterNumberParameter::create):
(WebCore::CustomFilterNumberParameter::size):
(WebCore::CustomFilterNumberParameter::valueAt):
(WebCore::CustomFilterNumberParameter::addValue):
(WebCore::CustomFilterNumberParameter::CustomFilterNumberParameter):

* platform/graphics/filters/CustomFilterOperation.cpp: Added.
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::~CustomFilterOperation):
    Moved constructor and destructor in CustomFilterOperation.cpp to avoid including CustomFilterParameter everywhere.
(WebCore::CustomFilterOperation::hasSortedParameterList):
    Debug runtime check that we always have parameters in alphabetic order.

* platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::create):
(WebCore::CustomFilterOperation::parameters):
    Just added the parameters list. Not using a map, but keeping the items sorted by name. We need them sorted
    to make it easy and fast to merge two CustomFilterOperations during animations.

* platform/graphics/filters/CustomFilterParameter.h: Added.
(WebCore::CustomFilterParameter::~CustomFilterParameter):
(WebCore::CustomFilterParameter::parameterType):
(WebCore::CustomFilterParameter::name):
(WebCore::CustomFilterParameter::CustomFilterParameter):
* platform/graphics/filters/CustomFilterShader.cpp:
(WebCore::CustomFilterShader::uniformLocationByName):
* platform/graphics/filters/CustomFilterShader.h:

* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::platformApplySoftware):
(WebCore::FECustomFilter::bindProgramNumberParameters):
(WebCore::FECustomFilter::bindProgramParameters):
    Added code that maps the parameters from CSS to WebGL.
(WebCore::FECustomFilter::bindProgramAndBuffers):
* platform/graphics/filters/FECustomFilter.h:

* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
    Fixed a case when the filter was not created, letting the filter add itself as a source of its own.
    Also added a test case for this particular case: css3/filters/effect-custom-combined-missing.html.

LayoutTests:

* css3/filters/custom-filter-property-computed-style-expected.txt:
* css3/filters/effect-custom-combined-missing-expected.png: Added.
* css3/filters/effect-custom-combined-missing-expected.txt: Added.
* css3/filters/effect-custom-combined-missing.html: Added.
    Testing that missing shader filters will not enter an infinite loop.

* css3/filters/effect-custom-parameters-expected.png: Added.
* css3/filters/effect-custom-parameters-expected.txt: Added.
* css3/filters/effect-custom-parameters.html: Added.
* css3/filters/resources/color-offset-parameters.fs: Added.
* css3/filters/resources/vertex-offset-parameters.vs: Added.
    Testing parameter passing from CSS to WebGL.

* css3/filters/script-tests/custom-filter-property-computed-style.js:
    Added computed style checks for number parameters.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Zoom in to the focused node only when vkb starts becoming visible https://bugs...
kenneth@webkit.org [Wed, 18 Jan 2012 15:36:47 +0000 (15:36 +0000)]
[Qt] Zoom in to the focused node only when vkb starts becoming visible https://bugs.webkit.org/show_bug.cgi?id=76174

Reviewed by Simon Hausmann.

Remove the old code which always zoomed in when something got focus,
even via JavaScript, and replaced it with code checking the state of
the Qt input panel.

Also make sure that we do not zoom in or request the input panel if
the item is not focused.

* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.cpp:
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::QtWebPageEventHandler):
(QtWebPageEventHandler::~QtWebPageEventHandler):
(QtWebPageEventHandler::inputPanelVisibleChanged):
* UIProcess/qt/QtWebPageEventHandler.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::respondToChangedSelection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: resource tree model leaks frames
caseq@chromium.org [Wed, 18 Jan 2012 15:21:48 +0000 (15:21 +0000)]
Web Inspector: resource tree model leaks frames
https://bugs.webkit.org/show_bug.cgi?id=76533

Reviewed by Pavel Feldman.

* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.prototype._removeFrame):
(WebInspector.ResourceTreeFrame.prototype._removeChildFrame):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCross-platform processor core counter
ossy@webkit.org [Wed, 18 Jan 2012 15:07:13 +0000 (15:07 +0000)]
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530

Unreviewed cross-MinGW buildfix after r105270.

* wtf/NumberOfCores.cpp: Use windows.h instead of Windows.h.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Enable support for Open Script dialog based on FilteredItemSelectionDi...
vsevik@chromium.org [Wed, 18 Jan 2012 14:20:26 +0000 (14:20 +0000)]
Web Inspector: Enable support for Open Script dialog based on FilteredItemSelectionDialog.
https://bugs.webkit.org/show_bug.cgi?id=76466

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.JavaScriptOutlineDialog.createShortcut):
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.install):
(WebInspector.OpenResourceDialog._show):
(WebInspector.OpenResourceDialog.createShortcut):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
(WebInspector.OpenResourceDialog.prototype.itemsCount):
(WebInspector.OpenResourceDialog.prototype.requestItems):
(WebInspector.OpenResourceDialog.prototype.selectItem):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.showUISourceCode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Update another SVG expected after r105247.
rgabor@webkit.org [Wed, 18 Jan 2012 14:15:06 +0000 (14:15 +0000)]
[Qt] Update another SVG expected after r105247.

Unreviewed.

* platform/qt/svg/custom/pointer-events-text-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-text-css-transform-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCross-platform processor core counter
commit-queue@webkit.org [Wed, 18 Jan 2012 14:15:05 +0000 (14:15 +0000)]
Cross-platform processor core counter
https://bugs.webkit.org/show_bug.cgi?id=76530

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-01-18
Reviewed by Zoltan Herczeg.

Source/JavaScriptCore:

Two files have been created that include the processor core counter function.
It used to be in ParallelJobsGeneric.h/cpp before.

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/Options.cpp:
(JSC::Options::initializeOptions):
* wtf/CMakeLists.txt:
* wtf/NumberOfCores.cpp: Added.
(WTF::numberOfProcessorCores):
* wtf/NumberOfCores.h: Added.
* wtf/ParallelJobsGeneric.cpp:
(WTF::ParallelEnvironment::ParallelEnvironment):
* wtf/ParallelJobsGeneric.h:

Source/WTF:

Two files have been added to the project, namely NumberOfCores.h/cpp,
that include a CPU core number determining function.

* WTF.pro:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143
rgabor@webkit.org [Wed, 18 Jan 2012 13:57:05 +0000 (13:57 +0000)]
[Qt] svg/carto.net/frameless-svg-parse-error.html asserting after r105143
https://bugs.webkit.org/show_bug.cgi?id=76534

Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNot reviewed: follow up to r105262, fixing front-end compilation.
pfeldman@chromium.org [Wed, 18 Jan 2012 13:52:02 +0000 (13:52 +0000)]
Not reviewed: follow up to r105262, fixing front-end compilation.

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMDocument):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Consolidate layout test crash logging
kbalazs@webkit.org [Wed, 18 Jan 2012 13:35:57 +0000 (13:35 +0000)]
[Qt] Consolidate layout test crash logging
https://bugs.webkit.org/show_bug.cgi?id=75088

Reviewed by Simon Hausmann.

Move backtrace generating logic into WTFReportBacktrace
and add a way to deinstall signal handlers if we know
that we have already printed the backtrace.

.:

* Source/qtwebkit-export.map:

Source/JavaScriptCore:

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/Assertions.cpp:
(WTFLogLocker::WTFReportBacktrace):
(WTFLogLocker::WTFSetCrashHook):
(WTFLogLocker::WTFInvokeCrashHook):
* wtf/Assertions.h:

Tools:

* DumpRenderTree/qt/main.cpp:
(crashHandler):
(setupSignalHandlers):
(WTFCrashHook):
(main):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::crashHandler):
(WTR::setupSignalHandlers):
(WTR::crashHook):
(WTR::InjectedBundle::platformInitialize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after testfonts update.
ossy@webkit.org [Wed, 18 Jan 2012 13:26:54 +0000 (13:26 +0000)]
[Qt] Unreviewed gardening after testfonts update.

* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png:
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Update some SVG expected after r105247.
rgabor@webkit.org [Wed, 18 Jan 2012 13:15:09 +0000 (13:15 +0000)]
[Qt] Update some SVG expected after r105247.

Unreviewed.

* platform/qt/svg/custom/linking-a-03-b-all-expected.png:
* platform/qt/svg/custom/linking-a-03-b-all-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-expected.txt:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
* platform/qt/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
* platform/qt/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/qt/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/qt/svg/custom/pointer-events-image-expected.png:
* platform/qt/svg/custom/pointer-events-image-expected.txt:
* platform/qt/svg/custom/pointer-events-text-expected.png:
* platform/qt/svg/custom/pointer-events-text-expected.txt:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[GTK] platform/gtk/accessibility/combo-box-collapsed-selection-changed.html is failin...
mario@webkit.org [Wed, 18 Jan 2012 13:00:55 +0000 (13:00 +0000)]
[GTK] platform/gtk/accessibility/combo-box-collapsed-selection-changed.html is failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76531

Unreviewed. Skip test now failing in the GTK port.

* platform/gtk/Skipped: Skip test.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix after r105256.
loislo@chromium.org [Wed, 18 Jan 2012 13:00:45 +0000 (13:00 +0000)]
Unreviewed build fix after r105256.

There was a cyclic dependency between self._port and self._host assigments.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
pfeldman@chromium.org [Wed, 18 Jan 2012 12:52:46 +0000 (12:52 +0000)]
Web Inspector: track HTML revisions when editing DOM and / or upon free flow edits.
https://bugs.webkit.org/show_bug.cgi?id=76457

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-html-via-resource.html

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchNode):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getOuterHTML):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::buildObjectForNode):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.setNodeName):
(WebInspector.DOMNode.prototype.setNodeValue):
(WebInspector.DOMNode.prototype.setAttribute):
(WebInspector.DOMNode.prototype.setAttributeValue):
(WebInspector.DOMNode.prototype.removeAttribute):
(WebInspector.DOMNode.prototype.getChildNodes.mycallback):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype.setOuterHTML):
(WebInspector.DOMNode.prototype.removeNode):
(WebInspector.DOMNode.prototype.moveTo):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype._setDocument):
(WebInspector.DOMAgent.prototype._buildHighlightConfig):
(WebInspector.DOMAgent.prototype._markRevision):
(WebInspector.DOMAgent.prototype._captureDOM.callback):
(WebInspector.DOMAgent.prototype._captureDOM):
(WebInspector.DOMModelResourceBinding.prototype.setContent):
(WebInspector.DOMModelResourceBinding.prototype.setContent.setOuterHTML):
(WebInspector.DOMModelResourceBinding.prototype.setContent.withDocument):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

LayoutTests:

* inspector/elements/resources/set-outer-html-body-iframe.html:
* inspector/elements/set-html-via-resource-expected.txt: Added.
* inspector/elements/set-html-via-resource.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWeb Inspector: Popover does not disappear, causes debugger failure.
caseq@chromium.org [Wed, 18 Jan 2012 12:46:55 +0000 (12:46 +0000)]
Web Inspector: Popover does not disappear, causes debugger failure.
https://bugs.webkit.org/show_bug.cgi?id=71363

Reviewed by Pavel Feldman.

This is a work-around simple enough for a merge. The real fix would
be to get TextViewer to manage the highlight on its own, so it's not
accidently removed while re-building DOM for the text chunk.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd new watchlist rule for the Qt build system
vestbo@webkit.org [Wed, 18 Jan 2012 11:33:06 +0000 (11:33 +0000)]
Add new watchlist rule for the Qt build system

Reviewed by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
vestbo@webkit.org [Wed, 18 Jan 2012 11:32:48 +0000 (11:32 +0000)]
[Qt] Move OTHER_FILES from WebKit.pro to Tools.pro

Reviewed by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Allow building only a subset of the WebKit sub-projects
vestbo@webkit.org [Wed, 18 Jan 2012 11:32:33 +0000 (11:32 +0000)]
[Qt] Allow building only a subset of the WebKit sub-projects

Fixes build-jsc, broken in r104825.

We no longer need the intermediate buildQMakeQtProject(), as we're the
only port using qmake, and buildQMakeProject is now highly Qt specific.

<http://webkit.org/b/76179>

Reviewed by Simon Hausmann.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, GTK rebaseline after r105247 and r105253.
philn@webkit.org [Wed, 18 Jan 2012 11:25:21 +0000 (11:25 +0000)]
Unreviewed, GTK rebaseline after r105247 and r105253.

* platform/gtk/css3/images/cross-fade-overflow-position-expected.txt:
* platform/gtk/fast/forms/implicit-submission-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
* platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
* platform/gtk/svg/custom/pointer-events-image-css-transform-expected.txt:
* platform/gtk/svg/custom/pointer-events-image-expected.txt:
* platform/gtk/svg/custom/pointer-events-text-css-transform-expected.txt:
* platform/gtk/svg/custom/pointer-events-text-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agorun-perf-tests should generate a json file that summaries the result
rniwa@webkit.org [Wed, 18 Jan 2012 10:52:41 +0000 (10:52 +0000)]
run-perf-tests should generate a json file that summaries the result
https://bugs.webkit.org/show_bug.cgi?id=76504

Reviewed by Adam Barth.

Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
New option --outout-json-path specifies the json file's path, and --source-json-path specifies
another json file to be merged into the generated json file.

Also fixed a bug that --build wasn't set by default.

* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.webkit_base):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
(PerfTestsRunner):
(PerfTestsRunner._parse_args):
(PerfTestsRunner.run):
(PerfTestsRunner._generate_json_if_specified):
(PerfTestsRunner._process_chromium_style_test_result):
(PerfTestsRunner._process_parser_test_result):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest):
(create_runner):
(test_run_test_set):
(test_run_test_set_for_parser_tests):
(test_run_test_set_with_summary_json):
(test_collect_tests):
(test_parse_args):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed build fix.
commit-queue@webkit.org [Wed, 18 Jan 2012 10:52:07 +0000 (10:52 +0000)]
Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=76525

Removed missing build headers.

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Chromium] Unreviewed, fix clashing svg/custom/linking-a-03-b-viewBox.svg expectation.
apavlov@chromium.org [Wed, 18 Jan 2012 10:40:43 +0000 (10:40 +0000)]
[Chromium] Unreviewed, fix clashing svg/custom/linking-a-03-b-viewBox.svg expectation.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse RenderTheme in HTMLSelectElement instead of #defines.
commit-queue@webkit.org [Wed, 18 Jan 2012 10:39:31 +0000 (10:39 +0000)]
Use RenderTheme in HTMLSelectElement instead of #defines.
<http://webkit.org/b/76519>

Patch by Jun Mukai <mukai@chromium.org> on 2012-01-18
Reviewed by Kent Tamura.

Tests: no new tests because of no behavioral changes.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuByArrowKeys):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::popsMenuByArrowKeys):
(WebCore::RenderTheme::popsMenuBySpaceOrReturn):
* rendering/RenderThemeChromiumLinux.h:
(WebCore::RenderThemeChromiumLinux::popsMenuBySpaceOrReturn):
* rendering/RenderThemeMac.h:
(WebCore::RenderThemeMac::popsMenuByArrowKeys):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed: Chromium test_expectations.txt update
rolandsteiner@chromium.org [Wed, 18 Jan 2012 10:08:22 +0000 (10:08 +0000)]
Unreviewed: Chromium test_expectations.txt update

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSource/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
inferno@chromium.org [Wed, 18 Jan 2012 10:00:20 +0000 (10:00 +0000)]
Source/WebCore: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309

Reviewed by Nikolas Zimmermann.

updateWidgetPositions can blow away the owning renderer
and its frameview, so need to protect it with refptr.

Test: svg/dom/parent-view-layout-crash.html

* page/FrameView.cpp:
(WebCore::FrameView::forceLayoutParentViewIfNeeded):

LayoutTests: Crash in FrameView::forceLayoutParentViewIfNeeded.
https://bugs.webkit.org/show_bug.cgi?id=76309

Reviewed by Nikolas Zimmermann.

* svg/dom/parent-view-layout-crash-expected.txt: Added.
* svg/dom/parent-view-layout-crash.html: Added.
* svg/dom/resources/svg-font-face.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass...
commit-queue@webkit.org [Wed, 18 Jan 2012 09:15:24 +0000 (09:15 +0000)]
Move ShadowContentElement from dom/ to html/ and make ShadowContentElement subclass of HTMLElement.
https://bugs.webkit.org/show_bug.cgi?id=76241

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-18
Reviewed by Dimitri Glazkov.

.:

* Source/autotools/symbols.filter: Exposed necessary symbols.

Source/WebCore:

Renamed ShadowContentElement to HTMLContentElement, and move it from dom/ to html/.
Also, ShadowInclusionSelector and ShadowContentSelectorQuery are renamed to
Content InclusionSelector and ContentSelectorQuery respectively.

No new tests, because no change in behavior.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/NodeRenderingContext.cpp:
(WebCore::nextRendererOf):
(WebCore::previousRendererOf):
(WebCore::firstRendererOf):
(WebCore::lastRendererOf):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
* dom/NodeRenderingContext.h:
(WebCore::NodeRenderingContext::includer):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::includerFor):
(WebCore::ShadowRoot::inclusions):
(WebCore::ShadowRoot::ensureInclusions):
* dom/ShadowRoot.h:
* html/HTMLDetailsElement.cpp:
(WebCore::DetailsContentElement::DetailsContentElement):
(WebCore::DetailsSummaryElement::DetailsSummaryElement):
* html/HTMLElementsAllInOne.cpp:
* html/HTMLSummaryElement.cpp:
(WebCore::SummaryContentElement::SummaryContentElement):
* html/shadow/ContentInclusionSelector.cpp: Renamed from Source/WebCore/dom/ShadowInclusionSelector.cpp.
(WebCore::ShadowInclusion::append):
(WebCore::ShadowInclusion::unlink):
(WebCore::ShadowInclusionList::ShadowInclusionList):
(WebCore::ShadowInclusionList::~ShadowInclusionList):
(WebCore::ShadowInclusionList::find):
(WebCore::ShadowInclusionList::clear):
(WebCore::ShadowInclusionList::append):
(WebCore::ContentInclusionSelector::ContentInclusionSelector):
(WebCore::ContentInclusionSelector::~ContentInclusionSelector):
(WebCore::ContentInclusionSelector::select):
(WebCore::ContentInclusionSelector::unselect):
(WebCore::ContentInclusionSelector::findFor):
(WebCore::ContentInclusionSelector::didSelect):
(WebCore::ContentInclusionSelector::willSelectOver):
* html/shadow/ContentInclusionSelector.h: Renamed from Source/WebCore/dom/ShadowInclusionSelector.h.
(WebCore::ShadowInclusion::includer):
(WebCore::ShadowInclusion::content):
(WebCore::ShadowInclusion::next):
(WebCore::ShadowInclusion::previous):
(WebCore::ShadowInclusion::ShadowInclusion):
(WebCore::ShadowInclusion::create):
(WebCore::ShadowInclusionList::first):
(WebCore::ShadowInclusionList::last):
(WebCore::ShadowInclusionList::isEmpty):
(WebCore::ShadowInclusionSet::add):
(WebCore::ShadowInclusionSet::remove):
(WebCore::ShadowInclusionSet::isEmpty):
(WebCore::ShadowInclusionSet::Translator::hash):
(WebCore::ShadowInclusionSet::Translator::equal):
(WebCore::ShadowInclusionSet::Hash::hash):
(WebCore::ShadowInclusionSet::Hash::equal):
(WebCore::ShadowInclusionSet::find):
(WebCore::ContentInclusionSelector::hasCandidates):
* html/shadow/ContentSelectorQuery.cpp: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.cpp.
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
(WebCore::ContentSelectorQuery::matches):
* html/shadow/ContentSelectorQuery.h: Renamed from Source/WebCore/dom/ShadowContentSelectorQuery.h.
* html/shadow/HTMLContentElement.cpp: Renamed from Source/WebCore/dom/ShadowContentElement.cpp.
(WebCore::HTMLContentElement::create):
(WebCore::HTMLContentElement::HTMLContentElement):
(WebCore::HTMLContentElement::~HTMLContentElement):
(WebCore::HTMLContentElement::attach):
(WebCore::HTMLContentElement::detach):
(WebCore::HTMLContentElement::select):
(WebCore::HTMLContentElement::setSelect):
* html/shadow/HTMLContentElement.h: Renamed from Source/WebCore/dom/ShadowContentElement.h.
(WebCore::HTMLContentElement::inclusions):
(WebCore::HTMLContentElement::isContentElement):
(WebCore::HTMLContentElement::rendererIsNeeded):
(WebCore::HTMLContentElement::createRenderer):
(WebCore::toHTMLContentElement):
* testing/Internals.cpp:
(WebCore::Internals::createContentElement):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

* win/WebKit2.def: Exposed necessary symbols.
* win/WebKit2CFLite.def: ditto.

LayoutTests:

Renamed internals.createShadowContentElement to internals.createContentElement.

* fast/dom/shadow/content-element-includer.html:
* fast/dom/shadow/content-element-renderers.html:
* fast/dom/shadow/create-content-element.html:
* fast/dom/shadow/shadow-contents-select.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed. Fix GTK+ build after r105245.
carlosgc@webkit.org [Wed, 18 Jan 2012 09:04:22 +0000 (09:04 +0000)]
Unreviewed. Fix GTK+ build after r105245.

* Source/autotools/symbols.filter: Fix symbol name.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRenderSVGRoot should inherit from RenderReplaced
zimmermann@webkit.org [Wed, 18 Jan 2012 08:45:17 +0000 (08:45 +0000)]
RenderSVGRoot should inherit from RenderReplaced
https://bugs.webkit.org/show_bug.cgi?id=76446

Reviewed by Zoltan Herczeg.

Source/WebCore:

Let RenderSVGRoot inherit from RenderReplaced, instead of faking RenderReplaced, by inherting from RenderBox
and calling setReplaced(true) in the constructor. The outermost <svg> element is a replaced element in the
sense of CSS, and thus this is just a logical move. It fixes some issues where the <svg> root appeared
as selection leaf, covered by existing tests.

It allows us to simplify the painting, as outlines, etc. are painted by RenderReplaced now.
While I was it, speed up the local to border box computations by caching the result.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::paint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::RenderSVGRoot):
(WebCore::RenderSVGRoot::layout):
(WebCore::RenderSVGRoot::paintReplaced):
(WebCore::RenderSVGRoot::willBeDestroyed):
(WebCore::RenderSVGRoot::styleWillChange):
(WebCore::RenderSVGRoot::styleDidChange):
(WebCore::RenderSVGRoot::updateFromElement):
(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):
(WebCore::RenderSVGRoot::localToParentTransform):
(WebCore::RenderSVGRoot::computeFloatRectForRepaint):
(WebCore::RenderSVGRoot::mapLocalToContainer):
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::canHaveChildren):
(WebCore::RenderSVGRoot::canBeSelectionLeaf):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):

LayoutTests:

Update test results after making RenderSVGRoot inherit from RenderReplaced.

* platform/chromium/test_expectations.txt:
* platform/mac/svg/custom/linking-a-03-b-all-expected.png: Text layout changed, we didn't relayout the tree when entering a new view before.
* platform/mac/svg/custom/linking-a-03-b-all-expected.txt: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-expected.png: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png: Ditto.
* platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.png: Moving the circle, triggered a selection before, where it shouldn't. It's gone now.
* platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-expected.txt: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.png: Ditto.
* platform/mac/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-image-css-transform-expected.png: Caret position which is reported changed, due the selection leaf changes.
* platform/mac/svg/custom/pointer-events-image-css-transform-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-image-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-image-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-text-css-transform-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt: Ditto.
* platform/mac/svg/custom/pointer-events-text-expected.png: Ditto.
* platform/mac/svg/custom/pointer-events-text-expected.txt: Ditto.
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png: This now reports a valid size for the RenderSVGRoot in the <fO> subtree.
* svg/foreignObject/text-tref-02-b-expected.txt: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed, rolling out r105244.
rolandsteiner@chromium.org [Wed, 18 Jan 2012 07:36:49 +0000 (07:36 +0000)]
Unreviewed, rolling out r105244.
http://trac.webkit.org/changeset/105244
https://bugs.webkit.org/show_bug.cgi?id=76518

broke Chromium Mac (Requested by rolandsteiner on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-17

Source/WebCore:

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::checkboxOrRadioValue):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
* accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:

Tools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::removeSelection):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::removeSelection):

LayoutTests:

* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Removed.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Removed.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Internals] Should be able to access corresponding Document object.
commit-queue@webkit.org [Wed, 18 Jan 2012 06:55:01 +0000 (06:55 +0000)]
[Internals] Should be able to access corresponding Document object.
https://bugs.webkit.org/show_bug.cgi?id=76425

.:

Added exported symbols.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

* Source/autotools/symbols.filter:

Source/WebCore:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

- Allow FrameDestructionObserver to re-setting the Frame reference.
- Make Internals a subclass of FrameDestructionObserver.

Since Internals::reset() is called for each test, we can access
the acive Frame object during the test. The frame reference will be
used by coming changes.

No new tests. Covered by existing tests.

* WebCore.exp.in:
* page/FrameDestructionObserver.cpp:
(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::observe):
* page/FrameDestructionObserver.h:
* testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::reset):
* testing/Internals.h:

Source/WebKit2:

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Adam Barth.

* win/WebKit2.def: Added exporting symbols.
* win/WebKit2CFLite.def: Added exporting symbols.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAccessibility: Chromium needs methods to scroll an object into view or to a specific...
dmazzoni@google.com [Wed, 18 Jan 2012 06:41:51 +0000 (06:41 +0000)]
Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
https://bugs.webkit.org/show_bug.cgi?id=73460

Reviewed by Chris Fleizach.

Source/WebCore:

Tests: platform/chromium/accessibility/scroll-to-global-point-main-window.html
       platform/chromium/accessibility/scroll-to-global-point-nested.html
       platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html
       platform/chromium/accessibility/scroll-to-make-visible-iframe.html
       platform/chromium/accessibility/scroll-to-make-visible-main-window.html
       platform/chromium/accessibility/scroll-to-make-visible-nested.html
       platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html

* accessibility/AccessibilityObject.cpp:
(WebCore::computeBestScrollOffset):
(WebCore::AccessibilityObject::scrollToMakeVisible):
(WebCore::AccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebCore::AccessibilityObject::scrollToGlobalPoint):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityObject::scrollTo):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getScrollableAreaIfScrollable):
(WebCore::AccessibilityRenderObject::scrollTo):
* accessibility/AccessibilityRenderObject.h:
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::getScrollableAreaIfScrollable):
(WebCore::AccessibilityScrollView::scrollTo):
* accessibility/AccessibilityScrollView.h:

Source/WebKit/chromium:

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::scrollToMakeVisible):
(WebKit::WebAccessibilityObject::scrollToMakeVisibleWithSubFocus):
(WebKit::WebAccessibilityObject::scrollToGlobalPoint):

Tools:

* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/chromium/AccessibilityUIElement.cpp:
(AccessibilityUIElement::AccessibilityUIElement):
(AccessibilityUIElement::scrollToMakeVisibleCallback):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
(AccessibilityUIElement::scrollToGlobalPointCallback):
* DumpRenderTree/chromium/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::scrollToMakeVisible):
(AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
(AccessibilityUIElement::scrollToGlobalPoint):

LayoutTests:

* platform/chromium/accessibility/scroll-to-global-point-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-iframe-nested.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-global-point-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-div-overflow.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-iframe.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-main-window.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-nested.html: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus-expected.txt: Added.
* platform/chromium/accessibility/scroll-to-make-visible-with-subfocus.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixing broken build. Missed a file in r105234.
mdelaney@apple.com [Wed, 18 Jan 2012 06:39:17 +0000 (06:39 +0000)]
Fixing broken build. Missed a file in r105234.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=75089
commit-queue@webkit.org [Wed, 18 Jan 2012 06:06:09 +0000 (06:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75089
Access-Control-Request-Headers value should be lowercase

Source/WebCore:

Access-Control-Request-Headers is used when issuing a preflight request to let the server know
the HTTP headers that will be used when the actual request is made.
As per the W3C specification, Access-Control-Request-Headers value should be set in lowercase.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.

Test: http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html

* loader/CrossOriginAccessControl.cpp:
(WebCore::createAccessControlPreflightRequest): setting Access-Control-Request-Headers value to lowercase

LayoutTests:

Added test to verify that the Access-Control-Request-Headers value is sent in lowercase.

Patch by Joe Thomas <joethomas@motorola.com> on 2012-01-17
Reviewed by Alexey Proskuryakov.

* http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase-expected.txt: Added.
* http/tests/xmlhttprequest/access-control-preflight-request-header-lowercase.html: Added.
* http/tests/xmlhttprequest/resources/access-control-preflight-request-header-lowercase.php: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClean EventContext and move phase-tweaking logic to EventDispatcher.
hayato@chromium.org [Wed, 18 Jan 2012 05:49:52 +0000 (05:49 +0000)]
Clean EventContext and move phase-tweaking logic to EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=76414

Reviewed by Dimitri Glazkov.

No tests. No change in behavior.

* dom/EventContext.cpp:
(WebCore::EventContext::handleLocalEvents):
* dom/EventContext.h:
(WebCore::EventContext::currentTargetSameAsTarget):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[EFL] Use static const insted of #define macro.
gyuyoung.kim@samsung.com [Wed, 18 Jan 2012 04:28:36 +0000 (04:28 +0000)]
[EFL] Use static const insted of #define macro.
https://bugs.webkit.org/show_bug.cgi?id=76499

Reviewed by Hajime Morita.

WebKit coding style prefers const to #define. EFL port needs to use const insted of #define macro.
This patch replace global variables defined by #define with const.

* ewk/ewk_tiled_backing_store.cpp:
(_ewk_tiled_backing_store_smart_add):
(_ewk_tiled_backing_store_zoom_set_internal):
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_tiled_matrix.cpp:
(ewk_tile_matrix_new):
* ewk/ewk_view.cpp:
(_ewk_view_repaint_add):
(_ewk_view_repaints_flush):
(_ewk_view_scroll_add):
(_ewk_view_scrolls_flush):
(_ewk_view_priv_new):
(ewk_view_base_smart_set):
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_smart_pre_render_start):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Remove public/WebWorker.h from the gyp projects
noel.gordon@gmail.com [Wed, 18 Jan 2012 04:15:02 +0000 (04:15 +0000)]
[chromium] Remove public/WebWorker.h from the gyp projects
https://bugs.webkit.org/show_bug.cgi?id=76512

Reviewed by David Levin.

public/WebWorker.h was removed in r105020, remove references from the gyp projects.

* WebKit.gyp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNeed to figure out which assert is firing when worker-read-blob-async.html fails.
levin@chromium.org [Wed, 18 Jan 2012 04:13:17 +0000 (04:13 +0000)]
Need to figure out which assert is firing when worker-read-blob-async.html fails.
https://bugs.webkit.org/show_bug.cgi?id=76503

Reviewed by Adam Barth.

No new functionality exposed so no new tests.

This is just a quick and dirty way to make these asserts unique
to expose which one of them is firing on a machine that doesn't have a
good stack trace.

* dom/ActiveDOMObject.cpp:
(WebCore::ContextDestructionObserver::ContextDestructionObserver):
(WebCore::ContextDestructionObserver::~ContextDestructionObserver):
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::changeVersion):
(WebCore::DatabaseSync::runTransaction):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnable tests on the mac-ews
abarth@webkit.org [Wed, 18 Jan 2012 04:01:27 +0000 (04:01 +0000)]
Enable tests on the mac-ews
https://bugs.webkit.org/show_bug.cgi?id=76502

Reviewed by Simon Fraser.

Apple now has five machines running the mac-ews.  Lucas Forschler has
asked that we try enabling tests to see if we have enough bandwidth.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoOn post-Lion releases, preserve the Lion behavior where WebKit explicitly calls ...
mdelaney@apple.com [Wed, 18 Jan 2012 03:59:02 +0000 (03:59 +0000)]
On post-Lion releases, preserve the Lion behavior where WebKit explicitly calls -setGeometryFlipped on the hosting layer for applications that were linked on Lion or earlier.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoClear 'm_size' of DrawingBuffer in the 'clear' function
commit-queue@webkit.org [Wed, 18 Jan 2012 03:24:38 +0000 (03:24 +0000)]
Clear 'm_size' of DrawingBuffer in the 'clear' function
https://bugs.webkit.org/show_bug.cgi?id=76239

Patch by Yongsheng Zhu <yongsheng.zhu@intel.com> on 2012-01-17
Reviewed by Kenneth Russell.

Clear the resources of DrawingBuffer but don't clear 'm_size'. This makes
's_currentResourceUsePixels' is not calculated correctly.

* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore::DrawingBuffer::clear):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a check-webkit-style exception for GDBInterface.cpp
commit-queue@webkit.org [Wed, 18 Jan 2012 03:19:09 +0000 (03:19 +0000)]
Add a check-webkit-style exception for GDBInterface.cpp
https://bugs.webkit.org/show_bug.cgi?id=76187

Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
that it does not fail the style check.

Patch by Sanjoy Das <sanjoy@playingwithpointers.com> on 2012-01-17
Reviewed by Martin Robinson.

* Scripts/webkitpy/style/checker.py: Tell the style checker to not run
readability/naming tests on
Source/JavaScriptCore/jit/GDBInterface.cpp.
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier): Add a test for
the above exception.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix getBBox for perpendicular paths
commit-queue@webkit.org [Wed, 18 Jan 2012 03:16:47 +0000 (03:16 +0000)]
Fix getBBox for perpendicular paths
https://bugs.webkit.org/show_bug.cgi?id=76177

Patch by Philip Rogers <pdr@google.com> on 2012-01-17
Reviewed by Darin Adler.

Source/WebCore:

Test: svg/custom/getBBox-perpendicular-path.svg

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::unite):
(WebCore::FloatRect::uniteEvenIfEmpty):
(WebCore::FloatRect::uniteIfNonZero):
* platform/graphics/FloatRect.h:
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::computeContainerBoundingBoxes):

LayoutTests:

* svg/custom/getBBox-perpendicular-path-expected.txt: Added.
* svg/custom/getBBox-perpendicular-path.svg: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Apply color profiles in more cases
kbr@google.com [Wed, 18 Jan 2012 03:09:16 +0000 (03:09 +0000)]
[chromium] Apply color profiles in more cases
https://bugs.webkit.org/show_bug.cgi?id=76498

Reviewed by Stephen White.

Not adding new tests, as application of the color profile is not
guaranteed for images used as textures in WebGL. Ran existing
WebGL layout tests; all pass.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::setStatus):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Mark some compositing tests as failing with an IMAGE diff due to video...
jamesr@google.com [Wed, 18 Jan 2012 02:48:00 +0000 (02:48 +0000)]
[chromium] Mark some compositing tests as failing with an IMAGE diff due to video playback problem

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix media handling in compositing tests after r105219.
simon.fraser@apple.com [Wed, 18 Jan 2012 02:43:13 +0000 (02:43 +0000)]
Fix media handling in compositing tests after r105219.

Reviewed by James Robinson.

Seeking seems to have issues on Chromium, and cause these tests to
timeout, so change the tests to play, then seek back to time 0.

New image results now show the first frame of the movie.

* compositing/resources/media-testing.js:
(ensureFrameVisible):
* platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/mac/compositing/self-painting-layers-expected.png:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename quickLookPreviewItemsAtWindowLocation: to quickLookWithEvent:
weinig@apple.com [Wed, 18 Jan 2012 02:18:28 +0000 (02:18 +0000)]
Rename quickLookPreviewItemsAtWindowLocation: to quickLookWithEvent:
<rdar://problem/10688913>

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKView.mm:
(-[WKView quickLookWithEvent:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoEnsure we don't cancel revalidation of a CachedResource
japhet@chromium.org [Wed, 18 Jan 2012 02:06:42 +0000 (02:06 +0000)]
Ensure we don't cancel revalidation of a CachedResource
in the middle of successful revalidation.
It's more reliable to enforce this in CachedResource than in
SubresourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=75713

Reviewed by Adam Barth.

No new test, the buggy case requires a non-stubbed window.print().

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
* loader/SubresourceLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::clearResourceToRevalidate):
(WebCore::CachedResource::switchClientsToRevalidatedResource):
* loader/cache/CachedResource.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTweak results.html keyboard handling and flagging UI
ojan@chromium.org [Wed, 18 Jan 2012 02:06:19 +0000 (02:06 +0000)]
Tweak results.html keyboard handling and flagging UI
https://bugs.webkit.org/show_bug.cgi?id=76331

Reviewed by Simon Fraser.

-Make it so that hitting j/k at the start selects the first/last test
instead of the second/none'th test.
-Use the unicode black flag character instead of " (flagged)"
-Make the text color of the whole selected row red. This showed
which row was selected without being to garish I think.
-Allow for having the flagged tests be space-separated instead of
newline separated.

* fast/harness/resources/results-test.js:
* fast/harness/results-expected.txt:
* fast/harness/results.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNULL ptr in WebCore::RenderSVGInlineText::localCaretRect
commit-queue@webkit.org [Wed, 18 Jan 2012 02:03:30 +0000 (02:03 +0000)]
NULL ptr in WebCore::RenderSVGInlineText::localCaretRect
https://bugs.webkit.org/show_bug.cgi?id=75851

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-17
Reviewed by Ryosuke Niwa.

.:

Added a check for null box in localCaretRect, to match test in other
implementations. Adding a manual test because the crash is not
reproducible in DRT.

* ManualTests/svg-modify-deleted-selection.svg: Added.

Source/WebCore:

Added a check for null box in localCaretRect, to match test in other
implementations. Adding a manual test because the crash is not reproducible
in DRT.

Test: ManualTests/svg-modify-deleted-selection.svg

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::localCaretRect):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFactored out some code into a helper function.
ggaren@apple.com [Wed, 18 Jan 2012 02:00:44 +0000 (02:00 +0000)]
Factored out some code into a helper function.

I think this might help getting rid of omit-frame-pointer.

Reviewed by Sam Weinig.

No benchmark change.

* runtime/StringPrototype.cpp:
(JSC::removeUsingRegExpSearch): Moved to here...
(JSC::replaceUsingRegExpSearch): ...from here.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReduce the number of compositing test failures
simon.fraser@apple.com [Wed, 18 Jan 2012 01:18:20 +0000 (01:18 +0000)]
Reduce the number of compositing test failures
https://bugs.webkit.org/show_bug.cgi?id=76495

Reviewed by James Robinson.

General cleanup of compositing tests:
    * video tests now do a seek to guarantee that the pixel result will show a frame
    * video tests use a shared JS file (can't use media/video-test.js because it always
    calls dumpAsText(), which is not reversible).
    * ideo-with-invalid-source.html fixed to use a file extension so that the
    error event fires (bug 76494).
    * pixel results rebaselined.

* compositing/geometry/clipped-video-controller.html:
* compositing/geometry/video-fixed-scrolling.html:
* compositing/geometry/video-opacity-overlay.html:
* compositing/layers-inside-overflow-scroll.html:
* compositing/overflow/scroll-ancestor-update.html:
* compositing/reflections/load-video-in-reflection.html:
* compositing/resources/media-testing.js: Added.
(ensureFrameVisible):
* compositing/self-painting-layers.html:
* compositing/video/video-with-invalid-source.html:
* compositing/visibility/visibility-simple-video-layer.html:
* platform/mac/compositing/color-matching/image-color-matching-expected.png:
* platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/mac/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/mac/compositing/overflow/scroll-ancestor-update-expected.txt:
* platform/mac/compositing/plugins/composited-plugin-expected.png:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
* platform/mac/compositing/self-painting-layers-expected.png:
* platform/mac/compositing/video/video-background-color-expected.png:
* platform/mac/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=76245
commit-queue@webkit.org [Wed, 18 Jan 2012 01:16:30 +0000 (01:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76245
[Mac][DRT] should allow query string for the file URL.

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-17
Reviewed by Tony Chang.

Taught DRT about file:// as a url instead of a file path.
We are now able to use a path file:///foo/bar.html?baz as a url
with which DRT opens "/foo/bar.html" with "baz" as a query string.

* DumpRenderTree/mac/DumpRenderTree.mm:
(runTest):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUint8ClampedArray support
caio.oliveira@openbossa.org [Wed, 18 Jan 2012 01:11:16 +0000 (01:11 +0000)]
Uint8ClampedArray support
https://bugs.webkit.org/show_bug.cgi?id=74455

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/PredictedType.cpp:
(JSC::predictionToString):
(JSC::predictionFromClassInfo):
* bytecode/PredictedType.h:
(JSC::isUint8ClampedArrayPrediction):
(JSC::isActionableMutableArrayPrediction):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::execute):
* dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateUint8ClampedArray):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::clampDoubleToByte):
(JSC::DFG::compileClampIntegerToByte):
(JSC::DFG::SpeculativeJIT::compilePutByValForByteArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSCell.h:
* runtime/JSGlobalData.h:
* wtf/Forward.h:
* wtf/Uint8Array.h:
* wtf/Uint8ClampedArray.h: Added.
(WTF::Uint8ClampedArray::set):
(WTF::Uint8ClampedArray::create):
(WTF::Uint8ClampedArray::Uint8ClampedArray):
(WTF::Uint8ClampedArray::subarray):

Source/WebCore:

Test: fast/js/dfg-uint8clampedarray.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* ForwardingHeaders/wtf/Uint8ClampedArray.h: Added.
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMWindowCustom.cpp:
* bindings/js/JSUint8ClampedArrayCustom.cpp: Added.
(WebCore::JSUint8ClampedArray::indexSetter):
(WebCore::toJS):
(WebCore::JSUint8ClampedArray::set):
(WebCore::JSUint8ClampedArrayConstructor::constructJSUint8ClampedArray):
* bindings/scripts/CodeGeneratorJS.pm:
(IsTypedArrayType):
(GenerateHeader):
* html/canvas/Uint8ClampedArray.idl: Added.
* page/DOMWindow.idl:

Source/WTF:

* WTF.pro:

LayoutTests:

* fast/canvas/webgl/array-unit-tests-expected.txt:
* fast/canvas/webgl/array-unit-tests.html:
* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties.html:
* fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
* fast/dom/script-tests/prototype-inheritance-2.js:
(constructorNamesForWindow):
* fast/js/dfg-uint8clampedarray-expected.txt: Added.
* fast/js/dfg-uint8clampedarray.html: Added.
* fast/js/script-tests/dfg-uint8clampedarray.js: Added.
(getter1):
(setter1):
(getter2):
(setter2):
(getter3):
(setter3):
(getter4):
(setter4):
(getters.getter1.a):
(.a):
(setters.setter1.a):
(safeGetter):
(safeSetter):
* fast/js/script-tests/global-constructors.js:
* platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt: Copied from LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Update baselines
jamesr@google.com [Wed, 18 Jan 2012 00:50:43 +0000 (00:50 +0000)]
[chromium] Update baselines

* platform/chromium-linux/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/chromium-mac-snowleopard/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/chromium-win/animations/cross-fade-webkit-mask-box-image-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/carto.net/window-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCheck style on test_expectations.txt files before commit
ojan@chromium.org [Wed, 18 Jan 2012 00:41:07 +0000 (00:41 +0000)]
Check style on test_expectations.txt files before commit
https://bugs.webkit.org/show_bug.cgi?id=76484

Reviewed by Adam Barth.

Unlike other style rules, if you get the syntax of the test_expectations.txt
file wrong, the layout tests won't run. Also, this check is simple and only
slows down committing if you actually modify one of the test_expectations.txt files.

* Scripts/webkitpy/tool/steps/commit.py:
(Commit._check_test_expectations):
(Commit.run):
* Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
(CommitTest):
(CommitTest.test_check_test_expectations):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCrash in in WebCore::EventHandler::mouseMoved.
inferno@chromium.org [Wed, 18 Jan 2012 00:33:10 +0000 (00:33 +0000)]
Crash in in WebCore::EventHandler::mouseMoved.
https://bugs.webkit.org/show_bug.cgi?id=76462

Reviewed by Ryosuke Niwa.

Source/WebCore:

handleMouseMoveEvent call in EventHandler::mouseMoved can
blow away the frame from underneath. Protect it with a frameview
refptr.

Test: fast/events/mouse-moved-remove-frame-crash.html

* page/EventHandler.cpp:
(WebCore::EventHandler::mouseMoved):

LayoutTests:

* fast/events/mouse-moved-remove-frame-crash-expected.txt: Added.
* fast/events/mouse-moved-remove-frame-crash.html: Added.
* fast/events/resources/mouse-move.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoIncrease test coverage for -webkit-border-image.
alexis.menard@openbossa.org [Wed, 18 Jan 2012 00:12:40 +0000 (00:12 +0000)]
Increase test coverage for -webkit-border-image.
https://bugs.webkit.org/show_bug.cgi?id=76473

Reviewed by Tony Chang.

Make sure we also set the width of the border in the shorthand. It will help
in the future to remove CSSBorderImageValue class without breaking this property.

* fast/css/getComputedStyle/getComputedStyle-border-image-expected.txt:
* fast/css/getComputedStyle/getComputedStyle-border-image.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Debug build fails with debug qt5
ostapenko.viatcheslav@nokia.com [Wed, 18 Jan 2012 00:10:53 +0000 (00:10 +0000)]
[Qt] Debug build fails with debug qt5
https://bugs.webkit.org/show_bug.cgi?id=76463

Reviewed by Simon Hausmann.

Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.

Source/WebKit/qt:

* WebCoreSupport/FrameNetworkingContextQt.cpp:

Tools:

* QtTestBrowser/cookiejar.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Update expectations for line-grid tests and one random svg thing
jamesr@google.com [Wed, 18 Jan 2012 00:06:37 +0000 (00:06 +0000)]
[chromium] Update expectations for line-grid tests and one random svg thing

* platform/chromium-linux/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-linux/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-mac-leopard/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-floating-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-floating-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-inside-columns-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-floats-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-floats-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-positioned-expected.png: Added.
* platform/chromium-win/fast/line-grid/line-grid-positioned-expected.txt: Added.
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Update expectations/baselines for cross-fade change
jamesr@google.com [Tue, 17 Jan 2012 23:57:45 +0000 (23:57 +0000)]
[chromium] Update expectations/baselines for cross-fade change

* css3/images/cross-fade-overflow-position-expected.txt: Renamed from LayoutTests/platform/mac/css3/images/cross-fade-overflow-position-expected.txt.
* platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium/test_expectations.txt:
* platform/qt/css3/images/cross-fade-overflow-position-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd helper macro for forward declaring objective-c classes
weinig@apple.com [Tue, 17 Jan 2012 23:46:16 +0000 (23:46 +0000)]
Add helper macro for forward declaring objective-c classes
https://bugs.webkit.org/show_bug.cgi?id=76485

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* wtf/Compiler.h:
Add OBJC_CLASS macro which helps reduce code when forward declaring an
objective-c class in a header which can be included from both Objective-C
and non-Objective-C files.

Source/WebCore:

* accessibility/AccessibilityObject.h:
* bindings/js/ScriptController.h:
* bridge/objc/objc_utility.h:
* page/DragClient.h:
* page/EditorClient.h:
* platform/AutodrainedPool.h:
* platform/ContextMenuItem.h:
* platform/Cursor.h:
* platform/DragData.h:
* platform/DragImage.h:
* platform/KURL.h:
* platform/Pasteboard.h:
* platform/PlatformKeyboardEvent.h:
* platform/PlatformMenuDescription.h:
* platform/PlatformScreen.h:
* platform/SharedBuffer.h:
* platform/Widget.h:
* platform/cf/SchedulePair.h:
* platform/graphics/BitmapImage.h:
* platform/graphics/FontPlatformData.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/GraphicsLayer.h:
* platform/graphics/Icon.h:
* platform/graphics/Image.h:
* platform/graphics/MediaPlayer.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/mac/ColorMac.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerProxy.h:
* platform/mac/ClipboardMac.h:
* platform/mac/LocalCurrentGraphicsContext.h:
* platform/mac/PasteboardHelper.h:
* platform/mac/PopupMenuMac.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/WebCoreSystemInterface.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/cf/AuthenticationChallenge.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceResponse.h:
* rendering/RenderThemeMac.h:
Deploy OBJC_CLASS for a little code reduction.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebDragClient.h:
Deploy OBJC_CLASS for a little code reduction.

* config.h:
Remove duplicate copy of OBJC_CLASS.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[chromium] Fix duplicate expectations for canvas tests on mac
jamesr@google.com [Tue, 17 Jan 2012 23:31:57 +0000 (23:31 +0000)]
[chromium] Fix duplicate expectations for canvas tests on mac

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION (r101413): Correction panel overlaps misspelled text.
enrica@apple.com [Tue, 17 Jan 2012 23:26:12 +0000 (23:26 +0000)]
REGRESSION (r101413): Correction panel overlaps misspelled text.
https://bugs.webkit.org/show_bug.cgi?id=74589
<rdar://problem/10585115>

When converting the rectangle from the root view, we need
to take into account the height of the rectangle.

Reviewed by Anders Carlsson.

* WebView/WebView.mm:
(-[WebView _convertRectFromRootView:]):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoConvert some fast/regions pixel tests to reftests
commit-queue@webkit.org [Tue, 17 Jan 2012 23:25:53 +0000 (23:25 +0000)]
Convert some fast/regions pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=74133

Patch by Jacob Goldstein <jacobg@adobe.com> on 2012-01-17
Reviewed by Tony Chang.

* fast/regions/webkit-flow-inlines-dynamic-expected.html: Added.
* fast/regions/webkit-flow-inlines-dynamic.html:
* platform/efl/fast/regions/webkit-flow-inlines-dynamic-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Removed.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Removed.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: fix json import on linux
dpranke@chromium.org [Tue, 17 Jan 2012 23:10:46 +0000 (23:10 +0000)]
webkitpy: fix json import on linux
https://bugs.webkit.org/show_bug.cgi?id=76481

Reviewed by Adam Barth.

For some reason, the version of simplejson autoinstalled on my linux
box seems to be broken. We should really only be using
simplejson if json isn't available anyway, so this change looks
for json first.

* Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
(JSONGeneratorTest.test_test_timings_trie):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix failures in test-webkitpy caused by r105177.
dpranke@chromium.org [Tue, 17 Jan 2012 22:31:33 +0000 (22:31 +0000)]
Fix failures in test-webkitpy caused by r105177.

Unreviewed, build fix.

* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort._determine_driver_path_statically):
(ChromiumLinuxPort._static_build_path):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Unreviewed gardening after r105172.
ossy@webkit.org [Tue, 17 Jan 2012 22:14:49 +0000 (22:14 +0000)]
[Qt] Unreviewed gardening after r105172.

* platform/qt/css3/images/cross-fade-overflow-position-expected.png:
* platform/qt/css3/images/cross-fade-overflow-position-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd some canvas tests to test_expectations to prepare for changes to use sw-rasterize...
commit-queue@webkit.org [Tue, 17 Jan 2012 21:43:47 +0000 (21:43 +0000)]
Add some canvas tests to test_expectations to prepare for changes to use sw-rasterized paths in skia-gpu
https://bugs.webkit.org/show_bug.cgi?id=76469

Patch by Brian Salomon <bsalomon@google.com> on 2012-01-17
Reviewed by Stephen White.

* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSpaceSplitString: Share equivalent string piece vectors.
kling@webkit.org [Tue, 17 Jan 2012 20:57:23 +0000 (20:57 +0000)]
SpaceSplitString: Share equivalent string piece vectors.
<http://webkit.org/b/76458>

Reviewed by Antti Koivisto.

Make SpaceSplitStringData ref-counted and cache them in a hashmap to reduce memory
usage and avoid redundant string splitting work.  This reduces memory consumption
by 618 kB (on 64-bit) when viewing the full HTML5 spec at <http://whatwg.org/c>

* dom/SpaceSplitString.h:

    Add the source string to SpaceSplitStringData so we have a key for uncaching
    in the destructor. Also bumped the vector's inline size from 2 to 4.

* dom/SpaceSplitString.cpp:
(WebCore::sharedDataMap):
(WebCore::SpaceSplitStringData::create):
(WebCore::SpaceSplitStringData::createUnique):
(WebCore::SpaceSplitStringData::SpaceSplitStringData):
(WebCore::SpaceSplitString::SpaceSplitString):
(WebCore::SpaceSplitString::set):
(WebCore::SpaceSplitStringData::createVector):

    Added create helpers for SpaceSplitStringData. Moved case folding from
    createVector() to create(AtomicString). Added a hash map for caching
    AtomicString -> SpaceSplitStringData.

(WebCore::SpaceSplitStringData::~SpaceSplitStringData):

    Remove the SpaceSplitStringData from the sharedDataMap().

* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitString::ensureUnique):

    Added, detaches from the shared SpaceSplitStringData if necessary.

(WebCore::SpaceSplitStringData::add):
(WebCore::SpaceSplitStringData::remove):

    Assert that add() and remove() are only used on unique SpaceSplitStringData.

(WebCore::SpaceSplitString::add):
(WebCore::SpaceSplitString::remove):

    Call ensureUnique() to potentially detach from a shared SpaceSplitStringData
    before making modifications.

* dom/SpaceSplitString.cpp:
(WebCore::SpaceSplitStringData::containsAll):

    Added gratuitous fast path for containsAll(*this).

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: make PortFactory.get() be fully data-driven
dpranke@chromium.org [Tue, 17 Jan 2012 20:32:59 +0000 (20:32 +0000)]
webkitpy: make PortFactory.get() be fully data-driven
https://bugs.webkit.org/show_bug.cgi?id=76360

Reviewed by Eric Seidel.

Refactor PortFactory.get() to be fully data-driven.

* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.get.in):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.assert_port):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowebkitpy: add determine_full_port_name(), clean up port.__init__()
dpranke@chromium.org [Tue, 17 Jan 2012 20:27:35 +0000 (20:27 +0000)]
webkitpy: add determine_full_port_name(), clean up port.__init__()
https://bugs.webkit.org/show_bug.cgi?id=76357

Reviewed by Adam Barth.

Each Port class is now required to implement a 'port_name' field
that will match the start of all ports constructed by this class and
a 'determine_full_port_name' field that will make the port
fully-qualified.

* Scripts/webkitpy/layout_tests/port/apple.py:
(ApplePort.__init__):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port):
(Port.determine_port_name):
(Port.__init__):
* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.for):
(ChromiumPort.__init__):
(ChromiumPort):
(ChromiumPort._chromium_base_dir):
(ChromiumPort.path_from_chromium_base):
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
(ChromiumGpuLinuxPort):
(ChromiumGpuLinuxPort.__init__):
(ChromiumGpuMacPort):
(ChromiumGpuMacPort.__init__):
(ChromiumGpuWinPort):
(ChromiumGpuWinPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_linux.py:
(ChromiumLinuxPort):
(ChromiumLinuxPort.determine_port_name):
(ChromiumLinuxPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
(ChromiumMacPort):
(ChromiumMacPort.determine_port_name):
(ChromiumMacPort.__init__):
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort):
(ChromiumWinPort.determine_port_name):
(ChromiumWinPort.__init__):
* Scripts/webkitpy/layout_tests/port/dryrun.py:
(DryRunPort):
(DryRunPort.determine_port_name):
(DryRunPort.__init__):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory):
(PortFactory._default_port):
(PortFactory.get):
(PortFactory.get.in):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(FactoryTest.assert_port):
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.determine_port_name):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.determine_port_name):
(GoogleChromeMacPort):
(GoogleChromeMacPort.determine_port_name):
(GoogleChromeWinPort):
(GoogleChromeWinPort.determine_port_name):
* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort):
* Scripts/webkitpy/layout_tests/port/mac.py:
(MacPort):
(MacPort.determine_port_name):
(MacPort.__init__):
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
(test_versions):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(MockDRTPort):
(MockDRTPort.determine_port_name):
(MockDRTPort.__init__):
(MockDRT):
(MockDRT.determine_port_name):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.make_port):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_port_name):
(QtPort.__init__):
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort):
(TestPort.determine_port_name):
(TestPort.__init__):
* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitPort.__init__):
* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort):
(WinPort.determine_port_name):
* Scripts/webkitpy/tool/servers/rebaselineserver.py:
(get_test_baselines.AllPlatformsPort.__init__):
* Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
(get_test_config.TestMacPort):
(get_test_config):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@105183 268f45cc-cd09-0410-ab3c-d52691b4dbfc