Kazu Hirata [Sat, 23 Jul 2022 20:01:14 +0000 (13:01 -0700)]
[Vectorize] Remove isConsecutiveLoadOrStore (NFC)
The last use was removed on Jan 4, 2022 in commit
95a93722db2d10753f8887cf6a61380936d32f1c.
Kazu Hirata [Sat, 23 Jul 2022 19:29:05 +0000 (12:29 -0700)]
[AMDGPU] Remove a redundant variable (NFC)
ArrayRef has operator[], so we don't need to access the contents via
data().
Kazu Hirata [Sat, 23 Jul 2022 19:17:27 +0000 (12:17 -0700)]
Convert for_each to range-based for loops (NFC)
Kazu Hirata [Sat, 23 Jul 2022 18:35:19 +0000 (11:35 -0700)]
[Analysis] Remove a redundant return statement (NFC)
Identified with readability-redundant-control-flow.
Fangrui Song [Sat, 23 Jul 2022 18:32:02 +0000 (11:32 -0700)]
[AMDGPU] Change DEBUG_TYPE from isel to amdgpu-isel
to match all other *ISelDAGToDAG.cpp
Kazu Hirata [Sat, 23 Jul 2022 18:30:23 +0000 (11:30 -0700)]
[TableGen] Drop an unnecessary const from a return type (NFC)
This patch also drops "&" that binds to a temporary.
Identified with readability-const-return-type.
Kazu Hirata [Sat, 23 Jul 2022 17:50:26 +0000 (10:50 -0700)]
[ADT] Use default member initialization (NFC)
Identified with modernize-use-default-member-init.
Peter Klausler [Fri, 22 Jul 2022 18:51:20 +0000 (11:51 -0700)]
[flang] Correct IsHostAssociated() to be true for BLOCK constructs
The predicate IsHostAssocited() was implemented in a way that would
return true only for cases of host association into a module or inner
subprogram. Technically, the use of a name in a BLOCK construct
that is not declared therein is considered in the Fortran standard
to also be a form of host association, and this matters when doing
error checking on DATA statements.
Differential Revision: https://reviews.llvm.org/D130388
Simon Pilgrim [Sat, 23 Jul 2022 17:38:48 +0000 (18:38 +0100)]
[DAG] isSplatValue - don't attempt to merge any BITCAST sub elements if they contain UNDEFs
We still haven't found a solution that correctly handles 'don't care' sub elements properly - given how close it is to the next release branch, I'm making this fail safe change and we can revisit this later if we can't find alternatives.
NOTE: This isn't a reversion of D128570 - it's the removal of undef handling across bitcasts entirely
Fixes #56520
Simon Pilgrim [Sat, 23 Jul 2022 17:18:39 +0000 (18:18 +0100)]
[X86] Add test case for Issue #56520
Peter Klausler [Mon, 18 Jul 2022 21:12:21 +0000 (14:12 -0700)]
[flang] Clean up bogus semantic error on procedure pointer assignment
When a procedure pointer with no interface is associated with
an EXTERNAL name with no interface information, but it is later
inferred that the procedure pointer must be a subroutine because it
appears in a CALL statement, don't complain that the EXTERNAL name
is not also known to be a subroutine.
Subroutine vs. function errors are still caught in procedure pointer
assignment compatibility checking; this fix simply ensures that those
more nuanced tests are not overridded by the attribute set equality test.
Also, leave in some code for dumping the differing attributes in legitimate
error cases that was added in the coures of debugging the specific problem.
Differential Revision: https://reviews.llvm.org/D130385
Jez Ng [Sat, 23 Jul 2022 16:21:46 +0000 (12:21 -0400)]
[lld-macho][nfc] Reduce nesting of code added in D130125
Peter Klausler [Mon, 18 Jul 2022 20:13:03 +0000 (13:13 -0700)]
[flang] Don't fold zero-length substring references
In some contexts the code looks cleaner if we fold zero-length substring
references into empty character constants, but those don't work in
variable definition contexts and can lead to bogus semantic error
messages.
Differential Revision: https://reviews.llvm.org/D130383
Nico Weber [Sat, 23 Jul 2022 16:31:31 +0000 (12:31 -0400)]
Revert "[NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute." and follow-ups
This reverts commit
9429b67b8e300e638d7828bbcb95585f85c4df4d.
It broke the build on Windows, see comments on https://reviews.llvm.org/D130309
It also reverts these follow-ups:
Revert "Fix buildbot breakage after https://reviews.llvm.org/D130309."
This reverts commit
f959d815f4637890ebbacca379f1c38ab47e4e14.
Revert "Fix buildbot breakage after https://reviews.llvm.org/D130309."
This reverts commit
0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24.
Revert "Cache the value for absolute path in FileSpec."
This reverts commit
dabe877248b85b34878e75d5510339325ee087d0.
Peter Klausler [Mon, 18 Jul 2022 18:30:29 +0000 (11:30 -0700)]
[flang] Fix name of dummy argument to intrinsic NEW_LINE(A='')
It should be A= but I misspelled it in the intrinsics table as X=.
Differential Revision: https://reviews.llvm.org/D130382
John Ericson [Fri, 22 Jul 2022 14:24:54 +0000 (14:24 +0000)]
Fix one stray `{LLVM -> CLANG}_TOOLS_INSTALL_DIR`
Follow up to D117977, where I missed this new usage after one rebase.
Thanks @tsteller in https://reviews.llvm.org/D117977#3670919 for
noticing.
Reviewed By: mstorsjo
Differential Revision: https://reviews.llvm.org/D130362
Kazu Hirata [Sat, 23 Jul 2022 16:22:27 +0000 (09:22 -0700)]
Use static_assert instead of assert (NFC)
Identified with misc-static-assert.
Jez Ng [Sat, 23 Jul 2022 16:11:46 +0000 (12:11 -0400)]
[lld-macho] Fold __objc_imageinfo sections
Previously, we treated it as a regular ConcatInputSection. However, ld64
actually parses its contents and uses that to synthesize a single image
info struct, generating one 8-byte section instead of `8 * number of
object files with ObjC code`.
I'm not entirely sure what impact this section has on the runtime, so I
just tried to follow ld64's semantics as closely as possible in this
diff. My main motivation though was to reduce binary size.
No significant perf change on chromium_framework on my 16-core Mac Pro:
base diff difference (95% CI)
sys_time 1.764 ± 0.062 1.748 ± 0.032 [ -2.4% .. +0.5%]
user_time 5.112 ± 0.104 5.106 ± 0.046 [ -0.9% .. +0.7%]
wall_time 6.111 ± 0.184 6.085 ± 0.076 [ -1.6% .. +0.8%]
samples 30 32
Reviewed By: #lld-macho, thakis
Differential Revision: https://reviews.llvm.org/D130125
Simon Pilgrim [Sat, 23 Jul 2022 15:56:39 +0000 (16:56 +0100)]
[X86] matchBinaryShuffle - limit SHUFFLE(X,Y) -> OR(X,Y) cases to where X + Y are the same width as the result
Minor bit of prep work toward not unnecessarily widening shuffle operands in combineX86ShufflesRecursively, instead only widening in combineX86ShuffleChain if we actual find a match - see Issue #45319
Jez Ng [Sat, 23 Jul 2022 15:47:44 +0000 (11:47 -0400)]
[lld-macho] Fix segfault when handling LTO + object file weak defs
which occurs when there are EH frames present in the object file's weak
def.
Reviewed By: abrachet
Differential Revision: https://reviews.llvm.org/D130409
Dmitry Vassiliev [Sat, 23 Jul 2022 14:28:18 +0000 (16:28 +0200)]
[IR] Fixed ambiguous call to llvm::report_fatal_error
This patch fixes the following error with MSVC 16.9.2:
llvm/lib/IR/GCStrategy.cpp(35): error C2668: 'llvm::report_fatal_error': ambiguous call to overloaded function
llvm/include/llvm/Support/ErrorHandling.h(75): note: could be 'void llvm::report_fatal_error(const llvm::Twine &,bool)'
llvm/include/llvm/Support/ErrorHandling.h(73): note: or 'void llvm::report_fatal_error(llvm::StringRef,bool)'
llvm/lib/IR/GCStrategy.cpp(35): note: while trying to match the argument list '(const std::string)'
Reviewed By: RKSimon, barannikov88
Differential Revision: https://reviews.llvm.org/D130407
Dmitri Gribenko [Sat, 23 Jul 2022 13:14:14 +0000 (15:14 +0200)]
Use llvm::sort instead of std::sort where possible
llvm::sort is beneficial even when we use the iterator-based overload,
since it can optionally shuffle the elements (to detect
non-determinism). However llvm::sort is not usable everywhere, for
example, in compiler-rt.
Reviewed By: nhaehnle
Differential Revision: https://reviews.llvm.org/D130406
Corentin Jabot [Sat, 23 Jul 2022 13:15:12 +0000 (15:15 +0200)]
[Clang] Update the status of N2393 in c_status.html
Dmitri Gribenko [Sat, 23 Jul 2022 13:07:49 +0000 (15:07 +0200)]
Use the range-based overload of llvm::sort where possible
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D130403
Simon Pilgrim [Sat, 23 Jul 2022 12:11:07 +0000 (13:11 +0100)]
[DAG] Move OR(AND(X,C1),AND(OR(X,Y),C2)) -> OR(AND(X,OR(C1,C2)),AND(Y,C2)) fold to SimplifyDemandedBits
This will fix the SystemZ v3i31 memcpy regression in D77804 (with the help of D129765 as well....).
It should also allow us to /bend/ the oneuse limitation for cases where we can use demanded bits to safely peek though multiple uses of the AND ops.
Corentin Jabot [Sat, 23 Jul 2022 09:08:14 +0000 (11:08 +0200)]
[Clang] Adjust extension warnings for #warning
The #warning directive is standard in C++2b and C2x,
this adjusts the pedantic and extensions warning accordingly.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D130415
Corentin Jabot [Sat, 23 Jul 2022 10:18:01 +0000 (12:18 +0200)]
[Clang] Add support for Unicode identifiers (UAX31) in C2x mode.
This implements
N2836 Identifier Syntax using Unicode Standard Annex 31.
The feature was already implemented for C++,
and the semantics are the same.
Unlike C++ there was, afaict, no decision to
backport the feature in older languages mode,
so C17 and earlier are not modified and the
code point tables for these language modes are conserved.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D130416
Benjamin Kramer [Sat, 23 Jul 2022 11:25:23 +0000 (13:25 +0200)]
Simon Pilgrim [Sat, 23 Jul 2022 11:01:54 +0000 (12:01 +0100)]
[DAG] SimplifyDemandedBits - pull out repeated getValueType() calls. NFC.
Simon Pilgrim [Sat, 23 Jul 2022 10:13:37 +0000 (11:13 +0100)]
[DAG] ExpandIntRes_ADDSUB - create UADDO/USUBO instead of ADDCARRY/SUBCARRY if overflow is known to be zero
As noticed on D127115, when splitting ADD/SUB nodes we often end up with cases where overflow from the lower bits is impossible - in such cases we're better off breaking the carry chain dependency as soon as possible.
This path is being exercised by llvm/test/CodeGen/ARM/dsp-mlal.ll, although I haven't been able to get any codegen diff without a topological worklist.
Dimitrije Milosevic [Sat, 23 Jul 2022 08:24:15 +0000 (10:24 +0200)]
[MIPS][compiler-rt] Fix stat struct's size for O32 ABI
Add the MIPS O32 ABI value for the stat struct's size.
Differential Revision: https://reviews.llvm.org/D129749.
Simon Pilgrim [Sat, 23 Jul 2022 08:46:30 +0000 (09:46 +0100)]
[DAG] computeKnownBits - add basic shift-by-parts handling
Concat KnownBits from ISD::SHL_PARTS / ISD::SRA_PARTS / ISD::SRL_PARTS lo/hi operands and perform the KnownBits calculation by the shift amount on the extended type, before splitting the KnownBits based on the requested lo/hi result.
Kazu Hirata [Sat, 23 Jul 2022 07:28:31 +0000 (00:28 -0700)]
Use callables directly in any_of, count_if, etc (NFC)
Peixin Qiao [Sat, 23 Jul 2022 06:44:20 +0000 (14:44 +0800)]
[flang] Support aint/anint for 80/128 bit in lowering
For aint/anint, LLVM conversion operations llvm.trunc and llvm.round
can support the edge case of aint(-0.) and anint(-0.). The output is -0.
and it is the same of `gfortran` and `classic flang`, while the output
of `ifort` is 0.. The `real(10)/real(16)` is not supported before.
Support it and remove the runtime functions for aint/anint.
For nint, `gfortran`, `ifort`, and LLVM Flang using llvm.lround have
different results when the magnitude of argument is more than the max of
result value range. So delay its support in lowering after more
investigations.
Reviewed By: vzakhari
Differential Revision: https://reviews.llvm.org/D130024
Kazu Hirata [Sat, 23 Jul 2022 06:33:46 +0000 (23:33 -0700)]
[mlir] Use value instead of getValue (NFC)
Kazu Hirata [Sat, 23 Jul 2022 06:04:38 +0000 (23:04 -0700)]
Use has_value instead of hasValue (NFC)
Jun Zhang [Sat, 23 Jul 2022 04:29:18 +0000 (12:29 +0800)]
[NFC] Move function definition to cpp file
Signed-off-by: Jun Zhang <jun@junz.org>
Johannes Doerfert [Sat, 23 Jul 2022 04:56:12 +0000 (23:56 -0500)]
[Attributor][FIX] HasBeenWrittenTo logic should only be used for reads
If we look at a write, we should not enact the "has been written to"
logic introduced to avoid spurious write -> read dependences. Doing so
lead to elimination of stores we needed, which is obviously bad.
Peter Klausler [Sat, 16 Jul 2022 00:33:44 +0000 (17:33 -0700)]
[flang] Fold calls to ISHFTC()
The integer arithmetic template supports ISHFTC() but the
integer intrinsic folding code had yet to call it; finish
the job.
Differential Revision: https://reviews.llvm.org/D130379
Kazu Hirata [Sat, 23 Jul 2022 00:56:10 +0000 (17:56 -0700)]
[flang] Fix a warning
This patch fixes:
llvm-project/flang/lib/Semantics/expression.cpp:405:12: error:
moving a local object in a return statement prevents copy elision
[-Werror,-Wpessimizing-move]
Ivan Trofimov [Mon, 11 Jul 2022 17:12:31 +0000 (10:12 -0700)]
[libasan] Remove 4Mb stack limit for swapcontext unpoisoning
Reviewed By: vitalybuka, eugenis
Differential Revision: https://reviews.llvm.org/D129219
Peter Klausler [Fri, 15 Jul 2022 19:15:07 +0000 (12:15 -0700)]
[flang] Correct folding of TRANSFER(integer, character array)
The code that copies data from a constant source array into a character
array constant result was failing to copy its last element if it was
only partially defined due to misalignment.
Differential Revision: https://reviews.llvm.org/D130376
Fangrui Song [Sat, 23 Jul 2022 00:16:41 +0000 (17:16 -0700)]
[Driver] Error for -gsplit-dwarf with RISC-V linker relaxation
-gsplit-dwarf produces a .dwo file which will not be processed by the linker. If
.dwo files contain relocations, they will not be resolved. Therefore the
practice is that .dwo files do not contain relocations.
Address ranges and location description need to use forms/entry kinds indexing
into .debug_addr (DW_FORM_addrx/DW_RLE_startx_endx/etc), which is currently not
implemented.
There is a difficult-to-read MC error with -gsplit-dwarf with RISC-V for both -mrelax and -mno-relax.
```
% clang --target=riscv64-linux-gnu -g -gsplit-dwarf -c a.c
error: A dwo section may not contain relocations
```
We expect to fix -mno-relax soon, so report a driver error for -mrelax for now.
Link: https://github.com/llvm/llvm-project/issues/56642
Reviewed By: compnerd, kito-cheng
Differential Revision: https://reviews.llvm.org/D130190
Peter Klausler [Fri, 22 Jul 2022 17:52:30 +0000 (10:52 -0700)]
[flang] Fix parsing and semantics for array element substring%KIND/%LEN
A type-param-inquiry of %KIND or %LEN applies to a designator, and
so must also be allowed for a substring. F18 presently (mis)parses
instances of a type-param-inquiry as structure component references
and then fixes them in expression semantics when types are known and
we can distinguish them. But when the base of a type-param-inquiry is
a substring of an array element, as in "charArray(i)(j:k)%len",
parsing fails.
Adjust the grammar to parse these cases, and extend expression semantics
to process the new production.
Differential Revision: https://reviews.llvm.org/D130375
Ilya Leoshkevich [Fri, 22 Jul 2022 23:38:26 +0000 (01:38 +0200)]
[Lit] Pass through DFLTCC from the surrounding environment
Many distros ship zlib with the IBM Z deflate hardware acceleration
patch [1]. Sometimes it's desirable to disable the acceleration, for
example, for reproducibility. This can be done by exporting DFLTCC=0.
llvm-lit clears this environment variable, which causes
compress-debug-sections-zlib.test fail on z15 and later machines. Add
DFLTCC to the list of variables to keep.
[1] https://github.com/madler/zlib/pull/410
Reviewed By: abrachet
Differential Revision: https://reviews.llvm.org/D130253
Dmitri Gribenko [Fri, 22 Jul 2022 23:23:17 +0000 (01:23 +0200)]
[clang][dataflow] Add DataflowEnvironment::dump()
Start by dumping the flow condition.
Reviewed By: ymandel
Differential Revision: https://reviews.llvm.org/D130398
Volodymyr Sapsai [Fri, 22 Jul 2022 18:43:07 +0000 (11:43 -0700)]
Move "clang/Basic/TokenKinds.h" into a separate top-level module.
Fixes modular build for clangPseudoGrammar from clang-tools-extra.
Starting from https://reviews.llvm.org/D126731 clangPseudoGrammar
doesn't depend on generated .inc headers but still depends on
"Basic/TokenKinds.h". It means clangPseudoGrammar depends on module
'Clang_Basic' which does depend on generated .inc headers. To avoid
these coarse dependencies and extra build steps, extract
"clang/Basic/TokenKinds.h" into a top-level module 'Clang_Basic_TokenKinds'.
rdar://
97387951
Differential Revision: https://reviews.llvm.org/D130377
Peter Klausler [Mon, 18 Jul 2022 18:16:01 +0000 (11:16 -0700)]
[flang] Admit trailing blanks when checking I/O specifiers
Fortran specifically allows character-valued I/O specifiers
to have trailing blanks, e.g. OPEN(666,STATUS='SCRATCH ').
The runtime I/O library already handles them, but the I/O
static checks in semantics do not.
Differential Revision: https://reviews.llvm.org/D130381
Dmitri Gribenko [Fri, 22 Jul 2022 23:18:03 +0000 (01:18 +0200)]
[clang][dataflow] Expose stringification functions for SAT solver enums
Reviewed By: ymandel
Differential Revision: https://reviews.llvm.org/D130399
Ryan Prichard [Fri, 22 Jul 2022 23:20:47 +0000 (16:20 -0700)]
[libc++][test] Fix infinite loop when mkstemp fails
mkstemp is guaranteed to make at least TMP_MAX attempts to create the
random file, and if it can't, it fails with EEXIST. get_temp_file_name
shouldn't call mkstemp again if it fails with anything other than
EEXIST. A single mkstemp call seems sufficient.
On Android, I've seen mkstemp fail with:
- EROFS (because cwd wasn't set to a writable filesystem)
- EACCES (because cwd pointed to a dir owned by root, but the test
program was running as the shell user instead)
Previously, get_temp_file_name would run forever in these situations.
See D4962 and "llvm-svn: 229035"
Reviewed By: #libc, ldionne
Differential Revision: https://reviews.llvm.org/D130214
Dmitri Gribenko [Fri, 22 Jul 2022 23:13:24 +0000 (01:13 +0200)]
[clang][dataflow] ArrayRef'ize debugString()
Reviewed By: ymandel
Differential Revision: https://reviews.llvm.org/D130400
Augusto Noronha [Fri, 22 Jul 2022 23:06:49 +0000 (16:06 -0700)]
[lldb] Remote accidental logs left in TestGuiExpandThreadsTree
Augusto Noronha [Fri, 22 Jul 2022 22:59:58 +0000 (15:59 -0700)]
[lldb] Disable TestGuiExpandThreadsTree
Peter Klausler [Fri, 15 Jul 2022 21:34:32 +0000 (14:34 -0700)]
[flang] Fold SET_EXPONENT() and FRACTION()
Fold the intrinsic function SET_EXPONENT() and its special case,
FRACTION().
Differential Revision: https://reviews.llvm.org/D130378
Med Ismail Bennani [Fri, 22 Jul 2022 22:21:34 +0000 (15:21 -0700)]
Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator"
This reverts commit
b797834748f1954950880bf50fb78abedd4494e6, since it
breaks building Clang: https://reviews.llvm.org/D129377
ARCHIT SAXENA [Fri, 22 Jul 2022 22:02:16 +0000 (15:02 -0700)]
Add a nop instruction if a section starts with landing pad for function splitter
This change adds a nop instruction if section starts with landing pad. This change is like [D73739](https://reviews.llvm.org/D73739) which avoids zero offset landing pad in basic block sections.
Detailed description:
The current machine functions splitter can create ˜sections which start with a landing pad themselves. This places landing pad at offset zero from LPStart.
```
.section .text.split.foo10,"ax",@progbits
foo10.cold: # %lpad
.cfi_startproc
.cfi_personality 3, __gxx_personality_v0
.cfi_lsda 3, .Lexception5
.cfi_def_cfa %rsp, 16
.Ltmp11: <--- This is a Landing pad and also LP Start as it is start of this section
movq %rax, %rdi <--- first instruction is at offest 0 from LPStart
callq _Unwind_Resume@PLT
```
This will cause landing pad entries to become zero (.Ltmp11-foo10.cold)
```
.Lcst_begin4:
.uleb128 .Ltmp9-.Lfunc_begin2 # >> Call Site 1 <<
.uleb128 .Ltmp10-.Ltmp9 # Call between .Ltmp9 and .Ltmp10
.uleb128 .Ltmp11-foo10.cold <---This is zero # jumps to .Ltmp11
.byte 3 # On action: 2
.uleb128 .Ltmp10-.Lfunc_begin2 # >> Call Site 2 <<
.uleb128 .Lfunc_end9-.Ltmp10 # Call between .Ltmp10 and .Lfunc_end9
.byte 0 # has no landing pad
.byte 0 # On action: cleanup
.p2align 2
```
The C++ ABI somehow assumes that no landing pads point directly to LPStart (which works in the normal case since the function begin is never a landing pad), and uses LP.offset = 0 to specify no landing pad. This change adds a nop instruction at start of such sections so that such a case could be avoided. Output:
```
.section .text.split.foo10,"ax",@progbits
foo10.cold: # %lpad
.cfi_startproc
.cfi_personality 3, __gxx_personality_v0
.cfi_lsda 3, .Lexception5
.cfi_def_cfa %rsp, 16
nop <--- new instruction that is added
.Ltmp11:
movq %rax, %rdi
callq _Unwind_Resume@PLT
```
Reviewed By: modimo, snehasish, rahmanl
Differential Revision: https://reviews.llvm.org/D130133
Alexander Shaposhnikov [Fri, 22 Jul 2022 22:08:47 +0000 (22:08 +0000)]
[InstCombine] Improve folding of mul + icmp
This diff adds folds for patterns like X * A < B
where A, B are constants and "mul" has either "nsw" or "nuw".
(to address https://github.com/llvm/llvm-project/issues/56563).
Test plan:
1/ ninja check-llvm check-clang
2/ Bootstrapped LLVM/Clang pass tests
Differential revision: https://reviews.llvm.org/D130039
Fangrui Song [Fri, 22 Jul 2022 22:07:28 +0000 (15:07 -0700)]
[Driver] Report -Wunused-command-line-argument for unimplemented -mtune=
Most common architectures (aarch64,riscv,s390x,x86,etc) have implemented -mtune=.
Don't ignore -mtune= in generic code.
Fangrui Song [Fri, 22 Jul 2022 21:54:27 +0000 (14:54 -0700)]
[Driver][SystemZ] Simplify -mtune
Similar to AArch64.
Fangrui Song [Fri, 22 Jul 2022 21:51:07 +0000 (14:51 -0700)]
[Driver][RISCV] Simplify -mtune
Fangrui Song [Fri, 22 Jul 2022 21:37:58 +0000 (14:37 -0700)]
[Driver][test] Clean up and improve some -mtune tests
Note: we should test CHECK-NOT: "-tune-cpu" instead of CHECK-NOT: "-tune-cpu" "generic"
Chelsea Cassanova [Mon, 11 Jul 2022 21:24:50 +0000 (17:24 -0400)]
[lldb/Fuzzer] Add fuzzer for expression evaluator
This commit adds a fuzzer for LLDB's expression evaluator.
The fuzzer takes a different approach than the current fuzzers
present, and uses an approach that is currently being used for
clang fuzzers.
Instead of fuzzing the evaluator with randomly mutated
characters, protobufs are used to generate a subset of C++. This
is then converted to valid C++ code and sent to the expression
evaluator. In addition, libprotobuf_mutator is used to mutate
the fuzzer's inputs from valid C++ code to valid C++ code, rather
than mutating from valid code to total nonsense.
Differential revision: https://reviews.llvm.org/D129377
Fangrui Song [Fri, 22 Jul 2022 21:19:27 +0000 (14:19 -0700)]
[Driver][AArch64] Simplify -mtune
llvm::sys::getHostCPUName()'s return value is not empty. `-mtune=` (empty value)
has caused a driver error. So we can omit `!TuneCPU.empty()` check.
Kjetil Kjeka [Fri, 22 Jul 2022 20:59:11 +0000 (13:59 -0700)]
[NVPTX] Promote i24, i40, i48 and i56 to next power-of-two register when passing
Today llc will crash when attempting to use non-power-of-two integer types as
function arguments or returns. This patch enables passing non standard integer
values in functions by promoting them before store and truncating after load.
The main motivation of implementing this change is that rust casts small structs
(less than pointer size) into an integer of the same size. As an example, if a
struct contains three u8 then it will be passed as an i24. This patch is a step
towards enabling rust compilation to ptx while retaining the target independent
optimizations.
More context can be found in https://github.com/llvm/llvm-project/issues/55764
Differential Revision: https://reviews.llvm.org/D129291
Artem Belevich [Fri, 22 Jul 2022 21:09:42 +0000 (14:09 -0700)]
Changed EOL to UNIX. NFC.
Greg Clayton [Fri, 22 Jul 2022 20:18:40 +0000 (13:18 -0700)]
Cache the value for absolute path in FileSpec.
Checking if a path is absolute can be expensive and currently the result is not cached in the FileSpec object. This patch adds caching and also code to clear the cache if the file is modified.
Differential Revision: https://reviews.llvm.org/D130396
Greg Clayton [Fri, 22 Jul 2022 20:59:06 +0000 (13:59 -0700)]
Fix buildbot breakage after https://reviews.llvm.org/D130309.
Nikolas Klauser [Sun, 10 Jul 2022 19:58:01 +0000 (21:58 +0200)]
[runtimes] Add pstl to the list of default runtimes to fix the build
Reviewed By: ldionne, #libc, #libc_abi
Spies: h-vetinari, sstefan1, libcxx-commits, mgorny
Differential Revision: https://reviews.llvm.org/D129452
rkayaith [Sat, 16 Jul 2022 20:41:33 +0000 (16:41 -0400)]
[mlir][python] Fix issue in diagnostic note initialization
Previously the elements of the notes tuple would be invalid objects when
accessed from a diagnostic handler, resulting in a segfault when used.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D129943
Vitaly Buka [Thu, 21 Jul 2022 01:23:17 +0000 (18:23 -0700)]
[asan] Reset stack bounds of context
ClearShadowMemoryForContextStack assumes that context contains the stack
bounds. This is not true for a context from getcontext or oucp of
swapcontext.
Reviewed By: kstoimenov
Differential Revision: https://reviews.llvm.org/D130218
Nuno Lopes [Fri, 22 Jul 2022 20:33:22 +0000 (21:33 +0100)]
Revert "[NFC] Add some additional features to MultiLevelTemplateArgumentList"
This reverts commit
0b36a62d5f3505e21692ae0abf25ef00836329e3.
It breaks the assertion build
Shangwu Yao [Fri, 22 Jul 2022 19:22:08 +0000 (19:22 +0000)]
[CUDA/SPIR-V] Force passing aggregate type byval
This patch forces copying aggregate type in kernel arguments by value when
compiling CUDA targeting SPIR-V. The original behavior is not passing by value
when there is any of destructor, copy constructor and move constructor defined
by user. This patch makes the behavior of SPIR-V generated from CUDA follow
the CUDA spec
(https://docs.nvidia.com/cuda/cuda-c-programming-guide/index.html#global-function-argument-processing),
and matches the NVPTX
implementation (
https://github.com/llvm/llvm-project/blob/
41958f76d8a2c47484fa176cba1de565cfe84de7/clang/lib/CodeGen/TargetInfo.cpp#L7241).
Differential Revision: https://reviews.llvm.org/D130387
Julian Lettner [Fri, 22 Jul 2022 18:33:35 +0000 (11:33 -0700)]
[Sanitizer][Darwin] Factor out code for GCD worker registration
This is a NFC change to factor out GCD worker thread registration via
the pthread introspection hook.
In a follow-up change we also want to register GCD workers for ASan to
make sure threads are registered before we attempt to print reports on
them.
rdar://
93276353
Differential Revision: https://reviews.llvm.org/D126351
Greg Clayton [Fri, 22 Jul 2022 20:24:04 +0000 (13:24 -0700)]
Fix buildbot breakage after https://reviews.llvm.org/D130309.
Erich Keane [Fri, 22 Jul 2022 20:04:59 +0000 (13:04 -0700)]
[NFC] Add some additional features to MultiLevelTemplateArgumentList
These are useful when dealing with multi-depth instantiation in deferred
concepts, so this is split off of that patch.
Shilei Tian [Fri, 22 Jul 2022 20:03:04 +0000 (16:03 -0400)]
[OpenMP][Offloading] Enlarge the work size of `wtime.c` in case of any noise
Alexander Yermolovich [Fri, 22 Jul 2022 20:02:08 +0000 (13:02 -0700)]
Revert "[DWP][DWARF] Detect and error on debug info offset overflow"
This reverts commit
417738d3a66cc65f3fc58ab9535c17fac1ddaff1.
Sanjay Patel [Fri, 22 Jul 2022 18:33:35 +0000 (14:33 -0400)]
Revert "[InstCombine] enhance fold for subtract-from-constant -> xor"
This reverts commit
79bb915fb60b2cd220d89e3bb54f67abb8cdb7bd.
This caused regressions because SCEV works better with sub.
Erich Keane [Fri, 22 Jul 2022 19:52:26 +0000 (12:52 -0700)]
[NFC] give getParentFunctionOrMethod a 'Lexical' parameter
Split up from the deferred concepts implementation, this function is
useful for determining the containing function of a different function.
However, in some cases it is valuable to instead get the lexical parent.
This adds a parameter to the existing function to allow a 'Lexical'
parameter to instead select the lexical parent.
Erich Keane [Fri, 22 Jul 2022 19:30:47 +0000 (12:30 -0700)]
[NFC] Start saving InstantiatedFromDecl in non-template functions
In cases where a non-template function is defined inside a function
template, we don't have information about the original uninstantiated
version. In the case of concepts instantiation, we will need the
ability to get back to the original template. This patch splits a piece
of the deferred concepts instantaition patch off to accomplish the
storage of this, with minor runtime overhead, and zero additional
storage.
Aaron Ballman [Fri, 22 Jul 2022 19:24:54 +0000 (15:24 -0400)]
Strengthen -Wint-conversion to default to an error
Clang has traditionally allowed C programs to implicitly convert
integers to pointers and pointers to integers, despite it not being
valid to do so except under special circumstances (like converting the
integer 0, which is the null pointer constant, to a pointer). In C89,
this would result in undefined behavior per 3.3.4, and in C99 this rule
was strengthened to be a constraint violation instead. Constraint
violations are most often handled as an error.
This patch changes the warning to default to an error in all C modes
(it is already an error in C++). This gives us better security posture
by calling out potential programmer mistakes in code but still allows
users who need this behavior to use -Wno-error=int-conversion to retain
the warning behavior, or -Wno-int-conversion to silence the diagnostic
entirely.
Differential Revision: https://reviews.llvm.org/D129881
Philip Reames [Fri, 22 Jul 2022 19:12:05 +0000 (12:12 -0700)]
[LV] Use early return to simplify code structure
Alex Brachet [Fri, 22 Jul 2022 19:06:54 +0000 (19:06 +0000)]
[CMake] Stop zstd find_package warnings
Fangrui Song [Fri, 22 Jul 2022 18:56:46 +0000 (11:56 -0700)]
[ELF] Internalize isBitcode. NFC
Fangrui Song [Fri, 22 Jul 2022 18:54:27 +0000 (11:54 -0700)]
[ELF] --fortran-common: remove unneeded identify_magic call. NFC
Arnold Schwaighofer [Wed, 20 Jul 2022 20:27:11 +0000 (13:27 -0700)]
llvm.swift.async.context.addr cannot be modeled as NoMem because we don't want it to be cse'd accross async suspends
An async suspend models the split between two partial async functions.
`llvm.swift.async.context.addr ` will have a different value in the two
partial functions so it is not correct to generally CSE the instruction.
rdar://
97336162
Differential Revision: https://reviews.llvm.org/D130201
Joel E. Denny [Fri, 22 Jul 2022 18:38:09 +0000 (14:38 -0400)]
[Libomptarget] Don't report lack of CUDA devices
Sometimes libomptarget's CUDA plugin produces unhelpful diagnostics
about a lack of CUDA devices before an application runs:
```
$ clang -fopenmp -fopenmp-targets=amdgcn-amd-amdhsa hello-world.c
$ ./a.out
CUDA error: Error returned from cuInit
CUDA error: no CUDA-capable device is detected
Hello World: 4
```
This can happen when the CUDA plugin was built but all CUDA devices
are currently disabled in some manner, perhaps because
`CUDA_VISIBLE_DEVICES` is set to the empty string. As shown in the
above example, it can even happen when we haven't compiled the
application for offloading to CUDA.
The following code from `openmp/libomptarget/plugins/cuda/src/rtl.cpp`
appears to be intended to handle this case, and it chooses not to
write a diagnostic to stderr unless debugging is enabled:
```
if (NumberOfDevices == 0) {
DP("There are no devices supporting CUDA.\n");
return;
}
```
The problem is that the above code is never reached because the
earlier `cuInit` returns `CUDA_ERROR_NO_DEVICE`. This patch handles
that `cuInit` case in the same manner as the above code handles the
`NumberOfDevices == 0` case.
Reviewed By: tianshilei1992
Differential Revision: https://reviews.llvm.org/D130371
Sanjay Patel [Fri, 22 Jul 2022 17:56:12 +0000 (13:56 -0400)]
[PhaseOrdering] add test for loop-idiom-recognize + tailcall; NFC
Huan Nguyen [Fri, 22 Jul 2022 18:23:38 +0000 (11:23 -0700)]
[BOLT] Handle broken .dynsym in stripped binaries
Strip tools cause a few symbols in .dynsym to have bad section index.
This update safely keeps such broken symbols intact.
Test Plan:
```
ninja check-bolt
```
Reviewed By: Amir
Differential Revision: https://reviews.llvm.org/D130073
Shilei Tian [Fri, 22 Jul 2022 18:16:47 +0000 (14:16 -0400)]
[OpenMP] Fix test error introduced in D130179
zhijian [Fri, 22 Jul 2022 17:52:18 +0000 (13:52 -0400)]
[AIX][NFC] modify the llvm-ar help information for big archive.
Reviewers: James Henderson
Differential Revision: https://reviews.llvm.org/D130292
Shilei Tian [Fri, 22 Jul 2022 17:46:31 +0000 (13:46 -0400)]
[OpenMP][DeviceRTL] Fix the issue that multiple calls to `omp_get_wtime` is optimized out by mistake
Multiple calls to `omp_get_wtime` could be optimized out due to the function
is mistakenly marked as `readnone`. This patch fixes the issue, and also add the
support to run optimization on `libomptarget` tests.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D130179
zr33 [Fri, 22 Jul 2022 17:45:09 +0000 (10:45 -0700)]
[BOLT][DWARF] Fix bolt/test/X86/shared-abbrev.s
There should not be a end of child mark before DW_AT_ranges, removed it and fixed unit offset.
Reviewed By: ayermolo
Differential Revision: https://reviews.llvm.org/D130335
Alexander Yermolovich [Mon, 18 Jul 2022 22:12:07 +0000 (15:12 -0700)]
[DWP][DWARF] Detect and error on debug info offset overflow
Right now we silently overflow uint32_t for debug_indfo sections. Added a check
and error out.
Differential Revision: https://reviews.llvm.org/D130046
Sergei Barannikov [Fri, 22 Jul 2022 17:45:02 +0000 (10:45 -0700)]
[clang][CodeGen] Only include ABIInfo.h where required (NFC)
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D130322
Paul Kirth [Fri, 22 Jul 2022 17:34:58 +0000 (17:34 +0000)]
[clang-doc] Add check for pointer validity
clang-doc would SEGV when running over the Fuchsia code base.
This patch adds a check to avoid dereferencing potentially null pointers
in the Values vector. These pointers were either never valid or had been
invalidated when the underlying pointer in std::unique_ptr was moved from,
hence making it nullptr within the vector.
Reviewed By: phosek
Differential Revision: https://reviews.llvm.org/D130279
Michael Jones [Wed, 13 Jul 2022 17:17:54 +0000 (10:17 -0700)]
[libc][nfc] move printf inf/nan to separate function
The floating point functions all use the same inf and nan formatting. By
separating this functionality out of the %a conversion I make it
available for reuse by %f/e/g.
Reviewed By: lntue, sivachandra
Differential Revision: https://reviews.llvm.org/D129665
Christopher Bate [Wed, 20 Jul 2022 20:39:30 +0000 (14:39 -0600)]
[mlir][Arithmetic] Add `arith.delinearize_index` operation
This change adds a new DelinearizeIndexOp to the `arith` dialect. The
operation accepts an `index` type as well as a basis (array of index
values) representing how the index should be decomposed into a
multi-index. The decomposition obeys a canonical semantic that treats
the final basis element as "fastest varying" and the first basis element
as "slowest varying". A naive lowering of the operation using a sequence
of `arith.divui` and `arith.remui` operations is also given.
Differential Revision: https://reviews.llvm.org/D129697
Thomas Raoux [Fri, 22 Jul 2022 17:13:22 +0000 (17:13 +0000)]
[mlir][vector] NFC change to improve doc of vector distribution op
Improve doc based on post commit review from https://reviews.llvm.org/D123703
Add more details on the op semantic, explicitly mention what part are parallel
and what parts are serial.
Differential Revision: https://reviews.llvm.org/D125227
Greg Clayton [Thu, 21 Jul 2022 21:43:29 +0000 (14:43 -0700)]
[NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.
The FileSpect APIs allow users to modify instance variables directly by getting a non const reference to the directory and filename instance variables. This makes it impossibly to control all of the times the FileSpec object is modified so we can clear the cache. This patch modifies the APIs of FileSpec so no one can modify the directory or filename directly by adding set accessors and by removing the get accessors that are non const.
Many clients were using FileSpec::GetCString(...) which returned a unique C string from a ConstString'ified version of the result of GetPath() which returned a std::string. This caused many locations to use this convenient function incorrectly and could cause many strings to be added to the constant string pool that didn't need to. Most clients were converted to using FileSpec::GetPath().c_str() when possible. Other clients were modified to use the newly renamed version of this function which returns an actualy ConstString:
ConstString FileSpec::GetPathAsConstString(bool denormalize = true) const;
This avoids the issue where people were getting an already uniqued "const char *" that came from a ConstString only to put the "const char *" back into a "ConstString" object. By returning the ConstString instead of a "const char *" clients can be more efficient with the result.
The patch:
- Removes the non const GetDirectory() and GetFilename() get accessors
- Adds set accessors to replace the above functions: SetDirectory() and SetFilename().
- Adds ClearDirectory() and ClearFilename() to replace usage of the FileSpec::GetDirectory().Clear()/FileSpec::GetFilename().Clear() call sites
- Fixed all incorrect usage of FileSpec::GetCString() to use FileSpec::GetPath().c_str() where appropriate, and updated other call sites that wanted a ConstString to use the newly returned ConstString appropriately and efficiently.
Differential Revision: https://reviews.llvm.org/D130309