Shane Neuville [Tue, 26 Nov 2019 15:26:39 +0000 (08:26 -0700)]
fix generating nugets (#8660)
Stephane Delcroix [Tue, 26 Nov 2019 00:29:40 +0000 (01:29 +0100)]
[X] RegisterSourceInfo for XamlC (#8579)
When compiling in DEBUG, Register sourceInfo even for compiled code
Gerald Versluis [Fri, 22 Nov 2019 14:51:22 +0000 (15:51 +0100)]
Update LabelRenderer.cs (#8571) fixes #7019
Gerald Versluis [Fri, 22 Nov 2019 03:04:10 +0000 (04:04 +0100)]
[UWP] Fix MDP Button "Padding" issue (#8610)
* Update MasterDetailControlStyle.xaml
* Added comments
* Update MasterDetailControlStyle.xaml
Brian Runck [Thu, 21 Nov 2019 23:49:05 +0000 (18:49 -0500)]
[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)
* iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command property binding on non-Xamarin.Forms.Command ICommand implementations
* Changes after code review
* - add ui test to android
Shane Neuville [Thu, 21 Nov 2019 15:33:05 +0000 (08:33 -0700)]
[iOS] Fix top tab highlighting (#8599)
* Let UICollectionViewCell handle state itself (#7884)
Fixes #7416
* [iOS] Fix top tab highlighting
melimion [Thu, 21 Nov 2019 15:22:40 +0000 (18:22 +0300)]
Fix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility=WhenEditing (#8429)
* repro
* fix
* set _clearBtn to null in Dispose
* comment removed
Shane Neuville [Thu, 21 Nov 2019 06:02:30 +0000 (23:02 -0700)]
slow down gesture scroll for ui test and let it retry (#8591)
Shane Neuville [Tue, 19 Nov 2019 00:58:28 +0000 (17:58 -0700)]
Merge branch '4.2.0' into 4.3.0
# Conflicts:
# azure-pipelines.yml
Shane Neuville [Tue, 19 Nov 2019 00:54:56 +0000 (17:54 -0700)]
Add export method for transform string on UI Tests (#8532)
* export transform string
* - add missing renderers to performance tracker
* Update Xamarin.Forms.ControlGallery.iOS/PerformanceTrackerRenderer.cs
Shane Neuville [Mon, 18 Nov 2019 17:10:14 +0000 (10:10 -0700)]
Implement FormsStack and FormsQueue internally for VS 2017 Compatibility (#8403)
* FormsStack and FormsQueue for VS 2017 Compat
* - sync stable vs mac versions
* - mono version
* - gtk
* - fix mono provision
* Update Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
* - remove uwp changes
* - add 2019 back in
* Update azure-pipelines.yml
Glenn Versweyveld [Mon, 18 Nov 2019 14:38:35 +0000 (15:38 +0100)]
Keep tab image collapsed if no datasource is available (#8050) fixes #6757
Stephane Delcroix [Mon, 18 Nov 2019 10:38:36 +0000 (11:38 +0100)]
Merge branch '4.2.0' into 4.3.0
Jon Robinson Levy [Fri, 15 Nov 2019 13:54:35 +0000 (14:54 +0100)]
Fix 7361 - [UWP] Stepper buttons not becoming enabled again, when disabled more than once. (#8191)
* Adding test class Issue7361
* Adding checks to prevent PseudoDisable from being called once _plus- or _minusStateCache is set.
* Improving Instructions in Issue7361 test page.
Rui Marinho [Wed, 13 Nov 2019 23:44:47 +0000 (23:44 +0000)]
[Build] Update version numbers to ship from yaml (#8437)
* Update version numbers
* Update Version.targets
* Fix variables
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
* Update azure-pipelines.yml
E.Z. Hart [Fri, 8 Nov 2019 19:44:08 +0000 (12:44 -0700)]
Make character spacing work for UWP Picker without breaking ItemsSource (#8356)
* Make character spacing work for UWP Picker without breaking ItemsSource
Fixes #8177
* Add test instructions
Shane Neuville [Wed, 6 Nov 2019 10:28:01 +0000 (03:28 -0700)]
Ensure that ParentSet fires before OnAppearing (#8242)
Gerald Versluis [Tue, 5 Nov 2019 09:53:34 +0000 (10:53 +0100)]
Added defensive code (#8324)
E.Z. Hart [Mon, 4 Nov 2019 21:21:59 +0000 (14:21 -0700)]
Add missing null check on ItemsSource when IsGrouped is true; fixes #8269 (#8273)
Gerald Versluis [Mon, 4 Nov 2019 20:37:28 +0000 (21:37 +0100)]
Fix UWP Toolbar icons (#8147)
* Added demo and fix
* Update Issue7505.cs
* Update Platform.cs
* Fixed AsyncValue
Rui Marinho [Mon, 4 Nov 2019 13:10:00 +0000 (13:10 +0000)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Fri, 1 Nov 2019 20:58:47 +0000 (20:58 +0000)]
[Android] Fix API21 usage on shell (#8335)
* [Android] Fix API21 usage
* [Android] Remove extra usings
E.Z. Hart [Fri, 1 Nov 2019 20:20:32 +0000 (14:20 -0600)]
Prevent UWP error/crash when updating binding off the main thread; fixes #8167 (#8311)
Rui Marinho [Thu, 31 Oct 2019 17:06:42 +0000 (17:06 +0000)]
[Build] Clean repos, update vs image (#8339)
Samantha Houts [Thu, 31 Oct 2019 00:31:13 +0000 (17:31 -0700)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#8096)
Samantha Houts [Tue, 29 Oct 2019 11:18:34 +0000 (04:18 -0700)]
[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145
* Add test case for issue 8145
* [Android] Don't double dispose the more sheet
fixes #8145
Shane Neuville [Tue, 29 Oct 2019 00:42:11 +0000 (18:42 -0600)]
Better detect IsCollapsed state/changes on master (#8181)
Shane Neuville [Tue, 29 Oct 2019 00:41:14 +0000 (18:41 -0600)]
[UWP] Delay RequestRefresh until Loaded (#8190)
fixes #8186
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)
Stephane Delcroix [Mon, 28 Oct 2019 18:25:35 +0000 (19:25 +0100)]
[X] resolve indexers on generic types (#8226)
The lovely #7837 is trying to be smarter at identifying which indexer to invoke,
by checking the parametertype. Of course, it wasn't tested on generic types...
So this is definitely a regression, I apologize for it.
- fixes #8221
Shane Neuville [Mon, 28 Oct 2019 17:26:55 +0000 (11:26 -0600)]
Fix Flyout behavior so it propagates from templated Content Page once it's created (#8135) fixes #7985
* Centralize SendAppearanceChanged call
* - Appearance Change UI tests
* - remove extra button and add better messaging
* - make sure there is space to swipe
* - fix rebase
* - only call appearance change if display page changes
* - process appearance changes before page has fully popped
Shane Neuville [Fri, 25 Oct 2019 14:38:53 +0000 (08:38 -0600)]
Store references to local variable so it's not collected (#8205)
Gerald Versluis [Fri, 25 Oct 2019 14:07:07 +0000 (16:07 +0200)]
iOS Cell default bgcolor to transparent (#7903) fixes #7680 fixes #7850
* Update CellRenderer.cs
* Update CellRenderer.cs
* Update CellRenderer.cs
Alan Grgic [Fri, 25 Oct 2019 11:37:46 +0000 (06:37 -0500)]
use support libs for DrawableWrapper (#8106) fixes #6291
Glenn Versweyveld [Thu, 24 Oct 2019 09:50:46 +0000 (11:50 +0200)]
Set correct MinWidth for CheckBox style (#7978)
Fixes #7048
# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Gerald Versluis [Thu, 24 Oct 2019 09:43:27 +0000 (11:43 +0200)]
[Android] Null checks (#7941) fixes #7939
Shane Neuville [Wed, 23 Oct 2019 10:37:02 +0000 (04:37 -0600)]
Don't force the Master page closed on disappear if it's set to always visible (#8164)
* Don't force master closed when on split
* - fix UI tests to correctly test for tablet
* - remove extra code
* - fix issue with rotation from Modal
Elashi [Tue, 22 Oct 2019 16:50:36 +0000 (19:50 +0300)]
In Android : Reverse layout only when default layout direction is the… (#7809)
* In Android : Reverse layout only when default layout direction is the opposite of the user settings (#7393)
* - remove ReverseLayout and just rely on LayoutDirection
* - fix formatting
Rui Marinho [Tue, 22 Oct 2019 09:54:50 +0000 (10:54 +0100)]
Fix random test failures (#8083)
* [UITEsts] Ignore vertical test
* [UITests] Ignore 5766 uitest
* [UITests] Ignore UITest 1342
Stephane Delcroix [Mon, 21 Oct 2019 08:40:15 +0000 (10:40 +0200)]
Merge branch '4.2.0' into 4.3.0
Konrad Müller [Fri, 18 Oct 2019 14:07:40 +0000 (16:07 +0200)]
Always use current dispatcher to invoke wpf timer (#7958) fixes #6957
Rui Marinho [Fri, 18 Oct 2019 12:03:53 +0000 (13:03 +0100)]
[MacOS] FIx agains NRE on disposing Entry renderer (#8019)
Gerald Versluis [Fri, 18 Oct 2019 12:03:43 +0000 (14:03 +0200)]
[MacOS] Fixed NRE with modal navigation (#7900)
* Added repro and fix
* Added UITest
Jon Robinson Levy [Fri, 18 Oct 2019 10:25:56 +0000 (12:25 +0200)]
Fixes #4941 (and 1722 for UWP). Adding a test in UWP NavigationPageRenderer.SetElement, to check if the supplied NavigationPage Eelement has a CurrentPage. If not, an InvalidOperationException is thrown. (Otherwise a NullReferenceException would be thrown at a later point.) (#8034)
Shane Neuville [Thu, 17 Oct 2019 06:44:25 +0000 (00:44 -0600)]
Make the Refresh View Respect Command CanExecute and add Refreshing event (#7866)
* Make Refresh View respect Command CanExecute
* - force isrefreshing false when isenabled fasle
- Add IsRefreshing Event
* - shift command execution up to xplat code
* - fix ui test
* - cleanup
* - add additional check
* Update Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7803.xaml.cs
* - fix flag
E.Z. Hart [Wed, 16 Oct 2019 20:54:16 +0000 (14:54 -0600)]
[iOS] Prevent crash when adding item to source of CollectionView in tab (#7940)
* Prevent crash when adding item to source of CollectionView that's never been displayed;
fixes #7700
* Fix renaming error in UI test
* Add test and fix for adding groups offscreen
* Fix rebase error
* Remove flags
* Add instructions
* Better instructions
Shane Neuville [Wed, 16 Oct 2019 16:11:51 +0000 (10:11 -0600)]
Cleanup material controls character spacing interactions (#7880)
* Cleanup material controls and spacing
* - remove left over code
* - remove virtual
* - pr comments
E.Z. Hart [Wed, 16 Oct 2019 15:44:47 +0000 (09:44 -0600)]
Remove requirement for CollectionView Experimental flag (#7907)
* CollectionView_Experimental is dead; long live CarouselView_Experimental!
* Change CollectionView enabling button labels to CarouselView for CarouselView tests
* Fix UI tests for Carousel
* Honor the CollectionView_Experimental flag for CarouselView
* Update Issue6963.cs
* Update Issue7817.xaml.cs
* Remove collection view flag settings
adrianknight89 [Wed, 16 Oct 2019 10:29:33 +0000 (05:29 -0500)]
[Android] Fix recyclerview offsets (#8018) fixes #7993
adrianknight89 [Wed, 16 Oct 2019 10:16:00 +0000 (05:16 -0500)]
remove duplicate statement (#8014)
Shane Neuville [Tue, 15 Oct 2019 22:10:36 +0000 (16:10 -0600)]
Fix Material Editor so TextChange delegate isn't removed (#8011)
* Fix Material Editor so delegate isn't removed
* - fix ui test
Konrad Müller [Tue, 15 Oct 2019 19:24:34 +0000 (21:24 +0200)]
Fix bug 5868 "VisualElement.Unfocus does not work on WPF" (#7883)
* Add repro
* fix bug
Shane Neuville [Tue, 15 Oct 2019 18:44:22 +0000 (12:44 -0600)]
Fix shell to correctly pick visible item (#8009)
- when items are removed
E.Z. Hart [Tue, 15 Oct 2019 18:19:36 +0000 (12:19 -0600)]
Fix iOS crash when group type is not an IList (#7955)
Javier Suárez Ruiz [Tue, 15 Oct 2019 14:37:41 +0000 (16:37 +0200)]
Fixed issue setting Position in CarouselView (#7901) fixes #7865
* Added sample file
* Updated sample
* Fixed the issue on Android and iOS
* Updated IsScrolling property from UWP CarouselView renderer
* Added repro sample instructions
* Update Issue7865.xaml.cs
* [iOS] Update IsScrolling from renderer
Javier Suárez Ruiz [Tue, 15 Oct 2019 13:18:03 +0000 (15:18 +0200)]
Fixed build error (merge) (#8024)
Stephane Delcroix [Tue, 15 Oct 2019 12:12:49 +0000 (14:12 +0200)]
Merge branch '4.2.0' into 4.3.0
bill2004158 [Tue, 15 Oct 2019 10:53:31 +0000 (18:53 +0800)]
Label size doesn't change when text changed (#7942)
- fixes #7888
Javier Suárez Ruiz [Tue, 15 Oct 2019 08:37:57 +0000 (10:37 +0200)]
Added sample (#7650)
adrianknight89 [Tue, 15 Oct 2019 08:32:26 +0000 (03:32 -0500)]
[iOS] Various fixes with ItemsViewController (#7618)
* various fixes
* remove comment
* move delegator setting to ViewDidLoad
* fix delegator
* fix accessibility issue
Shane Neuville [Tue, 15 Oct 2019 05:10:00 +0000 (23:10 -0600)]
[Android] speed up development builds (#7834)
* speed up development builds android
* - remove extra property group
* - add cake descriptions
* - fix
* - remove shared runtime
* - add check for TF_Build
Javier Suárez Ruiz [Tue, 15 Oct 2019 00:07:11 +0000 (02:07 +0200)]
Fixed ItemSpacing, NumberOfSideItems, PeekAreaInsets and Snap in UWP CarouselView. (#7930)
Javier Suárez Ruiz [Mon, 14 Oct 2019 21:24:53 +0000 (23:24 +0200)]
[Android] Fixed a crash on CollectionView changing ItemsSource (#7945)
* Added repro sample
* Fixed the crash
Glenn Versweyveld [Mon, 14 Oct 2019 15:56:57 +0000 (17:56 +0200)]
Validate on Date part only (#7766) fixes #5784
* Validate on Date part only
Fixes #5784
* Add unittest
* Both sides should be Date only validated
Javier Suárez Ruiz [Mon, 14 Oct 2019 15:48:33 +0000 (17:48 +0200)]
[Android] Fixed CarouselView string EmptyView not displayed (#7822) fixes #7792
* Added sample
* Updated sample
* Fixed CarouselView issue not displaying string EmptyView
* Fixed wrong controls shared projitems paths
melimion [Mon, 14 Oct 2019 11:57:44 +0000 (14:57 +0300)]
Fix [macOS] navigation page doesn't hide previous page (#7921)
* fix
* test added
* more transparency added to test
* test simplified
* test title fix
Stephane Delcroix [Mon, 14 Oct 2019 07:03:32 +0000 (09:03 +0200)]
Merge branch '4.1.0' into 4.2.0
E.Z. Hart [Fri, 11 Oct 2019 23:11:42 +0000 (17:11 -0600)]
Move CollectionView UWP implementation to generics (#7911)
* Clean up implementation with generics and get rid of awkward casts
* Save some unnecessary casts and switching on CarouselView
Javier Suárez Ruiz [Fri, 11 Oct 2019 11:43:08 +0000 (13:43 +0200)]
Fixed crash on UWP Switch (UpdateThumbColor) (#7932)
Kangho Hur [Fri, 11 Oct 2019 00:46:57 +0000 (09:46 +0900)]
[Tizen] Fix RenderWith attributes for Forwarders (#7854)
E.Z. Hart [Thu, 10 Oct 2019 23:21:22 +0000 (17:21 -0600)]
Generics for CollectionView iOS implementation (#7918)
* Make the ItemsView type generic
* Make controller type generic
* Generic all the things, and split up the delegators
Fix rebase error
Javier Suárez Ruiz [Thu, 10 Oct 2019 16:09:50 +0000 (18:09 +0200)]
Revert "Fixed crash on UWP Switch (UpdateThumbColor)"
This reverts commit
10a0f4e0b3ded2480b49faae0b301980fbf4dc65.
Javier Suárez Ruiz [Thu, 10 Oct 2019 16:08:43 +0000 (18:08 +0200)]
Fixed crash on UWP Switch (UpdateThumbColor)
Javier Suárez Ruiz [Thu, 10 Oct 2019 15:31:05 +0000 (17:31 +0200)]
[Android/iOS] Fixed ItemsUpdatingScrollMode on CarouselView (#7872)
* Added repro sample
* Updated sample
* Fixed issue on Android
* Fixed issue on iOS
* Updated sample
* Updated instructions
* Fixed property changed propagation from CarouselViewRenderer to ItemsViewRenderer
E.Z. Hart [Thu, 10 Oct 2019 15:16:38 +0000 (09:16 -0600)]
[UWP] [iOS] Verify selected items exist when updating native selections (#7902)
* Add selection synchronization tests
* Resync native selection after ItemsSource is updated
* Update native selection on iOS when changing ItemsSource; prevent crash when
selection contains items not in source; fixes #6963
* Automated test
Stephane Delcroix [Thu, 10 Oct 2019 08:19:04 +0000 (10:19 +0200)]
[X] binding find the right indexer (#7896)
supports having multiple indexers on a bound source, try to invoke the right one
- fixes #7837
Javier Suárez Ruiz [Wed, 9 Oct 2019 18:14:38 +0000 (20:14 +0200)]
Fixed SnapPointsType discrepancy between CarouselView and LinearItemsLayout (#7893)
E.Z. Hart [Wed, 9 Oct 2019 17:56:18 +0000 (11:56 -0600)]
Implement grouping for UWP CollectionView (#7697)
* Implement grouping for UWP CollectionView
* Clean up CollectionViewSource on teardown
Javier Suárez Ruiz [Wed, 9 Oct 2019 07:52:27 +0000 (09:52 +0200)]
[iOS] Fixed crash displaying strings in CarouselView (#7858)
* Added repro sample
* Fixed the crash on DequeueReusableCell registering the correct cell types
* Added instructions to the test
* Fixed wrong paths on Controls Issues projitems
Shane Neuville [Tue, 8 Oct 2019 18:16:03 +0000 (12:16 -0600)]
Shell android dispose (#7768)
* Better dispose of Android shell renderers
* - fixup a few dispose paths
* - set page to null
* - header container
Javier Suárez Ruiz [Tue, 8 Oct 2019 18:06:07 +0000 (20:06 +0200)]
[iOS] Fix issue changing the ItemTemplate on CollectionView dynamically (#7743)
* Fixed Issue 7742: Change CollectionView ItemTemplate programmatically
* Fixed typo
* Removed invalid test
adrianknight89 [Tue, 8 Oct 2019 15:44:49 +0000 (10:44 -0500)]
[iOS] Alternative proposal for PR 7794 (#7811)
* emptyview fix
* fix
* added collectionview flag
* added using for List
* fix formatting
* fix formatting 2
* fix formatting 3
* fixes
* fix test
Shane Neuville [Mon, 7 Oct 2019 15:41:24 +0000 (09:41 -0600)]
Ignore empty cache and don't cache invalid stream (#7764)
* Ignore empty cache and don't cache invalid stream
* - msbuild locator
Stephane Delcroix [Mon, 7 Oct 2019 14:09:51 +0000 (16:09 +0200)]
[X] pass the RootAssembly to DT Context (#7853)
regression introduced by #7531
- fixes #7830
Stephane Delcroix [Mon, 7 Oct 2019 09:54:46 +0000 (11:54 +0200)]
Merge branch '4.2.0' into 4.3.0
melimion [Fri, 4 Oct 2019 14:08:45 +0000 (17:08 +0300)]
[macOS] Fix Image Rotation issue (#7815) fixes #5395
* AnchorPoint fix
* rotation and translationY direction fix
* clipping fix
* test added
* anchor point and position translation fixed
* test update
adrianknight89 [Fri, 4 Oct 2019 00:36:53 +0000 (19:36 -0500)]
[iOS] Fix hard crash when horizontal GridViewLayout is refreshed (#7612) fixes #7593
* fix refreshview issue
* fix path
* remove extra line after rebase
Javier Suárez Ruiz [Fri, 4 Oct 2019 00:32:03 +0000 (02:32 +0200)]
[Android] Fix crash changing the Application MainPage (#7776) fixes #7283
* Fixed Issue 7283 - Fix crash changing the Application MainPage
* Update Xamarin.Forms.Platform.Android/AppCompat/NavigationPageRenderer.cs
* Fix build
Shane Neuville [Thu, 3 Oct 2019 23:20:07 +0000 (17:20 -0600)]
Remove Material Frame Renderer from Frame element on dispose of renderer (#7752) fixes #7339
* [iOS] remove renderer from Frame on dispose
* - add uitests
Javier Suárez Ruiz [Thu, 3 Oct 2019 22:47:16 +0000 (00:47 +0200)]
Fixed PeekAreaInsets not working on iOS (#7802)
Rui Marinho [Thu, 3 Oct 2019 12:35:23 +0000 (13:35 +0100)]
Merge branch '4.2.0' into 4.3.0
Rui Marinho [Thu, 3 Oct 2019 12:34:25 +0000 (13:34 +0100)]
Merge branch '4.1.0' into 4.2.0
Rui Marinho [Thu, 3 Oct 2019 08:50:00 +0000 (09:50 +0100)]
Revert "ios: raise touch event on touchbegin. (#6989) fixes #3320" (#7787)
This reverts commit
dca82ed828e3fc1b3fede8d376ea8c4abf56d4ca.
Rui Marinho [Wed, 2 Oct 2019 19:33:03 +0000 (20:33 +0100)]
Update Build.Locator (#7783)
Rui Marinho [Wed, 2 Oct 2019 14:20:44 +0000 (15:20 +0100)]
Remove duplicate items
Rui Marinho [Wed, 2 Oct 2019 13:42:26 +0000 (14:42 +0100)]
Fix merge
Stephane Delcroix [Wed, 2 Oct 2019 13:13:24 +0000 (15:13 +0200)]
[X] send VisualTreeChanged for root (#7747)
Stephane Delcroix [Wed, 2 Oct 2019 13:08:09 +0000 (15:08 +0200)]
Merge branch '4.2.0' into 4.3.0
Stephane Delcroix [Wed, 2 Oct 2019 13:06:24 +0000 (15:06 +0200)]
Merge branch '4.1.0' into 4.2.0
Stephane Delcroix [Wed, 2 Oct 2019 12:40:36 +0000 (14:40 +0200)]
[HR] allow the HR test harness to clear cache (#7774)