Stephen Toub [Sun, 7 Jul 2019 22:17:19 +0000 (18:17 -0400)]
Disable ConnectAsync_AddHostHeader_Success test (dotnet/corefx#39272)
Commit migrated from https://github.com/dotnet/corefx/commit/
480727f253bbe53bd94376830f3d4e645ee90ed0
Stephen Toub [Sat, 6 Jul 2019 22:45:11 +0000 (18:45 -0400)]
Don't force flush for data packets in SocketsHttpHandler HTTP/2 (dotnet/corefx#39236)
* Don't force flush for data packets in SocketsHttpHandler HTTP/2
Allow the write stream to request a flush via FlushAsync, but don't internally force a flush on each data packet.
* Address PR feedback
Also tweak use of ArrayBuffer.ActiveSpan/Memory.Length to just ArrayBuffer.ActiveLength.
Commit migrated from https://github.com/dotnet/corefx/commit/
15abdfc3816352c64098735b79a98dd97524ee36
Jan Kotas [Sat, 6 Jul 2019 20:46:32 +0000 (13:46 -0700)]
Fix System.Diagnostics.Process failures with disabled Remote Registry service (dotnet/corefx#39215)
* Fix System.Diagnostics.Process failures with disabled Remote Registry service
* Make the test more similar to other tests that depend on performance counters
Commit migrated from https://github.com/dotnet/corefx/commit/
da2cf2d7e6976b13cbc24eb9ae7d98b630dd3be3
Jeremy Barton [Sat, 6 Jul 2019 02:47:55 +0000 (19:47 -0700)]
Remove unused code from Linux crypto shim
* Remove uncalled methods in Interop.Crypto and clean using-imports
* Remove uncalled DLLEXPORT functions and their now-unused portable funcs.
Remove unused code from the crypto shim so that we don't pay a maintenance cost on it going forward.
Some functions have just fallen out of use slowly, others were shifts that left the old version intact just-in-case.
* Pass 1: For each file in the cryptoshim Interop directory (from X509Certificates, Algorithms, Encoding, and System.Net.Security) delete any methods that are uncalled.
* Pass 2: Delete anything in the shim that was abandoned by pass 1
Be surprised at things like CryptoNative_DsaCreate, which had a DllImport and a .h declaration, but no body.
* Pass 3: grep DLLEXPORT *.h, delete anything that is not mapped to by a DllImport
* Pass 4: Delete any function pointers that get bound during the portable build load but are no longer used (by this change)
It was less removal than anticipated. No audit was done that each function pointer that's bound is actually still used (other than the ones that had a usage reduced in this change); it felt less valuable per unit of time expended.
Commit migrated from https://github.com/dotnet/corefx/commit/
6c6d68558aaccbd16de6e84cf7e59c0fb32b8273
Omair Majid [Fri, 5 Jul 2019 20:58:50 +0000 (16:58 -0400)]
Add RHEL 8.1 runtime id to the runtime id graph
RHEL 8.1 is expected to release around 6 months after RHEL 8.0. That
would put it around Nov 2019. If it follows the RHEL 7 tradition, it
should get identified as 'rhel.8.1`.
Commit migrated from https://github.com/dotnet/corefx/commit/
8a02800c1e8002302bcc9340fe59eb8e199c9817
Viktor Hofer [Fri, 5 Jul 2019 20:50:57 +0000 (22:50 +0200)]
Enable XUnit Analyzers (dotnet/corefx#38676)
* Enable XUnit Analyzers
Commit migrated from https://github.com/dotnet/corefx/commit/
b8a7f34e1b64e5c594f591aa8683f34506eb9736
Jan Kotas [Fri, 5 Jul 2019 18:32:38 +0000 (11:32 -0700)]
Fix VisualBasic.Core test failures on non-English locales (dotnet/corefx#39213)
Commit migrated from https://github.com/dotnet/corefx/commit/
313ac450b3c07d8c93c5a1de3173d3299971bf38
Viktor Hofer [Fri, 5 Jul 2019 18:30:34 +0000 (20:30 +0200)]
Fix wrong outerloop/innerloop variable (dotnet/corefx#39217)
* Fix wrong outerloop/innerloop variable
Commit migrated from https://github.com/dotnet/corefx/commit/
1961dbf1672be1d30dd3e9e8cda1e8fad573b70e
Geoff Kizer [Fri, 5 Jul 2019 18:19:16 +0000 (11:19 -0700)]
Small improvements to HTTP2 testing (dotnet/corefx#39209)
* method tests
* in debug, start with very small buffer sizes to induce buffer growing
Commit migrated from https://github.com/dotnet/corefx/commit/
3fdc11c8d4720b6ae361cfa306710d2f20b5536e
Levi Broderick [Fri, 5 Jul 2019 16:41:08 +0000 (09:41 -0700)]
Change Span.Fill(0) call to Span.Clear() instead
Commit migrated from https://github.com/dotnet/corefx/commit/
c663f3ff12bcd95c54e9106aee218671d06fd675
Jan Kotas [Fri, 5 Jul 2019 16:22:11 +0000 (09:22 -0700)]
Move RegionInfo.DisplayName test to outer loop (dotnet/corefx#39212)
Commit migrated from https://github.com/dotnet/corefx/commit/
6a40a039c1f169c27777bdb7af32b14728897ee8
Maryam Ariyan [Thu, 4 Jul 2019 18:00:02 +0000 (11:00 -0700)]
Fix and re-enable outerloop test on OLEDB (dotnet/corefx#38024)
Commit migrated from https://github.com/dotnet/corefx/commit/
477abf147d8860fae35f975fddafb2711ee42bd4
Jan Kotas [Thu, 4 Jul 2019 13:13:46 +0000 (06:13 -0700)]
More cleanup for linker heuristics (dotnet/corefx#39191)
- Deleting dead or unrechable code
- Adding ILLinkTrim.xml files for types and methods accessed via reflection
Commit migrated from https://github.com/dotnet/corefx/commit/
0375ae0db48bf5c20b4fbcc5e4ccd5f2e3944cff
Stephen Toub [Thu, 4 Jul 2019 11:30:25 +0000 (07:30 -0400)]
Add more options to HttpStress program (dotnet/corefx#39188)
- "listOps" option, to see what numbers correspond to which client operations
- New client operation for HEAD
- New client operation for PUT
- New client operation for POST duplex, but that dribbles a byte at a time
- Fixed POST duplex to use ResponseHeadersRead
- Enable HTTP logging to be started to the console during a run
Commit migrated from https://github.com/dotnet/corefx/commit/
2f42dde968da92f1c67a91ab7b915af7c63848e5
Viktor Hofer [Thu, 4 Jul 2019 07:43:57 +0000 (09:43 +0200)]
Delete getting-started-core.md
Commit migrated from https://github.com/dotnet/corefx/commit/
1537f4706cc5155f99c5d2d62e4be0f594dbbf02
Viktor Hofer [Thu, 4 Jul 2019 07:40:31 +0000 (09:40 +0200)]
Update windows-instructions.md
Commit migrated from https://github.com/dotnet/corefx/commit/
6a2b0cfad37ff74d7f19524d08b3a1d1e2085e7b
Viktor Hofer [Thu, 4 Jul 2019 07:35:29 +0000 (09:35 +0200)]
Delete net-platform-standard.md
Commit migrated from https://github.com/dotnet/corefx/commit/
6efc2d5139538ae107b41b53c7e8d36b5ea14f22
Viktor Hofer [Thu, 4 Jul 2019 07:34:33 +0000 (09:34 +0200)]
Update net-core-applications.md
Commit migrated from https://github.com/dotnet/corefx/commit/
3d40dc82597719d802edc9ac95ae84ca320a4ce6
Viktor Hofer [Thu, 4 Jul 2019 07:28:25 +0000 (09:28 +0200)]
Delete advanced-inner-loop-testing.md
Remove this doc as it won't work anymore moving forward and the preferred path is to use dotnet.exe and not invoke csc or vbc manually anymore.
Commit migrated from https://github.com/dotnet/corefx/commit/
4d6cbe58074bd5edb720071d786fe1772e26b9b1
Viktor Hofer [Thu, 4 Jul 2019 07:26:58 +0000 (09:26 +0200)]
Delete cross-platform-testing.md
Commit migrated from https://github.com/dotnet/corefx/commit/
ab592e49272cbd6a20b521745d6949e53c2d5cd7
Vladimir Sadov [Thu, 4 Jul 2019 02:12:29 +0000 (19:12 -0700)]
Make `GetGCMemoryInfo` aware that `MemoryLoadBytes` can decrease after allocating since it also depends on what other processes are doing. (dotnet/corefx#39183)
Commit migrated from https://github.com/dotnet/corefx/commit/
a14c8a3e624bb2cb39616b2fa3a373f0e223ec04
Stephen Toub [Wed, 3 Jul 2019 23:57:22 +0000 (19:57 -0400)]
Augment HttpStress app to track socket reuse errors (dotnet/corefx#39179)
Commit migrated from https://github.com/dotnet/corefx/commit/
b21ca5fddd281f835de98dbe950405bcf9397ac4
Egor Bogatov [Wed, 3 Jul 2019 23:53:28 +0000 (02:53 +0300)]
Hide some tests under IsPreciseGcSupported condition (dotnet/corefx#39176)
Commit migrated from https://github.com/dotnet/corefx/commit/
9b75a46f6f716f77bb0e904b1cd4dd13aa83f0b9
Jan Kotas [Wed, 3 Jul 2019 23:53:11 +0000 (16:53 -0700)]
Fix EventLog tests on latest Win10 (dotnet/corefx#39182)
The Security EventLog is ACLed for admin access only. Remove it from the set we look
for to make the test work in regular prompt.
Commit migrated from https://github.com/dotnet/corefx/commit/
0d33f64bac69f2527b927c6a0d9d3a571c231aea
Vladimir Sadov [Wed, 3 Jul 2019 23:52:47 +0000 (16:52 -0700)]
Temporarily disable `MemoryLoadBytes` scenario in `GetGCMemoryInfo` test (dotnet/corefx#39180)
* Temporarily disable `MemoryLoadBytes` scenario in `GetGCMemoryInfo` test
* added a reference to the bug
Commit migrated from https://github.com/dotnet/corefx/commit/
29817ea42e841c0df1bf0a96f735956571011163
Vatsan Madhavan [Wed, 3 Jul 2019 23:27:05 +0000 (16:27 -0700)]
Move XamlAccessLevel to System.Windows.Extensions.dll
WPF needs continued access to XamlAccessLevel type. System.Xaml.Permissions.XamlLoadPermission also needs to use XamlAccessLevel.
WPF is trying to remove its references to System.Security.Permissions. In order to complete this work, XamlAccessLevel is being moved to System.Windows.Extensions.dll (while leaving XamlLoadPermission in System.Permission.dll as-is). This will allow WindowsDesktop.App to bundle System.Windows.Extensions.dll (but not carry System.Security.Permissions.dll).
Commit migrated from https://github.com/dotnet/corefx/commit/
758b1bfe0693801c3ac3e1b3b103a3b5e64be14a
Jan Kotas [Wed, 3 Jul 2019 23:00:26 +0000 (16:00 -0700)]
Prep work for cleaning up linker heuristics (dotnet/corefx#39142)
- Deleting dead or unrechable code
- Adding ILLinkTrim.xml files for types and methods accessed via reflection
Commit migrated from https://github.com/dotnet/corefx/commit/
bc1f6ae4e757251c8691fe94e68617ce1516e684
Anirudh Agnihotry [Wed, 3 Jul 2019 22:59:39 +0000 (15:59 -0700)]
Font converter implementation made similar to netfx (dotnet/corefx#39098)
* Font converter implementation made similar to netfx
* addressing feedback and fixing tests for spanish ci leg
* name changes and checking the paramter name in argument Exception
* fixing netfx failures and removing some redundant code
Commit migrated from https://github.com/dotnet/corefx/commit/
9635883cfc69eee3161693715a522ddecca05794
buyaa-n [Wed, 3 Jul 2019 20:35:51 +0000 (13:35 -0700)]
Code coverage JsonDocument, JsonElement (dotnet/corefx#39103)
Improve coverage, remove unreachable section
Commit migrated from https://github.com/dotnet/corefx/commit/
b00b4a5110c209b522fc711e48cd5243b3fb34ec
Immo Landwerth [Wed, 3 Jul 2019 18:44:00 +0000 (11:44 -0700)]
Merge pull request dotnet/corefx#39102 from terrajobst/ns21-baselining
Simplify baselining for .NET Standard
Commit migrated from https://github.com/dotnet/corefx/commit/
c430820321ac002d5e832867410f3232e703b79d
Youssef1313 [Wed, 3 Jul 2019 17:57:56 +0000 (19:57 +0200)]
Fix argument name & use nameof instead of magic string (dotnet/corefx#39154)
* Fix argument name & use nameof instead of magic string
* Update GraphicsTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
bb7e8b542f5f16ce5497097bbc2b26d77c601dbe
Stephen Toub [Wed, 3 Jul 2019 17:05:41 +0000 (13:05 -0400)]
Ensure HttpClient.Get*Async helpers wrap IOExceptions (dotnet/corefx#39137)
IOExceptions may emerge from the underlying response streams, but GetString/ByteArrayAsync should throw a wrapper HttpRequestException in this case.
Commit migrated from https://github.com/dotnet/corefx/commit/
1c3d001566b0d38c90e074e33d7394d507311956
Hugh Bellamy [Wed, 3 Jul 2019 15:38:51 +0000 (16:38 +0100)]
Move CultureInfoConverter to the new test base and fix NRE (dotnet/corefx#38980)
Commit migrated from https://github.com/dotnet/corefx/commit/
a9594f72540034902e2bcb2a5187fcdba584cf36
Hugh Bellamy [Wed, 3 Jul 2019 15:36:08 +0000 (16:36 +0100)]
Add MemberDescriptor tests and fix bugs (dotnet/corefx#39066)
Commit migrated from https://github.com/dotnet/corefx/commit/
f610925aee0ee4ad0586f677815dd0601209560f
Stephen Toub [Wed, 3 Jul 2019 14:37:04 +0000 (10:37 -0400)]
Disable two Task GC tests for UWP (dotnet/corefx#39157)
They're sporadically failing in CI.
Commit migrated from https://github.com/dotnet/corefx/commit/
7a9c2ab617229faad613fa5554b298df388f6fb7
Vladimir Sadov [Wed, 3 Jul 2019 13:53:20 +0000 (06:53 -0700)]
Enabling GetGCMemoryInfo test (dotnet/corefx#39131)
* enable the test
* additional output to narrow the location of a failure, if happens
* run 1000 times
* revert the "run 1000 times" change
Commit migrated from https://github.com/dotnet/corefx/commit/
9d2435f051c59cd30cbfad0fec2f0ab54fc80538
Santiago Fernandez Madero [Wed, 3 Jul 2019 12:09:16 +0000 (05:09 -0700)]
Fix conflict resolution for design time build (dotnet/corefx#39134)
Commit migrated from https://github.com/dotnet/corefx/commit/
7264bc96154f937dd69ff971f6be695de0a13a13
Andrei K [Wed, 3 Jul 2019 04:57:09 +0000 (21:57 -0700)]
Fix comments and ellipsis in code examples (dotnet/corefx#39132)
Fix comments and ellipsis in code examples to make it copy-pasteable.
Commit migrated from https://github.com/dotnet/corefx/commit/
1162dfc1b5da79dc29f3d28935b4c96c9d38a743
Stephen Toub [Wed, 3 Jul 2019 04:13:57 +0000 (00:13 -0400)]
Fix DateTimeOffsetConverterTests test (dotnet/corefx#39123)
We're getting a sporadic failure in CI due from a DateTimeOffset TypeConverter test. I believe the issue is that another test which changes the current culture to fr-FR runs before or concurrently and ends up affecting the test. I've fixed that test to do the culture change in another process (as is done in every other such test), but just in case that doesn't fix it, I've also augmented the test helper class that represents a test case here to have a ToString that makes the xunit output more debuggable.
Commit migrated from https://github.com/dotnet/corefx/commit/
f64f217d7f1ad4acf72b004e848b30c2a2d305a1
Geoff Kizer [Wed, 3 Jul 2019 03:17:08 +0000 (20:17 -0700)]
Merge pull request dotnet/corefx#39107 from geoffkizer/http2exceptionfix
clean up HTTP2 protocol exception handling
Commit migrated from https://github.com/dotnet/corefx/commit/
d0a88cf805724b9a58e272dc3eff8ce45ff48322
Stephen Toub [Wed, 3 Jul 2019 02:53:36 +0000 (22:53 -0400)]
Avoid extra allocation and interface calls in Append (dotnet/corefx#39045)
Commit migrated from https://github.com/dotnet/corefx/commit/
2ead5143ce31d6d25089a1f16e9619a374d48d4b
Stephen Toub [Wed, 3 Jul 2019 02:34:06 +0000 (22:34 -0400)]
Stop using EDI.Throw for shared exception objects in HTTP/2 (dotnet/corefx#39135)
Commit migrated from https://github.com/dotnet/corefx/commit/
4d56f6ddc5ec0901414e161199fe891cfe183e5d
Geoff Kizer [Wed, 3 Jul 2019 00:25:06 +0000 (17:25 -0700)]
address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
490593ffa52cd818a8c0ebeb5298b48b3844237b
Stephen Toub [Tue, 2 Jul 2019 21:21:10 +0000 (17:21 -0400)]
Update HttpStress app to accomodate recent changes (dotnet/corefx#39125)
Commit migrated from https://github.com/dotnet/corefx/commit/
64310c8da5c631a7271609a3cdbf2b0d58366783
Tomas Weinfurt [Tue, 2 Jul 2019 21:14:10 +0000 (23:14 +0200)]
correct sending RST when request body fails (dotnet/corefx#39117)
* correct sending RST when request body fails
* move test back to OuterLoop
* remove unnecesary ConfigureAwait()
Commit migrated from https://github.com/dotnet/corefx/commit/
26360c82c55c0c8dfc1c358614872b3c160c3bf6
Cory Nelson [Tue, 2 Jul 2019 18:11:36 +0000 (11:11 -0700)]
Fix Ping.Send() to return correct PingReply status (dotnet/corefx#39012)
Fix Ping.Send() to return valid status rather than throw exception for every non-success result. Regression from Core 2.2. Resolves dotnet/corefx#38770.
Commit migrated from https://github.com/dotnet/corefx/commit/
b132f92c28e4c4f696610f48cd9b3afb78b5eff3
Alexander Köplinger [Tue, 2 Jul 2019 17:57:26 +0000 (19:57 +0200)]
System.Numerics.Vectors: Remove reflection in GenericVectorTests (dotnet/corefx#39095)
* System.Numerics.Vectors: Remove reflection in GenericVectorTests
This allows us to use the test with the managed linker enabled in Xamarin.iOS
since it no longer strips out the MaxValue/MinValue fields.
* Fix T4 template to use type aliases instead of type names
The .cs file was changed but the .tt was still using the old style.
Commit migrated from https://github.com/dotnet/corefx/commit/
29af4242a751d17c658a36375dce26bff1dd8dd2
Tarek Mahmoud Sayed [Tue, 2 Jul 2019 17:45:12 +0000 (10:45 -0700)]
Update issue-guide.md
Commit migrated from https://github.com/dotnet/corefx/commit/
9d9ca028ae18281476ce49ed8f8bf52f5f360663
Shay Rojansky [Tue, 2 Jul 2019 17:44:36 +0000 (19:44 +0200)]
Remove cancellation token from new System.Data CloseAsync() (dotnet/corefx#39070)
Affects DbDataReader and DbConnection, since these APIs are very likely
to be used for cleanup only, in which case a cancellation token is
an anti-pattern (similar to why DisposeAsync doesn't accept one).
See discussion here:
https://github.com/dotnet/standard/pull/1283#pullrequestreview-
255383035
Fixes dotnet/corefx#39069
Commit migrated from https://github.com/dotnet/corefx/commit/
539ed313db3ecbfb2ac9dffbb360bb7108fb4c22
Layomi Akinrinade [Tue, 2 Jul 2019 17:39:28 +0000 (13:39 -0400)]
Honor dictionary key policy when serializing (dotnet/corefx#39032)
* Honor dictionary key policy when serializing
* Address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
00b49d189519677732bcde79a91bee955f3f7a82
Charles Stoner [Tue, 2 Jul 2019 17:28:28 +0000 (10:28 -0700)]
Compile InvocationExpression target if necessary (dotnet/corefx#39101)
Commit migrated from https://github.com/dotnet/corefx/commit/
52a6a31678753e25ce9b6949d45ea85b215aed81
Bradley Grainger [Tue, 2 Jul 2019 15:21:33 +0000 (08:21 -0700)]
Increase System.Data.Common test coverage (dotnet/corefx#38340)
* Increase DataTableMappingCollection test coverage.
* Increase BinaryNode.EvalBinaryOp test coverage.
* Increase test coverage of aggregate operators.
Commit migrated from https://github.com/dotnet/corefx/commit/
86ef1c507faa24ca4406b9e8ebfede2a2ae52100
Geoff Kizer [Tue, 2 Jul 2019 10:22:04 +0000 (03:22 -0700)]
clean up HTTP2 protocol exception handling
Commit migrated from https://github.com/dotnet/corefx/commit/
63e8aa4481928d4dc58c4cb563bfab7fdde322d0
Tomas Weinfurt [Tue, 2 Jul 2019 08:07:50 +0000 (10:07 +0200)]
improve Http2_PendingSend_SendsReset test. (dotnet/corefx#39097)
* improve Http2_PendingSend_SendsReset
* style update
Commit migrated from https://github.com/dotnet/corefx/commit/
ec138afba514ce9b53d931d66129e02e8be147a1
Charles Stoner [Tue, 2 Jul 2019 04:13:57 +0000 (21:13 -0700)]
Use same Encoding for Asc() and Chr() (dotnet/corefx#39096)
Commit migrated from https://github.com/dotnet/corefx/commit/
11fc2aa48748edb8cf2a9642d0ab0c3b84c393df
Immo Landwerth [Tue, 2 Jul 2019 01:01:52 +0000 (18:01 -0700)]
Use _camelCase for (logically) private properties
Commit migrated from https://github.com/dotnet/corefx/commit/
aaf1a0d6872cbded8bee06ab7975128da83df200
Tanner Gooding [Tue, 2 Jul 2019 00:29:21 +0000 (17:29 -0700)]
Add a number of new RealFormatter tests (dotnet/corefx#38627)
* Add a number of new RealFormatter tests
* Fixing up some custom formatter tests in response to dotnet/coreclrdotnet/corefx#25400
* Don't run the custom numeric format tests against the UTF8Formatter
Commit migrated from https://github.com/dotnet/corefx/commit/
1ab9b44f1a22cb94f74139ac946b0ba7a6532286
Immo Landwerth [Tue, 2 Jul 2019 00:10:33 +0000 (17:10 -0700)]
Add newline at the end of the baseline
When updating the baseline, a newline will always be added. This avoids noisy
diffs.
Commit migrated from https://github.com/dotnet/corefx/commit/
cc34137ee7989287381a69bcbdfbc93ea88dd913
Immo Landwerth [Mon, 1 Jul 2019 20:35:21 +0000 (13:35 -0700)]
Make it easier to update the .NET Standard 2.1 baseline
Now you can just update the baseline by running
$ build /p:NETStandard21UpdatedBaseLine=True
This assumes you've got a local build of .NET Standard parallel to corefx,
checked out to a folder named standard.
Commit migrated from https://github.com/dotnet/corefx/commit/
3bf48cae5495e51f1e09bb45df960d40624dfd91
Krzysztof Wicher [Mon, 1 Jul 2019 20:44:59 +0000 (13:44 -0700)]
Do not directly abort connection on GOAWAY (dotnet/corefx#39036)
* Do not directly abort connection on GOAWAY
* Address feedback and add disabled GOAWAY tests
* remove redundant frame ignoring logic
Commit migrated from https://github.com/dotnet/corefx/commit/
cc6435bb9ec069c57a3d155944b5729b3f06439f
Tanner Gooding [Mon, 1 Jul 2019 20:06:12 +0000 (13:06 -0700)]
Fixing up the System.Text.Json to handle floats/doubles according to the underlying framework (dotnet/corefx#38322)
* Fixing some doc comments and adjusting Utf8JsonWriter to try and roundtrip float/double on .NET Framework.
* Fixing up various tests to handle framework vs core differences for float/double
* Changing the Utf8JsonWriter to replicate the .NET Core 3.0 Utf8Formatter.TryFormat method.
* Modifying some tests to enforce netfx and netcore test the same things.
* Fixing up some code comments to clarify .NET Core 3.0 or higher vs anything else.
* Adding code comments explaining why we duplicate the netcoreapp3.0 Utf8Formatter logic.
* Removing three usages of var.
* Responding to more PR feedback.
* ifdef out the ISpanFormattable parts of the TryFormatDouble and TryFormatSingle shims for netfx
* Removing an unnecessary using that was added during a rebase.
* Changing some RangePassFloatingPoint scenarios to epect JsonException rather than FormatException
* Removing dependency on Span from the TryFormatSingle/TryFormatDouble fallback paths
* Resolving some more PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
ea33aae808f5f7d26109db5571640d1c4a9ee700
Levi Broderick [Mon, 1 Jul 2019 19:52:46 +0000 (12:52 -0700)]
Add unit tests for EncoderNLS / DecoderNLS fallbacks (dotnet/corefx#38937)
Commit migrated from https://github.com/dotnet/corefx/commit/
ef5b086fc5f134e3244d0bca10d70db8055fa1c6
Jeremy Barton [Mon, 1 Jul 2019 19:15:15 +0000 (12:15 -0700)]
Standardize error for RSACng.ImportParameters (dotnet/corefx#39087)
Windows 7, 8.1, 10-RS4, and 10-19H1 all fail to import the key described in the
RSAXml.FromNonsenseXml test with a WindowsCryptographicException from
NCryptImportKey reporting NTE_NOT_SUPPORTED.
Windows 10-RS1 successfully imports the invalid key, not realizing that it is
invalid until use -- e.g. calling SignData throws a
WindowsCryptographicException reporting NTE_INVALID_PARAMETER.
By copying the same D.Length == Modulus.Length, everything else == halfModulusLength
check from RSACryptoServiceProvider, invalid keys of this form are now
consistently rejected in ImportParameters, and the exception message is
a bit friendlier.
Commit migrated from https://github.com/dotnet/corefx/commit/
be698f30a88cf5c287f01276587ea5c740db8802
Stephen Toub [Mon, 1 Jul 2019 19:12:54 +0000 (15:12 -0400)]
Fix MaxResponseHeadersLength assert for value string (dotnet/corefx#39085)
I'd fixed the assert message to contain the right value when MaxResponseHeadersLength was exceeded, but this error message isn't used for WinHttpHandler, and thus it doesn't contain the value. Special-case the check for just SocketsHttpHandler.
Commit migrated from https://github.com/dotnet/corefx/commit/
e78b22b59d52e14d6099fd96cd713dc9d400103c
Carlos Sanchez Lopez [Mon, 1 Jul 2019 19:10:57 +0000 (12:10 -0700)]
Update ownership for System.IO.Packaging (dotnet/corefx#39088)
Commit migrated from https://github.com/dotnet/corefx/commit/
5465357d7396730da415ab3406aa288c8e13140c
Steve Harter [Mon, 1 Jul 2019 18:51:16 +0000 (11:51 -0700)]
JsonElement null support and serialize ext data without ext prop name (dotnet/corefx#39042)
Commit migrated from https://github.com/dotnet/corefx/commit/
8e2f9a765f6533d17e711365ce2a3064b8d1dfc6
Viktor Hofer [Mon, 1 Jul 2019 17:48:45 +0000 (19:48 +0200)]
Generate framework manifest file (dotnet/corefx#38792)
* Generate framework manifest file
* Manual darc update from build '
20190629.2'
* Handle DefaultReferenceExclusions
* Add runtime assets filter
* Generate manifest file for all verticals
Commit migrated from https://github.com/dotnet/corefx/commit/
c224a2400aae6abab701120f9e081bb0707d69f2
Tom Deseyn [Mon, 1 Jul 2019 16:15:24 +0000 (18:15 +0200)]
WaitIdAnyExitedNoHangNoWait: handle waitid returning 0 for no waitable children (dotnet/corefx#39078)
* WaitIdAnyExitedNoHangNoWait: handle waitid returning 0 for no waitable children
* clear using memset
Commit migrated from https://github.com/dotnet/corefx/commit/
5c83394112febe1b481ab1c0b61a45c850677165
Konstantin Baladurin [Mon, 1 Jul 2019 16:14:24 +0000 (19:14 +0300)]
Fix arm32-ci-script.sh (dotnet/corefx#38398)
Commit migrated from https://github.com/dotnet/corefx/commit/
d42fc2fe49b7915aa9ad1bb1998f325761691de6
Matt Kotsenas [Mon, 1 Jul 2019 15:46:25 +0000 (08:46 -0700)]
Remove dead code in System.Private.* namespaces (dotnet/corefx#36588)
* Remove dead code in System.Private.DataContractSerialization
* Remove dead code in System.Private.Uri
* Remove dead code in System.Private.Xml
* Remove dead code in System.Private.Xml.Linq
* Partial revert of
ab0a4ab9f47721b3eabf07d29
Partial revert of
ab0a4ab9f47721b3eabf07d29 for public APIs that got
flagged by accident.
Commit migrated from https://github.com/dotnet/corefx/commit/
d130beae519dc1486cb2af6251c089b6400e6eaf
Stephen Toub [Mon, 1 Jul 2019 15:09:52 +0000 (11:09 -0400)]
Disable Http2_PendingSend_SendsReset test sporadically failing in CI (dotnet/corefx#39077)
Commit migrated from https://github.com/dotnet/corefx/commit/
3a3c44a93ba968ada2d0c3ea0e997fcb4849a7d5
Stephen Toub [Mon, 1 Jul 2019 15:09:38 +0000 (11:09 -0400)]
Disable VeryLargePart Packaging test (dotnet/corefx#39076)
Commit migrated from https://github.com/dotnet/corefx/commit/
3a27e26eae2e84a58bc92e4f4549313a81af8533
Tomas Weinfurt [Mon, 1 Jul 2019 13:35:16 +0000 (15:35 +0200)]
move tests with SlowTestStream to outerloop (dotnet/corefx#39071)
Commit migrated from https://github.com/dotnet/corefx/commit/
fcaeb097c91b1dbf75ff675442a624802460fb47
Viktor Hofer [Sat, 29 Jun 2019 19:53:19 +0000 (21:53 +0200)]
Make CoreFx.Private.TestUtilites RID-agnostic (dotnet/corefx#36207)
* Make CoreFx.Private.TestUtilites RID-agnostic
* Add version checks for other distros
https://github.com/dotnet/corefx/commit/dotnet/corefx@
4f0d10773ccbb4849b869b6a0a73d5938f1804bd
Porting fix over into PlatformDetection.
* Build test lib in advance for VS support
* Disable pretest in AllConfigurations
Commit migrated from https://github.com/dotnet/corefx/commit/
d3d144fad9b600a0fc1ca6fc7d65c247fddd9f04
Stephen Toub [Sat, 29 Jun 2019 19:38:08 +0000 (15:38 -0400)]
Fix exception messages for max response headers length (dotnet/corefx#39038)
Some of the call sites use a value whose units is kbytes, but the exception message refers to bytes.
Commit migrated from https://github.com/dotnet/corefx/commit/
0decf070fb59b22b13d43082ac5333028ff53b1b
Jose Perez Rodriguez [Sat, 29 Jun 2019 07:06:28 +0000 (00:06 -0700)]
Fixing small issue with reference assemblies not setting BaseIntermediateOutputPath (dotnet/corefx#39003)
* Fixing small issue with reference assemblies not setting BaseIntermediateOutputPath
* Add BaseOutputPath to ref assembly
Commit migrated from https://github.com/dotnet/corefx/commit/
901a1d554a7bcb489eb363fb724c9d294ec35940
Geoff Kizer [Sat, 29 Jun 2019 06:11:32 +0000 (23:11 -0700)]
Merge pull request dotnet/corefx#39047 from geoffkizer/refusedstream
enable request retry when receiving REFUSED_STREAM protocol error
Commit migrated from https://github.com/dotnet/corefx/commit/
1b71b8945c506c801fbc77e61a85df630440b3af
Kevin Jones [Sat, 29 Jun 2019 06:01:53 +0000 (02:01 -0400)]
Lookup OID if only friendly name is specified for ECCurve
Fixes the use of Windows-specific curve identifiers with ECDsaOpenSsl
Commit migrated from https://github.com/dotnet/corefx/commit/
0509d602e8b83468279151cdec11694484b07a86
Geoff Kizer [Sat, 29 Jun 2019 03:18:27 +0000 (20:18 -0700)]
review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
95bca001973dfcd512de1830fd3898306462d1cf
Stephen Toub [Fri, 28 Jun 2019 19:42:42 +0000 (15:42 -0400)]
Ignore NullableContextAttributes in System.ComponentModel.Composition.Registration tests
Commit migrated from https://github.com/dotnet/corefx/commit/
794eaed96342da0072279d0936fafa9d16a468ae
Stephen Toub [Fri, 28 Jun 2019 14:50:25 +0000 (10:50 -0400)]
Workaround potential compiler nullability bug
Commit migrated from https://github.com/dotnet/corefx/commit/
5e3b0ae04986e9527eb51d3717ab96727c215c03
Jan Kotas [Thu, 27 Jun 2019 17:38:07 +0000 (10:38 -0700)]
Fix StackTrace test for pretty-printing updates
Commit migrated from https://github.com/dotnet/corefx/commit/
031cf3cd15684cb6f80d2a7e9038c99a430ab449
Geoff Kizer [Sat, 29 Jun 2019 00:42:27 +0000 (17:42 -0700)]
enable request retry when receiving REFUSED_STREAM protocol error
Commit migrated from https://github.com/dotnet/corefx/commit/
b251108b7fd0b3601eb6f8561ec11fd966671a0e
Krzysztof Wicher [Fri, 28 Jun 2019 22:45:40 +0000 (15:45 -0700)]
Harden System.Net.Http.Functional.Tests.HttpClientHandlerTest_Http2.Dispose_ProcessingResponse_OK (dotnet/corefx#39008)
* harden Dispose_ProcessingResponse_OK
* Add timeout to MRE.Wait
* remove duplicate test
Commit migrated from https://github.com/dotnet/corefx/commit/
124cceaae8309fe0d357e142ae5a0084101107c2
Stephen Toub [Fri, 28 Jun 2019 20:12:44 +0000 (16:12 -0400)]
Added a few more options to the HttpStress test (dotnet/corefx#39040)
- Ability to specify most options on the command-line.
- Several more client operations, including one with lots of headers and one where the server aborts the connection.
Commit migrated from https://github.com/dotnet/corefx/commit/
a13789324692ffa1f8c42c1da34c2c1de2103ba7
Eric Erhardt [Fri, 28 Jun 2019 20:12:19 +0000 (15:12 -0500)]
Clean up unnecessary ObjectModel suppressions from ApiCompat baseline. (dotnet/corefx#39029)
Commit migrated from https://github.com/dotnet/corefx/commit/
ca85abea33bfd01770c252b46dec7783761bf0b6
Steve Harter [Fri, 28 Jun 2019 19:20:24 +0000 (12:20 -0700)]
Add depth check for bad converters (dotnet/corefx#38956)
Commit migrated from https://github.com/dotnet/corefx/commit/
1232838843670020a7128ca548abeafb13164e86
Hugh Bellamy [Fri, 28 Jun 2019 18:09:44 +0000 (19:09 +0100)]
Fix System.ComponentModel.Primitives NREs (dotnet/corefx#39000)
Commit migrated from https://github.com/dotnet/corefx/commit/
98cebc878259cb614c5d360cbbce20dba3547e2b
Prashanth Govindarajan [Fri, 28 Jun 2019 16:42:10 +0000 (09:42 -0700)]
Improve default handling in ReadOnlySequence.Slice (dotnet/corefx#38431)
* Improve default handling in ReadOnlySequence.Slice
Commit migrated from https://github.com/dotnet/corefx/commit/
5f6cba88228bc48e4d0cb6ce2608eeeb7938c71b
Hugh Bellamy [Fri, 28 Jun 2019 13:17:50 +0000 (14:17 +0100)]
Fix typos in test names (dotnet/corefx#39025)
Commit migrated from https://github.com/dotnet/corefx/commit/
59d4a3ed40125b377083b10c8cb58d5f48522c0a
Stephen Toub [Fri, 28 Jun 2019 13:11:09 +0000 (09:11 -0400)]
Add standalone HTTP stress test (dotnet/corefx#39021)
* Add standalone HTTP stress test
This is a simple standalone stress test that launches Kestrel in-proc, creates an HttpClient, and then concurrently makes lots of requests of varying kinds from the client to the server. It's already discovered a plethora of issues in our HTTP/2 implementation, so I'm checking it in hopes that it can help to enable others to discover more.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
3298cd55f840a8a3fab4450ac64ff3547073f651
Carlos Sanchez Lopez [Fri, 28 Jun 2019 13:07:08 +0000 (06:07 -0700)]
Re-add removed Packaging.props lines related to IntelliSense packages (dotnet/corefx#39017)
* Re-add removed Packaging.props lines related to IntelliSense
* Move intellisense package to common versions.props
Commit migrated from https://github.com/dotnet/corefx/commit/
2e76f3ec5a956547119c653f82f3dbb004f52b8d
Stephen Toub [Fri, 28 Jun 2019 01:24:48 +0000 (21:24 -0400)]
Add more HTTP2 tracing (dotnet/corefx#39011)
Commit migrated from https://github.com/dotnet/corefx/commit/
b8761d4848d42040c81ec25c8b51fd386b97f5f4
Stephen Toub [Thu, 27 Jun 2019 23:30:11 +0000 (19:30 -0400)]
Fix HTTP2 duplex communication with Expect: 100-continue (dotnet/corefx#38995)
Duplex communication (allowing the request body to continue sending as the response body is processed) is currently broken with Expect: 100-continue: it's waiting for the request body to send before it'll return the stream for the response body to the caller. The fix is to simplify the code, and minimize the special handling for Expect: 100-continue to just control if/when the request body is sent, rather than forking all of the logic around the handling of the request/response.
As part of diagnosing this, I added a lot more tracing, which I'm also including.
I also streamlined the CreditManager's wait list to make it slimmer.
Commit migrated from https://github.com/dotnet/corefx/commit/
1833ec4769749dfce2b6dadad5882f208b499796
Stephen Toub [Thu, 27 Jun 2019 23:29:23 +0000 (19:29 -0400)]
Stop disposing of the proxy in HttpConnectionPoolManager.Dispose (dotnet/corefx#38991)
SocketsHttpHandler doesn't own the proxy its given; the lifetime of that proxy is up to the developer supplying it. We may also end up using a global proxy instance if the developer hasn't explicitly supplied one. However, SocketsHttpHandler's internal HttpConnectionPoolManager was disposing of this proxy instance on its disposal. For proxies that implement IDisposable, as our global default proxy does, that can be very problematic; on Windows, our default proxy has a SafeHandle, and once its disposed, every subsequent request to the proxy will fail (an exception gets thrown and then internally eaten). The fix is simply to stop disposing a proxy instance we don't own.
While investigating this, I also made a few style tweaks to WinInetProxyHelper, removing private property setters, so as to better be able to see that certain values were readonly and never changed after construction.
Commit migrated from https://github.com/dotnet/corefx/commit/
c6a849b8d24fc48bb0bbdb9f9165752a4a19459b
Stephen Toub [Thu, 27 Jun 2019 23:27:58 +0000 (19:27 -0400)]
Change CreateProcessLong test helper to use 5m rather than 30s sleep (dotnet/corefx#39002)
The ProcessTestBase.CreateProcessLong helper function is used in situations where we effectively want an infinitely running process, which we then terminate when the test creating it completes. But we also don't want the process to live in forever if something goes wrong with killing it, such as if the parent hangs or is itself terminated. So we instead have it sleep for a "long" period of time, currently 30s. However, in stress runs, that may not be long enough. This bumps it to 5m.
Commit migrated from https://github.com/dotnet/corefx/commit/
1ef14e50f9449544e38091ccb0930bb3d5b97f07
Andy Gocke [Thu, 27 Jun 2019 03:25:53 +0000 (20:25 -0700)]
Ignore NullableContextAttribute in API Compat and fix build break due to Range parsing change
Commit migrated from https://github.com/dotnet/corefx/commit/
b3643ab830694eedffb1c9c80051e41517ea0d5f
Hugh Bellamy [Thu, 27 Jun 2019 18:10:37 +0000 (19:10 +0100)]
Add back support for InstanceDescriptor in DateTimeOffsetConverter (dotnet/corefx#38952)
Commit migrated from https://github.com/dotnet/corefx/commit/
4fd677a3a3d56eea0a934dac398eb3bfd0f0fed1
Krzysztof Wicher [Thu, 27 Jun 2019 17:14:05 +0000 (10:14 -0700)]
Fix BytesConsumed when skipping single line comments (multi-segment) (dotnet/corefx#38965)
* Fix BytesConsumed when skipping single line comments (multi-segment)
* rename ret -> skipSucceeded
Commit migrated from https://github.com/dotnet/corefx/commit/
32f061ccb2d2b6a804f8040717f448d97cbf862d
Santiago Fernandez Madero [Thu, 27 Jun 2019 13:58:49 +0000 (06:58 -0700)]
Tweak custom nullable attributes based on API Review (dotnet/corefx#38977)
Commit migrated from https://github.com/dotnet/corefx/commit/
7dce7868e3b3023ee96edebb96042ca01a8ec368