platform/upstream/libSkiaSharp.git
9 years agoYUV to RGB Texture threading GrProcessorDataManager
joshualitt [Thu, 9 Jul 2015 14:31:31 +0000 (07:31 -0700)]
YUV to RGB Texture threading GrProcessorDataManager

BUG=skia:

Review URL: https://codereview.chromium.org/1230803002

9 years agodoc: more changes
halcanary [Thu, 9 Jul 2015 13:58:06 +0000 (06:58 -0700)]
doc: more changes

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/api/skcanvas?cl=1228063002
DOCS_PREVIEW= https://skia.org/user/tips?cl=1228063002
TBR=

Review URL: https://codereview.chromium.org/1228063002

9 years agorename GrShaderDataManager -> GrProcessorDataManager
joshualitt [Thu, 9 Jul 2015 13:28:14 +0000 (06:28 -0700)]
rename GrShaderDataManager -> GrProcessorDataManager

BUG=skia:

Review URL: https://codereview.chromium.org/1228683002

9 years agoRevert of Add normal map sample (patchset #6 id:100001 of https://codereview.chromium...
robertphillips [Wed, 8 Jul 2015 21:46:12 +0000 (14:46 -0700)]
Revert of Add normal map sample (patchset #6 id:100001 of https://codereview.chromium.org/1212813009/)

Reason for revert:
Compilation failures:

../../../../../samplecode/SampleLighting.cpp:13:18: fatal error: SkGr.h: No such file or directory

Original issue's description:
> Add normal map sample
>
> This adds an example of an SkShader that does normal
> mapping. It has a single directional light and an
> ambient light.
>
> Committed: https://skia.googlesource.com/skia/+/8e0da72ba890de395c9946ec6639c9e1e7b16027

TBR=reed@google.com,bsalomon@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1230603002

9 years agofix up test create functions
joshualitt [Wed, 8 Jul 2015 21:26:19 +0000 (14:26 -0700)]
fix up test create functions

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1213623022

9 years agoAdd normal map sample
jvanverth [Wed, 8 Jul 2015 21:21:47 +0000 (14:21 -0700)]
Add normal map sample

This adds an example of an SkShader that does normal
mapping. It has a single directional light and an
ambient light.

Review URL: https://codereview.chromium.org/1212813009

9 years agoSkAdvancedTypefaceMetrics zeroing constructor
halcanary [Wed, 8 Jul 2015 20:58:45 +0000 (13:58 -0700)]
SkAdvancedTypefaceMetrics zeroing constructor

Review URL: https://codereview.chromium.org/1221903004

9 years agoRemove another assertion that a reference is non-null.
dcheng [Wed, 8 Jul 2015 20:25:23 +0000 (13:25 -0700)]
Remove another assertion that a reference is non-null.

This tickles a warning in Clang:
reference cannot be bound to dereferenced null pointer in well-defined
C++ code; pointer may be assumed to always convert to true
[-Wundefined-bool-conversion]

BUG=none

Review URL: https://codereview.chromium.org/1225053003

9 years agodisabled GrAALinearizingConvexRenderer for now
ethannicholas [Wed, 8 Jul 2015 20:19:51 +0000 (13:19 -0700)]
disabled GrAALinearizingConvexRenderer for now

BUG=505579

Review URL: https://codereview.chromium.org/1219653004

9 years agoadd ability to get FBO ID to Surface
joshualitt [Wed, 8 Jul 2015 19:54:04 +0000 (12:54 -0700)]
add ability to get FBO ID to Surface

BUG=skia:

Review URL: https://codereview.chromium.org/1220733007

9 years agoAdd image->bitmap
reed [Wed, 8 Jul 2015 19:46:22 +0000 (12:46 -0700)]
Add image->bitmap

BUG=skia:

patch from issue 1212163012 at patchset 1 (http://crrev.com/1212163012#ps1)

Review URL: https://codereview.chromium.org/1208993017

9 years agodoc: embed fiddle
halcanary [Wed, 8 Jul 2015 18:34:36 +0000 (11:34 -0700)]
doc: embed fiddle

NOTRY=true
DOCS_PREVIEW= https://skia.org/user/api/skcanvas?cl=1149633009
DOCS_PREVIEW= https://skia.org/user/api/skpaint?cl=1149633009

Review URL: https://codereview.chromium.org/1149633009

9 years agoRemove SkImage::NewFromBitmap encoded data helper
fmalita [Wed, 8 Jul 2015 18:34:20 +0000 (11:34 -0700)]
Remove SkImage::NewFromBitmap encoded data helper

Attempting to instantiate image decoders at this stage introduces
embedder dependencies.

Instead, we can just let callers set up any needed generators on the
bitmap.

R=reed@google.com

Review URL: https://codereview.chromium.org/1218663012

9 years agoMakes GrPipelineInfo a class with query functions used by GrBatch subclasses.
bsalomon [Wed, 8 Jul 2015 18:26:37 +0000 (11:26 -0700)]
Makes GrPipelineInfo a class with query functions used by GrBatch subclasses.

Committed: https://skia.googlesource.com/skia/+/f5179a4c490bc787190321bd8ffdb0e6a4efa9ac

Review URL: https://codereview.chromium.org/1213383005

9 years agoRevert of Use the upstream version of libwebp, v0.4.3. (patchset #6 id:70001 of https...
scroggo [Wed, 8 Jul 2015 17:57:22 +0000 (10:57 -0700)]
Revert of Use the upstream version of libwebp, v0.4.3. (patchset #6 id:70001 of https://codereview.chromium.org/1178013008/)

Reason for revert:
Breaking the build e.g. http://build.chromium.org/p/client.skia/builders/Perf-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release/builds/1082/steps/build%20nanobench/logs/stdio

../../../third_party/externals/libwebp/src/utils/./endian_inl.h:51:10: error: use of unknown builtin '__builtin_bswap16' [-Wimplicit-function-declaration]
  return __builtin_bswap16(x);
         ^
1 error generated.

Original issue's description:
> Use the upstream version of libwebp, v0.4.3.
>
> DEPS:
> Update to pull v0.4.3 of libwebp from upstream
>
> gyp/libwebp.gyp:
> Add new files, as referenced by the gyp file used by Chromium.
>
> resource/tests:
> Add regression tests for particular images.
>
> BUG=skia:3442
> BUG=skia:3315
> BUG=skia:3429
>
> Committed: https://skia.googlesource.com/skia/+/3aa0fb4d80c76b559ff4b82d5e569993aea06da1

TBR=djsollen@google.com,jzern@chromium.org,msarett@google.com,emmaleer@google.com,scroggo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3442

Review URL: https://codereview.chromium.org/1223583004

9 years agodoc: add instructions to capture a `.skp` from chromium
halcanary [Wed, 8 Jul 2015 17:56:01 +0000 (10:56 -0700)]
doc: add instructions to capture a `.skp` from chromium

NOTRY=true

DOCS_PREVIEW= https://skia.org/user/tips?cl=1220783005

Review URL: https://codereview.chromium.org/1220783005

9 years agoAdd gradle wrappers for Android app builds
djsollen [Wed, 8 Jul 2015 17:50:42 +0000 (10:50 -0700)]
Add gradle wrappers for Android app builds

These wrappers are approxiately 56K in size and are the recommened
way to use Gradle.  It also ensures that developers wanting to
build the app don't need install an additional dependency.

Review URL: https://codereview.chromium.org/1227723002

9 years agoUse the upstream version of libwebp, v0.4.3.
scroggo [Wed, 8 Jul 2015 17:48:40 +0000 (10:48 -0700)]
Use the upstream version of libwebp, v0.4.3.

DEPS:
Update to pull v0.4.3 of libwebp from upstream

gyp/libwebp.gyp:
Add new files, as referenced by the gyp file used by Chromium.

resource/tests:
Add regression tests for particular images.

BUG=skia:3442
BUG=skia:3315
BUG=skia:3429

Review URL: https://codereview.chromium.org/1178013008

9 years agoRevert of Rework GrPipelineInfo (patchset #7 id:120001 of https://codereview.chromium...
bsalomon [Wed, 8 Jul 2015 17:20:21 +0000 (10:20 -0700)]
Revert of Rework GrPipelineInfo (patchset #7 id:120001 of https://codereview.chromium.org/1213383005/)

Reason for revert:
breaking stuff!

Original issue's description:
> Makes GrPipelineInfo a class with query functions used by GrBatch subclasses.
>
> Committed: https://skia.googlesource.com/skia/+/f5179a4c490bc787190321bd8ffdb0e6a4efa9ac

TBR=joshualitt@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1213013003

9 years agoAdd tools/flatten to flatten nested pictures in .skps.
mtklein [Wed, 8 Jul 2015 17:06:01 +0000 (10:06 -0700)]
Add tools/flatten to flatten nested pictures in .skps.

Tested by running on skps/sp_desk_nytimes.skp.
The output .skp had no nested draw picture calls, and the files were both 9.3M.

BUG=skia:

Review URL: https://codereview.chromium.org/1221303020

9 years agomore threading of GrShaderDataManager
joshualitt [Wed, 8 Jul 2015 16:36:59 +0000 (09:36 -0700)]
more threading of GrShaderDataManager

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1215643006

9 years agoThread GrShaderDataManager through Image filters
joshualitt [Wed, 8 Jul 2015 16:10:03 +0000 (09:10 -0700)]
Thread GrShaderDataManager through Image filters

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1229613002

9 years agoDM runs more than 100k tests now.
mtklein [Wed, 8 Jul 2015 15:49:20 +0000 (08:49 -0700)]
DM runs more than 100k tests now.

BUG=skia:

Review URL: https://codereview.chromium.org/1217493006

9 years agoFix leak in PictureTest.cpp
mtklein [Wed, 8 Jul 2015 15:26:39 +0000 (08:26 -0700)]
Fix leak in PictureTest.cpp

TBR=schenney@chromium.org

BUG=skia:

Review URL: https://codereview.chromium.org/1210053008

9 years agoMore threading of GrShaderDataManager
joshualitt [Wed, 8 Jul 2015 14:58:18 +0000 (07:58 -0700)]
More threading of GrShaderDataManager

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1213613016

9 years agoMakes GrPipelineInfo a class with query functions used by GrBatch subclasses.
bsalomon [Wed, 8 Jul 2015 14:55:59 +0000 (07:55 -0700)]
Makes GrPipelineInfo a class with query functions used by GrBatch subclasses.

Review URL: https://codereview.chromium.org/1213383005

9 years agoAdd SK_API to GrSurface
bsalomon [Wed, 8 Jul 2015 14:53:10 +0000 (07:53 -0700)]
Add SK_API to GrSurface

TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1209043012

9 years agoDM: swizzle BGRA to RGBA before calculating pixel MD5.
mtklein [Wed, 8 Jul 2015 14:25:27 +0000 (07:25 -0700)]
DM: swizzle BGRA to RGBA before calculating pixel MD5.

We name our .pngs by pixel hashes for gold.  For 8888 images, we're hashing
SkPMColors, which have platform-dependent order: BGRA on Linux and Windows,
RGBA otherwise. This means we can end up with pixel-identical pngs with
different hashes, which is confusing.

This CL standardizes on RGBA for 8888 configs, arbitrarily chosen so that
Android ends up a no-op.  Long-term, this should eliminate most of the
0-pixel-diff problems we see on gold.skia.org.  There are other ways to end up
with the same .png from different SkBitmaps (think, red 565 square vs. red 8888
square) but they're rather less common / likely.

This will temporarily create a giant 0-pixel-diff problem on gold.skia.org.
Any Linux or Windows images which are not already pixel-identical to a Mac or
Android image should show up as untriaged hashes that are pixel-identical to
their version just before landing (we're only changing the hash, not the .png).
This means anything vaguely platform dependent (fonts, GPUs) will probably show
up as needing a triage but with a zero diff from a previous image.

If this goes well, we might do the same for 565.  Just want to leave them out
for now to cut down on the triaging I need to do in one go.

BUG=skia:

Review URL: https://codereview.chromium.org/1226933005

9 years agoInitial CL to create dummy GrShaderDataManager and thread it through
joshualitt [Wed, 8 Jul 2015 13:51:43 +0000 (06:51 -0700)]
Initial CL to create dummy GrShaderDataManager and thread it through

TBR=bsalomon@google.com
BUG=skia:

Review URL: https://codereview.chromium.org/1225673007

9 years agoRemove &glyph from SkASSERT.
dcheng [Wed, 8 Jul 2015 02:35:53 +0000 (19:35 -0700)]
Remove &glyph from SkASSERT.

This tickles a warning in Clang:
reference cannot be bound to dereferenced null pointer in well-defined
C++ code; pointer may be assumed to always convert to true
[-Wundefined-bool-conversion]

BUG=none

Review URL: https://codereview.chromium.org/1220113003

9 years agofix pathops battle test
caryclark [Wed, 8 Jul 2015 01:09:32 +0000 (18:09 -0700)]
fix pathops battle test

The intermediate subtraction threw away bits causing
the subsequent cross product to fail. Defer the
bit truncation until after the vector is computed.

TBR=reed@google.com

Review URL: https://codereview.chromium.org/1226933003

9 years agoAdd check that Dwrite glyph fits in unicode table.
wfh [Wed, 8 Jul 2015 01:06:19 +0000 (18:06 -0700)]
Add check that Dwrite glyph fits in unicode table.

BUG=470146

Review URL: https://codereview.chromium.org/1218043004

9 years agoAllow reset of the SkPictureRecorder cull rect and other parameters during endRecording.
schenney [Tue, 7 Jul 2015 21:27:10 +0000 (14:27 -0700)]
Allow reset of the SkPictureRecorder cull rect and other parameters during endRecording.

For some users of SkPictureRecorder, the cull rect is more efficiently
determined while drawing is in progress, rather than when recording starts.
The existing API requires the cull rect at start time, even though the
information is not used for any culling purpose until the end of recording.

This patch provides a means to reset the cull rect when recording ends,
allowing users to update the rect based on information learned during
drawing and for the new rect to be used as the culling bound. A valid
bound is still required on the beginRecording call because
it sizes the underlying canvas and sets the aspect ratio for any bounding
box hierarchy. The bounding box factory can also be specified and parameters
that control SkPicture creation.

R=mtklein, reed1
BUG=skia:3919

Review URL: https://codereview.chromium.org/1178673007

9 years agoWhen GrAAConvesTesselator was merging the first and last point of the array, it was...
ethannicholas [Tue, 7 Jul 2015 19:41:52 +0000 (12:41 -0700)]
When GrAAConvesTesselator was merging the first and last point of the array, it was deleting the last point without checking to see if any of the previous points shared the same index. This led to continuing to use the index of a deleted point and thus referencing memory past the end of the vertex array.

BUG=chromium:505227

Review URL: https://codereview.chromium.org/1225683008

9 years agoRemove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.
mtklein [Tue, 7 Jul 2015 19:21:21 +0000 (12:21 -0700)]
Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.

SkThread.h doesn't do anything anymore execept include those two,
and thankfully, it doesn't seem to be mentioned outside Skia.

No public API changes.
TBR=reed@google.com

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc

Review URL: https://codereview.chromium.org/1215393002

9 years agoPropagate SkSurfaceProps when known
robertphillips [Tue, 7 Jul 2015 17:28:43 +0000 (10:28 -0700)]
Propagate SkSurfaceProps when known

This CL just closes the loop on some low hanging fruit w.r.t. propagating surface properties.

Review URL: https://codereview.chromium.org/1214853025

9 years agoadd matrix options to drawDrawable
reed [Tue, 7 Jul 2015 17:22:31 +0000 (10:22 -0700)]
add matrix options to drawDrawable

BUG=skia:

Review URL: https://codereview.chromium.org/1224783002

9 years agostyle nit cleanups. e.g. remove 'virtual' on override declarations
robertphillips [Tue, 7 Jul 2015 17:05:18 +0000 (10:05 -0700)]
style nit cleanups. e.g. remove 'virtual' on override declarations

Review URL: https://codereview.chromium.org/1216433005

9 years agoMake sp- via support SkDrawables; add a GM to test it.
mtklein [Tue, 7 Jul 2015 16:43:28 +0000 (09:43 -0700)]
Make sp- via support SkDrawables; add a GM to test it.

BUG=skia:

Review URL: https://codereview.chromium.org/1212363005

9 years agoAdd libjpeg-turbo library (depends on yasm)
msarett [Tue, 7 Jul 2015 15:50:01 +0000 (08:50 -0700)]
Add libjpeg-turbo library (depends on yasm)
Mangle external function names to avoid conflict with libjpeg
Take advantage of direct color conversion (RGBA, BGRA, 565)
Prepare to use jpeg_skip_scanlines (when it is upstreamed)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d

Committed: https://skia.googlesource.com/skia/+/f8bf9181d7b0463c8e371755cfbb9ece90b34fc5

Committed: https://skia.googlesource.com/skia/+/e9e3ee33f30c14c31afd5fc3fe4dda7f15783c75

Committed: https://skia.googlesource.com/skia/+/40141b57f061fbfcc2fa38da942d9efe25aca4d0

Review URL: https://codereview.chromium.org/1180983002

9 years agoadd SkImage::NewFromBitmap
reed [Tue, 7 Jul 2015 13:11:19 +0000 (06:11 -0700)]
add SkImage::NewFromBitmap

BUG=skia:

Review URL: https://codereview.chromium.org/1217053003

9 years agoRevert of Revert of Fixing libpng transform use (patchset #1 id:1 of https://coderev...
scroggo [Tue, 7 Jul 2015 13:09:08 +0000 (06:09 -0700)]
Revert of Revert of Fixing libpng transform use  (patchset #1 id:1 of https://codereview.chromium.org/1213743004/)

Reason for revert:
This appears to have been reverted in order to fix the DEPS roll in https://codereview.chromium.org/1214943004/

However, it only affects SkCodec, which is not used by Chromium. Relanding

Original issue's description:
> Revert of Fixing libpng transform use  (patchset #5 id:80001 of https://codereview.chromium.org/1214203005/)
>
> Reason for revert:
> DEPS roll failing
>
> Original issue's description:
> > This change:
> > - supports kGray correctly
> > - avoid extra call to png_get_IHDR by storing the bit depth
> > - call transforms as needed
> > - checks for tRNS alpha value in RGB and GRAY color types
> >
> >
> > BUG=skia:
> >
> > Committed: https://skia.googlesource.com/skia/+/9693037fd41b7ce545b44beaa3489dcfd915018c
>
> TBR=scroggo@google.com,msarett@google.com,emmaleer@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/6c90e09575c1a77aee060aa475fdb3d25a17d6a0

TBR=msarett@google.com,emmaleer@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1215853005

9 years agoFix up SkMatrix::isFinite call
robertphillips [Mon, 6 Jul 2015 19:15:34 +0000 (12:15 -0700)]
Fix up SkMatrix::isFinite call

Review URL: https://codereview.chromium.org/1228473004

9 years agoWhen three or more edges are coincident, the logic needs
caryclark [Mon, 6 Jul 2015 18:38:33 +0000 (11:38 -0700)]
When three or more edges are coincident, the logic needs
to compute the overlapping ranges and combine the winding
into a single destination.

This computes coincidence more rigorously, fixing the
edge cases exposed by this bug.

Also, add the ability to debug and dump pathop structures
from the coincident context.

TBR=reed@google.com
BUG=skia:3651

Review URL: https://codereview.chromium.org/1182493015

9 years agoAdd nanobench-style JSON output to llvm_coverage_run
borenet [Mon, 6 Jul 2015 18:18:45 +0000 (11:18 -0700)]
Add nanobench-style JSON output to llvm_coverage_run

Runs the build and run scripts for coverage, then dumps the results into
a file in nanobench-compatible format.

BUG=skia:2430

Review URL: https://codereview.chromium.org/1227523004

9 years agoUse kLow_SkFilterQuality in DrawBitmapAABench
fmalita [Mon, 6 Jul 2015 15:20:15 +0000 (08:20 -0700)]
Use kLow_SkFilterQuality in DrawBitmapAABench

BUG=skia:4001
R=reed@google.com

Review URL: https://codereview.chromium.org/1222713007

9 years agoRevert of Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction...
robertphillips [Mon, 6 Jul 2015 14:59:09 +0000 (07:59 -0700)]
Revert of Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1207353004/)

Reason for revert:
Still want to disable due to pref regression

Original issue's description:
> Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1219193002/)
>
> Reason for revert:
> Blocking the roll
>
> Original issue's description:
> > Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/)
> >
> > Reason for revert:
> > Perf regression: https://code.google.com/p/chromium/issues/detail?id=505564
> >
> > Original issue's description:
> > > Fix SkTileImageFilter clipping/cropRect interaction issue
> > >
> > > BUG=499499
> > >
> > > Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391
> >
> > TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=499499
> >
> > Committed: https://skia.googlesource.com/skia/+/ebaf6a69bf604c85185e23aca3fb93308e747ff5
>
> TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com,reed@chromium.org,bsalomon@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=499499
>
> Committed: https://skia.googlesource.com/skia/+/835510085062f055c04d8ea46d82831cfbe51793

TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,reed@chromium.org,bsalomon@google.com,jvanverth@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=499499

Review URL: https://codereview.chromium.org/1217303004

9 years agoAdd scripts for running LLVM coverage
borenet [Mon, 6 Jul 2015 14:43:58 +0000 (07:43 -0700)]
Add scripts for running LLVM coverage

BUG=skia:2430

Review URL: https://codereview.chromium.org/1213063009

9 years agoAdd a bench for measuring drawBitmap anti-aliasing overhead
fmalita [Mon, 6 Jul 2015 12:25:17 +0000 (05:25 -0700)]
Add a bench for measuring drawBitmap anti-aliasing overhead

R=reed@google.com,mtklein@google.com

Review URL: https://codereview.chromium.org/1207403007

9 years agoUpdate SKP version
skia.buildbots [Mon, 6 Jul 2015 12:25:09 +0000 (05:25 -0700)]
Update SKP version

Automatic commit by the RecreateSKPs bot.

TBR=
NO_MERGE_BUILDS

Review URL: https://codereview.chromium.org/1222483003

9 years agoadd colortable param to newrastercopy
reed [Sat, 4 Jul 2015 04:01:10 +0000 (21:01 -0700)]
add colortable param to newrastercopy

BUG=skia:
TBR=
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/1222683004

9 years agoexplicitly bump legacy genID on gpu surface
reed [Fri, 3 Jul 2015 17:43:43 +0000 (10:43 -0700)]
explicitly bump legacy genID on gpu surface

Previous attempt to "test" getTextureHandle was giving false-positive because we had an active image-snapshot, which was incidentally also triggering a new genID.

I think this CL will also enable this change: https://codereview.chromium.org/1222243002/

BUG=skia:
TBR=bsalomon@google.com
NOTREECHECKS=True

Review URL: https://codereview.chromium.org/1208993008

9 years agoRevert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchs...
jvanverth [Fri, 3 Jul 2015 12:48:53 +0000 (05:48 -0700)]
Revert of Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #1 id:1 of https://codereview.chromium.org/1219193002/)

Reason for revert:
Blocking the roll

Original issue's description:
> Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/)
>
> Reason for revert:
> Perf regression: https://code.google.com/p/chromium/issues/detail?id=505564
>
> Original issue's description:
> > Fix SkTileImageFilter clipping/cropRect interaction issue
> >
> > BUG=499499
> >
> > Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391
>
> TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=499499
>
> Committed: https://skia.googlesource.com/skia/+/ebaf6a69bf604c85185e23aca3fb93308e747ff5

TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com,reed@chromium.org,bsalomon@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=499499

Review URL: https://codereview.chromium.org/1207353004

9 years agoRevert of Implement support for CHROMIUM_path_rendering pseudo extension (patchset...
jvanverth [Thu, 2 Jul 2015 19:53:27 +0000 (12:53 -0700)]
Revert of Implement support for CHROMIUM_path_rendering pseudo extension (patchset #4 id:60001 of https://codereview.chromium.org/1192663002/)

Reason for revert:
DEPS roll failing

Original issue's description:
> Implement support for CHROMIUM_path_rendering pseudo extension
>
> Implement support for path rendering in Chromium through
> CHROMIUM_path_rendering pseudo extension.
>
> The extension defines a new pseudo-gl function,
> BindFragmentInputLocation. This behaves similarly to the
> BindUniformLocation pseudo-gl function. The idea is to assign fragment
> input location to a fragment input before linking the program.
>
> BUG=chromium:344330
>
> Committed: https://skia.googlesource.com/skia/+/eeef46d181f9f8db388ecea81df699fc1b3c9280

TBR=bsalomon@google.com,joshualitt@google.com,kkinnunen@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:344330

Review URL: https://codereview.chromium.org/1223673002

9 years agoRevert of Switch SkJpegCode to libjpeg-turbo (patchset #29 id:750001 of https://coder...
jvanverth [Thu, 2 Jul 2015 17:40:24 +0000 (10:40 -0700)]
Revert of Switch SkJpegCode to libjpeg-turbo (patchset #29 id:750001 of https://codereview.chromium.org/1180983002/)

Reason for revert:
DEPS roll failing

Original issue's description:
> Add libjpeg-turbo library (depends on yasm)
> Mangle external function names to avoid conflict with libjpeg
> Take advantage of direct color conversion (RGBA, BGRA, 565)
> Prepare to use jpeg_skip_scanlines (when it is upstreamed)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d
>
> Committed: https://skia.googlesource.com/skia/+/f8bf9181d7b0463c8e371755cfbb9ece90b34fc5
>
> Committed: https://skia.googlesource.com/skia/+/e9e3ee33f30c14c31afd5fc3fe4dda7f15783c75
>
> Committed: https://skia.googlesource.com/skia/+/40141b57f061fbfcc2fa38da942d9efe25aca4d0

TBR=scroggo@google.com,djsollen@google.com,emmaleer@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1226543003

9 years agoRevert of Fixing libpng transform use (patchset #5 id:80001 of https://codereview...
jvanverth [Thu, 2 Jul 2015 17:35:25 +0000 (10:35 -0700)]
Revert of Fixing libpng transform use  (patchset #5 id:80001 of https://codereview.chromium.org/1214203005/)

Reason for revert:
DEPS roll failing

Original issue's description:
> This change:
> - supports kGray correctly
> - avoid extra call to png_get_IHDR by storing the bit depth
> - call transforms as needed
> - checks for tRNS alpha value in RGB and GRAY color types
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/9693037fd41b7ce545b44beaa3489dcfd915018c

TBR=scroggo@google.com,msarett@google.com,emmaleer@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1213743004

9 years agoRevert of Fix libjpeg-turbo deps file (patchset #2 id:2 of https://codereview.chromiu...
jvanverth [Thu, 2 Jul 2015 17:35:08 +0000 (10:35 -0700)]
Revert of Fix libjpeg-turbo deps file (patchset #2 id:2 of https://codereview.chromium.org/1216303007/)

Reason for revert:
DEPS roll failing

Original issue's description:
> Fix libjpeg-turbo deps file
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4380f06a124c28a47dc99956d48c2d4c5bcb78e0

TBR=msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1226453003

9 years agoRevert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchs...
jvanverth [Thu, 2 Jul 2015 13:42:49 +0000 (06:42 -0700)]
Revert of Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate. (patchset #4 id:60001 of https://codereview.chromium.org/1215393002/)

Reason for revert:
Breaking the roll.

E.g. on android_chromium_gn_compile_dbg:

FAILED: /b/build/goma/gomacc ../../third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-g++ -MMD -MF obj/skia/ext/libskia.SkMemory_new_handler.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=1 -DENABLE_NOTIFICATIONS -DENABLE_BROWSER_CDMS -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DDONT_EMBED_BUILD_METADATA -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DDISABLE_NACL -DENABLE_CONFIGURATION_POLICY -DENABLE_SUPERVISED_USERS=1 -DENABLE_AUTOFILL_DIALOG=1 -DUSE_PROPRIETARY_CODECS -DV8_USE_EXTERNAL_STARTUP_DATA -DVIDEO_HOLE=1 -DMOBILE_SAFE_BROWSING -DSAFE_BROWSING_SERVICE -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64 -DANDROID -DHAVE_SYS_UIO_H -DCOMPONENT_BUILD -D__GNU_SOURCE=1 -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DSKIA_IMPLEMENTATION=1 -DSK_ARM_HAS_OPTIONAL_NEON -DSK_GAMMA_APPLY_TO_A8 -DSK_GAMMA_EXPONENT=1.4 -DSK_GAMMA_CONTRAST=0.0 -DSK_DEFAULT_FONT_CACHE_LIMIT=1048576 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_ANDROID -DUSE_CHROMIUM_SKIA -DXML_STATIC -I../.. -Igen -I../../third_party/skia/include/private -I../../third_party/skia/src/core -I../../third_party/skia/src/image -I../../third_party/skia/src/opts -I../../third_party/skia/src/pdf -I../../third_party/skia/src/ports -I../../third_party/skia/src/sfnt -I../../third_party/skia/src/utils -I../../third_party/skia/src/lazy -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/zlib -I../../third_party/expat/files/lib -I../../third_party/freetype-android/include -I../../third_party/freetype-android/src/include -I../../third_party/android_tools/ndk/sources/android/cpufeatures -fno-strict-aliasing -march=armv7-a -mfloat-abi=softfp -mtune=generic-armv7-a -mthumb -mthumb-interwork -fno-tree-sra -fno-caller-saves -funwind-tables -fPIC -pipe -ffunction-sections -funwind-tables -fno-short-enums -finline-limit=64 -mfpu=vfpv3-d16 -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++/libcxx/include -isystem../../third_party/android_tools/ndk/sources/cxx-stl/llvm-libc++abi/libcxxabi/include -isystem../../third_party/android_tools/ndk/sources/android/support/include -fvisibility=hidden --sysroot=/b/build/slave/android_chromium_gn/build/src/third_party/android_tools/ndk/platforms/android-16/arch-arm -Os -fdata-sections -ffunction-sections -fomit-frame-pointer -g1 -Wno-format -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi -Wno-extra -Wno-ignored-qualifiers -Wno-type-limits -Wno-unused-local-typedefs -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -Wno-deprecated -Wno-narrowing -Wno-literal-suffix -Wno-error=c++0x-compat -Wno-non-virtual-dtor -Wno-sign-promo -c ../../skia/ext/SkMemory_new_handler.cpp -o obj/skia/ext/libskia.SkMemory_new_handler.o
../../skia/ext/SkMemory_new_handler.cpp:12:52: fatal error: third_party/skia/include/core/SkThread.h: No such file or directory
 #include "third_party/skia/include/core/SkThread.h"

Original issue's description:
> Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.
>
> SkThread.h doesn't do anything anymore execept include those two,
> and thankfully, it doesn't seem to be mentioned outside Skia.
>
> No public API changes.
> TBR=reed@google.com
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/c50acf2321d7a934c80d754e9cbe936dfb8eb4cc

TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1214603003

9 years agoImplement support for CHROMIUM_path_rendering pseudo extension
kkinnunen [Thu, 2 Jul 2015 10:01:43 +0000 (03:01 -0700)]
Implement support for CHROMIUM_path_rendering pseudo extension

Implement support for path rendering in Chromium through
CHROMIUM_path_rendering pseudo extension.

The extension defines a new pseudo-gl function,
BindFragmentInputLocation. This behaves similarly to the
BindUniformLocation pseudo-gl function. The idea is to assign fragment
input location to a fragment input before linking the program.

BUG=chromium:344330

Review URL: https://codereview.chromium.org/1192663002

9 years agoFix libjpeg-turbo deps file
Matt Sarett [Wed, 1 Jul 2015 22:56:52 +0000 (18:56 -0400)]
Fix libjpeg-turbo deps file

BUG=skia:

Review URL: https://codereview.chromium.org/1216303007.

9 years agowhitespace
Matt Sarett [Wed, 1 Jul 2015 22:21:42 +0000 (18:21 -0400)]
whitespace

9 years agoThis change:
emmaleer [Wed, 1 Jul 2015 21:44:32 +0000 (14:44 -0700)]
This change:
- supports kGray correctly
- avoid extra call to png_get_IHDR by storing the bit depth
- call transforms as needed
- checks for tRNS alpha value in RGB and GRAY color types

BUG=skia:

Review URL: https://codereview.chromium.org/1214203005

9 years agoAdd libjpeg-turbo library (depends on yasm)
msarett [Wed, 1 Jul 2015 21:41:02 +0000 (14:41 -0700)]
Add libjpeg-turbo library (depends on yasm)
Mangle external function names to avoid conflict with libjpeg
Take advantage of direct color conversion (RGBA, BGRA, 565)
Prepare to use jpeg_skip_scanlines (when it is upstreamed)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d

Committed: https://skia.googlesource.com/skia/+/f8bf9181d7b0463c8e371755cfbb9ece90b34fc5

Committed: https://skia.googlesource.com/skia/+/e9e3ee33f30c14c31afd5fc3fe4dda7f15783c75

Review URL: https://codereview.chromium.org/1180983002

9 years agoRemove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.
mtklein [Wed, 1 Jul 2015 21:00:57 +0000 (14:00 -0700)]
Remove SkThread.h, include SkMutex.h or SkAtomics.h as appropriate.

SkThread.h doesn't do anything anymore execept include those two,
and thankfully, it doesn't seem to be mentioned outside Skia.

No public API changes.
TBR=reed@google.com

BUG=skia:

Review URL: https://codereview.chromium.org/1215393002

9 years agoAdd support for drawBitmapRect() to SkMiniRecorder.
mtklein [Wed, 1 Jul 2015 20:56:53 +0000 (13:56 -0700)]
Add support for drawBitmapRect() to SkMiniRecorder.

BUG=chromium:503705

Review URL: https://codereview.chromium.org/1220733006

9 years agoRevert "Move headers used by headers in include/ to include/private."
Mike Klein [Wed, 1 Jul 2015 20:35:59 +0000 (16:35 -0400)]
Revert "Move headers used by headers in include/ to include/private."

This reverts commit 928e16565f3e69cd6661e9ad300ac17e3f33c0c8.

BUG=skia:

Review URL: https://codereview.chromium.org/1213093004.

9 years agoRevert of Switch SkJpegCode to libjpeg-turbo (patchset #28 id:710001 of https://coder...
msarett [Wed, 1 Jul 2015 20:11:08 +0000 (13:11 -0700)]
Revert of Switch SkJpegCode to libjpeg-turbo (patchset #28 id:710001 of https://codereview.chromium.org/1180983002/)

Reason for revert:
Broke iOS build.

Original issue's description:
> Add libjpeg-turbo library (depends on yasm)
> Mangle external function names to avoid conflict with libjpeg
> Take advantage of direct color conversion (RGBA, BGRA, 565)
> Prepare to use jpeg_skip_scanlines (when it is upstreamed)
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d
>
> Committed: https://skia.googlesource.com/skia/+/f8bf9181d7b0463c8e371755cfbb9ece90b34fc5
>
> Committed: https://skia.googlesource.com/skia/+/e9e3ee33f30c14c31afd5fc3fe4dda7f15783c75

TBR=scroggo@google.com,djsollen@google.com,emmaleer@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Review URL: https://codereview.chromium.org/1213093003

9 years agoDon't cap num_cores at 32 on 32-bit Windows.
mtklein [Wed, 1 Jul 2015 20:06:49 +0000 (13:06 -0700)]
Don't cap num_cores at 32 on 32-bit Windows.

See here for a similar change in Ninja.  Wanna bet they just got Z840s too?
https://github.com/martine/ninja/commit/8c8834acffdc0da0d94119725929acc712c9dfad

BUG=skia:

Review URL: https://codereview.chromium.org/1213063011

9 years agocleanup GLBenches
joshualitt [Wed, 1 Jul 2015 19:39:07 +0000 (12:39 -0700)]
cleanup GLBenches

BUG=skia:

Review URL: https://codereview.chromium.org/1214203004

9 years agoAdd libjpeg-turbo library (depends on yasm)
msarett [Wed, 1 Jul 2015 19:36:18 +0000 (12:36 -0700)]
Add libjpeg-turbo library (depends on yasm)
Mangle external function names to avoid conflict with libjpeg
Take advantage of direct color conversion (RGBA, BGRA, 565)
Prepare to use jpeg_skip_scanlines (when it is upstreamed)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/b60c3f8291529303299262dba19b1a896060bd2d

Committed: https://skia.googlesource.com/skia/+/f8bf9181d7b0463c8e371755cfbb9ece90b34fc5

Review URL: https://codereview.chromium.org/1180983002

9 years agoMove headers used by headers in include/ to include/private.
mtklein [Wed, 1 Jul 2015 18:55:42 +0000 (11:55 -0700)]
Move headers used by headers in include/ to include/private.

Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/a89f55198bdc58f0b6f6196907ab25a6afc1a661

Review URL: https://codereview.chromium.org/1217293004

9 years agoRevert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2...
bsalomon [Wed, 1 Jul 2015 18:02:50 +0000 (11:02 -0700)]
Revert of Fix SkTileImageFilter clipping/cropRect interaction issue (patchset #2 id:30001 of https://codereview.chromium.org/1210053003/)

Reason for revert:
Perf regression: https://code.google.com/p/chromium/issues/detail?id=505564

Original issue's description:
> Fix SkTileImageFilter clipping/cropRect interaction issue
>
> BUG=499499
>
> Committed: https://skia.googlesource.com/skia/+/157bcd0840b578060dbc3365daafffc6837da391

TBR=reed@google.com,senorblanco@google.com,senorblanco@chromium.org,robertphillips@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=499499

Review URL: https://codereview.chromium.org/1219193002

9 years agoRevert "Move headers used by headers in include/ to include/private."
jvanverth [Wed, 1 Jul 2015 16:45:46 +0000 (09:45 -0700)]
Revert "Move headers used by headers in include/ to include/private."

This reverts commit a89f55198bdc58f0b6f6196907ab25a6afc1a661.

Reason: breaking the roll.

TBR=mtklein@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1216033008

9 years agoMove headers used by headers in include/ to include/private.
mtklein [Wed, 1 Jul 2015 15:41:14 +0000 (08:41 -0700)]
Move headers used by headers in include/ to include/private.

Some of this is transitive, like SkRecords.h used by SkMiniRecorder.h
used by (public) SkPictureRecorder.h.

BUG=skia:

Review URL: https://codereview.chromium.org/1217293004

9 years agofix for angle
joshualitt [Wed, 1 Jul 2015 15:34:50 +0000 (08:34 -0700)]
fix for angle

BUG=skia:

Review URL: https://codereview.chromium.org/1216963011

9 years agoThread through a flag to force SkPicture::playback() when recording subpictures.
mtklein [Wed, 1 Jul 2015 14:04:37 +0000 (07:04 -0700)]
Thread through a flag to force SkPicture::playback() when recording subpictures.

This makes nanobench picture recording benchmarks somewhat useful again,
as opposed to all taking about 5us to run no matter the content.

ATTN Sheriff: this will probably trigger perf.skia.org alerts.

BUG=skia:

Review URL: https://codereview.chromium.org/1219873002

9 years agoIn the case of subset decodes, we will often not decode to
msarett [Wed, 1 Jul 2015 13:50:35 +0000 (06:50 -0700)]
In the case of subset decodes, we will often not decode to
the bottom of the image.  In our code before this patch,
this would result in cleanup code in onFinish() never being
called.

We can allow subclasses to take ownership of the
SkScanlineDecoder in order to make sure that it is
finished/deleted before deleting the decode manager.

BUG=skia:

Review URL: https://codereview.chromium.org/1212593003

9 years agoBenchmark to test cost for additional vertex attributes
joshualitt [Wed, 1 Jul 2015 13:20:13 +0000 (06:20 -0700)]
Benchmark to test cost for additional vertex attributes

BUG=skia:

Review URL: https://codereview.chromium.org/1213233011

9 years agoFix dm failures after Cleanup legacy NVPR-related definitions
kkinnunen [Wed, 1 Jul 2015 11:31:29 +0000 (04:31 -0700)]
Fix dm failures after Cleanup legacy NVPR-related definitions

Non-NV_path_rendering drivers should always return NULL context
for NVPR context type request. Fix this.

This was needed due to the previous patch trying to implement below:
NV_path_rendering drivers should return non-NULL context
for NVPR context type request, regardless whether path
rendering is actually supported or not. This is due to SAN
bots having older drivers and trying to run nvprmsaa config.

Review URL: https://codereview.chromium.org/1220513005

9 years agoCleanup legacy NVPR-related definitions
kkinnunen [Wed, 1 Jul 2015 09:58:50 +0000 (02:58 -0700)]
Cleanup legacy NVPR-related definitions

Fixed-function NVPR codepaths were removed a while ago. Only NVPR API
version 1.3 (PathFragmentInputGen) was left working. Remove
backwards-compatibility code that was left behind.

Remove some NVPR API function typedefs that were left from initial
commits.

Remove PathCoords function pointer from GrGLInterface, it has
never been called and causes problems in the future, since it will
not be implemented in the Chromium pseudo extension.

Avoid failing interface creation even if nvprmsaaXX config is
requested but the driver is not recent enough. The SAN bots have
old driver, but try to run nvprmsaa16 configs. Instead, print
out a warning.

Committed: https://skia.googlesource.com/skia/+/fb8d6884e0e01d0c2f8596adf5af1efb0d08de7e

Committed: https://skia.googlesource.com/skia/+/e35b5d99d8dfcc6b2be844df28cba47436380809

Review URL: https://codereview.chromium.org/1177243004

9 years agoRevert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. ...
herb [Tue, 30 Jun 2015 21:23:29 +0000 (14:23 -0700)]
Revert of Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating. (patchset #1 id:1 of https://codereview.chromium.org/1213033003/)

Reason for revert:
Add tsan annotations to repair tests.

Original issue's description:
> Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating.
>
> The ~ means "don't run this".  This keeps all the other bots running the code, skipping it only on the whiny TSAN bot.
>
> BUG=skia:3997
>
> Committed: https://skia.googlesource.com/skia/+/37cc0b2e31e4a078b12790253d7032d36271440c

TBR=mtklein@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3997

Review URL: https://codereview.chromium.org/1218153004

9 years agoAdd annotations to SkSharedMutex.
herb [Tue, 30 Jun 2015 21:12:16 +0000 (14:12 -0700)]
Add annotations to SkSharedMutex.

BUG=skia:3997

Review URL: https://codereview.chromium.org/1213663004

9 years agoFix infinite matrix during an invert.
vmpstr [Tue, 30 Jun 2015 20:36:04 +0000 (13:36 -0700)]
Fix infinite matrix during an invert.

This patch ensures that when inverting a SkMatrix44, we handle small
floats properly. When inverted these can cause infinite values, but
still evaluate to true in an if condition.

BUG=chromium:498516

Review URL: https://codereview.chromium.org/1209763002

9 years agoFix CodecSubset benches seg faults for kIndex8
msarett [Tue, 30 Jun 2015 20:29:37 +0000 (13:29 -0700)]
Fix CodecSubset benches seg faults for kIndex8

All of the CodecSubset benches fail when the color type is
kIndex8.  We need to pass a color table to allocPixels()
when we want to decode to kIndex8 or it will throw a failure.

BUG=skia:

Review URL: https://codereview.chromium.org/1213983003

9 years agoAdd SkSurface factory for wrapping an FBO in SkSurface
bsalomon [Tue, 30 Jun 2015 19:04:40 +0000 (12:04 -0700)]
Add SkSurface factory for wrapping an FBO in SkSurface

Review URL: https://codereview.chromium.org/1221853003

9 years agoRename flushForExternalRead->flushForExternalIO and always call in SkSurface::getText...
bsalomon [Tue, 30 Jun 2015 18:37:35 +0000 (11:37 -0700)]
Rename flushForExternalRead->flushForExternalIO and always call in SkSurface::getTextureHandle

Review URL: https://codereview.chromium.org/1216243003

9 years agoSkip SkSharedMutexMultiThreaded test on TSAN bot while investigating.
mtklein [Tue, 30 Jun 2015 17:51:50 +0000 (10:51 -0700)]
Skip SkSharedMutexMultiThreaded test on TSAN bot while investigating.

The ~ means "don't run this".  This keeps all the other bots running the code, skipping it only on the whiny TSAN bot.

BUG=skia:3997

Review URL: https://codereview.chromium.org/1213033003

9 years agoAdd wrapper script for computing n-grams from SKPs on Cluster Telemetry
borenet [Tue, 30 Jun 2015 17:24:03 +0000 (10:24 -0700)]
Add wrapper script for computing n-grams from SKPs on Cluster Telemetry

Add --n argument

BUG=skia:3840

Review URL: https://codereview.chromium.org/1216073007

9 years agoPass arguments to SkRecords structs by const&.
mtklein [Tue, 30 Jun 2015 16:49:49 +0000 (09:49 -0700)]
Pass arguments to SkRecords structs by const&.

This has the effect of using delay_copy() on every argument,
obviating the need for delay_copy() and, crucially, having
to remember to call delay_copy().

All these constructors are fully inlined, so we'll never pay
a penalty for passing small things by reference... the compiler
can see that and just pass by value.

BUG=skia:

Review URL: https://codereview.chromium.org/1215523004

9 years agoRevert of Cleanup legacy NVPR-related definitions (patchset #4 id:60001 of https...
jvanverth [Tue, 30 Jun 2015 16:40:38 +0000 (09:40 -0700)]
Revert of Cleanup legacy NVPR-related definitions (patchset #4 id:60001 of https://codereview.chromium.org/1177243004/)

Reason for revert:
Breaks the Ubuntu *SAN bots.

Original issue's description:
> Cleanup legacy NVPR-related definitions
>
> Fixed-function NVPR codepaths were removed a while ago. Only NVPR API
> version 1.3 (PathFragmentInputGen) was left working. Remove
> backwards-compatibility code that was left behind.
>
> Remove some NVPR API function typedefs that were left from initial
> commits.
>
> Remove PathCoords function pointer from GrGLInterface, it has
> never been called and causes problems in the future, since it will
> not be implemented in the Chromium pseudo extension.
>
> Committed: https://skia.googlesource.com/skia/+/fb8d6884e0e01d0c2f8596adf5af1efb0d08de7e
>
> Committed: https://skia.googlesource.com/skia/+/e35b5d99d8dfcc6b2be844df28cba47436380809

TBR=joshualitt@google.com,cdalton@nvidia.com,bsalomon@google.com,kkinnunen@nvidia.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1219663005

9 years agoRemove default for --images in common flags
bsalomon [Tue, 30 Jun 2015 16:38:35 +0000 (09:38 -0700)]
Remove default for --images in common flags

Review URL: https://codereview.chromium.org/1214363002

9 years agoUse AddStory instead of deprecated AddUserStory
rmistry [Tue, 30 Jun 2015 16:20:17 +0000 (09:20 -0700)]
Use AddStory instead of deprecated AddUserStory

BUG=skia:3967
TBR=nednguyen
NOTRY=true

Review URL: https://codereview.chromium.org/1212843008

9 years agoFix blur bug on Andreno 430 with bool cast to float
bsalomon [Tue, 30 Jun 2015 16:19:14 +0000 (09:19 -0700)]
Fix blur bug on Andreno 430 with bool cast to float

BUG=skia:3944

Review URL: https://codereview.chromium.org/1214483007

9 years agoRevert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 id:1...
rmistry [Tue, 30 Jun 2015 15:22:25 +0000 (08:22 -0700)]
Revert of Use page_set_module.PageSet instead of story.StorySet (patchset #1 id:1 of https://codereview.chromium.org/1221553003/)

Reason for revert:
This should no longer be required due to Ned's fix in https://codereview.chromium.org/1217823005/

Original issue's description:
> Use page_set_module.PageSet instead of story.StorySet
>
> BUG=skia:3967
> NOTRY=true
> TBR=nednguyen
>
> Committed: https://skia.googlesource.com/skia/+/7b971f0152299ae9a924252a9bfd220318497bdd

TBR=nednguyen@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3967

Review URL: https://codereview.chromium.org/1214903008

9 years agoAdd benchmarkstream to visualbench
joshualitt [Tue, 30 Jun 2015 14:43:14 +0000 (07:43 -0700)]
Add benchmarkstream to visualbench

BUG=skia:

Review URL: https://codereview.chromium.org/1215033002

9 years agoUpdate blur image filter bench to have crop variation
bsalomon [Tue, 30 Jun 2015 14:42:42 +0000 (07:42 -0700)]
Update blur image filter bench to have crop variation

BUG=skia:3944

Review URL: https://codereview.chromium.org/1212973004

9 years agoChange initializer list order to match field declaration order.
sammc [Tue, 30 Jun 2015 14:09:49 +0000 (07:09 -0700)]
Change initializer list order to match field declaration order.

BUG=chromium:505304

Review URL: https://codereview.chromium.org/1214933004

9 years agoMove visualbench to its own folder
joshualitt [Tue, 30 Jun 2015 13:50:10 +0000 (06:50 -0700)]
Move visualbench to its own folder

BUG=skia:

Review URL: https://codereview.chromium.org/1216973002

9 years agoUse page_set_module.PageSet instead of story.StorySet
rmistry [Tue, 30 Jun 2015 12:03:05 +0000 (05:03 -0700)]
Use page_set_module.PageSet instead of story.StorySet

BUG=skia:3967
NOTRY=true
TBR=nednguyen

Review URL: https://codereview.chromium.org/1221553003

9 years agoCleanup legacy NVPR-related definitions
kkinnunen [Tue, 30 Jun 2015 10:59:50 +0000 (03:59 -0700)]
Cleanup legacy NVPR-related definitions

Fixed-function NVPR codepaths were removed a while ago. Only NVPR API
version 1.3 (PathFragmentInputGen) was left working. Remove
backwards-compatibility code that was left behind.

Remove some NVPR API function typedefs that were left from initial
commits.

Remove PathCoords function pointer from GrGLInterface, it has
never been called and causes problems in the future, since it will
not be implemented in the Chromium pseudo extension.

Committed: https://skia.googlesource.com/skia/+/fb8d6884e0e01d0c2f8596adf5af1efb0d08de7e

Review URL: https://codereview.chromium.org/1177243004