platform/upstream/llvm.git
3 years ago[SCEV] Stop blindly propagating flags from inbound geps to SCEV nodes
Philip Reames [Fri, 1 Oct 2021 23:30:44 +0000 (16:30 -0700)]
[SCEV] Stop blindly propagating flags from inbound geps to SCEV nodes

This fixes a violation of the wrap flag rules introduced in c4048d8f. This was also noted in the (very old) PR23527.

The issue being fixed is that we assume the inbound flag on any GEP assumes that all users of *any* gep (or add) which happens to map to that SCEV would also be UB if the (other) gep overflowed. That's simply not true.

In terms of the test diffs, I don't see anything seriously problematic. The lost flags are expected (given the semantic restriction on when its legal to tag the SCEV), and there are several cases where the previously inferred flags are unsound per the new semantics.

The only common trend I noticed when looking at the deltas is that by not considering branch on poison as immediate UB in ValueTracking, we do miss a few cases we could reclaim. We may be able to claw some of these back with the follow ideas mentioned in PR51817.

It's worth noting that most of the changes are analysis result only changes. The two transform changes are pretty minimal. In one case, we miss the opportunity to infer a nuw (correctly). In the other, we fail to fold an exit and produce a loop invariant form instead. This one is probably over-reduced as the program appears to be undefined in practice, and neither before or after exploits that.

Differential Revision: https://reviews.llvm.org/D109789

3 years ago[SCEV] Remove invariant requirement from isSCEVExprNeverPoison
Philip Reames [Fri, 1 Oct 2021 22:57:37 +0000 (15:57 -0700)]
[SCEV] Remove invariant requirement from isSCEVExprNeverPoison

This code is attempting to prove that I must execute if we enter the defining scope of the SCEV which will be created from I. In the case where it found a defining addrec scope, it had a rather odd restriction that all of the other operands must be loop invariant in that addrec's loop.

As near as I can tell here, we really only need a upper bound on the defining scope. If we can prove the stronger property, then we must also have proven the property on the exact defining scope as well.

In practice, the actual effect of this change is narrow. The compile time restriction at the top of the routine basically limits us to I being an arithmetic in some loop L with both an addrec operand in L, and a unknown operands in L. Possible to demonstrate, but the main value of the change is removing unneeded code.

Differential Revision: https://reviews.llvm.org/D110892

3 years ago[test] split flags-from-poison.ll to allow ease of autogen update
Philip Reames [Fri, 1 Oct 2021 22:34:58 +0000 (15:34 -0700)]
[test] split flags-from-poison.ll to allow ease of autogen update

3 years ago[AArch64][GlobalISel] Change G_ANYEXT fed by scalar G_ICMP to G_ZEXT
Jessica Paquette [Fri, 1 Oct 2021 16:22:51 +0000 (09:22 -0700)]
[AArch64][GlobalISel] Change G_ANYEXT fed by scalar G_ICMP to G_ZEXT

This is a common pattern:

```
    %icmp:_(s32) = G_ICMP intpred(eq), ...
    %ext:_(s64) = G_ANYEXT %icmp(s32)
    %and:_(s64) = G_AND %ext, 1
```

Here's an example: https://godbolt.org/z/T13f6o8zE

This pattern appears because of the following combine in the
LegalizationArtifactCombiner:

```
// zext(trunc x) - > and (aext/copy/trunc x), mask
```

Which kicks in when we widen the result of G_ICMP from 1 bit to 32 bits.

We know that, on AArch64, a scalar G_ICMP will produce 0 or 1. So the result
of `%ext` will always be 0 or 1 as well.

We have some KnownBits combines which eliminate redundant G_ANDs with masks.
These combines don't kick in with G_ANYEXT.

So, if we replace the G_ANYEXT with G_ZEXT in this situation, the KnownBits
based combines can remove the redundant G_AND.

I wasn't sure if it woud be more appropriate to

* Take this route
* Put this in the LegalizationArtifactCombiner.
* Allow 64 bit G_ICMP destinations

I decided on this route because

1) It's simple

2) I'm not sure if philosophically-speaking, we should be handling non-artifact
instructions + target-specific details like TargetBooleanContents in the
LegalizationArtifactCombiner

3) There is a lot of existing code which assumes we only have 32 bit G_ICMP
destinations. So, adding support for 64-bit destinations seems rather invasive
right now. I think that adding support for 64-bit destinations, or modelling
G_ICMP as ADDS/SUBS/etc is probably cleaner long term though.

This gives minor code size savings on all CTMark benchmarks.

Differential Revision: https://reviews.llvm.org/D110959

3 years ago[NFC][PowerPC] Add test case for byval store.
Stefan Pintilie [Fri, 1 Oct 2021 21:46:46 +0000 (16:46 -0500)]
[NFC][PowerPC] Add test case for byval store.

Added a test case for situations where a struct of size 1-7 bytes is
passed by value.

3 years agoRevert "[DomTree] Assert that blocks in queries aren't from another function"
Daniil Suchkov [Fri, 1 Oct 2021 21:49:38 +0000 (21:49 +0000)]
Revert "[DomTree] Assert that blocks in queries aren't from another function"

This reverts commit 86046516e4f4527213c595c154c9971d81a49601.
This assertion fails on https://lab.llvm.org/buildbot/#/builders/98/builds/6690
Reverting it for now.

3 years agoRevert "tsan: fix and test detection of TLS races"
Amy Kwan [Fri, 1 Oct 2021 21:38:20 +0000 (16:38 -0500)]
Revert "tsan: fix and test detection of TLS races"

This reverts commit b4c1e5cb73bd26e5853af77c2a235ca9f35e2577.

Reverting this as it contains a test that is currently failing on the PPC BE bots.

3 years agoRevert "tsan: fix tls_race3 test on darwin"
Amy Kwan [Fri, 1 Oct 2021 21:35:15 +0000 (16:35 -0500)]
Revert "tsan: fix tls_race3 test on darwin"

This reverts commit ade5023c54cffcbefe0557b5473d55b06e40809b.

Reverting this commit as it is dependent on a test breaking the PPC BE bots.

3 years agoRevert "tsan: print a meaningful frame for stack races"
Amy Kwan [Fri, 1 Oct 2021 21:32:32 +0000 (16:32 -0500)]
Revert "tsan: print a meaningful frame for stack races"

This reverts commit ccc83ac7c501c8e117753af0729414350aa9c117.

Reverting this commit as it is dependent on additional commits breaking the
PPC BE bots.

3 years ago[Profile] Add a warning when lock file failed in __llvm_profile_set_file_object with...
Zequan Wu [Fri, 1 Oct 2021 21:37:09 +0000 (14:37 -0700)]
[Profile] Add a warning when lock file failed in __llvm_profile_set_file_object with continuous mode

3 years ago[DomTree] Assert that blocks in queries aren't from another function
Daniil Suchkov [Tue, 28 Sep 2021 23:44:50 +0000 (23:44 +0000)]
[DomTree] Assert that blocks in queries aren't from another function

This assertion should help us catch cases when DT is used in a way that
doesn't make much sense and usually indicates usage errors. In D110752
you can see a test on which this assertion catches a miscompile.

The assertion is added to getNode since all queries seem to be
routed through that function for all non-trivial cases.

Reviewed By: aeubanks, MaskRay
Differential Revision: https://reviews.llvm.org/D110751

3 years ago[SimpleLoopUnswitch] Don't unswitch constant conditions
Daniil Suchkov [Tue, 28 Sep 2021 23:51:15 +0000 (23:51 +0000)]
[SimpleLoopUnswitch] Don't unswitch constant conditions

Added an additional check for constants after simplification of
"select _, true, false" pattern. We need to prevent attempts to unswitch constant
conditions for two reasons:
a) Doing that doesn't make any sense, in the best case it will just burn
some compile time.
b) SimpleLoopUnswitch isn't designed to unswitch constant conditions
(due to (a)), so attempting that can cause miscompiles. The attached
testcase is an example of such miscompile.

Also added an assertion that'll make sure we aren't trying to replace
constants, so it will help us prevent such bugs in future. The assertion
from D110751 is another layer of protection against such cases.

Reviewed By: aeubanks
Differential Revision: https://reviews.llvm.org/D110752

3 years ago[Test] Add a test exposing a miscompile in SimpleLoopUnswitch.
Daniil Suchkov [Tue, 28 Sep 2021 23:30:50 +0000 (23:30 +0000)]
[Test] Add a test exposing a miscompile in SimpleLoopUnswitch.

The miscompile was introduced by 6b4b1dc6ec6f0bf0a1bb414fbe751ccab99d41a0.

3 years ago[mlir][sparse] Sharing calls to adaptor.getOperands()[0]
wren romano [Fri, 1 Oct 2021 00:51:42 +0000 (17:51 -0700)]
[mlir][sparse] Sharing calls to adaptor.getOperands()[0]

This is preliminary work towards D110790. Depends On D110883.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D110884

3 years ago[mlir][sparse] Factoring out allocaIndices()
wren romano [Fri, 1 Oct 2021 00:47:43 +0000 (17:47 -0700)]
[mlir][sparse] Factoring out allocaIndices()

This is preliminary work towards D110790. Depends On D110882.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D110883

3 years ago[mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params
wren romano [Fri, 1 Oct 2021 00:25:32 +0000 (17:25 -0700)]
[mlir][sparse] Factoring out getZero() and avoiding unnecessary Type params

This is preliminary work towards D110790

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D110882

3 years ago[BasicAA] Make test more robust (NFC)
Nikita Popov [Fri, 1 Oct 2021 20:53:55 +0000 (22:53 +0200)]
[BasicAA] Make test more robust (NFC)

When taking into account the fact that GEP indices are truncated
to 32-bits in this test, the "path dependence" goes away, so
inferring MustAlias for all pointers would be correct. As this
goes against the spirit of the test, change it to extend from
i16 instead.

3 years ago[BasicAA] Add additional truncation tests (NFC)
Nikita Popov [Fri, 1 Oct 2021 20:02:32 +0000 (22:02 +0200)]
[BasicAA] Add additional truncation tests (NFC)

These show that the known bits and non-zero heuristics are incorrect
when truncation is involved.

3 years ago[mlir][capi] Add TypeID to MLIR C-API
Daniel Resnick [Fri, 1 Oct 2021 00:14:00 +0000 (18:14 -0600)]
[mlir][capi] Add TypeID to MLIR C-API

Exposes mlir::TypeID to the C API as MlirTypeID along with various accessors
and helper functions.

Differential Revision: https://reviews.llvm.org/D110897

3 years ago[gn build] Port c8c2b4629f75
LLVM GN Syncbot [Fri, 1 Oct 2021 20:14:30 +0000 (20:14 +0000)]
[gn build] Port c8c2b4629f75

3 years ago[Demangle][Rust] Parse non-ASCII identifiers
Tomasz Miąsko [Fri, 1 Oct 2021 00:00:00 +0000 (00:00 +0000)]
[Demangle][Rust] Parse non-ASCII identifiers

Rust allows use of non-ASCII identifiers, which in Rust mangling scheme
are encoded using Punycode.

The encoding deviates from the standard by using an underscore as the
separator between ASCII part and a base-36 encoding of non-ASCII
characters (avoiding hypen-minus in the symbol name). Other than that,
the encoding follows the standard, and the decoder implemented here in
turn follows the one given in RFC 3492.

To avoid an extra intermediate memory allocation while decoding
Punycode, the interface of OutputStream is extended with an insert
method.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D104366

3 years ago[DAG] scalarizeExtractedVectorLoad - replace getABITypeAlign with allowsMemoryAccess...
Simon Pilgrim [Fri, 1 Oct 2021 20:07:26 +0000 (21:07 +0100)]
[DAG] scalarizeExtractedVectorLoad - replace getABITypeAlign with allowsMemoryAccess (PR45116)

One of the cases identified in PR45116 - we don't need to limit extracted loads to ABI alignment, we can use allowsMemoryAccess - which tests using getABITypeAlign, but also checks if a target permits (fast) misaligned memory loads by checking allowsMisalignedMemoryAccesses as a fallback.

I've also cleaned up the alignment calculation code - if we have a constant extraction index then the alignment can be based on an offset from the original vector load alignment, but for non-constant indices we should assume the worst (single element alignment only).

Differential Revision: https://reviews.llvm.org/D110486

3 years ago[TwoAddressInstruction] Tweak constraining of tied operands
Jay Foad [Fri, 1 Oct 2021 16:12:14 +0000 (17:12 +0100)]
[TwoAddressInstruction] Tweak constraining of tied operands

In collectTiedOperands, when handling an undef use that is tied to a
def, constrain the dst reg with the actual register class of the src
reg, instead of with the register class from the instructions's
MCInstrDesc. This makes a difference in some AMDGPU test cases like
this, before:

  %16:sgpr_96 = INSERT_SUBREG undef %15:sgpr_96_with_sub0_sub1(tied-def 0), killed %11:sreg_64_xexec, %subreg.sub0_sub1

After, without this patch:

  undef %16.sub0_sub1:sgpr_96 = COPY killed %11:sreg_64_xexec

This fails machine verification if you force it to run after
TwoAddressInstruction (currently it is disabled) with:

*** Bad machine code: Invalid register class for subregister index ***
- function:    s_load_constant_v3i32_align4
- basic block: %bb.0  (0xa011a88)
- instruction: undef %16.sub0_sub1:sgpr_96 = COPY killed %11:sreg_64_xexec
- operand 0:   undef %16.sub0_sub1:sgpr_96
Register class SGPR_96 does not fully support subreg index 4

After, with this patch:

  undef %16.sub0_sub1:sgpr_96_with_sub0_sub1 = COPY killed %11:sreg_64_xexec

See also svn r159120 which introduced the code to handle tied undef
uses.

Differential Revision: https://reviews.llvm.org/D110944

3 years ago[TwoAddressInstruction] Pre-commit a test case for D110944
Jay Foad [Fri, 1 Oct 2021 18:36:54 +0000 (19:36 +0100)]
[TwoAddressInstruction] Pre-commit a test case for D110944

3 years ago[NFC][X86][Codegen] Add test coverage for interleaved i8 load/store stride=4
Roman Lebedev [Fri, 1 Oct 2021 19:46:51 +0000 (22:46 +0300)]
[NFC][X86][Codegen] Add test coverage for interleaved i8 load/store stride=4

3 years ago[NFC][X86][LV] Improve costmodel test coverage for interleaved i8 load/store stride=4
Roman Lebedev [Fri, 1 Oct 2021 19:41:11 +0000 (22:41 +0300)]
[NFC][X86][LV] Improve costmodel test coverage for interleaved i8 load/store stride=4

3 years ago[AIX] Don't pass namedsects in LTO mode
Jinsong Ji [Fri, 1 Oct 2021 19:12:00 +0000 (19:12 +0000)]
[AIX] Don't pass namedsects in LTO mode

LTO don't need binder option , don't pass it in LTO mode.

Reviewed By: Whitney

Differential Revision: https://reviews.llvm.org/D110955

3 years ago[BasicAA] Add additional 32-bit truncation test (NFC)
Nikita Popov [Fri, 1 Oct 2021 19:18:24 +0000 (21:18 +0200)]
[BasicAA] Add additional 32-bit truncation test (NFC)

This is a variant with a variable index, in which case the pointer
size adjustment is not performed.

3 years ago[fir][NFC] Move fir.global printer to cpp file
Valentin Clement [Fri, 1 Oct 2021 19:14:14 +0000 (21:14 +0200)]
[fir][NFC] Move fir.global printer to cpp file

All big enough parser, printer and verifier are moved to the cpp file.
This is one of the last one to be moved.

This patch is part of the upstreaming effort from fir-dev branch.

Reviewed By: kiranchandramohan

Differential Revision: https://reviews.llvm.org/D110929

3 years agorevert tsan part for investigation
ZijunZhao [Fri, 1 Oct 2021 18:52:36 +0000 (18:52 +0000)]
revert tsan part for investigation

3 years ago[ORC] Fix LLVM modulemap after removal of ORC RPC in 33dd98e9e49.
Lang Hames [Fri, 1 Oct 2021 18:36:11 +0000 (11:36 -0700)]
[ORC] Fix LLVM modulemap after removal of ORC RPC in 33dd98e9e49.

3 years ago[lldb] [Host] Sync TerminalState::Data to struct type
Michał Górny [Fri, 1 Oct 2021 18:33:29 +0000 (20:33 +0200)]
[lldb] [Host] Sync TerminalState::Data to struct type

3 years ago[InstCombine] fold (trunc (X>>C1)) << C to shift+mask directly
Sanjay Patel [Fri, 1 Oct 2021 17:30:44 +0000 (13:30 -0400)]
[InstCombine] fold (trunc (X>>C1)) << C to shift+mask directly

This is no-externally-visible-functional-difference-intended.
That is, the test diffs show identical instructions other than
name changes (those are included specifically to verify the logic).

The existing transforms created extra instructions and relied
on subsequent folds to get to the final result, but that could
conflict with other transforms like the proposed D110170 (and
caused that patch to be reverted twice so far because of infinite
combine loops).

3 years ago[gn build] Port 33dd98e9e499
LLVM GN Syncbot [Fri, 1 Oct 2021 18:18:21 +0000 (18:18 +0000)]
[gn build] Port 33dd98e9e499

3 years ago[ORC] Remove ORC RPC.
Lang Hames [Fri, 1 Oct 2021 17:07:03 +0000 (10:07 -0700)]
[ORC] Remove ORC RPC.

With the removal of OrcRPCExecutorProcessControl and OrcRPCTPCServer in
6aeed7b19c4 the ORC RPC library no longer has any in-tree users.

Clients needing serialization for ORC should move to Simple Packed
Serialization (usually by adopting SimpleRemoteEPC for remote JITing).

3 years ago[mlir][linalg] Include InitTensorOp in tiling canonicalization
Lei Zhang [Fri, 1 Oct 2021 18:12:54 +0000 (14:12 -0400)]
[mlir][linalg] Include InitTensorOp in tiling canonicalization

Tiling can create dim ops and those dim ops can take `InitTensorOp`
as input. Including it in the tiling canonicalization patterns
allows us to fold those dim ops away.

Also sorted the existing ops along the way.

Reviewed By: mravishankar

Differential Revision: https://reviews.llvm.org/D110876

3 years ago[NFC][AttributeList] Replace index_begin/end with an iterator
Arthur Eubanks [Thu, 30 Sep 2021 20:57:55 +0000 (13:57 -0700)]
[NFC][AttributeList] Replace index_begin/end with an iterator

We expose the fact that we rely on unsigned wrapping to iterate through
all indexes. This can be confusing. Rather, keeping it as an
implementation detail through an iterator is less confusing and is less
code.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D110885

3 years ago[MachineLoopInfo] Enable machine verification after this pass
Jay Foad [Wed, 29 Sep 2021 12:18:01 +0000 (13:18 +0100)]
[MachineLoopInfo] Enable machine verification after this pass

Enabling this does not show any problems in check-llvm in an
LLVM_ENABLE_EXPENSIVE_CHECKS build.

Differential Revision: https://reviews.llvm.org/D110703

3 years ago[LiveVariables] Skip verification of kills inside bundles
Jay Foad [Wed, 29 Sep 2021 12:09:22 +0000 (13:09 +0100)]
[LiveVariables] Skip verification of kills inside bundles

LiveVariables does not examine the contents of bundles, so
MachineVerifier should not expect it to know about kill flags on
operands of instructions inside a bundle.

With this fix we can enable machine verification after running the
LiveVariables analysis. Doing this does not show any problems in
check-llvm in an LLVM_ENABLE_EXPENSIVE_CHECKS build.

Differential Revision: https://reviews.llvm.org/D110700

3 years ago[UnreachableMachineBlockElim] Enable machine verification after this pass
Jay Foad [Wed, 29 Sep 2021 11:57:03 +0000 (12:57 +0100)]
[UnreachableMachineBlockElim] Enable machine verification after this pass

Enabling this does not show any problems in check-llvm in an
LLVM_ENABLE_EXPENSIVE_CHECKS build.

Differential Revision: https://reviews.llvm.org/D110697

3 years ago[ProcessImplicitDefs] Enable machine verification after this pass
Jay Foad [Wed, 29 Sep 2021 11:44:32 +0000 (12:44 +0100)]
[ProcessImplicitDefs] Enable machine verification after this pass

Enabling this does not show any problems in check-llvm in an
LLVM_ENABLE_EXPENSIVE_CHECKS build.

Differential Revision: https://reviews.llvm.org/D110695

3 years ago[DetectDeadLanes] Enable machine verification after this pass
Jay Foad [Wed, 29 Sep 2021 08:55:15 +0000 (09:55 +0100)]
[DetectDeadLanes] Enable machine verification after this pass

Machine verification after DetectDeadLanes has been disabled since the
pass was first added in D18427, but I guess this was just due to copy-
and-paste. Enabling it does not show any problems in check-llvm in an
LLVM_ENABLE_EXPENSIVE_CHECKS build.

Differential Revision: https://reviews.llvm.org/D110689

3 years ago[libc++] Revert the part of my b82683b that affected <version>.
Arthur O'Dwyer [Fri, 1 Oct 2021 16:59:24 +0000 (12:59 -0400)]
[libc++] Revert the part of my b82683b that affected <version>.

This reverts part of commit b82683b2eb3601f6e8970861b94ad7b37393aa90.
I hadn't intended to remove the `// -*- C++ -*-` comment line
from `libcxx/include/version`, only from the generated tests.
Thanks to Raul Tambre for the catch.

3 years ago[ORC] Remove OrcRPCExecutorProcessControl ad OrcRPCTPCServer.
Lang Hames [Fri, 1 Oct 2021 16:34:16 +0000 (09:34 -0700)]
[ORC] Remove OrcRPCExecutorProcessControl ad OrcRPCTPCServer.

All in-tree tools have moved to SimpleRemoteEPC.

3 years ago[Transforms] Migrate from getNumArgOperands to arg_size (NFC)
Kazu Hirata [Fri, 1 Oct 2021 16:57:40 +0000 (09:57 -0700)]
[Transforms] Migrate from getNumArgOperands to arg_size (NFC)

Note that getNumArgOperands is considered a legacy name.  See
llvm/include/llvm/IR/InstrTypes.h for details.

3 years ago[AIX]implement the --syms and using "symbol index and qualname" for --sym --symbol...
zhijian [Fri, 1 Oct 2021 16:37:51 +0000 (12:37 -0400)]
[AIX]implement the --syms and using "symbol index and qualname" for --sym --symbol--description for llvm-objdump for xcoff

Summary:

for xcoff :

implement the getSymbolFlag and getSymbolType() for option --syms.
llvm-objdump --sym , if the symbol is label, print the containing section for the symbol too.
when using llvm-objdump --sym --symbol--description, print the symbol index and qualname for symbol.
for example:
--symbol-description
00000000000000c0 l .text (csect: (idx: 2) .foov[PR]) (idx: 3) .foov

and without --symbol-description
00000000000000c0 l .text (csect: .foov) .foov

Reviewers: James Henderson,Esme Yi

Differential Revision: https://reviews.llvm.org/D109452

3 years ago[NFC][Codegen][X86] Drop unused check prefixes in newly added tests
Roman Lebedev [Fri, 1 Oct 2021 16:34:57 +0000 (19:34 +0300)]
[NFC][Codegen][X86] Drop unused check prefixes in newly added tests

3 years ago[lldb] [Host] Fix flipped logic in TerminalState::Save()
Michał Górny [Fri, 1 Oct 2021 16:23:25 +0000 (18:23 +0200)]
[lldb] [Host] Fix flipped logic in TerminalState::Save()

3 years ago[libc++] [test] Remove filenames from copyright headers. NFCI.
Arthur O'Dwyer [Fri, 1 Oct 2021 16:13:03 +0000 (12:13 -0400)]
[libc++] [test] Remove filenames from copyright headers. NFCI.

Discussed in D110794.

3 years ago[TrivialDeadness] Update function comment
Anna Thomas [Fri, 1 Oct 2021 15:49:25 +0000 (11:49 -0400)]
[TrivialDeadness] Update function comment

isInstructionTriviallyDead also works for certain side-effecting
instructions.
Update incorrect comment (as suggested in D109917).

3 years ago[OpenMP][host runtime] Introduce kmp_cpuinfo_flags_t to replace integer flags
Peyton, Jonathan L [Mon, 20 Sep 2021 18:24:55 +0000 (13:24 -0500)]
[OpenMP][host runtime] Introduce kmp_cpuinfo_flags_t to replace integer flags

Store CPUID support flags as bits instead of using entire integers.

Differential Revision: https://reviews.llvm.org/D110091

3 years ago[OpenMP][testing] increase threshold for omp_get_wtime test
Peyton, Jonathan L [Fri, 1 Oct 2021 16:06:58 +0000 (11:06 -0500)]
[OpenMP][testing] increase threshold for omp_get_wtime test

3 years ago[libc++] Remove "// -*- C++ -*-" comments from all .cpp files. NFCI.
Arthur O'Dwyer [Thu, 30 Sep 2021 19:43:38 +0000 (15:43 -0400)]
[libc++] Remove "// -*- C++ -*-" comments from all .cpp files. NFCI.

Even if these comments have a benefit in .h files (for editors that
care about language but can't be configured to treat .h as C++ code),
they certainly have no benefit for files with the .cpp extension.

Discussed in D110794.

3 years ago[libc++] [test] Remove "// -*- C++ -*-" comments from generated .cpp files.
Arthur O'Dwyer [Thu, 30 Sep 2021 19:40:45 +0000 (15:40 -0400)]
[libc++] [test] Remove "// -*- C++ -*-" comments from generated .cpp files.

Even if these comments have a benefit in .h files (for editors that
care about language but can't be configured to treat .h as C++ code),
they certainly have no benefit for files with the .cpp extension.

Discussed in D110794.

3 years ago[llvm-jitlink] Fix a FIXME.
Lang Hames [Fri, 1 Oct 2021 00:25:20 +0000 (17:25 -0700)]
[llvm-jitlink] Fix a FIXME.

ORC errors preserve the SymbolStringPool since 6fe2e9a9cc8, so we can stop
bailing out early.

3 years ago[NFC][X86][Codegen] Add test coverage for interleaved i8 load/store stride=3
Roman Lebedev [Fri, 1 Oct 2021 15:47:09 +0000 (18:47 +0300)]
[NFC][X86][Codegen] Add test coverage for interleaved i8 load/store stride=3

3 years ago[NFC][X86][LV] Improve costmodel test coverage for interleaved i8 load/store stride=3
Roman Lebedev [Fri, 1 Oct 2021 15:31:38 +0000 (18:31 +0300)]
[NFC][X86][LV] Improve costmodel test coverage for interleaved i8 load/store stride=3

3 years ago[analyzer] Fix deprecated plistlib functions
Manas [Fri, 1 Oct 2021 14:59:47 +0000 (16:59 +0200)]
[analyzer] Fix deprecated plistlib functions

It replaces the usage of readPlist,writePlist functions with load,dump
in plistlib package.

This fixes deprecation issues when analyzer reports are being generated
outside of docker.

Patch by Manas!

Reviewed By: steakhal

Differential Revision: https://reviews.llvm.org/D107312

3 years ago[gn build] Port 47d6274d4c31
LLVM GN Syncbot [Fri, 1 Oct 2021 14:57:31 +0000 (14:57 +0000)]
[gn build] Port 47d6274d4c31

3 years ago[InstCombine] add tests for icmp of gep; NFC
Sanjay Patel [Fri, 1 Oct 2021 14:37:01 +0000 (10:37 -0400)]
[InstCombine] add tests for icmp of gep; NFC

3 years ago[libunwind] Fix cfi_register for float registers.
Daniel Kiss [Fri, 1 Oct 2021 14:49:37 +0000 (16:49 +0200)]
[libunwind] Fix cfi_register for float registers.

Fixes D110144.
registers.getFloatRegister is not const in ARM therefor can't be called here.

Reviewed By: mstorsjo, #libunwind

Differential Revision: https://reviews.llvm.org/D110731

3 years ago[NFC][AMDGPU] Reduce includes dependencies, part 2
Daniil Fukalov [Tue, 7 Sep 2021 08:21:04 +0000 (11:21 +0300)]
[NFC][AMDGPU] Reduce includes dependencies, part 2

1. Splitted out some parts of R600 target to separate modules/headers.
2. Reduced some include lists in headers.
3. Minor forward declarations, redundant includes and flags in GCNSubtarget
   cleanup.

Reviewed By: foad

Differential Revision: https://reviews.llvm.org/D109351

3 years ago[X86][Costmodel] Load/store i64/f64 Stride=2 VF=16 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:53:39 +0000 (16:53 +0300)]
[X86][Costmodel] Load/store i64/f64 Stride=2 VF=16 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/1WMTojvfW - for intels `Block RThroughput: =16.0`; for ryzens, `Block RThroughput: <=8.0`
So pick cost of `16`.

For store we have:
https://godbolt.org/z/1WMTojvfW - for intels `Block RThroughput: =16.0`; for ryzens, `Block RThroughput: <=16.0`
So pick cost of `16`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110840

3 years ago[X86][Costmodel] Load/store i64/f64 Stride=2 VF=8 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:53:38 +0000 (16:53 +0300)]
[X86][Costmodel] Load/store i64/f64 Stride=2 VF=8 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/PGYbYKPq8 - for intels `Block RThroughput: =8.0`; for ryzens, `Block RThroughput: <=4.0`
So pick cost of `8`.

For store we have:
https://godbolt.org/z/PGYbYKPq8 - for intels `Block RThroughput: =8.0`; for ryzens, `Block RThroughput: <=8.0`
So pick cost of `8`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110838

3 years ago[X86][Costmodel] Load/store i64/f64 Stride=2 VF=4 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:53:32 +0000 (16:53 +0300)]
[X86][Costmodel] Load/store i64/f64 Stride=2 VF=4 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/j5co1qWEW - for intels `Block RThroughput: =4.0`; for ryzens, `Block RThroughput: <=2.0`
So pick cost of `4`.

For store we have:
https://godbolt.org/z/j5co1qWEW - for intels `Block RThroughput: =4.0`; for ryzens, `Block RThroughput: <=4.0`
So pick cost of `4`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110837

3 years ago[X86][Costmodel] Load/store i64/f64 Stride=2 VF=2 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:53:28 +0000 (16:53 +0300)]
[X86][Costmodel] Load/store i64/f64 Stride=2 VF=2 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/8a1cfGeMn - for intels `Block RThroughput: =2.0`; for ryzens, `Block RThroughput: =1.0`
So pick cost of `2`.

For store we have:
https://godbolt.org/z/jMdcM47bx - for intels `Block RThroughput: =2.0`; for ryzens, `Block RThroughput: <=2.0`
So pick cost of `2`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110835

3 years ago[X86][Costmodel] Load/store i32/f32 Stride=2 VF=32 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:52:51 +0000 (16:52 +0300)]
[X86][Costmodel] Load/store i32/f32 Stride=2 VF=32 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

Here for `store` pattern we are starting to have spilling,
so accurate modelling may be problematic,
although if i drop the spilling, the measurements don't change.

For load we have:
https://godbolt.org/z/1oTTnncbx - for intels `Block RThroughput: =16.0`; for ryzens, `Block RThroughput: <=8.0`
So pick cost of `16`.

For store we have:
https://godbolt.org/z/1oTTnncbx - for intels `Block RThroughput: =16.0`; for ryzens, `Block RThroughput: =8.0`
So pick cost of `16`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110761

3 years ago[X86][Costmodel] Load/store i32/f32 Stride=2 VF=16 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:52:51 +0000 (16:52 +0300)]
[X86][Costmodel] Load/store i32/f32 Stride=2 VF=16 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/M9eev3xe8 - for intels `Block RThroughput: =8.0`; for ryzens, `Block RThroughput: <=4.0`
So pick cost of `8`.

For store we have:
https://godbolt.org/z/M9eev3xe8 - for intels `Block RThroughput: =8.0`; for ryzens, `Block RThroughput: =4.0`
So pick cost of `8`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110756

3 years ago[X86][Costmodel] Load/store i32/f32 Stride=2 VF=8 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:52:46 +0000 (16:52 +0300)]
[X86][Costmodel] Load/store i32/f32 Stride=2 VF=8 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/n8aMKeo4E - for intels `Block RThroughput: =4.0`; for ryzens, `Block RThroughput: <=2.0`
So pick cost of `4`.

For store we have:
https://godbolt.org/z/n8aMKeo4E - for intels `Block RThroughput: =4.0`; for ryzens, `Block RThroughput: =2.0`
So pick cost of `4`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110755

3 years ago[X86][Costmodel] Load/store i32/f32 Stride=2 VF=4 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:52:41 +0000 (16:52 +0300)]
[X86][Costmodel] Load/store i32/f32 Stride=2 VF=4 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/EM5Ean7bd - for intels `Block RThroughput: =2.0`; for ryzens, `Block RThroughput: =1.0`
So pick cost of `2`.

For store we have:
https://godbolt.org/z/EM5Ean7bd - for intels `Block RThroughput: =2.0`; for ryzens, `Block RThroughput: <=2.0`
So pick cost of `2`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110754

3 years ago[X86][Costmodel] Load/store i32/f32 Stride=2 VF=2 interleaving costs
Roman Lebedev [Fri, 1 Oct 2021 13:52:36 +0000 (16:52 +0300)]
[X86][Costmodel] Load/store i32/f32 Stride=2 VF=2 interleaving costs

The only sched models that for cpu's that support avx2
but not avx512 are: haswell, broadwell, skylake, zen1-3

For load we have:
https://godbolt.org/z/4rY96hnGT - for intels `Block RThroughput: =2.0`; for ryzens, `Block RThroughput: =1.0`
So pick cost of `2`.

For store we have:
https://godbolt.org/z/vbo37Y3r9 - for intels `Block RThroughput: =1.0`; for ryzens, `Block RThroughput: =0.5`
So pick cost of `1`.

I'm directly using the shuffling asm the llc produced,
without any manual fixups that may be needed
to ensure sequential execution.

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D110753

3 years ago[gn build] Port fb99424a6f65
LLVM GN Syncbot [Fri, 1 Oct 2021 14:29:37 +0000 (14:29 +0000)]
[gn build] Port fb99424a6f65

3 years ago[SystemZ][z/OS] Introduce initial support for GOFF asm parser
Anirudh Prasad [Fri, 1 Oct 2021 14:29:02 +0000 (10:29 -0400)]
[SystemZ][z/OS] Introduce initial support for GOFF asm parser

- Introduce a skeleton outline for the GOFFAsmParser
- Before instantiating AsmParser/HLASMAsmParser, target specific asm parsers are attempted to be initialized first before proceeding. If it doesn't exist for a particular file type, we report a fatal error.
- This patch allows to properly instantiate the HLASMAsmParser on z/OS, and ensures we can write lit tests and unit tests which will involve the instantiation of asm parsers, without an assert / fatal error.

Reviewed By: uweigand, Kai

Differential Revision: https://reviews.llvm.org/D110730

3 years ago[fir] Remove obsolete fir.negf and fir.modf ops
Eric Schweitz [Fri, 1 Oct 2021 14:10:24 +0000 (16:10 +0200)]
[fir] Remove obsolete fir.negf and fir.modf ops

fir.negf op is replaced by mlir.negf and
fir.modf is just deleted.

Reviewed By: kiranchandramohan

Differential Revision: https://reviews.llvm.org/D110932

Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Valentin Clement <clementval@gmail.com>
3 years ago[libomptarget][amdgpu] Refactor memory pool collection
Jon Chesterfield [Fri, 1 Oct 2021 13:38:36 +0000 (14:38 +0100)]
[libomptarget][amdgpu] Refactor memory pool collection

3 years ago[mlir][linalg] Retire PoolingMaxOp/PoolingMinOp/PoolingSumOp.
Tobias Gysi [Fri, 1 Oct 2021 13:29:35 +0000 (13:29 +0000)]
[mlir][linalg] Retire PoolingMaxOp/PoolingMinOp/PoolingSumOp.

The pooling ops are among the last remaining hard coded Linalg operations that have no region attached. They got obsolete due to the OpDSL pooling operations. Removing them allows us to delete specialized code and tests that are not needed for the OpDSL counterparts that rely on the standard code paths.

Reviewed By: nicolasvasilache

Differential Revision: https://reviews.llvm.org/D110909

3 years ago[lldb] Simplify TestCompletion.py
Pavel Labath [Fri, 1 Oct 2021 13:47:22 +0000 (15:47 +0200)]
[lldb] Simplify TestCompletion.py

3 years ago[RISCV][NFC] Reformat a line of frame lowering code
Fraser Cormack [Fri, 1 Oct 2021 13:23:54 +0000 (14:23 +0100)]
[RISCV][NFC] Reformat a line of frame lowering code

3 years ago[clang] Try to unbreak crash-report.cpp on PS4 bot after 8dfbe9b0a
Nico Weber [Fri, 1 Oct 2021 13:31:10 +0000 (09:31 -0400)]
[clang] Try to unbreak crash-report.cpp on PS4 bot after 8dfbe9b0a

Looks like exceptions are off-by-default with the PS4 triple.
Since adding -fexceptions defeats the purpose of the test change
in 8dfbe9b0a, pass an explicit triple instead.

3 years ago[PowerPC] Optimal sequence for doubleword vec_all_{eq|ne} on Power7
Nemanja Ivanovic [Fri, 1 Oct 2021 13:05:15 +0000 (08:05 -0500)]
[PowerPC] Optimal sequence for doubleword vec_all_{eq|ne} on Power7

These builtins produce inefficient code for CPU's prior to Power8
due to vcmpequd being unavailable. The predicate forms can actually
leverage the available vcmpequw along with xxlxor to produce a better
sequence.

3 years ago[lldb] [test] Delay pty/tty imports to fix Windows builds
Michał Górny [Fri, 1 Oct 2021 13:24:49 +0000 (15:24 +0200)]
[lldb] [test] Delay pty/tty imports to fix Windows builds

Delay pty/tty module imports until they are actually used, in order
to prevent their import failures on Windows.

3 years agoFix ambiguous overload build failure
Marcelo Juchem [Fri, 1 Oct 2021 07:42:23 +0000 (08:42 +0100)]
Fix ambiguous overload build failure

LLVM (llvmorg-14-init) under Debian sid using latest gcc (Debian
10.3.0-9) 10.3.0 fails due to ambiguous overload on operators == and !=:

/root/src/llvm/src/llvm/tools/obj2yaml/elf2yaml.cpp:212:22:
error: ambiguous overload for 'operator!='
(operand types are 'llvm::ELFYAML::ELF_SHF' and 'int')

/root/src/llvm/src/llvm/tools/obj2yaml/elf2yaml.cpp:204:32:
error: ambiguous overload for 'operator!='
(operand types are 'const llvm::yaml::Hex64' and 'int')

/root/src/llvm/src/llvm/lib/CodeGen/LiveDebugValues/VarLocBasedImpl.cpp:629:35:
error: ambiguous overload for 'operator=='
(operand types are 'const uint64_t' {aka 'const long unsigned int'} and
'llvm::Register')

Reviewed by: StephenTozer, jmorse, Higuoxing

Differential Revision: https://reviews.llvm.org/D109534

3 years ago[fir][NFC] Remove explicit num of inlined element for SmallVectors
Valentin Clement [Fri, 1 Oct 2021 12:41:25 +0000 (14:41 +0200)]
[fir][NFC] Remove explicit num of inlined element for SmallVectors

Remove explicit number of inlined elements for SmallVector.

This patch is part of the upstreaming effort from fir-dev branch.

Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Reviewed By: awarzynski

Differential Revision: https://reviews.llvm.org/D110912

3 years ago[fir] Add fir.char_convert op
Eric Schweitz [Fri, 1 Oct 2021 12:39:03 +0000 (14:39 +0200)]
[fir] Add fir.char_convert op

Add the fir-char_convert op.

This patch is part of the upstreaming effort from fir-dev branch.

Reviewed By: kiranchandramohan

Differential Revision: https://reviews.llvm.org/D110818

Co-authored-by: Valentin Clement <clementval@gmail.com>
3 years ago[lldb] Add a gdb_remote_client test for connecting to pty
Michał Górny [Thu, 30 Sep 2021 20:30:30 +0000 (22:30 +0200)]
[lldb] Add a gdb_remote_client test for connecting to pty

Add a minimal mock server utilizing a pty, and add a client test
connecting to that server.

Differential Revision: https://reviews.llvm.org/D110878

3 years ago[MLIR][GPU] Add GPU launch op support for dynamic shared memory
Uday Bondhugula [Tue, 14 Sep 2021 08:43:21 +0000 (14:13 +0530)]
[MLIR][GPU] Add GPU launch op support for dynamic shared memory

Add support for dynamic shared memory for GPU launch ops: add an
optional operand to gpu.launch and gpu.launch_func ops to specify the
amount of "dynamic" shared memory to use. Update lowerings to connect
this operand to the GPU runtime.

Differential Revision: https://reviews.llvm.org/D110800

3 years ago[libFuzzer] Fix two typos
Hans Wennborg [Fri, 1 Oct 2021 08:59:43 +0000 (10:59 +0200)]
[libFuzzer] Fix two typos

3 years ago[mlir] Enable loop peeling for "reduction" dimensions of tiled_loop.
Alexander Belyaev [Fri, 1 Oct 2021 11:02:42 +0000 (13:02 +0200)]
[mlir] Enable loop peeling for "reduction" dimensions of tiled_loop.

Differential Revision: https://reviews.llvm.org/D110919

3 years ago[RISCV][NFC] Add closing parentheses to frame layout comments
Fraser Cormack [Fri, 1 Oct 2021 10:57:55 +0000 (11:57 +0100)]
[RISCV][NFC] Add closing parentheses to frame layout comments

3 years ago[lldb] [Host] Refactor TerminalState
Michał Górny [Wed, 29 Sep 2021 15:51:51 +0000 (17:51 +0200)]
[lldb] [Host] Refactor TerminalState

Refactor TerminalState to make the code simpler.  Move 'struct termios'
to a PImpl-style subclass.  Add an RAII interface to automatically store
and restore the state.

Differential revision: https://reviews.llvm.org/D110721

3 years ago[clangd] Handle members of anon structs in SelectionTree
Kadir Cetinkaya [Thu, 30 Sep 2021 13:25:42 +0000 (15:25 +0200)]
[clangd] Handle members of anon structs in SelectionTree

References to fields inside anon structs contain an implicit children
for the container, which has the same SourceLocation with the field.
This was resulting in SelectionTree always picking the anon-struct rather than
the field as the selection.

This patch prevents that by claiming the range for the field early.

https://github.com/clangd/clangd/issues/877.

Differential Revision: https://reviews.llvm.org/D110825

3 years ago[BasicAA] Add test showing 32 bit overflow issue for GEPs.
Florian Hahn [Fri, 1 Oct 2021 10:25:16 +0000 (11:25 +0100)]
[BasicAA] Add test showing 32 bit overflow issue for GEPs.

This patch additional tests with i64 GEP indices for 32 bit pointers.
@mustalias_overflow_in_32_bit_add_mul_gep highlights a case where
BasicAA currently incorrectly determines noalias.

Modeled in Alive2 for 32 bit pointers: https://alive2.llvm.org/ce/z/HHjQgb
Modeled in Alive2 for 64 bit pointers: https://alive2.llvm.org/ce/z/DoWK2c

3 years ago[AArch64][SVE] Replace fmul, fadd and fsub LLVM IR instrinsics with LLVM IR binary ops
Matthew Devereau [Wed, 1 Sep 2021 15:41:42 +0000 (16:41 +0100)]
[AArch64][SVE] Replace fmul, fadd and fsub LLVM IR instrinsics with LLVM IR binary ops

Replacing fmul and fadd instrinsics with their binary ops results
more succinct AArch64 SVE output, e.g.:

4:   65428041  fmul z1.h, p0/m, z1.h, z2.h
8:   65408020  fadd z0.h, p0/m, z0.h, z1.h
->
4:   65620020   fmla    z0.h, p0/m, z1.h, z2.h

3 years ago[SLPVectorizer] Fix crash in isShuffle with scalable vectors
Kerry McLaughlin [Fri, 1 Oct 2021 08:43:27 +0000 (09:43 +0100)]
[SLPVectorizer] Fix crash in isShuffle with scalable vectors

D104809 changed `buildTree_rec` to check for extract element instructions
with scalable types. However, if the extract is extended or truncated,
these changes do not apply and we assert later on in isShuffle(), which
attempts to cast the type of the extract to FixedVectorType.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D110640

3 years ago[llvm-reduce] Skip updating calls where OldF isn't the called fn.
Florian Hahn [Fri, 1 Oct 2021 08:56:08 +0000 (09:56 +0100)]
[llvm-reduce] Skip updating calls where OldF isn't the called fn.

When replacing function calls, skip call instructions where the old
function is not the called function, but e.g. the old function is passed
as an argument.

This fixes a crash due to trying to construct invalid IR for the test
case.

Reviewed By: aeubanks

Differential Revision: https://reviews.llvm.org/D109759

3 years agoRevert "[libcxx][test] Use python specified by build rather than system default python"
David Spickett [Fri, 1 Oct 2021 09:44:44 +0000 (09:44 +0000)]
Revert "[libcxx][test] Use python specified by build rather than system default python"

This reverts commit 9f641c96cb15c9752c976bff286bb57adf86acab.

The "python" command in gdb uses the python gdb is linked to,
not what "python" would give you if you used it directly in the shell.

3 years agoRevert "[libcxx] Run u16string tests for gdb pretty printers"
David Spickett [Fri, 1 Oct 2021 09:43:16 +0000 (09:43 +0000)]
Revert "[libcxx] Run u16string tests for gdb pretty printers"

This reverts commit e9564c3698edffc64439a8f957c7c28b19214613
due to a report of these tests failing.

3 years agoRevert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction...
Krasimir Georgiev [Fri, 1 Oct 2021 09:37:40 +0000 (11:37 +0200)]
Revert "[LoopVectorize] Permit vectorisation of more select(cmp(), X, Y) reduction patterns"

It appears to cause stage2 clang build failures, e.g.,
https://lab.llvm.org/buildbot/#/builders/74/builds/7145.

This reverts commit 1fb37334bdb3cdb028977382fbd84cebde64ebb2.

3 years ago[clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.
Balázs Kéri [Fri, 1 Oct 2021 09:04:54 +0000 (11:04 +0200)]
[clang][ASTImporter] Import ConstructorUsingShadowDecl correctly.

Fix import of ConstructorUsingShadowDecl and add tests.

Reviewed By: martong

Differential Revision: https://reviews.llvm.org/D110398

3 years ago[flang][driver] Error if uuidgen is not installed
David Spickett [Wed, 29 Sep 2021 11:30:55 +0000 (12:30 +0100)]
[flang][driver] Error if uuidgen is not installed

Ubuntu Bionic installs it by default, Focal does not.

Differential Revision: https://reviews.llvm.org/D110694