Alexander Galazin [Mon, 4 Feb 2019 12:09:04 +0000 (13:09 +0100)]
Merge pull request #136 from werman/vulkan/VK_EXT_conditional_rendering
Add tests of VK_EXT_conditional_rendering for secondary command buffer
Alexander Galazin [Wed, 30 Jan 2019 13:32:36 +0000 (14:32 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I4dc98f1a1a40a191c9adc8086d3c842444697a93
Alexander Galazin [Wed, 30 Jan 2019 12:48:36 +0000 (13:48 +0100)]
Fix mustpasses
Components: Vulkan
Change-Id: Ic0effbe836c0501255e3958e0224f55d64fe5d3f
Alexander Galazin [Wed, 30 Jan 2019 11:32:55 +0000 (12:32 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I6077e7955922b190bb161f7ea55b70622de9cc95
Alexander Galazin [Wed, 30 Jan 2019 11:32:51 +0000 (12:32 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ibe8e4681ee550224f9db8109857812113c2bc503
Alexander Galazin [Wed, 30 Jan 2019 11:32:48 +0000 (12:32 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I15606e0ae4cebef241218414134324f043f06633
Danylo Piliaiev [Wed, 12 Dec 2018 16:21:07 +0000 (18:21 +0200)]
Add tests of VK_EXT_conditional_rendering for secondary command buffer
Tests which previosly were under "secondary_buffer" category are now
under "inherited" category since begin/end conditional rendering is
still in primary command buffer.
New tests for conditional rendering in secondary command buffer took
these tests' names.
Components: Vulkan
Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com>
Ilkka Saarelainen [Sun, 13 Jan 2019 19:58:43 +0000 (21:58 +0200)]
Add missing PointSize to some geometry tests
Validation layers catch validation errors in YCbCr and glsl tests
caused by the missing gl_PointSize in the geometry shader code.
This adds the missing gl_PointSize to get rid of the validation
errors.
Components: Vulkan
Affects:
dEQP-VK.glsl.*geometry
dEQP-VK.ycbcr.*geometry*
VK-GL-CTS issue: 1502
Change-Id: I0f306d9c4c244b275f1e437869e3a6af5169f217
Jari Komppa [Fri, 7 Dec 2018 12:05:32 +0000 (14:05 +0200)]
Added variants of PointCoord test with uniforms
Adds variants of the PointCoord test that include an uniform that
changes the output.
New tests:
dEQP-VK.glsl.builtin_var.simple.pointcoord_uniform_frag
dEQP-VK.glsl.builtin_var.simple.pointcoord_uniform_vert
Components: Vulkan
VK-GL-CTS issue: 1365
Change-Id: If2e46051ae67aefa558886b0fffcbf5916213f28
Graeme Leese [Thu, 10 Jan 2019 11:20:02 +0000 (11:20 +0000)]
Fix validation errors in subgroups tests
Some subgroups tests were attempting to create a descriptor pool of size
0, which is invalid. Instead, skip the whole construction of descriptor
sets since they aren't needed.
Components: Vulkan
Affects: dEQP-VK.subgroups.*.graphics.*
Change-Id: I5abedcc2360a0336c521aea855a9725b127c9a0f
Toni Merilehti [Mon, 14 Jan 2019 12:42:01 +0000 (14:42 +0200)]
Extend api.version_check.entry_points test
This adds a check that verifies that vkGet*ProcAddr returns valid
function pointers for extension functions. The tested extensions are
multi-author extensions that are supported by the device.
Also, the gen_framework.py script is updated to generate
a vkExtensionFunctions.inl file that contains functions of instance
and device extensions.
Affects:
dEQP-VK.api.version_check.entry_points
Components: Vulkan
VK-GL-CTS issue: 1374
Change-Id: Ia66319515300474f5dcbcab6f090ec15a823ca7b
Dae Kim [Mon, 28 Jan 2019 11:11:09 +0000 (11:11 +0000)]
Added missing writes to gl_Position in vertex shaders
Some vertex shaders are not writing a value to gl_Position, which can cause
unintended run-time behavior (including termination or system instability).
Components: Vulkan
VK-GL-CTS issue: 1579
Affects:
dEQP-VK.binding_model.descriptorset_random.*
dEQP-VK.memory_model.message_passing.*
Change-Id: I3f2f21f23508bda3062a4480e9fac78748bab32b
Alex Walters [Fri, 25 Jan 2019 18:10:08 +0000 (18:10 +0000)]
Depth attachment not stored in late_fragment_tests
The stencil was stored, but the depth attachment was set to DONT_CARE.
This allows implementations to optimise out the depth store at the end
of the renderpass, when the test is expecting to readback valid depth
values for reference comparison.
Affects:
dEQP-VK.renderpass.suballocation.subpass_dependencies.late_fragment_tests*
Components: Vulkan
VK-GL-CTS issue: 1578
Change-Id: Ie3bb52fa63ff379d70759190460ce8662c4c09ad
Graeme Leese [Wed, 9 Jan 2019 17:54:49 +0000 (17:54 +0000)]
Change vkrunner tests to use Archive
Loading the files directly doesn't work on Android.
Components: Vulkan
Affects:
dEQP-VK.vkrunner.*
dEQP-VK.graphicsfuzz.*
dEQP-VK.draw.*
dEQP-VK.dynamic_state.*
VK-GL-CTS issue: 1574
Change-Id: I2efb547f74d44486aee093837c973425606fe4da
Alex Walters [Fri, 14 Sep 2018 10:44:55 +0000 (11:44 +0100)]
Add ASTC LDR error colour quality warning
Some hardware can output the HDR error colour (black) instead of the
LDR error colour (magenta). Valid compression blocks are rendered
correctly.
This change adds a second comparison mechanism if the initial *fast*
deMemCmp fails; the texture values are compared allowing for any value
matching an error colour to compare against the other error colour.
If such a match is detected the test will output a QualityWarning
instead of a Pass.
If the two compared values don't match, but are not both error colours
the test result is still a Fail.
Affects:
dEQP-VK.image.texel_view_compatible*astc*
Components: Vulkan
VK-GL-CTS issue: 1231
Change-Id: Ie14913de0f2f3cf7fed90c275e48c67181c1e7ff
(cherry picked from commit
b038d43aa868be1e6d4471c6977984151ada3af5)
Mohd Faisal [Fri, 19 Oct 2018 09:35:36 +0000 (10:35 +0100)]
Fix the device_group test failure by allowing same number of tries to
create object as device test.
Components: Vulkan
Affects: dEQP-VK.api.object_management.alloc_callback_fail.device_group
VK-GL-CTS Issue: 1431
Change-Id: I099a05f3109c1997cad323a0577f66c95755b151
(cherry picked from commit
4c98da04296ed97e73fecdd2e5b80478ba7f60af)
Peter Quayle [Tue, 11 Dec 2018 18:02:26 +0000 (18:02 +0000)]
Reduce devices created in device_group tests
The device_group tests could sometimes hit timeouts on
slower CPUs. This change reduces the number of objects
created in these tests to match the reduced number used
in the device and instance tests.
Affects:
dEQP-VK.api.object_management.
multithreaded_per_thread_resources.device_group
dEQP-VK.api.object_management.
multithreaded_shared_resources.device_group
Components: Vulkan
VK-GL-CTS issue: 1512
Change-Id: Icb68643ff530a8b1a1a7daa9fc93d8db8bc5faf9
(cherry picked from commit
9134406c47a0f345ea9e3c67dc7b99c7947b2436)
Alexander Galazin [Thu, 24 Jan 2019 21:13:10 +0000 (22:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I557cfbf99b4603ec546a3443bd2f5334475980dc
Alexander Galazin [Thu, 24 Jan 2019 21:13:07 +0000 (22:13 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I00246ec185fe843f4ca638ca0a4bfa34b8598cde
Yu-Jun Li [Mon, 7 Jan 2019 18:48:18 +0000 (10:48 -0800)]
Fixes multiview query tests
Queries need to be reset prior to use
Components: Vulkan
VK-GL-CTS issue: 1575
Affects:
dEQP-VK.multiview.queries.*
Change-Id: Icf0f712a3391784ee47c00de833f8417bb8337c3
(cherry picked from commit
bd913ffd046955e976337ab6fb1e93520b37c375)
Yu-Jun Li [Mon, 7 Jan 2019 18:48:18 +0000 (10:48 -0800)]
Fixes multiview query tests
Queries need to be reset prior to use
Components: Vulkan
VK-GL-CTS issue: 1575
Affects:
dEQP-VK.multiview.queries.*
Change-Id: Icf0f712a3391784ee47c00de833f8417bb8337c3
Stephen Clarke [Tue, 15 Jan 2019 11:32:49 +0000 (11:32 +0000)]
Fix dependency on unspecified rounding mode
These tests perform an addition whose Rounding mode is unspecified
according to the specification. This test is not testing addition,
it is testing that the input values are read correctly, so modify
the input values such that they do not require rounding.
Affected tests:
* dEQP-VK.spirv_assembly.instruction.compute.indexing.input.non16basealignment*
Components: Vulkan
VK-GL-CTS issue: 1473
Change-Id: Ifab284d95cc2e36c3a551c30d57deeca7bd8d4b2
Alexander Galazin [Mon, 21 Jan 2019 20:16:15 +0000 (21:16 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I90db06a96453f6f1ba2095858d490715b12b3b1d
Alexander Galazin [Mon, 21 Jan 2019 20:16:12 +0000 (21:16 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ia670fa92c0d87e0c01f07e156a00d19533faf9f0
Alexander Galazin [Mon, 21 Jan 2019 20:16:08 +0000 (21:16 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: Ic7e43b929357fc3e076de1105d7e24fb3b92b946
Alexander Galazin [Mon, 21 Jan 2019 18:21:53 +0000 (19:21 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: I79cdbe3b49745c53437cd85f3022bf9c6123211d
Chris Forbes [Fri, 18 Jan 2019 17:44:03 +0000 (09:44 -0800)]
Update vkrunner version
Includes fixes for missing synchronization.
VK-GL-CTS Issue: 1567
Change-Id: I21e8cf172e7bd45d54c0b8e0ef9e2776a85e691c
Paul Thomson [Wed, 2 Jan 2019 12:09:53 +0000 (12:09 +0000)]
Add const matrix multiply test
Test case ported from an ANGLE regression test.
New tests:
dEQP-GLES3.functional.shaders.constants.const_mat_multiply*
Components: AOSP
Chromium issue: 912508
Change-Id: I5ecc13af8f8e7a5d5a50126ea609e8ad6fab185b
Jari Komppa [Mon, 7 Jan 2019 12:31:34 +0000 (14:31 +0200)]
Add UTF8 abuse tests for extension and layer names
These tests abuse the layer and extension name fields of the instance
creation APIs. The APIs are defined as taking in UTF-8 strings but
all actual strings so far are ASCII, so it is possible that these
inputs are unexpected and may lead to crashes.
New tests:
dEQP-VK.api.device_init.create_instance_extension_name_abuse
dEQP-VK.api.device_init.create_instance_layer_name_abuse
Components: Vulkan
VK-GL-CTS issue: 1510
Change-Id: Iaf370dd737ca8ce8c4fda849a95b951fa12d2ab5
Paul Thomson [Fri, 21 Dec 2018 11:42:32 +0000 (11:42 +0000)]
Add graphicsfuzz vkrunner tests
Add a new category for simplified test cases found by GraphicsFuzz that
trigger bugs in widely-used shader compilers so that the bugs will be
fixed and will stay fixed. The test cases do not try to get coverage of
specific features; the tests usually trigger very specific and subtle
bugs and may look strange without this context. Nevertheless, the tests
should clearly pass.
Add one test case. Other test cases to follow.
Components: Vulkan
New Tests: dEQP-VK.graphicsfuzz.pow-vec4
Change-Id: I518cc24b5649e662ee383b36dbe05b55153325c4
Leif-Julian Ovrelid [Thu, 8 Nov 2018 09:16:10 +0000 (10:16 +0100)]
Fix missing self dependency in renderpass tests
The dEQP-VK.renderpass.suballocation.formats and
dEQP-VK.renderpass.dedicated_allocation.formats tests were missing self
dependencies in some cases where they read then write one attachment
in one subpass. In cases with overlapping rendering this would give a
read-write-then-read-write situation, which neads a self dependency to
work reliably. Some of the tests were missing the self dependency, some
of them had the color attachment bits set when depending on depth, and
one case had a self dependency where it should not.
This patch adds a self dependency to two test cases that need it,
removes self dependency from a case that does not need it, and fixes
the depth tests to have the correct bits set.
Affects:
dEQP-VK.renderpass.suballocation.formats.*.input.*
dEQP-VK.renderpass.dedicated_allocation.formats.*.input.*
dEQP-VK.renderpass2.suballocation.formats.*.input.*
dEQP-VK.renderpass2.dedicated_allocation.formats.*.input.*
Components: Vulkan
VK-GL-CTS Issue: 1454
Change-Id: I4a9bec3ef6b088ab3a50d7f658867076f68788b9
(cherry picked from commit
f659f8c9ad39c179a79a92ee3b66cb83e1dd52ed)
Alexander Galazin [Fri, 18 Jan 2019 12:19:35 +0000 (13:19 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I3eef5f481cfa4bf5c8bcb0feb69733d492de95d3
Alexander Galazin [Fri, 18 Jan 2019 10:54:53 +0000 (11:54 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Idec176bfe0b3a95eb0c557f32015968cbeb914d7
Alexander Galazin [Fri, 18 Jan 2019 09:47:28 +0000 (10:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I2b85e569622052ec742b1272ac367fc1dccf1733
Alexander Galazin [Fri, 18 Jan 2019 09:47:25 +0000 (10:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Iaf773ccd948a5707df4d2ae4628a702e739bd8df
Alexander Galazin [Fri, 18 Jan 2019 09:47:22 +0000 (10:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.0.2 into vk-gl-cts/vulkan-cts-1.1.0
Change-Id: Idf9225adfcbc231e544516558bd6d794dce40b26
Stephen Clarke [Mon, 14 Jan 2019 16:31:18 +0000 (16:31 +0000)]
Fix NaN handling in funord tests
Support of NaNs is optional according to the specification, but
these tests were assuming that NaNs are always supported.
Modify these tests to skip check if an operand is a NaN.
Add infrastructure for a new set of tests opfunord_nan*, which
use VK_KHR_shader_float_controls to check whether NaNs are supported.
But since this is a bugfix, do not actually add the new tests.
Affected tests:
* dEQP-VK.spirv_assembly.instruction.compute.opfunord*
Components: Vulkan
VK-GL-CTS issue: 1551
Change-Id: Ic60f13377ff9d2bdc2e10047aab8be0617904670
Piotr Byszewski [Thu, 17 Jan 2019 12:37:07 +0000 (13:37 +0100)]
Fix validation failure in float_controls
Half of float_controls tests read operation arguments from
SSBO (other half generates them in the code). Whent vertex
stage is tested this SSBO must be decorated as NonWritable.
This change resolves this issue by applying NonWritable
decoration to input SSBO for all tested stages.
Operation output is always saved in fragment stage and to
separate SSBO.
Components: Vulkan
VK-GL-CTS issue: 1543
Affects:
dEQP-VK.spirv_assembly.instruction.compute.float_controls.*
dEQP-VK.spirv_assembly.instruction.graphics.float_controls.*
Change-Id: Iaed891d7b45b2a5f02ce1443dc13a40e24fa2086
Alexander Galazin [Thu, 17 Jan 2019 11:51:30 +0000 (12:51 +0100)]
Update Vulkan CTS Readme
Clarify API level requirements for implementations with
VK_ANDROID_external_memory_android_hardware_buffer support
Components: Vulkan
Change-Id: I8536595678a8d4daff9e16ed3a9e9e25594e372e
Matthew Netsch [Wed, 16 Jan 2019 19:36:30 +0000 (14:36 -0500)]
Fixes ycbcr image properties requirement
Mipmaps/Arrays are optional for ycbcr images
Components: Vulkan
VK-GL-CTS issue: 1506
Affects:
dEQP-VK.api.info.image_format_properties.*
Change-Id: I795ec1c8b3e44a460ddd0c7c2fe0fe1731794cab
(cherry picked from commit
845394de5b43c71adddc72e7563b50c65e852b27)
Matthew Netsch [Wed, 16 Jan 2019 19:36:30 +0000 (14:36 -0500)]
Fixes ycbcr image properties requirement
Mipmaps/Arrays are optional for ycbcr images
Components: Vulkan
VK-GL-CTS issue: 1506
Affects:
dEQP-VK.api.info.image_format_properties.*
Change-Id: I795ec1c8b3e44a460ddd0c7c2fe0fe1731794cab
Alexander Galazin [Thu, 17 Jan 2019 11:56:27 +0000 (12:56 +0100)]
Fix image type in Uniform texel buffer tests
Form the issue:
The Shader Resource and Storage Class Correspondence table
in the Descriptor Set Interface section of the Vulkan 1.1
specification clearly states that a descriptor resource
which is a uniform texel buffer should correspond to
an OpTypeImage(Dim=Buffer,Sampled=1) type.
The current tests in the binding_model category
generate OpTypeSampledImage for uniform texel buffer
resources instead, which I believe is incorrect.
This can be fixed by changing the GLSL declaration from
samplerBuffer to textureBuffer
Components: Vulkan
VK-GL-CTS public issue: 139
Affects:
dEQP-VK.binding_model.*uniform_texel_buffer.*
Change-Id: Ie1beb05cac69a6cf1220bbd47c2d7876eed7ff26
Martin Freebody [Mon, 14 Jan 2019 13:34:40 +0000 (13:34 +0000)]
Protected Memory Fixes - Barrier Layouts & Flags
This change removes errors reported by core validation layer.
Affects: dEQP-VK.protected_memory.*
Components: Vulkan
Change-Id: Ic258ba2af077b2dc119db0d177613558464e0c9a
Alexander Galazin [Thu, 17 Jan 2019 12:07:33 +0000 (13:07 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I46729dcd60ae4c533dabacb17fbeecc92f709bb0
Alexander Galazin [Thu, 17 Jan 2019 11:24:09 +0000 (12:24 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ibfebb592de5aff940b3167f5475139cec99ef6f5
Jeff Bolz [Wed, 12 Dec 2018 19:46:54 +0000 (13:46 -0600)]
Update VK_KHR_vulkan_memory_model to spec version 3
Components: Vulkan
Affects: dEQP-VK.memory_model.*
Change-Id: I3ba8a275092f0a2fcfef02cdabf2ab51750f74f5
Tom Cooper [Mon, 14 Jan 2019 14:02:03 +0000 (14:02 +0000)]
Fixes depth load_op in multiview tests
Depth load_op was set to dont care before drawing with depth test.
Components: Vulkan
VK-GL-CTS issue: 1557
Affects:
dEQP-VK.multiview*.depth.*
Change-Id: Ia853a84fa7c96b641a2dd91075d015a90a372d35
Steve Hill [Fri, 11 Jan 2019 10:12:46 +0000 (10:12 +0000)]
Truncate random coordinates in late fragment tests
The late-fragment tests generate random triangles. Unfortunately,
the reference rasteriser does not respect the sub-pixel precision
of the physical device (it assumes 8 bits) which means that on
some platforms the reference rasterisation does not agree with
implementation.
This patch rounds the random coordinates to the reported
sub-pixel precision. It was decided that in the short term this
was a less invasive change than modifying the reference rasteriser.
Affects: dEQP-VK.renderpass*.subpass_dependencies.late_fragment_tests.*
Components: Vulkan
VK-GL-CTS issue: 1549
Change-Id: I50f20284d9d2cb22e73564d6f71c0a3342547b68
Graeme Leese [Tue, 8 Jan 2019 17:16:30 +0000 (17:16 +0000)]
Reenable coverage of opaque type indexing
These tests appear to have working code for testing various scenarios
that was disabled. This adds coverage of 1D samplers, non-constant SSBO
indexing, and SSBO indexing in tessellation and geometry stages.
Components: Vulkan
VK-GL-CTS Issue: 1544
New Tests: dEQP-VK.glsl.opaque_type_indexing.sampler.*.{i,u,}sampler1d
dEQP-VK.glsl.opaque_type_indexing.sampler.*.{i,u,}sampler1darray
dEQP-VK.glsl.opaque_type_indexing.sampler.*.sampler1dshadow
dEQP-VK.glsl.opaque_type_indexing.sampler.*.sampler1darrayshadow
dEQP-VK.glsl.opaque_type_indexing.ssbo.uniform_*
dEQP-VK.glsl.opaque_type_indexing.ssbo.dynamically_uniform_*
dEQP-VK.glsl.opaque_type_indexing.ssbo_storage_buffer_decoration.uniform_*
dEQP-VK.glsl.opaque_type_indexing.ssbo_storage_buffer_decoration.dynamically_uniform_*
dEQP-VK.glsl.opaque_type_indexing.ubo.*_geometry
dEQP-VK.glsl.opaque_type_indexing.ubo.*_tess_ctrl
dEQP-VK.glsl.opaque_type_indexing.ubo.*_tess_eval
dEQP-VK.glsl.opaque_type_indexing.ssbo.*_geometry
dEQP-VK.glsl.opaque_type_indexing.ssbo.*_tess_ctrl
dEQP-VK.glsl.opaque_type_indexing.ssbo.*_tess_eval
Change-Id: I16ed787be3057b1d77c89d9684472f1e74a3b870
Mika Väinölä [Mon, 7 Jan 2019 13:00:20 +0000 (15:00 +0200)]
Test swizzles of 2D texture lookup coordinates
Add new tests that verify 2D textures with given lookup coordinate
swizzles are rendered correctly.
New tests:
dEQP-VK.texture.swizzle.texture_coordinate.*
Affects:
dEQP-VK.texture.swizzle.*
Components: Vulkan
VK-GL-CTS issue: 1212
Change-Id: I8d1a3ef060542232ffa016342728d9b5fb01902a
Bas Nieuwenhuizen [Tue, 15 Jan 2019 17:02:59 +0000 (18:02 +0100)]
Touch watchdog more often for precision tests.
Have a test that takes ~2.5 minutes here using ARM
emulation:
01-15 17:58:54.903 3909 3926 I dEQP : Test case 'dEQP-VK.glsl.builtin.precision.reflect.mediump_compute.vec4'..
01-15 18:01:28.631 3909 3926 I dEQP : Pass (Pass)
Since this is still below the overall 300 seconds limit
for a test I thought just increasing the watchdog touch
frequency would be okay.
We probably strictly need about 1000, but for leaving
some time before/after this for the driver to do stuff
(like compiling a shader), I took something lower.
Affected tests:
dEQP-VK.glsl.builtin.precision.*
Component: Vulkan
VK-GL-CTS issue: 1560
Change-Id: I450ddac39635c857ee1966d86ae16085082d242b
Alexander Galazin [Tue, 15 Jan 2019 15:36:24 +0000 (16:36 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I7ca6e37c293b217b4e95f475e171e142c33ac181
Alexander Galazin [Tue, 15 Jan 2019 15:36:23 +0000 (16:36 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I99ab3d97b302f2b9d82ec0ce8a05e716d1aec54a
Dae Kim [Fri, 11 Jan 2019 11:38:11 +0000 (11:38 +0000)]
Added PointSize in shader used for drawing points
Follow-up change of
76a3efb8583de58358570c912e4388a780a2cb39.
A SPIR-V assembly shader with undefined PointSize was being used with
point list topology.
Affects:
dEQP-VK.subgroups.*
Components: Vulkan
VK-GL-CTS issue: 1197,1552
Change-Id: I10404d8fe45b9fb7484d1b90b984e66ca8569de4
Chris Forbes [Tue, 15 Jan 2019 01:30:31 +0000 (17:30 -0800)]
Add AHB to Android allowed extensions list
Affects: dEQP-VK.api.info.android.no_unknown_extensions
VK-GL-CTS Issue: 1559
Components: Vulkan
Google Bug: b/
120907290
Change-Id: Id1f2d63cbd51e7b3e51106f8f0214cd8d95c199c
Slawomir Cygan [Mon, 10 Dec 2018 16:08:05 +0000 (17:08 +0100)]
Fix logging of 8-bit integer values
The values were 'streamed' using << to std::stream, so they
were treated as characters, instead of integer values.
Components: Vulkan
VK-GL-CTS Issue: 1505
Affects:
dEQP-VK.spirv_assembly.type.scalar.*8.*
Change-Id: I34e697eb5b1c554b98a2fe556368bd6485fb406f
Samuel Pitoiset [Thu, 13 Dec 2018 15:45:41 +0000 (16:45 +0100)]
Fix incorrect use of copyImageToBuffer in TextureRenderer::renderQuad()
The last parameter is an access flag, not a pipeline stage one.
As the default value is already correct, removing the last
parameter is enough.
Fixes https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/1511
Components: Vulkan
VK-GL-CTS issue: 1511
Affects: dEQP-VK.texture.*
Change-Id: Ib261482d4a9fae911fbda6ad5a45548a02430c1a
(cherry picked from commit
92491133746a3d1715a683dad7f5516096c79d8f)
Boris Zanin [Tue, 27 Nov 2018 11:54:43 +0000 (12:54 +0100)]
Allow coarse derivatives to be calced by fine func
OpDPdxCoarse (OpDPdyCoarse) are allowed to be calculated by same
formulas as OpDPdxFine (OpDPdyFine). Also due to OpFwidthCoarse
is described as sum of OpDPdxCoarse, OpDPdyCoarse allow it to be
calculated by OpFwidthFine.
Components: vulkan
VK-GL-CTS issue: 1452
Affects: dEQP-VK.spirv_assembly.instruction.graphics.float16.derivative_*.opdpdxcoarse
Change-Id: Ib91d813626e579309d3d9176d52b0954efa920d4
Alexander Galazin [Sat, 12 Jan 2019 11:48:48 +0000 (12:48 +0100)]
Add 1.1.3.0 to known conformance versions
Components: Vulkan
Affects: dEQP-VK.api.driver_properties.properties
Change-Id: I521e0a02b6b26065e7da30b006511cdaf7707418
Alexander Galazin [Fri, 11 Jan 2019 17:42:50 +0000 (18:42 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: Ic27d89a0685072c89ba6c0ab226f7a4c7459f98a
Graeme Leese [Mon, 10 Dec 2018 14:31:51 +0000 (14:31 +0000)]
Correct support conditions for float16s
My previous fix missed out the graphics versions of these tests, so add
the correct conditions under which these tests can be supported as well.
Components: Vulkan
VK-GL-CTS issue: 1499
Affects:
dEQP-VK.spirv_assembly.instruction.compute.float16.opconstantcomposite.*
dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.fconvert16_*
dEQP-VK.spirv_assembly.instruction.graphics.float16.opconstant.*
Change-Id: I7ac48027b4160bd82484e7d8d780d8a1870babbf
(cherry picked from commit
f2ed80c3d2f8b4f2e782f71cc3755fe06ab52b33)
Graeme Leese [Mon, 10 Dec 2018 14:31:31 +0000 (14:31 +0000)]
Remove one method of specifying features in vktSpvAsm
The features can either be specified as a vector of strings (most of
which won't work), or as a VulkanFeatures struct, which is properly
checked. Remove the vector of strings method and change everything to
use the VulkanFeatures.
Components: Vulkan
Affects: dEQP-VK.spirv_assembly.*
Change-Id: Ia4f51f9e64dde129cb577982f2a17fa529c4c961
(cherry picked from commit
f58817ce095d2a0dda0b5d2a57f82428b3462f38)
Graeme Leese [Tue, 8 Jan 2019 15:38:23 +0000 (15:38 +0000)]
Remove incorrect vertexPipelineStoresAndAtomics dependencies
Components: Vulkan
Affects: dEQP-VK.pipeline.push_descriptor.graphics.*
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.*
dEQP-VK.glsl.opaque_type_indexing.ssbo.*
dEQP-VK.glsl.opaque_type_indexing.ssbo_storage_buffer_decoration.*
Change-Id: I68a6a42aac647e61b6d58f2cdc74b0a5b9ea9718
Graeme Leese [Mon, 10 Dec 2018 14:31:51 +0000 (14:31 +0000)]
Correct support conditions for float16s
My previous fix missed out the graphics versions of these tests, so add
the correct conditions under which these tests can be supported as well.
Components: Vulkan
VK-GL-CTS issue: 1499
Affects:
dEQP-VK.spirv_assembly.instruction.compute.float16.opconstantcomposite.*
dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.fconvert16_*
dEQP-VK.spirv_assembly.instruction.graphics.float16.opconstant.*
Change-Id: I7ac48027b4160bd82484e7d8d780d8a1870babbf
Graeme Leese [Mon, 10 Dec 2018 14:31:31 +0000 (14:31 +0000)]
Remove one method of specifying features in vktSpvAsm
The features can either be specified as a vector of strings (most of
which won't work), or as a VulkanFeatures struct, which is properly
checked. Remove the vector of strings method and change everything to
use the VulkanFeatures.
Components: Vulkan
Affects: dEQP-VK.spirv_assembly.*
Change-Id: Ia4f51f9e64dde129cb577982f2a17fa529c4c961
Piotr Byszewski [Tue, 4 Dec 2018 13:14:21 +0000 (14:14 +0100)]
Add tests for vkAcquireNextImage2KHR
This change adds two tests for vkAcquireNextImage2KHR.
* "basic2" test is based on existing "basic" test. This test
was generalized so that it can be executed using both
vkAcquireNextImage and vkAcquireNextImage2.
* New "device_group" test also does the same thing as "basic"
tests but it is rendering triangle over 600 frames using
device_group extension.
This change triggers layer errors (4 for each frame) but it
seams this is because of AcquireNextImage2 not beeing supported
by layers (https://github.com/KhronosGroup/
Vulkan-LoaderAndValidationLayers/issues/2502).
VK-GL-CTS issue: 1369
Components: Vulkan
Affects:
dEQP-VK.wsi.*.swapchain.render.*
Change-Id: I31b4ff99990a2b478cbcbbf4a8f7978edf2163c2
Alexander Galazin [Fri, 11 Jan 2019 11:22:52 +0000 (12:22 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: Ibbb2f02096cee66991004e8b14dedd9c4c618c59
Alexander Galazin [Fri, 11 Jan 2019 08:51:22 +0000 (09:51 +0100)]
Update glslang
Component: Framework
Change-Id: I35639832f859e7eb4d62c887eee465555f04b877
Martin Freebody [Tue, 18 Dec 2018 14:48:13 +0000 (14:48 +0000)]
Clear Core Validation Errors for Protected Memory
Affects: dEQP-VK.protected_memory.*
Components: Vulkan
VK-GL-CTS issue: 1539
Change-Id: I19c51330394f2fccc7a7a01fed3395bb66a5ab3f
Graeme Leese [Wed, 9 Jan 2019 16:46:22 +0000 (16:46 +0000)]
Cause vkrunner tests to fail if scripts not found
Rather than simply ignoring the test throw an InternalError.
Components: Vulkan
VK-GL-CTS Issue: 1548
Affects: dEQP-VK.vkrunner-example.*
Change-Id: Ib29692c792acf49f428e042fb9cc951dd32130dd
(cherry picked from commit
255f67d1d9dc6616058335ca8a0597b92a3bfa27)
Graeme Leese [Wed, 9 Jan 2019 16:21:05 +0000 (16:21 +0000)]
Allow a tolerance for results of sqrt
The tolerance added to the test is around 5 ULP.
Components: Vulkan
VK-GL-CTS Issue: 1546
Affects: dEQP-VK.vkrunner-example.sqrt_*
Change-Id: Idfb6f8485d10a29cf0c4c46355df1df1008298df
(cherry picked from commit
215b2e3f4424e4568cb19c290d82fe7c48cb1b8b)
Ari Suonpaa [Mon, 10 Dec 2018 07:50:45 +0000 (09:50 +0200)]
Added test for backwards subpass self dependency
There is a plan to change spec to allow subpass self dependency
to go backwards in non-framebuffer stages. This change adds
a test for one such case where geometry shader writes to an
indirect buffer, which in turn is used by an indirect draw
in the same subpass.
Affects:
dEQP-VK.renderpass*.subpass_dependencies.self_dependency.*
Components: Vulkan
VK-GL-CTS issue: 1446
Change-Id: If1d1f5fd7ad5938d54baf4c70dfc76ca0f332972
Liam Middlebrook [Thu, 3 Jan 2019 22:07:10 +0000 (14:07 -0800)]
Fix dup tests to not free in-use semaphores/fences
The dup{,2,3} tests were subject to a race condition in which a
semaphore may be deleted before a VkQueue which was dependent on it had
completed execution.
This change moves the vkQueueWaitIdle call into the same scope as the
semaphores/fences that the queue is dependent on.
VK-GL-CTS issue: 1538
Components: Vulkan
Affects: dEQP-VK.api.external.{fence,semaphore}.opaque_fd.dup*
Change-Id: I73cf541c9c184790df44b68b8a065787634847d9
(cherry picked from commit
732a8b6800972b271735cf9b865a3612fb56dfc4)
Liam Middlebrook [Thu, 3 Jan 2019 22:07:10 +0000 (14:07 -0800)]
Fix dup tests to not free in-use semaphores/fences
The dup{,2,3} tests were subject to a race condition in which a
semaphore may be deleted before a VkQueue which was dependent on it had
completed execution.
This change moves the vkQueueWaitIdle call into the same scope as the
semaphores/fences that the queue is dependent on.
VK-GL-CTS issue: 1538
Components: Vulkan
Affects: dEQP-VK.api.external.{fence,semaphore}.opaque_fd.dup*
Change-Id: I73cf541c9c184790df44b68b8a065787634847d9
Lingfeng Yang [Thu, 27 Dec 2018 00:43:40 +0000 (16:43 -0800)]
pipeline timestamps test: fix too-large VkBufferCopy
The pipeline timestamps test intends to copy the entire buffer contents
from source to destination, but the copy is done for 512 bytes, which
currently exceeds the size of the buffer, 256. That is not valid
behavior.
Components: Vulkan
Affects: dEQP-VK.pipeline.timestamp.transfer_tests.transfer_stage_with_copy_buffer_method
VK-GL-CTS Issue: 1535
Change-Id: I1ab1ef3a94f4d22702d37c86b6aa2c21c0919a7c
Alexander Galazin [Thu, 10 Jan 2019 11:57:11 +0000 (12:57 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I53a8d2676ea31656cd43414e20d203961fbdac76
Alexander Galazin [Thu, 10 Jan 2019 11:57:10 +0000 (12:57 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I7a9d2154ae19bdac61feed815f69691914a59bd4
Stephen Clarke [Fri, 21 Dec 2018 12:38:35 +0000 (12:38 +0000)]
Set correct range for OpVectorTimesScalar tests
The min[] and max[] values should be based on the result in double precision, not after it has been converted to fp16type.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_2.opvectortimesscalar
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_3.opvectortimesscalar
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_4.opvectortimesscalar
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.opvectortimesscalar*
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.opvectortimesscalar*
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.opvectortimesscalar*
Components: Vulkan
VK-GL-CTS issue: 1532
Change-Id: I30810c8c954ee899bb05602b1f8805f82ac021b3
(cherry picked from commit
12b26bd9762dd56068522cc0a17b26c9e31df1e2)
Samuel Iglesias Gonsálvez [Fri, 22 Jun 2018 06:30:28 +0000 (08:30 +0200)]
Fix errors in SPIR-V 16bit_storage tests
Commit
04ba8ac400a3 was wrongly setting a condition that made
all the *16_to_16* tests to fail. Also, in the last rebase of CL#2458,
there were a rename of an argument of OpFunction that was not updated.
Affects: dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.*
Components: Vulkan
VK-GL-CTS issue: 1234
Change-Id: Ia83bedefa33d3e37b62336ebadb2bc992e0ddb2a
(cherry picked from commit
56e8d4e2318dcd0bceddca4d182649f3a03be7ab)
Boris Zanin [Fri, 21 Dec 2018 13:53:25 +0000 (14:53 +0100)]
Remove NaN handling in float16 tests
Support of NaNs is optional according the specification.
Tests always have expected that NaNs are always supported.
To be compatible with the specification skip check of NaN
input floats.
Updated tests:
* dEQP-VK.spirv_assembly.instruction.compute.float16.logical.opfunord*
* dEQP-VK.spirv_assembly.instruction.graphics.float16.logical.opfunord*
* dEQP-VK.spirv_assembly.instruction.compute.float16.logical.opford*
* dEQP-VK.spirv_assembly.instruction.graphics.float16.logical.opford*
Affected tests:
* dEQP-VK.spirv_assembly.instruction.compute.float16.logical.opisnan*
* dEQP-VK.spirv_assembly.instruction.graphics.float16.logical.opisnan*
* dEQP-VK.spirv_assembly.instruction.compute.float16.logical.opisinf*
* dEQP-VK.spirv_assembly.instruction.graphics.float16.logical.opisinf*
Components: Vulkan
VK-GL-CTS issue: 1528
Change-Id: Iadd91ed24c78e15ff458355262b009015b8a8e4a
Stephen Clarke [Fri, 21 Dec 2018 12:38:35 +0000 (12:38 +0000)]
Set correct range for OpVectorTimesScalar tests
The min[] and max[] values should be based on the result in double precision, not after it has been converted to fp16type.
Affects:
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_2.opvectortimesscalar
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_3.opvectortimesscalar
dEQP-VK.spirv_assembly.instruction.compute.float16.arithmetic_4.opvectortimesscalar
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_2.opvectortimesscalar*
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_3.opvectortimesscalar*
dEQP-VK.spirv_assembly.instruction.graphics.float16.arithmetic_4.opvectortimesscalar*
Components: Vulkan
VK-GL-CTS issue: 1532
Change-Id: I30810c8c954ee899bb05602b1f8805f82ac021b3
Graeme Leese [Wed, 9 Jan 2019 16:21:05 +0000 (16:21 +0000)]
Allow a tolerance for results of sqrt
The tolerance added to the test is around 5 ULP.
Components: Vulkan
VK-GL-CTS Issue: 1546
Affects: dEQP-VK.vkrunner-example.sqrt_*
Change-Id: Idfb6f8485d10a29cf0c4c46355df1df1008298df
Samuel Pitoiset [Thu, 13 Dec 2018 15:45:41 +0000 (16:45 +0100)]
Fix incorrect use of copyImageToBuffer in TextureRenderer::renderQuad()
The last parameter is an access flag, not a pipeline stage one.
As the default value is already correct, removing the last
parameter is enough.
Fixes https://gitlab.khronos.org/Tracker/vk-gl-cts/issues/1511
Components: Vulkan
VK-GL-CTS issue: 1511
Affects: dEQP-VK.texture.*
Change-Id: Ib261482d4a9fae911fbda6ad5a45548a02430c1a
Graeme Leese [Wed, 9 Jan 2019 16:46:22 +0000 (16:46 +0000)]
Cause vkrunner tests to fail if scripts not found
Rather than simply ignoring the test throw an InternalError.
Components: Vulkan
VK-GL-CTS Issue: 1548
Affects: dEQP-VK.vkrunner-example.*
Change-Id: Ib29692c792acf49f428e042fb9cc951dd32130dd
Alexander Galazin [Wed, 9 Jan 2019 09:57:07 +0000 (10:57 +0100)]
Propagate required features down to the constructor
VariablePointers wasn't fully propagated down to the test constructor
Components: Vulkan
VK-GL-CTS issue: 1540
Affects:
dEQP-VK.spirv_assembly.instruction.compute.pointer_parameter.workgroup_memory_variable_pointers
Change-Id: I4d29248ad4c2f38cdda5c31be1be781331433399
Alexander Galazin [Tue, 8 Jan 2019 15:47:26 +0000 (16:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: If836faad2ea632456cf922f123ad1adb8eeed326
Alexander Galazin [Tue, 8 Jan 2019 15:47:23 +0000 (16:47 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I5302ce80a95a036db240f3097f806ffbfad6fe43
Alexander Galazin [Tue, 8 Jan 2019 15:37:27 +0000 (16:37 +0100)]
Remove unnecessary extension declarations
Declarations of SPV_AMD_gpu_shader_half_float
in the precision test are redundant and shouldn't appear
Components: Vulkan
Affects: dEQP-VK.glsl.builtin.*.comparison.*
VK-GL-CTS issue: 1541
Change-Id: I75b57cb3361b683e446effa3ab9e51f441f186d5
Alexander Galazin [Tue, 8 Jan 2019 15:07:44 +0000 (16:07 +0100)]
Merge vk-gl-cts/aosp-deqp-dev into vk-gl-cts/master
Change-Id: I3dd5a5a6c3f33307283624b2bc40cd93716f9785
Steven Perron [Tue, 11 Dec 2018 15:59:56 +0000 (10:59 -0500)]
Run validation before optimization.
The optimizer runs is own pass of the validator as a safety check.
However, that call to the validator does not get the any validatoin options passed in.
This causes problems with the memory layout tests.
The solution we will be to diable the call to the validator in the
optimizer. Instead the will be an explict call to validate the binary
before optimization starts, reusing functions that already exist to do
that.
At the same time, the run of the validator that is done with
--deqp-validation=enable will be moved so that it runs after
optimization. This way it will validate the output instead of the
input, and it will not be a redundant check.
VK-GL-CTS issue: 1503
Components: Vulkan, Framework
Affects: dEQP-VK.ssbo.layout.random.relaxed.*
Change-Id: Ib52fa97505855316739e07e472d23fcab4ac2beb
Peiyong Lin [Thu, 27 Dec 2018 23:53:39 +0000 (15:53 -0800)]
Update common.py to get the latest EGL registry.
Update common.py in order to get
EGL_EXT_gl_colorspace_display_p3_passthrough extension.
Components: EGL
VK-GL-CTS Issue: 1534
Change-Id: Ie24de656e9b88317b8e2fdc5b07d4e5ede796d0e
Treehugger Robot [Thu, 27 Dec 2018 23:38:32 +0000 (23:38 +0000)]
Merge "Merge commit aosp/master into deqp-dev" into deqp-dev
Chris Forbes [Wed, 26 Dec 2018 23:39:33 +0000 (15:39 -0800)]
Merge remote-tracking branch 'khronos/master' into deqp-dev
Change-Id: Ibacf4a76415fb5cdb0d35506adbae5f6f9e63364
Alexander Galazin [Sat, 22 Dec 2018 10:36:29 +0000 (11:36 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.3 into vk-gl-cts/master
Change-Id: I67bea781c4ee93c08da8ab6a45b33820672a62d5
Alexander Galazin [Fri, 21 Dec 2018 19:42:51 +0000 (20:42 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.2 into vk-gl-cts/vulkan-cts-1.1.3
Change-Id: I46453ca0e9531975079099a6f06e9076a20accf0
Alexander Galazin [Fri, 21 Dec 2018 18:32:00 +0000 (19:32 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.1 into vk-gl-cts/vulkan-cts-1.1.2
Change-Id: I93423c80882209c8c41d4bd9f3d403037ec9ad01
Alexander Galazin [Fri, 21 Dec 2018 15:16:09 +0000 (16:16 +0100)]
Merge vk-gl-cts/vulkan-cts-1.1.0 into vk-gl-cts/vulkan-cts-1.1.1
Change-Id: Ie0a15653a8e00e8dc4acb07c0371dad770c5ee9f
Samuel Iglesias Gonsálvez [Fri, 21 Dec 2018 11:06:16 +0000 (12:06 +0100)]
Fix Visual Studio 2013 build of VkRunner
There were build errors related to undefined inline attribute and
undefined offsetof() function.
Change-Id: I111225756c1c950d73c4886fe1c2d3d203b567c2
Components: Vulkan
VK-GL-CTS: 1530
(cherry picked from commit
0b091875702f6ac418928267917987196f0b1854)
Samuel Iglesias Gonsálvez [Fri, 21 Dec 2018 11:06:16 +0000 (12:06 +0100)]
Fix Visual Studio 2013 build of VkRunner
There were build errors related to undefined inline attribute and
undefined offsetof() function.
Change-Id: I111225756c1c950d73c4886fe1c2d3d203b567c2
Components: Vulkan
VK-GL-CTS: 1530
Boris Zanin [Thu, 20 Dec 2018 13:28:07 +0000 (14:28 +0100)]
Fix 0b prefix in conditional rendering tests
Binary integers prefixes 0b breaks Visual Studio 2013
build. Replace them with substitute constants.
Components: Vulkan
VK-GL-CTS issue: 1529
Change-Id: I58e9c1e18ba61f2248ec4ff7f29b1bf29eba8207