Jerome Jiang [Mon, 16 Apr 2018 23:37:04 +0000 (16:37 -0700)]
SVC: Fix duplicated run of svc datarate tests.
Change-Id: I3f4e45b398009852f1183943461625d621c4eb80
Jerome Jiang [Mon, 16 Apr 2018 21:25:51 +0000 (14:25 -0700)]
vp9: fix multiple run for vp9 datarate tests using one bitrate.
Change-Id: I1458bf25fadc23e8be5a9532a153d7129a53accf
Jerome Jiang [Sun, 15 Apr 2018 07:03:16 +0000 (07:03 +0000)]
Merge "vp9: refactor vp9 datarate test for better sharding."
Jerome Jiang [Thu, 12 Apr 2018 21:37:56 +0000 (14:37 -0700)]
vp9: refactor vp9 datarate test for better sharding.
Change-Id: Icfaf29e1ca847ba9e3748700c9e09383ce8d1f65
Jerome Jiang [Fri, 13 Apr 2018 22:36:39 +0000 (15:36 -0700)]
Clean up is_two_pass_svc.
Change-Id: I9e92616471be380d3ba4e2b85399d7eb9f687d2f
Jerome Jiang [Fri, 13 Apr 2018 03:40:50 +0000 (03:40 +0000)]
Merge "vp9 svc: Refactor svc datarate test for better sharding."
Jerome Jiang [Fri, 13 Apr 2018 03:40:20 +0000 (03:40 +0000)]
Merge "Silence warning when built with --enable-internal-stats."
Jerome Jiang [Thu, 12 Apr 2018 22:05:58 +0000 (15:05 -0700)]
Silence warning when built with --enable-internal-stats.
Change-Id: I3a600a9baf2b8e46c109f4ec2b5bd6bafda4bf58
Jerome Jiang [Wed, 11 Apr 2018 23:32:00 +0000 (16:32 -0700)]
vp9 svc: Refactor svc datarate test for better sharding.
Wrap denoiser tests under config flags.
Change-Id: I6175c3c9d8b5b079ad35a55553383145db58a10f
Paul Wilkins [Thu, 12 Apr 2018 10:42:50 +0000 (10:42 +0000)]
Merge "Add extra case to wq_err_divisor()"
James Zern [Mon, 9 Apr 2018 23:07:40 +0000 (16:07 -0700)]
vpx_image: remove unused image formats
libvpx only emits:
VPX_IMG_FMT_{I420,I422,I440,I444,I42016,I42216,I44016,I44416}
and additionally supports YV12 as input.
interleaved yuv, rgb and alpha formats are unused.
Change-Id: Ie2ab1099e950c6e696f475d46882f5c47a174042
Marco Paniconi [Mon, 9 Apr 2018 18:05:51 +0000 (18:05 +0000)]
Merge "vp9-svc: Make constrained_layer_drop default for svc."
Jerome Jiang [Mon, 9 Apr 2018 17:03:59 +0000 (17:03 +0000)]
Merge "Fix settings for num of tiles in samples & tests."
Marco Paniconi [Mon, 9 Apr 2018 16:41:47 +0000 (09:41 -0700)]
vp9-svc: Make constrained_layer_drop default for svc.
Switch the order of constrained and layer drop mode,
and keep constrained_layer_drop as the default.
Update the svc datarate tests.
Change-Id: I764270f7b4964b87b0cd3da6c2f96a628f212a30
Jerome Jiang [Thu, 5 Apr 2018 21:45:06 +0000 (14:45 -0700)]
Fix settings for num of tiles in samples & tests.
The control is set by log2 of number of threads (such that the number of
tiles is the same of number of threads).
Thus it should be log2(num_threads) instead of (num_threads >> 1).
Change-Id: I2ccec5557e660048dad3e561534e1c74fc8eec1f
Marco Paniconi [Fri, 6 Apr 2018 16:17:46 +0000 (09:17 -0700)]
vp9-svc: Hybrid search on spatial layers whose base is key.
For spatial layers whose base is a key frame, i.e., when
svc.layer_context[cpi->svc.temporal_layer_id].is_key_frame = 1,
allow for hybrid search, similar to what we do on key frames.
For small blocks (<= 8x8) rd-based intra search will be used,
otherwise non-rd pick mode is used.
Feature is controlled by nonrd_keyframe, which is set to 1
for now on non-base spatial layers, so this change has
currently no effect.
Small change only when inter-layer prediction is off, as we now
call vp9_pick_intra_mode instead of vp9_pick_inter_mode on key frame.
But this change is very small/insignificant.
Change-Id: I5372470f720812926ebbe6c4ce68c04336ce0bdd
Johann Koenig [Fri, 6 Apr 2018 15:26:59 +0000 (15:26 +0000)]
Merge "remove support for yuv 411"
Marco Paniconi [Fri, 6 Apr 2018 05:41:56 +0000 (05:41 +0000)]
Revert "vp9-svc: Fix to first superframe when inter_layer is off."
This reverts commit
5cc8df5bcfe49fbfca21ee57401c7807c048751b.
Reason for revert: <INSERT REASONING HERE>
We need to do this on all key frames in the stream (not just the first one). Will make another cleaner change for this.
Original change's description:
> vp9-svc: Fix to first superframe when inter_layer is off.
>
> When the application selects the setting INTER_LAYER_PRED_OFF
> each spatial stream should be decodeable separately.
> For this we need to force key frames on all spatial layers
> on the first superframe.
>
> In order to maintain the quality at the beginning of the stream
> the active_worst for spatial layer of the second superframe is set
> to the last_QP of the correspondng spatial layer of the first superframe.
> Also make sure nonrd_keyframe is set for non-base spatial layers.
>
> Change only affects SVC mode wit number_spatial_layers > 1 and
> svc->disable_inter_layer_pred == INTER_LAYER_PRED_OFF.
> And only affects first and second frame of sequence.
>
> Change-Id: I8ee9a0873ab1d3a02515774571f719617771ad41
TBR=marpan@google.com,builds@webmproject.org,jianj@google.com
Change-Id: If73d9f3932224fc6751e773763adf7e8ee67d17f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Marco Paniconi [Wed, 4 Apr 2018 23:24:39 +0000 (16:24 -0700)]
vp9-svc: Fix to first superframe when inter_layer is off.
When the application selects the setting INTER_LAYER_PRED_OFF
each spatial stream should be decodeable separately.
For this we need to force key frames on all spatial layers
on the first superframe.
In order to maintain the quality at the beginning of the stream
the active_worst for spatial layer of the second superframe is set
to the last_QP of the correspondng spatial layer of the first superframe.
Also make sure nonrd_keyframe is set for non-base spatial layers.
Change only affects SVC mode wit number_spatial_layers > 1 and
svc->disable_inter_layer_pred == INTER_LAYER_PRED_OFF.
And only affects first and second frame of sequence.
Change-Id: I8ee9a0873ab1d3a02515774571f719617771ad41
Marco Paniconi [Thu, 5 Apr 2018 22:54:17 +0000 (15:54 -0700)]
vp9-svc: Fix to disable cyclic refresh on key superframes.
Cyclic refresh is disabled on key frames, but we did not
disable it for for spatial layers whose base is a key frame
(i.e., on a key-superframe).
This fix means generally somewhat lower frame-level QP will be
used for those spatial layers whose base is a key frame,
which will generally mean little better quality for the
key-superframes.
Change-Id: Idf090651aa2f5856fb6696c89198a9f6d5d50280
Johann [Thu, 5 Apr 2018 18:59:56 +0000 (11:59 -0700)]
update codereview.settings
Using pdfium as a reference:
https://pdfium.googlesource.com/pdfium/+/master/codereview.settings
Change-Id: I30874cf9f1d575325c32342146137a1952db91ba
Johann [Tue, 27 Mar 2018 17:41:54 +0000 (10:41 -0700)]
ios configure: quiet shell warning
Generating file lists on a non-mac with:
--target=x86-iphonsimulator-gcc --enable-external-build
the lack of xcrun would cause a warning to print:
libvpx/build/make/configure.sh: line 1397: [: : integer expression expected
Change-Id: I4623b6c5b65296bc71986cd042823f4be9427b42
Marco Paniconi [Wed, 4 Apr 2018 05:59:00 +0000 (05:59 +0000)]
Merge "vp9-svc: Fix in choose_partitioning for different scaling."
Marco Paniconi [Wed, 4 Apr 2018 02:15:56 +0000 (02:15 +0000)]
Merge "Fix to svc sample enocoder for visual studio build."
Marco Paniconi [Tue, 3 Apr 2018 22:50:19 +0000 (15:50 -0700)]
vp9-svc: Fix in choose_partitioning for different scaling.
In the SVC encoder LAST ref frame should be the last temporal
reference at the same resolution. This is the case for the default/fixed
patterns, but may not be the case for arbitrary pattern in flexible mode.
Add check that the LAST reference frame has same resolution as the current frame.
If the reference scale for LAST is different from current treat the current
frame as key frame just for the purpose of superblock partitioning.
This avoids potential segfault in vp9_int_pro_motion_estimation() for different
scaled reference.
Change-Id: I4276ff616de46cd4e12c73316f85ae313f170242
Linfeng Zhang [Tue, 3 Apr 2018 22:36:41 +0000 (15:36 -0700)]
rm CONVERT_TO_SHORTPTR in vpx_highbd_comp_avg_pred
BUG=webm:1388
Change-Id: I1d0dd9af52a1461e3e2b2d60e8c4b6b74c3b90b0
Marco Paniconi [Tue, 3 Apr 2018 21:34:07 +0000 (14:34 -0700)]
Fix to svc sample enocoder for visual studio build.
Fix to sample encoder, for visual studio buid failure:
conversion from 'uint64_t' to 'int'.
Change-Id: I385ab8482e1ee97da9872437f8286d9071e38e0e
Johann [Mon, 2 Apr 2018 22:33:34 +0000 (15:33 -0700)]
remove support for yuv 411
Previously we attempted to convert 411 input. Remove support
because malformed 411 input can cause the conversion to crash.
BUG=webm:1386
Change-Id: I3d41465a94867ee7f8eaa43fb76beb41f8fa644b
Marco Paniconi [Mon, 2 Apr 2018 19:46:19 +0000 (12:46 -0700)]
vp9-svc: Fix to svc sample encoder for write_out.
When writing out stream for spatial layer N,
make sure to include all spatial layers up to N.
Fixes an issue with the streams when frame dropping occurs.
Change-Id: I1e20b7dac6b94dcda751043541dd8a12f7df6d8c
Johann Koenig [Mon, 2 Apr 2018 18:30:28 +0000 (18:30 +0000)]
Merge "helper script for sanitizer testing"
Linfeng Zhang [Mon, 2 Apr 2018 16:05:05 +0000 (16:05 +0000)]
Merge changes I5704bd66,I4d548e97
* changes:
Shrink size of mode_map in struct TileDataEnc
Update sad4d x86 functions
James Zern [Sat, 31 Mar 2018 00:49:11 +0000 (00:49 +0000)]
Merge "vp9_datarate_test: relax over shoot constraints"
Jerome Jiang [Fri, 30 Mar 2018 23:57:21 +0000 (23:57 +0000)]
Merge "VP9 SVC: Write bitstream for each spatial layer in sample."
James Zern [Fri, 30 Mar 2018 23:29:10 +0000 (16:29 -0700)]
vp9_datarate_test: relax over shoot constraints
in BasicRateTargetingVBRLagZero and
BasicRateTargetingVBRLagNonZeroFrameParDecOff after:
e0b28ad69 Add extra case to wq_err_divisor()
BUG=webm:1512
Change-Id: Id181613cc191ff2a2281deffe141efb982501edf
Jerome Jiang [Fri, 30 Mar 2018 21:15:06 +0000 (14:15 -0700)]
VP9 SVC: Write bitstream for each spatial layer in sample.
Added control for denoiser in the sample SVC encoder.
Change-Id: I8e62aa2fc13a943eb110cb33e419e912a898bbc7
Jerome Jiang [Fri, 30 Mar 2018 17:47:41 +0000 (10:47 -0700)]
Code cleanup for datarate tests.
Add/Remove static to functions. Name change.
Change-Id: I5de3efc23cd151fe8e70fe67a7a11acfcfa707dc
Jerome Jiang [Wed, 28 Mar 2018 23:35:43 +0000 (16:35 -0700)]
Split datarate_test.cc to vp8, vp9, svc ones.
As we add more tests to datarate_test.cc, it's growing bigger and hard
to find specific test.
Split it to vp8, vp9 and svc ones.
Change-Id: Ie8c302010cf304a95554bee19d87ddc90498d0fb
James Zern [Thu, 29 Mar 2018 19:01:34 +0000 (19:01 +0000)]
Merge "test: use testing::*tuple instead of std::tr1"
Marco Paniconi [Thu, 29 Mar 2018 18:49:26 +0000 (18:49 +0000)]
Merge "vp9-svc: Fix in pickmode for key frames."
Jerome Jiang [Thu, 29 Mar 2018 18:44:35 +0000 (18:44 +0000)]
Merge "VP9 SVC: Add enum type for framedrop_mode."
Jerome Jiang [Wed, 28 Mar 2018 23:23:26 +0000 (16:23 -0700)]
VP9 SVC: Add enum type for framedrop_mode.
Change-Id: I3d4697b00729553e0860762b9264e29b8a89b9d4
Johann [Tue, 27 Mar 2018 19:59:15 +0000 (12:59 -0700)]
helper script for sanitizer testing
source tools/set_analyzer_env.sh <sanitizer>
will set the compiler, flag, and sanitizer variables necessary to build
and run a variety of sanitizers.
Change-Id: I5dd2ae947cb337d5ccf2a11e9fe87991bc8ba0c8
paulwilkins [Thu, 29 Mar 2018 11:52:15 +0000 (12:52 +0100)]
Add extra case to wq_err_divisor()
Add extra case for 360P and smaller.
This hurts a little in psnr for the derf cif set but helps a little
in terms of average rate accuracy. Most clips come in a little
smaller with this patch.
No impact on larger formats.
Change-Id: I5056246cb53b90f961ff9ea5813937f33778aa4c
xiwei gu [Thu, 29 Mar 2018 01:05:33 +0000 (01:05 +0000)]
Merge "vp9: [loongson] optimize vpx_convolve8 with mmi."
Marco Paniconi [Wed, 28 Mar 2018 23:10:17 +0000 (16:10 -0700)]
vp9-svc: Fix in pickmode for key frames.
For the fixed/default SVC patterns, GOLDEN is the
spatial reference, except on key frames, where LAST
is labeled as the spatial reference.
The current code was assuming GOLDEN is always the
spatial reference for the purpose of selecting the
subpel motion (due to the downsampling filter).
Fix is make sure flag_svc_subpel is set and used
with spatial_ref, which is labeled as the proper
spatial reference before entering mode check.
Some quality improvement on key frames.
Change-Id: Id236bcd47055b035731cc910ed84449d7e29f50c
Marco Paniconi [Wed, 28 Mar 2018 21:29:35 +0000 (21:29 +0000)]
Merge "vp9-svc: Modify logic for frame dropping with spatial layers."
Marco Paniconi [Wed, 28 Mar 2018 19:09:54 +0000 (12:09 -0700)]
vp9-svc: Modify logic for frame dropping with spatial layers.
In the constrained framedrop mode for svc: modify the buffer check
condition relative to (non-zero) dropmark to include uppper spatial layers,
in addition to the current spatial layer.
But keep the single layer check if the buffer goes below zero, since
in this case (buffer underflow) we should force drop of that layer
regardless of upper layers.
Change-Id: Id277f0b4a3ae6275effdd5f5f0c80e3229c17424
Linfeng Zhang [Mon, 26 Mar 2018 23:42:00 +0000 (16:42 -0700)]
Shrink size of mode_map in struct TileDataEnc
To reduce the memcpy() cycles in vp9_rd_pick_inter_mode_sb().
The maximum value of mode_map is (MAX_MODES - 1) = 29.
Change-Id: I5704bd66838ea0b075f0afb001f5cbebfd3f1602
Linfeng Zhang [Mon, 26 Mar 2018 20:06:09 +0000 (13:06 -0700)]
Update sad4d x86 functions
Speed change is marginal.
Change-Id: I4d548e9763ce43bd546f19132202f7a8509a32bf
James Zern [Wed, 28 Mar 2018 19:42:27 +0000 (12:42 -0700)]
test: use testing::*tuple instead of std::tr1
googletest imports tuple into testing to allow for compatibility across
c++ versions where tuple may be in std::tr1 or std. fixes deprecation
warnings under visual studio 2017
Change-Id: Id78b372d5478b12d8c8f63fd3f2166fec25aa8be
Linfeng Zhang [Wed, 28 Mar 2018 19:39:37 +0000 (19:39 +0000)]
Merge "Add speed test in SADx4Test"
Linfeng Zhang [Thu, 22 Mar 2018 20:37:49 +0000 (13:37 -0700)]
Add speed test in SADx4Test
Change-Id: I42dd3df8c13c0a6d08ce28e27e8917b5d831fc1a
gxw [Thu, 25 Jan 2018 01:38:28 +0000 (09:38 +0800)]
vp9: [loongson] optimize vpx_convolve8 with mmi.
1. vpx_convolve8_vert_mmi
2. vpx_convolve8_horiz_mmi
3. vpx_convolve8_mmi
4. vpx_convolve8_avg_mmi
5. vpx_convolve8_avg_vert_mmi
Change-Id: I41a6b3b4f327d6b67d282e0163cfa0aee8648abe
Marco Paniconi [Wed, 28 Mar 2018 17:28:14 +0000 (10:28 -0700)]
vp9-svc: Add check in datarate unittests for frame-dropping.
Add verfication for constrained svc framedrop mode: check that
if a given spatial is dropped, all uppper layers must be dropped.
Change-Id: I9b4821b23c95d1d9d0c031a41af19984647ec5dc
Marco Paniconi [Tue, 27 Mar 2018 03:25:57 +0000 (20:25 -0700)]
vp9-svc: Add logic to enable for constrained framedrop.
Add the logic for the constrained framdrop mode for SVC.
Add test case in datarate unittests.
Also lower target bitrates in the tests to better test
frame dropper.
Change-Id: I8ee1b8cb56d835c233ad1fbe0fc1456cb2e7291f
Johann Koenig [Tue, 27 Mar 2018 01:08:12 +0000 (01:08 +0000)]
Merge "third_part/googletest: update to release-1.8.0-742-g7857975"
Marco Paniconi [Mon, 26 Mar 2018 17:53:38 +0000 (10:53 -0700)]
vp9-svc: Allow for setting frame drop thresholds per layer.
Add encoder control to set the frame drop thresholds per
spatial layer, and add a frame drop mode: 0 = per-layer drop,
and 1 = constrained drop mode (a drop on a given layer forces
drops to all upper layers).
Default is mode 0 (per-layer dropping).
Implementation for mode 1 will come in subsequent change.
If the control is not used, then the spatial layer frame
drop thresholds (water mark) are all equal and set to the value
given by the encoder config (oxcf->drop_frames_water_mark).
Bump up the ABI version.
Change-Id: Id038d4181b86fa98b3d44d026f96d5f344d81629
Johann [Mon, 26 Mar 2018 18:24:26 +0000 (11:24 -0700)]
third_part/googletest: update to release-1.8.0-742-g7857975
Address std::tr1::tuple warnings:
https://github.com/google/googletest/issues/1111
The unsigned overflow fix has been superseded by:
https://github.com/google/googletest/pull/1180
Change-Id: I92dc0ba08a4d0d63f5e5b2da7b64f4a4642ed9ab
Johann [Tue, 20 Mar 2018 00:00:44 +0000 (17:00 -0700)]
msvs build: only fix_file_list when it is broken
Clears a warning when generating VS project files with older versions of
bash:
declare: -n: invalid option
Change-Id: Id0c0bc17dc5a1599f7d2d73e3cc9259a45540f3f
Paul Wilkins [Sat, 24 Mar 2018 11:27:12 +0000 (11:27 +0000)]
Merge "Adjustment to initial q range estimate and kf boost."
Martin Storsjö [Fri, 23 Mar 2018 22:04:43 +0000 (22:04 +0000)]
Merge "Restore emms usage on x86_64 after
726b021a12c1b"
Martin Storsjo [Fri, 23 Mar 2018 10:48:42 +0000 (12:48 +0200)]
Restore emms usage on x86_64 after
726b021a12c1b
Even on x86_64, emms has to be called if the x87 state has
been clobbered - the calling code (either within libvpx or
in a caller outside of libvpx) may be using the x87 instructions,
even though use of them isn't all that common on x86_64.
This fixes builds with clang for mingw/x86_64.
Change-Id: I1f6072835590b862bad156f17331ba65c813ddd9
Martin Storsjö [Fri, 23 Mar 2018 19:54:01 +0000 (19:54 +0000)]
Merge "thumb: Remove a brittle, ugly and unused arm->thumb conversion"
Martin Storsjö [Fri, 23 Mar 2018 19:49:40 +0000 (19:49 +0000)]
Merge changes from topic "llvm-mingw"
* changes:
configure: Add an arm64-win64-gcc target
test: Check for ARCH_X86_64 in addition to _WIN64
configure: Add an armv7-win32-gcc target
ads2gas: Add a -noelf option
Johann Koenig [Fri, 23 Mar 2018 18:04:35 +0000 (18:04 +0000)]
Revert "remove fldcw/fstcw from Win64 builds"
This reverts commit
60a3cb9ad840377d46286bfd703c30a4a4ee56e2.
Reason for revert: x87 instruction usage might not be as
clear cut as I would like. At the very least, llvm mingw
builds appear to having issues with emms.
Original change's description:
> remove fldcw/fstcw from Win64 builds
>
> _MCW_PC (Precision control) is not supported on x64:
> https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/control87-controlfp-control87-2
>
> The x87 FPU is not used on Win64 or ARM so setting the x87 control word
> is not necessary. The SSE/SSE2 and ARM FPUs don't have a precision
> control - the precision is embedded in each instruction - so the need to
> set the control word is also gone.
BUG=webm:1500
Change-Id: I25bcfa96bc9c860f6c7e03315d75fa6fd1d88ec5
Johann Koenig [Fri, 23 Mar 2018 13:23:58 +0000 (13:23 +0000)]
Merge "remove fldcw/fstcw from Win64 builds"
Johann [Mon, 5 Mar 2018 21:48:35 +0000 (13:48 -0800)]
remove fldcw/fstcw from Win64 builds
_MCW_PC (Precision control) is not supported on x64:
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/control87-controlfp-control87-2
The x87 FPU is not used on Win64 or ARM so setting the x87 control word
is not necessary. The SSE/SSE2 and ARM FPUs don't have a precision
control - the precision is embedded in each instruction - so the need to
set the control word is also gone.
BUG=webm:1500
Change-Id: I014513282a7dc320d1cdeaec48249d98a66bf09f
Martin Storsjo [Wed, 21 Mar 2018 12:15:13 +0000 (14:15 +0200)]
configure: Add an arm64-win64-gcc target
This configuration doesn't require any extra custom settings, since
it only uses neon intrinsics that are handled automatically by the
compiler (no external assembly).
Change-Id: I35415c68f483a430c0672e060a7bbd09a3469512
Martin Storsjo [Wed, 21 Mar 2018 12:13:33 +0000 (14:13 +0200)]
test: Check for ARCH_X86_64 in addition to _WIN64
_WIN64 is also defined when targeting windows on aarch64.
Change-Id: I42b84e14079c19d0ba9362a06d8c6e7287644373
Martin Storsjo [Wed, 21 Mar 2018 12:12:04 +0000 (14:12 +0200)]
configure: Add an armv7-win32-gcc target
This builds for windows on arm, with llvm-mingw. The target triplet
is named -gcc since that's how similar existing targets are named,
even though it technically runs clang (via frontends named
"$CROSS-gcc").
Assemble using $CC -c since there's no standalone assembler
available (except perhaps llvm-mc).
Change-Id: I2c9a319730afef73f811bad79f488dcdc244ab0d
Martin Storsjo [Wed, 21 Mar 2018 12:09:04 +0000 (14:09 +0200)]
ads2gas: Add a -noelf option
This allows skipping elf specific features from the output.
Change-Id: I739299ba41286ca10415e056b4ffd561be5e0350
Martin Storsjo [Fri, 23 Mar 2018 11:06:41 +0000 (13:06 +0200)]
thumb: Remove a brittle, ugly and unused arm->thumb conversion
The relevant code that this conversion handled was removed in
c26a9ecaa21f4.
Change-Id: Iee40f95134e609c291c7c4e06bc50dcb895bc5e3
James Zern [Fri, 23 Mar 2018 03:56:50 +0000 (03:56 +0000)]
Merge changes Ied91c7ef,If2dcc6e2,Ib7397e71,Ib6392c79
* changes:
Fix implicit-fallthrough warnings
Fix dangling-else warnings
Fix a strict-overflow warning
Rename several static NEON iht functions
Jerome Jiang [Fri, 23 Mar 2018 01:41:21 +0000 (01:41 +0000)]
Merge "vp9 svc frame drop: enable adaptive rd for row mt."
Jerome Jiang [Tue, 20 Mar 2018 22:39:02 +0000 (15:39 -0700)]
vp9 svc frame drop: enable adaptive rd for row mt.
adaptive_rd_threshold_mt is set to 1 when speed >= 7 for SVC.
QVGA in SVC uses speed 5 which set adaptive_rd_threshold_mt to 0.
If VGA or HD is dropped for the last super frame, the flag is still 0
when the encoder is destroyed. Thus memory won't be released.
Change the bitrate threshold in datarate test.
Change-Id: I55352cc0b030568d38eb735d99c2fa29058d3690
Linfeng Zhang [Thu, 22 Mar 2018 17:58:37 +0000 (10:58 -0700)]
Fix implicit-fallthrough warnings
Compiler -- gcc (Debian 7.3.0-5) 7.3.0
Change-Id: Ied91c7ef3d25c3ef44a1f667656176e2709b4f44
Linfeng Zhang [Thu, 22 Mar 2018 17:46:02 +0000 (10:46 -0700)]
Fix dangling-else warnings
Compiler -- gcc (Debian 7.3.0-5) 7.3.0
Change-Id: If2dcc6e215a2990cde575f0e744ce0c7a44a15f1
Linfeng Zhang [Thu, 22 Mar 2018 01:00:40 +0000 (18:00 -0700)]
Fix a strict-overflow warning
Compiler -- gcc (Debian 7.3.0-5) 7.3.0
./libvpx/vp9/encoder/vp9_denoiser.c:374:9: assuming signed overflow
does not occur when assuming that (X + c) < X is always false
[-Wstrict-overflow]
for (j = 0; j < xmis; j++) {
Change-Id: Ib7397e718ff717bdabc088fc4c6e1771381fb522
Linfeng Zhang [Wed, 21 Mar 2018 20:06:02 +0000 (13:06 -0700)]
Rename several static NEON iht functions
Change-Id: Ib6392c79d0269a43dbe180a89f2571482d98844d
Marco Paniconi [Wed, 21 Mar 2018 17:56:09 +0000 (10:56 -0700)]
vp9-svc: Fix to sample encoder
Get the correct computation of number of input
layers to account for frame drops.
Change-Id: I39637381e1981b53c930da67a5c525191de6907d
James Zern [Wed, 21 Mar 2018 17:52:47 +0000 (17:52 +0000)]
Merge "vp9_highbd_iht8x8_add_neon: rm unused functions"
Jerome Jiang [Tue, 20 Mar 2018 18:12:16 +0000 (11:12 -0700)]
VP9 SVC: Add control to disable inter layer prediction.
Add VP9E_SET_SVC_INTER_LAYER_PRED to disable inter layer (spatial)
prediction.
0: prediction on
1: prediction off for all frames
2: prediction off for non key frames
Bump up ABI version.
Change-Id: I5ab2a96b47e6bef202290fe726bed5f99bd4951f
Marco Paniconi [Tue, 20 Mar 2018 21:46:36 +0000 (21:46 +0000)]
Merge "vp9-svc: Improve frame dropper for spatial layers."
Marco Paniconi [Mon, 19 Mar 2018 03:46:30 +0000 (20:46 -0700)]
vp9-svc: Improve frame dropper for spatial layers.
SVC frame dropper: modify the logic to allow for individual
spatial layers to drop. This removes the constraint that all
upper spatial layers must drop when a given spatial layer drops.
Add a flag to the pkt to indicate whether a spatial layer is
encoded or dropped. This is needed for applications that enable
this feature (frame dropping for SVC).
For a current spatial layer, if its previous spatial layer is
dropped, then disable certain features for that layer:
inter-layer prediction, base_mv, partition_reuse, copy partition.
Also add the constraint to never drop a spatial layer if its
base layer is a key frame.
Updates to sample encoder (vp9_spatial_svc_encoder) and the
SVC datarate unittests to properly handle frame dropping.
Bump up ABI version.
Change-Id: I7d14ccf67b8d014a7abfce5ba3989fc623e94067
Johann [Mon, 19 Mar 2018 23:46:06 +0000 (16:46 -0700)]
visual studio: add yasm instructions
Change-Id: Ied2a1fc0e1d1a2245d63f267669add8889dd0cec
Johann Koenig [Tue, 20 Mar 2018 17:06:18 +0000 (17:06 +0000)]
Merge "x86 android: default on realtime-only"
Johann Koenig [Tue, 20 Mar 2018 17:06:05 +0000 (17:06 +0000)]
Merge "build: remove stale .git files"
Johann Koenig [Tue, 20 Mar 2018 17:05:17 +0000 (17:05 +0000)]
Merge "reland "use intrinsics for 'emms'""
Johann [Mon, 19 Mar 2018 22:57:29 +0000 (15:57 -0700)]
build: remove stale .git files
These were used for an older style of Visual Studio configurations.
Change-Id: I51f07b30ad51c4da0c5caf1ede36cdb69b2d2b19
Johann [Wed, 14 Mar 2018 23:57:57 +0000 (16:57 -0700)]
reland "use intrinsics for 'emms'"
Only target 32bit builds. Visual Studio does not define _mm_empty for
64bit configurations.
Rename emms.asm and remove from 32 bit builds to avoid empty file
warnings.
Don't check register state on 64bit builds.
BUG=webm:1500
This reverts commit
60beb781c140b61c1957abd2a6717d2e9a831933.
Change-Id: I5ac4cf6c67249ff24f7da19792144de20527bfce
Jerome Jiang [Mon, 19 Mar 2018 19:00:55 +0000 (19:00 +0000)]
Merge "VP8: Fix out of range index for mvcost."
James Zern [Mon, 19 Mar 2018 01:24:41 +0000 (18:24 -0700)]
vp9_highbd_iht8x8_add_neon: rm unused functions
their use was removed in:
d8424d289 Fix a bug in vp9_highbd_iht8x8_64_add_neon
Change-Id: I041800f3fb34ffbb7cfa7401370c5a5ceeab01c6
James Zern [Sat, 17 Mar 2018 00:47:56 +0000 (17:47 -0700)]
CopyFrameTest: reduce max size for 32-bit targets
avoids potential OOM when allocating 3 buffers for 16383x16383; 3840 is
used as a replacement
this test was missed in:
215bddf32 vpx_scale_test: reduce max size for 32-bit targets
Change-Id: I515adf5999c6ef1724394ccd62d677134bd35e6d
Jerome Jiang [Wed, 21 Feb 2018 23:28:54 +0000 (15:28 -0800)]
VP8: Fix out of range index for mvcost.
Clamp index between 0 and MVvals.
Bit exact for speed -8, -6 and -4 on RTC set.
BUG=b/
72510002
Change-Id: I61bdb02a0924e157b3c1980f74fbbfe5ce51bc44
James Zern [Sat, 17 Mar 2018 00:47:56 +0000 (17:47 -0700)]
vpx_scale_test: reduce max size for 32-bit targets
avoids potential OOM when allocating 3 buffers for 16383x16383; 3840 is
used as a replacement
Change-Id: I92116ab69b10db6820fc651d3626bd9699700208
paulwilkins [Mon, 26 Feb 2018 17:44:50 +0000 (17:44 +0000)]
Adjustment to initial q range estimate and kf boost.
Adjustment to initial active based on image size.
Add extra breakout case for kf boost loop.
Small adjustment to q delta calculation for key frames.
Net % improvements for all standard tests sets (-ve values) measured
using c-bvr mode.
(Overall PSNR, SSIM, PSNR-HVS)
Low Res: -0.223 -0.229 -0.107
Mid Res: -0.175 0.008 -0.180
High Res: -0.131 0.106 -0.206
NFlix 2K: -0.390 -0.271 -0.489
NFlix 4K: -1.370 -0.825 -1.590
Change-Id: I06a39de43594e1a99bb0cb281af15cdb8058a8ed
Marco Paniconi [Wed, 14 Mar 2018 17:03:31 +0000 (10:03 -0700)]
vp9-svc: Frame dropper for SVC.
If a given spatial layer decides to drop, due to the
buffer/overshoot conditions for that layer, then drop
that current spatial layer and all spatial layers above.
In the current implementation the svc frame counter
(and hence the pattern for the non-flexible SVC case)
are updated on frame drops.
Also add last spatial layer encoded to the pkt.
This is useful for RTC applications that enable
frame dropping for SVC.
Update to the SVC datarate tests:
enabled frame dropper on all SVC datarate tests, and
made a fix to properly set the temporal_layer_id, which
works now even on frame drops.
Change-Id: If828c193f3cb6b1839803fd52fe9fbbda5b5a039
James Zern [Fri, 16 Mar 2018 03:52:02 +0000 (03:52 +0000)]
Merge "libs.mk,vcxproj generation: split srcs in invocation"
James Zern [Fri, 16 Mar 2018 02:11:52 +0000 (02:11 +0000)]
Merge "Revert "vp9_loopfilter.c: zero lfl_uv""
James Zern [Thu, 15 Mar 2018 21:43:29 +0000 (21:43 +0000)]
Revert "vp9_loopfilter.c: zero lfl_uv"
This reverts commit
13d0955b250bcb7eac99034e7b1677d3d026b569.
Reason for revert:
this should be investigated further to ensure the memset is really
necessary outside of the static analysis pass.
Original change's description:
> vp9_loopfilter.c: zero lfl_uv
>
> The initialization depends on cm and mi_row which static
> analysis does not approve of.
>
> Clears a static analysis warning:
> warning: The right operand of '+' is a garbage value
> const loop_filter_thresh *lfi = lfthr + *lfl;
>
> Change-Id: I8c863ced2b1e9a7e10103b7281098f20941a6ca2
TBR=johannkoenig@google.com,marpan@google.com,builds@webmproject.org,jianj@google.com
Change-Id: Icadb6438fbcddba747622f06f2eadebdb333edf6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true