Jean Perier [Thu, 30 Sep 2021 13:26:00 +0000 (06:26 -0700)]
[flang] Add a wrapper for Fortran main program
Add a C wrapper that calls the Fortran runtime initialization and
finalization routines as well as the compiled Fortran main program
_QQmain.
Place it in its own library to satisfy shared library builds since it
contains a C main function.
- https://github.com/flang-compiler/f18-llvm-project/commit/
cc7ac498f916d32a9b197d3ace816f4de5d36aad#diff-fa35a5efa62731fd2845e5e982eca9a2e36439783e11a4e4a463753c2160ec10R53
- was created in flang/test/Examples/main.c in Eric's branch
Jean Perier [Thu, 30 Sep 2021 12:04:47 +0000 (05:04 -0700)]
[flang][NFC] Fix header comments in some runtime headers
Teresa Johnson [Fri, 1 Oct 2021 04:13:51 +0000 (21:13 -0700)]
[MemProf] Loosen matching of profile data to avoid bot flakes
Allow for the allocations to have migrated cpus, assuming they wouldn't
is causing some bot flakiness, e.g.:
https://lab.llvm.org/buildbot/#/builders/37/builds/7197
Koutheir Attouchi [Fri, 1 Oct 2021 03:57:53 +0000 (20:57 -0700)]
Expose `DIBuilder::finalizeSubprogram()` through the LLVM C API
The LLVM C API function is called `LLVMDIBuilderFinalizeSubprogram()`.
Reviewed By: CodaFi
Differential Revision: https://reviews.llvm.org/D104794
Albion Fung [Thu, 30 Sep 2021 23:50:09 +0000 (18:50 -0500)]
[PowerPC] Fix lharx and lbarx builtin signatures
The signatures for the PowerPC builtins lharx and
lbarx are incorrect, and causes issues when used in a function
that requires the return of the builtin to be promoted.
This patch fixes these signatures.
Differential revision: https://reviews.llvm.org/D110273
Vitaly Buka [Fri, 1 Oct 2021 02:36:53 +0000 (19:36 -0700)]
[NFC][asan] Remove redundant functions
Vitaly Buka [Fri, 1 Oct 2021 02:24:53 +0000 (19:24 -0700)]
[NFC][lsan] Expand use StackDepotReverseMap
Before StackDepotReverseMap was used only by ProcessPC.
Vitaly Buka [Fri, 1 Oct 2021 02:10:20 +0000 (19:10 -0700)]
[NFC][sanitizer] Lazy init in StackDepotReverseMap
LLVM GN Syncbot [Fri, 1 Oct 2021 00:43:50 +0000 (00:43 +0000)]
[gn build] Port
3077bc90de8d
Christopher Tetreault [Thu, 30 Sep 2021 17:34:56 +0000 (10:34 -0700)]
[NFC] Restore magic and magicu to a globally visible location
While these functions are only used in one location in upstream,
it has been reused in multiple downstreams. Restore this file to
a globally visibile location (outside of APInt.h) to eliminate
donwstream breakage and enable potential future reuse.
Additionally, this patch renames types and cleans up
clang-tidy issues.
ZijunZhao [Fri, 1 Oct 2021 00:19:35 +0000 (00:19 +0000)]
add tsan shared library
Vitaly Buka [Fri, 1 Oct 2021 00:15:07 +0000 (17:15 -0700)]
[NFC][sanitizer] Add const into method
Yonghong Song [Mon, 27 Sep 2021 15:21:48 +0000 (08:21 -0700)]
BPF: implement isLegalAddressingMode() properly
Latest upstream llvm caused the kernel bpf selftest emitting the
following warnings:
In file included from progs/profiler3.c:6:
progs/profiler.inc.h:489:2: warning: loop not unrolled:
the optimizer was unable to perform the requested transformation;
the transformation might be disabled or specified as part of an unsupported
transformation ordering [-Wpass-failed=transform-warning]
for (int i = 0; i < MAX_PATH_DEPTH; i++) {
^
Further bisecting shows this SimplifyCFG patch ([1]) changed
the condition on how to fold branch to common dest. This caused
some unroll pragma is not honored in selftests/bpf.
The patch [1] test getUserCost() as the condition to
perform the certain basic block folding transformation.
For the above example, before the loop unroll pass, the control flow
looks like:
cond_block:
branch target: body_block, cleanup_block
body_block:
branch target: cleanup_block, end_block
end_block:
branch target: cleanup_block, end10_block
end10_block:
%add.ptr = getelementptr i8, i8* %payload.addr.0, i64 %call2
%inc = add nuw nsw i32 %i.0, 1
branch target: cond_block
In the above, %call2 is an unknown scalar.
Before patch [1], end10_block will be folded into end_block, forming
the code like
cond_block:
branch target: body_block, cleanup_block
body_block:
branch target: cleanup_block, end_block
end_block:
branch target: cleanup_block, cond_block
and the compiler is happy to perform unrolling.
With patch [1], getUserCost(), which calls getGEPCost(), which calls
isLegalAddressingMode() in TargetLoweringBase.cpp, considers IR
%add.ptr = getelementptr i8, i8* %payload.addr.0, i64 %call2
is free, so the above basic block folding transformation is not performed
and unrolling does not happen.
For BPF target, the IR
%add.ptr = getelementptr i8, i8* %payload.addr.0, i64 %call2
is not free and we don't have ld/st instruction address with 'r+r' mode.
This patch implemented a BPF hook for isLegalAddressingMode(), which is
identical to Mips isLegalAddressingMode() implementation where
the address pattern like 'r+r', 'r+r+i' or '2*r' are not allowed.
With testing kernel bpf selftests, all loop not unrolled warnings
are gone and all selftests run successfully.
[1] https://reviews.llvm.org/D108837
Differential Revision: https://reviews.llvm.org/D110789
Philip Reames [Thu, 30 Sep 2021 23:14:55 +0000 (16:14 -0700)]
[test] Add tests covering a missing opt in SCEV's isSCEVExprNeverPoison
Leonard Chan [Thu, 30 Sep 2021 22:34:30 +0000 (15:34 -0700)]
[libcxx][test] Use python specified by build rather than system default python
As of
e9564c3698edffc64439a8f957c7c28b19214613, libcxx/gdb/gdb_pretty_printer_test.sh.cpp
fails locally for me because the REQUIRES check for host-has-gdb-with-python
uses python, which for me expands to python 2.7.18. This failure does not seem
to be caught on any upstream builders, potentially because they don't have gdb,
python, or a version of python that makes the test UNSUPPORTED (like python3).
This updates the check to use the python specified by the build (which should
be the python that runs this code), rather than just python.
Differential Revision: https://reviews.llvm.org/D110887
Philip Reames [Thu, 30 Sep 2021 22:13:00 +0000 (15:13 -0700)]
[SCEV] Modernize code style of isSCEVExprNeverPoison [NFC]
Use for-range and all_of to make code easier to read in advance of other changes.
Teresa Johnson [Thu, 30 Sep 2021 02:14:09 +0000 (19:14 -0700)]
[MemProf] Record accesses for all words touched in mem intrinsic
Previously for mem* intrinsics we only incremented the access count for
the first word in the range. However, after thinking it through I think
it makes more sense to record an access for every word in the range.
This better matches the behavior of inlined memory intrinsics, and also
allows better analysis of utilization at a future date.
Differential Revision: https://reviews.llvm.org/D110799
Rafael Auler [Thu, 30 Sep 2021 21:35:38 +0000 (14:35 -0700)]
[MC] Fix buildbots with shared lib builds
In D109412 I forgot to add a dependency on libObject. Fix that.
Reviewed By: maksfb
Differential Revision: https://reviews.llvm.org/D110886
Amara Emerson [Thu, 30 Sep 2021 07:20:56 +0000 (00:20 -0700)]
[GlobalISel] Extend CombinerHelper::matchConstantOp() to match constant splat vectors.
This allows the "x op 0 -> x" fold to optimize vector constant RHSs.
Differential Revision: https://reviews.llvm.org/D110802
Jean Perier [Thu, 30 Sep 2021 21:16:29 +0000 (23:16 +0200)]
[flang][NFC] Add debug dump method to evaluate::Expr and semantics::Symbol
Helps debugging when working with symbol/expression issue. The dump
method is easy to call in the debugger.
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Differential Revision: https://reviews.llvm.org/D110856
Craig Topper [Thu, 30 Sep 2021 19:00:31 +0000 (12:00 -0700)]
[RISCV] Remove Zbproposedc extension
This consists of 3 compressed instructions, c.not, c.neg, and c.zext.w.
I believe these have been picked up by the Zce effort using different
encodings. I don't think it makes sense to keep them in bitmanip. It
will eventually cause a conflict if/when Zce is implemented in llvm.
Differential Revision: https://reviews.llvm.org/D110871
Jean Perier [Thu, 30 Sep 2021 21:06:22 +0000 (23:06 +0200)]
[flang] Take into account SubprogramDetails in GetInterfaceSymbol
When the ProcRef is Symbol is a SubprogramDetails, the interface is
the SubprogramDetails. Do not return nullptr.
Differential Revision: https://reviews.llvm.org/D110853
Jon Chesterfield [Thu, 30 Sep 2021 21:05:11 +0000 (22:05 +0100)]
[openmp][docs] Describe how the internal components are found
Add a FAQ entry about the names of openmp offloading components
and how they are searched for.
Reviewed By: jhuber6
Differential Revision: https://reviews.llvm.org/D109619
Jean Perier [Thu, 30 Sep 2021 21:04:03 +0000 (23:04 +0200)]
[flang][NFC] Fix header comments in some runtime headers
Differential Revision: https://reviews.llvm.org/D110850
Petr Hosek [Thu, 30 Sep 2021 20:41:57 +0000 (13:41 -0700)]
[CMake] Remove the LLD LTO check for Darwin
LLD now supports LTO on Darwin.
Differential Revision: https://reviews.llvm.org/D110881
Gwen Mittertreiner [Thu, 30 Sep 2021 20:52:51 +0000 (13:52 -0700)]
[compiler-rt] Add -fno-omit-frame-pointer check to builtins
rG210d72e9d6b4a8e7633921d0bd7186fd3c7a2c8c moved the check from
builtin-config-ix to config-ix so that the check would be made even when
the builtins are not built. However, now the check is no longer made
when the builtins are built standalone which causes the builtins to fail
to build.
Add the check back to builtins-config-ix so that the check gets
performed both when the builtins are not built, and when they are built
standalone.
Reviewed By: smeenai
Differential Revision: https://reviews.llvm.org/D110879
Jon Chesterfield [Thu, 30 Sep 2021 20:36:30 +0000 (21:36 +0100)]
[openmp] Add addrspacecast to getOrCreateIdent
Fixes 51982. Adds a missing CreatePointerCast and allocates a global in
the correct address space.
Test case derived from https://github.com/ROCm-Developer-Tools/aomp/\
blob/aomp-dev/test/smoke/nest_call_par2/nest_call_par2.c by deleting
parts while checking the assertion failure still occurred.
Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D110556
Jon Chesterfield [Thu, 30 Sep 2021 20:29:36 +0000 (21:29 +0100)]
[libomptarget] Apply D110029 to amdgpu
Use enum for execution mode.
This is partly a port from ROCm and partly a port from D110029. Attempted to
make the same choices as ROCm as far as comments etc go to reduce the merge
conflicts.
There is some cleanup warranted here - in particular I like the cuda patch
factoring out the comparisons into named variables - but I'd like to leave
that for a follow up patch, keeping this one minimal.
Reviewed By: carlo.bertolli
Differential Revision: https://reviews.llvm.org/D110845
Arnold Schwaighofer [Tue, 21 Sep 2021 18:07:07 +0000 (11:07 -0700)]
[cora async] Cleanup undefined llvm.coro.async.resume
In situations where the coroutine function is not split we can just
replace the async.resume by null.
rdar://
82591919
Differential Revision: https://reviews.llvm.org/D110191
Nicolas Vasilache [Thu, 30 Sep 2021 19:51:45 +0000 (19:51 +0000)]
[mlir][Linalg] Refactor comprehensive bufferize for external uses - NFC
This revision exposes some minimal funcitonality to allow comprehensive
bufferization to interop with external projects.
Differential Revision: https://reviews.llvm.org/D110875
Jinsong Ji [Thu, 30 Sep 2021 19:58:39 +0000 (19:58 +0000)]
[AIX] Rename binder option for PGO support
Update the binder option.
Florian Hahn [Thu, 30 Sep 2021 17:52:38 +0000 (18:52 +0100)]
Revert "Recommit "[SCEV] Look through single value PHIs." (take 2)"
This reverts commit
764d9aa97905f202385b4f25f8d234630b4feef3.
This patch exposed a few additional cases where SCEV expressions are not
properly invalidated.
See PR52024, PR52023.
Andrew Browne [Wed, 29 Sep 2021 17:07:17 +0000 (10:07 -0700)]
[DFSan] Optimize code for writing to shadow. Move SetShadow to namespace.
Writing zeros to shadow (including checking for existing zero) is now ~2x
faster on one example.
Reviewed By: morehouse
Differential Revision: https://reviews.llvm.org/D110733
LLVM GN Syncbot [Thu, 30 Sep 2021 19:35:12 +0000 (19:35 +0000)]
[gn build] Port
050edef8538e
Maksim Panchenko [Fri, 17 Sep 2021 20:24:15 +0000 (13:24 -0700)]
[MC] Make MCDwarfLineStr class public
Add MCDwarfLineStr class to the public API.
Note that MCDwarfLineTableHeader::Emit(), takes MCDwarfLineStr as
an Optional<> parameter making it impossible to use the API if the class
is not publicly defined.
Reviewed By: alexander-shaposhnikov
Differential Revision: https://reviews.llvm.org/D109412
Albion Fung [Thu, 30 Sep 2021 18:45:29 +0000 (13:45 -0500)]
[PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws
This patch removes the uneccessary mf/mtvsr generated in conjunction
with xscvdpsxws/xscvdpuxws.
Differential revision: https://reviews.llvm.org/D109902
Amara Emerson [Wed, 29 Sep 2021 22:38:59 +0000 (15:38 -0700)]
[GlobalISel] Extend G_SELECT of known condition combine to vectors.
Adds a new utility function: isConstantOrConstantSplatVector().
Differential Revision: https://reviews.llvm.org/D110786
Peter Klausler [Tue, 28 Sep 2021 16:56:38 +0000 (09:56 -0700)]
[flang] Fold FINDLOC()
Fold the transformational intrinsic function FINDLOC() for
all combinations of optional arguments and data types.
Differential Revision: https://reviews.llvm.org/D110757
Sanjay Patel [Thu, 30 Sep 2021 18:47:02 +0000 (14:47 -0400)]
[InstCombine] restrict shift-trunc-shift fold to opposite direction shifts
This is NFCI because the pattern with 2 left-shifts should get
folded independently by smaller folds.
The motivation is to refine this block to avoid infinite loops
seen with D110170.
Sanjay Patel [Thu, 30 Sep 2021 18:09:24 +0000 (14:09 -0400)]
[InstCombine] add tests for shift-trunc-shift; NFC
Nico Weber [Thu, 30 Sep 2021 18:41:58 +0000 (14:41 -0400)]
Reland "[clang-cl] Accept `#pragma warning(disable : N)` for some N"
This reverts commit
0cd9d8a48bdddb17de2c6388f9d775353f9acab9 and
adds the changes described in https://reviews.llvm.org/D110668#3034461.
Nikita Popov [Thu, 30 Sep 2021 17:09:11 +0000 (19:09 +0200)]
[BasicAA] Move more extension logic into ExtendedValue (NFC)
Add methods to appropriately extend KnownBits/ConstantRange there,
same as with APInt. Also clean up the known bits handling by
actually doing that extension rather than checking ZExtBits. This
doesn't matter now, but becomes relevant once truncation is
involved.
wren romano [Wed, 29 Sep 2021 22:01:35 +0000 (15:01 -0700)]
[mlir][sparse] Correcting a few typos
Reviewed By: aartbik
Differential Revision: https://reviews.llvm.org/D110773
Arthur Eubanks [Wed, 29 Sep 2021 01:33:26 +0000 (18:33 -0700)]
[clang] Don't modify OptRemark if the argument is not relevant
A followup to D110201.
For example, we'd set OptimizationRemarkMissed's Regex to '.*' when
encountering -Rpass. Normally this doesn't actually affect remarks we
emit because in clang::ProcessWarningOptions() we'll separately look at
all -R arguments and turn on/off corresponding diagnostic groups.
However, this is reproducible with -round-trip-args.
Reviewed By: JamesNagurne
Differential Revision: https://reviews.llvm.org/D110673
peter klausler [Tue, 28 Sep 2021 22:43:27 +0000 (15:43 -0700)]
[flang] Fix test regression from SQRT folding
The algorithm used to fold SQRT has some holes that
led to test failures; debug and add more tests.
Differential Revision: https://reviews.llvm.org/D110744
Nico Weber [Wed, 29 Sep 2021 22:46:24 +0000 (18:46 -0400)]
[clang] Make crash reproducer work with clang-cl
When clang crashes, it writes a standalone source file and shell script
to reproduce the crash.
The Driver used to set `Mode = CPPMode` in generateCompilationDiagnostics()
to force preprocessing mode. This has the side effect of making
IsCLMode() return false, which in turn meant Clang::AddClangCLArgs()
didn't get called when creating the standalone source file, which meant
the stand-alone file was preprocessed with the gcc driver's defaults
In particular, exceptions default to on with the gcc driver, but to
off with the cl driver. The .sh script did use the original command
line, so in the reproducer for a clang-cl crash, the standalone source
file could contain exception-using code after preprocessing that the
compiler invocation in the shell script would then complain about.
This patch removes the `Mode = CPPMode;` line and instead additionally
checks for `CCGenDiagnostics` in most places that check `CCCIsCPP().
This also matches the strategy Clang::ConstructJob() uses to add
-frewrite-includes for creating the standalone source file for a crash
report.
Fixes PR52007.
Differential Revision: https://reviews.llvm.org/D110783
Zequan Wu [Wed, 29 Sep 2021 22:00:39 +0000 (15:00 -0700)]
[clang] do not emit note for bad conversion when destination type qualifiers are not compatibly include source type qualifiers
llvm.org/PR52014
Differential Revision: https://reviews.llvm.org/D110780
Nico Weber [Wed, 29 Sep 2021 19:19:36 +0000 (15:19 -0400)]
[clang] Remove duplication in types::getCompilationPhases()
Call Driver::getFinalPhase() instead of duplicating it.
https://reviews.llvm.org/D65993 added the duplication, then
02e35832c301e maded it more obviously a copy of getFinalPhase().
The only difference is that getCompilationPhases() used to use
LastPhase / IfsMerge where getFinalPhase() used Link. Adapt
getFinalPhase() to return IfsMerge when needed.
No intentional behavior change.
Differential Revision: https://reviews.llvm.org/D110770
Louis Dionne [Thu, 30 Sep 2021 17:29:12 +0000 (13:29 -0400)]
[libc++abi][NFCI] Consistently group new_handler, unexpected_handler and terminate_handler
Previously, the definitions of __cxa_terminate_handler and __cxa_unexpected_handler
(and their set_xxx_handler functions) were grouped together, but the
definition of __cxa_new_handler wasn't. This commit simply moves those
to the same file to treat all handlers consistently.
Haowei Wu [Thu, 30 Sep 2021 18:03:59 +0000 (11:03 -0700)]
Revert "[libc++][libc++abi] Add tests for vendor-specific properties"
This reverts commit
9892d1644f62cf8f5133ee0d2ebafb56f6500cc1, which
causes clang test failures in libcxx tests.
peter klausler [Thu, 23 Sep 2021 23:36:04 +0000 (16:36 -0700)]
[flang] Front-end and runtime support for CALL EXIT and ABORT
Support the extension intrinsic subroutines EXIT([status]) and ABORT()
in the intrinsic table and runtime support library. Lowering remains
to be done.
Differential Revision: https://reviews.llvm.org/D110741
Lei Zhang [Thu, 30 Sep 2021 17:50:44 +0000 (13:50 -0400)]
[mlir][linalg] Fix incorrect bound calculation for tiling conv
For convolution, the input window dimension's access affine map
is of the form `(d0 * s0 + d1)`, where `d0`/`d1` is the output/
filter window dimension, and `s0` is the stride.
When tiling, https://reviews.llvm.org/D109267 changed how the
way dimensions are acquired. Instead of directly querying using
`*.dim` ops on the original convolution op, we now get it by
applying the access affine map to the loop upper bounds. This
is fine for dimensions having single-dimension affine maps,
like matmul, but not for convolution input. It will cause
incorrect compuation and out of bound. A concrete example, say
we have 1x225x225x3 (NHWC) input, 3x3x3x32 (HWCF) filter, and
1x112x112x3 (NHWC) output with stride 2, (112 * 2 + 3) would be
227, which is different from the correct input window dimension
size 225.
Instead, we should first calculate the max indices for each loop,
and apply the affine map to them, and then plus one to get the
dimension size. Note this makes no difference for matmul-like
ops given they will have `d0 - 1 + 1` effectively.
Reviewed By: nicolasvasilache
Differential Revision: https://reviews.llvm.org/D110849
Jonas Devlieghere [Thu, 30 Sep 2021 05:32:21 +0000 (22:32 -0700)]
[lldb] Remove support for replaying the test suite from a reproducer
This patch removes the infrastructure to replay the test suite from a
reproducer, as well as the modifications made to the individual tests.
Stanislav Mekhanoshin [Wed, 29 Sep 2021 19:43:12 +0000 (12:43 -0700)]
[AMDGPU] move hasAGPRs/hasVGPRs into header
It is now very simple and can go right into the header
allowing optimizer to combine callers, such as isVGPRClass
and similar.
It does not need anything from the TRI itself anymore, so
make it static class member along with the callers.
Differential Revision: https://reviews.llvm.org/D110762
Arthur Eubanks [Wed, 29 Sep 2021 23:04:39 +0000 (16:04 -0700)]
Manually create unique_ptr in various pass adaptors
This avoids creating tons of make_unique template instantiations. And we
only create a unique_ptr of the actual pass concept type, rather than
creating a unique_ptr of the pass model subclass then casting it to the
pass concept type.
This reduces the work spent compiling PassBuilder.cpp from 83M -> 73M
instructions according to perf stat.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D110784
Nikita Popov [Thu, 30 Sep 2021 16:18:15 +0000 (18:18 +0200)]
[BasicAA] Use ExtendedValue in VariableGEPIndex (NFC)
Use the ExtendedValue structure which is used for LinearExpression
in VariableGEPIndex as well.
Arthur Eubanks [Wed, 29 Sep 2021 19:12:03 +0000 (12:12 -0700)]
Instantiate fewer templates in PassManager::addPass()
We create many instantiations of PassManager::addPass() in
PassBuilder.cpp. vector::emplace_back() and make_unique() are both
templated and would have many instantiations based on the number of
times we instantiate addPass(). Now we directly construct the
unique_ptr with the type as the actual unique_ptr type in the vector we
are adding it to, so we only have one unique_ptr constructor
instantiation across all addPass() instantiations and only the
non-templated push_back().
This makes PassBuilder.cpp slightly faster to build.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D110775
Craig Topper [Wed, 29 Sep 2021 17:21:44 +0000 (10:21 -0700)]
[CostModel] Update default cost model for sadd/ssub overflow to match TargetLowering
The expansion for these was updated in https://reviews.llvm.org/D47927 but the cost model was not adjusted.
I believe the cost model was also incorrect for the old expansion.
The expansion prior to D47927 used 3 icmps using LHS, RHS, and Result
to calculate theirs signs. Then 2 icmps to compare the signs. Followed
by an And. The previous cost model was using 3 icmps and 2 selects.
Digging back through git blame, those 2 selects in the cost model used to
be 2 icmps, but were changed in https://reviews.llvm.org/D90681
Differential Revision: https://reviews.llvm.org/D110739
Stella Laurenzo [Wed, 29 Sep 2021 23:47:17 +0000 (23:47 +0000)]
[mlir] Remove old "tc" linalg ods generator.
* This could have been removed some time ago as it only had one op left in it, which is redundant with the new approach.
* `matmul_i8_i8_i32` (the remaining op) can be trivially replaced by `matmul`, which natively supports mixed precision.
Differential Revision: https://reviews.llvm.org/D110792
Adrian Prantl [Mon, 27 Sep 2021 17:51:04 +0000 (10:51 -0700)]
Improve the effectiveness of BDCE's debug info salvaging
This patch improves the effectiveness of BDCE's debug info salvaging
by processing the instructions in reverse order and delaying
dropAllReferences until after debug info salvaging. This allows
salvaging of entire chains of deleted instructions!
Previously we would remove all references from an instruction, which
would make it impossible to use that instruction to salvage a later
instruction in the instruction stream, because its operands were
already removed.
This reapplies the previous patch with a fix for a use-after-free.
Differential Revision: https://reviews.llvm.org/D110568
Louis Dionne [Thu, 30 Sep 2021 16:18:30 +0000 (12:18 -0400)]
[libc++][NFC] Remove stray whitespace
Eric Schweitz [Thu, 30 Sep 2021 15:55:31 +0000 (17:55 +0200)]
[fir][NFC] Rename lenParams to typeparams in builders
Fine tuning after couple of upstreamed patches.
Rename the lenParams varaiables in buidlers to typeparams.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D110821
Co-authored-by: Valentin Clement <clementval@gmail.com>
Kazu Hirata [Thu, 30 Sep 2021 15:51:21 +0000 (08:51 -0700)]
[llvm] Migrate from arg_operands to args (NFC)
Note that arg_operands is considered a legacy name. See
llvm/include/llvm/IR/InstrTypes.h for details.
Daniil Fukalov [Thu, 30 Sep 2021 15:13:17 +0000 (18:13 +0300)]
[NFC][AMDGPU] Improve cost model tests coverage.
Florian Mayer [Wed, 29 Sep 2021 23:57:57 +0000 (00:57 +0100)]
[NFC] [hwasan] Remove unneeded member.
Reviewed By: hctim
Differential Revision: https://reviews.llvm.org/D110791
Sanjay Patel [Thu, 30 Sep 2021 14:34:29 +0000 (10:34 -0400)]
[x86] add test for 3 fcmps and logic; NFC
This is a more complex pattern than we handled with the
initial patch for PR51245:
D110342 /
09e71c367af3
We could extend the logic matching to allow a setcc as
one operand and an extract of vector setcc (or even an
arbitrary bool?) as the other.
Kiran Chandramohan [Thu, 30 Sep 2021 15:00:17 +0000 (17:00 +0200)]
[fir] Update fir.alloca op
Add pinned attributes and speicifc builders.
The pinned attribute helps mark those allocas in OpenMP regions that should not
be hoisted out by an alloca hoisting pass.
This patch is part of the upstreaming effort from fir-dev branch.
Coming from PR: https://github.com/flang-compiler/f18-llvm-project/pull/1065
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D110815
Co-authored-by: Valentin Clement <clementval@gmail.com>
Louis Dionne [Wed, 29 Sep 2021 18:56:42 +0000 (14:56 -0400)]
[libc++] Add a testing configuration specific to Apple's libc++
Apple's libc++ has a few differences with the LLVM libc++, and it is
necessary to use a custom configuration file to test it properly.
Differential Revision: https://reviews.llvm.org/D110777
Valentin Clement [Thu, 30 Sep 2021 14:45:46 +0000 (16:45 +0200)]
[fir][NFC] Removed unused declaration from td file
Remove unused code from FIROps.td file after latest
patches.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D110814
Kirill Bobyrev [Thu, 30 Sep 2021 14:45:10 +0000 (16:45 +0200)]
Anna Thomas [Thu, 30 Sep 2021 14:37:18 +0000 (10:37 -0400)]
[LoopPredication] Remove unused variable
After rG452714f8f8037ff37f9358317651d1652e231db2, the Function `F` retrieved in LoopPredication is not used.
Remove this unused variable to stop some buildbots (ASAN, clang-ppc) from failing.
Roman Lebedev [Thu, 30 Sep 2021 14:30:57 +0000 (17:30 +0300)]
[NFC][X86][Codegen] Add test coverage for interleaved i64 load/store stride=2
Roman Lebedev [Thu, 30 Sep 2021 14:14:16 +0000 (17:14 +0300)]
[NFC][X86][LV] Add costmodel test coverage for interleaved i64/f64 load/store stride=2
Jakub Kuderski [Thu, 30 Sep 2021 14:28:10 +0000 (10:28 -0400)]
[NFC] Improve file-level documentation for Sequence.h
Add usage samples.
This was extracted from a bigger patch: https://reviews.llvm.org/D107378.
Reviewed By: aaron.ballman, gchatelet
Differential Revision: https://reviews.llvm.org/D110760
Valentin Clement [Thu, 30 Sep 2021 14:27:02 +0000 (16:27 +0200)]
[fir][NFC] Move parser/printer for fir.global_len
Move parser and printer to the .cpp file.
Follow up to https://reviews.llvm.org/D110626.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D110828
Anna Thomas [Fri, 24 Sep 2021 18:38:41 +0000 (14:38 -0400)]
[BPI] Keep BPI available in loop passes through LoopStandardAnalysisResults
This is analogous to D86156 (which preserves "lossy" BFI in loop
passes). Lossy means that the analysis preserved may not be up to date
with regards to new blocks that are added in loop passes, but BPI will
not contain stale pointers to basic blocks that are deleted by the loop
passes.
This is achieved through BasicBlockCallbackVH in BPI, which calls
eraseBlock that updates the data structures in BPI whenever a basic
block is deleted.
This patch does not have any changes in the upstream pipeline, since
none of the loop passes in the pipeline use BPI currently.
However, since BPI wasn't previously preserved in loop passes, the loop
predication pass was invoking BPI *on the entire
function* every time it ran in an LPM. This caused massive compile time
in our downstream LPM invocation which contained loop predication.
See updated test with an invocation of a loop-pipeline containing loop
predication and -debug-pass turned ON.
Reviewed-By: asbirlea, modimo
Differential Revision: https://reviews.llvm.org/D110438
Valentin Clement [Thu, 30 Sep 2021 14:26:29 +0000 (16:26 +0200)]
[fir][NFC] Move fir.shape verifier to cpp file
Move verifier code to the .cpp file.
Follow up to https://reviews.llvm.org/D110626.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D110826
Valentin Clement [Thu, 30 Sep 2021 14:25:21 +0000 (16:25 +0200)]
[fir][NFC] Update and move fir.freemem and fir.store
Move fir.freemem and fir.store to the Memory SSA operations sections.
Move parser, printer and verifier of fir.store to the .cpp file.
This patch is part of the upstreaming effort from fir-dev branch.
Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
Reviewed By: jeanPerier
Differential Revision: https://reviews.llvm.org/D110816
Alex Zinenko [Thu, 30 Sep 2021 13:09:30 +0000 (15:09 +0200)]
[mlir][python] provide bindings for ops from the sparse_tensor dialect
Previously, the dialect was exposed for linking and pass management purposes,
but we did not generate op classes for it. Generate them.
Reviewed By: nicolasvasilache
Differential Revision: https://reviews.llvm.org/D110819
David Green [Thu, 30 Sep 2021 13:41:23 +0000 (14:41 +0100)]
[ARM] Add more MVE intrinsics to sink splats to
This adds a few more unpredicated intrinsics to sink splats to, in order
to create more qr instruction variants. Notably this includes
saddsat/uaddsat but also some of the unpredicated mve intrinsics.
Differential Revision: https://reviews.llvm.org/D110333
Brock Wyma [Wed, 22 Sep 2021 23:41:05 +0000 (19:41 -0400)]
[CodeView] Recognize Fortran95 as Fortran instead of MASM
Map Fortran95 sources to Fortran so the CodeView language is not emitted as
MASM.
Differential Revision: https://reviews.llvm.org/D110330
Guillaume Chatelet [Thu, 30 Sep 2021 13:10:45 +0000 (13:10 +0000)]
[libc] move benchmark function registration to a different file
Kirill Bobyrev [Thu, 30 Sep 2021 12:41:27 +0000 (14:41 +0200)]
[clangd] Land D110386 again
This time, use llvm::sys::fs::UniqueID instead of unstable
FileEntry::getName(), this should solve the problems on Windows and
elsewhere.
Adrian Kuegel [Thu, 30 Sep 2021 11:50:31 +0000 (13:50 +0200)]
[mlir] Remove unused namespace alias.
Roman Lebedev [Thu, 30 Sep 2021 11:24:42 +0000 (14:24 +0300)]
[NFC][Costmodel][LV][X86] Add test coverage for f32 interleaved load/store stride=2
Amara Emerson [Thu, 30 Sep 2021 11:15:30 +0000 (04:15 -0700)]
[AArch64][GlobalISel] Re-generate some tests for D110802.
Nemanja Ivanovic [Thu, 30 Sep 2021 02:28:38 +0000 (21:28 -0500)]
[PowerPC] Truncate element index for vec_insert in altivec.h
When a user specifies an out-of-range index for vec_insert, we
just produce IR that has undefined behaviour even though the
documentation states that modulo arithmetic is used. This patch
just truncates the value to a valid index.
Valentin Clement [Thu, 30 Sep 2021 10:51:14 +0000 (12:51 +0200)]
[fir] Update fir.field_index op
Move the parser, printer, verifier and builder out of the .td file.
Rename lenparams to typeparams to be in sync with fir-dev.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: rovka
Differential Revision: https://reviews.llvm.org/D110690
Balazs Benics [Thu, 30 Sep 2021 09:53:08 +0000 (11:53 +0200)]
[NFC] Cleanup the overload of ASTImporter::import()
This patch aims to address the comment of a previous review:
https://reviews.llvm.org/D109237#inline-1040678
The original problem was the following:
`T` is substituted by `clang::Type`
Expected<T *> import(T *From) {
auto ToOrErr = Importer.Import(From);
// ^^^^^^^^^^^^^^^^^^^^^
if (!ToOrErr)
return ToOrErr.takeError();
return cast_or_null<T>(*ToOrErr);
// ^^^^^^^^^^^^^^^^^^^^^^^^^
}
`Importer.Import()` operates on `const Type *`, thus returns `const Type *`.
Later, at the return statement, we will try to construct an `Expected<Type*>`
from a `const Type *`, which failed with a miserable error message.
In all other cases `importer.Import()` results in a non-const version,
so everything works out just fine, but for `clang::type`s, we should
really return a const version.
So, in case of `T` is a subclass of `clang::Type`, it will return a
`Exprected<const T*>` instead.
Reviewed By: martong
Differential Revision: https://reviews.llvm.org/D109269
Kirill Bobyrev [Thu, 30 Sep 2021 09:36:34 +0000 (11:36 +0200)]
Valentin Clement [Thu, 30 Sep 2021 09:17:46 +0000 (11:17 +0200)]
[fir][NFC] Move parser/printer/builder to cpp file
Move the parsers, printers and builders from the TableGen file
to the .cpp file. Remaining parsers, printers and builders will be
moved when we update the operations.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: schweitz
Differential Revision: https://reviews.llvm.org/D110626
Eric Schweitz [Thu, 30 Sep 2021 09:04:02 +0000 (11:04 +0200)]
[fir] Update fir.alloca op
Update the fir.alloca operation.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: mehdi_amini
Differential Revision: https://reviews.llvm.org/D110415
Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Valentin Clement <clementval@gmail.com>
Valentin Clement [Thu, 30 Sep 2021 08:57:37 +0000 (10:57 +0200)]
[fir] Update fir.allocmem op
Updatet the fir.allocmem operation.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: schweitz
Differential Revision: https://reviews.llvm.org/D110412
Co-authored-by: Eric Schweitz <eschweitz@nvidia.com>
LLVM GN Syncbot [Thu, 30 Sep 2021 08:28:24 +0000 (08:28 +0000)]
[gn build] Port
13f3c39f3658
Jingu Kang [Wed, 29 Sep 2021 01:42:21 +0000 (02:42 +0100)]
Second Recommit "[AArch64] Split bitmask immediate of bitwise AND operation"
This reverts the revert commit
c07f7099690e8607d119227db1f80ee21eff3a3b with
bug fixes.
Differential Revision: https://reviews.llvm.org/D109963
Eric Schweitz [Thu, 30 Sep 2021 08:22:16 +0000 (10:22 +0200)]
[fir] Update fir.extract_value and fir.insert_value ops
Move coor operand from variadic values to ArrayAttr.
Update assembly format.
This patch is part of the upstreaming effort from fir-dev branch.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D110652
Co-authored-by: Jean Perier <jperier@nvidia.com>
Co-authored-by: Valentin Clement <clementval@gmail.com>
Jay Foad [Mon, 27 Sep 2021 10:44:18 +0000 (11:44 +0100)]
[LiveIntervals] Remove unused subreg ranges in repairIntervalsInRange
If the old instructions mentioned a subreg that the new instructions do
not, remove the subrange for that subreg.
For example, in TwoAddressInstructionPass::eliminateRegSequence, if a
use operand in the REG_SEQUENCE has the undef flag then we don't
generate a copy for it so after the elimination there should be no live
interval at all for the corresponding subreg of the def.
This is a small step towards switching TwoAddressInstructionPass over
from LiveVariables to LiveIntervals. Currently this path is only tested
if you explicitly enable -early-live-intervals.
Differential Revision: https://reviews.llvm.org/D110542
Eric Schweitz [Thu, 30 Sep 2021 07:55:45 +0000 (09:55 +0200)]
[fir] Update fir.array_update, fir.array_fetch and fir.array_merge_store
Add typeparams to fir.array_update, fir.array_fetch and
fir.array_merge_store operations. Add optional slice operands to
fir.array_merge_store op.
Move verifiers to cpp file.
Reviewed By: kiranchandramohan
Differential Revision: https://reviews.llvm.org/D110701
Co-authored-by: Valentin Clement <clementval@gmail.com>
Kirill Bobyrev [Thu, 30 Sep 2021 07:52:37 +0000 (09:52 +0200)]
Andrzej Warzynski [Thu, 30 Sep 2021 07:49:15 +0000 (07:49 +0000)]
[flang][docs] Remove the new driver sync-up calls