yunchao.he [Tue, 29 Jul 2014 02:18:49 +0000 (19:18 -0700)]
round and bevel hairline rects show the same as miter hairline rects
So round and bevel hairline rects can generate the vertices and indices the same as miter rects do. The original code behaves the same as bevel rects for round and bevel hairline rects.
This small CL can save (vertices and indices) buffer memory as well as improve performance (draw less triangles).
gm cases show no difference after this CL is applied.
BUG=skia:
R=robertphillips@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
417113002
cdalton [Mon, 28 Jul 2014 22:39:05 +0000 (15:39 -0700)]
Rebaseline needed nvpr gms after text change
Updates a few nvpr expectations for slight pixel diffs after a change
in the math that positions glyphs.
BUG=skia:
R=jvanverth@google.com, bungeman@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
421423002
krajcevski [Mon, 28 Jul 2014 21:14:16 +0000 (14:14 -0700)]
Generalize compressed blitter into its own templated class
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
421593004
bsalomon [Mon, 28 Jul 2014 20:48:36 +0000 (13:48 -0700)]
Test abandoning GL context in dm/nanobench.
Rename GrContext::contextDestroyed to GrContext::abandonContext.
Remove GrContext::resetContext.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
422903002
bsalomon [Mon, 28 Jul 2014 20:43:02 +0000 (13:43 -0700)]
Revert of Remove relative path to GrColor.h in SkShader.h (https://codereview.chromium.org/
422023005/)
Reason for revert:
As Ben suspected, this breaks the chrome build.
Original issue's description:
> Remove relative path to GrColor.h in SkShader.h
>
> Committed: https://skia.googlesource.com/skia/+/
939f430f660d26e46116a38d2a8436afbd55dfb9
R=bungeman@google.com, george@mozilla.com
TBR=bungeman@google.com, george@mozilla.com
NOTREECHECKS=true
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
423943005
bsalomon [Mon, 28 Jul 2014 20:27:35 +0000 (13:27 -0700)]
Remove relative path to GrColor.h in SkShader.h
R=bungeman@google.com, george@mozilla.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
422023005
halcanary [Mon, 28 Jul 2014 17:54:26 +0000 (10:54 -0700)]
disable new test on windows
R=bensong@google.com, djsollen@google.com
TBR=bensong@google.com, djsollen@google.com
CQ_EXTRA_TRYBOTS=tryserver.skia:Test-Win7-ShuttleA-HD2000-x86_64-Release-Trybot
NOTREECHECKS=true
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
424833002
halcanary [Mon, 28 Jul 2014 15:56:35 +0000 (08:56 -0700)]
If decoder doesn't ouput indexed color, don't check colortable
R=djsollen@google.com, bungeman@google.com
TBR=bungeman@google.com, djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
427593002
halcanary [Mon, 28 Jul 2014 15:23:55 +0000 (08:23 -0700)]
SkDiscardablePixelRef returns correct indexed color on relock.
R=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
428603002
bungeman [Mon, 28 Jul 2014 15:19:45 +0000 (08:19 -0700)]
Only lowercase names in Android font config parser.
BUG=chromium:397549
R=tomhudson@chromium.org, tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
420223003
djsollen [Mon, 28 Jul 2014 14:44:55 +0000 (07:44 -0700)]
Remove code only used by SkCreateTypefaceForScript which has already been deleted
R=tomhudson@google.com, bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
425753002
halcanary [Mon, 28 Jul 2014 14:21:24 +0000 (07:21 -0700)]
dm prints out number of matching skp files
R=bungeman@google.com, mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
421713002
Derek Sollenberger [Mon, 28 Jul 2014 14:04:55 +0000 (10:04 -0400)]
Remove redundant helper function as all clients pass locale
R=tomhudson@google.com
Review URL: https://codereview.chromium.org/
426643003
Derek Sollenberger [Mon, 28 Jul 2014 13:54:10 +0000 (09:54 -0400)]
Remove unused code now that the android framework has move this logic elsewhere.
R=tomhudson@google.com
Review URL: https://codereview.chromium.org/
424663005
borenet [Sun, 27 Jul 2014 05:45:10 +0000 (22:45 -0700)]
Update SKP version to 60
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
420133002
borenet [Sat, 26 Jul 2014 07:32:37 +0000 (00:32 -0700)]
Update SKP version to 59
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
422643002
jvanverth [Sat, 26 Jul 2014 02:03:34 +0000 (19:03 -0700)]
Add vertex color support to distance field text.
BUG=skia:
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
421563002
jvanverth [Fri, 25 Jul 2014 23:46:53 +0000 (16:46 -0700)]
Move vertex buffer setup out of drawPackedGlyph().
This gets a very welcome ~10% speedup on my Mac.
Committed: https://skia.googlesource.com/skia/+/
1d38619389cc1100bd516b9acbf17b7bd42d33ce
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
414573002
bungeman [Fri, 25 Jul 2014 22:11:03 +0000 (15:11 -0700)]
Fix thread unsafe mutex initialization.
BUG=skia:2779
Committed: https://skia.googlesource.com/skia/+/
d6aeb6dc8fe21066f1a2c4813a4256a3acd3edf5
R=robertphillips@google.com, mtklein@google.com, reed@android.com, bsalomon@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
419113002
halcanary [Fri, 25 Jul 2014 21:17:35 +0000 (14:17 -0700)]
Fix crash in DM/SKPTask
R=bungeman@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
416333007
cdalton [Fri, 25 Jul 2014 21:13:57 +0000 (14:13 -0700)]
Send less transform data when drawing text with nvpr
Before this change, GrStencilAndCoverTextContext would send 6-float
affine transforms to drawPaths for every glyph. This updates it to
concat the text scale onto the context matrix, and then only send
2-float translates (or 1-float x-translates when possible).
Also adds a glyph_pos_align test to gm that exercises the newly added
codepaths, and starts ignoring a few gm tests with benign pixel diffs
until we can rebaseline.
BUG=skia:
R=bsalomon@google.com, kkinnunen@nvidia.com, jvanverth@google.com, bungeman@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
406523003
scroggo [Fri, 25 Jul 2014 20:54:43 +0000 (13:54 -0700)]
Fix image decoder memory overwrite bug.
In SkPNGImageDecoder::onDecodeSubset, use png_read_rows to write to
the scratch memory provided. This is what we should have been doing
anyway. Further, writing directly to the bitmap can cause writing
to the wrong memory since the bitmap may not be as big as the
scratch memory in the case of sampling with a short bitmap.
Bug=b/
13921093
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
423473003
bungeman [Fri, 25 Jul 2014 18:52:47 +0000 (11:52 -0700)]
Fix thread unsafe mutex initialization.
BUG=skia:2779
R=robertphillips@google.com, mtklein@google.com, reed@android.com, bsalomon@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
419113002
jvanverth [Fri, 25 Jul 2014 18:52:16 +0000 (11:52 -0700)]
Revert of Move vertex buffer setup out of drawPackedGlyph(). (https://codereview.chromium.org/
414573002/)
Reason for revert:
Breaking Ubuntu and Windows bots.
Original issue's description:
> Move vertex buffer setup out of drawPackedGlyph().
>
> This gets a very welcome ~10% speedup on my Mac.
>
> Committed: https://skia.googlesource.com/skia/+/
1d38619389cc1100bd516b9acbf17b7bd42d33ce
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
419943002
jvanverth [Fri, 25 Jul 2014 18:31:13 +0000 (11:31 -0700)]
Move vertex buffer setup out of drawPackedGlyph().
This gets a very welcome ~10% speedup on my Mac.
R=bsalomon@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
414573002
dandov [Fri, 25 Jul 2014 17:44:53 +0000 (10:44 -0700)]
Added classes SkPatch and SkPatchMesh which help encapsulate and generalize this new primitive. The functionality and responsability of each class is better explained in the comments of the files.
Each patch defines a method genMesh that produces the geometry to draw. To do this they receive a SkPatchMesh object which they need to initialize in order to set up how the data is going to be formatted. Later they call function like setColor or pointAt to set the values at a specific index, the SkMeshPatch object handles the indices based on the format and makes it transparent to the client.
Added a slide to sample app to show how to set up this classes and how they interact.
BUG=skia:
R=jvanverth@google.com, egdaniel@google.com, bsalomon@google.com
Author: dandov@google.com
Review URL: https://codereview.chromium.org/
405163003
scroggo [Fri, 25 Jul 2014 17:26:32 +0000 (10:26 -0700)]
Fix assert in skimage test.
The width and height may not match expected width and height when
sampleSize is not 1.
R=djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
418363002
krajcevski [Fri, 25 Jul 2014 17:23:42 +0000 (10:23 -0700)]
Some small ASTC optimizations
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
417123003
bsalomon [Fri, 25 Jul 2014 15:35:45 +0000 (08:35 -0700)]
Rename GrGpuObject to GrGpuResource
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
418143004
kelvinly [Fri, 25 Jul 2014 15:30:11 +0000 (08:30 -0700)]
Fix the other microbench schema
BUG=skia:
R=bensong@google.com, jcgregorio@google.com
Author: kelvinly@google.com
Review URL: https://codereview.chromium.org/
420723004
krajcevski [Fri, 25 Jul 2014 14:33:01 +0000 (07:33 -0700)]
Add preliminary ASTC encoder
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
417933005
bsalomon [Fri, 25 Jul 2014 14:32:33 +0000 (07:32 -0700)]
Merge GrGpuObject and GrCacheable.
We want to create a new base class for "meta" gr resources as part of the GrResourceCache rewrite and this is an iterim step towards that goal.s
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
414013005
robertphillips [Fri, 25 Jul 2014 12:52:38 +0000 (05:52 -0700)]
Alter Default & Software path renderers to better handle AA hairline paths
For some (as yet unknown reason) the guard in ConicPathBench that disables the path_hairline_big_AA_conic case isn't working. As an alternate fix, this CL makes the Default path renderer confess its lack of support for conics and allows the Software path renderer to handle non-AA cases. This will work but the real fix is to enable conics in the Default path renderer.
Here is the situation we're seeing in the path_hairline_big_AA_conic case:
the path is a hairline drawn with AA
the render target is multisampled (so AA on the draw gets disabled)
StencilAndCover path renderer doesn't handle hairlines
AAHairLine path renderer only handles AA paths (but can handle conics)
AAConvexPath renderer also only handles AA paths
Default path renderer only handles non-AA paths (but doesn't handle conics)
Software path renderer - was disallowed from handling non-AA paths
BUG=skia:2078
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
418073002
robertphillips [Fri, 25 Jul 2014 11:34:40 +0000 (04:34 -0700)]
Rebaseline GN & N4 perf trigger flakes
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
419683005
borenet [Fri, 25 Jul 2014 05:58:07 +0000 (22:58 -0700)]
Update SKP version to 58
Automatic commit by the RecreateSKPs bot.
TBR=
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
420693002
Brian Salomon [Thu, 24 Jul 2014 21:23:44 +0000 (17:23 -0400)]
Add initial baselines for varied_text* GMs
Review URL: https://codereview.chromium.org/
416983002
djsollen [Thu, 24 Jul 2014 20:53:56 +0000 (13:53 -0700)]
Enable the SSSE3 compile time check on all platforms (4th attempt)
BUG=skia:2746
R=bungeman@google.com, robertphillips@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
414033002
epoger [Thu, 24 Jul 2014 18:46:47 +0000 (11:46 -0700)]
check in empty SKP expectations for a single platform
This should trigger the http://108.170.220.120:10117/builders/Test-Mac10.8-MacMini4.1-GeForce320M-x86_64-Debug
to start recording images from the SKPs.
BUG=skia:1942
NOTRY=True
R=rmistry@google.com
TBR=rmistry
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
410423006
epoger [Thu, 24 Jul 2014 17:39:01 +0000 (10:39 -0700)]
roll common DEPS
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
411063006
krajcevski [Thu, 24 Jul 2014 15:16:00 +0000 (08:16 -0700)]
Add ASTC to list of alpha compressed formats
R=bsalomon@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
412113004
bungeman [Thu, 24 Jul 2014 15:05:09 +0000 (08:05 -0700)]
SkFontMgr for Android.
Committed: https://skia.googlesource.com/skia/+/
4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06
R=djsollen@google.com, tomhudson@google.com, robertphillips@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
414483002
scroggo [Thu, 24 Jul 2014 13:55:31 +0000 (06:55 -0700)]
skimage expectations for Android-Reference-Unknown
Fixes build.
NOTRY=true
R=borenet@google.com, robertphillips@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
416083002
robertphillips [Thu, 24 Jul 2014 12:30:39 +0000 (05:30 -0700)]
Suppress Win8 raster verylargebitmap GM flakes
BUG=skia:2775
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
418863003
bungeman [Wed, 23 Jul 2014 20:31:06 +0000 (13:31 -0700)]
Get additional DW font metrics when available.
BUG=chromium:395043
R=eae@chromium.org, caryclark@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
412993002
bungeman [Wed, 23 Jul 2014 18:28:18 +0000 (11:28 -0700)]
Revert of Enable the SSSE3 compile time check on all platforms. (https://codereview.chromium.org/
403583002/)
Reason for revert:
This is blocking the roll. Chromium Windows trybots (like win_chromium_x64_rel) are crashing in the SSSE3 code (for example SkCanvasVideoRenderTest.CroppedFrame).
Original issue's description:
> Enable the SSSE3 compile time check on all platforms (3rd attempt)
>
> BUG=skia:2746
>
> Committed: https://skia.googlesource.com/skia/+/
933834851f9d48fbd85b728cc92e1f0134bfaa4e
R=halcanary@google.com, mtklein@google.com, djsollen@google.com
TBR=djsollen@google.com, halcanary@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2746
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
418523002
robertphillips [Wed, 23 Jul 2014 11:55:09 +0000 (04:55 -0700)]
Fix some flaky perf triggers
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
416483002
robertphillips [Tue, 22 Jul 2014 23:36:13 +0000 (16:36 -0700)]
Revert of SkFontMgr for Android. (https://codereview.chromium.org/
414483002/)
Reason for revert:
Reverting to unblock DEPS roll.
Original issue's description:
> SkFontMgr for Android.
>
> Committed: https://skia.googlesource.com/skia/+/
4f9a01e03ef3bbe7dd8f9bebdcb3555226087e06
R=djsollen@google.com, tomhudson@google.com, bungeman@google.com
TBR=bungeman@google.com, djsollen@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
408143010
robertphillips [Tue, 22 Jul 2014 23:34:37 +0000 (16:34 -0700)]
Revert "Update fontmgr expectations."
This reverts commit
ff4b56b2d52b0e0042d8b2201fd125a6258dd791.
R=bungeman@gmail.com
TBR=bungeman@gmail.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
406323004
bungeman [Tue, 22 Jul 2014 22:21:24 +0000 (18:21 -0400)]
Update fontmgr expectations.
piotaixr [Tue, 22 Jul 2014 22:02:05 +0000 (15:02 -0700)]
Now able to set the localMatrix when creating a SkShader from a SkImage
BUG=skia:2771
R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, bsalomon@google.com
Author: piotaixr@chromium.org
Review URL: https://codereview.chromium.org/
409653003
djsollen [Tue, 22 Jul 2014 20:56:34 +0000 (13:56 -0700)]
fix android_framework build do to missing library at link time
R=scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
407073006
jvanverth [Tue, 22 Jul 2014 20:25:26 +0000 (13:25 -0700)]
Replace use of GrTHashTable in GrFontCache with SkTDynamicHash.
Searching the font cache for existing text strikes was showing up
as a hotspot on Android. This change reduces that cost.
R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com
Author: jvanverth@google.com
Review URL: https://codereview.chromium.org/
390103002
bsalomon [Tue, 22 Jul 2014 20:09:46 +0000 (13:09 -0700)]
Revert "Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… (https://codereview.chromium.org/
376703009/)"
This reverts commit
249171e7d29b5559f3eefe9dbd437030bfad3fda.
Uses 32 bit id instead of 64. Renamed instanceID to uniqueID to match existing code.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
414493002
bsalomon [Tue, 22 Jul 2014 20:09:05 +0000 (13:09 -0700)]
Make nanobench setup configs outside of loop over benchmarks
R=mtklein@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
410683005
bungeman [Tue, 22 Jul 2014 20:02:58 +0000 (16:02 -0400)]
Suppress fontmgr gm changes while Android catches up.
senorblanco [Tue, 22 Jul 2014 19:49:25 +0000 (12:49 -0700)]
Remove the single-sigma version of SkDropShadowImageFilter::Create().
It's no longer used in Chrome.
BUG=skia:
R=bsalomon@google.com
Author: senorblanco@chromium.org
Review URL: https://codereview.chromium.org/
407203002
scroggo [Tue, 22 Jul 2014 19:38:55 +0000 (12:38 -0700)]
Run CanvasState test across a library boundary.
Refactor CanvasStateTest to pull out functions which can
either be called directly or from a shared library. Add a
command line flag to pass in the path to a library to open
to call those functions from.
Separate different CanvasTest tests into separate DEF_TEST
tests. This allows them to be run in parallel.
Move the ifdefs outside of function declarations to skip
running CanvasTest tests which do nothing.
Add the canvas_state_lib target. It is a shared library that
exports some functions to be called by another version of
Skia.
BUG=b/
15693384
R=djsollen@google.com, reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
400043003
scroggo [Tue, 22 Jul 2014 19:09:30 +0000 (12:09 -0700)]
Introduce skia_pic gyp variable.
skia_pic tells ninja to use -fPIC when building for position
independent code.
Set skia_pic to true when building our existing targets that
require position independent code.
Also use skia_pic when building for Android.
R=mtklein@google.com, djsollen@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
406613003
bungeman [Tue, 22 Jul 2014 19:07:14 +0000 (12:07 -0700)]
SkFontMgr for Android.
R=djsollen@google.com, tomhudson@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
414483002
bsalomon [Tue, 22 Jul 2014 18:17:14 +0000 (11:17 -0700)]
Remove unused enum value and member of GrGpuObject
R=robertphillips@google.com
TBR=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
413523002
caryclark [Tue, 22 Jul 2014 17:54:07 +0000 (10:54 -0700)]
remove command line args
R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
408243003
caryclark [Tue, 22 Jul 2014 17:40:06 +0000 (10:40 -0700)]
fix nacl
R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
407163002
robertphillips [Tue, 22 Jul 2014 17:18:06 +0000 (10:18 -0700)]
Add auto purging for SkPicture-related Ganesh resources (esp. layers)
This is intended to lower the bookkeeping burden for the Layer Caching feature. Cached layers are now automatically purged when a picture is deleted.
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
408923002
caryclark [Tue, 22 Jul 2014 17:15:34 +0000 (10:15 -0700)]
share dm and command flags
Share command flags between dm and unit tests.
Also, allow dm's core to be included by itself and iOSShell.
Command line flags that are the same (or nearly the same) in DM
and in skia_tests have been moved to common_flags. Authors,
please check to see that the shared common flag is correct for
the tool.
For iOS, the 'tool_main' entry point has a wrapper to allow multiple
tools to be statically linked in the iOSShell.
Since SkCommandLineFlags::Parse can only be called once, these calls
are disabled in the IOS build.
Since the iOS app directory is dynamically assigned a name, use '@' to
select it. (This is the same convention chosen by the Mobile Harness
iOS file system utilities.)
Move the heart of dm.gyp into dm.gypi so that it can be included by
itself and iOSShell.gyp.
Add tools/flags/SkCommonFlags.* to define and declare common
command line flags.
Add support for dm to iOSShell.
BUG=skia:
R=scroggo@google.com, mtklein@google.com, jvanverth@google.com, bsalomon@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
389653004
joshualitt [Tue, 22 Jul 2014 16:52:11 +0000 (09:52 -0700)]
Initial change to move 2D kernel to its own file.
BUG=skia:
R=bsalomon@chromium.org, senorblanco@chromium.org, bsalomon@google.com
Author: joshualitt@chromium.org
Review URL: https://codereview.chromium.org/
379253003
krajcevski [Tue, 22 Jul 2014 14:44:00 +0000 (07:44 -0700)]
Refactor texture compressors into separate files
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
403383003
sugoi [Tue, 22 Jul 2014 14:26:35 +0000 (07:26 -0700)]
Added count validation in SkImageFilter::Common::unflatten()
BUG=395641
R=reed@google.com, senorblanco@google.com, senorblanco@chromium.org
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
405983006
djsollen [Tue, 22 Jul 2014 14:20:18 +0000 (07:20 -0700)]
Enable the SSSE3 compile time check on all platforms (3rd attempt)
BUG=skia:2746
R=halcanary@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
403583002
egdaniel [Tue, 22 Jul 2014 13:46:45 +0000 (06:46 -0700)]
Rebaseline from recent gpu optimization changes
R=bsalomon@google.com
TBR=bsalomon@google.com
BUG=skia:
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
408203002
robertphillips [Tue, 22 Jul 2014 12:02:50 +0000 (05:02 -0700)]
Rebaseline some flaky perf triggers
R=borenet@google.com
TBR=borenet@google.com
NOTRY=true
NOTREECHECKS=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
411513002
cdalton [Mon, 21 Jul 2014 22:32:44 +0000 (15:32 -0700)]
Add a GrPathRange class
Adds a GrPathRange object that represents a range of paths on the gpu.
Updates GrDrawTarget::drawPaths and supporting code to use GrPathRange
instead of an array of GrPath objects.
Change-Id: I67845f3893cd4d955db947d699aa3733cbb081e0
BUG=skia:
R=bsalomon@google.com, jvanverth@google.com, kkinnunen@nvidia.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
400713003
bsalomon [Mon, 21 Jul 2014 21:24:01 +0000 (14:24 -0700)]
Make GrCacheable implement its own ref counting.
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
392333008
epoger [Mon, 21 Jul 2014 20:55:57 +0000 (13:55 -0700)]
roll common DEPS
R=borenet@google.com
TBR=borenet
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
404823005
egdaniel [Mon, 21 Jul 2014 20:47:57 +0000 (13:47 -0700)]
Add macro so that gpu trace marker can add an arg to the TRACE_EVENT it makes
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
379223004
robertphillips [Mon, 21 Jul 2014 19:40:57 +0000 (12:40 -0700)]
Move GrTMultiMap to src/core and rename it
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
401343002
krajcevski [Mon, 21 Jul 2014 18:44:37 +0000 (11:44 -0700)]
First pass at a blitter for R11 EAC alpha masks. This shaves 10ms off
of the polygon gpu benchmark on the Nexus 7v2 (which is about 6.7% faster).
R=robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
406693002
sugoi [Mon, 21 Jul 2014 18:37:39 +0000 (11:37 -0700)]
Skia side RGB to YUV gpu conversion
This code is the one that's currently working in my local chromium build. A few things still need to be addressed and I'll highlight these directly in the code.
BUG=skia:
R=reed@google.com, bsalomon@google.com, senorblanco@google.com, senorblanco@chromium.org, robertphillips@google.com, scroggo@google.com, halcanary@google.com
Author: sugoi@chromium.org
Review URL: https://codereview.chromium.org/
374743003
egdaniel [Mon, 21 Jul 2014 18:37:28 +0000 (11:37 -0700)]
Remove gpu shader optimatization for solid white or trans black colors
Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.
With optimization in (ms):
White Blue Checkered
Linux ~80 ~80 ~160
N7 ~800 ~1100 ~1500
Moto-e ~830 ~1100 ~2500
Without optimization in (ms):
White Blue Checkered
Linux ~80 ~80 ~80
N7 ~1100 ~1100 ~1100
Moto-e ~1100 ~1100 ~1500
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
5f78d2251a440443c9eaa321dad058d7a32bfef7
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
375823005
borenet [Mon, 21 Jul 2014 17:01:56 +0000 (10:01 -0700)]
Move DirectWrite skimage expectations -> GDI
BUG=skia:
R=scroggo@google.com, bungeman@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
407973003
krajcevski [Mon, 21 Jul 2014 16:54:23 +0000 (09:54 -0700)]
Let blitters be notified when they're done being used
R=reed@google.com, robertphillips@google.com
Author: krajcevski@google.com
Review URL: https://codereview.chromium.org/
399593007
bsalomon [Mon, 21 Jul 2014 15:03:14 +0000 (08:03 -0700)]
Allow GrGLEffects to produce variable length keys.
R=robertphillips@google.com, jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
385713005
reed [Mon, 21 Jul 2014 14:31:53 +0000 (07:31 -0700)]
hide public factory for intermediate class
Use SK_DECLARE_UNFLATTENABLE_OBJECT if the subclass should not be directly instantiated.
TBR=
Author: reed@google.com
Review URL: https://codereview.chromium.org/
399383007
dominikg [Mon, 21 Jul 2014 09:43:20 +0000 (02:43 -0700)]
Remove use of SK_SUPPORT_LEGACY_LAYERRASTERIZER_API.
Mozilla have removed any uses of the legacy API from their Moz2D code.
Since they were the last users we know of, we can remove the legacy API.
BUG=skia:2187
R=scroggo@google.com, reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
402613003
robertphillips [Sun, 20 Jul 2014 16:40:00 +0000 (09:40 -0700)]
Replace GrTHash with SkTDynamicHash
Mike: SkTDynamicHash changes
Brian: Ganesh changes
This removes three instances of GrTHash leaving the ones in GrTextStrike.h
R=mtklein@google.com, bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
402693003
robertphillips [Sun, 20 Jul 2014 16:21:02 +0000 (09:21 -0700)]
Revert of Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are… (https://codereview.chromium.org/
376703009/)
Reason for revert:
Trying to unblock roll wedged on 64 bit intrinsic call on XP
Original issue's description:
> Use the GrCacheable ID to eliminate the need for notifications to GrGpuGL when textures and RTs are deleted.
>
> Also, rename GrCacheable::getGenerationID() to getInstanceID() since it doesn't behave like other "generation" IDs.
>
> Committed: https://skia.googlesource.com/skia/+/
91bdbcdbbdf5cdf0fdb4518a0d30206c964cfdf6
R=jvanverth@google.com, bsalomon@google.com
TBR=bsalomon@google.com, jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
405023003
caryclark [Fri, 18 Jul 2014 17:58:56 +0000 (10:58 -0700)]
git sample app working on iOS
R=jvanverth@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
405653002
halcanary [Fri, 18 Jul 2014 16:18:40 +0000 (09:18 -0700)]
Make ScaledImageCache unit test less dependent on global state.
motivation: The ASAN bot routinely trips this unit test.
R=tomhudson@chromium.org, tomhudson@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
401833002
djsollen [Fri, 18 Jul 2014 14:09:33 +0000 (07:09 -0700)]
expand workaround to all 32-bit mips devices without the appropriate gcc support
R=halcanary@google.com, reed@google.com, mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
400753004
egdaniel [Fri, 18 Jul 2014 13:15:43 +0000 (06:15 -0700)]
Cache the return values of getBlendOpts in GrDrawState
BUG=skia:
R=bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
404473007
rmistry [Fri, 18 Jul 2014 12:25:56 +0000 (05:25 -0700)]
Adding djsollen to list of owners
(SkipBuildbotRuns)
BUG=skia:
R=djsollen@google.com
Author: rmistry@google.com
Review URL: https://codereview.chromium.org/
397813007
caryclark [Fri, 18 Jul 2014 12:08:14 +0000 (05:08 -0700)]
update pathops core and tests
split out skpclip (the test of 1M pictures) into its own project
TBR=reed
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
400033002
djsollen [Thu, 17 Jul 2014 21:00:57 +0000 (14:00 -0700)]
Fix mac NDK builds
R=jvanverth@google.com, scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
401613005
jcgregorio [Thu, 17 Jul 2014 20:54:36 +0000 (13:54 -0700)]
Fix GLubyte to GrGLubyte.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
405433008
jcgregorio [Thu, 17 Jul 2014 20:14:16 +0000 (13:14 -0700)]
Change JSON output of nanobench.
We're moving away from BigQuery for storing results so the output doens't have to conform to BQ requirements, which allows simplifying the format. Also stop parsing the filename for information and pass in buildbot parameters explicitly.
Adds the following flags to nanobench:
--key
--gitHash
BUG=skia:
R=mtklein@google.com, bsalomon@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
392393002
epoger [Thu, 17 Jul 2014 19:54:16 +0000 (12:54 -0700)]
combine base_unittest.py modules from gm and tools
general cleanup, which will also help with http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"')
R=rmistry@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
397103003
bungeman [Thu, 17 Jul 2014 19:17:55 +0000 (12:17 -0700)]
Remove SkRefPtr.
R=mtklein@google.com, reed@google.com, bsalomon@google.com
Author: bungeman@google.com
Review URL: https://codereview.chromium.org/
393913002
mtklein [Thu, 17 Jul 2014 18:23:07 +0000 (11:23 -0700)]
Revert of nanobench: --veryVerbose for more Win7 debugging (https://codereview.chromium.org/
401663002/)
Reason for revert:
Shouldn't be needed anymore.
Original issue's description:
> nanobench: --veryVerbose for more Win7 debugging
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e57452d
R=mtklein@chromium.org
TBR=mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
404543004
bsalomon [Thu, 17 Jul 2014 17:50:59 +0000 (10:50 -0700)]
Fix alpha textures in NV ES3 contexts on Windows.
Make unit tests iterate over all the rendering GL context types rather than using kNative.
Fix the extension printing when gStartupSpew is set.
R=jvanverth@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
398183002
Mike Klein [Thu, 17 Jul 2014 17:19:22 +0000 (13:19 -0400)]
nanobench: --veryVerbose for more Win7 debugging
BUG=skia:
Review URL: https://codereview.chromium.org/
401663002
halcanary [Thu, 17 Jul 2014 17:17:28 +0000 (10:17 -0700)]
erase bitmap inside unit test to make valgrind happier
R=mtklein@google.com
TBR=sunshine
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
397273006
projects / platform / upstream / libSkiaSharp.git / log