Denis Kenzior [Sat, 13 Jun 2009 02:15:24 +0000 (21:15 -0500)]
Add pretty print function for SMS addresses
Denis Kenzior [Sat, 13 Jun 2009 02:05:06 +0000 (21:05 -0500)]
Add sms_extract_common function
Extract common attributes from the various SMS types
Denis Kenzior [Sat, 13 Jun 2009 02:02:49 +0000 (21:02 -0500)]
Make SCTS to time function const-correct
Denis Kenzior [Fri, 12 Jun 2009 16:44:32 +0000 (11:44 -0500)]
Can't implement Multiparty Hangup without chld
Denis Kenzior [Fri, 12 Jun 2009 05:19:14 +0000 (00:19 -0500)]
Do not use chld=1 on mpty when another held
If we're trying to hangup an active MPTY call, and we have
calls on hold we shouldn't use CHLD=1 (release_all_active)
since this will have the side-effect of activating the held
calls
Denis Kenzior [Sat, 13 Jun 2009 00:40:51 +0000 (19:40 -0500)]
Fix memory leak
Denis Kenzior [Sat, 13 Jun 2009 00:33:55 +0000 (19:33 -0500)]
Fixup style issues with previous MCC/MNC patch
- Breakup MCC/MNC LENGTH constant
- Don't hardcode numbers
- Fix >80 column length
- Fix test case to expect strings instead of shorts
Aki Niemi [Fri, 12 Jun 2009 07:02:52 +0000 (10:02 +0300)]
Change MNC and MCC variable types to string
This is to make sure both 2 and 3-digit MNC values are correctly
handled. Both the modem plugin API as well as the D-Bus API are
affected.
Denis Kenzior [Fri, 12 Jun 2009 04:43:33 +0000 (23:43 -0500)]
Fix another pointer cast to use GINT_TO_POINTER
Denis Kenzior [Thu, 11 Jun 2009 22:00:14 +0000 (17:00 -0500)]
Add additional sanity check
Denis Kenzior [Thu, 11 Jun 2009 19:27:14 +0000 (14:27 -0500)]
Make SMS UDH iterators const-correct
Rémi Denis-Courmont [Tue, 9 Jun 2009 13:26:36 +0000 (16:26 +0300)]
Phonet/ISI client helper
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Rémi Denis-Courmont [Tue, 9 Jun 2009 13:26:26 +0000 (16:26 +0300)]
Phonet datagram socket helpers
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Rémi Denis-Courmont [Thu, 4 Jun 2009 15:46:48 +0000 (18:46 +0300)]
Phonet Netlink helpers
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Rémi Denis-Courmont [Thu, 4 Jun 2009 15:26:20 +0000 (18:26 +0300)]
Check for restrict keyword
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Rémi Denis-Courmont [Tue, 9 Jun 2009 13:35:28 +0000 (16:35 +0300)]
configure: set compiler flags at the end
This fixes interferences with warning-unsafe autoconf macros.
Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Denis Kenzior [Thu, 11 Jun 2009 15:43:30 +0000 (10:43 -0500)]
Fix for multiparty_hangup
Due to the use of an invalid structure, release_all_active was being
called instead of release_all_held
Denis Kenzior [Wed, 10 Jun 2009 21:06:14 +0000 (16:06 -0500)]
Fix typo
Denis Kenzior [Wed, 10 Jun 2009 20:52:28 +0000 (15:52 -0500)]
Add TP-PID enumeration
Denis Kenzior [Tue, 9 Jun 2009 03:43:27 +0000 (22:43 -0500)]
Additional fixes to multiline responses
The previous fix did not take into account the logic in have_line
function, which takes care of certain modems that do not prefix
their responses by <cr><lf> at all. This fix should take both
into consideration
Denis Kenzior [Mon, 8 Jun 2009 19:06:07 +0000 (14:06 -0500)]
Fix multiline responses in GAtChat
The standard is a bit fuzzy on how multiline responses are returned
GAtChat assumed that they will always start with <cr><lf>, however
this doesn't seem to be correct. Add a new state which is entered
when a response is obtained. If <cr> is encountered, then it
is processed regularly, otherwise the parser assumes that the
next line is part of the multiline response
Denis Kenzior [Fri, 5 Jun 2009 22:56:11 +0000 (17:56 -0500)]
Add utility for parsing MWI SMS DCS types
Denis Kenzior [Fri, 5 Jun 2009 22:35:50 +0000 (17:35 -0500)]
Only USSD needs the special <cr> handling
Apparently all Cell Broadcasts are always 88 bytes long, with a
6 byte header and 82 byte payload. <cr> character is used as a
terminator and padding for the unused payload
Denis Kenzior [Fri, 5 Jun 2009 22:30:30 +0000 (17:30 -0500)]
Fixup header
Denis Kenzior [Fri, 5 Jun 2009 22:28:09 +0000 (17:28 -0500)]
Reorder the header file a bit
Denis Kenzior [Fri, 5 Jun 2009 18:31:47 +0000 (13:31 -0500)]
Rename ud_len_in_octets to sms_udl_in_bytes
Denis Kenzior [Fri, 5 Jun 2009 18:29:03 +0000 (13:29 -0500)]
Rename sms utilities properly
Rename encode_sms to sms_encode
Rename decode_sms to sms_decode
Denis Kenzior [Fri, 5 Jun 2009 18:27:16 +0000 (13:27 -0500)]
Add SMS specific DCS decoding function
Denis Kenzior [Fri, 5 Jun 2009 16:51:46 +0000 (11:51 -0500)]
Add utility to convert SCTS to local/remote time
Denis Kenzior [Thu, 4 Jun 2009 22:13:09 +0000 (17:13 -0500)]
Add proper handling for various messages
Handle Deliver / Status Report / Cell Broadcast messages and send the
appropriate acknowledgement PDUs (+CNMA) if required
Denis Kenzior [Thu, 4 Jun 2009 21:17:29 +0000 (16:17 -0500)]
SMS-Command is also submitted with sc address
Denis Kenzior [Thu, 4 Jun 2009 17:35:17 +0000 (12:35 -0500)]
Add colons to SMS prefixes
Denis Kenzior [Thu, 4 Jun 2009 02:07:25 +0000 (21:07 -0500)]
Add SMS interface initialization code for atmodem
Denis Kenzior [Tue, 2 Jun 2009 19:39:27 +0000 (14:39 -0500)]
Add check for error path
Denis Kenzior [Tue, 2 Jun 2009 19:38:42 +0000 (14:38 -0500)]
Add check for error path
Denis Kenzior [Tue, 2 Jun 2009 18:20:18 +0000 (13:20 -0500)]
Add UDH Iterator unit test
Denis Kenzior [Tue, 2 Jun 2009 18:18:25 +0000 (13:18 -0500)]
Break out VPF printing into separate function
Denis Kenzior [Tue, 2 Jun 2009 18:17:20 +0000 (13:17 -0500)]
Add User-Data-Header iterator utilities
Denis Kenzior [Tue, 2 Jun 2009 15:31:55 +0000 (10:31 -0500)]
Unit test for SMS-Submit encoding
Denis Kenzior [Mon, 1 Jun 2009 23:11:12 +0000 (18:11 -0500)]
Calculation for UCS2 cases was wrong
Minjun Li [Tue, 2 Jun 2009 00:50:35 +0000 (08:50 +0800)]
Adding common unregister code in atmodem driver
Modem cleanup happens in two places: manager_free (ofono exit) and
manager_destroy (manually removing a specific modem). Both need
to unregister the entire set of registered interfaces.
manager_destroy function did not unregister all interfaces. Fixed
by adding a common function for both code paths.
Denis Kenzior [Mon, 1 Jun 2009 18:57:47 +0000 (13:57 -0500)]
Squash another uninitialized warning
GCC detects that next_octet only sets oct if successful. However,
we've already checked the length, so it should always succeed.
Denis Kenzior [Mon, 1 Jun 2009 18:56:50 +0000 (13:56 -0500)]
Squash another uninitialized warning
GCC is smart enough to detect that oct is only set if the next_octet
function succeeds. However, we've already checked that buf is big
enough, so it should always succeed. Still, lets keep gcc happy
Denis Kenzior [Mon, 1 Jun 2009 18:47:55 +0000 (13:47 -0500)]
Squish another uninitialized warning in CB
Denis Kenzior [Mon, 1 Jun 2009 18:47:20 +0000 (13:47 -0500)]
Squish another uninitialized warning
Denis Kenzior [Mon, 1 Jun 2009 18:46:42 +0000 (13:46 -0500)]
Change int type to enum for SS control callbacks
Denis Kenzior [Mon, 1 Jun 2009 17:51:49 +0000 (12:51 -0500)]
Squash another uninitialized value warning
Denis Kenzior [Mon, 1 Jun 2009 19:03:24 +0000 (14:03 -0500)]
Forgot this for SMS driver
Denis Kenzior [Mon, 1 Jun 2009 19:01:18 +0000 (14:01 -0500)]
Forgot to add this
Denis Kenzior [Fri, 29 May 2009 23:31:46 +0000 (18:31 -0500)]
Add atmodem driver implementation for SMS
Denis Kenzior [Fri, 29 May 2009 23:31:33 +0000 (18:31 -0500)]
Add basic skeleton for SmsManager interface
Denis Kenzior [Fri, 29 May 2009 23:14:40 +0000 (18:14 -0500)]
Do not use empty prefixes
Denis Kenzior [Fri, 29 May 2009 20:29:12 +0000 (15:29 -0500)]
Remove unnecessary define
Denis Kenzior [Fri, 29 May 2009 01:47:04 +0000 (20:47 -0500)]
Mention Minjun's contribution
Denis Kenzior [Fri, 29 May 2009 01:44:30 +0000 (20:44 -0500)]
Remove unused function
Denis Kenzior [Fri, 29 May 2009 01:44:03 +0000 (20:44 -0500)]
Remove unused function
Denis Kenzior [Fri, 29 May 2009 01:42:49 +0000 (20:42 -0500)]
Free voicecalls when exiting
Denis Kenzior [Thu, 28 May 2009 23:16:40 +0000 (18:16 -0500)]
Don't emit the Operator changed if not registered
SPN Update emits the Operator property changed signal. However,
this should not happen if there is no current operator
Denis Kenzior [Thu, 28 May 2009 23:20:23 +0000 (18:20 -0500)]
Add test script for NetworkRegistration interface
Denis Kenzior [Thu, 28 May 2009 23:16:24 +0000 (18:16 -0500)]
Fix a few style issues
Denis Kenzior [Thu, 28 May 2009 22:58:10 +0000 (17:58 -0500)]
Fix signal emission when the operator changes
If the operator changes without going through a searching state the
Operator change signal was not properly emitted
Denis Kenzior [Thu, 28 May 2009 21:50:31 +0000 (16:50 -0500)]
Adding test script to test CallBarring SS strings
Denis Kenzior [Thu, 28 May 2009 21:13:41 +0000 (16:13 -0500)]
Add test script for CallBarring interface
Denis Kenzior [Thu, 28 May 2009 21:05:26 +0000 (16:05 -0500)]
Adding test script for CallMeter interface
Denis Kenzior [Thu, 28 May 2009 20:14:33 +0000 (15:14 -0500)]
Remove unused function
Denis Kenzior [Thu, 28 May 2009 20:01:14 +0000 (15:01 -0500)]
Minor style tweak
Denis Kenzior [Thu, 28 May 2009 19:54:12 +0000 (14:54 -0500)]
Add Supplementary Services test for CallSettings
Denis Kenzior [Thu, 28 May 2009 18:51:41 +0000 (13:51 -0500)]
Add simple test for CallSettings interface
Denis Kenzior [Thu, 28 May 2009 18:50:25 +0000 (13:50 -0500)]
Squash CallWaiting onto CallSettings interface
The CallWaiting interface had one settable attribute after the latest
set of refactoring. Squash it onto the CallSettings interface where
it belonged in the first place
Denis Kenzior [Thu, 28 May 2009 16:21:26 +0000 (11:21 -0500)]
Simplify CallWaiting plugin interface
The use of a struct with status & cls seemed pointless when only
a single integer can work just as well.
Also the Fax & Data attributes have been squished. oFono does
not yet support those call types.
Denis Kenzior [Thu, 28 May 2009 16:20:40 +0000 (11:20 -0500)]
Fix CallWaiting ss request to query bearers better
Denis Kenzior [Thu, 28 May 2009 15:02:22 +0000 (10:02 -0500)]
Squash gcc warning about uninitialized use of v
Denis Kenzior [Wed, 27 May 2009 22:33:41 +0000 (17:33 -0500)]
Tweak the call barring API
Denis Kenzior [Wed, 27 May 2009 22:31:23 +0000 (17:31 -0500)]
Make CB operations take a mask of the bearers
Currently we only really support Voice calls, so only that
bearer is enabled. However, in the future we might support
other call types.
Denis Kenzior [Wed, 27 May 2009 19:52:35 +0000 (14:52 -0500)]
Make Operator attribute work when SPN is empty
Minjun Li [Tue, 26 May 2009 07:37:22 +0000 (15:37 +0800)]
Delete the repeated calling of voicecall_create
Minjun Li [Tue, 26 May 2009 07:28:00 +0000 (15:28 +0800)]
Fix erroneous check in voicecall_busy to set_udub
The not implemented check should be checking for the presence of the
set_udub function, not the presence of the release_specific function
Denis Kenzior [Tue, 26 May 2009 23:09:07 +0000 (18:09 -0500)]
Add plus sign for ATD when dialing international
Denis Kenzior [Tue, 26 May 2009 23:07:48 +0000 (18:07 -0500)]
Ignore cls for call barring queries
Denis Kenzior [Tue, 26 May 2009 23:04:31 +0000 (18:04 -0500)]
Cleanup SimManager interface
Future-Proof own numbers support. For now we only report voice numbers
Rename attributes to be a bit better
Denis Kenzior [Tue, 26 May 2009 22:36:42 +0000 (17:36 -0500)]
Fixup the initialization / destruction order
Denis Kenzior [Tue, 26 May 2009 18:48:42 +0000 (13:48 -0500)]
Create ofono_phone_number struct
Creates a new structure in driver.h called ofono_phone_number.
This is meant to replace const char *number, int number_type
arguments everywhere.
Fix up all existing code to use this structure instead.
Andrzej Zaborowski [Fri, 22 May 2009 11:58:49 +0000 (13:58 +0200)]
Add atmodem SIM-related operations
Andrzej Zaborowski [Fri, 22 May 2009 11:58:49 +0000 (13:58 +0200)]
Add hex-encoded character string getter to AtChat
Andrzej Zaborowski [Fri, 22 May 2009 11:57:18 +0000 (13:57 +0200)]
Add SimManager interface.
Implement basic SIM filesystem utilities.
Obtain Service Provider Name EF-SPN record.
Make NetworkRegistration use SPN for PLMN display. This implements PLMN
display rules in 31.102 "EFSPN".
Denis Kenzior [Thu, 21 May 2009 23:57:44 +0000 (18:57 -0500)]
Make voicecall test a bit more generic
Denis Kenzior [Thu, 21 May 2009 21:21:15 +0000 (16:21 -0500)]
Add more basic test scripts
Denis Kenzior [Thu, 21 May 2009 21:18:49 +0000 (16:18 -0500)]
Adding basic Call Forwarding test scripts
Denis Kenzior [Thu, 21 May 2009 21:17:20 +0000 (16:17 -0500)]
Make the Call Forwarding atmodem driver work
Denis Kenzior [Thu, 21 May 2009 21:14:51 +0000 (16:14 -0500)]
Simplify CallForwarding interface
Simplify the Call Forwarding interface using some of the ideas from the
Call Barring interface. The code should be much easier to follow now
Remove Data/Fax attributes and refactor how the Supplementary Service
requests are performed. The Data/Fax attributes can still be
controlled via supplementary service strings for GCF compliance, but
have been removed from general consumption since oFono does not yet
support Fax or Data bearers.
Denis Kenzior [Thu, 21 May 2009 21:14:01 +0000 (16:14 -0500)]
Fix Supplementary Service MMI strings per 22.030
Denis Kenzior [Wed, 20 May 2009 20:34:37 +0000 (15:34 -0500)]
Fix minor logic flow bug in CallBarring
Andrzej Zaborowski [Tue, 19 May 2009 15:52:52 +0000 (17:52 +0200)]
Remove yet more unused variables.
Denis Kenzior [Wed, 20 May 2009 17:36:43 +0000 (12:36 -0500)]
Add class parameter to the query function for CB
Denis Kenzior [Wed, 20 May 2009 17:35:15 +0000 (12:35 -0500)]
Fixup SS control case
In certain cases, querying/setting prperties via SS control req
doesn't provide complete state, resulting in subsequent
GetProperties reporting incorrect values
Denis Kenzior [Wed, 20 May 2009 04:11:26 +0000 (23:11 -0500)]
Fix some minor style issues
Denis Kenzior [Mon, 18 May 2009 20:12:17 +0000 (15:12 -0500)]
Minor build system fix
Denis Kenzior [Mon, 18 May 2009 20:11:17 +0000 (15:11 -0500)]
Rework Call Barring Interface
Andrzej Zaborowski [Thu, 14 May 2009 22:15:03 +0000 (00:15 +0200)]
drivers/atmodem implementation for CallBarring.
Andrzej Zaborowski [Thu, 14 May 2009 22:14:49 +0000 (00:14 +0200)]
Implement the CallBarring interface.