platform/upstream/curl.git
12 years agoMakefileBuild.vc: Allow building without SSL
Yang Tse [Wed, 13 Jun 2012 19:15:41 +0000 (21:15 +0200)]
MakefileBuild.vc: Allow building without SSL

In order to use Windows native SSL support define 'USE_WINSSL'

12 years agoconfigure: new option --with-winssl
Yang Tse [Wed, 13 Jun 2012 18:54:03 +0000 (20:54 +0200)]
configure: new option --with-winssl

This option may be used to build curl/libcurl using SSL/TLS support provided
by MS windows system libraries. Option is mutually exclusive with any other
SSL library. Default value is --without-winssl.

--with-winssl option implies --with-sspi option.

Option meaningful only for Windows builds.

12 years agoChanged Schannel string to SSL-Windows-native.
Guenter Knauf [Wed, 13 Jun 2012 17:29:45 +0000 (19:29 +0200)]
Changed Schannel string to SSL-Windows-native.

This is more descriptive for the user who might
not even know what schannnel is at all.

12 years agoschannel: remove version number and identify its use with 'schannel' literal
Yang Tse [Wed, 13 Jun 2012 13:53:51 +0000 (15:53 +0200)]
schannel: remove version number and identify its use with 'schannel' literal

Version number is removed in order to make this info consistent with
how we do it with other MS and Linux system libraries for which we don't
provide this info.

Identifier changed from 'WinSSPI' to 'schannel' given that this is the
actual provider of the SSL/TLS support. libcurl can still be built with
SSPI and without SCHANNEL support.

12 years agosinglesocket: remove dead code
Daniel Stenberg [Tue, 12 Jun 2012 21:04:04 +0000 (23:04 +0200)]
singlesocket: remove dead code

No need to check if 'entry' is non-NULL in a spot where it is already checked
and guaranteed to be non-NULL.

(Spotted by a Coverity scan)

12 years agonetrc: remove dead code
Daniel Stenberg [Tue, 12 Jun 2012 20:46:14 +0000 (22:46 +0200)]
netrc: remove dead code

Remove two states from the enum and the corresponding code for them as
these states were never reached or used.

(Spotted by a Coverity scan)

12 years agoRevert "connect.c/ftp.c: Fixed dereferencing pointer breakin strict-aliasing"
Yang Tse [Tue, 12 Jun 2012 11:12:09 +0000 (13:12 +0200)]
Revert "connect.c/ftp.c: Fixed dereferencing pointer breakin strict-aliasing"

This reverts commit 9c94236e6cc078a0dc5a78b6e2fefc1403e5375e.

It didn't server its purpose, so lets go back to long-time working code.

12 years agosocks_sspi.c: further cleanup
Yang Tse [Tue, 12 Jun 2012 10:34:52 +0000 (12:34 +0200)]
socks_sspi.c: further cleanup

12 years agosocks_sspi.c: Clean up and removal of obsolete minor status
Marc Hoersken [Tue, 12 Jun 2012 06:50:10 +0000 (08:50 +0200)]
socks_sspi.c: Clean up and removal of obsolete minor status

Removed obsolete minor status variable and parameter of status function
which was never used or set at all. Also Curl_sspi_strerror does support
only one status and there is no need for a second sub status.

12 years agoRemoved trailing whitespaces.
Guenter Knauf [Tue, 12 Jun 2012 03:36:08 +0000 (05:36 +0200)]
Removed trailing whitespaces.

12 years agostrerror.c: make Curl_sspi_strerror() always return code for errors
Yang Tse [Tue, 12 Jun 2012 01:57:15 +0000 (03:57 +0200)]
strerror.c: make Curl_sspi_strerror() always return code for errors

12 years agocurl_sspi.h: provide sspi status definitions missing in old headers
Yang Tse [Tue, 12 Jun 2012 01:56:24 +0000 (03:56 +0200)]
curl_sspi.h: provide sspi status definitions missing in old headers

12 years agosspi: make Curl_sspi_strerror() libcurl's sspi status code string function
Yang Tse [Mon, 11 Jun 2012 23:11:10 +0000 (01:11 +0200)]
sspi: make Curl_sspi_strerror() libcurl's sspi status code string function

12 years agosspi: make Curl_sspi_strerror() libcurl's sspi status code string function
Yang Tse [Mon, 11 Jun 2012 23:06:48 +0000 (01:06 +0200)]
sspi: make Curl_sspi_strerror() libcurl's sspi status code string function

12 years agoRevert: 634f7cfee40d4658 partially
Daniel Stenberg [Mon, 11 Jun 2012 20:58:39 +0000 (22:58 +0200)]
Revert: 634f7cfee40d4658 partially

Make sure CURL_VERSION_SSPI is present and works as in previous releases
for ABI and API compatibility reasons.

12 years agochecksrc: shorten a few lines to comply
Daniel Stenberg [Mon, 11 Jun 2012 17:08:46 +0000 (19:08 +0200)]
checksrc: shorten a few lines to comply

12 years agocleanup: remove trailing whitespace
Daniel Stenberg [Mon, 11 Jun 2012 17:06:43 +0000 (19:06 +0200)]
cleanup: remove trailing whitespace

12 years agowinbuild: Removed WITH_SSL=schannel and tie schannel to SSPI
Marc Hoersken [Mon, 11 Jun 2012 17:04:49 +0000 (19:04 +0200)]
winbuild: Removed WITH_SSL=schannel and tie schannel to SSPI

Removed specific WITH_SSL=schannel paramter that did not fit the general
schema and complicated the parameters. For now Schannel will be enabled
if SSPI is enabled and OpenSSL is disabled.

12 years agoMakefile.vc6: Added version.lib if built with SSPI
Steve Holme [Mon, 11 Jun 2012 17:04:16 +0000 (19:04 +0200)]
Makefile.vc6: Added version.lib if built with SSPI

12 years agowinbuild: Updated winbuild scripts to add schannel
Marc Hoersken [Mon, 11 Jun 2012 17:03:14 +0000 (19:03 +0200)]
winbuild: Updated winbuild scripts to add schannel

12 years agomingw32: Fixed warning of USE_SSL being redefined
Marc Hoersken [Sun, 10 Jun 2012 21:40:29 +0000 (23:40 +0200)]
mingw32: Fixed warning of USE_SSL being redefined

12 years agosspi: Fixed incompatible parameter pointer type in Curl_sspi_version
Marc Hoersken [Sun, 10 Jun 2012 21:31:59 +0000 (23:31 +0200)]
sspi: Fixed incompatible parameter pointer type in Curl_sspi_version

12 years agosspi: Updated RELEASE-NOTES, FEATURES and THANKS
Marc Hoersken [Sun, 10 Jun 2012 20:34:43 +0000 (22:34 +0200)]
sspi: Updated RELEASE-NOTES, FEATURES and THANKS

12 years agosetup.h: Automatically define USE_SSL if USE_SCHANNEL is defined
Marc Hoersken [Mon, 11 Jun 2012 06:37:22 +0000 (08:37 +0200)]
setup.h: Automatically define USE_SSL if USE_SCHANNEL is defined

12 years agoversion: Replaced SSPI feature information with version string details
Marc Hoersken [Mon, 11 Jun 2012 06:36:48 +0000 (08:36 +0200)]
version: Replaced SSPI feature information with version string details

Added Windows SSPI version information to the curl version string when
SCHANNEL SSL is not enabled, as the version of the library should also
be included when SSPI is used to generate security contexts.

Removed SSPI from the feature list as the features are GSS-Negotiate,
NTLM and SSL depending on the usage of the SSPI library.

12 years agosspi.c: Post Curl_sspi_version() rework code tidy up
Steve Holme [Sun, 10 Jun 2012 11:30:02 +0000 (12:30 +0100)]
sspi.c: Post Curl_sspi_version() rework code tidy up

Removed duplicate blank lines.
Removed spaces between the not and test in various if statements.
Removed explicit test of NULL in an if statement.
Placed function returns on same line as function declarations.
Replaced the use of curl_maprintf() with aprintf() as it is the
preprocessor job to do this substitution if ENABLE_CURLX_PRINTF
is set.

12 years agosspi: Reworked Curl_sspi_version() to return version components
Steve Holme [Sun, 10 Jun 2012 11:07:45 +0000 (12:07 +0100)]
sspi: Reworked Curl_sspi_version() to return version components

Reworked the version function to return four version components rather
than a string that has to be freed by the caller.

12 years agoconfigure.ac: Added -lversion if built with SSPI
Guenter Knauf [Mon, 23 Apr 2012 00:14:32 +0000 (01:14 +0100)]
configure.ac: Added -lversion if built with SSPI

12 years agoschannel: Code cleanup and bug fixes
Marc Hoersken [Sun, 15 Apr 2012 02:12:26 +0000 (04:12 +0200)]
schannel: Code cleanup and bug fixes

curl_sspi.c: Fixed mingw32-gcc compiler warnings
curl_sspi.c: Fixed length of error code hex output

The hex value was printed as signed 64-bit value on 64-bit systems:
SEC_E_WRONG_PRINCIPAL (0xFFFFFFFF80090322)

It is now correctly printed as the following:
SEC_E_WRONG_PRINCIPAL (0x80090322)

curl_sspi.c: Fallback to security function table version number
Instead of reporting an unknown version, the interface version is used.

curl_sspi.c: Removed SSPI/ version prefix from Curl_sspi_version
curl_schannel: Replaced static buffer sizes with defined names
curl_schannel.c: First brace when declaring functions on column 0
curl_schannel.c: Put the pointer sign directly at variable name
curl_schannel.c: Use structs directly instead of typedef'ed structs
curl_schannel.c: Removed space before opening brace
curl_schannel.c: Fixed lines being longer than 80 chars

12 years agocurl_sspi: Added Curl_sspi_version function
Marc Hoersken [Sat, 14 Apr 2012 13:00:33 +0000 (15:00 +0200)]
curl_sspi: Added Curl_sspi_version function

Added new function to get SSPI version as string.
Added required library version.lib to makefiles.
Changed curl_schannel.c to use Curl_sspi_version.

12 years agoschannel: Updated mingw32 makefiles
Guenter Knauf [Fri, 13 Apr 2012 11:17:57 +0000 (13:17 +0200)]
schannel: Updated mingw32 makefiles

12 years agoschannel: Replace ASCII specific code with general defines
Marc Hoersken [Fri, 13 Apr 2012 11:10:09 +0000 (13:10 +0200)]
schannel: Replace ASCII specific code with general defines

12 years agoschannel: Added definitions which are missing in mingw32
Marc Hoersken [Fri, 13 Apr 2012 11:09:24 +0000 (13:09 +0200)]
schannel: Added definitions which are missing in mingw32

12 years agoschannel: Moved interal struct types to urldata.h
Marc Hoersken [Fri, 13 Apr 2012 11:04:53 +0000 (13:04 +0200)]
schannel: Moved interal struct types to urldata.h

Moved type definitions in order to avoid inclusion loop

12 years agoschannel: Fixed compiler warnings about pointer type assignments
Marc Hoersken [Fri, 13 Apr 2012 11:05:26 +0000 (13:05 +0200)]
schannel: Fixed compiler warnings about pointer type assignments

12 years agoschannel: Fixed critical typo in conditions and added buffer length checks
Marc Hoersken [Fri, 13 Apr 2012 11:02:59 +0000 (13:02 +0200)]
schannel: Fixed critical typo in conditions and added buffer length checks

12 years agosspi: Refactored socks_sspi and schannel to use same error message functions
Marc Hoersken [Wed, 11 Apr 2012 15:25:26 +0000 (17:25 +0200)]
sspi: Refactored socks_sspi and schannel to use same error message functions

Moved the error constant switch to curl_sspi.c and added two new helper
functions to curl_sspi.[ch] which either return the constant or a fully
translated message representing the SSPI security status.
Updated socks_sspi.c and curl_schannel.c to use the new functions.

12 years agoschannel: Added special shutdown check for Windows 2000 Professional
Marc Hoersken [Tue, 10 Apr 2012 19:49:35 +0000 (21:49 +0200)]
schannel: Added special shutdown check for Windows 2000 Professional

Windows 2000 Professional:  Schannel returns SEC_E_OK instead
of SEC_I_CONTEXT_EXPIRED. If the length of the output buffer
is zero and the first byte of the encrypted packet is 0x15,
the application can safely assume that the message was a
close_notify message and change the return value to
SEC_I_CONTEXT_EXPIRED.

Connection shutdown does not mean that there is no data to read
Correctly handle incomplete message and ask curl to re-read
Fixed buffer for decrypted being to small
Re-structured read condition to be more effective
Removed obsolete verbose messages
Changed memory reduction method to keep a minimum buffer of size 4096

12 years agoschannel: Implemented SSL/TLS renegotiation
Marc Hoersken [Tue, 10 Apr 2012 19:21:31 +0000 (21:21 +0200)]
schannel: Implemented SSL/TLS renegotiation

Updated TODO information and added related MSDN articles

12 years agoschannel: Save session credential handles in session cache
Marc Hoersken [Mon, 9 Apr 2012 21:24:55 +0000 (23:24 +0200)]
schannel: Save session credential handles in session cache

12 years agoschannel: Code cleanup
Marc Hoersken [Mon, 9 Apr 2012 20:43:48 +0000 (22:43 +0200)]
schannel: Code cleanup

12 years agoschannel: Check for required context attributes
Marc Hoersken [Mon, 9 Apr 2012 20:33:58 +0000 (22:33 +0200)]
schannel: Check for required context attributes

12 years agoschannel: Allow certificate and revocation checks being deactivated
Marc Hoersken [Mon, 9 Apr 2012 16:35:00 +0000 (18:35 +0200)]
schannel: Allow certificate and revocation checks being deactivated

12 years agoschannel: Added SSL/TLS support with Microsoft Windows Schannel SSPI
Marc Hoersken [Mon, 9 Apr 2012 13:40:06 +0000 (15:40 +0200)]
schannel: Added SSL/TLS support with Microsoft Windows Schannel SSPI

12 years agohttp: Replaced specific SSL libraries list in https_getsock fallback
Marc Hoersken [Mon, 9 Apr 2012 13:19:54 +0000 (15:19 +0200)]
http: Replaced specific SSL libraries list in https_getsock fallback

12 years agoconnect.c/ftp.c: Fixed dereferencing pointer breakin strict-aliasing
Marc Hoersken [Mon, 11 Jun 2012 10:24:03 +0000 (12:24 +0200)]
connect.c/ftp.c: Fixed dereferencing pointer breakin strict-aliasing

Fixed warning: dereferencing pointer does break strict-aliasing rules
by using a union instead of separate pointer variables.
Internal union sockaddr_u could probably be moved to generic header.
Thanks to Paul Howarth for the hint about using unions for this.

Important for winbuild: Separate declaration of sockaddr_u pointer.
The pointer variable *sock cannot be declared and initialized right
after the union declaration. Therefore it has to be a separate statement.

12 years agocurl_ntlm_msgs.c: Fixed passwdlen not being used and recalculated
Marc Hoersken [Mon, 11 Jun 2012 00:23:00 +0000 (02:23 +0200)]
curl_ntlm_msgs.c: Fixed passwdlen not being used and recalculated

12 years agotests: fix test definitions # 1355, 1363, 1385 and 1393
Yang Tse [Mon, 11 Jun 2012 11:56:40 +0000 (13:56 +0200)]
tests: fix test definitions # 1355, 1363, 1385 and 1393

-i without HTTP protocol shall not include headers in the output

12 years agoCurl_pgrsDone: return int and acknowledge return code
Daniel Stenberg [Sun, 10 Jun 2012 21:39:04 +0000 (23:39 +0200)]
Curl_pgrsDone: return int and acknowledge return code

Since Curl_pgrsDone() itself calls Curl_pgrsUpdate() which may return an
abort instruction or similar we need to return that info back and
subsequently properly handle return codes from Curl_pgrsDone() where
used.

(Spotted by a Coverity scan)

12 years agowinbuild: Fixed environment variables being lost
Marc Hoersken [Sun, 10 Jun 2012 14:50:11 +0000 (16:50 +0200)]
winbuild: Fixed environment variables being lost

Fixed USE_IPV6 and USE_IDN not being passed
from Makefile.vc to MakefileBuild.vc
Fixed whitespace and formatting issues
Fixed typo and format in help message

12 years agoAdded metalink support to NetWare builds.
Guenter Knauf [Sat, 9 Jun 2012 21:10:23 +0000 (23:10 +0200)]
Added metalink support to NetWare builds.

12 years agosmtp.c: Removed unused variable
Steve Holme [Sat, 9 Jun 2012 18:49:59 +0000 (19:49 +0100)]
smtp.c: Removed unused variable

12 years agosmtp: Post apop feature code tidy up
Steve Holme [Sat, 9 Jun 2012 18:22:29 +0000 (19:22 +0100)]
smtp: Post apop feature code tidy up

12 years agopop3: Post apop feature code tidy up
Steve Holme [Sat, 9 Jun 2012 18:21:44 +0000 (19:21 +0100)]
pop3: Post apop feature code tidy up

12 years agopop3: Added support for apop authentication
Steve Holme [Sat, 9 Jun 2012 12:49:37 +0000 (13:49 +0100)]
pop3: Added support for apop authentication

12 years agopop3: Enhanced the extended authentication mechanism detection
Steve Holme [Sat, 9 Jun 2012 10:48:44 +0000 (11:48 +0100)]
pop3: Enhanced the extended authentication mechanism detection

Enhanced the authentication type / mechanism detection in preparation
for the introduction of APOP support.

12 years agopop3.c: Fixed length of SASL check
Steve Holme [Sat, 9 Jun 2012 10:08:08 +0000 (11:08 +0100)]
pop3.c: Fixed length of SASL check

12 years agoFixes allowing 26 more test cases in 1334 to 1393 range to succeed
Yang Tse [Sat, 9 Jun 2012 03:42:39 +0000 (05:42 +0200)]
Fixes allowing 26 more test cases in 1334 to 1393 range to succeed

12 years agotests: fix test definitions # 1370 and 1371
Yang Tse [Sat, 9 Jun 2012 03:31:57 +0000 (05:31 +0200)]
tests: fix test definitions # 1370 and 1371

-J without -O shall not honor C-D filename

12 years agoOpenSSL: support longer certificate subject names
Daniel Stenberg [Fri, 8 Jun 2012 22:06:54 +0000 (00:06 +0200)]
OpenSSL: support longer certificate subject names

Previously it would use a 256 byte buffer and thus cut off very long
subject names. The limit is now upped to the receive buffer size, 16K.

Bug: http://curl.haxx.se/bug/view.cgi?id=3533045
Reported by: Anthony G. Basile

12 years agossl: fix duplicated SSL handshake with multi interface and proxy
Kamil Dudka [Fri, 8 Jun 2012 21:02:57 +0000 (23:02 +0200)]
ssl: fix duplicated SSL handshake with multi interface and proxy

Bug: https://bugzilla.redhat.com/788526
Reported by: Enrico Scholz

12 years agotool_getparam.h: fix compiler error
Daniel Stenberg [Fri, 8 Jun 2012 21:14:30 +0000 (23:14 +0200)]
tool_getparam.h: fix compiler error

forward declare the Configurable struct

12 years agometalink: restore some includes
Daniel Stenberg [Fri, 8 Jun 2012 21:13:32 +0000 (23:13 +0200)]
metalink: restore some includes

Commit eeeba1496cbca removed them and thus broke my Linux build

12 years agoopenldap: OOM fixes
Daniel Stenberg [Fri, 8 Jun 2012 18:56:22 +0000 (20:56 +0200)]
openldap: OOM fixes

when calloc fails, return error! (Detected by Fortify)

Reported by: Robert B. Harris

12 years agosasl: Re-factored mechanism constants in preparation for APOP work
Steve Holme [Fri, 8 Jun 2012 18:52:28 +0000 (19:52 +0100)]
sasl: Re-factored mechanism constants in preparation for APOP work

12 years agometalink: build fixes and adjustments II
Yang Tse [Fri, 8 Jun 2012 12:21:29 +0000 (14:21 +0200)]
metalink: build fixes and adjustments II

Additionally, make hash checking ability mandatory in order to allow metalink
support in curl.

A command line option could be introduced to skip hash checking at runtime,
but the ability to check hashes should always be built-in when providing
metalink support.

12 years agoAdded metalink support to MinGW builds.
Guenter Knauf [Fri, 8 Jun 2012 12:11:36 +0000 (14:11 +0200)]
Added metalink support to MinGW builds.

12 years agolog2changes.pl: fix the Version output
Daniel Stenberg [Thu, 7 Jun 2012 21:49:14 +0000 (23:49 +0200)]
log2changes.pl: fix the Version output

Previously it could easily wrongly get repeated

12 years agometalink: build fixes and adjustments I
Yang Tse [Thu, 7 Jun 2012 21:49:27 +0000 (23:49 +0200)]
metalink: build fixes and adjustments I

12 years agolib554.c: use curl_formadd() properly
Daniel Stenberg [Thu, 7 Jun 2012 21:08:35 +0000 (23:08 +0200)]
lib554.c: use curl_formadd() properly

The length/size options take longs so make sure to pass on such types.

Reported by: Neil Bowers
Bug: http://curl.haxx.se/mail/lib-2012-06/0001.html

12 years agosmtp.c: Re-factored the smtp_state_*_resp() functions
Steve Holme [Thu, 7 Jun 2012 21:06:01 +0000 (22:06 +0100)]
smtp.c: Re-factored the smtp_state_*_resp() functions

Re-factored the smtp_state_*_resp() functions to 1) Match the constants
that were refactored in commit 00fddba6727c, 2) To be more readable and
3) To match their counterparties in pop3.c.

12 years agoFixes allowing HTTP test cases 1338, 1339, 1368 and 1369 to succeed
Yang Tse [Thu, 7 Jun 2012 19:57:53 +0000 (21:57 +0200)]
Fixes allowing HTTP test cases 1338, 1339, 1368 and 1369 to succeed

12 years agotests 1364 to 1393: several -o filename -J -i -D combinations for HTTP and FTP
Yang Tse [Thu, 7 Jun 2012 15:45:37 +0000 (17:45 +0200)]
tests 1364 to 1393: several -o filename -J -i -D combinations for HTTP and FTP

12 years agotests 1348 to 1363: test definition polishing
Yang Tse [Thu, 7 Jun 2012 13:26:03 +0000 (15:26 +0200)]
tests 1348 to 1363: test definition polishing

Verify that the "Saved to filename 'blabla'" message is only displayed when
the 'blabla' filename being used _actually_ has been specified by the server
in the Content-Disposition header.

Use relative path for unintended file creation postcheck.

12 years agosmtp: Re-factored the SMTP_AUTH* state machine constants
Steve Holme [Wed, 6 Jun 2012 19:14:52 +0000 (20:14 +0100)]
smtp: Re-factored the SMTP_AUTH* state machine constants

Re-factored the SMTP_AUTH* constants, that are used by the state
machine, to be clearer to read.

12 years agoAdded hint for pkg-config wrapper script.
Guenter Knauf [Wed, 6 Jun 2012 15:22:17 +0000 (17:22 +0200)]
Added hint for pkg-config wrapper script.

12 years agoUpdated Android section with recent NDK.
Guenter Knauf [Wed, 6 Jun 2012 14:14:03 +0000 (16:14 +0200)]
Updated Android section with recent NDK.

The r7b had some bugs, and shouldnt be used.

12 years agoDisable non-HTTP header related tests
Yang Tse [Wed, 6 Jun 2012 11:04:18 +0000 (13:04 +0200)]
Disable non-HTTP header related tests

These now detect incompleate header data and fail

12 years agotests 1348 to 1363: compleate header data part of test definition
Yang Tse [Wed, 6 Jun 2012 10:59:52 +0000 (12:59 +0200)]
tests 1348 to 1363: compleate header data part of test definition

12 years agotests 1334 to 1363 revisited.
Yang Tse [Tue, 5 Jun 2012 18:19:27 +0000 (20:19 +0200)]
tests 1334 to 1363 revisited.

Add a postcheck section to verify unintended file creation.

Remove needless <file> checks in verify section. Renumbering where appropriate.

12 years agotests: adjust file part behavior in test verify section.
Yang Tse [Tue, 5 Jun 2012 18:01:23 +0000 (20:01 +0200)]
tests: adjust file part behavior in test verify section.

When a <file> part is now specified with no contents at all, this
will actually verify that the specified file has no contents at all.
Previously file contents would be ignored.

12 years agosmtp.c: Removed whitespace
Steve Holme [Tue, 5 Jun 2012 13:34:17 +0000 (14:34 +0100)]
smtp.c: Removed whitespace

12 years agopop3: Another small code tidy up
Steve Holme [Tue, 5 Jun 2012 12:49:50 +0000 (13:49 +0100)]
pop3: Another small code tidy up

Missed some comments that we identified during the SMTP tidy up earlier.

12 years agosmtp: Post authentication code tidy up
Steve Holme [Tue, 5 Jun 2012 11:23:01 +0000 (12:23 +0100)]
smtp: Post authentication code tidy up

Corrected lines longer than 78 characters.

Removed unnecessary braces in smtp_state_helo_resp().

Introduced some comments in data sending functions.

Tidied up comments to match changes made in pop3.c.

12 years agotests 1348 to 1363: add a comma in test description
Yang Tse [Tue, 5 Jun 2012 10:31:57 +0000 (12:31 +0200)]
tests 1348 to 1363: add a comma in test description

12 years agoemail: Removed duplicated header file
Steve Holme [Tue, 5 Jun 2012 10:18:07 +0000 (11:18 +0100)]
email: Removed duplicated header file

12 years agosasl: Renamed Curl_sasl_decode_ntlm_type2_message()
Steve Holme [Mon, 4 Jun 2012 21:25:45 +0000 (22:25 +0100)]
sasl: Renamed Curl_sasl_decode_ntlm_type2_message()

For consistency with other SASL based functions renamed this function
to Curl_sasl_create_ntlm_type3_message() which better describes its
usage.

12 years agopop3: Post authentication code tidy up
Steve Holme [Mon, 4 Jun 2012 21:15:51 +0000 (22:15 +0100)]
pop3: Post authentication code tidy up

Corrected lines longer than 78 characters.

Changed POP3_AUTH_FINAL to POP3_AUTH to match SMTP code now that the
AUTH command is no longer sent on its own.

Introduced some comments in data sending functions.

Another attempt at trying to rational code and comment style.

12 years agopop3: Added support for sasl digest-md5 authentication
Steve Holme [Mon, 4 Jun 2012 20:50:16 +0000 (21:50 +0100)]
pop3: Added support for sasl digest-md5 authentication

12 years agosasl: add reference for curl_sasl
Yang Tse [Mon, 4 Jun 2012 20:49:07 +0000 (22:49 +0200)]
sasl: add reference for curl_sasl

12 years agoMakefile.inc: tab adjustment
Yang Tse [Mon, 4 Jun 2012 20:48:09 +0000 (22:48 +0200)]
Makefile.inc: tab adjustment

12 years agopop3 tests: CAPA instead of AUTH
Daniel Stenberg [Mon, 4 Jun 2012 20:34:06 +0000 (22:34 +0200)]
pop3 tests: CAPA instead of AUTH

After Steve's commit e336bc7c42c7340 test 1319 and 1407 need to check
for CAPA instead of AUTH.

12 years agosasl: Added service parameter to Curl_sasl_create_digest_md5_message()
Steve Holme [Mon, 4 Jun 2012 19:22:06 +0000 (20:22 +0100)]
sasl: Added service parameter to Curl_sasl_create_digest_md5_message()

Added a service type parameter to Curl_sasl_create_digest_md5_message()
to allow the function to be used by different services rather than being
hard coded to "smtp".

12 years agotests 1356 to 1363: several -O -J -i -D combinations with FTP protocol
Yang Tse [Mon, 4 Jun 2012 18:58:46 +0000 (20:58 +0200)]
tests 1356 to 1363: several -O -J -i -D combinations with FTP protocol

Currently 1356 to 1362 succeed but a write failure is logged in traceNNNN.

Currently 1363 fails, so disabled for now.

12 years agotests: Updated pop3 tests for change in auth mechanism detection
Steve Holme [Mon, 4 Jun 2012 18:41:56 +0000 (19:41 +0100)]
tests: Updated pop3 tests for change in auth mechanism detection

12 years agopop3: Changed the sasl mechanism detection from auth to capa
Steve Holme [Mon, 4 Jun 2012 18:09:45 +0000 (19:09 +0100)]
pop3: Changed the sasl mechanism detection from auth to capa

Not all SASL enabled POP3 servers support the AUTH command on its own
when trying to detect the supported mechanisms. As such changed the
mechanism detection to use the CAPA command instead.

12 years agocurl_easy_setopt.3: proto updates + cleanups
Daniel Stenberg [Mon, 4 Jun 2012 17:59:48 +0000 (19:59 +0200)]
curl_easy_setopt.3: proto updates + cleanups

- For all *FUNCTION options, they now all show the complete prototype in
  the description. Previously some of them would just refer to a
  typedef'ed function pointer in the curl.h header.

- I made the phrasing of that "Pass a pointer to a function that matches
  the following prototype" the same for all *FUNCTION option descriptions.

- I removed some uses of 'should'. I think I sometimes over-use this
  word as in many places I actually mean MUST or otherwise more specific
  and not-so-optional synonyms.

12 years agotests 1348 to 1355: several -O -J -i -D combinations with FTP protocol
Yang Tse [Mon, 4 Jun 2012 17:40:04 +0000 (19:40 +0200)]
tests 1348 to 1355: several -O -J -i -D combinations with FTP protocol

Currently 1348 to 1354 succeed but a write failure is logged in traceNNNN.

Currently 1355 fails, so disabled for now.

12 years agotests 1346 to 1347: several -O -J -i -D combinations with HTTP protocol
Yang Tse [Mon, 4 Jun 2012 16:54:24 +0000 (18:54 +0200)]
tests 1346 to 1347: several -O -J -i -D combinations with HTTP protocol

12 years agosasl: Small code tidy up
Steve Holme [Mon, 4 Jun 2012 10:02:03 +0000 (11:02 +0100)]
sasl: Small code tidy up

Reworked variable names in Curl_sasl_create_cram_md5_message() to match
those in Curl_sasl_create_digest_md5_message() as they are more
appropriate.