Armin Novak [Wed, 4 Apr 2018 08:45:07 +0000 (10:45 +0200)]
Fixed integer to float type cast.
Armin Novak [Wed, 4 Apr 2018 08:44:51 +0000 (10:44 +0200)]
Fixed printf format string.
Armin Novak [Wed, 4 Apr 2018 08:43:31 +0000 (10:43 +0200)]
Fixed intrinsic integer overflow.
Adding 128 in 8bit is not possible due to range [-128,127].
Instead subtract -128, that should eliminate the overflow.
akallabeth [Wed, 4 Apr 2018 08:35:47 +0000 (10:35 +0200)]
Merge pull request #4457 from RangeeGmbH/fix_custom_sizes
Fix /size: /w: /h: with /monitors: (Fix custom sizes)
MartinHaimberger [Wed, 4 Apr 2018 08:12:04 +0000 (10:12 +0200)]
Merge pull request #4472 from akallabeth/win_mouse_button
[WIN] Added additional mouse mappings.
MartinHaimberger [Wed, 4 Apr 2018 08:06:07 +0000 (10:06 +0200)]
Merge pull request #4477 from akallabeth/command_line_fix
Detect command line flags in case RDP or MSINCIDENT files are used.
MartinHaimberger [Wed, 4 Apr 2018 08:04:58 +0000 (10:04 +0200)]
Merge pull request #4416 from akallabeth/audin_fix
Audin fix
Martin Fleisz [Wed, 4 Apr 2018 07:32:46 +0000 (09:32 +0200)]
Merge pull request #4529 from akallabeth/wlog_cleanup_fix
Fix #4524: Initialize with cleanup handler
akallabeth [Tue, 3 Apr 2018 13:52:35 +0000 (15:52 +0200)]
Merge pull request #4519 from mfleisz/cssp_nonce_fix
cssp: Fix handling of nonce
akallabeth [Tue, 3 Apr 2018 13:04:32 +0000 (15:04 +0200)]
Merge pull request #4532 from RangeeGmbH/cmdline_spelling
Fix spelling of network commandline values
Kai Harms [Tue, 3 Apr 2018 12:12:58 +0000 (12:12 +0000)]
Fix spelling of network commandline values
Armin Novak [Tue, 3 Apr 2018 12:04:22 +0000 (14:04 +0200)]
Use __attribute__((destructor)) on non windows systems.
atexit in shared libraries is not universally supported.
Armin Novak [Tue, 3 Apr 2018 11:06:41 +0000 (13:06 +0200)]
Removed all calls to WLog_Init and WLog_Uninit
Since the calls are no longer required remove their usage.
Armin Novak [Tue, 3 Apr 2018 10:55:17 +0000 (12:55 +0200)]
Removed winpr_exit
As the cleanup functions are called by atexit a dedicated
cleanup call is no longer required.
akallabeth [Tue, 3 Apr 2018 08:22:08 +0000 (10:22 +0200)]
Merge pull request #4527 from jkaivo/master
PCB support
Armin Novak [Tue, 3 Apr 2018 07:59:42 +0000 (09:59 +0200)]
Fix #4524: Initialize with cleanup handler
Use singleton initializer and register cleanup handler for logger.
Jakob Kaivo [Sun, 1 Apr 2018 02:15:39 +0000 (22:15 -0400)]
add support for the "pcb" block in .rdp files provided by Project Honolulu in the VM interface
Bernhard Miklautz [Fri, 30 Mar 2018 15:20:50 +0000 (17:20 +0200)]
Merge pull request #4522 from UndefBehavior/fix_SCardStatusW
Fix SCardStatusW function
UndefBehavior [Fri, 30 Mar 2018 14:11:24 +0000 (07:11 -0700)]
Fix SCardStatusW function
Terminating null character was inserted in the middle of readerNames instead of
last position in the unicode version of SCardStatus function.
This commit fix it.
Martin Fleisz [Thu, 29 Mar 2018 13:50:16 +0000 (15:50 +0200)]
cssp: Fix handling of nonce
Kai Harms [Mon, 26 Feb 2018 14:38:16 +0000 (14:38 +0000)]
Fix /size: /w: /h: with /monitor: (Fix custom sizes)
Fix weird rectangle by removing checks
Armin Novak [Fri, 9 Feb 2018 13:04:10 +0000 (14:04 +0100)]
Fixed #4412: memory corruption in audin channel.
Armin Novak [Fri, 9 Feb 2018 12:49:58 +0000 (13:49 +0100)]
Audin channel use dynamic logger where possible.
Bernhard Miklautz [Mon, 26 Mar 2018 12:31:14 +0000 (14:31 +0200)]
Merge pull request #4513 from chipitsine/travis-new
initial travis-ci support
akallabeth [Mon, 26 Mar 2018 11:09:11 +0000 (13:09 +0200)]
Merge pull request #4512 from chipitsine/master
resolve several possible null pointer dereference
Ilya Shipitsin [Sun, 25 Mar 2018 16:38:46 +0000 (21:38 +0500)]
initial travis-ci support
Ilya Shipitsin [Sat, 24 Mar 2018 12:46:39 +0000 (17:46 +0500)]
resolve several possible null pointer dereference
issue detected by cppcheck
[channels/drive/client/drive_main.c:454] -> [channels/drive/client/drive_main.c:443]: (warning) Either the condition '!irp' is redundant or there is possible null pointer dereference: irp.
[client/X11/xf_window.c:582] -> [client/X11/xf_window.c:580]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc.
[winpr/libwinpr/path/test/TestPathShell.c:40] -> [winpr/libwinpr/path/test/TestPathShell.c:43]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.
[winpr/libwinpr/path/test/TestPathShell.c:49] -> [winpr/libwinpr/path/test/TestPathShell.c:52]: (warning) Either the condition '!path' is redundant or there is possible null pointer dereference: path.
akallabeth [Fri, 23 Mar 2018 13:12:19 +0000 (14:12 +0100)]
Merge pull request #4510 from mfleisz/cssp_version_fix
cssp: Separate client/server version handling (#4502)
Martin Fleisz [Fri, 23 Mar 2018 11:12:08 +0000 (12:12 +0100)]
cssp: Separate client/server version handling (#4502)
Bernhard Miklautz [Thu, 22 Mar 2018 16:03:52 +0000 (17:03 +0100)]
Merge pull request #4508 from h3xx/fix-ccache-support
Fix ccache support
Dan Church [Wed, 21 Mar 2018 16:57:36 +0000 (11:57 -0500)]
Fix ccache support
Setting the compiler launcher to "ccache" is the recommended way of
enabling ccache for the build.
If cmake is run with it defined, it causes an error when ccache tries to
run:
ccache: error: Recursive invocation (the name of the ccache binary must be "ccache")
This was because the compiler was getting invoked as
"ccache ccache [COMPILER]"
David Fort [Wed, 21 Mar 2018 13:19:51 +0000 (14:19 +0100)]
Merge pull request #4469 from akallabeth/win_server_fix
Fixed windows shadow server update copy.
akallabeth [Wed, 21 Mar 2018 12:36:46 +0000 (13:36 +0100)]
Merge pull request #4504 from mfleisz/cssp_warnings
cssp: Fix warnings (#4503)
Martin Fleisz [Wed, 21 Mar 2018 10:30:02 +0000 (11:30 +0100)]
cssp: Fix warnings (#4503)
akallabeth [Wed, 21 Mar 2018 11:34:46 +0000 (12:34 +0100)]
Merge pull request #4505 from bmiklautz/nightlies_bionic
pkg freerdp-nightly: fix build on bionic
Bernhard Miklautz [Wed, 21 Mar 2018 11:00:01 +0000 (12:00 +0100)]
pkg freerdp-nightly: fix build on bionic
akallabeth [Tue, 20 Mar 2018 10:02:40 +0000 (11:02 +0100)]
Merge pull request #4499 from mfleisz/cssp_v6
cssp: Add support for protocol version 6
Martin Fleisz [Tue, 20 Mar 2018 08:57:30 +0000 (09:57 +0100)]
cssp: Add support for protocol version 6
David Fort [Mon, 19 Mar 2018 18:12:02 +0000 (19:12 +0100)]
Merge pull request #4497 from akallabeth/kwin_multimon
Fix #2707: Set fullscreen first
Armin Novak [Mon, 19 Mar 2018 10:54:06 +0000 (11:54 +0100)]
Fix #2707: Set fullscreen first
Due to kwin bug https://bugs.kde.org/show_bug.cgi?id=391960
multimonitor fullscreen is not applied correctly with the
previous approach.
David Fort [Sat, 17 Mar 2018 16:07:48 +0000 (17:07 +0100)]
Merge pull request #4495 from akallabeth/header_fix
Fixed #4493: duplicate typedef.
Armin Novak [Sat, 17 Mar 2018 14:25:06 +0000 (15:25 +0100)]
Fixed #4493: duplicate typedef.
akallabeth [Wed, 14 Mar 2018 13:34:01 +0000 (14:34 +0100)]
Merge pull request #4487 from bmiklautz/KB4088776
fix nla: don't use server version
Bernhard Miklautz [Wed, 14 Mar 2018 12:39:23 +0000 (13:39 +0100)]
fix nla: don't use server version
FreeRDP currently only supports CredSSP protocol version 3. However the
current implementation always sent back the version received by the
server indicating that this version was supported.
With recent windows updates applied the protocol changed and this approach
doesn't work anymore (see
https://msdn.microsoft.com/en-us/library/mt752485.aspx for protocol changes).
With this fix FreeRDP always sends version 3 as supported version.
Credit goes to @mfleisz.
Fixes #4449
Martin Fleisz [Mon, 12 Mar 2018 15:11:48 +0000 (16:11 +0100)]
Merge pull request #4473 from akallabeth/mac_timer
Added WaitableTimer implementation for mac OS.
Armin Novak [Thu, 8 Mar 2018 12:46:46 +0000 (13:46 +0100)]
Added WaitableTimer implementation for mac OS.
Armin Novak [Fri, 9 Mar 2018 13:25:45 +0000 (14:25 +0100)]
Detect command line flags in case RDP or MSINCIDENT files are used.
Armin Novak [Thu, 8 Mar 2018 09:58:47 +0000 (10:58 +0100)]
Added additional mouse mappings.
Armin Novak [Tue, 6 Mar 2018 14:52:24 +0000 (15:52 +0100)]
Do not clear invalid region if no client connected.
Armin Novak [Tue, 6 Mar 2018 14:43:54 +0000 (15:43 +0100)]
Fixed windows shadow server update copy.
Martin Fleisz [Wed, 7 Mar 2018 14:13:22 +0000 (15:13 +0100)]
Merge pull request #4471 from akallabeth/thread_function_fix
Thread and Threadpool work function fix
Armin Novak [Wed, 7 Mar 2018 13:47:06 +0000 (14:47 +0100)]
Fixed compiler warnings.
Armin Novak [Wed, 7 Mar 2018 11:42:17 +0000 (12:42 +0100)]
Fixed threadpool work function return and arguments.
Armin Novak [Wed, 7 Mar 2018 11:03:10 +0000 (12:03 +0100)]
Fixed thread function return and parameters.
akallabeth [Wed, 7 Mar 2018 13:05:22 +0000 (14:05 +0100)]
Merge pull request #4470 from mfleisz/misc_fixes
Various fixes after running VS 2017 code analysis
akallabeth [Wed, 7 Mar 2018 12:47:23 +0000 (13:47 +0100)]
Merge pull request #4464 from perkerk/misc-windows-client
Misc changes for Windows client
Eric Brown [Wed, 7 Mar 2018 10:40:18 +0000 (04:40 -0600)]
Remove NULL check before _aligned_free call
Eric Brown [Wed, 7 Mar 2018 10:30:15 +0000 (04:30 -0600)]
Clean up mf_uninit
Martin Fleisz [Wed, 7 Mar 2018 09:17:17 +0000 (10:17 +0100)]
Merge pull request #4454 from akallabeth/nightly
Use a custom command to generate helper tool
Martin Fleisz [Tue, 6 Mar 2018 15:35:56 +0000 (16:35 +0100)]
rdpei: Fix possible NULL ptr access
Martin Fleisz [Tue, 6 Mar 2018 15:34:36 +0000 (16:34 +0100)]
drive: Fix possible NULL ptr access
Martin Fleisz [Tue, 6 Mar 2018 15:32:36 +0000 (16:32 +0100)]
debug: Fix broken format specifiers
Martin Fleisz [Tue, 6 Mar 2018 15:03:13 +0000 (16:03 +0100)]
drdynvc: Fix possible NULL pointer accesses
Martin Fleisz [Tue, 6 Mar 2018 15:02:28 +0000 (16:02 +0100)]
codec: Another realloc fix
Martin Fleisz [Tue, 6 Mar 2018 14:52:34 +0000 (15:52 +0100)]
core: Fix possible out-of-bounds read
Martin Fleisz [Tue, 6 Mar 2018 14:39:03 +0000 (15:39 +0100)]
nla: Add NULL pointer check
Martin Fleisz [Tue, 6 Mar 2018 14:34:55 +0000 (15:34 +0100)]
codec: Prevent invalid mem access on realloc failure
Martin Fleisz [Tue, 6 Mar 2018 14:32:04 +0000 (15:32 +0100)]
codec: Fix broken reallocs
Bernhard Miklautz [Tue, 6 Mar 2018 14:08:57 +0000 (15:08 +0100)]
Merge pull request #4468 from akallabeth/transport_fix_handle
Fix invalid handle offset.
Armin Novak [Tue, 6 Mar 2018 12:58:40 +0000 (13:58 +0100)]
Fix invalid handle offset.
Eric Brown [Mon, 5 Mar 2018 19:20:41 +0000 (13:20 -0600)]
Fix memory leak of Decompress buffer in client wf_Bitmap_Free
Eric Brown [Mon, 5 Mar 2018 18:32:42 +0000 (12:32 -0600)]
Remove unnecessary WM_SETCURSOR handling from wf_event_proc
Eric Brown [Fri, 2 Mar 2018 18:42:04 +0000 (12:42 -0600)]
Misc fixes for Windows clients
Eric Brown [Fri, 2 Mar 2018 18:39:59 +0000 (12:39 -0600)]
Support EmbeddedWindow in wf_resize_window
Eric Brown [Fri, 2 Mar 2018 18:39:28 +0000 (12:39 -0600)]
Fix H.264 codec init access violation on Windows N/KN systems
Martin Fleisz [Thu, 1 Mar 2018 11:08:47 +0000 (12:08 +0100)]
Merge pull request #4459 from akallabeth/surface_cmd_fix
Fixed read/write of surface bits command.
Armin Novak [Wed, 28 Feb 2018 09:10:09 +0000 (10:10 +0100)]
Fixed read/write of surface bits command.
The optional field exBitmapDataHeader of TS_ BITMAP_DATA_EX was ignored.
Read and expose the data (currently unused)
Martin Fleisz [Wed, 21 Feb 2018 15:56:55 +0000 (16:56 +0100)]
Merge pull request #4450 from akallabeth/assist_fix
Assistance and RDP file parser fix
Armin Novak [Wed, 21 Feb 2018 12:14:45 +0000 (13:14 +0100)]
Use a custom command to generate helper tool
Removing elements from CMAKE_C_FLAGS is not reliable,
to use a custom command to compile the helper tool
with default CFLAGS for the system.
Martin Fleisz [Tue, 20 Feb 2018 10:10:57 +0000 (11:10 +0100)]
Merge pull request #4451 from akallabeth/gsm_leak_fix
Clean up GSM context on channel close.
Martin Fleisz [Mon, 19 Feb 2018 16:28:32 +0000 (17:28 +0100)]
Merge pull request #4441 from akallabeth/paa
[cleanup] Support for gatewayaccesstoken / PAA
Armin Novak [Mon, 19 Feb 2018 13:03:49 +0000 (14:03 +0100)]
Free gsmBuffer on channel close.
Armin Novak [Mon, 19 Feb 2018 12:05:53 +0000 (13:05 +0100)]
Clean up GSM context on channel close.
Armin Novak [Mon, 19 Feb 2018 09:00:54 +0000 (10:00 +0100)]
Fixed .rdp and .msrcIncident checks.
The command line detection fails, if only one of the aforementioned
files is used as an argument. Detect those first and ignore command
line detection if found.
Armin Novak [Mon, 19 Feb 2018 09:00:23 +0000 (10:00 +0100)]
Added assistance file name NULL check.
MartinHaimberger [Fri, 16 Feb 2018 14:45:01 +0000 (15:45 +0100)]
Merge pull request #4448 from akallabeth/nightly_manpage_fix
Nightly manpage fix
Armin Novak [Fri, 16 Feb 2018 12:45:18 +0000 (13:45 +0100)]
Reenable -DWITH_SANITIZE_ADDRESS=ON for i386 builds.
Now that the manpage helper tool is always build without
address sanitizer there is no longer a reason to deactivate.
Armin Novak [Fri, 16 Feb 2018 12:42:10 +0000 (13:42 +0100)]
manpage helper tool generation fixes
The generator tool is called by CMake and is incompatible
with certain options. Therefore this commit
* removes WinPR dependency
* removes -fsanitize=* from CFLAGS
Martin Fleisz [Fri, 16 Feb 2018 09:54:03 +0000 (10:54 +0100)]
Merge pull request #4447 from akallabeth/apple_rpath_namespace
Apple rpath namespace fixes
Armin Novak [Fri, 16 Feb 2018 09:05:28 +0000 (10:05 +0100)]
Fixed apple rpath settings.
Armin Novak [Fri, 16 Feb 2018 09:05:11 +0000 (10:05 +0100)]
Removed apple flat-namespace hack.
David Fort [Fri, 16 Feb 2018 08:30:27 +0000 (09:30 +0100)]
Merge pull request #4446 from akallabeth/sam_crash_fix
Fix #3335: Do not call fclose on NULL file.
Armin Novak [Fri, 16 Feb 2018 07:57:05 +0000 (08:57 +0100)]
Fix #4445: Do not call fclose on NULL file.
Martin Fleisz [Thu, 15 Feb 2018 11:22:50 +0000 (12:22 +0100)]
Merge pull request #4440 from akallabeth/silence_unused_profiler
Disable unused variable warning from profiler.
Armin Novak [Thu, 15 Feb 2018 09:19:15 +0000 (10:19 +0100)]
Fix PROFILER_* macros
Add the semicolon to the macro to allow clean
undefinition if the profiler is not used.
This used to break VisualC compilers.
Martin Fleisz [Thu, 15 Feb 2018 10:02:37 +0000 (11:02 +0100)]
Merge pull request #4414 from akallabeth/pthread_cleanup_fix
Pthread cleanup fix
Jacco Braat [Tue, 13 Feb 2018 15:40:23 +0000 (16:40 +0100)]
Modified RDG connection setup using PAA Cookie.
Skip NTLM auth on the IN/OUT channels. Add PAACookie to TUNNEL_CREATE.
Jacco Braat [Tue, 13 Feb 2018 13:59:33 +0000 (14:59 +0100)]
Added to rdp file parsing: gatewayaccesstoken:s:<token>
Added to commandline parsing: /gat:<token>
Added GatewayAccessToken to sings
Martin Fleisz [Thu, 15 Feb 2018 09:39:33 +0000 (10:39 +0100)]
Merge pull request #4325 from akallabeth/fixes_com
Fixes serial redirection name check and SAM file parser
Martin Fleisz [Thu, 15 Feb 2018 09:06:05 +0000 (10:06 +0100)]
Merge pull request #4415 from akallabeth/drdynvc_dyn_log
Prefer dynamic logger in dynamic channel.