Harish Kumara Marappa [Fri, 10 Jul 2015 12:49:36 +0000 (18:19 +0530)]
Fix for observe request handling issue.
This change set also includes code for notifying the application layer
when simulator resource model gets changed.
Change-Id: If1cae07038485636aef46a4fe5d76d17d05666ec
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1619
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Harish Kumara Marappa [Thu, 9 Jul 2015 18:27:40 +0000 (23:57 +0530)]
Base code for simulator module.
This changeset has following features
1. Service provider creation and deletion.
2. Request validation and response creation.
3. Handling notification requests.
4. Handling Service Provider automation.
Change-Id: I2ea21c7daf77414c21a709d02f3b3717b4a21417
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1525
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Tested-by: Uze Choi <uzchoi@samsung.com>
Jamal Haidar [Sat, 20 Jun 2015 06:19:07 +0000 (11:49 +0530)]
Fix NULL pointer dereferencing in ocstack
NULL check guard updated to call presenceResource.handle pointer only
when it is not NULL pointer.
Change-Id: I70f3f17b4a7b5c1f956efb7136458df0cc06f728
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1371
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Fri, 19 Jun 2015 23:31:45 +0000 (16:31 -0700)]
Added Valgrind generated "*.memcheck" files to the .gitignore list.
Change-Id: I6483c27e7867eacd4d05205d7ab140613b23f5af
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1370
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Satya Prakash Gupta [Thu, 18 Jun 2015 12:41:56 +0000 (18:11 +0530)]
Fix NULL pointer deferencing in policyengine.
Update ProcessAccessRequest to call IsAccessGranted only when context is
not NULL.
Change-Id: I63abb58f254a5080ba46b30203f1e43fa6b2e781
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1359
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Jaehong Jo [Wed, 10 Jun 2015 02:35:46 +0000 (11:35 +0900)]
Modify android sample app
Modify the address to be automatically entered for testing
Change-Id: Ieaecd7e26571d1e767ef70318ec027d1c827c904
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1229
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Thu, 18 Jun 2015 12:37:45 +0000 (21:37 +0900)]
[IOT-575] fixed Android Sample App in CA
there are some wrong and missed codes
after IPv6 changed
Change-Id: I965dcec243fb9ae59353595ee5a89d8ea881fe34
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1358
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 17 Jun 2015 10:38:21 +0000 (19:38 +0900)]
[IOT-570] fixed multicast issue
there are some wrong codes in IPv6 changed.
CreateEndPoint(..) API need address parameter
even through Multicast
Change-Id: Ie9829c5ee56fb81446184737904a699efd941b9d
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1323
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jamal Haidar [Tue, 16 Jun 2015 13:45:15 +0000 (19:15 +0530)]
Fix memory leak in Thing-Manager SampleAPP for Tizen Platform
In "onObserve" function locally malloc char* buf is not freed, which
creates a possible memory leak.
Change-Id: Ie8a6e6b31f580ffd4bc66c13f8f1dc3c3429a8c3
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1283
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Jamal Haidar [Tue, 16 Jun 2015 11:27:39 +0000 (16:57 +0530)]
Fix possible memory leak condition in PPM for Tizen Platform.
API app_get_id allocates memory internally, which was not freed
resulting in possible memory leak.
Change-Id: I513bda2dbb407eedd9e855703188eab180974122
Signed-off-by: Jamal Haidar <jamal.haidar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1281
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Harish Marappa <h.marappa@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Mandeep Shetty [Wed, 17 Jun 2015 17:46:02 +0000 (10:46 -0700)]
Remove logging lines running in a tight loop that flood logs.
These lines flood the logs with messages that are not useful most times
in debug mode.
Change-Id: I99aadb13379242ad529f0e075df09605a4b4d692
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1331
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Thu, 18 Jun 2015 06:06:43 +0000 (11:36 +0530)]
Fix compile warnings in srmutility unittest
Unit test was emitting a warning due to type mismatch of the constant.
Corrected it by explicitly using the proper type.
Change-Id: I58a5aa4bacf551aeebf011069a38f47ed3888814
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1336
Reviewed-by: Jon A. Cruz <jonc@osg.samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 29 May 2015 05:03:32 +0000 (14:03 +0900)]
Rename camsgparser to cafragmentation in adapter_util directory
file naming convention should be consistent throughout the entire code.
camsgparser seems to mean the control layer functionality.
Change-Id: Idb5d31fb4b480e879cb50b70588cc6ef24c6a8a6
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1134
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Satya Prakash Gupta [Thu, 18 Jun 2015 10:12:55 +0000 (15:42 +0530)]
Fix memory leak in sample app for linux
memory free applied in leakage areas
Change-Id: I34e356ff3ff5abb0072a15c526b2b37827d5b676
Signed-off-by: Satya Prakash Gupta <sp.gupta@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1341
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jaehong Jo [Thu, 18 Jun 2015 06:02:30 +0000 (15:02 +0900)]
Fixed android build error
Changed to OICStrcpyPartial
Change-Id: I8fde944a0f2b85bfdbee6adc276db209574bf422
Signed-off-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1337
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Jon A. Cruz [Wed, 17 Jun 2015 03:11:58 +0000 (20:11 -0700)]
Correct code that combined assignment with condition test.
Combining assignment with an if() condition test is prone to
errors in maintenance, triggers compile warnings and complicates
debugging.
Also fixed missing EOL at EOF.
Change-Id: I6691fdc4de915c5c95d0fa58997398e6028beaa6
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1290
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
jihwan.seo [Wed, 17 Jun 2015 10:46:56 +0000 (19:46 +0900)]
[IOT-569] fixed Transport type issue in EDR
there is previous Transport type in IPv6 changed.
Change-Id: Id91b83d673baa83bf562c68f8521f5563f931c37
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1324
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Wed, 17 Jun 2015 10:26:57 +0000 (19:26 +0900)]
[IOT-568] fixed linux sample app in CA
there are some wrong and missed codes in IPv6 changed.
Change-Id: I408a5c079a8ef1228194ce51b55a26dcd6f8c380
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1322
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Tue, 16 Jun 2015 17:11:13 +0000 (10:11 -0700)]
Fix segfault on GET for device and platform info.
The mandatory fields for device and platform are not enforced by the
stack on init. They are enforced only when the info is explicitly added.
Servers that did not register this device and platform info segfaulted
when getting discovery requests from clients.
Added a null check before dereferencing a pointer to fix the problem.
Change-Id: I8b77d149014329e60f8aa8e9c1efb761394487da
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1285
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Randeep Singh [Tue, 16 Jun 2015 02:53:24 +0000 (11:53 +0900)]
Fixed Provisioning API handling for empty and malformed payload
please refer for details https://jira.iotivity.org/browse/IOT-564
Change-Id: I04a8ca6946b6d1c371e5235303f4733c5214674e
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1279
Tested-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Jon A. Cruz [Wed, 17 Jun 2015 02:59:21 +0000 (19:59 -0700)]
Fix compile warning in oic_string unit test.
Unit test was emitting a warning due to type mismatch of the constant.
Corrected it by explicitly using the proper type.
Change-Id: Ibabdf289a46df025007b091b8a5e05f5a6ce7821
Signed-off-by: Jon A. Cruz <jonc@osg.samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1289
Reviewed-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Hauke Mehrtens [Mon, 8 Jun 2015 19:57:52 +0000 (21:57 +0200)]
libcoap: fix big endian problems
When this is build for a big endian Linux system WORDS_BIGENDIAN was
not be set. This patch sets it correctly so it will not generate broken
code on big endian systems.
This was tested on MIPS BE 32 Bit.
Change-Id: I59dd07d8020c553318e2aa43894a2185fe9b9286
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1219
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Tue, 16 Jun 2015 22:01:27 +0000 (18:01 -0400)]
Fix segfault in ocserver on invalid PUT json
If a client does a PUT with json that has the old "oc"
instead of "oic" it will cause a crash.
Change-Id: I05764cf7fe5613486d55d3a81cc757f45204dad3
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1286
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Tue, 16 Jun 2015 19:07:57 +0000 (12:07 -0700)]
IP address plumbing changes to support IPv6
IPv6 selection logic and IPv6 modifiers are now available throughout
the stack.
Builds with all samples and tests.
Works with IPv4.
Merged with security update.
Supports JIRA IOT-476,477,488,489,493,509,548
Change-Id: I539879aeeb5aeddf2b136d81fdf1247c2af12b5f
Signed-off-by: John Light <john.j.light@intel.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1081
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Erich Keane [Thu, 4 Jun 2015 23:33:04 +0000 (16:33 -0700)]
Replace/examine usages of mem* and strcat/strcpy
The codebase has a large number of mis-uses of memset, memcpy,
strcat, and strcpy. This patch replaces them with OICStrdup,
OICStrcpy, and OICStrcat where possible, and fixes a number of
issues with memcpy/memset usages throughout the code.
Change-Id: Ifa03ed611778488c28f261266eb9a8821fa4db5c
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1208
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Moumita Ray [Thu, 11 Jun 2015 16:22:25 +0000 (09:22 -0700)]
Fixed double free corruption in occlientbasicops handler
The scenario described in IOT-554 caused memory corruption in occlientbasicops
where OICFree is called twice in order to clean up ResourceNode List.
Removing explicit free calls in freeResourceList fixes the problem described
in IOT-554.
Change-Id: If5be1104cfb8804846f8fd684d59b018fb0401ba
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1244
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Mon, 15 Jun 2015 18:48:01 +0000 (11:48 -0700)]
Added REST query parser
Implemented rest query parser and added unit test for the parser's API.
Also added code to handle query in Doxm resource.
Change-Id: Id3dc6c171d9faa25a44849b316eaa54171a997a6
Signed-off-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1216
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Sakthivel Samidurai [Fri, 12 Jun 2015 18:46:32 +0000 (11:46 -0700)]
Provisioning Manager to send CON request
Replace non-confirmable request to confirmable for the Provisioning
Manager.
Change-Id: I2cae1564d1c96c1cb35ced97813983467a6d96f2
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1260
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Shilpa Sodani <shilpa.a.sodani@intel.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Ravi Nanjundappa [Fri, 12 Jun 2015 09:43:12 +0000 (15:13 +0530)]
Updated README files to refer to usage of scons
Changed README files in resource/csdk/connectivity/samples/linux/
and resource/csdk/stack/ directories to refer to usage of scons
instead of make commands.
Removed trailing whitspaces as well, as recommended from Erich
and also removed the references to sample.sh as per
https://gerrit.iotivity.org/gerrit/#/c/1253/
Change-Id: I9f61ea80c12b48f0a86ea4ff24e0758d288ddc8e
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1254
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Fri, 12 Jun 2015 09:23:41 +0000 (14:53 +0530)]
Remove sample.sh file
sample.sh file in resource/csdk/connectivity/samples/linux/
directory is not used after scons adaption. We can remove this file
Change-Id: Ica2bc6188696fd44a567b053dce899431252f0e1
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1253
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Thu, 11 Jun 2015 23:39:56 +0000 (16:39 -0700)]
Updated resource discovery parsing logic for new 'policy' node
Recently resource discovery payload was updated to add a new
policy node. This changeset updated the payload parsing logic
for secure client application.
Change-Id: I3b256a0f3f496fe058890eec92587eb5b2fab241
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1246
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 12 Jun 2015 16:55:05 +0000 (09:55 -0700)]
Fixed memory leak in OICStrdup test
OICStrdup test didn't release its result memory, this fix
ensures that it is properly released.
Change-Id: Ieb271c5fbace45a730905de4dd02f2208bbf42e5
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1259
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jnashok [Thu, 4 Jun 2015 08:18:03 +0000 (17:18 +0900)]
Update NDK build with common source location change
oic_malloc and oic_string are moved to resource/c_common directory
in the patch https://gerrit.iotivity.org/gerrit/#/c/1163/
Updating android make file with the changes to fix the build
Change-Id: I297b6a25ee6a7fd744174194f9e37a877ba7cd57
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1191
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Hyuna Jo <hyuna0213.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Fri, 12 Jun 2015 08:59:57 +0000 (14:29 +0530)]
Added unit tests for StackStop
Unit test modified to exercise code paths
* for checking OCStop() without any OCInit()
* to check for repeated OCStop()s after one OCInit()
Change-Id: I78a817befdce335d3dba40e5aee62275784f4ef2
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1252
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Caiwen Zhang [Fri, 12 Jun 2015 01:10:45 +0000 (09:10 +0800)]
Fix cross compile link error
If call ld directly some flags (e.g. -m32) can't be recoglized.
Change-Id: I7f0c62c9f9e7530baf61ed9c658aa1cb15008009
Signed-off-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1248
Reviewed-by: Nirav Shah <nirav.j2.shah@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Omkar Hegde [Thu, 11 Jun 2015 22:09:38 +0000 (15:09 -0700)]
Changing ocstack to retrieve double instead of int using cJson
Previously, we retrieved the sequence no. from presence payload
using object->valueint. Since the sequence no. is 32-bit unsigned
int, this caused the valueint to overflow. Hence, changing it to
object->valuedouble. This should fix IOT-549.
Change-Id: Idd30408c617e2ff84faa7c7c7f2a3f028577d337
Signed-off-by: Omkar Hegde <omkar.m.hegde@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1245
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Thu, 11 Jun 2015 19:20:53 +0000 (15:20 -0400)]
fix master because cherry-picked change broke build
Change-Id: Idded4c0bedd28ce6d2064737f1ec1b7ddc630599
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1243
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Charlie Lenahan [Tue, 19 May 2015 20:54:32 +0000 (16:54 -0400)]
Add EntityHandler callback parameter to C SDK.
Allows C api users to have a context callback parameter
with the use of EntityHandler callbacks for OCCreateResource.
Change-Id: I1358b6dbd5c2a9a1940f6146a87aacf84c16bb3c
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1042
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-by: Patrick Lankswert <patrick.lankswert@intel.com>
Jay Sharma [Fri, 5 Jun 2015 13:08:29 +0000 (18:38 +0530)]
Fix for the Jira issue IOT-538
CpluffAdapter::findPlugins and PluginManagerImpl::findPlugins methods include the
plugins which does not have the attribute of parameter "key" and when the parameter
"value" is empty string. Modified the code to handle the case where getValueByAttribute
method returns empty string value.
Change-Id: Ia2564bff28b273a3552686d16374198e223f0bb2
Signed-off-by: Jay Sharma <jay.sharma@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1206
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
YounghyunJoo [Tue, 9 Jun 2015 07:34:07 +0000 (16:34 +0900)]
Fix Android Plugin code file
For changed base code
Change-Id: If3a40333cb09a6c3bb2d6a01d275114a7ec45b14
Signed-off-by: YounghyunJoo <yh_.joo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1225
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Randeep Singh [Fri, 5 Jun 2015 08:05:53 +0000 (17:05 +0900)]
Fixed possible memory leak condition.
Provisioning API returns list of unprovisioned devices. If parameter for
list is not null it can cause memory leak, changed code from just warning
from API to error and corrected test case according to it
Change-Id: I7ffe7efe116add643c1b062f2396d3486d677273
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1203
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Sakthivel Samidurai [Mon, 8 Jun 2015 18:57:06 +0000 (11:57 -0700)]
Update pstat property name
Update the pstate commit hash property name based on the
security specification.
Change-Id: Id965150e9a1b17920e9c6339a7bc967e63f6f318
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1217
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Ravi Nanjundappa [Tue, 9 Jun 2015 08:59:16 +0000 (14:29 +0530)]
Added unit tests for StackStart
Unit test exercise code path to check for zero length
Manufacturer Name in OCSetPlatformInfo()
Change-Id: Ic0003ba1041d14a0de1e55a09f5ff6181bc19a7f
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1226
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Fri, 5 Jun 2015 08:57:22 +0000 (14:27 +0530)]
[ARDUINO] Modified sample to let user select response
Modified sample to let user select response to a request
Change-Id: I3ce60015ce2dff382429bb546618950b6080dabd
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1204
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Wed, 10 Jun 2015 14:32:23 +0000 (20:02 +0530)]
[TIZEN] Fix broken build caused by c_common merge
Tizen build was broken after merging of oic_malloc / oic_string.
Change-Id: I81ed8e5e5d5d13fd741ec66ac108f58430c8dcb9
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1233
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Hauke Mehrtens [Mon, 8 Jun 2015 20:03:19 +0000 (22:03 +0200)]
cdsk: fix big endian problem
Without this patch the client will endianes swap the port number when
sending the detailed request after it got the answer for his multicast
get. Use the same method for storing the port number in the address
array in ever part of the code and do not use memcpy and manual
bytewise coping mixed over the code. memcpy was used once and byte wise
copy was used twice so I choose the majority.
This was tested on MIPS BE 32 Bit.
Change-Id: Ib486171987004d10209d2bbf6b1d9ada75235651
Signed-off-by: Hauke Mehrtens <hauke.mehrtens@lantiq.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1220
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Mon, 8 Jun 2015 17:22:35 +0000 (10:22 -0700)]
Increase delay in presence notifications to avoid stability issues.
The C sample server, ocserver.cpp had a delay of 5 seconds before
sending out presence notifications. Failing to start the client would
cause missed notifications.
Increased delay to avoid false stability issues when testing.
This addresses IOT-546.
Change-Id: I2c9a7810d71886ff3abe7024c1f583bcd4ab65c5
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1215
Reviewed-by: Mark Tung <mark.y.tung@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Sun, 7 Jun 2015 02:57:41 +0000 (11:57 +0900)]
fixed android LE multicast
when send is failed in multicast in a device,
multicast routine just return without next step.
next device can be tried send through this fix.
Change-Id: I870c40384ddd5fbe092fdaae0db1ba03b7ccd583
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1210
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ravi Nanjundappa [Mon, 8 Jun 2015 10:24:23 +0000 (15:54 +0530)]
Bug fixing related to stringtests failures on x86
Fixed Crash issues related to Strcat in the following cases
* StrcatPartialShorterSourceLen
* StrcatPartialEqualSourceLen
* StrcatPartialLongerSourceLen
* StrcatPartialZeroSourceLen
The failures were due to buffer overflow during memset.
Change-Id: Ie588c7288377bea59366e8e1ebf9fed78f4fe5b1
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1213
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Abhishek Sharma [Thu, 4 Jun 2015 14:19:41 +0000 (19:49 +0530)]
[ARDUINO] [BLE / IP] Fixed broken BLE build and IP crash
> Fixed broken Arduino BLE build
> Fixed IP crash
Change-Id: I1d367fd9b27a9a39b10d4fba267ca070daacd6e0
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1192
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 5 Jun 2015 04:39:55 +0000 (13:39 +0900)]
Add proguard-project.txt to the .gitignore file
The generated file proguard-project.txt was previously checked
in accidentally. This patch adds it to the .gitignore so that
errors like this won't happen in the future.
Change-Id: Ic26b0d48bbb4bf50445e7314ecac6d9979b51e9d
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1196
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: Erich Keane <erich.keane@intel.com>
arya.kumar [Fri, 5 Jun 2015 11:19:27 +0000 (16:49 +0530)]
Fix for the Jira issue IOT- 531 and review comment fixes
Change-Id: I598491a857e95af37b03f44eac200d775728e6c9
Signed-off-by: arya.kumar <arya.kumar@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1141
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Hun-je Yeon <hunje.yeon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
krishna.kb [Tue, 2 Jun 2015 06:20:34 +0000 (11:50 +0530)]
Fix for JIRA Issue IOT-535 and IOT-536
Change-Id: I5d581e8e2d98fa55f2718fecfa8143d0d59d6d17
Signed-off-by: Krishna Kumar KB <krishna.kb@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1167
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Younghyun Joo <yh_.joo@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Erich Keane [Fri, 5 Jun 2015 00:05:31 +0000 (17:05 -0700)]
Added Policy property to web type linking format
This change set is based on OIC core framework standard specification draft A,
Page#30,section 7.2.1.3 (Policy Property Definition).Added necessary changes
to display policy property (Discoverable,Observable, Active, Slow etc) in
JSON format. Modified core framework unit tests and samples to validate.
Change-Id: I406889d21488e3c4d49b9e3fac5d223770d9420e
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1110
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Caiwen Zhang [Fri, 5 Jun 2015 06:01:23 +0000 (14:01 +0800)]
Clean Arduino build intermediate files
1) Remove .d files
2) Remove .map file
Change-Id: Ia196d072be56a8f31a492804e4d2d9a94ea43fec
Signed-off-by: Caiwen Zhang<caiwen.zhang@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1199
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Sachin Agrawal [Thu, 4 Jun 2015 16:51:01 +0000 (09:51 -0700)]
Merging security-M3 to master
Added support for resource access control, anonymous ECDH,
and Just Works Provisioning.
Patch 1 : Squashed all security-M3 patches and rebased to
common ancestor of security-M3 and master.
Patch 2 : Rebased to master. (Arduino build fails).
Patch 3-4 : Fix the unit test failures.
Patch 5 : Fix the previsioning server send request issue
by adding token length.
Patch 6 : Fixed Arduino compilation.
Patch 7 : Fixed DTLS handshake issue.
Patch 8 : Fix the build issue.
Patch 9 : Replaced strncmp with memcmp, As token handling is
from null terminated string to byte buffer.
Patch 10: Rebased with master.
Patch 11-12: OSX Build Failure Fixes.
Patch 13: Updated README related to secure-Iotivity stack.
Patch 14: Fixed issues identified in Patch 5.
Patch 15: Rebased with master to avoid merge conflicts.
Patch 16: Updated commit message
Change-Id: Icae698c3bf377862b561d6ebba1d784058d28adb
Signed-off-by: Sachin Agrawal <sachin.agrawal@intel.com>
Signed-off-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Signed-off-by: Randeep Singh <randeep.s@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1071
jnashok [Wed, 3 Jun 2015 01:54:36 +0000 (10:54 +0900)]
NDK build Fix to support DTLS in Android sample
As the DTLS flag was not defined for in sample application
Android.mk, secure message sending fails, as credentials
cannot be set.This patch fixes the issue
Change-Id: I3f44cb1b299c967855112f9f1c3981b8499815e2
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1177
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Thu, 4 Jun 2015 00:14:17 +0000 (20:14 -0400)]
Add script license headers.
Change-Id: I94b31f4e7971d9840d760e8a5deb5478e17f7b7f
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1186
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
hyuna0213.jo [Thu, 4 Jun 2015 05:37:29 +0000 (14:37 +0900)]
remove the unnecessary file.
proguard-project.txt is the unnecessary file.
so this file should be removed for open source.
Change-Id: Ib6c78cf7c1e104bc19ace44e1a965a0c6d368e6f
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1190
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Tue, 2 Jun 2015 00:15:24 +0000 (17:15 -0700)]
Moved oic_string and combined mallocs to central place
Created the c_common directory to contain all stuff common
to the C stack. Currently, oic_string has been added. Additionally,
ocmalloc and oic_malloc have been combined and moved to this directory.
Future targets will be the ocrandom and oc/oic_logger libraries.
Change-Id: Ic4858881565367b3e69b47d6b0e0145a42d4ace0
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1163
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Ravi Nanjundappa [Wed, 3 Jun 2015 10:29:52 +0000 (15:59 +0530)]
Addressed build warnings in resource folder.
Fixed compile-time warnings regarding
* not handling a enumeration value in switch case of OCException
* unused exit label and
* comparison between signed and unsigned integer expressions
in resource/csdk/ and resource/src folders.
Change-Id: Ia2d00ec335db56a5070cbe222093d392dd3a531c
Signed-off-by: Ravi Nanjundappa <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1182
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
nravi [Tue, 2 Jun 2015 06:05:20 +0000 (11:35 +0530)]
Added unit tests for OCCreateResource()
Unit tests exercise code paths to check for invalid URI field.
Change-Id: Id4f1f759c5d554e808af7da77194b688d2283d7b
Signed-off-by: nravi <nravi.n@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1166
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Wed, 20 May 2015 07:48:12 +0000 (16:48 +0900)]
Adding Error handling from CA to RI
This is the first step to add the error handling
Error handling in adapters will be added incrementally
Change-Id: I6d27133cab49d5945e9eb42ea734d7ad881e89b8
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1046
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jaehong.jo [Wed, 3 Jun 2015 04:43:54 +0000 (13:43 +0900)]
Fix to android EDR multicast
When send data fail, do not return.
Try to send data to next bonded list.
Change-Id: I7d3d16b768c72ca4f81c8cf7a2e8be400502986f
Signed-off-by: jaehong.jo <jaehong.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1178
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Tue, 2 Jun 2015 15:37:32 +0000 (11:37 -0400)]
Refactored android default ArchType check in SConscript.
According to SCons' wiki, checking strings should be done with "==" and
not "is". "is" is to be used for checking against the ID value for a
value and not the value, while "==" checks against the value.
Change-Id: I28710e324d998098cd22bb615a03c388f6903f18
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1170
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Fri, 29 May 2015 07:33:51 +0000 (16:33 +0900)]
Fixed [IOT-539] issue for CAInitialize
CA APIs is returning CA_STATUS_OK without CAInitialize.
so we have fixed it through some flag is used.
Change-Id: I1adfee5a0e9dfbd3b91acc851fea52b2f7740619
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1138
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 29 May 2015 20:39:40 +0000 (13:39 -0700)]
Fixes for strcat/strcpy implementation
Jon Cruz suggested a number of ways of simplifying the Strcpy/StrCat
implementation, sot his contains them. Additionally, the error
conditions are now run-time so as to be entirely run-time safe, rather
than asserts, which resulted in some nasty undefined behavio.
Change-Id: I175b0df37d822d2c95b22b6521dbfbedbe15797b
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1147
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Charlie Lenahan [Fri, 29 May 2015 19:28:16 +0000 (15:28 -0400)]
Remove CreateResourceWithHost calls.
"host" member is never referenced anywhere or returned in
any callbacks,so it is just a blackhole.
Change-Id: I957e44361851191c2a834528e60a3007e58db026
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1143
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 29 May 2015 22:21:27 +0000 (15:21 -0700)]
Fixed trailing-comma in too-long JSON discovery packet
The logic for removing the trailing comma in the event that a resource
was improperly added was reversed. This removes the "NOT" to correct
this so that the comma is only removed in the event that it was actually
added.
Change-Id: I4f6037198ef7a67cd3d83d77f5e27aebb7cc0b28
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1155
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jnashok [Fri, 29 May 2015 05:12:49 +0000 (14:12 +0900)]
Fix to avoid android log messages in release mode
Problem occured due to android logs defined when TB_LOG is not enabled
Removed the code to fix the issue
Change-Id: I247df1ece564b0996fcbd6929360bf0367a84107
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1135
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-by: jihwan seo <jihwan.seo@samsung.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
G S Senthil Kumar [Wed, 27 May 2015 10:05:33 +0000 (15:35 +0530)]
Constructing the libraries path in PPM at runtime loading using tizen
app framework package.
Removing libcoap.so and loading libuuid.so in tizen applications and
removed unwanted files to be packaged into rpm.
Change-Id: Ic207a0609044b39a6a3809745dea62b964bf89e1
Signed-off-by: G S Senthil Kumar <senthil.gs@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1096
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Joseph Morrow [Fri, 29 May 2015 22:30:57 +0000 (18:30 -0400)]
Fixed issue where stack logging is incorrectly enabled in release mode.
This will ensure that release mode applications & tests will not
log out extranneous messages that should only be printed in debug
mode.
Change-Id: Id66c2f511e8b31ea58cfb1e41a26c6b83daac3a1
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1156
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Fri, 29 May 2015 21:28:05 +0000 (17:28 -0400)]
Fixed template issue on Android for arch types armeabi or x86.
The issue arises because Jave templates expect the Object
type to be used and not the primitive type.Other compilers
other than armeabi and x86 (at least reproducible for
armeabi-v7a) properly convert the primitive types to their
object form.
Change-Id: I6f4916b2e6d6699c58018baf25269c369eee01a5
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1153
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Fri, 29 May 2015 22:07:14 +0000 (18:07 -0400)]
Specify proper default SCons parameter build values for Android.
This will allow an end user to simply issue "scons TARGET_OS=android" and
expect the build to work. Before this, end users had to specify
the TARGET_TRANSPORT & TARGET_ARCH parameters every time.
Change-Id: I48cea638a441fa55b1a82d320cd2a65b6cc39c01
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1154
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Fri, 29 May 2015 21:25:13 +0000 (17:25 -0400)]
Refactoring the TB_LOG flag for Android builds.
The TB_LOG flag on Android should not be defined with '-D'.
When using compilers for an arch type other than armeabi
or x86 (reproducable for sure on armeabi-v7a), the definition
for TB_LOG ended up being "-D-DTB_LOG".
This issue & solution was raised by an outside contributor
Anton Spaans <flyingdutchie@gmail.com>.
Change-Id: I9f8caeec37e241fb62772bc8d9f9628f87ff0eb0
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1152
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 29 May 2015 20:08:57 +0000 (13:08 -0700)]
Revert "Adding error handling in IP Adapter"
This reverts commit
c6f597bdc2eaf385c50be824cfb8845d7ca72e46.
Change-Id: Ia0d8b3a9b604206bb9027e170ba3fda6613aa0b3
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1146
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
jw1103.kim [Wed, 20 May 2015 08:44:14 +0000 (17:44 +0900)]
Adding error handling in IP Adapter
Change-Id: I8e59cc7d876207cdf8b29af760ff602aada35b5e
Signed-off-by: jw1103.kim <jw1103.kim@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1048
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Naga Ashok Jampani <jn.ashok@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
hyuna0213.jo [Fri, 29 May 2015 01:06:13 +0000 (10:06 +0900)]
Fix for issue of CA don't check the invalid CAResponseInfo_t.result.
currently, CA don't check the value of CAResponseInfo_t.result.
so I add the logic which CA check whether CAResponseInfo_t.result
is valid value.
This issue is related to IOT-385, IOT-386.
Change-Id: I8fdb7bc021c2b294b068d202a5bd6d5131d1904d
Signed-off-by: hyuna0213.jo <hyuna0213.jo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1133
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Thu, 21 May 2015 22:47:24 +0000 (15:47 -0700)]
Implementation of OICStrcat/OICStrcpy
Repeated mistakes based on copy and cat operations in the C
code shows that we need a unified implementation that is as safe as
possible. These implementations closely emulate the Microsoft _S
versions of these functions, which seem to be safest feature wise.
Replacing copy and cat operations is reserved for a different
commit.
Change-Id: Id1f6f4515a00679661cc722419fa0bab84a624c2
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1115
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Abhishek Sharma [Thu, 28 May 2015 07:39:29 +0000 (13:09 +0530)]
[TIZEN][DTLS] Fix broken DTLS build for Tizen
Fixed Tizen DTLS related scripts.
Change-Id: I0ace0f5e44d8b6808f7a71d994464f5202d1aa89
Signed-off-by: Abhishek Sharma <ce.abhishek@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1126
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: Sachin Agrawal <sachin.agrawal@intel.com>
Joseph Morrow [Thu, 28 May 2015 21:23:03 +0000 (17:23 -0400)]
Fixed a bug introduced in Spec Compliance change for Android
A change of the interface names in C++ was not propogated into Android API
https://gerrit.iotivity.org/gerrit/#/c/956/
Change-Id: Ida9540ea6ea45575d8c0191164b8e80a6981f393
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1103
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Thu, 28 May 2015 16:10:28 +0000 (12:10 -0400)]
Converting OTA payload for advertisements to JSON packaging.
This commit ensures that presence advertisments comply with section
11.3.4, wrt. Table 21 of the OIC Core Specification 0.9. This further
ensures that any OIC Core Spec Compliant project will be able to
send/receive advertisements with IoTivity.
Change-Id: I4df50b5a7e322c6e1c2f422de4de1b5b38fa0af9
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1123
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Joseph Morrow [Thu, 28 May 2015 19:57:09 +0000 (15:57 -0400)]
Fixed issue where Scons param 'LOGGING' is assigned wrong default value.
This will fix issue reported on the IoTivity dev list where the flag
for Stack Logging (ie. TB_LOG) was not being enabled in any Debug build
that wasn't invoked by using exactly "false" for the Scons param
'RELEASE'.
Change-Id: I19677113d3d195059cf15c7073adc6418a152a1f
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1130
Reviewed-by: Erich Keane <erich.keane@intel.com>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Joseph Morrow [Thu, 28 May 2015 17:26:07 +0000 (13:26 -0400)]
Fix issue where Boost is downloaded everytime for Android builds.
Change-Id: I6c5244ef63c360993ecf569d35f95b5eac6ed42c
Signed-off-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1124
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Charlie Lenahan [Wed, 27 May 2015 00:21:42 +0000 (20:21 -0400)]
Auto-detect OS X/iOS SDK versions.
Detects the latest SDK installed and uses that if no SYS_VERSION
param is passed to scons.
Change-Id: I5387c704df5d7649485c9c90a55f98f652da50fc
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1117
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Moumita Ray [Fri, 15 May 2015 20:28:02 +0000 (13:28 -0700)]
Changed ampersand '&' to semicolon ';' to concatenate multiple query string
This change set is based on OIC core framework standard specification draft A.
Modified '&' to ';' to separate multiple filters in a query params.
Added necessary changes in the parser to validate and parse the query
including core framework, unit tests and sample.
Change-Id: I5dd3cb130bdf1bcce5785fec5517bd8d80f5e433
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1014
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Erich Keane [Fri, 22 May 2015 21:04:14 +0000 (14:04 -0700)]
Added constructors to trivial struct types used in C++
The C++ stack uses a OCHeaderOption and OCCallbackData
directly and in situations where construction is necessary.
This patch adds a constructor to both (a trival ctor, permitted
by C++11) POD types. This cleans up the code and prevents
avoidable errors with either.
Change-Id: I744daf3bb091b646e06d23a069bbe7ee048a8e51
Signed-off-by: Erich Keane <erich.keane@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1100
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Doug Hudson [Wed, 27 May 2015 15:25:08 +0000 (11:25 -0400)]
Fix broken build for Arduino when UPLOAD=yes.
Bug documented in JIRA IOT-521.
Change-Id: I613b0abdd8a1aab75abfe5d27fbeb0ef5f86ec1b
Signed-off-by: Doug Hudson <douglas.hudson@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1120
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Sakthivel Samidurai <sakthivel.samidurai@intel.com>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Harish Kumara Marappa [Fri, 22 May 2015 09:58:14 +0000 (15:28 +0530)]
Fix for issue of NM ResourceHosting android sample not working.
Error code type changed from OCStackResult to int in
ISubscribePresenceListener::onPresenceCallback.
Change-Id: If0cc7684ca8cd1932a721bf56ca23c13fa98421f
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1092
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Harish Kumara Marappa [Tue, 26 May 2015 14:55:41 +0000 (20:25 +0530)]
Cleaning things-manager service build scripts.
Removed all unnecessary header file inclusion and libraries linking in
things-manager service build scripts. Changed Android.mk file to copy all the required libraries to "libs/armeabi" folder for building TM java layer.
Specified the connectivity_abstraction library instead of coap in SSM's
Android.mk file
Change-Id: Ie31387f77f3452b7d8420489a569a315be7301a2
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1108
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Harish Kumara Marappa [Fri, 22 May 2015 10:06:06 +0000 (15:36 +0530)]
Removed libcoap.so and added libconnectivity_abstraction.so dependency
in ResourceHostingSample and SampleProvierApp Android.mk files
Change-Id: I3a13319aa1629b7874646f1626cf173ebbe2a09c
Signed-off-by: Harish Kumara Marappa <h.marappa@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1093
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: RadhaBhavani <radha.p@samsung.com>
Reviewed-by: Madan Lanka <lanka.madan@samsung.com>
Reviewed-by: kwon doil <doil.kwon@samsung.com>
Reviewed-by: Uze Choi <uzchoi@samsung.com>
Charlie Lenahan [Tue, 19 May 2015 22:15:37 +0000 (18:15 -0400)]
Adjust compile messages to handle "Shared" targets .
Scons has compile messages for Static targets and Shared targets.
Adds shared targets for non-verbose builds, to allow warning messages
to be more visible(standout).
Change-Id: I7f4a5e7dd53c70003c963a486dcb0dfd99bb0ff7
Signed-off-by: Charlie Lenahan <charlie.lenahan@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1043
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Caiwen Zhang <caiwen.zhang@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Mandeep Shetty [Wed, 20 May 2015 22:33:17 +0000 (15:33 -0700)]
Added support for device discovery at oic/d.
Spec compliance task for adding support for device discovery.
Using a struct for Device info with the device name field that is
expected from the application. Generate device id of type UUID and
insert string representation of uuid in discovery responses.
Updated sample apps and unit tests to support changes.
Also updated android jni, OCDeviceInfo.java class and a test in
SmokeTest.java.
Change-Id: Ib2d676d2a504fb9ff177487899f74bd121dc1d59
Signed-off-by: Mandeep Shetty <mandeep.shetty@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1057
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Joseph Morrow <joseph.l.morrow@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Kishen Maloor [Mon, 25 May 2015 10:37:39 +0000 (03:37 -0700)]
Updates for the Yocto build
* Added libuuid to LIBS in the Yocto build configuration.
* Updated OICSensorBoard client for API change.
* Replaced scons script with Makefile for OICSensorBoard.
* Updated OICSensorBoardREADME to reflect the above change.
Change-Id: I8764616476b7d62d06510999535cef10c132e23d
Signed-off-by: Kishen Maloor <kishen.maloor@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1106
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Bernie Keany <bernie.keany@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jihwan.seo [Thu, 14 May 2015 10:17:59 +0000 (19:17 +0900)]
replace 'org_iotivity' with 'org_iotivity_ca' and change java file name
- replace 'org_iotivity' with 'org_iotivity_ca'
- change java file name for android callback interface
- android EDR interface code is added
- android BLE code had been separated
since Gatt Server can be only supported after Android v5.0
and interface of LE client can only be supported until v4.4
- COPY: <iotivity>resource/csdk/connectivity/samples/android
/sample_service/src/org/iotivity/ca/< CaEdrInterface.java
& CaIpInterface.java & CaLeClientInterface.java &
CaLeServerInterface.java>
PASTE to: <iotivity>/android/android_api/base/src/main/java
/org/iotivity/ca/
Change-Id: I77b605313f73f3b2677d05e99a047f541cfcda14
Signed-off-by: jihwan.seo <jihwan.seo@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/990
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Jaehong Jo <jaehong.jo@samsung.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Moumita Ray [Mon, 11 May 2015 17:39:12 +0000 (10:39 -0700)]
Renamed all references to ‘/oc/core’ to ‘/oic/res’ and '/oc to /oic'
This change set is based on OIC core framework standard specification draft A.
Modified reserved namespace to ‘/oc/core’ to ‘/oic/res’ and '/oc to /oic' for
discovery, including core framework, unit tests and samples.
Change-Id: I9721a2a70fd1e3245088b8a2f6366853db849b21
Signed-off-by: Moumita Ray <moumita.ray@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/953
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
jnashok [Tue, 26 May 2015 07:32:51 +0000 (16:32 +0900)]
[Jira] IOT-529, Fix to support multiple IP networks in Android
currently only one IP network is enabled due to the bug
Change-Id: I878dec13ec7e4da6a5b2867d8b3c28fb99d85530
Signed-off-by: jnashok <jn.ashok@samsung.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1107
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Ashok Babu Channa <ashok.channa@samsung.com>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Thiago Macieira [Tue, 7 Apr 2015 18:25:02 +0000 (11:25 -0700)]
Update .gitignore to ignore *.orig files too
Change-Id: I9a75ad8521ae4e5cbbe5ffff13d2ce8696e14c83
Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1101
Reviewed-by: Erich Keane <erich.keane@intel.com>
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Tim Kourt [Sat, 23 May 2015 01:36:22 +0000 (18:36 -0700)]
Changed behavior of the Android tests
Change-Id: I47df4d62e5b41c1b84de1f5d6fa71adacc94d295
Signed-off-by: Tim Kourt <tim.a.kourt@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1104
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: Erich Keane <erich.keane@intel.com>
Ossama Othman [Fri, 22 May 2015 16:12:15 +0000 (09:12 -0700)]
Corrected spelling. s/Unitcast/Unicast/g
Change-Id: I19639f550d7d8dc70700c9b5e2fdb54ed0a769e5
Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Reviewed-on: https://gerrit.iotivity.org/gerrit/1097
Tested-by: jenkins-iotivity <jenkins-iotivity@opendaylight.org>
Reviewed-by: John Light <john.j.light@intel.com>
Reviewed-by: Erich Keane <erich.keane@intel.com>
projects / platform / upstream / iotivity.git / log