Shigeki Ohtsu [Thu, 17 Jul 2014 14:01:40 +0000 (23:01 +0900)]
tls: fix to send TLS Alert before socket destroyed
When TLS Alert is occured in handshake, ClearOut only write it into
wbio and does not flush to socket. TLS Alert should be written to
socket with EncOut before socket is destroyed within its error
callback.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Maciej Małecki [Wed, 23 Jul 2014 13:24:07 +0000 (15:24 +0200)]
gyp: fix ARM build
According to V8 changelog, `armv7` config variable was replaced by
`arm_version`, with value either '7', '6' or 'default'.
Detect ARMv7 and ARMv6 CPUs and default to 'default'.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
cjihrig [Sun, 20 Jul 2014 02:35:07 +0000 (22:35 -0400)]
child_process: do not access stderr when stdio set to 'ignore'
Currently, checkExecSyncError() attempts to access the contents
of stderr. When stdio is set to 'ignore', this causes a crash.
This commit adds a check on the access of stderr. Closes #7966.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Wed, 23 Jul 2014 19:08:46 +0000 (23:08 +0400)]
deps: update http_parser to 2.3.0
Dean McNamee [Fri, 18 Jul 2014 07:16:28 +0000 (09:16 +0200)]
src: export additional startup functions
This allows embedders enough control to initialize node, run the
event loop, and cleanly exit (including calling handlers).
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Mon, 21 Jul 2014 18:12:11 +0000 (22:12 +0400)]
gyp: fix post-mortem in v0.11
Expose missing constants and keep symbols on OSX.
Brian White [Thu, 17 Jul 2014 04:23:15 +0000 (00:23 -0400)]
tls_wrap: remove unused variable
Closes #7957.
Ryan Graham [Thu, 10 Jul 2014 16:13:27 +0000 (09:13 -0700)]
cluster: include settings object in 'setup' event
Emits on every call to cluster.setupMaster(), even if no new settings
are given. This is because calling cluster.setupMaster() without
arguments (or with an empty options object) results in the settings
being restored to their defaults.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ryan Graham [Fri, 23 May 2014 01:56:18 +0000 (18:56 -0700)]
cluster: allow multiple calls to setupMaster()
Only attributes of 'cluster.settings' will be modified after the first
call, leaving all other cluster initialization alone. Each call that
includes a 'settings' argument triggers a 'setup' event to be emitted.
Instead of each call resetting all values to their defaults, use the
current settings (if any) as the default. This retains setupMaster's
support how cluster.fork() uses setupMaster() to ensure
cluster.settings has been populated.
Update example in docs to use current node coding style and include
an example of progressive configuration.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Sun, 13 Jul 2014 19:15:52 +0000 (23:15 +0400)]
test: fix regress-GH-1726
Dean McNamee [Wed, 9 Jul 2014 11:36:50 +0000 (13:36 +0200)]
src: pass the v8::Context to CreateEnvironment
Pass in the v8::Context, instead of creating it
within CreateEnvironment. This allows callers
to use a pre-existing context.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
cjihrig [Wed, 25 Jun 2014 03:18:00 +0000 (23:18 -0400)]
child_process: copy spawnSync() cwd option to proper buffer
The spawnSync() cwd option was being copied to the incorrect
location. This commit copies to the correct location.
Closes #7824
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ryan Graham [Mon, 7 Jul 2014 23:38:05 +0000 (16:38 -0700)]
doc: re-org child_process into async/sync
Cleaner separation between the traditional non-blocking functions and
the new blocking variants.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ryan Graham [Tue, 8 Jul 2014 19:14:58 +0000 (12:14 -0700)]
test: Remove references to customFds
Option has been deprecated since v0.5.11
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ryan Graham [Tue, 8 Jul 2014 18:33:50 +0000 (11:33 -0700)]
doc: remove customFds mentions
The feature has been marked as deprecated since v0.5.11.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ryan Graham [Tue, 8 Jul 2014 00:04:42 +0000 (17:04 -0700)]
lib: noisy deprecation of child_process customFds
Use a util.deprecate wrapper to issue warnings like any other
deprecated API. The option has been marked as deprecated in the docs
since v0.5.11.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Andrew Oppenlander [Tue, 8 Jul 2014 22:06:40 +0000 (18:06 -0400)]
streams: set default hwm properly for Duplex
Default highWaterMark is now set properly when using stream Duplex's
writableObjectMode and readableObjectMode options.
Added condition to the already existing split objectMode test to ensure
the highWaterMark is being set to the correct default value on both the
ReadableState and WritableState for readableObjectMode and
writableObjectMode.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Tue, 8 Jul 2014 18:43:48 +0000 (21:43 +0300)]
contextify: remove useless header file
fix #7910
John Albietz [Thu, 3 Jul 2014 23:15:46 +0000 (16:15 -0700)]
readme: added g++ requirement
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Robert Kowalski [Thu, 3 Jul 2014 20:39:29 +0000 (22:39 +0200)]
module: don't require fs several times
As we are going to need fs in any case, just require it at the
beginning of the file.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ed Umansky [Thu, 3 Jul 2014 00:59:28 +0000 (18:59 -0600)]
net: reset `errorEmitted` on reconnect
Fix for `error` events emitting only once when reconnecting
a single instance of net.Socket.
Fixes joyent/node#7888
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Trevor Norris [Thu, 3 Jul 2014 04:02:36 +0000 (21:02 -0700)]
lint: fix indentation
Andrius Bentkus [Wed, 2 Jul 2014 13:24:17 +0000 (15:24 +0200)]
udp: make it possible to receive empty udp packets
A udp packet can have 0 content. In that case nread will be equal to 0,
but addr != NULL.
Add test case for empty data gram packets and fixed test that checked
for OOB when length == 0.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Fedor Indutny [Wed, 2 Jul 2014 17:35:50 +0000 (19:35 +0200)]
deps: cherry-pick
eca441b2 from OpenSSL
Original commit message:
bn_exp.c: fix x86_64-specific crash with one-word modulus.
PR: #3397
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Mon, 14 Apr 2014 16:08:38 +0000 (20:08 +0400)]
tls: better error reporting at cert validation
fix #7417
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Wed, 2 Jul 2014 11:26:46 +0000 (15:26 +0400)]
child_process: accept uid/gid everywhere
Accept uid/gid option in every execute/spawn call (including
cluster.fork). Add documentation where needed.
fix #7881
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Eli Skeggs [Sat, 28 Jun 2014 05:32:50 +0000 (22:32 -0700)]
net: don't emit listening if handle is closed
Fixes #7834
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Yazhong Liu [Tue, 1 Jul 2014 13:35:35 +0000 (21:35 +0800)]
test: fix multiple_line problem in match
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ionică Bizău [Mon, 31 Mar 2014 19:06:03 +0000 (22:06 +0300)]
docs: highlight shell-codes in CONTRIBUTING.md
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Refael Ackermann [Tue, 1 Jul 2014 07:48:28 +0000 (10:48 +0300)]
configure: better detect windows 'bitness' (WOW64)
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Arnout Kazemier [Tue, 1 Jul 2014 06:44:09 +0000 (08:44 +0200)]
events: Output the event that is leaking
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Sat, 7 Jun 2014 06:00:55 +0000 (23:00 -0700)]
repl: fix multi-line input
The refactor in
3ae0b17c broke the multiline input's visual appearence.
While actually switching to this mode, the `...` prefix is not
displayed.
Additionally, account only SyntaxErrors that are happening at the parse
time, everything else should not be switching repl to the multiline
mode.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Jonathan Reem [Sat, 28 Jun 2014 18:46:42 +0000 (11:46 -0700)]
stream: only end reading on null, not undefined
The [Stream documentation for .push](http://nodejs.org/api/stream.html#stream_readable_push_chunk_encoding)
explicitly states multiple times that null is a special cased value
that indicates the end of a stream. It is confusing and undocumented
that undefined *also* ends the stream, even though in object mode
there is a distinct and important difference.
The docs for Object-Mode also explicitly mention null as the *only*
special cased value, making no mention of undefined.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Thu, 12 Jun 2014 04:38:58 +0000 (21:38 -0700)]
http: remove unused code block
fix #7769
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Yazhong Liu [Wed, 25 Jun 2014 13:18:50 +0000 (21:18 +0800)]
node: fix #7841 by overlooking the spare sourceline
Signed-off-by: Fedor Indutny <fedor@indutny.com>
cjihrig [Fri, 27 Jun 2014 04:07:16 +0000 (00:07 -0400)]
buffer: construct new buffer from buffer toJSON() output
Creating a new buffer from the toJSON() output of another
buffer does not currently work. This commit adds that
support. Closes #7849.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Fri, 27 Jun 2014 00:44:36 +0000 (04:44 +0400)]
deps: update libuv to v0.11.26
Saúl Ibarra Corretgé [Fri, 20 Jun 2014 22:43:00 +0000 (00:43 +0200)]
dns: introduce lookupService function
Uses getnameinfo to resolve an address an port into a hostname and
service.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Sat, 17 May 2014 08:42:50 +0000 (12:42 +0400)]
deps: build v8 with disassembler support
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Wed, 25 Jun 2014 10:47:59 +0000 (14:47 +0400)]
crypto: add `honorCipherOrder` argument
Add `honorCipherOrder` argument to `crypto.createCredentials`.
fix #7249
Fedor Indutny [Wed, 25 Jun 2014 10:11:09 +0000 (14:11 +0400)]
doc: document `tls.createSecureContext`
Fedor Indutny [Wed, 25 Jun 2014 07:16:08 +0000 (11:16 +0400)]
test: fix tls-client-default-ciphers
The test execution should not depend on the servers running locally.
fix #7832
Chris Dickinson [Thu, 5 Jun 2014 00:26:34 +0000 (17:26 -0700)]
dns: send lookup c-ares errors to callback
Calling dns.lookup with arguments that generate an error from c-ares
previously sent those errors back to the callback. This commit restores
the ca9eb71 behavior.
Fixes #7731.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fred K. Schott [Thu, 12 Jun 2014 18:12:54 +0000 (11:12 -0700)]
module: document important methods
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Kyle Robinson Young [Sun, 15 Jun 2014 16:04:12 +0000 (09:04 -0700)]
doc: typos in child_process
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Jan Krems [Sun, 22 Jun 2014 00:09:04 +0000 (17:09 -0700)]
doc: process: Document process.mainModule
Instrumentation code might need to find out the entry point of the
process in a global context.
Documenting the existing process.mainModule to officially support this.
Fixes #7808
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Yazhong Liu [Sun, 22 Jun 2014 15:34:47 +0000 (23:34 +0800)]
tls: using %StringSplit to split `cert.subjectaltname`
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Charles [Tue, 17 Jun 2014 22:44:11 +0000 (00:44 +0200)]
child_process: don't throw on EAGAIN
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ed Morley [Tue, 13 May 2014 12:20:36 +0000 (13:20 +0100)]
child_process: use full path for cmd.exe on Win32
Currently child_process.exec() assumes that cmd.exe is on the PATH,
and fails with a spawn ENOENT error if it is not.
The Windows 'comspec' environment variable contains the full filepath
to the default command interpreter, eg "C:\Windows\System32\cmd.exe".
Should it not be set, we fall-back to using 'cmd.exe' from PATH, as
before.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Timothy J Fontaine [Tue, 17 Jun 2014 00:20:45 +0000 (19:20 -0500)]
Merge remote-tracking branch 'upstream-rw/v0.10'
Timothy J Fontaine [Tue, 17 Jun 2014 00:16:13 +0000 (19:16 -0500)]
node: update changelog to have proper npm version
fixes #7793
Timothy J Fontaine [Fri, 13 Jun 2014 21:39:53 +0000 (14:39 -0700)]
build: run wix tool chain out of process
Building MSIs for different arch's can sometimes confuse MSBuild and
Wix, isntead run the toolchain externally so we don't have to worry
about which arch cmd.exe is running as.
Fedor Indutny [Thu, 12 Jun 2014 22:40:28 +0000 (15:40 -0700)]
contextify: throw timeout error properly
fix #7509
Fedor Indutny [Thu, 12 Jun 2014 18:21:26 +0000 (11:21 -0700)]
watchdog: terminate one specific isolate
Ben Noordhuis [Fri, 23 May 2014 14:01:17 +0000 (14:01 +0000)]
deps: cherry-pick r21466 from v8 trunk
Check for cached transition to ExternalArray elements kind.
See [1] and [2] for details.
[1] https://code.google.com/p/v8/issues/detail?id=3337
[2] https://codereview.chromium.org/
291193011
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ben Noordhuis [Wed, 14 May 2014 09:25:57 +0000 (11:25 +0200)]
deps: cherry-pick r21297 from v8 trunk
Changes the return value of PropertyCallbackInfo<T>::This() from
Local<Value> back to Local<Object>. See [1] and [2] for background.
[1] https://groups.google.com/forum/#!topic/v8-users/wP2UcQ4cBW4
[2] https://codereview.chromium.org/
285643008/
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ben Noordhuis [Mon, 12 May 2014 03:38:47 +0000 (05:38 +0200)]
deps: fix up v8 postmortem codegen
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ben Noordhuis [Mon, 12 May 2014 03:07:46 +0000 (05:07 +0200)]
deps: upgrade v8 to 3.26.33
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Euan [Thu, 5 Jun 2014 00:15:22 +0000 (20:15 -0400)]
doc: Fix typo in dns.resolveSrv docs
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Xavi Magrinyà [Sun, 8 Jun 2014 10:02:54 +0000 (13:02 +0300)]
console: console.dir() accepts options object
This features comes from the need of adding extra options when displaying
the object using console.dir().
console.dir() accepts now a second parameter that is passed to util.inspect()
in order to provide extra options to the output. These options are: depth, color
and showHidden. More information about these options in util.inspect() documentation.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Xavi Magrinyà [Sun, 8 Jun 2014 09:14:14 +0000 (12:14 +0300)]
Added support for options parameter in console.dir()
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Brian White [Wed, 11 Jun 2014 19:16:48 +0000 (15:16 -0400)]
lib: remove unused variables
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Sun, 8 Jun 2014 18:58:07 +0000 (11:58 -0700)]
tls_wrap: fix interleaving in InvokeQueued
WriteItem callback may add new item to the `pending_write_items`. Ensure
that this item won't be called in the same `InvokeQueued` call, as it
may result in way-to-early `finish` event on js-side.
fix #7733
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Sun, 8 Jun 2014 02:25:02 +0000 (19:25 -0700)]
tls_wrap: fix small obvious memory leak
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Roman Klauke [Wed, 11 Jun 2014 20:03:50 +0000 (22:03 +0200)]
readline: remove doubled case.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ryan Graham [Fri, 23 May 2014 20:15:15 +0000 (13:15 -0700)]
test: regression test for cluser.setupMaster()
Tests for the behaviour in v0.10.x which allows process.argv changes
to be honoured by cluster.setupMaster().
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Ryan Graham [Fri, 23 May 2014 19:41:40 +0000 (12:41 -0700)]
cluster: restore v0.10.x setupMaster() behaviour
In v0.10.x, process.argv and process.execArgv would only be
evaluated and copied into cluster.settings on the first call to
cluster.setupMaster() (either directly or via cluster.fork()),
allowing them to be modified as needed before initializing the
settings.
In 41b75ca the behaviour was changed so that these values are
initialized at the time of the first require('cluster').
Fixes #7670.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Timothy J Fontaine [Wed, 11 Jun 2014 15:59:55 +0000 (11:59 -0400)]
Merge remote-tracking branch 'upstream/v0.10'
Timothy J Fontaine [Wed, 11 Jun 2014 15:51:53 +0000 (11:51 -0400)]
node: signing the CLA is no longer a requirement
Timothy J Fontaine [Tue, 10 Jun 2014 23:36:04 +0000 (19:36 -0400)]
Merge remote-tracking branch 'upstream/v0.10'
Conflicts:
AUTHORS
ChangeLog
deps/v8/src/api.cc
deps/v8/src/unicode-inl.h
deps/v8/src/unicode.h
lib/_stream_readable.js
lib/http.js
src/cares_wrap.cc
src/node.cc
src/node_crypto.cc
src/node_dtrace.cc
src/node_file.cc
src/node_stat_watcher.cc
src/node_version.h
src/process_wrap.cc
src/string_bytes.cc
src/string_bytes.h
src/udp_wrap.cc
src/util.h
test/simple/test-buffer.js
test/simple/test-stream2-compatibility.js
Timothy J Fontaine [Mon, 9 Jun 2014 17:52:27 +0000 (10:52 -0700)]
Now working on 0.10.30
Timothy J Fontaine [Mon, 9 Jun 2014 17:51:53 +0000 (10:51 -0700)]
Merge branch 'v0.10.29-release' into v0.10
Timothy J Fontaine [Mon, 9 Jun 2014 17:04:36 +0000 (10:04 -0700)]
2014.06.05, Version 0.10.29 (Stable)
* openssl: to 1.0.1h (CVE-2014-0224)
* npm: upgrade to 1.4.10
* utf8: Prevent Node from sending invalid UTF-8 (Felix Geisendörfer)
- *NOTE* this introduces a breaking change, previously you could construct
invalid UTF-8 and invoke an error in a client that was expecting valid
UTF-8, now unmatched surrogate pairs are replaced with the unknown UTF-8
character. To restore the old functionality simply have NODE_INVALID_UTF8
environment variable set.
* child_process: do not set args before throwing (Greg Sabia Tucker)
* child_process: spawn() does not throw TypeError (Greg Sabia Tucker)
* constants: export O_NONBLOCK (Fedor Indutny)
* crypto: improve memory usage (Alexis Campailla)
* fs: close file if fstat() fails in readFile() (cjihrig)
* lib: name EventEmitter prototype methods (Ben Noordhuis)
* tls: fix performance issue (Alexis Campailla)
Yazhong Liu [Sat, 7 Jun 2014 14:01:46 +0000 (22:01 +0800)]
http: add 308 status_code, see RFC7238
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Brian White [Sat, 7 Jun 2014 15:53:23 +0000 (11:53 -0400)]
fs: remove duplicate check
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Timothy J Fontaine [Thu, 5 Jun 2014 22:55:48 +0000 (15:55 -0700)]
v8: shift heap space for aslr on 64bit
Previously we were only shifting the address space for ASLR on 32bit
processes, apply the same shift for 64bit so processes don't
get artificially limited native heap.
Timothy J Fontaine [Thu, 5 Jun 2014 22:18:15 +0000 (15:18 -0700)]
npm: upgrade to v1.4.14
Timothy J Fontaine [Thu, 10 Apr 2014 00:33:33 +0000 (17:33 -0700)]
src: replace usage of String::Utf8Value
v8::String::Utf8Value previously could allow invalid surrogates when
interpreting values.
Felix Geisendörfer [Mon, 20 Jan 2014 08:47:19 +0000 (09:47 +0100)]
string_bytes: Guarantee valid utf-8 output
Previously v8's WriteUtf8 function would produce invalid utf-8 output
when encountering unmatched surrogate code units [1]. The new
REPLACE_INVALID_UTF8 option fixes that by replacing invalid code points
with the unicode replacement character.
[1]: JS Strings are defined as arrays of 16 bit unsigned integers. There
is no unicode enforcement, so one can easily end up with invalid unicode
code unit sequences inside a string.
Felix Geisendörfer [Mon, 20 Jan 2014 08:43:43 +0000 (09:43 +0100)]
deps/v8: Apply REPLACE_INVALID_UTF8 patch
- https://codereview.chromium.org/
121173009/
- https://code.google.com/p/v8/source/detail?r=18683
Note: The v8 test case did not cleanly apply, so it's missing from this
patch. I'm assuming this is not a problem if the v8 test suite is not
part of the node build / test system. If that's the case I'll fix it.
Otherwise the test case will be integrated once v8 is upgraded.
Felix Geisendörfer [Tue, 13 May 2014 15:42:48 +0000 (17:42 +0200)]
string_decoder: Add more comments
Felix Geisendörfer [Tue, 13 May 2014 15:36:40 +0000 (17:36 +0200)]
string_decoder: Fix failures from new test cases
This patch simplifies the implementation of StringDecoder, fixes the
failures from the new test cases, and also no longer relies on v8's
WriteUtf8 function to encode individual surrogates.
Felix Geisendörfer [Tue, 13 May 2014 15:30:25 +0000 (17:30 +0200)]
string_decoder: Improve test coverage
The test cases are still essentially the same, but now all possible ways
of writing a buffer into the decoder are tested, which has exposed a few
failing scenarios that had not been discovered so far!
Fedor Indutny [Fri, 16 May 2014 09:10:34 +0000 (13:10 +0400)]
stream: start old-mode read in a next tick
Calling `.read()` in the same tick with `.on('data', ...)` may cause
users missing `error` events, because no `error` listeners were set yet.
fix #7618
Nick Muerdter [Wed, 4 Jun 2014 03:49:38 +0000 (21:49 -0600)]
http: don't default OPTIONS to chunked encoding
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Fedor Indutny [Thu, 5 Jun 2014 14:46:55 +0000 (07:46 -0700)]
test: fix event-emitter-method-names
Fedor Indutny [Thu, 5 Jun 2014 14:28:39 +0000 (07:28 -0700)]
Merge branch 'v0.10'
Conflicts:
ChangeLog
lib/events.js
lib/tls.js
src/node_constants.cc
src/node_crypto.cc
src/node_crypto.h
src/node_version.h
Fedor Indutny [Thu, 5 Jun 2014 14:09:35 +0000 (07:09 -0700)]
deps: update openssl to 1.0.1h
Michael Kebe [Thu, 15 May 2014 15:56:04 +0000 (17:56 +0200)]
test: remove duplicate tests
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Ben Noordhuis [Wed, 4 Jun 2014 13:25:09 +0000 (15:25 +0200)]
bench: fix buffers/buffer-base64-encode benchmark
The test is supposed to measure the performance of the base64 encoder
so move the Buffer#write() calls out of the benchmark section.
The overhead of the calls isn't terrible (about 1-3%) but having
unrelated activity in a micro-benchmark is never a good idea.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Chris Barber [Fri, 30 May 2014 21:25:52 +0000 (14:25 -0700)]
doc: fixed wording in child_process
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ben Noordhuis [Tue, 27 May 2014 21:31:31 +0000 (23:31 +0200)]
src: replace CONTAINER_OF with type-safe function
Replace the CONTAINER_OF macro with a template function that is as
type-safe as a reinterpret_cast<> of an arbitrary pointer can be made.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
cjihrig [Wed, 28 May 2014 22:34:04 +0000 (18:34 -0400)]
fs: close file if fstat() fails in readFile()
Currently, if fstat() fails in readFile(), the callback
is invoked without closing the file. This commit closes
the file before calling back.
Closes #7697
cjihrig [Wed, 28 May 2014 22:34:04 +0000 (18:34 -0400)]
fs: close file if fstat() fails in readFile()
Currently, if fstat() fails in readFile(), the callback
is invoked without closing the file. This commit closes
the file before calling back.
Closes #7697
Raymond Feng [Tue, 27 May 2014 22:26:13 +0000 (15:26 -0700)]
net: Ensure consistent binding to IPV6 if address is absent
See https://github.com/joyent/node/issues/7675
net.server.listen() behaves inconsistently depending on whether the port
number is provided.
1. port === 0 && host == '' (i.e. false-y), node creates an AF_INET
socket but does not call bind().
2. port > 0 && host == '', node creates an AF_INET6 socket and calls
bind().
The fix makes 1 consistent with 2.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Raymond Feng [Fri, 23 May 2014 03:57:31 +0000 (20:57 -0700)]
doc: Add a README for benchmark tests
The README.md documents how to run node core benchmark tests and
how to write new tests.
Raymond Feng [Fri, 23 May 2014 03:37:47 +0000 (20:37 -0700)]
benchmark: Add a test to measure Buffer.slice perf
Buffer.slice can be expensive. One regression was reported by https://github.com/joyent/node/issues/7633. The method should be benchmarked.
Ben Noordhuis [Fri, 23 May 2014 13:27:51 +0000 (15:27 +0200)]
smalloc: rework double free bug fix
Rework the fix from commit 6810132 in a way that removes ~60 lines of
code.
The bug was introduced in commit e87ceb2 (mea culpa) and is at its core
a pointer aliasing bug where sometimes two independent pointers existed
that pointed to the same chunk of heap memory.
Signed-off-by: Trevor Norris <trev.norris@gmail.com>
Alexis Campailla [Fri, 23 May 2014 18:55:34 +0000 (14:55 -0400)]
tls: fix performance issue
See https://github.com/orangemocha/node-connection-drop
I have pinpointed the performance degradation to
https://github.com/joyent/node/commit/
ac2263b77f3f346458d06fc019de27e24c63cee0
This change brings performance back to the orginal levels.
Signed-off-by: Fedor Indutny <fedor@indutny.com>
Ben Noordhuis [Thu, 22 May 2014 23:08:27 +0000 (01:08 +0200)]
src: kill isolate on exit
Otherwise it's not possible to check from inside a destructor if V8 is
still alive with v8::V8::IsDead(). In V8 3.25, that function returns
true until the last isolate is destroyed.
This used to work in v0.10 and is a standard trick to dispose persistent
handles conditionally.
Signed-off-by: Fedor Indutny <fedor@indutny.com>