review.tizen.org Git - platform/upstream/libSkiaSharp.git/log

projects / platform / upstream / libSkiaSharp.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

scroggo@google.com [Fri, 21 Jun 2013 19:12:47 +0000 (19:12 +0000)]

Treat empty directory properly in skimage.

Instead of treating an empty directory as a file that failed to
decode, treat it as an empty directory.

Add self tests to check for this.

Builds upon from https://codereview.chromium.org/16866010,
which was reverted.

R=epoger@google.com

Review URL: https://codereview.chromium.org/17101029

git-svn-id: http://skia.googlecode.com/svn/trunk@9730 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 21 Jun 2013 19:05:57 +0000 (19:05 +0000)]

remove dead AutoValidator

git-svn-id: http://skia.googlecode.com/svn/trunk@9729 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 21 Jun 2013 18:40:09 +0000 (18:40 +0000)]

remove dead references to PlatformProcs4444

git-svn-id: http://skia.googlecode.com/svn/trunk@9728 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 21 Jun 2013 18:30:53 +0000 (18:30 +0000)]

remove dst/rendertarget support for kARGB_4444_Config

BUG=

Review URL: https://codereview.chromium.org/17335008

git-svn-id: http://skia.googlecode.com/svn/trunk@9727 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 21 Jun 2013 18:16:47 +0000 (18:16 +0000)]

GM: add --missingExpectationsPath option, similar to --mismatchPath

This will allow us to make the buildbots record all images EXCEPT those which
match expectations to Google Storage.

R=borenet@google.com

Review URL: https://codereview.chromium.org/17552012

git-svn-id: http://skia.googlecode.com/svn/trunk@9725 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 21 Jun 2013 17:32:32 +0000 (17:32 +0000)]

add rect-output parameter to isRect, allowing us to return the correct bounds even if a rectagular path has a trailing moveTo

https://code.google.com/p/chromium/issues/detail?id=247770

R=caryclark@google.com

Review URL: https://codereview.chromium.org/16950021

git-svn-id: http://skia.googlecode.com/svn/trunk@9724 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 21 Jun 2013 17:14:48 +0000 (17:14 +0000)]

SkDebugCanvas: remove unused <iostream> include.

No only this is unused, but it's pulling in a static initializer (which makes SkDebugCanvas unusable in Chromium).

BUG=
R=robertphillips@google.com, bungeman@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17553006

git-svn-id: http://skia.googlecode.com/svn/trunk@9723 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 21 Jun 2013 15:28:54 +0000 (15:28 +0000)]

Fix macro for r9718.

git-svn-id: http://skia.googlecode.com/svn/trunk@9720 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 21 Jun 2013 15:13:34 +0000 (15:13 +0000)]

SkPath::rewind needs to have same reset as SkPath::reset.

R=caryclark@google.com, reed@google.com

Review URL: https://codereview.chromium.org/17432003

git-svn-id: http://skia.googlecode.com/svn/trunk@9718 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 21 Jun 2013 15:11:40 +0000 (15:11 +0000)]

add (disabled) wrapper for javascript canvas

git-svn-id: http://skia.googlecode.com/svn/trunk@9717 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 21 Jun 2013 07:00:53 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9713 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Fri, 21 Jun 2013 05:31:38 +0000 (05:31 +0000)]

Add maxCharWidth and a compile flag to use old metrics (needed by Blink).

Review URL: https://codereview.chromium.org/17502006

git-svn-id: http://skia.googlecode.com/svn/trunk@9712 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Thu, 20 Jun 2013 21:18:05 +0000 (21:18 +0000)]

Change window size on GM to fit objects properly

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/17419010

git-svn-id: http://skia.googlecode.com/svn/trunk@9711 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 20 Jun 2013 20:28:54 +0000 (20:28 +0000)]

Add gyp define for optimization level

R=tomhudson@google.com, djsollen@google.com, epoger@google.com, bungeman@google.com

Author: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/17370005

git-svn-id: http://skia.googlecode.com/svn/trunk@9710 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Thu, 20 Jun 2013 18:05:31 +0000 (18:05 +0000)]

Turn off conic GM for now

BUG=

Review URL: https://codereview.chromium.org/17500004

git-svn-id: http://skia.googlecode.com/svn/trunk@9707 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 20 Jun 2013 17:54:26 +0000 (17:54 +0000)]

Fixed invalid cast on mingw.

Fixes GCC error:
SkThread_win.cpp:39:61: error: invalid static_cast from type â€˜int32_t {aka int}â€™ to type â€˜const volatile LONG& {aka const volatile long int&}â€™

Review URL: https://codereview.chromium.org/17047004

git-svn-id: http://skia.googlecode.com/svn/trunk@9706 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 20 Jun 2013 17:40:21 +0000 (17:40 +0000)]

formally declare luaskia extern guy, and then define it

BUG=

Review URL: https://codereview.chromium.org/17503003

git-svn-id: http://skia.googlecode.com/svn/trunk@9705 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 20 Jun 2013 17:37:24 +0000 (17:37 +0000)]

disable PDF for now, until it knows about conics

git-svn-id: http://skia.googlecode.com/svn/trunk@9704 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Thu, 20 Jun 2013 17:15:05 +0000 (17:15 +0000)]

enable shared lib support in linux for lua

R=bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/16099014

git-svn-id: http://skia.googlecode.com/svn/trunk@9703 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Thu, 20 Jun 2013 16:54:31 +0000 (16:54 +0000)]

Add GM to test conic path rendering

R=reed@google.com

Review URL: https://codereview.chromium.org/17365006

git-svn-id: http://skia.googlecode.com/svn/trunk@9702 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Thu, 20 Jun 2013 15:29:16 +0000 (15:29 +0000)]

Fix limit on size of glyph paths.

Some web fonts have been observed to contain glyphs which require a buffer
greater than 20KB. In these rare cases we should allocate space on the heap.
Most glyphs require less than 8KB, and Windows has a 1MB stack, so in the
common case just use the stack.

This change also removes the gFTMutex which was both poorly named and used.
The constructor does not appear to have any need for it, and with this change
the path generation code does not need it. The mask generating code does need
memory barriers for correctness, but these bariers are no-ops on x86. We will
need another change to clean up this sort of static initialization code.

R=caryclark@google.com

Review URL: https://codereview.chromium.org/17435003

git-svn-id: http://skia.googlecode.com/svn/trunk@9700 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 20 Jun 2013 07:06:44 +0000 (07:06 +0000)]

Rebaselining some performance trigger flakes

git-svn-id: http://skia.googlecode.com/svn/trunk@9696 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 20 Jun 2013 07:00:59 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9695 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bungeman@google.com [Wed, 19 Jun 2013 23:06:00 +0000 (23:06 +0000)]

Fix shift detection in views on X.

On X, the meta keys are encoded in xkey.state, not xkey.keycode.
This fixes 'h' and 's' not working in SampleApp.

git-svn-id: http://skia.googlecode.com/svn/trunk@9694 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 19 Jun 2013 20:56:45 +0000 (20:56 +0000)]

post Expose event when we see an inval

git-svn-id: http://skia.googlecode.com/svn/trunk@9693 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 19 Jun 2013 19:44:18 +0000 (19:44 +0000)]

Allow specification of a non-default boto file in chromeos_make

This is needed because our GS bucket needs a different auth key from the
ChromeOS bucket.

(SkipBuildbotRuns)

R=epoger@google.com

Review URL: https://codereview.chromium.org/16975017

git-svn-id: http://skia.googlecode.com/svn/trunk@9692 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Wed, 19 Jun 2013 19:25:36 +0000 (19:25 +0000)]

combine glyph and image bulk alloc, and adjust initial alloc size, to reduce total waste from 50% to 30%

add diagnostics to measure cache efficiency

BUG=

Review URL: https://codereview.chromium.org/17449012

git-svn-id: http://skia.googlecode.com/svn/trunk@9691 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Wed, 19 Jun 2013 19:12:53 +0000 (19:12 +0000)]

Allow skimage expectations file to not exist.

If the file is not there, assume that all images are mismatches.
This allows running the test before the initial rebaseline.

R=epoger@google.com

Review URL: https://codereview.chromium.org/17448011

git-svn-id: http://skia.googlecode.com/svn/trunk@9690 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 19 Jun 2013 18:56:59 +0000 (18:56 +0000)]

rebaseline.py: split image-based rebaselining, which will go away soon, into its own script
(part of step 3 in https://goto.google.com/ChecksumTransitionDetail )

also adds new --expectations-root option

R=scroggo@google.com, senorblanco@chromium.org

Review URL: https://codereview.chromium.org/17379004

git-svn-id: http://skia.googlecode.com/svn/trunk@9689 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 19 Jun 2013 18:52:42 +0000 (18:52 +0000)]

fix https://code.google.com/p/skia/issues/detail?id=1356
('32-bit Mac compiler doesn't like https://code.google.com/p/skia/source/detail?r=9686')

git-svn-id: http://skia.googlecode.com/svn/trunk@9688 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 19 Jun 2013 18:28:31 +0000 (18:28 +0000)]

Reland r9682, using new SkString::appendU64()

Review URL: https://codereview.chromium.org/17157005

git-svn-id: http://skia.googlecode.com/svn/trunk@9687 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 19 Jun 2013 18:27:20 +0000 (18:27 +0000)]

Add SkString::appendU32() and SkString::appendU64()
as needed to re-land r9682

R=reed@google.com

Review URL: https://codereview.chromium.org/17448012

git-svn-id: http://skia.googlecode.com/svn/trunk@9686 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Wed, 19 Jun 2013 17:42:17 +0000 (17:42 +0000)]

Deal with ca and CA transparency operators in pdf. add comments to generated classes.

Review URL: https://codereview.chromium.org/16975013

git-svn-id: http://skia.googlecode.com/svn/trunk@9685 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 19 Jun 2013 15:58:00 +0000 (15:58 +0000)]

Reverting r9682, which broke on some compilers

git-svn-id: http://skia.googlecode.com/svn/trunk@9684 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Wed, 19 Jun 2013 15:50:09 +0000 (15:50 +0000)]

GM: add --writeChecksumBasedFilenames option

as needed for Step 2 of https://goto.google.com/ChecksumTransitionDetail :
make GenerateGMs upload actual images to Google Storage instead of skia-autogen

R=scroggo@google.com

Review URL: https://codereview.chromium.org/17365002

git-svn-id: http://skia.googlecode.com/svn/trunk@9682 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Wed, 19 Jun 2013 15:13:32 +0000 (15:13 +0000)]

Use "Simple Chrome for Chrome OS Workflow" to build Skia for ChromeOS

(SkipBuildbotRuns) since this isn't used yet.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/17412007

git-svn-id: http://skia.googlecode.com/svn/trunk@9681 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 19 Jun 2013 13:28:44 +0000 (13:28 +0000)]

Remove unused NormalizeBench::fUsePortable field.

To address build warnings:

../bench/MathBench.cpp:442:10: error: private field 'fUsePortable' is not used
[-Werror,-Wunused-private-field]
bool fUsePortable;
^

R=reed@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17463002

git-svn-id: http://skia.googlecode.com/svn/trunk@9677 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Wed, 19 Jun 2013 11:50:18 +0000 (11:50 +0000)]

Performance trigger rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@9673 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 19 Jun 2013 11:41:02 +0000 (11:41 +0000)]

Make GrGLConfigConversionEffect work on Intel GPUs

BUG=247664
R=noel@chromium.org, bsalomon@chromium.org, reed@google.com, tomhudson@chromium.org, bsalomon@google.com

Author: jun.a.jiang@intel.com

Review URL: https://chromiumcodereview.appspot.com/15719007

git-svn-id: http://skia.googlecode.com/svn/trunk@9672 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Wed, 19 Jun 2013 07:01:12 +0000 (07:01 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9671 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 18 Jun 2013 22:00:40 +0000 (22:00 +0000)]

Continue to contain podofo, shorter enums

Review URL: https://codereview.chromium.org/17395005

git-svn-id: http://skia.googlecode.com/svn/trunk@9670 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

zachr@google.com [Tue, 18 Jun 2013 21:23:31 +0000 (21:23 +0000)]

force linking inside of skdiff

Review URL: https://codereview.chromium.org/16879012

git-svn-id: http://skia.googlecode.com/svn/trunk@9669 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 18 Jun 2013 20:50:34 +0000 (20:50 +0000)]

Refactor: clean up some unused or mostly-unused API I saw here.

BUG=
R=bungeman@google.com, reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/17414003

git-svn-id: http://skia.googlecode.com/svn/trunk@9668 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 18 Jun 2013 20:20:55 +0000 (20:20 +0000)]

Rename SkDrawCommand subclasses

SkDrawCommand subclass names are too generic and likely to clash in the default namespace.
This makes the header unusable in Chrome - for example, on Mac builders:

../../third_party/skia/src/utils/debugger/SkDrawCommand.h:251:7: error: redefinition of 'Comment'
class Comment : public SkDrawCommand {
^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/AIFF.h:192:8: note: previous definition is here
struct Comment {

This CL renames SkDrawCommand subclasses using the following pattern: "${cmd}" -> "Sk${cmd}Command".

R=robertphillips@google.com, bungeman@google.com, djsollen@google.com

Author: fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/17101005

git-svn-id: http://skia.googlecode.com/svn/trunk@9667 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 18 Jun 2013 20:06:36 +0000 (20:06 +0000)]

remove double including of libpng decoder

R=bungeman@google.com

Author: zachr@google.com

Review URL: https://chromiumcodereview.appspot.com/17408002

git-svn-id: http://skia.googlecode.com/svn/trunk@9666 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 18 Jun 2013 18:35:58 +0000 (18:35 +0000)]

Allow files, making ".skp files or directories are required." less of a lie.

BUG=
R=reed@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/17151008

git-svn-id: http://skia.googlecode.com/svn/trunk@9665 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 18 Jun 2013 16:28:29 +0000 (16:28 +0000)]

put each generated pdf api class in a file (step 1, add new files)

Review URL: https://codereview.chromium.org/17395005

git-svn-id: http://skia.googlecode.com/svn/trunk@9661 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Tue, 18 Jun 2013 15:37:27 +0000 (15:37 +0000)]

Smallest possible desktop application that uses Skia to render stuff.

Small Hello World smaple. Subclasses SkOSWindow.

R=caryclark@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/16337012

git-svn-id: http://skia.googlecode.com/svn/trunk@9657 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Tue, 18 Jun 2013 14:51:21 +0000 (14:51 +0000)]

add value() functions to podofo wrapers to isolate the client from knowing it is using podofo internally

Review URL: https://codereview.chromium.org/17101011

git-svn-id: http://skia.googlecode.com/svn/trunk@9654 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 18 Jun 2013 14:43:53 +0000 (14:43 +0000)]

Fuse skgr & gr targets in gyp files

https://codereview.chromium.org/17101010/

git-svn-id: http://skia.googlecode.com/svn/trunk@9653 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Tue, 18 Jun 2013 13:29:32 +0000 (13:29 +0000)]

Performance trigger rebaselines after hard reboot

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@9651 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Tue, 18 Jun 2013 07:00:52 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9648 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Tue, 18 Jun 2013 02:53:16 +0000 (02:53 +0000)]

skimage: revert r9642

git-svn-id: http://skia.googlecode.com/svn/trunk@9647 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 17 Jun 2013 23:36:45 +0000 (23:36 +0000)]

Pdfviewer: generate isAFoo() and getAsFoo() api for fields that can have multiple types.

Review URL: https://codereview.chromium.org/16968007

git-svn-id: http://skia.googlecode.com/svn/trunk@9646 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 17 Jun 2013 21:06:22 +0000 (21:06 +0000)]

fix typo in spec

Review URL: https://codereview.chromium.org/17124003

git-svn-id: http://skia.googlecode.com/svn/trunk@9644 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Mon, 17 Jun 2013 20:46:27 +0000 (20:46 +0000)]

few steps in the direction of to encapsulating podofo, so the client is not aware podofo is used.

Review URL: https://codereview.chromium.org/17286007

git-svn-id: http://skia.googlecode.com/svn/trunk@9643 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 17 Jun 2013 19:34:58 +0000 (19:34 +0000)]

skimage: if --readPath points at an empty dir, create an empty expectations file

TBR=scroggo

Review URL: https://codereview.chromium.org/17294006

git-svn-id: http://skia.googlecode.com/svn/trunk@9642 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

borenet@google.com [Mon, 17 Jun 2013 15:39:43 +0000 (15:39 +0000)]

SkHello for NaCl

Not ready to submit.

R=reed@google.com

Review URL: https://codereview.chromium.org/16904003

git-svn-id: http://skia.googlecode.com/svn/trunk@9639 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Mon, 17 Jun 2013 14:19:01 +0000 (14:19 +0000)]

*** Perlin noise GM needs to be rebaselined ***

Enabling Perlin Noise on Android

I enabled the Perlin Noise shader on Android after doing some minor modifications to the shader, specifically for Android (and #ifdefed for Android, to make sure none of this affects other platforms).

For Tegra devices (Nexus 7, Xoom), a precision issue related to the color values read from textures caused the noise to read the wrong indices and produce bad noise. I fixed this by adding a founding of the values read by simply doing the equivalent of "colorValue = floor(colorValue * 255.0) / 255.0" to make sure we retrieve the colors that were written in the texture originally.

For non-Tegra devices (Nexus 10), dealing with values in the order of 4096.0 was problematic without using the "highp" precision setting. To solve this, a few variables were given the high precision setting.

Since both fixes don't seem to do considerable harm to the platforms that are not being targetted, I left both fixes on all android devices for now.

I also reduced the Perlin noise gm so that it takes less time to test it on the Xoom (Original time was about 20 seconds, this shold take less than 10, hopefully)

BUG=
R=senorblanco@google.com, bsalomon@google.com, sugoi@google.com, senorblanco@chromium.org

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16818013

git-svn-id: http://skia.googlecode.com/svn/trunk@9637 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

caryclark@google.com [Mon, 17 Jun 2013 14:10:36 +0000 (14:10 +0000)]

convert pathops to use SkSTArray where possible.

Replace SkTDArray with SkTArray and use SkSTArray when
the probable array size is known.

In a couple of places (spans, chases) the arrays are
constructed using insert() so SkTArrays can't be used for
now.

Also, add an optimization to cubic subdivide if either end
is zero or one.

BUG=

Review URL: https://codereview.chromium.org/16951017

git-svn-id: http://skia.googlecode.com/svn/trunk@9635 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Mon, 17 Jun 2013 13:42:43 +0000 (13:42 +0000)]

use select() so we can wait for XEvents or our timer

poll for xevents using XPending

BUG=

Review URL: https://codereview.chromium.org/17275003

git-svn-id: http://skia.googlecode.com/svn/trunk@9633 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Mon, 17 Jun 2013 04:43:05 +0000 (04:43 +0000)]

whitespace change to trigger buildbots after master restart

git-svn-id: http://skia.googlecode.com/svn/trunk@9632 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Sat, 15 Jun 2013 07:00:53 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9631 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Fri, 14 Jun 2013 23:56:20 +0000 (23:56 +0000)]

whitespace change to trigger buildbots after skia-autogen reset

git-svn-id: http://skia.googlecode.com/svn/trunk@9630 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 14 Jun 2013 20:39:48 +0000 (20:39 +0000)]

Fixes for unpremul decode.

SkImageDecoder_CG.cpp:
If a non opaque bitmap was decoded, and the caller wants
unpremultiplied, unpremultiply the colors.

Always use the RGB colorspace, since the other colorspaces
do not match the desired bitmap format.

ImageDecodingTest:
Allow for a difference of 1 in each color component when comparing
the result of premultiplying the unpremultiplied decode with the
premultiplied decode, since I found an image (in WEBP format) where
the unpremultiplied colors did not compare perfectly in my comparison.

R=reed@google.com

Review URL: https://codereview.chromium.org/17084012

git-svn-id: http://skia.googlecode.com/svn/trunk@9628 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 14 Jun 2013 20:22:13 +0000 (20:22 +0000)]

remove unused line of code (from xcode's analysis)

git-svn-id: http://skia.googlecode.com/svn/trunk@9627 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

egdaniel@google.com [Fri, 14 Jun 2013 19:25:53 +0000 (19:25 +0000)]

Change general fill rect shader code to match geometry vers

-Matches shader implemented for alligned rects
-Uses multiplication instead of min (used in geom version)
to combine width and height coverages

R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/17035012

git-svn-id: http://skia.googlecode.com/svn/trunk@9626 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Fri, 14 Jun 2013 19:22:19 +0000 (19:22 +0000)]

Object model generated from pdf spec 1.4, draft code

Review URL: https://codereview.chromium.org/17095004

git-svn-id: http://skia.googlecode.com/svn/trunk@9625 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Fri, 14 Jun 2013 17:46:07 +0000 (17:46 +0000)]

speculative fix in TransitionView. don't validate after detachFromParent (we may have been deleted)

git-svn-id: http://skia.googlecode.com/svn/trunk@9619 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 14 Jun 2013 17:45:30 +0000 (17:45 +0000)]

Fix for r9609

git-svn-id: http://skia.googlecode.com/svn/trunk@9618 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 14 Jun 2013 17:26:54 +0000 (17:26 +0000)]

add skpdiff tool to compare bitmaps

- start framework for pluggable algorithms
- implement simple number of pixels different OpenCL algo

R=djsollen@google.com, bsalomon@google.com, jvanverth@google.com

Author: zachr@google.com

Review URL: https://chromiumcodereview.appspot.com/16284007

git-svn-id: http://skia.googlecode.com/svn/trunk@9616 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 14 Jun 2013 17:10:09 +0000 (17:10 +0000)]

Add skia_exceptinos gyp define

R=robertphillips@google.com

Author: borenet@google.com

Review URL: https://chromiumcodereview.appspot.com/17094003

git-svn-id: http://skia.googlecode.com/svn/trunk@9615 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 14 Jun 2013 15:55:56 +0000 (15:55 +0000)]

Update SkBitmap::validate to respect Android flag.

Without this change, an SkBitmap with hardware mip will assert in
validate.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/16870002

git-svn-id: http://skia.googlecode.com/svn/trunk@9614 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 14 Jun 2013 15:44:11 +0000 (15:44 +0000)]

Prototype for build warning as error.

BUG=

Review URL: https://codereview.chromium.org/17060004

git-svn-id: http://skia.googlecode.com/svn/trunk@9613 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

scroggo@google.com [Fri, 14 Jun 2013 15:33:20 +0000 (15:33 +0000)]

Add an option to create unpremultiplied bitmaps.
Currently they cannot be used directly by Skia, but
the pixels can be used elsewhere.

SkImageDecoder:
Add functions to require unpremultiplied output
and query the presence of the requirement

SkImageDecoder_libpng:
SkImageDecoder_libwebp:
SkImageDecoder_WIC:
Respect the requirement for unpremultiplied output.
TODO: Fix SkImageDecoder_CG.

SkScaledBitmapSampler:
Add procs to skip premultiplication and a boolean
parameter to use those procs.

ImageDecodingTest:
Test unpremultiplied bitmap decoding.

SampleUnpremul:
Add a sample which allows visually comparing between the
unpremultiplied version (copied into a premultiplied bitmap,
since drawing unpremultiplied is not currently supported)
and a premultiplied version of image files.

gm.h:
Add a getter for the resource path, so Samples can use it.

As of patch set 13, https://codereview.chromium.org/16816016/
and https://codereview.chromium.org/16983004/, which were
approved separately.

R=reed@google.com

Review URL: https://codereview.chromium.org/16410009

git-svn-id: http://skia.googlecode.com/svn/trunk@9612 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 14 Jun 2013 14:58:50 +0000 (14:58 +0000)]

Update Alligned Rect Shader to match geometry version

-Also update to combine width and height coverage using multiplication
instead of using min

R=bsalomon@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://chromiumcodereview.appspot.com/16854012

git-svn-id: http://skia.googlecode.com/svn/trunk@9609 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 14 Jun 2013 14:42:56 +0000 (14:42 +0000)]

Add MESA detection to GrContextInfo and use to decide whether to use GL_ALPHA or GL_RED.

Based on yunchao.he@intel.com's original change here: https://codereview.chromium.org/15994006/

R=yunchao.he@intel.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/16955005

git-svn-id: http://skia.googlecode.com/svn/trunk@9608 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Fri, 14 Jun 2013 13:38:56 +0000 (13:38 +0000)]

Improve the performance of SkConvertConfig8888Pixels using Array lookup

BUG=242097
R=kbr@chromium.org, vangelis@chromium.org, zmo@chromium.org, gman@chromium.org, bsalomon@google.com, reed@google.com, tomhudson@chromium.org, noel@chromium.org

Author: jun.a.jiang@intel.com

Review URL: https://chromiumcodereview.appspot.com/15402003

git-svn-id: http://skia.googlecode.com/svn/trunk@9605 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Fri, 14 Jun 2013 12:45:25 +0000 (12:45 +0000)]

Fix for 9603

git-svn-id: http://skia.googlecode.com/svn/trunk@9604 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Fri, 14 Jun 2013 12:30:50 +0000 (12:30 +0000)]

Add operator delete for SkTArray to match operator new

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/17075002

git-svn-id: http://skia.googlecode.com/svn/trunk@9603 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Fri, 14 Jun 2013 07:00:49 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9602 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Thu, 13 Jun 2013 23:40:05 +0000 (23:40 +0000)]

Adds microbench range generation option; renames file appropriately. (SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/16858015

git-svn-id: http://skia.googlecode.com/svn/trunk@9601 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Thu, 13 Jun 2013 21:25:45 +0000 (21:25 +0000)]

Build fix after r9598.

Updated include paths for debugger backend classes.

R=bungeman@google.com

Review URL: https://codereview.chromium.org/16866017

git-svn-id: http://skia.googlecode.com/svn/trunk@9600 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

fmalita@google.com [Thu, 13 Jun 2013 20:59:14 +0000 (20:59 +0000)]

Expose debugger backend classes externally.

SkDebugCanvas & friends are useful beyond the Qt debugger app - Chromium's picture inspector (in development) is at the point where it could take advantage of it.

This patch moves SkDrawCommand, SkDebugCanvas & SkObjectParser from trunk/debugger to trunk/src/utils (since several tools already use these, this seems appropriate), and makes SkDrawCommand & SkDebugCanvas' symbols visible externally (SK_API).

R=reed@google.com

Review URL: https://codereview.chromium.org/16638014

git-svn-id: http://skia.googlecode.com/svn/trunk@9598 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 13 Jun 2013 20:48:09 +0000 (20:48 +0000)]

fix warning related to && and || and parens

git-svn-id: http://skia.googlecode.com/svn/trunk@9597 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 13 Jun 2013 20:20:17 +0000 (20:20 +0000)]

add validate to SkView for debugging

git-svn-id: http://skia.googlecode.com/svn/trunk@9596 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

robertphillips@google.com [Thu, 13 Jun 2013 20:06:44 +0000 (20:06 +0000)]

Fix compiler error for r9592

git-svn-id: http://skia.googlecode.com/svn/trunk@9595 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 13 Jun 2013 20:02:29 +0000 (20:02 +0000)]

most pdf dictionary types suported, need enabling now

Review URL: https://codereview.chromium.org/16844017

git-svn-id: http://skia.googlecode.com/svn/trunk@9594 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 13 Jun 2013 19:47:23 +0000 (19:47 +0000)]

Hopefully fix Android warning-as-error about uninit var.

git-svn-id: http://skia.googlecode.com/svn/trunk@9593 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 13 Jun 2013 19:34:18 +0000 (19:34 +0000)]

Replace fixed-size array of effect stages in GrDrawState with two appendable arrays, one for color, one for coverage.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/16952006

git-svn-id: http://skia.googlecode.com/svn/trunk@9592 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

epoger@google.com [Thu, 13 Jun 2013 19:12:05 +0000 (19:12 +0000)]

skimage self-tests: confirm correctness of bitmap hash values

R=scroggo@google.com

Review URL: https://codereview.chromium.org/16866010

git-svn-id: http://skia.googlecode.com/svn/trunk@9591 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 13 Jun 2013 17:44:07 +0000 (17:44 +0000)]

Make text context responsible for setting GrPaint on GrDrawState.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/16928010

git-svn-id: http://skia.googlecode.com/svn/trunk@9588 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

edisonn@google.com [Thu, 13 Jun 2013 17:24:54 +0000 (17:24 +0000)]

Parse pdf reference manual for 1.4 to extract dictionary definition, initial code. Use spec2def.py <PdfReference-okular-1.txt

Review URL: https://codereview.chromium.org/16838015

git-svn-id: http://skia.googlecode.com/svn/trunk@9587 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bsalomon@google.com [Thu, 13 Jun 2013 15:13:46 +0000 (15:13 +0000)]

Enhancements and a fix to templated containers.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/16951004

git-svn-id: http://skia.googlecode.com/svn/trunk@9582 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

reed@google.com [Thu, 13 Jun 2013 14:34:51 +0000 (14:34 +0000)]

oops, fix missing change in 9532, setting hashbits to 8

git-svn-id: http://skia.googlecode.com/svn/trunk@9581 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

bensong@google.com [Thu, 13 Jun 2013 13:53:16 +0000 (13:53 +0000)]

Fixes zero division when there are no lines to plot (only one revision in range)
(SkipBuildbotRuns)
Review URL: https://codereview.chromium.org/16907003

git-svn-id: http://skia.googlecode.com/svn/trunk@9578 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Thu, 13 Jun 2013 10:18:02 +0000 (10:18 +0000)]

Add benchmark for PremultiplyAlpha and UnpremultiplyAlpha in Skia

BUG=248549
R=tomhudson@chromium.org, bsalomon@chromium.org, reed@google.com, noel@chromium.org, tomhudson@google.com

Author: jun.a.jiang@intel.com

Review URL: https://chromiumcodereview.appspot.com/16654004

git-svn-id: http://skia.googlecode.com/svn/trunk@9569 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

skia.committer@gmail.com [Thu, 13 Jun 2013 07:00:51 +0000 (07:00 +0000)]

Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@9567 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

mike@reedtribe.org [Thu, 13 Jun 2013 01:28:56 +0000 (01:28 +0000)]

add canvas scale and rotate

git-svn-id: http://skia.googlecode.com/svn/trunk@9564 2bbb7eff-a529-9590-31e7-b0007b416f81

commit | commitdiff | tree

commit-bot@chromium.org [Wed, 12 Jun 2013 23:36:50 +0000 (23:36 +0000)]

add SkIntToScalar and SkFloatToScalar to stop build errors on Mac10.6

BUG=
R=vandebo@chromium.org

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16871004

git-svn-id: http://skia.googlecode.com/svn/trunk@9562 2bbb7eff-a529-9590-31e7-b0007b416f81

Domain: Dotnet / API;